1 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
3 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
6 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
8 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
9 after it have been deleted
11 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
12 * FIX: src/* fix the doxygen warnings.
13 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
14 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
15 was erroneously defined with a size of 15 instead of 16. [many thanks
16 to Jean Michel Rouet for pointing out this bug].
18 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
19 1. Finish merging JMR patch for writting DICOM from scratch
20 2. Fix -hopefully- bug with MONOCHROME and space vs null character
21 3. Use const ref when possible
22 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
23 5. A few more comments
24 6. CreateUniqueUID can now be called without parameter"
26 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
27 * ENH: Slightly bigger patch:
28 1. Getting toward full integration of JMR patch for writting dicom from scratch
29 2. Update Test to test part of this patch: CreateUniqueUID
30 3. File was not close properly in gdcmDict
31 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
32 5. Use of const ref instead of copy (speed issue)
33 6. Remove temporary (duplicate) string in TranslateToKey
34 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
35 8. Do not repeat virtual in subclasses
36 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
38 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
39 * Apply first patch toward better string comparison when dealing with broken
40 DICOM files. Essentially the string could be padded with a space instead
41 of a null character as defined by standard
43 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
45 because never used... and in the same time, that's remove some memory leaks
47 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * src/gdcmFile.cxx : now delete the PixelConvert instance.
49 * In examples and tests : change the type of image data variables from void*
50 to uint8_t*. Remmove all delete on image data variables
52 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
54 Verify the file pointer value before open the file, and if it's not null,
55 a verbose message is generated.
56 Close correctly the file when the file isn't considered dicom-like. The
57 correctly close is a call to CloseFile.
58 When closing the file pointer, test if its not null to close the file.
59 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
60 file. For an uncompressed image, the copied datas correspond in the least
61 case to the image size (calculated) or the image size specified in the
62 header. A verbose is generated if these two size mismatch
64 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
66 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
67 break under windows (with msvc6 compilation).
69 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
73 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * Bugs fix for the Windows build with VC6
75 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
76 needed (only for projects required VTK). If the VTK is included in all
77 projects, there is conflicts with the jpeg lib of vtk when compiling the
78 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
79 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
80 when compiling the gdcm_wrap.cxx file (created by the compilation of the
82 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
83 (like it's already made for the cout use). Otherwise, conflict with the
86 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
87 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
89 - comments on the DicomDir::Method related usage added.
90 - now that we use the namespace gdcm, a lot of internal classes do
91 NOT need to be wrapped anymore.
92 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
93 DicomDir::Method) new example added.
95 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
96 * Improve string manipulation. I now inforce the notion of 'DicomString'
97 A DicomString can contain as many \0 as they want
98 and it is *always* of even length.
99 We only support odd length for very rare case.
100 And in the near future this should be removed.
102 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
103 * /binary_write/ gdcm source. Now even on big endian we are writting
104 little endian. This should -heopfully- fix some tests
106 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
107 * Now the dictionary is compiled into gdcm lib. This is a default
108 behavior, thus any dic file specified is picked before failback to
109 the one comiled into lib
111 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
112 * Change internals for gdcmDict. Don't use any 'new' any more.
113 This should definitely solve any leak problem, and we should be
114 as fast as before, as long as don't modify too much the dictionary.
116 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
117 * STYLE: ivars should start with a capital letter.
118 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
119 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
121 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
122 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
123 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
124 new 2004 dictionaries added (thanks to JPR).
125 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
126 * CLEANUP_ROUND (15) for gdcmPixelConvert
127 - RLEFrame::NumberFragments is now of type unsigned int
128 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
129 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
132 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
133 * Initial work in gathering all transfer syntax accessors. clearly
134 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
135 ivars, but only one transfersyntax (class) ivar with equivalent method on
138 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
139 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
140 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
141 discussed (plus I didn't like having a 2000 lines patch not commited)
143 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
144 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
145 * CLEANUP_ROUND (14) for gdcmPixelConvert
146 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
147 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
148 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
150 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
151 anymore and hence avoids storing a copy of PixelConvert::Decompressed
152 into File::Pixel_Data.
154 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
155 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
156 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
157 * CLEANUP_ROUND (13) for gdcmPixelConvert
158 Substituted File::ParsePixelData() with PixelConvert::Print() new
160 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
161 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
162 method to those classes.
163 - src/gdcmFile.[cxx|h]:
164 -- Added a ::Print() method.
165 -- PixelConverter is now a reference instead of a member.
166 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
167 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
169 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
170 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
171 collaboration diagram and inheritance diagram should be generated with
173 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
174 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
175 pointlessly wrapped (see
176 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
177 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
178 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
179 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
180 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
181 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
182 -- File::Initialise: PixelConverter setup moved away to
183 PixelConverter::GrabInformationsFromHeader()
184 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
185 interpretation moved away to PixelConverter::BuildRGBImage()
187 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
188 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
189 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
191 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
192 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
193 displayed on Win32 when a brutal abort() occurs (because of uncatched
194 exception). See TODO new entry of this commit for more on this.
195 * TODO added new entry.
196 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
197 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
198 - HandleColor is no longer called from gdcmFile.cxx
199 - gdcmPixelConvert.cxx clean up on method arguments and internal
200 variable names for semantical coherence.
202 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
203 * Finished lossless transition, not only do we now read all lossless jpeg
204 images, without the need of the Cornwell lib, but we do read them properly now
205 * To reduce code (well to avoid code duplication), I defined a common place
206 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
207 redefine symbols. This is not prefect but this the best solution I found for a
208 compilation time jpeg option.
210 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
211 * Update jpeg ijg lib to support lossless jpeg implementation
212 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
214 * Also added a special copyright for dcmtk since we use their bugfixes.
217 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
218 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
219 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
220 matters, as stated in warning note at begining of %include section).
221 * src/gdcmDicomDir*.[cxx|h]: coding style
222 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
223 * src/gdcmJpeg8.cxx: doxygen fix.
224 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
225 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
226 from File:: to PixelConvert::.
228 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
229 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
230 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
231 - more code moved away from File:: to PixelConvert::
232 - fat setup of PixelConverter set in place in File::Initialise.
234 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
235 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
236 namespace at the file system level. So now you should convert your examples
238 gdcmHeader -> gdcm::Header
239 It would be nice if people keep in mind to no open the namespace, since it
240 allows compilation on broken plateform which were defining common symbol in
241 the standart namespace (like LP, Unknown ...)
243 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
244 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
245 The JPEG fragments are now parsed at the same stage than the RLE
246 information. All code related to JPEG is now in gdcmPixelConvert:
247 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
248 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
249 export a gdcmFile:: method. Those are simply global functions
250 (for the time being this is better than having them attach to
251 either gdcmFile:: or gdcmPixelConvert::).
252 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
253 and stores the result in a gdcmJPEGFragmentsInfo.
254 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
255 code (among other stuff) moved away from gdcmFile:; to
258 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
259 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
260 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
261 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
262 clean up of RLE related code.
263 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
264 - src/gdcmRLE.cxx removed
265 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
266 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
267 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
268 * CLEANUP_ROUND (9) for gdcmPixelConvert
269 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
270 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
271 away from gdcmFile:: to gdcmPixelConvert::.
273 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
274 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
275 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
276 This is because Parse7Fe0 used to parse the pixels to compute the
277 length. This task was passed over to FindDocEntryLengthOB() a long
278 time ago, EXCEPT I had forgotten the OW case...
279 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
280 we just recylce the code for parsing RLE fragments and computing
282 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
283 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
284 with the retired Parse7Fe0().
285 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
286 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
288 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
289 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
290 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
291 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
292 - src/CMakeLists.txt: alphabetic order reodering + new entries.
293 * CLEANUP_ROUND (4) for gdcmPixelConvert
294 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
295 to return an unused length.
297 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
298 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
299 this should be cleanner from the plane view. The iostream are erally a pain
300 to use to do simple stuff.
302 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
303 * Redo the compilation of the ijg jpeg library. Now only one source is
304 necesseray. No need to rename file by hand what so ever. CMake handle the
305 copying of the file within different directory, configure header file to
306 modify some symbol. The only addition made to ijg wasd a mangle table so
307 that symbol are different wether we are within 8bits or 12bits.
309 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
310 * Added documentation of vtkgdcmReader on Website:
311 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
312 with it's binary name).
313 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
314 the Website to be more complete.
315 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
316 doxygenated documentation.
317 - Doc/DoxyVtkGdcmReaderExamples.txt added
318 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
319 DoxyVtkGdmReaderExamples.html )
320 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
321 * CLEANUP_ROUND (3) for gdcmPixelConvert
322 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
324 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
325 * CLEANUP_ROUND (2) for gdcmPixelConvert
326 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
328 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
329 * CLEANUP_ROUND for gdcmPixelConvert:
330 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
331 - src/gdcmPixelStuff[h|cxx] removed
332 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
333 - src/CMakeLists.txt changed accordingly
335 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
336 gdcmVersion.py moved to newly created ATTIC related
337 gdcmPython/SetupOldies/ directory.
338 * Autotools clean up:
339 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
340 - autogen.sh configure.in acinclude.m4 python.m4 removed
342 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
343 * src/*.cxx *.h Reference to License.htm fixed to License.html.
344 * Doc/CMakeLists.txt, doxygen.config.in: fix.
345 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
347 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
348 * TODO updated with Mathieu suggestions. I proposed a template for
349 describing TODO entries and used it for new entries.
350 * Added Doc/Website/CodingStyle.html, Developpers.html,
351 DeveloppersPython.html, GdcmDataCvs.html and
352 DownloadVersion0_1.html, DownloadVersion0_3.html.
353 * Some Doc/*.txt Doxygen files (which do not really concern the
354 documentation itself, but the website) moved to html and
355 placed in directory Doc/Website:
356 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
357 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
358 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
359 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
360 * CMakeLists.txt changed accordingly.
361 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
362 DeveloppersPython.html
363 * INSTALL nows refers to Doc/Website/Installation.html
365 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
366 * Added Doc/Website directory, that contains a first raw version
369 2004-09-23 Jean-Pierre Roux
370 * FIX In order not to be poluted any longer by casting problems,
371 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
372 we can now delete[] it safely
373 * VoidArea is now called BinArea (less confusing name),
374 and all the methods called ...VoidArea... are now ... BinArea...
375 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
377 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
378 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
379 clear) TagHT, which is an inherited member of gdcmElementSet. It is
380 up to the destructor of gdcmElementSet to clean up TagHt and it's
383 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
384 * Test/CMakeLists.txt: update to follow gdcmData renamings.
385 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
387 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
388 * ENH: added some utility method that builds a flat dictionnary
389 holding all the Dicom entries contained in the recursive structure
390 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
392 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
393 BuildFlatHashTable() that build a flat dictionary.
394 - src/gdcmElementSet.h: added a new private GetTag() accessor.
395 gdcmDocument is now a friend of gdcmElementSet.
396 - src/gdcmElementSet.cxx: clean up.
397 - Example/FlatHashTablePrint.cxx added.
398 - Example/CmakeLists.txt changed accordingly
400 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
402 moved away from gdcmDocEntrySet (since this class is an abstract class
403 acting like an interface). SQDepthLevel and BaseTagKey are now
405 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
406 and associated accessors. Doxygenation of the class.
407 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
409 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
410 Use SQDepthLevel accessor instead. ::Print() adapted.
411 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
412 - src/gdcmDocument.cxx changed accordingly.
414 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
415 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
416 - The following is the doxygen comment of the typedef declaration
417 of gdcmagKey in src/gdcmCommon.h:
418 gdcmTagKey is made to old an "universal" (as in URL, Universal
419 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
420 A dicom tag allways has a group and an element, but a set of tags
421 embeded in various (optionally nested) sequences and sharing
422 the same group and element all share the same (group, element)
423 "identifier". Hence the (group, element) cannot be used as an
424 identifier (in gdcm we shall refer to a "TagKey") of a tag.
425 In order to construct a proper tag identifier (i.e. a key) we
426 consider the following definition of a TagKey:
427 - let Group, Element be the string representation of the
428 group and element dicom tag members,
429 - let ItemNumber be the string representation of the integer
430 index of the considered item number of a sequence,
431 Let the key of a tag embeded in a sequence, noted SeqTag, be
433 /ItemNumber#Group|Element
434 where "/", "#" and "|" are characters acting as separators.
435 Then the general form of a gdcmTagKey is given by:
436 Group|Element<SeqTag>
437 where <SeqTag> means NO or many instances of SeqTag.
438 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
441 but the gdcmTagKey of a tag "embeded" is the first item of
442 a sequence, itself nested in the third item of a sequence is the
444 0004|1220/2#0008|0082/0#0008|0090
445 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
446 order to hold the new sequence compatible key. Previously, the
447 GetKey() method would look in the underlying gdcmDictEntry.
448 - src/gdcmDocEntry.cxx:
449 -- constructor now copies the underlying DictEntry key, in the local
451 -- ::Print: displays the member Key, instead of the (group, element).
452 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
453 - src/gdcmDocEntrySet.h:xi
454 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
455 -- now has a new BaseTagKey member.
457 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
458 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
460 This poses the problem with the semantics of the following lines
461 LoadEntryVoidArea(0x0028,0x1201); // R LUT
462 LoadEntryVoidArea(0x0028,0x1202); // G LUT
463 LoadEntryVoidArea(0x0028,0x1203); // B LUT
464 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
465 to the long FIXME note for what the problem is. Nevertheless in
466 order to get things working the dicom dictionary was altered !
467 Please fix things urgently...
468 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
469 information), see above note on moving the member VoidArea. Nevertheless
470 the following entries previously correctly set as US are now inproperly
472 0028 1201 OW IMG Red Palette Color Lookup Table Data
473 0028 1202 OW IMG Green Palette Color Lookup Table Data
474 0028 1203 OW IMG Blue Palette Color Lookup Table Data
475 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
476 of gdcmDocEntry moved to gdcmSeqEntry.
477 * src/gdcmSeqEntry.cxx: STYLE.
479 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
480 * Test/TestAllEntryVerify.cxx minor fix and added comments.
482 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
483 * gdcmPython/testSuite.py: all the test suite in python is now moved
484 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
485 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
486 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
488 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
489 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
490 to avoid inclusion recursion until STL is reached.
491 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
492 mecanism. errno.h is not included in gdcm anymore.
493 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
494 (gdcmFormatError now inherits from gdcmFormatUnexpected).
496 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
497 gdcmData/TestAllEntryVerifyReference.txt
498 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
499 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
500 exception_on_error parameter.
501 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
502 - vtk/vtkGdcmReader.cxx changed accordingly,
503 - Example/*.cxx and Test/*.cxx changed accordingly.
505 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
506 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
507 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
508 enable_sequences removed from gdcmHeader constructor and dependencies.
509 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
510 * gdcmPython/demo/PrintHeader.py: dummy fix.
511 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
512 skip_shadow removed from gdcmHeader constructor and dependencies.
513 * Example/*.cxx and Test/*.cxx changed accordingly.
515 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
516 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
517 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
519 2004-07-21 Jean-Pierre Roux
520 * FIX Now, Parsing and Printing a DICOMDIR do work!
521 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
523 2004-07-20 Jean-Pierre Roux
524 * FIX Some brain damaged headers have Zero-Lenght fields
525 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
527 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
528 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
529 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
530 variable (instance of gdcmDebug) by a definition macro, and the instance
531 is now in static in the gdcmDebug class
532 * src/gdcmSQItem.h : (FIXME) remove an undefined method
533 * Test/PrintAllDocument.cxx : bug fix in the result of the test
535 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
536 * WARNING: ctest now depends more tightly on gdcmData. You should
537 check out gdcmData properly for things to run smoothly...
538 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
539 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
540 we need the pixels not be loaded in order to use the ValEntry
541 that displays position and size).
542 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
543 This is a C++ based equivalent of gdcmPython/testSuite.py that should
544 be deprecated. If you have any doubts about the advantages of a
545 modern scripting language (read Python) versus grass root C++ (i.e.
546 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
547 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
548 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
549 Anyhow, consider documenting the gdcmData images in
550 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
552 * Test/CMakeLists.txt:
553 - now uses TestAllEntryVerify.cxx
554 - specific comments on oldACR00001.ima (now renamed in gdcmData
555 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
556 gdcmData/TestAllEntryVerifyReference.txt
559 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
560 * src/*.[h|cxx] : typedef clean up
561 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
562 - TagKey renamed to gdcmTagKey (for external usage)
563 - VRKey renamed to gdcmVRKey (for external usage)
564 - removal of typedef duplication.
565 - Removed all unecessary inline keyword from class inline definitions.
566 - Some method|function(void) declarations replaced with method|function().
567 * src/jpeg/libijg12/jdhuff12.c:
568 - printf polluting ctest removed.
569 - TAB removal for comminting
571 - TestAllReadCompareDicom.cxx: added a test that compares all the
572 images in gdcmDataImages.h with corresponding images in
573 gdcmData/BaselineDicom/. When baseline images are not present
574 this test creates them.
575 Note: we need to validate each reference image, but before that
576 I'd like to rename them with a more explicit name...
577 - CMakeLists.txt: changed accordingly.
578 * Example/*.cxx: examples now only include gdcm.h (as opposed to
579 including each header needed).
581 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
582 * Test/*.cxx and Example/*.cxx: moved some examples away from the
583 test suite to the Example directory. Are concerned:
588 - TestWriteSimple.cxx
589 * Test/CMakeLists.txt: added some comments on reasons for black listing
590 image gdcmData/oldACR00001.ima
592 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
593 * Test/CmakeList.txt: removed the following from black list (to be coherent
594 with removal from gdcmData):
595 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
596 - gdcm-MR-PHILIPS-16.dcm
598 Added the following because after last cvs update, they cause
599 ctest -R TestReadWriteReadCompare
601 - gdcm-MR-SIEMENS-16-1.acr
603 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
604 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
605 new comments in this file) we temporarily (sigh) move to a weaker
607 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
608 we don't need to black list the following images anymore:
609 - 8BitsUncompressedColor.dcm
611 - US-PAL-8-10x-echo.dcm
612 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
613 fixes and the beautified code ;-)
614 This fixes the bug introduced in version 1.42 (when beautifying)
615 that made the parsing of 8BitsRunLengthColor.dcm unproper.
616 Note: ctest was blind to this bug (this means we need to still
617 improve the test suite). The bug could be detected by using
618 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
620 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
621 and by displaying the (garbage) produced file temp.XDCM...
623 2004-06-29 Jean-Pierre Roux
624 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
625 - replace by uggly but working old code :-(
626 A lot of things should be OK again.
627 It's really urgent to have a test suite that *tests*,
628 to prevent Frog's beautifying sessions to break all the stuff
629 (twice, withing a fortnigh ...)
631 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
632 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
633 redundancy) to added Test/TestReadWriteReadCompare.cxx
634 * Test/CmakeList.txt: because the compare test of
635 Test/TestReadWriteReadCompare.cxx fails, the following images are
636 black listed: - 8BitsUncompressedColor.dcm
638 - US-PAL-8-10x-echo.dcm
639 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
640 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
641 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
642 and ad-hoc kludge. This kludge is now removed, and on encountering
643 such an image (OB field brain damaged) we set errno. Then in
644 ::FindDocLength() we "fix" the length as being ALL what remains
645 in the file (until EOF). We then proceed, hoping for the best...
646 This fixes a SegFault in ShowDicom when trying to write such an
648 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
649 (because TestWriteRead breaks on it, after a non conformal commit?).
650 ctest now runs properly, except for MakeDicomDir (which was allways
651 broken) and the Python related stuff (still not fixed).
653 2004-06-24 Jean-Pierre Roux
654 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
655 FIX : Test/TestReadWrite now iterates on all the file names
656 (instead of infinite loop)
657 ENH : Test/TestWriteRead now iterates on all the file names
659 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
660 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
662 2004-06-24 Jean-Pierre Roux
663 FIX : - now Write drops LUT Descriptors and LUTs (if any)
664 when SamplesPerPixel =3
665 - now Write is no longer confused by
666 'BitsAllocated = 12" and 'BitsStored=12"
667 - "UN" value representation Elements are now written correctly
668 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
669 ENH : - now gdcmHeader has its own Write methods
670 (in order to split the job that has not to be done
673 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
674 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
675 loop on the same image until memory went out.
676 Note: this means we still have gobs of memory loss in PrintDocument
677 * src/gdcmDocument.cxx: fixes problem on parsing on file
678 gdcmData/16BitsJpegLosslessGrayScale.dcm.
680 2004-06-24 Jean-Pierre Roux
681 FIX : Write - All the Sequences and Sequence Item are now written
682 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
683 is added a the end, when necessary.
684 - A lot of brain-damaged images, that were read correctly are
685 now written correctly
686 - length compatible BinEntry are now loaded correctly
687 (even for odd groups)
688 Note : only Explicit Value Representation was checked.
689 (question : is implicit VR really necessary for gdcm ?)
691 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
692 * DEVELOPPER: added a proposition of coding style.
693 * src/gdcmDocEntry.h: removed every inline declaration (for test of
696 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
697 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
698 Use the gdcmDocEntry::Print() and Write() instead.
699 * src/gdcmDocument.cxx: bug fix.
701 2004-06-22 Jean-Pierre Roux
702 FIX : gdcmDocument.cxx
703 - Now we do recognize the JpegLossLess format (there was a misstyping in
704 code 'beautyfication' :-(
705 - Now we automaticaticaly load the Luts, if any
707 2004-06-22 Jean-Pierre Roux
708 In order : to write Sequences, whatever their imbrication level,
709 : to allow user to create his own Sequences
710 a lot of modif where necessary (adding, moving, or virtualising methods)
712 WARNING : save your own sources *before* cvs up !
715 ADD virtual void Write(FILE *fp, FileType filetype);
718 ADD virtual void Write(FILE *fp, FileType filetype);
719 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
722 ADD virtual void Write (FILE *fp, FileType filetype)=0;
723 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
724 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
725 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
726 ADD std::string GetEntryByName(TagName name);
727 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
729 std::string vr = "unkn",
730 std::string fourth = "unkn",
731 std::string name = "unkn");
732 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
733 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
734 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
735 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
736 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
737 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
738 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
739 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
742 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
743 ADD virtual std::string GetEntryByName (TagName tagName);
744 ADD virtual std::string GetEntryVRByName (TagName tagName);
745 REM virtual bool Write(FILE *, FileType);
746 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
747 FILE *_fp, FileType type);
748 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
749 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
750 REM virtual bool WriteEntries(FILE *_fp,FileType type);
751 REM virtual std::string GetEntryByName (std::string tagName);
752 REM virtual std::string GetEntryVRByName (std::string tagName);
753 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
754 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
755 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
757 std::string vr = "unkn",
758 std::string fourth = "unkn",
759 std::string name = "unkn");
760 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
761 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
762 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
763 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
766 ADD virtual void Write(FILE *fp, FileType filetype);
769 ADD virtual void Write(FILE *fp,FileType filetype);
772 ADD virtual void Write(FILE *fp, FileType filetype);
773 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
774 REM std::string GetEntryByNumber(guint16 group, guint16 element);
775 REM std::string GetEntryByName(TagName name);
778 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
780 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
781 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
782 The default constructor invoked by the line
783 gdcmHeader *f1 = new gdcmHeader( header );
784 was gdcmHeader::gdcmHeader(bool) instead of the expected
785 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
786 Hence the parsing wasn't executed... See also below.
787 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
788 as explicit constructor didn't do the trick to fix the above problem.
789 Could anyone explain why ?
790 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
791 properly calls gdcmValEntry::Print() (that was weed out from
792 code related to gdcmBinEntry).
794 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
795 * In order to fix memory leaks:
796 - Test/TestWriteSimple.cxx: added cleaning of free store through
798 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
799 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
800 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
801 (through the call to ::AddDicomDirMeta()) or the destructor
802 would crash when deleting uninitialized ::metaElems].
803 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
804 - src/gdcmDocument.cxx:
805 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
807 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
808 was causing memory leaks.
809 - src/gdcmSQItem.cxx:
810 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
811 cleanly handled with polymophism: sorry but my milage is low).
812 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
813 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
814 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
815 This avoids SegFaulting.
816 - src/gdcmSQItem.h: coding style.
818 - Test/TestWriteSimple still severely sucks. The output image content
819 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
820 damaged when displayed with vtkgdcmViewer.
821 - on memory leaks: TestWriteSimple leaks really less (see entry
822 of 2004-06-18 in Changelog file for the call to valgrind).
823 - on segfaults: ctest now passes all the tests but one (no more
825 * Erroneous leading white fix:
826 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
827 white[s] (as opposed to from >> xxx, that removes it [them].
828 - src/gdcmTS.cxx: ditto.
829 - gdcmPython/testSuite.py: dirty related kludge removed.
830 * src/*: remaining references to gdcmParser removed.
831 * src/*[cxx|h]: added copy[way]left header.
834 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
835 * In order to fix writing of dicom files:
836 - Test/TestWriteSimple.cxx: a simpler example of writing.
837 - Test/CMakeLists.txt changed accordingly.
838 - src/gdcmDocument.cxx:
839 -- The destructor now recursilvely removes potential sequences.
840 -- Bug fix in ::IsJPEG2000()
841 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
842 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
844 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
845 to only declared) and build on top of
846 ::GetDocEntryByNumber(guint16, guint16).
847 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
848 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
849 for usage in destructor and treatement of promotion in
850 ::ReplaceOrCreateByNumber().
851 - src/gdcmSQItem.cxx: destructor should better handle his job.
852 Test/TestWriteSimple now runs (or at least it DOES something).
853 * We can now start hutting memory links. A good starting point is:
854 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
855 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
856 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
858 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
859 * Valgrind note: after Mathieu Malaterre teached me how to read
860 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
862 Using gcc, you can force the STL to use malloc and to free memory as
863 soon as possible by globally disabling memory caching.
864 With 3.2.2 and later, you should export the environment variable
865 GLIBCPP_FORCE_NEW before running your program.
866 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
867 simply vanish (it is still not clear to me, whether this means that
868 STL std::string leaks or if valgrind believes it leaks...).
869 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
870 running bin/gdcmTests makeDicomDir):
871 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
872 - Test/makeDicomDir.cxx now properly traps empty lists and returns
874 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
875 SegFaulting (I drowned in DicomDir related code when trying to
876 understand why the list is empty...).
877 * src/gdcmDocument.h: first BSD license header try.
878 * Doc/License.txt added.
880 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
881 * src/gdcmDocument.[h|cxx]:
882 - Clean up of the Transfer related predicates. They are now all based
883 on new method isGivenTransferSyntax, that (should) handle properly
885 - general clean up, simplification, and coding style.
886 - Specific clean up of Parse7FE0() (umproperly named actually).
887 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
889 2004-06-14 Jean-Pierre Roux
891 - fix the display of Sequence Delimitor (SQDepthLevel pb)
892 - fix the display of SQItem ordinal number
893 - add the GetSQItemByOrdinalNumber method
894 - remove some useless never written private methods
896 2004-06-14 Jean-Pierre Roux
898 - adding a constructor taking a gdcmDocEntry as an input param
899 - ReplaceOrCreateByNumber now returns :
900 a gdcmBinEntry * if a Binary (void *) value is passed as a param
901 a gdcmValEntry * if a string value is passed as a param
903 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
904 according to the param type (no longer sets a gdcmDocEntry)
905 - GetValEntryByNumber, GetBinEntryByNumber added
906 - NewValEntryByNumber and NewBinEntryByNumber added
908 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
910 - GetSQItemNumber and SetSQItemNumber added, to provide
911 a (relative) Item identier inside a given Sequence
912 \warning : some pb remaining around this number
914 - AddEntry now takes the Item Number as a param
916 - adding a constructor taking a gdcmDocEntry as an input param
918 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
919 * Memory leak hunt with the following command:
920 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
921 --show-reachable=yes gdcmTests PrintDocument
922 It looks like many (all?) leaks are due to the STL (or a bad usage
923 of the STL. The lines producing the leaks now have a comment with
924 a "MEMORY LEAK" tag: you can retrieve them with
925 grep "MEMORY LEAK" src/*
926 Here are two typical examples which I can't help fixing:
931 char * test = "babo";
932 name = test; //// <--- valgrind detects 960 bytes lost in
933 //// call to std::string::operator=(char const*)
934 name.clear(); //// Doesn't help !
942 std::cout << "Type a bunch of characters followed by RETURN: ";
943 getline(std::cin, line); //// <--- valgrind dectects a loss
944 //// of 1320 bytes in call to
945 /// std::basic_istream<>& std::getline<>
951 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
952 * src/gdcmHeader.[cxx|h]:
953 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
954 and related, moved away to gdcmDocument.
955 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
956 the corresponding protected accessors of inherited class
957 gdcmDocument, removed ! As a consequence gdcmFile had to be
958 declared friend of class gdcmDocument (see below).
959 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
960 - Clean up of undefined or unused methods.
961 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
962 account the changes to gdcmHeader.h).
963 * src/gdcmDocument.h:
964 - gdcmFile is now a friend class (in order to take into account the
965 changes to gdcmHeader.h).
966 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
967 (see changes to gdcmHeader.h).
968 - Accessors (reading on the form GetEntry*) are now public.
969 - Clean up of undefined or unused methods.
970 * src/gdcmDocument.cxx:
971 - adaptation to changes to gdcmDocument.h
972 - ::OpenFile now writes a verbose message when file cannot be opened.
973 - some std::string properly set to VRKey
974 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
975 references to gdcmDocument.
976 * Test/TestFindTags.cxx: changed accordingly to above changes.
977 * gdcmPython/testSuite.py: adapted to renaming of acr files in
978 cvs repository gdcmData.
980 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
981 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
982 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
983 conflicts with gdcmValEntry::voidArea.
984 * src/gdcmValEntry.cxx: unmatching comment wiped out.
985 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
986 Value representation between StringRepresentable and BinaryRepresentable.
987 * src/gdcmDocument.cxx:
988 - method ParseDES: proper indentation restored and usage of
989 gdcmVR::IsVROfGdcmStringRepresentable wired in.
990 - method LoadDocEntry: the fingerprint left in the SetValue() of
991 unloaded entries (length > MaxSizeLoadEntry) had curiously been
992 removed. Reverting to previous code segment with the proper
993 dynamic_cast< gdcmValEntry* >.
994 Note: this was (partially) breaking the python test suite
995 (gdcmPython/testSuite.py) that made usage of the above
996 fingerprint to check presence of "Pixel Data".
997 * src/gdcmDocEntry.h: coding style.
998 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
999 now taken into account.
1000 * gdcmPython/gdcm.i: adaptation to the new internal representation
1001 of gdcm (exit gdcmParser, hello gdcmDocument).
1002 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1004 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1005 anymore, but instead prints the loaded Python dictionary.
1006 * .... alas, the python testSuite is still broken.
1008 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1009 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1011 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1012 * src/gdcmUtil.h : export methods
1014 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1015 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1017 * Initial addition of automatic python testing
1018 * Initial addition of automatic image comparison
1020 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1021 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1022 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1024 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1025 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1026 * Test/ShowDicom.cxx : bug fix for msvc compilation
1027 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1029 2004-05-04 Jean-Pierre Roux
1030 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1031 new concepts (and new classes) :
1032 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1033 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1034 - Sequence Doc Entries (gdcmSeqEntries)
1035 a Sequence is composed of Items.
1036 Each item is a set of Doc Entries (this is recursive)
1037 The non uniqueness of the 'Dicom tag' is due to this recursivity
1038 (never taken into account)
1039 Our unability to add a new 'entry' in the header
1040 at the proper location (neither in the H-Table (map or multimap),
1041 nor in the Chained List is also due to this recursivity.
1042 Don't try, right now, to use/modify/compile these new sources :
1043 nothing is finished.
1044 We just commit all the stuff, 'as is', in order not to loose it.
1046 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1047 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1049 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1050 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1051 file prefix (SetFilePrefix)
1053 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1054 * Add a new test: ShowDicom, for now this is just the c++ version of
1055 checkRead.sh, later it will be able to compare the image read against a
1057 * Replace the DEBUG on the stack with a global entry in cmake interface:
1058 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1060 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1061 * Add an example subdir, with a real example on how to read + write a
1064 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1065 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1066 * Doc/CMakeLists.txt: the main page is now properly differentiated
1067 between the developper and user version.
1068 * Doc/doxygen.config.in: dropped search related obsolete flags
1069 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1071 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1072 * DEVELOPPER: added some helpfull comments for compile/test/install
1075 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1076 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1077 src directory, now generated in the build dir.
1078 2. Tests as mentionned smarter
1080 4. Add a new method in gdcmDict that return the PubDict by name
1081 this is interesting for 3rd party lib like ITK,
1082 where we could set the institution name / patient name...
1084 * ENH: 1. Now the test suite is working for real
1085 2. All binaries are now output in the gdcm-bin directory
1086 (this was not true before)
1088 2004-04-28 Jean-Pierre Roux
1089 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1090 SeQuence indented printing of Dicom Header.
1091 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1092 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1093 Computation of SQDepthLevel is now part of gdcmHeader constructor
1094 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1095 tree-like structure of a Dicom Header.
1096 * FIX Test code cleaning
1098 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1099 * ENH: Adding automatic testing
1100 1. Need a DartConfig.cmake to submit to public
1101 2. Add a test driver gdcmTest.cxx
1102 3. gdcmTestMain, an helper for the main test driver gdcmTest
1103 4. Files in Test don't have a main anymore, this becomes interesting
1104 when we add more and more tests, thus dsw don't have to load
1106 * ENH: Adding a GDCM_DATA_ROOT for testing
1107 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1108 one file instead of seven + some small cleanup
1110 2004-04-22 Jean-Pierre Roux
1111 * ENH Minor changes to the Print() methods.
1112 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1113 Header printing. Example given with :
1114 > PrintHeader fileName 2 new
1115 (SQ based tree-like structure still to be done for the Header ...)
1117 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1118 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1119 1. I have added some unsigned where needed
1120 2. Some function parameter not used -> (void)
1121 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1122 4. g++ don't like character '\' in comment
1123 5. #define jpeg_create_decompress jCreaDecompress
1124 this really need to be fixed
1125 6. virtualize destructor of gdcmObject ... leakage
1126 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1127 this also really need to be fixed
1128 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1129 remove compression file
1130 (as we only do decompression, right ?)
1131 * ENH: Change malloc/calloc/free with c++ equivalent
1133 2004-04-21 Jean-Pierre Roux
1134 * FIX gdcmHeaderHelper::GetXSpacing
1135 when a single value is found (bug ?), xpacing is now
1136 defaulted to yspacing
1138 2004-04-19 Jean-Pierre Roux
1139 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1140 * ENH add parameters :
1141 bool exception_on_error = false,
1142 bool enable_sequences = false,
1143 bool ignore_shadow = false
1144 to the gdcmFile constructors to be full gdcmParser compliant
1145 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1146 to allow reading of PAPYRUS 3.0 files
1148 2004-04-06 Jean-Pierre Roux
1149 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1151 2004-04-02 Jean-Pierre Roux
1152 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1153 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1154 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1156 2004-03-30 Jean-Pierre Roux
1157 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1158 for ACR file, written out as DICOM files (hope so...)
1160 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1161 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1162 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1163 moved to base class gdcmParser and only the specialisation is kept
1165 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1166 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1167 already does the job.
1168 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1169 (to be consistent with gdcmParser::WriteEntries).
1171 2004-03-30 Benoit Regrain
1172 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1173 upate of the object's instance. It's passed to 2 in the unfavorable
1174 case : one in the ExecuteInformation, one in the ExecuteData
1176 2004-03-29 Jean-Pierre Roux
1177 * ENH : Check on file type to be written moved
1178 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1179 * FIX : gdcmObject::ResetBoundaries now stops properly
1180 when end-of-list is reached
1181 : gdcmVersion modified (as Benoit Regrain asked)
1183 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1184 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1185 * src/gdcmUtil.cxx: added forgotten iostream include.
1186 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1187 equivalent to ExplicitVR in existing code).
1189 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1190 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1191 now contains all the gdcmGlobal related code.
1192 * minor coding style and doxygenation changes.
1194 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1195 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1196 now contains all the Debug related code.
1197 * minor clean-up of includes in src/*.cxx
1198 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1199 CreateCleanString) removed.
1200 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1201 * Doc/DoxyMainPageUser.txt added.
1202 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1203 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1204 src/gdcmDirList.cxx)
1206 2004-03-24 Jean-Pierre Roux
1207 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1209 2004-03-23 Jean-Pierre Roux
1210 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1211 big endian made volumes
1212 * ENH Now gdcmParser constructor and destructor are protected to forbid
1213 end user to instanciate class gdcmParser
1214 (only gdcmHeader and gdcmDicomDir are meaningfull)
1216 2004-03-22 Benoit Regrain
1217 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1218 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1219 gdcmSerie to gdcmDicomDirSerie
1221 2004-03-19 Jean-Pierre Roux
1222 * ENH Now the tree-like structure describing a DICOMDIR comming from
1223 an already existing DICOMDIR file is consistent with
1224 the home-made tree-like structure build ex-nihilo
1225 or build from the files held (recursively) in a Directory
1226 functions gdcmDicomDir::CheckBoundaries()
1227 gdcmObject::SetBoundaries() added
1229 2004-03-17 Jean-Pierre Roux
1230 * REM (Eric Boix bug) : removal of meaningless
1231 gdcmDicomDirImage::NewImage function.
1232 * FIX now file names and directory name are written properly in the
1234 * FIX now gdcmDicomDir constructor may be call without any trick
1237 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1238 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1239 of gdcmDicomDirImage::NewImage as empty function.
1241 2004-02-28 Jean-Pierre Roux
1242 * ENH add gdcmDicomDir:NewPatient
1243 add gdcmDicomDirPatient:NewStudy
1244 add gdcmDicomDirStudy:NewSerie
1245 add gdcmDicomDirSerie:NewImage
1246 to allow making gdcDicomDir object.
1247 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1248 (as opposite to the gdcmHeader chained list)
1250 2004-02-11 Benoit Regrain
1251 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1252 when using from python
1254 2004-02-10 Benoit Regrain
1255 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1256 * FIX : in gdcmDicomDir when the directory is empty
1257 * ENH : add callback and methods to get the progression of dicomDir
1260 2004-02-06 Jean-Pierre Roux
1261 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1262 - GDCM_META added to gdcmDicomDirType
1263 - class gdcmMeta created
1264 * ENH : - A brief summary is now displayed at the beginning of
1265 'testDicomDir' to help disaster magnitude estimation
1266 * REM : Now useless Test/explDICOMDIR.cxx
1268 2004-02-05 Benoit Regrain
1269 * ENH : add methods in gdcmObject to get the hash table or the list of
1271 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1272 * FIX : wrapping python for TagHeaderEntryHT
1274 2004-02-04 Benoit Regrain
1275 * FIX : even length for some strings when writting the dicom dir
1276 * FIX : sort the images in the dicom dir
1277 * FIX : Bug fix for python use of dicom dir
1278 * ADD : a python demo
1280 2004-02-04 Jean-Pierre Roux
1281 * FIX : Final solution (?) for icone embedded images
1282 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1283 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1284 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1285 gdcmData/gdcm-MR-SIEMENS-16.acr1
1286 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1287 to make full checking easier
1289 2004-02-04 Benoit Regrain
1290 * FIX : WriteEntries : coding style & logic in parameters
1291 * FIX : Set the elements to create the DicomDir in a dictionary file
1293 2004-02-03 Benoit Regrain
1294 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1295 * gdcmDicomDir : add the load of directory
1296 * Bug fix and print add-on
1298 2004-02-03 Jean-Pierre Roux
1299 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1300 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1301 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1302 * FIX gdcmParser.cxx : 'group length' elements are now considered
1303 as integers, even for shadow groups, when file is Implicit VR
1305 2004-02-02 Jean-Pierre Roux
1306 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1308 of the last synonym :-(
1309 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1311 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1312 * FIX taking into account the possible 7fe0,0010 multiplicity
1313 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1314 to allow removal of references to 7fe0,0010, to deal with
1315 ACR-NEMA images, when 0028,0200 is meaningfull
1317 2004-01-31 Jean-Pierre Roux
1318 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1319 no longer writes 'Un' on disk
1320 * FIX SQ elements with actual length are now dealt with corectly
1321 * FIX gdcmFile::WriteBase make the difference, for color images, between
1322 the length (for Palette expanded images)
1323 and Raw Length (non expanded image + Palette)
1324 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1325 (that broke Write). Replaced by UL.
1326 Aware user will reload the field if he
1327 thinks it's necesssary
1329 2004-01-30 Jean-Pierre Roux
1330 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1331 when 'dirty Acr' is found, to be compliant with the new
1332 IsReadable() methods.
1334 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1335 (no DOUBLE images in kosher DICOM,
1336 but so usefull for people that miss them ;-)
1338 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1339 DICOMDIR related utilities (not checked as Windoze compliant)
1341 2004-01-28 Jean-Pierre Roux
1342 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1344 2004-01-27 Jean-Pierre Roux
1345 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1346 to allow skipping the shadow elements, to save memory space.
1347 The TRUE value for this param has to be used
1348 with a FALSE value for the 'enable_sequence' param.
1349 ('public elements' may be embedded in 'shadow Sequences')
1350 * gdcmHeader methods now deal with 'embedded icones images' in the header
1351 (even when an 'icone image sequence' is announced by the
1352 element (0x0088,0x0200), but there is NO icone at all ...
1354 * gdcmHeader sometimes Image Location value doesn't follow
1355 the supposed processor endianity (see gdcmData/cr172241.dcm).
1358 * gdcmHeader add the method
1359 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1360 to get *all* the Header Entries with the same tag.
1361 GetHeaderEntrySameName is probabely *useless*
1362 (no meaning : Name is *not* an identifier within the Dictionnary)
1364 2004-01-26 Benoit Regrain
1365 * Bug fix in the print of hexadecimal representations. Remove long fields
1366 in the print and add a third level of print to print them
1368 2004-01-23 Benoit Regrain
1369 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1370 * Bug fix on test suite after remove the strip made on not string fields
1371 * Split the IsReadable method between gdcmParser which test that the file
1372 is dicom and gdcmHeader which test that it's an image file
1374 2004-01-22 Benoit Regrain
1375 * DicomDir : clean code, add methods, set variables in protected or private
1376 * gdcmUtil : bug fix for the clean string method
1378 2004-01-19 Benoit Regrain
1379 * Add the use of shadow dictionaries
1380 * bug fix and coding style
1382 2004-01-19 Benoit Regrain
1383 * src/gdcmFile.cxx : bug fix concerning the close of file
1384 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1385 * Add the update of header entries using the shadow library
1387 2004-01-19 Benoit Regrain
1388 * removal of file gdcmHeader2.cxx
1389 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1390 inheriting from gdcmParser. This split is to prepare the integration
1391 of dicom dir parsing
1392 * bug fix under python
1394 2004-01-16 Jean-Pierre Roux
1395 * REM removal of class gdcmHeaderEntrySet
1396 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1397 * ADD add file gdcmHeader2.cxx
1398 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1400 2004-01-15 Benoit Regrain
1401 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1402 entries created while parsing the header. Thus, they will be destroyed
1403 when the gdcmDictSet will be destroyed
1404 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1407 2004-01-15 Benoit Regrain
1408 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1409 made a fatal error because of the memory release at the end of program.
1410 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1411 some memory and vtk seems to have some problems with that.
1412 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1414 2004-01-14 Benoit Regrain
1415 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1416 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1417 * src/*.[h|cxx] : make changes due to class name changes
1418 * gdcmPython/demo/*.py : bug fix due to method names
1420 2004-01-13 Benoit Regrain
1421 * src/*.[h|cxx] : coding style
1422 * vtk/*.[h|cxx] : coding style
1424 2004-01-13 Benoit Regrain
1425 * gdcmPython/testSuite.py : test the readable flag of file for tests
1426 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1427 It's lied to the stl compilation by MSVC (windows, always windows...)
1428 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1430 2004-01-12 Benoit Regrain
1431 * src/*.h : add comments
1432 * src/gdcmDictSet.h : set the method BuildDictPath in public
1433 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1434 directly setted in the source code
1435 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1438 2004-01-09 Benoit Regrain
1439 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1440 * setup.py : use a reference to gdcmVERSION
1442 2004-01-07 Benoit Regrain
1443 * Modification to compile with the distutils.
1446 2003-12-10 Benoit Regrain
1447 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1448 can use a gdcmHeaderHelper to load datas
1449 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1450 made in the source code
1452 2003-12-10 Benoit Regrain
1453 * Update Windows projects and .cvsignore files
1455 2003-11-12 Jean-Pierre Roux
1456 * ENH gdcmHeader constructor has one more parameter (default value : false)
1457 that allows the user to 'go inside' the SeQuences only
1459 gdcmElValSet:Print takes it into account
1461 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1462 * ENH: Update gdcmPython/CMakeLists
1463 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1464 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1466 2003-11-10 Jean-Pierre Roux
1467 * FIX : gdcmHeader::LoadElements is now based
1468 on the ListTag listElem member,
1469 not longer on the TagElValueHT tagHt member
1470 * ENH : PrintPubElVal shows (temporarily) both results,
1471 with the tagHt member and the listElem member.
1472 (it's easier to 'see' the problems when using Printheader)
1474 * FIX : old private member LgrElem is now splitted into
1475 ReadLength : Length actually found on disk (updated only
1476 if bug fixing is necessary), for internal
1478 UsableLength : Updated by FixFoundLength, to fix a bug
1479 or to allow Parser going on.
1480 Will allow to re-write a kosher header when a SeQuence
1481 with a length (not 0000) is found
1482 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1483 because gdcmElValSet::Add does not update ListElem
1486 2003-11-07 Jean-Pierre Roux
1487 * FIX misstyping in Transfert Syntax name table
1488 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1489 when they have an actual length (not 0000 nor FFFFF)
1490 (Nobody should care of it, but DICOMDIR explorers)
1492 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1493 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1495 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1496 * ENH: vtkGdcmReader now supports LUT !
1497 (vtkgdcmViewer for now is not able to use them though)
1499 2003-11-05 Jean-Pierre Roux
1500 * in testSuite.py : new files names for checking the package
1501 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1502 that returns the pixel area size to the *aware* (vtk) user
1503 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1505 2003-11-05 Benoit Regrain
1506 * in testSuite.py : Modify the rules for checking the paths
1507 : Explicit error messages
1508 * in __init__.py : Related modif
1510 2003-11-03 Jean-Pierre Roux
1511 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1512 to be used by aware (vtk) users that want to manage
1513 LUT (and no to turn the PALETTE image into an RGB pixels one)
1514 * GetPixelType now returns 8U for 24 Bits images
1515 (vtkGdcmReader compliant)
1517 2003-10-31 Jean-Pierre Roux
1518 * Removal of *all* gdcmData images and add them again
1519 in order to loose the 'history' of un-anonymised images
1521 2003-10-31 Jean-Pierre Roux
1522 * RMV : removal of useless jBitsInJsample.h
1523 for both 8 and 12 Bits JPEG Lossy Libraries
1525 2003-10-31 Jean-Pierre Roux
1526 * ENH : Add the functions gdcmFile::GetImageDataRaw
1527 gdcmFile::GetImageDataIntoVectorRaw
1528 that act as GetImageData and GetImageDataIntoVector
1529 except the making of an RGB Plane from Gray Plane + LUT
1530 Intended to aware (vtk) users who know how to manage
1533 GetLUTRGBA return a R,G,B,A LUT if any
1534 lgrTotaleRaw gives the 'Raw' length
1535 GetImageDataRaw returns the gray Plane
1536 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1537 (They stay Grey, just like with other Dicom viewers :-(
1539 2003-10-30 Jean-Pierre Roux
1540 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1542 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1543 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1544 being coherents dicom files.
1546 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1547 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1549 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1550 * ENH: Two steps is necessary to please VC++ compiler...
1551 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1552 * ENH: Add include dir to medcon lib
1553 * FIX: only one function is being exported for now !
1554 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1556 2003-10-29 Jean-Pierre Roux
1557 * adding gdcmHeader::GetLUTRGBA
1558 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1559 --> Mathieu, the modif u're waiting for is not yet committed
1560 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1562 2003-10-27 Jean-Pierre Roux
1563 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1564 00191113.dcm DermaColorLossLess.dcm
1565 MxTwinLossLess.dcm RadBWLossLess.dcm
1566 * ENH: For version prior to vtkImageViewer2 -r 1.19
1567 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1569 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1570 * Removal of ido stuff in CMakeLists.txt
1572 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1573 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1574 * FIX: remove a call to ->Modified ... see comments
1575 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1577 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1578 * FIX: Problem with path for libvtkgdcmPython
1579 * ENH: Try adding a search script for python site-package
1580 * RMV: Remove some file from medcon lib that are not necessary
1581 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1582 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1583 * FIX: More pragma disable fro VC++,
1584 I don't think I break something as it is also disable in VTK/ITK.
1585 But it fasten debug compilation time.
1587 2003-10-23 Jean-Pierre Roux
1588 * gdcm now deals with 16 Bits Run Length Encoded images
1589 (they are compressed as 2 planes images,
1590 one for the high Bytes, the other for low Bytes)
1592 2003-10-22 Jean-Pierre Roux
1593 * Now CheckRead takes into account :
1594 - the bugged 'Leonardo' Siemens images
1595 - the XA images, sent thru the burning VPRO station
1596 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1599 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1600 * FIX: When copying a Makefile.am to CMakeLists.txt
1601 one should remove the '\'
1603 2003-10-22 Jean-Pierre Roux
1604 * in gdcmData adding a bugged 'Leonardo' Siemens image
1605 (wrong lengths in header)
1606 OK with gdcm, KO with the other viewers :-)
1607 * add a GE dlx XA image, thru the VEPRO burning station
1610 2003-10-21 Jean-Pierre Roux
1611 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1612 for a brutal checking of vtkgdcmViewer compliance
1614 2003-10-21 Jean-Pierre Roux
1615 * add the files for 'xmedcon' Jpeg Lossless library
1616 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1618 2003-10-21 Jean-Pierre Roux
1619 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1621 2003-10-21 Jean-Pierre Roux
1622 * garbage Siemens 'Leonardo' images dealt with
1623 (the patch is easy to remove)
1624 * cosmetic changes to avoid warnings
1626 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1627 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1628 no need to press 'r' now.
1630 2003-10-20 Jean-Pierre Roux
1631 * upgrade of checkRead.sh checkWrite.sh according
1632 to new Jpeg Lossless decompressor
1633 * add US.3405.1.dcm, a genuine RGB medical file ...
1634 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1635 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1637 2003-10-15 Jean-Pierre Roux
1638 * general anonymisation in gdcmData
1639 * adding the 'color files' from
1640 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1641 * adding some well knowed bugged-header images
1642 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1643 waiting for their inclusion in Python testsuite
1645 2003-10-15 Jean-Pierre Roux
1646 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1647 no longer seg faults when file is not found
1649 2003-10-14 Jean-Pierre Roux
1650 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1653 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1654 * TODO: *.in file to genereate a UseGDCM later
1656 2003-10-14 Jean-Pierre Roux
1657 * Some supposed-to-be Dicom Images have no preamble.
1658 OpenFile takes it into account
1659 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1660 * Missing elements added in dicomV3.dic
1661 (just to be affraid : have a look at
1662 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1663 and do it again next year ;->
1665 2003-10-13 Jean-Pierre Roux
1666 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1667 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1668 But there are NOT. It's fixed !
1670 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1671 * FIX: "jpeglib.h" was not found on VC++
1672 * FIX: vtkgdcm was not being installed
1674 2003-10-10 Jean-Pierre Roux
1675 * ENH : OpenFile closes the file if it *really* doesn't look like
1676 an ACR-NEMA / DICOM one.
1677 * FIX : testWrite no longer writes an empty file if the source file
1678 is not gdcm Readable
1679 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1682 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1683 * FIX: CMake generate now documentation
1684 * ENH: out of source doc build !
1685 * ENH: Generate both user and dev documentation
1686 * ENH: Should work on windows too
1687 * ENH: Only one doxygen config.in file is needed
1688 * FIX: make install should be ok now on ùnix plateform
1689 * FIX: PATH to dictionary was wrong (missing /)
1690 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1692 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1693 * vtkGdcmReader is now able to read rgb dicom file.
1694 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1695 * added a gdcmViewer to vtk test, use mouse to control
1696 window level & window width
1698 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1699 * CMake-ification of gdcm, we have now two build system
1700 * FIX: on cygwin Wsock32 doesn't exist
1701 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1703 2003-10-06 Emanuel Ollart
1704 * FIX : compilation process wad broken.
1705 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1707 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1708 * change gdcmViewer -> vtkgdcmViewer
1709 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1711 2003-10-06 Jean-Pierre Roux
1712 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1713 ( e.g : well known GE images with a wrong elem length,
1714 : Philips MRI Images with a wrong Huffman table)
1715 * still to be done : allow the reading of bugged LEONARDO Siemens images
1717 2003-10-03 Jean-Pierre Roux
1718 * Odd length strings are padded with '\0' (not with spaces,
1719 to remain compliant with already defined strings,
1720 like Transfert Syntax UID and others)
1722 2003-10-03 Jean-Pierre Roux
1723 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1724 to allow displaying RGB images (not only by affim ;-)
1726 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1727 * vtkGdcmReader is now able to read rgb dicom file.
1728 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1730 2003-10-03 Jean-Pierre Roux
1731 * A few nasty patches to allow the reading of a lot of nasty images
1732 ( e.g : well known GE images with a wrong elem length,
1733 : Philips MRI Images with a wrong Huffman table)
1734 * still to be done : allow the reading of bugged LEONARDO Siemens images
1736 2003-10-03 Jean-Pierre Roux
1737 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1739 2003-10-03 Jean-Pierre Roux
1740 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1741 to allow displaying RGB images (not only by affim ;-)
1743 2003-10-03 Jean-Pierre Roux
1744 * gdcmFile::GetImageDataIntoVector now
1745 - deals with MultiFrames MultiFragments Run Length Encoded files
1746 - deals with YcBcR (YBR_FULL) files
1747 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1748 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1750 (no sample found :-(
1752 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1753 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1754 Two reasons: - clear things
1755 - third parties acces gdcm through header files, so won't
1756 suffer anymore VC++ complains
1758 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1759 * add argv[1] in testvtkGdcmReader.cxx
1762 2003-09-24 Jean-Pierre Roux
1763 * The lines are now eigthy characters long.for
1764 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1766 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1767 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1768 char* to std::string. Thus, the use of strdup becomes useless. (see
1769 previous commis of Malaterre)
1770 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1771 before the last Malaterre's commit.
1773 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1774 * This commit should fix the Debug building under VC++, the problem
1775 was mainly a mixture of debug and release lib being loaded at startup.
1776 * I also remove a depency to a specific C function: strdup. Because I had
1777 to force the link to msvcrtd (whereas strdup is in libc).
1779 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1780 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1781 located in the gdcmCommon.h file. All use of reference of tha has been
1782 changed to now use the variable GDCM_UNFOUND.
1784 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1786 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1787 Dicom dictionary. The test suite can now be run again. Note:
1788 I'm note very happy with the " (RET)" changes. I believe this
1789 RETAINED comment should be dropped when parsing the dictionary.
1790 - PACKAGER corrected
1792 - AUTHORS updated and now in alphabetical order
1793 * Makefile.am now exports gdcm.dsw for Windoze users.
1795 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1796 * cygwin complains about missing std:: in subdir Test/
1798 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1799 * remove some methods that are now in gdcmHeaderHelper
1801 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1802 * vtkGdcmReader set spacing and origin correctly
1804 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1805 * Fix a few delete/delete[] mismatch
1807 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1808 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1809 interpretation to data given by gdcmHeader. For instance there are
1810 heuristics to get informations (look at different places).
1811 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1812 sorting DICOM images based on different strategies.
1813 * modified Makefiles accordingly.
1815 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1816 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1817 when building in debug mode
1818 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1819 src/win32/gdcmdll.dsp
1820 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1822 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1823 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1826 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1827 * src/win32/libgdcmjpeg12.dsp was not dos format
1828 * src/win32/libgdcmjpeg12.dsp :
1829 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1830 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1832 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1833 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1835 * src/gdcmFile.cxx : bug fix in affectation type
1836 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1837 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1838 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1839 symbols... future problem ?
1841 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1842 * src/win32/libgdcmijpeg12.dsp was missing
1843 * modified gdcm.dsw accordingly
1845 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1846 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1848 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1849 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1850 commit of JPR (before his hollidays to facilitate our work).
1851 * setup.py : bug fix in code. Modifications made while the last commit
1852 of JPR. The code hasn't been tested before the commit... it's so
1853 useless to make that (for best programmer that is JPR) !!!
1855 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1856 * tagged the current version as Version0_3 (i.e. version 0.3)
1858 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1859 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1860 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1861 * *.dsp : modifications to use new libgdcmijpeg8 library
1862 * setup.py : bug fix on VTKPATH variable
1863 * PACKAGER : adding all concerning windows
1865 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1866 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1868 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1869 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1870 test suite reported error.
1871 * PACKAGER file added (describes what a packager must do when
1872 packaging a new release).
1873 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1874 * configure.in: upgraded version number to 0.3.0
1875 * fixing build of rpm (through rpm -ta):
1876 - Doc/Makefile.am exports proper doxygen files
1877 - src/jpeg/libijg8/Makefile.am exports the include files.
1879 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1880 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1881 * src/gdcmHeader.h : formatting code
1883 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1884 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1885 We were obtaining error message from vtk. Now, creation of file list
1886 is made in an internal list to prevent this problem.
1887 Bug fix when output is empty.
1888 Bug fix in update of progress value. Previous commit for this was a bad
1890 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1892 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1893 * src/gdcmHeader.h : added method to get the file name
1894 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1895 files. Added method to remove all files on the input
1896 Added FIXME comment concerning the bad parsing of header made by
1897 ExecuteInformation method (in ExecuteData method)
1899 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1900 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1901 when using make instal.
1902 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1903 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1905 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1906 * setup.py : adding include dir of jpeg lib to compile all sources
1907 * */Win32/*.dsp : JPR fix for windows compilation
1909 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1910 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1912 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1913 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1915 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1916 * setup.py is again effective on un*x (takes into account the
1917 addon of the jpeg library)
1918 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1919 * Doc/Doxy* updated (includes above enhancements)
1920 * INSTALL now points to web documentation
1922 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1923 * src/gdcmHeader.h doesn't make unnecessary reference to
1925 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1927 * src/gdcm*.[cxx|h] :
1928 - to allow compilation with gcc 3.x
1929 -- clean up of STL usage (added explicit usage of std::)
1930 -- small fixes on exceptions.
1931 Note: linking not tested !
1932 - clean of doxygen comments to avoid warnings at documentation
1934 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1935 dependent convertion).
1937 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1938 * Clean up of previous JPR garbage commit (not even commented in the
1940 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1941 - moved all jpeg related files from src to src/jpeg/libijg8, with
1942 addition/modification of Makefile.am and configure.in.
1943 - the testSuite is still brain damage (not guilty).
1945 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1946 * WrapVTK.py : modifications to get correctly vtk source files to
1948 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1949 (FileName -> Filename)
1951 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1952 * vtk/vtkGdcmReader.[cxx/h]:
1953 - UpdateProgress method should now be effective
1954 - removed the limitation on having only images loaded (as opposed
1956 - when building a stack of images/volume, a lesser number of
1957 gdcmHeader and gdcmFile instances should be used (hopefully
1958 accelerating things).
1959 - when building a stack of images/volumes, files which are not
1960 loadable (wrong path-filename, wrong permissions on existing file,
1961 or file not parsable by gdcm) are replaced with a black image
1962 in the stack (for the caller to notice the problem).
1964 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1965 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1967 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1968 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1969 between standard library (std) and vtk library (problems are found
1970 under Windows... thanks Windows !)
1972 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1973 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1975 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1977 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1978 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1980 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1981 * When compiling with distutils (see setup.py) the C++ compiler is
1982 called with different flags than the default ones (with automake).
1983 In order to fix all those warning, I compiled gdcm with the command
1984 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1985 and went for warning fixes:
1986 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1987 up from unused variables.
1988 - vtk/vtkGdcmReader.cxx: potential bug fix.
1989 * src/gdcmHeader.h: Doxygen warning cleanup
1991 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1992 * gdcmPython/gdcm.i:
1993 - typemaps correction to take into account the systematic replacement
1994 of "using namespace std" with std:: prefix e.g. std::list,
1995 std::string... (cf changes of 2003-05-21).
1996 - gdcmGlob global variable of type gdcmGlobal (defined in
1997 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1998 exported to Python a as cvar.
1999 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2000 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2001 gdcmDictSet.GetPubDictTagNames() and
2002 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2003 C++ static methods).
2004 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2005 with the above changes.
2007 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2008 * setup.py, manifest.in : bug fix under linux
2010 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2011 * Modification of setup.py to compile vtk part too. Then, we have 2
2012 wrappers which must work with same distutils. For that, we have a
2013 generic distutils in distusiltsWrapping.py ; with :
2014 - build_extWrap class to wrap generically all extensions,
2015 - ExtensionWrap base class for all wrapping extension that contains
2017 - Wrapper interface which wrap sources
2018 + In WrapSwig.py we have extension and wrapper for Swig
2019 + In WrapVTK.py we have extension and wrapper for VTK
2020 * MANIFEST.in : modifications to consider vtk directory and new python
2021 files for compilation
2023 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2024 * Added python wrappers of vtkGdcmReader vtk class (see the
2025 source in vtk/vtkGdcmReader.cxx) :
2026 - vtk/Makefile.am now builds a library
2027 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2028 python library (as opposed to _gdcm.so wich are the python
2029 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2030 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2032 - configure.in has an additional flag --enable-vtk that needs
2033 to be set to enable compilation of vtk related code, that is:
2034 + vtk/vtkGdcmReader.so and
2035 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2036 + gdcmPython/vtkgdcmPython.so (see above)
2037 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2038 be read when compressed or when HighBit + 1 != BitsStored),
2039 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2040 the usage of the python wrapper of vtkGdcmReader vtk class.
2041 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2042 * src/*.[h] all occurences of stl classes are now prefixed with
2043 std::, and all occurences of "using namespace std;" where removed.
2044 This is to avoid pollution of global namespace in included files.
2045 Apparently vtk does not avoid this pitfall: when using both
2046 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2047 collision of various stl members (principally cout...).
2048 * gdcmPython/testSuite.py now cleanly removes temprory generated
2050 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2051 comply with above changes)
2053 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2054 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2055 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2056 vtk data structure (an image Flip was required).
2057 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2058 * cosmetic changes in documentation.
2060 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2061 * src/gdcmHeader.cxx: the constructor no longer exits when an
2062 unexisting file is given as argument.
2063 * The subdirectory Data (containing all the images used for the
2064 test suite) is not part of this repository anymore. A new module
2065 containing those images is now available at
2066 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2067 with the name gdcmData.
2068 All the python scripts (including the package initialisation file
2069 gdcmPython/__init__.py) were adapated to take this change into
2070 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2072 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2073 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2074 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2075 demo of the usage of this class.
2076 Compilation of this vtk part is only done when using the --enable-vtk
2077 at configure (or autogen.sh) stage.
2079 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2080 * More memory link related corrections and documentation fixes.
2082 - maximum info is obtained with a command of the form:
2083 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2084 --show-reachable=yes PrintHeader
2085 - the remaining reachable blocks seem to come from the STL
2086 allocation scheme through the usage of map and list. It looks
2087 like this memory cannot be freed but it is not a memory leak
2088 (in fact further invocation to the STL would recollect the
2089 unused memory allthough it cannot explicitely be freed).
2090 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2091 of displaying an image parsed with gdcm and displayed with VTK.
2092 Note: some images don't seem to work e.g.
2093 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2094 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2095 Allthough this weakens the semantics, it is a ditch attempt to
2096 make gdcm more thread friendly.
2098 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2099 * Memory link hunt (by using valgrind through the command
2100 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2101 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2102 gdcmHeader::_dicom_vr.
2103 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2104 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2106 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2108 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2109 * src/Makefile.am now exports all the necessary include files at
2113 * UpdateGroupLength replaced by new one
2116 * UpdateGroupLength re-written using H-Table
2117 (named UpdateGroupLengthNew untill checks are over)
2119 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2120 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2121 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2123 - gdcmHeader::GetPubElValSet removed.
2124 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2125 UpdateGroupLength, WriteElements, Write.
2126 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2127 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2128 carried the same semantics.
2129 - src/gdcmHeaderIdo.cxx changed accordingly.
2130 - gdcmFile::WriteBase now regroups all the codes from previous
2131 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2132 - enum FileType moved to gdcmCommon.h
2133 * src/gdcmHeader.cxx AddDefault trashed
2134 * gdcmGetXSize added
2135 * getimageDataSize now calls gdcmGetXSize
2136 * Test/*.cxx changed to agree with above changes
2138 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2139 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2140 (to avoid double call by end user).
2141 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2142 by end user, since gdcmHeader::gdcmHeader now handles it.
2144 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2145 * gdcm/Doc many doxygen changes:
2146 - Doxyfile now has two different versions, DoxyfileUsers that generates
2147 the html.users end users oriented documentation and
2148 DoxyfileDeveloppers that generates the html.developper developper
2149 oriented documentation.
2150 - README changed accordingly
2151 - requirement.txt removed (old design info moved to TODO).
2152 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2153 DoxyMainPage.txt, DoxyPython.txt provide more information.
2154 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2155 be updated by simply regenerating the docs with doxygen and copying
2156 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2157 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2158 all the tests in the form "if (<map>.count() >1)" were removed.
2159 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2160 ill-formed documentation sections.
2161 * src/gdcmHeader.cxx: ditto
2163 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2164 * setup.py fixed for un*x (needed macro for stdint.h)
2165 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2166 un*ces with sh-utils test utility.
2167 * gdcmPython/demo/test.py renamed to PrintHeader.py
2168 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2169 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2170 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2171 * src/gdcm*.cxx JPR's bad inclusion fixed.
2173 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2174 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2175 * gdcmPython/demo/test.py changed accordingly.
2177 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2178 * gdcmPython/Makefile.am fixed linking against libstdc++
2179 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2180 * Swig subdir (historical tests of swig version 1.3.17++) removed
2181 * Test/testChangeEntete.cxx some lines commented out in order to make
2183 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2184 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2186 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2187 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2188 hence the user doesn't need this explicit call.
2189 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2190 i.e. LoadElements() call removed.
2191 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2192 - src/Makefile.am declares the proper flag for g++.
2193 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2194 for adding user defined new tags.
2195 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2196 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2197 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2199 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2200 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2201 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2202 src/Makefile.am : the project should properly compile and install
2203 with the autotools, included the python wrappers part.
2204 * gdcm.spec.in : added a spec file for RPM packaging.
2206 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2207 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2209 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2210 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2211 to exported to the environement (see gdcmPython/testSuite.py
2213 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2214 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2215 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2216 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2217 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2219 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2220 * gdcmPython/__init__.py doesn't crash anymore when running in
2221 in InstallMode or PreInstallMode but with an environement given
2222 value of GDCM_DICT_PATH.
2223 * src/gdcmDictSet.[cxx/h] coding style.
2225 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2226 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2227 * src/gdcm.h general comments moved to TODO, and README
2228 * src/gdcm.h should now be seen as a user commodity (including it
2229 should suffice to fully use gdcm). It is nowhere including within
2230 any of the kernel files src/*.cxx and src/*.h.
2232 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2233 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2234 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2236 * src/gdcm*.cxx only include their corresponding include file
2237 (as opposed to gdcm.h)
2238 * gdcmPython/gdcm.i changed accordingly
2239 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2240 the autogen.sh generated "make snapshot" command to work.
2241 * autogen.sh removed history related references to crea package.
2243 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2244 * distutilsSwigCPlusPlus.py work around some swig portability
2247 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2248 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2249 was done in a last ditch attempt to get setup.py _really_
2250 operationnal. The python/gdcmPython layaout add the advantage
2251 of hidding away the python related distutils specific files
2252 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2253 Alas, the src directory was out of scope (i.e. it's relative
2254 position to setup.py was ../src) which made things impossible to
2255 handle (see previous version of python/setup.py). Crossing fingers...
2257 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2258 * python/setup.py now works on Un*x. (harder than I thougth)
2259 * python/distutilsSwigCPlusPlus.py can now have include files
2260 among the list of sources.
2262 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2263 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2264 * modifications in MSVC projects
2266 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2267 * As stated by the first lines of Test/ExceptionAndPython/README, it
2268 looks like we can move back to original usage of exception within
2269 src/gdcm* and hence remove the errno stuff that was introduced
2270 as a quick and dirty fixture of this problem (added to the TODO).
2271 * Doc/Doxyfile configuration file for Doxygen and corresponding
2272 README file for usage added.
2273 * Test/testWrite.cxx added. This new test comes from a split of
2274 test.cxx that is now reverted to its original purpous i.e.
2275 testing the proper parsing of a Dicom related file.
2276 testWrite.cxx concentrates on testing the IO part of gdcm.
2277 * Test/bug1.cxx (containing a bug on WIn32) added.
2278 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2279 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2280 whose purpose is to publish the content of the TagNames of the
2281 Dicom public dictionnary were not accessible without an
2282 instance of class gdcmHeader.
2283 - those methods are now static methods of gdcmDictSet and hence
2284 require no instances at all to be invocated.
2285 - within gdcmDictSet this change required to change some method
2286 to class methods (i.e. are now static) among which SetDictPath
2287 (renamed to BuildDictPath) and LoadDefaultPubDict.
2288 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2289 the above changes by calling the new method classes of gdcmDictSet.
2290 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2291 the above to be effective.
2292 * python/gdcmPython: in order to wrap properly the above changes
2293 for Python, swig version now needs to be > 1.3.17.
2294 * python/gdcmPython/Makefile fixed to adapt itself to new
2295 configure/make shema introduced by Johan Montagnat (thanks for the
2296 contribution). Alas this Makefile cannot be turned into a proper
2297 Makefile.am without some heavy changes in the configure.in
2298 (for python dectection).
2299 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2300 now avoids publishing the empty entries.
2302 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2303 * python/setup.py : bug fix concerning install under windows
2304 ExtraPath reused :-P
2305 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2307 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2308 * Dicts/dicomV3.dic : remove double spaces !!!
2309 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2310 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2313 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2314 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2315 method. Doxygenation.
2316 * src/gdcm.h clean up of JPR spurious comments.
2318 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2319 * python/distutilsSwigCPlusPlus.py now properly collects the
2320 shadow classes generated by "swig -c++" (gdcm.py in our case)
2321 when using "python setup.py install".
2322 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2323 reexports the working classes.
2324 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2325 by the classical C errno scheme. This is to prevent an obscure
2326 behavior of the python wrappers when importing wxPython.wx prior
2327 to gdcmPython (which ended up in an abort call). An illustration
2328 of this oddity can be found in the Test/ExceptionAndPython
2329 subdir (see the README file). This problem probably due to
2330 an combination of g++ and dynamic loading.
2331 * added Test/ExceptionAndPython (see above)
2333 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2334 * Changed the layout of the python part to avoid bloating main
2335 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2336 i.e. the distutils arsenal. All the python related stuff is
2337 again in a python subdir, but the package itself is now in
2339 * setup.py was cleaned up:
2340 - pythonIncludePath removed
2341 - python setup.py bdist target is now functional.
2342 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2343 collision with other packages). gdcmPython/demo/*.py changed
2346 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2347 * python subdir moved to gdcmPython (preparation of distutils packaging).
2348 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2349 distutils installer is operational.
2350 * - gdcmPython/__init__.py now properly loads the swig generated
2351 shadow classes (from gdcm.py).
2352 - gdcmPython/demo/*.py changed to import the package gdcmPython
2353 instead of gdcmPython/demo/load.py.
2354 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2356 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2357 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2358 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2359 entries within the associated public Dicom dictionary resp. the same
2360 information but sorted by the fourth field (PAT, IMG, DIR) of the
2362 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2363 are now in the "???" group.
2364 - python/gdcm.i changed accordingly,
2365 - python/demo/printGroupedPublicDict.py added, that gives an example
2366 of the above new functionalities in Python.
2368 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2369 * src/gdcm.h, gdcmHeader.cxx:
2370 - historic references to glib's g_malloc and g_free (#defined)
2371 were definitively removed.
2372 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2373 * src/gdcmElValSet.cxx:
2374 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2375 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2376 - GetElValue(string) renamed to GetElValueByName.
2377 - Added GetElementByName(string).
2378 * src/gdcmHeader.cxx: added
2379 - GetPubElValRepByNumber(guint16, guint16)
2380 - GetPubElValRepByName(string)
2381 - GetShaElValRepByNumber(guint16, guint16)
2382 - GetShaElValRepByName(string)
2383 - GetShaElValByNumber(guint16, guint16)
2384 - GetShaElValRepByName(string)
2385 - GetElValRepByNumber(guint16, guint16)
2386 - GetElValRepByName(string)
2387 - GetElValByNumber(guint16, guint16)
2388 - GetElValRepByName(string)
2389 * Doc/requirements.txt added.
2391 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2392 * Test/Makefile building now depends on the one of libgdcm.so
2393 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2394 pixel data) aware which enables finding the address (offset) of
2395 the pixel data of JPEG encoded DICOM files. This leaves only a single
2396 file in the testSuite whose pixel data address (offset) is unknown.
2397 * python/testSuite.py changed accordingly.
2399 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2400 * VC++ has some strong limitations when working with the STL, as stated
2401 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2402 "Also note that some STL containers (map, set, queue, list, deque)
2403 cannot be exported. [...]
2404 Some STL classes contain nested classes. These classes can not
2406 This is caused by a designed limitation that once a template
2407 class is instantiated, it can not be re-instantiated and
2409 Since our usage of map<> is ubiquitous in gdcm, this "designed
2410 limitation" of VC++ is a pitfall.
2411 Hence the Python wrappers of gdcm cannot be incrementally linked
2412 against the c++ dynamic library. The dirty but only workaround is
2413 to forget about incremental link of dynamic libraries and to generate
2414 the Python wrappers library with the inclusions of the underlying C++
2416 The following modifications concern this matter on Win32/VC++:
2417 - wrapping python correct with standalone wrapped dll (don't use separate
2418 dll under windows !!!!)
2419 - python21_d debug mode enabled (ask Frog how to use it :-)
2420 - NO problem with having an STL member of class for example string in C++
2421 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2422 - Python test of dcmlib in Python is ok under windows on a large set
2424 * removed glib references
2425 * typedef's inserted in gdcm.i for correct swig type management
2427 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2428 * python/demo/*.py load.py extracted from test.py. Added explore.py
2429 that only displays required tags and testAll.py that parses all
2430 the files of the testsuite without using unittest.
2431 * python/testSuite.py other additional test on new files added.
2432 * Data/* new test files added accordingly to the testSuite.
2433 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2434 the vr in the file differs from the one of the dictionary.
2436 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2437 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2438 values, but limits itself to values which are below a user specified
2439 size (by default 1024 bytes).
2440 * python/gdcm.i : elements not loaded (because their size is above the
2441 user specified treshold) are exported with their TagKey as key of the
2442 python dictionary. This enables the testsuite to make some checks
2443 on the unloaded elements (since we have their offset and size).
2444 * python/testSuite.py
2445 - now tests for the existence and proper value of the pixel data
2446 - two new examples added.
2447 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2449 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2450 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2451 aware. See the strategy comments in gdcmHeader::FindeLength().
2452 * Test/test.cxx now accepts a filename as first argument.
2453 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2454 * python/testSuite.py changed to integrate test on above files.
2456 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2457 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2458 the vr was also RET.
2459 * python/testSuite.py more tests added.
2461 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2462 * python/testSuite.py unittest test suite added (uses Data)
2463 * Data/* dcm and acr files for the test suite.
2464 * glib dependance removed from un*x version. We now use ISO C99
2465 7.18 Integer types (see stdint.h)
2466 - python/Makefile, src/Makefile src/gdcm.h
2467 * src/ when an explicit vr (like dicom files) suddenly poped an
2468 implicit element we use to mark the underlying DictEntry of the
2469 concerned ElValue with "Implicit". This strategy was damageable
2470 too the public or provite dictionaries, since some of their vr
2471 would be changed. Since Header::FindLength heavily relies on the
2472 detection by Header::FindVR of falsely explicit elements, I
2473 added an extra ImplicitVr member to ElValue (boolean).
2474 The rest of the changes we the necessary adaptations.
2476 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2477 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2479 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2481 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2482 * Adaptation for porting to VC++:
2484 o forced to use std namespace (for string to be known)
2485 o all class use __declspec export style on WIN32
2486 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2487 (in stdlib.h on Win32 but in std:: for gcc)
2488 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2489 variable GDCM_DICT_PATH.
2490 * src/gdcmHeader.cxx verbose comments made discrete.
2492 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2493 * python/gdcm.i: added a typemap that converts a C++ hashing table
2494 to native Python dictionary.
2495 * python/demo/test.py:
2496 - now uses the native dictionary for exploration of gdcmHeader.
2497 - takes an optional filename argument (the file to parse).
2498 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2499 PubElVals hashing table.
2500 * Dicts/dicomV3.dic removed error prone trailing spaces.
2502 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2503 * Python wrapping process moved away from src/Makefile to
2504 newly created python/Makefile (as well as gdcm.i)
2505 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2506 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2507 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2508 from the environement variable GDCM_DICT_PATH (when existing).
2509 * src/gdcmDict::GetTag bug fix.
2511 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2512 * Straightforward temporary fixes for swig to build the python wrappers.
2513 src/Makefile now has a python working entry [by working we mean
2514 that we can import de shadow classes without errors].
2516 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2517 * hashtest.cxx removed (since allready in Test)
2518 * src/gdcmlib.h renamed to src/gdcm.h
2519 * src/dcm.i renamed to src/gdcm.i
2520 * src/Makefile prepared for python wrapping
2522 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2523 * src/gdcmHeader.cxx :
2524 - Parsing of header is now separated from loading of element values
2525 (see gdcmHeader::LoadElements).
2526 - general clean up of hopefully all file access (creation of
2527 ReadInt16 and ReadInt32)
2529 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2530 * src/gdcmHeader.cxx :
2531 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2533 - SetLgrElem renamed to SetLength
2534 - GetLgrElem renamed to GetLength
2535 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2536 * src/gdcmElValSet.cxx fixed both GetElValue methods
2537 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2538 due to IdoDude was cleaned out.
2540 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2541 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2542 concentrates on finding the value representation (when it exists).
2543 RecupLgr now only finds the element value length, and it avoids
2544 returning the unecessary skL (skipped length).
2545 Also, offsetCourant was simply removed (with taille_fich) since
2546 it was redundant with the File position internals (by using
2547 ftell and fseek). This also made skL (see above in RecupLgr) usage
2549 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2550 on the libido specificities which are handled through class
2552 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2555 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2556 * Truckload of changes. Parsing of header is barely functional
2557 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2559 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2560 * src/gdcmHeader.cxx many addons of low level methods
2562 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2563 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2564 and _IdDcmSWAP_LONG.
2566 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2567 * This corresponds to all the changes decided at the meeting of
2568 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob