1 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
3 because never used... and in the same time, that's remove some memory leaks
5 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmFile.cxx : now delete the PixelConvert instance.
7 * In examples and tests : change the type of image data variables from void*
8 to uint8_t*. Remmove all delete on image data variables
10 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
12 Verify the file pointer value before open the file, and if it's not null,
13 a verbose message is generated.
14 Close correctly the file when the file isn't considered dicom-like. The
15 correctly close is a call to CloseFile.
16 When closing the file pointer, test if its not null to close the file.
17 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
18 file. For an uncompressed image, the copied datas correspond in the least
19 case to the image size (calculated) or the image size specified in the
20 header. A verbose is generated if these two size mismatch
22 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
24 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
25 break under windows (with msvc6 compilation).
27 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
31 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * Bugs fix for the Windows build with VC6
33 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
34 needed (only for projects required VTK). If the VTK is included in all
35 projects, there is conflicts with the jpeg lib of vtk when compiling the
36 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
37 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
38 when compiling the gdcm_wrap.cxx file (created by the compilation of the
40 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
41 (like it's already made for the cout use). Otherwise, conflict with the
44 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
45 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
47 - comments on the DicomDir::Method related usage added.
48 - now that we use the namespace gdcm, a lot of internal classes do
49 NOT need to be wrapped anymore.
50 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
51 DicomDir::Method) new example added.
53 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
54 * Improve string manipulation. I now inforce the notion of 'DicomString'
55 A DicomString can contain as many \0 as they want
56 and it is *always* of even length.
57 We only support odd length for very rare case.
58 And in the near future this should be removed.
60 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
61 * /binary_write/ gdcm source. Now even on big endian we are writting
62 little endian. This should -heopfully- fix some tests
64 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
65 * Now the dictionary is compiled into gdcm lib. This is a default
66 behavior, thus any dic file specified is picked before failback to
67 the one comiled into lib
69 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
70 * Change internals for gdcmDict. Don't use any 'new' any more.
71 This should definitely solve any leak problem, and we should be
72 as fast as before, as long as don't modify too much the dictionary.
74 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
75 * STYLE: ivars should start with a capital letter.
76 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
77 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
79 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
80 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
81 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
82 new 2004 dictionaries added (thanks to JPR).
83 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
84 * CLEANUP_ROUND (15) for gdcmPixelConvert
85 - RLEFrame::NumberFragments is now of type unsigned int
86 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
87 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
90 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
91 * Initial work in gathering all transfer syntax accessors. clearly
92 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
93 ivars, but only one transfersyntax (class) ivar with equivalent method on
96 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
97 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
98 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
99 discussed (plus I didn't like having a 2000 lines patch not commited)
101 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
102 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
103 * CLEANUP_ROUND (14) for gdcmPixelConvert
104 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
105 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
106 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
108 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
109 anymore and hence avoids storing a copy of PixelConvert::Decompressed
110 into File::Pixel_Data.
112 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
113 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
114 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
115 * CLEANUP_ROUND (13) for gdcmPixelConvert
116 Substituted File::ParsePixelData() with PixelConvert::Print() new
118 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
119 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
120 method to those classes.
121 - src/gdcmFile.[cxx|h]:
122 -- Added a ::Print() method.
123 -- PixelConverter is now a reference instead of a member.
124 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
125 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
127 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
128 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
129 collaboration diagram and inheritance diagram should be generated with
131 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
132 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
133 pointlessly wrapped (see
134 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
135 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
136 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
137 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
138 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
139 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
140 -- File::Initialise: PixelConverter setup moved away to
141 PixelConverter::GrabInformationsFromHeader()
142 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
143 interpretation moved away to PixelConverter::BuildRGBImage()
145 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
146 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
147 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
149 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
150 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
151 displayed on Win32 when a brutal abort() occurs (because of uncatched
152 exception). See TODO new entry of this commit for more on this.
153 * TODO added new entry.
154 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
155 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
156 - HandleColor is no longer called from gdcmFile.cxx
157 - gdcmPixelConvert.cxx clean up on method arguments and internal
158 variable names for semantical coherence.
160 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
161 * Finished lossless transition, not only do we now read all lossless jpeg
162 images, without the need of the Cornwell lib, but we do read them properly now
163 * To reduce code (well to avoid code duplication), I defined a common place
164 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
165 redefine symbols. This is not prefect but this the best solution I found for a
166 compilation time jpeg option.
168 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
169 * Update jpeg ijg lib to support lossless jpeg implementation
170 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
172 * Also added a special copyright for dcmtk since we use their bugfixes.
175 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
176 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
177 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
178 matters, as stated in warning note at begining of %include section).
179 * src/gdcmDicomDir*.[cxx|h]: coding style
180 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
181 * src/gdcmJpeg8.cxx: doxygen fix.
182 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
183 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
184 from File:: to PixelConvert::.
186 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
187 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
188 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
189 - more code moved away from File:: to PixelConvert::
190 - fat setup of PixelConverter set in place in File::Initialise.
192 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
193 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
194 namespace at the file system level. So now you should convert your examples
196 gdcmHeader -> gdcm::Header
197 It would be nice if people keep in mind to no open the namespace, since it
198 allows compilation on broken plateform which were defining common symbol in
199 the standart namespace (like LP, Unknown ...)
201 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
202 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
203 The JPEG fragments are now parsed at the same stage than the RLE
204 information. All code related to JPEG is now in gdcmPixelConvert:
205 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
206 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
207 export a gdcmFile:: method. Those are simply global functions
208 (for the time being this is better than having them attach to
209 either gdcmFile:: or gdcmPixelConvert::).
210 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
211 and stores the result in a gdcmJPEGFragmentsInfo.
212 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
213 code (among other stuff) moved away from gdcmFile:; to
216 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
217 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
218 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
219 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
220 clean up of RLE related code.
221 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
222 - src/gdcmRLE.cxx removed
223 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
224 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
225 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
226 * CLEANUP_ROUND (9) for gdcmPixelConvert
227 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
228 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
229 away from gdcmFile:: to gdcmPixelConvert::.
231 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
232 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
233 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
234 This is because Parse7Fe0 used to parse the pixels to compute the
235 length. This task was passed over to FindDocEntryLengthOB() a long
236 time ago, EXCEPT I had forgotten the OW case...
237 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
238 we just recylce the code for parsing RLE fragments and computing
240 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
241 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
242 with the retired Parse7Fe0().
243 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
244 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
246 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
248 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
249 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
250 - src/CMakeLists.txt: alphabetic order reodering + new entries.
251 * CLEANUP_ROUND (4) for gdcmPixelConvert
252 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
253 to return an unused length.
255 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
256 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
257 this should be cleanner from the plane view. The iostream are erally a pain
258 to use to do simple stuff.
260 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
261 * Redo the compilation of the ijg jpeg library. Now only one source is
262 necesseray. No need to rename file by hand what so ever. CMake handle the
263 copying of the file within different directory, configure header file to
264 modify some symbol. The only addition made to ijg wasd a mangle table so
265 that symbol are different wether we are within 8bits or 12bits.
267 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
268 * Added documentation of vtkgdcmReader on Website:
269 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
270 with it's binary name).
271 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
272 the Website to be more complete.
273 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
274 doxygenated documentation.
275 - Doc/DoxyVtkGdcmReaderExamples.txt added
276 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
277 DoxyVtkGdmReaderExamples.html )
278 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
279 * CLEANUP_ROUND (3) for gdcmPixelConvert
280 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
282 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
283 * CLEANUP_ROUND (2) for gdcmPixelConvert
284 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
286 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
287 * CLEANUP_ROUND for gdcmPixelConvert:
288 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
289 - src/gdcmPixelStuff[h|cxx] removed
290 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
291 - src/CMakeLists.txt changed accordingly
293 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
294 gdcmVersion.py moved to newly created ATTIC related
295 gdcmPython/SetupOldies/ directory.
296 * Autotools clean up:
297 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
298 - autogen.sh configure.in acinclude.m4 python.m4 removed
300 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
301 * src/*.cxx *.h Reference to License.htm fixed to License.html.
302 * Doc/CMakeLists.txt, doxygen.config.in: fix.
303 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
305 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * TODO updated with Mathieu suggestions. I proposed a template for
307 describing TODO entries and used it for new entries.
308 * Added Doc/Website/CodingStyle.html, Developpers.html,
309 DeveloppersPython.html, GdcmDataCvs.html and
310 DownloadVersion0_1.html, DownloadVersion0_3.html.
311 * Some Doc/*.txt Doxygen files (which do not really concern the
312 documentation itself, but the website) moved to html and
313 placed in directory Doc/Website:
314 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
315 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
316 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
317 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
318 * CMakeLists.txt changed accordingly.
319 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
320 DeveloppersPython.html
321 * INSTALL nows refers to Doc/Website/Installation.html
323 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
324 * Added Doc/Website directory, that contains a first raw version
327 2004-09-23 Jean-Pierre Roux
328 * FIX In order not to be poluted any longer by casting problems,
329 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
330 we can now delete[] it safely
331 * VoidArea is now called BinArea (less confusing name),
332 and all the methods called ...VoidArea... are now ... BinArea...
333 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
335 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
336 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
337 clear) TagHT, which is an inherited member of gdcmElementSet. It is
338 up to the destructor of gdcmElementSet to clean up TagHt and it's
341 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
342 * Test/CMakeLists.txt: update to follow gdcmData renamings.
343 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
345 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
346 * ENH: added some utility method that builds a flat dictionnary
347 holding all the Dicom entries contained in the recursive structure
348 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
350 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
351 BuildFlatHashTable() that build a flat dictionary.
352 - src/gdcmElementSet.h: added a new private GetTag() accessor.
353 gdcmDocument is now a friend of gdcmElementSet.
354 - src/gdcmElementSet.cxx: clean up.
355 - Example/FlatHashTablePrint.cxx added.
356 - Example/CmakeLists.txt changed accordingly
358 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
359 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
360 moved away from gdcmDocEntrySet (since this class is an abstract class
361 acting like an interface). SQDepthLevel and BaseTagKey are now
363 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
364 and associated accessors. Doxygenation of the class.
365 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
367 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
368 Use SQDepthLevel accessor instead. ::Print() adapted.
369 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
370 - src/gdcmDocument.cxx changed accordingly.
372 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
373 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
374 - The following is the doxygen comment of the typedef declaration
375 of gdcmagKey in src/gdcmCommon.h:
376 gdcmTagKey is made to old an "universal" (as in URL, Universal
377 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
378 A dicom tag allways has a group and an element, but a set of tags
379 embeded in various (optionally nested) sequences and sharing
380 the same group and element all share the same (group, element)
381 "identifier". Hence the (group, element) cannot be used as an
382 identifier (in gdcm we shall refer to a "TagKey") of a tag.
383 In order to construct a proper tag identifier (i.e. a key) we
384 consider the following definition of a TagKey:
385 - let Group, Element be the string representation of the
386 group and element dicom tag members,
387 - let ItemNumber be the string representation of the integer
388 index of the considered item number of a sequence,
389 Let the key of a tag embeded in a sequence, noted SeqTag, be
391 /ItemNumber#Group|Element
392 where "/", "#" and "|" are characters acting as separators.
393 Then the general form of a gdcmTagKey is given by:
394 Group|Element<SeqTag>
395 where <SeqTag> means NO or many instances of SeqTag.
396 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
399 but the gdcmTagKey of a tag "embeded" is the first item of
400 a sequence, itself nested in the third item of a sequence is the
402 0004|1220/2#0008|0082/0#0008|0090
403 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
404 order to hold the new sequence compatible key. Previously, the
405 GetKey() method would look in the underlying gdcmDictEntry.
406 - src/gdcmDocEntry.cxx:
407 -- constructor now copies the underlying DictEntry key, in the local
409 -- ::Print: displays the member Key, instead of the (group, element).
410 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
411 - src/gdcmDocEntrySet.h:xi
412 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
413 -- now has a new BaseTagKey member.
415 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
416 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
418 This poses the problem with the semantics of the following lines
419 LoadEntryVoidArea(0x0028,0x1201); // R LUT
420 LoadEntryVoidArea(0x0028,0x1202); // G LUT
421 LoadEntryVoidArea(0x0028,0x1203); // B LUT
422 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
423 to the long FIXME note for what the problem is. Nevertheless in
424 order to get things working the dicom dictionary was altered !
425 Please fix things urgently...
426 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
427 information), see above note on moving the member VoidArea. Nevertheless
428 the following entries previously correctly set as US are now inproperly
430 0028 1201 OW IMG Red Palette Color Lookup Table Data
431 0028 1202 OW IMG Green Palette Color Lookup Table Data
432 0028 1203 OW IMG Blue Palette Color Lookup Table Data
433 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
434 of gdcmDocEntry moved to gdcmSeqEntry.
435 * src/gdcmSeqEntry.cxx: STYLE.
437 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
438 * Test/TestAllEntryVerify.cxx minor fix and added comments.
440 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
441 * gdcmPython/testSuite.py: all the test suite in python is now moved
442 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
443 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
444 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
446 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
447 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
448 to avoid inclusion recursion until STL is reached.
449 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
450 mecanism. errno.h is not included in gdcm anymore.
451 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
452 (gdcmFormatError now inherits from gdcmFormatUnexpected).
454 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
455 gdcmData/TestAllEntryVerifyReference.txt
456 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
457 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
458 exception_on_error parameter.
459 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
460 - vtk/vtkGdcmReader.cxx changed accordingly,
461 - Example/*.cxx and Test/*.cxx changed accordingly.
463 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
465 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
466 enable_sequences removed from gdcmHeader constructor and dependencies.
467 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
468 * gdcmPython/demo/PrintHeader.py: dummy fix.
469 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
470 skip_shadow removed from gdcmHeader constructor and dependencies.
471 * Example/*.cxx and Test/*.cxx changed accordingly.
473 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
474 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
475 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
477 2004-07-21 Jean-Pierre Roux
478 * FIX Now, Parsing and Printing a DICOMDIR do work!
479 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
481 2004-07-20 Jean-Pierre Roux
482 * FIX Some brain damaged headers have Zero-Lenght fields
483 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
485 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
486 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
487 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
488 variable (instance of gdcmDebug) by a definition macro, and the instance
489 is now in static in the gdcmDebug class
490 * src/gdcmSQItem.h : (FIXME) remove an undefined method
491 * Test/PrintAllDocument.cxx : bug fix in the result of the test
493 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
494 * WARNING: ctest now depends more tightly on gdcmData. You should
495 check out gdcmData properly for things to run smoothly...
496 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
497 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
498 we need the pixels not be loaded in order to use the ValEntry
499 that displays position and size).
500 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
501 This is a C++ based equivalent of gdcmPython/testSuite.py that should
502 be deprecated. If you have any doubts about the advantages of a
503 modern scripting language (read Python) versus grass root C++ (i.e.
504 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
505 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
506 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
507 Anyhow, consider documenting the gdcmData images in
508 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
510 * Test/CMakeLists.txt:
511 - now uses TestAllEntryVerify.cxx
512 - specific comments on oldACR00001.ima (now renamed in gdcmData
513 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
514 gdcmData/TestAllEntryVerifyReference.txt
517 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
518 * src/*.[h|cxx] : typedef clean up
519 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
520 - TagKey renamed to gdcmTagKey (for external usage)
521 - VRKey renamed to gdcmVRKey (for external usage)
522 - removal of typedef duplication.
523 - Removed all unecessary inline keyword from class inline definitions.
524 - Some method|function(void) declarations replaced with method|function().
525 * src/jpeg/libijg12/jdhuff12.c:
526 - printf polluting ctest removed.
527 - TAB removal for comminting
529 - TestAllReadCompareDicom.cxx: added a test that compares all the
530 images in gdcmDataImages.h with corresponding images in
531 gdcmData/BaselineDicom/. When baseline images are not present
532 this test creates them.
533 Note: we need to validate each reference image, but before that
534 I'd like to rename them with a more explicit name...
535 - CMakeLists.txt: changed accordingly.
536 * Example/*.cxx: examples now only include gdcm.h (as opposed to
537 including each header needed).
539 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
540 * Test/*.cxx and Example/*.cxx: moved some examples away from the
541 test suite to the Example directory. Are concerned:
546 - TestWriteSimple.cxx
547 * Test/CMakeLists.txt: added some comments on reasons for black listing
548 image gdcmData/oldACR00001.ima
550 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
551 * Test/CmakeList.txt: removed the following from black list (to be coherent
552 with removal from gdcmData):
553 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
554 - gdcm-MR-PHILIPS-16.dcm
556 Added the following because after last cvs update, they cause
557 ctest -R TestReadWriteReadCompare
559 - gdcm-MR-SIEMENS-16-1.acr
561 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
562 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
563 new comments in this file) we temporarily (sigh) move to a weaker
565 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
566 we don't need to black list the following images anymore:
567 - 8BitsUncompressedColor.dcm
569 - US-PAL-8-10x-echo.dcm
570 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
571 fixes and the beautified code ;-)
572 This fixes the bug introduced in version 1.42 (when beautifying)
573 that made the parsing of 8BitsRunLengthColor.dcm unproper.
574 Note: ctest was blind to this bug (this means we need to still
575 improve the test suite). The bug could be detected by using
576 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
578 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
579 and by displaying the (garbage) produced file temp.XDCM...
581 2004-06-29 Jean-Pierre Roux
582 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
583 - replace by uggly but working old code :-(
584 A lot of things should be OK again.
585 It's really urgent to have a test suite that *tests*,
586 to prevent Frog's beautifying sessions to break all the stuff
587 (twice, withing a fortnigh ...)
589 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
590 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
591 redundancy) to added Test/TestReadWriteReadCompare.cxx
592 * Test/CmakeList.txt: because the compare test of
593 Test/TestReadWriteReadCompare.cxx fails, the following images are
594 black listed: - 8BitsUncompressedColor.dcm
596 - US-PAL-8-10x-echo.dcm
597 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
598 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
599 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
600 and ad-hoc kludge. This kludge is now removed, and on encountering
601 such an image (OB field brain damaged) we set errno. Then in
602 ::FindDocLength() we "fix" the length as being ALL what remains
603 in the file (until EOF). We then proceed, hoping for the best...
604 This fixes a SegFault in ShowDicom when trying to write such an
606 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
607 (because TestWriteRead breaks on it, after a non conformal commit?).
608 ctest now runs properly, except for MakeDicomDir (which was allways
609 broken) and the Python related stuff (still not fixed).
611 2004-06-24 Jean-Pierre Roux
612 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
613 FIX : Test/TestReadWrite now iterates on all the file names
614 (instead of infinite loop)
615 ENH : Test/TestWriteRead now iterates on all the file names
617 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
618 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
620 2004-06-24 Jean-Pierre Roux
621 FIX : - now Write drops LUT Descriptors and LUTs (if any)
622 when SamplesPerPixel =3
623 - now Write is no longer confused by
624 'BitsAllocated = 12" and 'BitsStored=12"
625 - "UN" value representation Elements are now written correctly
626 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
627 ENH : - now gdcmHeader has its own Write methods
628 (in order to split the job that has not to be done
631 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
632 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
633 loop on the same image until memory went out.
634 Note: this means we still have gobs of memory loss in PrintDocument
635 * src/gdcmDocument.cxx: fixes problem on parsing on file
636 gdcmData/16BitsJpegLosslessGrayScale.dcm.
638 2004-06-24 Jean-Pierre Roux
639 FIX : Write - All the Sequences and Sequence Item are now written
640 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
641 is added a the end, when necessary.
642 - A lot of brain-damaged images, that were read correctly are
643 now written correctly
644 - length compatible BinEntry are now loaded correctly
645 (even for odd groups)
646 Note : only Explicit Value Representation was checked.
647 (question : is implicit VR really necessary for gdcm ?)
649 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
650 * DEVELOPPER: added a proposition of coding style.
651 * src/gdcmDocEntry.h: removed every inline declaration (for test of
654 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
655 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
656 Use the gdcmDocEntry::Print() and Write() instead.
657 * src/gdcmDocument.cxx: bug fix.
659 2004-06-22 Jean-Pierre Roux
660 FIX : gdcmDocument.cxx
661 - Now we do recognize the JpegLossLess format (there was a misstyping in
662 code 'beautyfication' :-(
663 - Now we automaticaticaly load the Luts, if any
665 2004-06-22 Jean-Pierre Roux
666 In order : to write Sequences, whatever their imbrication level,
667 : to allow user to create his own Sequences
668 a lot of modif where necessary (adding, moving, or virtualising methods)
670 WARNING : save your own sources *before* cvs up !
673 ADD virtual void Write(FILE *fp, FileType filetype);
676 ADD virtual void Write(FILE *fp, FileType filetype);
677 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
680 ADD virtual void Write (FILE *fp, FileType filetype)=0;
681 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
682 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
683 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
684 ADD std::string GetEntryByName(TagName name);
685 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
687 std::string vr = "unkn",
688 std::string fourth = "unkn",
689 std::string name = "unkn");
690 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
691 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
692 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
693 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
694 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
695 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
696 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
697 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
700 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
701 ADD virtual std::string GetEntryByName (TagName tagName);
702 ADD virtual std::string GetEntryVRByName (TagName tagName);
703 REM virtual bool Write(FILE *, FileType);
704 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
705 FILE *_fp, FileType type);
706 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
707 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
708 REM virtual bool WriteEntries(FILE *_fp,FileType type);
709 REM virtual std::string GetEntryByName (std::string tagName);
710 REM virtual std::string GetEntryVRByName (std::string tagName);
711 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
712 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
713 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
715 std::string vr = "unkn",
716 std::string fourth = "unkn",
717 std::string name = "unkn");
718 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
719 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
720 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
721 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
724 ADD virtual void Write(FILE *fp, FileType filetype);
727 ADD virtual void Write(FILE *fp,FileType filetype);
730 ADD virtual void Write(FILE *fp, FileType filetype);
731 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
732 REM std::string GetEntryByNumber(guint16 group, guint16 element);
733 REM std::string GetEntryByName(TagName name);
736 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
738 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
739 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
740 The default constructor invoked by the line
741 gdcmHeader *f1 = new gdcmHeader( header );
742 was gdcmHeader::gdcmHeader(bool) instead of the expected
743 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
744 Hence the parsing wasn't executed... See also below.
745 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
746 as explicit constructor didn't do the trick to fix the above problem.
747 Could anyone explain why ?
748 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
749 properly calls gdcmValEntry::Print() (that was weed out from
750 code related to gdcmBinEntry).
752 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
753 * In order to fix memory leaks:
754 - Test/TestWriteSimple.cxx: added cleaning of free store through
756 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
757 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
758 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
759 (through the call to ::AddDicomDirMeta()) or the destructor
760 would crash when deleting uninitialized ::metaElems].
761 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
762 - src/gdcmDocument.cxx:
763 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
765 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
766 was causing memory leaks.
767 - src/gdcmSQItem.cxx:
768 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
769 cleanly handled with polymophism: sorry but my milage is low).
770 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
771 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
772 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
773 This avoids SegFaulting.
774 - src/gdcmSQItem.h: coding style.
776 - Test/TestWriteSimple still severely sucks. The output image content
777 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
778 damaged when displayed with vtkgdcmViewer.
779 - on memory leaks: TestWriteSimple leaks really less (see entry
780 of 2004-06-18 in Changelog file for the call to valgrind).
781 - on segfaults: ctest now passes all the tests but one (no more
783 * Erroneous leading white fix:
784 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
785 white[s] (as opposed to from >> xxx, that removes it [them].
786 - src/gdcmTS.cxx: ditto.
787 - gdcmPython/testSuite.py: dirty related kludge removed.
788 * src/*: remaining references to gdcmParser removed.
789 * src/*[cxx|h]: added copy[way]left header.
792 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
793 * In order to fix writing of dicom files:
794 - Test/TestWriteSimple.cxx: a simpler example of writing.
795 - Test/CMakeLists.txt changed accordingly.
796 - src/gdcmDocument.cxx:
797 -- The destructor now recursilvely removes potential sequences.
798 -- Bug fix in ::IsJPEG2000()
799 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
800 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
802 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
803 to only declared) and build on top of
804 ::GetDocEntryByNumber(guint16, guint16).
805 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
806 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
807 for usage in destructor and treatement of promotion in
808 ::ReplaceOrCreateByNumber().
809 - src/gdcmSQItem.cxx: destructor should better handle his job.
810 Test/TestWriteSimple now runs (or at least it DOES something).
811 * We can now start hutting memory links. A good starting point is:
812 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
813 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
814 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
816 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
817 * Valgrind note: after Mathieu Malaterre teached me how to read
818 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
820 Using gcc, you can force the STL to use malloc and to free memory as
821 soon as possible by globally disabling memory caching.
822 With 3.2.2 and later, you should export the environment variable
823 GLIBCPP_FORCE_NEW before running your program.
824 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
825 simply vanish (it is still not clear to me, whether this means that
826 STL std::string leaks or if valgrind believes it leaks...).
827 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
828 running bin/gdcmTests makeDicomDir):
829 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
830 - Test/makeDicomDir.cxx now properly traps empty lists and returns
832 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
833 SegFaulting (I drowned in DicomDir related code when trying to
834 understand why the list is empty...).
835 * src/gdcmDocument.h: first BSD license header try.
836 * Doc/License.txt added.
838 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
839 * src/gdcmDocument.[h|cxx]:
840 - Clean up of the Transfer related predicates. They are now all based
841 on new method isGivenTransferSyntax, that (should) handle properly
843 - general clean up, simplification, and coding style.
844 - Specific clean up of Parse7FE0() (umproperly named actually).
845 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
847 2004-06-14 Jean-Pierre Roux
849 - fix the display of Sequence Delimitor (SQDepthLevel pb)
850 - fix the display of SQItem ordinal number
851 - add the GetSQItemByOrdinalNumber method
852 - remove some useless never written private methods
854 2004-06-14 Jean-Pierre Roux
856 - adding a constructor taking a gdcmDocEntry as an input param
857 - ReplaceOrCreateByNumber now returns :
858 a gdcmBinEntry * if a Binary (void *) value is passed as a param
859 a gdcmValEntry * if a string value is passed as a param
861 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
862 according to the param type (no longer sets a gdcmDocEntry)
863 - GetValEntryByNumber, GetBinEntryByNumber added
864 - NewValEntryByNumber and NewBinEntryByNumber added
866 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
868 - GetSQItemNumber and SetSQItemNumber added, to provide
869 a (relative) Item identier inside a given Sequence
870 \warning : some pb remaining around this number
872 - AddEntry now takes the Item Number as a param
874 - adding a constructor taking a gdcmDocEntry as an input param
876 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
877 * Memory leak hunt with the following command:
878 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
879 --show-reachable=yes gdcmTests PrintDocument
880 It looks like many (all?) leaks are due to the STL (or a bad usage
881 of the STL. The lines producing the leaks now have a comment with
882 a "MEMORY LEAK" tag: you can retrieve them with
883 grep "MEMORY LEAK" src/*
884 Here are two typical examples which I can't help fixing:
889 char * test = "babo";
890 name = test; //// <--- valgrind detects 960 bytes lost in
891 //// call to std::string::operator=(char const*)
892 name.clear(); //// Doesn't help !
900 std::cout << "Type a bunch of characters followed by RETURN: ";
901 getline(std::cin, line); //// <--- valgrind dectects a loss
902 //// of 1320 bytes in call to
903 /// std::basic_istream<>& std::getline<>
909 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
910 * src/gdcmHeader.[cxx|h]:
911 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
912 and related, moved away to gdcmDocument.
913 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
914 the corresponding protected accessors of inherited class
915 gdcmDocument, removed ! As a consequence gdcmFile had to be
916 declared friend of class gdcmDocument (see below).
917 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
918 - Clean up of undefined or unused methods.
919 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
920 account the changes to gdcmHeader.h).
921 * src/gdcmDocument.h:
922 - gdcmFile is now a friend class (in order to take into account the
923 changes to gdcmHeader.h).
924 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
925 (see changes to gdcmHeader.h).
926 - Accessors (reading on the form GetEntry*) are now public.
927 - Clean up of undefined or unused methods.
928 * src/gdcmDocument.cxx:
929 - adaptation to changes to gdcmDocument.h
930 - ::OpenFile now writes a verbose message when file cannot be opened.
931 - some std::string properly set to VRKey
932 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
933 references to gdcmDocument.
934 * Test/TestFindTags.cxx: changed accordingly to above changes.
935 * gdcmPython/testSuite.py: adapted to renaming of acr files in
936 cvs repository gdcmData.
938 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
939 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
940 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
941 conflicts with gdcmValEntry::voidArea.
942 * src/gdcmValEntry.cxx: unmatching comment wiped out.
943 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
944 Value representation between StringRepresentable and BinaryRepresentable.
945 * src/gdcmDocument.cxx:
946 - method ParseDES: proper indentation restored and usage of
947 gdcmVR::IsVROfGdcmStringRepresentable wired in.
948 - method LoadDocEntry: the fingerprint left in the SetValue() of
949 unloaded entries (length > MaxSizeLoadEntry) had curiously been
950 removed. Reverting to previous code segment with the proper
951 dynamic_cast< gdcmValEntry* >.
952 Note: this was (partially) breaking the python test suite
953 (gdcmPython/testSuite.py) that made usage of the above
954 fingerprint to check presence of "Pixel Data".
955 * src/gdcmDocEntry.h: coding style.
956 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
957 now taken into account.
958 * gdcmPython/gdcm.i: adaptation to the new internal representation
959 of gdcm (exit gdcmParser, hello gdcmDocument).
960 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
962 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
963 anymore, but instead prints the loaded Python dictionary.
964 * .... alas, the python testSuite is still broken.
966 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
967 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
969 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
970 * src/gdcmUtil.h : export methods
972 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
973 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
975 * Initial addition of automatic python testing
976 * Initial addition of automatic image comparison
978 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
979 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
980 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
982 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
983 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
984 * Test/ShowDicom.cxx : bug fix for msvc compilation
985 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
987 2004-05-04 Jean-Pierre Roux
988 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
989 new concepts (and new classes) :
990 a 'gdcmDocument' is composed of a set of Doc Entries, that are
991 - elementary gdcmDocEntries (former gdcmHeaderEntries)
992 - Sequence Doc Entries (gdcmSeqEntries)
993 a Sequence is composed of Items.
994 Each item is a set of Doc Entries (this is recursive)
995 The non uniqueness of the 'Dicom tag' is due to this recursivity
996 (never taken into account)
997 Our unability to add a new 'entry' in the header
998 at the proper location (neither in the H-Table (map or multimap),
999 nor in the Chained List is also due to this recursivity.
1000 Don't try, right now, to use/modify/compile these new sources :
1001 nothing is finished.
1002 We just commit all the stuff, 'as is', in order not to loose it.
1004 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1005 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1007 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1008 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1009 file prefix (SetFilePrefix)
1011 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1012 * Add a new test: ShowDicom, for now this is just the c++ version of
1013 checkRead.sh, later it will be able to compare the image read against a
1015 * Replace the DEBUG on the stack with a global entry in cmake interface:
1016 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1018 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1019 * Add an example subdir, with a real example on how to read + write a
1022 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1023 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1024 * Doc/CMakeLists.txt: the main page is now properly differentiated
1025 between the developper and user version.
1026 * Doc/doxygen.config.in: dropped search related obsolete flags
1027 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1029 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1030 * DEVELOPPER: added some helpfull comments for compile/test/install
1033 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1034 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1035 src directory, now generated in the build dir.
1036 2. Tests as mentionned smarter
1038 4. Add a new method in gdcmDict that return the PubDict by name
1039 this is interesting for 3rd party lib like ITK,
1040 where we could set the institution name / patient name...
1042 * ENH: 1. Now the test suite is working for real
1043 2. All binaries are now output in the gdcm-bin directory
1044 (this was not true before)
1046 2004-04-28 Jean-Pierre Roux
1047 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1048 SeQuence indented printing of Dicom Header.
1049 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1050 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1051 Computation of SQDepthLevel is now part of gdcmHeader constructor
1052 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1053 tree-like structure of a Dicom Header.
1054 * FIX Test code cleaning
1056 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1057 * ENH: Adding automatic testing
1058 1. Need a DartConfig.cmake to submit to public
1059 2. Add a test driver gdcmTest.cxx
1060 3. gdcmTestMain, an helper for the main test driver gdcmTest
1061 4. Files in Test don't have a main anymore, this becomes interesting
1062 when we add more and more tests, thus dsw don't have to load
1064 * ENH: Adding a GDCM_DATA_ROOT for testing
1065 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1066 one file instead of seven + some small cleanup
1068 2004-04-22 Jean-Pierre Roux
1069 * ENH Minor changes to the Print() methods.
1070 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1071 Header printing. Example given with :
1072 > PrintHeader fileName 2 new
1073 (SQ based tree-like structure still to be done for the Header ...)
1075 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1076 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1077 1. I have added some unsigned where needed
1078 2. Some function parameter not used -> (void)
1079 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1080 4. g++ don't like character '\' in comment
1081 5. #define jpeg_create_decompress jCreaDecompress
1082 this really need to be fixed
1083 6. virtualize destructor of gdcmObject ... leakage
1084 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1085 this also really need to be fixed
1086 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1087 remove compression file
1088 (as we only do decompression, right ?)
1089 * ENH: Change malloc/calloc/free with c++ equivalent
1091 2004-04-21 Jean-Pierre Roux
1092 * FIX gdcmHeaderHelper::GetXSpacing
1093 when a single value is found (bug ?), xpacing is now
1094 defaulted to yspacing
1096 2004-04-19 Jean-Pierre Roux
1097 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1098 * ENH add parameters :
1099 bool exception_on_error = false,
1100 bool enable_sequences = false,
1101 bool ignore_shadow = false
1102 to the gdcmFile constructors to be full gdcmParser compliant
1103 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1104 to allow reading of PAPYRUS 3.0 files
1106 2004-04-06 Jean-Pierre Roux
1107 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1109 2004-04-02 Jean-Pierre Roux
1110 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1111 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1112 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1114 2004-03-30 Jean-Pierre Roux
1115 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1116 for ACR file, written out as DICOM files (hope so...)
1118 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1119 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1120 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1121 moved to base class gdcmParser and only the specialisation is kept
1123 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1124 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1125 already does the job.
1126 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1127 (to be consistent with gdcmParser::WriteEntries).
1129 2004-03-30 Benoit Regrain
1130 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1131 upate of the object's instance. It's passed to 2 in the unfavorable
1132 case : one in the ExecuteInformation, one in the ExecuteData
1134 2004-03-29 Jean-Pierre Roux
1135 * ENH : Check on file type to be written moved
1136 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1137 * FIX : gdcmObject::ResetBoundaries now stops properly
1138 when end-of-list is reached
1139 : gdcmVersion modified (as Benoit Regrain asked)
1141 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1142 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1143 * src/gdcmUtil.cxx: added forgotten iostream include.
1144 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1145 equivalent to ExplicitVR in existing code).
1147 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1148 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1149 now contains all the gdcmGlobal related code.
1150 * minor coding style and doxygenation changes.
1152 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1153 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1154 now contains all the Debug related code.
1155 * minor clean-up of includes in src/*.cxx
1156 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1157 CreateCleanString) removed.
1158 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1159 * Doc/DoxyMainPageUser.txt added.
1160 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1161 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1162 src/gdcmDirList.cxx)
1164 2004-03-24 Jean-Pierre Roux
1165 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1167 2004-03-23 Jean-Pierre Roux
1168 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1169 big endian made volumes
1170 * ENH Now gdcmParser constructor and destructor are protected to forbid
1171 end user to instanciate class gdcmParser
1172 (only gdcmHeader and gdcmDicomDir are meaningfull)
1174 2004-03-22 Benoit Regrain
1175 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1176 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1177 gdcmSerie to gdcmDicomDirSerie
1179 2004-03-19 Jean-Pierre Roux
1180 * ENH Now the tree-like structure describing a DICOMDIR comming from
1181 an already existing DICOMDIR file is consistent with
1182 the home-made tree-like structure build ex-nihilo
1183 or build from the files held (recursively) in a Directory
1184 functions gdcmDicomDir::CheckBoundaries()
1185 gdcmObject::SetBoundaries() added
1187 2004-03-17 Jean-Pierre Roux
1188 * REM (Eric Boix bug) : removal of meaningless
1189 gdcmDicomDirImage::NewImage function.
1190 * FIX now file names and directory name are written properly in the
1192 * FIX now gdcmDicomDir constructor may be call without any trick
1195 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1196 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1197 of gdcmDicomDirImage::NewImage as empty function.
1199 2004-02-28 Jean-Pierre Roux
1200 * ENH add gdcmDicomDir:NewPatient
1201 add gdcmDicomDirPatient:NewStudy
1202 add gdcmDicomDirStudy:NewSerie
1203 add gdcmDicomDirSerie:NewImage
1204 to allow making gdcDicomDir object.
1205 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1206 (as opposite to the gdcmHeader chained list)
1208 2004-02-11 Benoit Regrain
1209 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1210 when using from python
1212 2004-02-10 Benoit Regrain
1213 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1214 * FIX : in gdcmDicomDir when the directory is empty
1215 * ENH : add callback and methods to get the progression of dicomDir
1218 2004-02-06 Jean-Pierre Roux
1219 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1220 - GDCM_META added to gdcmDicomDirType
1221 - class gdcmMeta created
1222 * ENH : - A brief summary is now displayed at the beginning of
1223 'testDicomDir' to help disaster magnitude estimation
1224 * REM : Now useless Test/explDICOMDIR.cxx
1226 2004-02-05 Benoit Regrain
1227 * ENH : add methods in gdcmObject to get the hash table or the list of
1229 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1230 * FIX : wrapping python for TagHeaderEntryHT
1232 2004-02-04 Benoit Regrain
1233 * FIX : even length for some strings when writting the dicom dir
1234 * FIX : sort the images in the dicom dir
1235 * FIX : Bug fix for python use of dicom dir
1236 * ADD : a python demo
1238 2004-02-04 Jean-Pierre Roux
1239 * FIX : Final solution (?) for icone embedded images
1240 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1241 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1242 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1243 gdcmData/gdcm-MR-SIEMENS-16.acr1
1244 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1245 to make full checking easier
1247 2004-02-04 Benoit Regrain
1248 * FIX : WriteEntries : coding style & logic in parameters
1249 * FIX : Set the elements to create the DicomDir in a dictionary file
1251 2004-02-03 Benoit Regrain
1252 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1253 * gdcmDicomDir : add the load of directory
1254 * Bug fix and print add-on
1256 2004-02-03 Jean-Pierre Roux
1257 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1258 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1259 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1260 * FIX gdcmParser.cxx : 'group length' elements are now considered
1261 as integers, even for shadow groups, when file is Implicit VR
1263 2004-02-02 Jean-Pierre Roux
1264 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1266 of the last synonym :-(
1267 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1269 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1270 * FIX taking into account the possible 7fe0,0010 multiplicity
1271 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1272 to allow removal of references to 7fe0,0010, to deal with
1273 ACR-NEMA images, when 0028,0200 is meaningfull
1275 2004-01-31 Jean-Pierre Roux
1276 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1277 no longer writes 'Un' on disk
1278 * FIX SQ elements with actual length are now dealt with corectly
1279 * FIX gdcmFile::WriteBase make the difference, for color images, between
1280 the length (for Palette expanded images)
1281 and Raw Length (non expanded image + Palette)
1282 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1283 (that broke Write). Replaced by UL.
1284 Aware user will reload the field if he
1285 thinks it's necesssary
1287 2004-01-30 Jean-Pierre Roux
1288 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1289 when 'dirty Acr' is found, to be compliant with the new
1290 IsReadable() methods.
1292 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1293 (no DOUBLE images in kosher DICOM,
1294 but so usefull for people that miss them ;-)
1296 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1297 DICOMDIR related utilities (not checked as Windoze compliant)
1299 2004-01-28 Jean-Pierre Roux
1300 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1302 2004-01-27 Jean-Pierre Roux
1303 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1304 to allow skipping the shadow elements, to save memory space.
1305 The TRUE value for this param has to be used
1306 with a FALSE value for the 'enable_sequence' param.
1307 ('public elements' may be embedded in 'shadow Sequences')
1308 * gdcmHeader methods now deal with 'embedded icones images' in the header
1309 (even when an 'icone image sequence' is announced by the
1310 element (0x0088,0x0200), but there is NO icone at all ...
1312 * gdcmHeader sometimes Image Location value doesn't follow
1313 the supposed processor endianity (see gdcmData/cr172241.dcm).
1316 * gdcmHeader add the method
1317 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1318 to get *all* the Header Entries with the same tag.
1319 GetHeaderEntrySameName is probabely *useless*
1320 (no meaning : Name is *not* an identifier within the Dictionnary)
1322 2004-01-26 Benoit Regrain
1323 * Bug fix in the print of hexadecimal representations. Remove long fields
1324 in the print and add a third level of print to print them
1326 2004-01-23 Benoit Regrain
1327 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1328 * Bug fix on test suite after remove the strip made on not string fields
1329 * Split the IsReadable method between gdcmParser which test that the file
1330 is dicom and gdcmHeader which test that it's an image file
1332 2004-01-22 Benoit Regrain
1333 * DicomDir : clean code, add methods, set variables in protected or private
1334 * gdcmUtil : bug fix for the clean string method
1336 2004-01-19 Benoit Regrain
1337 * Add the use of shadow dictionaries
1338 * bug fix and coding style
1340 2004-01-19 Benoit Regrain
1341 * src/gdcmFile.cxx : bug fix concerning the close of file
1342 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1343 * Add the update of header entries using the shadow library
1345 2004-01-19 Benoit Regrain
1346 * removal of file gdcmHeader2.cxx
1347 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1348 inheriting from gdcmParser. This split is to prepare the integration
1349 of dicom dir parsing
1350 * bug fix under python
1352 2004-01-16 Jean-Pierre Roux
1353 * REM removal of class gdcmHeaderEntrySet
1354 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1355 * ADD add file gdcmHeader2.cxx
1356 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1358 2004-01-15 Benoit Regrain
1359 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1360 entries created while parsing the header. Thus, they will be destroyed
1361 when the gdcmDictSet will be destroyed
1362 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1365 2004-01-15 Benoit Regrain
1366 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1367 made a fatal error because of the memory release at the end of program.
1368 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1369 some memory and vtk seems to have some problems with that.
1370 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1372 2004-01-14 Benoit Regrain
1373 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1374 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1375 * src/*.[h|cxx] : make changes due to class name changes
1376 * gdcmPython/demo/*.py : bug fix due to method names
1378 2004-01-13 Benoit Regrain
1379 * src/*.[h|cxx] : coding style
1380 * vtk/*.[h|cxx] : coding style
1382 2004-01-13 Benoit Regrain
1383 * gdcmPython/testSuite.py : test the readable flag of file for tests
1384 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1385 It's lied to the stl compilation by MSVC (windows, always windows...)
1386 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1388 2004-01-12 Benoit Regrain
1389 * src/*.h : add comments
1390 * src/gdcmDictSet.h : set the method BuildDictPath in public
1391 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1392 directly setted in the source code
1393 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1396 2004-01-09 Benoit Regrain
1397 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1398 * setup.py : use a reference to gdcmVERSION
1400 2004-01-07 Benoit Regrain
1401 * Modification to compile with the distutils.
1404 2003-12-10 Benoit Regrain
1405 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1406 can use a gdcmHeaderHelper to load datas
1407 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1408 made in the source code
1410 2003-12-10 Benoit Regrain
1411 * Update Windows projects and .cvsignore files
1413 2003-11-12 Jean-Pierre Roux
1414 * ENH gdcmHeader constructor has one more parameter (default value : false)
1415 that allows the user to 'go inside' the SeQuences only
1417 gdcmElValSet:Print takes it into account
1419 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1420 * ENH: Update gdcmPython/CMakeLists
1421 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1422 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1424 2003-11-10 Jean-Pierre Roux
1425 * FIX : gdcmHeader::LoadElements is now based
1426 on the ListTag listElem member,
1427 not longer on the TagElValueHT tagHt member
1428 * ENH : PrintPubElVal shows (temporarily) both results,
1429 with the tagHt member and the listElem member.
1430 (it's easier to 'see' the problems when using Printheader)
1432 * FIX : old private member LgrElem is now splitted into
1433 ReadLength : Length actually found on disk (updated only
1434 if bug fixing is necessary), for internal
1436 UsableLength : Updated by FixFoundLength, to fix a bug
1437 or to allow Parser going on.
1438 Will allow to re-write a kosher header when a SeQuence
1439 with a length (not 0000) is found
1440 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1441 because gdcmElValSet::Add does not update ListElem
1444 2003-11-07 Jean-Pierre Roux
1445 * FIX misstyping in Transfert Syntax name table
1446 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1447 when they have an actual length (not 0000 nor FFFFF)
1448 (Nobody should care of it, but DICOMDIR explorers)
1450 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1451 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1453 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1454 * ENH: vtkGdcmReader now supports LUT !
1455 (vtkgdcmViewer for now is not able to use them though)
1457 2003-11-05 Jean-Pierre Roux
1458 * in testSuite.py : new files names for checking the package
1459 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1460 that returns the pixel area size to the *aware* (vtk) user
1461 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1463 2003-11-05 Benoit Regrain
1464 * in testSuite.py : Modify the rules for checking the paths
1465 : Explicit error messages
1466 * in __init__.py : Related modif
1468 2003-11-03 Jean-Pierre Roux
1469 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1470 to be used by aware (vtk) users that want to manage
1471 LUT (and no to turn the PALETTE image into an RGB pixels one)
1472 * GetPixelType now returns 8U for 24 Bits images
1473 (vtkGdcmReader compliant)
1475 2003-10-31 Jean-Pierre Roux
1476 * Removal of *all* gdcmData images and add them again
1477 in order to loose the 'history' of un-anonymised images
1479 2003-10-31 Jean-Pierre Roux
1480 * RMV : removal of useless jBitsInJsample.h
1481 for both 8 and 12 Bits JPEG Lossy Libraries
1483 2003-10-31 Jean-Pierre Roux
1484 * ENH : Add the functions gdcmFile::GetImageDataRaw
1485 gdcmFile::GetImageDataIntoVectorRaw
1486 that act as GetImageData and GetImageDataIntoVector
1487 except the making of an RGB Plane from Gray Plane + LUT
1488 Intended to aware (vtk) users who know how to manage
1491 GetLUTRGBA return a R,G,B,A LUT if any
1492 lgrTotaleRaw gives the 'Raw' length
1493 GetImageDataRaw returns the gray Plane
1494 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1495 (They stay Grey, just like with other Dicom viewers :-(
1497 2003-10-30 Jean-Pierre Roux
1498 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1500 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1501 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1502 being coherents dicom files.
1504 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1505 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1507 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1508 * ENH: Two steps is necessary to please VC++ compiler...
1509 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1510 * ENH: Add include dir to medcon lib
1511 * FIX: only one function is being exported for now !
1512 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1514 2003-10-29 Jean-Pierre Roux
1515 * adding gdcmHeader::GetLUTRGBA
1516 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1517 --> Mathieu, the modif u're waiting for is not yet committed
1518 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1520 2003-10-27 Jean-Pierre Roux
1521 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1522 00191113.dcm DermaColorLossLess.dcm
1523 MxTwinLossLess.dcm RadBWLossLess.dcm
1524 * ENH: For version prior to vtkImageViewer2 -r 1.19
1525 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1527 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1528 * Removal of ido stuff in CMakeLists.txt
1530 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1531 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1532 * FIX: remove a call to ->Modified ... see comments
1533 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1535 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1536 * FIX: Problem with path for libvtkgdcmPython
1537 * ENH: Try adding a search script for python site-package
1538 * RMV: Remove some file from medcon lib that are not necessary
1539 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1540 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1541 * FIX: More pragma disable fro VC++,
1542 I don't think I break something as it is also disable in VTK/ITK.
1543 But it fasten debug compilation time.
1545 2003-10-23 Jean-Pierre Roux
1546 * gdcm now deals with 16 Bits Run Length Encoded images
1547 (they are compressed as 2 planes images,
1548 one for the high Bytes, the other for low Bytes)
1550 2003-10-22 Jean-Pierre Roux
1551 * Now CheckRead takes into account :
1552 - the bugged 'Leonardo' Siemens images
1553 - the XA images, sent thru the burning VPRO station
1554 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1557 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1558 * FIX: When copying a Makefile.am to CMakeLists.txt
1559 one should remove the '\'
1561 2003-10-22 Jean-Pierre Roux
1562 * in gdcmData adding a bugged 'Leonardo' Siemens image
1563 (wrong lengths in header)
1564 OK with gdcm, KO with the other viewers :-)
1565 * add a GE dlx XA image, thru the VEPRO burning station
1568 2003-10-21 Jean-Pierre Roux
1569 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1570 for a brutal checking of vtkgdcmViewer compliance
1572 2003-10-21 Jean-Pierre Roux
1573 * add the files for 'xmedcon' Jpeg Lossless library
1574 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1576 2003-10-21 Jean-Pierre Roux
1577 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1579 2003-10-21 Jean-Pierre Roux
1580 * garbage Siemens 'Leonardo' images dealt with
1581 (the patch is easy to remove)
1582 * cosmetic changes to avoid warnings
1584 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1585 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1586 no need to press 'r' now.
1588 2003-10-20 Jean-Pierre Roux
1589 * upgrade of checkRead.sh checkWrite.sh according
1590 to new Jpeg Lossless decompressor
1591 * add US.3405.1.dcm, a genuine RGB medical file ...
1592 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1593 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1595 2003-10-15 Jean-Pierre Roux
1596 * general anonymisation in gdcmData
1597 * adding the 'color files' from
1598 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1599 * adding some well knowed bugged-header images
1600 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1601 waiting for their inclusion in Python testsuite
1603 2003-10-15 Jean-Pierre Roux
1604 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1605 no longer seg faults when file is not found
1607 2003-10-14 Jean-Pierre Roux
1608 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1611 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1612 * TODO: *.in file to genereate a UseGDCM later
1614 2003-10-14 Jean-Pierre Roux
1615 * Some supposed-to-be Dicom Images have no preamble.
1616 OpenFile takes it into account
1617 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1618 * Missing elements added in dicomV3.dic
1619 (just to be affraid : have a look at
1620 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1621 and do it again next year ;->
1623 2003-10-13 Jean-Pierre Roux
1624 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1625 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1626 But there are NOT. It's fixed !
1628 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1629 * FIX: "jpeglib.h" was not found on VC++
1630 * FIX: vtkgdcm was not being installed
1632 2003-10-10 Jean-Pierre Roux
1633 * ENH : OpenFile closes the file if it *really* doesn't look like
1634 an ACR-NEMA / DICOM one.
1635 * FIX : testWrite no longer writes an empty file if the source file
1636 is not gdcm Readable
1637 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1640 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1641 * FIX: CMake generate now documentation
1642 * ENH: out of source doc build !
1643 * ENH: Generate both user and dev documentation
1644 * ENH: Should work on windows too
1645 * ENH: Only one doxygen config.in file is needed
1646 * FIX: make install should be ok now on ùnix plateform
1647 * FIX: PATH to dictionary was wrong (missing /)
1648 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1650 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1651 * vtkGdcmReader is now able to read rgb dicom file.
1652 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1653 * added a gdcmViewer to vtk test, use mouse to control
1654 window level & window width
1656 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1657 * CMake-ification of gdcm, we have now two build system
1658 * FIX: on cygwin Wsock32 doesn't exist
1659 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1661 2003-10-06 Emanuel Ollart
1662 * FIX : compilation process wad broken.
1663 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1665 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1666 * change gdcmViewer -> vtkgdcmViewer
1667 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1669 2003-10-06 Jean-Pierre Roux
1670 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1671 ( e.g : well known GE images with a wrong elem length,
1672 : Philips MRI Images with a wrong Huffman table)
1673 * still to be done : allow the reading of bugged LEONARDO Siemens images
1675 2003-10-03 Jean-Pierre Roux
1676 * Odd length strings are padded with '\0' (not with spaces,
1677 to remain compliant with already defined strings,
1678 like Transfert Syntax UID and others)
1680 2003-10-03 Jean-Pierre Roux
1681 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1682 to allow displaying RGB images (not only by affim ;-)
1684 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1685 * vtkGdcmReader is now able to read rgb dicom file.
1686 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1688 2003-10-03 Jean-Pierre Roux
1689 * A few nasty patches to allow the reading of a lot of nasty images
1690 ( e.g : well known GE images with a wrong elem length,
1691 : Philips MRI Images with a wrong Huffman table)
1692 * still to be done : allow the reading of bugged LEONARDO Siemens images
1694 2003-10-03 Jean-Pierre Roux
1695 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1697 2003-10-03 Jean-Pierre Roux
1698 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1699 to allow displaying RGB images (not only by affim ;-)
1701 2003-10-03 Jean-Pierre Roux
1702 * gdcmFile::GetImageDataIntoVector now
1703 - deals with MultiFrames MultiFragments Run Length Encoded files
1704 - deals with YcBcR (YBR_FULL) files
1705 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1706 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1708 (no sample found :-(
1710 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1711 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1712 Two reasons: - clear things
1713 - third parties acces gdcm through header files, so won't
1714 suffer anymore VC++ complains
1716 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1717 * add argv[1] in testvtkGdcmReader.cxx
1720 2003-09-24 Jean-Pierre Roux
1721 * The lines are now eigthy characters long.for
1722 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1724 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1725 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1726 char* to std::string. Thus, the use of strdup becomes useless. (see
1727 previous commis of Malaterre)
1728 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1729 before the last Malaterre's commit.
1731 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1732 * This commit should fix the Debug building under VC++, the problem
1733 was mainly a mixture of debug and release lib being loaded at startup.
1734 * I also remove a depency to a specific C function: strdup. Because I had
1735 to force the link to msvcrtd (whereas strdup is in libc).
1737 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1738 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1739 located in the gdcmCommon.h file. All use of reference of tha has been
1740 changed to now use the variable GDCM_UNFOUND.
1742 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1744 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1745 Dicom dictionary. The test suite can now be run again. Note:
1746 I'm note very happy with the " (RET)" changes. I believe this
1747 RETAINED comment should be dropped when parsing the dictionary.
1748 - PACKAGER corrected
1750 - AUTHORS updated and now in alphabetical order
1751 * Makefile.am now exports gdcm.dsw for Windoze users.
1753 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1754 * cygwin complains about missing std:: in subdir Test/
1756 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1757 * remove some methods that are now in gdcmHeaderHelper
1759 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1760 * vtkGdcmReader set spacing and origin correctly
1762 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1763 * Fix a few delete/delete[] mismatch
1765 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1766 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1767 interpretation to data given by gdcmHeader. For instance there are
1768 heuristics to get informations (look at different places).
1769 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1770 sorting DICOM images based on different strategies.
1771 * modified Makefiles accordingly.
1773 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1774 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1775 when building in debug mode
1776 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1777 src/win32/gdcmdll.dsp
1778 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1780 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1781 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1784 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1785 * src/win32/libgdcmjpeg12.dsp was not dos format
1786 * src/win32/libgdcmjpeg12.dsp :
1787 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1788 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1790 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1791 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1793 * src/gdcmFile.cxx : bug fix in affectation type
1794 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1795 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1796 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1797 symbols... future problem ?
1799 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1800 * src/win32/libgdcmijpeg12.dsp was missing
1801 * modified gdcm.dsw accordingly
1803 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1804 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1806 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1807 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1808 commit of JPR (before his hollidays to facilitate our work).
1809 * setup.py : bug fix in code. Modifications made while the last commit
1810 of JPR. The code hasn't been tested before the commit... it's so
1811 useless to make that (for best programmer that is JPR) !!!
1813 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1814 * tagged the current version as Version0_3 (i.e. version 0.3)
1816 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1817 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1818 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1819 * *.dsp : modifications to use new libgdcmijpeg8 library
1820 * setup.py : bug fix on VTKPATH variable
1821 * PACKAGER : adding all concerning windows
1823 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1824 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1826 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1827 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1828 test suite reported error.
1829 * PACKAGER file added (describes what a packager must do when
1830 packaging a new release).
1831 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1832 * configure.in: upgraded version number to 0.3.0
1833 * fixing build of rpm (through rpm -ta):
1834 - Doc/Makefile.am exports proper doxygen files
1835 - src/jpeg/libijg8/Makefile.am exports the include files.
1837 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1838 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1839 * src/gdcmHeader.h : formatting code
1841 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1842 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1843 We were obtaining error message from vtk. Now, creation of file list
1844 is made in an internal list to prevent this problem.
1845 Bug fix when output is empty.
1846 Bug fix in update of progress value. Previous commit for this was a bad
1848 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1850 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1851 * src/gdcmHeader.h : added method to get the file name
1852 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1853 files. Added method to remove all files on the input
1854 Added FIXME comment concerning the bad parsing of header made by
1855 ExecuteInformation method (in ExecuteData method)
1857 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1858 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1859 when using make instal.
1860 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1861 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1863 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1864 * setup.py : adding include dir of jpeg lib to compile all sources
1865 * */Win32/*.dsp : JPR fix for windows compilation
1867 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1868 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1870 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1871 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1873 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1874 * setup.py is again effective on un*x (takes into account the
1875 addon of the jpeg library)
1876 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1877 * Doc/Doxy* updated (includes above enhancements)
1878 * INSTALL now points to web documentation
1880 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1881 * src/gdcmHeader.h doesn't make unnecessary reference to
1883 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1885 * src/gdcm*.[cxx|h] :
1886 - to allow compilation with gcc 3.x
1887 -- clean up of STL usage (added explicit usage of std::)
1888 -- small fixes on exceptions.
1889 Note: linking not tested !
1890 - clean of doxygen comments to avoid warnings at documentation
1892 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1893 dependent convertion).
1895 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1896 * Clean up of previous JPR garbage commit (not even commented in the
1898 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1899 - moved all jpeg related files from src to src/jpeg/libijg8, with
1900 addition/modification of Makefile.am and configure.in.
1901 - the testSuite is still brain damage (not guilty).
1903 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1904 * WrapVTK.py : modifications to get correctly vtk source files to
1906 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1907 (FileName -> Filename)
1909 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1910 * vtk/vtkGdcmReader.[cxx/h]:
1911 - UpdateProgress method should now be effective
1912 - removed the limitation on having only images loaded (as opposed
1914 - when building a stack of images/volume, a lesser number of
1915 gdcmHeader and gdcmFile instances should be used (hopefully
1916 accelerating things).
1917 - when building a stack of images/volumes, files which are not
1918 loadable (wrong path-filename, wrong permissions on existing file,
1919 or file not parsable by gdcm) are replaced with a black image
1920 in the stack (for the caller to notice the problem).
1922 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1923 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1925 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1926 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1927 between standard library (std) and vtk library (problems are found
1928 under Windows... thanks Windows !)
1930 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1931 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1933 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1935 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1936 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1938 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1939 * When compiling with distutils (see setup.py) the C++ compiler is
1940 called with different flags than the default ones (with automake).
1941 In order to fix all those warning, I compiled gdcm with the command
1942 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1943 and went for warning fixes:
1944 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1945 up from unused variables.
1946 - vtk/vtkGdcmReader.cxx: potential bug fix.
1947 * src/gdcmHeader.h: Doxygen warning cleanup
1949 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1950 * gdcmPython/gdcm.i:
1951 - typemaps correction to take into account the systematic replacement
1952 of "using namespace std" with std:: prefix e.g. std::list,
1953 std::string... (cf changes of 2003-05-21).
1954 - gdcmGlob global variable of type gdcmGlobal (defined in
1955 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1956 exported to Python a as cvar.
1957 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1958 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1959 gdcmDictSet.GetPubDictTagNames() and
1960 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1961 C++ static methods).
1962 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1963 with the above changes.
1965 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1966 * setup.py, manifest.in : bug fix under linux
1968 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1969 * Modification of setup.py to compile vtk part too. Then, we have 2
1970 wrappers which must work with same distutils. For that, we have a
1971 generic distutils in distusiltsWrapping.py ; with :
1972 - build_extWrap class to wrap generically all extensions,
1973 - ExtensionWrap base class for all wrapping extension that contains
1975 - Wrapper interface which wrap sources
1976 + In WrapSwig.py we have extension and wrapper for Swig
1977 + In WrapVTK.py we have extension and wrapper for VTK
1978 * MANIFEST.in : modifications to consider vtk directory and new python
1979 files for compilation
1981 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1982 * Added python wrappers of vtkGdcmReader vtk class (see the
1983 source in vtk/vtkGdcmReader.cxx) :
1984 - vtk/Makefile.am now builds a library
1985 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1986 python library (as opposed to _gdcm.so wich are the python
1987 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1988 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1990 - configure.in has an additional flag --enable-vtk that needs
1991 to be set to enable compilation of vtk related code, that is:
1992 + vtk/vtkGdcmReader.so and
1993 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1994 + gdcmPython/vtkgdcmPython.so (see above)
1995 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1996 be read when compressed or when HighBit + 1 != BitsStored),
1997 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1998 the usage of the python wrapper of vtkGdcmReader vtk class.
1999 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2000 * src/*.[h] all occurences of stl classes are now prefixed with
2001 std::, and all occurences of "using namespace std;" where removed.
2002 This is to avoid pollution of global namespace in included files.
2003 Apparently vtk does not avoid this pitfall: when using both
2004 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2005 collision of various stl members (principally cout...).
2006 * gdcmPython/testSuite.py now cleanly removes temprory generated
2008 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2009 comply with above changes)
2011 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2012 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2013 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2014 vtk data structure (an image Flip was required).
2015 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2016 * cosmetic changes in documentation.
2018 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2019 * src/gdcmHeader.cxx: the constructor no longer exits when an
2020 unexisting file is given as argument.
2021 * The subdirectory Data (containing all the images used for the
2022 test suite) is not part of this repository anymore. A new module
2023 containing those images is now available at
2024 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2025 with the name gdcmData.
2026 All the python scripts (including the package initialisation file
2027 gdcmPython/__init__.py) were adapated to take this change into
2028 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2030 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2031 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2032 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2033 demo of the usage of this class.
2034 Compilation of this vtk part is only done when using the --enable-vtk
2035 at configure (or autogen.sh) stage.
2037 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2038 * More memory link related corrections and documentation fixes.
2040 - maximum info is obtained with a command of the form:
2041 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2042 --show-reachable=yes PrintHeader
2043 - the remaining reachable blocks seem to come from the STL
2044 allocation scheme through the usage of map and list. It looks
2045 like this memory cannot be freed but it is not a memory leak
2046 (in fact further invocation to the STL would recollect the
2047 unused memory allthough it cannot explicitely be freed).
2048 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2049 of displaying an image parsed with gdcm and displayed with VTK.
2050 Note: some images don't seem to work e.g.
2051 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2052 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2053 Allthough this weakens the semantics, it is a ditch attempt to
2054 make gdcm more thread friendly.
2056 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2057 * Memory link hunt (by using valgrind through the command
2058 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2059 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2060 gdcmHeader::_dicom_vr.
2061 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2062 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2064 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2066 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2067 * src/Makefile.am now exports all the necessary include files at
2071 * UpdateGroupLength replaced by new one
2074 * UpdateGroupLength re-written using H-Table
2075 (named UpdateGroupLengthNew untill checks are over)
2077 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2078 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2079 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2081 - gdcmHeader::GetPubElValSet removed.
2082 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2083 UpdateGroupLength, WriteElements, Write.
2084 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2085 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2086 carried the same semantics.
2087 - src/gdcmHeaderIdo.cxx changed accordingly.
2088 - gdcmFile::WriteBase now regroups all the codes from previous
2089 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2090 - enum FileType moved to gdcmCommon.h
2091 * src/gdcmHeader.cxx AddDefault trashed
2092 * gdcmGetXSize added
2093 * getimageDataSize now calls gdcmGetXSize
2094 * Test/*.cxx changed to agree with above changes
2096 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2097 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2098 (to avoid double call by end user).
2099 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2100 by end user, since gdcmHeader::gdcmHeader now handles it.
2102 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2103 * gdcm/Doc many doxygen changes:
2104 - Doxyfile now has two different versions, DoxyfileUsers that generates
2105 the html.users end users oriented documentation and
2106 DoxyfileDeveloppers that generates the html.developper developper
2107 oriented documentation.
2108 - README changed accordingly
2109 - requirement.txt removed (old design info moved to TODO).
2110 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2111 DoxyMainPage.txt, DoxyPython.txt provide more information.
2112 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2113 be updated by simply regenerating the docs with doxygen and copying
2114 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2115 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2116 all the tests in the form "if (<map>.count() >1)" were removed.
2117 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2118 ill-formed documentation sections.
2119 * src/gdcmHeader.cxx: ditto
2121 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2122 * setup.py fixed for un*x (needed macro for stdint.h)
2123 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2124 un*ces with sh-utils test utility.
2125 * gdcmPython/demo/test.py renamed to PrintHeader.py
2126 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2127 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2128 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2129 * src/gdcm*.cxx JPR's bad inclusion fixed.
2131 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2132 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2133 * gdcmPython/demo/test.py changed accordingly.
2135 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2136 * gdcmPython/Makefile.am fixed linking against libstdc++
2137 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2138 * Swig subdir (historical tests of swig version 1.3.17++) removed
2139 * Test/testChangeEntete.cxx some lines commented out in order to make
2141 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2142 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2144 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2145 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2146 hence the user doesn't need this explicit call.
2147 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2148 i.e. LoadElements() call removed.
2149 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2150 - src/Makefile.am declares the proper flag for g++.
2151 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2152 for adding user defined new tags.
2153 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2154 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2155 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2157 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2158 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2159 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2160 src/Makefile.am : the project should properly compile and install
2161 with the autotools, included the python wrappers part.
2162 * gdcm.spec.in : added a spec file for RPM packaging.
2164 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2165 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2167 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2168 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2169 to exported to the environement (see gdcmPython/testSuite.py
2171 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2172 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2173 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2174 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2175 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2177 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2178 * gdcmPython/__init__.py doesn't crash anymore when running in
2179 in InstallMode or PreInstallMode but with an environement given
2180 value of GDCM_DICT_PATH.
2181 * src/gdcmDictSet.[cxx/h] coding style.
2183 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2184 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2185 * src/gdcm.h general comments moved to TODO, and README
2186 * src/gdcm.h should now be seen as a user commodity (including it
2187 should suffice to fully use gdcm). It is nowhere including within
2188 any of the kernel files src/*.cxx and src/*.h.
2190 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2191 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2192 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2194 * src/gdcm*.cxx only include their corresponding include file
2195 (as opposed to gdcm.h)
2196 * gdcmPython/gdcm.i changed accordingly
2197 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2198 the autogen.sh generated "make snapshot" command to work.
2199 * autogen.sh removed history related references to crea package.
2201 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2202 * distutilsSwigCPlusPlus.py work around some swig portability
2205 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2206 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2207 was done in a last ditch attempt to get setup.py _really_
2208 operationnal. The python/gdcmPython layaout add the advantage
2209 of hidding away the python related distutils specific files
2210 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2211 Alas, the src directory was out of scope (i.e. it's relative
2212 position to setup.py was ../src) which made things impossible to
2213 handle (see previous version of python/setup.py). Crossing fingers...
2215 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2216 * python/setup.py now works on Un*x. (harder than I thougth)
2217 * python/distutilsSwigCPlusPlus.py can now have include files
2218 among the list of sources.
2220 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2221 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2222 * modifications in MSVC projects
2224 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2225 * As stated by the first lines of Test/ExceptionAndPython/README, it
2226 looks like we can move back to original usage of exception within
2227 src/gdcm* and hence remove the errno stuff that was introduced
2228 as a quick and dirty fixture of this problem (added to the TODO).
2229 * Doc/Doxyfile configuration file for Doxygen and corresponding
2230 README file for usage added.
2231 * Test/testWrite.cxx added. This new test comes from a split of
2232 test.cxx that is now reverted to its original purpous i.e.
2233 testing the proper parsing of a Dicom related file.
2234 testWrite.cxx concentrates on testing the IO part of gdcm.
2235 * Test/bug1.cxx (containing a bug on WIn32) added.
2236 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2237 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2238 whose purpose is to publish the content of the TagNames of the
2239 Dicom public dictionnary were not accessible without an
2240 instance of class gdcmHeader.
2241 - those methods are now static methods of gdcmDictSet and hence
2242 require no instances at all to be invocated.
2243 - within gdcmDictSet this change required to change some method
2244 to class methods (i.e. are now static) among which SetDictPath
2245 (renamed to BuildDictPath) and LoadDefaultPubDict.
2246 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2247 the above changes by calling the new method classes of gdcmDictSet.
2248 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2249 the above to be effective.
2250 * python/gdcmPython: in order to wrap properly the above changes
2251 for Python, swig version now needs to be > 1.3.17.
2252 * python/gdcmPython/Makefile fixed to adapt itself to new
2253 configure/make shema introduced by Johan Montagnat (thanks for the
2254 contribution). Alas this Makefile cannot be turned into a proper
2255 Makefile.am without some heavy changes in the configure.in
2256 (for python dectection).
2257 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2258 now avoids publishing the empty entries.
2260 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2261 * python/setup.py : bug fix concerning install under windows
2262 ExtraPath reused :-P
2263 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2265 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2266 * Dicts/dicomV3.dic : remove double spaces !!!
2267 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2268 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2271 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2272 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2273 method. Doxygenation.
2274 * src/gdcm.h clean up of JPR spurious comments.
2276 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2277 * python/distutilsSwigCPlusPlus.py now properly collects the
2278 shadow classes generated by "swig -c++" (gdcm.py in our case)
2279 when using "python setup.py install".
2280 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2281 reexports the working classes.
2282 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2283 by the classical C errno scheme. This is to prevent an obscure
2284 behavior of the python wrappers when importing wxPython.wx prior
2285 to gdcmPython (which ended up in an abort call). An illustration
2286 of this oddity can be found in the Test/ExceptionAndPython
2287 subdir (see the README file). This problem probably due to
2288 an combination of g++ and dynamic loading.
2289 * added Test/ExceptionAndPython (see above)
2291 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2292 * Changed the layout of the python part to avoid bloating main
2293 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2294 i.e. the distutils arsenal. All the python related stuff is
2295 again in a python subdir, but the package itself is now in
2297 * setup.py was cleaned up:
2298 - pythonIncludePath removed
2299 - python setup.py bdist target is now functional.
2300 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2301 collision with other packages). gdcmPython/demo/*.py changed
2304 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2305 * python subdir moved to gdcmPython (preparation of distutils packaging).
2306 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2307 distutils installer is operational.
2308 * - gdcmPython/__init__.py now properly loads the swig generated
2309 shadow classes (from gdcm.py).
2310 - gdcmPython/demo/*.py changed to import the package gdcmPython
2311 instead of gdcmPython/demo/load.py.
2312 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2314 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2315 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2316 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2317 entries within the associated public Dicom dictionary resp. the same
2318 information but sorted by the fourth field (PAT, IMG, DIR) of the
2320 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2321 are now in the "???" group.
2322 - python/gdcm.i changed accordingly,
2323 - python/demo/printGroupedPublicDict.py added, that gives an example
2324 of the above new functionalities in Python.
2326 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2327 * src/gdcm.h, gdcmHeader.cxx:
2328 - historic references to glib's g_malloc and g_free (#defined)
2329 were definitively removed.
2330 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2331 * src/gdcmElValSet.cxx:
2332 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2333 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2334 - GetElValue(string) renamed to GetElValueByName.
2335 - Added GetElementByName(string).
2336 * src/gdcmHeader.cxx: added
2337 - GetPubElValRepByNumber(guint16, guint16)
2338 - GetPubElValRepByName(string)
2339 - GetShaElValRepByNumber(guint16, guint16)
2340 - GetShaElValRepByName(string)
2341 - GetShaElValByNumber(guint16, guint16)
2342 - GetShaElValRepByName(string)
2343 - GetElValRepByNumber(guint16, guint16)
2344 - GetElValRepByName(string)
2345 - GetElValByNumber(guint16, guint16)
2346 - GetElValRepByName(string)
2347 * Doc/requirements.txt added.
2349 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2350 * Test/Makefile building now depends on the one of libgdcm.so
2351 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2352 pixel data) aware which enables finding the address (offset) of
2353 the pixel data of JPEG encoded DICOM files. This leaves only a single
2354 file in the testSuite whose pixel data address (offset) is unknown.
2355 * python/testSuite.py changed accordingly.
2357 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2358 * VC++ has some strong limitations when working with the STL, as stated
2359 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2360 "Also note that some STL containers (map, set, queue, list, deque)
2361 cannot be exported. [...]
2362 Some STL classes contain nested classes. These classes can not
2364 This is caused by a designed limitation that once a template
2365 class is instantiated, it can not be re-instantiated and
2367 Since our usage of map<> is ubiquitous in gdcm, this "designed
2368 limitation" of VC++ is a pitfall.
2369 Hence the Python wrappers of gdcm cannot be incrementally linked
2370 against the c++ dynamic library. The dirty but only workaround is
2371 to forget about incremental link of dynamic libraries and to generate
2372 the Python wrappers library with the inclusions of the underlying C++
2374 The following modifications concern this matter on Win32/VC++:
2375 - wrapping python correct with standalone wrapped dll (don't use separate
2376 dll under windows !!!!)
2377 - python21_d debug mode enabled (ask Frog how to use it :-)
2378 - NO problem with having an STL member of class for example string in C++
2379 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2380 - Python test of dcmlib in Python is ok under windows on a large set
2382 * removed glib references
2383 * typedef's inserted in gdcm.i for correct swig type management
2385 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2386 * python/demo/*.py load.py extracted from test.py. Added explore.py
2387 that only displays required tags and testAll.py that parses all
2388 the files of the testsuite without using unittest.
2389 * python/testSuite.py other additional test on new files added.
2390 * Data/* new test files added accordingly to the testSuite.
2391 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2392 the vr in the file differs from the one of the dictionary.
2394 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2395 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2396 values, but limits itself to values which are below a user specified
2397 size (by default 1024 bytes).
2398 * python/gdcm.i : elements not loaded (because their size is above the
2399 user specified treshold) are exported with their TagKey as key of the
2400 python dictionary. This enables the testsuite to make some checks
2401 on the unloaded elements (since we have their offset and size).
2402 * python/testSuite.py
2403 - now tests for the existence and proper value of the pixel data
2404 - two new examples added.
2405 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2407 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2408 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2409 aware. See the strategy comments in gdcmHeader::FindeLength().
2410 * Test/test.cxx now accepts a filename as first argument.
2411 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2412 * python/testSuite.py changed to integrate test on above files.
2414 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2415 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2416 the vr was also RET.
2417 * python/testSuite.py more tests added.
2419 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2420 * python/testSuite.py unittest test suite added (uses Data)
2421 * Data/* dcm and acr files for the test suite.
2422 * glib dependance removed from un*x version. We now use ISO C99
2423 7.18 Integer types (see stdint.h)
2424 - python/Makefile, src/Makefile src/gdcm.h
2425 * src/ when an explicit vr (like dicom files) suddenly poped an
2426 implicit element we use to mark the underlying DictEntry of the
2427 concerned ElValue with "Implicit". This strategy was damageable
2428 too the public or provite dictionaries, since some of their vr
2429 would be changed. Since Header::FindLength heavily relies on the
2430 detection by Header::FindVR of falsely explicit elements, I
2431 added an extra ImplicitVr member to ElValue (boolean).
2432 The rest of the changes we the necessary adaptations.
2434 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2435 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2437 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2439 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2440 * Adaptation for porting to VC++:
2442 o forced to use std namespace (for string to be known)
2443 o all class use __declspec export style on WIN32
2444 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2445 (in stdlib.h on Win32 but in std:: for gcc)
2446 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2447 variable GDCM_DICT_PATH.
2448 * src/gdcmHeader.cxx verbose comments made discrete.
2450 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2451 * python/gdcm.i: added a typemap that converts a C++ hashing table
2452 to native Python dictionary.
2453 * python/demo/test.py:
2454 - now uses the native dictionary for exploration of gdcmHeader.
2455 - takes an optional filename argument (the file to parse).
2456 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2457 PubElVals hashing table.
2458 * Dicts/dicomV3.dic removed error prone trailing spaces.
2460 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2461 * Python wrapping process moved away from src/Makefile to
2462 newly created python/Makefile (as well as gdcm.i)
2463 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2464 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2465 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2466 from the environement variable GDCM_DICT_PATH (when existing).
2467 * src/gdcmDict::GetTag bug fix.
2469 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2470 * Straightforward temporary fixes for swig to build the python wrappers.
2471 src/Makefile now has a python working entry [by working we mean
2472 that we can import de shadow classes without errors].
2474 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2475 * hashtest.cxx removed (since allready in Test)
2476 * src/gdcmlib.h renamed to src/gdcm.h
2477 * src/dcm.i renamed to src/gdcm.i
2478 * src/Makefile prepared for python wrapping
2480 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2481 * src/gdcmHeader.cxx :
2482 - Parsing of header is now separated from loading of element values
2483 (see gdcmHeader::LoadElements).
2484 - general clean up of hopefully all file access (creation of
2485 ReadInt16 and ReadInt32)
2487 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2488 * src/gdcmHeader.cxx :
2489 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2491 - SetLgrElem renamed to SetLength
2492 - GetLgrElem renamed to GetLength
2493 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2494 * src/gdcmElValSet.cxx fixed both GetElValue methods
2495 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2496 due to IdoDude was cleaned out.
2498 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2499 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2500 concentrates on finding the value representation (when it exists).
2501 RecupLgr now only finds the element value length, and it avoids
2502 returning the unecessary skL (skipped length).
2503 Also, offsetCourant was simply removed (with taille_fich) since
2504 it was redundant with the File position internals (by using
2505 ftell and fseek). This also made skL (see above in RecupLgr) usage
2507 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2508 on the libido specificities which are handled through class
2510 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2513 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2514 * Truckload of changes. Parsing of header is barely functional
2515 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2517 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2518 * src/gdcmHeader.cxx many addons of low level methods
2520 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2521 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2522 and _IdDcmSWAP_LONG.
2524 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2525 * This corresponds to all the changes decided at the meeting of
2526 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob