1 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
3 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
5 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
7 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
9 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
10 set because already copied when copying the BinEntry's of the header
11 * Test/TestAllReadCompareDicom.cxx : remove warnings
13 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
15 Two problems appear when doing it :
16 - with the gdcmFile : when the GetImageData method is called, the pixels
17 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
18 datas (pixels). And each structure destruct the datas when it's
19 destructed. So we have two destructions for the same datas. To solve it,
20 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
21 datas or not. If it doesn't own datas, then they will not destroyed by
23 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
24 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
25 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
26 create a double destruction of the same DocEntry's. So, to solve it,
27 the TagHT is simply cleared and the DicomDir* elements are destroyed.
28 * TODO : add an entry concerning memory leaks in the DicomDir
30 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
32 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
35 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
37 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
38 after it have been deleted
40 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
41 * FIX: src/* fix the doxygen warnings.
42 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
43 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
44 was erroneously defined with a size of 15 instead of 16. [many thanks
45 to Jean Michel Rouet for pointing out this bug].
47 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
48 1. Finish merging JMR patch for writting DICOM from scratch
49 2. Fix -hopefully- bug with MONOCHROME and space vs null character
50 3. Use const ref when possible
51 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
52 5. A few more comments
53 6. CreateUniqueUID can now be called without parameter"
55 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
56 * ENH: Slightly bigger patch:
57 1. Getting toward full integration of JMR patch for writting dicom from scratch
58 2. Update Test to test part of this patch: CreateUniqueUID
59 3. File was not close properly in gdcmDict
60 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
61 5. Use of const ref instead of copy (speed issue)
62 6. Remove temporary (duplicate) string in TranslateToKey
63 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
64 8. Do not repeat virtual in subclasses
65 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
67 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
68 * Apply first patch toward better string comparison when dealing with broken
69 DICOM files. Essentially the string could be padded with a space instead
70 of a null character as defined by standard
72 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
74 because never used... and in the same time, that's remove some memory leaks
76 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * src/gdcmFile.cxx : now delete the PixelConvert instance.
78 * In examples and tests : change the type of image data variables from void*
79 to uint8_t*. Remmove all delete on image data variables
81 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
83 Verify the file pointer value before open the file, and if it's not null,
84 a verbose message is generated.
85 Close correctly the file when the file isn't considered dicom-like. The
86 correctly close is a call to CloseFile.
87 When closing the file pointer, test if its not null to close the file.
88 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
89 file. For an uncompressed image, the copied datas correspond in the least
90 case to the image size (calculated) or the image size specified in the
91 header. A verbose is generated if these two size mismatch
93 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
94 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
95 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
96 break under windows (with msvc6 compilation).
98 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
100 compiling with MSVC6)
102 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * Bugs fix for the Windows build with VC6
104 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
105 needed (only for projects required VTK). If the VTK is included in all
106 projects, there is conflicts with the jpeg lib of vtk when compiling the
107 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
108 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
109 when compiling the gdcm_wrap.cxx file (created by the compilation of the
111 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
112 (like it's already made for the cout use). Otherwise, conflict with the
115 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
116 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
118 - comments on the DicomDir::Method related usage added.
119 - now that we use the namespace gdcm, a lot of internal classes do
120 NOT need to be wrapped anymore.
121 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
122 DicomDir::Method) new example added.
124 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
125 * Improve string manipulation. I now inforce the notion of 'DicomString'
126 A DicomString can contain as many \0 as they want
127 and it is *always* of even length.
128 We only support odd length for very rare case.
129 And in the near future this should be removed.
131 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
132 * /binary_write/ gdcm source. Now even on big endian we are writting
133 little endian. This should -heopfully- fix some tests
135 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
136 * Now the dictionary is compiled into gdcm lib. This is a default
137 behavior, thus any dic file specified is picked before failback to
138 the one comiled into lib
140 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
141 * Change internals for gdcmDict. Don't use any 'new' any more.
142 This should definitely solve any leak problem, and we should be
143 as fast as before, as long as don't modify too much the dictionary.
145 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
146 * STYLE: ivars should start with a capital letter.
147 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
148 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
150 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
151 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
152 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
153 new 2004 dictionaries added (thanks to JPR).
154 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
155 * CLEANUP_ROUND (15) for gdcmPixelConvert
156 - RLEFrame::NumberFragments is now of type unsigned int
157 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
158 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
161 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
162 * Initial work in gathering all transfer syntax accessors. clearly
163 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
164 ivars, but only one transfersyntax (class) ivar with equivalent method on
167 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
168 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
169 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
170 discussed (plus I didn't like having a 2000 lines patch not commited)
172 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
173 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
174 * CLEANUP_ROUND (14) for gdcmPixelConvert
175 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
176 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
177 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
179 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
180 anymore and hence avoids storing a copy of PixelConvert::Decompressed
181 into File::Pixel_Data.
183 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
184 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
185 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
186 * CLEANUP_ROUND (13) for gdcmPixelConvert
187 Substituted File::ParsePixelData() with PixelConvert::Print() new
189 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
190 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
191 method to those classes.
192 - src/gdcmFile.[cxx|h]:
193 -- Added a ::Print() method.
194 -- PixelConverter is now a reference instead of a member.
195 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
196 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
198 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
199 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
200 collaboration diagram and inheritance diagram should be generated with
202 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
203 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
204 pointlessly wrapped (see
205 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
206 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
207 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
208 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
209 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
210 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
211 -- File::Initialise: PixelConverter setup moved away to
212 PixelConverter::GrabInformationsFromHeader()
213 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
214 interpretation moved away to PixelConverter::BuildRGBImage()
216 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
217 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
218 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
220 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
221 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
222 displayed on Win32 when a brutal abort() occurs (because of uncatched
223 exception). See TODO new entry of this commit for more on this.
224 * TODO added new entry.
225 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
226 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
227 - HandleColor is no longer called from gdcmFile.cxx
228 - gdcmPixelConvert.cxx clean up on method arguments and internal
229 variable names for semantical coherence.
231 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
232 * Finished lossless transition, not only do we now read all lossless jpeg
233 images, without the need of the Cornwell lib, but we do read them properly now
234 * To reduce code (well to avoid code duplication), I defined a common place
235 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
236 redefine symbols. This is not prefect but this the best solution I found for a
237 compilation time jpeg option.
239 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
240 * Update jpeg ijg lib to support lossless jpeg implementation
241 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
243 * Also added a special copyright for dcmtk since we use their bugfixes.
246 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
248 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
249 matters, as stated in warning note at begining of %include section).
250 * src/gdcmDicomDir*.[cxx|h]: coding style
251 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
252 * src/gdcmJpeg8.cxx: doxygen fix.
253 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
254 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
255 from File:: to PixelConvert::.
257 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
258 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
259 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
260 - more code moved away from File:: to PixelConvert::
261 - fat setup of PixelConverter set in place in File::Initialise.
263 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
264 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
265 namespace at the file system level. So now you should convert your examples
267 gdcmHeader -> gdcm::Header
268 It would be nice if people keep in mind to no open the namespace, since it
269 allows compilation on broken plateform which were defining common symbol in
270 the standart namespace (like LP, Unknown ...)
272 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
273 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
274 The JPEG fragments are now parsed at the same stage than the RLE
275 information. All code related to JPEG is now in gdcmPixelConvert:
276 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
277 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
278 export a gdcmFile:: method. Those are simply global functions
279 (for the time being this is better than having them attach to
280 either gdcmFile:: or gdcmPixelConvert::).
281 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
282 and stores the result in a gdcmJPEGFragmentsInfo.
283 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
284 code (among other stuff) moved away from gdcmFile:; to
287 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
288 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
289 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
290 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
291 clean up of RLE related code.
292 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
293 - src/gdcmRLE.cxx removed
294 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
295 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
296 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
297 * CLEANUP_ROUND (9) for gdcmPixelConvert
298 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
299 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
300 away from gdcmFile:: to gdcmPixelConvert::.
302 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
303 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
304 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
305 This is because Parse7Fe0 used to parse the pixels to compute the
306 length. This task was passed over to FindDocEntryLengthOB() a long
307 time ago, EXCEPT I had forgotten the OW case...
308 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
309 we just recylce the code for parsing RLE fragments and computing
311 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
312 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
313 with the retired Parse7Fe0().
314 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
315 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
317 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
318 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
319 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
320 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
321 - src/CMakeLists.txt: alphabetic order reodering + new entries.
322 * CLEANUP_ROUND (4) for gdcmPixelConvert
323 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
324 to return an unused length.
326 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
327 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
328 this should be cleanner from the plane view. The iostream are erally a pain
329 to use to do simple stuff.
331 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
332 * Redo the compilation of the ijg jpeg library. Now only one source is
333 necesseray. No need to rename file by hand what so ever. CMake handle the
334 copying of the file within different directory, configure header file to
335 modify some symbol. The only addition made to ijg wasd a mangle table so
336 that symbol are different wether we are within 8bits or 12bits.
338 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
339 * Added documentation of vtkgdcmReader on Website:
340 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
341 with it's binary name).
342 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
343 the Website to be more complete.
344 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
345 doxygenated documentation.
346 - Doc/DoxyVtkGdcmReaderExamples.txt added
347 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
348 DoxyVtkGdmReaderExamples.html )
349 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
350 * CLEANUP_ROUND (3) for gdcmPixelConvert
351 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
353 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
354 * CLEANUP_ROUND (2) for gdcmPixelConvert
355 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
357 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
358 * CLEANUP_ROUND for gdcmPixelConvert:
359 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
360 - src/gdcmPixelStuff[h|cxx] removed
361 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
362 - src/CMakeLists.txt changed accordingly
364 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
365 gdcmVersion.py moved to newly created ATTIC related
366 gdcmPython/SetupOldies/ directory.
367 * Autotools clean up:
368 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
369 - autogen.sh configure.in acinclude.m4 python.m4 removed
371 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
372 * src/*.cxx *.h Reference to License.htm fixed to License.html.
373 * Doc/CMakeLists.txt, doxygen.config.in: fix.
374 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
376 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
377 * TODO updated with Mathieu suggestions. I proposed a template for
378 describing TODO entries and used it for new entries.
379 * Added Doc/Website/CodingStyle.html, Developpers.html,
380 DeveloppersPython.html, GdcmDataCvs.html and
381 DownloadVersion0_1.html, DownloadVersion0_3.html.
382 * Some Doc/*.txt Doxygen files (which do not really concern the
383 documentation itself, but the website) moved to html and
384 placed in directory Doc/Website:
385 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
386 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
387 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
388 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
389 * CMakeLists.txt changed accordingly.
390 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
391 DeveloppersPython.html
392 * INSTALL nows refers to Doc/Website/Installation.html
394 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
395 * Added Doc/Website directory, that contains a first raw version
398 2004-09-23 Jean-Pierre Roux
399 * FIX In order not to be poluted any longer by casting problems,
400 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
401 we can now delete[] it safely
402 * VoidArea is now called BinArea (less confusing name),
403 and all the methods called ...VoidArea... are now ... BinArea...
404 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
406 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
407 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
408 clear) TagHT, which is an inherited member of gdcmElementSet. It is
409 up to the destructor of gdcmElementSet to clean up TagHt and it's
412 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
413 * Test/CMakeLists.txt: update to follow gdcmData renamings.
414 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
416 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
417 * ENH: added some utility method that builds a flat dictionnary
418 holding all the Dicom entries contained in the recursive structure
419 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
421 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
422 BuildFlatHashTable() that build a flat dictionary.
423 - src/gdcmElementSet.h: added a new private GetTag() accessor.
424 gdcmDocument is now a friend of gdcmElementSet.
425 - src/gdcmElementSet.cxx: clean up.
426 - Example/FlatHashTablePrint.cxx added.
427 - Example/CmakeLists.txt changed accordingly
429 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
430 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
431 moved away from gdcmDocEntrySet (since this class is an abstract class
432 acting like an interface). SQDepthLevel and BaseTagKey are now
434 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
435 and associated accessors. Doxygenation of the class.
436 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
438 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
439 Use SQDepthLevel accessor instead. ::Print() adapted.
440 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
441 - src/gdcmDocument.cxx changed accordingly.
443 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
444 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
445 - The following is the doxygen comment of the typedef declaration
446 of gdcmagKey in src/gdcmCommon.h:
447 gdcmTagKey is made to old an "universal" (as in URL, Universal
448 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
449 A dicom tag allways has a group and an element, but a set of tags
450 embeded in various (optionally nested) sequences and sharing
451 the same group and element all share the same (group, element)
452 "identifier". Hence the (group, element) cannot be used as an
453 identifier (in gdcm we shall refer to a "TagKey") of a tag.
454 In order to construct a proper tag identifier (i.e. a key) we
455 consider the following definition of a TagKey:
456 - let Group, Element be the string representation of the
457 group and element dicom tag members,
458 - let ItemNumber be the string representation of the integer
459 index of the considered item number of a sequence,
460 Let the key of a tag embeded in a sequence, noted SeqTag, be
462 /ItemNumber#Group|Element
463 where "/", "#" and "|" are characters acting as separators.
464 Then the general form of a gdcmTagKey is given by:
465 Group|Element<SeqTag>
466 where <SeqTag> means NO or many instances of SeqTag.
467 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
470 but the gdcmTagKey of a tag "embeded" is the first item of
471 a sequence, itself nested in the third item of a sequence is the
473 0004|1220/2#0008|0082/0#0008|0090
474 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
475 order to hold the new sequence compatible key. Previously, the
476 GetKey() method would look in the underlying gdcmDictEntry.
477 - src/gdcmDocEntry.cxx:
478 -- constructor now copies the underlying DictEntry key, in the local
480 -- ::Print: displays the member Key, instead of the (group, element).
481 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
482 - src/gdcmDocEntrySet.h:xi
483 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
484 -- now has a new BaseTagKey member.
486 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
487 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
489 This poses the problem with the semantics of the following lines
490 LoadEntryVoidArea(0x0028,0x1201); // R LUT
491 LoadEntryVoidArea(0x0028,0x1202); // G LUT
492 LoadEntryVoidArea(0x0028,0x1203); // B LUT
493 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
494 to the long FIXME note for what the problem is. Nevertheless in
495 order to get things working the dicom dictionary was altered !
496 Please fix things urgently...
497 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
498 information), see above note on moving the member VoidArea. Nevertheless
499 the following entries previously correctly set as US are now inproperly
501 0028 1201 OW IMG Red Palette Color Lookup Table Data
502 0028 1202 OW IMG Green Palette Color Lookup Table Data
503 0028 1203 OW IMG Blue Palette Color Lookup Table Data
504 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
505 of gdcmDocEntry moved to gdcmSeqEntry.
506 * src/gdcmSeqEntry.cxx: STYLE.
508 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
509 * Test/TestAllEntryVerify.cxx minor fix and added comments.
511 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
512 * gdcmPython/testSuite.py: all the test suite in python is now moved
513 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
514 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
515 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
517 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
518 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
519 to avoid inclusion recursion until STL is reached.
520 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
521 mecanism. errno.h is not included in gdcm anymore.
522 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
523 (gdcmFormatError now inherits from gdcmFormatUnexpected).
525 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
526 gdcmData/TestAllEntryVerifyReference.txt
527 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
528 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
529 exception_on_error parameter.
530 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
531 - vtk/vtkGdcmReader.cxx changed accordingly,
532 - Example/*.cxx and Test/*.cxx changed accordingly.
534 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
535 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
536 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
537 enable_sequences removed from gdcmHeader constructor and dependencies.
538 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
539 * gdcmPython/demo/PrintHeader.py: dummy fix.
540 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
541 skip_shadow removed from gdcmHeader constructor and dependencies.
542 * Example/*.cxx and Test/*.cxx changed accordingly.
544 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
545 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
546 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
548 2004-07-21 Jean-Pierre Roux
549 * FIX Now, Parsing and Printing a DICOMDIR do work!
550 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
552 2004-07-20 Jean-Pierre Roux
553 * FIX Some brain damaged headers have Zero-Lenght fields
554 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
556 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
557 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
558 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
559 variable (instance of gdcmDebug) by a definition macro, and the instance
560 is now in static in the gdcmDebug class
561 * src/gdcmSQItem.h : (FIXME) remove an undefined method
562 * Test/PrintAllDocument.cxx : bug fix in the result of the test
564 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
565 * WARNING: ctest now depends more tightly on gdcmData. You should
566 check out gdcmData properly for things to run smoothly...
567 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
568 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
569 we need the pixels not be loaded in order to use the ValEntry
570 that displays position and size).
571 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
572 This is a C++ based equivalent of gdcmPython/testSuite.py that should
573 be deprecated. If you have any doubts about the advantages of a
574 modern scripting language (read Python) versus grass root C++ (i.e.
575 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
576 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
577 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
578 Anyhow, consider documenting the gdcmData images in
579 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
581 * Test/CMakeLists.txt:
582 - now uses TestAllEntryVerify.cxx
583 - specific comments on oldACR00001.ima (now renamed in gdcmData
584 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
585 gdcmData/TestAllEntryVerifyReference.txt
588 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
589 * src/*.[h|cxx] : typedef clean up
590 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
591 - TagKey renamed to gdcmTagKey (for external usage)
592 - VRKey renamed to gdcmVRKey (for external usage)
593 - removal of typedef duplication.
594 - Removed all unecessary inline keyword from class inline definitions.
595 - Some method|function(void) declarations replaced with method|function().
596 * src/jpeg/libijg12/jdhuff12.c:
597 - printf polluting ctest removed.
598 - TAB removal for comminting
600 - TestAllReadCompareDicom.cxx: added a test that compares all the
601 images in gdcmDataImages.h with corresponding images in
602 gdcmData/BaselineDicom/. When baseline images are not present
603 this test creates them.
604 Note: we need to validate each reference image, but before that
605 I'd like to rename them with a more explicit name...
606 - CMakeLists.txt: changed accordingly.
607 * Example/*.cxx: examples now only include gdcm.h (as opposed to
608 including each header needed).
610 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
611 * Test/*.cxx and Example/*.cxx: moved some examples away from the
612 test suite to the Example directory. Are concerned:
617 - TestWriteSimple.cxx
618 * Test/CMakeLists.txt: added some comments on reasons for black listing
619 image gdcmData/oldACR00001.ima
621 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
622 * Test/CmakeList.txt: removed the following from black list (to be coherent
623 with removal from gdcmData):
624 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
625 - gdcm-MR-PHILIPS-16.dcm
627 Added the following because after last cvs update, they cause
628 ctest -R TestReadWriteReadCompare
630 - gdcm-MR-SIEMENS-16-1.acr
632 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
633 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
634 new comments in this file) we temporarily (sigh) move to a weaker
636 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
637 we don't need to black list the following images anymore:
638 - 8BitsUncompressedColor.dcm
640 - US-PAL-8-10x-echo.dcm
641 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
642 fixes and the beautified code ;-)
643 This fixes the bug introduced in version 1.42 (when beautifying)
644 that made the parsing of 8BitsRunLengthColor.dcm unproper.
645 Note: ctest was blind to this bug (this means we need to still
646 improve the test suite). The bug could be detected by using
647 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
649 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
650 and by displaying the (garbage) produced file temp.XDCM...
652 2004-06-29 Jean-Pierre Roux
653 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
654 - replace by uggly but working old code :-(
655 A lot of things should be OK again.
656 It's really urgent to have a test suite that *tests*,
657 to prevent Frog's beautifying sessions to break all the stuff
658 (twice, withing a fortnigh ...)
660 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
661 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
662 redundancy) to added Test/TestReadWriteReadCompare.cxx
663 * Test/CmakeList.txt: because the compare test of
664 Test/TestReadWriteReadCompare.cxx fails, the following images are
665 black listed: - 8BitsUncompressedColor.dcm
667 - US-PAL-8-10x-echo.dcm
668 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
669 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
670 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
671 and ad-hoc kludge. This kludge is now removed, and on encountering
672 such an image (OB field brain damaged) we set errno. Then in
673 ::FindDocLength() we "fix" the length as being ALL what remains
674 in the file (until EOF). We then proceed, hoping for the best...
675 This fixes a SegFault in ShowDicom when trying to write such an
677 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
678 (because TestWriteRead breaks on it, after a non conformal commit?).
679 ctest now runs properly, except for MakeDicomDir (which was allways
680 broken) and the Python related stuff (still not fixed).
682 2004-06-24 Jean-Pierre Roux
683 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
684 FIX : Test/TestReadWrite now iterates on all the file names
685 (instead of infinite loop)
686 ENH : Test/TestWriteRead now iterates on all the file names
688 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
689 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
691 2004-06-24 Jean-Pierre Roux
692 FIX : - now Write drops LUT Descriptors and LUTs (if any)
693 when SamplesPerPixel =3
694 - now Write is no longer confused by
695 'BitsAllocated = 12" and 'BitsStored=12"
696 - "UN" value representation Elements are now written correctly
697 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
698 ENH : - now gdcmHeader has its own Write methods
699 (in order to split the job that has not to be done
702 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
703 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
704 loop on the same image until memory went out.
705 Note: this means we still have gobs of memory loss in PrintDocument
706 * src/gdcmDocument.cxx: fixes problem on parsing on file
707 gdcmData/16BitsJpegLosslessGrayScale.dcm.
709 2004-06-24 Jean-Pierre Roux
710 FIX : Write - All the Sequences and Sequence Item are now written
711 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
712 is added a the end, when necessary.
713 - A lot of brain-damaged images, that were read correctly are
714 now written correctly
715 - length compatible BinEntry are now loaded correctly
716 (even for odd groups)
717 Note : only Explicit Value Representation was checked.
718 (question : is implicit VR really necessary for gdcm ?)
720 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
721 * DEVELOPPER: added a proposition of coding style.
722 * src/gdcmDocEntry.h: removed every inline declaration (for test of
725 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
726 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
727 Use the gdcmDocEntry::Print() and Write() instead.
728 * src/gdcmDocument.cxx: bug fix.
730 2004-06-22 Jean-Pierre Roux
731 FIX : gdcmDocument.cxx
732 - Now we do recognize the JpegLossLess format (there was a misstyping in
733 code 'beautyfication' :-(
734 - Now we automaticaticaly load the Luts, if any
736 2004-06-22 Jean-Pierre Roux
737 In order : to write Sequences, whatever their imbrication level,
738 : to allow user to create his own Sequences
739 a lot of modif where necessary (adding, moving, or virtualising methods)
741 WARNING : save your own sources *before* cvs up !
744 ADD virtual void Write(FILE *fp, FileType filetype);
747 ADD virtual void Write(FILE *fp, FileType filetype);
748 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
751 ADD virtual void Write (FILE *fp, FileType filetype)=0;
752 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
753 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
754 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
755 ADD std::string GetEntryByName(TagName name);
756 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
758 std::string vr = "unkn",
759 std::string fourth = "unkn",
760 std::string name = "unkn");
761 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
762 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
763 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
764 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
765 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
766 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
767 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
768 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
771 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
772 ADD virtual std::string GetEntryByName (TagName tagName);
773 ADD virtual std::string GetEntryVRByName (TagName tagName);
774 REM virtual bool Write(FILE *, FileType);
775 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
776 FILE *_fp, FileType type);
777 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
778 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
779 REM virtual bool WriteEntries(FILE *_fp,FileType type);
780 REM virtual std::string GetEntryByName (std::string tagName);
781 REM virtual std::string GetEntryVRByName (std::string tagName);
782 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
783 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
784 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
786 std::string vr = "unkn",
787 std::string fourth = "unkn",
788 std::string name = "unkn");
789 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
790 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
791 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
792 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
795 ADD virtual void Write(FILE *fp, FileType filetype);
798 ADD virtual void Write(FILE *fp,FileType filetype);
801 ADD virtual void Write(FILE *fp, FileType filetype);
802 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
803 REM std::string GetEntryByNumber(guint16 group, guint16 element);
804 REM std::string GetEntryByName(TagName name);
807 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
809 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
810 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
811 The default constructor invoked by the line
812 gdcmHeader *f1 = new gdcmHeader( header );
813 was gdcmHeader::gdcmHeader(bool) instead of the expected
814 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
815 Hence the parsing wasn't executed... See also below.
816 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
817 as explicit constructor didn't do the trick to fix the above problem.
818 Could anyone explain why ?
819 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
820 properly calls gdcmValEntry::Print() (that was weed out from
821 code related to gdcmBinEntry).
823 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
824 * In order to fix memory leaks:
825 - Test/TestWriteSimple.cxx: added cleaning of free store through
827 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
828 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
829 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
830 (through the call to ::AddDicomDirMeta()) or the destructor
831 would crash when deleting uninitialized ::metaElems].
832 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
833 - src/gdcmDocument.cxx:
834 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
836 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
837 was causing memory leaks.
838 - src/gdcmSQItem.cxx:
839 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
840 cleanly handled with polymophism: sorry but my milage is low).
841 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
842 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
843 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
844 This avoids SegFaulting.
845 - src/gdcmSQItem.h: coding style.
847 - Test/TestWriteSimple still severely sucks. The output image content
848 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
849 damaged when displayed with vtkgdcmViewer.
850 - on memory leaks: TestWriteSimple leaks really less (see entry
851 of 2004-06-18 in Changelog file for the call to valgrind).
852 - on segfaults: ctest now passes all the tests but one (no more
854 * Erroneous leading white fix:
855 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
856 white[s] (as opposed to from >> xxx, that removes it [them].
857 - src/gdcmTS.cxx: ditto.
858 - gdcmPython/testSuite.py: dirty related kludge removed.
859 * src/*: remaining references to gdcmParser removed.
860 * src/*[cxx|h]: added copy[way]left header.
863 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
864 * In order to fix writing of dicom files:
865 - Test/TestWriteSimple.cxx: a simpler example of writing.
866 - Test/CMakeLists.txt changed accordingly.
867 - src/gdcmDocument.cxx:
868 -- The destructor now recursilvely removes potential sequences.
869 -- Bug fix in ::IsJPEG2000()
870 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
871 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
873 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
874 to only declared) and build on top of
875 ::GetDocEntryByNumber(guint16, guint16).
876 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
877 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
878 for usage in destructor and treatement of promotion in
879 ::ReplaceOrCreateByNumber().
880 - src/gdcmSQItem.cxx: destructor should better handle his job.
881 Test/TestWriteSimple now runs (or at least it DOES something).
882 * We can now start hutting memory links. A good starting point is:
883 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
884 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
885 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
887 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
888 * Valgrind note: after Mathieu Malaterre teached me how to read
889 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
891 Using gcc, you can force the STL to use malloc and to free memory as
892 soon as possible by globally disabling memory caching.
893 With 3.2.2 and later, you should export the environment variable
894 GLIBCPP_FORCE_NEW before running your program.
895 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
896 simply vanish (it is still not clear to me, whether this means that
897 STL std::string leaks or if valgrind believes it leaks...).
898 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
899 running bin/gdcmTests makeDicomDir):
900 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
901 - Test/makeDicomDir.cxx now properly traps empty lists and returns
903 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
904 SegFaulting (I drowned in DicomDir related code when trying to
905 understand why the list is empty...).
906 * src/gdcmDocument.h: first BSD license header try.
907 * Doc/License.txt added.
909 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
910 * src/gdcmDocument.[h|cxx]:
911 - Clean up of the Transfer related predicates. They are now all based
912 on new method isGivenTransferSyntax, that (should) handle properly
914 - general clean up, simplification, and coding style.
915 - Specific clean up of Parse7FE0() (umproperly named actually).
916 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
918 2004-06-14 Jean-Pierre Roux
920 - fix the display of Sequence Delimitor (SQDepthLevel pb)
921 - fix the display of SQItem ordinal number
922 - add the GetSQItemByOrdinalNumber method
923 - remove some useless never written private methods
925 2004-06-14 Jean-Pierre Roux
927 - adding a constructor taking a gdcmDocEntry as an input param
928 - ReplaceOrCreateByNumber now returns :
929 a gdcmBinEntry * if a Binary (void *) value is passed as a param
930 a gdcmValEntry * if a string value is passed as a param
932 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
933 according to the param type (no longer sets a gdcmDocEntry)
934 - GetValEntryByNumber, GetBinEntryByNumber added
935 - NewValEntryByNumber and NewBinEntryByNumber added
937 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
939 - GetSQItemNumber and SetSQItemNumber added, to provide
940 a (relative) Item identier inside a given Sequence
941 \warning : some pb remaining around this number
943 - AddEntry now takes the Item Number as a param
945 - adding a constructor taking a gdcmDocEntry as an input param
947 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
948 * Memory leak hunt with the following command:
949 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
950 --show-reachable=yes gdcmTests PrintDocument
951 It looks like many (all?) leaks are due to the STL (or a bad usage
952 of the STL. The lines producing the leaks now have a comment with
953 a "MEMORY LEAK" tag: you can retrieve them with
954 grep "MEMORY LEAK" src/*
955 Here are two typical examples which I can't help fixing:
960 char * test = "babo";
961 name = test; //// <--- valgrind detects 960 bytes lost in
962 //// call to std::string::operator=(char const*)
963 name.clear(); //// Doesn't help !
971 std::cout << "Type a bunch of characters followed by RETURN: ";
972 getline(std::cin, line); //// <--- valgrind dectects a loss
973 //// of 1320 bytes in call to
974 /// std::basic_istream<>& std::getline<>
980 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
981 * src/gdcmHeader.[cxx|h]:
982 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
983 and related, moved away to gdcmDocument.
984 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
985 the corresponding protected accessors of inherited class
986 gdcmDocument, removed ! As a consequence gdcmFile had to be
987 declared friend of class gdcmDocument (see below).
988 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
989 - Clean up of undefined or unused methods.
990 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
991 account the changes to gdcmHeader.h).
992 * src/gdcmDocument.h:
993 - gdcmFile is now a friend class (in order to take into account the
994 changes to gdcmHeader.h).
995 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
996 (see changes to gdcmHeader.h).
997 - Accessors (reading on the form GetEntry*) are now public.
998 - Clean up of undefined or unused methods.
999 * src/gdcmDocument.cxx:
1000 - adaptation to changes to gdcmDocument.h
1001 - ::OpenFile now writes a verbose message when file cannot be opened.
1002 - some std::string properly set to VRKey
1003 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1004 references to gdcmDocument.
1005 * Test/TestFindTags.cxx: changed accordingly to above changes.
1006 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1007 cvs repository gdcmData.
1009 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1010 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1011 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1012 conflicts with gdcmValEntry::voidArea.
1013 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1014 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1015 Value representation between StringRepresentable and BinaryRepresentable.
1016 * src/gdcmDocument.cxx:
1017 - method ParseDES: proper indentation restored and usage of
1018 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1019 - method LoadDocEntry: the fingerprint left in the SetValue() of
1020 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1021 removed. Reverting to previous code segment with the proper
1022 dynamic_cast< gdcmValEntry* >.
1023 Note: this was (partially) breaking the python test suite
1024 (gdcmPython/testSuite.py) that made usage of the above
1025 fingerprint to check presence of "Pixel Data".
1026 * src/gdcmDocEntry.h: coding style.
1027 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1028 now taken into account.
1029 * gdcmPython/gdcm.i: adaptation to the new internal representation
1030 of gdcm (exit gdcmParser, hello gdcmDocument).
1031 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1033 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1034 anymore, but instead prints the loaded Python dictionary.
1035 * .... alas, the python testSuite is still broken.
1037 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1038 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1040 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1041 * src/gdcmUtil.h : export methods
1043 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1044 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1046 * Initial addition of automatic python testing
1047 * Initial addition of automatic image comparison
1049 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1050 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1051 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1053 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1054 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1055 * Test/ShowDicom.cxx : bug fix for msvc compilation
1056 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1058 2004-05-04 Jean-Pierre Roux
1059 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1060 new concepts (and new classes) :
1061 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1062 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1063 - Sequence Doc Entries (gdcmSeqEntries)
1064 a Sequence is composed of Items.
1065 Each item is a set of Doc Entries (this is recursive)
1066 The non uniqueness of the 'Dicom tag' is due to this recursivity
1067 (never taken into account)
1068 Our unability to add a new 'entry' in the header
1069 at the proper location (neither in the H-Table (map or multimap),
1070 nor in the Chained List is also due to this recursivity.
1071 Don't try, right now, to use/modify/compile these new sources :
1072 nothing is finished.
1073 We just commit all the stuff, 'as is', in order not to loose it.
1075 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1076 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1078 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1079 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1080 file prefix (SetFilePrefix)
1082 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1083 * Add a new test: ShowDicom, for now this is just the c++ version of
1084 checkRead.sh, later it will be able to compare the image read against a
1086 * Replace the DEBUG on the stack with a global entry in cmake interface:
1087 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1089 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1090 * Add an example subdir, with a real example on how to read + write a
1093 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1094 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1095 * Doc/CMakeLists.txt: the main page is now properly differentiated
1096 between the developper and user version.
1097 * Doc/doxygen.config.in: dropped search related obsolete flags
1098 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1100 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1101 * DEVELOPPER: added some helpfull comments for compile/test/install
1104 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1105 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1106 src directory, now generated in the build dir.
1107 2. Tests as mentionned smarter
1109 4. Add a new method in gdcmDict that return the PubDict by name
1110 this is interesting for 3rd party lib like ITK,
1111 where we could set the institution name / patient name...
1113 * ENH: 1. Now the test suite is working for real
1114 2. All binaries are now output in the gdcm-bin directory
1115 (this was not true before)
1117 2004-04-28 Jean-Pierre Roux
1118 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1119 SeQuence indented printing of Dicom Header.
1120 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1121 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1122 Computation of SQDepthLevel is now part of gdcmHeader constructor
1123 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1124 tree-like structure of a Dicom Header.
1125 * FIX Test code cleaning
1127 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1128 * ENH: Adding automatic testing
1129 1. Need a DartConfig.cmake to submit to public
1130 2. Add a test driver gdcmTest.cxx
1131 3. gdcmTestMain, an helper for the main test driver gdcmTest
1132 4. Files in Test don't have a main anymore, this becomes interesting
1133 when we add more and more tests, thus dsw don't have to load
1135 * ENH: Adding a GDCM_DATA_ROOT for testing
1136 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1137 one file instead of seven + some small cleanup
1139 2004-04-22 Jean-Pierre Roux
1140 * ENH Minor changes to the Print() methods.
1141 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1142 Header printing. Example given with :
1143 > PrintHeader fileName 2 new
1144 (SQ based tree-like structure still to be done for the Header ...)
1146 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1147 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1148 1. I have added some unsigned where needed
1149 2. Some function parameter not used -> (void)
1150 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1151 4. g++ don't like character '\' in comment
1152 5. #define jpeg_create_decompress jCreaDecompress
1153 this really need to be fixed
1154 6. virtualize destructor of gdcmObject ... leakage
1155 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1156 this also really need to be fixed
1157 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1158 remove compression file
1159 (as we only do decompression, right ?)
1160 * ENH: Change malloc/calloc/free with c++ equivalent
1162 2004-04-21 Jean-Pierre Roux
1163 * FIX gdcmHeaderHelper::GetXSpacing
1164 when a single value is found (bug ?), xpacing is now
1165 defaulted to yspacing
1167 2004-04-19 Jean-Pierre Roux
1168 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1169 * ENH add parameters :
1170 bool exception_on_error = false,
1171 bool enable_sequences = false,
1172 bool ignore_shadow = false
1173 to the gdcmFile constructors to be full gdcmParser compliant
1174 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1175 to allow reading of PAPYRUS 3.0 files
1177 2004-04-06 Jean-Pierre Roux
1178 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1180 2004-04-02 Jean-Pierre Roux
1181 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1182 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1183 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1185 2004-03-30 Jean-Pierre Roux
1186 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1187 for ACR file, written out as DICOM files (hope so...)
1189 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1190 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1191 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1192 moved to base class gdcmParser and only the specialisation is kept
1194 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1195 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1196 already does the job.
1197 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1198 (to be consistent with gdcmParser::WriteEntries).
1200 2004-03-30 Benoit Regrain
1201 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1202 upate of the object's instance. It's passed to 2 in the unfavorable
1203 case : one in the ExecuteInformation, one in the ExecuteData
1205 2004-03-29 Jean-Pierre Roux
1206 * ENH : Check on file type to be written moved
1207 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1208 * FIX : gdcmObject::ResetBoundaries now stops properly
1209 when end-of-list is reached
1210 : gdcmVersion modified (as Benoit Regrain asked)
1212 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1213 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1214 * src/gdcmUtil.cxx: added forgotten iostream include.
1215 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1216 equivalent to ExplicitVR in existing code).
1218 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1219 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1220 now contains all the gdcmGlobal related code.
1221 * minor coding style and doxygenation changes.
1223 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1224 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1225 now contains all the Debug related code.
1226 * minor clean-up of includes in src/*.cxx
1227 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1228 CreateCleanString) removed.
1229 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1230 * Doc/DoxyMainPageUser.txt added.
1231 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1232 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1233 src/gdcmDirList.cxx)
1235 2004-03-24 Jean-Pierre Roux
1236 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1238 2004-03-23 Jean-Pierre Roux
1239 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1240 big endian made volumes
1241 * ENH Now gdcmParser constructor and destructor are protected to forbid
1242 end user to instanciate class gdcmParser
1243 (only gdcmHeader and gdcmDicomDir are meaningfull)
1245 2004-03-22 Benoit Regrain
1246 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1247 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1248 gdcmSerie to gdcmDicomDirSerie
1250 2004-03-19 Jean-Pierre Roux
1251 * ENH Now the tree-like structure describing a DICOMDIR comming from
1252 an already existing DICOMDIR file is consistent with
1253 the home-made tree-like structure build ex-nihilo
1254 or build from the files held (recursively) in a Directory
1255 functions gdcmDicomDir::CheckBoundaries()
1256 gdcmObject::SetBoundaries() added
1258 2004-03-17 Jean-Pierre Roux
1259 * REM (Eric Boix bug) : removal of meaningless
1260 gdcmDicomDirImage::NewImage function.
1261 * FIX now file names and directory name are written properly in the
1263 * FIX now gdcmDicomDir constructor may be call without any trick
1266 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1267 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1268 of gdcmDicomDirImage::NewImage as empty function.
1270 2004-02-28 Jean-Pierre Roux
1271 * ENH add gdcmDicomDir:NewPatient
1272 add gdcmDicomDirPatient:NewStudy
1273 add gdcmDicomDirStudy:NewSerie
1274 add gdcmDicomDirSerie:NewImage
1275 to allow making gdcDicomDir object.
1276 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1277 (as opposite to the gdcmHeader chained list)
1279 2004-02-11 Benoit Regrain
1280 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1281 when using from python
1283 2004-02-10 Benoit Regrain
1284 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1285 * FIX : in gdcmDicomDir when the directory is empty
1286 * ENH : add callback and methods to get the progression of dicomDir
1289 2004-02-06 Jean-Pierre Roux
1290 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1291 - GDCM_META added to gdcmDicomDirType
1292 - class gdcmMeta created
1293 * ENH : - A brief summary is now displayed at the beginning of
1294 'testDicomDir' to help disaster magnitude estimation
1295 * REM : Now useless Test/explDICOMDIR.cxx
1297 2004-02-05 Benoit Regrain
1298 * ENH : add methods in gdcmObject to get the hash table or the list of
1300 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1301 * FIX : wrapping python for TagHeaderEntryHT
1303 2004-02-04 Benoit Regrain
1304 * FIX : even length for some strings when writting the dicom dir
1305 * FIX : sort the images in the dicom dir
1306 * FIX : Bug fix for python use of dicom dir
1307 * ADD : a python demo
1309 2004-02-04 Jean-Pierre Roux
1310 * FIX : Final solution (?) for icone embedded images
1311 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1312 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1313 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1314 gdcmData/gdcm-MR-SIEMENS-16.acr1
1315 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1316 to make full checking easier
1318 2004-02-04 Benoit Regrain
1319 * FIX : WriteEntries : coding style & logic in parameters
1320 * FIX : Set the elements to create the DicomDir in a dictionary file
1322 2004-02-03 Benoit Regrain
1323 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1324 * gdcmDicomDir : add the load of directory
1325 * Bug fix and print add-on
1327 2004-02-03 Jean-Pierre Roux
1328 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1329 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1330 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1331 * FIX gdcmParser.cxx : 'group length' elements are now considered
1332 as integers, even for shadow groups, when file is Implicit VR
1334 2004-02-02 Jean-Pierre Roux
1335 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1337 of the last synonym :-(
1338 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1340 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1341 * FIX taking into account the possible 7fe0,0010 multiplicity
1342 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1343 to allow removal of references to 7fe0,0010, to deal with
1344 ACR-NEMA images, when 0028,0200 is meaningfull
1346 2004-01-31 Jean-Pierre Roux
1347 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1348 no longer writes 'Un' on disk
1349 * FIX SQ elements with actual length are now dealt with corectly
1350 * FIX gdcmFile::WriteBase make the difference, for color images, between
1351 the length (for Palette expanded images)
1352 and Raw Length (non expanded image + Palette)
1353 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1354 (that broke Write). Replaced by UL.
1355 Aware user will reload the field if he
1356 thinks it's necesssary
1358 2004-01-30 Jean-Pierre Roux
1359 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1360 when 'dirty Acr' is found, to be compliant with the new
1361 IsReadable() methods.
1363 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1364 (no DOUBLE images in kosher DICOM,
1365 but so usefull for people that miss them ;-)
1367 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1368 DICOMDIR related utilities (not checked as Windoze compliant)
1370 2004-01-28 Jean-Pierre Roux
1371 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1373 2004-01-27 Jean-Pierre Roux
1374 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1375 to allow skipping the shadow elements, to save memory space.
1376 The TRUE value for this param has to be used
1377 with a FALSE value for the 'enable_sequence' param.
1378 ('public elements' may be embedded in 'shadow Sequences')
1379 * gdcmHeader methods now deal with 'embedded icones images' in the header
1380 (even when an 'icone image sequence' is announced by the
1381 element (0x0088,0x0200), but there is NO icone at all ...
1383 * gdcmHeader sometimes Image Location value doesn't follow
1384 the supposed processor endianity (see gdcmData/cr172241.dcm).
1387 * gdcmHeader add the method
1388 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1389 to get *all* the Header Entries with the same tag.
1390 GetHeaderEntrySameName is probabely *useless*
1391 (no meaning : Name is *not* an identifier within the Dictionnary)
1393 2004-01-26 Benoit Regrain
1394 * Bug fix in the print of hexadecimal representations. Remove long fields
1395 in the print and add a third level of print to print them
1397 2004-01-23 Benoit Regrain
1398 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1399 * Bug fix on test suite after remove the strip made on not string fields
1400 * Split the IsReadable method between gdcmParser which test that the file
1401 is dicom and gdcmHeader which test that it's an image file
1403 2004-01-22 Benoit Regrain
1404 * DicomDir : clean code, add methods, set variables in protected or private
1405 * gdcmUtil : bug fix for the clean string method
1407 2004-01-19 Benoit Regrain
1408 * Add the use of shadow dictionaries
1409 * bug fix and coding style
1411 2004-01-19 Benoit Regrain
1412 * src/gdcmFile.cxx : bug fix concerning the close of file
1413 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1414 * Add the update of header entries using the shadow library
1416 2004-01-19 Benoit Regrain
1417 * removal of file gdcmHeader2.cxx
1418 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1419 inheriting from gdcmParser. This split is to prepare the integration
1420 of dicom dir parsing
1421 * bug fix under python
1423 2004-01-16 Jean-Pierre Roux
1424 * REM removal of class gdcmHeaderEntrySet
1425 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1426 * ADD add file gdcmHeader2.cxx
1427 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1429 2004-01-15 Benoit Regrain
1430 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1431 entries created while parsing the header. Thus, they will be destroyed
1432 when the gdcmDictSet will be destroyed
1433 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1436 2004-01-15 Benoit Regrain
1437 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1438 made a fatal error because of the memory release at the end of program.
1439 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1440 some memory and vtk seems to have some problems with that.
1441 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1443 2004-01-14 Benoit Regrain
1444 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1445 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1446 * src/*.[h|cxx] : make changes due to class name changes
1447 * gdcmPython/demo/*.py : bug fix due to method names
1449 2004-01-13 Benoit Regrain
1450 * src/*.[h|cxx] : coding style
1451 * vtk/*.[h|cxx] : coding style
1453 2004-01-13 Benoit Regrain
1454 * gdcmPython/testSuite.py : test the readable flag of file for tests
1455 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1456 It's lied to the stl compilation by MSVC (windows, always windows...)
1457 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1459 2004-01-12 Benoit Regrain
1460 * src/*.h : add comments
1461 * src/gdcmDictSet.h : set the method BuildDictPath in public
1462 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1463 directly setted in the source code
1464 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1467 2004-01-09 Benoit Regrain
1468 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1469 * setup.py : use a reference to gdcmVERSION
1471 2004-01-07 Benoit Regrain
1472 * Modification to compile with the distutils.
1475 2003-12-10 Benoit Regrain
1476 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1477 can use a gdcmHeaderHelper to load datas
1478 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1479 made in the source code
1481 2003-12-10 Benoit Regrain
1482 * Update Windows projects and .cvsignore files
1484 2003-11-12 Jean-Pierre Roux
1485 * ENH gdcmHeader constructor has one more parameter (default value : false)
1486 that allows the user to 'go inside' the SeQuences only
1488 gdcmElValSet:Print takes it into account
1490 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1491 * ENH: Update gdcmPython/CMakeLists
1492 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1493 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1495 2003-11-10 Jean-Pierre Roux
1496 * FIX : gdcmHeader::LoadElements is now based
1497 on the ListTag listElem member,
1498 not longer on the TagElValueHT tagHt member
1499 * ENH : PrintPubElVal shows (temporarily) both results,
1500 with the tagHt member and the listElem member.
1501 (it's easier to 'see' the problems when using Printheader)
1503 * FIX : old private member LgrElem is now splitted into
1504 ReadLength : Length actually found on disk (updated only
1505 if bug fixing is necessary), for internal
1507 UsableLength : Updated by FixFoundLength, to fix a bug
1508 or to allow Parser going on.
1509 Will allow to re-write a kosher header when a SeQuence
1510 with a length (not 0000) is found
1511 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1512 because gdcmElValSet::Add does not update ListElem
1515 2003-11-07 Jean-Pierre Roux
1516 * FIX misstyping in Transfert Syntax name table
1517 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1518 when they have an actual length (not 0000 nor FFFFF)
1519 (Nobody should care of it, but DICOMDIR explorers)
1521 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1522 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1524 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1525 * ENH: vtkGdcmReader now supports LUT !
1526 (vtkgdcmViewer for now is not able to use them though)
1528 2003-11-05 Jean-Pierre Roux
1529 * in testSuite.py : new files names for checking the package
1530 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1531 that returns the pixel area size to the *aware* (vtk) user
1532 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1534 2003-11-05 Benoit Regrain
1535 * in testSuite.py : Modify the rules for checking the paths
1536 : Explicit error messages
1537 * in __init__.py : Related modif
1539 2003-11-03 Jean-Pierre Roux
1540 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1541 to be used by aware (vtk) users that want to manage
1542 LUT (and no to turn the PALETTE image into an RGB pixels one)
1543 * GetPixelType now returns 8U for 24 Bits images
1544 (vtkGdcmReader compliant)
1546 2003-10-31 Jean-Pierre Roux
1547 * Removal of *all* gdcmData images and add them again
1548 in order to loose the 'history' of un-anonymised images
1550 2003-10-31 Jean-Pierre Roux
1551 * RMV : removal of useless jBitsInJsample.h
1552 for both 8 and 12 Bits JPEG Lossy Libraries
1554 2003-10-31 Jean-Pierre Roux
1555 * ENH : Add the functions gdcmFile::GetImageDataRaw
1556 gdcmFile::GetImageDataIntoVectorRaw
1557 that act as GetImageData and GetImageDataIntoVector
1558 except the making of an RGB Plane from Gray Plane + LUT
1559 Intended to aware (vtk) users who know how to manage
1562 GetLUTRGBA return a R,G,B,A LUT if any
1563 lgrTotaleRaw gives the 'Raw' length
1564 GetImageDataRaw returns the gray Plane
1565 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1566 (They stay Grey, just like with other Dicom viewers :-(
1568 2003-10-30 Jean-Pierre Roux
1569 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1571 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1572 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1573 being coherents dicom files.
1575 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1576 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1578 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1579 * ENH: Two steps is necessary to please VC++ compiler...
1580 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1581 * ENH: Add include dir to medcon lib
1582 * FIX: only one function is being exported for now !
1583 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1585 2003-10-29 Jean-Pierre Roux
1586 * adding gdcmHeader::GetLUTRGBA
1587 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1588 --> Mathieu, the modif u're waiting for is not yet committed
1589 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1591 2003-10-27 Jean-Pierre Roux
1592 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1593 00191113.dcm DermaColorLossLess.dcm
1594 MxTwinLossLess.dcm RadBWLossLess.dcm
1595 * ENH: For version prior to vtkImageViewer2 -r 1.19
1596 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1598 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1599 * Removal of ido stuff in CMakeLists.txt
1601 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1602 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1603 * FIX: remove a call to ->Modified ... see comments
1604 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1606 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1607 * FIX: Problem with path for libvtkgdcmPython
1608 * ENH: Try adding a search script for python site-package
1609 * RMV: Remove some file from medcon lib that are not necessary
1610 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1611 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1612 * FIX: More pragma disable fro VC++,
1613 I don't think I break something as it is also disable in VTK/ITK.
1614 But it fasten debug compilation time.
1616 2003-10-23 Jean-Pierre Roux
1617 * gdcm now deals with 16 Bits Run Length Encoded images
1618 (they are compressed as 2 planes images,
1619 one for the high Bytes, the other for low Bytes)
1621 2003-10-22 Jean-Pierre Roux
1622 * Now CheckRead takes into account :
1623 - the bugged 'Leonardo' Siemens images
1624 - the XA images, sent thru the burning VPRO station
1625 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1628 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1629 * FIX: When copying a Makefile.am to CMakeLists.txt
1630 one should remove the '\'
1632 2003-10-22 Jean-Pierre Roux
1633 * in gdcmData adding a bugged 'Leonardo' Siemens image
1634 (wrong lengths in header)
1635 OK with gdcm, KO with the other viewers :-)
1636 * add a GE dlx XA image, thru the VEPRO burning station
1639 2003-10-21 Jean-Pierre Roux
1640 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1641 for a brutal checking of vtkgdcmViewer compliance
1643 2003-10-21 Jean-Pierre Roux
1644 * add the files for 'xmedcon' Jpeg Lossless library
1645 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1647 2003-10-21 Jean-Pierre Roux
1648 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1650 2003-10-21 Jean-Pierre Roux
1651 * garbage Siemens 'Leonardo' images dealt with
1652 (the patch is easy to remove)
1653 * cosmetic changes to avoid warnings
1655 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1656 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1657 no need to press 'r' now.
1659 2003-10-20 Jean-Pierre Roux
1660 * upgrade of checkRead.sh checkWrite.sh according
1661 to new Jpeg Lossless decompressor
1662 * add US.3405.1.dcm, a genuine RGB medical file ...
1663 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1664 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1666 2003-10-15 Jean-Pierre Roux
1667 * general anonymisation in gdcmData
1668 * adding the 'color files' from
1669 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1670 * adding some well knowed bugged-header images
1671 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1672 waiting for their inclusion in Python testsuite
1674 2003-10-15 Jean-Pierre Roux
1675 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1676 no longer seg faults when file is not found
1678 2003-10-14 Jean-Pierre Roux
1679 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1682 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1683 * TODO: *.in file to genereate a UseGDCM later
1685 2003-10-14 Jean-Pierre Roux
1686 * Some supposed-to-be Dicom Images have no preamble.
1687 OpenFile takes it into account
1688 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1689 * Missing elements added in dicomV3.dic
1690 (just to be affraid : have a look at
1691 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1692 and do it again next year ;->
1694 2003-10-13 Jean-Pierre Roux
1695 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1696 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1697 But there are NOT. It's fixed !
1699 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1700 * FIX: "jpeglib.h" was not found on VC++
1701 * FIX: vtkgdcm was not being installed
1703 2003-10-10 Jean-Pierre Roux
1704 * ENH : OpenFile closes the file if it *really* doesn't look like
1705 an ACR-NEMA / DICOM one.
1706 * FIX : testWrite no longer writes an empty file if the source file
1707 is not gdcm Readable
1708 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1711 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1712 * FIX: CMake generate now documentation
1713 * ENH: out of source doc build !
1714 * ENH: Generate both user and dev documentation
1715 * ENH: Should work on windows too
1716 * ENH: Only one doxygen config.in file is needed
1717 * FIX: make install should be ok now on ùnix plateform
1718 * FIX: PATH to dictionary was wrong (missing /)
1719 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1721 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1722 * vtkGdcmReader is now able to read rgb dicom file.
1723 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1724 * added a gdcmViewer to vtk test, use mouse to control
1725 window level & window width
1727 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1728 * CMake-ification of gdcm, we have now two build system
1729 * FIX: on cygwin Wsock32 doesn't exist
1730 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1732 2003-10-06 Emanuel Ollart
1733 * FIX : compilation process wad broken.
1734 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1736 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1737 * change gdcmViewer -> vtkgdcmViewer
1738 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1740 2003-10-06 Jean-Pierre Roux
1741 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1742 ( e.g : well known GE images with a wrong elem length,
1743 : Philips MRI Images with a wrong Huffman table)
1744 * still to be done : allow the reading of bugged LEONARDO Siemens images
1746 2003-10-03 Jean-Pierre Roux
1747 * Odd length strings are padded with '\0' (not with spaces,
1748 to remain compliant with already defined strings,
1749 like Transfert Syntax UID and others)
1751 2003-10-03 Jean-Pierre Roux
1752 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1753 to allow displaying RGB images (not only by affim ;-)
1755 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1756 * vtkGdcmReader is now able to read rgb dicom file.
1757 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1759 2003-10-03 Jean-Pierre Roux
1760 * A few nasty patches to allow the reading of a lot of nasty images
1761 ( e.g : well known GE images with a wrong elem length,
1762 : Philips MRI Images with a wrong Huffman table)
1763 * still to be done : allow the reading of bugged LEONARDO Siemens images
1765 2003-10-03 Jean-Pierre Roux
1766 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1768 2003-10-03 Jean-Pierre Roux
1769 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1770 to allow displaying RGB images (not only by affim ;-)
1772 2003-10-03 Jean-Pierre Roux
1773 * gdcmFile::GetImageDataIntoVector now
1774 - deals with MultiFrames MultiFragments Run Length Encoded files
1775 - deals with YcBcR (YBR_FULL) files
1776 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1777 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1779 (no sample found :-(
1781 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1782 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1783 Two reasons: - clear things
1784 - third parties acces gdcm through header files, so won't
1785 suffer anymore VC++ complains
1787 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1788 * add argv[1] in testvtkGdcmReader.cxx
1791 2003-09-24 Jean-Pierre Roux
1792 * The lines are now eigthy characters long.for
1793 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1795 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1796 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1797 char* to std::string. Thus, the use of strdup becomes useless. (see
1798 previous commis of Malaterre)
1799 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1800 before the last Malaterre's commit.
1802 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1803 * This commit should fix the Debug building under VC++, the problem
1804 was mainly a mixture of debug and release lib being loaded at startup.
1805 * I also remove a depency to a specific C function: strdup. Because I had
1806 to force the link to msvcrtd (whereas strdup is in libc).
1808 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1809 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1810 located in the gdcmCommon.h file. All use of reference of tha has been
1811 changed to now use the variable GDCM_UNFOUND.
1813 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1815 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1816 Dicom dictionary. The test suite can now be run again. Note:
1817 I'm note very happy with the " (RET)" changes. I believe this
1818 RETAINED comment should be dropped when parsing the dictionary.
1819 - PACKAGER corrected
1821 - AUTHORS updated and now in alphabetical order
1822 * Makefile.am now exports gdcm.dsw for Windoze users.
1824 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1825 * cygwin complains about missing std:: in subdir Test/
1827 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1828 * remove some methods that are now in gdcmHeaderHelper
1830 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1831 * vtkGdcmReader set spacing and origin correctly
1833 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1834 * Fix a few delete/delete[] mismatch
1836 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1837 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1838 interpretation to data given by gdcmHeader. For instance there are
1839 heuristics to get informations (look at different places).
1840 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1841 sorting DICOM images based on different strategies.
1842 * modified Makefiles accordingly.
1844 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1845 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1846 when building in debug mode
1847 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1848 src/win32/gdcmdll.dsp
1849 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1851 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1852 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1855 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1856 * src/win32/libgdcmjpeg12.dsp was not dos format
1857 * src/win32/libgdcmjpeg12.dsp :
1858 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1859 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1861 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1862 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1864 * src/gdcmFile.cxx : bug fix in affectation type
1865 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1866 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1867 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1868 symbols... future problem ?
1870 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1871 * src/win32/libgdcmijpeg12.dsp was missing
1872 * modified gdcm.dsw accordingly
1874 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1875 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1877 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1878 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1879 commit of JPR (before his hollidays to facilitate our work).
1880 * setup.py : bug fix in code. Modifications made while the last commit
1881 of JPR. The code hasn't been tested before the commit... it's so
1882 useless to make that (for best programmer that is JPR) !!!
1884 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1885 * tagged the current version as Version0_3 (i.e. version 0.3)
1887 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1888 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1889 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1890 * *.dsp : modifications to use new libgdcmijpeg8 library
1891 * setup.py : bug fix on VTKPATH variable
1892 * PACKAGER : adding all concerning windows
1894 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1895 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1897 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1898 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1899 test suite reported error.
1900 * PACKAGER file added (describes what a packager must do when
1901 packaging a new release).
1902 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1903 * configure.in: upgraded version number to 0.3.0
1904 * fixing build of rpm (through rpm -ta):
1905 - Doc/Makefile.am exports proper doxygen files
1906 - src/jpeg/libijg8/Makefile.am exports the include files.
1908 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1909 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1910 * src/gdcmHeader.h : formatting code
1912 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1913 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1914 We were obtaining error message from vtk. Now, creation of file list
1915 is made in an internal list to prevent this problem.
1916 Bug fix when output is empty.
1917 Bug fix in update of progress value. Previous commit for this was a bad
1919 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1921 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1922 * src/gdcmHeader.h : added method to get the file name
1923 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1924 files. Added method to remove all files on the input
1925 Added FIXME comment concerning the bad parsing of header made by
1926 ExecuteInformation method (in ExecuteData method)
1928 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1929 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1930 when using make instal.
1931 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1932 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1934 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1935 * setup.py : adding include dir of jpeg lib to compile all sources
1936 * */Win32/*.dsp : JPR fix for windows compilation
1938 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1939 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1941 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1942 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1944 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1945 * setup.py is again effective on un*x (takes into account the
1946 addon of the jpeg library)
1947 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1948 * Doc/Doxy* updated (includes above enhancements)
1949 * INSTALL now points to web documentation
1951 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1952 * src/gdcmHeader.h doesn't make unnecessary reference to
1954 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1956 * src/gdcm*.[cxx|h] :
1957 - to allow compilation with gcc 3.x
1958 -- clean up of STL usage (added explicit usage of std::)
1959 -- small fixes on exceptions.
1960 Note: linking not tested !
1961 - clean of doxygen comments to avoid warnings at documentation
1963 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1964 dependent convertion).
1966 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1967 * Clean up of previous JPR garbage commit (not even commented in the
1969 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1970 - moved all jpeg related files from src to src/jpeg/libijg8, with
1971 addition/modification of Makefile.am and configure.in.
1972 - the testSuite is still brain damage (not guilty).
1974 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1975 * WrapVTK.py : modifications to get correctly vtk source files to
1977 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1978 (FileName -> Filename)
1980 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1981 * vtk/vtkGdcmReader.[cxx/h]:
1982 - UpdateProgress method should now be effective
1983 - removed the limitation on having only images loaded (as opposed
1985 - when building a stack of images/volume, a lesser number of
1986 gdcmHeader and gdcmFile instances should be used (hopefully
1987 accelerating things).
1988 - when building a stack of images/volumes, files which are not
1989 loadable (wrong path-filename, wrong permissions on existing file,
1990 or file not parsable by gdcm) are replaced with a black image
1991 in the stack (for the caller to notice the problem).
1993 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1994 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1996 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1997 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1998 between standard library (std) and vtk library (problems are found
1999 under Windows... thanks Windows !)
2001 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2002 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2004 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2006 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2007 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2009 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2010 * When compiling with distutils (see setup.py) the C++ compiler is
2011 called with different flags than the default ones (with automake).
2012 In order to fix all those warning, I compiled gdcm with the command
2013 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2014 and went for warning fixes:
2015 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2016 up from unused variables.
2017 - vtk/vtkGdcmReader.cxx: potential bug fix.
2018 * src/gdcmHeader.h: Doxygen warning cleanup
2020 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2021 * gdcmPython/gdcm.i:
2022 - typemaps correction to take into account the systematic replacement
2023 of "using namespace std" with std:: prefix e.g. std::list,
2024 std::string... (cf changes of 2003-05-21).
2025 - gdcmGlob global variable of type gdcmGlobal (defined in
2026 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2027 exported to Python a as cvar.
2028 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2029 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2030 gdcmDictSet.GetPubDictTagNames() and
2031 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2032 C++ static methods).
2033 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2034 with the above changes.
2036 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2037 * setup.py, manifest.in : bug fix under linux
2039 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2040 * Modification of setup.py to compile vtk part too. Then, we have 2
2041 wrappers which must work with same distutils. For that, we have a
2042 generic distutils in distusiltsWrapping.py ; with :
2043 - build_extWrap class to wrap generically all extensions,
2044 - ExtensionWrap base class for all wrapping extension that contains
2046 - Wrapper interface which wrap sources
2047 + In WrapSwig.py we have extension and wrapper for Swig
2048 + In WrapVTK.py we have extension and wrapper for VTK
2049 * MANIFEST.in : modifications to consider vtk directory and new python
2050 files for compilation
2052 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2053 * Added python wrappers of vtkGdcmReader vtk class (see the
2054 source in vtk/vtkGdcmReader.cxx) :
2055 - vtk/Makefile.am now builds a library
2056 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2057 python library (as opposed to _gdcm.so wich are the python
2058 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2059 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2061 - configure.in has an additional flag --enable-vtk that needs
2062 to be set to enable compilation of vtk related code, that is:
2063 + vtk/vtkGdcmReader.so and
2064 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2065 + gdcmPython/vtkgdcmPython.so (see above)
2066 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2067 be read when compressed or when HighBit + 1 != BitsStored),
2068 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2069 the usage of the python wrapper of vtkGdcmReader vtk class.
2070 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2071 * src/*.[h] all occurences of stl classes are now prefixed with
2072 std::, and all occurences of "using namespace std;" where removed.
2073 This is to avoid pollution of global namespace in included files.
2074 Apparently vtk does not avoid this pitfall: when using both
2075 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2076 collision of various stl members (principally cout...).
2077 * gdcmPython/testSuite.py now cleanly removes temprory generated
2079 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2080 comply with above changes)
2082 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2083 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2084 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2085 vtk data structure (an image Flip was required).
2086 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2087 * cosmetic changes in documentation.
2089 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2090 * src/gdcmHeader.cxx: the constructor no longer exits when an
2091 unexisting file is given as argument.
2092 * The subdirectory Data (containing all the images used for the
2093 test suite) is not part of this repository anymore. A new module
2094 containing those images is now available at
2095 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2096 with the name gdcmData.
2097 All the python scripts (including the package initialisation file
2098 gdcmPython/__init__.py) were adapated to take this change into
2099 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2101 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2102 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2103 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2104 demo of the usage of this class.
2105 Compilation of this vtk part is only done when using the --enable-vtk
2106 at configure (or autogen.sh) stage.
2108 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2109 * More memory link related corrections and documentation fixes.
2111 - maximum info is obtained with a command of the form:
2112 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2113 --show-reachable=yes PrintHeader
2114 - the remaining reachable blocks seem to come from the STL
2115 allocation scheme through the usage of map and list. It looks
2116 like this memory cannot be freed but it is not a memory leak
2117 (in fact further invocation to the STL would recollect the
2118 unused memory allthough it cannot explicitely be freed).
2119 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2120 of displaying an image parsed with gdcm and displayed with VTK.
2121 Note: some images don't seem to work e.g.
2122 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2123 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2124 Allthough this weakens the semantics, it is a ditch attempt to
2125 make gdcm more thread friendly.
2127 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2128 * Memory link hunt (by using valgrind through the command
2129 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2130 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2131 gdcmHeader::_dicom_vr.
2132 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2133 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2135 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2137 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2138 * src/Makefile.am now exports all the necessary include files at
2142 * UpdateGroupLength replaced by new one
2145 * UpdateGroupLength re-written using H-Table
2146 (named UpdateGroupLengthNew untill checks are over)
2148 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2149 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2150 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2152 - gdcmHeader::GetPubElValSet removed.
2153 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2154 UpdateGroupLength, WriteElements, Write.
2155 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2156 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2157 carried the same semantics.
2158 - src/gdcmHeaderIdo.cxx changed accordingly.
2159 - gdcmFile::WriteBase now regroups all the codes from previous
2160 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2161 - enum FileType moved to gdcmCommon.h
2162 * src/gdcmHeader.cxx AddDefault trashed
2163 * gdcmGetXSize added
2164 * getimageDataSize now calls gdcmGetXSize
2165 * Test/*.cxx changed to agree with above changes
2167 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2168 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2169 (to avoid double call by end user).
2170 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2171 by end user, since gdcmHeader::gdcmHeader now handles it.
2173 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2174 * gdcm/Doc many doxygen changes:
2175 - Doxyfile now has two different versions, DoxyfileUsers that generates
2176 the html.users end users oriented documentation and
2177 DoxyfileDeveloppers that generates the html.developper developper
2178 oriented documentation.
2179 - README changed accordingly
2180 - requirement.txt removed (old design info moved to TODO).
2181 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2182 DoxyMainPage.txt, DoxyPython.txt provide more information.
2183 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2184 be updated by simply regenerating the docs with doxygen and copying
2185 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2186 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2187 all the tests in the form "if (<map>.count() >1)" were removed.
2188 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2189 ill-formed documentation sections.
2190 * src/gdcmHeader.cxx: ditto
2192 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2193 * setup.py fixed for un*x (needed macro for stdint.h)
2194 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2195 un*ces with sh-utils test utility.
2196 * gdcmPython/demo/test.py renamed to PrintHeader.py
2197 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2198 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2199 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2200 * src/gdcm*.cxx JPR's bad inclusion fixed.
2202 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2203 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2204 * gdcmPython/demo/test.py changed accordingly.
2206 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2207 * gdcmPython/Makefile.am fixed linking against libstdc++
2208 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2209 * Swig subdir (historical tests of swig version 1.3.17++) removed
2210 * Test/testChangeEntete.cxx some lines commented out in order to make
2212 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2213 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2215 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2216 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2217 hence the user doesn't need this explicit call.
2218 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2219 i.e. LoadElements() call removed.
2220 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2221 - src/Makefile.am declares the proper flag for g++.
2222 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2223 for adding user defined new tags.
2224 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2225 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2226 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2228 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2229 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2230 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2231 src/Makefile.am : the project should properly compile and install
2232 with the autotools, included the python wrappers part.
2233 * gdcm.spec.in : added a spec file for RPM packaging.
2235 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2236 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2238 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2239 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2240 to exported to the environement (see gdcmPython/testSuite.py
2242 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2243 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2244 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2245 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2246 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2248 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2249 * gdcmPython/__init__.py doesn't crash anymore when running in
2250 in InstallMode or PreInstallMode but with an environement given
2251 value of GDCM_DICT_PATH.
2252 * src/gdcmDictSet.[cxx/h] coding style.
2254 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2255 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2256 * src/gdcm.h general comments moved to TODO, and README
2257 * src/gdcm.h should now be seen as a user commodity (including it
2258 should suffice to fully use gdcm). It is nowhere including within
2259 any of the kernel files src/*.cxx and src/*.h.
2261 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2262 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2263 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2265 * src/gdcm*.cxx only include their corresponding include file
2266 (as opposed to gdcm.h)
2267 * gdcmPython/gdcm.i changed accordingly
2268 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2269 the autogen.sh generated "make snapshot" command to work.
2270 * autogen.sh removed history related references to crea package.
2272 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2273 * distutilsSwigCPlusPlus.py work around some swig portability
2276 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2277 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2278 was done in a last ditch attempt to get setup.py _really_
2279 operationnal. The python/gdcmPython layaout add the advantage
2280 of hidding away the python related distutils specific files
2281 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2282 Alas, the src directory was out of scope (i.e. it's relative
2283 position to setup.py was ../src) which made things impossible to
2284 handle (see previous version of python/setup.py). Crossing fingers...
2286 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2287 * python/setup.py now works on Un*x. (harder than I thougth)
2288 * python/distutilsSwigCPlusPlus.py can now have include files
2289 among the list of sources.
2291 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2292 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2293 * modifications in MSVC projects
2295 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2296 * As stated by the first lines of Test/ExceptionAndPython/README, it
2297 looks like we can move back to original usage of exception within
2298 src/gdcm* and hence remove the errno stuff that was introduced
2299 as a quick and dirty fixture of this problem (added to the TODO).
2300 * Doc/Doxyfile configuration file for Doxygen and corresponding
2301 README file for usage added.
2302 * Test/testWrite.cxx added. This new test comes from a split of
2303 test.cxx that is now reverted to its original purpous i.e.
2304 testing the proper parsing of a Dicom related file.
2305 testWrite.cxx concentrates on testing the IO part of gdcm.
2306 * Test/bug1.cxx (containing a bug on WIn32) added.
2307 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2308 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2309 whose purpose is to publish the content of the TagNames of the
2310 Dicom public dictionnary were not accessible without an
2311 instance of class gdcmHeader.
2312 - those methods are now static methods of gdcmDictSet and hence
2313 require no instances at all to be invocated.
2314 - within gdcmDictSet this change required to change some method
2315 to class methods (i.e. are now static) among which SetDictPath
2316 (renamed to BuildDictPath) and LoadDefaultPubDict.
2317 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2318 the above changes by calling the new method classes of gdcmDictSet.
2319 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2320 the above to be effective.
2321 * python/gdcmPython: in order to wrap properly the above changes
2322 for Python, swig version now needs to be > 1.3.17.
2323 * python/gdcmPython/Makefile fixed to adapt itself to new
2324 configure/make shema introduced by Johan Montagnat (thanks for the
2325 contribution). Alas this Makefile cannot be turned into a proper
2326 Makefile.am without some heavy changes in the configure.in
2327 (for python dectection).
2328 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2329 now avoids publishing the empty entries.
2331 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2332 * python/setup.py : bug fix concerning install under windows
2333 ExtraPath reused :-P
2334 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2336 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2337 * Dicts/dicomV3.dic : remove double spaces !!!
2338 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2339 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2342 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2343 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2344 method. Doxygenation.
2345 * src/gdcm.h clean up of JPR spurious comments.
2347 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2348 * python/distutilsSwigCPlusPlus.py now properly collects the
2349 shadow classes generated by "swig -c++" (gdcm.py in our case)
2350 when using "python setup.py install".
2351 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2352 reexports the working classes.
2353 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2354 by the classical C errno scheme. This is to prevent an obscure
2355 behavior of the python wrappers when importing wxPython.wx prior
2356 to gdcmPython (which ended up in an abort call). An illustration
2357 of this oddity can be found in the Test/ExceptionAndPython
2358 subdir (see the README file). This problem probably due to
2359 an combination of g++ and dynamic loading.
2360 * added Test/ExceptionAndPython (see above)
2362 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2363 * Changed the layout of the python part to avoid bloating main
2364 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2365 i.e. the distutils arsenal. All the python related stuff is
2366 again in a python subdir, but the package itself is now in
2368 * setup.py was cleaned up:
2369 - pythonIncludePath removed
2370 - python setup.py bdist target is now functional.
2371 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2372 collision with other packages). gdcmPython/demo/*.py changed
2375 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2376 * python subdir moved to gdcmPython (preparation of distutils packaging).
2377 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2378 distutils installer is operational.
2379 * - gdcmPython/__init__.py now properly loads the swig generated
2380 shadow classes (from gdcm.py).
2381 - gdcmPython/demo/*.py changed to import the package gdcmPython
2382 instead of gdcmPython/demo/load.py.
2383 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2385 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2386 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2387 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2388 entries within the associated public Dicom dictionary resp. the same
2389 information but sorted by the fourth field (PAT, IMG, DIR) of the
2391 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2392 are now in the "???" group.
2393 - python/gdcm.i changed accordingly,
2394 - python/demo/printGroupedPublicDict.py added, that gives an example
2395 of the above new functionalities in Python.
2397 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2398 * src/gdcm.h, gdcmHeader.cxx:
2399 - historic references to glib's g_malloc and g_free (#defined)
2400 were definitively removed.
2401 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2402 * src/gdcmElValSet.cxx:
2403 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2404 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2405 - GetElValue(string) renamed to GetElValueByName.
2406 - Added GetElementByName(string).
2407 * src/gdcmHeader.cxx: added
2408 - GetPubElValRepByNumber(guint16, guint16)
2409 - GetPubElValRepByName(string)
2410 - GetShaElValRepByNumber(guint16, guint16)
2411 - GetShaElValRepByName(string)
2412 - GetShaElValByNumber(guint16, guint16)
2413 - GetShaElValRepByName(string)
2414 - GetElValRepByNumber(guint16, guint16)
2415 - GetElValRepByName(string)
2416 - GetElValByNumber(guint16, guint16)
2417 - GetElValRepByName(string)
2418 * Doc/requirements.txt added.
2420 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2421 * Test/Makefile building now depends on the one of libgdcm.so
2422 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2423 pixel data) aware which enables finding the address (offset) of
2424 the pixel data of JPEG encoded DICOM files. This leaves only a single
2425 file in the testSuite whose pixel data address (offset) is unknown.
2426 * python/testSuite.py changed accordingly.
2428 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2429 * VC++ has some strong limitations when working with the STL, as stated
2430 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2431 "Also note that some STL containers (map, set, queue, list, deque)
2432 cannot be exported. [...]
2433 Some STL classes contain nested classes. These classes can not
2435 This is caused by a designed limitation that once a template
2436 class is instantiated, it can not be re-instantiated and
2438 Since our usage of map<> is ubiquitous in gdcm, this "designed
2439 limitation" of VC++ is a pitfall.
2440 Hence the Python wrappers of gdcm cannot be incrementally linked
2441 against the c++ dynamic library. The dirty but only workaround is
2442 to forget about incremental link of dynamic libraries and to generate
2443 the Python wrappers library with the inclusions of the underlying C++
2445 The following modifications concern this matter on Win32/VC++:
2446 - wrapping python correct with standalone wrapped dll (don't use separate
2447 dll under windows !!!!)
2448 - python21_d debug mode enabled (ask Frog how to use it :-)
2449 - NO problem with having an STL member of class for example string in C++
2450 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2451 - Python test of dcmlib in Python is ok under windows on a large set
2453 * removed glib references
2454 * typedef's inserted in gdcm.i for correct swig type management
2456 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2457 * python/demo/*.py load.py extracted from test.py. Added explore.py
2458 that only displays required tags and testAll.py that parses all
2459 the files of the testsuite without using unittest.
2460 * python/testSuite.py other additional test on new files added.
2461 * Data/* new test files added accordingly to the testSuite.
2462 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2463 the vr in the file differs from the one of the dictionary.
2465 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2467 values, but limits itself to values which are below a user specified
2468 size (by default 1024 bytes).
2469 * python/gdcm.i : elements not loaded (because their size is above the
2470 user specified treshold) are exported with their TagKey as key of the
2471 python dictionary. This enables the testsuite to make some checks
2472 on the unloaded elements (since we have their offset and size).
2473 * python/testSuite.py
2474 - now tests for the existence and proper value of the pixel data
2475 - two new examples added.
2476 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2478 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2479 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2480 aware. See the strategy comments in gdcmHeader::FindeLength().
2481 * Test/test.cxx now accepts a filename as first argument.
2482 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2483 * python/testSuite.py changed to integrate test on above files.
2485 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2486 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2487 the vr was also RET.
2488 * python/testSuite.py more tests added.
2490 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2491 * python/testSuite.py unittest test suite added (uses Data)
2492 * Data/* dcm and acr files for the test suite.
2493 * glib dependance removed from un*x version. We now use ISO C99
2494 7.18 Integer types (see stdint.h)
2495 - python/Makefile, src/Makefile src/gdcm.h
2496 * src/ when an explicit vr (like dicom files) suddenly poped an
2497 implicit element we use to mark the underlying DictEntry of the
2498 concerned ElValue with "Implicit". This strategy was damageable
2499 too the public or provite dictionaries, since some of their vr
2500 would be changed. Since Header::FindLength heavily relies on the
2501 detection by Header::FindVR of falsely explicit elements, I
2502 added an extra ImplicitVr member to ElValue (boolean).
2503 The rest of the changes we the necessary adaptations.
2505 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2506 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2508 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2510 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2511 * Adaptation for porting to VC++:
2513 o forced to use std namespace (for string to be known)
2514 o all class use __declspec export style on WIN32
2515 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2516 (in stdlib.h on Win32 but in std:: for gcc)
2517 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2518 variable GDCM_DICT_PATH.
2519 * src/gdcmHeader.cxx verbose comments made discrete.
2521 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2522 * python/gdcm.i: added a typemap that converts a C++ hashing table
2523 to native Python dictionary.
2524 * python/demo/test.py:
2525 - now uses the native dictionary for exploration of gdcmHeader.
2526 - takes an optional filename argument (the file to parse).
2527 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2528 PubElVals hashing table.
2529 * Dicts/dicomV3.dic removed error prone trailing spaces.
2531 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2532 * Python wrapping process moved away from src/Makefile to
2533 newly created python/Makefile (as well as gdcm.i)
2534 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2535 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2536 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2537 from the environement variable GDCM_DICT_PATH (when existing).
2538 * src/gdcmDict::GetTag bug fix.
2540 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2541 * Straightforward temporary fixes for swig to build the python wrappers.
2542 src/Makefile now has a python working entry [by working we mean
2543 that we can import de shadow classes without errors].
2545 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2546 * hashtest.cxx removed (since allready in Test)
2547 * src/gdcmlib.h renamed to src/gdcm.h
2548 * src/dcm.i renamed to src/gdcm.i
2549 * src/Makefile prepared for python wrapping
2551 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2552 * src/gdcmHeader.cxx :
2553 - Parsing of header is now separated from loading of element values
2554 (see gdcmHeader::LoadElements).
2555 - general clean up of hopefully all file access (creation of
2556 ReadInt16 and ReadInt32)
2558 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2559 * src/gdcmHeader.cxx :
2560 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2562 - SetLgrElem renamed to SetLength
2563 - GetLgrElem renamed to GetLength
2564 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2565 * src/gdcmElValSet.cxx fixed both GetElValue methods
2566 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2567 due to IdoDude was cleaned out.
2569 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2570 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2571 concentrates on finding the value representation (when it exists).
2572 RecupLgr now only finds the element value length, and it avoids
2573 returning the unecessary skL (skipped length).
2574 Also, offsetCourant was simply removed (with taille_fich) since
2575 it was redundant with the File position internals (by using
2576 ftell and fseek). This also made skL (see above in RecupLgr) usage
2578 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2579 on the libido specificities which are handled through class
2581 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2584 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2585 * Truckload of changes. Parsing of header is barely functional
2586 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2588 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2589 * src/gdcmHeader.cxx many addons of low level methods
2591 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2592 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2593 and _IdDcmSWAP_LONG.
2595 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2596 * This corresponds to all the changes decided at the meeting of
2597 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob