1 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmFile.[h|cxx] : add the Print method
3 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
4 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
5 * src/gdcmDocument.h : remove the PrintLevel informations
6 * Example/PrintFile.cxx : use the new gdcm::File::Print
8 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
10 problems when compiling with the python wrapping
12 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
14 writting in ImplicitVR
16 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
17 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
18 JPEG decompression, especially when dicom frames are split into several
19 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
20 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
22 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * src/gdcmHeader.cxx : change the initialisation of default header.
24 Now, this header is readable by gdm, e-film, DicomWorks
26 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
28 Rename Decompressed to Raw
29 * Use the API changes in gdcm::File.
30 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
33 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
35 each added entry in the header. Replace the 'Planes' field by the 'Number
38 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
40 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
42 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
44 At this time, this image isn't readable by e-film... waiting JPR help to
47 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
49 DocEntry. Now use methods of the Document !
51 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * Test/ShowDicomSeq.cxx : bug fix
54 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
55 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
56 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
57 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
58 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
60 * Test/TestCopyRescaleDicom.cxx : remove unused variable
61 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
62 containing found sequences
64 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
67 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
68 Some fields in BinEntry must be copied to not seg fault when making the :
69 gdcm::File *copy = new gdcm::File( copyH );
70 and tests are now made on good variables
72 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
74 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
76 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
77 * Add vtkGdcmWriter example and test
79 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
80 * Test/TestUtil.cxx : reformat the source code
81 * vtk/vtkGdcmReader.cxx : remove and change prints
82 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
84 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
85 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
87 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
89 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
91 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
93 by an eof to prevent all bad read of the file... and in this case, the
96 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * Example/Volume2Dicom.cxx : comment unused variables
98 * Test/PrintDicomDir.cxx : comment unused variables
99 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
100 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
101 method that is redondant with AddEntry.
102 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
105 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * Bug fix due my last commit (compilation under Windows).
107 * Example/Volume2Dicom : bug fix in the file and reformatting source code
108 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
110 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
112 - Remove printf / sprintf
113 - include iostream AFTER gdcm so we don't get warnings
114 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
116 - Also remove tons of include from header files, hopefully this should
117 speeup the compilation time, since it was becoming a dog slow.
118 - Remove gdcm.h as it include way too many files and slow down compilation
119 (plus it is not up to date)
120 - remove 'using namespace std' this is BAD !
122 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * Remove memory leaks on the DicomDir
124 * Remove some useless datas in DicomDirObject
125 * Add usefull methods in SQItem, to be complient withe the ElementSet
127 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
130 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
132 future, with convertion)
133 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
134 and ImageDataSize values. Remove the method to get the PixelReadConverter
135 from the output of the class
137 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
140 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
142 and vtkErrorMacro use.
143 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
145 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
148 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
149 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
150 The string leaves only in the fonction. So when we make a .c_str(), we
151 get the pointeur on the first element, element that will be destroyed
152 immediately after thee instruction.
153 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
154 file has been opened : the test must be made on the content of the
155 pointer and not directly on the pointer !
158 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
159 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
160 the python part recompiles
162 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
164 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
165 X session is killed (for my computer... it seems to not be identic on
168 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
170 avoid problems (otherwise, the difference test between the visible image
171 and the reference is incorrect. If the reference is greater than the
172 screen resolution, it's produce errors).
173 Can be used for only one image. Can be used with a visible flag.
174 * vtk/vtkGdcmReader.cxx : remove commented codes.
175 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
176 under windows at compilation
177 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
179 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
181 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
183 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
184 tests on the image size X, Y, Z
186 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
187 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
188 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
189 between the class name and the file name
191 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * src/ : fix compilation warnings for the Write method (2 different
193 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
194 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
195 variable... create a static method in gdcm::Document to access to
196 this variable content.
198 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
200 file, to be accessed by other files (like gdcmFile). Remove commented
201 code. Move the change of the header to the gdcmFile, using the
203 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
204 To be sure of that (and simplify calls), the Write of the header now
205 gets a file name and not a file pointer (std::ifstream).
206 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
207 DocEntryArchive. Remove all open of the written file
209 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
212 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
214 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
216 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
217 some corresponding methods. Write correctly the file and check before
219 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
220 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
221 is now on RGB datas (as before my last commit
222 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
224 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
225 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
226 Add a print information of the type of the entry
227 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
228 It was in the gdcmFile, and all write have been regrouped
229 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
230 Write correctly all dicom files (in decompressed mode only at this time)
231 * Test/ : test on files are now made using Raw datas and not color datas if
233 * Example/PrintFile.cxx : add more printings
235 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * Amelioration of code, remove some code copy. For the loading of
237 BinEntry (in gdcmDocument), add the test to verify if the file is already
240 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
242 remove a DocEntry in the header (push an empty DocEntry)
243 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
244 lines. Bug fix in the initialization of the PixelConvert and the
246 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
247 use in TestCopyDicom (now this test can run under windows... but fails)
248 * Test/TestCopyDicom.cxx : amelioration of the test :
249 - test the pixels written
250 - add test points to quickly find where is the error
251 - can set a file name input and output in arguments
252 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
253 amelioration of the test output
255 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
257 all replaced DocEntry's
258 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
259 Now, each needed DocEntry to modify is duplicated, modified and inserted
260 to the header using DocEntryArchive. Thus, after save, we can restore the
261 header initial state.
263 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
264 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
266 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
268 correct to copy it. The DictEntry is specified at the DocEntry creation,
269 then, it musn't change in the time.
270 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
271 header correctly. At this time, the change is only made for the first
272 level of the Document. In the future, it might consider sequences.
273 The change is made by replacing a DocEntry by an other that is created
274 outside the class. The old value is kept. When we restore the header
275 status, the added DocEntry is deleted and replaced by the old value.
276 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
277 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
278 set the write type to explicit VR, implicit VR or ACR. Add methods to set
279 the write mode to native, decompressed or RGB (but not used at this time)
281 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
283 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
285 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
286 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
287 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
289 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
290 set because already copied when copying the BinEntry's of the header
291 * Test/TestAllReadCompareDicom.cxx : remove warnings
293 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
294 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
295 Two problems appear when doing it :
296 - with the gdcmFile : when the GetImageData method is called, the pixels
297 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
298 datas (pixels). And each structure destruct the datas when it's
299 destructed. So we have two destructions for the same datas. To solve it,
300 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
301 datas or not. If it doesn't own datas, then they will not destroyed by
303 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
304 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
305 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
306 create a double destruction of the same DocEntry's. So, to solve it,
307 the TagHT is simply cleared and the DicomDir* elements are destroyed.
308 * TODO : add an entry concerning memory leaks in the DicomDir
310 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
312 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
315 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
317 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
318 after it have been deleted
320 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * FIX: src/* fix the doxygen warnings.
322 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
323 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
324 was erroneously defined with a size of 15 instead of 16. [many thanks
325 to Jean Michel Rouet for pointing out this bug].
327 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
328 1. Finish merging JMR patch for writting DICOM from scratch
329 2. Fix -hopefully- bug with MONOCHROME and space vs null character
330 3. Use const ref when possible
331 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
332 5. A few more comments
333 6. CreateUniqueUID can now be called without parameter"
335 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
336 * ENH: Slightly bigger patch:
337 1. Getting toward full integration of JMR patch for writting dicom from scratch
338 2. Update Test to test part of this patch: CreateUniqueUID
339 3. File was not close properly in gdcmDict
340 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
341 5. Use of const ref instead of copy (speed issue)
342 6. Remove temporary (duplicate) string in TranslateToKey
343 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
344 8. Do not repeat virtual in subclasses
345 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
347 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
348 * Apply first patch toward better string comparison when dealing with broken
349 DICOM files. Essentially the string could be padded with a space instead
350 of a null character as defined by standard
352 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
353 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
354 because never used... and in the same time, that's remove some memory leaks
356 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
357 * src/gdcmFile.cxx : now delete the PixelConvert instance.
358 * In examples and tests : change the type of image data variables from void*
359 to uint8_t*. Remmove all delete on image data variables
361 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
362 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
363 Verify the file pointer value before open the file, and if it's not null,
364 a verbose message is generated.
365 Close correctly the file when the file isn't considered dicom-like. The
366 correctly close is a call to CloseFile.
367 When closing the file pointer, test if its not null to close the file.
368 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
369 file. For an uncompressed image, the copied datas correspond in the least
370 case to the image size (calculated) or the image size specified in the
371 header. A verbose is generated if these two size mismatch
373 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
374 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
375 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
376 break under windows (with msvc6 compilation).
378 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
379 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
380 compiling with MSVC6)
382 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
383 * Bugs fix for the Windows build with VC6
384 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
385 needed (only for projects required VTK). If the VTK is included in all
386 projects, there is conflicts with the jpeg lib of vtk when compiling the
387 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
388 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
389 when compiling the gdcm_wrap.cxx file (created by the compilation of the
391 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
392 (like it's already made for the cout use). Otherwise, conflict with the
395 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
396 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
398 - comments on the DicomDir::Method related usage added.
399 - now that we use the namespace gdcm, a lot of internal classes do
400 NOT need to be wrapped anymore.
401 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
402 DicomDir::Method) new example added.
404 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
405 * Improve string manipulation. I now inforce the notion of 'DicomString'
406 A DicomString can contain as many \0 as they want
407 and it is *always* of even length.
408 We only support odd length for very rare case.
409 And in the near future this should be removed.
411 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
412 * /binary_write/ gdcm source. Now even on big endian we are writting
413 little endian. This should -heopfully- fix some tests
415 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
416 * Now the dictionary is compiled into gdcm lib. This is a default
417 behavior, thus any dic file specified is picked before failback to
418 the one comiled into lib
420 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
421 * Change internals for gdcmDict. Don't use any 'new' any more.
422 This should definitely solve any leak problem, and we should be
423 as fast as before, as long as don't modify too much the dictionary.
425 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
426 * STYLE: ivars should start with a capital letter.
427 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
428 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
430 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
431 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
432 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
433 new 2004 dictionaries added (thanks to JPR).
434 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
435 * CLEANUP_ROUND (15) for gdcmPixelConvert
436 - RLEFrame::NumberFragments is now of type unsigned int
437 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
438 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
441 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
442 * Initial work in gathering all transfer syntax accessors. clearly
443 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
444 ivars, but only one transfersyntax (class) ivar with equivalent method on
447 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
448 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
449 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
450 discussed (plus I didn't like having a 2000 lines patch not commited)
452 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
453 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
454 * CLEANUP_ROUND (14) for gdcmPixelConvert
455 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
456 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
457 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
459 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
460 anymore and hence avoids storing a copy of PixelConvert::Decompressed
461 into File::Pixel_Data.
463 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
465 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
466 * CLEANUP_ROUND (13) for gdcmPixelConvert
467 Substituted File::ParsePixelData() with PixelConvert::Print() new
469 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
470 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
471 method to those classes.
472 - src/gdcmFile.[cxx|h]:
473 -- Added a ::Print() method.
474 -- PixelConverter is now a reference instead of a member.
475 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
476 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
478 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
479 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
480 collaboration diagram and inheritance diagram should be generated with
482 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
483 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
484 pointlessly wrapped (see
485 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
486 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
487 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
488 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
489 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
490 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
491 -- File::Initialise: PixelConverter setup moved away to
492 PixelConverter::GrabInformationsFromHeader()
493 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
494 interpretation moved away to PixelConverter::BuildRGBImage()
496 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
497 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
498 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
500 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
501 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
502 displayed on Win32 when a brutal abort() occurs (because of uncatched
503 exception). See TODO new entry of this commit for more on this.
504 * TODO added new entry.
505 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
506 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
507 - HandleColor is no longer called from gdcmFile.cxx
508 - gdcmPixelConvert.cxx clean up on method arguments and internal
509 variable names for semantical coherence.
511 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
512 * Finished lossless transition, not only do we now read all lossless jpeg
513 images, without the need of the Cornwell lib, but we do read them properly now
514 * To reduce code (well to avoid code duplication), I defined a common place
515 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
516 redefine symbols. This is not prefect but this the best solution I found for a
517 compilation time jpeg option.
519 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
520 * Update jpeg ijg lib to support lossless jpeg implementation
521 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
523 * Also added a special copyright for dcmtk since we use their bugfixes.
526 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
527 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
528 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
529 matters, as stated in warning note at begining of %include section).
530 * src/gdcmDicomDir*.[cxx|h]: coding style
531 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
532 * src/gdcmJpeg8.cxx: doxygen fix.
533 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
534 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
535 from File:: to PixelConvert::.
537 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
538 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
539 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
540 - more code moved away from File:: to PixelConvert::
541 - fat setup of PixelConverter set in place in File::Initialise.
543 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
544 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
545 namespace at the file system level. So now you should convert your examples
547 gdcmHeader -> gdcm::Header
548 It would be nice if people keep in mind to no open the namespace, since it
549 allows compilation on broken plateform which were defining common symbol in
550 the standart namespace (like LP, Unknown ...)
552 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
553 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
554 The JPEG fragments are now parsed at the same stage than the RLE
555 information. All code related to JPEG is now in gdcmPixelConvert:
556 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
557 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
558 export a gdcmFile:: method. Those are simply global functions
559 (for the time being this is better than having them attach to
560 either gdcmFile:: or gdcmPixelConvert::).
561 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
562 and stores the result in a gdcmJPEGFragmentsInfo.
563 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
564 code (among other stuff) moved away from gdcmFile:; to
567 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
568 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
569 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
570 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
571 clean up of RLE related code.
572 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
573 - src/gdcmRLE.cxx removed
574 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
575 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
576 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
577 * CLEANUP_ROUND (9) for gdcmPixelConvert
578 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
579 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
580 away from gdcmFile:: to gdcmPixelConvert::.
582 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
583 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
584 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
585 This is because Parse7Fe0 used to parse the pixels to compute the
586 length. This task was passed over to FindDocEntryLengthOB() a long
587 time ago, EXCEPT I had forgotten the OW case...
588 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
589 we just recylce the code for parsing RLE fragments and computing
591 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
592 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
593 with the retired Parse7Fe0().
594 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
595 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
597 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
598 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
599 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
600 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
601 - src/CMakeLists.txt: alphabetic order reodering + new entries.
602 * CLEANUP_ROUND (4) for gdcmPixelConvert
603 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
604 to return an unused length.
606 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
607 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
608 this should be cleanner from the plane view. The iostream are erally a pain
609 to use to do simple stuff.
611 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
612 * Redo the compilation of the ijg jpeg library. Now only one source is
613 necesseray. No need to rename file by hand what so ever. CMake handle the
614 copying of the file within different directory, configure header file to
615 modify some symbol. The only addition made to ijg wasd a mangle table so
616 that symbol are different wether we are within 8bits or 12bits.
618 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
619 * Added documentation of vtkgdcmReader on Website:
620 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
621 with it's binary name).
622 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
623 the Website to be more complete.
624 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
625 doxygenated documentation.
626 - Doc/DoxyVtkGdcmReaderExamples.txt added
627 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
628 DoxyVtkGdmReaderExamples.html )
629 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
630 * CLEANUP_ROUND (3) for gdcmPixelConvert
631 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
633 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
634 * CLEANUP_ROUND (2) for gdcmPixelConvert
635 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
637 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
638 * CLEANUP_ROUND for gdcmPixelConvert:
639 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
640 - src/gdcmPixelStuff[h|cxx] removed
641 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
642 - src/CMakeLists.txt changed accordingly
644 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
645 gdcmVersion.py moved to newly created ATTIC related
646 gdcmPython/SetupOldies/ directory.
647 * Autotools clean up:
648 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
649 - autogen.sh configure.in acinclude.m4 python.m4 removed
651 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
652 * src/*.cxx *.h Reference to License.htm fixed to License.html.
653 * Doc/CMakeLists.txt, doxygen.config.in: fix.
654 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
656 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
657 * TODO updated with Mathieu suggestions. I proposed a template for
658 describing TODO entries and used it for new entries.
659 * Added Doc/Website/CodingStyle.html, Developpers.html,
660 DeveloppersPython.html, GdcmDataCvs.html and
661 DownloadVersion0_1.html, DownloadVersion0_3.html.
662 * Some Doc/*.txt Doxygen files (which do not really concern the
663 documentation itself, but the website) moved to html and
664 placed in directory Doc/Website:
665 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
666 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
667 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
668 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
669 * CMakeLists.txt changed accordingly.
670 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
671 DeveloppersPython.html
672 * INSTALL nows refers to Doc/Website/Installation.html
674 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
675 * Added Doc/Website directory, that contains a first raw version
678 2004-09-23 Jean-Pierre Roux
679 * FIX In order not to be poluted any longer by casting problems,
680 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
681 we can now delete[] it safely
682 * VoidArea is now called BinArea (less confusing name),
683 and all the methods called ...VoidArea... are now ... BinArea...
684 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
686 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
687 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
688 clear) TagHT, which is an inherited member of gdcmElementSet. It is
689 up to the destructor of gdcmElementSet to clean up TagHt and it's
692 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
693 * Test/CMakeLists.txt: update to follow gdcmData renamings.
694 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
696 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
697 * ENH: added some utility method that builds a flat dictionnary
698 holding all the Dicom entries contained in the recursive structure
699 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
701 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
702 BuildFlatHashTable() that build a flat dictionary.
703 - src/gdcmElementSet.h: added a new private GetTag() accessor.
704 gdcmDocument is now a friend of gdcmElementSet.
705 - src/gdcmElementSet.cxx: clean up.
706 - Example/FlatHashTablePrint.cxx added.
707 - Example/CmakeLists.txt changed accordingly
709 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
710 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
711 moved away from gdcmDocEntrySet (since this class is an abstract class
712 acting like an interface). SQDepthLevel and BaseTagKey are now
714 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
715 and associated accessors. Doxygenation of the class.
716 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
718 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
719 Use SQDepthLevel accessor instead. ::Print() adapted.
720 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
721 - src/gdcmDocument.cxx changed accordingly.
723 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
724 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
725 - The following is the doxygen comment of the typedef declaration
726 of gdcmagKey in src/gdcmCommon.h:
727 gdcmTagKey is made to old an "universal" (as in URL, Universal
728 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
729 A dicom tag allways has a group and an element, but a set of tags
730 embeded in various (optionally nested) sequences and sharing
731 the same group and element all share the same (group, element)
732 "identifier". Hence the (group, element) cannot be used as an
733 identifier (in gdcm we shall refer to a "TagKey") of a tag.
734 In order to construct a proper tag identifier (i.e. a key) we
735 consider the following definition of a TagKey:
736 - let Group, Element be the string representation of the
737 group and element dicom tag members,
738 - let ItemNumber be the string representation of the integer
739 index of the considered item number of a sequence,
740 Let the key of a tag embeded in a sequence, noted SeqTag, be
742 /ItemNumber#Group|Element
743 where "/", "#" and "|" are characters acting as separators.
744 Then the general form of a gdcmTagKey is given by:
745 Group|Element<SeqTag>
746 where <SeqTag> means NO or many instances of SeqTag.
747 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
750 but the gdcmTagKey of a tag "embeded" is the first item of
751 a sequence, itself nested in the third item of a sequence is the
753 0004|1220/2#0008|0082/0#0008|0090
754 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
755 order to hold the new sequence compatible key. Previously, the
756 GetKey() method would look in the underlying gdcmDictEntry.
757 - src/gdcmDocEntry.cxx:
758 -- constructor now copies the underlying DictEntry key, in the local
760 -- ::Print: displays the member Key, instead of the (group, element).
761 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
762 - src/gdcmDocEntrySet.h:xi
763 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
764 -- now has a new BaseTagKey member.
766 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
767 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
769 This poses the problem with the semantics of the following lines
770 LoadEntryVoidArea(0x0028,0x1201); // R LUT
771 LoadEntryVoidArea(0x0028,0x1202); // G LUT
772 LoadEntryVoidArea(0x0028,0x1203); // B LUT
773 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
774 to the long FIXME note for what the problem is. Nevertheless in
775 order to get things working the dicom dictionary was altered !
776 Please fix things urgently...
777 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
778 information), see above note on moving the member VoidArea. Nevertheless
779 the following entries previously correctly set as US are now inproperly
781 0028 1201 OW IMG Red Palette Color Lookup Table Data
782 0028 1202 OW IMG Green Palette Color Lookup Table Data
783 0028 1203 OW IMG Blue Palette Color Lookup Table Data
784 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
785 of gdcmDocEntry moved to gdcmSeqEntry.
786 * src/gdcmSeqEntry.cxx: STYLE.
788 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
789 * Test/TestAllEntryVerify.cxx minor fix and added comments.
791 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
792 * gdcmPython/testSuite.py: all the test suite in python is now moved
793 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
794 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
795 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
797 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
798 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
799 to avoid inclusion recursion until STL is reached.
800 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
801 mecanism. errno.h is not included in gdcm anymore.
802 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
803 (gdcmFormatError now inherits from gdcmFormatUnexpected).
805 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
806 gdcmData/TestAllEntryVerifyReference.txt
807 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
808 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
809 exception_on_error parameter.
810 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
811 - vtk/vtkGdcmReader.cxx changed accordingly,
812 - Example/*.cxx and Test/*.cxx changed accordingly.
814 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
815 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
816 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
817 enable_sequences removed from gdcmHeader constructor and dependencies.
818 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
819 * gdcmPython/demo/PrintHeader.py: dummy fix.
820 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
821 skip_shadow removed from gdcmHeader constructor and dependencies.
822 * Example/*.cxx and Test/*.cxx changed accordingly.
824 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
825 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
826 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
828 2004-07-21 Jean-Pierre Roux
829 * FIX Now, Parsing and Printing a DICOMDIR do work!
830 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
832 2004-07-20 Jean-Pierre Roux
833 * FIX Some brain damaged headers have Zero-Lenght fields
834 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
836 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
837 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
838 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
839 variable (instance of gdcmDebug) by a definition macro, and the instance
840 is now in static in the gdcmDebug class
841 * src/gdcmSQItem.h : (FIXME) remove an undefined method
842 * Test/PrintAllDocument.cxx : bug fix in the result of the test
844 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
845 * WARNING: ctest now depends more tightly on gdcmData. You should
846 check out gdcmData properly for things to run smoothly...
847 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
848 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
849 we need the pixels not be loaded in order to use the ValEntry
850 that displays position and size).
851 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
852 This is a C++ based equivalent of gdcmPython/testSuite.py that should
853 be deprecated. If you have any doubts about the advantages of a
854 modern scripting language (read Python) versus grass root C++ (i.e.
855 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
856 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
857 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
858 Anyhow, consider documenting the gdcmData images in
859 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
861 * Test/CMakeLists.txt:
862 - now uses TestAllEntryVerify.cxx
863 - specific comments on oldACR00001.ima (now renamed in gdcmData
864 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
865 gdcmData/TestAllEntryVerifyReference.txt
868 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
869 * src/*.[h|cxx] : typedef clean up
870 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
871 - TagKey renamed to gdcmTagKey (for external usage)
872 - VRKey renamed to gdcmVRKey (for external usage)
873 - removal of typedef duplication.
874 - Removed all unecessary inline keyword from class inline definitions.
875 - Some method|function(void) declarations replaced with method|function().
876 * src/jpeg/libijg12/jdhuff12.c:
877 - printf polluting ctest removed.
878 - TAB removal for comminting
880 - TestAllReadCompareDicom.cxx: added a test that compares all the
881 images in gdcmDataImages.h with corresponding images in
882 gdcmData/BaselineDicom/. When baseline images are not present
883 this test creates them.
884 Note: we need to validate each reference image, but before that
885 I'd like to rename them with a more explicit name...
886 - CMakeLists.txt: changed accordingly.
887 * Example/*.cxx: examples now only include gdcm.h (as opposed to
888 including each header needed).
890 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
891 * Test/*.cxx and Example/*.cxx: moved some examples away from the
892 test suite to the Example directory. Are concerned:
897 - TestWriteSimple.cxx
898 * Test/CMakeLists.txt: added some comments on reasons for black listing
899 image gdcmData/oldACR00001.ima
901 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
902 * Test/CmakeList.txt: removed the following from black list (to be coherent
903 with removal from gdcmData):
904 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
905 - gdcm-MR-PHILIPS-16.dcm
907 Added the following because after last cvs update, they cause
908 ctest -R TestReadWriteReadCompare
910 - gdcm-MR-SIEMENS-16-1.acr
912 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
913 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
914 new comments in this file) we temporarily (sigh) move to a weaker
916 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
917 we don't need to black list the following images anymore:
918 - 8BitsUncompressedColor.dcm
920 - US-PAL-8-10x-echo.dcm
921 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
922 fixes and the beautified code ;-)
923 This fixes the bug introduced in version 1.42 (when beautifying)
924 that made the parsing of 8BitsRunLengthColor.dcm unproper.
925 Note: ctest was blind to this bug (this means we need to still
926 improve the test suite). The bug could be detected by using
927 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
929 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
930 and by displaying the (garbage) produced file temp.XDCM...
932 2004-06-29 Jean-Pierre Roux
933 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
934 - replace by uggly but working old code :-(
935 A lot of things should be OK again.
936 It's really urgent to have a test suite that *tests*,
937 to prevent Frog's beautifying sessions to break all the stuff
938 (twice, withing a fortnigh ...)
940 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
941 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
942 redundancy) to added Test/TestReadWriteReadCompare.cxx
943 * Test/CmakeList.txt: because the compare test of
944 Test/TestReadWriteReadCompare.cxx fails, the following images are
945 black listed: - 8BitsUncompressedColor.dcm
947 - US-PAL-8-10x-echo.dcm
948 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
949 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
950 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
951 and ad-hoc kludge. This kludge is now removed, and on encountering
952 such an image (OB field brain damaged) we set errno. Then in
953 ::FindDocLength() we "fix" the length as being ALL what remains
954 in the file (until EOF). We then proceed, hoping for the best...
955 This fixes a SegFault in ShowDicom when trying to write such an
957 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
958 (because TestWriteRead breaks on it, after a non conformal commit?).
959 ctest now runs properly, except for MakeDicomDir (which was allways
960 broken) and the Python related stuff (still not fixed).
962 2004-06-24 Jean-Pierre Roux
963 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
964 FIX : Test/TestReadWrite now iterates on all the file names
965 (instead of infinite loop)
966 ENH : Test/TestWriteRead now iterates on all the file names
968 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
969 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
971 2004-06-24 Jean-Pierre Roux
972 FIX : - now Write drops LUT Descriptors and LUTs (if any)
973 when SamplesPerPixel =3
974 - now Write is no longer confused by
975 'BitsAllocated = 12" and 'BitsStored=12"
976 - "UN" value representation Elements are now written correctly
977 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
978 ENH : - now gdcmHeader has its own Write methods
979 (in order to split the job that has not to be done
982 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
983 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
984 loop on the same image until memory went out.
985 Note: this means we still have gobs of memory loss in PrintDocument
986 * src/gdcmDocument.cxx: fixes problem on parsing on file
987 gdcmData/16BitsJpegLosslessGrayScale.dcm.
989 2004-06-24 Jean-Pierre Roux
990 FIX : Write - All the Sequences and Sequence Item are now written
991 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
992 is added a the end, when necessary.
993 - A lot of brain-damaged images, that were read correctly are
994 now written correctly
995 - length compatible BinEntry are now loaded correctly
996 (even for odd groups)
997 Note : only Explicit Value Representation was checked.
998 (question : is implicit VR really necessary for gdcm ?)
1000 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1001 * DEVELOPPER: added a proposition of coding style.
1002 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1005 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1006 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1007 Use the gdcmDocEntry::Print() and Write() instead.
1008 * src/gdcmDocument.cxx: bug fix.
1010 2004-06-22 Jean-Pierre Roux
1011 FIX : gdcmDocument.cxx
1012 - Now we do recognize the JpegLossLess format (there was a misstyping in
1013 code 'beautyfication' :-(
1014 - Now we automaticaticaly load the Luts, if any
1016 2004-06-22 Jean-Pierre Roux
1017 In order : to write Sequences, whatever their imbrication level,
1018 : to allow user to create his own Sequences
1019 a lot of modif where necessary (adding, moving, or virtualising methods)
1021 WARNING : save your own sources *before* cvs up !
1024 ADD virtual void Write(FILE *fp, FileType filetype);
1027 ADD virtual void Write(FILE *fp, FileType filetype);
1028 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1031 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1032 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1033 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1034 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1035 ADD std::string GetEntryByName(TagName name);
1036 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1038 std::string vr = "unkn",
1039 std::string fourth = "unkn",
1040 std::string name = "unkn");
1041 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1042 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1043 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1044 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1045 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1046 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1047 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1048 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1051 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1052 ADD virtual std::string GetEntryByName (TagName tagName);
1053 ADD virtual std::string GetEntryVRByName (TagName tagName);
1054 REM virtual bool Write(FILE *, FileType);
1055 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1056 FILE *_fp, FileType type);
1057 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1058 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1059 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1060 REM virtual std::string GetEntryByName (std::string tagName);
1061 REM virtual std::string GetEntryVRByName (std::string tagName);
1062 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1063 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1064 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1066 std::string vr = "unkn",
1067 std::string fourth = "unkn",
1068 std::string name = "unkn");
1069 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1070 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1071 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1072 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1075 ADD virtual void Write(FILE *fp, FileType filetype);
1078 ADD virtual void Write(FILE *fp,FileType filetype);
1081 ADD virtual void Write(FILE *fp, FileType filetype);
1082 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1083 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1084 REM std::string GetEntryByName(TagName name);
1087 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1089 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1090 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1091 The default constructor invoked by the line
1092 gdcmHeader *f1 = new gdcmHeader( header );
1093 was gdcmHeader::gdcmHeader(bool) instead of the expected
1094 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1095 Hence the parsing wasn't executed... See also below.
1096 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1097 as explicit constructor didn't do the trick to fix the above problem.
1098 Could anyone explain why ?
1099 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1100 properly calls gdcmValEntry::Print() (that was weed out from
1101 code related to gdcmBinEntry).
1103 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1104 * In order to fix memory leaks:
1105 - Test/TestWriteSimple.cxx: added cleaning of free store through
1107 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1108 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1109 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1110 (through the call to ::AddDicomDirMeta()) or the destructor
1111 would crash when deleting uninitialized ::metaElems].
1112 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1113 - src/gdcmDocument.cxx:
1114 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1115 from dynamic stores.
1116 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1117 was causing memory leaks.
1118 - src/gdcmSQItem.cxx:
1119 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1120 cleanly handled with polymophism: sorry but my milage is low).
1121 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1122 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1123 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1124 This avoids SegFaulting.
1125 - src/gdcmSQItem.h: coding style.
1127 - Test/TestWriteSimple still severely sucks. The output image content
1128 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1129 damaged when displayed with vtkgdcmViewer.
1130 - on memory leaks: TestWriteSimple leaks really less (see entry
1131 of 2004-06-18 in Changelog file for the call to valgrind).
1132 - on segfaults: ctest now passes all the tests but one (no more
1134 * Erroneous leading white fix:
1135 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1136 white[s] (as opposed to from >> xxx, that removes it [them].
1137 - src/gdcmTS.cxx: ditto.
1138 - gdcmPython/testSuite.py: dirty related kludge removed.
1139 * src/*: remaining references to gdcmParser removed.
1140 * src/*[cxx|h]: added copy[way]left header.
1143 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * In order to fix writing of dicom files:
1145 - Test/TestWriteSimple.cxx: a simpler example of writing.
1146 - Test/CMakeLists.txt changed accordingly.
1147 - src/gdcmDocument.cxx:
1148 -- The destructor now recursilvely removes potential sequences.
1149 -- Bug fix in ::IsJPEG2000()
1150 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1151 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1153 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1154 to only declared) and build on top of
1155 ::GetDocEntryByNumber(guint16, guint16).
1156 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1157 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1158 for usage in destructor and treatement of promotion in
1159 ::ReplaceOrCreateByNumber().
1160 - src/gdcmSQItem.cxx: destructor should better handle his job.
1161 Test/TestWriteSimple now runs (or at least it DOES something).
1162 * We can now start hutting memory links. A good starting point is:
1163 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1164 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1165 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1167 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1168 * Valgrind note: after Mathieu Malaterre teached me how to read
1169 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1171 Using gcc, you can force the STL to use malloc and to free memory as
1172 soon as possible by globally disabling memory caching.
1173 With 3.2.2 and later, you should export the environment variable
1174 GLIBCPP_FORCE_NEW before running your program.
1175 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1176 simply vanish (it is still not clear to me, whether this means that
1177 STL std::string leaks or if valgrind believes it leaks...).
1178 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1179 running bin/gdcmTests makeDicomDir):
1180 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1181 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1183 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1184 SegFaulting (I drowned in DicomDir related code when trying to
1185 understand why the list is empty...).
1186 * src/gdcmDocument.h: first BSD license header try.
1187 * Doc/License.txt added.
1189 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1190 * src/gdcmDocument.[h|cxx]:
1191 - Clean up of the Transfer related predicates. They are now all based
1192 on new method isGivenTransferSyntax, that (should) handle properly
1193 the padding problem.
1194 - general clean up, simplification, and coding style.
1195 - Specific clean up of Parse7FE0() (umproperly named actually).
1196 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1198 2004-06-14 Jean-Pierre Roux
1200 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1201 - fix the display of SQItem ordinal number
1202 - add the GetSQItemByOrdinalNumber method
1203 - remove some useless never written private methods
1205 2004-06-14 Jean-Pierre Roux
1207 - adding a constructor taking a gdcmDocEntry as an input param
1208 - ReplaceOrCreateByNumber now returns :
1209 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1210 a gdcmValEntry * if a string value is passed as a param
1212 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1213 according to the param type (no longer sets a gdcmDocEntry)
1214 - GetValEntryByNumber, GetBinEntryByNumber added
1215 - NewValEntryByNumber and NewBinEntryByNumber added
1217 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1219 - GetSQItemNumber and SetSQItemNumber added, to provide
1220 a (relative) Item identier inside a given Sequence
1221 \warning : some pb remaining around this number
1223 - AddEntry now takes the Item Number as a param
1225 - adding a constructor taking a gdcmDocEntry as an input param
1227 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1228 * Memory leak hunt with the following command:
1229 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1230 --show-reachable=yes gdcmTests PrintDocument
1231 It looks like many (all?) leaks are due to the STL (or a bad usage
1232 of the STL. The lines producing the leaks now have a comment with
1233 a "MEMORY LEAK" tag: you can retrieve them with
1234 grep "MEMORY LEAK" src/*
1235 Here are two typical examples which I can't help fixing:
1240 char * test = "babo";
1241 name = test; //// <--- valgrind detects 960 bytes lost in
1242 //// call to std::string::operator=(char const*)
1243 name.clear(); //// Doesn't help !
1251 std::cout << "Type a bunch of characters followed by RETURN: ";
1252 getline(std::cin, line); //// <--- valgrind dectects a loss
1253 //// of 1320 bytes in call to
1254 /// std::basic_istream<>& std::getline<>
1260 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1261 * src/gdcmHeader.[cxx|h]:
1262 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1263 and related, moved away to gdcmDocument.
1264 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1265 the corresponding protected accessors of inherited class
1266 gdcmDocument, removed ! As a consequence gdcmFile had to be
1267 declared friend of class gdcmDocument (see below).
1268 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1269 - Clean up of undefined or unused methods.
1270 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1271 account the changes to gdcmHeader.h).
1272 * src/gdcmDocument.h:
1273 - gdcmFile is now a friend class (in order to take into account the
1274 changes to gdcmHeader.h).
1275 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1276 (see changes to gdcmHeader.h).
1277 - Accessors (reading on the form GetEntry*) are now public.
1278 - Clean up of undefined or unused methods.
1279 * src/gdcmDocument.cxx:
1280 - adaptation to changes to gdcmDocument.h
1281 - ::OpenFile now writes a verbose message when file cannot be opened.
1282 - some std::string properly set to VRKey
1283 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1284 references to gdcmDocument.
1285 * Test/TestFindTags.cxx: changed accordingly to above changes.
1286 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1287 cvs repository gdcmData.
1289 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1290 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1291 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1292 conflicts with gdcmValEntry::voidArea.
1293 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1294 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1295 Value representation between StringRepresentable and BinaryRepresentable.
1296 * src/gdcmDocument.cxx:
1297 - method ParseDES: proper indentation restored and usage of
1298 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1299 - method LoadDocEntry: the fingerprint left in the SetValue() of
1300 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1301 removed. Reverting to previous code segment with the proper
1302 dynamic_cast< gdcmValEntry* >.
1303 Note: this was (partially) breaking the python test suite
1304 (gdcmPython/testSuite.py) that made usage of the above
1305 fingerprint to check presence of "Pixel Data".
1306 * src/gdcmDocEntry.h: coding style.
1307 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1308 now taken into account.
1309 * gdcmPython/gdcm.i: adaptation to the new internal representation
1310 of gdcm (exit gdcmParser, hello gdcmDocument).
1311 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1313 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1314 anymore, but instead prints the loaded Python dictionary.
1315 * .... alas, the python testSuite is still broken.
1317 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1318 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1320 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1321 * src/gdcmUtil.h : export methods
1323 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1324 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1326 * Initial addition of automatic python testing
1327 * Initial addition of automatic image comparison
1329 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1330 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1331 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1333 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1334 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1335 * Test/ShowDicom.cxx : bug fix for msvc compilation
1336 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1338 2004-05-04 Jean-Pierre Roux
1339 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1340 new concepts (and new classes) :
1341 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1342 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1343 - Sequence Doc Entries (gdcmSeqEntries)
1344 a Sequence is composed of Items.
1345 Each item is a set of Doc Entries (this is recursive)
1346 The non uniqueness of the 'Dicom tag' is due to this recursivity
1347 (never taken into account)
1348 Our unability to add a new 'entry' in the header
1349 at the proper location (neither in the H-Table (map or multimap),
1350 nor in the Chained List is also due to this recursivity.
1351 Don't try, right now, to use/modify/compile these new sources :
1352 nothing is finished.
1353 We just commit all the stuff, 'as is', in order not to loose it.
1355 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1356 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1358 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1359 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1360 file prefix (SetFilePrefix)
1362 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1363 * Add a new test: ShowDicom, for now this is just the c++ version of
1364 checkRead.sh, later it will be able to compare the image read against a
1366 * Replace the DEBUG on the stack with a global entry in cmake interface:
1367 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1369 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1370 * Add an example subdir, with a real example on how to read + write a
1373 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1374 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1375 * Doc/CMakeLists.txt: the main page is now properly differentiated
1376 between the developper and user version.
1377 * Doc/doxygen.config.in: dropped search related obsolete flags
1378 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1380 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1381 * DEVELOPPER: added some helpfull comments for compile/test/install
1384 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1385 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1386 src directory, now generated in the build dir.
1387 2. Tests as mentionned smarter
1389 4. Add a new method in gdcmDict that return the PubDict by name
1390 this is interesting for 3rd party lib like ITK,
1391 where we could set the institution name / patient name...
1393 * ENH: 1. Now the test suite is working for real
1394 2. All binaries are now output in the gdcm-bin directory
1395 (this was not true before)
1397 2004-04-28 Jean-Pierre Roux
1398 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1399 SeQuence indented printing of Dicom Header.
1400 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1401 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1402 Computation of SQDepthLevel is now part of gdcmHeader constructor
1403 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1404 tree-like structure of a Dicom Header.
1405 * FIX Test code cleaning
1407 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1408 * ENH: Adding automatic testing
1409 1. Need a DartConfig.cmake to submit to public
1410 2. Add a test driver gdcmTest.cxx
1411 3. gdcmTestMain, an helper for the main test driver gdcmTest
1412 4. Files in Test don't have a main anymore, this becomes interesting
1413 when we add more and more tests, thus dsw don't have to load
1415 * ENH: Adding a GDCM_DATA_ROOT for testing
1416 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1417 one file instead of seven + some small cleanup
1419 2004-04-22 Jean-Pierre Roux
1420 * ENH Minor changes to the Print() methods.
1421 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1422 Header printing. Example given with :
1423 > PrintHeader fileName 2 new
1424 (SQ based tree-like structure still to be done for the Header ...)
1426 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1427 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1428 1. I have added some unsigned where needed
1429 2. Some function parameter not used -> (void)
1430 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1431 4. g++ don't like character '\' in comment
1432 5. #define jpeg_create_decompress jCreaDecompress
1433 this really need to be fixed
1434 6. virtualize destructor of gdcmObject ... leakage
1435 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1436 this also really need to be fixed
1437 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1438 remove compression file
1439 (as we only do decompression, right ?)
1440 * ENH: Change malloc/calloc/free with c++ equivalent
1442 2004-04-21 Jean-Pierre Roux
1443 * FIX gdcmHeaderHelper::GetXSpacing
1444 when a single value is found (bug ?), xpacing is now
1445 defaulted to yspacing
1447 2004-04-19 Jean-Pierre Roux
1448 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1449 * ENH add parameters :
1450 bool exception_on_error = false,
1451 bool enable_sequences = false,
1452 bool ignore_shadow = false
1453 to the gdcmFile constructors to be full gdcmParser compliant
1454 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1455 to allow reading of PAPYRUS 3.0 files
1457 2004-04-06 Jean-Pierre Roux
1458 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1460 2004-04-02 Jean-Pierre Roux
1461 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1462 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1463 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1465 2004-03-30 Jean-Pierre Roux
1466 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1467 for ACR file, written out as DICOM files (hope so...)
1469 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1470 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1471 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1472 moved to base class gdcmParser and only the specialisation is kept
1474 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1475 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1476 already does the job.
1477 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1478 (to be consistent with gdcmParser::WriteEntries).
1480 2004-03-30 Benoit Regrain
1481 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1482 upate of the object's instance. It's passed to 2 in the unfavorable
1483 case : one in the ExecuteInformation, one in the ExecuteData
1485 2004-03-29 Jean-Pierre Roux
1486 * ENH : Check on file type to be written moved
1487 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1488 * FIX : gdcmObject::ResetBoundaries now stops properly
1489 when end-of-list is reached
1490 : gdcmVersion modified (as Benoit Regrain asked)
1492 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1493 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1494 * src/gdcmUtil.cxx: added forgotten iostream include.
1495 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1496 equivalent to ExplicitVR in existing code).
1498 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1499 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1500 now contains all the gdcmGlobal related code.
1501 * minor coding style and doxygenation changes.
1503 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1504 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1505 now contains all the Debug related code.
1506 * minor clean-up of includes in src/*.cxx
1507 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1508 CreateCleanString) removed.
1509 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1510 * Doc/DoxyMainPageUser.txt added.
1511 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1512 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1513 src/gdcmDirList.cxx)
1515 2004-03-24 Jean-Pierre Roux
1516 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1518 2004-03-23 Jean-Pierre Roux
1519 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1520 big endian made volumes
1521 * ENH Now gdcmParser constructor and destructor are protected to forbid
1522 end user to instanciate class gdcmParser
1523 (only gdcmHeader and gdcmDicomDir are meaningfull)
1525 2004-03-22 Benoit Regrain
1526 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1527 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1528 gdcmSerie to gdcmDicomDirSerie
1530 2004-03-19 Jean-Pierre Roux
1531 * ENH Now the tree-like structure describing a DICOMDIR comming from
1532 an already existing DICOMDIR file is consistent with
1533 the home-made tree-like structure build ex-nihilo
1534 or build from the files held (recursively) in a Directory
1535 functions gdcmDicomDir::CheckBoundaries()
1536 gdcmObject::SetBoundaries() added
1538 2004-03-17 Jean-Pierre Roux
1539 * REM (Eric Boix bug) : removal of meaningless
1540 gdcmDicomDirImage::NewImage function.
1541 * FIX now file names and directory name are written properly in the
1543 * FIX now gdcmDicomDir constructor may be call without any trick
1546 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1547 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1548 of gdcmDicomDirImage::NewImage as empty function.
1550 2004-02-28 Jean-Pierre Roux
1551 * ENH add gdcmDicomDir:NewPatient
1552 add gdcmDicomDirPatient:NewStudy
1553 add gdcmDicomDirStudy:NewSerie
1554 add gdcmDicomDirSerie:NewImage
1555 to allow making gdcDicomDir object.
1556 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1557 (as opposite to the gdcmHeader chained list)
1559 2004-02-11 Benoit Regrain
1560 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1561 when using from python
1563 2004-02-10 Benoit Regrain
1564 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1565 * FIX : in gdcmDicomDir when the directory is empty
1566 * ENH : add callback and methods to get the progression of dicomDir
1569 2004-02-06 Jean-Pierre Roux
1570 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1571 - GDCM_META added to gdcmDicomDirType
1572 - class gdcmMeta created
1573 * ENH : - A brief summary is now displayed at the beginning of
1574 'testDicomDir' to help disaster magnitude estimation
1575 * REM : Now useless Test/explDICOMDIR.cxx
1577 2004-02-05 Benoit Regrain
1578 * ENH : add methods in gdcmObject to get the hash table or the list of
1580 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1581 * FIX : wrapping python for TagHeaderEntryHT
1583 2004-02-04 Benoit Regrain
1584 * FIX : even length for some strings when writting the dicom dir
1585 * FIX : sort the images in the dicom dir
1586 * FIX : Bug fix for python use of dicom dir
1587 * ADD : a python demo
1589 2004-02-04 Jean-Pierre Roux
1590 * FIX : Final solution (?) for icone embedded images
1591 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1592 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1593 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1594 gdcmData/gdcm-MR-SIEMENS-16.acr1
1595 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1596 to make full checking easier
1598 2004-02-04 Benoit Regrain
1599 * FIX : WriteEntries : coding style & logic in parameters
1600 * FIX : Set the elements to create the DicomDir in a dictionary file
1602 2004-02-03 Benoit Regrain
1603 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1604 * gdcmDicomDir : add the load of directory
1605 * Bug fix and print add-on
1607 2004-02-03 Jean-Pierre Roux
1608 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1609 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1610 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1611 * FIX gdcmParser.cxx : 'group length' elements are now considered
1612 as integers, even for shadow groups, when file is Implicit VR
1614 2004-02-02 Jean-Pierre Roux
1615 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1617 of the last synonym :-(
1618 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1620 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1621 * FIX taking into account the possible 7fe0,0010 multiplicity
1622 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1623 to allow removal of references to 7fe0,0010, to deal with
1624 ACR-NEMA images, when 0028,0200 is meaningfull
1626 2004-01-31 Jean-Pierre Roux
1627 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1628 no longer writes 'Un' on disk
1629 * FIX SQ elements with actual length are now dealt with corectly
1630 * FIX gdcmFile::WriteBase make the difference, for color images, between
1631 the length (for Palette expanded images)
1632 and Raw Length (non expanded image + Palette)
1633 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1634 (that broke Write). Replaced by UL.
1635 Aware user will reload the field if he
1636 thinks it's necesssary
1638 2004-01-30 Jean-Pierre Roux
1639 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1640 when 'dirty Acr' is found, to be compliant with the new
1641 IsReadable() methods.
1643 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1644 (no DOUBLE images in kosher DICOM,
1645 but so usefull for people that miss them ;-)
1647 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1648 DICOMDIR related utilities (not checked as Windoze compliant)
1650 2004-01-28 Jean-Pierre Roux
1651 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1653 2004-01-27 Jean-Pierre Roux
1654 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1655 to allow skipping the shadow elements, to save memory space.
1656 The TRUE value for this param has to be used
1657 with a FALSE value for the 'enable_sequence' param.
1658 ('public elements' may be embedded in 'shadow Sequences')
1659 * gdcmHeader methods now deal with 'embedded icones images' in the header
1660 (even when an 'icone image sequence' is announced by the
1661 element (0x0088,0x0200), but there is NO icone at all ...
1663 * gdcmHeader sometimes Image Location value doesn't follow
1664 the supposed processor endianity (see gdcmData/cr172241.dcm).
1667 * gdcmHeader add the method
1668 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1669 to get *all* the Header Entries with the same tag.
1670 GetHeaderEntrySameName is probabely *useless*
1671 (no meaning : Name is *not* an identifier within the Dictionnary)
1673 2004-01-26 Benoit Regrain
1674 * Bug fix in the print of hexadecimal representations. Remove long fields
1675 in the print and add a third level of print to print them
1677 2004-01-23 Benoit Regrain
1678 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1679 * Bug fix on test suite after remove the strip made on not string fields
1680 * Split the IsReadable method between gdcmParser which test that the file
1681 is dicom and gdcmHeader which test that it's an image file
1683 2004-01-22 Benoit Regrain
1684 * DicomDir : clean code, add methods, set variables in protected or private
1685 * gdcmUtil : bug fix for the clean string method
1687 2004-01-19 Benoit Regrain
1688 * Add the use of shadow dictionaries
1689 * bug fix and coding style
1691 2004-01-19 Benoit Regrain
1692 * src/gdcmFile.cxx : bug fix concerning the close of file
1693 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1694 * Add the update of header entries using the shadow library
1696 2004-01-19 Benoit Regrain
1697 * removal of file gdcmHeader2.cxx
1698 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1699 inheriting from gdcmParser. This split is to prepare the integration
1700 of dicom dir parsing
1701 * bug fix under python
1703 2004-01-16 Jean-Pierre Roux
1704 * REM removal of class gdcmHeaderEntrySet
1705 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1706 * ADD add file gdcmHeader2.cxx
1707 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1709 2004-01-15 Benoit Regrain
1710 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1711 entries created while parsing the header. Thus, they will be destroyed
1712 when the gdcmDictSet will be destroyed
1713 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1716 2004-01-15 Benoit Regrain
1717 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1718 made a fatal error because of the memory release at the end of program.
1719 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1720 some memory and vtk seems to have some problems with that.
1721 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1723 2004-01-14 Benoit Regrain
1724 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1725 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1726 * src/*.[h|cxx] : make changes due to class name changes
1727 * gdcmPython/demo/*.py : bug fix due to method names
1729 2004-01-13 Benoit Regrain
1730 * src/*.[h|cxx] : coding style
1731 * vtk/*.[h|cxx] : coding style
1733 2004-01-13 Benoit Regrain
1734 * gdcmPython/testSuite.py : test the readable flag of file for tests
1735 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1736 It's lied to the stl compilation by MSVC (windows, always windows...)
1737 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1739 2004-01-12 Benoit Regrain
1740 * src/*.h : add comments
1741 * src/gdcmDictSet.h : set the method BuildDictPath in public
1742 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1743 directly setted in the source code
1744 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1747 2004-01-09 Benoit Regrain
1748 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1749 * setup.py : use a reference to gdcmVERSION
1751 2004-01-07 Benoit Regrain
1752 * Modification to compile with the distutils.
1755 2003-12-10 Benoit Regrain
1756 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1757 can use a gdcmHeaderHelper to load datas
1758 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1759 made in the source code
1761 2003-12-10 Benoit Regrain
1762 * Update Windows projects and .cvsignore files
1764 2003-11-12 Jean-Pierre Roux
1765 * ENH gdcmHeader constructor has one more parameter (default value : false)
1766 that allows the user to 'go inside' the SeQuences only
1768 gdcmElValSet:Print takes it into account
1770 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1771 * ENH: Update gdcmPython/CMakeLists
1772 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1773 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1775 2003-11-10 Jean-Pierre Roux
1776 * FIX : gdcmHeader::LoadElements is now based
1777 on the ListTag listElem member,
1778 not longer on the TagElValueHT tagHt member
1779 * ENH : PrintPubElVal shows (temporarily) both results,
1780 with the tagHt member and the listElem member.
1781 (it's easier to 'see' the problems when using Printheader)
1783 * FIX : old private member LgrElem is now splitted into
1784 ReadLength : Length actually found on disk (updated only
1785 if bug fixing is necessary), for internal
1787 UsableLength : Updated by FixFoundLength, to fix a bug
1788 or to allow Parser going on.
1789 Will allow to re-write a kosher header when a SeQuence
1790 with a length (not 0000) is found
1791 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1792 because gdcmElValSet::Add does not update ListElem
1795 2003-11-07 Jean-Pierre Roux
1796 * FIX misstyping in Transfert Syntax name table
1797 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1798 when they have an actual length (not 0000 nor FFFFF)
1799 (Nobody should care of it, but DICOMDIR explorers)
1801 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1802 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1804 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1805 * ENH: vtkGdcmReader now supports LUT !
1806 (vtkgdcmViewer for now is not able to use them though)
1808 2003-11-05 Jean-Pierre Roux
1809 * in testSuite.py : new files names for checking the package
1810 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1811 that returns the pixel area size to the *aware* (vtk) user
1812 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1814 2003-11-05 Benoit Regrain
1815 * in testSuite.py : Modify the rules for checking the paths
1816 : Explicit error messages
1817 * in __init__.py : Related modif
1819 2003-11-03 Jean-Pierre Roux
1820 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1821 to be used by aware (vtk) users that want to manage
1822 LUT (and no to turn the PALETTE image into an RGB pixels one)
1823 * GetPixelType now returns 8U for 24 Bits images
1824 (vtkGdcmReader compliant)
1826 2003-10-31 Jean-Pierre Roux
1827 * Removal of *all* gdcmData images and add them again
1828 in order to loose the 'history' of un-anonymised images
1830 2003-10-31 Jean-Pierre Roux
1831 * RMV : removal of useless jBitsInJsample.h
1832 for both 8 and 12 Bits JPEG Lossy Libraries
1834 2003-10-31 Jean-Pierre Roux
1835 * ENH : Add the functions gdcmFile::GetImageDataRaw
1836 gdcmFile::GetImageDataIntoVectorRaw
1837 that act as GetImageData and GetImageDataIntoVector
1838 except the making of an RGB Plane from Gray Plane + LUT
1839 Intended to aware (vtk) users who know how to manage
1842 GetLUTRGBA return a R,G,B,A LUT if any
1843 lgrTotaleRaw gives the 'Raw' length
1844 GetImageDataRaw returns the gray Plane
1845 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1846 (They stay Grey, just like with other Dicom viewers :-(
1848 2003-10-30 Jean-Pierre Roux
1849 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1851 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1852 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1853 being coherents dicom files.
1855 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1856 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1858 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1859 * ENH: Two steps is necessary to please VC++ compiler...
1860 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1861 * ENH: Add include dir to medcon lib
1862 * FIX: only one function is being exported for now !
1863 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1865 2003-10-29 Jean-Pierre Roux
1866 * adding gdcmHeader::GetLUTRGBA
1867 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1868 --> Mathieu, the modif u're waiting for is not yet committed
1869 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1871 2003-10-27 Jean-Pierre Roux
1872 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1873 00191113.dcm DermaColorLossLess.dcm
1874 MxTwinLossLess.dcm RadBWLossLess.dcm
1875 * ENH: For version prior to vtkImageViewer2 -r 1.19
1876 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1878 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1879 * Removal of ido stuff in CMakeLists.txt
1881 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1882 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1883 * FIX: remove a call to ->Modified ... see comments
1884 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1886 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1887 * FIX: Problem with path for libvtkgdcmPython
1888 * ENH: Try adding a search script for python site-package
1889 * RMV: Remove some file from medcon lib that are not necessary
1890 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1891 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1892 * FIX: More pragma disable fro VC++,
1893 I don't think I break something as it is also disable in VTK/ITK.
1894 But it fasten debug compilation time.
1896 2003-10-23 Jean-Pierre Roux
1897 * gdcm now deals with 16 Bits Run Length Encoded images
1898 (they are compressed as 2 planes images,
1899 one for the high Bytes, the other for low Bytes)
1901 2003-10-22 Jean-Pierre Roux
1902 * Now CheckRead takes into account :
1903 - the bugged 'Leonardo' Siemens images
1904 - the XA images, sent thru the burning VPRO station
1905 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1908 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1909 * FIX: When copying a Makefile.am to CMakeLists.txt
1910 one should remove the '\'
1912 2003-10-22 Jean-Pierre Roux
1913 * in gdcmData adding a bugged 'Leonardo' Siemens image
1914 (wrong lengths in header)
1915 OK with gdcm, KO with the other viewers :-)
1916 * add a GE dlx XA image, thru the VEPRO burning station
1919 2003-10-21 Jean-Pierre Roux
1920 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1921 for a brutal checking of vtkgdcmViewer compliance
1923 2003-10-21 Jean-Pierre Roux
1924 * add the files for 'xmedcon' Jpeg Lossless library
1925 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1927 2003-10-21 Jean-Pierre Roux
1928 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1930 2003-10-21 Jean-Pierre Roux
1931 * garbage Siemens 'Leonardo' images dealt with
1932 (the patch is easy to remove)
1933 * cosmetic changes to avoid warnings
1935 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1936 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1937 no need to press 'r' now.
1939 2003-10-20 Jean-Pierre Roux
1940 * upgrade of checkRead.sh checkWrite.sh according
1941 to new Jpeg Lossless decompressor
1942 * add US.3405.1.dcm, a genuine RGB medical file ...
1943 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1944 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1946 2003-10-15 Jean-Pierre Roux
1947 * general anonymisation in gdcmData
1948 * adding the 'color files' from
1949 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1950 * adding some well knowed bugged-header images
1951 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1952 waiting for their inclusion in Python testsuite
1954 2003-10-15 Jean-Pierre Roux
1955 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1956 no longer seg faults when file is not found
1958 2003-10-14 Jean-Pierre Roux
1959 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1962 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1963 * TODO: *.in file to genereate a UseGDCM later
1965 2003-10-14 Jean-Pierre Roux
1966 * Some supposed-to-be Dicom Images have no preamble.
1967 OpenFile takes it into account
1968 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1969 * Missing elements added in dicomV3.dic
1970 (just to be affraid : have a look at
1971 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1972 and do it again next year ;->
1974 2003-10-13 Jean-Pierre Roux
1975 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1976 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1977 But there are NOT. It's fixed !
1979 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1980 * FIX: "jpeglib.h" was not found on VC++
1981 * FIX: vtkgdcm was not being installed
1983 2003-10-10 Jean-Pierre Roux
1984 * ENH : OpenFile closes the file if it *really* doesn't look like
1985 an ACR-NEMA / DICOM one.
1986 * FIX : testWrite no longer writes an empty file if the source file
1987 is not gdcm Readable
1988 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1991 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1992 * FIX: CMake generate now documentation
1993 * ENH: out of source doc build !
1994 * ENH: Generate both user and dev documentation
1995 * ENH: Should work on windows too
1996 * ENH: Only one doxygen config.in file is needed
1997 * FIX: make install should be ok now on ùnix plateform
1998 * FIX: PATH to dictionary was wrong (missing /)
1999 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2001 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2002 * vtkGdcmReader is now able to read rgb dicom file.
2003 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2004 * added a gdcmViewer to vtk test, use mouse to control
2005 window level & window width
2007 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2008 * CMake-ification of gdcm, we have now two build system
2009 * FIX: on cygwin Wsock32 doesn't exist
2010 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2012 2003-10-06 Emanuel Ollart
2013 * FIX : compilation process wad broken.
2014 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2016 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2017 * change gdcmViewer -> vtkgdcmViewer
2018 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2020 2003-10-06 Jean-Pierre Roux
2021 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2022 ( e.g : well known GE images with a wrong elem length,
2023 : Philips MRI Images with a wrong Huffman table)
2024 * still to be done : allow the reading of bugged LEONARDO Siemens images
2026 2003-10-03 Jean-Pierre Roux
2027 * Odd length strings are padded with '\0' (not with spaces,
2028 to remain compliant with already defined strings,
2029 like Transfert Syntax UID and others)
2031 2003-10-03 Jean-Pierre Roux
2032 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2033 to allow displaying RGB images (not only by affim ;-)
2035 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2036 * vtkGdcmReader is now able to read rgb dicom file.
2037 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2039 2003-10-03 Jean-Pierre Roux
2040 * A few nasty patches to allow the reading of a lot of nasty images
2041 ( e.g : well known GE images with a wrong elem length,
2042 : Philips MRI Images with a wrong Huffman table)
2043 * still to be done : allow the reading of bugged LEONARDO Siemens images
2045 2003-10-03 Jean-Pierre Roux
2046 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2048 2003-10-03 Jean-Pierre Roux
2049 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2050 to allow displaying RGB images (not only by affim ;-)
2052 2003-10-03 Jean-Pierre Roux
2053 * gdcmFile::GetImageDataIntoVector now
2054 - deals with MultiFrames MultiFragments Run Length Encoded files
2055 - deals with YcBcR (YBR_FULL) files
2056 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2057 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2059 (no sample found :-(
2061 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2062 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2063 Two reasons: - clear things
2064 - third parties acces gdcm through header files, so won't
2065 suffer anymore VC++ complains
2067 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2068 * add argv[1] in testvtkGdcmReader.cxx
2071 2003-09-24 Jean-Pierre Roux
2072 * The lines are now eigthy characters long.for
2073 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2075 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2076 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2077 char* to std::string. Thus, the use of strdup becomes useless. (see
2078 previous commis of Malaterre)
2079 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2080 before the last Malaterre's commit.
2082 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2083 * This commit should fix the Debug building under VC++, the problem
2084 was mainly a mixture of debug and release lib being loaded at startup.
2085 * I also remove a depency to a specific C function: strdup. Because I had
2086 to force the link to msvcrtd (whereas strdup is in libc).
2088 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2089 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2090 located in the gdcmCommon.h file. All use of reference of tha has been
2091 changed to now use the variable GDCM_UNFOUND.
2093 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2095 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2096 Dicom dictionary. The test suite can now be run again. Note:
2097 I'm note very happy with the " (RET)" changes. I believe this
2098 RETAINED comment should be dropped when parsing the dictionary.
2099 - PACKAGER corrected
2101 - AUTHORS updated and now in alphabetical order
2102 * Makefile.am now exports gdcm.dsw for Windoze users.
2104 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2105 * cygwin complains about missing std:: in subdir Test/
2107 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2108 * remove some methods that are now in gdcmHeaderHelper
2110 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2111 * vtkGdcmReader set spacing and origin correctly
2113 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2114 * Fix a few delete/delete[] mismatch
2116 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2117 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2118 interpretation to data given by gdcmHeader. For instance there are
2119 heuristics to get informations (look at different places).
2120 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2121 sorting DICOM images based on different strategies.
2122 * modified Makefiles accordingly.
2124 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2125 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2126 when building in debug mode
2127 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2128 src/win32/gdcmdll.dsp
2129 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2131 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2132 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2135 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2136 * src/win32/libgdcmjpeg12.dsp was not dos format
2137 * src/win32/libgdcmjpeg12.dsp :
2138 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2139 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2141 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2142 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2144 * src/gdcmFile.cxx : bug fix in affectation type
2145 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2146 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2147 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2148 symbols... future problem ?
2150 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2151 * src/win32/libgdcmijpeg12.dsp was missing
2152 * modified gdcm.dsw accordingly
2154 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2155 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2157 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2158 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2159 commit of JPR (before his hollidays to facilitate our work).
2160 * setup.py : bug fix in code. Modifications made while the last commit
2161 of JPR. The code hasn't been tested before the commit... it's so
2162 useless to make that (for best programmer that is JPR) !!!
2164 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2165 * tagged the current version as Version0_3 (i.e. version 0.3)
2167 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2168 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2169 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2170 * *.dsp : modifications to use new libgdcmijpeg8 library
2171 * setup.py : bug fix on VTKPATH variable
2172 * PACKAGER : adding all concerning windows
2174 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2175 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2177 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2178 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2179 test suite reported error.
2180 * PACKAGER file added (describes what a packager must do when
2181 packaging a new release).
2182 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2183 * configure.in: upgraded version number to 0.3.0
2184 * fixing build of rpm (through rpm -ta):
2185 - Doc/Makefile.am exports proper doxygen files
2186 - src/jpeg/libijg8/Makefile.am exports the include files.
2188 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2189 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2190 * src/gdcmHeader.h : formatting code
2192 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2193 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2194 We were obtaining error message from vtk. Now, creation of file list
2195 is made in an internal list to prevent this problem.
2196 Bug fix when output is empty.
2197 Bug fix in update of progress value. Previous commit for this was a bad
2199 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2201 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2202 * src/gdcmHeader.h : added method to get the file name
2203 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2204 files. Added method to remove all files on the input
2205 Added FIXME comment concerning the bad parsing of header made by
2206 ExecuteInformation method (in ExecuteData method)
2208 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2209 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2210 when using make instal.
2211 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2212 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2214 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2215 * setup.py : adding include dir of jpeg lib to compile all sources
2216 * */Win32/*.dsp : JPR fix for windows compilation
2218 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2219 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2221 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2222 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2224 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2225 * setup.py is again effective on un*x (takes into account the
2226 addon of the jpeg library)
2227 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2228 * Doc/Doxy* updated (includes above enhancements)
2229 * INSTALL now points to web documentation
2231 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2232 * src/gdcmHeader.h doesn't make unnecessary reference to
2234 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2236 * src/gdcm*.[cxx|h] :
2237 - to allow compilation with gcc 3.x
2238 -- clean up of STL usage (added explicit usage of std::)
2239 -- small fixes on exceptions.
2240 Note: linking not tested !
2241 - clean of doxygen comments to avoid warnings at documentation
2243 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2244 dependent convertion).
2246 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2247 * Clean up of previous JPR garbage commit (not even commented in the
2249 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2250 - moved all jpeg related files from src to src/jpeg/libijg8, with
2251 addition/modification of Makefile.am and configure.in.
2252 - the testSuite is still brain damage (not guilty).
2254 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2255 * WrapVTK.py : modifications to get correctly vtk source files to
2257 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2258 (FileName -> Filename)
2260 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2261 * vtk/vtkGdcmReader.[cxx/h]:
2262 - UpdateProgress method should now be effective
2263 - removed the limitation on having only images loaded (as opposed
2265 - when building a stack of images/volume, a lesser number of
2266 gdcmHeader and gdcmFile instances should be used (hopefully
2267 accelerating things).
2268 - when building a stack of images/volumes, files which are not
2269 loadable (wrong path-filename, wrong permissions on existing file,
2270 or file not parsable by gdcm) are replaced with a black image
2271 in the stack (for the caller to notice the problem).
2273 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2274 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2276 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2277 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2278 between standard library (std) and vtk library (problems are found
2279 under Windows... thanks Windows !)
2281 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2282 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2284 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2286 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2287 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2289 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2290 * When compiling with distutils (see setup.py) the C++ compiler is
2291 called with different flags than the default ones (with automake).
2292 In order to fix all those warning, I compiled gdcm with the command
2293 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2294 and went for warning fixes:
2295 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2296 up from unused variables.
2297 - vtk/vtkGdcmReader.cxx: potential bug fix.
2298 * src/gdcmHeader.h: Doxygen warning cleanup
2300 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2301 * gdcmPython/gdcm.i:
2302 - typemaps correction to take into account the systematic replacement
2303 of "using namespace std" with std:: prefix e.g. std::list,
2304 std::string... (cf changes of 2003-05-21).
2305 - gdcmGlob global variable of type gdcmGlobal (defined in
2306 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2307 exported to Python a as cvar.
2308 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2309 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2310 gdcmDictSet.GetPubDictTagNames() and
2311 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2312 C++ static methods).
2313 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2314 with the above changes.
2316 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2317 * setup.py, manifest.in : bug fix under linux
2319 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2320 * Modification of setup.py to compile vtk part too. Then, we have 2
2321 wrappers which must work with same distutils. For that, we have a
2322 generic distutils in distusiltsWrapping.py ; with :
2323 - build_extWrap class to wrap generically all extensions,
2324 - ExtensionWrap base class for all wrapping extension that contains
2326 - Wrapper interface which wrap sources
2327 + In WrapSwig.py we have extension and wrapper for Swig
2328 + In WrapVTK.py we have extension and wrapper for VTK
2329 * MANIFEST.in : modifications to consider vtk directory and new python
2330 files for compilation
2332 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2333 * Added python wrappers of vtkGdcmReader vtk class (see the
2334 source in vtk/vtkGdcmReader.cxx) :
2335 - vtk/Makefile.am now builds a library
2336 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2337 python library (as opposed to _gdcm.so wich are the python
2338 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2339 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2341 - configure.in has an additional flag --enable-vtk that needs
2342 to be set to enable compilation of vtk related code, that is:
2343 + vtk/vtkGdcmReader.so and
2344 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2345 + gdcmPython/vtkgdcmPython.so (see above)
2346 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2347 be read when compressed or when HighBit + 1 != BitsStored),
2348 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2349 the usage of the python wrapper of vtkGdcmReader vtk class.
2350 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2351 * src/*.[h] all occurences of stl classes are now prefixed with
2352 std::, and all occurences of "using namespace std;" where removed.
2353 This is to avoid pollution of global namespace in included files.
2354 Apparently vtk does not avoid this pitfall: when using both
2355 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2356 collision of various stl members (principally cout...).
2357 * gdcmPython/testSuite.py now cleanly removes temprory generated
2359 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2360 comply with above changes)
2362 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2363 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2364 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2365 vtk data structure (an image Flip was required).
2366 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2367 * cosmetic changes in documentation.
2369 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2370 * src/gdcmHeader.cxx: the constructor no longer exits when an
2371 unexisting file is given as argument.
2372 * The subdirectory Data (containing all the images used for the
2373 test suite) is not part of this repository anymore. A new module
2374 containing those images is now available at
2375 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2376 with the name gdcmData.
2377 All the python scripts (including the package initialisation file
2378 gdcmPython/__init__.py) were adapated to take this change into
2379 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2381 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2382 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2383 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2384 demo of the usage of this class.
2385 Compilation of this vtk part is only done when using the --enable-vtk
2386 at configure (or autogen.sh) stage.
2388 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2389 * More memory link related corrections and documentation fixes.
2391 - maximum info is obtained with a command of the form:
2392 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2393 --show-reachable=yes PrintHeader
2394 - the remaining reachable blocks seem to come from the STL
2395 allocation scheme through the usage of map and list. It looks
2396 like this memory cannot be freed but it is not a memory leak
2397 (in fact further invocation to the STL would recollect the
2398 unused memory allthough it cannot explicitely be freed).
2399 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2400 of displaying an image parsed with gdcm and displayed with VTK.
2401 Note: some images don't seem to work e.g.
2402 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2403 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2404 Allthough this weakens the semantics, it is a ditch attempt to
2405 make gdcm more thread friendly.
2407 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2408 * Memory link hunt (by using valgrind through the command
2409 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2410 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2411 gdcmHeader::_dicom_vr.
2412 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2413 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2415 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2417 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2418 * src/Makefile.am now exports all the necessary include files at
2422 * UpdateGroupLength replaced by new one
2425 * UpdateGroupLength re-written using H-Table
2426 (named UpdateGroupLengthNew untill checks are over)
2428 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2429 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2430 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2432 - gdcmHeader::GetPubElValSet removed.
2433 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2434 UpdateGroupLength, WriteElements, Write.
2435 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2436 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2437 carried the same semantics.
2438 - src/gdcmHeaderIdo.cxx changed accordingly.
2439 - gdcmFile::WriteBase now regroups all the codes from previous
2440 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2441 - enum FileType moved to gdcmCommon.h
2442 * src/gdcmHeader.cxx AddDefault trashed
2443 * gdcmGetXSize added
2444 * getimageDataSize now calls gdcmGetXSize
2445 * Test/*.cxx changed to agree with above changes
2447 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2448 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2449 (to avoid double call by end user).
2450 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2451 by end user, since gdcmHeader::gdcmHeader now handles it.
2453 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2454 * gdcm/Doc many doxygen changes:
2455 - Doxyfile now has two different versions, DoxyfileUsers that generates
2456 the html.users end users oriented documentation and
2457 DoxyfileDeveloppers that generates the html.developper developper
2458 oriented documentation.
2459 - README changed accordingly
2460 - requirement.txt removed (old design info moved to TODO).
2461 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2462 DoxyMainPage.txt, DoxyPython.txt provide more information.
2463 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2464 be updated by simply regenerating the docs with doxygen and copying
2465 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2466 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2467 all the tests in the form "if (<map>.count() >1)" were removed.
2468 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2469 ill-formed documentation sections.
2470 * src/gdcmHeader.cxx: ditto
2472 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2473 * setup.py fixed for un*x (needed macro for stdint.h)
2474 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2475 un*ces with sh-utils test utility.
2476 * gdcmPython/demo/test.py renamed to PrintHeader.py
2477 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2478 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2479 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2480 * src/gdcm*.cxx JPR's bad inclusion fixed.
2482 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2483 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2484 * gdcmPython/demo/test.py changed accordingly.
2486 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2487 * gdcmPython/Makefile.am fixed linking against libstdc++
2488 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2489 * Swig subdir (historical tests of swig version 1.3.17++) removed
2490 * Test/testChangeEntete.cxx some lines commented out in order to make
2492 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2493 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2495 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2496 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2497 hence the user doesn't need this explicit call.
2498 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2499 i.e. LoadElements() call removed.
2500 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2501 - src/Makefile.am declares the proper flag for g++.
2502 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2503 for adding user defined new tags.
2504 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2505 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2506 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2508 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2509 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2510 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2511 src/Makefile.am : the project should properly compile and install
2512 with the autotools, included the python wrappers part.
2513 * gdcm.spec.in : added a spec file for RPM packaging.
2515 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2516 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2518 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2519 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2520 to exported to the environement (see gdcmPython/testSuite.py
2522 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2523 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2524 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2525 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2526 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2528 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2529 * gdcmPython/__init__.py doesn't crash anymore when running in
2530 in InstallMode or PreInstallMode but with an environement given
2531 value of GDCM_DICT_PATH.
2532 * src/gdcmDictSet.[cxx/h] coding style.
2534 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2535 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2536 * src/gdcm.h general comments moved to TODO, and README
2537 * src/gdcm.h should now be seen as a user commodity (including it
2538 should suffice to fully use gdcm). It is nowhere including within
2539 any of the kernel files src/*.cxx and src/*.h.
2541 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2542 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2543 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2545 * src/gdcm*.cxx only include their corresponding include file
2546 (as opposed to gdcm.h)
2547 * gdcmPython/gdcm.i changed accordingly
2548 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2549 the autogen.sh generated "make snapshot" command to work.
2550 * autogen.sh removed history related references to crea package.
2552 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2553 * distutilsSwigCPlusPlus.py work around some swig portability
2556 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2557 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2558 was done in a last ditch attempt to get setup.py _really_
2559 operationnal. The python/gdcmPython layaout add the advantage
2560 of hidding away the python related distutils specific files
2561 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2562 Alas, the src directory was out of scope (i.e. it's relative
2563 position to setup.py was ../src) which made things impossible to
2564 handle (see previous version of python/setup.py). Crossing fingers...
2566 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2567 * python/setup.py now works on Un*x. (harder than I thougth)
2568 * python/distutilsSwigCPlusPlus.py can now have include files
2569 among the list of sources.
2571 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2572 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2573 * modifications in MSVC projects
2575 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2576 * As stated by the first lines of Test/ExceptionAndPython/README, it
2577 looks like we can move back to original usage of exception within
2578 src/gdcm* and hence remove the errno stuff that was introduced
2579 as a quick and dirty fixture of this problem (added to the TODO).
2580 * Doc/Doxyfile configuration file for Doxygen and corresponding
2581 README file for usage added.
2582 * Test/testWrite.cxx added. This new test comes from a split of
2583 test.cxx that is now reverted to its original purpous i.e.
2584 testing the proper parsing of a Dicom related file.
2585 testWrite.cxx concentrates on testing the IO part of gdcm.
2586 * Test/bug1.cxx (containing a bug on WIn32) added.
2587 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2588 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2589 whose purpose is to publish the content of the TagNames of the
2590 Dicom public dictionnary were not accessible without an
2591 instance of class gdcmHeader.
2592 - those methods are now static methods of gdcmDictSet and hence
2593 require no instances at all to be invocated.
2594 - within gdcmDictSet this change required to change some method
2595 to class methods (i.e. are now static) among which SetDictPath
2596 (renamed to BuildDictPath) and LoadDefaultPubDict.
2597 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2598 the above changes by calling the new method classes of gdcmDictSet.
2599 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2600 the above to be effective.
2601 * python/gdcmPython: in order to wrap properly the above changes
2602 for Python, swig version now needs to be > 1.3.17.
2603 * python/gdcmPython/Makefile fixed to adapt itself to new
2604 configure/make shema introduced by Johan Montagnat (thanks for the
2605 contribution). Alas this Makefile cannot be turned into a proper
2606 Makefile.am without some heavy changes in the configure.in
2607 (for python dectection).
2608 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2609 now avoids publishing the empty entries.
2611 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2612 * python/setup.py : bug fix concerning install under windows
2613 ExtraPath reused :-P
2614 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2616 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2617 * Dicts/dicomV3.dic : remove double spaces !!!
2618 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2619 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2622 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2623 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2624 method. Doxygenation.
2625 * src/gdcm.h clean up of JPR spurious comments.
2627 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2628 * python/distutilsSwigCPlusPlus.py now properly collects the
2629 shadow classes generated by "swig -c++" (gdcm.py in our case)
2630 when using "python setup.py install".
2631 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2632 reexports the working classes.
2633 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2634 by the classical C errno scheme. This is to prevent an obscure
2635 behavior of the python wrappers when importing wxPython.wx prior
2636 to gdcmPython (which ended up in an abort call). An illustration
2637 of this oddity can be found in the Test/ExceptionAndPython
2638 subdir (see the README file). This problem probably due to
2639 an combination of g++ and dynamic loading.
2640 * added Test/ExceptionAndPython (see above)
2642 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2643 * Changed the layout of the python part to avoid bloating main
2644 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2645 i.e. the distutils arsenal. All the python related stuff is
2646 again in a python subdir, but the package itself is now in
2648 * setup.py was cleaned up:
2649 - pythonIncludePath removed
2650 - python setup.py bdist target is now functional.
2651 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2652 collision with other packages). gdcmPython/demo/*.py changed
2655 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2656 * python subdir moved to gdcmPython (preparation of distutils packaging).
2657 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2658 distutils installer is operational.
2659 * - gdcmPython/__init__.py now properly loads the swig generated
2660 shadow classes (from gdcm.py).
2661 - gdcmPython/demo/*.py changed to import the package gdcmPython
2662 instead of gdcmPython/demo/load.py.
2663 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2665 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2666 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2667 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2668 entries within the associated public Dicom dictionary resp. the same
2669 information but sorted by the fourth field (PAT, IMG, DIR) of the
2671 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2672 are now in the "???" group.
2673 - python/gdcm.i changed accordingly,
2674 - python/demo/printGroupedPublicDict.py added, that gives an example
2675 of the above new functionalities in Python.
2677 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2678 * src/gdcm.h, gdcmHeader.cxx:
2679 - historic references to glib's g_malloc and g_free (#defined)
2680 were definitively removed.
2681 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2682 * src/gdcmElValSet.cxx:
2683 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2684 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2685 - GetElValue(string) renamed to GetElValueByName.
2686 - Added GetElementByName(string).
2687 * src/gdcmHeader.cxx: added
2688 - GetPubElValRepByNumber(guint16, guint16)
2689 - GetPubElValRepByName(string)
2690 - GetShaElValRepByNumber(guint16, guint16)
2691 - GetShaElValRepByName(string)
2692 - GetShaElValByNumber(guint16, guint16)
2693 - GetShaElValRepByName(string)
2694 - GetElValRepByNumber(guint16, guint16)
2695 - GetElValRepByName(string)
2696 - GetElValByNumber(guint16, guint16)
2697 - GetElValRepByName(string)
2698 * Doc/requirements.txt added.
2700 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2701 * Test/Makefile building now depends on the one of libgdcm.so
2702 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2703 pixel data) aware which enables finding the address (offset) of
2704 the pixel data of JPEG encoded DICOM files. This leaves only a single
2705 file in the testSuite whose pixel data address (offset) is unknown.
2706 * python/testSuite.py changed accordingly.
2708 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2709 * VC++ has some strong limitations when working with the STL, as stated
2710 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2711 "Also note that some STL containers (map, set, queue, list, deque)
2712 cannot be exported. [...]
2713 Some STL classes contain nested classes. These classes can not
2715 This is caused by a designed limitation that once a template
2716 class is instantiated, it can not be re-instantiated and
2718 Since our usage of map<> is ubiquitous in gdcm, this "designed
2719 limitation" of VC++ is a pitfall.
2720 Hence the Python wrappers of gdcm cannot be incrementally linked
2721 against the c++ dynamic library. The dirty but only workaround is
2722 to forget about incremental link of dynamic libraries and to generate
2723 the Python wrappers library with the inclusions of the underlying C++
2725 The following modifications concern this matter on Win32/VC++:
2726 - wrapping python correct with standalone wrapped dll (don't use separate
2727 dll under windows !!!!)
2728 - python21_d debug mode enabled (ask Frog how to use it :-)
2729 - NO problem with having an STL member of class for example string in C++
2730 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2731 - Python test of dcmlib in Python is ok under windows on a large set
2733 * removed glib references
2734 * typedef's inserted in gdcm.i for correct swig type management
2736 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2737 * python/demo/*.py load.py extracted from test.py. Added explore.py
2738 that only displays required tags and testAll.py that parses all
2739 the files of the testsuite without using unittest.
2740 * python/testSuite.py other additional test on new files added.
2741 * Data/* new test files added accordingly to the testSuite.
2742 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2743 the vr in the file differs from the one of the dictionary.
2745 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2747 values, but limits itself to values which are below a user specified
2748 size (by default 1024 bytes).
2749 * python/gdcm.i : elements not loaded (because their size is above the
2750 user specified treshold) are exported with their TagKey as key of the
2751 python dictionary. This enables the testsuite to make some checks
2752 on the unloaded elements (since we have their offset and size).
2753 * python/testSuite.py
2754 - now tests for the existence and proper value of the pixel data
2755 - two new examples added.
2756 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2758 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2759 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2760 aware. See the strategy comments in gdcmHeader::FindeLength().
2761 * Test/test.cxx now accepts a filename as first argument.
2762 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2763 * python/testSuite.py changed to integrate test on above files.
2765 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2766 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2767 the vr was also RET.
2768 * python/testSuite.py more tests added.
2770 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2771 * python/testSuite.py unittest test suite added (uses Data)
2772 * Data/* dcm and acr files for the test suite.
2773 * glib dependance removed from un*x version. We now use ISO C99
2774 7.18 Integer types (see stdint.h)
2775 - python/Makefile, src/Makefile src/gdcm.h
2776 * src/ when an explicit vr (like dicom files) suddenly poped an
2777 implicit element we use to mark the underlying DictEntry of the
2778 concerned ElValue with "Implicit". This strategy was damageable
2779 too the public or provite dictionaries, since some of their vr
2780 would be changed. Since Header::FindLength heavily relies on the
2781 detection by Header::FindVR of falsely explicit elements, I
2782 added an extra ImplicitVr member to ElValue (boolean).
2783 The rest of the changes we the necessary adaptations.
2785 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2786 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2788 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2790 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2791 * Adaptation for porting to VC++:
2793 o forced to use std namespace (for string to be known)
2794 o all class use __declspec export style on WIN32
2795 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2796 (in stdlib.h on Win32 but in std:: for gcc)
2797 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2798 variable GDCM_DICT_PATH.
2799 * src/gdcmHeader.cxx verbose comments made discrete.
2801 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2802 * python/gdcm.i: added a typemap that converts a C++ hashing table
2803 to native Python dictionary.
2804 * python/demo/test.py:
2805 - now uses the native dictionary for exploration of gdcmHeader.
2806 - takes an optional filename argument (the file to parse).
2807 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2808 PubElVals hashing table.
2809 * Dicts/dicomV3.dic removed error prone trailing spaces.
2811 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2812 * Python wrapping process moved away from src/Makefile to
2813 newly created python/Makefile (as well as gdcm.i)
2814 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2815 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2816 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2817 from the environement variable GDCM_DICT_PATH (when existing).
2818 * src/gdcmDict::GetTag bug fix.
2820 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2821 * Straightforward temporary fixes for swig to build the python wrappers.
2822 src/Makefile now has a python working entry [by working we mean
2823 that we can import de shadow classes without errors].
2825 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2826 * hashtest.cxx removed (since allready in Test)
2827 * src/gdcmlib.h renamed to src/gdcm.h
2828 * src/dcm.i renamed to src/gdcm.i
2829 * src/Makefile prepared for python wrapping
2831 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2832 * src/gdcmHeader.cxx :
2833 - Parsing of header is now separated from loading of element values
2834 (see gdcmHeader::LoadElements).
2835 - general clean up of hopefully all file access (creation of
2836 ReadInt16 and ReadInt32)
2838 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2839 * src/gdcmHeader.cxx :
2840 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2842 - SetLgrElem renamed to SetLength
2843 - GetLgrElem renamed to GetLength
2844 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2845 * src/gdcmElValSet.cxx fixed both GetElValue methods
2846 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2847 due to IdoDude was cleaned out.
2849 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2850 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2851 concentrates on finding the value representation (when it exists).
2852 RecupLgr now only finds the element value length, and it avoids
2853 returning the unecessary skL (skipped length).
2854 Also, offsetCourant was simply removed (with taille_fich) since
2855 it was redundant with the File position internals (by using
2856 ftell and fseek). This also made skL (see above in RecupLgr) usage
2858 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2859 on the libido specificities which are handled through class
2861 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2864 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2865 * Truckload of changes. Parsing of header is barely functional
2866 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2868 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2869 * src/gdcmHeader.cxx many addons of low level methods
2871 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2872 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2873 and _IdDcmSWAP_LONG.
2875 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2876 * This corresponds to all the changes decided at the meeting of
2877 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob