1 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
3 each added entry in the header. Replace the 'Planes' field by the 'Number
6 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
8 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
10 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
12 At this time, this image isn't readable by e-film... waiting JPR help to
15 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
17 DocEntry. Now use methods of the Document !
19 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * Test/ShowDicomSeq.cxx : bug fix
22 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
24 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
25 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
26 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
28 * Test/TestCopyRescaleDicom.cxx : remove unused variable
29 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
30 containing found sequences
32 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
35 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
36 Some fields in BinEntry must be copied to not seg fault when making the :
37 gdcm::File *copy = new gdcm::File( copyH );
38 and tests are now made on good variables
40 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
42 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
44 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
45 * Add vtkGdcmWriter example and test
47 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * Test/TestUtil.cxx : reformat the source code
49 * vtk/vtkGdcmReader.cxx : remove and change prints
50 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
52 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
53 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
55 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
57 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
59 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
61 by an eof to prevent all bad read of the file... and in this case, the
64 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * Example/Volume2Dicom.cxx : comment unused variables
66 * Test/PrintDicomDir.cxx : comment unused variables
67 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
68 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
69 method that is redondant with AddEntry.
70 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
73 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * Bug fix due my last commit (compilation under Windows).
75 * Example/Volume2Dicom : bug fix in the file and reformatting source code
76 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
78 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
80 - Remove printf / sprintf
81 - include iostream AFTER gdcm so we don't get warnings
82 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
84 - Also remove tons of include from header files, hopefully this should
85 speeup the compilation time, since it was becoming a dog slow.
86 - Remove gdcm.h as it include way too many files and slow down compilation
87 (plus it is not up to date)
88 - remove 'using namespace std' this is BAD !
90 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
91 * Remove memory leaks on the DicomDir
92 * Remove some useless datas in DicomDirObject
93 * Add usefull methods in SQItem, to be complient withe the ElementSet
95 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
98 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
100 future, with convertion)
101 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
102 and ImageDataSize values. Remove the method to get the PixelReadConverter
103 from the output of the class
105 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
108 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
110 and vtkErrorMacro use.
111 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
113 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
114 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
116 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
117 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
118 The string leaves only in the fonction. So when we make a .c_str(), we
119 get the pointeur on the first element, element that will be destroyed
120 immediately after thee instruction.
121 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
122 file has been opened : the test must be made on the content of the
123 pointer and not directly on the pointer !
126 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
128 the python part recompiles
130 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
132 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
133 X session is killed (for my computer... it seems to not be identic on
136 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
138 avoid problems (otherwise, the difference test between the visible image
139 and the reference is incorrect. If the reference is greater than the
140 screen resolution, it's produce errors).
141 Can be used for only one image. Can be used with a visible flag.
142 * vtk/vtkGdcmReader.cxx : remove commented codes.
143 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
144 under windows at compilation
145 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
147 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
149 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
151 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
152 tests on the image size X, Y, Z
154 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
156 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
157 between the class name and the file name
159 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * src/ : fix compilation warnings for the Write method (2 different
161 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
162 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
163 variable... create a static method in gdcm::Document to access to
164 this variable content.
166 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
168 file, to be accessed by other files (like gdcmFile). Remove commented
169 code. Move the change of the header to the gdcmFile, using the
171 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
172 To be sure of that (and simplify calls), the Write of the header now
173 gets a file name and not a file pointer (std::ifstream).
174 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
175 DocEntryArchive. Remove all open of the written file
177 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
180 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
182 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
184 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
185 some corresponding methods. Write correctly the file and check before
187 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
188 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
189 is now on RGB datas (as before my last commit
190 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
192 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
194 Add a print information of the type of the entry
195 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
196 It was in the gdcmFile, and all write have been regrouped
197 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
198 Write correctly all dicom files (in decompressed mode only at this time)
199 * Test/ : test on files are now made using Raw datas and not color datas if
201 * Example/PrintFile.cxx : add more printings
203 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * Amelioration of code, remove some code copy. For the loading of
205 BinEntry (in gdcmDocument), add the test to verify if the file is already
208 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
210 remove a DocEntry in the header (push an empty DocEntry)
211 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
212 lines. Bug fix in the initialization of the PixelConvert and the
214 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
215 use in TestCopyDicom (now this test can run under windows... but fails)
216 * Test/TestCopyDicom.cxx : amelioration of the test :
217 - test the pixels written
218 - add test points to quickly find where is the error
219 - can set a file name input and output in arguments
220 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
221 amelioration of the test output
223 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
224 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
225 all replaced DocEntry's
226 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
227 Now, each needed DocEntry to modify is duplicated, modified and inserted
228 to the header using DocEntryArchive. Thus, after save, we can restore the
229 header initial state.
231 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
232 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
234 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
235 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
236 correct to copy it. The DictEntry is specified at the DocEntry creation,
237 then, it musn't change in the time.
238 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
239 header correctly. At this time, the change is only made for the first
240 level of the Document. In the future, it might consider sequences.
241 The change is made by replacing a DocEntry by an other that is created
242 outside the class. The old value is kept. When we restore the header
243 status, the added DocEntry is deleted and replaced by the old value.
244 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
245 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
246 set the write type to explicit VR, implicit VR or ACR. Add methods to set
247 the write mode to native, decompressed or RGB (but not used at this time)
249 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
251 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
253 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
254 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
255 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
257 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
258 set because already copied when copying the BinEntry's of the header
259 * Test/TestAllReadCompareDicom.cxx : remove warnings
261 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
263 Two problems appear when doing it :
264 - with the gdcmFile : when the GetImageData method is called, the pixels
265 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
266 datas (pixels). And each structure destruct the datas when it's
267 destructed. So we have two destructions for the same datas. To solve it,
268 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
269 datas or not. If it doesn't own datas, then they will not destroyed by
271 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
272 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
273 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
274 create a double destruction of the same DocEntry's. So, to solve it,
275 the TagHT is simply cleared and the DicomDir* elements are destroyed.
276 * TODO : add an entry concerning memory leaks in the DicomDir
278 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
280 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
283 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
285 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
286 after it have been deleted
288 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
289 * FIX: src/* fix the doxygen warnings.
290 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
291 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
292 was erroneously defined with a size of 15 instead of 16. [many thanks
293 to Jean Michel Rouet for pointing out this bug].
295 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
296 1. Finish merging JMR patch for writting DICOM from scratch
297 2. Fix -hopefully- bug with MONOCHROME and space vs null character
298 3. Use const ref when possible
299 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
300 5. A few more comments
301 6. CreateUniqueUID can now be called without parameter"
303 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
304 * ENH: Slightly bigger patch:
305 1. Getting toward full integration of JMR patch for writting dicom from scratch
306 2. Update Test to test part of this patch: CreateUniqueUID
307 3. File was not close properly in gdcmDict
308 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
309 5. Use of const ref instead of copy (speed issue)
310 6. Remove temporary (duplicate) string in TranslateToKey
311 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
312 8. Do not repeat virtual in subclasses
313 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
315 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
316 * Apply first patch toward better string comparison when dealing with broken
317 DICOM files. Essentially the string could be padded with a space instead
318 of a null character as defined by standard
320 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
322 because never used... and in the same time, that's remove some memory leaks
324 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
325 * src/gdcmFile.cxx : now delete the PixelConvert instance.
326 * In examples and tests : change the type of image data variables from void*
327 to uint8_t*. Remmove all delete on image data variables
329 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
330 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
331 Verify the file pointer value before open the file, and if it's not null,
332 a verbose message is generated.
333 Close correctly the file when the file isn't considered dicom-like. The
334 correctly close is a call to CloseFile.
335 When closing the file pointer, test if its not null to close the file.
336 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
337 file. For an uncompressed image, the copied datas correspond in the least
338 case to the image size (calculated) or the image size specified in the
339 header. A verbose is generated if these two size mismatch
341 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
343 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
344 break under windows (with msvc6 compilation).
346 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
347 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
348 compiling with MSVC6)
350 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
351 * Bugs fix for the Windows build with VC6
352 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
353 needed (only for projects required VTK). If the VTK is included in all
354 projects, there is conflicts with the jpeg lib of vtk when compiling the
355 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
356 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
357 when compiling the gdcm_wrap.cxx file (created by the compilation of the
359 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
360 (like it's already made for the cout use). Otherwise, conflict with the
363 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
364 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
366 - comments on the DicomDir::Method related usage added.
367 - now that we use the namespace gdcm, a lot of internal classes do
368 NOT need to be wrapped anymore.
369 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
370 DicomDir::Method) new example added.
372 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
373 * Improve string manipulation. I now inforce the notion of 'DicomString'
374 A DicomString can contain as many \0 as they want
375 and it is *always* of even length.
376 We only support odd length for very rare case.
377 And in the near future this should be removed.
379 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
380 * /binary_write/ gdcm source. Now even on big endian we are writting
381 little endian. This should -heopfully- fix some tests
383 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
384 * Now the dictionary is compiled into gdcm lib. This is a default
385 behavior, thus any dic file specified is picked before failback to
386 the one comiled into lib
388 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
389 * Change internals for gdcmDict. Don't use any 'new' any more.
390 This should definitely solve any leak problem, and we should be
391 as fast as before, as long as don't modify too much the dictionary.
393 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
394 * STYLE: ivars should start with a capital letter.
395 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
396 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
398 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
399 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
400 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
401 new 2004 dictionaries added (thanks to JPR).
402 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
403 * CLEANUP_ROUND (15) for gdcmPixelConvert
404 - RLEFrame::NumberFragments is now of type unsigned int
405 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
406 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
409 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
410 * Initial work in gathering all transfer syntax accessors. clearly
411 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
412 ivars, but only one transfersyntax (class) ivar with equivalent method on
415 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
416 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
417 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
418 discussed (plus I didn't like having a 2000 lines patch not commited)
420 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
421 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
422 * CLEANUP_ROUND (14) for gdcmPixelConvert
423 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
424 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
425 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
427 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
428 anymore and hence avoids storing a copy of PixelConvert::Decompressed
429 into File::Pixel_Data.
431 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
432 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
433 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
434 * CLEANUP_ROUND (13) for gdcmPixelConvert
435 Substituted File::ParsePixelData() with PixelConvert::Print() new
437 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
438 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
439 method to those classes.
440 - src/gdcmFile.[cxx|h]:
441 -- Added a ::Print() method.
442 -- PixelConverter is now a reference instead of a member.
443 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
444 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
446 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
447 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
448 collaboration diagram and inheritance diagram should be generated with
450 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
451 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
452 pointlessly wrapped (see
453 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
454 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
455 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
456 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
457 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
458 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
459 -- File::Initialise: PixelConverter setup moved away to
460 PixelConverter::GrabInformationsFromHeader()
461 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
462 interpretation moved away to PixelConverter::BuildRGBImage()
464 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
465 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
466 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
468 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
469 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
470 displayed on Win32 when a brutal abort() occurs (because of uncatched
471 exception). See TODO new entry of this commit for more on this.
472 * TODO added new entry.
473 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
474 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
475 - HandleColor is no longer called from gdcmFile.cxx
476 - gdcmPixelConvert.cxx clean up on method arguments and internal
477 variable names for semantical coherence.
479 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
480 * Finished lossless transition, not only do we now read all lossless jpeg
481 images, without the need of the Cornwell lib, but we do read them properly now
482 * To reduce code (well to avoid code duplication), I defined a common place
483 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
484 redefine symbols. This is not prefect but this the best solution I found for a
485 compilation time jpeg option.
487 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
488 * Update jpeg ijg lib to support lossless jpeg implementation
489 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
491 * Also added a special copyright for dcmtk since we use their bugfixes.
494 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
495 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
496 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
497 matters, as stated in warning note at begining of %include section).
498 * src/gdcmDicomDir*.[cxx|h]: coding style
499 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
500 * src/gdcmJpeg8.cxx: doxygen fix.
501 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
502 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
503 from File:: to PixelConvert::.
505 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
506 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
507 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
508 - more code moved away from File:: to PixelConvert::
509 - fat setup of PixelConverter set in place in File::Initialise.
511 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
512 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
513 namespace at the file system level. So now you should convert your examples
515 gdcmHeader -> gdcm::Header
516 It would be nice if people keep in mind to no open the namespace, since it
517 allows compilation on broken plateform which were defining common symbol in
518 the standart namespace (like LP, Unknown ...)
520 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
521 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
522 The JPEG fragments are now parsed at the same stage than the RLE
523 information. All code related to JPEG is now in gdcmPixelConvert:
524 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
525 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
526 export a gdcmFile:: method. Those are simply global functions
527 (for the time being this is better than having them attach to
528 either gdcmFile:: or gdcmPixelConvert::).
529 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
530 and stores the result in a gdcmJPEGFragmentsInfo.
531 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
532 code (among other stuff) moved away from gdcmFile:; to
535 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
536 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
537 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
538 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
539 clean up of RLE related code.
540 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
541 - src/gdcmRLE.cxx removed
542 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
543 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
544 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
545 * CLEANUP_ROUND (9) for gdcmPixelConvert
546 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
547 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
548 away from gdcmFile:: to gdcmPixelConvert::.
550 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
551 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
552 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
553 This is because Parse7Fe0 used to parse the pixels to compute the
554 length. This task was passed over to FindDocEntryLengthOB() a long
555 time ago, EXCEPT I had forgotten the OW case...
556 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
557 we just recylce the code for parsing RLE fragments and computing
559 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
560 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
561 with the retired Parse7Fe0().
562 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
563 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
565 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
566 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
567 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
568 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
569 - src/CMakeLists.txt: alphabetic order reodering + new entries.
570 * CLEANUP_ROUND (4) for gdcmPixelConvert
571 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
572 to return an unused length.
574 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
575 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
576 this should be cleanner from the plane view. The iostream are erally a pain
577 to use to do simple stuff.
579 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
580 * Redo the compilation of the ijg jpeg library. Now only one source is
581 necesseray. No need to rename file by hand what so ever. CMake handle the
582 copying of the file within different directory, configure header file to
583 modify some symbol. The only addition made to ijg wasd a mangle table so
584 that symbol are different wether we are within 8bits or 12bits.
586 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
587 * Added documentation of vtkgdcmReader on Website:
588 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
589 with it's binary name).
590 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
591 the Website to be more complete.
592 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
593 doxygenated documentation.
594 - Doc/DoxyVtkGdcmReaderExamples.txt added
595 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
596 DoxyVtkGdmReaderExamples.html )
597 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
598 * CLEANUP_ROUND (3) for gdcmPixelConvert
599 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
601 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
602 * CLEANUP_ROUND (2) for gdcmPixelConvert
603 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
605 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
606 * CLEANUP_ROUND for gdcmPixelConvert:
607 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
608 - src/gdcmPixelStuff[h|cxx] removed
609 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
610 - src/CMakeLists.txt changed accordingly
612 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
613 gdcmVersion.py moved to newly created ATTIC related
614 gdcmPython/SetupOldies/ directory.
615 * Autotools clean up:
616 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
617 - autogen.sh configure.in acinclude.m4 python.m4 removed
619 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
620 * src/*.cxx *.h Reference to License.htm fixed to License.html.
621 * Doc/CMakeLists.txt, doxygen.config.in: fix.
622 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
624 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
625 * TODO updated with Mathieu suggestions. I proposed a template for
626 describing TODO entries and used it for new entries.
627 * Added Doc/Website/CodingStyle.html, Developpers.html,
628 DeveloppersPython.html, GdcmDataCvs.html and
629 DownloadVersion0_1.html, DownloadVersion0_3.html.
630 * Some Doc/*.txt Doxygen files (which do not really concern the
631 documentation itself, but the website) moved to html and
632 placed in directory Doc/Website:
633 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
634 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
635 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
636 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
637 * CMakeLists.txt changed accordingly.
638 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
639 DeveloppersPython.html
640 * INSTALL nows refers to Doc/Website/Installation.html
642 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
643 * Added Doc/Website directory, that contains a first raw version
646 2004-09-23 Jean-Pierre Roux
647 * FIX In order not to be poluted any longer by casting problems,
648 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
649 we can now delete[] it safely
650 * VoidArea is now called BinArea (less confusing name),
651 and all the methods called ...VoidArea... are now ... BinArea...
652 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
654 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
655 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
656 clear) TagHT, which is an inherited member of gdcmElementSet. It is
657 up to the destructor of gdcmElementSet to clean up TagHt and it's
660 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
661 * Test/CMakeLists.txt: update to follow gdcmData renamings.
662 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
664 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
665 * ENH: added some utility method that builds a flat dictionnary
666 holding all the Dicom entries contained in the recursive structure
667 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
669 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
670 BuildFlatHashTable() that build a flat dictionary.
671 - src/gdcmElementSet.h: added a new private GetTag() accessor.
672 gdcmDocument is now a friend of gdcmElementSet.
673 - src/gdcmElementSet.cxx: clean up.
674 - Example/FlatHashTablePrint.cxx added.
675 - Example/CmakeLists.txt changed accordingly
677 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
678 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
679 moved away from gdcmDocEntrySet (since this class is an abstract class
680 acting like an interface). SQDepthLevel and BaseTagKey are now
682 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
683 and associated accessors. Doxygenation of the class.
684 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
686 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
687 Use SQDepthLevel accessor instead. ::Print() adapted.
688 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
689 - src/gdcmDocument.cxx changed accordingly.
691 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
692 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
693 - The following is the doxygen comment of the typedef declaration
694 of gdcmagKey in src/gdcmCommon.h:
695 gdcmTagKey is made to old an "universal" (as in URL, Universal
696 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
697 A dicom tag allways has a group and an element, but a set of tags
698 embeded in various (optionally nested) sequences and sharing
699 the same group and element all share the same (group, element)
700 "identifier". Hence the (group, element) cannot be used as an
701 identifier (in gdcm we shall refer to a "TagKey") of a tag.
702 In order to construct a proper tag identifier (i.e. a key) we
703 consider the following definition of a TagKey:
704 - let Group, Element be the string representation of the
705 group and element dicom tag members,
706 - let ItemNumber be the string representation of the integer
707 index of the considered item number of a sequence,
708 Let the key of a tag embeded in a sequence, noted SeqTag, be
710 /ItemNumber#Group|Element
711 where "/", "#" and "|" are characters acting as separators.
712 Then the general form of a gdcmTagKey is given by:
713 Group|Element<SeqTag>
714 where <SeqTag> means NO or many instances of SeqTag.
715 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
718 but the gdcmTagKey of a tag "embeded" is the first item of
719 a sequence, itself nested in the third item of a sequence is the
721 0004|1220/2#0008|0082/0#0008|0090
722 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
723 order to hold the new sequence compatible key. Previously, the
724 GetKey() method would look in the underlying gdcmDictEntry.
725 - src/gdcmDocEntry.cxx:
726 -- constructor now copies the underlying DictEntry key, in the local
728 -- ::Print: displays the member Key, instead of the (group, element).
729 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
730 - src/gdcmDocEntrySet.h:xi
731 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
732 -- now has a new BaseTagKey member.
734 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
735 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
737 This poses the problem with the semantics of the following lines
738 LoadEntryVoidArea(0x0028,0x1201); // R LUT
739 LoadEntryVoidArea(0x0028,0x1202); // G LUT
740 LoadEntryVoidArea(0x0028,0x1203); // B LUT
741 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
742 to the long FIXME note for what the problem is. Nevertheless in
743 order to get things working the dicom dictionary was altered !
744 Please fix things urgently...
745 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
746 information), see above note on moving the member VoidArea. Nevertheless
747 the following entries previously correctly set as US are now inproperly
749 0028 1201 OW IMG Red Palette Color Lookup Table Data
750 0028 1202 OW IMG Green Palette Color Lookup Table Data
751 0028 1203 OW IMG Blue Palette Color Lookup Table Data
752 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
753 of gdcmDocEntry moved to gdcmSeqEntry.
754 * src/gdcmSeqEntry.cxx: STYLE.
756 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
757 * Test/TestAllEntryVerify.cxx minor fix and added comments.
759 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
760 * gdcmPython/testSuite.py: all the test suite in python is now moved
761 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
762 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
763 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
765 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
766 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
767 to avoid inclusion recursion until STL is reached.
768 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
769 mecanism. errno.h is not included in gdcm anymore.
770 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
771 (gdcmFormatError now inherits from gdcmFormatUnexpected).
773 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
774 gdcmData/TestAllEntryVerifyReference.txt
775 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
776 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
777 exception_on_error parameter.
778 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
779 - vtk/vtkGdcmReader.cxx changed accordingly,
780 - Example/*.cxx and Test/*.cxx changed accordingly.
782 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
783 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
784 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
785 enable_sequences removed from gdcmHeader constructor and dependencies.
786 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
787 * gdcmPython/demo/PrintHeader.py: dummy fix.
788 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
789 skip_shadow removed from gdcmHeader constructor and dependencies.
790 * Example/*.cxx and Test/*.cxx changed accordingly.
792 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
793 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
794 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
796 2004-07-21 Jean-Pierre Roux
797 * FIX Now, Parsing and Printing a DICOMDIR do work!
798 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
800 2004-07-20 Jean-Pierre Roux
801 * FIX Some brain damaged headers have Zero-Lenght fields
802 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
804 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
805 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
806 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
807 variable (instance of gdcmDebug) by a definition macro, and the instance
808 is now in static in the gdcmDebug class
809 * src/gdcmSQItem.h : (FIXME) remove an undefined method
810 * Test/PrintAllDocument.cxx : bug fix in the result of the test
812 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
813 * WARNING: ctest now depends more tightly on gdcmData. You should
814 check out gdcmData properly for things to run smoothly...
815 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
816 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
817 we need the pixels not be loaded in order to use the ValEntry
818 that displays position and size).
819 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
820 This is a C++ based equivalent of gdcmPython/testSuite.py that should
821 be deprecated. If you have any doubts about the advantages of a
822 modern scripting language (read Python) versus grass root C++ (i.e.
823 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
824 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
825 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
826 Anyhow, consider documenting the gdcmData images in
827 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
829 * Test/CMakeLists.txt:
830 - now uses TestAllEntryVerify.cxx
831 - specific comments on oldACR00001.ima (now renamed in gdcmData
832 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
833 gdcmData/TestAllEntryVerifyReference.txt
836 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
837 * src/*.[h|cxx] : typedef clean up
838 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
839 - TagKey renamed to gdcmTagKey (for external usage)
840 - VRKey renamed to gdcmVRKey (for external usage)
841 - removal of typedef duplication.
842 - Removed all unecessary inline keyword from class inline definitions.
843 - Some method|function(void) declarations replaced with method|function().
844 * src/jpeg/libijg12/jdhuff12.c:
845 - printf polluting ctest removed.
846 - TAB removal for comminting
848 - TestAllReadCompareDicom.cxx: added a test that compares all the
849 images in gdcmDataImages.h with corresponding images in
850 gdcmData/BaselineDicom/. When baseline images are not present
851 this test creates them.
852 Note: we need to validate each reference image, but before that
853 I'd like to rename them with a more explicit name...
854 - CMakeLists.txt: changed accordingly.
855 * Example/*.cxx: examples now only include gdcm.h (as opposed to
856 including each header needed).
858 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
859 * Test/*.cxx and Example/*.cxx: moved some examples away from the
860 test suite to the Example directory. Are concerned:
865 - TestWriteSimple.cxx
866 * Test/CMakeLists.txt: added some comments on reasons for black listing
867 image gdcmData/oldACR00001.ima
869 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
870 * Test/CmakeList.txt: removed the following from black list (to be coherent
871 with removal from gdcmData):
872 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
873 - gdcm-MR-PHILIPS-16.dcm
875 Added the following because after last cvs update, they cause
876 ctest -R TestReadWriteReadCompare
878 - gdcm-MR-SIEMENS-16-1.acr
880 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
881 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
882 new comments in this file) we temporarily (sigh) move to a weaker
884 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
885 we don't need to black list the following images anymore:
886 - 8BitsUncompressedColor.dcm
888 - US-PAL-8-10x-echo.dcm
889 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
890 fixes and the beautified code ;-)
891 This fixes the bug introduced in version 1.42 (when beautifying)
892 that made the parsing of 8BitsRunLengthColor.dcm unproper.
893 Note: ctest was blind to this bug (this means we need to still
894 improve the test suite). The bug could be detected by using
895 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
897 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
898 and by displaying the (garbage) produced file temp.XDCM...
900 2004-06-29 Jean-Pierre Roux
901 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
902 - replace by uggly but working old code :-(
903 A lot of things should be OK again.
904 It's really urgent to have a test suite that *tests*,
905 to prevent Frog's beautifying sessions to break all the stuff
906 (twice, withing a fortnigh ...)
908 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
909 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
910 redundancy) to added Test/TestReadWriteReadCompare.cxx
911 * Test/CmakeList.txt: because the compare test of
912 Test/TestReadWriteReadCompare.cxx fails, the following images are
913 black listed: - 8BitsUncompressedColor.dcm
915 - US-PAL-8-10x-echo.dcm
916 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
917 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
918 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
919 and ad-hoc kludge. This kludge is now removed, and on encountering
920 such an image (OB field brain damaged) we set errno. Then in
921 ::FindDocLength() we "fix" the length as being ALL what remains
922 in the file (until EOF). We then proceed, hoping for the best...
923 This fixes a SegFault in ShowDicom when trying to write such an
925 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
926 (because TestWriteRead breaks on it, after a non conformal commit?).
927 ctest now runs properly, except for MakeDicomDir (which was allways
928 broken) and the Python related stuff (still not fixed).
930 2004-06-24 Jean-Pierre Roux
931 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
932 FIX : Test/TestReadWrite now iterates on all the file names
933 (instead of infinite loop)
934 ENH : Test/TestWriteRead now iterates on all the file names
936 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
937 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
939 2004-06-24 Jean-Pierre Roux
940 FIX : - now Write drops LUT Descriptors and LUTs (if any)
941 when SamplesPerPixel =3
942 - now Write is no longer confused by
943 'BitsAllocated = 12" and 'BitsStored=12"
944 - "UN" value representation Elements are now written correctly
945 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
946 ENH : - now gdcmHeader has its own Write methods
947 (in order to split the job that has not to be done
950 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
951 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
952 loop on the same image until memory went out.
953 Note: this means we still have gobs of memory loss in PrintDocument
954 * src/gdcmDocument.cxx: fixes problem on parsing on file
955 gdcmData/16BitsJpegLosslessGrayScale.dcm.
957 2004-06-24 Jean-Pierre Roux
958 FIX : Write - All the Sequences and Sequence Item are now written
959 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
960 is added a the end, when necessary.
961 - A lot of brain-damaged images, that were read correctly are
962 now written correctly
963 - length compatible BinEntry are now loaded correctly
964 (even for odd groups)
965 Note : only Explicit Value Representation was checked.
966 (question : is implicit VR really necessary for gdcm ?)
968 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
969 * DEVELOPPER: added a proposition of coding style.
970 * src/gdcmDocEntry.h: removed every inline declaration (for test of
973 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
974 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
975 Use the gdcmDocEntry::Print() and Write() instead.
976 * src/gdcmDocument.cxx: bug fix.
978 2004-06-22 Jean-Pierre Roux
979 FIX : gdcmDocument.cxx
980 - Now we do recognize the JpegLossLess format (there was a misstyping in
981 code 'beautyfication' :-(
982 - Now we automaticaticaly load the Luts, if any
984 2004-06-22 Jean-Pierre Roux
985 In order : to write Sequences, whatever their imbrication level,
986 : to allow user to create his own Sequences
987 a lot of modif where necessary (adding, moving, or virtualising methods)
989 WARNING : save your own sources *before* cvs up !
992 ADD virtual void Write(FILE *fp, FileType filetype);
995 ADD virtual void Write(FILE *fp, FileType filetype);
996 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
999 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1000 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1001 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1002 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1003 ADD std::string GetEntryByName(TagName name);
1004 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1006 std::string vr = "unkn",
1007 std::string fourth = "unkn",
1008 std::string name = "unkn");
1009 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1010 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1011 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1012 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1013 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1014 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1015 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1016 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1019 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1020 ADD virtual std::string GetEntryByName (TagName tagName);
1021 ADD virtual std::string GetEntryVRByName (TagName tagName);
1022 REM virtual bool Write(FILE *, FileType);
1023 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1024 FILE *_fp, FileType type);
1025 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1026 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1027 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1028 REM virtual std::string GetEntryByName (std::string tagName);
1029 REM virtual std::string GetEntryVRByName (std::string tagName);
1030 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1031 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1032 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1034 std::string vr = "unkn",
1035 std::string fourth = "unkn",
1036 std::string name = "unkn");
1037 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1038 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1039 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1040 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1043 ADD virtual void Write(FILE *fp, FileType filetype);
1046 ADD virtual void Write(FILE *fp,FileType filetype);
1049 ADD virtual void Write(FILE *fp, FileType filetype);
1050 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1051 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1052 REM std::string GetEntryByName(TagName name);
1055 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1057 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1059 The default constructor invoked by the line
1060 gdcmHeader *f1 = new gdcmHeader( header );
1061 was gdcmHeader::gdcmHeader(bool) instead of the expected
1062 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1063 Hence the parsing wasn't executed... See also below.
1064 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1065 as explicit constructor didn't do the trick to fix the above problem.
1066 Could anyone explain why ?
1067 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1068 properly calls gdcmValEntry::Print() (that was weed out from
1069 code related to gdcmBinEntry).
1071 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1072 * In order to fix memory leaks:
1073 - Test/TestWriteSimple.cxx: added cleaning of free store through
1075 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1076 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1077 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1078 (through the call to ::AddDicomDirMeta()) or the destructor
1079 would crash when deleting uninitialized ::metaElems].
1080 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1081 - src/gdcmDocument.cxx:
1082 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1083 from dynamic stores.
1084 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1085 was causing memory leaks.
1086 - src/gdcmSQItem.cxx:
1087 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1088 cleanly handled with polymophism: sorry but my milage is low).
1089 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1090 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1091 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1092 This avoids SegFaulting.
1093 - src/gdcmSQItem.h: coding style.
1095 - Test/TestWriteSimple still severely sucks. The output image content
1096 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1097 damaged when displayed with vtkgdcmViewer.
1098 - on memory leaks: TestWriteSimple leaks really less (see entry
1099 of 2004-06-18 in Changelog file for the call to valgrind).
1100 - on segfaults: ctest now passes all the tests but one (no more
1102 * Erroneous leading white fix:
1103 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1104 white[s] (as opposed to from >> xxx, that removes it [them].
1105 - src/gdcmTS.cxx: ditto.
1106 - gdcmPython/testSuite.py: dirty related kludge removed.
1107 * src/*: remaining references to gdcmParser removed.
1108 * src/*[cxx|h]: added copy[way]left header.
1111 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1112 * In order to fix writing of dicom files:
1113 - Test/TestWriteSimple.cxx: a simpler example of writing.
1114 - Test/CMakeLists.txt changed accordingly.
1115 - src/gdcmDocument.cxx:
1116 -- The destructor now recursilvely removes potential sequences.
1117 -- Bug fix in ::IsJPEG2000()
1118 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1119 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1121 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1122 to only declared) and build on top of
1123 ::GetDocEntryByNumber(guint16, guint16).
1124 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1125 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1126 for usage in destructor and treatement of promotion in
1127 ::ReplaceOrCreateByNumber().
1128 - src/gdcmSQItem.cxx: destructor should better handle his job.
1129 Test/TestWriteSimple now runs (or at least it DOES something).
1130 * We can now start hutting memory links. A good starting point is:
1131 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1132 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1133 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1135 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1136 * Valgrind note: after Mathieu Malaterre teached me how to read
1137 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1139 Using gcc, you can force the STL to use malloc and to free memory as
1140 soon as possible by globally disabling memory caching.
1141 With 3.2.2 and later, you should export the environment variable
1142 GLIBCPP_FORCE_NEW before running your program.
1143 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1144 simply vanish (it is still not clear to me, whether this means that
1145 STL std::string leaks or if valgrind believes it leaks...).
1146 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1147 running bin/gdcmTests makeDicomDir):
1148 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1149 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1151 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1152 SegFaulting (I drowned in DicomDir related code when trying to
1153 understand why the list is empty...).
1154 * src/gdcmDocument.h: first BSD license header try.
1155 * Doc/License.txt added.
1157 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1158 * src/gdcmDocument.[h|cxx]:
1159 - Clean up of the Transfer related predicates. They are now all based
1160 on new method isGivenTransferSyntax, that (should) handle properly
1161 the padding problem.
1162 - general clean up, simplification, and coding style.
1163 - Specific clean up of Parse7FE0() (umproperly named actually).
1164 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1166 2004-06-14 Jean-Pierre Roux
1168 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1169 - fix the display of SQItem ordinal number
1170 - add the GetSQItemByOrdinalNumber method
1171 - remove some useless never written private methods
1173 2004-06-14 Jean-Pierre Roux
1175 - adding a constructor taking a gdcmDocEntry as an input param
1176 - ReplaceOrCreateByNumber now returns :
1177 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1178 a gdcmValEntry * if a string value is passed as a param
1180 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1181 according to the param type (no longer sets a gdcmDocEntry)
1182 - GetValEntryByNumber, GetBinEntryByNumber added
1183 - NewValEntryByNumber and NewBinEntryByNumber added
1185 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1187 - GetSQItemNumber and SetSQItemNumber added, to provide
1188 a (relative) Item identier inside a given Sequence
1189 \warning : some pb remaining around this number
1191 - AddEntry now takes the Item Number as a param
1193 - adding a constructor taking a gdcmDocEntry as an input param
1195 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1196 * Memory leak hunt with the following command:
1197 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1198 --show-reachable=yes gdcmTests PrintDocument
1199 It looks like many (all?) leaks are due to the STL (or a bad usage
1200 of the STL. The lines producing the leaks now have a comment with
1201 a "MEMORY LEAK" tag: you can retrieve them with
1202 grep "MEMORY LEAK" src/*
1203 Here are two typical examples which I can't help fixing:
1208 char * test = "babo";
1209 name = test; //// <--- valgrind detects 960 bytes lost in
1210 //// call to std::string::operator=(char const*)
1211 name.clear(); //// Doesn't help !
1219 std::cout << "Type a bunch of characters followed by RETURN: ";
1220 getline(std::cin, line); //// <--- valgrind dectects a loss
1221 //// of 1320 bytes in call to
1222 /// std::basic_istream<>& std::getline<>
1228 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1229 * src/gdcmHeader.[cxx|h]:
1230 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1231 and related, moved away to gdcmDocument.
1232 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1233 the corresponding protected accessors of inherited class
1234 gdcmDocument, removed ! As a consequence gdcmFile had to be
1235 declared friend of class gdcmDocument (see below).
1236 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1237 - Clean up of undefined or unused methods.
1238 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1239 account the changes to gdcmHeader.h).
1240 * src/gdcmDocument.h:
1241 - gdcmFile is now a friend class (in order to take into account the
1242 changes to gdcmHeader.h).
1243 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1244 (see changes to gdcmHeader.h).
1245 - Accessors (reading on the form GetEntry*) are now public.
1246 - Clean up of undefined or unused methods.
1247 * src/gdcmDocument.cxx:
1248 - adaptation to changes to gdcmDocument.h
1249 - ::OpenFile now writes a verbose message when file cannot be opened.
1250 - some std::string properly set to VRKey
1251 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1252 references to gdcmDocument.
1253 * Test/TestFindTags.cxx: changed accordingly to above changes.
1254 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1255 cvs repository gdcmData.
1257 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1258 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1259 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1260 conflicts with gdcmValEntry::voidArea.
1261 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1262 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1263 Value representation between StringRepresentable and BinaryRepresentable.
1264 * src/gdcmDocument.cxx:
1265 - method ParseDES: proper indentation restored and usage of
1266 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1267 - method LoadDocEntry: the fingerprint left in the SetValue() of
1268 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1269 removed. Reverting to previous code segment with the proper
1270 dynamic_cast< gdcmValEntry* >.
1271 Note: this was (partially) breaking the python test suite
1272 (gdcmPython/testSuite.py) that made usage of the above
1273 fingerprint to check presence of "Pixel Data".
1274 * src/gdcmDocEntry.h: coding style.
1275 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1276 now taken into account.
1277 * gdcmPython/gdcm.i: adaptation to the new internal representation
1278 of gdcm (exit gdcmParser, hello gdcmDocument).
1279 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1281 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1282 anymore, but instead prints the loaded Python dictionary.
1283 * .... alas, the python testSuite is still broken.
1285 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1286 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1288 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1289 * src/gdcmUtil.h : export methods
1291 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1292 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1294 * Initial addition of automatic python testing
1295 * Initial addition of automatic image comparison
1297 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1298 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1299 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1301 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1302 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1303 * Test/ShowDicom.cxx : bug fix for msvc compilation
1304 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1306 2004-05-04 Jean-Pierre Roux
1307 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1308 new concepts (and new classes) :
1309 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1310 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1311 - Sequence Doc Entries (gdcmSeqEntries)
1312 a Sequence is composed of Items.
1313 Each item is a set of Doc Entries (this is recursive)
1314 The non uniqueness of the 'Dicom tag' is due to this recursivity
1315 (never taken into account)
1316 Our unability to add a new 'entry' in the header
1317 at the proper location (neither in the H-Table (map or multimap),
1318 nor in the Chained List is also due to this recursivity.
1319 Don't try, right now, to use/modify/compile these new sources :
1320 nothing is finished.
1321 We just commit all the stuff, 'as is', in order not to loose it.
1323 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1324 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1326 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1327 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1328 file prefix (SetFilePrefix)
1330 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1331 * Add a new test: ShowDicom, for now this is just the c++ version of
1332 checkRead.sh, later it will be able to compare the image read against a
1334 * Replace the DEBUG on the stack with a global entry in cmake interface:
1335 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1337 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1338 * Add an example subdir, with a real example on how to read + write a
1341 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1342 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1343 * Doc/CMakeLists.txt: the main page is now properly differentiated
1344 between the developper and user version.
1345 * Doc/doxygen.config.in: dropped search related obsolete flags
1346 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1348 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1349 * DEVELOPPER: added some helpfull comments for compile/test/install
1352 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1353 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1354 src directory, now generated in the build dir.
1355 2. Tests as mentionned smarter
1357 4. Add a new method in gdcmDict that return the PubDict by name
1358 this is interesting for 3rd party lib like ITK,
1359 where we could set the institution name / patient name...
1361 * ENH: 1. Now the test suite is working for real
1362 2. All binaries are now output in the gdcm-bin directory
1363 (this was not true before)
1365 2004-04-28 Jean-Pierre Roux
1366 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1367 SeQuence indented printing of Dicom Header.
1368 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1369 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1370 Computation of SQDepthLevel is now part of gdcmHeader constructor
1371 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1372 tree-like structure of a Dicom Header.
1373 * FIX Test code cleaning
1375 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1376 * ENH: Adding automatic testing
1377 1. Need a DartConfig.cmake to submit to public
1378 2. Add a test driver gdcmTest.cxx
1379 3. gdcmTestMain, an helper for the main test driver gdcmTest
1380 4. Files in Test don't have a main anymore, this becomes interesting
1381 when we add more and more tests, thus dsw don't have to load
1383 * ENH: Adding a GDCM_DATA_ROOT for testing
1384 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1385 one file instead of seven + some small cleanup
1387 2004-04-22 Jean-Pierre Roux
1388 * ENH Minor changes to the Print() methods.
1389 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1390 Header printing. Example given with :
1391 > PrintHeader fileName 2 new
1392 (SQ based tree-like structure still to be done for the Header ...)
1394 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1395 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1396 1. I have added some unsigned where needed
1397 2. Some function parameter not used -> (void)
1398 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1399 4. g++ don't like character '\' in comment
1400 5. #define jpeg_create_decompress jCreaDecompress
1401 this really need to be fixed
1402 6. virtualize destructor of gdcmObject ... leakage
1403 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1404 this also really need to be fixed
1405 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1406 remove compression file
1407 (as we only do decompression, right ?)
1408 * ENH: Change malloc/calloc/free with c++ equivalent
1410 2004-04-21 Jean-Pierre Roux
1411 * FIX gdcmHeaderHelper::GetXSpacing
1412 when a single value is found (bug ?), xpacing is now
1413 defaulted to yspacing
1415 2004-04-19 Jean-Pierre Roux
1416 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1417 * ENH add parameters :
1418 bool exception_on_error = false,
1419 bool enable_sequences = false,
1420 bool ignore_shadow = false
1421 to the gdcmFile constructors to be full gdcmParser compliant
1422 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1423 to allow reading of PAPYRUS 3.0 files
1425 2004-04-06 Jean-Pierre Roux
1426 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1428 2004-04-02 Jean-Pierre Roux
1429 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1430 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1431 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1433 2004-03-30 Jean-Pierre Roux
1434 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1435 for ACR file, written out as DICOM files (hope so...)
1437 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1438 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1439 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1440 moved to base class gdcmParser and only the specialisation is kept
1442 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1443 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1444 already does the job.
1445 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1446 (to be consistent with gdcmParser::WriteEntries).
1448 2004-03-30 Benoit Regrain
1449 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1450 upate of the object's instance. It's passed to 2 in the unfavorable
1451 case : one in the ExecuteInformation, one in the ExecuteData
1453 2004-03-29 Jean-Pierre Roux
1454 * ENH : Check on file type to be written moved
1455 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1456 * FIX : gdcmObject::ResetBoundaries now stops properly
1457 when end-of-list is reached
1458 : gdcmVersion modified (as Benoit Regrain asked)
1460 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1461 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1462 * src/gdcmUtil.cxx: added forgotten iostream include.
1463 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1464 equivalent to ExplicitVR in existing code).
1466 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1467 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1468 now contains all the gdcmGlobal related code.
1469 * minor coding style and doxygenation changes.
1471 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1472 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1473 now contains all the Debug related code.
1474 * minor clean-up of includes in src/*.cxx
1475 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1476 CreateCleanString) removed.
1477 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1478 * Doc/DoxyMainPageUser.txt added.
1479 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1480 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1481 src/gdcmDirList.cxx)
1483 2004-03-24 Jean-Pierre Roux
1484 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1486 2004-03-23 Jean-Pierre Roux
1487 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1488 big endian made volumes
1489 * ENH Now gdcmParser constructor and destructor are protected to forbid
1490 end user to instanciate class gdcmParser
1491 (only gdcmHeader and gdcmDicomDir are meaningfull)
1493 2004-03-22 Benoit Regrain
1494 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1495 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1496 gdcmSerie to gdcmDicomDirSerie
1498 2004-03-19 Jean-Pierre Roux
1499 * ENH Now the tree-like structure describing a DICOMDIR comming from
1500 an already existing DICOMDIR file is consistent with
1501 the home-made tree-like structure build ex-nihilo
1502 or build from the files held (recursively) in a Directory
1503 functions gdcmDicomDir::CheckBoundaries()
1504 gdcmObject::SetBoundaries() added
1506 2004-03-17 Jean-Pierre Roux
1507 * REM (Eric Boix bug) : removal of meaningless
1508 gdcmDicomDirImage::NewImage function.
1509 * FIX now file names and directory name are written properly in the
1511 * FIX now gdcmDicomDir constructor may be call without any trick
1514 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1515 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1516 of gdcmDicomDirImage::NewImage as empty function.
1518 2004-02-28 Jean-Pierre Roux
1519 * ENH add gdcmDicomDir:NewPatient
1520 add gdcmDicomDirPatient:NewStudy
1521 add gdcmDicomDirStudy:NewSerie
1522 add gdcmDicomDirSerie:NewImage
1523 to allow making gdcDicomDir object.
1524 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1525 (as opposite to the gdcmHeader chained list)
1527 2004-02-11 Benoit Regrain
1528 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1529 when using from python
1531 2004-02-10 Benoit Regrain
1532 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1533 * FIX : in gdcmDicomDir when the directory is empty
1534 * ENH : add callback and methods to get the progression of dicomDir
1537 2004-02-06 Jean-Pierre Roux
1538 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1539 - GDCM_META added to gdcmDicomDirType
1540 - class gdcmMeta created
1541 * ENH : - A brief summary is now displayed at the beginning of
1542 'testDicomDir' to help disaster magnitude estimation
1543 * REM : Now useless Test/explDICOMDIR.cxx
1545 2004-02-05 Benoit Regrain
1546 * ENH : add methods in gdcmObject to get the hash table or the list of
1548 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1549 * FIX : wrapping python for TagHeaderEntryHT
1551 2004-02-04 Benoit Regrain
1552 * FIX : even length for some strings when writting the dicom dir
1553 * FIX : sort the images in the dicom dir
1554 * FIX : Bug fix for python use of dicom dir
1555 * ADD : a python demo
1557 2004-02-04 Jean-Pierre Roux
1558 * FIX : Final solution (?) for icone embedded images
1559 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1560 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1561 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1562 gdcmData/gdcm-MR-SIEMENS-16.acr1
1563 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1564 to make full checking easier
1566 2004-02-04 Benoit Regrain
1567 * FIX : WriteEntries : coding style & logic in parameters
1568 * FIX : Set the elements to create the DicomDir in a dictionary file
1570 2004-02-03 Benoit Regrain
1571 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1572 * gdcmDicomDir : add the load of directory
1573 * Bug fix and print add-on
1575 2004-02-03 Jean-Pierre Roux
1576 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1577 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1578 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1579 * FIX gdcmParser.cxx : 'group length' elements are now considered
1580 as integers, even for shadow groups, when file is Implicit VR
1582 2004-02-02 Jean-Pierre Roux
1583 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1585 of the last synonym :-(
1586 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1588 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1589 * FIX taking into account the possible 7fe0,0010 multiplicity
1590 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1591 to allow removal of references to 7fe0,0010, to deal with
1592 ACR-NEMA images, when 0028,0200 is meaningfull
1594 2004-01-31 Jean-Pierre Roux
1595 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1596 no longer writes 'Un' on disk
1597 * FIX SQ elements with actual length are now dealt with corectly
1598 * FIX gdcmFile::WriteBase make the difference, for color images, between
1599 the length (for Palette expanded images)
1600 and Raw Length (non expanded image + Palette)
1601 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1602 (that broke Write). Replaced by UL.
1603 Aware user will reload the field if he
1604 thinks it's necesssary
1606 2004-01-30 Jean-Pierre Roux
1607 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1608 when 'dirty Acr' is found, to be compliant with the new
1609 IsReadable() methods.
1611 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1612 (no DOUBLE images in kosher DICOM,
1613 but so usefull for people that miss them ;-)
1615 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1616 DICOMDIR related utilities (not checked as Windoze compliant)
1618 2004-01-28 Jean-Pierre Roux
1619 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1621 2004-01-27 Jean-Pierre Roux
1622 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1623 to allow skipping the shadow elements, to save memory space.
1624 The TRUE value for this param has to be used
1625 with a FALSE value for the 'enable_sequence' param.
1626 ('public elements' may be embedded in 'shadow Sequences')
1627 * gdcmHeader methods now deal with 'embedded icones images' in the header
1628 (even when an 'icone image sequence' is announced by the
1629 element (0x0088,0x0200), but there is NO icone at all ...
1631 * gdcmHeader sometimes Image Location value doesn't follow
1632 the supposed processor endianity (see gdcmData/cr172241.dcm).
1635 * gdcmHeader add the method
1636 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1637 to get *all* the Header Entries with the same tag.
1638 GetHeaderEntrySameName is probabely *useless*
1639 (no meaning : Name is *not* an identifier within the Dictionnary)
1641 2004-01-26 Benoit Regrain
1642 * Bug fix in the print of hexadecimal representations. Remove long fields
1643 in the print and add a third level of print to print them
1645 2004-01-23 Benoit Regrain
1646 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1647 * Bug fix on test suite after remove the strip made on not string fields
1648 * Split the IsReadable method between gdcmParser which test that the file
1649 is dicom and gdcmHeader which test that it's an image file
1651 2004-01-22 Benoit Regrain
1652 * DicomDir : clean code, add methods, set variables in protected or private
1653 * gdcmUtil : bug fix for the clean string method
1655 2004-01-19 Benoit Regrain
1656 * Add the use of shadow dictionaries
1657 * bug fix and coding style
1659 2004-01-19 Benoit Regrain
1660 * src/gdcmFile.cxx : bug fix concerning the close of file
1661 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1662 * Add the update of header entries using the shadow library
1664 2004-01-19 Benoit Regrain
1665 * removal of file gdcmHeader2.cxx
1666 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1667 inheriting from gdcmParser. This split is to prepare the integration
1668 of dicom dir parsing
1669 * bug fix under python
1671 2004-01-16 Jean-Pierre Roux
1672 * REM removal of class gdcmHeaderEntrySet
1673 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1674 * ADD add file gdcmHeader2.cxx
1675 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1677 2004-01-15 Benoit Regrain
1678 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1679 entries created while parsing the header. Thus, they will be destroyed
1680 when the gdcmDictSet will be destroyed
1681 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1684 2004-01-15 Benoit Regrain
1685 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1686 made a fatal error because of the memory release at the end of program.
1687 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1688 some memory and vtk seems to have some problems with that.
1689 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1691 2004-01-14 Benoit Regrain
1692 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1693 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1694 * src/*.[h|cxx] : make changes due to class name changes
1695 * gdcmPython/demo/*.py : bug fix due to method names
1697 2004-01-13 Benoit Regrain
1698 * src/*.[h|cxx] : coding style
1699 * vtk/*.[h|cxx] : coding style
1701 2004-01-13 Benoit Regrain
1702 * gdcmPython/testSuite.py : test the readable flag of file for tests
1703 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1704 It's lied to the stl compilation by MSVC (windows, always windows...)
1705 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1707 2004-01-12 Benoit Regrain
1708 * src/*.h : add comments
1709 * src/gdcmDictSet.h : set the method BuildDictPath in public
1710 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1711 directly setted in the source code
1712 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1715 2004-01-09 Benoit Regrain
1716 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1717 * setup.py : use a reference to gdcmVERSION
1719 2004-01-07 Benoit Regrain
1720 * Modification to compile with the distutils.
1723 2003-12-10 Benoit Regrain
1724 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1725 can use a gdcmHeaderHelper to load datas
1726 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1727 made in the source code
1729 2003-12-10 Benoit Regrain
1730 * Update Windows projects and .cvsignore files
1732 2003-11-12 Jean-Pierre Roux
1733 * ENH gdcmHeader constructor has one more parameter (default value : false)
1734 that allows the user to 'go inside' the SeQuences only
1736 gdcmElValSet:Print takes it into account
1738 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1739 * ENH: Update gdcmPython/CMakeLists
1740 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1741 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1743 2003-11-10 Jean-Pierre Roux
1744 * FIX : gdcmHeader::LoadElements is now based
1745 on the ListTag listElem member,
1746 not longer on the TagElValueHT tagHt member
1747 * ENH : PrintPubElVal shows (temporarily) both results,
1748 with the tagHt member and the listElem member.
1749 (it's easier to 'see' the problems when using Printheader)
1751 * FIX : old private member LgrElem is now splitted into
1752 ReadLength : Length actually found on disk (updated only
1753 if bug fixing is necessary), for internal
1755 UsableLength : Updated by FixFoundLength, to fix a bug
1756 or to allow Parser going on.
1757 Will allow to re-write a kosher header when a SeQuence
1758 with a length (not 0000) is found
1759 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1760 because gdcmElValSet::Add does not update ListElem
1763 2003-11-07 Jean-Pierre Roux
1764 * FIX misstyping in Transfert Syntax name table
1765 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1766 when they have an actual length (not 0000 nor FFFFF)
1767 (Nobody should care of it, but DICOMDIR explorers)
1769 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1770 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1772 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1773 * ENH: vtkGdcmReader now supports LUT !
1774 (vtkgdcmViewer for now is not able to use them though)
1776 2003-11-05 Jean-Pierre Roux
1777 * in testSuite.py : new files names for checking the package
1778 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1779 that returns the pixel area size to the *aware* (vtk) user
1780 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1782 2003-11-05 Benoit Regrain
1783 * in testSuite.py : Modify the rules for checking the paths
1784 : Explicit error messages
1785 * in __init__.py : Related modif
1787 2003-11-03 Jean-Pierre Roux
1788 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1789 to be used by aware (vtk) users that want to manage
1790 LUT (and no to turn the PALETTE image into an RGB pixels one)
1791 * GetPixelType now returns 8U for 24 Bits images
1792 (vtkGdcmReader compliant)
1794 2003-10-31 Jean-Pierre Roux
1795 * Removal of *all* gdcmData images and add them again
1796 in order to loose the 'history' of un-anonymised images
1798 2003-10-31 Jean-Pierre Roux
1799 * RMV : removal of useless jBitsInJsample.h
1800 for both 8 and 12 Bits JPEG Lossy Libraries
1802 2003-10-31 Jean-Pierre Roux
1803 * ENH : Add the functions gdcmFile::GetImageDataRaw
1804 gdcmFile::GetImageDataIntoVectorRaw
1805 that act as GetImageData and GetImageDataIntoVector
1806 except the making of an RGB Plane from Gray Plane + LUT
1807 Intended to aware (vtk) users who know how to manage
1810 GetLUTRGBA return a R,G,B,A LUT if any
1811 lgrTotaleRaw gives the 'Raw' length
1812 GetImageDataRaw returns the gray Plane
1813 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1814 (They stay Grey, just like with other Dicom viewers :-(
1816 2003-10-30 Jean-Pierre Roux
1817 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1819 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1820 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1821 being coherents dicom files.
1823 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1824 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1826 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1827 * ENH: Two steps is necessary to please VC++ compiler...
1828 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1829 * ENH: Add include dir to medcon lib
1830 * FIX: only one function is being exported for now !
1831 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1833 2003-10-29 Jean-Pierre Roux
1834 * adding gdcmHeader::GetLUTRGBA
1835 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1836 --> Mathieu, the modif u're waiting for is not yet committed
1837 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1839 2003-10-27 Jean-Pierre Roux
1840 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1841 00191113.dcm DermaColorLossLess.dcm
1842 MxTwinLossLess.dcm RadBWLossLess.dcm
1843 * ENH: For version prior to vtkImageViewer2 -r 1.19
1844 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1846 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1847 * Removal of ido stuff in CMakeLists.txt
1849 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1850 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1851 * FIX: remove a call to ->Modified ... see comments
1852 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1854 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1855 * FIX: Problem with path for libvtkgdcmPython
1856 * ENH: Try adding a search script for python site-package
1857 * RMV: Remove some file from medcon lib that are not necessary
1858 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1859 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1860 * FIX: More pragma disable fro VC++,
1861 I don't think I break something as it is also disable in VTK/ITK.
1862 But it fasten debug compilation time.
1864 2003-10-23 Jean-Pierre Roux
1865 * gdcm now deals with 16 Bits Run Length Encoded images
1866 (they are compressed as 2 planes images,
1867 one for the high Bytes, the other for low Bytes)
1869 2003-10-22 Jean-Pierre Roux
1870 * Now CheckRead takes into account :
1871 - the bugged 'Leonardo' Siemens images
1872 - the XA images, sent thru the burning VPRO station
1873 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1876 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1877 * FIX: When copying a Makefile.am to CMakeLists.txt
1878 one should remove the '\'
1880 2003-10-22 Jean-Pierre Roux
1881 * in gdcmData adding a bugged 'Leonardo' Siemens image
1882 (wrong lengths in header)
1883 OK with gdcm, KO with the other viewers :-)
1884 * add a GE dlx XA image, thru the VEPRO burning station
1887 2003-10-21 Jean-Pierre Roux
1888 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1889 for a brutal checking of vtkgdcmViewer compliance
1891 2003-10-21 Jean-Pierre Roux
1892 * add the files for 'xmedcon' Jpeg Lossless library
1893 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1895 2003-10-21 Jean-Pierre Roux
1896 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1898 2003-10-21 Jean-Pierre Roux
1899 * garbage Siemens 'Leonardo' images dealt with
1900 (the patch is easy to remove)
1901 * cosmetic changes to avoid warnings
1903 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1904 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1905 no need to press 'r' now.
1907 2003-10-20 Jean-Pierre Roux
1908 * upgrade of checkRead.sh checkWrite.sh according
1909 to new Jpeg Lossless decompressor
1910 * add US.3405.1.dcm, a genuine RGB medical file ...
1911 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1912 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1914 2003-10-15 Jean-Pierre Roux
1915 * general anonymisation in gdcmData
1916 * adding the 'color files' from
1917 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1918 * adding some well knowed bugged-header images
1919 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1920 waiting for their inclusion in Python testsuite
1922 2003-10-15 Jean-Pierre Roux
1923 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1924 no longer seg faults when file is not found
1926 2003-10-14 Jean-Pierre Roux
1927 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1930 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1931 * TODO: *.in file to genereate a UseGDCM later
1933 2003-10-14 Jean-Pierre Roux
1934 * Some supposed-to-be Dicom Images have no preamble.
1935 OpenFile takes it into account
1936 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1937 * Missing elements added in dicomV3.dic
1938 (just to be affraid : have a look at
1939 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1940 and do it again next year ;->
1942 2003-10-13 Jean-Pierre Roux
1943 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1944 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1945 But there are NOT. It's fixed !
1947 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1948 * FIX: "jpeglib.h" was not found on VC++
1949 * FIX: vtkgdcm was not being installed
1951 2003-10-10 Jean-Pierre Roux
1952 * ENH : OpenFile closes the file if it *really* doesn't look like
1953 an ACR-NEMA / DICOM one.
1954 * FIX : testWrite no longer writes an empty file if the source file
1955 is not gdcm Readable
1956 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1959 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1960 * FIX: CMake generate now documentation
1961 * ENH: out of source doc build !
1962 * ENH: Generate both user and dev documentation
1963 * ENH: Should work on windows too
1964 * ENH: Only one doxygen config.in file is needed
1965 * FIX: make install should be ok now on ùnix plateform
1966 * FIX: PATH to dictionary was wrong (missing /)
1967 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1969 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1970 * vtkGdcmReader is now able to read rgb dicom file.
1971 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1972 * added a gdcmViewer to vtk test, use mouse to control
1973 window level & window width
1975 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1976 * CMake-ification of gdcm, we have now two build system
1977 * FIX: on cygwin Wsock32 doesn't exist
1978 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1980 2003-10-06 Emanuel Ollart
1981 * FIX : compilation process wad broken.
1982 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1984 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1985 * change gdcmViewer -> vtkgdcmViewer
1986 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1988 2003-10-06 Jean-Pierre Roux
1989 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1990 ( e.g : well known GE images with a wrong elem length,
1991 : Philips MRI Images with a wrong Huffman table)
1992 * still to be done : allow the reading of bugged LEONARDO Siemens images
1994 2003-10-03 Jean-Pierre Roux
1995 * Odd length strings are padded with '\0' (not with spaces,
1996 to remain compliant with already defined strings,
1997 like Transfert Syntax UID and others)
1999 2003-10-03 Jean-Pierre Roux
2000 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2001 to allow displaying RGB images (not only by affim ;-)
2003 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2004 * vtkGdcmReader is now able to read rgb dicom file.
2005 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2007 2003-10-03 Jean-Pierre Roux
2008 * A few nasty patches to allow the reading of a lot of nasty images
2009 ( e.g : well known GE images with a wrong elem length,
2010 : Philips MRI Images with a wrong Huffman table)
2011 * still to be done : allow the reading of bugged LEONARDO Siemens images
2013 2003-10-03 Jean-Pierre Roux
2014 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2016 2003-10-03 Jean-Pierre Roux
2017 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2018 to allow displaying RGB images (not only by affim ;-)
2020 2003-10-03 Jean-Pierre Roux
2021 * gdcmFile::GetImageDataIntoVector now
2022 - deals with MultiFrames MultiFragments Run Length Encoded files
2023 - deals with YcBcR (YBR_FULL) files
2024 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2025 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2027 (no sample found :-(
2029 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2030 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2031 Two reasons: - clear things
2032 - third parties acces gdcm through header files, so won't
2033 suffer anymore VC++ complains
2035 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2036 * add argv[1] in testvtkGdcmReader.cxx
2039 2003-09-24 Jean-Pierre Roux
2040 * The lines are now eigthy characters long.for
2041 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2043 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2044 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2045 char* to std::string. Thus, the use of strdup becomes useless. (see
2046 previous commis of Malaterre)
2047 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2048 before the last Malaterre's commit.
2050 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2051 * This commit should fix the Debug building under VC++, the problem
2052 was mainly a mixture of debug and release lib being loaded at startup.
2053 * I also remove a depency to a specific C function: strdup. Because I had
2054 to force the link to msvcrtd (whereas strdup is in libc).
2056 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2057 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2058 located in the gdcmCommon.h file. All use of reference of tha has been
2059 changed to now use the variable GDCM_UNFOUND.
2061 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2063 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2064 Dicom dictionary. The test suite can now be run again. Note:
2065 I'm note very happy with the " (RET)" changes. I believe this
2066 RETAINED comment should be dropped when parsing the dictionary.
2067 - PACKAGER corrected
2069 - AUTHORS updated and now in alphabetical order
2070 * Makefile.am now exports gdcm.dsw for Windoze users.
2072 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2073 * cygwin complains about missing std:: in subdir Test/
2075 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2076 * remove some methods that are now in gdcmHeaderHelper
2078 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2079 * vtkGdcmReader set spacing and origin correctly
2081 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2082 * Fix a few delete/delete[] mismatch
2084 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2085 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2086 interpretation to data given by gdcmHeader. For instance there are
2087 heuristics to get informations (look at different places).
2088 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2089 sorting DICOM images based on different strategies.
2090 * modified Makefiles accordingly.
2092 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2093 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2094 when building in debug mode
2095 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2096 src/win32/gdcmdll.dsp
2097 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2099 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2100 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2103 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2104 * src/win32/libgdcmjpeg12.dsp was not dos format
2105 * src/win32/libgdcmjpeg12.dsp :
2106 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2107 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2109 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2110 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2112 * src/gdcmFile.cxx : bug fix in affectation type
2113 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2114 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2115 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2116 symbols... future problem ?
2118 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2119 * src/win32/libgdcmijpeg12.dsp was missing
2120 * modified gdcm.dsw accordingly
2122 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2123 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2125 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2126 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2127 commit of JPR (before his hollidays to facilitate our work).
2128 * setup.py : bug fix in code. Modifications made while the last commit
2129 of JPR. The code hasn't been tested before the commit... it's so
2130 useless to make that (for best programmer that is JPR) !!!
2132 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2133 * tagged the current version as Version0_3 (i.e. version 0.3)
2135 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2136 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2137 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2138 * *.dsp : modifications to use new libgdcmijpeg8 library
2139 * setup.py : bug fix on VTKPATH variable
2140 * PACKAGER : adding all concerning windows
2142 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2143 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2145 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2146 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2147 test suite reported error.
2148 * PACKAGER file added (describes what a packager must do when
2149 packaging a new release).
2150 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2151 * configure.in: upgraded version number to 0.3.0
2152 * fixing build of rpm (through rpm -ta):
2153 - Doc/Makefile.am exports proper doxygen files
2154 - src/jpeg/libijg8/Makefile.am exports the include files.
2156 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2157 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2158 * src/gdcmHeader.h : formatting code
2160 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2161 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2162 We were obtaining error message from vtk. Now, creation of file list
2163 is made in an internal list to prevent this problem.
2164 Bug fix when output is empty.
2165 Bug fix in update of progress value. Previous commit for this was a bad
2167 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2169 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2170 * src/gdcmHeader.h : added method to get the file name
2171 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2172 files. Added method to remove all files on the input
2173 Added FIXME comment concerning the bad parsing of header made by
2174 ExecuteInformation method (in ExecuteData method)
2176 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2177 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2178 when using make instal.
2179 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2180 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2182 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2183 * setup.py : adding include dir of jpeg lib to compile all sources
2184 * */Win32/*.dsp : JPR fix for windows compilation
2186 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2187 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2189 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2190 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2192 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2193 * setup.py is again effective on un*x (takes into account the
2194 addon of the jpeg library)
2195 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2196 * Doc/Doxy* updated (includes above enhancements)
2197 * INSTALL now points to web documentation
2199 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2200 * src/gdcmHeader.h doesn't make unnecessary reference to
2202 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2204 * src/gdcm*.[cxx|h] :
2205 - to allow compilation with gcc 3.x
2206 -- clean up of STL usage (added explicit usage of std::)
2207 -- small fixes on exceptions.
2208 Note: linking not tested !
2209 - clean of doxygen comments to avoid warnings at documentation
2211 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2212 dependent convertion).
2214 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2215 * Clean up of previous JPR garbage commit (not even commented in the
2217 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2218 - moved all jpeg related files from src to src/jpeg/libijg8, with
2219 addition/modification of Makefile.am and configure.in.
2220 - the testSuite is still brain damage (not guilty).
2222 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2223 * WrapVTK.py : modifications to get correctly vtk source files to
2225 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2226 (FileName -> Filename)
2228 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2229 * vtk/vtkGdcmReader.[cxx/h]:
2230 - UpdateProgress method should now be effective
2231 - removed the limitation on having only images loaded (as opposed
2233 - when building a stack of images/volume, a lesser number of
2234 gdcmHeader and gdcmFile instances should be used (hopefully
2235 accelerating things).
2236 - when building a stack of images/volumes, files which are not
2237 loadable (wrong path-filename, wrong permissions on existing file,
2238 or file not parsable by gdcm) are replaced with a black image
2239 in the stack (for the caller to notice the problem).
2241 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2242 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2244 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2245 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2246 between standard library (std) and vtk library (problems are found
2247 under Windows... thanks Windows !)
2249 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2250 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2252 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2254 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2255 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2257 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2258 * When compiling with distutils (see setup.py) the C++ compiler is
2259 called with different flags than the default ones (with automake).
2260 In order to fix all those warning, I compiled gdcm with the command
2261 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2262 and went for warning fixes:
2263 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2264 up from unused variables.
2265 - vtk/vtkGdcmReader.cxx: potential bug fix.
2266 * src/gdcmHeader.h: Doxygen warning cleanup
2268 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2269 * gdcmPython/gdcm.i:
2270 - typemaps correction to take into account the systematic replacement
2271 of "using namespace std" with std:: prefix e.g. std::list,
2272 std::string... (cf changes of 2003-05-21).
2273 - gdcmGlob global variable of type gdcmGlobal (defined in
2274 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2275 exported to Python a as cvar.
2276 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2277 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2278 gdcmDictSet.GetPubDictTagNames() and
2279 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2280 C++ static methods).
2281 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2282 with the above changes.
2284 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2285 * setup.py, manifest.in : bug fix under linux
2287 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2288 * Modification of setup.py to compile vtk part too. Then, we have 2
2289 wrappers which must work with same distutils. For that, we have a
2290 generic distutils in distusiltsWrapping.py ; with :
2291 - build_extWrap class to wrap generically all extensions,
2292 - ExtensionWrap base class for all wrapping extension that contains
2294 - Wrapper interface which wrap sources
2295 + In WrapSwig.py we have extension and wrapper for Swig
2296 + In WrapVTK.py we have extension and wrapper for VTK
2297 * MANIFEST.in : modifications to consider vtk directory and new python
2298 files for compilation
2300 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2301 * Added python wrappers of vtkGdcmReader vtk class (see the
2302 source in vtk/vtkGdcmReader.cxx) :
2303 - vtk/Makefile.am now builds a library
2304 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2305 python library (as opposed to _gdcm.so wich are the python
2306 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2307 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2309 - configure.in has an additional flag --enable-vtk that needs
2310 to be set to enable compilation of vtk related code, that is:
2311 + vtk/vtkGdcmReader.so and
2312 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2313 + gdcmPython/vtkgdcmPython.so (see above)
2314 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2315 be read when compressed or when HighBit + 1 != BitsStored),
2316 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2317 the usage of the python wrapper of vtkGdcmReader vtk class.
2318 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2319 * src/*.[h] all occurences of stl classes are now prefixed with
2320 std::, and all occurences of "using namespace std;" where removed.
2321 This is to avoid pollution of global namespace in included files.
2322 Apparently vtk does not avoid this pitfall: when using both
2323 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2324 collision of various stl members (principally cout...).
2325 * gdcmPython/testSuite.py now cleanly removes temprory generated
2327 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2328 comply with above changes)
2330 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2331 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2332 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2333 vtk data structure (an image Flip was required).
2334 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2335 * cosmetic changes in documentation.
2337 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2338 * src/gdcmHeader.cxx: the constructor no longer exits when an
2339 unexisting file is given as argument.
2340 * The subdirectory Data (containing all the images used for the
2341 test suite) is not part of this repository anymore. A new module
2342 containing those images is now available at
2343 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2344 with the name gdcmData.
2345 All the python scripts (including the package initialisation file
2346 gdcmPython/__init__.py) were adapated to take this change into
2347 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2349 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2350 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2351 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2352 demo of the usage of this class.
2353 Compilation of this vtk part is only done when using the --enable-vtk
2354 at configure (or autogen.sh) stage.
2356 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2357 * More memory link related corrections and documentation fixes.
2359 - maximum info is obtained with a command of the form:
2360 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2361 --show-reachable=yes PrintHeader
2362 - the remaining reachable blocks seem to come from the STL
2363 allocation scheme through the usage of map and list. It looks
2364 like this memory cannot be freed but it is not a memory leak
2365 (in fact further invocation to the STL would recollect the
2366 unused memory allthough it cannot explicitely be freed).
2367 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2368 of displaying an image parsed with gdcm and displayed with VTK.
2369 Note: some images don't seem to work e.g.
2370 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2371 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2372 Allthough this weakens the semantics, it is a ditch attempt to
2373 make gdcm more thread friendly.
2375 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2376 * Memory link hunt (by using valgrind through the command
2377 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2378 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2379 gdcmHeader::_dicom_vr.
2380 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2381 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2383 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2385 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2386 * src/Makefile.am now exports all the necessary include files at
2390 * UpdateGroupLength replaced by new one
2393 * UpdateGroupLength re-written using H-Table
2394 (named UpdateGroupLengthNew untill checks are over)
2396 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2397 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2398 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2400 - gdcmHeader::GetPubElValSet removed.
2401 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2402 UpdateGroupLength, WriteElements, Write.
2403 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2404 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2405 carried the same semantics.
2406 - src/gdcmHeaderIdo.cxx changed accordingly.
2407 - gdcmFile::WriteBase now regroups all the codes from previous
2408 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2409 - enum FileType moved to gdcmCommon.h
2410 * src/gdcmHeader.cxx AddDefault trashed
2411 * gdcmGetXSize added
2412 * getimageDataSize now calls gdcmGetXSize
2413 * Test/*.cxx changed to agree with above changes
2415 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2416 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2417 (to avoid double call by end user).
2418 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2419 by end user, since gdcmHeader::gdcmHeader now handles it.
2421 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2422 * gdcm/Doc many doxygen changes:
2423 - Doxyfile now has two different versions, DoxyfileUsers that generates
2424 the html.users end users oriented documentation and
2425 DoxyfileDeveloppers that generates the html.developper developper
2426 oriented documentation.
2427 - README changed accordingly
2428 - requirement.txt removed (old design info moved to TODO).
2429 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2430 DoxyMainPage.txt, DoxyPython.txt provide more information.
2431 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2432 be updated by simply regenerating the docs with doxygen and copying
2433 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2434 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2435 all the tests in the form "if (<map>.count() >1)" were removed.
2436 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2437 ill-formed documentation sections.
2438 * src/gdcmHeader.cxx: ditto
2440 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2441 * setup.py fixed for un*x (needed macro for stdint.h)
2442 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2443 un*ces with sh-utils test utility.
2444 * gdcmPython/demo/test.py renamed to PrintHeader.py
2445 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2446 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2447 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2448 * src/gdcm*.cxx JPR's bad inclusion fixed.
2450 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2451 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2452 * gdcmPython/demo/test.py changed accordingly.
2454 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2455 * gdcmPython/Makefile.am fixed linking against libstdc++
2456 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2457 * Swig subdir (historical tests of swig version 1.3.17++) removed
2458 * Test/testChangeEntete.cxx some lines commented out in order to make
2460 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2461 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2463 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2464 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2465 hence the user doesn't need this explicit call.
2466 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2467 i.e. LoadElements() call removed.
2468 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2469 - src/Makefile.am declares the proper flag for g++.
2470 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2471 for adding user defined new tags.
2472 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2473 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2474 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2476 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2477 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2478 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2479 src/Makefile.am : the project should properly compile and install
2480 with the autotools, included the python wrappers part.
2481 * gdcm.spec.in : added a spec file for RPM packaging.
2483 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2484 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2486 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2487 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2488 to exported to the environement (see gdcmPython/testSuite.py
2490 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2491 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2492 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2493 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2494 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2496 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2497 * gdcmPython/__init__.py doesn't crash anymore when running in
2498 in InstallMode or PreInstallMode but with an environement given
2499 value of GDCM_DICT_PATH.
2500 * src/gdcmDictSet.[cxx/h] coding style.
2502 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2503 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2504 * src/gdcm.h general comments moved to TODO, and README
2505 * src/gdcm.h should now be seen as a user commodity (including it
2506 should suffice to fully use gdcm). It is nowhere including within
2507 any of the kernel files src/*.cxx and src/*.h.
2509 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2510 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2511 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2513 * src/gdcm*.cxx only include their corresponding include file
2514 (as opposed to gdcm.h)
2515 * gdcmPython/gdcm.i changed accordingly
2516 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2517 the autogen.sh generated "make snapshot" command to work.
2518 * autogen.sh removed history related references to crea package.
2520 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2521 * distutilsSwigCPlusPlus.py work around some swig portability
2524 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2525 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2526 was done in a last ditch attempt to get setup.py _really_
2527 operationnal. The python/gdcmPython layaout add the advantage
2528 of hidding away the python related distutils specific files
2529 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2530 Alas, the src directory was out of scope (i.e. it's relative
2531 position to setup.py was ../src) which made things impossible to
2532 handle (see previous version of python/setup.py). Crossing fingers...
2534 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2535 * python/setup.py now works on Un*x. (harder than I thougth)
2536 * python/distutilsSwigCPlusPlus.py can now have include files
2537 among the list of sources.
2539 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2540 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2541 * modifications in MSVC projects
2543 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2544 * As stated by the first lines of Test/ExceptionAndPython/README, it
2545 looks like we can move back to original usage of exception within
2546 src/gdcm* and hence remove the errno stuff that was introduced
2547 as a quick and dirty fixture of this problem (added to the TODO).
2548 * Doc/Doxyfile configuration file for Doxygen and corresponding
2549 README file for usage added.
2550 * Test/testWrite.cxx added. This new test comes from a split of
2551 test.cxx that is now reverted to its original purpous i.e.
2552 testing the proper parsing of a Dicom related file.
2553 testWrite.cxx concentrates on testing the IO part of gdcm.
2554 * Test/bug1.cxx (containing a bug on WIn32) added.
2555 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2556 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2557 whose purpose is to publish the content of the TagNames of the
2558 Dicom public dictionnary were not accessible without an
2559 instance of class gdcmHeader.
2560 - those methods are now static methods of gdcmDictSet and hence
2561 require no instances at all to be invocated.
2562 - within gdcmDictSet this change required to change some method
2563 to class methods (i.e. are now static) among which SetDictPath
2564 (renamed to BuildDictPath) and LoadDefaultPubDict.
2565 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2566 the above changes by calling the new method classes of gdcmDictSet.
2567 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2568 the above to be effective.
2569 * python/gdcmPython: in order to wrap properly the above changes
2570 for Python, swig version now needs to be > 1.3.17.
2571 * python/gdcmPython/Makefile fixed to adapt itself to new
2572 configure/make shema introduced by Johan Montagnat (thanks for the
2573 contribution). Alas this Makefile cannot be turned into a proper
2574 Makefile.am without some heavy changes in the configure.in
2575 (for python dectection).
2576 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2577 now avoids publishing the empty entries.
2579 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2580 * python/setup.py : bug fix concerning install under windows
2581 ExtraPath reused :-P
2582 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2584 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2585 * Dicts/dicomV3.dic : remove double spaces !!!
2586 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2587 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2590 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2591 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2592 method. Doxygenation.
2593 * src/gdcm.h clean up of JPR spurious comments.
2595 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2596 * python/distutilsSwigCPlusPlus.py now properly collects the
2597 shadow classes generated by "swig -c++" (gdcm.py in our case)
2598 when using "python setup.py install".
2599 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2600 reexports the working classes.
2601 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2602 by the classical C errno scheme. This is to prevent an obscure
2603 behavior of the python wrappers when importing wxPython.wx prior
2604 to gdcmPython (which ended up in an abort call). An illustration
2605 of this oddity can be found in the Test/ExceptionAndPython
2606 subdir (see the README file). This problem probably due to
2607 an combination of g++ and dynamic loading.
2608 * added Test/ExceptionAndPython (see above)
2610 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2611 * Changed the layout of the python part to avoid bloating main
2612 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2613 i.e. the distutils arsenal. All the python related stuff is
2614 again in a python subdir, but the package itself is now in
2616 * setup.py was cleaned up:
2617 - pythonIncludePath removed
2618 - python setup.py bdist target is now functional.
2619 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2620 collision with other packages). gdcmPython/demo/*.py changed
2623 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2624 * python subdir moved to gdcmPython (preparation of distutils packaging).
2625 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2626 distutils installer is operational.
2627 * - gdcmPython/__init__.py now properly loads the swig generated
2628 shadow classes (from gdcm.py).
2629 - gdcmPython/demo/*.py changed to import the package gdcmPython
2630 instead of gdcmPython/demo/load.py.
2631 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2633 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2634 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2635 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2636 entries within the associated public Dicom dictionary resp. the same
2637 information but sorted by the fourth field (PAT, IMG, DIR) of the
2639 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2640 are now in the "???" group.
2641 - python/gdcm.i changed accordingly,
2642 - python/demo/printGroupedPublicDict.py added, that gives an example
2643 of the above new functionalities in Python.
2645 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2646 * src/gdcm.h, gdcmHeader.cxx:
2647 - historic references to glib's g_malloc and g_free (#defined)
2648 were definitively removed.
2649 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2650 * src/gdcmElValSet.cxx:
2651 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2652 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2653 - GetElValue(string) renamed to GetElValueByName.
2654 - Added GetElementByName(string).
2655 * src/gdcmHeader.cxx: added
2656 - GetPubElValRepByNumber(guint16, guint16)
2657 - GetPubElValRepByName(string)
2658 - GetShaElValRepByNumber(guint16, guint16)
2659 - GetShaElValRepByName(string)
2660 - GetShaElValByNumber(guint16, guint16)
2661 - GetShaElValRepByName(string)
2662 - GetElValRepByNumber(guint16, guint16)
2663 - GetElValRepByName(string)
2664 - GetElValByNumber(guint16, guint16)
2665 - GetElValRepByName(string)
2666 * Doc/requirements.txt added.
2668 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2669 * Test/Makefile building now depends on the one of libgdcm.so
2670 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2671 pixel data) aware which enables finding the address (offset) of
2672 the pixel data of JPEG encoded DICOM files. This leaves only a single
2673 file in the testSuite whose pixel data address (offset) is unknown.
2674 * python/testSuite.py changed accordingly.
2676 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2677 * VC++ has some strong limitations when working with the STL, as stated
2678 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2679 "Also note that some STL containers (map, set, queue, list, deque)
2680 cannot be exported. [...]
2681 Some STL classes contain nested classes. These classes can not
2683 This is caused by a designed limitation that once a template
2684 class is instantiated, it can not be re-instantiated and
2686 Since our usage of map<> is ubiquitous in gdcm, this "designed
2687 limitation" of VC++ is a pitfall.
2688 Hence the Python wrappers of gdcm cannot be incrementally linked
2689 against the c++ dynamic library. The dirty but only workaround is
2690 to forget about incremental link of dynamic libraries and to generate
2691 the Python wrappers library with the inclusions of the underlying C++
2693 The following modifications concern this matter on Win32/VC++:
2694 - wrapping python correct with standalone wrapped dll (don't use separate
2695 dll under windows !!!!)
2696 - python21_d debug mode enabled (ask Frog how to use it :-)
2697 - NO problem with having an STL member of class for example string in C++
2698 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2699 - Python test of dcmlib in Python is ok under windows on a large set
2701 * removed glib references
2702 * typedef's inserted in gdcm.i for correct swig type management
2704 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2705 * python/demo/*.py load.py extracted from test.py. Added explore.py
2706 that only displays required tags and testAll.py that parses all
2707 the files of the testsuite without using unittest.
2708 * python/testSuite.py other additional test on new files added.
2709 * Data/* new test files added accordingly to the testSuite.
2710 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2711 the vr in the file differs from the one of the dictionary.
2713 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2714 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2715 values, but limits itself to values which are below a user specified
2716 size (by default 1024 bytes).
2717 * python/gdcm.i : elements not loaded (because their size is above the
2718 user specified treshold) are exported with their TagKey as key of the
2719 python dictionary. This enables the testsuite to make some checks
2720 on the unloaded elements (since we have their offset and size).
2721 * python/testSuite.py
2722 - now tests for the existence and proper value of the pixel data
2723 - two new examples added.
2724 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2726 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2727 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2728 aware. See the strategy comments in gdcmHeader::FindeLength().
2729 * Test/test.cxx now accepts a filename as first argument.
2730 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2731 * python/testSuite.py changed to integrate test on above files.
2733 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2734 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2735 the vr was also RET.
2736 * python/testSuite.py more tests added.
2738 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2739 * python/testSuite.py unittest test suite added (uses Data)
2740 * Data/* dcm and acr files for the test suite.
2741 * glib dependance removed from un*x version. We now use ISO C99
2742 7.18 Integer types (see stdint.h)
2743 - python/Makefile, src/Makefile src/gdcm.h
2744 * src/ when an explicit vr (like dicom files) suddenly poped an
2745 implicit element we use to mark the underlying DictEntry of the
2746 concerned ElValue with "Implicit". This strategy was damageable
2747 too the public or provite dictionaries, since some of their vr
2748 would be changed. Since Header::FindLength heavily relies on the
2749 detection by Header::FindVR of falsely explicit elements, I
2750 added an extra ImplicitVr member to ElValue (boolean).
2751 The rest of the changes we the necessary adaptations.
2753 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2754 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2756 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2758 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2759 * Adaptation for porting to VC++:
2761 o forced to use std namespace (for string to be known)
2762 o all class use __declspec export style on WIN32
2763 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2764 (in stdlib.h on Win32 but in std:: for gcc)
2765 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2766 variable GDCM_DICT_PATH.
2767 * src/gdcmHeader.cxx verbose comments made discrete.
2769 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2770 * python/gdcm.i: added a typemap that converts a C++ hashing table
2771 to native Python dictionary.
2772 * python/demo/test.py:
2773 - now uses the native dictionary for exploration of gdcmHeader.
2774 - takes an optional filename argument (the file to parse).
2775 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2776 PubElVals hashing table.
2777 * Dicts/dicomV3.dic removed error prone trailing spaces.
2779 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2780 * Python wrapping process moved away from src/Makefile to
2781 newly created python/Makefile (as well as gdcm.i)
2782 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2783 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2784 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2785 from the environement variable GDCM_DICT_PATH (when existing).
2786 * src/gdcmDict::GetTag bug fix.
2788 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2789 * Straightforward temporary fixes for swig to build the python wrappers.
2790 src/Makefile now has a python working entry [by working we mean
2791 that we can import de shadow classes without errors].
2793 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2794 * hashtest.cxx removed (since allready in Test)
2795 * src/gdcmlib.h renamed to src/gdcm.h
2796 * src/dcm.i renamed to src/gdcm.i
2797 * src/Makefile prepared for python wrapping
2799 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2800 * src/gdcmHeader.cxx :
2801 - Parsing of header is now separated from loading of element values
2802 (see gdcmHeader::LoadElements).
2803 - general clean up of hopefully all file access (creation of
2804 ReadInt16 and ReadInt32)
2806 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2807 * src/gdcmHeader.cxx :
2808 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2810 - SetLgrElem renamed to SetLength
2811 - GetLgrElem renamed to GetLength
2812 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2813 * src/gdcmElValSet.cxx fixed both GetElValue methods
2814 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2815 due to IdoDude was cleaned out.
2817 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2818 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2819 concentrates on finding the value representation (when it exists).
2820 RecupLgr now only finds the element value length, and it avoids
2821 returning the unecessary skL (skipped length).
2822 Also, offsetCourant was simply removed (with taille_fich) since
2823 it was redundant with the File position internals (by using
2824 ftell and fseek). This also made skL (see above in RecupLgr) usage
2826 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2827 on the libido specificities which are handled through class
2829 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2832 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2833 * Truckload of changes. Parsing of header is barely functional
2834 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2836 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2837 * src/gdcmHeader.cxx many addons of low level methods
2839 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2840 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2841 and _IdDcmSWAP_LONG.
2843 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2844 * This corresponds to all the changes decided at the meeting of
2845 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob