1 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * gdcmPython/Makefile.am fixed linking against libstdc++
3 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
4 * Swig subdir (historical tests of swig version 1.3.17++) removed
5 * Test/testChangeEntete.cxx some lines commented out in order to make
7 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
8 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
10 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
11 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
12 hence the user doesn't need this explicit call.
13 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
14 i.e. LoadElements() call removed.
15 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
16 - src/Makefile.am declares the proper flag for g++.
17 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
18 for adding user defined new tags.
19 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
20 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
21 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
23 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
24 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
25 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
26 src/Makefile.am : the project should properly compile and install
27 with the autotools, included the python wrappers part.
28 * gdcm.spec.in : added a spec file for RPM packaging.
30 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
33 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
34 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
35 to exported to the environement (see gdcmPython/testSuite.py
37 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
38 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
39 ElValue class renamed to gdcmElValue for obvious consistency reasons.
40 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
41 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
43 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
44 * gdcmPython/__init__.py doesn't crash anymore when running in
45 in InstallMode or PreInstallMode but with an environement given
46 value of GDCM_DICT_PATH.
47 * src/gdcmDictSet.[cxx/h] coding style.
49 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
50 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
51 * src/gdcm.h general comments moved to TODO, and README
52 * src/gdcm.h should now be seen as a user commodity (including it
53 should suffice to fully use gdcm). It is nowhere including within
54 any of the kernel files src/*.cxx and src/*.h.
56 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
57 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
58 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
60 * src/gdcm*.cxx only include their corresponding include file
61 (as opposed to gdcm.h)
62 * gdcmPython/gdcm.i changed accordingly
63 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
64 the autogen.sh generated "make snapshot" command to work.
65 * autogen.sh removed history related references to crea package.
67 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
68 * distutilsSwigCPlusPlus.py work around some swig portability
71 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
72 * Eventually, python/gdcmPython was renamed to gdcmPython. This
73 was done in a last ditch attempt to get setup.py _really_
74 operationnal. The python/gdcmPython layaout add the advantage
75 of hidding away the python related distutils specific files
76 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
77 Alas, the src directory was out of scope (i.e. it's relative
78 position to setup.py was ../src) which made things impossible to
79 handle (see previous version of python/setup.py). Crossing fingers...
81 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
82 * python/setup.py now works on Un*x. (harder than I thougth)
83 * python/distutilsSwigCPlusPlus.py can now have include files
84 among the list of sources.
86 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
87 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
88 * modifications in MSVC projects
90 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
91 * As stated by the first lines of Test/ExceptionAndPython/README, it
92 looks like we can move back to original usage of exception within
93 src/gdcm* and hence remove the errno stuff that was introduced
94 as a quick and dirty fixture of this problem (added to the TODO).
95 * Doc/Doxyfile configuration file for Doxygen and corresponding
96 README file for usage added.
97 * Test/testWrite.cxx added. This new test comes from a split of
98 test.cxx that is now reverted to its original purpous i.e.
99 testing the proper parsing of a Dicom related file.
100 testWrite.cxx concentrates on testing the IO part of gdcm.
101 * Test/bug1.cxx (containing a bug on WIn32) added.
102 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
103 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
104 whose purpose is to publish the content of the TagNames of the
105 Dicom public dictionnary were not accessible without an
106 instance of class gdcmHeader.
107 - those methods are now static methods of gdcmDictSet and hence
108 require no instances at all to be invocated.
109 - within gdcmDictSet this change required to change some method
110 to class methods (i.e. are now static) among which SetDictPath
111 (renamed to BuildDictPath) and LoadDefaultPubDict.
112 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
113 the above changes by calling the new method classes of gdcmDictSet.
114 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
115 the above to be effective.
116 * python/gdcmPython: in order to wrap properly the above changes
117 for Python, swig version now needs to be > 1.3.17.
118 * python/gdcmPython/Makefile fixed to adapt itself to new
119 configure/make shema introduced by Johan Montagnat (thanks for the
120 contribution). Alas this Makefile cannot be turned into a proper
121 Makefile.am without some heavy changes in the configure.in
122 (for python dectection).
123 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
124 now avoids publishing the empty entries.
126 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * python/setup.py : bug fix concerning install under windows
129 * gdcm.dsw : bug fix concerning path for libraries for python !!!
131 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * Dicts/dicomV3.dic : remove double spaces !!!
133 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
134 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
137 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
138 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
139 method. Doxygenation.
140 * src/gdcm.h clean up of JPR spurious comments.
142 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
143 * python/distutilsSwigCPlusPlus.py now properly collects the
144 shadow classes generated by "swig -c++" (gdcm.py in our case)
145 when using "python setup.py install".
146 * python/gdcmPython/__init__.py imports gdcm.py and only manually
147 reexports the working classes.
148 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
149 by the classical C errno scheme. This is to prevent an obscure
150 behavior of the python wrappers when importing wxPython.wx prior
151 to gdcmPython (which ended up in an abort call). An illustration
152 of this oddity can be found in the Test/ExceptionAndPython
153 subdir (see the README file). This problem probably due to
154 an combination of g++ and dynamic loading.
155 * added Test/ExceptionAndPython (see above)
157 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
158 * Changed the layout of the python part to avoid bloating main
159 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
160 i.e. the distutils arsenal. All the python related stuff is
161 again in a python subdir, but the package itself is now in
163 * setup.py was cleaned up:
164 - pythonIncludePath removed
165 - python setup.py bdist target is now functional.
166 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
167 collision with other packages). gdcmPython/demo/*.py changed
169 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
170 * python subdir moved to gdcmPython (preparation of distutils packaging).
171 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
172 distutils installer is operational.
173 * - gdcmPython/__init__.py now properly loads the swig generated
174 shadow classes (from gdcm.py).
175 - gdcmPython/demo/*.py changed to import the package gdcmPython
176 instead of gdcmPython/demo/load.py.
177 - gdcmPython/testSuite.py changed to import the package gdcmPython.
180 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
181 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
182 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
183 entries within the associated public Dicom dictionary resp. the same
184 information but sorted by the fourth field (PAT, IMG, DIR) of the
186 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
187 are now in the "???" group.
188 - python/gdcm.i changed accordingly,
189 - python/demo/printGroupedPublicDict.py added, that gives an example
190 of the above new functionalities in Python.
192 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
193 * src/gdcm.h, gdcmHeader.cxx:
194 - historic references to glib's g_malloc and g_free (#defined)
195 were definitively removed.
196 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
197 * src/gdcmElValSet.cxx:
198 - GetElement(guint32, guint32) renamed to GetElementByNumber.
199 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
200 - GetElValue(string) renamed to GetElValueByName.
201 - Added GetElementByName(string).
202 * src/gdcmHeader.cxx: added
203 - GetPubElValRepByNumber(guint16, guint16)
204 - GetPubElValRepByName(string)
205 - GetShaElValRepByNumber(guint16, guint16)
206 - GetShaElValRepByName(string)
207 - GetShaElValByNumber(guint16, guint16)
208 - GetShaElValRepByName(string)
209 - GetElValRepByNumber(guint16, guint16)
210 - GetElValRepByName(string)
211 - GetElValByNumber(guint16, guint16)
212 - GetElValRepByName(string)
213 * Doc/requirements.txt added.
215 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
216 * Test/Makefile building now depends on the one of libgdcm.so
217 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
218 pixel data) aware which enables finding the address (offset) of
219 the pixel data of JPEG encoded DICOM files. This leaves only a single
220 file in the testSuite whose pixel data address (offset) is unknown.
221 * python/testSuite.py changed accordingly.
223 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
224 * VC++ has some strong limitations when working with the STL, as stated
225 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
226 "Also note that some STL containers (map, set, queue, list, deque)
227 cannot be exported. [...]
228 Some STL classes contain nested classes. These classes can not
230 This is caused by a designed limitation that once a template
231 class is instantiated, it can not be re-instantiated and
233 Since our usage of map<> is ubiquitous in gdcm, this "designed
234 limitation" of VC++ is a pitfall.
235 Hence the Python wrappers of gdcm cannot be incrementally linked
236 against the c++ dynamic library. The dirty but only workaround is
237 to forget about incremental link of dynamic libraries and to generate
238 the Python wrappers library with the inclusions of the underlying C++
240 The following modifications concern this matter on Win32/VC++:
241 - wrapping python correct with standalone wrapped dll (don't use separate
242 dll under windows !!!!)
243 - python21_d debug mode enabled (ask Frog how to use it :-)
244 - NO problem with having an STL member of class for example string in C++
245 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
246 - Python test of dcmlib in Python is ok under windows on a large set
248 * removed glib references
249 * typedef's inserted in gdcm.i for correct swig type management
251 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
252 * python/demo/*.py load.py extracted from test.py. Added explore.py
253 that only displays required tags and testAll.py that parses all
254 the files of the testsuite without using unittest.
255 * python/testSuite.py other additional test on new files added.
256 * Data/* new test files added accordingly to the testSuite.
257 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
258 the vr in the file differs from the one of the dictionary.
260 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
261 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
262 values, but limits itself to values which are below a user specified
263 size (by default 1024 bytes).
264 * python/gdcm.i : elements not loaded (because their size is above the
265 user specified treshold) are exported with their TagKey as key of the
266 python dictionary. This enables the testsuite to make some checks
267 on the unloaded elements (since we have their offset and size).
268 * python/testSuite.py
269 - now tests for the existence and proper value of the pixel data
270 - two new examples added.
271 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
273 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
274 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
275 aware. See the strategy comments in gdcmHeader::FindeLength().
276 * Test/test.cxx now accepts a filename as first argument.
277 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
278 * python/testSuite.py changed to integrate test on above files.
280 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
281 * Dicts/dicomV3.dic removed all the trailing (RET) when the
283 * python/testSuite.py more tests added.
285 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
286 * python/testSuite.py unittest test suite added (uses Data)
287 * Data/* dcm and acr files for the test suite.
288 * glib dependance removed from un*x version. We now use ISO C99
289 7.18 Integer types (see stdint.h)
290 - python/Makefile, src/Makefile src/gdcm.h
291 * src/ when an explicit vr (like dicom files) suddenly poped an
292 implicit element we use to mark the underlying DictEntry of the
293 concerned ElValue with "Implicit". This strategy was damageable
294 too the public or provite dictionaries, since some of their vr
295 would be changed. Since Header::FindLength heavily relies on the
296 detection by Header::FindVR of falsely explicit elements, I
297 added an extra ImplicitVr member to ElValue (boolean).
298 The rest of the changes we the necessary adaptations.
300 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
301 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
303 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
305 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * Adaptation for porting to VC++:
308 o forced to use std namespace (for string to be known)
309 o all class use __declspec export style on WIN32
310 - src/gdcmUtil.cxx new Exit method that wraps the exit call
311 (in stdlib.h on Win32 but in std:: for gcc)
312 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
313 variable GDCM_DICT_PATH.
314 * src/gdcmHeader.cxx verbose comments made discrete.
316 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
317 * python/gdcm.i: added a typemap that converts a C++ hashing table
318 to native Python dictionary.
319 * python/demo/test.py:
320 - now uses the native dictionary for exploration of gdcmHeader.
321 - takes an optional filename argument (the file to parse).
322 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
323 PubElVals hashing table.
324 * Dicts/dicomV3.dic removed error prone trailing spaces.
326 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
327 * Python wrapping process moved away from src/Makefile to
328 newly created python/Makefile (as well as gdcm.i)
329 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
330 * src/gdcmHeader::FindLength only looks for current vr when necessary.
331 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
332 from the environement variable GDCM_DICT_PATH (when existing).
333 * src/gdcmDict::GetTag bug fix.
335 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
336 * Straightforward temporary fixes for swig to build the python wrappers.
337 src/Makefile now has a python working entry [by working we mean
338 that we can import de shadow classes without errors].
340 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
341 * hashtest.cxx removed (since allready in Test)
342 * src/gdcmlib.h renamed to src/gdcm.h
343 * src/dcm.i renamed to src/gdcm.i
344 * src/Makefile prepared for python wrapping
346 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
347 * src/gdcmHeader.cxx :
348 - Parsing of header is now separated from loading of element values
349 (see gdcmHeader::LoadElements).
350 - general clean up of hopefully all file access (creation of
351 ReadInt16 and ReadInt32)
353 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
354 * src/gdcmHeader.cxx :
355 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
357 - SetLgrElem renamed to SetLength
358 - GetLgrElem renamed to GetLength
359 - ~gdcmHeader() made virtual to pesky warning messages at compile.
360 * src/gdcmElValSet.cxx fixed both GetElValue methods
361 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
362 due to IdoDude was cleaned out.
364 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
365 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
366 concentrates on finding the value representation (when it exists).
367 RecupLgr now only finds the element value length, and it avoids
368 returning the unecessary skL (skipped length).
369 Also, offsetCourant was simply removed (with taille_fich) since
370 it was redundant with the File position internals (by using
371 ftell and fseek). This also made skL (see above in RecupLgr) usage
373 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
374 on the libido specificities which are handled through class
376 * Test/implicit_vr.dcm dicom v3 in implicit value representation
379 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
380 * Truckload of changes. Parsing of header is barely functional
381 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
383 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
384 * src/gdcmHeader.cxx many addons of low level methods
386 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
387 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
390 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
391 * This corresponds to all the changes decided at the meeting of
392 May 23 2002. Needless to say we are running late...