1 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
4 * Set the gdcm::Base class to some Printable classes
6 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmFile.[h|cxx] : add the Print method
8 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
9 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
10 * src/gdcmDocument.h : remove the PrintLevel informations
11 * Example/PrintFile.cxx : use the new gdcm::File::Print
13 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
15 problems when compiling with the python wrapping
17 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
19 writting in ImplicitVR
21 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
22 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
23 JPEG decompression, especially when dicom frames are split into several
24 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
25 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
27 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmHeader.cxx : change the initialisation of default header.
29 Now, this header is readable by gdm, e-film, DicomWorks
31 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
33 Rename Decompressed to Raw
34 * Use the API changes in gdcm::File.
35 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
38 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
40 each added entry in the header. Replace the 'Planes' field by the 'Number
43 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
45 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
47 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
49 At this time, this image isn't readable by e-film... waiting JPR help to
52 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
54 DocEntry. Now use methods of the Document !
56 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * Test/ShowDicomSeq.cxx : bug fix
59 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
61 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
62 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
63 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
65 * Test/TestCopyRescaleDicom.cxx : remove unused variable
66 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
67 containing found sequences
69 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
72 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
73 Some fields in BinEntry must be copied to not seg fault when making the :
74 gdcm::File *copy = new gdcm::File( copyH );
75 and tests are now made on good variables
77 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
79 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
81 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
82 * Add vtkGdcmWriter example and test
84 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * Test/TestUtil.cxx : reformat the source code
86 * vtk/vtkGdcmReader.cxx : remove and change prints
87 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
89 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
90 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
92 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
94 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
96 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
98 by an eof to prevent all bad read of the file... and in this case, the
101 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * Example/Volume2Dicom.cxx : comment unused variables
103 * Test/PrintDicomDir.cxx : comment unused variables
104 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
105 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
106 method that is redondant with AddEntry.
107 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
110 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
111 * Bug fix due my last commit (compilation under Windows).
112 * Example/Volume2Dicom : bug fix in the file and reformatting source code
113 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
115 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
117 - Remove printf / sprintf
118 - include iostream AFTER gdcm so we don't get warnings
119 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
121 - Also remove tons of include from header files, hopefully this should
122 speeup the compilation time, since it was becoming a dog slow.
123 - Remove gdcm.h as it include way too many files and slow down compilation
124 (plus it is not up to date)
125 - remove 'using namespace std' this is BAD !
127 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * Remove memory leaks on the DicomDir
129 * Remove some useless datas in DicomDirObject
130 * Add usefull methods in SQItem, to be complient withe the ElementSet
132 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
133 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
135 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
137 future, with convertion)
138 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
139 and ImageDataSize values. Remove the method to get the PixelReadConverter
140 from the output of the class
142 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
143 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
145 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
147 and vtkErrorMacro use.
148 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
150 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
153 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
154 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
155 The string leaves only in the fonction. So when we make a .c_str(), we
156 get the pointeur on the first element, element that will be destroyed
157 immediately after thee instruction.
158 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
159 file has been opened : the test must be made on the content of the
160 pointer and not directly on the pointer !
163 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
165 the python part recompiles
167 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
168 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
169 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
170 X session is killed (for my computer... it seems to not be identic on
173 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
174 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
175 avoid problems (otherwise, the difference test between the visible image
176 and the reference is incorrect. If the reference is greater than the
177 screen resolution, it's produce errors).
178 Can be used for only one image. Can be used with a visible flag.
179 * vtk/vtkGdcmReader.cxx : remove commented codes.
180 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
181 under windows at compilation
182 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
184 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
186 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
187 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
188 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
189 tests on the image size X, Y, Z
191 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
193 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
194 between the class name and the file name
196 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
197 * src/ : fix compilation warnings for the Write method (2 different
198 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
199 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
200 variable... create a static method in gdcm::Document to access to
201 this variable content.
203 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
205 file, to be accessed by other files (like gdcmFile). Remove commented
206 code. Move the change of the header to the gdcmFile, using the
208 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
209 To be sure of that (and simplify calls), the Write of the header now
210 gets a file name and not a file pointer (std::ifstream).
211 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
212 DocEntryArchive. Remove all open of the written file
214 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
215 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
217 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
218 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
219 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
221 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
222 some corresponding methods. Write correctly the file and check before
224 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
225 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
226 is now on RGB datas (as before my last commit
227 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
229 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
231 Add a print information of the type of the entry
232 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
233 It was in the gdcmFile, and all write have been regrouped
234 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
235 Write correctly all dicom files (in decompressed mode only at this time)
236 * Test/ : test on files are now made using Raw datas and not color datas if
238 * Example/PrintFile.cxx : add more printings
240 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * Amelioration of code, remove some code copy. For the loading of
242 BinEntry (in gdcmDocument), add the test to verify if the file is already
245 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
246 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
247 remove a DocEntry in the header (push an empty DocEntry)
248 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
249 lines. Bug fix in the initialization of the PixelConvert and the
251 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
252 use in TestCopyDicom (now this test can run under windows... but fails)
253 * Test/TestCopyDicom.cxx : amelioration of the test :
254 - test the pixels written
255 - add test points to quickly find where is the error
256 - can set a file name input and output in arguments
257 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
258 amelioration of the test output
260 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
261 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
262 all replaced DocEntry's
263 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
264 Now, each needed DocEntry to modify is duplicated, modified and inserted
265 to the header using DocEntryArchive. Thus, after save, we can restore the
266 header initial state.
268 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
269 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
271 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
272 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
273 correct to copy it. The DictEntry is specified at the DocEntry creation,
274 then, it musn't change in the time.
275 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
276 header correctly. At this time, the change is only made for the first
277 level of the Document. In the future, it might consider sequences.
278 The change is made by replacing a DocEntry by an other that is created
279 outside the class. The old value is kept. When we restore the header
280 status, the added DocEntry is deleted and replaced by the old value.
281 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
282 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
283 set the write type to explicit VR, implicit VR or ACR. Add methods to set
284 the write mode to native, decompressed or RGB (but not used at this time)
286 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
287 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
288 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
290 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
291 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
292 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
294 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
295 set because already copied when copying the BinEntry's of the header
296 * Test/TestAllReadCompareDicom.cxx : remove warnings
298 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
299 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
300 Two problems appear when doing it :
301 - with the gdcmFile : when the GetImageData method is called, the pixels
302 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
303 datas (pixels). And each structure destruct the datas when it's
304 destructed. So we have two destructions for the same datas. To solve it,
305 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
306 datas or not. If it doesn't own datas, then they will not destroyed by
308 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
309 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
310 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
311 create a double destruction of the same DocEntry's. So, to solve it,
312 the TagHT is simply cleared and the DicomDir* elements are destroyed.
313 * TODO : add an entry concerning memory leaks in the DicomDir
315 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
317 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
320 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
322 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
323 after it have been deleted
325 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
326 * FIX: src/* fix the doxygen warnings.
327 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
328 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
329 was erroneously defined with a size of 15 instead of 16. [many thanks
330 to Jean Michel Rouet for pointing out this bug].
332 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
333 1. Finish merging JMR patch for writting DICOM from scratch
334 2. Fix -hopefully- bug with MONOCHROME and space vs null character
335 3. Use const ref when possible
336 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
337 5. A few more comments
338 6. CreateUniqueUID can now be called without parameter"
340 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
341 * ENH: Slightly bigger patch:
342 1. Getting toward full integration of JMR patch for writting dicom from scratch
343 2. Update Test to test part of this patch: CreateUniqueUID
344 3. File was not close properly in gdcmDict
345 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
346 5. Use of const ref instead of copy (speed issue)
347 6. Remove temporary (duplicate) string in TranslateToKey
348 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
349 8. Do not repeat virtual in subclasses
350 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
352 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
353 * Apply first patch toward better string comparison when dealing with broken
354 DICOM files. Essentially the string could be padded with a space instead
355 of a null character as defined by standard
357 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
358 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
359 because never used... and in the same time, that's remove some memory leaks
361 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
362 * src/gdcmFile.cxx : now delete the PixelConvert instance.
363 * In examples and tests : change the type of image data variables from void*
364 to uint8_t*. Remmove all delete on image data variables
366 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
367 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
368 Verify the file pointer value before open the file, and if it's not null,
369 a verbose message is generated.
370 Close correctly the file when the file isn't considered dicom-like. The
371 correctly close is a call to CloseFile.
372 When closing the file pointer, test if its not null to close the file.
373 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
374 file. For an uncompressed image, the copied datas correspond in the least
375 case to the image size (calculated) or the image size specified in the
376 header. A verbose is generated if these two size mismatch
378 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
379 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
380 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
381 break under windows (with msvc6 compilation).
383 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
385 compiling with MSVC6)
387 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
388 * Bugs fix for the Windows build with VC6
389 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
390 needed (only for projects required VTK). If the VTK is included in all
391 projects, there is conflicts with the jpeg lib of vtk when compiling the
392 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
393 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
394 when compiling the gdcm_wrap.cxx file (created by the compilation of the
396 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
397 (like it's already made for the cout use). Otherwise, conflict with the
400 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
403 - comments on the DicomDir::Method related usage added.
404 - now that we use the namespace gdcm, a lot of internal classes do
405 NOT need to be wrapped anymore.
406 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
407 DicomDir::Method) new example added.
409 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
410 * Improve string manipulation. I now inforce the notion of 'DicomString'
411 A DicomString can contain as many \0 as they want
412 and it is *always* of even length.
413 We only support odd length for very rare case.
414 And in the near future this should be removed.
416 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
417 * /binary_write/ gdcm source. Now even on big endian we are writting
418 little endian. This should -heopfully- fix some tests
420 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
421 * Now the dictionary is compiled into gdcm lib. This is a default
422 behavior, thus any dic file specified is picked before failback to
423 the one comiled into lib
425 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
426 * Change internals for gdcmDict. Don't use any 'new' any more.
427 This should definitely solve any leak problem, and we should be
428 as fast as before, as long as don't modify too much the dictionary.
430 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
431 * STYLE: ivars should start with a capital letter.
432 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
433 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
435 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
436 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
437 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
438 new 2004 dictionaries added (thanks to JPR).
439 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
440 * CLEANUP_ROUND (15) for gdcmPixelConvert
441 - RLEFrame::NumberFragments is now of type unsigned int
442 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
443 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
446 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
447 * Initial work in gathering all transfer syntax accessors. clearly
448 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
449 ivars, but only one transfersyntax (class) ivar with equivalent method on
452 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
453 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
454 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
455 discussed (plus I didn't like having a 2000 lines patch not commited)
457 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
458 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
459 * CLEANUP_ROUND (14) for gdcmPixelConvert
460 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
461 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
462 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
464 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
465 anymore and hence avoids storing a copy of PixelConvert::Decompressed
466 into File::Pixel_Data.
468 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
469 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
470 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
471 * CLEANUP_ROUND (13) for gdcmPixelConvert
472 Substituted File::ParsePixelData() with PixelConvert::Print() new
474 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
475 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
476 method to those classes.
477 - src/gdcmFile.[cxx|h]:
478 -- Added a ::Print() method.
479 -- PixelConverter is now a reference instead of a member.
480 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
481 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
483 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
484 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
485 collaboration diagram and inheritance diagram should be generated with
487 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
488 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
489 pointlessly wrapped (see
490 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
491 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
492 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
493 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
494 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
495 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
496 -- File::Initialise: PixelConverter setup moved away to
497 PixelConverter::GrabInformationsFromHeader()
498 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
499 interpretation moved away to PixelConverter::BuildRGBImage()
501 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
502 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
503 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
505 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
506 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
507 displayed on Win32 when a brutal abort() occurs (because of uncatched
508 exception). See TODO new entry of this commit for more on this.
509 * TODO added new entry.
510 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
511 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
512 - HandleColor is no longer called from gdcmFile.cxx
513 - gdcmPixelConvert.cxx clean up on method arguments and internal
514 variable names for semantical coherence.
516 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
517 * Finished lossless transition, not only do we now read all lossless jpeg
518 images, without the need of the Cornwell lib, but we do read them properly now
519 * To reduce code (well to avoid code duplication), I defined a common place
520 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
521 redefine symbols. This is not prefect but this the best solution I found for a
522 compilation time jpeg option.
524 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
525 * Update jpeg ijg lib to support lossless jpeg implementation
526 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
528 * Also added a special copyright for dcmtk since we use their bugfixes.
531 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
532 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
533 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
534 matters, as stated in warning note at begining of %include section).
535 * src/gdcmDicomDir*.[cxx|h]: coding style
536 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
537 * src/gdcmJpeg8.cxx: doxygen fix.
538 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
539 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
540 from File:: to PixelConvert::.
542 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
543 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
544 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
545 - more code moved away from File:: to PixelConvert::
546 - fat setup of PixelConverter set in place in File::Initialise.
548 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
549 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
550 namespace at the file system level. So now you should convert your examples
552 gdcmHeader -> gdcm::Header
553 It would be nice if people keep in mind to no open the namespace, since it
554 allows compilation on broken plateform which were defining common symbol in
555 the standart namespace (like LP, Unknown ...)
557 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
558 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
559 The JPEG fragments are now parsed at the same stage than the RLE
560 information. All code related to JPEG is now in gdcmPixelConvert:
561 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
562 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
563 export a gdcmFile:: method. Those are simply global functions
564 (for the time being this is better than having them attach to
565 either gdcmFile:: or gdcmPixelConvert::).
566 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
567 and stores the result in a gdcmJPEGFragmentsInfo.
568 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
569 code (among other stuff) moved away from gdcmFile:; to
572 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
573 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
574 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
575 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
576 clean up of RLE related code.
577 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
578 - src/gdcmRLE.cxx removed
579 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
580 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
581 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
582 * CLEANUP_ROUND (9) for gdcmPixelConvert
583 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
584 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
585 away from gdcmFile:: to gdcmPixelConvert::.
587 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
588 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
589 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
590 This is because Parse7Fe0 used to parse the pixels to compute the
591 length. This task was passed over to FindDocEntryLengthOB() a long
592 time ago, EXCEPT I had forgotten the OW case...
593 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
594 we just recylce the code for parsing RLE fragments and computing
596 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
597 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
598 with the retired Parse7Fe0().
599 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
600 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
602 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
603 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
604 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
605 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
606 - src/CMakeLists.txt: alphabetic order reodering + new entries.
607 * CLEANUP_ROUND (4) for gdcmPixelConvert
608 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
609 to return an unused length.
611 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
612 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
613 this should be cleanner from the plane view. The iostream are erally a pain
614 to use to do simple stuff.
616 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
617 * Redo the compilation of the ijg jpeg library. Now only one source is
618 necesseray. No need to rename file by hand what so ever. CMake handle the
619 copying of the file within different directory, configure header file to
620 modify some symbol. The only addition made to ijg wasd a mangle table so
621 that symbol are different wether we are within 8bits or 12bits.
623 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
624 * Added documentation of vtkgdcmReader on Website:
625 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
626 with it's binary name).
627 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
628 the Website to be more complete.
629 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
630 doxygenated documentation.
631 - Doc/DoxyVtkGdcmReaderExamples.txt added
632 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
633 DoxyVtkGdmReaderExamples.html )
634 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
635 * CLEANUP_ROUND (3) for gdcmPixelConvert
636 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
638 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
639 * CLEANUP_ROUND (2) for gdcmPixelConvert
640 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
642 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
643 * CLEANUP_ROUND for gdcmPixelConvert:
644 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
645 - src/gdcmPixelStuff[h|cxx] removed
646 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
647 - src/CMakeLists.txt changed accordingly
649 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
650 gdcmVersion.py moved to newly created ATTIC related
651 gdcmPython/SetupOldies/ directory.
652 * Autotools clean up:
653 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
654 - autogen.sh configure.in acinclude.m4 python.m4 removed
656 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
657 * src/*.cxx *.h Reference to License.htm fixed to License.html.
658 * Doc/CMakeLists.txt, doxygen.config.in: fix.
659 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
661 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
662 * TODO updated with Mathieu suggestions. I proposed a template for
663 describing TODO entries and used it for new entries.
664 * Added Doc/Website/CodingStyle.html, Developpers.html,
665 DeveloppersPython.html, GdcmDataCvs.html and
666 DownloadVersion0_1.html, DownloadVersion0_3.html.
667 * Some Doc/*.txt Doxygen files (which do not really concern the
668 documentation itself, but the website) moved to html and
669 placed in directory Doc/Website:
670 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
671 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
672 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
673 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
674 * CMakeLists.txt changed accordingly.
675 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
676 DeveloppersPython.html
677 * INSTALL nows refers to Doc/Website/Installation.html
679 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
680 * Added Doc/Website directory, that contains a first raw version
683 2004-09-23 Jean-Pierre Roux
684 * FIX In order not to be poluted any longer by casting problems,
685 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
686 we can now delete[] it safely
687 * VoidArea is now called BinArea (less confusing name),
688 and all the methods called ...VoidArea... are now ... BinArea...
689 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
691 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
692 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
693 clear) TagHT, which is an inherited member of gdcmElementSet. It is
694 up to the destructor of gdcmElementSet to clean up TagHt and it's
697 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
698 * Test/CMakeLists.txt: update to follow gdcmData renamings.
699 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
701 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
702 * ENH: added some utility method that builds a flat dictionnary
703 holding all the Dicom entries contained in the recursive structure
704 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
706 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
707 BuildFlatHashTable() that build a flat dictionary.
708 - src/gdcmElementSet.h: added a new private GetTag() accessor.
709 gdcmDocument is now a friend of gdcmElementSet.
710 - src/gdcmElementSet.cxx: clean up.
711 - Example/FlatHashTablePrint.cxx added.
712 - Example/CmakeLists.txt changed accordingly
714 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
715 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
716 moved away from gdcmDocEntrySet (since this class is an abstract class
717 acting like an interface). SQDepthLevel and BaseTagKey are now
719 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
720 and associated accessors. Doxygenation of the class.
721 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
723 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
724 Use SQDepthLevel accessor instead. ::Print() adapted.
725 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
726 - src/gdcmDocument.cxx changed accordingly.
728 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
729 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
730 - The following is the doxygen comment of the typedef declaration
731 of gdcmagKey in src/gdcmCommon.h:
732 gdcmTagKey is made to old an "universal" (as in URL, Universal
733 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
734 A dicom tag allways has a group and an element, but a set of tags
735 embeded in various (optionally nested) sequences and sharing
736 the same group and element all share the same (group, element)
737 "identifier". Hence the (group, element) cannot be used as an
738 identifier (in gdcm we shall refer to a "TagKey") of a tag.
739 In order to construct a proper tag identifier (i.e. a key) we
740 consider the following definition of a TagKey:
741 - let Group, Element be the string representation of the
742 group and element dicom tag members,
743 - let ItemNumber be the string representation of the integer
744 index of the considered item number of a sequence,
745 Let the key of a tag embeded in a sequence, noted SeqTag, be
747 /ItemNumber#Group|Element
748 where "/", "#" and "|" are characters acting as separators.
749 Then the general form of a gdcmTagKey is given by:
750 Group|Element<SeqTag>
751 where <SeqTag> means NO or many instances of SeqTag.
752 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
755 but the gdcmTagKey of a tag "embeded" is the first item of
756 a sequence, itself nested in the third item of a sequence is the
758 0004|1220/2#0008|0082/0#0008|0090
759 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
760 order to hold the new sequence compatible key. Previously, the
761 GetKey() method would look in the underlying gdcmDictEntry.
762 - src/gdcmDocEntry.cxx:
763 -- constructor now copies the underlying DictEntry key, in the local
765 -- ::Print: displays the member Key, instead of the (group, element).
766 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
767 - src/gdcmDocEntrySet.h:xi
768 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
769 -- now has a new BaseTagKey member.
771 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
772 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
774 This poses the problem with the semantics of the following lines
775 LoadEntryVoidArea(0x0028,0x1201); // R LUT
776 LoadEntryVoidArea(0x0028,0x1202); // G LUT
777 LoadEntryVoidArea(0x0028,0x1203); // B LUT
778 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
779 to the long FIXME note for what the problem is. Nevertheless in
780 order to get things working the dicom dictionary was altered !
781 Please fix things urgently...
782 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
783 information), see above note on moving the member VoidArea. Nevertheless
784 the following entries previously correctly set as US are now inproperly
786 0028 1201 OW IMG Red Palette Color Lookup Table Data
787 0028 1202 OW IMG Green Palette Color Lookup Table Data
788 0028 1203 OW IMG Blue Palette Color Lookup Table Data
789 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
790 of gdcmDocEntry moved to gdcmSeqEntry.
791 * src/gdcmSeqEntry.cxx: STYLE.
793 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
794 * Test/TestAllEntryVerify.cxx minor fix and added comments.
796 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
797 * gdcmPython/testSuite.py: all the test suite in python is now moved
798 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
799 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
800 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
802 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
803 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
804 to avoid inclusion recursion until STL is reached.
805 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
806 mecanism. errno.h is not included in gdcm anymore.
807 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
808 (gdcmFormatError now inherits from gdcmFormatUnexpected).
810 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
811 gdcmData/TestAllEntryVerifyReference.txt
812 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
813 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
814 exception_on_error parameter.
815 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
816 - vtk/vtkGdcmReader.cxx changed accordingly,
817 - Example/*.cxx and Test/*.cxx changed accordingly.
819 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
820 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
821 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
822 enable_sequences removed from gdcmHeader constructor and dependencies.
823 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
824 * gdcmPython/demo/PrintHeader.py: dummy fix.
825 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
826 skip_shadow removed from gdcmHeader constructor and dependencies.
827 * Example/*.cxx and Test/*.cxx changed accordingly.
829 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
830 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
831 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
833 2004-07-21 Jean-Pierre Roux
834 * FIX Now, Parsing and Printing a DICOMDIR do work!
835 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
837 2004-07-20 Jean-Pierre Roux
838 * FIX Some brain damaged headers have Zero-Lenght fields
839 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
841 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
842 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
843 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
844 variable (instance of gdcmDebug) by a definition macro, and the instance
845 is now in static in the gdcmDebug class
846 * src/gdcmSQItem.h : (FIXME) remove an undefined method
847 * Test/PrintAllDocument.cxx : bug fix in the result of the test
849 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
850 * WARNING: ctest now depends more tightly on gdcmData. You should
851 check out gdcmData properly for things to run smoothly...
852 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
853 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
854 we need the pixels not be loaded in order to use the ValEntry
855 that displays position and size).
856 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
857 This is a C++ based equivalent of gdcmPython/testSuite.py that should
858 be deprecated. If you have any doubts about the advantages of a
859 modern scripting language (read Python) versus grass root C++ (i.e.
860 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
861 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
862 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
863 Anyhow, consider documenting the gdcmData images in
864 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
866 * Test/CMakeLists.txt:
867 - now uses TestAllEntryVerify.cxx
868 - specific comments on oldACR00001.ima (now renamed in gdcmData
869 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
870 gdcmData/TestAllEntryVerifyReference.txt
873 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
874 * src/*.[h|cxx] : typedef clean up
875 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
876 - TagKey renamed to gdcmTagKey (for external usage)
877 - VRKey renamed to gdcmVRKey (for external usage)
878 - removal of typedef duplication.
879 - Removed all unecessary inline keyword from class inline definitions.
880 - Some method|function(void) declarations replaced with method|function().
881 * src/jpeg/libijg12/jdhuff12.c:
882 - printf polluting ctest removed.
883 - TAB removal for comminting
885 - TestAllReadCompareDicom.cxx: added a test that compares all the
886 images in gdcmDataImages.h with corresponding images in
887 gdcmData/BaselineDicom/. When baseline images are not present
888 this test creates them.
889 Note: we need to validate each reference image, but before that
890 I'd like to rename them with a more explicit name...
891 - CMakeLists.txt: changed accordingly.
892 * Example/*.cxx: examples now only include gdcm.h (as opposed to
893 including each header needed).
895 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
896 * Test/*.cxx and Example/*.cxx: moved some examples away from the
897 test suite to the Example directory. Are concerned:
902 - TestWriteSimple.cxx
903 * Test/CMakeLists.txt: added some comments on reasons for black listing
904 image gdcmData/oldACR00001.ima
906 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
907 * Test/CmakeList.txt: removed the following from black list (to be coherent
908 with removal from gdcmData):
909 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
910 - gdcm-MR-PHILIPS-16.dcm
912 Added the following because after last cvs update, they cause
913 ctest -R TestReadWriteReadCompare
915 - gdcm-MR-SIEMENS-16-1.acr
917 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
918 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
919 new comments in this file) we temporarily (sigh) move to a weaker
921 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
922 we don't need to black list the following images anymore:
923 - 8BitsUncompressedColor.dcm
925 - US-PAL-8-10x-echo.dcm
926 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
927 fixes and the beautified code ;-)
928 This fixes the bug introduced in version 1.42 (when beautifying)
929 that made the parsing of 8BitsRunLengthColor.dcm unproper.
930 Note: ctest was blind to this bug (this means we need to still
931 improve the test suite). The bug could be detected by using
932 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
934 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
935 and by displaying the (garbage) produced file temp.XDCM...
937 2004-06-29 Jean-Pierre Roux
938 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
939 - replace by uggly but working old code :-(
940 A lot of things should be OK again.
941 It's really urgent to have a test suite that *tests*,
942 to prevent Frog's beautifying sessions to break all the stuff
943 (twice, withing a fortnigh ...)
945 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
946 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
947 redundancy) to added Test/TestReadWriteReadCompare.cxx
948 * Test/CmakeList.txt: because the compare test of
949 Test/TestReadWriteReadCompare.cxx fails, the following images are
950 black listed: - 8BitsUncompressedColor.dcm
952 - US-PAL-8-10x-echo.dcm
953 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
954 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
955 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
956 and ad-hoc kludge. This kludge is now removed, and on encountering
957 such an image (OB field brain damaged) we set errno. Then in
958 ::FindDocLength() we "fix" the length as being ALL what remains
959 in the file (until EOF). We then proceed, hoping for the best...
960 This fixes a SegFault in ShowDicom when trying to write such an
962 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
963 (because TestWriteRead breaks on it, after a non conformal commit?).
964 ctest now runs properly, except for MakeDicomDir (which was allways
965 broken) and the Python related stuff (still not fixed).
967 2004-06-24 Jean-Pierre Roux
968 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
969 FIX : Test/TestReadWrite now iterates on all the file names
970 (instead of infinite loop)
971 ENH : Test/TestWriteRead now iterates on all the file names
973 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
974 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
976 2004-06-24 Jean-Pierre Roux
977 FIX : - now Write drops LUT Descriptors and LUTs (if any)
978 when SamplesPerPixel =3
979 - now Write is no longer confused by
980 'BitsAllocated = 12" and 'BitsStored=12"
981 - "UN" value representation Elements are now written correctly
982 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
983 ENH : - now gdcmHeader has its own Write methods
984 (in order to split the job that has not to be done
987 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
988 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
989 loop on the same image until memory went out.
990 Note: this means we still have gobs of memory loss in PrintDocument
991 * src/gdcmDocument.cxx: fixes problem on parsing on file
992 gdcmData/16BitsJpegLosslessGrayScale.dcm.
994 2004-06-24 Jean-Pierre Roux
995 FIX : Write - All the Sequences and Sequence Item are now written
996 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
997 is added a the end, when necessary.
998 - A lot of brain-damaged images, that were read correctly are
999 now written correctly
1000 - length compatible BinEntry are now loaded correctly
1001 (even for odd groups)
1002 Note : only Explicit Value Representation was checked.
1003 (question : is implicit VR really necessary for gdcm ?)
1005 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1006 * DEVELOPPER: added a proposition of coding style.
1007 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1010 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1011 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1012 Use the gdcmDocEntry::Print() and Write() instead.
1013 * src/gdcmDocument.cxx: bug fix.
1015 2004-06-22 Jean-Pierre Roux
1016 FIX : gdcmDocument.cxx
1017 - Now we do recognize the JpegLossLess format (there was a misstyping in
1018 code 'beautyfication' :-(
1019 - Now we automaticaticaly load the Luts, if any
1021 2004-06-22 Jean-Pierre Roux
1022 In order : to write Sequences, whatever their imbrication level,
1023 : to allow user to create his own Sequences
1024 a lot of modif where necessary (adding, moving, or virtualising methods)
1026 WARNING : save your own sources *before* cvs up !
1029 ADD virtual void Write(FILE *fp, FileType filetype);
1032 ADD virtual void Write(FILE *fp, FileType filetype);
1033 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1036 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1037 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1038 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1039 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1040 ADD std::string GetEntryByName(TagName name);
1041 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1043 std::string vr = "unkn",
1044 std::string fourth = "unkn",
1045 std::string name = "unkn");
1046 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1047 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1048 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1049 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1050 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1051 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1052 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1053 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1056 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1057 ADD virtual std::string GetEntryByName (TagName tagName);
1058 ADD virtual std::string GetEntryVRByName (TagName tagName);
1059 REM virtual bool Write(FILE *, FileType);
1060 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1061 FILE *_fp, FileType type);
1062 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1063 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1064 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1065 REM virtual std::string GetEntryByName (std::string tagName);
1066 REM virtual std::string GetEntryVRByName (std::string tagName);
1067 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1068 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1069 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1071 std::string vr = "unkn",
1072 std::string fourth = "unkn",
1073 std::string name = "unkn");
1074 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1075 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1076 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1077 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1080 ADD virtual void Write(FILE *fp, FileType filetype);
1083 ADD virtual void Write(FILE *fp,FileType filetype);
1086 ADD virtual void Write(FILE *fp, FileType filetype);
1087 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1088 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1089 REM std::string GetEntryByName(TagName name);
1092 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1094 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1095 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1096 The default constructor invoked by the line
1097 gdcmHeader *f1 = new gdcmHeader( header );
1098 was gdcmHeader::gdcmHeader(bool) instead of the expected
1099 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1100 Hence the parsing wasn't executed... See also below.
1101 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1102 as explicit constructor didn't do the trick to fix the above problem.
1103 Could anyone explain why ?
1104 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1105 properly calls gdcmValEntry::Print() (that was weed out from
1106 code related to gdcmBinEntry).
1108 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1109 * In order to fix memory leaks:
1110 - Test/TestWriteSimple.cxx: added cleaning of free store through
1112 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1113 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1114 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1115 (through the call to ::AddDicomDirMeta()) or the destructor
1116 would crash when deleting uninitialized ::metaElems].
1117 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1118 - src/gdcmDocument.cxx:
1119 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1120 from dynamic stores.
1121 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1122 was causing memory leaks.
1123 - src/gdcmSQItem.cxx:
1124 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1125 cleanly handled with polymophism: sorry but my milage is low).
1126 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1127 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1128 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1129 This avoids SegFaulting.
1130 - src/gdcmSQItem.h: coding style.
1132 - Test/TestWriteSimple still severely sucks. The output image content
1133 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1134 damaged when displayed with vtkgdcmViewer.
1135 - on memory leaks: TestWriteSimple leaks really less (see entry
1136 of 2004-06-18 in Changelog file for the call to valgrind).
1137 - on segfaults: ctest now passes all the tests but one (no more
1139 * Erroneous leading white fix:
1140 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1141 white[s] (as opposed to from >> xxx, that removes it [them].
1142 - src/gdcmTS.cxx: ditto.
1143 - gdcmPython/testSuite.py: dirty related kludge removed.
1144 * src/*: remaining references to gdcmParser removed.
1145 * src/*[cxx|h]: added copy[way]left header.
1148 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1149 * In order to fix writing of dicom files:
1150 - Test/TestWriteSimple.cxx: a simpler example of writing.
1151 - Test/CMakeLists.txt changed accordingly.
1152 - src/gdcmDocument.cxx:
1153 -- The destructor now recursilvely removes potential sequences.
1154 -- Bug fix in ::IsJPEG2000()
1155 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1156 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1158 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1159 to only declared) and build on top of
1160 ::GetDocEntryByNumber(guint16, guint16).
1161 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1162 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1163 for usage in destructor and treatement of promotion in
1164 ::ReplaceOrCreateByNumber().
1165 - src/gdcmSQItem.cxx: destructor should better handle his job.
1166 Test/TestWriteSimple now runs (or at least it DOES something).
1167 * We can now start hutting memory links. A good starting point is:
1168 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1169 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1170 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1172 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1173 * Valgrind note: after Mathieu Malaterre teached me how to read
1174 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1176 Using gcc, you can force the STL to use malloc and to free memory as
1177 soon as possible by globally disabling memory caching.
1178 With 3.2.2 and later, you should export the environment variable
1179 GLIBCPP_FORCE_NEW before running your program.
1180 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1181 simply vanish (it is still not clear to me, whether this means that
1182 STL std::string leaks or if valgrind believes it leaks...).
1183 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1184 running bin/gdcmTests makeDicomDir):
1185 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1186 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1188 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1189 SegFaulting (I drowned in DicomDir related code when trying to
1190 understand why the list is empty...).
1191 * src/gdcmDocument.h: first BSD license header try.
1192 * Doc/License.txt added.
1194 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1195 * src/gdcmDocument.[h|cxx]:
1196 - Clean up of the Transfer related predicates. They are now all based
1197 on new method isGivenTransferSyntax, that (should) handle properly
1198 the padding problem.
1199 - general clean up, simplification, and coding style.
1200 - Specific clean up of Parse7FE0() (umproperly named actually).
1201 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1203 2004-06-14 Jean-Pierre Roux
1205 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1206 - fix the display of SQItem ordinal number
1207 - add the GetSQItemByOrdinalNumber method
1208 - remove some useless never written private methods
1210 2004-06-14 Jean-Pierre Roux
1212 - adding a constructor taking a gdcmDocEntry as an input param
1213 - ReplaceOrCreateByNumber now returns :
1214 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1215 a gdcmValEntry * if a string value is passed as a param
1217 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1218 according to the param type (no longer sets a gdcmDocEntry)
1219 - GetValEntryByNumber, GetBinEntryByNumber added
1220 - NewValEntryByNumber and NewBinEntryByNumber added
1222 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1224 - GetSQItemNumber and SetSQItemNumber added, to provide
1225 a (relative) Item identier inside a given Sequence
1226 \warning : some pb remaining around this number
1228 - AddEntry now takes the Item Number as a param
1230 - adding a constructor taking a gdcmDocEntry as an input param
1232 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1233 * Memory leak hunt with the following command:
1234 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1235 --show-reachable=yes gdcmTests PrintDocument
1236 It looks like many (all?) leaks are due to the STL (or a bad usage
1237 of the STL. The lines producing the leaks now have a comment with
1238 a "MEMORY LEAK" tag: you can retrieve them with
1239 grep "MEMORY LEAK" src/*
1240 Here are two typical examples which I can't help fixing:
1245 char * test = "babo";
1246 name = test; //// <--- valgrind detects 960 bytes lost in
1247 //// call to std::string::operator=(char const*)
1248 name.clear(); //// Doesn't help !
1256 std::cout << "Type a bunch of characters followed by RETURN: ";
1257 getline(std::cin, line); //// <--- valgrind dectects a loss
1258 //// of 1320 bytes in call to
1259 /// std::basic_istream<>& std::getline<>
1265 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1266 * src/gdcmHeader.[cxx|h]:
1267 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1268 and related, moved away to gdcmDocument.
1269 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1270 the corresponding protected accessors of inherited class
1271 gdcmDocument, removed ! As a consequence gdcmFile had to be
1272 declared friend of class gdcmDocument (see below).
1273 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1274 - Clean up of undefined or unused methods.
1275 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1276 account the changes to gdcmHeader.h).
1277 * src/gdcmDocument.h:
1278 - gdcmFile is now a friend class (in order to take into account the
1279 changes to gdcmHeader.h).
1280 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1281 (see changes to gdcmHeader.h).
1282 - Accessors (reading on the form GetEntry*) are now public.
1283 - Clean up of undefined or unused methods.
1284 * src/gdcmDocument.cxx:
1285 - adaptation to changes to gdcmDocument.h
1286 - ::OpenFile now writes a verbose message when file cannot be opened.
1287 - some std::string properly set to VRKey
1288 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1289 references to gdcmDocument.
1290 * Test/TestFindTags.cxx: changed accordingly to above changes.
1291 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1292 cvs repository gdcmData.
1294 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1295 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1296 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1297 conflicts with gdcmValEntry::voidArea.
1298 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1299 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1300 Value representation between StringRepresentable and BinaryRepresentable.
1301 * src/gdcmDocument.cxx:
1302 - method ParseDES: proper indentation restored and usage of
1303 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1304 - method LoadDocEntry: the fingerprint left in the SetValue() of
1305 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1306 removed. Reverting to previous code segment with the proper
1307 dynamic_cast< gdcmValEntry* >.
1308 Note: this was (partially) breaking the python test suite
1309 (gdcmPython/testSuite.py) that made usage of the above
1310 fingerprint to check presence of "Pixel Data".
1311 * src/gdcmDocEntry.h: coding style.
1312 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1313 now taken into account.
1314 * gdcmPython/gdcm.i: adaptation to the new internal representation
1315 of gdcm (exit gdcmParser, hello gdcmDocument).
1316 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1318 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1319 anymore, but instead prints the loaded Python dictionary.
1320 * .... alas, the python testSuite is still broken.
1322 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1323 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1325 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1326 * src/gdcmUtil.h : export methods
1328 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1329 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1331 * Initial addition of automatic python testing
1332 * Initial addition of automatic image comparison
1334 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1335 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1336 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1338 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1339 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1340 * Test/ShowDicom.cxx : bug fix for msvc compilation
1341 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1343 2004-05-04 Jean-Pierre Roux
1344 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1345 new concepts (and new classes) :
1346 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1347 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1348 - Sequence Doc Entries (gdcmSeqEntries)
1349 a Sequence is composed of Items.
1350 Each item is a set of Doc Entries (this is recursive)
1351 The non uniqueness of the 'Dicom tag' is due to this recursivity
1352 (never taken into account)
1353 Our unability to add a new 'entry' in the header
1354 at the proper location (neither in the H-Table (map or multimap),
1355 nor in the Chained List is also due to this recursivity.
1356 Don't try, right now, to use/modify/compile these new sources :
1357 nothing is finished.
1358 We just commit all the stuff, 'as is', in order not to loose it.
1360 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1361 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1363 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1364 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1365 file prefix (SetFilePrefix)
1367 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1368 * Add a new test: ShowDicom, for now this is just the c++ version of
1369 checkRead.sh, later it will be able to compare the image read against a
1371 * Replace the DEBUG on the stack with a global entry in cmake interface:
1372 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1374 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1375 * Add an example subdir, with a real example on how to read + write a
1378 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1379 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1380 * Doc/CMakeLists.txt: the main page is now properly differentiated
1381 between the developper and user version.
1382 * Doc/doxygen.config.in: dropped search related obsolete flags
1383 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1385 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1386 * DEVELOPPER: added some helpfull comments for compile/test/install
1389 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1390 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1391 src directory, now generated in the build dir.
1392 2. Tests as mentionned smarter
1394 4. Add a new method in gdcmDict that return the PubDict by name
1395 this is interesting for 3rd party lib like ITK,
1396 where we could set the institution name / patient name...
1398 * ENH: 1. Now the test suite is working for real
1399 2. All binaries are now output in the gdcm-bin directory
1400 (this was not true before)
1402 2004-04-28 Jean-Pierre Roux
1403 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1404 SeQuence indented printing of Dicom Header.
1405 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1406 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1407 Computation of SQDepthLevel is now part of gdcmHeader constructor
1408 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1409 tree-like structure of a Dicom Header.
1410 * FIX Test code cleaning
1412 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1413 * ENH: Adding automatic testing
1414 1. Need a DartConfig.cmake to submit to public
1415 2. Add a test driver gdcmTest.cxx
1416 3. gdcmTestMain, an helper for the main test driver gdcmTest
1417 4. Files in Test don't have a main anymore, this becomes interesting
1418 when we add more and more tests, thus dsw don't have to load
1420 * ENH: Adding a GDCM_DATA_ROOT for testing
1421 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1422 one file instead of seven + some small cleanup
1424 2004-04-22 Jean-Pierre Roux
1425 * ENH Minor changes to the Print() methods.
1426 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1427 Header printing. Example given with :
1428 > PrintHeader fileName 2 new
1429 (SQ based tree-like structure still to be done for the Header ...)
1431 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1432 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1433 1. I have added some unsigned where needed
1434 2. Some function parameter not used -> (void)
1435 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1436 4. g++ don't like character '\' in comment
1437 5. #define jpeg_create_decompress jCreaDecompress
1438 this really need to be fixed
1439 6. virtualize destructor of gdcmObject ... leakage
1440 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1441 this also really need to be fixed
1442 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1443 remove compression file
1444 (as we only do decompression, right ?)
1445 * ENH: Change malloc/calloc/free with c++ equivalent
1447 2004-04-21 Jean-Pierre Roux
1448 * FIX gdcmHeaderHelper::GetXSpacing
1449 when a single value is found (bug ?), xpacing is now
1450 defaulted to yspacing
1452 2004-04-19 Jean-Pierre Roux
1453 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1454 * ENH add parameters :
1455 bool exception_on_error = false,
1456 bool enable_sequences = false,
1457 bool ignore_shadow = false
1458 to the gdcmFile constructors to be full gdcmParser compliant
1459 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1460 to allow reading of PAPYRUS 3.0 files
1462 2004-04-06 Jean-Pierre Roux
1463 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1465 2004-04-02 Jean-Pierre Roux
1466 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1467 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1468 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1470 2004-03-30 Jean-Pierre Roux
1471 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1472 for ACR file, written out as DICOM files (hope so...)
1474 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1475 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1476 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1477 moved to base class gdcmParser and only the specialisation is kept
1479 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1480 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1481 already does the job.
1482 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1483 (to be consistent with gdcmParser::WriteEntries).
1485 2004-03-30 Benoit Regrain
1486 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1487 upate of the object's instance. It's passed to 2 in the unfavorable
1488 case : one in the ExecuteInformation, one in the ExecuteData
1490 2004-03-29 Jean-Pierre Roux
1491 * ENH : Check on file type to be written moved
1492 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1493 * FIX : gdcmObject::ResetBoundaries now stops properly
1494 when end-of-list is reached
1495 : gdcmVersion modified (as Benoit Regrain asked)
1497 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1498 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1499 * src/gdcmUtil.cxx: added forgotten iostream include.
1500 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1501 equivalent to ExplicitVR in existing code).
1503 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1504 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1505 now contains all the gdcmGlobal related code.
1506 * minor coding style and doxygenation changes.
1508 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1509 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1510 now contains all the Debug related code.
1511 * minor clean-up of includes in src/*.cxx
1512 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1513 CreateCleanString) removed.
1514 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1515 * Doc/DoxyMainPageUser.txt added.
1516 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1517 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1518 src/gdcmDirList.cxx)
1520 2004-03-24 Jean-Pierre Roux
1521 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1523 2004-03-23 Jean-Pierre Roux
1524 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1525 big endian made volumes
1526 * ENH Now gdcmParser constructor and destructor are protected to forbid
1527 end user to instanciate class gdcmParser
1528 (only gdcmHeader and gdcmDicomDir are meaningfull)
1530 2004-03-22 Benoit Regrain
1531 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1532 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1533 gdcmSerie to gdcmDicomDirSerie
1535 2004-03-19 Jean-Pierre Roux
1536 * ENH Now the tree-like structure describing a DICOMDIR comming from
1537 an already existing DICOMDIR file is consistent with
1538 the home-made tree-like structure build ex-nihilo
1539 or build from the files held (recursively) in a Directory
1540 functions gdcmDicomDir::CheckBoundaries()
1541 gdcmObject::SetBoundaries() added
1543 2004-03-17 Jean-Pierre Roux
1544 * REM (Eric Boix bug) : removal of meaningless
1545 gdcmDicomDirImage::NewImage function.
1546 * FIX now file names and directory name are written properly in the
1548 * FIX now gdcmDicomDir constructor may be call without any trick
1551 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1552 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1553 of gdcmDicomDirImage::NewImage as empty function.
1555 2004-02-28 Jean-Pierre Roux
1556 * ENH add gdcmDicomDir:NewPatient
1557 add gdcmDicomDirPatient:NewStudy
1558 add gdcmDicomDirStudy:NewSerie
1559 add gdcmDicomDirSerie:NewImage
1560 to allow making gdcDicomDir object.
1561 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1562 (as opposite to the gdcmHeader chained list)
1564 2004-02-11 Benoit Regrain
1565 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1566 when using from python
1568 2004-02-10 Benoit Regrain
1569 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1570 * FIX : in gdcmDicomDir when the directory is empty
1571 * ENH : add callback and methods to get the progression of dicomDir
1574 2004-02-06 Jean-Pierre Roux
1575 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1576 - GDCM_META added to gdcmDicomDirType
1577 - class gdcmMeta created
1578 * ENH : - A brief summary is now displayed at the beginning of
1579 'testDicomDir' to help disaster magnitude estimation
1580 * REM : Now useless Test/explDICOMDIR.cxx
1582 2004-02-05 Benoit Regrain
1583 * ENH : add methods in gdcmObject to get the hash table or the list of
1585 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1586 * FIX : wrapping python for TagHeaderEntryHT
1588 2004-02-04 Benoit Regrain
1589 * FIX : even length for some strings when writting the dicom dir
1590 * FIX : sort the images in the dicom dir
1591 * FIX : Bug fix for python use of dicom dir
1592 * ADD : a python demo
1594 2004-02-04 Jean-Pierre Roux
1595 * FIX : Final solution (?) for icone embedded images
1596 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1597 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1598 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1599 gdcmData/gdcm-MR-SIEMENS-16.acr1
1600 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1601 to make full checking easier
1603 2004-02-04 Benoit Regrain
1604 * FIX : WriteEntries : coding style & logic in parameters
1605 * FIX : Set the elements to create the DicomDir in a dictionary file
1607 2004-02-03 Benoit Regrain
1608 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1609 * gdcmDicomDir : add the load of directory
1610 * Bug fix and print add-on
1612 2004-02-03 Jean-Pierre Roux
1613 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1614 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1615 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1616 * FIX gdcmParser.cxx : 'group length' elements are now considered
1617 as integers, even for shadow groups, when file is Implicit VR
1619 2004-02-02 Jean-Pierre Roux
1620 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1622 of the last synonym :-(
1623 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1625 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1626 * FIX taking into account the possible 7fe0,0010 multiplicity
1627 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1628 to allow removal of references to 7fe0,0010, to deal with
1629 ACR-NEMA images, when 0028,0200 is meaningfull
1631 2004-01-31 Jean-Pierre Roux
1632 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1633 no longer writes 'Un' on disk
1634 * FIX SQ elements with actual length are now dealt with corectly
1635 * FIX gdcmFile::WriteBase make the difference, for color images, between
1636 the length (for Palette expanded images)
1637 and Raw Length (non expanded image + Palette)
1638 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1639 (that broke Write). Replaced by UL.
1640 Aware user will reload the field if he
1641 thinks it's necesssary
1643 2004-01-30 Jean-Pierre Roux
1644 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1645 when 'dirty Acr' is found, to be compliant with the new
1646 IsReadable() methods.
1648 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1649 (no DOUBLE images in kosher DICOM,
1650 but so usefull for people that miss them ;-)
1652 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1653 DICOMDIR related utilities (not checked as Windoze compliant)
1655 2004-01-28 Jean-Pierre Roux
1656 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1658 2004-01-27 Jean-Pierre Roux
1659 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1660 to allow skipping the shadow elements, to save memory space.
1661 The TRUE value for this param has to be used
1662 with a FALSE value for the 'enable_sequence' param.
1663 ('public elements' may be embedded in 'shadow Sequences')
1664 * gdcmHeader methods now deal with 'embedded icones images' in the header
1665 (even when an 'icone image sequence' is announced by the
1666 element (0x0088,0x0200), but there is NO icone at all ...
1668 * gdcmHeader sometimes Image Location value doesn't follow
1669 the supposed processor endianity (see gdcmData/cr172241.dcm).
1672 * gdcmHeader add the method
1673 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1674 to get *all* the Header Entries with the same tag.
1675 GetHeaderEntrySameName is probabely *useless*
1676 (no meaning : Name is *not* an identifier within the Dictionnary)
1678 2004-01-26 Benoit Regrain
1679 * Bug fix in the print of hexadecimal representations. Remove long fields
1680 in the print and add a third level of print to print them
1682 2004-01-23 Benoit Regrain
1683 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1684 * Bug fix on test suite after remove the strip made on not string fields
1685 * Split the IsReadable method between gdcmParser which test that the file
1686 is dicom and gdcmHeader which test that it's an image file
1688 2004-01-22 Benoit Regrain
1689 * DicomDir : clean code, add methods, set variables in protected or private
1690 * gdcmUtil : bug fix for the clean string method
1692 2004-01-19 Benoit Regrain
1693 * Add the use of shadow dictionaries
1694 * bug fix and coding style
1696 2004-01-19 Benoit Regrain
1697 * src/gdcmFile.cxx : bug fix concerning the close of file
1698 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1699 * Add the update of header entries using the shadow library
1701 2004-01-19 Benoit Regrain
1702 * removal of file gdcmHeader2.cxx
1703 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1704 inheriting from gdcmParser. This split is to prepare the integration
1705 of dicom dir parsing
1706 * bug fix under python
1708 2004-01-16 Jean-Pierre Roux
1709 * REM removal of class gdcmHeaderEntrySet
1710 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1711 * ADD add file gdcmHeader2.cxx
1712 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1714 2004-01-15 Benoit Regrain
1715 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1716 entries created while parsing the header. Thus, they will be destroyed
1717 when the gdcmDictSet will be destroyed
1718 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1721 2004-01-15 Benoit Regrain
1722 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1723 made a fatal error because of the memory release at the end of program.
1724 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1725 some memory and vtk seems to have some problems with that.
1726 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1728 2004-01-14 Benoit Regrain
1729 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1730 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1731 * src/*.[h|cxx] : make changes due to class name changes
1732 * gdcmPython/demo/*.py : bug fix due to method names
1734 2004-01-13 Benoit Regrain
1735 * src/*.[h|cxx] : coding style
1736 * vtk/*.[h|cxx] : coding style
1738 2004-01-13 Benoit Regrain
1739 * gdcmPython/testSuite.py : test the readable flag of file for tests
1740 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1741 It's lied to the stl compilation by MSVC (windows, always windows...)
1742 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1744 2004-01-12 Benoit Regrain
1745 * src/*.h : add comments
1746 * src/gdcmDictSet.h : set the method BuildDictPath in public
1747 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1748 directly setted in the source code
1749 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1752 2004-01-09 Benoit Regrain
1753 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1754 * setup.py : use a reference to gdcmVERSION
1756 2004-01-07 Benoit Regrain
1757 * Modification to compile with the distutils.
1760 2003-12-10 Benoit Regrain
1761 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1762 can use a gdcmHeaderHelper to load datas
1763 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1764 made in the source code
1766 2003-12-10 Benoit Regrain
1767 * Update Windows projects and .cvsignore files
1769 2003-11-12 Jean-Pierre Roux
1770 * ENH gdcmHeader constructor has one more parameter (default value : false)
1771 that allows the user to 'go inside' the SeQuences only
1773 gdcmElValSet:Print takes it into account
1775 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1776 * ENH: Update gdcmPython/CMakeLists
1777 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1778 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1780 2003-11-10 Jean-Pierre Roux
1781 * FIX : gdcmHeader::LoadElements is now based
1782 on the ListTag listElem member,
1783 not longer on the TagElValueHT tagHt member
1784 * ENH : PrintPubElVal shows (temporarily) both results,
1785 with the tagHt member and the listElem member.
1786 (it's easier to 'see' the problems when using Printheader)
1788 * FIX : old private member LgrElem is now splitted into
1789 ReadLength : Length actually found on disk (updated only
1790 if bug fixing is necessary), for internal
1792 UsableLength : Updated by FixFoundLength, to fix a bug
1793 or to allow Parser going on.
1794 Will allow to re-write a kosher header when a SeQuence
1795 with a length (not 0000) is found
1796 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1797 because gdcmElValSet::Add does not update ListElem
1800 2003-11-07 Jean-Pierre Roux
1801 * FIX misstyping in Transfert Syntax name table
1802 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1803 when they have an actual length (not 0000 nor FFFFF)
1804 (Nobody should care of it, but DICOMDIR explorers)
1806 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1807 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1809 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1810 * ENH: vtkGdcmReader now supports LUT !
1811 (vtkgdcmViewer for now is not able to use them though)
1813 2003-11-05 Jean-Pierre Roux
1814 * in testSuite.py : new files names for checking the package
1815 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1816 that returns the pixel area size to the *aware* (vtk) user
1817 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1819 2003-11-05 Benoit Regrain
1820 * in testSuite.py : Modify the rules for checking the paths
1821 : Explicit error messages
1822 * in __init__.py : Related modif
1824 2003-11-03 Jean-Pierre Roux
1825 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1826 to be used by aware (vtk) users that want to manage
1827 LUT (and no to turn the PALETTE image into an RGB pixels one)
1828 * GetPixelType now returns 8U for 24 Bits images
1829 (vtkGdcmReader compliant)
1831 2003-10-31 Jean-Pierre Roux
1832 * Removal of *all* gdcmData images and add them again
1833 in order to loose the 'history' of un-anonymised images
1835 2003-10-31 Jean-Pierre Roux
1836 * RMV : removal of useless jBitsInJsample.h
1837 for both 8 and 12 Bits JPEG Lossy Libraries
1839 2003-10-31 Jean-Pierre Roux
1840 * ENH : Add the functions gdcmFile::GetImageDataRaw
1841 gdcmFile::GetImageDataIntoVectorRaw
1842 that act as GetImageData and GetImageDataIntoVector
1843 except the making of an RGB Plane from Gray Plane + LUT
1844 Intended to aware (vtk) users who know how to manage
1847 GetLUTRGBA return a R,G,B,A LUT if any
1848 lgrTotaleRaw gives the 'Raw' length
1849 GetImageDataRaw returns the gray Plane
1850 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1851 (They stay Grey, just like with other Dicom viewers :-(
1853 2003-10-30 Jean-Pierre Roux
1854 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1856 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1857 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1858 being coherents dicom files.
1860 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1861 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1863 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1864 * ENH: Two steps is necessary to please VC++ compiler...
1865 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1866 * ENH: Add include dir to medcon lib
1867 * FIX: only one function is being exported for now !
1868 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1870 2003-10-29 Jean-Pierre Roux
1871 * adding gdcmHeader::GetLUTRGBA
1872 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1873 --> Mathieu, the modif u're waiting for is not yet committed
1874 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1876 2003-10-27 Jean-Pierre Roux
1877 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1878 00191113.dcm DermaColorLossLess.dcm
1879 MxTwinLossLess.dcm RadBWLossLess.dcm
1880 * ENH: For version prior to vtkImageViewer2 -r 1.19
1881 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1883 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1884 * Removal of ido stuff in CMakeLists.txt
1886 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1887 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1888 * FIX: remove a call to ->Modified ... see comments
1889 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1891 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1892 * FIX: Problem with path for libvtkgdcmPython
1893 * ENH: Try adding a search script for python site-package
1894 * RMV: Remove some file from medcon lib that are not necessary
1895 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1896 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1897 * FIX: More pragma disable fro VC++,
1898 I don't think I break something as it is also disable in VTK/ITK.
1899 But it fasten debug compilation time.
1901 2003-10-23 Jean-Pierre Roux
1902 * gdcm now deals with 16 Bits Run Length Encoded images
1903 (they are compressed as 2 planes images,
1904 one for the high Bytes, the other for low Bytes)
1906 2003-10-22 Jean-Pierre Roux
1907 * Now CheckRead takes into account :
1908 - the bugged 'Leonardo' Siemens images
1909 - the XA images, sent thru the burning VPRO station
1910 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1913 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1914 * FIX: When copying a Makefile.am to CMakeLists.txt
1915 one should remove the '\'
1917 2003-10-22 Jean-Pierre Roux
1918 * in gdcmData adding a bugged 'Leonardo' Siemens image
1919 (wrong lengths in header)
1920 OK with gdcm, KO with the other viewers :-)
1921 * add a GE dlx XA image, thru the VEPRO burning station
1924 2003-10-21 Jean-Pierre Roux
1925 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1926 for a brutal checking of vtkgdcmViewer compliance
1928 2003-10-21 Jean-Pierre Roux
1929 * add the files for 'xmedcon' Jpeg Lossless library
1930 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1932 2003-10-21 Jean-Pierre Roux
1933 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1935 2003-10-21 Jean-Pierre Roux
1936 * garbage Siemens 'Leonardo' images dealt with
1937 (the patch is easy to remove)
1938 * cosmetic changes to avoid warnings
1940 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1941 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1942 no need to press 'r' now.
1944 2003-10-20 Jean-Pierre Roux
1945 * upgrade of checkRead.sh checkWrite.sh according
1946 to new Jpeg Lossless decompressor
1947 * add US.3405.1.dcm, a genuine RGB medical file ...
1948 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1949 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1951 2003-10-15 Jean-Pierre Roux
1952 * general anonymisation in gdcmData
1953 * adding the 'color files' from
1954 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1955 * adding some well knowed bugged-header images
1956 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1957 waiting for their inclusion in Python testsuite
1959 2003-10-15 Jean-Pierre Roux
1960 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1961 no longer seg faults when file is not found
1963 2003-10-14 Jean-Pierre Roux
1964 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1967 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1968 * TODO: *.in file to genereate a UseGDCM later
1970 2003-10-14 Jean-Pierre Roux
1971 * Some supposed-to-be Dicom Images have no preamble.
1972 OpenFile takes it into account
1973 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1974 * Missing elements added in dicomV3.dic
1975 (just to be affraid : have a look at
1976 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1977 and do it again next year ;->
1979 2003-10-13 Jean-Pierre Roux
1980 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1981 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1982 But there are NOT. It's fixed !
1984 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1985 * FIX: "jpeglib.h" was not found on VC++
1986 * FIX: vtkgdcm was not being installed
1988 2003-10-10 Jean-Pierre Roux
1989 * ENH : OpenFile closes the file if it *really* doesn't look like
1990 an ACR-NEMA / DICOM one.
1991 * FIX : testWrite no longer writes an empty file if the source file
1992 is not gdcm Readable
1993 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1996 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1997 * FIX: CMake generate now documentation
1998 * ENH: out of source doc build !
1999 * ENH: Generate both user and dev documentation
2000 * ENH: Should work on windows too
2001 * ENH: Only one doxygen config.in file is needed
2002 * FIX: make install should be ok now on ùnix plateform
2003 * FIX: PATH to dictionary was wrong (missing /)
2004 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2006 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2007 * vtkGdcmReader is now able to read rgb dicom file.
2008 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2009 * added a gdcmViewer to vtk test, use mouse to control
2010 window level & window width
2012 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2013 * CMake-ification of gdcm, we have now two build system
2014 * FIX: on cygwin Wsock32 doesn't exist
2015 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2017 2003-10-06 Emanuel Ollart
2018 * FIX : compilation process wad broken.
2019 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2021 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2022 * change gdcmViewer -> vtkgdcmViewer
2023 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2025 2003-10-06 Jean-Pierre Roux
2026 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2027 ( e.g : well known GE images with a wrong elem length,
2028 : Philips MRI Images with a wrong Huffman table)
2029 * still to be done : allow the reading of bugged LEONARDO Siemens images
2031 2003-10-03 Jean-Pierre Roux
2032 * Odd length strings are padded with '\0' (not with spaces,
2033 to remain compliant with already defined strings,
2034 like Transfert Syntax UID and others)
2036 2003-10-03 Jean-Pierre Roux
2037 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2038 to allow displaying RGB images (not only by affim ;-)
2040 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2041 * vtkGdcmReader is now able to read rgb dicom file.
2042 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2044 2003-10-03 Jean-Pierre Roux
2045 * A few nasty patches to allow the reading of a lot of nasty images
2046 ( e.g : well known GE images with a wrong elem length,
2047 : Philips MRI Images with a wrong Huffman table)
2048 * still to be done : allow the reading of bugged LEONARDO Siemens images
2050 2003-10-03 Jean-Pierre Roux
2051 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2053 2003-10-03 Jean-Pierre Roux
2054 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2055 to allow displaying RGB images (not only by affim ;-)
2057 2003-10-03 Jean-Pierre Roux
2058 * gdcmFile::GetImageDataIntoVector now
2059 - deals with MultiFrames MultiFragments Run Length Encoded files
2060 - deals with YcBcR (YBR_FULL) files
2061 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2062 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2064 (no sample found :-(
2066 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2067 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2068 Two reasons: - clear things
2069 - third parties acces gdcm through header files, so won't
2070 suffer anymore VC++ complains
2072 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2073 * add argv[1] in testvtkGdcmReader.cxx
2076 2003-09-24 Jean-Pierre Roux
2077 * The lines are now eigthy characters long.for
2078 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2080 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2081 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2082 char* to std::string. Thus, the use of strdup becomes useless. (see
2083 previous commis of Malaterre)
2084 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2085 before the last Malaterre's commit.
2087 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2088 * This commit should fix the Debug building under VC++, the problem
2089 was mainly a mixture of debug and release lib being loaded at startup.
2090 * I also remove a depency to a specific C function: strdup. Because I had
2091 to force the link to msvcrtd (whereas strdup is in libc).
2093 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2094 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2095 located in the gdcmCommon.h file. All use of reference of tha has been
2096 changed to now use the variable GDCM_UNFOUND.
2098 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2100 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2101 Dicom dictionary. The test suite can now be run again. Note:
2102 I'm note very happy with the " (RET)" changes. I believe this
2103 RETAINED comment should be dropped when parsing the dictionary.
2104 - PACKAGER corrected
2106 - AUTHORS updated and now in alphabetical order
2107 * Makefile.am now exports gdcm.dsw for Windoze users.
2109 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2110 * cygwin complains about missing std:: in subdir Test/
2112 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2113 * remove some methods that are now in gdcmHeaderHelper
2115 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2116 * vtkGdcmReader set spacing and origin correctly
2118 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2119 * Fix a few delete/delete[] mismatch
2121 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2122 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2123 interpretation to data given by gdcmHeader. For instance there are
2124 heuristics to get informations (look at different places).
2125 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2126 sorting DICOM images based on different strategies.
2127 * modified Makefiles accordingly.
2129 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2130 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2131 when building in debug mode
2132 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2133 src/win32/gdcmdll.dsp
2134 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2136 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2137 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2140 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2141 * src/win32/libgdcmjpeg12.dsp was not dos format
2142 * src/win32/libgdcmjpeg12.dsp :
2143 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2144 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2146 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2147 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2149 * src/gdcmFile.cxx : bug fix in affectation type
2150 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2151 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2152 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2153 symbols... future problem ?
2155 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2156 * src/win32/libgdcmijpeg12.dsp was missing
2157 * modified gdcm.dsw accordingly
2159 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2160 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2162 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2163 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2164 commit of JPR (before his hollidays to facilitate our work).
2165 * setup.py : bug fix in code. Modifications made while the last commit
2166 of JPR. The code hasn't been tested before the commit... it's so
2167 useless to make that (for best programmer that is JPR) !!!
2169 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2170 * tagged the current version as Version0_3 (i.e. version 0.3)
2172 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2173 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2174 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2175 * *.dsp : modifications to use new libgdcmijpeg8 library
2176 * setup.py : bug fix on VTKPATH variable
2177 * PACKAGER : adding all concerning windows
2179 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2180 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2182 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2183 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2184 test suite reported error.
2185 * PACKAGER file added (describes what a packager must do when
2186 packaging a new release).
2187 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2188 * configure.in: upgraded version number to 0.3.0
2189 * fixing build of rpm (through rpm -ta):
2190 - Doc/Makefile.am exports proper doxygen files
2191 - src/jpeg/libijg8/Makefile.am exports the include files.
2193 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2194 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2195 * src/gdcmHeader.h : formatting code
2197 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2198 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2199 We were obtaining error message from vtk. Now, creation of file list
2200 is made in an internal list to prevent this problem.
2201 Bug fix when output is empty.
2202 Bug fix in update of progress value. Previous commit for this was a bad
2204 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2206 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2207 * src/gdcmHeader.h : added method to get the file name
2208 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2209 files. Added method to remove all files on the input
2210 Added FIXME comment concerning the bad parsing of header made by
2211 ExecuteInformation method (in ExecuteData method)
2213 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2214 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2215 when using make instal.
2216 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2217 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2219 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2220 * setup.py : adding include dir of jpeg lib to compile all sources
2221 * */Win32/*.dsp : JPR fix for windows compilation
2223 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2224 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2226 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2227 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2229 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2230 * setup.py is again effective on un*x (takes into account the
2231 addon of the jpeg library)
2232 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2233 * Doc/Doxy* updated (includes above enhancements)
2234 * INSTALL now points to web documentation
2236 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2237 * src/gdcmHeader.h doesn't make unnecessary reference to
2239 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2241 * src/gdcm*.[cxx|h] :
2242 - to allow compilation with gcc 3.x
2243 -- clean up of STL usage (added explicit usage of std::)
2244 -- small fixes on exceptions.
2245 Note: linking not tested !
2246 - clean of doxygen comments to avoid warnings at documentation
2248 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2249 dependent convertion).
2251 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2252 * Clean up of previous JPR garbage commit (not even commented in the
2254 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2255 - moved all jpeg related files from src to src/jpeg/libijg8, with
2256 addition/modification of Makefile.am and configure.in.
2257 - the testSuite is still brain damage (not guilty).
2259 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2260 * WrapVTK.py : modifications to get correctly vtk source files to
2262 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2263 (FileName -> Filename)
2265 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2266 * vtk/vtkGdcmReader.[cxx/h]:
2267 - UpdateProgress method should now be effective
2268 - removed the limitation on having only images loaded (as opposed
2270 - when building a stack of images/volume, a lesser number of
2271 gdcmHeader and gdcmFile instances should be used (hopefully
2272 accelerating things).
2273 - when building a stack of images/volumes, files which are not
2274 loadable (wrong path-filename, wrong permissions on existing file,
2275 or file not parsable by gdcm) are replaced with a black image
2276 in the stack (for the caller to notice the problem).
2278 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2279 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2281 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2282 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2283 between standard library (std) and vtk library (problems are found
2284 under Windows... thanks Windows !)
2286 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2287 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2289 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2291 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2292 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2294 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2295 * When compiling with distutils (see setup.py) the C++ compiler is
2296 called with different flags than the default ones (with automake).
2297 In order to fix all those warning, I compiled gdcm with the command
2298 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2299 and went for warning fixes:
2300 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2301 up from unused variables.
2302 - vtk/vtkGdcmReader.cxx: potential bug fix.
2303 * src/gdcmHeader.h: Doxygen warning cleanup
2305 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2306 * gdcmPython/gdcm.i:
2307 - typemaps correction to take into account the systematic replacement
2308 of "using namespace std" with std:: prefix e.g. std::list,
2309 std::string... (cf changes of 2003-05-21).
2310 - gdcmGlob global variable of type gdcmGlobal (defined in
2311 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2312 exported to Python a as cvar.
2313 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2314 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2315 gdcmDictSet.GetPubDictTagNames() and
2316 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2317 C++ static methods).
2318 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2319 with the above changes.
2321 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2322 * setup.py, manifest.in : bug fix under linux
2324 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2325 * Modification of setup.py to compile vtk part too. Then, we have 2
2326 wrappers which must work with same distutils. For that, we have a
2327 generic distutils in distusiltsWrapping.py ; with :
2328 - build_extWrap class to wrap generically all extensions,
2329 - ExtensionWrap base class for all wrapping extension that contains
2331 - Wrapper interface which wrap sources
2332 + In WrapSwig.py we have extension and wrapper for Swig
2333 + In WrapVTK.py we have extension and wrapper for VTK
2334 * MANIFEST.in : modifications to consider vtk directory and new python
2335 files for compilation
2337 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2338 * Added python wrappers of vtkGdcmReader vtk class (see the
2339 source in vtk/vtkGdcmReader.cxx) :
2340 - vtk/Makefile.am now builds a library
2341 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2342 python library (as opposed to _gdcm.so wich are the python
2343 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2344 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2346 - configure.in has an additional flag --enable-vtk that needs
2347 to be set to enable compilation of vtk related code, that is:
2348 + vtk/vtkGdcmReader.so and
2349 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2350 + gdcmPython/vtkgdcmPython.so (see above)
2351 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2352 be read when compressed or when HighBit + 1 != BitsStored),
2353 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2354 the usage of the python wrapper of vtkGdcmReader vtk class.
2355 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2356 * src/*.[h] all occurences of stl classes are now prefixed with
2357 std::, and all occurences of "using namespace std;" where removed.
2358 This is to avoid pollution of global namespace in included files.
2359 Apparently vtk does not avoid this pitfall: when using both
2360 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2361 collision of various stl members (principally cout...).
2362 * gdcmPython/testSuite.py now cleanly removes temprory generated
2364 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2365 comply with above changes)
2367 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2368 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2369 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2370 vtk data structure (an image Flip was required).
2371 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2372 * cosmetic changes in documentation.
2374 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2375 * src/gdcmHeader.cxx: the constructor no longer exits when an
2376 unexisting file is given as argument.
2377 * The subdirectory Data (containing all the images used for the
2378 test suite) is not part of this repository anymore. A new module
2379 containing those images is now available at
2380 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2381 with the name gdcmData.
2382 All the python scripts (including the package initialisation file
2383 gdcmPython/__init__.py) were adapated to take this change into
2384 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2386 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2387 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2388 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2389 demo of the usage of this class.
2390 Compilation of this vtk part is only done when using the --enable-vtk
2391 at configure (or autogen.sh) stage.
2393 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2394 * More memory link related corrections and documentation fixes.
2396 - maximum info is obtained with a command of the form:
2397 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2398 --show-reachable=yes PrintHeader
2399 - the remaining reachable blocks seem to come from the STL
2400 allocation scheme through the usage of map and list. It looks
2401 like this memory cannot be freed but it is not a memory leak
2402 (in fact further invocation to the STL would recollect the
2403 unused memory allthough it cannot explicitely be freed).
2404 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2405 of displaying an image parsed with gdcm and displayed with VTK.
2406 Note: some images don't seem to work e.g.
2407 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2408 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2409 Allthough this weakens the semantics, it is a ditch attempt to
2410 make gdcm more thread friendly.
2412 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2413 * Memory link hunt (by using valgrind through the command
2414 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2415 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2416 gdcmHeader::_dicom_vr.
2417 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2418 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2420 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2422 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2423 * src/Makefile.am now exports all the necessary include files at
2427 * UpdateGroupLength replaced by new one
2430 * UpdateGroupLength re-written using H-Table
2431 (named UpdateGroupLengthNew untill checks are over)
2433 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2434 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2435 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2437 - gdcmHeader::GetPubElValSet removed.
2438 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2439 UpdateGroupLength, WriteElements, Write.
2440 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2441 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2442 carried the same semantics.
2443 - src/gdcmHeaderIdo.cxx changed accordingly.
2444 - gdcmFile::WriteBase now regroups all the codes from previous
2445 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2446 - enum FileType moved to gdcmCommon.h
2447 * src/gdcmHeader.cxx AddDefault trashed
2448 * gdcmGetXSize added
2449 * getimageDataSize now calls gdcmGetXSize
2450 * Test/*.cxx changed to agree with above changes
2452 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2453 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2454 (to avoid double call by end user).
2455 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2456 by end user, since gdcmHeader::gdcmHeader now handles it.
2458 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2459 * gdcm/Doc many doxygen changes:
2460 - Doxyfile now has two different versions, DoxyfileUsers that generates
2461 the html.users end users oriented documentation and
2462 DoxyfileDeveloppers that generates the html.developper developper
2463 oriented documentation.
2464 - README changed accordingly
2465 - requirement.txt removed (old design info moved to TODO).
2466 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2467 DoxyMainPage.txt, DoxyPython.txt provide more information.
2468 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2469 be updated by simply regenerating the docs with doxygen and copying
2470 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2471 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2472 all the tests in the form "if (<map>.count() >1)" were removed.
2473 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2474 ill-formed documentation sections.
2475 * src/gdcmHeader.cxx: ditto
2477 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2478 * setup.py fixed for un*x (needed macro for stdint.h)
2479 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2480 un*ces with sh-utils test utility.
2481 * gdcmPython/demo/test.py renamed to PrintHeader.py
2482 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2483 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2484 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2485 * src/gdcm*.cxx JPR's bad inclusion fixed.
2487 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2488 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2489 * gdcmPython/demo/test.py changed accordingly.
2491 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2492 * gdcmPython/Makefile.am fixed linking against libstdc++
2493 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2494 * Swig subdir (historical tests of swig version 1.3.17++) removed
2495 * Test/testChangeEntete.cxx some lines commented out in order to make
2497 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2498 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2500 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2501 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2502 hence the user doesn't need this explicit call.
2503 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2504 i.e. LoadElements() call removed.
2505 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2506 - src/Makefile.am declares the proper flag for g++.
2507 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2508 for adding user defined new tags.
2509 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2510 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2511 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2513 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2514 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2515 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2516 src/Makefile.am : the project should properly compile and install
2517 with the autotools, included the python wrappers part.
2518 * gdcm.spec.in : added a spec file for RPM packaging.
2520 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2521 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2523 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2524 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2525 to exported to the environement (see gdcmPython/testSuite.py
2527 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2528 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2529 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2530 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2531 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2533 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2534 * gdcmPython/__init__.py doesn't crash anymore when running in
2535 in InstallMode or PreInstallMode but with an environement given
2536 value of GDCM_DICT_PATH.
2537 * src/gdcmDictSet.[cxx/h] coding style.
2539 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2540 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2541 * src/gdcm.h general comments moved to TODO, and README
2542 * src/gdcm.h should now be seen as a user commodity (including it
2543 should suffice to fully use gdcm). It is nowhere including within
2544 any of the kernel files src/*.cxx and src/*.h.
2546 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2547 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2548 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2550 * src/gdcm*.cxx only include their corresponding include file
2551 (as opposed to gdcm.h)
2552 * gdcmPython/gdcm.i changed accordingly
2553 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2554 the autogen.sh generated "make snapshot" command to work.
2555 * autogen.sh removed history related references to crea package.
2557 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2558 * distutilsSwigCPlusPlus.py work around some swig portability
2561 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2562 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2563 was done in a last ditch attempt to get setup.py _really_
2564 operationnal. The python/gdcmPython layaout add the advantage
2565 of hidding away the python related distutils specific files
2566 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2567 Alas, the src directory was out of scope (i.e. it's relative
2568 position to setup.py was ../src) which made things impossible to
2569 handle (see previous version of python/setup.py). Crossing fingers...
2571 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2572 * python/setup.py now works on Un*x. (harder than I thougth)
2573 * python/distutilsSwigCPlusPlus.py can now have include files
2574 among the list of sources.
2576 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2577 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2578 * modifications in MSVC projects
2580 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2581 * As stated by the first lines of Test/ExceptionAndPython/README, it
2582 looks like we can move back to original usage of exception within
2583 src/gdcm* and hence remove the errno stuff that was introduced
2584 as a quick and dirty fixture of this problem (added to the TODO).
2585 * Doc/Doxyfile configuration file for Doxygen and corresponding
2586 README file for usage added.
2587 * Test/testWrite.cxx added. This new test comes from a split of
2588 test.cxx that is now reverted to its original purpous i.e.
2589 testing the proper parsing of a Dicom related file.
2590 testWrite.cxx concentrates on testing the IO part of gdcm.
2591 * Test/bug1.cxx (containing a bug on WIn32) added.
2592 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2593 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2594 whose purpose is to publish the content of the TagNames of the
2595 Dicom public dictionnary were not accessible without an
2596 instance of class gdcmHeader.
2597 - those methods are now static methods of gdcmDictSet and hence
2598 require no instances at all to be invocated.
2599 - within gdcmDictSet this change required to change some method
2600 to class methods (i.e. are now static) among which SetDictPath
2601 (renamed to BuildDictPath) and LoadDefaultPubDict.
2602 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2603 the above changes by calling the new method classes of gdcmDictSet.
2604 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2605 the above to be effective.
2606 * python/gdcmPython: in order to wrap properly the above changes
2607 for Python, swig version now needs to be > 1.3.17.
2608 * python/gdcmPython/Makefile fixed to adapt itself to new
2609 configure/make shema introduced by Johan Montagnat (thanks for the
2610 contribution). Alas this Makefile cannot be turned into a proper
2611 Makefile.am without some heavy changes in the configure.in
2612 (for python dectection).
2613 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2614 now avoids publishing the empty entries.
2616 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2617 * python/setup.py : bug fix concerning install under windows
2618 ExtraPath reused :-P
2619 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2621 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2622 * Dicts/dicomV3.dic : remove double spaces !!!
2623 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2624 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2627 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2628 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2629 method. Doxygenation.
2630 * src/gdcm.h clean up of JPR spurious comments.
2632 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2633 * python/distutilsSwigCPlusPlus.py now properly collects the
2634 shadow classes generated by "swig -c++" (gdcm.py in our case)
2635 when using "python setup.py install".
2636 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2637 reexports the working classes.
2638 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2639 by the classical C errno scheme. This is to prevent an obscure
2640 behavior of the python wrappers when importing wxPython.wx prior
2641 to gdcmPython (which ended up in an abort call). An illustration
2642 of this oddity can be found in the Test/ExceptionAndPython
2643 subdir (see the README file). This problem probably due to
2644 an combination of g++ and dynamic loading.
2645 * added Test/ExceptionAndPython (see above)
2647 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2648 * Changed the layout of the python part to avoid bloating main
2649 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2650 i.e. the distutils arsenal. All the python related stuff is
2651 again in a python subdir, but the package itself is now in
2653 * setup.py was cleaned up:
2654 - pythonIncludePath removed
2655 - python setup.py bdist target is now functional.
2656 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2657 collision with other packages). gdcmPython/demo/*.py changed
2660 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2661 * python subdir moved to gdcmPython (preparation of distutils packaging).
2662 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2663 distutils installer is operational.
2664 * - gdcmPython/__init__.py now properly loads the swig generated
2665 shadow classes (from gdcm.py).
2666 - gdcmPython/demo/*.py changed to import the package gdcmPython
2667 instead of gdcmPython/demo/load.py.
2668 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2670 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2671 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2672 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2673 entries within the associated public Dicom dictionary resp. the same
2674 information but sorted by the fourth field (PAT, IMG, DIR) of the
2676 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2677 are now in the "???" group.
2678 - python/gdcm.i changed accordingly,
2679 - python/demo/printGroupedPublicDict.py added, that gives an example
2680 of the above new functionalities in Python.
2682 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2683 * src/gdcm.h, gdcmHeader.cxx:
2684 - historic references to glib's g_malloc and g_free (#defined)
2685 were definitively removed.
2686 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2687 * src/gdcmElValSet.cxx:
2688 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2689 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2690 - GetElValue(string) renamed to GetElValueByName.
2691 - Added GetElementByName(string).
2692 * src/gdcmHeader.cxx: added
2693 - GetPubElValRepByNumber(guint16, guint16)
2694 - GetPubElValRepByName(string)
2695 - GetShaElValRepByNumber(guint16, guint16)
2696 - GetShaElValRepByName(string)
2697 - GetShaElValByNumber(guint16, guint16)
2698 - GetShaElValRepByName(string)
2699 - GetElValRepByNumber(guint16, guint16)
2700 - GetElValRepByName(string)
2701 - GetElValByNumber(guint16, guint16)
2702 - GetElValRepByName(string)
2703 * Doc/requirements.txt added.
2705 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2706 * Test/Makefile building now depends on the one of libgdcm.so
2707 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2708 pixel data) aware which enables finding the address (offset) of
2709 the pixel data of JPEG encoded DICOM files. This leaves only a single
2710 file in the testSuite whose pixel data address (offset) is unknown.
2711 * python/testSuite.py changed accordingly.
2713 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2714 * VC++ has some strong limitations when working with the STL, as stated
2715 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2716 "Also note that some STL containers (map, set, queue, list, deque)
2717 cannot be exported. [...]
2718 Some STL classes contain nested classes. These classes can not
2720 This is caused by a designed limitation that once a template
2721 class is instantiated, it can not be re-instantiated and
2723 Since our usage of map<> is ubiquitous in gdcm, this "designed
2724 limitation" of VC++ is a pitfall.
2725 Hence the Python wrappers of gdcm cannot be incrementally linked
2726 against the c++ dynamic library. The dirty but only workaround is
2727 to forget about incremental link of dynamic libraries and to generate
2728 the Python wrappers library with the inclusions of the underlying C++
2730 The following modifications concern this matter on Win32/VC++:
2731 - wrapping python correct with standalone wrapped dll (don't use separate
2732 dll under windows !!!!)
2733 - python21_d debug mode enabled (ask Frog how to use it :-)
2734 - NO problem with having an STL member of class for example string in C++
2735 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2736 - Python test of dcmlib in Python is ok under windows on a large set
2738 * removed glib references
2739 * typedef's inserted in gdcm.i for correct swig type management
2741 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2742 * python/demo/*.py load.py extracted from test.py. Added explore.py
2743 that only displays required tags and testAll.py that parses all
2744 the files of the testsuite without using unittest.
2745 * python/testSuite.py other additional test on new files added.
2746 * Data/* new test files added accordingly to the testSuite.
2747 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2748 the vr in the file differs from the one of the dictionary.
2750 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2751 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2752 values, but limits itself to values which are below a user specified
2753 size (by default 1024 bytes).
2754 * python/gdcm.i : elements not loaded (because their size is above the
2755 user specified treshold) are exported with their TagKey as key of the
2756 python dictionary. This enables the testsuite to make some checks
2757 on the unloaded elements (since we have their offset and size).
2758 * python/testSuite.py
2759 - now tests for the existence and proper value of the pixel data
2760 - two new examples added.
2761 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2763 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2764 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2765 aware. See the strategy comments in gdcmHeader::FindeLength().
2766 * Test/test.cxx now accepts a filename as first argument.
2767 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2768 * python/testSuite.py changed to integrate test on above files.
2770 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2771 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2772 the vr was also RET.
2773 * python/testSuite.py more tests added.
2775 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2776 * python/testSuite.py unittest test suite added (uses Data)
2777 * Data/* dcm and acr files for the test suite.
2778 * glib dependance removed from un*x version. We now use ISO C99
2779 7.18 Integer types (see stdint.h)
2780 - python/Makefile, src/Makefile src/gdcm.h
2781 * src/ when an explicit vr (like dicom files) suddenly poped an
2782 implicit element we use to mark the underlying DictEntry of the
2783 concerned ElValue with "Implicit". This strategy was damageable
2784 too the public or provite dictionaries, since some of their vr
2785 would be changed. Since Header::FindLength heavily relies on the
2786 detection by Header::FindVR of falsely explicit elements, I
2787 added an extra ImplicitVr member to ElValue (boolean).
2788 The rest of the changes we the necessary adaptations.
2790 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2791 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2793 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2795 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2796 * Adaptation for porting to VC++:
2798 o forced to use std namespace (for string to be known)
2799 o all class use __declspec export style on WIN32
2800 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2801 (in stdlib.h on Win32 but in std:: for gcc)
2802 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2803 variable GDCM_DICT_PATH.
2804 * src/gdcmHeader.cxx verbose comments made discrete.
2806 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2807 * python/gdcm.i: added a typemap that converts a C++ hashing table
2808 to native Python dictionary.
2809 * python/demo/test.py:
2810 - now uses the native dictionary for exploration of gdcmHeader.
2811 - takes an optional filename argument (the file to parse).
2812 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2813 PubElVals hashing table.
2814 * Dicts/dicomV3.dic removed error prone trailing spaces.
2816 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2817 * Python wrapping process moved away from src/Makefile to
2818 newly created python/Makefile (as well as gdcm.i)
2819 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2820 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2821 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2822 from the environement variable GDCM_DICT_PATH (when existing).
2823 * src/gdcmDict::GetTag bug fix.
2825 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2826 * Straightforward temporary fixes for swig to build the python wrappers.
2827 src/Makefile now has a python working entry [by working we mean
2828 that we can import de shadow classes without errors].
2830 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2831 * hashtest.cxx removed (since allready in Test)
2832 * src/gdcmlib.h renamed to src/gdcm.h
2833 * src/dcm.i renamed to src/gdcm.i
2834 * src/Makefile prepared for python wrapping
2836 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2837 * src/gdcmHeader.cxx :
2838 - Parsing of header is now separated from loading of element values
2839 (see gdcmHeader::LoadElements).
2840 - general clean up of hopefully all file access (creation of
2841 ReadInt16 and ReadInt32)
2843 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2844 * src/gdcmHeader.cxx :
2845 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2847 - SetLgrElem renamed to SetLength
2848 - GetLgrElem renamed to GetLength
2849 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2850 * src/gdcmElValSet.cxx fixed both GetElValue methods
2851 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2852 due to IdoDude was cleaned out.
2854 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2855 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2856 concentrates on finding the value representation (when it exists).
2857 RecupLgr now only finds the element value length, and it avoids
2858 returning the unecessary skL (skipped length).
2859 Also, offsetCourant was simply removed (with taille_fich) since
2860 it was redundant with the File position internals (by using
2861 ftell and fseek). This also made skL (see above in RecupLgr) usage
2863 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2864 on the libido specificities which are handled through class
2866 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2869 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2870 * Truckload of changes. Parsing of header is barely functional
2871 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2873 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2874 * src/gdcmHeader.cxx many addons of low level methods
2876 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2877 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2878 and _IdDcmSWAP_LONG.
2880 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2881 * This corresponds to all the changes decided at the meeting of
2882 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob