1 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
4 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
6 correct to copy it. The DictEntry is specified at the DocEntry creation,
7 then, it musn't change in the time.
8 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
9 header correctly. At this time, the change is only made for the first
10 level of the Document. In the future, it might consider sequences.
11 The change is made by replacing a DocEntry by an other that is created
12 outside the class. The old value is kept. When we restore the header
13 status, the added DocEntry is deleted and replaced by the old value.
14 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
15 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
16 set the write type to explicit VR, implicit VR or ACR. Add methods to set
17 the write mode to native, decompressed or RGB (but not used at this time)
19 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
21 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
23 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
25 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
27 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
28 set because already copied when copying the BinEntry's of the header
29 * Test/TestAllReadCompareDicom.cxx : remove warnings
31 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
33 Two problems appear when doing it :
34 - with the gdcmFile : when the GetImageData method is called, the pixels
35 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
36 datas (pixels). And each structure destruct the datas when it's
37 destructed. So we have two destructions for the same datas. To solve it,
38 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
39 datas or not. If it doesn't own datas, then they will not destroyed by
41 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
42 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
43 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
44 create a double destruction of the same DocEntry's. So, to solve it,
45 the TagHT is simply cleared and the DicomDir* elements are destroyed.
46 * TODO : add an entry concerning memory leaks in the DicomDir
48 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
49 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
50 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
53 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
55 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
56 after it have been deleted
58 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
59 * FIX: src/* fix the doxygen warnings.
60 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
61 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
62 was erroneously defined with a size of 15 instead of 16. [many thanks
63 to Jean Michel Rouet for pointing out this bug].
65 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
66 1. Finish merging JMR patch for writting DICOM from scratch
67 2. Fix -hopefully- bug with MONOCHROME and space vs null character
68 3. Use const ref when possible
69 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
70 5. A few more comments
71 6. CreateUniqueUID can now be called without parameter"
73 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
74 * ENH: Slightly bigger patch:
75 1. Getting toward full integration of JMR patch for writting dicom from scratch
76 2. Update Test to test part of this patch: CreateUniqueUID
77 3. File was not close properly in gdcmDict
78 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
79 5. Use of const ref instead of copy (speed issue)
80 6. Remove temporary (duplicate) string in TranslateToKey
81 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
82 8. Do not repeat virtual in subclasses
83 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
85 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
86 * Apply first patch toward better string comparison when dealing with broken
87 DICOM files. Essentially the string could be padded with a space instead
88 of a null character as defined by standard
90 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
91 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
92 because never used... and in the same time, that's remove some memory leaks
94 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * src/gdcmFile.cxx : now delete the PixelConvert instance.
96 * In examples and tests : change the type of image data variables from void*
97 to uint8_t*. Remmove all delete on image data variables
99 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
101 Verify the file pointer value before open the file, and if it's not null,
102 a verbose message is generated.
103 Close correctly the file when the file isn't considered dicom-like. The
104 correctly close is a call to CloseFile.
105 When closing the file pointer, test if its not null to close the file.
106 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
107 file. For an uncompressed image, the copied datas correspond in the least
108 case to the image size (calculated) or the image size specified in the
109 header. A verbose is generated if these two size mismatch
111 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
112 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
113 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
114 break under windows (with msvc6 compilation).
116 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
117 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
118 compiling with MSVC6)
120 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
121 * Bugs fix for the Windows build with VC6
122 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
123 needed (only for projects required VTK). If the VTK is included in all
124 projects, there is conflicts with the jpeg lib of vtk when compiling the
125 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
126 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
127 when compiling the gdcm_wrap.cxx file (created by the compilation of the
129 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
130 (like it's already made for the cout use). Otherwise, conflict with the
133 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
134 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
136 - comments on the DicomDir::Method related usage added.
137 - now that we use the namespace gdcm, a lot of internal classes do
138 NOT need to be wrapped anymore.
139 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
140 DicomDir::Method) new example added.
142 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
143 * Improve string manipulation. I now inforce the notion of 'DicomString'
144 A DicomString can contain as many \0 as they want
145 and it is *always* of even length.
146 We only support odd length for very rare case.
147 And in the near future this should be removed.
149 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
150 * /binary_write/ gdcm source. Now even on big endian we are writting
151 little endian. This should -heopfully- fix some tests
153 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
154 * Now the dictionary is compiled into gdcm lib. This is a default
155 behavior, thus any dic file specified is picked before failback to
156 the one comiled into lib
158 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
159 * Change internals for gdcmDict. Don't use any 'new' any more.
160 This should definitely solve any leak problem, and we should be
161 as fast as before, as long as don't modify too much the dictionary.
163 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
164 * STYLE: ivars should start with a capital letter.
165 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
166 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
168 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
169 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
170 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
171 new 2004 dictionaries added (thanks to JPR).
172 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
173 * CLEANUP_ROUND (15) for gdcmPixelConvert
174 - RLEFrame::NumberFragments is now of type unsigned int
175 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
176 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
179 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
180 * Initial work in gathering all transfer syntax accessors. clearly
181 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
182 ivars, but only one transfersyntax (class) ivar with equivalent method on
185 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
186 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
187 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
188 discussed (plus I didn't like having a 2000 lines patch not commited)
190 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
191 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
192 * CLEANUP_ROUND (14) for gdcmPixelConvert
193 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
194 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
195 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
197 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
198 anymore and hence avoids storing a copy of PixelConvert::Decompressed
199 into File::Pixel_Data.
201 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
202 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
203 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
204 * CLEANUP_ROUND (13) for gdcmPixelConvert
205 Substituted File::ParsePixelData() with PixelConvert::Print() new
207 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
208 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
209 method to those classes.
210 - src/gdcmFile.[cxx|h]:
211 -- Added a ::Print() method.
212 -- PixelConverter is now a reference instead of a member.
213 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
214 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
216 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
217 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
218 collaboration diagram and inheritance diagram should be generated with
220 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
221 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
222 pointlessly wrapped (see
223 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
224 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
225 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
226 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
227 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
228 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
229 -- File::Initialise: PixelConverter setup moved away to
230 PixelConverter::GrabInformationsFromHeader()
231 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
232 interpretation moved away to PixelConverter::BuildRGBImage()
234 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
235 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
236 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
238 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
239 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
240 displayed on Win32 when a brutal abort() occurs (because of uncatched
241 exception). See TODO new entry of this commit for more on this.
242 * TODO added new entry.
243 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
244 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
245 - HandleColor is no longer called from gdcmFile.cxx
246 - gdcmPixelConvert.cxx clean up on method arguments and internal
247 variable names for semantical coherence.
249 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
250 * Finished lossless transition, not only do we now read all lossless jpeg
251 images, without the need of the Cornwell lib, but we do read them properly now
252 * To reduce code (well to avoid code duplication), I defined a common place
253 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
254 redefine symbols. This is not prefect but this the best solution I found for a
255 compilation time jpeg option.
257 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
258 * Update jpeg ijg lib to support lossless jpeg implementation
259 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
261 * Also added a special copyright for dcmtk since we use their bugfixes.
264 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
265 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
266 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
267 matters, as stated in warning note at begining of %include section).
268 * src/gdcmDicomDir*.[cxx|h]: coding style
269 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
270 * src/gdcmJpeg8.cxx: doxygen fix.
271 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
272 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
273 from File:: to PixelConvert::.
275 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
276 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
277 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
278 - more code moved away from File:: to PixelConvert::
279 - fat setup of PixelConverter set in place in File::Initialise.
281 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
282 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
283 namespace at the file system level. So now you should convert your examples
285 gdcmHeader -> gdcm::Header
286 It would be nice if people keep in mind to no open the namespace, since it
287 allows compilation on broken plateform which were defining common symbol in
288 the standart namespace (like LP, Unknown ...)
290 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
291 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
292 The JPEG fragments are now parsed at the same stage than the RLE
293 information. All code related to JPEG is now in gdcmPixelConvert:
294 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
295 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
296 export a gdcmFile:: method. Those are simply global functions
297 (for the time being this is better than having them attach to
298 either gdcmFile:: or gdcmPixelConvert::).
299 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
300 and stores the result in a gdcmJPEGFragmentsInfo.
301 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
302 code (among other stuff) moved away from gdcmFile:; to
305 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
307 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
308 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
309 clean up of RLE related code.
310 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
311 - src/gdcmRLE.cxx removed
312 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
313 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
314 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
315 * CLEANUP_ROUND (9) for gdcmPixelConvert
316 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
317 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
318 away from gdcmFile:: to gdcmPixelConvert::.
320 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
322 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
323 This is because Parse7Fe0 used to parse the pixels to compute the
324 length. This task was passed over to FindDocEntryLengthOB() a long
325 time ago, EXCEPT I had forgotten the OW case...
326 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
327 we just recylce the code for parsing RLE fragments and computing
329 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
330 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
331 with the retired Parse7Fe0().
332 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
333 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
335 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
336 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
337 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
338 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
339 - src/CMakeLists.txt: alphabetic order reodering + new entries.
340 * CLEANUP_ROUND (4) for gdcmPixelConvert
341 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
342 to return an unused length.
344 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
345 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
346 this should be cleanner from the plane view. The iostream are erally a pain
347 to use to do simple stuff.
349 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
350 * Redo the compilation of the ijg jpeg library. Now only one source is
351 necesseray. No need to rename file by hand what so ever. CMake handle the
352 copying of the file within different directory, configure header file to
353 modify some symbol. The only addition made to ijg wasd a mangle table so
354 that symbol are different wether we are within 8bits or 12bits.
356 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
357 * Added documentation of vtkgdcmReader on Website:
358 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
359 with it's binary name).
360 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
361 the Website to be more complete.
362 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
363 doxygenated documentation.
364 - Doc/DoxyVtkGdcmReaderExamples.txt added
365 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
366 DoxyVtkGdmReaderExamples.html )
367 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
368 * CLEANUP_ROUND (3) for gdcmPixelConvert
369 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
371 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
372 * CLEANUP_ROUND (2) for gdcmPixelConvert
373 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
375 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
376 * CLEANUP_ROUND for gdcmPixelConvert:
377 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
378 - src/gdcmPixelStuff[h|cxx] removed
379 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
380 - src/CMakeLists.txt changed accordingly
382 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
383 gdcmVersion.py moved to newly created ATTIC related
384 gdcmPython/SetupOldies/ directory.
385 * Autotools clean up:
386 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
387 - autogen.sh configure.in acinclude.m4 python.m4 removed
389 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
390 * src/*.cxx *.h Reference to License.htm fixed to License.html.
391 * Doc/CMakeLists.txt, doxygen.config.in: fix.
392 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
394 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
395 * TODO updated with Mathieu suggestions. I proposed a template for
396 describing TODO entries and used it for new entries.
397 * Added Doc/Website/CodingStyle.html, Developpers.html,
398 DeveloppersPython.html, GdcmDataCvs.html and
399 DownloadVersion0_1.html, DownloadVersion0_3.html.
400 * Some Doc/*.txt Doxygen files (which do not really concern the
401 documentation itself, but the website) moved to html and
402 placed in directory Doc/Website:
403 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
404 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
405 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
406 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
407 * CMakeLists.txt changed accordingly.
408 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
409 DeveloppersPython.html
410 * INSTALL nows refers to Doc/Website/Installation.html
412 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
413 * Added Doc/Website directory, that contains a first raw version
416 2004-09-23 Jean-Pierre Roux
417 * FIX In order not to be poluted any longer by casting problems,
418 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
419 we can now delete[] it safely
420 * VoidArea is now called BinArea (less confusing name),
421 and all the methods called ...VoidArea... are now ... BinArea...
422 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
424 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
425 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
426 clear) TagHT, which is an inherited member of gdcmElementSet. It is
427 up to the destructor of gdcmElementSet to clean up TagHt and it's
430 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
431 * Test/CMakeLists.txt: update to follow gdcmData renamings.
432 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
434 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
435 * ENH: added some utility method that builds a flat dictionnary
436 holding all the Dicom entries contained in the recursive structure
437 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
439 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
440 BuildFlatHashTable() that build a flat dictionary.
441 - src/gdcmElementSet.h: added a new private GetTag() accessor.
442 gdcmDocument is now a friend of gdcmElementSet.
443 - src/gdcmElementSet.cxx: clean up.
444 - Example/FlatHashTablePrint.cxx added.
445 - Example/CmakeLists.txt changed accordingly
447 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
448 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
449 moved away from gdcmDocEntrySet (since this class is an abstract class
450 acting like an interface). SQDepthLevel and BaseTagKey are now
452 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
453 and associated accessors. Doxygenation of the class.
454 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
456 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
457 Use SQDepthLevel accessor instead. ::Print() adapted.
458 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
459 - src/gdcmDocument.cxx changed accordingly.
461 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
462 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
463 - The following is the doxygen comment of the typedef declaration
464 of gdcmagKey in src/gdcmCommon.h:
465 gdcmTagKey is made to old an "universal" (as in URL, Universal
466 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
467 A dicom tag allways has a group and an element, but a set of tags
468 embeded in various (optionally nested) sequences and sharing
469 the same group and element all share the same (group, element)
470 "identifier". Hence the (group, element) cannot be used as an
471 identifier (in gdcm we shall refer to a "TagKey") of a tag.
472 In order to construct a proper tag identifier (i.e. a key) we
473 consider the following definition of a TagKey:
474 - let Group, Element be the string representation of the
475 group and element dicom tag members,
476 - let ItemNumber be the string representation of the integer
477 index of the considered item number of a sequence,
478 Let the key of a tag embeded in a sequence, noted SeqTag, be
480 /ItemNumber#Group|Element
481 where "/", "#" and "|" are characters acting as separators.
482 Then the general form of a gdcmTagKey is given by:
483 Group|Element<SeqTag>
484 where <SeqTag> means NO or many instances of SeqTag.
485 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
488 but the gdcmTagKey of a tag "embeded" is the first item of
489 a sequence, itself nested in the third item of a sequence is the
491 0004|1220/2#0008|0082/0#0008|0090
492 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
493 order to hold the new sequence compatible key. Previously, the
494 GetKey() method would look in the underlying gdcmDictEntry.
495 - src/gdcmDocEntry.cxx:
496 -- constructor now copies the underlying DictEntry key, in the local
498 -- ::Print: displays the member Key, instead of the (group, element).
499 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
500 - src/gdcmDocEntrySet.h:xi
501 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
502 -- now has a new BaseTagKey member.
504 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
505 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
507 This poses the problem with the semantics of the following lines
508 LoadEntryVoidArea(0x0028,0x1201); // R LUT
509 LoadEntryVoidArea(0x0028,0x1202); // G LUT
510 LoadEntryVoidArea(0x0028,0x1203); // B LUT
511 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
512 to the long FIXME note for what the problem is. Nevertheless in
513 order to get things working the dicom dictionary was altered !
514 Please fix things urgently...
515 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
516 information), see above note on moving the member VoidArea. Nevertheless
517 the following entries previously correctly set as US are now inproperly
519 0028 1201 OW IMG Red Palette Color Lookup Table Data
520 0028 1202 OW IMG Green Palette Color Lookup Table Data
521 0028 1203 OW IMG Blue Palette Color Lookup Table Data
522 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
523 of gdcmDocEntry moved to gdcmSeqEntry.
524 * src/gdcmSeqEntry.cxx: STYLE.
526 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
527 * Test/TestAllEntryVerify.cxx minor fix and added comments.
529 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
530 * gdcmPython/testSuite.py: all the test suite in python is now moved
531 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
532 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
533 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
535 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
536 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
537 to avoid inclusion recursion until STL is reached.
538 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
539 mecanism. errno.h is not included in gdcm anymore.
540 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
541 (gdcmFormatError now inherits from gdcmFormatUnexpected).
543 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
544 gdcmData/TestAllEntryVerifyReference.txt
545 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
546 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
547 exception_on_error parameter.
548 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
549 - vtk/vtkGdcmReader.cxx changed accordingly,
550 - Example/*.cxx and Test/*.cxx changed accordingly.
552 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
553 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
554 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
555 enable_sequences removed from gdcmHeader constructor and dependencies.
556 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
557 * gdcmPython/demo/PrintHeader.py: dummy fix.
558 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
559 skip_shadow removed from gdcmHeader constructor and dependencies.
560 * Example/*.cxx and Test/*.cxx changed accordingly.
562 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
563 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
564 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
566 2004-07-21 Jean-Pierre Roux
567 * FIX Now, Parsing and Printing a DICOMDIR do work!
568 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
570 2004-07-20 Jean-Pierre Roux
571 * FIX Some brain damaged headers have Zero-Lenght fields
572 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
574 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
576 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
577 variable (instance of gdcmDebug) by a definition macro, and the instance
578 is now in static in the gdcmDebug class
579 * src/gdcmSQItem.h : (FIXME) remove an undefined method
580 * Test/PrintAllDocument.cxx : bug fix in the result of the test
582 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
583 * WARNING: ctest now depends more tightly on gdcmData. You should
584 check out gdcmData properly for things to run smoothly...
585 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
586 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
587 we need the pixels not be loaded in order to use the ValEntry
588 that displays position and size).
589 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
590 This is a C++ based equivalent of gdcmPython/testSuite.py that should
591 be deprecated. If you have any doubts about the advantages of a
592 modern scripting language (read Python) versus grass root C++ (i.e.
593 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
594 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
595 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
596 Anyhow, consider documenting the gdcmData images in
597 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
599 * Test/CMakeLists.txt:
600 - now uses TestAllEntryVerify.cxx
601 - specific comments on oldACR00001.ima (now renamed in gdcmData
602 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
603 gdcmData/TestAllEntryVerifyReference.txt
606 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
607 * src/*.[h|cxx] : typedef clean up
608 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
609 - TagKey renamed to gdcmTagKey (for external usage)
610 - VRKey renamed to gdcmVRKey (for external usage)
611 - removal of typedef duplication.
612 - Removed all unecessary inline keyword from class inline definitions.
613 - Some method|function(void) declarations replaced with method|function().
614 * src/jpeg/libijg12/jdhuff12.c:
615 - printf polluting ctest removed.
616 - TAB removal for comminting
618 - TestAllReadCompareDicom.cxx: added a test that compares all the
619 images in gdcmDataImages.h with corresponding images in
620 gdcmData/BaselineDicom/. When baseline images are not present
621 this test creates them.
622 Note: we need to validate each reference image, but before that
623 I'd like to rename them with a more explicit name...
624 - CMakeLists.txt: changed accordingly.
625 * Example/*.cxx: examples now only include gdcm.h (as opposed to
626 including each header needed).
628 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
629 * Test/*.cxx and Example/*.cxx: moved some examples away from the
630 test suite to the Example directory. Are concerned:
635 - TestWriteSimple.cxx
636 * Test/CMakeLists.txt: added some comments on reasons for black listing
637 image gdcmData/oldACR00001.ima
639 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
640 * Test/CmakeList.txt: removed the following from black list (to be coherent
641 with removal from gdcmData):
642 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
643 - gdcm-MR-PHILIPS-16.dcm
645 Added the following because after last cvs update, they cause
646 ctest -R TestReadWriteReadCompare
648 - gdcm-MR-SIEMENS-16-1.acr
650 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
651 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
652 new comments in this file) we temporarily (sigh) move to a weaker
654 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
655 we don't need to black list the following images anymore:
656 - 8BitsUncompressedColor.dcm
658 - US-PAL-8-10x-echo.dcm
659 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
660 fixes and the beautified code ;-)
661 This fixes the bug introduced in version 1.42 (when beautifying)
662 that made the parsing of 8BitsRunLengthColor.dcm unproper.
663 Note: ctest was blind to this bug (this means we need to still
664 improve the test suite). The bug could be detected by using
665 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
667 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
668 and by displaying the (garbage) produced file temp.XDCM...
670 2004-06-29 Jean-Pierre Roux
671 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
672 - replace by uggly but working old code :-(
673 A lot of things should be OK again.
674 It's really urgent to have a test suite that *tests*,
675 to prevent Frog's beautifying sessions to break all the stuff
676 (twice, withing a fortnigh ...)
678 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
679 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
680 redundancy) to added Test/TestReadWriteReadCompare.cxx
681 * Test/CmakeList.txt: because the compare test of
682 Test/TestReadWriteReadCompare.cxx fails, the following images are
683 black listed: - 8BitsUncompressedColor.dcm
685 - US-PAL-8-10x-echo.dcm
686 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
687 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
688 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
689 and ad-hoc kludge. This kludge is now removed, and on encountering
690 such an image (OB field brain damaged) we set errno. Then in
691 ::FindDocLength() we "fix" the length as being ALL what remains
692 in the file (until EOF). We then proceed, hoping for the best...
693 This fixes a SegFault in ShowDicom when trying to write such an
695 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
696 (because TestWriteRead breaks on it, after a non conformal commit?).
697 ctest now runs properly, except for MakeDicomDir (which was allways
698 broken) and the Python related stuff (still not fixed).
700 2004-06-24 Jean-Pierre Roux
701 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
702 FIX : Test/TestReadWrite now iterates on all the file names
703 (instead of infinite loop)
704 ENH : Test/TestWriteRead now iterates on all the file names
706 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
707 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
709 2004-06-24 Jean-Pierre Roux
710 FIX : - now Write drops LUT Descriptors and LUTs (if any)
711 when SamplesPerPixel =3
712 - now Write is no longer confused by
713 'BitsAllocated = 12" and 'BitsStored=12"
714 - "UN" value representation Elements are now written correctly
715 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
716 ENH : - now gdcmHeader has its own Write methods
717 (in order to split the job that has not to be done
720 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
721 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
722 loop on the same image until memory went out.
723 Note: this means we still have gobs of memory loss in PrintDocument
724 * src/gdcmDocument.cxx: fixes problem on parsing on file
725 gdcmData/16BitsJpegLosslessGrayScale.dcm.
727 2004-06-24 Jean-Pierre Roux
728 FIX : Write - All the Sequences and Sequence Item are now written
729 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
730 is added a the end, when necessary.
731 - A lot of brain-damaged images, that were read correctly are
732 now written correctly
733 - length compatible BinEntry are now loaded correctly
734 (even for odd groups)
735 Note : only Explicit Value Representation was checked.
736 (question : is implicit VR really necessary for gdcm ?)
738 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
739 * DEVELOPPER: added a proposition of coding style.
740 * src/gdcmDocEntry.h: removed every inline declaration (for test of
743 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
744 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
745 Use the gdcmDocEntry::Print() and Write() instead.
746 * src/gdcmDocument.cxx: bug fix.
748 2004-06-22 Jean-Pierre Roux
749 FIX : gdcmDocument.cxx
750 - Now we do recognize the JpegLossLess format (there was a misstyping in
751 code 'beautyfication' :-(
752 - Now we automaticaticaly load the Luts, if any
754 2004-06-22 Jean-Pierre Roux
755 In order : to write Sequences, whatever their imbrication level,
756 : to allow user to create his own Sequences
757 a lot of modif where necessary (adding, moving, or virtualising methods)
759 WARNING : save your own sources *before* cvs up !
762 ADD virtual void Write(FILE *fp, FileType filetype);
765 ADD virtual void Write(FILE *fp, FileType filetype);
766 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
769 ADD virtual void Write (FILE *fp, FileType filetype)=0;
770 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
771 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
772 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
773 ADD std::string GetEntryByName(TagName name);
774 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
776 std::string vr = "unkn",
777 std::string fourth = "unkn",
778 std::string name = "unkn");
779 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
780 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
781 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
782 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
783 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
784 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
785 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
786 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
789 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
790 ADD virtual std::string GetEntryByName (TagName tagName);
791 ADD virtual std::string GetEntryVRByName (TagName tagName);
792 REM virtual bool Write(FILE *, FileType);
793 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
794 FILE *_fp, FileType type);
795 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
796 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
797 REM virtual bool WriteEntries(FILE *_fp,FileType type);
798 REM virtual std::string GetEntryByName (std::string tagName);
799 REM virtual std::string GetEntryVRByName (std::string tagName);
800 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
801 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
802 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
804 std::string vr = "unkn",
805 std::string fourth = "unkn",
806 std::string name = "unkn");
807 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
808 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
809 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
810 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
813 ADD virtual void Write(FILE *fp, FileType filetype);
816 ADD virtual void Write(FILE *fp,FileType filetype);
819 ADD virtual void Write(FILE *fp, FileType filetype);
820 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
821 REM std::string GetEntryByNumber(guint16 group, guint16 element);
822 REM std::string GetEntryByName(TagName name);
825 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
827 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
828 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
829 The default constructor invoked by the line
830 gdcmHeader *f1 = new gdcmHeader( header );
831 was gdcmHeader::gdcmHeader(bool) instead of the expected
832 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
833 Hence the parsing wasn't executed... See also below.
834 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
835 as explicit constructor didn't do the trick to fix the above problem.
836 Could anyone explain why ?
837 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
838 properly calls gdcmValEntry::Print() (that was weed out from
839 code related to gdcmBinEntry).
841 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
842 * In order to fix memory leaks:
843 - Test/TestWriteSimple.cxx: added cleaning of free store through
845 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
846 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
847 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
848 (through the call to ::AddDicomDirMeta()) or the destructor
849 would crash when deleting uninitialized ::metaElems].
850 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
851 - src/gdcmDocument.cxx:
852 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
854 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
855 was causing memory leaks.
856 - src/gdcmSQItem.cxx:
857 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
858 cleanly handled with polymophism: sorry but my milage is low).
859 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
860 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
861 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
862 This avoids SegFaulting.
863 - src/gdcmSQItem.h: coding style.
865 - Test/TestWriteSimple still severely sucks. The output image content
866 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
867 damaged when displayed with vtkgdcmViewer.
868 - on memory leaks: TestWriteSimple leaks really less (see entry
869 of 2004-06-18 in Changelog file for the call to valgrind).
870 - on segfaults: ctest now passes all the tests but one (no more
872 * Erroneous leading white fix:
873 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
874 white[s] (as opposed to from >> xxx, that removes it [them].
875 - src/gdcmTS.cxx: ditto.
876 - gdcmPython/testSuite.py: dirty related kludge removed.
877 * src/*: remaining references to gdcmParser removed.
878 * src/*[cxx|h]: added copy[way]left header.
881 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
882 * In order to fix writing of dicom files:
883 - Test/TestWriteSimple.cxx: a simpler example of writing.
884 - Test/CMakeLists.txt changed accordingly.
885 - src/gdcmDocument.cxx:
886 -- The destructor now recursilvely removes potential sequences.
887 -- Bug fix in ::IsJPEG2000()
888 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
889 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
891 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
892 to only declared) and build on top of
893 ::GetDocEntryByNumber(guint16, guint16).
894 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
895 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
896 for usage in destructor and treatement of promotion in
897 ::ReplaceOrCreateByNumber().
898 - src/gdcmSQItem.cxx: destructor should better handle his job.
899 Test/TestWriteSimple now runs (or at least it DOES something).
900 * We can now start hutting memory links. A good starting point is:
901 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
902 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
903 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
905 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
906 * Valgrind note: after Mathieu Malaterre teached me how to read
907 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
909 Using gcc, you can force the STL to use malloc and to free memory as
910 soon as possible by globally disabling memory caching.
911 With 3.2.2 and later, you should export the environment variable
912 GLIBCPP_FORCE_NEW before running your program.
913 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
914 simply vanish (it is still not clear to me, whether this means that
915 STL std::string leaks or if valgrind believes it leaks...).
916 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
917 running bin/gdcmTests makeDicomDir):
918 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
919 - Test/makeDicomDir.cxx now properly traps empty lists and returns
921 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
922 SegFaulting (I drowned in DicomDir related code when trying to
923 understand why the list is empty...).
924 * src/gdcmDocument.h: first BSD license header try.
925 * Doc/License.txt added.
927 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
928 * src/gdcmDocument.[h|cxx]:
929 - Clean up of the Transfer related predicates. They are now all based
930 on new method isGivenTransferSyntax, that (should) handle properly
932 - general clean up, simplification, and coding style.
933 - Specific clean up of Parse7FE0() (umproperly named actually).
934 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
936 2004-06-14 Jean-Pierre Roux
938 - fix the display of Sequence Delimitor (SQDepthLevel pb)
939 - fix the display of SQItem ordinal number
940 - add the GetSQItemByOrdinalNumber method
941 - remove some useless never written private methods
943 2004-06-14 Jean-Pierre Roux
945 - adding a constructor taking a gdcmDocEntry as an input param
946 - ReplaceOrCreateByNumber now returns :
947 a gdcmBinEntry * if a Binary (void *) value is passed as a param
948 a gdcmValEntry * if a string value is passed as a param
950 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
951 according to the param type (no longer sets a gdcmDocEntry)
952 - GetValEntryByNumber, GetBinEntryByNumber added
953 - NewValEntryByNumber and NewBinEntryByNumber added
955 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
957 - GetSQItemNumber and SetSQItemNumber added, to provide
958 a (relative) Item identier inside a given Sequence
959 \warning : some pb remaining around this number
961 - AddEntry now takes the Item Number as a param
963 - adding a constructor taking a gdcmDocEntry as an input param
965 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
966 * Memory leak hunt with the following command:
967 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
968 --show-reachable=yes gdcmTests PrintDocument
969 It looks like many (all?) leaks are due to the STL (or a bad usage
970 of the STL. The lines producing the leaks now have a comment with
971 a "MEMORY LEAK" tag: you can retrieve them with
972 grep "MEMORY LEAK" src/*
973 Here are two typical examples which I can't help fixing:
978 char * test = "babo";
979 name = test; //// <--- valgrind detects 960 bytes lost in
980 //// call to std::string::operator=(char const*)
981 name.clear(); //// Doesn't help !
989 std::cout << "Type a bunch of characters followed by RETURN: ";
990 getline(std::cin, line); //// <--- valgrind dectects a loss
991 //// of 1320 bytes in call to
992 /// std::basic_istream<>& std::getline<>
998 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
999 * src/gdcmHeader.[cxx|h]:
1000 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1001 and related, moved away to gdcmDocument.
1002 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1003 the corresponding protected accessors of inherited class
1004 gdcmDocument, removed ! As a consequence gdcmFile had to be
1005 declared friend of class gdcmDocument (see below).
1006 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1007 - Clean up of undefined or unused methods.
1008 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1009 account the changes to gdcmHeader.h).
1010 * src/gdcmDocument.h:
1011 - gdcmFile is now a friend class (in order to take into account the
1012 changes to gdcmHeader.h).
1013 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1014 (see changes to gdcmHeader.h).
1015 - Accessors (reading on the form GetEntry*) are now public.
1016 - Clean up of undefined or unused methods.
1017 * src/gdcmDocument.cxx:
1018 - adaptation to changes to gdcmDocument.h
1019 - ::OpenFile now writes a verbose message when file cannot be opened.
1020 - some std::string properly set to VRKey
1021 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1022 references to gdcmDocument.
1023 * Test/TestFindTags.cxx: changed accordingly to above changes.
1024 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1025 cvs repository gdcmData.
1027 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1028 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1029 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1030 conflicts with gdcmValEntry::voidArea.
1031 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1032 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1033 Value representation between StringRepresentable and BinaryRepresentable.
1034 * src/gdcmDocument.cxx:
1035 - method ParseDES: proper indentation restored and usage of
1036 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1037 - method LoadDocEntry: the fingerprint left in the SetValue() of
1038 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1039 removed. Reverting to previous code segment with the proper
1040 dynamic_cast< gdcmValEntry* >.
1041 Note: this was (partially) breaking the python test suite
1042 (gdcmPython/testSuite.py) that made usage of the above
1043 fingerprint to check presence of "Pixel Data".
1044 * src/gdcmDocEntry.h: coding style.
1045 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1046 now taken into account.
1047 * gdcmPython/gdcm.i: adaptation to the new internal representation
1048 of gdcm (exit gdcmParser, hello gdcmDocument).
1049 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1051 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1052 anymore, but instead prints the loaded Python dictionary.
1053 * .... alas, the python testSuite is still broken.
1055 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1056 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1058 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1059 * src/gdcmUtil.h : export methods
1061 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1062 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1064 * Initial addition of automatic python testing
1065 * Initial addition of automatic image comparison
1067 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1068 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1069 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1071 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1072 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1073 * Test/ShowDicom.cxx : bug fix for msvc compilation
1074 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1076 2004-05-04 Jean-Pierre Roux
1077 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1078 new concepts (and new classes) :
1079 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1080 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1081 - Sequence Doc Entries (gdcmSeqEntries)
1082 a Sequence is composed of Items.
1083 Each item is a set of Doc Entries (this is recursive)
1084 The non uniqueness of the 'Dicom tag' is due to this recursivity
1085 (never taken into account)
1086 Our unability to add a new 'entry' in the header
1087 at the proper location (neither in the H-Table (map or multimap),
1088 nor in the Chained List is also due to this recursivity.
1089 Don't try, right now, to use/modify/compile these new sources :
1090 nothing is finished.
1091 We just commit all the stuff, 'as is', in order not to loose it.
1093 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1094 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1096 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1097 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1098 file prefix (SetFilePrefix)
1100 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1101 * Add a new test: ShowDicom, for now this is just the c++ version of
1102 checkRead.sh, later it will be able to compare the image read against a
1104 * Replace the DEBUG on the stack with a global entry in cmake interface:
1105 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1107 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1108 * Add an example subdir, with a real example on how to read + write a
1111 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1112 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1113 * Doc/CMakeLists.txt: the main page is now properly differentiated
1114 between the developper and user version.
1115 * Doc/doxygen.config.in: dropped search related obsolete flags
1116 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1118 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1119 * DEVELOPPER: added some helpfull comments for compile/test/install
1122 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1123 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1124 src directory, now generated in the build dir.
1125 2. Tests as mentionned smarter
1127 4. Add a new method in gdcmDict that return the PubDict by name
1128 this is interesting for 3rd party lib like ITK,
1129 where we could set the institution name / patient name...
1131 * ENH: 1. Now the test suite is working for real
1132 2. All binaries are now output in the gdcm-bin directory
1133 (this was not true before)
1135 2004-04-28 Jean-Pierre Roux
1136 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1137 SeQuence indented printing of Dicom Header.
1138 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1139 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1140 Computation of SQDepthLevel is now part of gdcmHeader constructor
1141 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1142 tree-like structure of a Dicom Header.
1143 * FIX Test code cleaning
1145 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1146 * ENH: Adding automatic testing
1147 1. Need a DartConfig.cmake to submit to public
1148 2. Add a test driver gdcmTest.cxx
1149 3. gdcmTestMain, an helper for the main test driver gdcmTest
1150 4. Files in Test don't have a main anymore, this becomes interesting
1151 when we add more and more tests, thus dsw don't have to load
1153 * ENH: Adding a GDCM_DATA_ROOT for testing
1154 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1155 one file instead of seven + some small cleanup
1157 2004-04-22 Jean-Pierre Roux
1158 * ENH Minor changes to the Print() methods.
1159 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1160 Header printing. Example given with :
1161 > PrintHeader fileName 2 new
1162 (SQ based tree-like structure still to be done for the Header ...)
1164 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1165 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1166 1. I have added some unsigned where needed
1167 2. Some function parameter not used -> (void)
1168 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1169 4. g++ don't like character '\' in comment
1170 5. #define jpeg_create_decompress jCreaDecompress
1171 this really need to be fixed
1172 6. virtualize destructor of gdcmObject ... leakage
1173 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1174 this also really need to be fixed
1175 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1176 remove compression file
1177 (as we only do decompression, right ?)
1178 * ENH: Change malloc/calloc/free with c++ equivalent
1180 2004-04-21 Jean-Pierre Roux
1181 * FIX gdcmHeaderHelper::GetXSpacing
1182 when a single value is found (bug ?), xpacing is now
1183 defaulted to yspacing
1185 2004-04-19 Jean-Pierre Roux
1186 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1187 * ENH add parameters :
1188 bool exception_on_error = false,
1189 bool enable_sequences = false,
1190 bool ignore_shadow = false
1191 to the gdcmFile constructors to be full gdcmParser compliant
1192 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1193 to allow reading of PAPYRUS 3.0 files
1195 2004-04-06 Jean-Pierre Roux
1196 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1198 2004-04-02 Jean-Pierre Roux
1199 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1200 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1201 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1203 2004-03-30 Jean-Pierre Roux
1204 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1205 for ACR file, written out as DICOM files (hope so...)
1207 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1208 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1209 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1210 moved to base class gdcmParser and only the specialisation is kept
1212 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1213 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1214 already does the job.
1215 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1216 (to be consistent with gdcmParser::WriteEntries).
1218 2004-03-30 Benoit Regrain
1219 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1220 upate of the object's instance. It's passed to 2 in the unfavorable
1221 case : one in the ExecuteInformation, one in the ExecuteData
1223 2004-03-29 Jean-Pierre Roux
1224 * ENH : Check on file type to be written moved
1225 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1226 * FIX : gdcmObject::ResetBoundaries now stops properly
1227 when end-of-list is reached
1228 : gdcmVersion modified (as Benoit Regrain asked)
1230 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1231 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1232 * src/gdcmUtil.cxx: added forgotten iostream include.
1233 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1234 equivalent to ExplicitVR in existing code).
1236 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1237 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1238 now contains all the gdcmGlobal related code.
1239 * minor coding style and doxygenation changes.
1241 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1242 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1243 now contains all the Debug related code.
1244 * minor clean-up of includes in src/*.cxx
1245 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1246 CreateCleanString) removed.
1247 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1248 * Doc/DoxyMainPageUser.txt added.
1249 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1250 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1251 src/gdcmDirList.cxx)
1253 2004-03-24 Jean-Pierre Roux
1254 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1256 2004-03-23 Jean-Pierre Roux
1257 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1258 big endian made volumes
1259 * ENH Now gdcmParser constructor and destructor are protected to forbid
1260 end user to instanciate class gdcmParser
1261 (only gdcmHeader and gdcmDicomDir are meaningfull)
1263 2004-03-22 Benoit Regrain
1264 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1265 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1266 gdcmSerie to gdcmDicomDirSerie
1268 2004-03-19 Jean-Pierre Roux
1269 * ENH Now the tree-like structure describing a DICOMDIR comming from
1270 an already existing DICOMDIR file is consistent with
1271 the home-made tree-like structure build ex-nihilo
1272 or build from the files held (recursively) in a Directory
1273 functions gdcmDicomDir::CheckBoundaries()
1274 gdcmObject::SetBoundaries() added
1276 2004-03-17 Jean-Pierre Roux
1277 * REM (Eric Boix bug) : removal of meaningless
1278 gdcmDicomDirImage::NewImage function.
1279 * FIX now file names and directory name are written properly in the
1281 * FIX now gdcmDicomDir constructor may be call without any trick
1284 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1285 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1286 of gdcmDicomDirImage::NewImage as empty function.
1288 2004-02-28 Jean-Pierre Roux
1289 * ENH add gdcmDicomDir:NewPatient
1290 add gdcmDicomDirPatient:NewStudy
1291 add gdcmDicomDirStudy:NewSerie
1292 add gdcmDicomDirSerie:NewImage
1293 to allow making gdcDicomDir object.
1294 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1295 (as opposite to the gdcmHeader chained list)
1297 2004-02-11 Benoit Regrain
1298 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1299 when using from python
1301 2004-02-10 Benoit Regrain
1302 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1303 * FIX : in gdcmDicomDir when the directory is empty
1304 * ENH : add callback and methods to get the progression of dicomDir
1307 2004-02-06 Jean-Pierre Roux
1308 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1309 - GDCM_META added to gdcmDicomDirType
1310 - class gdcmMeta created
1311 * ENH : - A brief summary is now displayed at the beginning of
1312 'testDicomDir' to help disaster magnitude estimation
1313 * REM : Now useless Test/explDICOMDIR.cxx
1315 2004-02-05 Benoit Regrain
1316 * ENH : add methods in gdcmObject to get the hash table or the list of
1318 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1319 * FIX : wrapping python for TagHeaderEntryHT
1321 2004-02-04 Benoit Regrain
1322 * FIX : even length for some strings when writting the dicom dir
1323 * FIX : sort the images in the dicom dir
1324 * FIX : Bug fix for python use of dicom dir
1325 * ADD : a python demo
1327 2004-02-04 Jean-Pierre Roux
1328 * FIX : Final solution (?) for icone embedded images
1329 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1330 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1331 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1332 gdcmData/gdcm-MR-SIEMENS-16.acr1
1333 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1334 to make full checking easier
1336 2004-02-04 Benoit Regrain
1337 * FIX : WriteEntries : coding style & logic in parameters
1338 * FIX : Set the elements to create the DicomDir in a dictionary file
1340 2004-02-03 Benoit Regrain
1341 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1342 * gdcmDicomDir : add the load of directory
1343 * Bug fix and print add-on
1345 2004-02-03 Jean-Pierre Roux
1346 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1347 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1348 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1349 * FIX gdcmParser.cxx : 'group length' elements are now considered
1350 as integers, even for shadow groups, when file is Implicit VR
1352 2004-02-02 Jean-Pierre Roux
1353 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1355 of the last synonym :-(
1356 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1358 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1359 * FIX taking into account the possible 7fe0,0010 multiplicity
1360 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1361 to allow removal of references to 7fe0,0010, to deal with
1362 ACR-NEMA images, when 0028,0200 is meaningfull
1364 2004-01-31 Jean-Pierre Roux
1365 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1366 no longer writes 'Un' on disk
1367 * FIX SQ elements with actual length are now dealt with corectly
1368 * FIX gdcmFile::WriteBase make the difference, for color images, between
1369 the length (for Palette expanded images)
1370 and Raw Length (non expanded image + Palette)
1371 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1372 (that broke Write). Replaced by UL.
1373 Aware user will reload the field if he
1374 thinks it's necesssary
1376 2004-01-30 Jean-Pierre Roux
1377 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1378 when 'dirty Acr' is found, to be compliant with the new
1379 IsReadable() methods.
1381 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1382 (no DOUBLE images in kosher DICOM,
1383 but so usefull for people that miss them ;-)
1385 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1386 DICOMDIR related utilities (not checked as Windoze compliant)
1388 2004-01-28 Jean-Pierre Roux
1389 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1391 2004-01-27 Jean-Pierre Roux
1392 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1393 to allow skipping the shadow elements, to save memory space.
1394 The TRUE value for this param has to be used
1395 with a FALSE value for the 'enable_sequence' param.
1396 ('public elements' may be embedded in 'shadow Sequences')
1397 * gdcmHeader methods now deal with 'embedded icones images' in the header
1398 (even when an 'icone image sequence' is announced by the
1399 element (0x0088,0x0200), but there is NO icone at all ...
1401 * gdcmHeader sometimes Image Location value doesn't follow
1402 the supposed processor endianity (see gdcmData/cr172241.dcm).
1405 * gdcmHeader add the method
1406 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1407 to get *all* the Header Entries with the same tag.
1408 GetHeaderEntrySameName is probabely *useless*
1409 (no meaning : Name is *not* an identifier within the Dictionnary)
1411 2004-01-26 Benoit Regrain
1412 * Bug fix in the print of hexadecimal representations. Remove long fields
1413 in the print and add a third level of print to print them
1415 2004-01-23 Benoit Regrain
1416 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1417 * Bug fix on test suite after remove the strip made on not string fields
1418 * Split the IsReadable method between gdcmParser which test that the file
1419 is dicom and gdcmHeader which test that it's an image file
1421 2004-01-22 Benoit Regrain
1422 * DicomDir : clean code, add methods, set variables in protected or private
1423 * gdcmUtil : bug fix for the clean string method
1425 2004-01-19 Benoit Regrain
1426 * Add the use of shadow dictionaries
1427 * bug fix and coding style
1429 2004-01-19 Benoit Regrain
1430 * src/gdcmFile.cxx : bug fix concerning the close of file
1431 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1432 * Add the update of header entries using the shadow library
1434 2004-01-19 Benoit Regrain
1435 * removal of file gdcmHeader2.cxx
1436 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1437 inheriting from gdcmParser. This split is to prepare the integration
1438 of dicom dir parsing
1439 * bug fix under python
1441 2004-01-16 Jean-Pierre Roux
1442 * REM removal of class gdcmHeaderEntrySet
1443 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1444 * ADD add file gdcmHeader2.cxx
1445 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1447 2004-01-15 Benoit Regrain
1448 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1449 entries created while parsing the header. Thus, they will be destroyed
1450 when the gdcmDictSet will be destroyed
1451 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1454 2004-01-15 Benoit Regrain
1455 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1456 made a fatal error because of the memory release at the end of program.
1457 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1458 some memory and vtk seems to have some problems with that.
1459 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1461 2004-01-14 Benoit Regrain
1462 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1463 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1464 * src/*.[h|cxx] : make changes due to class name changes
1465 * gdcmPython/demo/*.py : bug fix due to method names
1467 2004-01-13 Benoit Regrain
1468 * src/*.[h|cxx] : coding style
1469 * vtk/*.[h|cxx] : coding style
1471 2004-01-13 Benoit Regrain
1472 * gdcmPython/testSuite.py : test the readable flag of file for tests
1473 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1474 It's lied to the stl compilation by MSVC (windows, always windows...)
1475 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1477 2004-01-12 Benoit Regrain
1478 * src/*.h : add comments
1479 * src/gdcmDictSet.h : set the method BuildDictPath in public
1480 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1481 directly setted in the source code
1482 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1485 2004-01-09 Benoit Regrain
1486 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1487 * setup.py : use a reference to gdcmVERSION
1489 2004-01-07 Benoit Regrain
1490 * Modification to compile with the distutils.
1493 2003-12-10 Benoit Regrain
1494 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1495 can use a gdcmHeaderHelper to load datas
1496 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1497 made in the source code
1499 2003-12-10 Benoit Regrain
1500 * Update Windows projects and .cvsignore files
1502 2003-11-12 Jean-Pierre Roux
1503 * ENH gdcmHeader constructor has one more parameter (default value : false)
1504 that allows the user to 'go inside' the SeQuences only
1506 gdcmElValSet:Print takes it into account
1508 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1509 * ENH: Update gdcmPython/CMakeLists
1510 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1511 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1513 2003-11-10 Jean-Pierre Roux
1514 * FIX : gdcmHeader::LoadElements is now based
1515 on the ListTag listElem member,
1516 not longer on the TagElValueHT tagHt member
1517 * ENH : PrintPubElVal shows (temporarily) both results,
1518 with the tagHt member and the listElem member.
1519 (it's easier to 'see' the problems when using Printheader)
1521 * FIX : old private member LgrElem is now splitted into
1522 ReadLength : Length actually found on disk (updated only
1523 if bug fixing is necessary), for internal
1525 UsableLength : Updated by FixFoundLength, to fix a bug
1526 or to allow Parser going on.
1527 Will allow to re-write a kosher header when a SeQuence
1528 with a length (not 0000) is found
1529 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1530 because gdcmElValSet::Add does not update ListElem
1533 2003-11-07 Jean-Pierre Roux
1534 * FIX misstyping in Transfert Syntax name table
1535 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1536 when they have an actual length (not 0000 nor FFFFF)
1537 (Nobody should care of it, but DICOMDIR explorers)
1539 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1540 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1542 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1543 * ENH: vtkGdcmReader now supports LUT !
1544 (vtkgdcmViewer for now is not able to use them though)
1546 2003-11-05 Jean-Pierre Roux
1547 * in testSuite.py : new files names for checking the package
1548 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1549 that returns the pixel area size to the *aware* (vtk) user
1550 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1552 2003-11-05 Benoit Regrain
1553 * in testSuite.py : Modify the rules for checking the paths
1554 : Explicit error messages
1555 * in __init__.py : Related modif
1557 2003-11-03 Jean-Pierre Roux
1558 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1559 to be used by aware (vtk) users that want to manage
1560 LUT (and no to turn the PALETTE image into an RGB pixels one)
1561 * GetPixelType now returns 8U for 24 Bits images
1562 (vtkGdcmReader compliant)
1564 2003-10-31 Jean-Pierre Roux
1565 * Removal of *all* gdcmData images and add them again
1566 in order to loose the 'history' of un-anonymised images
1568 2003-10-31 Jean-Pierre Roux
1569 * RMV : removal of useless jBitsInJsample.h
1570 for both 8 and 12 Bits JPEG Lossy Libraries
1572 2003-10-31 Jean-Pierre Roux
1573 * ENH : Add the functions gdcmFile::GetImageDataRaw
1574 gdcmFile::GetImageDataIntoVectorRaw
1575 that act as GetImageData and GetImageDataIntoVector
1576 except the making of an RGB Plane from Gray Plane + LUT
1577 Intended to aware (vtk) users who know how to manage
1580 GetLUTRGBA return a R,G,B,A LUT if any
1581 lgrTotaleRaw gives the 'Raw' length
1582 GetImageDataRaw returns the gray Plane
1583 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1584 (They stay Grey, just like with other Dicom viewers :-(
1586 2003-10-30 Jean-Pierre Roux
1587 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1589 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1590 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1591 being coherents dicom files.
1593 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1594 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1596 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1597 * ENH: Two steps is necessary to please VC++ compiler...
1598 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1599 * ENH: Add include dir to medcon lib
1600 * FIX: only one function is being exported for now !
1601 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1603 2003-10-29 Jean-Pierre Roux
1604 * adding gdcmHeader::GetLUTRGBA
1605 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1606 --> Mathieu, the modif u're waiting for is not yet committed
1607 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1609 2003-10-27 Jean-Pierre Roux
1610 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1611 00191113.dcm DermaColorLossLess.dcm
1612 MxTwinLossLess.dcm RadBWLossLess.dcm
1613 * ENH: For version prior to vtkImageViewer2 -r 1.19
1614 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1616 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1617 * Removal of ido stuff in CMakeLists.txt
1619 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1620 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1621 * FIX: remove a call to ->Modified ... see comments
1622 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1624 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1625 * FIX: Problem with path for libvtkgdcmPython
1626 * ENH: Try adding a search script for python site-package
1627 * RMV: Remove some file from medcon lib that are not necessary
1628 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1629 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1630 * FIX: More pragma disable fro VC++,
1631 I don't think I break something as it is also disable in VTK/ITK.
1632 But it fasten debug compilation time.
1634 2003-10-23 Jean-Pierre Roux
1635 * gdcm now deals with 16 Bits Run Length Encoded images
1636 (they are compressed as 2 planes images,
1637 one for the high Bytes, the other for low Bytes)
1639 2003-10-22 Jean-Pierre Roux
1640 * Now CheckRead takes into account :
1641 - the bugged 'Leonardo' Siemens images
1642 - the XA images, sent thru the burning VPRO station
1643 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1646 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1647 * FIX: When copying a Makefile.am to CMakeLists.txt
1648 one should remove the '\'
1650 2003-10-22 Jean-Pierre Roux
1651 * in gdcmData adding a bugged 'Leonardo' Siemens image
1652 (wrong lengths in header)
1653 OK with gdcm, KO with the other viewers :-)
1654 * add a GE dlx XA image, thru the VEPRO burning station
1657 2003-10-21 Jean-Pierre Roux
1658 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1659 for a brutal checking of vtkgdcmViewer compliance
1661 2003-10-21 Jean-Pierre Roux
1662 * add the files for 'xmedcon' Jpeg Lossless library
1663 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1665 2003-10-21 Jean-Pierre Roux
1666 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1668 2003-10-21 Jean-Pierre Roux
1669 * garbage Siemens 'Leonardo' images dealt with
1670 (the patch is easy to remove)
1671 * cosmetic changes to avoid warnings
1673 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1674 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1675 no need to press 'r' now.
1677 2003-10-20 Jean-Pierre Roux
1678 * upgrade of checkRead.sh checkWrite.sh according
1679 to new Jpeg Lossless decompressor
1680 * add US.3405.1.dcm, a genuine RGB medical file ...
1681 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1682 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1684 2003-10-15 Jean-Pierre Roux
1685 * general anonymisation in gdcmData
1686 * adding the 'color files' from
1687 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1688 * adding some well knowed bugged-header images
1689 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1690 waiting for their inclusion in Python testsuite
1692 2003-10-15 Jean-Pierre Roux
1693 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1694 no longer seg faults when file is not found
1696 2003-10-14 Jean-Pierre Roux
1697 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1700 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1701 * TODO: *.in file to genereate a UseGDCM later
1703 2003-10-14 Jean-Pierre Roux
1704 * Some supposed-to-be Dicom Images have no preamble.
1705 OpenFile takes it into account
1706 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1707 * Missing elements added in dicomV3.dic
1708 (just to be affraid : have a look at
1709 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1710 and do it again next year ;->
1712 2003-10-13 Jean-Pierre Roux
1713 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1714 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1715 But there are NOT. It's fixed !
1717 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1718 * FIX: "jpeglib.h" was not found on VC++
1719 * FIX: vtkgdcm was not being installed
1721 2003-10-10 Jean-Pierre Roux
1722 * ENH : OpenFile closes the file if it *really* doesn't look like
1723 an ACR-NEMA / DICOM one.
1724 * FIX : testWrite no longer writes an empty file if the source file
1725 is not gdcm Readable
1726 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1729 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1730 * FIX: CMake generate now documentation
1731 * ENH: out of source doc build !
1732 * ENH: Generate both user and dev documentation
1733 * ENH: Should work on windows too
1734 * ENH: Only one doxygen config.in file is needed
1735 * FIX: make install should be ok now on ùnix plateform
1736 * FIX: PATH to dictionary was wrong (missing /)
1737 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1739 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1740 * vtkGdcmReader is now able to read rgb dicom file.
1741 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1742 * added a gdcmViewer to vtk test, use mouse to control
1743 window level & window width
1745 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1746 * CMake-ification of gdcm, we have now two build system
1747 * FIX: on cygwin Wsock32 doesn't exist
1748 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1750 2003-10-06 Emanuel Ollart
1751 * FIX : compilation process wad broken.
1752 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1754 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1755 * change gdcmViewer -> vtkgdcmViewer
1756 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1758 2003-10-06 Jean-Pierre Roux
1759 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1760 ( e.g : well known GE images with a wrong elem length,
1761 : Philips MRI Images with a wrong Huffman table)
1762 * still to be done : allow the reading of bugged LEONARDO Siemens images
1764 2003-10-03 Jean-Pierre Roux
1765 * Odd length strings are padded with '\0' (not with spaces,
1766 to remain compliant with already defined strings,
1767 like Transfert Syntax UID and others)
1769 2003-10-03 Jean-Pierre Roux
1770 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1771 to allow displaying RGB images (not only by affim ;-)
1773 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1774 * vtkGdcmReader is now able to read rgb dicom file.
1775 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1777 2003-10-03 Jean-Pierre Roux
1778 * A few nasty patches to allow the reading of a lot of nasty images
1779 ( e.g : well known GE images with a wrong elem length,
1780 : Philips MRI Images with a wrong Huffman table)
1781 * still to be done : allow the reading of bugged LEONARDO Siemens images
1783 2003-10-03 Jean-Pierre Roux
1784 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1786 2003-10-03 Jean-Pierre Roux
1787 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1788 to allow displaying RGB images (not only by affim ;-)
1790 2003-10-03 Jean-Pierre Roux
1791 * gdcmFile::GetImageDataIntoVector now
1792 - deals with MultiFrames MultiFragments Run Length Encoded files
1793 - deals with YcBcR (YBR_FULL) files
1794 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1795 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1797 (no sample found :-(
1799 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1800 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1801 Two reasons: - clear things
1802 - third parties acces gdcm through header files, so won't
1803 suffer anymore VC++ complains
1805 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1806 * add argv[1] in testvtkGdcmReader.cxx
1809 2003-09-24 Jean-Pierre Roux
1810 * The lines are now eigthy characters long.for
1811 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1813 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1814 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1815 char* to std::string. Thus, the use of strdup becomes useless. (see
1816 previous commis of Malaterre)
1817 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1818 before the last Malaterre's commit.
1820 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1821 * This commit should fix the Debug building under VC++, the problem
1822 was mainly a mixture of debug and release lib being loaded at startup.
1823 * I also remove a depency to a specific C function: strdup. Because I had
1824 to force the link to msvcrtd (whereas strdup is in libc).
1826 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1827 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1828 located in the gdcmCommon.h file. All use of reference of tha has been
1829 changed to now use the variable GDCM_UNFOUND.
1831 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1833 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1834 Dicom dictionary. The test suite can now be run again. Note:
1835 I'm note very happy with the " (RET)" changes. I believe this
1836 RETAINED comment should be dropped when parsing the dictionary.
1837 - PACKAGER corrected
1839 - AUTHORS updated and now in alphabetical order
1840 * Makefile.am now exports gdcm.dsw for Windoze users.
1842 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1843 * cygwin complains about missing std:: in subdir Test/
1845 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1846 * remove some methods that are now in gdcmHeaderHelper
1848 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1849 * vtkGdcmReader set spacing and origin correctly
1851 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1852 * Fix a few delete/delete[] mismatch
1854 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1855 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1856 interpretation to data given by gdcmHeader. For instance there are
1857 heuristics to get informations (look at different places).
1858 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1859 sorting DICOM images based on different strategies.
1860 * modified Makefiles accordingly.
1862 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1863 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1864 when building in debug mode
1865 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1866 src/win32/gdcmdll.dsp
1867 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1869 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1870 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1873 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1874 * src/win32/libgdcmjpeg12.dsp was not dos format
1875 * src/win32/libgdcmjpeg12.dsp :
1876 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1877 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1879 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1880 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1882 * src/gdcmFile.cxx : bug fix in affectation type
1883 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1884 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1885 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1886 symbols... future problem ?
1888 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1889 * src/win32/libgdcmijpeg12.dsp was missing
1890 * modified gdcm.dsw accordingly
1892 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1893 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1895 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1896 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1897 commit of JPR (before his hollidays to facilitate our work).
1898 * setup.py : bug fix in code. Modifications made while the last commit
1899 of JPR. The code hasn't been tested before the commit... it's so
1900 useless to make that (for best programmer that is JPR) !!!
1902 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1903 * tagged the current version as Version0_3 (i.e. version 0.3)
1905 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1906 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1907 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1908 * *.dsp : modifications to use new libgdcmijpeg8 library
1909 * setup.py : bug fix on VTKPATH variable
1910 * PACKAGER : adding all concerning windows
1912 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1913 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1915 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1916 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1917 test suite reported error.
1918 * PACKAGER file added (describes what a packager must do when
1919 packaging a new release).
1920 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1921 * configure.in: upgraded version number to 0.3.0
1922 * fixing build of rpm (through rpm -ta):
1923 - Doc/Makefile.am exports proper doxygen files
1924 - src/jpeg/libijg8/Makefile.am exports the include files.
1926 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1927 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1928 * src/gdcmHeader.h : formatting code
1930 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1931 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1932 We were obtaining error message from vtk. Now, creation of file list
1933 is made in an internal list to prevent this problem.
1934 Bug fix when output is empty.
1935 Bug fix in update of progress value. Previous commit for this was a bad
1937 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1939 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1940 * src/gdcmHeader.h : added method to get the file name
1941 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1942 files. Added method to remove all files on the input
1943 Added FIXME comment concerning the bad parsing of header made by
1944 ExecuteInformation method (in ExecuteData method)
1946 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1947 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1948 when using make instal.
1949 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1950 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1952 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1953 * setup.py : adding include dir of jpeg lib to compile all sources
1954 * */Win32/*.dsp : JPR fix for windows compilation
1956 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1957 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1959 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1960 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1962 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1963 * setup.py is again effective on un*x (takes into account the
1964 addon of the jpeg library)
1965 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1966 * Doc/Doxy* updated (includes above enhancements)
1967 * INSTALL now points to web documentation
1969 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1970 * src/gdcmHeader.h doesn't make unnecessary reference to
1972 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1974 * src/gdcm*.[cxx|h] :
1975 - to allow compilation with gcc 3.x
1976 -- clean up of STL usage (added explicit usage of std::)
1977 -- small fixes on exceptions.
1978 Note: linking not tested !
1979 - clean of doxygen comments to avoid warnings at documentation
1981 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1982 dependent convertion).
1984 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1985 * Clean up of previous JPR garbage commit (not even commented in the
1987 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1988 - moved all jpeg related files from src to src/jpeg/libijg8, with
1989 addition/modification of Makefile.am and configure.in.
1990 - the testSuite is still brain damage (not guilty).
1992 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1993 * WrapVTK.py : modifications to get correctly vtk source files to
1995 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1996 (FileName -> Filename)
1998 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1999 * vtk/vtkGdcmReader.[cxx/h]:
2000 - UpdateProgress method should now be effective
2001 - removed the limitation on having only images loaded (as opposed
2003 - when building a stack of images/volume, a lesser number of
2004 gdcmHeader and gdcmFile instances should be used (hopefully
2005 accelerating things).
2006 - when building a stack of images/volumes, files which are not
2007 loadable (wrong path-filename, wrong permissions on existing file,
2008 or file not parsable by gdcm) are replaced with a black image
2009 in the stack (for the caller to notice the problem).
2011 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2012 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2014 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2015 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2016 between standard library (std) and vtk library (problems are found
2017 under Windows... thanks Windows !)
2019 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2020 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2022 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2024 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2025 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2027 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2028 * When compiling with distutils (see setup.py) the C++ compiler is
2029 called with different flags than the default ones (with automake).
2030 In order to fix all those warning, I compiled gdcm with the command
2031 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2032 and went for warning fixes:
2033 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2034 up from unused variables.
2035 - vtk/vtkGdcmReader.cxx: potential bug fix.
2036 * src/gdcmHeader.h: Doxygen warning cleanup
2038 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2039 * gdcmPython/gdcm.i:
2040 - typemaps correction to take into account the systematic replacement
2041 of "using namespace std" with std:: prefix e.g. std::list,
2042 std::string... (cf changes of 2003-05-21).
2043 - gdcmGlob global variable of type gdcmGlobal (defined in
2044 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2045 exported to Python a as cvar.
2046 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2047 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2048 gdcmDictSet.GetPubDictTagNames() and
2049 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2050 C++ static methods).
2051 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2052 with the above changes.
2054 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2055 * setup.py, manifest.in : bug fix under linux
2057 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2058 * Modification of setup.py to compile vtk part too. Then, we have 2
2059 wrappers which must work with same distutils. For that, we have a
2060 generic distutils in distusiltsWrapping.py ; with :
2061 - build_extWrap class to wrap generically all extensions,
2062 - ExtensionWrap base class for all wrapping extension that contains
2064 - Wrapper interface which wrap sources
2065 + In WrapSwig.py we have extension and wrapper for Swig
2066 + In WrapVTK.py we have extension and wrapper for VTK
2067 * MANIFEST.in : modifications to consider vtk directory and new python
2068 files for compilation
2070 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2071 * Added python wrappers of vtkGdcmReader vtk class (see the
2072 source in vtk/vtkGdcmReader.cxx) :
2073 - vtk/Makefile.am now builds a library
2074 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2075 python library (as opposed to _gdcm.so wich are the python
2076 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2077 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2079 - configure.in has an additional flag --enable-vtk that needs
2080 to be set to enable compilation of vtk related code, that is:
2081 + vtk/vtkGdcmReader.so and
2082 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2083 + gdcmPython/vtkgdcmPython.so (see above)
2084 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2085 be read when compressed or when HighBit + 1 != BitsStored),
2086 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2087 the usage of the python wrapper of vtkGdcmReader vtk class.
2088 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2089 * src/*.[h] all occurences of stl classes are now prefixed with
2090 std::, and all occurences of "using namespace std;" where removed.
2091 This is to avoid pollution of global namespace in included files.
2092 Apparently vtk does not avoid this pitfall: when using both
2093 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2094 collision of various stl members (principally cout...).
2095 * gdcmPython/testSuite.py now cleanly removes temprory generated
2097 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2098 comply with above changes)
2100 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2101 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2102 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2103 vtk data structure (an image Flip was required).
2104 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2105 * cosmetic changes in documentation.
2107 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2108 * src/gdcmHeader.cxx: the constructor no longer exits when an
2109 unexisting file is given as argument.
2110 * The subdirectory Data (containing all the images used for the
2111 test suite) is not part of this repository anymore. A new module
2112 containing those images is now available at
2113 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2114 with the name gdcmData.
2115 All the python scripts (including the package initialisation file
2116 gdcmPython/__init__.py) were adapated to take this change into
2117 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2119 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2120 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2121 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2122 demo of the usage of this class.
2123 Compilation of this vtk part is only done when using the --enable-vtk
2124 at configure (or autogen.sh) stage.
2126 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2127 * More memory link related corrections and documentation fixes.
2129 - maximum info is obtained with a command of the form:
2130 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2131 --show-reachable=yes PrintHeader
2132 - the remaining reachable blocks seem to come from the STL
2133 allocation scheme through the usage of map and list. It looks
2134 like this memory cannot be freed but it is not a memory leak
2135 (in fact further invocation to the STL would recollect the
2136 unused memory allthough it cannot explicitely be freed).
2137 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2138 of displaying an image parsed with gdcm and displayed with VTK.
2139 Note: some images don't seem to work e.g.
2140 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2141 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2142 Allthough this weakens the semantics, it is a ditch attempt to
2143 make gdcm more thread friendly.
2145 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2146 * Memory link hunt (by using valgrind through the command
2147 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2148 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2149 gdcmHeader::_dicom_vr.
2150 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2151 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2153 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2155 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2156 * src/Makefile.am now exports all the necessary include files at
2160 * UpdateGroupLength replaced by new one
2163 * UpdateGroupLength re-written using H-Table
2164 (named UpdateGroupLengthNew untill checks are over)
2166 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2167 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2168 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2170 - gdcmHeader::GetPubElValSet removed.
2171 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2172 UpdateGroupLength, WriteElements, Write.
2173 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2174 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2175 carried the same semantics.
2176 - src/gdcmHeaderIdo.cxx changed accordingly.
2177 - gdcmFile::WriteBase now regroups all the codes from previous
2178 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2179 - enum FileType moved to gdcmCommon.h
2180 * src/gdcmHeader.cxx AddDefault trashed
2181 * gdcmGetXSize added
2182 * getimageDataSize now calls gdcmGetXSize
2183 * Test/*.cxx changed to agree with above changes
2185 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2186 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2187 (to avoid double call by end user).
2188 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2189 by end user, since gdcmHeader::gdcmHeader now handles it.
2191 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2192 * gdcm/Doc many doxygen changes:
2193 - Doxyfile now has two different versions, DoxyfileUsers that generates
2194 the html.users end users oriented documentation and
2195 DoxyfileDeveloppers that generates the html.developper developper
2196 oriented documentation.
2197 - README changed accordingly
2198 - requirement.txt removed (old design info moved to TODO).
2199 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2200 DoxyMainPage.txt, DoxyPython.txt provide more information.
2201 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2202 be updated by simply regenerating the docs with doxygen and copying
2203 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2204 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2205 all the tests in the form "if (<map>.count() >1)" were removed.
2206 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2207 ill-formed documentation sections.
2208 * src/gdcmHeader.cxx: ditto
2210 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2211 * setup.py fixed for un*x (needed macro for stdint.h)
2212 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2213 un*ces with sh-utils test utility.
2214 * gdcmPython/demo/test.py renamed to PrintHeader.py
2215 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2216 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2217 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2218 * src/gdcm*.cxx JPR's bad inclusion fixed.
2220 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2221 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2222 * gdcmPython/demo/test.py changed accordingly.
2224 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2225 * gdcmPython/Makefile.am fixed linking against libstdc++
2226 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2227 * Swig subdir (historical tests of swig version 1.3.17++) removed
2228 * Test/testChangeEntete.cxx some lines commented out in order to make
2230 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2231 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2233 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2234 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2235 hence the user doesn't need this explicit call.
2236 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2237 i.e. LoadElements() call removed.
2238 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2239 - src/Makefile.am declares the proper flag for g++.
2240 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2241 for adding user defined new tags.
2242 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2243 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2244 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2246 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2247 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2248 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2249 src/Makefile.am : the project should properly compile and install
2250 with the autotools, included the python wrappers part.
2251 * gdcm.spec.in : added a spec file for RPM packaging.
2253 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2254 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2256 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2257 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2258 to exported to the environement (see gdcmPython/testSuite.py
2260 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2261 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2262 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2263 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2264 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2266 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2267 * gdcmPython/__init__.py doesn't crash anymore when running in
2268 in InstallMode or PreInstallMode but with an environement given
2269 value of GDCM_DICT_PATH.
2270 * src/gdcmDictSet.[cxx/h] coding style.
2272 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2273 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2274 * src/gdcm.h general comments moved to TODO, and README
2275 * src/gdcm.h should now be seen as a user commodity (including it
2276 should suffice to fully use gdcm). It is nowhere including within
2277 any of the kernel files src/*.cxx and src/*.h.
2279 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2280 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2281 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2283 * src/gdcm*.cxx only include their corresponding include file
2284 (as opposed to gdcm.h)
2285 * gdcmPython/gdcm.i changed accordingly
2286 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2287 the autogen.sh generated "make snapshot" command to work.
2288 * autogen.sh removed history related references to crea package.
2290 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2291 * distutilsSwigCPlusPlus.py work around some swig portability
2294 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2295 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2296 was done in a last ditch attempt to get setup.py _really_
2297 operationnal. The python/gdcmPython layaout add the advantage
2298 of hidding away the python related distutils specific files
2299 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2300 Alas, the src directory was out of scope (i.e. it's relative
2301 position to setup.py was ../src) which made things impossible to
2302 handle (see previous version of python/setup.py). Crossing fingers...
2304 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2305 * python/setup.py now works on Un*x. (harder than I thougth)
2306 * python/distutilsSwigCPlusPlus.py can now have include files
2307 among the list of sources.
2309 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2310 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2311 * modifications in MSVC projects
2313 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2314 * As stated by the first lines of Test/ExceptionAndPython/README, it
2315 looks like we can move back to original usage of exception within
2316 src/gdcm* and hence remove the errno stuff that was introduced
2317 as a quick and dirty fixture of this problem (added to the TODO).
2318 * Doc/Doxyfile configuration file for Doxygen and corresponding
2319 README file for usage added.
2320 * Test/testWrite.cxx added. This new test comes from a split of
2321 test.cxx that is now reverted to its original purpous i.e.
2322 testing the proper parsing of a Dicom related file.
2323 testWrite.cxx concentrates on testing the IO part of gdcm.
2324 * Test/bug1.cxx (containing a bug on WIn32) added.
2325 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2326 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2327 whose purpose is to publish the content of the TagNames of the
2328 Dicom public dictionnary were not accessible without an
2329 instance of class gdcmHeader.
2330 - those methods are now static methods of gdcmDictSet and hence
2331 require no instances at all to be invocated.
2332 - within gdcmDictSet this change required to change some method
2333 to class methods (i.e. are now static) among which SetDictPath
2334 (renamed to BuildDictPath) and LoadDefaultPubDict.
2335 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2336 the above changes by calling the new method classes of gdcmDictSet.
2337 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2338 the above to be effective.
2339 * python/gdcmPython: in order to wrap properly the above changes
2340 for Python, swig version now needs to be > 1.3.17.
2341 * python/gdcmPython/Makefile fixed to adapt itself to new
2342 configure/make shema introduced by Johan Montagnat (thanks for the
2343 contribution). Alas this Makefile cannot be turned into a proper
2344 Makefile.am without some heavy changes in the configure.in
2345 (for python dectection).
2346 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2347 now avoids publishing the empty entries.
2349 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2350 * python/setup.py : bug fix concerning install under windows
2351 ExtraPath reused :-P
2352 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2354 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2355 * Dicts/dicomV3.dic : remove double spaces !!!
2356 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2357 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2360 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2361 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2362 method. Doxygenation.
2363 * src/gdcm.h clean up of JPR spurious comments.
2365 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2366 * python/distutilsSwigCPlusPlus.py now properly collects the
2367 shadow classes generated by "swig -c++" (gdcm.py in our case)
2368 when using "python setup.py install".
2369 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2370 reexports the working classes.
2371 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2372 by the classical C errno scheme. This is to prevent an obscure
2373 behavior of the python wrappers when importing wxPython.wx prior
2374 to gdcmPython (which ended up in an abort call). An illustration
2375 of this oddity can be found in the Test/ExceptionAndPython
2376 subdir (see the README file). This problem probably due to
2377 an combination of g++ and dynamic loading.
2378 * added Test/ExceptionAndPython (see above)
2380 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2381 * Changed the layout of the python part to avoid bloating main
2382 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2383 i.e. the distutils arsenal. All the python related stuff is
2384 again in a python subdir, but the package itself is now in
2386 * setup.py was cleaned up:
2387 - pythonIncludePath removed
2388 - python setup.py bdist target is now functional.
2389 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2390 collision with other packages). gdcmPython/demo/*.py changed
2393 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2394 * python subdir moved to gdcmPython (preparation of distutils packaging).
2395 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2396 distutils installer is operational.
2397 * - gdcmPython/__init__.py now properly loads the swig generated
2398 shadow classes (from gdcm.py).
2399 - gdcmPython/demo/*.py changed to import the package gdcmPython
2400 instead of gdcmPython/demo/load.py.
2401 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2403 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2404 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2405 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2406 entries within the associated public Dicom dictionary resp. the same
2407 information but sorted by the fourth field (PAT, IMG, DIR) of the
2409 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2410 are now in the "???" group.
2411 - python/gdcm.i changed accordingly,
2412 - python/demo/printGroupedPublicDict.py added, that gives an example
2413 of the above new functionalities in Python.
2415 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2416 * src/gdcm.h, gdcmHeader.cxx:
2417 - historic references to glib's g_malloc and g_free (#defined)
2418 were definitively removed.
2419 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2420 * src/gdcmElValSet.cxx:
2421 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2422 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2423 - GetElValue(string) renamed to GetElValueByName.
2424 - Added GetElementByName(string).
2425 * src/gdcmHeader.cxx: added
2426 - GetPubElValRepByNumber(guint16, guint16)
2427 - GetPubElValRepByName(string)
2428 - GetShaElValRepByNumber(guint16, guint16)
2429 - GetShaElValRepByName(string)
2430 - GetShaElValByNumber(guint16, guint16)
2431 - GetShaElValRepByName(string)
2432 - GetElValRepByNumber(guint16, guint16)
2433 - GetElValRepByName(string)
2434 - GetElValByNumber(guint16, guint16)
2435 - GetElValRepByName(string)
2436 * Doc/requirements.txt added.
2438 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2439 * Test/Makefile building now depends on the one of libgdcm.so
2440 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2441 pixel data) aware which enables finding the address (offset) of
2442 the pixel data of JPEG encoded DICOM files. This leaves only a single
2443 file in the testSuite whose pixel data address (offset) is unknown.
2444 * python/testSuite.py changed accordingly.
2446 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2447 * VC++ has some strong limitations when working with the STL, as stated
2448 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2449 "Also note that some STL containers (map, set, queue, list, deque)
2450 cannot be exported. [...]
2451 Some STL classes contain nested classes. These classes can not
2453 This is caused by a designed limitation that once a template
2454 class is instantiated, it can not be re-instantiated and
2456 Since our usage of map<> is ubiquitous in gdcm, this "designed
2457 limitation" of VC++ is a pitfall.
2458 Hence the Python wrappers of gdcm cannot be incrementally linked
2459 against the c++ dynamic library. The dirty but only workaround is
2460 to forget about incremental link of dynamic libraries and to generate
2461 the Python wrappers library with the inclusions of the underlying C++
2463 The following modifications concern this matter on Win32/VC++:
2464 - wrapping python correct with standalone wrapped dll (don't use separate
2465 dll under windows !!!!)
2466 - python21_d debug mode enabled (ask Frog how to use it :-)
2467 - NO problem with having an STL member of class for example string in C++
2468 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2469 - Python test of dcmlib in Python is ok under windows on a large set
2471 * removed glib references
2472 * typedef's inserted in gdcm.i for correct swig type management
2474 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2475 * python/demo/*.py load.py extracted from test.py. Added explore.py
2476 that only displays required tags and testAll.py that parses all
2477 the files of the testsuite without using unittest.
2478 * python/testSuite.py other additional test on new files added.
2479 * Data/* new test files added accordingly to the testSuite.
2480 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2481 the vr in the file differs from the one of the dictionary.
2483 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2484 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2485 values, but limits itself to values which are below a user specified
2486 size (by default 1024 bytes).
2487 * python/gdcm.i : elements not loaded (because their size is above the
2488 user specified treshold) are exported with their TagKey as key of the
2489 python dictionary. This enables the testsuite to make some checks
2490 on the unloaded elements (since we have their offset and size).
2491 * python/testSuite.py
2492 - now tests for the existence and proper value of the pixel data
2493 - two new examples added.
2494 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2496 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2497 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2498 aware. See the strategy comments in gdcmHeader::FindeLength().
2499 * Test/test.cxx now accepts a filename as first argument.
2500 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2501 * python/testSuite.py changed to integrate test on above files.
2503 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2505 the vr was also RET.
2506 * python/testSuite.py more tests added.
2508 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2509 * python/testSuite.py unittest test suite added (uses Data)
2510 * Data/* dcm and acr files for the test suite.
2511 * glib dependance removed from un*x version. We now use ISO C99
2512 7.18 Integer types (see stdint.h)
2513 - python/Makefile, src/Makefile src/gdcm.h
2514 * src/ when an explicit vr (like dicom files) suddenly poped an
2515 implicit element we use to mark the underlying DictEntry of the
2516 concerned ElValue with "Implicit". This strategy was damageable
2517 too the public or provite dictionaries, since some of their vr
2518 would be changed. Since Header::FindLength heavily relies on the
2519 detection by Header::FindVR of falsely explicit elements, I
2520 added an extra ImplicitVr member to ElValue (boolean).
2521 The rest of the changes we the necessary adaptations.
2523 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2524 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2526 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2528 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2529 * Adaptation for porting to VC++:
2531 o forced to use std namespace (for string to be known)
2532 o all class use __declspec export style on WIN32
2533 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2534 (in stdlib.h on Win32 but in std:: for gcc)
2535 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2536 variable GDCM_DICT_PATH.
2537 * src/gdcmHeader.cxx verbose comments made discrete.
2539 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2540 * python/gdcm.i: added a typemap that converts a C++ hashing table
2541 to native Python dictionary.
2542 * python/demo/test.py:
2543 - now uses the native dictionary for exploration of gdcmHeader.
2544 - takes an optional filename argument (the file to parse).
2545 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2546 PubElVals hashing table.
2547 * Dicts/dicomV3.dic removed error prone trailing spaces.
2549 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2550 * Python wrapping process moved away from src/Makefile to
2551 newly created python/Makefile (as well as gdcm.i)
2552 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2553 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2554 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2555 from the environement variable GDCM_DICT_PATH (when existing).
2556 * src/gdcmDict::GetTag bug fix.
2558 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2559 * Straightforward temporary fixes for swig to build the python wrappers.
2560 src/Makefile now has a python working entry [by working we mean
2561 that we can import de shadow classes without errors].
2563 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2564 * hashtest.cxx removed (since allready in Test)
2565 * src/gdcmlib.h renamed to src/gdcm.h
2566 * src/dcm.i renamed to src/gdcm.i
2567 * src/Makefile prepared for python wrapping
2569 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2570 * src/gdcmHeader.cxx :
2571 - Parsing of header is now separated from loading of element values
2572 (see gdcmHeader::LoadElements).
2573 - general clean up of hopefully all file access (creation of
2574 ReadInt16 and ReadInt32)
2576 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2577 * src/gdcmHeader.cxx :
2578 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2580 - SetLgrElem renamed to SetLength
2581 - GetLgrElem renamed to GetLength
2582 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2583 * src/gdcmElValSet.cxx fixed both GetElValue methods
2584 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2585 due to IdoDude was cleaned out.
2587 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2588 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2589 concentrates on finding the value representation (when it exists).
2590 RecupLgr now only finds the element value length, and it avoids
2591 returning the unecessary skL (skipped length).
2592 Also, offsetCourant was simply removed (with taille_fich) since
2593 it was redundant with the File position internals (by using
2594 ftell and fseek). This also made skL (see above in RecupLgr) usage
2596 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2597 on the libido specificities which are handled through class
2599 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2602 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2603 * Truckload of changes. Parsing of header is barely functional
2604 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2606 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2607 * src/gdcmHeader.cxx many addons of low level methods
2609 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2610 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2611 and _IdDcmSWAP_LONG.
2613 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2614 * This corresponds to all the changes decided at the meeting of
2615 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob