1 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Change internals for gdcmDict. Don't use any 'new' any more.
3 This should definitely solve any leak problem, and we should be
4 as fast as before, as long as don't modify too much the dictionary.
6 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
7 * STYLE: ivars should start with a capital letter.
8 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
9 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
11 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
12 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
13 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
14 new 2004 dictionaries added (thanks to JPR).
15 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
16 * CLEANUP_ROUND (15) for gdcmPixelConvert
17 - RLEFrame::NumberFragments is now of type unsigned int
18 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
19 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
22 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
23 * Initial work in gathering all transfer syntax accessors. clearly
24 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
25 ivars, but only one transfersyntax (class) ivar with equivalent method on
28 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
29 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
30 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
31 discussed (plus I didn't like having a 2000 lines patch not commited)
33 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
34 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
35 * CLEANUP_ROUND (14) for gdcmPixelConvert
36 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
37 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
38 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
40 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
41 anymore and hence avoids storing a copy of PixelConvert::Decompressed
42 into File::Pixel_Data.
44 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
45 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
46 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
47 * CLEANUP_ROUND (13) for gdcmPixelConvert
48 Substituted File::ParsePixelData() with PixelConvert::Print() new
50 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
51 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
52 method to those classes.
53 - src/gdcmFile.[cxx|h]:
54 -- Added a ::Print() method.
55 -- PixelConverter is now a reference instead of a member.
56 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
57 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
59 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
60 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
61 collaboration diagram and inheritance diagram should be generated with
63 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
64 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
65 pointlessly wrapped (see
66 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
67 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
68 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
69 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
70 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
71 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
72 -- File::Initialise: PixelConverter setup moved away to
73 PixelConverter::GrabInformationsFromHeader()
74 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
75 interpretation moved away to PixelConverter::BuildRGBImage()
77 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
78 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
79 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
81 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
82 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
83 displayed on Win32 when a brutal abort() occurs (because of uncatched
84 exception). See TODO new entry of this commit for more on this.
85 * TODO added new entry.
86 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
87 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
88 - HandleColor is no longer called from gdcmFile.cxx
89 - gdcmPixelConvert.cxx clean up on method arguments and internal
90 variable names for semantical coherence.
92 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
93 * Finished lossless transition, not only do we now read all lossless jpeg
94 images, without the need of the Cornwell lib, but we do read them properly now
95 * To reduce code (well to avoid code duplication), I defined a common place
96 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
97 redefine symbols. This is not prefect but this the best solution I found for a
98 compilation time jpeg option.
100 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
101 * Update jpeg ijg lib to support lossless jpeg implementation
102 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
104 * Also added a special copyright for dcmtk since we use their bugfixes.
107 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
108 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
109 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
110 matters, as stated in warning note at begining of %include section).
111 * src/gdcmDicomDir*.[cxx|h]: coding style
112 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
113 * src/gdcmJpeg8.cxx: doxygen fix.
114 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
115 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
116 from File:: to PixelConvert::.
118 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
119 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
120 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
121 - more code moved away from File:: to PixelConvert::
122 - fat setup of PixelConverter set in place in File::Initialise.
124 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
125 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
126 namespace at the file system level. So now you should convert your examples
128 gdcmHeader -> gdcm::Header
129 It would be nice if people keep in mind to no open the namespace, since it
130 allows compilation on broken plateform which were defining common symbol in
131 the standart namespace (like LP, Unknown ...)
133 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
134 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
135 The JPEG fragments are now parsed at the same stage than the RLE
136 information. All code related to JPEG is now in gdcmPixelConvert:
137 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
138 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
139 export a gdcmFile:: method. Those are simply global functions
140 (for the time being this is better than having them attach to
141 either gdcmFile:: or gdcmPixelConvert::).
142 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
143 and stores the result in a gdcmJPEGFragmentsInfo.
144 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
145 code (among other stuff) moved away from gdcmFile:; to
148 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
149 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
150 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
151 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
152 clean up of RLE related code.
153 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
154 - src/gdcmRLE.cxx removed
155 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
156 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
157 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
158 * CLEANUP_ROUND (9) for gdcmPixelConvert
159 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
160 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
161 away from gdcmFile:: to gdcmPixelConvert::.
163 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
164 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
165 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
166 This is because Parse7Fe0 used to parse the pixels to compute the
167 length. This task was passed over to FindDocEntryLengthOB() a long
168 time ago, EXCEPT I had forgotten the OW case...
169 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
170 we just recylce the code for parsing RLE fragments and computing
172 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
173 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
174 with the retired Parse7Fe0().
175 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
176 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
178 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
179 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
180 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
181 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
182 - src/CMakeLists.txt: alphabetic order reodering + new entries.
183 * CLEANUP_ROUND (4) for gdcmPixelConvert
184 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
185 to return an unused length.
187 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
188 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
189 this should be cleanner from the plane view. The iostream are erally a pain
190 to use to do simple stuff.
192 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
193 * Redo the compilation of the ijg jpeg library. Now only one source is
194 necesseray. No need to rename file by hand what so ever. CMake handle the
195 copying of the file within different directory, configure header file to
196 modify some symbol. The only addition made to ijg wasd a mangle table so
197 that symbol are different wether we are within 8bits or 12bits.
199 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
200 * Added documentation of vtkgdcmReader on Website:
201 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
202 with it's binary name).
203 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
204 the Website to be more complete.
205 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
206 doxygenated documentation.
207 - Doc/DoxyVtkGdcmReaderExamples.txt added
208 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
209 DoxyVtkGdmReaderExamples.html )
210 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
211 * CLEANUP_ROUND (3) for gdcmPixelConvert
212 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
214 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
215 * CLEANUP_ROUND (2) for gdcmPixelConvert
216 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
218 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
219 * CLEANUP_ROUND for gdcmPixelConvert:
220 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
221 - src/gdcmPixelStuff[h|cxx] removed
222 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
223 - src/CMakeLists.txt changed accordingly
225 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
226 gdcmVersion.py moved to newly created ATTIC related
227 gdcmPython/SetupOldies/ directory.
228 * Autotools clean up:
229 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
230 - autogen.sh configure.in acinclude.m4 python.m4 removed
232 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
233 * src/*.cxx *.h Reference to License.htm fixed to License.html.
234 * Doc/CMakeLists.txt, doxygen.config.in: fix.
235 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
237 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
238 * TODO updated with Mathieu suggestions. I proposed a template for
239 describing TODO entries and used it for new entries.
240 * Added Doc/Website/CodingStyle.html, Developpers.html,
241 DeveloppersPython.html, GdcmDataCvs.html and
242 DownloadVersion0_1.html, DownloadVersion0_3.html.
243 * Some Doc/*.txt Doxygen files (which do not really concern the
244 documentation itself, but the website) moved to html and
245 placed in directory Doc/Website:
246 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
247 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
248 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
249 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
250 * CMakeLists.txt changed accordingly.
251 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
252 DeveloppersPython.html
253 * INSTALL nows refers to Doc/Website/Installation.html
255 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
256 * Added Doc/Website directory, that contains a first raw version
259 2004-09-23 Jean-Pierre Roux
260 * FIX In order not to be poluted any longer by casting problems,
261 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
262 we can now delete[] it safely
263 * VoidArea is now called BinArea (less confusing name),
264 and all the methods called ...VoidArea... are now ... BinArea...
265 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
267 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
268 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
269 clear) TagHT, which is an inherited member of gdcmElementSet. It is
270 up to the destructor of gdcmElementSet to clean up TagHt and it's
273 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
274 * Test/CMakeLists.txt: update to follow gdcmData renamings.
275 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
277 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
278 * ENH: added some utility method that builds a flat dictionnary
279 holding all the Dicom entries contained in the recursive structure
280 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
282 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
283 BuildFlatHashTable() that build a flat dictionary.
284 - src/gdcmElementSet.h: added a new private GetTag() accessor.
285 gdcmDocument is now a friend of gdcmElementSet.
286 - src/gdcmElementSet.cxx: clean up.
287 - Example/FlatHashTablePrint.cxx added.
288 - Example/CmakeLists.txt changed accordingly
290 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
291 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
292 moved away from gdcmDocEntrySet (since this class is an abstract class
293 acting like an interface). SQDepthLevel and BaseTagKey are now
295 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
296 and associated accessors. Doxygenation of the class.
297 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
299 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
300 Use SQDepthLevel accessor instead. ::Print() adapted.
301 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
302 - src/gdcmDocument.cxx changed accordingly.
304 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
305 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
306 - The following is the doxygen comment of the typedef declaration
307 of gdcmagKey in src/gdcmCommon.h:
308 gdcmTagKey is made to old an "universal" (as in URL, Universal
309 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
310 A dicom tag allways has a group and an element, but a set of tags
311 embeded in various (optionally nested) sequences and sharing
312 the same group and element all share the same (group, element)
313 "identifier". Hence the (group, element) cannot be used as an
314 identifier (in gdcm we shall refer to a "TagKey") of a tag.
315 In order to construct a proper tag identifier (i.e. a key) we
316 consider the following definition of a TagKey:
317 - let Group, Element be the string representation of the
318 group and element dicom tag members,
319 - let ItemNumber be the string representation of the integer
320 index of the considered item number of a sequence,
321 Let the key of a tag embeded in a sequence, noted SeqTag, be
323 /ItemNumber#Group|Element
324 where "/", "#" and "|" are characters acting as separators.
325 Then the general form of a gdcmTagKey is given by:
326 Group|Element<SeqTag>
327 where <SeqTag> means NO or many instances of SeqTag.
328 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
331 but the gdcmTagKey of a tag "embeded" is the first item of
332 a sequence, itself nested in the third item of a sequence is the
334 0004|1220/2#0008|0082/0#0008|0090
335 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
336 order to hold the new sequence compatible key. Previously, the
337 GetKey() method would look in the underlying gdcmDictEntry.
338 - src/gdcmDocEntry.cxx:
339 -- constructor now copies the underlying DictEntry key, in the local
341 -- ::Print: displays the member Key, instead of the (group, element).
342 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
343 - src/gdcmDocEntrySet.h:xi
344 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
345 -- now has a new BaseTagKey member.
347 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
348 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
350 This poses the problem with the semantics of the following lines
351 LoadEntryVoidArea(0x0028,0x1201); // R LUT
352 LoadEntryVoidArea(0x0028,0x1202); // G LUT
353 LoadEntryVoidArea(0x0028,0x1203); // B LUT
354 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
355 to the long FIXME note for what the problem is. Nevertheless in
356 order to get things working the dicom dictionary was altered !
357 Please fix things urgently...
358 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
359 information), see above note on moving the member VoidArea. Nevertheless
360 the following entries previously correctly set as US are now inproperly
362 0028 1201 OW IMG Red Palette Color Lookup Table Data
363 0028 1202 OW IMG Green Palette Color Lookup Table Data
364 0028 1203 OW IMG Blue Palette Color Lookup Table Data
365 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
366 of gdcmDocEntry moved to gdcmSeqEntry.
367 * src/gdcmSeqEntry.cxx: STYLE.
369 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
370 * Test/TestAllEntryVerify.cxx minor fix and added comments.
372 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
373 * gdcmPython/testSuite.py: all the test suite in python is now moved
374 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
375 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
376 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
378 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
379 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
380 to avoid inclusion recursion until STL is reached.
381 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
382 mecanism. errno.h is not included in gdcm anymore.
383 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
384 (gdcmFormatError now inherits from gdcmFormatUnexpected).
386 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
387 gdcmData/TestAllEntryVerifyReference.txt
388 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
389 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
390 exception_on_error parameter.
391 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
392 - vtk/vtkGdcmReader.cxx changed accordingly,
393 - Example/*.cxx and Test/*.cxx changed accordingly.
395 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
396 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
397 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
398 enable_sequences removed from gdcmHeader constructor and dependencies.
399 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
400 * gdcmPython/demo/PrintHeader.py: dummy fix.
401 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
402 skip_shadow removed from gdcmHeader constructor and dependencies.
403 * Example/*.cxx and Test/*.cxx changed accordingly.
405 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
406 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
407 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
409 2004-07-21 Jean-Pierre Roux
410 * FIX Now, Parsing and Printing a DICOMDIR do work!
411 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
413 2004-07-20 Jean-Pierre Roux
414 * FIX Some brain damaged headers have Zero-Lenght fields
415 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
417 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
418 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
419 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
420 variable (instance of gdcmDebug) by a definition macro, and the instance
421 is now in static in the gdcmDebug class
422 * src/gdcmSQItem.h : (FIXME) remove an undefined method
423 * Test/PrintAllDocument.cxx : bug fix in the result of the test
425 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
426 * WARNING: ctest now depends more tightly on gdcmData. You should
427 check out gdcmData properly for things to run smoothly...
428 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
429 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
430 we need the pixels not be loaded in order to use the ValEntry
431 that displays position and size).
432 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
433 This is a C++ based equivalent of gdcmPython/testSuite.py that should
434 be deprecated. If you have any doubts about the advantages of a
435 modern scripting language (read Python) versus grass root C++ (i.e.
436 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
437 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
438 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
439 Anyhow, consider documenting the gdcmData images in
440 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
442 * Test/CMakeLists.txt:
443 - now uses TestAllEntryVerify.cxx
444 - specific comments on oldACR00001.ima (now renamed in gdcmData
445 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
446 gdcmData/TestAllEntryVerifyReference.txt
449 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
450 * src/*.[h|cxx] : typedef clean up
451 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
452 - TagKey renamed to gdcmTagKey (for external usage)
453 - VRKey renamed to gdcmVRKey (for external usage)
454 - removal of typedef duplication.
455 - Removed all unecessary inline keyword from class inline definitions.
456 - Some method|function(void) declarations replaced with method|function().
457 * src/jpeg/libijg12/jdhuff12.c:
458 - printf polluting ctest removed.
459 - TAB removal for comminting
461 - TestAllReadCompareDicom.cxx: added a test that compares all the
462 images in gdcmDataImages.h with corresponding images in
463 gdcmData/BaselineDicom/. When baseline images are not present
464 this test creates them.
465 Note: we need to validate each reference image, but before that
466 I'd like to rename them with a more explicit name...
467 - CMakeLists.txt: changed accordingly.
468 * Example/*.cxx: examples now only include gdcm.h (as opposed to
469 including each header needed).
471 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
472 * Test/*.cxx and Example/*.cxx: moved some examples away from the
473 test suite to the Example directory. Are concerned:
478 - TestWriteSimple.cxx
479 * Test/CMakeLists.txt: added some comments on reasons for black listing
480 image gdcmData/oldACR00001.ima
482 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
483 * Test/CmakeList.txt: removed the following from black list (to be coherent
484 with removal from gdcmData):
485 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
486 - gdcm-MR-PHILIPS-16.dcm
488 Added the following because after last cvs update, they cause
489 ctest -R TestReadWriteReadCompare
491 - gdcm-MR-SIEMENS-16-1.acr
493 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
494 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
495 new comments in this file) we temporarily (sigh) move to a weaker
497 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
498 we don't need to black list the following images anymore:
499 - 8BitsUncompressedColor.dcm
501 - US-PAL-8-10x-echo.dcm
502 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
503 fixes and the beautified code ;-)
504 This fixes the bug introduced in version 1.42 (when beautifying)
505 that made the parsing of 8BitsRunLengthColor.dcm unproper.
506 Note: ctest was blind to this bug (this means we need to still
507 improve the test suite). The bug could be detected by using
508 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
510 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
511 and by displaying the (garbage) produced file temp.XDCM...
513 2004-06-29 Jean-Pierre Roux
514 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
515 - replace by uggly but working old code :-(
516 A lot of things should be OK again.
517 It's really urgent to have a test suite that *tests*,
518 to prevent Frog's beautifying sessions to break all the stuff
519 (twice, withing a fortnigh ...)
521 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
522 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
523 redundancy) to added Test/TestReadWriteReadCompare.cxx
524 * Test/CmakeList.txt: because the compare test of
525 Test/TestReadWriteReadCompare.cxx fails, the following images are
526 black listed: - 8BitsUncompressedColor.dcm
528 - US-PAL-8-10x-echo.dcm
529 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
530 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
531 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
532 and ad-hoc kludge. This kludge is now removed, and on encountering
533 such an image (OB field brain damaged) we set errno. Then in
534 ::FindDocLength() we "fix" the length as being ALL what remains
535 in the file (until EOF). We then proceed, hoping for the best...
536 This fixes a SegFault in ShowDicom when trying to write such an
538 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
539 (because TestWriteRead breaks on it, after a non conformal commit?).
540 ctest now runs properly, except for MakeDicomDir (which was allways
541 broken) and the Python related stuff (still not fixed).
543 2004-06-24 Jean-Pierre Roux
544 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
545 FIX : Test/TestReadWrite now iterates on all the file names
546 (instead of infinite loop)
547 ENH : Test/TestWriteRead now iterates on all the file names
549 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
550 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
552 2004-06-24 Jean-Pierre Roux
553 FIX : - now Write drops LUT Descriptors and LUTs (if any)
554 when SamplesPerPixel =3
555 - now Write is no longer confused by
556 'BitsAllocated = 12" and 'BitsStored=12"
557 - "UN" value representation Elements are now written correctly
558 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
559 ENH : - now gdcmHeader has its own Write methods
560 (in order to split the job that has not to be done
563 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
564 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
565 loop on the same image until memory went out.
566 Note: this means we still have gobs of memory loss in PrintDocument
567 * src/gdcmDocument.cxx: fixes problem on parsing on file
568 gdcmData/16BitsJpegLosslessGrayScale.dcm.
570 2004-06-24 Jean-Pierre Roux
571 FIX : Write - All the Sequences and Sequence Item are now written
572 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
573 is added a the end, when necessary.
574 - A lot of brain-damaged images, that were read correctly are
575 now written correctly
576 - length compatible BinEntry are now loaded correctly
577 (even for odd groups)
578 Note : only Explicit Value Representation was checked.
579 (question : is implicit VR really necessary for gdcm ?)
581 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
582 * DEVELOPPER: added a proposition of coding style.
583 * src/gdcmDocEntry.h: removed every inline declaration (for test of
586 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
587 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
588 Use the gdcmDocEntry::Print() and Write() instead.
589 * src/gdcmDocument.cxx: bug fix.
591 2004-06-22 Jean-Pierre Roux
592 FIX : gdcmDocument.cxx
593 - Now we do recognize the JpegLossLess format (there was a misstyping in
594 code 'beautyfication' :-(
595 - Now we automaticaticaly load the Luts, if any
597 2004-06-22 Jean-Pierre Roux
598 In order : to write Sequences, whatever their imbrication level,
599 : to allow user to create his own Sequences
600 a lot of modif where necessary (adding, moving, or virtualising methods)
602 WARNING : save your own sources *before* cvs up !
605 ADD virtual void Write(FILE *fp, FileType filetype);
608 ADD virtual void Write(FILE *fp, FileType filetype);
609 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
612 ADD virtual void Write (FILE *fp, FileType filetype)=0;
613 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
614 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
615 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
616 ADD std::string GetEntryByName(TagName name);
617 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
619 std::string vr = "unkn",
620 std::string fourth = "unkn",
621 std::string name = "unkn");
622 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
623 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
624 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
625 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
626 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
627 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
628 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
629 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
632 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
633 ADD virtual std::string GetEntryByName (TagName tagName);
634 ADD virtual std::string GetEntryVRByName (TagName tagName);
635 REM virtual bool Write(FILE *, FileType);
636 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
637 FILE *_fp, FileType type);
638 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
639 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
640 REM virtual bool WriteEntries(FILE *_fp,FileType type);
641 REM virtual std::string GetEntryByName (std::string tagName);
642 REM virtual std::string GetEntryVRByName (std::string tagName);
643 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
644 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
645 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
647 std::string vr = "unkn",
648 std::string fourth = "unkn",
649 std::string name = "unkn");
650 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
651 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
652 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
653 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
656 ADD virtual void Write(FILE *fp, FileType filetype);
659 ADD virtual void Write(FILE *fp,FileType filetype);
662 ADD virtual void Write(FILE *fp, FileType filetype);
663 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
664 REM std::string GetEntryByNumber(guint16 group, guint16 element);
665 REM std::string GetEntryByName(TagName name);
668 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
670 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
671 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
672 The default constructor invoked by the line
673 gdcmHeader *f1 = new gdcmHeader( header );
674 was gdcmHeader::gdcmHeader(bool) instead of the expected
675 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
676 Hence the parsing wasn't executed... See also below.
677 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
678 as explicit constructor didn't do the trick to fix the above problem.
679 Could anyone explain why ?
680 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
681 properly calls gdcmValEntry::Print() (that was weed out from
682 code related to gdcmBinEntry).
684 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
685 * In order to fix memory leaks:
686 - Test/TestWriteSimple.cxx: added cleaning of free store through
688 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
689 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
690 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
691 (through the call to ::AddDicomDirMeta()) or the destructor
692 would crash when deleting uninitialized ::metaElems].
693 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
694 - src/gdcmDocument.cxx:
695 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
697 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
698 was causing memory leaks.
699 - src/gdcmSQItem.cxx:
700 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
701 cleanly handled with polymophism: sorry but my milage is low).
702 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
703 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
704 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
705 This avoids SegFaulting.
706 - src/gdcmSQItem.h: coding style.
708 - Test/TestWriteSimple still severely sucks. The output image content
709 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
710 damaged when displayed with vtkgdcmViewer.
711 - on memory leaks: TestWriteSimple leaks really less (see entry
712 of 2004-06-18 in Changelog file for the call to valgrind).
713 - on segfaults: ctest now passes all the tests but one (no more
715 * Erroneous leading white fix:
716 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
717 white[s] (as opposed to from >> xxx, that removes it [them].
718 - src/gdcmTS.cxx: ditto.
719 - gdcmPython/testSuite.py: dirty related kludge removed.
720 * src/*: remaining references to gdcmParser removed.
721 * src/*[cxx|h]: added copy[way]left header.
724 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
725 * In order to fix writing of dicom files:
726 - Test/TestWriteSimple.cxx: a simpler example of writing.
727 - Test/CMakeLists.txt changed accordingly.
728 - src/gdcmDocument.cxx:
729 -- The destructor now recursilvely removes potential sequences.
730 -- Bug fix in ::IsJPEG2000()
731 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
732 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
734 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
735 to only declared) and build on top of
736 ::GetDocEntryByNumber(guint16, guint16).
737 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
738 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
739 for usage in destructor and treatement of promotion in
740 ::ReplaceOrCreateByNumber().
741 - src/gdcmSQItem.cxx: destructor should better handle his job.
742 Test/TestWriteSimple now runs (or at least it DOES something).
743 * We can now start hutting memory links. A good starting point is:
744 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
745 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
746 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
748 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
749 * Valgrind note: after Mathieu Malaterre teached me how to read
750 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
752 Using gcc, you can force the STL to use malloc and to free memory as
753 soon as possible by globally disabling memory caching.
754 With 3.2.2 and later, you should export the environment variable
755 GLIBCPP_FORCE_NEW before running your program.
756 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
757 simply vanish (it is still not clear to me, whether this means that
758 STL std::string leaks or if valgrind believes it leaks...).
759 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
760 running bin/gdcmTests makeDicomDir):
761 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
762 - Test/makeDicomDir.cxx now properly traps empty lists and returns
764 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
765 SegFaulting (I drowned in DicomDir related code when trying to
766 understand why the list is empty...).
767 * src/gdcmDocument.h: first BSD license header try.
768 * Doc/License.txt added.
770 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
771 * src/gdcmDocument.[h|cxx]:
772 - Clean up of the Transfer related predicates. They are now all based
773 on new method isGivenTransferSyntax, that (should) handle properly
775 - general clean up, simplification, and coding style.
776 - Specific clean up of Parse7FE0() (umproperly named actually).
777 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
779 2004-06-14 Jean-Pierre Roux
781 - fix the display of Sequence Delimitor (SQDepthLevel pb)
782 - fix the display of SQItem ordinal number
783 - add the GetSQItemByOrdinalNumber method
784 - remove some useless never written private methods
786 2004-06-14 Jean-Pierre Roux
788 - adding a constructor taking a gdcmDocEntry as an input param
789 - ReplaceOrCreateByNumber now returns :
790 a gdcmBinEntry * if a Binary (void *) value is passed as a param
791 a gdcmValEntry * if a string value is passed as a param
793 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
794 according to the param type (no longer sets a gdcmDocEntry)
795 - GetValEntryByNumber, GetBinEntryByNumber added
796 - NewValEntryByNumber and NewBinEntryByNumber added
798 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
800 - GetSQItemNumber and SetSQItemNumber added, to provide
801 a (relative) Item identier inside a given Sequence
802 \warning : some pb remaining around this number
804 - AddEntry now takes the Item Number as a param
806 - adding a constructor taking a gdcmDocEntry as an input param
808 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
809 * Memory leak hunt with the following command:
810 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
811 --show-reachable=yes gdcmTests PrintDocument
812 It looks like many (all?) leaks are due to the STL (or a bad usage
813 of the STL. The lines producing the leaks now have a comment with
814 a "MEMORY LEAK" tag: you can retrieve them with
815 grep "MEMORY LEAK" src/*
816 Here are two typical examples which I can't help fixing:
821 char * test = "babo";
822 name = test; //// <--- valgrind detects 960 bytes lost in
823 //// call to std::string::operator=(char const*)
824 name.clear(); //// Doesn't help !
832 std::cout << "Type a bunch of characters followed by RETURN: ";
833 getline(std::cin, line); //// <--- valgrind dectects a loss
834 //// of 1320 bytes in call to
835 /// std::basic_istream<>& std::getline<>
841 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
842 * src/gdcmHeader.[cxx|h]:
843 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
844 and related, moved away to gdcmDocument.
845 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
846 the corresponding protected accessors of inherited class
847 gdcmDocument, removed ! As a consequence gdcmFile had to be
848 declared friend of class gdcmDocument (see below).
849 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
850 - Clean up of undefined or unused methods.
851 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
852 account the changes to gdcmHeader.h).
853 * src/gdcmDocument.h:
854 - gdcmFile is now a friend class (in order to take into account the
855 changes to gdcmHeader.h).
856 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
857 (see changes to gdcmHeader.h).
858 - Accessors (reading on the form GetEntry*) are now public.
859 - Clean up of undefined or unused methods.
860 * src/gdcmDocument.cxx:
861 - adaptation to changes to gdcmDocument.h
862 - ::OpenFile now writes a verbose message when file cannot be opened.
863 - some std::string properly set to VRKey
864 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
865 references to gdcmDocument.
866 * Test/TestFindTags.cxx: changed accordingly to above changes.
867 * gdcmPython/testSuite.py: adapted to renaming of acr files in
868 cvs repository gdcmData.
870 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
871 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
872 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
873 conflicts with gdcmValEntry::voidArea.
874 * src/gdcmValEntry.cxx: unmatching comment wiped out.
875 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
876 Value representation between StringRepresentable and BinaryRepresentable.
877 * src/gdcmDocument.cxx:
878 - method ParseDES: proper indentation restored and usage of
879 gdcmVR::IsVROfGdcmStringRepresentable wired in.
880 - method LoadDocEntry: the fingerprint left in the SetValue() of
881 unloaded entries (length > MaxSizeLoadEntry) had curiously been
882 removed. Reverting to previous code segment with the proper
883 dynamic_cast< gdcmValEntry* >.
884 Note: this was (partially) breaking the python test suite
885 (gdcmPython/testSuite.py) that made usage of the above
886 fingerprint to check presence of "Pixel Data".
887 * src/gdcmDocEntry.h: coding style.
888 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
889 now taken into account.
890 * gdcmPython/gdcm.i: adaptation to the new internal representation
891 of gdcm (exit gdcmParser, hello gdcmDocument).
892 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
894 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
895 anymore, but instead prints the loaded Python dictionary.
896 * .... alas, the python testSuite is still broken.
898 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
899 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
901 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
902 * src/gdcmUtil.h : export methods
904 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
905 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
907 * Initial addition of automatic python testing
908 * Initial addition of automatic image comparison
910 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
911 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
912 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
914 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
915 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
916 * Test/ShowDicom.cxx : bug fix for msvc compilation
917 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
919 2004-05-04 Jean-Pierre Roux
920 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
921 new concepts (and new classes) :
922 a 'gdcmDocument' is composed of a set of Doc Entries, that are
923 - elementary gdcmDocEntries (former gdcmHeaderEntries)
924 - Sequence Doc Entries (gdcmSeqEntries)
925 a Sequence is composed of Items.
926 Each item is a set of Doc Entries (this is recursive)
927 The non uniqueness of the 'Dicom tag' is due to this recursivity
928 (never taken into account)
929 Our unability to add a new 'entry' in the header
930 at the proper location (neither in the H-Table (map or multimap),
931 nor in the Chained List is also due to this recursivity.
932 Don't try, right now, to use/modify/compile these new sources :
934 We just commit all the stuff, 'as is', in order not to loose it.
936 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
937 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
939 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
940 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
941 file prefix (SetFilePrefix)
943 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
944 * Add a new test: ShowDicom, for now this is just the c++ version of
945 checkRead.sh, later it will be able to compare the image read against a
947 * Replace the DEBUG on the stack with a global entry in cmake interface:
948 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
950 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
951 * Add an example subdir, with a real example on how to read + write a
954 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
955 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
956 * Doc/CMakeLists.txt: the main page is now properly differentiated
957 between the developper and user version.
958 * Doc/doxygen.config.in: dropped search related obsolete flags
959 * src/gdcmParser.h, gdcmHeader.h: doxygenation
961 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
962 * DEVELOPPER: added some helpfull comments for compile/test/install
965 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
966 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
967 src directory, now generated in the build dir.
968 2. Tests as mentionned smarter
970 4. Add a new method in gdcmDict that return the PubDict by name
971 this is interesting for 3rd party lib like ITK,
972 where we could set the institution name / patient name...
974 * ENH: 1. Now the test suite is working for real
975 2. All binaries are now output in the gdcm-bin directory
976 (this was not true before)
978 2004-04-28 Jean-Pierre Roux
979 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
980 SeQuence indented printing of Dicom Header.
981 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
982 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
983 Computation of SQDepthLevel is now part of gdcmHeader constructor
984 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
985 tree-like structure of a Dicom Header.
986 * FIX Test code cleaning
988 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
989 * ENH: Adding automatic testing
990 1. Need a DartConfig.cmake to submit to public
991 2. Add a test driver gdcmTest.cxx
992 3. gdcmTestMain, an helper for the main test driver gdcmTest
993 4. Files in Test don't have a main anymore, this becomes interesting
994 when we add more and more tests, thus dsw don't have to load
996 * ENH: Adding a GDCM_DATA_ROOT for testing
997 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
998 one file instead of seven + some small cleanup
1000 2004-04-22 Jean-Pierre Roux
1001 * ENH Minor changes to the Print() methods.
1002 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1003 Header printing. Example given with :
1004 > PrintHeader fileName 2 new
1005 (SQ based tree-like structure still to be done for the Header ...)
1007 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1008 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1009 1. I have added some unsigned where needed
1010 2. Some function parameter not used -> (void)
1011 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1012 4. g++ don't like character '\' in comment
1013 5. #define jpeg_create_decompress jCreaDecompress
1014 this really need to be fixed
1015 6. virtualize destructor of gdcmObject ... leakage
1016 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1017 this also really need to be fixed
1018 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1019 remove compression file
1020 (as we only do decompression, right ?)
1021 * ENH: Change malloc/calloc/free with c++ equivalent
1023 2004-04-21 Jean-Pierre Roux
1024 * FIX gdcmHeaderHelper::GetXSpacing
1025 when a single value is found (bug ?), xpacing is now
1026 defaulted to yspacing
1028 2004-04-19 Jean-Pierre Roux
1029 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1030 * ENH add parameters :
1031 bool exception_on_error = false,
1032 bool enable_sequences = false,
1033 bool ignore_shadow = false
1034 to the gdcmFile constructors to be full gdcmParser compliant
1035 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1036 to allow reading of PAPYRUS 3.0 files
1038 2004-04-06 Jean-Pierre Roux
1039 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1041 2004-04-02 Jean-Pierre Roux
1042 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1043 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1044 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1046 2004-03-30 Jean-Pierre Roux
1047 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1048 for ACR file, written out as DICOM files (hope so...)
1050 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1051 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1052 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1053 moved to base class gdcmParser and only the specialisation is kept
1055 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1056 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1057 already does the job.
1058 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1059 (to be consistent with gdcmParser::WriteEntries).
1061 2004-03-30 Benoit Regrain
1062 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1063 upate of the object's instance. It's passed to 2 in the unfavorable
1064 case : one in the ExecuteInformation, one in the ExecuteData
1066 2004-03-29 Jean-Pierre Roux
1067 * ENH : Check on file type to be written moved
1068 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1069 * FIX : gdcmObject::ResetBoundaries now stops properly
1070 when end-of-list is reached
1071 : gdcmVersion modified (as Benoit Regrain asked)
1073 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1074 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1075 * src/gdcmUtil.cxx: added forgotten iostream include.
1076 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1077 equivalent to ExplicitVR in existing code).
1079 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1080 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1081 now contains all the gdcmGlobal related code.
1082 * minor coding style and doxygenation changes.
1084 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1085 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1086 now contains all the Debug related code.
1087 * minor clean-up of includes in src/*.cxx
1088 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1089 CreateCleanString) removed.
1090 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1091 * Doc/DoxyMainPageUser.txt added.
1092 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1093 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1094 src/gdcmDirList.cxx)
1096 2004-03-24 Jean-Pierre Roux
1097 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1099 2004-03-23 Jean-Pierre Roux
1100 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1101 big endian made volumes
1102 * ENH Now gdcmParser constructor and destructor are protected to forbid
1103 end user to instanciate class gdcmParser
1104 (only gdcmHeader and gdcmDicomDir are meaningfull)
1106 2004-03-22 Benoit Regrain
1107 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1108 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1109 gdcmSerie to gdcmDicomDirSerie
1111 2004-03-19 Jean-Pierre Roux
1112 * ENH Now the tree-like structure describing a DICOMDIR comming from
1113 an already existing DICOMDIR file is consistent with
1114 the home-made tree-like structure build ex-nihilo
1115 or build from the files held (recursively) in a Directory
1116 functions gdcmDicomDir::CheckBoundaries()
1117 gdcmObject::SetBoundaries() added
1119 2004-03-17 Jean-Pierre Roux
1120 * REM (Eric Boix bug) : removal of meaningless
1121 gdcmDicomDirImage::NewImage function.
1122 * FIX now file names and directory name are written properly in the
1124 * FIX now gdcmDicomDir constructor may be call without any trick
1127 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1128 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1129 of gdcmDicomDirImage::NewImage as empty function.
1131 2004-02-28 Jean-Pierre Roux
1132 * ENH add gdcmDicomDir:NewPatient
1133 add gdcmDicomDirPatient:NewStudy
1134 add gdcmDicomDirStudy:NewSerie
1135 add gdcmDicomDirSerie:NewImage
1136 to allow making gdcDicomDir object.
1137 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1138 (as opposite to the gdcmHeader chained list)
1140 2004-02-11 Benoit Regrain
1141 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1142 when using from python
1144 2004-02-10 Benoit Regrain
1145 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1146 * FIX : in gdcmDicomDir when the directory is empty
1147 * ENH : add callback and methods to get the progression of dicomDir
1150 2004-02-06 Jean-Pierre Roux
1151 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1152 - GDCM_META added to gdcmDicomDirType
1153 - class gdcmMeta created
1154 * ENH : - A brief summary is now displayed at the beginning of
1155 'testDicomDir' to help disaster magnitude estimation
1156 * REM : Now useless Test/explDICOMDIR.cxx
1158 2004-02-05 Benoit Regrain
1159 * ENH : add methods in gdcmObject to get the hash table or the list of
1161 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1162 * FIX : wrapping python for TagHeaderEntryHT
1164 2004-02-04 Benoit Regrain
1165 * FIX : even length for some strings when writting the dicom dir
1166 * FIX : sort the images in the dicom dir
1167 * FIX : Bug fix for python use of dicom dir
1168 * ADD : a python demo
1170 2004-02-04 Jean-Pierre Roux
1171 * FIX : Final solution (?) for icone embedded images
1172 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1173 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1174 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1175 gdcmData/gdcm-MR-SIEMENS-16.acr1
1176 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1177 to make full checking easier
1179 2004-02-04 Benoit Regrain
1180 * FIX : WriteEntries : coding style & logic in parameters
1181 * FIX : Set the elements to create the DicomDir in a dictionary file
1183 2004-02-03 Benoit Regrain
1184 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1185 * gdcmDicomDir : add the load of directory
1186 * Bug fix and print add-on
1188 2004-02-03 Jean-Pierre Roux
1189 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1190 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1191 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1192 * FIX gdcmParser.cxx : 'group length' elements are now considered
1193 as integers, even for shadow groups, when file is Implicit VR
1195 2004-02-02 Jean-Pierre Roux
1196 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1198 of the last synonym :-(
1199 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1201 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1202 * FIX taking into account the possible 7fe0,0010 multiplicity
1203 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1204 to allow removal of references to 7fe0,0010, to deal with
1205 ACR-NEMA images, when 0028,0200 is meaningfull
1207 2004-01-31 Jean-Pierre Roux
1208 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1209 no longer writes 'Un' on disk
1210 * FIX SQ elements with actual length are now dealt with corectly
1211 * FIX gdcmFile::WriteBase make the difference, for color images, between
1212 the length (for Palette expanded images)
1213 and Raw Length (non expanded image + Palette)
1214 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1215 (that broke Write). Replaced by UL.
1216 Aware user will reload the field if he
1217 thinks it's necesssary
1219 2004-01-30 Jean-Pierre Roux
1220 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1221 when 'dirty Acr' is found, to be compliant with the new
1222 IsReadable() methods.
1224 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1225 (no DOUBLE images in kosher DICOM,
1226 but so usefull for people that miss them ;-)
1228 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1229 DICOMDIR related utilities (not checked as Windoze compliant)
1231 2004-01-28 Jean-Pierre Roux
1232 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1234 2004-01-27 Jean-Pierre Roux
1235 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1236 to allow skipping the shadow elements, to save memory space.
1237 The TRUE value for this param has to be used
1238 with a FALSE value for the 'enable_sequence' param.
1239 ('public elements' may be embedded in 'shadow Sequences')
1240 * gdcmHeader methods now deal with 'embedded icones images' in the header
1241 (even when an 'icone image sequence' is announced by the
1242 element (0x0088,0x0200), but there is NO icone at all ...
1244 * gdcmHeader sometimes Image Location value doesn't follow
1245 the supposed processor endianity (see gdcmData/cr172241.dcm).
1248 * gdcmHeader add the method
1249 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1250 to get *all* the Header Entries with the same tag.
1251 GetHeaderEntrySameName is probabely *useless*
1252 (no meaning : Name is *not* an identifier within the Dictionnary)
1254 2004-01-26 Benoit Regrain
1255 * Bug fix in the print of hexadecimal representations. Remove long fields
1256 in the print and add a third level of print to print them
1258 2004-01-23 Benoit Regrain
1259 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1260 * Bug fix on test suite after remove the strip made on not string fields
1261 * Split the IsReadable method between gdcmParser which test that the file
1262 is dicom and gdcmHeader which test that it's an image file
1264 2004-01-22 Benoit Regrain
1265 * DicomDir : clean code, add methods, set variables in protected or private
1266 * gdcmUtil : bug fix for the clean string method
1268 2004-01-19 Benoit Regrain
1269 * Add the use of shadow dictionaries
1270 * bug fix and coding style
1272 2004-01-19 Benoit Regrain
1273 * src/gdcmFile.cxx : bug fix concerning the close of file
1274 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1275 * Add the update of header entries using the shadow library
1277 2004-01-19 Benoit Regrain
1278 * removal of file gdcmHeader2.cxx
1279 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1280 inheriting from gdcmParser. This split is to prepare the integration
1281 of dicom dir parsing
1282 * bug fix under python
1284 2004-01-16 Jean-Pierre Roux
1285 * REM removal of class gdcmHeaderEntrySet
1286 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1287 * ADD add file gdcmHeader2.cxx
1288 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1290 2004-01-15 Benoit Regrain
1291 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1292 entries created while parsing the header. Thus, they will be destroyed
1293 when the gdcmDictSet will be destroyed
1294 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1297 2004-01-15 Benoit Regrain
1298 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1299 made a fatal error because of the memory release at the end of program.
1300 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1301 some memory and vtk seems to have some problems with that.
1302 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1304 2004-01-14 Benoit Regrain
1305 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1306 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1307 * src/*.[h|cxx] : make changes due to class name changes
1308 * gdcmPython/demo/*.py : bug fix due to method names
1310 2004-01-13 Benoit Regrain
1311 * src/*.[h|cxx] : coding style
1312 * vtk/*.[h|cxx] : coding style
1314 2004-01-13 Benoit Regrain
1315 * gdcmPython/testSuite.py : test the readable flag of file for tests
1316 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1317 It's lied to the stl compilation by MSVC (windows, always windows...)
1318 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1320 2004-01-12 Benoit Regrain
1321 * src/*.h : add comments
1322 * src/gdcmDictSet.h : set the method BuildDictPath in public
1323 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1324 directly setted in the source code
1325 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1328 2004-01-09 Benoit Regrain
1329 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1330 * setup.py : use a reference to gdcmVERSION
1332 2004-01-07 Benoit Regrain
1333 * Modification to compile with the distutils.
1336 2003-12-10 Benoit Regrain
1337 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1338 can use a gdcmHeaderHelper to load datas
1339 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1340 made in the source code
1342 2003-12-10 Benoit Regrain
1343 * Update Windows projects and .cvsignore files
1345 2003-11-12 Jean-Pierre Roux
1346 * ENH gdcmHeader constructor has one more parameter (default value : false)
1347 that allows the user to 'go inside' the SeQuences only
1349 gdcmElValSet:Print takes it into account
1351 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1352 * ENH: Update gdcmPython/CMakeLists
1353 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1354 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1356 2003-11-10 Jean-Pierre Roux
1357 * FIX : gdcmHeader::LoadElements is now based
1358 on the ListTag listElem member,
1359 not longer on the TagElValueHT tagHt member
1360 * ENH : PrintPubElVal shows (temporarily) both results,
1361 with the tagHt member and the listElem member.
1362 (it's easier to 'see' the problems when using Printheader)
1364 * FIX : old private member LgrElem is now splitted into
1365 ReadLength : Length actually found on disk (updated only
1366 if bug fixing is necessary), for internal
1368 UsableLength : Updated by FixFoundLength, to fix a bug
1369 or to allow Parser going on.
1370 Will allow to re-write a kosher header when a SeQuence
1371 with a length (not 0000) is found
1372 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1373 because gdcmElValSet::Add does not update ListElem
1376 2003-11-07 Jean-Pierre Roux
1377 * FIX misstyping in Transfert Syntax name table
1378 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1379 when they have an actual length (not 0000 nor FFFFF)
1380 (Nobody should care of it, but DICOMDIR explorers)
1382 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1383 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1385 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1386 * ENH: vtkGdcmReader now supports LUT !
1387 (vtkgdcmViewer for now is not able to use them though)
1389 2003-11-05 Jean-Pierre Roux
1390 * in testSuite.py : new files names for checking the package
1391 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1392 that returns the pixel area size to the *aware* (vtk) user
1393 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1395 2003-11-05 Benoit Regrain
1396 * in testSuite.py : Modify the rules for checking the paths
1397 : Explicit error messages
1398 * in __init__.py : Related modif
1400 2003-11-03 Jean-Pierre Roux
1401 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1402 to be used by aware (vtk) users that want to manage
1403 LUT (and no to turn the PALETTE image into an RGB pixels one)
1404 * GetPixelType now returns 8U for 24 Bits images
1405 (vtkGdcmReader compliant)
1407 2003-10-31 Jean-Pierre Roux
1408 * Removal of *all* gdcmData images and add them again
1409 in order to loose the 'history' of un-anonymised images
1411 2003-10-31 Jean-Pierre Roux
1412 * RMV : removal of useless jBitsInJsample.h
1413 for both 8 and 12 Bits JPEG Lossy Libraries
1415 2003-10-31 Jean-Pierre Roux
1416 * ENH : Add the functions gdcmFile::GetImageDataRaw
1417 gdcmFile::GetImageDataIntoVectorRaw
1418 that act as GetImageData and GetImageDataIntoVector
1419 except the making of an RGB Plane from Gray Plane + LUT
1420 Intended to aware (vtk) users who know how to manage
1423 GetLUTRGBA return a R,G,B,A LUT if any
1424 lgrTotaleRaw gives the 'Raw' length
1425 GetImageDataRaw returns the gray Plane
1426 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1427 (They stay Grey, just like with other Dicom viewers :-(
1429 2003-10-30 Jean-Pierre Roux
1430 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1432 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1433 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1434 being coherents dicom files.
1436 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1437 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1439 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1440 * ENH: Two steps is necessary to please VC++ compiler...
1441 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1442 * ENH: Add include dir to medcon lib
1443 * FIX: only one function is being exported for now !
1444 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1446 2003-10-29 Jean-Pierre Roux
1447 * adding gdcmHeader::GetLUTRGBA
1448 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1449 --> Mathieu, the modif u're waiting for is not yet committed
1450 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1452 2003-10-27 Jean-Pierre Roux
1453 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1454 00191113.dcm DermaColorLossLess.dcm
1455 MxTwinLossLess.dcm RadBWLossLess.dcm
1456 * ENH: For version prior to vtkImageViewer2 -r 1.19
1457 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1459 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1460 * Removal of ido stuff in CMakeLists.txt
1462 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1463 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1464 * FIX: remove a call to ->Modified ... see comments
1465 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1467 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1468 * FIX: Problem with path for libvtkgdcmPython
1469 * ENH: Try adding a search script for python site-package
1470 * RMV: Remove some file from medcon lib that are not necessary
1471 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1472 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1473 * FIX: More pragma disable fro VC++,
1474 I don't think I break something as it is also disable in VTK/ITK.
1475 But it fasten debug compilation time.
1477 2003-10-23 Jean-Pierre Roux
1478 * gdcm now deals with 16 Bits Run Length Encoded images
1479 (they are compressed as 2 planes images,
1480 one for the high Bytes, the other for low Bytes)
1482 2003-10-22 Jean-Pierre Roux
1483 * Now CheckRead takes into account :
1484 - the bugged 'Leonardo' Siemens images
1485 - the XA images, sent thru the burning VPRO station
1486 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1489 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1490 * FIX: When copying a Makefile.am to CMakeLists.txt
1491 one should remove the '\'
1493 2003-10-22 Jean-Pierre Roux
1494 * in gdcmData adding a bugged 'Leonardo' Siemens image
1495 (wrong lengths in header)
1496 OK with gdcm, KO with the other viewers :-)
1497 * add a GE dlx XA image, thru the VEPRO burning station
1500 2003-10-21 Jean-Pierre Roux
1501 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1502 for a brutal checking of vtkgdcmViewer compliance
1504 2003-10-21 Jean-Pierre Roux
1505 * add the files for 'xmedcon' Jpeg Lossless library
1506 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1508 2003-10-21 Jean-Pierre Roux
1509 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1511 2003-10-21 Jean-Pierre Roux
1512 * garbage Siemens 'Leonardo' images dealt with
1513 (the patch is easy to remove)
1514 * cosmetic changes to avoid warnings
1516 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1517 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1518 no need to press 'r' now.
1520 2003-10-20 Jean-Pierre Roux
1521 * upgrade of checkRead.sh checkWrite.sh according
1522 to new Jpeg Lossless decompressor
1523 * add US.3405.1.dcm, a genuine RGB medical file ...
1524 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1525 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1527 2003-10-15 Jean-Pierre Roux
1528 * general anonymisation in gdcmData
1529 * adding the 'color files' from
1530 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1531 * adding some well knowed bugged-header images
1532 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1533 waiting for their inclusion in Python testsuite
1535 2003-10-15 Jean-Pierre Roux
1536 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1537 no longer seg faults when file is not found
1539 2003-10-14 Jean-Pierre Roux
1540 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1543 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1544 * TODO: *.in file to genereate a UseGDCM later
1546 2003-10-14 Jean-Pierre Roux
1547 * Some supposed-to-be Dicom Images have no preamble.
1548 OpenFile takes it into account
1549 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1550 * Missing elements added in dicomV3.dic
1551 (just to be affraid : have a look at
1552 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1553 and do it again next year ;->
1555 2003-10-13 Jean-Pierre Roux
1556 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1557 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1558 But there are NOT. It's fixed !
1560 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1561 * FIX: "jpeglib.h" was not found on VC++
1562 * FIX: vtkgdcm was not being installed
1564 2003-10-10 Jean-Pierre Roux
1565 * ENH : OpenFile closes the file if it *really* doesn't look like
1566 an ACR-NEMA / DICOM one.
1567 * FIX : testWrite no longer writes an empty file if the source file
1568 is not gdcm Readable
1569 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1572 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1573 * FIX: CMake generate now documentation
1574 * ENH: out of source doc build !
1575 * ENH: Generate both user and dev documentation
1576 * ENH: Should work on windows too
1577 * ENH: Only one doxygen config.in file is needed
1578 * FIX: make install should be ok now on ùnix plateform
1579 * FIX: PATH to dictionary was wrong (missing /)
1580 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1582 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1583 * vtkGdcmReader is now able to read rgb dicom file.
1584 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1585 * added a gdcmViewer to vtk test, use mouse to control
1586 window level & window width
1588 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1589 * CMake-ification of gdcm, we have now two build system
1590 * FIX: on cygwin Wsock32 doesn't exist
1591 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1593 2003-10-06 Emanuel Ollart
1594 * FIX : compilation process wad broken.
1595 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1597 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1598 * change gdcmViewer -> vtkgdcmViewer
1599 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1601 2003-10-06 Jean-Pierre Roux
1602 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1603 ( e.g : well known GE images with a wrong elem length,
1604 : Philips MRI Images with a wrong Huffman table)
1605 * still to be done : allow the reading of bugged LEONARDO Siemens images
1607 2003-10-03 Jean-Pierre Roux
1608 * Odd length strings are padded with '\0' (not with spaces,
1609 to remain compliant with already defined strings,
1610 like Transfert Syntax UID and others)
1612 2003-10-03 Jean-Pierre Roux
1613 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1614 to allow displaying RGB images (not only by affim ;-)
1616 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1617 * vtkGdcmReader is now able to read rgb dicom file.
1618 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1620 2003-10-03 Jean-Pierre Roux
1621 * A few nasty patches to allow the reading of a lot of nasty images
1622 ( e.g : well known GE images with a wrong elem length,
1623 : Philips MRI Images with a wrong Huffman table)
1624 * still to be done : allow the reading of bugged LEONARDO Siemens images
1626 2003-10-03 Jean-Pierre Roux
1627 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1629 2003-10-03 Jean-Pierre Roux
1630 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1631 to allow displaying RGB images (not only by affim ;-)
1633 2003-10-03 Jean-Pierre Roux
1634 * gdcmFile::GetImageDataIntoVector now
1635 - deals with MultiFrames MultiFragments Run Length Encoded files
1636 - deals with YcBcR (YBR_FULL) files
1637 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1638 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1640 (no sample found :-(
1642 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1643 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1644 Two reasons: - clear things
1645 - third parties acces gdcm through header files, so won't
1646 suffer anymore VC++ complains
1648 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1649 * add argv[1] in testvtkGdcmReader.cxx
1652 2003-09-24 Jean-Pierre Roux
1653 * The lines are now eigthy characters long.for
1654 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1656 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1657 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1658 char* to std::string. Thus, the use of strdup becomes useless. (see
1659 previous commis of Malaterre)
1660 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1661 before the last Malaterre's commit.
1663 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1664 * This commit should fix the Debug building under VC++, the problem
1665 was mainly a mixture of debug and release lib being loaded at startup.
1666 * I also remove a depency to a specific C function: strdup. Because I had
1667 to force the link to msvcrtd (whereas strdup is in libc).
1669 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1670 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1671 located in the gdcmCommon.h file. All use of reference of tha has been
1672 changed to now use the variable GDCM_UNFOUND.
1674 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1676 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1677 Dicom dictionary. The test suite can now be run again. Note:
1678 I'm note very happy with the " (RET)" changes. I believe this
1679 RETAINED comment should be dropped when parsing the dictionary.
1680 - PACKAGER corrected
1682 - AUTHORS updated and now in alphabetical order
1683 * Makefile.am now exports gdcm.dsw for Windoze users.
1685 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1686 * cygwin complains about missing std:: in subdir Test/
1688 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1689 * remove some methods that are now in gdcmHeaderHelper
1691 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1692 * vtkGdcmReader set spacing and origin correctly
1694 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1695 * Fix a few delete/delete[] mismatch
1697 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1698 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1699 interpretation to data given by gdcmHeader. For instance there are
1700 heuristics to get informations (look at different places).
1701 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1702 sorting DICOM images based on different strategies.
1703 * modified Makefiles accordingly.
1705 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1706 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1707 when building in debug mode
1708 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1709 src/win32/gdcmdll.dsp
1710 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1712 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1713 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1716 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1717 * src/win32/libgdcmjpeg12.dsp was not dos format
1718 * src/win32/libgdcmjpeg12.dsp :
1719 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1720 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1722 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1723 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1725 * src/gdcmFile.cxx : bug fix in affectation type
1726 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1727 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1728 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1729 symbols... future problem ?
1731 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1732 * src/win32/libgdcmijpeg12.dsp was missing
1733 * modified gdcm.dsw accordingly
1735 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1736 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1738 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1739 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1740 commit of JPR (before his hollidays to facilitate our work).
1741 * setup.py : bug fix in code. Modifications made while the last commit
1742 of JPR. The code hasn't been tested before the commit... it's so
1743 useless to make that (for best programmer that is JPR) !!!
1745 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1746 * tagged the current version as Version0_3 (i.e. version 0.3)
1748 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1749 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1750 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1751 * *.dsp : modifications to use new libgdcmijpeg8 library
1752 * setup.py : bug fix on VTKPATH variable
1753 * PACKAGER : adding all concerning windows
1755 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1756 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1758 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1759 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1760 test suite reported error.
1761 * PACKAGER file added (describes what a packager must do when
1762 packaging a new release).
1763 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1764 * configure.in: upgraded version number to 0.3.0
1765 * fixing build of rpm (through rpm -ta):
1766 - Doc/Makefile.am exports proper doxygen files
1767 - src/jpeg/libijg8/Makefile.am exports the include files.
1769 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1770 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1771 * src/gdcmHeader.h : formatting code
1773 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1774 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1775 We were obtaining error message from vtk. Now, creation of file list
1776 is made in an internal list to prevent this problem.
1777 Bug fix when output is empty.
1778 Bug fix in update of progress value. Previous commit for this was a bad
1780 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1782 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1783 * src/gdcmHeader.h : added method to get the file name
1784 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1785 files. Added method to remove all files on the input
1786 Added FIXME comment concerning the bad parsing of header made by
1787 ExecuteInformation method (in ExecuteData method)
1789 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1790 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1791 when using make instal.
1792 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1793 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1795 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1796 * setup.py : adding include dir of jpeg lib to compile all sources
1797 * */Win32/*.dsp : JPR fix for windows compilation
1799 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1800 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1802 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1803 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1805 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1806 * setup.py is again effective on un*x (takes into account the
1807 addon of the jpeg library)
1808 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1809 * Doc/Doxy* updated (includes above enhancements)
1810 * INSTALL now points to web documentation
1812 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1813 * src/gdcmHeader.h doesn't make unnecessary reference to
1815 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1817 * src/gdcm*.[cxx|h] :
1818 - to allow compilation with gcc 3.x
1819 -- clean up of STL usage (added explicit usage of std::)
1820 -- small fixes on exceptions.
1821 Note: linking not tested !
1822 - clean of doxygen comments to avoid warnings at documentation
1824 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1825 dependent convertion).
1827 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1828 * Clean up of previous JPR garbage commit (not even commented in the
1830 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1831 - moved all jpeg related files from src to src/jpeg/libijg8, with
1832 addition/modification of Makefile.am and configure.in.
1833 - the testSuite is still brain damage (not guilty).
1835 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1836 * WrapVTK.py : modifications to get correctly vtk source files to
1838 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1839 (FileName -> Filename)
1841 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1842 * vtk/vtkGdcmReader.[cxx/h]:
1843 - UpdateProgress method should now be effective
1844 - removed the limitation on having only images loaded (as opposed
1846 - when building a stack of images/volume, a lesser number of
1847 gdcmHeader and gdcmFile instances should be used (hopefully
1848 accelerating things).
1849 - when building a stack of images/volumes, files which are not
1850 loadable (wrong path-filename, wrong permissions on existing file,
1851 or file not parsable by gdcm) are replaced with a black image
1852 in the stack (for the caller to notice the problem).
1854 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1855 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1857 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1858 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1859 between standard library (std) and vtk library (problems are found
1860 under Windows... thanks Windows !)
1862 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1863 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1865 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1867 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1868 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1870 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1871 * When compiling with distutils (see setup.py) the C++ compiler is
1872 called with different flags than the default ones (with automake).
1873 In order to fix all those warning, I compiled gdcm with the command
1874 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1875 and went for warning fixes:
1876 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1877 up from unused variables.
1878 - vtk/vtkGdcmReader.cxx: potential bug fix.
1879 * src/gdcmHeader.h: Doxygen warning cleanup
1881 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1882 * gdcmPython/gdcm.i:
1883 - typemaps correction to take into account the systematic replacement
1884 of "using namespace std" with std:: prefix e.g. std::list,
1885 std::string... (cf changes of 2003-05-21).
1886 - gdcmGlob global variable of type gdcmGlobal (defined in
1887 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1888 exported to Python a as cvar.
1889 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1890 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1891 gdcmDictSet.GetPubDictTagNames() and
1892 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1893 C++ static methods).
1894 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1895 with the above changes.
1897 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1898 * setup.py, manifest.in : bug fix under linux
1900 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1901 * Modification of setup.py to compile vtk part too. Then, we have 2
1902 wrappers which must work with same distutils. For that, we have a
1903 generic distutils in distusiltsWrapping.py ; with :
1904 - build_extWrap class to wrap generically all extensions,
1905 - ExtensionWrap base class for all wrapping extension that contains
1907 - Wrapper interface which wrap sources
1908 + In WrapSwig.py we have extension and wrapper for Swig
1909 + In WrapVTK.py we have extension and wrapper for VTK
1910 * MANIFEST.in : modifications to consider vtk directory and new python
1911 files for compilation
1913 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1914 * Added python wrappers of vtkGdcmReader vtk class (see the
1915 source in vtk/vtkGdcmReader.cxx) :
1916 - vtk/Makefile.am now builds a library
1917 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1918 python library (as opposed to _gdcm.so wich are the python
1919 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1920 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1922 - configure.in has an additional flag --enable-vtk that needs
1923 to be set to enable compilation of vtk related code, that is:
1924 + vtk/vtkGdcmReader.so and
1925 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1926 + gdcmPython/vtkgdcmPython.so (see above)
1927 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1928 be read when compressed or when HighBit + 1 != BitsStored),
1929 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1930 the usage of the python wrapper of vtkGdcmReader vtk class.
1931 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1932 * src/*.[h] all occurences of stl classes are now prefixed with
1933 std::, and all occurences of "using namespace std;" where removed.
1934 This is to avoid pollution of global namespace in included files.
1935 Apparently vtk does not avoid this pitfall: when using both
1936 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1937 collision of various stl members (principally cout...).
1938 * gdcmPython/testSuite.py now cleanly removes temprory generated
1940 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1941 comply with above changes)
1943 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1944 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1945 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1946 vtk data structure (an image Flip was required).
1947 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1948 * cosmetic changes in documentation.
1950 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1951 * src/gdcmHeader.cxx: the constructor no longer exits when an
1952 unexisting file is given as argument.
1953 * The subdirectory Data (containing all the images used for the
1954 test suite) is not part of this repository anymore. A new module
1955 containing those images is now available at
1956 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1957 with the name gdcmData.
1958 All the python scripts (including the package initialisation file
1959 gdcmPython/__init__.py) were adapated to take this change into
1960 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1962 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1963 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1964 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1965 demo of the usage of this class.
1966 Compilation of this vtk part is only done when using the --enable-vtk
1967 at configure (or autogen.sh) stage.
1969 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1970 * More memory link related corrections and documentation fixes.
1972 - maximum info is obtained with a command of the form:
1973 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1974 --show-reachable=yes PrintHeader
1975 - the remaining reachable blocks seem to come from the STL
1976 allocation scheme through the usage of map and list. It looks
1977 like this memory cannot be freed but it is not a memory leak
1978 (in fact further invocation to the STL would recollect the
1979 unused memory allthough it cannot explicitely be freed).
1980 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1981 of displaying an image parsed with gdcm and displayed with VTK.
1982 Note: some images don't seem to work e.g.
1983 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1984 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1985 Allthough this weakens the semantics, it is a ditch attempt to
1986 make gdcm more thread friendly.
1988 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1989 * Memory link hunt (by using valgrind through the command
1990 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1991 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1992 gdcmHeader::_dicom_vr.
1993 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1994 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1996 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1998 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1999 * src/Makefile.am now exports all the necessary include files at
2003 * UpdateGroupLength replaced by new one
2006 * UpdateGroupLength re-written using H-Table
2007 (named UpdateGroupLengthNew untill checks are over)
2009 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2010 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2011 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2013 - gdcmHeader::GetPubElValSet removed.
2014 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2015 UpdateGroupLength, WriteElements, Write.
2016 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2017 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2018 carried the same semantics.
2019 - src/gdcmHeaderIdo.cxx changed accordingly.
2020 - gdcmFile::WriteBase now regroups all the codes from previous
2021 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2022 - enum FileType moved to gdcmCommon.h
2023 * src/gdcmHeader.cxx AddDefault trashed
2024 * gdcmGetXSize added
2025 * getimageDataSize now calls gdcmGetXSize
2026 * Test/*.cxx changed to agree with above changes
2028 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2029 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2030 (to avoid double call by end user).
2031 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2032 by end user, since gdcmHeader::gdcmHeader now handles it.
2034 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2035 * gdcm/Doc many doxygen changes:
2036 - Doxyfile now has two different versions, DoxyfileUsers that generates
2037 the html.users end users oriented documentation and
2038 DoxyfileDeveloppers that generates the html.developper developper
2039 oriented documentation.
2040 - README changed accordingly
2041 - requirement.txt removed (old design info moved to TODO).
2042 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2043 DoxyMainPage.txt, DoxyPython.txt provide more information.
2044 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2045 be updated by simply regenerating the docs with doxygen and copying
2046 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2047 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2048 all the tests in the form "if (<map>.count() >1)" were removed.
2049 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2050 ill-formed documentation sections.
2051 * src/gdcmHeader.cxx: ditto
2053 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2054 * setup.py fixed for un*x (needed macro for stdint.h)
2055 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2056 un*ces with sh-utils test utility.
2057 * gdcmPython/demo/test.py renamed to PrintHeader.py
2058 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2059 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2060 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2061 * src/gdcm*.cxx JPR's bad inclusion fixed.
2063 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2064 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2065 * gdcmPython/demo/test.py changed accordingly.
2067 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2068 * gdcmPython/Makefile.am fixed linking against libstdc++
2069 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2070 * Swig subdir (historical tests of swig version 1.3.17++) removed
2071 * Test/testChangeEntete.cxx some lines commented out in order to make
2073 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2074 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2076 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2077 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2078 hence the user doesn't need this explicit call.
2079 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2080 i.e. LoadElements() call removed.
2081 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2082 - src/Makefile.am declares the proper flag for g++.
2083 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2084 for adding user defined new tags.
2085 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2086 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2087 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2089 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2090 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2091 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2092 src/Makefile.am : the project should properly compile and install
2093 with the autotools, included the python wrappers part.
2094 * gdcm.spec.in : added a spec file for RPM packaging.
2096 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2097 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2099 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2100 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2101 to exported to the environement (see gdcmPython/testSuite.py
2103 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2104 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2105 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2106 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2107 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2109 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2110 * gdcmPython/__init__.py doesn't crash anymore when running in
2111 in InstallMode or PreInstallMode but with an environement given
2112 value of GDCM_DICT_PATH.
2113 * src/gdcmDictSet.[cxx/h] coding style.
2115 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2116 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2117 * src/gdcm.h general comments moved to TODO, and README
2118 * src/gdcm.h should now be seen as a user commodity (including it
2119 should suffice to fully use gdcm). It is nowhere including within
2120 any of the kernel files src/*.cxx and src/*.h.
2122 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2123 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2124 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2126 * src/gdcm*.cxx only include their corresponding include file
2127 (as opposed to gdcm.h)
2128 * gdcmPython/gdcm.i changed accordingly
2129 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2130 the autogen.sh generated "make snapshot" command to work.
2131 * autogen.sh removed history related references to crea package.
2133 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2134 * distutilsSwigCPlusPlus.py work around some swig portability
2137 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2138 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2139 was done in a last ditch attempt to get setup.py _really_
2140 operationnal. The python/gdcmPython layaout add the advantage
2141 of hidding away the python related distutils specific files
2142 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2143 Alas, the src directory was out of scope (i.e. it's relative
2144 position to setup.py was ../src) which made things impossible to
2145 handle (see previous version of python/setup.py). Crossing fingers...
2147 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2148 * python/setup.py now works on Un*x. (harder than I thougth)
2149 * python/distutilsSwigCPlusPlus.py can now have include files
2150 among the list of sources.
2152 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2153 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2154 * modifications in MSVC projects
2156 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2157 * As stated by the first lines of Test/ExceptionAndPython/README, it
2158 looks like we can move back to original usage of exception within
2159 src/gdcm* and hence remove the errno stuff that was introduced
2160 as a quick and dirty fixture of this problem (added to the TODO).
2161 * Doc/Doxyfile configuration file for Doxygen and corresponding
2162 README file for usage added.
2163 * Test/testWrite.cxx added. This new test comes from a split of
2164 test.cxx that is now reverted to its original purpous i.e.
2165 testing the proper parsing of a Dicom related file.
2166 testWrite.cxx concentrates on testing the IO part of gdcm.
2167 * Test/bug1.cxx (containing a bug on WIn32) added.
2168 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2169 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2170 whose purpose is to publish the content of the TagNames of the
2171 Dicom public dictionnary were not accessible without an
2172 instance of class gdcmHeader.
2173 - those methods are now static methods of gdcmDictSet and hence
2174 require no instances at all to be invocated.
2175 - within gdcmDictSet this change required to change some method
2176 to class methods (i.e. are now static) among which SetDictPath
2177 (renamed to BuildDictPath) and LoadDefaultPubDict.
2178 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2179 the above changes by calling the new method classes of gdcmDictSet.
2180 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2181 the above to be effective.
2182 * python/gdcmPython: in order to wrap properly the above changes
2183 for Python, swig version now needs to be > 1.3.17.
2184 * python/gdcmPython/Makefile fixed to adapt itself to new
2185 configure/make shema introduced by Johan Montagnat (thanks for the
2186 contribution). Alas this Makefile cannot be turned into a proper
2187 Makefile.am without some heavy changes in the configure.in
2188 (for python dectection).
2189 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2190 now avoids publishing the empty entries.
2192 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2193 * python/setup.py : bug fix concerning install under windows
2194 ExtraPath reused :-P
2195 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2197 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2198 * Dicts/dicomV3.dic : remove double spaces !!!
2199 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2200 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2203 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2204 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2205 method. Doxygenation.
2206 * src/gdcm.h clean up of JPR spurious comments.
2208 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2209 * python/distutilsSwigCPlusPlus.py now properly collects the
2210 shadow classes generated by "swig -c++" (gdcm.py in our case)
2211 when using "python setup.py install".
2212 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2213 reexports the working classes.
2214 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2215 by the classical C errno scheme. This is to prevent an obscure
2216 behavior of the python wrappers when importing wxPython.wx prior
2217 to gdcmPython (which ended up in an abort call). An illustration
2218 of this oddity can be found in the Test/ExceptionAndPython
2219 subdir (see the README file). This problem probably due to
2220 an combination of g++ and dynamic loading.
2221 * added Test/ExceptionAndPython (see above)
2223 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2224 * Changed the layout of the python part to avoid bloating main
2225 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2226 i.e. the distutils arsenal. All the python related stuff is
2227 again in a python subdir, but the package itself is now in
2229 * setup.py was cleaned up:
2230 - pythonIncludePath removed
2231 - python setup.py bdist target is now functional.
2232 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2233 collision with other packages). gdcmPython/demo/*.py changed
2236 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2237 * python subdir moved to gdcmPython (preparation of distutils packaging).
2238 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2239 distutils installer is operational.
2240 * - gdcmPython/__init__.py now properly loads the swig generated
2241 shadow classes (from gdcm.py).
2242 - gdcmPython/demo/*.py changed to import the package gdcmPython
2243 instead of gdcmPython/demo/load.py.
2244 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2246 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2247 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2248 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2249 entries within the associated public Dicom dictionary resp. the same
2250 information but sorted by the fourth field (PAT, IMG, DIR) of the
2252 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2253 are now in the "???" group.
2254 - python/gdcm.i changed accordingly,
2255 - python/demo/printGroupedPublicDict.py added, that gives an example
2256 of the above new functionalities in Python.
2258 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2259 * src/gdcm.h, gdcmHeader.cxx:
2260 - historic references to glib's g_malloc and g_free (#defined)
2261 were definitively removed.
2262 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2263 * src/gdcmElValSet.cxx:
2264 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2265 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2266 - GetElValue(string) renamed to GetElValueByName.
2267 - Added GetElementByName(string).
2268 * src/gdcmHeader.cxx: added
2269 - GetPubElValRepByNumber(guint16, guint16)
2270 - GetPubElValRepByName(string)
2271 - GetShaElValRepByNumber(guint16, guint16)
2272 - GetShaElValRepByName(string)
2273 - GetShaElValByNumber(guint16, guint16)
2274 - GetShaElValRepByName(string)
2275 - GetElValRepByNumber(guint16, guint16)
2276 - GetElValRepByName(string)
2277 - GetElValByNumber(guint16, guint16)
2278 - GetElValRepByName(string)
2279 * Doc/requirements.txt added.
2281 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2282 * Test/Makefile building now depends on the one of libgdcm.so
2283 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2284 pixel data) aware which enables finding the address (offset) of
2285 the pixel data of JPEG encoded DICOM files. This leaves only a single
2286 file in the testSuite whose pixel data address (offset) is unknown.
2287 * python/testSuite.py changed accordingly.
2289 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2290 * VC++ has some strong limitations when working with the STL, as stated
2291 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2292 "Also note that some STL containers (map, set, queue, list, deque)
2293 cannot be exported. [...]
2294 Some STL classes contain nested classes. These classes can not
2296 This is caused by a designed limitation that once a template
2297 class is instantiated, it can not be re-instantiated and
2299 Since our usage of map<> is ubiquitous in gdcm, this "designed
2300 limitation" of VC++ is a pitfall.
2301 Hence the Python wrappers of gdcm cannot be incrementally linked
2302 against the c++ dynamic library. The dirty but only workaround is
2303 to forget about incremental link of dynamic libraries and to generate
2304 the Python wrappers library with the inclusions of the underlying C++
2306 The following modifications concern this matter on Win32/VC++:
2307 - wrapping python correct with standalone wrapped dll (don't use separate
2308 dll under windows !!!!)
2309 - python21_d debug mode enabled (ask Frog how to use it :-)
2310 - NO problem with having an STL member of class for example string in C++
2311 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2312 - Python test of dcmlib in Python is ok under windows on a large set
2314 * removed glib references
2315 * typedef's inserted in gdcm.i for correct swig type management
2317 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2318 * python/demo/*.py load.py extracted from test.py. Added explore.py
2319 that only displays required tags and testAll.py that parses all
2320 the files of the testsuite without using unittest.
2321 * python/testSuite.py other additional test on new files added.
2322 * Data/* new test files added accordingly to the testSuite.
2323 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2324 the vr in the file differs from the one of the dictionary.
2326 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2327 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2328 values, but limits itself to values which are below a user specified
2329 size (by default 1024 bytes).
2330 * python/gdcm.i : elements not loaded (because their size is above the
2331 user specified treshold) are exported with their TagKey as key of the
2332 python dictionary. This enables the testsuite to make some checks
2333 on the unloaded elements (since we have their offset and size).
2334 * python/testSuite.py
2335 - now tests for the existence and proper value of the pixel data
2336 - two new examples added.
2337 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2339 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2340 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2341 aware. See the strategy comments in gdcmHeader::FindeLength().
2342 * Test/test.cxx now accepts a filename as first argument.
2343 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2344 * python/testSuite.py changed to integrate test on above files.
2346 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2347 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2348 the vr was also RET.
2349 * python/testSuite.py more tests added.
2351 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2352 * python/testSuite.py unittest test suite added (uses Data)
2353 * Data/* dcm and acr files for the test suite.
2354 * glib dependance removed from un*x version. We now use ISO C99
2355 7.18 Integer types (see stdint.h)
2356 - python/Makefile, src/Makefile src/gdcm.h
2357 * src/ when an explicit vr (like dicom files) suddenly poped an
2358 implicit element we use to mark the underlying DictEntry of the
2359 concerned ElValue with "Implicit". This strategy was damageable
2360 too the public or provite dictionaries, since some of their vr
2361 would be changed. Since Header::FindLength heavily relies on the
2362 detection by Header::FindVR of falsely explicit elements, I
2363 added an extra ImplicitVr member to ElValue (boolean).
2364 The rest of the changes we the necessary adaptations.
2366 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2367 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2369 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2371 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2372 * Adaptation for porting to VC++:
2374 o forced to use std namespace (for string to be known)
2375 o all class use __declspec export style on WIN32
2376 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2377 (in stdlib.h on Win32 but in std:: for gcc)
2378 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2379 variable GDCM_DICT_PATH.
2380 * src/gdcmHeader.cxx verbose comments made discrete.
2382 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2383 * python/gdcm.i: added a typemap that converts a C++ hashing table
2384 to native Python dictionary.
2385 * python/demo/test.py:
2386 - now uses the native dictionary for exploration of gdcmHeader.
2387 - takes an optional filename argument (the file to parse).
2388 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2389 PubElVals hashing table.
2390 * Dicts/dicomV3.dic removed error prone trailing spaces.
2392 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2393 * Python wrapping process moved away from src/Makefile to
2394 newly created python/Makefile (as well as gdcm.i)
2395 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2396 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2397 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2398 from the environement variable GDCM_DICT_PATH (when existing).
2399 * src/gdcmDict::GetTag bug fix.
2401 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2402 * Straightforward temporary fixes for swig to build the python wrappers.
2403 src/Makefile now has a python working entry [by working we mean
2404 that we can import de shadow classes without errors].
2406 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2407 * hashtest.cxx removed (since allready in Test)
2408 * src/gdcmlib.h renamed to src/gdcm.h
2409 * src/dcm.i renamed to src/gdcm.i
2410 * src/Makefile prepared for python wrapping
2412 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2413 * src/gdcmHeader.cxx :
2414 - Parsing of header is now separated from loading of element values
2415 (see gdcmHeader::LoadElements).
2416 - general clean up of hopefully all file access (creation of
2417 ReadInt16 and ReadInt32)
2419 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2420 * src/gdcmHeader.cxx :
2421 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2423 - SetLgrElem renamed to SetLength
2424 - GetLgrElem renamed to GetLength
2425 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2426 * src/gdcmElValSet.cxx fixed both GetElValue methods
2427 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2428 due to IdoDude was cleaned out.
2430 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2431 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2432 concentrates on finding the value representation (when it exists).
2433 RecupLgr now only finds the element value length, and it avoids
2434 returning the unecessary skL (skipped length).
2435 Also, offsetCourant was simply removed (with taille_fich) since
2436 it was redundant with the File position internals (by using
2437 ftell and fseek). This also made skL (see above in RecupLgr) usage
2439 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2440 on the libido specificities which are handled through class
2442 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2445 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2446 * Truckload of changes. Parsing of header is barely functional
2447 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2449 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2450 * src/gdcmHeader.cxx many addons of low level methods
2452 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2453 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2454 and _IdDcmSWAP_LONG.
2456 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2457 * This corresponds to all the changes decided at the meeting of
2458 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob