1 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/*.cxx *.h Reference to License.htm fixed to License.html.
3 * Doc/CMakeLists.txt, doxygen.config.in: fix.
5 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
6 * TODO updated with Mathieu suggestions. I proposed a template for
7 describing TODO entries and used it for new entries.
8 * Added Doc/Website/CodingStyle.html, Developpers.html,
9 DeveloppersPython.html, GdcmDataCvs.html and
10 DownloadVersion0_1.html, DownloadVersion0_3.html.
11 * Some Doc/*.txt Doxygen files (which do not really concern the
12 documentation itself, but the website) moved to html and
13 placed in directory Doc/Website:
14 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
15 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
16 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
17 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
18 * CMakeLists.txt changed accordingly.
19 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
20 DeveloppersPython.html
21 * INSTALL nows refers to Doc/Website/Installation.html
23 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
24 * Added Doc/Website directory, that contains a first raw version
27 2004-09-23 Jean-Pierre Roux
28 * FIX In order not to be poluted any longer by casting problems,
29 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
30 we can now delete[] it safely
31 * VoidArea is now called BinArea (less confusing name),
32 and all the methods called ...VoidArea... are now ... BinArea...
33 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
35 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
36 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
37 clear) TagHT, which is an inherited member of gdcmElementSet. It is
38 up to the destructor of gdcmElementSet to clean up TagHt and it's
41 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
42 * Test/CMakeLists.txt: update to follow gdcmData renamings.
43 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
45 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
46 * ENH: added some utility method that builds a flat dictionnary
47 holding all the Dicom entries contained in the recursive structure
48 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
50 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
51 BuildFlatHashTable() that build a flat dictionary.
52 - src/gdcmElementSet.h: added a new private GetTag() accessor.
53 gdcmDocument is now a friend of gdcmElementSet.
54 - src/gdcmElementSet.cxx: clean up.
55 - Example/FlatHashTablePrint.cxx added.
56 - Example/CmakeLists.txt changed accordingly
58 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
59 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
60 moved away from gdcmDocEntrySet (since this class is an abstract class
61 acting like an interface). SQDepthLevel and BaseTagKey are now
63 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
64 and associated accessors. Doxygenation of the class.
65 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
67 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
68 Use SQDepthLevel accessor instead. ::Print() adapted.
69 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
70 - src/gdcmDocument.cxx changed accordingly.
72 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
73 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
74 - The following is the doxygen comment of the typedef declaration
75 of gdcmagKey in src/gdcmCommon.h:
76 gdcmTagKey is made to old an "universal" (as in URL, Universal
77 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
78 A dicom tag allways has a group and an element, but a set of tags
79 embeded in various (optionally nested) sequences and sharing
80 the same group and element all share the same (group, element)
81 "identifier". Hence the (group, element) cannot be used as an
82 identifier (in gdcm we shall refer to a "TagKey") of a tag.
83 In order to construct a proper tag identifier (i.e. a key) we
84 consider the following definition of a TagKey:
85 - let Group, Element be the string representation of the
86 group and element dicom tag members,
87 - let ItemNumber be the string representation of the integer
88 index of the considered item number of a sequence,
89 Let the key of a tag embeded in a sequence, noted SeqTag, be
91 /ItemNumber#Group|Element
92 where "/", "#" and "|" are characters acting as separators.
93 Then the general form of a gdcmTagKey is given by:
95 where <SeqTag> means NO or many instances of SeqTag.
96 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
99 but the gdcmTagKey of a tag "embeded" is the first item of
100 a sequence, itself nested in the third item of a sequence is the
102 0004|1220/2#0008|0082/0#0008|0090
103 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
104 order to hold the new sequence compatible key. Previously, the
105 GetKey() method would look in the underlying gdcmDictEntry.
106 - src/gdcmDocEntry.cxx:
107 -- constructor now copies the underlying DictEntry key, in the local
109 -- ::Print: displays the member Key, instead of the (group, element).
110 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
111 - src/gdcmDocEntrySet.h:xi
112 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
113 -- now has a new BaseTagKey member.
115 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
116 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
118 This poses the problem with the semantics of the following lines
119 LoadEntryVoidArea(0x0028,0x1201); // R LUT
120 LoadEntryVoidArea(0x0028,0x1202); // G LUT
121 LoadEntryVoidArea(0x0028,0x1203); // B LUT
122 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
123 to the long FIXME note for what the problem is. Nevertheless in
124 order to get things working the dicom dictionary was altered !
125 Please fix things urgently...
126 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
127 information), see above note on moving the member VoidArea. Nevertheless
128 the following entries previously correctly set as US are now inproperly
130 0028 1201 OW IMG Red Palette Color Lookup Table Data
131 0028 1202 OW IMG Green Palette Color Lookup Table Data
132 0028 1203 OW IMG Blue Palette Color Lookup Table Data
133 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
134 of gdcmDocEntry moved to gdcmSeqEntry.
135 * src/gdcmSeqEntry.cxx: STYLE.
137 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
138 * Test/TestAllEntryVerify.cxx minor fix and added comments.
140 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
141 * gdcmPython/testSuite.py: all the test suite in python is now moved
142 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
143 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
144 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
146 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
147 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
148 to avoid inclusion recursion until STL is reached.
149 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
150 mecanism. errno.h is not included in gdcm anymore.
151 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
152 (gdcmFormatError now inherits from gdcmFormatUnexpected).
154 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
155 gdcmData/TestAllEntryVerifyReference.txt
156 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
157 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
158 exception_on_error parameter.
159 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
160 - vtk/vtkGdcmReader.cxx changed accordingly,
161 - Example/*.cxx and Test/*.cxx changed accordingly.
163 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
164 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
165 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
166 enable_sequences removed from gdcmHeader constructor and dependencies.
167 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
168 * gdcmPython/demo/PrintHeader.py: dummy fix.
169 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
170 skip_shadow removed from gdcmHeader constructor and dependencies.
171 * Example/*.cxx and Test/*.cxx changed accordingly.
173 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
174 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
175 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
177 2004-07-21 Jean-Pierre Roux
178 * FIX Now, Parsing and Printing a DICOMDIR do work!
179 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
181 2004-07-20 Jean-Pierre Roux
182 * FIX Some brain damaged headers have Zero-Lenght fields
183 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
185 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
187 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
188 variable (instance of gdcmDebug) by a definition macro, and the instance
189 is now in static in the gdcmDebug class
190 * src/gdcmSQItem.h : (FIXME) remove an undefined method
191 * Test/PrintAllDocument.cxx : bug fix in the result of the test
193 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
194 * WARNING: ctest now depends more tightly on gdcmData. You should
195 check out gdcmData properly for things to run smoothly...
196 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
197 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
198 we need the pixels not be loaded in order to use the ValEntry
199 that displays position and size).
200 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
201 This is a C++ based equivalent of gdcmPython/testSuite.py that should
202 be deprecated. If you have any doubts about the advantages of a
203 modern scripting language (read Python) versus grass root C++ (i.e.
204 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
205 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
206 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
207 Anyhow, consider documenting the gdcmData images in
208 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
210 * Test/CMakeLists.txt:
211 - now uses TestAllEntryVerify.cxx
212 - specific comments on oldACR00001.ima (now renamed in gdcmData
213 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
214 gdcmData/TestAllEntryVerifyReference.txt
217 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
218 * src/*.[h|cxx] : typedef clean up
219 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
220 - TagKey renamed to gdcmTagKey (for external usage)
221 - VRKey renamed to gdcmVRKey (for external usage)
222 - removal of typedef duplication.
223 - Removed all unecessary inline keyword from class inline definitions.
224 - Some method|function(void) declarations replaced with method|function().
225 * src/jpeg/libijg12/jdhuff12.c:
226 - printf polluting ctest removed.
227 - TAB removal for comminting
229 - TestAllReadCompareDicom.cxx: added a test that compares all the
230 images in gdcmDataImages.h with corresponding images in
231 gdcmData/BaselineDicom/. When baseline images are not present
232 this test creates them.
233 Note: we need to validate each reference image, but before that
234 I'd like to rename them with a more explicit name...
235 - CMakeLists.txt: changed accordingly.
236 * Example/*.cxx: examples now only include gdcm.h (as opposed to
237 including each header needed).
239 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
240 * Test/*.cxx and Example/*.cxx: moved some examples away from the
241 test suite to the Example directory. Are concerned:
246 - TestWriteSimple.cxx
247 * Test/CMakeLists.txt: added some comments on reasons for black listing
248 image gdcmData/oldACR00001.ima
250 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
251 * Test/CmakeList.txt: removed the following from black list (to be coherent
252 with removal from gdcmData):
253 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
254 - gdcm-MR-PHILIPS-16.dcm
256 Added the following because after last cvs update, they cause
257 ctest -R TestReadWriteReadCompare
259 - gdcm-MR-SIEMENS-16-1.acr
261 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
262 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
263 new comments in this file) we temporarily (sigh) move to a weaker
265 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
266 we don't need to black list the following images anymore:
267 - 8BitsUncompressedColor.dcm
269 - US-PAL-8-10x-echo.dcm
270 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
271 fixes and the beautified code ;-)
272 This fixes the bug introduced in version 1.42 (when beautifying)
273 that made the parsing of 8BitsRunLengthColor.dcm unproper.
274 Note: ctest was blind to this bug (this means we need to still
275 improve the test suite). The bug could be detected by using
276 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
278 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
279 and by displaying the (garbage) produced file temp.XDCM...
281 2004-06-29 Jean-Pierre Roux
282 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
283 - replace by uggly but working old code :-(
284 A lot of things should be OK again.
285 It's really urgent to have a test suite that *tests*,
286 to prevent Frog's beautifying sessions to break all the stuff
287 (twice, withing a fortnigh ...)
289 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
290 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
291 redundancy) to added Test/TestReadWriteReadCompare.cxx
292 * Test/CmakeList.txt: because the compare test of
293 Test/TestReadWriteReadCompare.cxx fails, the following images are
294 black listed: - 8BitsUncompressedColor.dcm
296 - US-PAL-8-10x-echo.dcm
297 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
298 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
299 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
300 and ad-hoc kludge. This kludge is now removed, and on encountering
301 such an image (OB field brain damaged) we set errno. Then in
302 ::FindDocLength() we "fix" the length as being ALL what remains
303 in the file (until EOF). We then proceed, hoping for the best...
304 This fixes a SegFault in ShowDicom when trying to write such an
306 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
307 (because TestWriteRead breaks on it, after a non conformal commit?).
308 ctest now runs properly, except for MakeDicomDir (which was allways
309 broken) and the Python related stuff (still not fixed).
311 2004-06-24 Jean-Pierre Roux
312 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
313 FIX : Test/TestReadWrite now iterates on all the file names
314 (instead of infinite loop)
315 ENH : Test/TestWriteRead now iterates on all the file names
317 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
318 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
320 2004-06-24 Jean-Pierre Roux
321 FIX : - now Write drops LUT Descriptors and LUTs (if any)
322 when SamplesPerPixel =3
323 - now Write is no longer confused by
324 'BitsAllocated = 12" and 'BitsStored=12"
325 - "UN" value representation Elements are now written correctly
326 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
327 ENH : - now gdcmHeader has its own Write methods
328 (in order to split the job that has not to be done
331 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
332 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
333 loop on the same image until memory went out.
334 Note: this means we still have gobs of memory loss in PrintDocument
335 * src/gdcmDocument.cxx: fixes problem on parsing on file
336 gdcmData/16BitsJpegLosslessGrayScale.dcm.
338 2004-06-24 Jean-Pierre Roux
339 FIX : Write - All the Sequences and Sequence Item are now written
340 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
341 is added a the end, when necessary.
342 - A lot of brain-damaged images, that were read correctly are
343 now written correctly
344 - length compatible BinEntry are now loaded correctly
345 (even for odd groups)
346 Note : only Explicit Value Representation was checked.
347 (question : is implicit VR really necessary for gdcm ?)
349 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
350 * DEVELOPPER: added a proposition of coding style.
351 * src/gdcmDocEntry.h: removed every inline declaration (for test of
354 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
355 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
356 Use the gdcmDocEntry::Print() and Write() instead.
357 * src/gdcmDocument.cxx: bug fix.
359 2004-06-22 Jean-Pierre Roux
360 FIX : gdcmDocument.cxx
361 - Now we do recognize the JpegLossLess format (there was a misstyping in
362 code 'beautyfication' :-(
363 - Now we automaticaticaly load the Luts, if any
365 2004-06-22 Jean-Pierre Roux
366 In order : to write Sequences, whatever their imbrication level,
367 : to allow user to create his own Sequences
368 a lot of modif where necessary (adding, moving, or virtualising methods)
370 WARNING : save your own sources *before* cvs up !
373 ADD virtual void Write(FILE *fp, FileType filetype);
376 ADD virtual void Write(FILE *fp, FileType filetype);
377 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
380 ADD virtual void Write (FILE *fp, FileType filetype)=0;
381 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
382 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
383 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
384 ADD std::string GetEntryByName(TagName name);
385 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
387 std::string vr = "unkn",
388 std::string fourth = "unkn",
389 std::string name = "unkn");
390 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
391 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
392 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
393 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
394 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
395 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
396 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
397 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
400 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
401 ADD virtual std::string GetEntryByName (TagName tagName);
402 ADD virtual std::string GetEntryVRByName (TagName tagName);
403 REM virtual bool Write(FILE *, FileType);
404 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
405 FILE *_fp, FileType type);
406 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
407 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
408 REM virtual bool WriteEntries(FILE *_fp,FileType type);
409 REM virtual std::string GetEntryByName (std::string tagName);
410 REM virtual std::string GetEntryVRByName (std::string tagName);
411 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
412 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
413 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
415 std::string vr = "unkn",
416 std::string fourth = "unkn",
417 std::string name = "unkn");
418 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
419 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
420 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
421 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
424 ADD virtual void Write(FILE *fp, FileType filetype);
427 ADD virtual void Write(FILE *fp,FileType filetype);
430 ADD virtual void Write(FILE *fp, FileType filetype);
431 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
432 REM std::string GetEntryByNumber(guint16 group, guint16 element);
433 REM std::string GetEntryByName(TagName name);
436 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
438 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
439 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
440 The default constructor invoked by the line
441 gdcmHeader *f1 = new gdcmHeader( header );
442 was gdcmHeader::gdcmHeader(bool) instead of the expected
443 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
444 Hence the parsing wasn't executed... See also below.
445 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
446 as explicit constructor didn't do the trick to fix the above problem.
447 Could anyone explain why ?
448 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
449 properly calls gdcmValEntry::Print() (that was weed out from
450 code related to gdcmBinEntry).
452 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
453 * In order to fix memory leaks:
454 - Test/TestWriteSimple.cxx: added cleaning of free store through
456 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
457 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
458 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
459 (through the call to ::AddDicomDirMeta()) or the destructor
460 would crash when deleting uninitialized ::metaElems].
461 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
462 - src/gdcmDocument.cxx:
463 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
465 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
466 was causing memory leaks.
467 - src/gdcmSQItem.cxx:
468 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
469 cleanly handled with polymophism: sorry but my milage is low).
470 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
471 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
472 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
473 This avoids SegFaulting.
474 - src/gdcmSQItem.h: coding style.
476 - Test/TestWriteSimple still severely sucks. The output image content
477 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
478 damaged when displayed with vtkgdcmViewer.
479 - on memory leaks: TestWriteSimple leaks really less (see entry
480 of 2004-06-18 in Changelog file for the call to valgrind).
481 - on segfaults: ctest now passes all the tests but one (no more
483 * Erroneous leading white fix:
484 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
485 white[s] (as opposed to from >> xxx, that removes it [them].
486 - src/gdcmTS.cxx: ditto.
487 - gdcmPython/testSuite.py: dirty related kludge removed.
488 * src/*: remaining references to gdcmParser removed.
489 * src/*[cxx|h]: added copy[way]left header.
492 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
493 * In order to fix writing of dicom files:
494 - Test/TestWriteSimple.cxx: a simpler example of writing.
495 - Test/CMakeLists.txt changed accordingly.
496 - src/gdcmDocument.cxx:
497 -- The destructor now recursilvely removes potential sequences.
498 -- Bug fix in ::IsJPEG2000()
499 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
500 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
502 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
503 to only declared) and build on top of
504 ::GetDocEntryByNumber(guint16, guint16).
505 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
506 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
507 for usage in destructor and treatement of promotion in
508 ::ReplaceOrCreateByNumber().
509 - src/gdcmSQItem.cxx: destructor should better handle his job.
510 Test/TestWriteSimple now runs (or at least it DOES something).
511 * We can now start hutting memory links. A good starting point is:
512 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
513 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
514 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
516 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
517 * Valgrind note: after Mathieu Malaterre teached me how to read
518 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
520 Using gcc, you can force the STL to use malloc and to free memory as
521 soon as possible by globally disabling memory caching.
522 With 3.2.2 and later, you should export the environment variable
523 GLIBCPP_FORCE_NEW before running your program.
524 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
525 simply vanish (it is still not clear to me, whether this means that
526 STL std::string leaks or if valgrind believes it leaks...).
527 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
528 running bin/gdcmTests makeDicomDir):
529 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
530 - Test/makeDicomDir.cxx now properly traps empty lists and returns
532 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
533 SegFaulting (I drowned in DicomDir related code when trying to
534 understand why the list is empty...).
535 * src/gdcmDocument.h: first BSD license header try.
536 * Doc/License.txt added.
538 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
539 * src/gdcmDocument.[h|cxx]:
540 - Clean up of the Transfer related predicates. They are now all based
541 on new method isGivenTransferSyntax, that (should) handle properly
543 - general clean up, simplification, and coding style.
544 - Specific clean up of Parse7FE0() (umproperly named actually).
545 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
547 2004-06-14 Jean-Pierre Roux
549 - fix the display of Sequence Delimitor (SQDepthLevel pb)
550 - fix the display of SQItem ordinal number
551 - add the GetSQItemByOrdinalNumber method
552 - remove some useless never written private methods
554 2004-06-14 Jean-Pierre Roux
556 - adding a constructor taking a gdcmDocEntry as an input param
557 - ReplaceOrCreateByNumber now returns :
558 a gdcmBinEntry * if a Binary (void *) value is passed as a param
559 a gdcmValEntry * if a string value is passed as a param
561 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
562 according to the param type (no longer sets a gdcmDocEntry)
563 - GetValEntryByNumber, GetBinEntryByNumber added
564 - NewValEntryByNumber and NewBinEntryByNumber added
566 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
568 - GetSQItemNumber and SetSQItemNumber added, to provide
569 a (relative) Item identier inside a given Sequence
570 \warning : some pb remaining around this number
572 - AddEntry now takes the Item Number as a param
574 - adding a constructor taking a gdcmDocEntry as an input param
576 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
577 * Memory leak hunt with the following command:
578 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
579 --show-reachable=yes gdcmTests PrintDocument
580 It looks like many (all?) leaks are due to the STL (or a bad usage
581 of the STL. The lines producing the leaks now have a comment with
582 a "MEMORY LEAK" tag: you can retrieve them with
583 grep "MEMORY LEAK" src/*
584 Here are two typical examples which I can't help fixing:
589 char * test = "babo";
590 name = test; //// <--- valgrind detects 960 bytes lost in
591 //// call to std::string::operator=(char const*)
592 name.clear(); //// Doesn't help !
600 std::cout << "Type a bunch of characters followed by RETURN: ";
601 getline(std::cin, line); //// <--- valgrind dectects a loss
602 //// of 1320 bytes in call to
603 /// std::basic_istream<>& std::getline<>
609 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
610 * src/gdcmHeader.[cxx|h]:
611 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
612 and related, moved away to gdcmDocument.
613 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
614 the corresponding protected accessors of inherited class
615 gdcmDocument, removed ! As a consequence gdcmFile had to be
616 declared friend of class gdcmDocument (see below).
617 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
618 - Clean up of undefined or unused methods.
619 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
620 account the changes to gdcmHeader.h).
621 * src/gdcmDocument.h:
622 - gdcmFile is now a friend class (in order to take into account the
623 changes to gdcmHeader.h).
624 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
625 (see changes to gdcmHeader.h).
626 - Accessors (reading on the form GetEntry*) are now public.
627 - Clean up of undefined or unused methods.
628 * src/gdcmDocument.cxx:
629 - adaptation to changes to gdcmDocument.h
630 - ::OpenFile now writes a verbose message when file cannot be opened.
631 - some std::string properly set to VRKey
632 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
633 references to gdcmDocument.
634 * Test/TestFindTags.cxx: changed accordingly to above changes.
635 * gdcmPython/testSuite.py: adapted to renaming of acr files in
636 cvs repository gdcmData.
638 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
639 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
640 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
641 conflicts with gdcmValEntry::voidArea.
642 * src/gdcmValEntry.cxx: unmatching comment wiped out.
643 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
644 Value representation between StringRepresentable and BinaryRepresentable.
645 * src/gdcmDocument.cxx:
646 - method ParseDES: proper indentation restored and usage of
647 gdcmVR::IsVROfGdcmStringRepresentable wired in.
648 - method LoadDocEntry: the fingerprint left in the SetValue() of
649 unloaded entries (length > MaxSizeLoadEntry) had curiously been
650 removed. Reverting to previous code segment with the proper
651 dynamic_cast< gdcmValEntry* >.
652 Note: this was (partially) breaking the python test suite
653 (gdcmPython/testSuite.py) that made usage of the above
654 fingerprint to check presence of "Pixel Data".
655 * src/gdcmDocEntry.h: coding style.
656 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
657 now taken into account.
658 * gdcmPython/gdcm.i: adaptation to the new internal representation
659 of gdcm (exit gdcmParser, hello gdcmDocument).
660 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
662 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
663 anymore, but instead prints the loaded Python dictionary.
664 * .... alas, the python testSuite is still broken.
666 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
667 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
669 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
670 * src/gdcmUtil.h : export methods
672 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
673 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
675 * Initial addition of automatic python testing
676 * Initial addition of automatic image comparison
678 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
679 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
680 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
682 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
683 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
684 * Test/ShowDicom.cxx : bug fix for msvc compilation
685 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
687 2004-05-04 Jean-Pierre Roux
688 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
689 new concepts (and new classes) :
690 a 'gdcmDocument' is composed of a set of Doc Entries, that are
691 - elementary gdcmDocEntries (former gdcmHeaderEntries)
692 - Sequence Doc Entries (gdcmSeqEntries)
693 a Sequence is composed of Items.
694 Each item is a set of Doc Entries (this is recursive)
695 The non uniqueness of the 'Dicom tag' is due to this recursivity
696 (never taken into account)
697 Our unability to add a new 'entry' in the header
698 at the proper location (neither in the H-Table (map or multimap),
699 nor in the Chained List is also due to this recursivity.
700 Don't try, right now, to use/modify/compile these new sources :
702 We just commit all the stuff, 'as is', in order not to loose it.
704 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
705 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
707 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
708 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
709 file prefix (SetFilePrefix)
711 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
712 * Add a new test: ShowDicom, for now this is just the c++ version of
713 checkRead.sh, later it will be able to compare the image read against a
715 * Replace the DEBUG on the stack with a global entry in cmake interface:
716 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
718 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
719 * Add an example subdir, with a real example on how to read + write a
722 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
723 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
724 * Doc/CMakeLists.txt: the main page is now properly differentiated
725 between the developper and user version.
726 * Doc/doxygen.config.in: dropped search related obsolete flags
727 * src/gdcmParser.h, gdcmHeader.h: doxygenation
729 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
730 * DEVELOPPER: added some helpfull comments for compile/test/install
733 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
734 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
735 src directory, now generated in the build dir.
736 2. Tests as mentionned smarter
738 4. Add a new method in gdcmDict that return the PubDict by name
739 this is interesting for 3rd party lib like ITK,
740 where we could set the institution name / patient name...
742 * ENH: 1. Now the test suite is working for real
743 2. All binaries are now output in the gdcm-bin directory
744 (this was not true before)
746 2004-04-28 Jean-Pierre Roux
747 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
748 SeQuence indented printing of Dicom Header.
749 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
750 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
751 Computation of SQDepthLevel is now part of gdcmHeader constructor
752 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
753 tree-like structure of a Dicom Header.
754 * FIX Test code cleaning
756 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
757 * ENH: Adding automatic testing
758 1. Need a DartConfig.cmake to submit to public
759 2. Add a test driver gdcmTest.cxx
760 3. gdcmTestMain, an helper for the main test driver gdcmTest
761 4. Files in Test don't have a main anymore, this becomes interesting
762 when we add more and more tests, thus dsw don't have to load
764 * ENH: Adding a GDCM_DATA_ROOT for testing
765 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
766 one file instead of seven + some small cleanup
768 2004-04-22 Jean-Pierre Roux
769 * ENH Minor changes to the Print() methods.
770 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
771 Header printing. Example given with :
772 > PrintHeader fileName 2 new
773 (SQ based tree-like structure still to be done for the Header ...)
775 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
776 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
777 1. I have added some unsigned where needed
778 2. Some function parameter not used -> (void)
779 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
780 4. g++ don't like character '\' in comment
781 5. #define jpeg_create_decompress jCreaDecompress
782 this really need to be fixed
783 6. virtualize destructor of gdcmObject ... leakage
784 7. sscanf(g->first.c_str(),"%x",&gr_bid);
785 this also really need to be fixed
786 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
787 remove compression file
788 (as we only do decompression, right ?)
789 * ENH: Change malloc/calloc/free with c++ equivalent
791 2004-04-21 Jean-Pierre Roux
792 * FIX gdcmHeaderHelper::GetXSpacing
793 when a single value is found (bug ?), xpacing is now
794 defaulted to yspacing
796 2004-04-19 Jean-Pierre Roux
797 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
798 * ENH add parameters :
799 bool exception_on_error = false,
800 bool enable_sequences = false,
801 bool ignore_shadow = false
802 to the gdcmFile constructors to be full gdcmParser compliant
803 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
804 to allow reading of PAPYRUS 3.0 files
806 2004-04-06 Jean-Pierre Roux
807 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
809 2004-04-02 Jean-Pierre Roux
810 * ADD : Test/checksequence.sh, for a general recap on SQ pb
811 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
812 for Philips spurious Tag fffe|0000 while rewritting Dicom files
814 2004-03-30 Jean-Pierre Roux
815 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
816 for ACR file, written out as DICOM files (hope so...)
818 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
819 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
820 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
821 moved to base class gdcmParser and only the specialisation is kept
823 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
824 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
825 already does the job.
826 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
827 (to be consistent with gdcmParser::WriteEntries).
829 2004-03-30 Benoit Regrain
830 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
831 upate of the object's instance. It's passed to 2 in the unfavorable
832 case : one in the ExecuteInformation, one in the ExecuteData
834 2004-03-29 Jean-Pierre Roux
835 * ENH : Check on file type to be written moved
836 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
837 * FIX : gdcmObject::ResetBoundaries now stops properly
838 when end-of-list is reached
839 : gdcmVersion modified (as Benoit Regrain asked)
841 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
842 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
843 * src/gdcmUtil.cxx: added forgotten iostream include.
844 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
845 equivalent to ExplicitVR in existing code).
847 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
848 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
849 now contains all the gdcmGlobal related code.
850 * minor coding style and doxygenation changes.
852 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
853 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
854 now contains all the Debug related code.
855 * minor clean-up of includes in src/*.cxx
856 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
857 CreateCleanString) removed.
858 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
859 * Doc/DoxyMainPageUser.txt added.
860 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
861 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
864 2004-03-24 Jean-Pierre Roux
865 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
867 2004-03-23 Jean-Pierre Roux
868 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
869 big endian made volumes
870 * ENH Now gdcmParser constructor and destructor are protected to forbid
871 end user to instanciate class gdcmParser
872 (only gdcmHeader and gdcmDicomDir are meaningfull)
874 2004-03-22 Benoit Regrain
875 * FIX : src/gdcmDicomDir.cxx : make windows compilable
876 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
877 gdcmSerie to gdcmDicomDirSerie
879 2004-03-19 Jean-Pierre Roux
880 * ENH Now the tree-like structure describing a DICOMDIR comming from
881 an already existing DICOMDIR file is consistent with
882 the home-made tree-like structure build ex-nihilo
883 or build from the files held (recursively) in a Directory
884 functions gdcmDicomDir::CheckBoundaries()
885 gdcmObject::SetBoundaries() added
887 2004-03-17 Jean-Pierre Roux
888 * REM (Eric Boix bug) : removal of meaningless
889 gdcmDicomDirImage::NewImage function.
890 * FIX now file names and directory name are written properly in the
892 * FIX now gdcmDicomDir constructor may be call without any trick
895 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
896 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
897 of gdcmDicomDirImage::NewImage as empty function.
899 2004-02-28 Jean-Pierre Roux
900 * ENH add gdcmDicomDir:NewPatient
901 add gdcmDicomDirPatient:NewStudy
902 add gdcmDicomDirStudy:NewSerie
903 add gdcmDicomDirSerie:NewImage
904 to allow making gdcDicomDir object.
905 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
906 (as opposite to the gdcmHeader chained list)
908 2004-02-11 Benoit Regrain
909 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
910 when using from python
912 2004-02-10 Benoit Regrain
913 * FIX : bug fix in the gdcmDirList for the recursivity in directories
914 * FIX : in gdcmDicomDir when the directory is empty
915 * ENH : add callback and methods to get the progression of dicomDir
918 2004-02-06 Jean-Pierre Roux
919 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
920 - GDCM_META added to gdcmDicomDirType
921 - class gdcmMeta created
922 * ENH : - A brief summary is now displayed at the beginning of
923 'testDicomDir' to help disaster magnitude estimation
924 * REM : Now useless Test/explDICOMDIR.cxx
926 2004-02-05 Benoit Regrain
927 * ENH : add methods in gdcmObject to get the hash table or the list of
929 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
930 * FIX : wrapping python for TagHeaderEntryHT
932 2004-02-04 Benoit Regrain
933 * FIX : even length for some strings when writting the dicom dir
934 * FIX : sort the images in the dicom dir
935 * FIX : Bug fix for python use of dicom dir
936 * ADD : a python demo
938 2004-02-04 Jean-Pierre Roux
939 * FIX : Final solution (?) for icone embedded images
940 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
941 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
942 add groups 6002, 6004, 6006, to allow 'clean' parsing of
943 gdcmData/gdcm-MR-SIEMENS-16.acr1
944 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
945 to make full checking easier
947 2004-02-04 Benoit Regrain
948 * FIX : WriteEntries : coding style & logic in parameters
949 * FIX : Set the elements to create the DicomDir in a dictionary file
951 2004-02-03 Benoit Regrain
952 * gdcmDirList : to parse a hard drive directory in recursive (or not)
953 * gdcmDicomDir : add the load of directory
954 * Bug fix and print add-on
956 2004-02-03 Jean-Pierre Roux
957 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
958 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
959 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
960 * FIX gdcmParser.cxx : 'group length' elements are now considered
961 as integers, even for shadow groups, when file is Implicit VR
963 2004-02-02 Jean-Pierre Roux
964 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
966 of the last synonym :-(
967 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
969 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
970 * FIX taking into account the possible 7fe0,0010 multiplicity
971 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
972 to allow removal of references to 7fe0,0010, to deal with
973 ACR-NEMA images, when 0028,0200 is meaningfull
975 2004-01-31 Jean-Pierre Roux
976 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
977 no longer writes 'Un' on disk
978 * FIX SQ elements with actual length are now dealt with corectly
979 * FIX gdcmFile::WriteBase make the difference, for color images, between
980 the length (for Palette expanded images)
981 and Raw Length (non expanded image + Palette)
982 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
983 (that broke Write). Replaced by UL.
984 Aware user will reload the field if he
985 thinks it's necesssary
987 2004-01-30 Jean-Pierre Roux
988 * gdcmParser::CheckSwap() now defaults the filetype to ACR
989 when 'dirty Acr' is found, to be compliant with the new
990 IsReadable() methods.
992 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
993 (no DOUBLE images in kosher DICOM,
994 but so usefull for people that miss them ;-)
996 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
997 DICOMDIR related utilities (not checked as Windoze compliant)
999 2004-01-28 Jean-Pierre Roux
1000 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1002 2004-01-27 Jean-Pierre Roux
1003 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1004 to allow skipping the shadow elements, to save memory space.
1005 The TRUE value for this param has to be used
1006 with a FALSE value for the 'enable_sequence' param.
1007 ('public elements' may be embedded in 'shadow Sequences')
1008 * gdcmHeader methods now deal with 'embedded icones images' in the header
1009 (even when an 'icone image sequence' is announced by the
1010 element (0x0088,0x0200), but there is NO icone at all ...
1012 * gdcmHeader sometimes Image Location value doesn't follow
1013 the supposed processor endianity (see gdcmData/cr172241.dcm).
1016 * gdcmHeader add the method
1017 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1018 to get *all* the Header Entries with the same tag.
1019 GetHeaderEntrySameName is probabely *useless*
1020 (no meaning : Name is *not* an identifier within the Dictionnary)
1022 2004-01-26 Benoit Regrain
1023 * Bug fix in the print of hexadecimal representations. Remove long fields
1024 in the print and add a third level of print to print them
1026 2004-01-23 Benoit Regrain
1027 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1028 * Bug fix on test suite after remove the strip made on not string fields
1029 * Split the IsReadable method between gdcmParser which test that the file
1030 is dicom and gdcmHeader which test that it's an image file
1032 2004-01-22 Benoit Regrain
1033 * DicomDir : clean code, add methods, set variables in protected or private
1034 * gdcmUtil : bug fix for the clean string method
1036 2004-01-19 Benoit Regrain
1037 * Add the use of shadow dictionaries
1038 * bug fix and coding style
1040 2004-01-19 Benoit Regrain
1041 * src/gdcmFile.cxx : bug fix concerning the close of file
1042 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1043 * Add the update of header entries using the shadow library
1045 2004-01-19 Benoit Regrain
1046 * removal of file gdcmHeader2.cxx
1047 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1048 inheriting from gdcmParser. This split is to prepare the integration
1049 of dicom dir parsing
1050 * bug fix under python
1052 2004-01-16 Jean-Pierre Roux
1053 * REM removal of class gdcmHeaderEntrySet
1054 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1055 * ADD add file gdcmHeader2.cxx
1056 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1058 2004-01-15 Benoit Regrain
1059 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1060 entries created while parsing the header. Thus, they will be destroyed
1061 when the gdcmDictSet will be destroyed
1062 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1065 2004-01-15 Benoit Regrain
1066 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1067 made a fatal error because of the memory release at the end of program.
1068 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1069 some memory and vtk seems to have some problems with that.
1070 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1072 2004-01-14 Benoit Regrain
1073 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1074 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1075 * src/*.[h|cxx] : make changes due to class name changes
1076 * gdcmPython/demo/*.py : bug fix due to method names
1078 2004-01-13 Benoit Regrain
1079 * src/*.[h|cxx] : coding style
1080 * vtk/*.[h|cxx] : coding style
1082 2004-01-13 Benoit Regrain
1083 * gdcmPython/testSuite.py : test the readable flag of file for tests
1084 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1085 It's lied to the stl compilation by MSVC (windows, always windows...)
1086 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1088 2004-01-12 Benoit Regrain
1089 * src/*.h : add comments
1090 * src/gdcmDictSet.h : set the method BuildDictPath in public
1091 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1092 directly setted in the source code
1093 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1096 2004-01-09 Benoit Regrain
1097 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1098 * setup.py : use a reference to gdcmVERSION
1100 2004-01-07 Benoit Regrain
1101 * Modification to compile with the distutils.
1104 2003-12-10 Benoit Regrain
1105 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1106 can use a gdcmHeaderHelper to load datas
1107 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1108 made in the source code
1110 2003-12-10 Benoit Regrain
1111 * Update Windows projects and .cvsignore files
1113 2003-11-12 Jean-Pierre Roux
1114 * ENH gdcmHeader constructor has one more parameter (default value : false)
1115 that allows the user to 'go inside' the SeQuences only
1117 gdcmElValSet:Print takes it into account
1119 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1120 * ENH: Update gdcmPython/CMakeLists
1121 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1122 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1124 2003-11-10 Jean-Pierre Roux
1125 * FIX : gdcmHeader::LoadElements is now based
1126 on the ListTag listElem member,
1127 not longer on the TagElValueHT tagHt member
1128 * ENH : PrintPubElVal shows (temporarily) both results,
1129 with the tagHt member and the listElem member.
1130 (it's easier to 'see' the problems when using Printheader)
1132 * FIX : old private member LgrElem is now splitted into
1133 ReadLength : Length actually found on disk (updated only
1134 if bug fixing is necessary), for internal
1136 UsableLength : Updated by FixFoundLength, to fix a bug
1137 or to allow Parser going on.
1138 Will allow to re-write a kosher header when a SeQuence
1139 with a length (not 0000) is found
1140 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1141 because gdcmElValSet::Add does not update ListElem
1144 2003-11-07 Jean-Pierre Roux
1145 * FIX misstyping in Transfert Syntax name table
1146 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1147 when they have an actual length (not 0000 nor FFFFF)
1148 (Nobody should care of it, but DICOMDIR explorers)
1150 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1151 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1153 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1154 * ENH: vtkGdcmReader now supports LUT !
1155 (vtkgdcmViewer for now is not able to use them though)
1157 2003-11-05 Jean-Pierre Roux
1158 * in testSuite.py : new files names for checking the package
1159 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1160 that returns the pixel area size to the *aware* (vtk) user
1161 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1163 2003-11-05 Benoit Regrain
1164 * in testSuite.py : Modify the rules for checking the paths
1165 : Explicit error messages
1166 * in __init__.py : Related modif
1168 2003-11-03 Jean-Pierre Roux
1169 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1170 to be used by aware (vtk) users that want to manage
1171 LUT (and no to turn the PALETTE image into an RGB pixels one)
1172 * GetPixelType now returns 8U for 24 Bits images
1173 (vtkGdcmReader compliant)
1175 2003-10-31 Jean-Pierre Roux
1176 * Removal of *all* gdcmData images and add them again
1177 in order to loose the 'history' of un-anonymised images
1179 2003-10-31 Jean-Pierre Roux
1180 * RMV : removal of useless jBitsInJsample.h
1181 for both 8 and 12 Bits JPEG Lossy Libraries
1183 2003-10-31 Jean-Pierre Roux
1184 * ENH : Add the functions gdcmFile::GetImageDataRaw
1185 gdcmFile::GetImageDataIntoVectorRaw
1186 that act as GetImageData and GetImageDataIntoVector
1187 except the making of an RGB Plane from Gray Plane + LUT
1188 Intended to aware (vtk) users who know how to manage
1191 GetLUTRGBA return a R,G,B,A LUT if any
1192 lgrTotaleRaw gives the 'Raw' length
1193 GetImageDataRaw returns the gray Plane
1194 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1195 (They stay Grey, just like with other Dicom viewers :-(
1197 2003-10-30 Jean-Pierre Roux
1198 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1200 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1201 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1202 being coherents dicom files.
1204 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1205 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1207 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1208 * ENH: Two steps is necessary to please VC++ compiler...
1209 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1210 * ENH: Add include dir to medcon lib
1211 * FIX: only one function is being exported for now !
1212 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1214 2003-10-29 Jean-Pierre Roux
1215 * adding gdcmHeader::GetLUTRGBA
1216 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1217 --> Mathieu, the modif u're waiting for is not yet committed
1218 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1220 2003-10-27 Jean-Pierre Roux
1221 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1222 00191113.dcm DermaColorLossLess.dcm
1223 MxTwinLossLess.dcm RadBWLossLess.dcm
1224 * ENH: For version prior to vtkImageViewer2 -r 1.19
1225 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1227 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1228 * Removal of ido stuff in CMakeLists.txt
1230 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1231 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1232 * FIX: remove a call to ->Modified ... see comments
1233 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1235 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1236 * FIX: Problem with path for libvtkgdcmPython
1237 * ENH: Try adding a search script for python site-package
1238 * RMV: Remove some file from medcon lib that are not necessary
1239 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1240 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1241 * FIX: More pragma disable fro VC++,
1242 I don't think I break something as it is also disable in VTK/ITK.
1243 But it fasten debug compilation time.
1245 2003-10-23 Jean-Pierre Roux
1246 * gdcm now deals with 16 Bits Run Length Encoded images
1247 (they are compressed as 2 planes images,
1248 one for the high Bytes, the other for low Bytes)
1250 2003-10-22 Jean-Pierre Roux
1251 * Now CheckRead takes into account :
1252 - the bugged 'Leonardo' Siemens images
1253 - the XA images, sent thru the burning VPRO station
1254 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1257 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1258 * FIX: When copying a Makefile.am to CMakeLists.txt
1259 one should remove the '\'
1261 2003-10-22 Jean-Pierre Roux
1262 * in gdcmData adding a bugged 'Leonardo' Siemens image
1263 (wrong lengths in header)
1264 OK with gdcm, KO with the other viewers :-)
1265 * add a GE dlx XA image, thru the VEPRO burning station
1268 2003-10-21 Jean-Pierre Roux
1269 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1270 for a brutal checking of vtkgdcmViewer compliance
1272 2003-10-21 Jean-Pierre Roux
1273 * add the files for 'xmedcon' Jpeg Lossless library
1274 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1276 2003-10-21 Jean-Pierre Roux
1277 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1279 2003-10-21 Jean-Pierre Roux
1280 * garbage Siemens 'Leonardo' images dealt with
1281 (the patch is easy to remove)
1282 * cosmetic changes to avoid warnings
1284 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1285 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1286 no need to press 'r' now.
1288 2003-10-20 Jean-Pierre Roux
1289 * upgrade of checkRead.sh checkWrite.sh according
1290 to new Jpeg Lossless decompressor
1291 * add US.3405.1.dcm, a genuine RGB medical file ...
1292 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1293 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1295 2003-10-15 Jean-Pierre Roux
1296 * general anonymisation in gdcmData
1297 * adding the 'color files' from
1298 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1299 * adding some well knowed bugged-header images
1300 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1301 waiting for their inclusion in Python testsuite
1303 2003-10-15 Jean-Pierre Roux
1304 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1305 no longer seg faults when file is not found
1307 2003-10-14 Jean-Pierre Roux
1308 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1311 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1312 * TODO: *.in file to genereate a UseGDCM later
1314 2003-10-14 Jean-Pierre Roux
1315 * Some supposed-to-be Dicom Images have no preamble.
1316 OpenFile takes it into account
1317 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1318 * Missing elements added in dicomV3.dic
1319 (just to be affraid : have a look at
1320 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1321 and do it again next year ;->
1323 2003-10-13 Jean-Pierre Roux
1324 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1325 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1326 But there are NOT. It's fixed !
1328 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1329 * FIX: "jpeglib.h" was not found on VC++
1330 * FIX: vtkgdcm was not being installed
1332 2003-10-10 Jean-Pierre Roux
1333 * ENH : OpenFile closes the file if it *really* doesn't look like
1334 an ACR-NEMA / DICOM one.
1335 * FIX : testWrite no longer writes an empty file if the source file
1336 is not gdcm Readable
1337 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1340 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1341 * FIX: CMake generate now documentation
1342 * ENH: out of source doc build !
1343 * ENH: Generate both user and dev documentation
1344 * ENH: Should work on windows too
1345 * ENH: Only one doxygen config.in file is needed
1346 * FIX: make install should be ok now on ùnix plateform
1347 * FIX: PATH to dictionary was wrong (missing /)
1348 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1350 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1351 * vtkGdcmReader is now able to read rgb dicom file.
1352 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1353 * added a gdcmViewer to vtk test, use mouse to control
1354 window level & window width
1356 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1357 * CMake-ification of gdcm, we have now two build system
1358 * FIX: on cygwin Wsock32 doesn't exist
1359 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1361 2003-10-06 Emanuel Ollart
1362 * FIX : compilation process wad broken.
1363 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1365 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1366 * change gdcmViewer -> vtkgdcmViewer
1367 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1369 2003-10-06 Jean-Pierre Roux
1370 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1371 ( e.g : well known GE images with a wrong elem length,
1372 : Philips MRI Images with a wrong Huffman table)
1373 * still to be done : allow the reading of bugged LEONARDO Siemens images
1375 2003-10-03 Jean-Pierre Roux
1376 * Odd length strings are padded with '\0' (not with spaces,
1377 to remain compliant with already defined strings,
1378 like Transfert Syntax UID and others)
1380 2003-10-03 Jean-Pierre Roux
1381 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1382 to allow displaying RGB images (not only by affim ;-)
1384 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1385 * vtkGdcmReader is now able to read rgb dicom file.
1386 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1388 2003-10-03 Jean-Pierre Roux
1389 * A few nasty patches to allow the reading of a lot of nasty images
1390 ( e.g : well known GE images with a wrong elem length,
1391 : Philips MRI Images with a wrong Huffman table)
1392 * still to be done : allow the reading of bugged LEONARDO Siemens images
1394 2003-10-03 Jean-Pierre Roux
1395 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1397 2003-10-03 Jean-Pierre Roux
1398 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1399 to allow displaying RGB images (not only by affim ;-)
1401 2003-10-03 Jean-Pierre Roux
1402 * gdcmFile::GetImageDataIntoVector now
1403 - deals with MultiFrames MultiFragments Run Length Encoded files
1404 - deals with YcBcR (YBR_FULL) files
1405 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1406 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1408 (no sample found :-(
1410 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1411 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1412 Two reasons: - clear things
1413 - third parties acces gdcm through header files, so won't
1414 suffer anymore VC++ complains
1416 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1417 * add argv[1] in testvtkGdcmReader.cxx
1420 2003-09-24 Jean-Pierre Roux
1421 * The lines are now eigthy characters long.for
1422 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1424 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1425 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1426 char* to std::string. Thus, the use of strdup becomes useless. (see
1427 previous commis of Malaterre)
1428 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1429 before the last Malaterre's commit.
1431 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1432 * This commit should fix the Debug building under VC++, the problem
1433 was mainly a mixture of debug and release lib being loaded at startup.
1434 * I also remove a depency to a specific C function: strdup. Because I had
1435 to force the link to msvcrtd (whereas strdup is in libc).
1437 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1438 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1439 located in the gdcmCommon.h file. All use of reference of tha has been
1440 changed to now use the variable GDCM_UNFOUND.
1442 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1444 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1445 Dicom dictionary. The test suite can now be run again. Note:
1446 I'm note very happy with the " (RET)" changes. I believe this
1447 RETAINED comment should be dropped when parsing the dictionary.
1448 - PACKAGER corrected
1450 - AUTHORS updated and now in alphabetical order
1451 * Makefile.am now exports gdcm.dsw for Windoze users.
1453 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1454 * cygwin complains about missing std:: in subdir Test/
1456 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1457 * remove some methods that are now in gdcmHeaderHelper
1459 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1460 * vtkGdcmReader set spacing and origin correctly
1462 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1463 * Fix a few delete/delete[] mismatch
1465 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1466 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1467 interpretation to data given by gdcmHeader. For instance there are
1468 heuristics to get informations (look at different places).
1469 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1470 sorting DICOM images based on different strategies.
1471 * modified Makefiles accordingly.
1473 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1474 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1475 when building in debug mode
1476 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1477 src/win32/gdcmdll.dsp
1478 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1480 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1481 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1484 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1485 * src/win32/libgdcmjpeg12.dsp was not dos format
1486 * src/win32/libgdcmjpeg12.dsp :
1487 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1488 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1490 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1491 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1493 * src/gdcmFile.cxx : bug fix in affectation type
1494 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1495 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1496 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1497 symbols... future problem ?
1499 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1500 * src/win32/libgdcmijpeg12.dsp was missing
1501 * modified gdcm.dsw accordingly
1503 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1504 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1506 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1507 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1508 commit of JPR (before his hollidays to facilitate our work).
1509 * setup.py : bug fix in code. Modifications made while the last commit
1510 of JPR. The code hasn't been tested before the commit... it's so
1511 useless to make that (for best programmer that is JPR) !!!
1513 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1514 * tagged the current version as Version0_3 (i.e. version 0.3)
1516 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1517 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1518 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1519 * *.dsp : modifications to use new libgdcmijpeg8 library
1520 * setup.py : bug fix on VTKPATH variable
1521 * PACKAGER : adding all concerning windows
1523 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1524 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1526 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1527 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1528 test suite reported error.
1529 * PACKAGER file added (describes what a packager must do when
1530 packaging a new release).
1531 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1532 * configure.in: upgraded version number to 0.3.0
1533 * fixing build of rpm (through rpm -ta):
1534 - Doc/Makefile.am exports proper doxygen files
1535 - src/jpeg/libijg8/Makefile.am exports the include files.
1537 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1538 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1539 * src/gdcmHeader.h : formatting code
1541 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1542 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1543 We were obtaining error message from vtk. Now, creation of file list
1544 is made in an internal list to prevent this problem.
1545 Bug fix when output is empty.
1546 Bug fix in update of progress value. Previous commit for this was a bad
1548 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1550 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1551 * src/gdcmHeader.h : added method to get the file name
1552 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1553 files. Added method to remove all files on the input
1554 Added FIXME comment concerning the bad parsing of header made by
1555 ExecuteInformation method (in ExecuteData method)
1557 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1558 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1559 when using make instal.
1560 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1561 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1563 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1564 * setup.py : adding include dir of jpeg lib to compile all sources
1565 * */Win32/*.dsp : JPR fix for windows compilation
1567 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1568 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1570 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1571 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1573 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1574 * setup.py is again effective on un*x (takes into account the
1575 addon of the jpeg library)
1576 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1577 * Doc/Doxy* updated (includes above enhancements)
1578 * INSTALL now points to web documentation
1580 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1581 * src/gdcmHeader.h doesn't make unnecessary reference to
1583 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1585 * src/gdcm*.[cxx|h] :
1586 - to allow compilation with gcc 3.x
1587 -- clean up of STL usage (added explicit usage of std::)
1588 -- small fixes on exceptions.
1589 Note: linking not tested !
1590 - clean of doxygen comments to avoid warnings at documentation
1592 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1593 dependent convertion).
1595 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1596 * Clean up of previous JPR garbage commit (not even commented in the
1598 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1599 - moved all jpeg related files from src to src/jpeg/libijg8, with
1600 addition/modification of Makefile.am and configure.in.
1601 - the testSuite is still brain damage (not guilty).
1603 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1604 * WrapVTK.py : modifications to get correctly vtk source files to
1606 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1607 (FileName -> Filename)
1609 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1610 * vtk/vtkGdcmReader.[cxx/h]:
1611 - UpdateProgress method should now be effective
1612 - removed the limitation on having only images loaded (as opposed
1614 - when building a stack of images/volume, a lesser number of
1615 gdcmHeader and gdcmFile instances should be used (hopefully
1616 accelerating things).
1617 - when building a stack of images/volumes, files which are not
1618 loadable (wrong path-filename, wrong permissions on existing file,
1619 or file not parsable by gdcm) are replaced with a black image
1620 in the stack (for the caller to notice the problem).
1622 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1623 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1625 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1626 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1627 between standard library (std) and vtk library (problems are found
1628 under Windows... thanks Windows !)
1630 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1631 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1633 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1635 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1636 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1638 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1639 * When compiling with distutils (see setup.py) the C++ compiler is
1640 called with different flags than the default ones (with automake).
1641 In order to fix all those warning, I compiled gdcm with the command
1642 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1643 and went for warning fixes:
1644 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1645 up from unused variables.
1646 - vtk/vtkGdcmReader.cxx: potential bug fix.
1647 * src/gdcmHeader.h: Doxygen warning cleanup
1649 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1650 * gdcmPython/gdcm.i:
1651 - typemaps correction to take into account the systematic replacement
1652 of "using namespace std" with std:: prefix e.g. std::list,
1653 std::string... (cf changes of 2003-05-21).
1654 - gdcmGlob global variable of type gdcmGlobal (defined in
1655 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1656 exported to Python a as cvar.
1657 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1658 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1659 gdcmDictSet.GetPubDictTagNames() and
1660 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1661 C++ static methods).
1662 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1663 with the above changes.
1665 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1666 * setup.py, manifest.in : bug fix under linux
1668 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1669 * Modification of setup.py to compile vtk part too. Then, we have 2
1670 wrappers which must work with same distutils. For that, we have a
1671 generic distutils in distusiltsWrapping.py ; with :
1672 - build_extWrap class to wrap generically all extensions,
1673 - ExtensionWrap base class for all wrapping extension that contains
1675 - Wrapper interface which wrap sources
1676 + In WrapSwig.py we have extension and wrapper for Swig
1677 + In WrapVTK.py we have extension and wrapper for VTK
1678 * MANIFEST.in : modifications to consider vtk directory and new python
1679 files for compilation
1681 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1682 * Added python wrappers of vtkGdcmReader vtk class (see the
1683 source in vtk/vtkGdcmReader.cxx) :
1684 - vtk/Makefile.am now builds a library
1685 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1686 python library (as opposed to _gdcm.so wich are the python
1687 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1688 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1690 - configure.in has an additional flag --enable-vtk that needs
1691 to be set to enable compilation of vtk related code, that is:
1692 + vtk/vtkGdcmReader.so and
1693 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1694 + gdcmPython/vtkgdcmPython.so (see above)
1695 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1696 be read when compressed or when HighBit + 1 != BitsStored),
1697 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1698 the usage of the python wrapper of vtkGdcmReader vtk class.
1699 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1700 * src/*.[h] all occurences of stl classes are now prefixed with
1701 std::, and all occurences of "using namespace std;" where removed.
1702 This is to avoid pollution of global namespace in included files.
1703 Apparently vtk does not avoid this pitfall: when using both
1704 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1705 collision of various stl members (principally cout...).
1706 * gdcmPython/testSuite.py now cleanly removes temprory generated
1708 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1709 comply with above changes)
1711 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1712 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1713 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1714 vtk data structure (an image Flip was required).
1715 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1716 * cosmetic changes in documentation.
1718 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1719 * src/gdcmHeader.cxx: the constructor no longer exits when an
1720 unexisting file is given as argument.
1721 * The subdirectory Data (containing all the images used for the
1722 test suite) is not part of this repository anymore. A new module
1723 containing those images is now available at
1724 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1725 with the name gdcmData.
1726 All the python scripts (including the package initialisation file
1727 gdcmPython/__init__.py) were adapated to take this change into
1728 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1730 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1731 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1732 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1733 demo of the usage of this class.
1734 Compilation of this vtk part is only done when using the --enable-vtk
1735 at configure (or autogen.sh) stage.
1737 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1738 * More memory link related corrections and documentation fixes.
1740 - maximum info is obtained with a command of the form:
1741 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1742 --show-reachable=yes PrintHeader
1743 - the remaining reachable blocks seem to come from the STL
1744 allocation scheme through the usage of map and list. It looks
1745 like this memory cannot be freed but it is not a memory leak
1746 (in fact further invocation to the STL would recollect the
1747 unused memory allthough it cannot explicitely be freed).
1748 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1749 of displaying an image parsed with gdcm and displayed with VTK.
1750 Note: some images don't seem to work e.g.
1751 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1752 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1753 Allthough this weakens the semantics, it is a ditch attempt to
1754 make gdcm more thread friendly.
1756 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1757 * Memory link hunt (by using valgrind through the command
1758 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1759 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1760 gdcmHeader::_dicom_vr.
1761 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1762 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1764 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1766 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1767 * src/Makefile.am now exports all the necessary include files at
1771 * UpdateGroupLength replaced by new one
1774 * UpdateGroupLength re-written using H-Table
1775 (named UpdateGroupLengthNew untill checks are over)
1777 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1778 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1779 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1781 - gdcmHeader::GetPubElValSet removed.
1782 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1783 UpdateGroupLength, WriteElements, Write.
1784 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1785 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1786 carried the same semantics.
1787 - src/gdcmHeaderIdo.cxx changed accordingly.
1788 - gdcmFile::WriteBase now regroups all the codes from previous
1789 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1790 - enum FileType moved to gdcmCommon.h
1791 * src/gdcmHeader.cxx AddDefault trashed
1792 * gdcmGetXSize added
1793 * getimageDataSize now calls gdcmGetXSize
1794 * Test/*.cxx changed to agree with above changes
1796 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1797 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1798 (to avoid double call by end user).
1799 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1800 by end user, since gdcmHeader::gdcmHeader now handles it.
1802 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1803 * gdcm/Doc many doxygen changes:
1804 - Doxyfile now has two different versions, DoxyfileUsers that generates
1805 the html.users end users oriented documentation and
1806 DoxyfileDeveloppers that generates the html.developper developper
1807 oriented documentation.
1808 - README changed accordingly
1809 - requirement.txt removed (old design info moved to TODO).
1810 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1811 DoxyMainPage.txt, DoxyPython.txt provide more information.
1812 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1813 be updated by simply regenerating the docs with doxygen and copying
1814 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1815 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1816 all the tests in the form "if (<map>.count() >1)" were removed.
1817 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1818 ill-formed documentation sections.
1819 * src/gdcmHeader.cxx: ditto
1821 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1822 * setup.py fixed for un*x (needed macro for stdint.h)
1823 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1824 un*ces with sh-utils test utility.
1825 * gdcmPython/demo/test.py renamed to PrintHeader.py
1826 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1827 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1828 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1829 * src/gdcm*.cxx JPR's bad inclusion fixed.
1831 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1832 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1833 * gdcmPython/demo/test.py changed accordingly.
1835 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1836 * gdcmPython/Makefile.am fixed linking against libstdc++
1837 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1838 * Swig subdir (historical tests of swig version 1.3.17++) removed
1839 * Test/testChangeEntete.cxx some lines commented out in order to make
1841 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1842 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1844 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1845 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1846 hence the user doesn't need this explicit call.
1847 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1848 i.e. LoadElements() call removed.
1849 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1850 - src/Makefile.am declares the proper flag for g++.
1851 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1852 for adding user defined new tags.
1853 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1854 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1855 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1857 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1858 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1859 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1860 src/Makefile.am : the project should properly compile and install
1861 with the autotools, included the python wrappers part.
1862 * gdcm.spec.in : added a spec file for RPM packaging.
1864 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1865 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1867 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1868 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1869 to exported to the environement (see gdcmPython/testSuite.py
1871 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1872 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1873 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1874 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1875 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1877 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1878 * gdcmPython/__init__.py doesn't crash anymore when running in
1879 in InstallMode or PreInstallMode but with an environement given
1880 value of GDCM_DICT_PATH.
1881 * src/gdcmDictSet.[cxx/h] coding style.
1883 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1884 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1885 * src/gdcm.h general comments moved to TODO, and README
1886 * src/gdcm.h should now be seen as a user commodity (including it
1887 should suffice to fully use gdcm). It is nowhere including within
1888 any of the kernel files src/*.cxx and src/*.h.
1890 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1891 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1892 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1894 * src/gdcm*.cxx only include their corresponding include file
1895 (as opposed to gdcm.h)
1896 * gdcmPython/gdcm.i changed accordingly
1897 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1898 the autogen.sh generated "make snapshot" command to work.
1899 * autogen.sh removed history related references to crea package.
1901 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1902 * distutilsSwigCPlusPlus.py work around some swig portability
1905 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1906 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1907 was done in a last ditch attempt to get setup.py _really_
1908 operationnal. The python/gdcmPython layaout add the advantage
1909 of hidding away the python related distutils specific files
1910 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1911 Alas, the src directory was out of scope (i.e. it's relative
1912 position to setup.py was ../src) which made things impossible to
1913 handle (see previous version of python/setup.py). Crossing fingers...
1915 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1916 * python/setup.py now works on Un*x. (harder than I thougth)
1917 * python/distutilsSwigCPlusPlus.py can now have include files
1918 among the list of sources.
1920 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1921 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1922 * modifications in MSVC projects
1924 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1925 * As stated by the first lines of Test/ExceptionAndPython/README, it
1926 looks like we can move back to original usage of exception within
1927 src/gdcm* and hence remove the errno stuff that was introduced
1928 as a quick and dirty fixture of this problem (added to the TODO).
1929 * Doc/Doxyfile configuration file for Doxygen and corresponding
1930 README file for usage added.
1931 * Test/testWrite.cxx added. This new test comes from a split of
1932 test.cxx that is now reverted to its original purpous i.e.
1933 testing the proper parsing of a Dicom related file.
1934 testWrite.cxx concentrates on testing the IO part of gdcm.
1935 * Test/bug1.cxx (containing a bug on WIn32) added.
1936 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1937 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1938 whose purpose is to publish the content of the TagNames of the
1939 Dicom public dictionnary were not accessible without an
1940 instance of class gdcmHeader.
1941 - those methods are now static methods of gdcmDictSet and hence
1942 require no instances at all to be invocated.
1943 - within gdcmDictSet this change required to change some method
1944 to class methods (i.e. are now static) among which SetDictPath
1945 (renamed to BuildDictPath) and LoadDefaultPubDict.
1946 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1947 the above changes by calling the new method classes of gdcmDictSet.
1948 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1949 the above to be effective.
1950 * python/gdcmPython: in order to wrap properly the above changes
1951 for Python, swig version now needs to be > 1.3.17.
1952 * python/gdcmPython/Makefile fixed to adapt itself to new
1953 configure/make shema introduced by Johan Montagnat (thanks for the
1954 contribution). Alas this Makefile cannot be turned into a proper
1955 Makefile.am without some heavy changes in the configure.in
1956 (for python dectection).
1957 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1958 now avoids publishing the empty entries.
1960 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1961 * python/setup.py : bug fix concerning install under windows
1962 ExtraPath reused :-P
1963 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1965 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1966 * Dicts/dicomV3.dic : remove double spaces !!!
1967 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1968 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1971 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1972 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1973 method. Doxygenation.
1974 * src/gdcm.h clean up of JPR spurious comments.
1976 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1977 * python/distutilsSwigCPlusPlus.py now properly collects the
1978 shadow classes generated by "swig -c++" (gdcm.py in our case)
1979 when using "python setup.py install".
1980 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1981 reexports the working classes.
1982 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1983 by the classical C errno scheme. This is to prevent an obscure
1984 behavior of the python wrappers when importing wxPython.wx prior
1985 to gdcmPython (which ended up in an abort call). An illustration
1986 of this oddity can be found in the Test/ExceptionAndPython
1987 subdir (see the README file). This problem probably due to
1988 an combination of g++ and dynamic loading.
1989 * added Test/ExceptionAndPython (see above)
1991 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1992 * Changed the layout of the python part to avoid bloating main
1993 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1994 i.e. the distutils arsenal. All the python related stuff is
1995 again in a python subdir, but the package itself is now in
1997 * setup.py was cleaned up:
1998 - pythonIncludePath removed
1999 - python setup.py bdist target is now functional.
2000 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2001 collision with other packages). gdcmPython/demo/*.py changed
2004 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2005 * python subdir moved to gdcmPython (preparation of distutils packaging).
2006 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2007 distutils installer is operational.
2008 * - gdcmPython/__init__.py now properly loads the swig generated
2009 shadow classes (from gdcm.py).
2010 - gdcmPython/demo/*.py changed to import the package gdcmPython
2011 instead of gdcmPython/demo/load.py.
2012 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2014 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2015 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2016 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2017 entries within the associated public Dicom dictionary resp. the same
2018 information but sorted by the fourth field (PAT, IMG, DIR) of the
2020 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2021 are now in the "???" group.
2022 - python/gdcm.i changed accordingly,
2023 - python/demo/printGroupedPublicDict.py added, that gives an example
2024 of the above new functionalities in Python.
2026 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2027 * src/gdcm.h, gdcmHeader.cxx:
2028 - historic references to glib's g_malloc and g_free (#defined)
2029 were definitively removed.
2030 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2031 * src/gdcmElValSet.cxx:
2032 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2033 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2034 - GetElValue(string) renamed to GetElValueByName.
2035 - Added GetElementByName(string).
2036 * src/gdcmHeader.cxx: added
2037 - GetPubElValRepByNumber(guint16, guint16)
2038 - GetPubElValRepByName(string)
2039 - GetShaElValRepByNumber(guint16, guint16)
2040 - GetShaElValRepByName(string)
2041 - GetShaElValByNumber(guint16, guint16)
2042 - GetShaElValRepByName(string)
2043 - GetElValRepByNumber(guint16, guint16)
2044 - GetElValRepByName(string)
2045 - GetElValByNumber(guint16, guint16)
2046 - GetElValRepByName(string)
2047 * Doc/requirements.txt added.
2049 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2050 * Test/Makefile building now depends on the one of libgdcm.so
2051 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2052 pixel data) aware which enables finding the address (offset) of
2053 the pixel data of JPEG encoded DICOM files. This leaves only a single
2054 file in the testSuite whose pixel data address (offset) is unknown.
2055 * python/testSuite.py changed accordingly.
2057 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2058 * VC++ has some strong limitations when working with the STL, as stated
2059 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2060 "Also note that some STL containers (map, set, queue, list, deque)
2061 cannot be exported. [...]
2062 Some STL classes contain nested classes. These classes can not
2064 This is caused by a designed limitation that once a template
2065 class is instantiated, it can not be re-instantiated and
2067 Since our usage of map<> is ubiquitous in gdcm, this "designed
2068 limitation" of VC++ is a pitfall.
2069 Hence the Python wrappers of gdcm cannot be incrementally linked
2070 against the c++ dynamic library. The dirty but only workaround is
2071 to forget about incremental link of dynamic libraries and to generate
2072 the Python wrappers library with the inclusions of the underlying C++
2074 The following modifications concern this matter on Win32/VC++:
2075 - wrapping python correct with standalone wrapped dll (don't use separate
2076 dll under windows !!!!)
2077 - python21_d debug mode enabled (ask Frog how to use it :-)
2078 - NO problem with having an STL member of class for example string in C++
2079 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2080 - Python test of dcmlib in Python is ok under windows on a large set
2082 * removed glib references
2083 * typedef's inserted in gdcm.i for correct swig type management
2085 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2086 * python/demo/*.py load.py extracted from test.py. Added explore.py
2087 that only displays required tags and testAll.py that parses all
2088 the files of the testsuite without using unittest.
2089 * python/testSuite.py other additional test on new files added.
2090 * Data/* new test files added accordingly to the testSuite.
2091 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2092 the vr in the file differs from the one of the dictionary.
2094 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2095 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2096 values, but limits itself to values which are below a user specified
2097 size (by default 1024 bytes).
2098 * python/gdcm.i : elements not loaded (because their size is above the
2099 user specified treshold) are exported with their TagKey as key of the
2100 python dictionary. This enables the testsuite to make some checks
2101 on the unloaded elements (since we have their offset and size).
2102 * python/testSuite.py
2103 - now tests for the existence and proper value of the pixel data
2104 - two new examples added.
2105 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2107 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2108 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2109 aware. See the strategy comments in gdcmHeader::FindeLength().
2110 * Test/test.cxx now accepts a filename as first argument.
2111 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2112 * python/testSuite.py changed to integrate test on above files.
2114 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2115 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2116 the vr was also RET.
2117 * python/testSuite.py more tests added.
2119 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2120 * python/testSuite.py unittest test suite added (uses Data)
2121 * Data/* dcm and acr files for the test suite.
2122 * glib dependance removed from un*x version. We now use ISO C99
2123 7.18 Integer types (see stdint.h)
2124 - python/Makefile, src/Makefile src/gdcm.h
2125 * src/ when an explicit vr (like dicom files) suddenly poped an
2126 implicit element we use to mark the underlying DictEntry of the
2127 concerned ElValue with "Implicit". This strategy was damageable
2128 too the public or provite dictionaries, since some of their vr
2129 would be changed. Since Header::FindLength heavily relies on the
2130 detection by Header::FindVR of falsely explicit elements, I
2131 added an extra ImplicitVr member to ElValue (boolean).
2132 The rest of the changes we the necessary adaptations.
2134 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2135 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2137 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2139 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2140 * Adaptation for porting to VC++:
2142 o forced to use std namespace (for string to be known)
2143 o all class use __declspec export style on WIN32
2144 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2145 (in stdlib.h on Win32 but in std:: for gcc)
2146 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2147 variable GDCM_DICT_PATH.
2148 * src/gdcmHeader.cxx verbose comments made discrete.
2150 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2151 * python/gdcm.i: added a typemap that converts a C++ hashing table
2152 to native Python dictionary.
2153 * python/demo/test.py:
2154 - now uses the native dictionary for exploration of gdcmHeader.
2155 - takes an optional filename argument (the file to parse).
2156 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2157 PubElVals hashing table.
2158 * Dicts/dicomV3.dic removed error prone trailing spaces.
2160 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2161 * Python wrapping process moved away from src/Makefile to
2162 newly created python/Makefile (as well as gdcm.i)
2163 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2164 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2165 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2166 from the environement variable GDCM_DICT_PATH (when existing).
2167 * src/gdcmDict::GetTag bug fix.
2169 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2170 * Straightforward temporary fixes for swig to build the python wrappers.
2171 src/Makefile now has a python working entry [by working we mean
2172 that we can import de shadow classes without errors].
2174 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2175 * hashtest.cxx removed (since allready in Test)
2176 * src/gdcmlib.h renamed to src/gdcm.h
2177 * src/dcm.i renamed to src/gdcm.i
2178 * src/Makefile prepared for python wrapping
2180 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2181 * src/gdcmHeader.cxx :
2182 - Parsing of header is now separated from loading of element values
2183 (see gdcmHeader::LoadElements).
2184 - general clean up of hopefully all file access (creation of
2185 ReadInt16 and ReadInt32)
2187 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2188 * src/gdcmHeader.cxx :
2189 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2191 - SetLgrElem renamed to SetLength
2192 - GetLgrElem renamed to GetLength
2193 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2194 * src/gdcmElValSet.cxx fixed both GetElValue methods
2195 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2196 due to IdoDude was cleaned out.
2198 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2199 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2200 concentrates on finding the value representation (when it exists).
2201 RecupLgr now only finds the element value length, and it avoids
2202 returning the unecessary skL (skipped length).
2203 Also, offsetCourant was simply removed (with taille_fich) since
2204 it was redundant with the File position internals (by using
2205 ftell and fseek). This also made skL (see above in RecupLgr) usage
2207 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2208 on the libido specificities which are handled through class
2210 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2213 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2214 * Truckload of changes. Parsing of header is barely functional
2215 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2217 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2218 * src/gdcmHeader.cxx many addons of low level methods
2220 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2221 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2222 and _IdDcmSWAP_LONG.
2224 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2225 * This corresponds to all the changes decided at the meeting of
2226 May 23 2002. Needless to say we are running late...