1 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
3 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
4 discussed (plus I didn't like having a 2000 lines patch not commited)
6 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
7 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
8 * CLEANUP_ROUND (14) for gdcmPixelConvert
9 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
10 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
11 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
13 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
14 anymore and hence avoids storing a copy of PixelConvert::Decompressed
15 into File::Pixel_Data.
17 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
18 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
19 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
20 * CLEANUP_ROUND (13) for gdcmPixelConvert
21 Substituted File::ParsePixelData() with PixelConvert::Print() new
23 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
24 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
25 method to those classes.
26 - src/gdcmFile.[cxx|h]:
27 -- Added a ::Print() method.
28 -- PixelConverter is now a reference instead of a member.
29 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
30 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
32 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
33 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
34 collaboration diagram and inheritance diagram should be generated with
36 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
37 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
38 pointlessly wrapped (see
39 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
40 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
41 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
42 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
43 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
44 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
45 -- File::Initialise: PixelConverter setup moved away to
46 PixelConverter::GrabInformationsFromHeader()
47 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
48 interpretation moved away to PixelConverter::BuildRGBImage()
50 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
51 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
52 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
54 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
55 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
56 displayed on Win32 when a brutal abort() occurs (because of uncatched
57 exception). See TODO new entry of this commit for more on this.
58 * TODO added new entry.
59 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
60 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
61 - HandleColor is no longer called from gdcmFile.cxx
62 - gdcmPixelConvert.cxx clean up on method arguments and internal
63 variable names for semantical coherence.
65 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
66 * Finished lossless transition, not only do we now read all lossless jpeg
67 images, without the need of the Cornwell lib, but we do read them properly now
68 * To reduce code (well to avoid code duplication), I defined a common place
69 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
70 redefine symbols. This is not prefect but this the best solution I found for a
71 compilation time jpeg option.
73 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
74 * Update jpeg ijg lib to support lossless jpeg implementation
75 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
77 * Also added a special copyright for dcmtk since we use their bugfixes.
80 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
81 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
82 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
83 matters, as stated in warning note at begining of %include section).
84 * src/gdcmDicomDir*.[cxx|h]: coding style
85 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
86 * src/gdcmJpeg8.cxx: doxygen fix.
87 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
88 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
89 from File:: to PixelConvert::.
91 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
92 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
93 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
94 - more code moved away from File:: to PixelConvert::
95 - fat setup of PixelConverter set in place in File::Initialise.
97 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
98 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
99 namespace at the file system level. So now you should convert your examples
101 gdcmHeader -> gdcm::Header
102 It would be nice if people keep in mind to no open the namespace, since it
103 allows compilation on broken plateform which were defining common symbol in
104 the standart namespace (like LP, Unknown ...)
106 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
107 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
108 The JPEG fragments are now parsed at the same stage than the RLE
109 information. All code related to JPEG is now in gdcmPixelConvert:
110 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
111 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
112 export a gdcmFile:: method. Those are simply global functions
113 (for the time being this is better than having them attach to
114 either gdcmFile:: or gdcmPixelConvert::).
115 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
116 and stores the result in a gdcmJPEGFragmentsInfo.
117 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
118 code (among other stuff) moved away from gdcmFile:; to
121 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
122 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
123 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
124 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
125 clean up of RLE related code.
126 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
127 - src/gdcmRLE.cxx removed
128 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
129 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
130 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
131 * CLEANUP_ROUND (9) for gdcmPixelConvert
132 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
133 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
134 away from gdcmFile:: to gdcmPixelConvert::.
136 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
137 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
138 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
139 This is because Parse7Fe0 used to parse the pixels to compute the
140 length. This task was passed over to FindDocEntryLengthOB() a long
141 time ago, EXCEPT I had forgotten the OW case...
142 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
143 we just recylce the code for parsing RLE fragments and computing
145 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
146 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
147 with the retired Parse7Fe0().
148 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
149 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
151 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
152 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
153 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
154 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
155 - src/CMakeLists.txt: alphabetic order reodering + new entries.
156 * CLEANUP_ROUND (4) for gdcmPixelConvert
157 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
158 to return an unused length.
160 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
161 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
162 this should be cleanner from the plane view. The iostream are erally a pain
163 to use to do simple stuff.
165 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
166 * Redo the compilation of the ijg jpeg library. Now only one source is
167 necesseray. No need to rename file by hand what so ever. CMake handle the
168 copying of the file within different directory, configure header file to
169 modify some symbol. The only addition made to ijg wasd a mangle table so
170 that symbol are different wether we are within 8bits or 12bits.
172 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
173 * Added documentation of vtkgdcmReader on Website:
174 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
175 with it's binary name).
176 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
177 the Website to be more complete.
178 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
179 doxygenated documentation.
180 - Doc/DoxyVtkGdcmReaderExamples.txt added
181 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
182 DoxyVtkGdmReaderExamples.html )
183 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
184 * CLEANUP_ROUND (3) for gdcmPixelConvert
185 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
187 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
188 * CLEANUP_ROUND (2) for gdcmPixelConvert
189 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
191 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
192 * CLEANUP_ROUND for gdcmPixelConvert:
193 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
194 - src/gdcmPixelStuff[h|cxx] removed
195 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
196 - src/CMakeLists.txt changed accordingly
198 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
199 gdcmVersion.py moved to newly created ATTIC related
200 gdcmPython/SetupOldies/ directory.
201 * Autotools clean up:
202 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
203 - autogen.sh configure.in acinclude.m4 python.m4 removed
205 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
206 * src/*.cxx *.h Reference to License.htm fixed to License.html.
207 * Doc/CMakeLists.txt, doxygen.config.in: fix.
208 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
210 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
211 * TODO updated with Mathieu suggestions. I proposed a template for
212 describing TODO entries and used it for new entries.
213 * Added Doc/Website/CodingStyle.html, Developpers.html,
214 DeveloppersPython.html, GdcmDataCvs.html and
215 DownloadVersion0_1.html, DownloadVersion0_3.html.
216 * Some Doc/*.txt Doxygen files (which do not really concern the
217 documentation itself, but the website) moved to html and
218 placed in directory Doc/Website:
219 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
220 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
221 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
222 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
223 * CMakeLists.txt changed accordingly.
224 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
225 DeveloppersPython.html
226 * INSTALL nows refers to Doc/Website/Installation.html
228 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
229 * Added Doc/Website directory, that contains a first raw version
232 2004-09-23 Jean-Pierre Roux
233 * FIX In order not to be poluted any longer by casting problems,
234 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
235 we can now delete[] it safely
236 * VoidArea is now called BinArea (less confusing name),
237 and all the methods called ...VoidArea... are now ... BinArea...
238 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
240 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
241 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
242 clear) TagHT, which is an inherited member of gdcmElementSet. It is
243 up to the destructor of gdcmElementSet to clean up TagHt and it's
246 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * Test/CMakeLists.txt: update to follow gdcmData renamings.
248 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
250 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
251 * ENH: added some utility method that builds a flat dictionnary
252 holding all the Dicom entries contained in the recursive structure
253 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
255 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
256 BuildFlatHashTable() that build a flat dictionary.
257 - src/gdcmElementSet.h: added a new private GetTag() accessor.
258 gdcmDocument is now a friend of gdcmElementSet.
259 - src/gdcmElementSet.cxx: clean up.
260 - Example/FlatHashTablePrint.cxx added.
261 - Example/CmakeLists.txt changed accordingly
263 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
264 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
265 moved away from gdcmDocEntrySet (since this class is an abstract class
266 acting like an interface). SQDepthLevel and BaseTagKey are now
268 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
269 and associated accessors. Doxygenation of the class.
270 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
272 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
273 Use SQDepthLevel accessor instead. ::Print() adapted.
274 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
275 - src/gdcmDocument.cxx changed accordingly.
277 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
278 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
279 - The following is the doxygen comment of the typedef declaration
280 of gdcmagKey in src/gdcmCommon.h:
281 gdcmTagKey is made to old an "universal" (as in URL, Universal
282 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
283 A dicom tag allways has a group and an element, but a set of tags
284 embeded in various (optionally nested) sequences and sharing
285 the same group and element all share the same (group, element)
286 "identifier". Hence the (group, element) cannot be used as an
287 identifier (in gdcm we shall refer to a "TagKey") of a tag.
288 In order to construct a proper tag identifier (i.e. a key) we
289 consider the following definition of a TagKey:
290 - let Group, Element be the string representation of the
291 group and element dicom tag members,
292 - let ItemNumber be the string representation of the integer
293 index of the considered item number of a sequence,
294 Let the key of a tag embeded in a sequence, noted SeqTag, be
296 /ItemNumber#Group|Element
297 where "/", "#" and "|" are characters acting as separators.
298 Then the general form of a gdcmTagKey is given by:
299 Group|Element<SeqTag>
300 where <SeqTag> means NO or many instances of SeqTag.
301 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
304 but the gdcmTagKey of a tag "embeded" is the first item of
305 a sequence, itself nested in the third item of a sequence is the
307 0004|1220/2#0008|0082/0#0008|0090
308 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
309 order to hold the new sequence compatible key. Previously, the
310 GetKey() method would look in the underlying gdcmDictEntry.
311 - src/gdcmDocEntry.cxx:
312 -- constructor now copies the underlying DictEntry key, in the local
314 -- ::Print: displays the member Key, instead of the (group, element).
315 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
316 - src/gdcmDocEntrySet.h:xi
317 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
318 -- now has a new BaseTagKey member.
320 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
321 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
323 This poses the problem with the semantics of the following lines
324 LoadEntryVoidArea(0x0028,0x1201); // R LUT
325 LoadEntryVoidArea(0x0028,0x1202); // G LUT
326 LoadEntryVoidArea(0x0028,0x1203); // B LUT
327 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
328 to the long FIXME note for what the problem is. Nevertheless in
329 order to get things working the dicom dictionary was altered !
330 Please fix things urgently...
331 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
332 information), see above note on moving the member VoidArea. Nevertheless
333 the following entries previously correctly set as US are now inproperly
335 0028 1201 OW IMG Red Palette Color Lookup Table Data
336 0028 1202 OW IMG Green Palette Color Lookup Table Data
337 0028 1203 OW IMG Blue Palette Color Lookup Table Data
338 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
339 of gdcmDocEntry moved to gdcmSeqEntry.
340 * src/gdcmSeqEntry.cxx: STYLE.
342 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
343 * Test/TestAllEntryVerify.cxx minor fix and added comments.
345 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
346 * gdcmPython/testSuite.py: all the test suite in python is now moved
347 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
348 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
349 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
351 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
352 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
353 to avoid inclusion recursion until STL is reached.
354 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
355 mecanism. errno.h is not included in gdcm anymore.
356 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
357 (gdcmFormatError now inherits from gdcmFormatUnexpected).
359 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
360 gdcmData/TestAllEntryVerifyReference.txt
361 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
362 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
363 exception_on_error parameter.
364 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
365 - vtk/vtkGdcmReader.cxx changed accordingly,
366 - Example/*.cxx and Test/*.cxx changed accordingly.
368 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
369 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
370 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
371 enable_sequences removed from gdcmHeader constructor and dependencies.
372 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
373 * gdcmPython/demo/PrintHeader.py: dummy fix.
374 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
375 skip_shadow removed from gdcmHeader constructor and dependencies.
376 * Example/*.cxx and Test/*.cxx changed accordingly.
378 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
379 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
380 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
382 2004-07-21 Jean-Pierre Roux
383 * FIX Now, Parsing and Printing a DICOMDIR do work!
384 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
386 2004-07-20 Jean-Pierre Roux
387 * FIX Some brain damaged headers have Zero-Lenght fields
388 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
390 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
391 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
392 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
393 variable (instance of gdcmDebug) by a definition macro, and the instance
394 is now in static in the gdcmDebug class
395 * src/gdcmSQItem.h : (FIXME) remove an undefined method
396 * Test/PrintAllDocument.cxx : bug fix in the result of the test
398 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
399 * WARNING: ctest now depends more tightly on gdcmData. You should
400 check out gdcmData properly for things to run smoothly...
401 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
402 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
403 we need the pixels not be loaded in order to use the ValEntry
404 that displays position and size).
405 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
406 This is a C++ based equivalent of gdcmPython/testSuite.py that should
407 be deprecated. If you have any doubts about the advantages of a
408 modern scripting language (read Python) versus grass root C++ (i.e.
409 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
410 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
411 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
412 Anyhow, consider documenting the gdcmData images in
413 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
415 * Test/CMakeLists.txt:
416 - now uses TestAllEntryVerify.cxx
417 - specific comments on oldACR00001.ima (now renamed in gdcmData
418 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
419 gdcmData/TestAllEntryVerifyReference.txt
422 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
423 * src/*.[h|cxx] : typedef clean up
424 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
425 - TagKey renamed to gdcmTagKey (for external usage)
426 - VRKey renamed to gdcmVRKey (for external usage)
427 - removal of typedef duplication.
428 - Removed all unecessary inline keyword from class inline definitions.
429 - Some method|function(void) declarations replaced with method|function().
430 * src/jpeg/libijg12/jdhuff12.c:
431 - printf polluting ctest removed.
432 - TAB removal for comminting
434 - TestAllReadCompareDicom.cxx: added a test that compares all the
435 images in gdcmDataImages.h with corresponding images in
436 gdcmData/BaselineDicom/. When baseline images are not present
437 this test creates them.
438 Note: we need to validate each reference image, but before that
439 I'd like to rename them with a more explicit name...
440 - CMakeLists.txt: changed accordingly.
441 * Example/*.cxx: examples now only include gdcm.h (as opposed to
442 including each header needed).
444 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
445 * Test/*.cxx and Example/*.cxx: moved some examples away from the
446 test suite to the Example directory. Are concerned:
451 - TestWriteSimple.cxx
452 * Test/CMakeLists.txt: added some comments on reasons for black listing
453 image gdcmData/oldACR00001.ima
455 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
456 * Test/CmakeList.txt: removed the following from black list (to be coherent
457 with removal from gdcmData):
458 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
459 - gdcm-MR-PHILIPS-16.dcm
461 Added the following because after last cvs update, they cause
462 ctest -R TestReadWriteReadCompare
464 - gdcm-MR-SIEMENS-16-1.acr
466 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
467 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
468 new comments in this file) we temporarily (sigh) move to a weaker
470 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
471 we don't need to black list the following images anymore:
472 - 8BitsUncompressedColor.dcm
474 - US-PAL-8-10x-echo.dcm
475 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
476 fixes and the beautified code ;-)
477 This fixes the bug introduced in version 1.42 (when beautifying)
478 that made the parsing of 8BitsRunLengthColor.dcm unproper.
479 Note: ctest was blind to this bug (this means we need to still
480 improve the test suite). The bug could be detected by using
481 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
483 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
484 and by displaying the (garbage) produced file temp.XDCM...
486 2004-06-29 Jean-Pierre Roux
487 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
488 - replace by uggly but working old code :-(
489 A lot of things should be OK again.
490 It's really urgent to have a test suite that *tests*,
491 to prevent Frog's beautifying sessions to break all the stuff
492 (twice, withing a fortnigh ...)
494 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
495 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
496 redundancy) to added Test/TestReadWriteReadCompare.cxx
497 * Test/CmakeList.txt: because the compare test of
498 Test/TestReadWriteReadCompare.cxx fails, the following images are
499 black listed: - 8BitsUncompressedColor.dcm
501 - US-PAL-8-10x-echo.dcm
502 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
503 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
504 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
505 and ad-hoc kludge. This kludge is now removed, and on encountering
506 such an image (OB field brain damaged) we set errno. Then in
507 ::FindDocLength() we "fix" the length as being ALL what remains
508 in the file (until EOF). We then proceed, hoping for the best...
509 This fixes a SegFault in ShowDicom when trying to write such an
511 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
512 (because TestWriteRead breaks on it, after a non conformal commit?).
513 ctest now runs properly, except for MakeDicomDir (which was allways
514 broken) and the Python related stuff (still not fixed).
516 2004-06-24 Jean-Pierre Roux
517 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
518 FIX : Test/TestReadWrite now iterates on all the file names
519 (instead of infinite loop)
520 ENH : Test/TestWriteRead now iterates on all the file names
522 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
523 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
525 2004-06-24 Jean-Pierre Roux
526 FIX : - now Write drops LUT Descriptors and LUTs (if any)
527 when SamplesPerPixel =3
528 - now Write is no longer confused by
529 'BitsAllocated = 12" and 'BitsStored=12"
530 - "UN" value representation Elements are now written correctly
531 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
532 ENH : - now gdcmHeader has its own Write methods
533 (in order to split the job that has not to be done
536 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
537 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
538 loop on the same image until memory went out.
539 Note: this means we still have gobs of memory loss in PrintDocument
540 * src/gdcmDocument.cxx: fixes problem on parsing on file
541 gdcmData/16BitsJpegLosslessGrayScale.dcm.
543 2004-06-24 Jean-Pierre Roux
544 FIX : Write - All the Sequences and Sequence Item are now written
545 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
546 is added a the end, when necessary.
547 - A lot of brain-damaged images, that were read correctly are
548 now written correctly
549 - length compatible BinEntry are now loaded correctly
550 (even for odd groups)
551 Note : only Explicit Value Representation was checked.
552 (question : is implicit VR really necessary for gdcm ?)
554 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
555 * DEVELOPPER: added a proposition of coding style.
556 * src/gdcmDocEntry.h: removed every inline declaration (for test of
559 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
560 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
561 Use the gdcmDocEntry::Print() and Write() instead.
562 * src/gdcmDocument.cxx: bug fix.
564 2004-06-22 Jean-Pierre Roux
565 FIX : gdcmDocument.cxx
566 - Now we do recognize the JpegLossLess format (there was a misstyping in
567 code 'beautyfication' :-(
568 - Now we automaticaticaly load the Luts, if any
570 2004-06-22 Jean-Pierre Roux
571 In order : to write Sequences, whatever their imbrication level,
572 : to allow user to create his own Sequences
573 a lot of modif where necessary (adding, moving, or virtualising methods)
575 WARNING : save your own sources *before* cvs up !
578 ADD virtual void Write(FILE *fp, FileType filetype);
581 ADD virtual void Write(FILE *fp, FileType filetype);
582 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
585 ADD virtual void Write (FILE *fp, FileType filetype)=0;
586 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
587 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
588 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
589 ADD std::string GetEntryByName(TagName name);
590 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
592 std::string vr = "unkn",
593 std::string fourth = "unkn",
594 std::string name = "unkn");
595 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
596 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
597 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
598 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
599 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
600 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
601 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
602 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
605 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
606 ADD virtual std::string GetEntryByName (TagName tagName);
607 ADD virtual std::string GetEntryVRByName (TagName tagName);
608 REM virtual bool Write(FILE *, FileType);
609 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
610 FILE *_fp, FileType type);
611 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
612 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
613 REM virtual bool WriteEntries(FILE *_fp,FileType type);
614 REM virtual std::string GetEntryByName (std::string tagName);
615 REM virtual std::string GetEntryVRByName (std::string tagName);
616 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
617 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
618 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
620 std::string vr = "unkn",
621 std::string fourth = "unkn",
622 std::string name = "unkn");
623 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
624 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
625 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
626 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
629 ADD virtual void Write(FILE *fp, FileType filetype);
632 ADD virtual void Write(FILE *fp,FileType filetype);
635 ADD virtual void Write(FILE *fp, FileType filetype);
636 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
637 REM std::string GetEntryByNumber(guint16 group, guint16 element);
638 REM std::string GetEntryByName(TagName name);
641 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
643 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
644 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
645 The default constructor invoked by the line
646 gdcmHeader *f1 = new gdcmHeader( header );
647 was gdcmHeader::gdcmHeader(bool) instead of the expected
648 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
649 Hence the parsing wasn't executed... See also below.
650 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
651 as explicit constructor didn't do the trick to fix the above problem.
652 Could anyone explain why ?
653 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
654 properly calls gdcmValEntry::Print() (that was weed out from
655 code related to gdcmBinEntry).
657 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
658 * In order to fix memory leaks:
659 - Test/TestWriteSimple.cxx: added cleaning of free store through
661 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
662 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
663 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
664 (through the call to ::AddDicomDirMeta()) or the destructor
665 would crash when deleting uninitialized ::metaElems].
666 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
667 - src/gdcmDocument.cxx:
668 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
670 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
671 was causing memory leaks.
672 - src/gdcmSQItem.cxx:
673 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
674 cleanly handled with polymophism: sorry but my milage is low).
675 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
676 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
677 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
678 This avoids SegFaulting.
679 - src/gdcmSQItem.h: coding style.
681 - Test/TestWriteSimple still severely sucks. The output image content
682 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
683 damaged when displayed with vtkgdcmViewer.
684 - on memory leaks: TestWriteSimple leaks really less (see entry
685 of 2004-06-18 in Changelog file for the call to valgrind).
686 - on segfaults: ctest now passes all the tests but one (no more
688 * Erroneous leading white fix:
689 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
690 white[s] (as opposed to from >> xxx, that removes it [them].
691 - src/gdcmTS.cxx: ditto.
692 - gdcmPython/testSuite.py: dirty related kludge removed.
693 * src/*: remaining references to gdcmParser removed.
694 * src/*[cxx|h]: added copy[way]left header.
697 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
698 * In order to fix writing of dicom files:
699 - Test/TestWriteSimple.cxx: a simpler example of writing.
700 - Test/CMakeLists.txt changed accordingly.
701 - src/gdcmDocument.cxx:
702 -- The destructor now recursilvely removes potential sequences.
703 -- Bug fix in ::IsJPEG2000()
704 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
705 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
707 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
708 to only declared) and build on top of
709 ::GetDocEntryByNumber(guint16, guint16).
710 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
711 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
712 for usage in destructor and treatement of promotion in
713 ::ReplaceOrCreateByNumber().
714 - src/gdcmSQItem.cxx: destructor should better handle his job.
715 Test/TestWriteSimple now runs (or at least it DOES something).
716 * We can now start hutting memory links. A good starting point is:
717 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
718 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
719 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
721 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
722 * Valgrind note: after Mathieu Malaterre teached me how to read
723 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
725 Using gcc, you can force the STL to use malloc and to free memory as
726 soon as possible by globally disabling memory caching.
727 With 3.2.2 and later, you should export the environment variable
728 GLIBCPP_FORCE_NEW before running your program.
729 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
730 simply vanish (it is still not clear to me, whether this means that
731 STL std::string leaks or if valgrind believes it leaks...).
732 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
733 running bin/gdcmTests makeDicomDir):
734 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
735 - Test/makeDicomDir.cxx now properly traps empty lists and returns
737 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
738 SegFaulting (I drowned in DicomDir related code when trying to
739 understand why the list is empty...).
740 * src/gdcmDocument.h: first BSD license header try.
741 * Doc/License.txt added.
743 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
744 * src/gdcmDocument.[h|cxx]:
745 - Clean up of the Transfer related predicates. They are now all based
746 on new method isGivenTransferSyntax, that (should) handle properly
748 - general clean up, simplification, and coding style.
749 - Specific clean up of Parse7FE0() (umproperly named actually).
750 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
752 2004-06-14 Jean-Pierre Roux
754 - fix the display of Sequence Delimitor (SQDepthLevel pb)
755 - fix the display of SQItem ordinal number
756 - add the GetSQItemByOrdinalNumber method
757 - remove some useless never written private methods
759 2004-06-14 Jean-Pierre Roux
761 - adding a constructor taking a gdcmDocEntry as an input param
762 - ReplaceOrCreateByNumber now returns :
763 a gdcmBinEntry * if a Binary (void *) value is passed as a param
764 a gdcmValEntry * if a string value is passed as a param
766 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
767 according to the param type (no longer sets a gdcmDocEntry)
768 - GetValEntryByNumber, GetBinEntryByNumber added
769 - NewValEntryByNumber and NewBinEntryByNumber added
771 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
773 - GetSQItemNumber and SetSQItemNumber added, to provide
774 a (relative) Item identier inside a given Sequence
775 \warning : some pb remaining around this number
777 - AddEntry now takes the Item Number as a param
779 - adding a constructor taking a gdcmDocEntry as an input param
781 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
782 * Memory leak hunt with the following command:
783 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
784 --show-reachable=yes gdcmTests PrintDocument
785 It looks like many (all?) leaks are due to the STL (or a bad usage
786 of the STL. The lines producing the leaks now have a comment with
787 a "MEMORY LEAK" tag: you can retrieve them with
788 grep "MEMORY LEAK" src/*
789 Here are two typical examples which I can't help fixing:
794 char * test = "babo";
795 name = test; //// <--- valgrind detects 960 bytes lost in
796 //// call to std::string::operator=(char const*)
797 name.clear(); //// Doesn't help !
805 std::cout << "Type a bunch of characters followed by RETURN: ";
806 getline(std::cin, line); //// <--- valgrind dectects a loss
807 //// of 1320 bytes in call to
808 /// std::basic_istream<>& std::getline<>
814 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
815 * src/gdcmHeader.[cxx|h]:
816 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
817 and related, moved away to gdcmDocument.
818 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
819 the corresponding protected accessors of inherited class
820 gdcmDocument, removed ! As a consequence gdcmFile had to be
821 declared friend of class gdcmDocument (see below).
822 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
823 - Clean up of undefined or unused methods.
824 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
825 account the changes to gdcmHeader.h).
826 * src/gdcmDocument.h:
827 - gdcmFile is now a friend class (in order to take into account the
828 changes to gdcmHeader.h).
829 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
830 (see changes to gdcmHeader.h).
831 - Accessors (reading on the form GetEntry*) are now public.
832 - Clean up of undefined or unused methods.
833 * src/gdcmDocument.cxx:
834 - adaptation to changes to gdcmDocument.h
835 - ::OpenFile now writes a verbose message when file cannot be opened.
836 - some std::string properly set to VRKey
837 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
838 references to gdcmDocument.
839 * Test/TestFindTags.cxx: changed accordingly to above changes.
840 * gdcmPython/testSuite.py: adapted to renaming of acr files in
841 cvs repository gdcmData.
843 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
844 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
845 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
846 conflicts with gdcmValEntry::voidArea.
847 * src/gdcmValEntry.cxx: unmatching comment wiped out.
848 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
849 Value representation between StringRepresentable and BinaryRepresentable.
850 * src/gdcmDocument.cxx:
851 - method ParseDES: proper indentation restored and usage of
852 gdcmVR::IsVROfGdcmStringRepresentable wired in.
853 - method LoadDocEntry: the fingerprint left in the SetValue() of
854 unloaded entries (length > MaxSizeLoadEntry) had curiously been
855 removed. Reverting to previous code segment with the proper
856 dynamic_cast< gdcmValEntry* >.
857 Note: this was (partially) breaking the python test suite
858 (gdcmPython/testSuite.py) that made usage of the above
859 fingerprint to check presence of "Pixel Data".
860 * src/gdcmDocEntry.h: coding style.
861 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
862 now taken into account.
863 * gdcmPython/gdcm.i: adaptation to the new internal representation
864 of gdcm (exit gdcmParser, hello gdcmDocument).
865 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
867 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
868 anymore, but instead prints the loaded Python dictionary.
869 * .... alas, the python testSuite is still broken.
871 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
872 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
874 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
875 * src/gdcmUtil.h : export methods
877 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
878 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
880 * Initial addition of automatic python testing
881 * Initial addition of automatic image comparison
883 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
884 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
885 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
887 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
888 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
889 * Test/ShowDicom.cxx : bug fix for msvc compilation
890 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
892 2004-05-04 Jean-Pierre Roux
893 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
894 new concepts (and new classes) :
895 a 'gdcmDocument' is composed of a set of Doc Entries, that are
896 - elementary gdcmDocEntries (former gdcmHeaderEntries)
897 - Sequence Doc Entries (gdcmSeqEntries)
898 a Sequence is composed of Items.
899 Each item is a set of Doc Entries (this is recursive)
900 The non uniqueness of the 'Dicom tag' is due to this recursivity
901 (never taken into account)
902 Our unability to add a new 'entry' in the header
903 at the proper location (neither in the H-Table (map or multimap),
904 nor in the Chained List is also due to this recursivity.
905 Don't try, right now, to use/modify/compile these new sources :
907 We just commit all the stuff, 'as is', in order not to loose it.
909 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
910 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
912 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
913 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
914 file prefix (SetFilePrefix)
916 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
917 * Add a new test: ShowDicom, for now this is just the c++ version of
918 checkRead.sh, later it will be able to compare the image read against a
920 * Replace the DEBUG on the stack with a global entry in cmake interface:
921 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
923 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
924 * Add an example subdir, with a real example on how to read + write a
927 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
928 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
929 * Doc/CMakeLists.txt: the main page is now properly differentiated
930 between the developper and user version.
931 * Doc/doxygen.config.in: dropped search related obsolete flags
932 * src/gdcmParser.h, gdcmHeader.h: doxygenation
934 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
935 * DEVELOPPER: added some helpfull comments for compile/test/install
938 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
939 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
940 src directory, now generated in the build dir.
941 2. Tests as mentionned smarter
943 4. Add a new method in gdcmDict that return the PubDict by name
944 this is interesting for 3rd party lib like ITK,
945 where we could set the institution name / patient name...
947 * ENH: 1. Now the test suite is working for real
948 2. All binaries are now output in the gdcm-bin directory
949 (this was not true before)
951 2004-04-28 Jean-Pierre Roux
952 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
953 SeQuence indented printing of Dicom Header.
954 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
955 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
956 Computation of SQDepthLevel is now part of gdcmHeader constructor
957 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
958 tree-like structure of a Dicom Header.
959 * FIX Test code cleaning
961 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
962 * ENH: Adding automatic testing
963 1. Need a DartConfig.cmake to submit to public
964 2. Add a test driver gdcmTest.cxx
965 3. gdcmTestMain, an helper for the main test driver gdcmTest
966 4. Files in Test don't have a main anymore, this becomes interesting
967 when we add more and more tests, thus dsw don't have to load
969 * ENH: Adding a GDCM_DATA_ROOT for testing
970 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
971 one file instead of seven + some small cleanup
973 2004-04-22 Jean-Pierre Roux
974 * ENH Minor changes to the Print() methods.
975 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
976 Header printing. Example given with :
977 > PrintHeader fileName 2 new
978 (SQ based tree-like structure still to be done for the Header ...)
980 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
981 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
982 1. I have added some unsigned where needed
983 2. Some function parameter not used -> (void)
984 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
985 4. g++ don't like character '\' in comment
986 5. #define jpeg_create_decompress jCreaDecompress
987 this really need to be fixed
988 6. virtualize destructor of gdcmObject ... leakage
989 7. sscanf(g->first.c_str(),"%x",&gr_bid);
990 this also really need to be fixed
991 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
992 remove compression file
993 (as we only do decompression, right ?)
994 * ENH: Change malloc/calloc/free with c++ equivalent
996 2004-04-21 Jean-Pierre Roux
997 * FIX gdcmHeaderHelper::GetXSpacing
998 when a single value is found (bug ?), xpacing is now
999 defaulted to yspacing
1001 2004-04-19 Jean-Pierre Roux
1002 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1003 * ENH add parameters :
1004 bool exception_on_error = false,
1005 bool enable_sequences = false,
1006 bool ignore_shadow = false
1007 to the gdcmFile constructors to be full gdcmParser compliant
1008 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1009 to allow reading of PAPYRUS 3.0 files
1011 2004-04-06 Jean-Pierre Roux
1012 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1014 2004-04-02 Jean-Pierre Roux
1015 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1016 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1017 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1019 2004-03-30 Jean-Pierre Roux
1020 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1021 for ACR file, written out as DICOM files (hope so...)
1023 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1024 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1025 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1026 moved to base class gdcmParser and only the specialisation is kept
1028 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1029 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1030 already does the job.
1031 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1032 (to be consistent with gdcmParser::WriteEntries).
1034 2004-03-30 Benoit Regrain
1035 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1036 upate of the object's instance. It's passed to 2 in the unfavorable
1037 case : one in the ExecuteInformation, one in the ExecuteData
1039 2004-03-29 Jean-Pierre Roux
1040 * ENH : Check on file type to be written moved
1041 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1042 * FIX : gdcmObject::ResetBoundaries now stops properly
1043 when end-of-list is reached
1044 : gdcmVersion modified (as Benoit Regrain asked)
1046 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1047 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1048 * src/gdcmUtil.cxx: added forgotten iostream include.
1049 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1050 equivalent to ExplicitVR in existing code).
1052 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1053 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1054 now contains all the gdcmGlobal related code.
1055 * minor coding style and doxygenation changes.
1057 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1059 now contains all the Debug related code.
1060 * minor clean-up of includes in src/*.cxx
1061 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1062 CreateCleanString) removed.
1063 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1064 * Doc/DoxyMainPageUser.txt added.
1065 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1066 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1067 src/gdcmDirList.cxx)
1069 2004-03-24 Jean-Pierre Roux
1070 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1072 2004-03-23 Jean-Pierre Roux
1073 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1074 big endian made volumes
1075 * ENH Now gdcmParser constructor and destructor are protected to forbid
1076 end user to instanciate class gdcmParser
1077 (only gdcmHeader and gdcmDicomDir are meaningfull)
1079 2004-03-22 Benoit Regrain
1080 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1081 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1082 gdcmSerie to gdcmDicomDirSerie
1084 2004-03-19 Jean-Pierre Roux
1085 * ENH Now the tree-like structure describing a DICOMDIR comming from
1086 an already existing DICOMDIR file is consistent with
1087 the home-made tree-like structure build ex-nihilo
1088 or build from the files held (recursively) in a Directory
1089 functions gdcmDicomDir::CheckBoundaries()
1090 gdcmObject::SetBoundaries() added
1092 2004-03-17 Jean-Pierre Roux
1093 * REM (Eric Boix bug) : removal of meaningless
1094 gdcmDicomDirImage::NewImage function.
1095 * FIX now file names and directory name are written properly in the
1097 * FIX now gdcmDicomDir constructor may be call without any trick
1100 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1101 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1102 of gdcmDicomDirImage::NewImage as empty function.
1104 2004-02-28 Jean-Pierre Roux
1105 * ENH add gdcmDicomDir:NewPatient
1106 add gdcmDicomDirPatient:NewStudy
1107 add gdcmDicomDirStudy:NewSerie
1108 add gdcmDicomDirSerie:NewImage
1109 to allow making gdcDicomDir object.
1110 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1111 (as opposite to the gdcmHeader chained list)
1113 2004-02-11 Benoit Regrain
1114 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1115 when using from python
1117 2004-02-10 Benoit Regrain
1118 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1119 * FIX : in gdcmDicomDir when the directory is empty
1120 * ENH : add callback and methods to get the progression of dicomDir
1123 2004-02-06 Jean-Pierre Roux
1124 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1125 - GDCM_META added to gdcmDicomDirType
1126 - class gdcmMeta created
1127 * ENH : - A brief summary is now displayed at the beginning of
1128 'testDicomDir' to help disaster magnitude estimation
1129 * REM : Now useless Test/explDICOMDIR.cxx
1131 2004-02-05 Benoit Regrain
1132 * ENH : add methods in gdcmObject to get the hash table or the list of
1134 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1135 * FIX : wrapping python for TagHeaderEntryHT
1137 2004-02-04 Benoit Regrain
1138 * FIX : even length for some strings when writting the dicom dir
1139 * FIX : sort the images in the dicom dir
1140 * FIX : Bug fix for python use of dicom dir
1141 * ADD : a python demo
1143 2004-02-04 Jean-Pierre Roux
1144 * FIX : Final solution (?) for icone embedded images
1145 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1146 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1147 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1148 gdcmData/gdcm-MR-SIEMENS-16.acr1
1149 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1150 to make full checking easier
1152 2004-02-04 Benoit Regrain
1153 * FIX : WriteEntries : coding style & logic in parameters
1154 * FIX : Set the elements to create the DicomDir in a dictionary file
1156 2004-02-03 Benoit Regrain
1157 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1158 * gdcmDicomDir : add the load of directory
1159 * Bug fix and print add-on
1161 2004-02-03 Jean-Pierre Roux
1162 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1163 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1164 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1165 * FIX gdcmParser.cxx : 'group length' elements are now considered
1166 as integers, even for shadow groups, when file is Implicit VR
1168 2004-02-02 Jean-Pierre Roux
1169 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1171 of the last synonym :-(
1172 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1174 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1175 * FIX taking into account the possible 7fe0,0010 multiplicity
1176 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1177 to allow removal of references to 7fe0,0010, to deal with
1178 ACR-NEMA images, when 0028,0200 is meaningfull
1180 2004-01-31 Jean-Pierre Roux
1181 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1182 no longer writes 'Un' on disk
1183 * FIX SQ elements with actual length are now dealt with corectly
1184 * FIX gdcmFile::WriteBase make the difference, for color images, between
1185 the length (for Palette expanded images)
1186 and Raw Length (non expanded image + Palette)
1187 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1188 (that broke Write). Replaced by UL.
1189 Aware user will reload the field if he
1190 thinks it's necesssary
1192 2004-01-30 Jean-Pierre Roux
1193 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1194 when 'dirty Acr' is found, to be compliant with the new
1195 IsReadable() methods.
1197 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1198 (no DOUBLE images in kosher DICOM,
1199 but so usefull for people that miss them ;-)
1201 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1202 DICOMDIR related utilities (not checked as Windoze compliant)
1204 2004-01-28 Jean-Pierre Roux
1205 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1207 2004-01-27 Jean-Pierre Roux
1208 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1209 to allow skipping the shadow elements, to save memory space.
1210 The TRUE value for this param has to be used
1211 with a FALSE value for the 'enable_sequence' param.
1212 ('public elements' may be embedded in 'shadow Sequences')
1213 * gdcmHeader methods now deal with 'embedded icones images' in the header
1214 (even when an 'icone image sequence' is announced by the
1215 element (0x0088,0x0200), but there is NO icone at all ...
1217 * gdcmHeader sometimes Image Location value doesn't follow
1218 the supposed processor endianity (see gdcmData/cr172241.dcm).
1221 * gdcmHeader add the method
1222 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1223 to get *all* the Header Entries with the same tag.
1224 GetHeaderEntrySameName is probabely *useless*
1225 (no meaning : Name is *not* an identifier within the Dictionnary)
1227 2004-01-26 Benoit Regrain
1228 * Bug fix in the print of hexadecimal representations. Remove long fields
1229 in the print and add a third level of print to print them
1231 2004-01-23 Benoit Regrain
1232 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1233 * Bug fix on test suite after remove the strip made on not string fields
1234 * Split the IsReadable method between gdcmParser which test that the file
1235 is dicom and gdcmHeader which test that it's an image file
1237 2004-01-22 Benoit Regrain
1238 * DicomDir : clean code, add methods, set variables in protected or private
1239 * gdcmUtil : bug fix for the clean string method
1241 2004-01-19 Benoit Regrain
1242 * Add the use of shadow dictionaries
1243 * bug fix and coding style
1245 2004-01-19 Benoit Regrain
1246 * src/gdcmFile.cxx : bug fix concerning the close of file
1247 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1248 * Add the update of header entries using the shadow library
1250 2004-01-19 Benoit Regrain
1251 * removal of file gdcmHeader2.cxx
1252 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1253 inheriting from gdcmParser. This split is to prepare the integration
1254 of dicom dir parsing
1255 * bug fix under python
1257 2004-01-16 Jean-Pierre Roux
1258 * REM removal of class gdcmHeaderEntrySet
1259 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1260 * ADD add file gdcmHeader2.cxx
1261 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1263 2004-01-15 Benoit Regrain
1264 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1265 entries created while parsing the header. Thus, they will be destroyed
1266 when the gdcmDictSet will be destroyed
1267 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1270 2004-01-15 Benoit Regrain
1271 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1272 made a fatal error because of the memory release at the end of program.
1273 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1274 some memory and vtk seems to have some problems with that.
1275 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1277 2004-01-14 Benoit Regrain
1278 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1279 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1280 * src/*.[h|cxx] : make changes due to class name changes
1281 * gdcmPython/demo/*.py : bug fix due to method names
1283 2004-01-13 Benoit Regrain
1284 * src/*.[h|cxx] : coding style
1285 * vtk/*.[h|cxx] : coding style
1287 2004-01-13 Benoit Regrain
1288 * gdcmPython/testSuite.py : test the readable flag of file for tests
1289 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1290 It's lied to the stl compilation by MSVC (windows, always windows...)
1291 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1293 2004-01-12 Benoit Regrain
1294 * src/*.h : add comments
1295 * src/gdcmDictSet.h : set the method BuildDictPath in public
1296 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1297 directly setted in the source code
1298 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1301 2004-01-09 Benoit Regrain
1302 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1303 * setup.py : use a reference to gdcmVERSION
1305 2004-01-07 Benoit Regrain
1306 * Modification to compile with the distutils.
1309 2003-12-10 Benoit Regrain
1310 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1311 can use a gdcmHeaderHelper to load datas
1312 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1313 made in the source code
1315 2003-12-10 Benoit Regrain
1316 * Update Windows projects and .cvsignore files
1318 2003-11-12 Jean-Pierre Roux
1319 * ENH gdcmHeader constructor has one more parameter (default value : false)
1320 that allows the user to 'go inside' the SeQuences only
1322 gdcmElValSet:Print takes it into account
1324 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1325 * ENH: Update gdcmPython/CMakeLists
1326 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1327 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1329 2003-11-10 Jean-Pierre Roux
1330 * FIX : gdcmHeader::LoadElements is now based
1331 on the ListTag listElem member,
1332 not longer on the TagElValueHT tagHt member
1333 * ENH : PrintPubElVal shows (temporarily) both results,
1334 with the tagHt member and the listElem member.
1335 (it's easier to 'see' the problems when using Printheader)
1337 * FIX : old private member LgrElem is now splitted into
1338 ReadLength : Length actually found on disk (updated only
1339 if bug fixing is necessary), for internal
1341 UsableLength : Updated by FixFoundLength, to fix a bug
1342 or to allow Parser going on.
1343 Will allow to re-write a kosher header when a SeQuence
1344 with a length (not 0000) is found
1345 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1346 because gdcmElValSet::Add does not update ListElem
1349 2003-11-07 Jean-Pierre Roux
1350 * FIX misstyping in Transfert Syntax name table
1351 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1352 when they have an actual length (not 0000 nor FFFFF)
1353 (Nobody should care of it, but DICOMDIR explorers)
1355 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1356 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1358 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1359 * ENH: vtkGdcmReader now supports LUT !
1360 (vtkgdcmViewer for now is not able to use them though)
1362 2003-11-05 Jean-Pierre Roux
1363 * in testSuite.py : new files names for checking the package
1364 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1365 that returns the pixel area size to the *aware* (vtk) user
1366 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1368 2003-11-05 Benoit Regrain
1369 * in testSuite.py : Modify the rules for checking the paths
1370 : Explicit error messages
1371 * in __init__.py : Related modif
1373 2003-11-03 Jean-Pierre Roux
1374 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1375 to be used by aware (vtk) users that want to manage
1376 LUT (and no to turn the PALETTE image into an RGB pixels one)
1377 * GetPixelType now returns 8U for 24 Bits images
1378 (vtkGdcmReader compliant)
1380 2003-10-31 Jean-Pierre Roux
1381 * Removal of *all* gdcmData images and add them again
1382 in order to loose the 'history' of un-anonymised images
1384 2003-10-31 Jean-Pierre Roux
1385 * RMV : removal of useless jBitsInJsample.h
1386 for both 8 and 12 Bits JPEG Lossy Libraries
1388 2003-10-31 Jean-Pierre Roux
1389 * ENH : Add the functions gdcmFile::GetImageDataRaw
1390 gdcmFile::GetImageDataIntoVectorRaw
1391 that act as GetImageData and GetImageDataIntoVector
1392 except the making of an RGB Plane from Gray Plane + LUT
1393 Intended to aware (vtk) users who know how to manage
1396 GetLUTRGBA return a R,G,B,A LUT if any
1397 lgrTotaleRaw gives the 'Raw' length
1398 GetImageDataRaw returns the gray Plane
1399 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1400 (They stay Grey, just like with other Dicom viewers :-(
1402 2003-10-30 Jean-Pierre Roux
1403 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1405 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1406 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1407 being coherents dicom files.
1409 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1410 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1412 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1413 * ENH: Two steps is necessary to please VC++ compiler...
1414 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1415 * ENH: Add include dir to medcon lib
1416 * FIX: only one function is being exported for now !
1417 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1419 2003-10-29 Jean-Pierre Roux
1420 * adding gdcmHeader::GetLUTRGBA
1421 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1422 --> Mathieu, the modif u're waiting for is not yet committed
1423 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1425 2003-10-27 Jean-Pierre Roux
1426 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1427 00191113.dcm DermaColorLossLess.dcm
1428 MxTwinLossLess.dcm RadBWLossLess.dcm
1429 * ENH: For version prior to vtkImageViewer2 -r 1.19
1430 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1432 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1433 * Removal of ido stuff in CMakeLists.txt
1435 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1436 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1437 * FIX: remove a call to ->Modified ... see comments
1438 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1440 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1441 * FIX: Problem with path for libvtkgdcmPython
1442 * ENH: Try adding a search script for python site-package
1443 * RMV: Remove some file from medcon lib that are not necessary
1444 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1445 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1446 * FIX: More pragma disable fro VC++,
1447 I don't think I break something as it is also disable in VTK/ITK.
1448 But it fasten debug compilation time.
1450 2003-10-23 Jean-Pierre Roux
1451 * gdcm now deals with 16 Bits Run Length Encoded images
1452 (they are compressed as 2 planes images,
1453 one for the high Bytes, the other for low Bytes)
1455 2003-10-22 Jean-Pierre Roux
1456 * Now CheckRead takes into account :
1457 - the bugged 'Leonardo' Siemens images
1458 - the XA images, sent thru the burning VPRO station
1459 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1462 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1463 * FIX: When copying a Makefile.am to CMakeLists.txt
1464 one should remove the '\'
1466 2003-10-22 Jean-Pierre Roux
1467 * in gdcmData adding a bugged 'Leonardo' Siemens image
1468 (wrong lengths in header)
1469 OK with gdcm, KO with the other viewers :-)
1470 * add a GE dlx XA image, thru the VEPRO burning station
1473 2003-10-21 Jean-Pierre Roux
1474 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1475 for a brutal checking of vtkgdcmViewer compliance
1477 2003-10-21 Jean-Pierre Roux
1478 * add the files for 'xmedcon' Jpeg Lossless library
1479 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1481 2003-10-21 Jean-Pierre Roux
1482 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1484 2003-10-21 Jean-Pierre Roux
1485 * garbage Siemens 'Leonardo' images dealt with
1486 (the patch is easy to remove)
1487 * cosmetic changes to avoid warnings
1489 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1490 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1491 no need to press 'r' now.
1493 2003-10-20 Jean-Pierre Roux
1494 * upgrade of checkRead.sh checkWrite.sh according
1495 to new Jpeg Lossless decompressor
1496 * add US.3405.1.dcm, a genuine RGB medical file ...
1497 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1498 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1500 2003-10-15 Jean-Pierre Roux
1501 * general anonymisation in gdcmData
1502 * adding the 'color files' from
1503 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1504 * adding some well knowed bugged-header images
1505 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1506 waiting for their inclusion in Python testsuite
1508 2003-10-15 Jean-Pierre Roux
1509 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1510 no longer seg faults when file is not found
1512 2003-10-14 Jean-Pierre Roux
1513 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1516 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1517 * TODO: *.in file to genereate a UseGDCM later
1519 2003-10-14 Jean-Pierre Roux
1520 * Some supposed-to-be Dicom Images have no preamble.
1521 OpenFile takes it into account
1522 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1523 * Missing elements added in dicomV3.dic
1524 (just to be affraid : have a look at
1525 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1526 and do it again next year ;->
1528 2003-10-13 Jean-Pierre Roux
1529 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1530 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1531 But there are NOT. It's fixed !
1533 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1534 * FIX: "jpeglib.h" was not found on VC++
1535 * FIX: vtkgdcm was not being installed
1537 2003-10-10 Jean-Pierre Roux
1538 * ENH : OpenFile closes the file if it *really* doesn't look like
1539 an ACR-NEMA / DICOM one.
1540 * FIX : testWrite no longer writes an empty file if the source file
1541 is not gdcm Readable
1542 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1545 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1546 * FIX: CMake generate now documentation
1547 * ENH: out of source doc build !
1548 * ENH: Generate both user and dev documentation
1549 * ENH: Should work on windows too
1550 * ENH: Only one doxygen config.in file is needed
1551 * FIX: make install should be ok now on ùnix plateform
1552 * FIX: PATH to dictionary was wrong (missing /)
1553 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1555 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1556 * vtkGdcmReader is now able to read rgb dicom file.
1557 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1558 * added a gdcmViewer to vtk test, use mouse to control
1559 window level & window width
1561 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1562 * CMake-ification of gdcm, we have now two build system
1563 * FIX: on cygwin Wsock32 doesn't exist
1564 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1566 2003-10-06 Emanuel Ollart
1567 * FIX : compilation process wad broken.
1568 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1570 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1571 * change gdcmViewer -> vtkgdcmViewer
1572 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1574 2003-10-06 Jean-Pierre Roux
1575 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1576 ( e.g : well known GE images with a wrong elem length,
1577 : Philips MRI Images with a wrong Huffman table)
1578 * still to be done : allow the reading of bugged LEONARDO Siemens images
1580 2003-10-03 Jean-Pierre Roux
1581 * Odd length strings are padded with '\0' (not with spaces,
1582 to remain compliant with already defined strings,
1583 like Transfert Syntax UID and others)
1585 2003-10-03 Jean-Pierre Roux
1586 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1587 to allow displaying RGB images (not only by affim ;-)
1589 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1590 * vtkGdcmReader is now able to read rgb dicom file.
1591 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1593 2003-10-03 Jean-Pierre Roux
1594 * A few nasty patches to allow the reading of a lot of nasty images
1595 ( e.g : well known GE images with a wrong elem length,
1596 : Philips MRI Images with a wrong Huffman table)
1597 * still to be done : allow the reading of bugged LEONARDO Siemens images
1599 2003-10-03 Jean-Pierre Roux
1600 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1602 2003-10-03 Jean-Pierre Roux
1603 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1604 to allow displaying RGB images (not only by affim ;-)
1606 2003-10-03 Jean-Pierre Roux
1607 * gdcmFile::GetImageDataIntoVector now
1608 - deals with MultiFrames MultiFragments Run Length Encoded files
1609 - deals with YcBcR (YBR_FULL) files
1610 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1611 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1613 (no sample found :-(
1615 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1616 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1617 Two reasons: - clear things
1618 - third parties acces gdcm through header files, so won't
1619 suffer anymore VC++ complains
1621 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1622 * add argv[1] in testvtkGdcmReader.cxx
1625 2003-09-24 Jean-Pierre Roux
1626 * The lines are now eigthy characters long.for
1627 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1629 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1630 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1631 char* to std::string. Thus, the use of strdup becomes useless. (see
1632 previous commis of Malaterre)
1633 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1634 before the last Malaterre's commit.
1636 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1637 * This commit should fix the Debug building under VC++, the problem
1638 was mainly a mixture of debug and release lib being loaded at startup.
1639 * I also remove a depency to a specific C function: strdup. Because I had
1640 to force the link to msvcrtd (whereas strdup is in libc).
1642 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1643 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1644 located in the gdcmCommon.h file. All use of reference of tha has been
1645 changed to now use the variable GDCM_UNFOUND.
1647 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1649 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1650 Dicom dictionary. The test suite can now be run again. Note:
1651 I'm note very happy with the " (RET)" changes. I believe this
1652 RETAINED comment should be dropped when parsing the dictionary.
1653 - PACKAGER corrected
1655 - AUTHORS updated and now in alphabetical order
1656 * Makefile.am now exports gdcm.dsw for Windoze users.
1658 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1659 * cygwin complains about missing std:: in subdir Test/
1661 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1662 * remove some methods that are now in gdcmHeaderHelper
1664 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1665 * vtkGdcmReader set spacing and origin correctly
1667 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1668 * Fix a few delete/delete[] mismatch
1670 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1671 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1672 interpretation to data given by gdcmHeader. For instance there are
1673 heuristics to get informations (look at different places).
1674 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1675 sorting DICOM images based on different strategies.
1676 * modified Makefiles accordingly.
1678 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1679 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1680 when building in debug mode
1681 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1682 src/win32/gdcmdll.dsp
1683 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1685 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1686 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1689 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1690 * src/win32/libgdcmjpeg12.dsp was not dos format
1691 * src/win32/libgdcmjpeg12.dsp :
1692 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1693 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1695 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1696 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1698 * src/gdcmFile.cxx : bug fix in affectation type
1699 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1700 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1701 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1702 symbols... future problem ?
1704 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1705 * src/win32/libgdcmijpeg12.dsp was missing
1706 * modified gdcm.dsw accordingly
1708 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1709 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1711 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1712 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1713 commit of JPR (before his hollidays to facilitate our work).
1714 * setup.py : bug fix in code. Modifications made while the last commit
1715 of JPR. The code hasn't been tested before the commit... it's so
1716 useless to make that (for best programmer that is JPR) !!!
1718 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1719 * tagged the current version as Version0_3 (i.e. version 0.3)
1721 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1722 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1723 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1724 * *.dsp : modifications to use new libgdcmijpeg8 library
1725 * setup.py : bug fix on VTKPATH variable
1726 * PACKAGER : adding all concerning windows
1728 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1729 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1731 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1732 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1733 test suite reported error.
1734 * PACKAGER file added (describes what a packager must do when
1735 packaging a new release).
1736 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1737 * configure.in: upgraded version number to 0.3.0
1738 * fixing build of rpm (through rpm -ta):
1739 - Doc/Makefile.am exports proper doxygen files
1740 - src/jpeg/libijg8/Makefile.am exports the include files.
1742 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1743 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1744 * src/gdcmHeader.h : formatting code
1746 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1747 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1748 We were obtaining error message from vtk. Now, creation of file list
1749 is made in an internal list to prevent this problem.
1750 Bug fix when output is empty.
1751 Bug fix in update of progress value. Previous commit for this was a bad
1753 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1755 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1756 * src/gdcmHeader.h : added method to get the file name
1757 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1758 files. Added method to remove all files on the input
1759 Added FIXME comment concerning the bad parsing of header made by
1760 ExecuteInformation method (in ExecuteData method)
1762 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1763 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1764 when using make instal.
1765 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1766 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1768 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1769 * setup.py : adding include dir of jpeg lib to compile all sources
1770 * */Win32/*.dsp : JPR fix for windows compilation
1772 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1773 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1775 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1776 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1778 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1779 * setup.py is again effective on un*x (takes into account the
1780 addon of the jpeg library)
1781 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1782 * Doc/Doxy* updated (includes above enhancements)
1783 * INSTALL now points to web documentation
1785 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1786 * src/gdcmHeader.h doesn't make unnecessary reference to
1788 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1790 * src/gdcm*.[cxx|h] :
1791 - to allow compilation with gcc 3.x
1792 -- clean up of STL usage (added explicit usage of std::)
1793 -- small fixes on exceptions.
1794 Note: linking not tested !
1795 - clean of doxygen comments to avoid warnings at documentation
1797 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1798 dependent convertion).
1800 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1801 * Clean up of previous JPR garbage commit (not even commented in the
1803 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1804 - moved all jpeg related files from src to src/jpeg/libijg8, with
1805 addition/modification of Makefile.am and configure.in.
1806 - the testSuite is still brain damage (not guilty).
1808 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1809 * WrapVTK.py : modifications to get correctly vtk source files to
1811 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1812 (FileName -> Filename)
1814 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1815 * vtk/vtkGdcmReader.[cxx/h]:
1816 - UpdateProgress method should now be effective
1817 - removed the limitation on having only images loaded (as opposed
1819 - when building a stack of images/volume, a lesser number of
1820 gdcmHeader and gdcmFile instances should be used (hopefully
1821 accelerating things).
1822 - when building a stack of images/volumes, files which are not
1823 loadable (wrong path-filename, wrong permissions on existing file,
1824 or file not parsable by gdcm) are replaced with a black image
1825 in the stack (for the caller to notice the problem).
1827 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1828 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1830 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1831 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1832 between standard library (std) and vtk library (problems are found
1833 under Windows... thanks Windows !)
1835 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1836 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1838 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1840 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1841 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1843 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1844 * When compiling with distutils (see setup.py) the C++ compiler is
1845 called with different flags than the default ones (with automake).
1846 In order to fix all those warning, I compiled gdcm with the command
1847 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1848 and went for warning fixes:
1849 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1850 up from unused variables.
1851 - vtk/vtkGdcmReader.cxx: potential bug fix.
1852 * src/gdcmHeader.h: Doxygen warning cleanup
1854 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1855 * gdcmPython/gdcm.i:
1856 - typemaps correction to take into account the systematic replacement
1857 of "using namespace std" with std:: prefix e.g. std::list,
1858 std::string... (cf changes of 2003-05-21).
1859 - gdcmGlob global variable of type gdcmGlobal (defined in
1860 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1861 exported to Python a as cvar.
1862 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1863 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1864 gdcmDictSet.GetPubDictTagNames() and
1865 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1866 C++ static methods).
1867 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1868 with the above changes.
1870 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1871 * setup.py, manifest.in : bug fix under linux
1873 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1874 * Modification of setup.py to compile vtk part too. Then, we have 2
1875 wrappers which must work with same distutils. For that, we have a
1876 generic distutils in distusiltsWrapping.py ; with :
1877 - build_extWrap class to wrap generically all extensions,
1878 - ExtensionWrap base class for all wrapping extension that contains
1880 - Wrapper interface which wrap sources
1881 + In WrapSwig.py we have extension and wrapper for Swig
1882 + In WrapVTK.py we have extension and wrapper for VTK
1883 * MANIFEST.in : modifications to consider vtk directory and new python
1884 files for compilation
1886 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1887 * Added python wrappers of vtkGdcmReader vtk class (see the
1888 source in vtk/vtkGdcmReader.cxx) :
1889 - vtk/Makefile.am now builds a library
1890 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1891 python library (as opposed to _gdcm.so wich are the python
1892 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1893 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1895 - configure.in has an additional flag --enable-vtk that needs
1896 to be set to enable compilation of vtk related code, that is:
1897 + vtk/vtkGdcmReader.so and
1898 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1899 + gdcmPython/vtkgdcmPython.so (see above)
1900 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1901 be read when compressed or when HighBit + 1 != BitsStored),
1902 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1903 the usage of the python wrapper of vtkGdcmReader vtk class.
1904 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1905 * src/*.[h] all occurences of stl classes are now prefixed with
1906 std::, and all occurences of "using namespace std;" where removed.
1907 This is to avoid pollution of global namespace in included files.
1908 Apparently vtk does not avoid this pitfall: when using both
1909 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1910 collision of various stl members (principally cout...).
1911 * gdcmPython/testSuite.py now cleanly removes temprory generated
1913 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1914 comply with above changes)
1916 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1917 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1918 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1919 vtk data structure (an image Flip was required).
1920 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1921 * cosmetic changes in documentation.
1923 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1924 * src/gdcmHeader.cxx: the constructor no longer exits when an
1925 unexisting file is given as argument.
1926 * The subdirectory Data (containing all the images used for the
1927 test suite) is not part of this repository anymore. A new module
1928 containing those images is now available at
1929 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1930 with the name gdcmData.
1931 All the python scripts (including the package initialisation file
1932 gdcmPython/__init__.py) were adapated to take this change into
1933 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1935 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1936 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1937 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1938 demo of the usage of this class.
1939 Compilation of this vtk part is only done when using the --enable-vtk
1940 at configure (or autogen.sh) stage.
1942 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1943 * More memory link related corrections and documentation fixes.
1945 - maximum info is obtained with a command of the form:
1946 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1947 --show-reachable=yes PrintHeader
1948 - the remaining reachable blocks seem to come from the STL
1949 allocation scheme through the usage of map and list. It looks
1950 like this memory cannot be freed but it is not a memory leak
1951 (in fact further invocation to the STL would recollect the
1952 unused memory allthough it cannot explicitely be freed).
1953 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1954 of displaying an image parsed with gdcm and displayed with VTK.
1955 Note: some images don't seem to work e.g.
1956 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1957 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1958 Allthough this weakens the semantics, it is a ditch attempt to
1959 make gdcm more thread friendly.
1961 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1962 * Memory link hunt (by using valgrind through the command
1963 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1964 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1965 gdcmHeader::_dicom_vr.
1966 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1967 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1969 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1971 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1972 * src/Makefile.am now exports all the necessary include files at
1976 * UpdateGroupLength replaced by new one
1979 * UpdateGroupLength re-written using H-Table
1980 (named UpdateGroupLengthNew untill checks are over)
1982 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1983 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1984 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1986 - gdcmHeader::GetPubElValSet removed.
1987 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1988 UpdateGroupLength, WriteElements, Write.
1989 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1990 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1991 carried the same semantics.
1992 - src/gdcmHeaderIdo.cxx changed accordingly.
1993 - gdcmFile::WriteBase now regroups all the codes from previous
1994 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1995 - enum FileType moved to gdcmCommon.h
1996 * src/gdcmHeader.cxx AddDefault trashed
1997 * gdcmGetXSize added
1998 * getimageDataSize now calls gdcmGetXSize
1999 * Test/*.cxx changed to agree with above changes
2001 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2002 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2003 (to avoid double call by end user).
2004 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2005 by end user, since gdcmHeader::gdcmHeader now handles it.
2007 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2008 * gdcm/Doc many doxygen changes:
2009 - Doxyfile now has two different versions, DoxyfileUsers that generates
2010 the html.users end users oriented documentation and
2011 DoxyfileDeveloppers that generates the html.developper developper
2012 oriented documentation.
2013 - README changed accordingly
2014 - requirement.txt removed (old design info moved to TODO).
2015 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2016 DoxyMainPage.txt, DoxyPython.txt provide more information.
2017 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2018 be updated by simply regenerating the docs with doxygen and copying
2019 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2020 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2021 all the tests in the form "if (<map>.count() >1)" were removed.
2022 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2023 ill-formed documentation sections.
2024 * src/gdcmHeader.cxx: ditto
2026 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2027 * setup.py fixed for un*x (needed macro for stdint.h)
2028 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2029 un*ces with sh-utils test utility.
2030 * gdcmPython/demo/test.py renamed to PrintHeader.py
2031 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2032 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2033 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2034 * src/gdcm*.cxx JPR's bad inclusion fixed.
2036 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2037 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2038 * gdcmPython/demo/test.py changed accordingly.
2040 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2041 * gdcmPython/Makefile.am fixed linking against libstdc++
2042 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2043 * Swig subdir (historical tests of swig version 1.3.17++) removed
2044 * Test/testChangeEntete.cxx some lines commented out in order to make
2046 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2047 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2049 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2050 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2051 hence the user doesn't need this explicit call.
2052 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2053 i.e. LoadElements() call removed.
2054 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2055 - src/Makefile.am declares the proper flag for g++.
2056 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2057 for adding user defined new tags.
2058 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2059 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2060 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2062 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2063 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2064 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2065 src/Makefile.am : the project should properly compile and install
2066 with the autotools, included the python wrappers part.
2067 * gdcm.spec.in : added a spec file for RPM packaging.
2069 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2070 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2072 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2073 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2074 to exported to the environement (see gdcmPython/testSuite.py
2076 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2077 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2078 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2079 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2080 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2082 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2083 * gdcmPython/__init__.py doesn't crash anymore when running in
2084 in InstallMode or PreInstallMode but with an environement given
2085 value of GDCM_DICT_PATH.
2086 * src/gdcmDictSet.[cxx/h] coding style.
2088 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2089 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2090 * src/gdcm.h general comments moved to TODO, and README
2091 * src/gdcm.h should now be seen as a user commodity (including it
2092 should suffice to fully use gdcm). It is nowhere including within
2093 any of the kernel files src/*.cxx and src/*.h.
2095 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2096 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2097 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2099 * src/gdcm*.cxx only include their corresponding include file
2100 (as opposed to gdcm.h)
2101 * gdcmPython/gdcm.i changed accordingly
2102 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2103 the autogen.sh generated "make snapshot" command to work.
2104 * autogen.sh removed history related references to crea package.
2106 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2107 * distutilsSwigCPlusPlus.py work around some swig portability
2110 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2111 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2112 was done in a last ditch attempt to get setup.py _really_
2113 operationnal. The python/gdcmPython layaout add the advantage
2114 of hidding away the python related distutils specific files
2115 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2116 Alas, the src directory was out of scope (i.e. it's relative
2117 position to setup.py was ../src) which made things impossible to
2118 handle (see previous version of python/setup.py). Crossing fingers...
2120 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2121 * python/setup.py now works on Un*x. (harder than I thougth)
2122 * python/distutilsSwigCPlusPlus.py can now have include files
2123 among the list of sources.
2125 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2126 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2127 * modifications in MSVC projects
2129 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2130 * As stated by the first lines of Test/ExceptionAndPython/README, it
2131 looks like we can move back to original usage of exception within
2132 src/gdcm* and hence remove the errno stuff that was introduced
2133 as a quick and dirty fixture of this problem (added to the TODO).
2134 * Doc/Doxyfile configuration file for Doxygen and corresponding
2135 README file for usage added.
2136 * Test/testWrite.cxx added. This new test comes from a split of
2137 test.cxx that is now reverted to its original purpous i.e.
2138 testing the proper parsing of a Dicom related file.
2139 testWrite.cxx concentrates on testing the IO part of gdcm.
2140 * Test/bug1.cxx (containing a bug on WIn32) added.
2141 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2142 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2143 whose purpose is to publish the content of the TagNames of the
2144 Dicom public dictionnary were not accessible without an
2145 instance of class gdcmHeader.
2146 - those methods are now static methods of gdcmDictSet and hence
2147 require no instances at all to be invocated.
2148 - within gdcmDictSet this change required to change some method
2149 to class methods (i.e. are now static) among which SetDictPath
2150 (renamed to BuildDictPath) and LoadDefaultPubDict.
2151 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2152 the above changes by calling the new method classes of gdcmDictSet.
2153 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2154 the above to be effective.
2155 * python/gdcmPython: in order to wrap properly the above changes
2156 for Python, swig version now needs to be > 1.3.17.
2157 * python/gdcmPython/Makefile fixed to adapt itself to new
2158 configure/make shema introduced by Johan Montagnat (thanks for the
2159 contribution). Alas this Makefile cannot be turned into a proper
2160 Makefile.am without some heavy changes in the configure.in
2161 (for python dectection).
2162 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2163 now avoids publishing the empty entries.
2165 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2166 * python/setup.py : bug fix concerning install under windows
2167 ExtraPath reused :-P
2168 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2170 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2171 * Dicts/dicomV3.dic : remove double spaces !!!
2172 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2173 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2176 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2177 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2178 method. Doxygenation.
2179 * src/gdcm.h clean up of JPR spurious comments.
2181 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2182 * python/distutilsSwigCPlusPlus.py now properly collects the
2183 shadow classes generated by "swig -c++" (gdcm.py in our case)
2184 when using "python setup.py install".
2185 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2186 reexports the working classes.
2187 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2188 by the classical C errno scheme. This is to prevent an obscure
2189 behavior of the python wrappers when importing wxPython.wx prior
2190 to gdcmPython (which ended up in an abort call). An illustration
2191 of this oddity can be found in the Test/ExceptionAndPython
2192 subdir (see the README file). This problem probably due to
2193 an combination of g++ and dynamic loading.
2194 * added Test/ExceptionAndPython (see above)
2196 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2197 * Changed the layout of the python part to avoid bloating main
2198 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2199 i.e. the distutils arsenal. All the python related stuff is
2200 again in a python subdir, but the package itself is now in
2202 * setup.py was cleaned up:
2203 - pythonIncludePath removed
2204 - python setup.py bdist target is now functional.
2205 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2206 collision with other packages). gdcmPython/demo/*.py changed
2209 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2210 * python subdir moved to gdcmPython (preparation of distutils packaging).
2211 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2212 distutils installer is operational.
2213 * - gdcmPython/__init__.py now properly loads the swig generated
2214 shadow classes (from gdcm.py).
2215 - gdcmPython/demo/*.py changed to import the package gdcmPython
2216 instead of gdcmPython/demo/load.py.
2217 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2219 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2220 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2221 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2222 entries within the associated public Dicom dictionary resp. the same
2223 information but sorted by the fourth field (PAT, IMG, DIR) of the
2225 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2226 are now in the "???" group.
2227 - python/gdcm.i changed accordingly,
2228 - python/demo/printGroupedPublicDict.py added, that gives an example
2229 of the above new functionalities in Python.
2231 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2232 * src/gdcm.h, gdcmHeader.cxx:
2233 - historic references to glib's g_malloc and g_free (#defined)
2234 were definitively removed.
2235 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2236 * src/gdcmElValSet.cxx:
2237 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2238 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2239 - GetElValue(string) renamed to GetElValueByName.
2240 - Added GetElementByName(string).
2241 * src/gdcmHeader.cxx: added
2242 - GetPubElValRepByNumber(guint16, guint16)
2243 - GetPubElValRepByName(string)
2244 - GetShaElValRepByNumber(guint16, guint16)
2245 - GetShaElValRepByName(string)
2246 - GetShaElValByNumber(guint16, guint16)
2247 - GetShaElValRepByName(string)
2248 - GetElValRepByNumber(guint16, guint16)
2249 - GetElValRepByName(string)
2250 - GetElValByNumber(guint16, guint16)
2251 - GetElValRepByName(string)
2252 * Doc/requirements.txt added.
2254 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2255 * Test/Makefile building now depends on the one of libgdcm.so
2256 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2257 pixel data) aware which enables finding the address (offset) of
2258 the pixel data of JPEG encoded DICOM files. This leaves only a single
2259 file in the testSuite whose pixel data address (offset) is unknown.
2260 * python/testSuite.py changed accordingly.
2262 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2263 * VC++ has some strong limitations when working with the STL, as stated
2264 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2265 "Also note that some STL containers (map, set, queue, list, deque)
2266 cannot be exported. [...]
2267 Some STL classes contain nested classes. These classes can not
2269 This is caused by a designed limitation that once a template
2270 class is instantiated, it can not be re-instantiated and
2272 Since our usage of map<> is ubiquitous in gdcm, this "designed
2273 limitation" of VC++ is a pitfall.
2274 Hence the Python wrappers of gdcm cannot be incrementally linked
2275 against the c++ dynamic library. The dirty but only workaround is
2276 to forget about incremental link of dynamic libraries and to generate
2277 the Python wrappers library with the inclusions of the underlying C++
2279 The following modifications concern this matter on Win32/VC++:
2280 - wrapping python correct with standalone wrapped dll (don't use separate
2281 dll under windows !!!!)
2282 - python21_d debug mode enabled (ask Frog how to use it :-)
2283 - NO problem with having an STL member of class for example string in C++
2284 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2285 - Python test of dcmlib in Python is ok under windows on a large set
2287 * removed glib references
2288 * typedef's inserted in gdcm.i for correct swig type management
2290 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2291 * python/demo/*.py load.py extracted from test.py. Added explore.py
2292 that only displays required tags and testAll.py that parses all
2293 the files of the testsuite without using unittest.
2294 * python/testSuite.py other additional test on new files added.
2295 * Data/* new test files added accordingly to the testSuite.
2296 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2297 the vr in the file differs from the one of the dictionary.
2299 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2300 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2301 values, but limits itself to values which are below a user specified
2302 size (by default 1024 bytes).
2303 * python/gdcm.i : elements not loaded (because their size is above the
2304 user specified treshold) are exported with their TagKey as key of the
2305 python dictionary. This enables the testsuite to make some checks
2306 on the unloaded elements (since we have their offset and size).
2307 * python/testSuite.py
2308 - now tests for the existence and proper value of the pixel data
2309 - two new examples added.
2310 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2312 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2313 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2314 aware. See the strategy comments in gdcmHeader::FindeLength().
2315 * Test/test.cxx now accepts a filename as first argument.
2316 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2317 * python/testSuite.py changed to integrate test on above files.
2319 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2320 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2321 the vr was also RET.
2322 * python/testSuite.py more tests added.
2324 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2325 * python/testSuite.py unittest test suite added (uses Data)
2326 * Data/* dcm and acr files for the test suite.
2327 * glib dependance removed from un*x version. We now use ISO C99
2328 7.18 Integer types (see stdint.h)
2329 - python/Makefile, src/Makefile src/gdcm.h
2330 * src/ when an explicit vr (like dicom files) suddenly poped an
2331 implicit element we use to mark the underlying DictEntry of the
2332 concerned ElValue with "Implicit". This strategy was damageable
2333 too the public or provite dictionaries, since some of their vr
2334 would be changed. Since Header::FindLength heavily relies on the
2335 detection by Header::FindVR of falsely explicit elements, I
2336 added an extra ImplicitVr member to ElValue (boolean).
2337 The rest of the changes we the necessary adaptations.
2339 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2340 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2342 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2344 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2345 * Adaptation for porting to VC++:
2347 o forced to use std namespace (for string to be known)
2348 o all class use __declspec export style on WIN32
2349 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2350 (in stdlib.h on Win32 but in std:: for gcc)
2351 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2352 variable GDCM_DICT_PATH.
2353 * src/gdcmHeader.cxx verbose comments made discrete.
2355 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2356 * python/gdcm.i: added a typemap that converts a C++ hashing table
2357 to native Python dictionary.
2358 * python/demo/test.py:
2359 - now uses the native dictionary for exploration of gdcmHeader.
2360 - takes an optional filename argument (the file to parse).
2361 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2362 PubElVals hashing table.
2363 * Dicts/dicomV3.dic removed error prone trailing spaces.
2365 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2366 * Python wrapping process moved away from src/Makefile to
2367 newly created python/Makefile (as well as gdcm.i)
2368 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2369 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2370 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2371 from the environement variable GDCM_DICT_PATH (when existing).
2372 * src/gdcmDict::GetTag bug fix.
2374 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2375 * Straightforward temporary fixes for swig to build the python wrappers.
2376 src/Makefile now has a python working entry [by working we mean
2377 that we can import de shadow classes without errors].
2379 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2380 * hashtest.cxx removed (since allready in Test)
2381 * src/gdcmlib.h renamed to src/gdcm.h
2382 * src/dcm.i renamed to src/gdcm.i
2383 * src/Makefile prepared for python wrapping
2385 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2386 * src/gdcmHeader.cxx :
2387 - Parsing of header is now separated from loading of element values
2388 (see gdcmHeader::LoadElements).
2389 - general clean up of hopefully all file access (creation of
2390 ReadInt16 and ReadInt32)
2392 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2393 * src/gdcmHeader.cxx :
2394 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2396 - SetLgrElem renamed to SetLength
2397 - GetLgrElem renamed to GetLength
2398 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2399 * src/gdcmElValSet.cxx fixed both GetElValue methods
2400 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2401 due to IdoDude was cleaned out.
2403 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2404 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2405 concentrates on finding the value representation (when it exists).
2406 RecupLgr now only finds the element value length, and it avoids
2407 returning the unecessary skL (skipped length).
2408 Also, offsetCourant was simply removed (with taille_fich) since
2409 it was redundant with the File position internals (by using
2410 ftell and fseek). This also made skL (see above in RecupLgr) usage
2412 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2413 on the libido specificities which are handled through class
2415 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2418 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2419 * Truckload of changes. Parsing of header is barely functional
2420 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2422 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2423 * src/gdcmHeader.cxx many addons of low level methods
2425 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2426 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2427 and _IdDcmSWAP_LONG.
2429 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2430 * This corresponds to all the changes decided at the meeting of
2431 May 23 2002. Needless to say we are running late...