1 * gdcmElValSet::SetElValueLengthByNumber IMNSHO should be trashed.
2 It's only purpose is a onliner substitute to calling GetElValueByNumber
3 and then SetLength. This only obfuscates the caller code more than
5 Besides the definition of gdcmElValSet::SetElValueLengthByNumber itself
6 it quite poor since it is a almost exact copy of
7 gdcmElValSet::GetElValueByNumber except for the returned code.
8 gdcmHeader::SetPubElValLengthByNumber (which is based on
9 gdcmElValSet::SetElValueLengthByNumber) is used nowhere...
10 * The declarations commented out and starting with "TODO Swig" (try
11 grep "TODO Swig" *.h) needed to be temporarily removed for swig to
12 proceed correctly (in fact problems appears at loading of _gdcm.[so/dll]).
13 So, simply uncomment the declaration once you provided the definition of
15 * As stated by the first lines of Test/ExceptionAndPython/README, it looks
16 like we can move back to the exceptions and remove the errno stuff from
18 * Fix the bug in Test/bug1.cxx (see first comment line): Win32 only.
19 * All (or at least many of) the methods of gdcmHeader whose only arguments
20 are an ElValue* (e.g. FindLength, FindVR, LoadElementValue...) can
21 be moved away to ElValue class on condition of transmitting the
22 gdcmHeader.fp attribute. This change should be considered since it
23 would allow those method to avoid artificial calls to ElValue::GetElement(),
25 * Eat leanding_trailing_whitespace (found in python/gdcmPython/gdcmi) should
26 be used when parsing the dictionary in C++ !
27 * Group length is not a unique tag in a file. Hence avoid putting it
28 in the element values dictionary without doing something smarter
29 (say, instead of storing the length store the group and the length
30 so we can related a length to a group).
31 * GetPubElValByNumber doit faire la difference entre chaine vide
32 et chaine pas touve''. Eventuellement raiser une exception ?
33 * gdcmHeader::LoadElements only loads the element whose length is
34 below the specified size. When accessing the value of such an element
35 the content is unfound ! Find a decent way of loading the value on
37 * fournir une method qui ne fait que lire les elements passes en arguments
38 sous forme d'une liste.
39 * gdcmHeader::CheckSwap() dans le cas ACR pas propre, degager tout de suite
40 si on a deduit que c'en est pas...
41 * python /usr/lib/python2.2/site-packages/DaVaW/demo/dvwDcmReader.py
42 and load image /home/frog/cvs/DCMlib/Data/CT-MONO2-16-ankle.dcm
43 will yield wrong coloring scheme as opposed to
44 affim filein=/home/frog/cvs/DCMlib/Data/CT-MONO2-16-ankle.dcm
45 * gdcmFile should implement the following:
47 WriteDicom.SetFileName("MyDicomFile.dcm");
48 string * AllTags = gdcmHeader.GetDcmTagNames();
49 WriteDicom.SetDcmTag(AllTags[5], "253");
50 WriteDicom.SetDcmTag("Patient Name", "bozo");
51 WriteDicom.SetDcmTag("Patient Name", "bozo");
52 WriteDicom.SetImageData(Image);
55 Anonymize(ostream& output) {
56 a = gdcmFile("toto1");
57 a.SetPubValueByName("Patient Name", "");
58 a.SetPubValueByName("Date", "");
59 a.SetPubValueByName("Study Date", "");