#include "gdcmValEntry.h"
////////////////////////////////////////////////////////////////////////////
-// Utility functions on strings for removing leading and trailing spaces
-void EatLeadingAndTrailingSpaces(std::string & s) {
- while ( s.length() && (s[0] == ' ') )
- s.erase(0,1);
- while ( s.length() && (s[s.length()-1] == ' ') )
- s.erase(s.length()-1, 1);
-}
-
+/// Refer (below) to the definition of multi-argument typemap
+/// %typemap(python, in)
+/// ( gdcm::DicomDir::Method*, void*, gdcm::DicomDir::Method*)
+/// for detail on gdcmPythonVoidFunc() and gdcmPythonVoidFuncArgDelete().
void gdcmPythonVoidFunc(void *arg)
{
PyObject *arglist, *result;
}
}
+/// This is required in order to avoid %including all the gdcm include files.
using namespace gdcm;
%}
-typedef unsigned short guint16;
-typedef unsigned int guint32;
-////////////////////////////////////////////////////////////////////////////
+
+/////////////////////// typemap section ////////////////////////////////////
+
+////////////////////////////////////////////////
+// Convert an STL list<> to a python native list
%typemap(out) std::list<std::string> * {
PyObject* NewItem = (PyObject*)0;
PyObject* NewList = PyList_New(0); // The result of this typemap
$result = NewList;
}
-////////////////////////////////////////////////////////////////////////////
-// Convert a c++ hash table in a python native dictionary
+//////////////////////////////////////////////////////////////////
+// Convert an STL map<> (hash table) to a python native dictionary
%typemap(out) std::map<std::string, std::list<std::string> > * {
PyObject* NewDict = PyDict_New(); // The result of this typemap
PyObject* NewKey = (PyObject*)0;
$result = NewDict;
}
-////////////////////////////////////////////////////////////////////////////
+/////////////////////////////////////////////////////////
// Convert a c++ hash table in a python native dictionary
%typemap(out) gdcm::TagDocEntryHT & {
PyObject* NewDict = PyDict_New(); // The result of this typemap
}
else
continue;
- EatLeadingAndTrailingSpaces(RawValue);
NewVal = PyString_FromString(RawValue.c_str());
PyDict_SetItem( NewDict, NewKey, NewVal);
}
$result = NewDict;
}
-////////////////////////////////////////////////////////////////////////////
+/////////////////////////////////////
%typemap(out) ListDicomDirPatient & {
PyObject* NewItem = (PyObject*)0;
$result = PyList_New(0); // The result of this typemap
}
////////////////////////////////////////////////////////////////////////////
-// Deals with function returning a C++ string.
-%typemap(python, in) (gdcm::Method *,void * =NULL,gdcm::Method * =NULL) {
+// Multi-argument typemap designed for wrapping the progress related methods
+// in order to control from an external application the computation of
+// a DicomDir object (see DicomDir::SetStartMethod*,
+// DicomDir::SetProgressMethod* and DicomDir::SetEndMethod*).
+// Motivation: since DicomDir parsing can be quite long, a GUI application
+// needs to display the avancement and potentially offer a
+// cancel method to the user (when this one feels things are
+// longer than expected).
+// Example of usage: refer to demo/DicomDirProgressMethod.py
+// Note: Uses gdcmPythonVoidFunc and gdcmPythonVoidFuncArgDelete defined
+// in the Swig verbatim section of this gdcm.i i.e. in the above section
+// enclosed within the %{ ... %} scope operator ).
+%typemap(python, in) ( gdcm::DicomDir::Method *,
+ void * = NULL,
+ gdcm::DicomDir::Method * = NULL )
+{
if($input!=Py_None)
{
Py_INCREF($input);
}
}
-
-////////////////////////////////////////////////////////////////////////////
-// Deals with function returning a C++ string.
+//////////////////// STL string versus Python str ////////////////////////
+// Convertion returning a C++ string.
%typemap(out) string, std::string {
$result = PyString_FromString(($1).c_str());
}
+// Convertion of incoming Python str to STL string
%typemap(python, in) const std::string, std::string
{
$1 = PyString_AsString($input);
}
+// Same convertion as above but references (since swig converts C++
+// refererences to pointers)
+%typemap(python, in) std::string const &
+{
+ $1 = new std::string( PyString_AsString( $input ) );
+}
+
+////////////////////////////////////////////////////////////////////////////
+// Because overloading and %rename don't work together (see below Note 1)
+// we need to ignore some methods (e.g. the overloaded default constructor).
+// The gdcm::Header class doesn't have any SetFilename method anyhow, and
+// this constructor is only used internaly (not from the API) so this is
+// not a big loss.
+%ignore gdcm::Header::Header();
+%ignore gdcm::DicomDir::DicomDir();
+
////////////////////////////////////////////////////////////////////////////
// Warning: Order matters !
%include "gdcmCommon.h"
-%include "gdcmRLEFramesInfo.h"
-%include "gdcmJPEGFragmentsInfo.h"
-%include "gdcmDictEntry.h"
-%include "gdcmDict.h"
-%include "gdcmDocEntry.h"
+//CLEANME %include "gdcmRLEFramesInfo.h"
+//CLEANME %include "gdcmJPEGFragmentsInfo.h"
+//CLEANME %include "gdcmDictEntry.h"
+//CLEANME %include "gdcmDict.h"
+//CLEANME %include "gdcmDocEntry.h"
%include "gdcmDocEntrySet.h"
-%include "gdcmElementSet.h"
-%include "gdcmDictSet.h"
-%include "gdcmTS.h"
-%include "gdcmVR.h"
-%include "gdcmSQItem.h"
+//CLEANME %include "gdcmElementSet.h"
+//CLEANME %include "gdcmDictSet.h"
+//CLEANME %include "gdcmTS.h"
+//CLEANME %include "gdcmVR.h"
+//CLEANME %include "gdcmSQItem.h"
%include "gdcmDicomDirElement.h"
%include "gdcmDicomDirObject.h"
%include "gdcmDicomDirImage.h"
%include "gdcmUtil.h"
%include "gdcmGlobal.h"
%include "gdcmDicomDir.h"
+
+////////////////////////////////////////////////////////////////////////////
+// Notes on swig and this file gdcm.i:
+//
+/////////////////////////////////////
+// Note 1: swig collision of method overloading and %typemap
+// Consider the following junk.i file:
+// %module junk
+// %{
+// #include <string>
+// #include <iostream>
+// void Junk(std::string const & bozo) { std::cout << bozo << std::endl; }
+// void Junk() { std::cout << "Renamed Junk()" << std::endl; }
+// %}
+//
+// %typemap(python, in) std::string const &
+// {
+// $1 = new std::string( PyString_AsString( $input ) );
+// }
+// void Junk();
+// void Junk(std::string const & bozo);
+//
+// that we compile on linux with:
+// swig -c++ -python junk.i
+// g++ -g -I/usr/include/python2.3/ -o junk_wrap.o -c junk_wrap.cxx
+// g++ junk_wrap.o -shared -g -o _junk.so -L/usr/lib/python2.3/config \
+// -lpython2.3
+// and invoque with:
+// python -c 'from junk import *; Junk("aaa") '
+// then we get the following unexpected (for novice) python TypeError:
+// TypeError: No matching function for overloaded 'Junk'
+//
+// This happens because the swig generated code (at least for python) does
+// the following two stage process:
+// 1/ first do a dynamic dispatch ON THE NUMBER OF ARGUMENTS of the overloaded
+// Junk function (the same happens with method of course). [Note that the
+// dispatch is NOT done on the type of the arguments].
+// 2/ second apply the typemap.
+// When the first dynamic dispatch is executed, the swig generated code
+// has no knowledge of the typemap, and thus expects a pointer to a std::string
+// type i.e. an argument to Junk of the form _p_std__int<address>. But this
+// is not what python handles to Junk ! An invocation of the form 'Junk("aaa")'
+// will make Python pass a PyString to swig (and this is precisely why we
+// wrote the typemap). And this will fail....
+/////////////////////////////////////