X-Git-Url: https://git.creatis.insa-lyon.fr/pubgit/?a=blobdiff_plain;f=ChangeLog;h=fd48dd6dcbc2cc0c1601d5128206c7b2073e605d;hb=8d10ccb6794a0f22234983990e2181a24625fbd8;hp=659f043315dd523ec0106b784d0f01564fc6eb29;hpb=96078bd0d3edf63c984fb5bd76ee5b57601872bd;p=gdcm.git diff --git a/ChangeLog b/ChangeLog index 659f0433..fd48dd6d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,273 @@ +2004-12-04 Benoit Regrain + * Bug fix due my last commit (compilation under Windows). + * Example/Volume2Dicom : bug fix in the file and reformatting source code + * src/gdcmFile.h : bug fix. Variable type and variable name had same name + +2004-12-03 Mathieu Malaterre + * Huge cleanup: + - Remove printf / sprintf + - include iostream AFTER gdcm so we don't get warnings + - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm + source + - Also remove tons of include from header files, hopefully this should + speeup the compilation time, since it was becoming a dog slow. + - Remove gdcm.h as it include way too many files and slow down compilation + (plus it is not up to date) + - remove 'using namespace std' this is BAD ! + +2004-12-03 Benoit Regrain + * Remove memory leaks on the DicomDir + * Remove some useless datas in DicomDirObject + * Add usefull methods in SQItem, to be complient withe the ElementSet + +2004-12-03 Benoit Regrain + * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType. + +2004-12-03 Benoit Regrain + * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the + future, with convertion) + * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data + and ImageDataSize values. Remove the method to get the PixelReadConverter + from the output of the class + +2004-12-03 Benoit Regrain + * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx] + +2004-12-02 Benoit Regrain + * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro + and vtkErrorMacro use. + * gdcmPython/gdcm.i : corrections to avoid warnings at compilation + +2004-12-02 Benoit Regrain + * Test/TestCopyDicom.cxx : the new dicom created is created empty, without + file name in input + * src/gdcmSeqEntry.cxx : bug fix in destruction of an element + * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed. + The string leaves only in the fonction. So when we make a .c_str(), we + get the pointeur on the first element, element that will be destroyed + immediately after thee instruction. + * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the + file has been opened : the test must be made on the content of the + pointer and not directly on the pointer ! + Code formatting + +2004-12-02 Benoit Regrain + * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now, + the python part recompiles + +2004-11-30 Benoit Regrain + * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer. + Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the + X session is killed (for my computer... it seems to not be identic on + all linux) + +2004-11-30 Benoit Regrain + * Test/ShowDicom.cxx : now can be used with an off-screen rendering to + avoid problems (otherwise, the difference test between the visible image + and the reference is incorrect. If the reference is greater than the + screen resolution, it's produce errors). + Can be used for only one image. Can be used with a visible flag. + * vtk/vtkGdcmReader.cxx : remove commented codes. + * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings + under windows at compilation + * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level + for grayscale images + * vtk/GdcmToBaseline.cxx : new program to easy create the reference image + +2004-11-30 Benoit Regrain + * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file + * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add + tests on the image size X, Y, Z + +2004-11-26 Benoit Regrain + * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File + * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent + between the class name and the file name + +2004-11-25 Benoit Regrain + * src/ : fix compilation warnings for the Write method (2 different + proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp' + fix compilation warnings for the gdcm::Document::TransferSyntaxStrings + variable... create a static method in gdcm::Document to access to + this variable content. + +2004-11-25 Benoit Regrain + * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header + file, to be accessed by other files (like gdcmFile). Remove commented + code. Move the change of the header to the gdcmFile, using the + DocEntryArchive + * src/gdcmHeader.[h|cxx] : the write is completely made in the Header. + To be sure of that (and simplify calls), the Write of the header now + gets a file name and not a file pointer (std::ifstream). + * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the + DocEntryArchive. Remove all open of the written file + +2004-11-25 Benoit Regrain + * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part + +2004-11-25 Benoit Regrain + * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it + * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of + the header. + * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and + some corresponding methods. Write correctly the file and check before + write + * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx, + TestAllReadCompareDicom.cxx : pass the write of images to RGB and test + is now on RGB datas (as before my last commit + * Example/PrintHeader.cxx, PrintFile.cxx : repad files. + +2004-11-24 Benoit Regrain + * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx : + Add a print information of the type of the entry + * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file. + It was in the gdcmFile, and all write have been regrouped + * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size. + Write correctly all dicom files (in decompressed mode only at this time) + * Test/ : test on files are now made using Raw datas and not color datas if + any. + * Example/PrintFile.cxx : add more printings + +2004-11-24 Benoit Regrain + * Amelioration of code, remove some code copy. For the loading of + BinEntry (in gdcmDocument), add the test to verify if the file is already + opened or not. + +2004-11-24 Benoit Regrain + * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary + remove a DocEntry in the header (push an empty DocEntry) + * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code + lines. Bug fix in the initialization of the PixelConvert and the + DocEntryArchive + * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to + use in TestCopyDicom (now this test can run under windows... but fails) + * Test/TestCopyDicom.cxx : amelioration of the test : + - test the pixels written + - add test points to quickly find where is the error + - can set a file name input and output in arguments + * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : + amelioration of the test output + +2004-11-23 Benoit Regrain + * src/gdcmDocEntryArchive.cxx : complete the print function, that prints + all replaced DocEntry's + * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas. + Now, each needed DocEntry to modify is duplicated, modified and inserted + to the header using DocEntryArchive. Thus, after save, we can restore the + header initial state. + +2004-11-22 Benoit Regrain + * src/gdcmFile.h : fix compilation errors on zorglub linuc computer + +2004-11-19 Benoit Regrain + * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't + correct to copy it. The DictEntry is specified at the DocEntry creation, + then, it musn't change in the time. + * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the + header correctly. At this time, the change is only made for the first + level of the Document. In the future, it might consider sequences. + The change is made by replacing a DocEntry by an other that is created + outside the class. The old value is kept. When we restore the header + status, the added DocEntry is deleted and replaced by the old value. + * src/gdcmElementSet.h : Set the DocEntryArchive like friend. + * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to + set the write type to explicit VR, implicit VR or ACR. Add methods to set + the write mode to native, decompressed or RGB (but not used at this time) + +2004-11-15 Benoit Regrain + * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm + * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks + +2004-11-15 Benoit Regrain + * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to + set a BinEntry, the binArea is copied (like to set a ValEntry, the string + is copied). + * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't + set because already copied when copying the BinEntry's of the header + * Test/TestAllReadCompareDicom.cxx : remove warnings + +2004-11-15 Benoit Regrain + * FIX : now, the DocEntries are all deleted in the gdcmElementSet. + Two problems appear when doing it : + - with the gdcmFile : when the GetImageData method is called, the pixels + are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these + datas (pixels). And each structure destruct the datas when it's + destructed. So we have two destructions for the same datas. To solve it, + a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the + datas or not. If it doesn't own datas, then they will not destroyed by + the gdcmBinEntry. + - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry + elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem. + Thus destruct the DicomDir* elements and the TagHT of the ElementSet + create a double destruction of the same DocEntry's. So, to solve it, + the TagHT is simply cleared and the DicomDir* elements are destroyed. + * TODO : add an entry concerning memory leaks in the DicomDir + +2004-11-15 Benoit Regrain + * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor + * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the + squeeze method + +2004-11-15 Benoit Regrain + * FIX: src/gdcmUtil.cxx : to compile with MSVC6 + * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object + after it have been deleted + +2004-11-16 Eric Boix + * FIX: src/* fix the doxygen warnings. + * src/gdcmVR.cxx: removed some redundant tests (e.g. LO) + * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[] + was erroneously defined with a size of 15 instead of 16. [many thanks + to Jean Michel Rouet for pointing out this bug]. + +2004-11-15 Mathieu Malaterre + 1. Finish merging JMR patch for writting DICOM from scratch + 2. Fix -hopefully- bug with MONOCHROME and space vs null character + 3. Use const ref when possible + 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now) + 5. A few more comments + 6. CreateUniqueUID can now be called without parameter" + +2004-11-15 Mathieu Malaterre + * ENH: Slightly bigger patch: + 1. Getting toward full integration of JMR patch for writting dicom from scratch + 2. Update Test to test part of this patch: CreateUniqueUID + 3. File was not close properly in gdcmDict + 4. Use of typedef is to be prefered when possible (gdcmDict.cxx) + 5. Use of const ref instead of copy (speed issue) + 6. Remove temporary (duplicate) string in TranslateToKey + 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case) + 8. Do not repeat virtual in subclasses + 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID + +2004-11-15 Mathieu Malaterre + * Apply first patch toward better string comparison when dealing with broken + DICOM files. Essentially the string could be padded with a space instead + of a null character as defined by standard + +2004-11-15 Benoit Regrain + * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed + because never used... and in the same time, that's remove some memory leaks + +2004-11-15 Benoit Regrain + * src/gdcmFile.cxx : now delete the PixelConvert instance. + * In examples and tests : change the type of image data variables from void* + to uint8_t*. Remmove all delete on image data variables + +2004-11-10 Benoit Regrain + * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors. + Verify the file pointer value before open the file, and if it's not null, + a verbose message is generated. + Close correctly the file when the file isn't considered dicom-like. The + correctly close is a call to CloseFile. + When closing the file pointer, test if its not null to close the file. + * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr + file. For an uncompressed image, the copied datas correspond in the least + case to the image size (calculated) or the image size specified in the + header. A verbose is generated if these two size mismatch + 2004-11-09 Benoit Regrain - * src/TestAllReadCompareDicom.cxx : test the existence of the directory + * Test/TestAllReadCompareDicom.cxx : test the existence of the directory using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *') break under windows (with msvc6 compilation). @@ -41,7 +309,7 @@ little endian. This should -heopfully- fix some tests 2004-11-03 Mathieu Malaterre - * Now the dictionary is compiled into gdcm lib. This is a default + * Now the dictionary is compiled into gdcm lib. This is a default behavior, thus any dic file specified is picked before failback to the one comiled into lib @@ -306,7 +574,7 @@ 2004-09-23 Jean-Pierre Roux * FIX In order not to be poluted any longer by casting problems, the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *) - we can now delete[] it safely + we can now delete[] it safely * VoidArea is now called BinArea (less confusing name), and all the methods called ...VoidArea... are now ... BinArea... * class gdcmObject is now called gdcmDicomDirObject (less confusing name) @@ -456,7 +724,7 @@ 2004-07-21 Jean-Pierre Roux * FIX Now, Parsing and Printing a DICOMDIR do work! ( troubles remain in makeDicomDir and BuildUpDicomDir :-( - + 2004-07-20 Jean-Pierre Roux * FIX Some brain damaged headers have Zero-Lenght fields for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'. @@ -560,10 +828,10 @@ 2004-06-29 Jean-Pierre Roux FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code, - replace by uggly but working old code :-( - A lot of things should be OK again. - It's really urgent to have a test suite that *tests*, - to prevent Frog's beautifying sessions to break all the stuff - (twice, withing a fortnigh ...) + A lot of things should be OK again. + It's really urgent to have a test suite that *tests*, + to prevent Frog's beautifying sessions to break all the stuff + (twice, withing a fortnigh ...) 2004-06-28 Eric Boix * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of @@ -598,14 +866,14 @@ 2004-06-24 Jean-Pierre Roux FIX : - now Write drops LUT Descriptors and LUTs (if any) - when SamplesPerPixel =3 + when SamplesPerPixel =3 - now Write is no longer confused by - 'BitsAllocated = 12" and 'BitsStored=12" + 'BitsAllocated = 12" and 'BitsStored=12" - "UN" value representation Elements are now written correctly - (their legth is stored on 4 bytes -just like OB, OW, and SQ-) + (their legth is stored on 4 bytes -just like OB, OW, and SQ-) ENH : - now gdcmHeader has its own Write methods - (in order to split the job that has not to be done - for gdcmDicomDir) + (in order to split the job that has not to be done + for gdcmDicomDir) 2004-06-23 Eric Boix * Test/PrintAllDocument.cxx: looping on files is now effective. It used to @@ -617,13 +885,13 @@ 2004-06-24 Jean-Pierre Roux FIX : Write - All the Sequences and Sequence Item are now written as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor - is added a the end, when necessary. + is added a the end, when necessary. - A lot of brain-damaged images, that were read correctly are - now written correctly - - length compatible BinEntry are now loaded correctly - (even for odd groups) + now written correctly + - length compatible BinEntry are now loaded correctly + (even for odd groups) Note : only Explicit Value Representation was checked. - (question : is implicit VR really necessary for gdcm ?) + (question : is implicit VR really necessary for gdcm ?) 2004-06-23 Eric Boix * DEVELOPPER: added a proposition of coding style. @@ -643,40 +911,40 @@ 2004-06-22 Jean-Pierre Roux In order : to write Sequences, whatever their imbrication level, - : to allow user to create his own Sequences - a lot of modif where necessary (adding, moving, or virtualising methods) + : to allow user to create his own Sequences + a lot of modif where necessary (adding, moving, or virtualising methods) -WARNING : save your own sources *before* cvs up ! - - - gdcmBinEntry - ADD virtual void Write(FILE *fp, FileType filetype); - + WARNING : save your own sources *before* cvs up ! + + - gdcmBinEntry + ADD virtual void Write(FILE *fp, FileType filetype); + - gdcmDocEntry - ADD virtual void Write(FILE *fp, FileType filetype); - ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype); - - - gdcmDocEntrySet - ADD virtual void Write (FILE *fp, FileType filetype)=0; - ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0; + ADD virtual void Write(FILE *fp, FileType filetype); + ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype); + + - gdcmDocEntrySet + ADD virtual void Write (FILE *fp, FileType filetype)=0; + ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0; ADD gdcmDocEntry *GetDocEntryByName(std::string name); ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0; - ADD std::string GetEntryByName(TagName name); + ADD std::string GetEntryByName(TagName name); ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group, guint16 element, std::string vr = "unkn", std::string fourth = "unkn", std::string name = "unkn"); - ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element); - ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element); + ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element); + ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element); ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element); ADD gdcmDocEntry *NewDocEntryByName (std::string Name); ADD gdcmDictEntry *GetDictEntryByName (std::string Name); ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16); - REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0; + REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0; REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0; - - - gdcmDocument - ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration + + - gdcmDocument + ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration ADD virtual std::string GetEntryByName (TagName tagName); ADD virtual std::string GetEntryVRByName (TagName tagName); REM virtual bool Write(FILE *, FileType);