X-Git-Url: https://git.creatis.insa-lyon.fr/pubgit/?a=blobdiff_plain;f=TODO;h=b7a40513a06c24a0428f3fcefd71d50ee92543c3;hb=4a0c2407ec81e041c2e43781acec4c78c83fc487;hp=1ba8deee56dabe95719501d506dcfbcf512110c7;hpb=21dc537d0c6c274bf1bc49084813a9f4e4cf29eb;p=gdcm.git diff --git a/TODO b/TODO index 1ba8deee..b7a40513 100644 --- a/TODO +++ b/TODO @@ -1,3 +1,12 @@ +* gdcmElValSet::SetElValueLengthByNumber IMNSHO should be trashed. + It's only purpose is a onliner substitute to calling GetElValueByNumber + and then SetLength. This only obfuscates the caller code more than + clarifying it. + Besides the definition of gdcmElValSet::SetElValueLengthByNumber itself + it quite poor since it is a almost exact copy of + gdcmElValSet::GetElValueByNumber except for the returned code. + gdcmHeader::SetPubElValLengthByNumber (which is based on + gdcmElValSet::SetElValueLengthByNumber) is used nowhere... * The declarations commented out and starting with "TODO Swig" (try grep "TODO Swig" *.h) needed to be temporarily removed for swig to proceed correctly (in fact problems appears at loading of _gdcm.[so/dll]). @@ -6,7 +15,6 @@ * As stated by the first lines of Test/ExceptionAndPython/README, it looks like we can move back to the exceptions and remove the errno stuff from src/gdcm* ! -* adapt python/gdcmPython/Makefile to automake/autoconf tools * Fix the bug in Test/bug1.cxx (see first comment line): Win32 only. * All (or at least many of) the methods of gdcmHeader whose only arguments are an ElValue* (e.g. FindLength, FindVR, LoadElementValue...) can @@ -34,3 +42,21 @@ and load image /home/frog/cvs/DCMlib/Data/CT-MONO2-16-ankle.dcm will yield wrong coloring scheme as opposed to affim filein=/home/frog/cvs/DCMlib/Data/CT-MONO2-16-ankle.dcm +* gdcmFile should implement the following: + gdcmFile WriteDicom; + WriteDicom.SetFileName("MyDicomFile.dcm"); + string * AllTags = gdcmHeader.GetDcmTagNames(); + WriteDicom.SetDcmTag(AllTags[5], "253"); + WriteDicom.SetDcmTag("Patient Name", "bozo"); + WriteDicom.SetDcmTag("Patient Name", "bozo"); + WriteDicom.SetImageData(Image); + WriteDicom.Write(); + + Anonymize(ostream& output) { + a = gdcmFile("toto1"); + a.SetPubValueByName("Patient Name", ""); + a.SetPubValueByName("Date", ""); + a.SetPubValueByName("Study Date", ""); + a.write(output); + } +