X-Git-Url: https://git.creatis.insa-lyon.fr/pubgit/?a=blobdiff_plain;f=src%2FgdcmDict.cxx;h=75834e1f76ea3f8a82b836d97241470cafcd9627;hb=22f785a2627d1e7823701193bd7624739a3e033b;hp=9f2d3882bb2550405953c26b3b998644dbe223d6;hpb=65467b71ee500909b0ef7c31d442ca0c160d6a15;p=gdcm.git

diff --git a/src/gdcmDict.cxx b/src/gdcmDict.cxx
index 9f2d3882..75834e1f 100644
--- a/src/gdcmDict.cxx
+++ b/src/gdcmDict.cxx
@@ -2,7 +2,11 @@
 //-----------------------------------------------------------------------------
 #include "gdcmDict.h"
 #include "gdcmUtil.h"
+
 #include <fstream>
+#include <iostream>
+#include <iomanip>
+
 #ifdef GDCM_NO_ANSI_STRING_STREAM
 #  include <strstream>
 #  define  ostringstream ostrstream
@@ -18,17 +22,16 @@
  * @param   FileName from which to build the dictionary.
  */
 gdcmDict::gdcmDict(std::string & FileName) {
-   std::ifstream from(FileName.c_str());
-   dbg.Error(!from, "gdcmDict::gdcmDict: can't open dictionary",
-                    FileName.c_str());
    guint16 group, element;
-	// CLEANME : use defines for all those constants
    char buff[1024];
-   TagKey key;
    TagName vr;
    TagName fourth;
    TagName name;
 
+   std::ifstream from(FileName.c_str());
+   dbg.Error(!from, "gdcmDict::gdcmDict: can't open dictionary",
+                    FileName.c_str());
+
    while (!from.eof()) {
       from >> std::hex >> group >> element;
       eatwhite(from);
@@ -39,13 +42,14 @@ gdcmDict::gdcmDict(std::string & FileName) {
       fourth = buff;
       from.getline(buff, 256, '\n');
       name = buff;
+
       gdcmDictEntry * newEntry = new gdcmDictEntry(group, element,
 		                                   vr, fourth, name);
-      // FIXME: use AddNewEntry
-      NameHt[name] = newEntry;
-      KeyHt[gdcmDictEntry::TranslateToKey(group, element)] = newEntry;
+      AddNewEntry(newEntry);
    }
    from.close();
+
+   filename=FileName;
 }
 
 /**
@@ -58,7 +62,6 @@ gdcmDict::~gdcmDict() {
       if ( EntryToDelete )
          delete EntryToDelete;
    }
-
    // Since AddNewEntry adds symetrical in both KeyHt and NameHT we can
    // assume all the pointed gdcmDictEntries are already cleaned-up when
    // we cleaned KeyHt.
@@ -74,6 +77,7 @@ gdcmDict::~gdcmDict() {
  * @param   os The output stream to be written to.
  */
 void gdcmDict::Print(std::ostream &os) {
+   os<<"Dict file name : "<<filename<<std::endl;
    PrintByKey(os);
 }
 
@@ -87,9 +91,9 @@ void gdcmDict::PrintByKey(std::ostream &os) {
    std::ostringstream s;
 
    for (TagKeyHT::iterator tag = KeyHt.begin(); tag != KeyHt.end(); ++tag){
-      s << "Tag : ";
-      s << "(" << std::hex << tag->second->GetGroup() << ',';
-      s << std::hex << tag->second->GetElement() << ") = " << std::dec;
+      s << "Entry : ";
+      s << "(" << std::hex << std::setw(4) << tag->second->GetGroup() << ',';
+      s << std::hex << std::setw(4) << tag->second->GetElement() << ") = " << std::dec;
       s << tag->second->GetVR() << ", ";
       s << tag->second->GetFourth() << ", ";
       s << tag->second->GetName() << "."  << std::endl;
@@ -101,7 +105,7 @@ void gdcmDict::PrintByKey(std::ostream &os) {
  * \ingroup gdcmDict
  * \brief   Print all the dictionary entries contained in this dictionary.
  *          Entries will be sorted by the name of the dictionary entries.
- * \warning AVOID USING IT : the name IS NOT an identifier
+ * \warning AVOID USING IT : the name IS NOT an identifier; 
  *                           unpredictable result
  * @param   os The output stream to be written to.
  */
@@ -109,12 +113,13 @@ void gdcmDict::PrintByName(std::ostream& os) {
    std::ostringstream s;
 
    for (TagNameHT::iterator tag = NameHt.begin(); tag != NameHt.end(); ++tag){
-      s << "Tag : ";
+      s << "Entry : ";
       s << tag->second->GetName() << ",";
       s << tag->second->GetVR() << ", ";
       s << tag->second->GetFourth() << ", ";
-      s << "(" << std::hex << tag->second->GetGroup() << ',';
-      s << std::hex << tag->second->GetElement() << ") = " << std::dec << std::endl;
+      s << "(" << std::hex << std::setw(4) << tag->second->GetGroup() << ',';
+      s << std::hex << std::setw(4) << tag->second->GetElement() << ") = ";
+      s << std::dec << std::endl;
    }
    os << s.str();
 }
@@ -124,8 +129,8 @@ void gdcmDict::PrintByName(std::ostream& os) {
 /**
  * \ingroup gdcmDict
  * \brief  adds a new Dicom Dictionary Entry 
- * @param   NewEntry 
- * @return  false if Dicom Element already existed
+ * @param   NewEntry entry to add 
+ * @return  false if Dicom Element already exists
  */
 bool gdcmDict::AddNewEntry(gdcmDictEntry *NewEntry) 
 {
@@ -148,7 +153,7 @@ bool gdcmDict::AddNewEntry(gdcmDictEntry *NewEntry)
 /**
  * \ingroup gdcmDict
  * \brief  replaces an already existing Dicom Element by a new one
- * @param   NewEntry
+ * @param   NewEntry new entry (overwrites any previous one with same tag)
  * @return  false if Dicom Element doesn't exist
  */
 bool gdcmDict::ReplaceEntry(gdcmDictEntry *NewEntry) {
@@ -192,8 +197,7 @@ bool gdcmDict::RemoveEntry(TagKey key)
 /**
  * \ingroup gdcmDict
  * \brief  removes an already existing Dicom Dictionary Entry, 
- *          identified by its group,element
- number
+ *          identified by its group,element number
  * @param   group   Dicom group number of the Dicom Element
  * @param   element Dicom element number of the Dicom Element
  * @return  false if Dicom Dictionary Entry doesn't exist
@@ -267,7 +271,7 @@ std::list<std::string> *gdcmDict::GetDictEntryNames(void)
  *           than asking us to perform a line by line check of the dictionnary
  *           at the beginning of each year to -try to- guess the changes)
  *           Therefore : please NEVER use that fourth field :-(
- * *
+ *
  * @return  An hashtable: whose keys are the names of the groups and whose
  *          corresponding values are lists of all the dictionnary entries
  *          among that group.