X-Git-Url: https://git.creatis.insa-lyon.fr/pubgit/?a=blobdiff_plain;f=src%2FgdcmDocument.cxx;h=45b8fb97f1d29da81134ecf9b1bc0a0a3bd2ed1f;hb=70b9dde9da207191fa6d799fdf03c2aff7941273;hp=306354a4e999f089d03cbdb37fd425940bf697cd;hpb=ee6b053bb6a51ecd2363836beacdb55bcc1c9a46;p=gdcm.git diff --git a/src/gdcmDocument.cxx b/src/gdcmDocument.cxx index 306354a4..45b8fb97 100644 --- a/src/gdcmDocument.cxx +++ b/src/gdcmDocument.cxx @@ -3,8 +3,8 @@ Program: gdcm Module: $RCSfile: gdcmDocument.cxx,v $ Language: C++ - Date: $Date: 2004/11/19 12:44:00 $ - Version: $Revision: 1.135 $ + Date: $Date: 2005/01/07 16:26:12 $ + Version: $Revision: 1.163 $ Copyright (c) CREATIS (Centre de Recherche et d'Applications en Traitement de l'Image). All rights reserved. See Doc/License.txt or @@ -23,6 +23,13 @@ #include "gdcmGlobal.h" #include "gdcmUtil.h" #include "gdcmDebug.h" +#include "gdcmTS.h" +#include "gdcmException.h" +#include "gdcmDictSet.h" +#include "gdcmRLEFramesInfo.h" +#include "gdcmJPEGFragmentsInfo.h" +#include "gdcmDocEntrySet.h" +#include "gdcmSQItem.h" #include #include @@ -36,10 +43,11 @@ namespace gdcm { +//----------------------------------------------------------------------------- static const char *TransferSyntaxStrings[] = { // Implicit VR Little Endian "1.2.840.10008.1.2", - // Implicit VR Little Endian DLX G.E? + // Implicit VR Big Endian DLX G.E? "1.2.840.113619.5.2", // Explicit VR Little Endian "1.2.840.10008.1.2.1", @@ -73,7 +81,7 @@ static const char *TransferSyntaxStrings[] = { //----------------------------------------------------------------------------- // Refer to Document::CheckSwap() -const unsigned int Document::HEADER_LENGTH_TO_READ = 256; +//const unsigned int Document::HEADER_LENGTH_TO_READ = 256; // Refer to Document::SetMaxSizeLoadEntry() const unsigned int Document::MAX_SIZE_LOAD_ELEMENT_VALUE = 0xfff; // 4096 @@ -86,7 +94,7 @@ const unsigned int Document::MAX_SIZE_PRINT_ELEMENT_VALUE = 0x7fffffff; * \brief constructor * @param filename file to be opened for parsing */ -Document::Document( std::string const & filename ) : ElementSet(-1) +Document::Document( std::string const &filename ) : ElementSet(-1) { SetMaxSizeLoadEntry(MAX_SIZE_LOAD_ELEMENT_VALUE); Filename = filename; @@ -98,21 +106,21 @@ Document::Document( std::string const & filename ) : ElementSet(-1) return; } - dbg.Verbose(0, "Document::Document: starting parsing of file: ", + Debug::Verbose(0, "Document::Document: starting parsing of file: ", Filename.c_str()); - Fp->seekg( 0, std::ios_base::beg); + Fp->seekg( 0, std::ios::beg); - Fp->seekg(0, std::ios_base::end); + Fp->seekg(0, std::ios::end); long lgt = Fp->tellg(); - Fp->seekg( 0, std::ios_base::beg); + Fp->seekg( 0, std::ios::beg); CheckSwap(); long beg = Fp->tellg(); lgt -= beg; ParseDES( this, beg, lgt, false); // le Load sera fait a la volee - Fp->seekg( 0, std::ios_base::beg); + Fp->seekg( 0, std::ios::beg); // Load 'non string' values @@ -174,8 +182,6 @@ Document::Document( std::string const & filename ) : ElementSet(-1) SetEntryByNumber(rows , 0x0028, 0x0011); } // ----------------- End of ACR-LibIDO kludge ------------------ - - PrintLevel = 1; // 'Medium' print level by default } /** @@ -190,7 +196,6 @@ Document::Document() : ElementSet(-1) Initialise(); SwapCode = 0; Filetype = ExplicitVR; - PrintLevel = 1; // 'Medium' print level by default } /** @@ -212,8 +217,9 @@ Document::~Document () * \brief Prints The Dict Entries of THE public Dicom Dictionary * @return */ -void Document::PrintPubDict(std::ostream & os) +void Document::PrintPubDict(std::ostream &os) { + RefPubDict->SetPrintLevel(PrintLevel); RefPubDict->Print(os); } @@ -221,8 +227,9 @@ void Document::PrintPubDict(std::ostream & os) * \brief Prints The Dict Entries of THE shadow Dicom Dictionary * @return */ -void Document::PrintShaDict(std::ostream & os) +void Document::PrintShaDict(std::ostream &os) { + RefShaDict->SetPrintLevel(PrintLevel); RefShaDict->Print(os); } @@ -231,7 +238,7 @@ void Document::PrintShaDict(std::ostream & os) /** * \brief Get the public dictionary used */ -Dict* Document::GetPubDict() +Dict *Document::GetPubDict() { return RefPubDict; } @@ -239,14 +246,14 @@ Dict* Document::GetPubDict() /** * \brief Get the shadow dictionary used */ -Dict* Document::GetShaDict() +Dict *Document::GetShaDict() { return RefShaDict; } /** * \brief Set the shadow dictionary used - * \param dict dictionary to use in shadow + * @param dict dictionary to use in shadow */ bool Document::SetShaDict(Dict *dict) { @@ -256,9 +263,9 @@ bool Document::SetShaDict(Dict *dict) /** * \brief Set the shadow dictionary used - * \param dictName name of the dictionary to use in shadow + * @param dictName name of the dictionary to use in shadow */ -bool Document::SetShaDict(DictKey const & dictName) +bool Document::SetShaDict(DictKey const &dictName) { RefShaDict = Global::GetDicts()->GetDict(dictName); return !RefShaDict; @@ -276,13 +283,13 @@ bool Document::IsReadable() { if( Filetype == Unknown) { - dbg.Verbose(0, "Document::IsReadable: wrong filetype"); + Debug::Verbose(0, "Document::IsReadable: wrong filetype"); return false; } if( TagHT.empty() ) { - dbg.Verbose(0, "Document::IsReadable: no tags in internal" + Debug::Verbose(0, "Document::IsReadable: no tags in internal" " hash table."); return false; } @@ -307,7 +314,7 @@ TransferSyntaxType Document::GetTransferSyntax() // The entry might be present but not loaded (parsing and loading // happen at different stages): try loading and proceed with check... LoadDocEntrySafe(entry); - if (ValEntry* valEntry = dynamic_cast< ValEntry* >(entry) ) + if (ValEntry *valEntry = dynamic_cast< ValEntry* >(entry) ) { std::string transfer = valEntry->GetValue(); // The actual transfer (as read from disk) might be padded. We @@ -408,28 +415,38 @@ FileType Document::GetFileType() * checks the preamble when existing. * @return The FILE pointer on success. */ -std::ifstream* Document::OpenFile() +std::ifstream *Document::OpenFile() { - if (Filename.length() == 0) return 0; + if (Filename.length() == 0) + { + return 0; + } + if(Fp) { - dbg.Verbose( 0, + Debug::Verbose( 0, "Document::OpenFile is already opened when opening: ", Filename.c_str()); } Fp = new std::ifstream(Filename.c_str(), std::ios::in | std::ios::binary); - - if(!Fp) + if( ! *Fp ) { - dbg.Verbose( 0, + Debug::Verbose( 0, "Document::OpenFile cannot open file: ", Filename.c_str()); + delete Fp; + Fp = 0; return 0; } uint16_t zero; - Fp->read((char*)&zero, (size_t)2 ); + Fp->read((char*)&zero, (size_t)2); + if( Fp->eof() ) + { + CloseFile(); + return 0; + } //ACR -- or DICOM with no Preamble; may start with a Shadow Group -- if( @@ -442,16 +459,21 @@ std::ifstream* Document::OpenFile() } //DICOM - Fp->seekg(126L, std::ios_base::cur); + Fp->seekg(126L, std::ios::cur); char dicm[4]; Fp->read(dicm, (size_t)4); + if( Fp->eof() ) + { + CloseFile(); + return 0; + } if( memcmp(dicm, "DICM", 4) == 0 ) { return Fp; } CloseFile(); - dbg.Verbose( 0, + Debug::Verbose( 0, "Document::OpenFile not DICOM/ACR (missing preamble)", Filename.c_str()); @@ -481,41 +503,22 @@ bool Document::CloseFile() * (ACR-NEMA, ExplicitVR, ImplicitVR) * \return Always true. */ -void Document::Write(std::ofstream* fp, FileType filetype) +void Document::WriteContent(std::ofstream *fp, FileType filetype) { /// \todo move the following lines (and a lot of others, to be written) /// to a future function CheckAndCorrectHeader /// (necessary if user wants to write a DICOM V3 file /// starting from an ACR-NEMA (V2) Header - if (filetype == ImplicitVR) + if ( filetype == ImplicitVR || filetype == ExplicitVR ) { - std::string ts = - Util::DicomString( TransferSyntaxStrings[ImplicitVRLittleEndian] ); - ReplaceOrCreateByNumber(ts, 0x0002, 0x0010); - - /// \todo Refer to standards on page 21, chapter 6.2 - /// "Value representation": values with a VR of UI shall be - /// padded with a single trailing null - /// in the following case we have to padd manually with a 0 - - SetEntryLengthByNumber(18, 0x0002, 0x0010); - } - - if (filetype == ExplicitVR) - { - std::string ts = - Util::DicomString( TransferSyntaxStrings[ExplicitVRLittleEndian] ); - ReplaceOrCreateByNumber(ts, 0x0002, 0x0010); //LEAK - - /// \todo Refer to standards on page 21, chapter 6.2 - /// "Value representation": values with a VR of UI shall be - /// padded with a single trailing null - /// Dans le cas suivant on doit pader manuellement avec un 0 - - SetEntryLengthByNumber(20, 0x0002, 0x0010); + // writing Dicom File Preamble + char filePreamble[128]; + memset(filePreamble, 0, 128); + fp->write(filePreamble, 128); + fp->write("DICM", 4); } - + /** * \todo rewrite later, if really usefull * - 'Group Length' element is optional in DICOM @@ -528,12 +531,11 @@ void Document::Write(std::ofstream* fp, FileType filetype) * UpdateGroupLength(true,ACR); */ - ElementSet::Write(fp, filetype); // This one is recursive - + ElementSet::WriteContent(fp, filetype); // This one is recursive } /** - * \brief Modifies the value of a given Header Entry (Dicom Element) + * \brief Modifies the value of a given Doc Entry (Dicom Element) * when it exists. Create it with the given value when unexistant. * @param value (string) Value to be set * @param group Group number of the Entry @@ -542,79 +544,53 @@ void Document::Write(std::ofstream* fp, FileType filetype) * \return pointer to the modified/created Header Entry (NULL when creation * failed). */ -ValEntry* Document::ReplaceOrCreateByNumber( - std::string const & value, - uint16_t group, - uint16_t elem, - TagName const & vr ) -{ - ValEntry* valEntry = 0; - DocEntry* currentEntry = GetDocEntryByNumber( group, elem); +ValEntry *Document::ReplaceOrCreateByNumber(std::string const &value, + uint16_t group, + uint16_t elem, + TagName const &vr ) +{ + ValEntry *valEntry = 0; + DocEntry *currentEntry = GetDocEntryByNumber( group, elem); - if (!currentEntry) + if (currentEntry) { - // check if (group,element) DictEntry exists - // if it doesn't, create an entry in DictSet::VirtualEntry - // and use it + valEntry = dynamic_cast< ValEntry* >(currentEntry); - // Find out if the tag we received is in the dictionaries: - Dict *pubDict = Global::GetDicts()->GetDefaultPubDict(); - DictEntry* dictEntry = pubDict->GetDictEntryByNumber(group, elem); - if (!dictEntry) - { - currentEntry = NewDocEntryByNumber(group, elem, vr); - } - else - { - currentEntry = NewDocEntryByNumber(group, elem); - } + // Verify the VR + if( valEntry ) + if( valEntry->GetVR()!=vr ) + valEntry=NULL; - if (!currentEntry) + // if currentEntry doesn't correspond to the requested valEntry + if( !valEntry) { - dbg.Verbose(0, "Document::ReplaceOrCreateByNumber: call to" - " NewDocEntryByNumber failed."); - return NULL; + if (!RemoveEntry(currentEntry)) + { + Debug::Verbose(0, "Document::ReplaceOrCreateByNumber: removal" + " of previous DocEntry failed."); + + return NULL; + } } + } - valEntry = new ValEntry(currentEntry); - delete currentEntry; + // Create a new valEntry if necessary + if (!valEntry) + { + valEntry = NewValEntryByNumber(group, elem, vr); if ( !AddEntry(valEntry)) { - delete valEntry; - dbg.Verbose(0, "Document::ReplaceOrCreateByNumber: AddEntry" + Debug::Verbose(0, "Document::ReplaceOrCreateByNumber: AddEntry" " failed allthough this is a creation."); + + delete valEntry; return NULL; } } - else - { - valEntry = dynamic_cast< ValEntry* >(currentEntry); - if ( !valEntry ) // Euuuuh? It wasn't a ValEntry - // then we change it to a ValEntry ? - // Shouldn't it be considered as an error ? - { - // We need to promote the DocEntry to a ValEntry: - valEntry = new ValEntry(currentEntry); - if (!RemoveEntry(currentEntry)) - { - delete valEntry; - dbg.Verbose(0, "Document::ReplaceOrCreateByNumber: removal" - " of previous DocEntry failed."); - return NULL; - } - if ( !AddEntry(valEntry)) - { - delete valEntry; - dbg.Verbose(0, "Document::ReplaceOrCreateByNumber: adding" - " promoted ValEntry failed."); - return NULL; - } - } - } - - SetEntryByNumber(value, group, elem); + // Set the binEntry value + SetEntry(value, valEntry); return valEntry; } @@ -625,74 +601,58 @@ ValEntry* Document::ReplaceOrCreateByNumber( * @param binArea (binary) value to be set * @param Group Group number of the Entry * @param Elem Element number of the Entry + * @param vr V(alue) R(epresentation) of the Entry -if private Entry- * \return pointer to the modified/created Header Entry (NULL when creation * failed). */ -BinEntry* Document::ReplaceOrCreateByNumber( - uint8_t* binArea, - int lgth, - uint16_t group, - uint16_t elem, - TagName const & vr ) +BinEntry *Document::ReplaceOrCreateByNumber(uint8_t *binArea, + int lgth, + uint16_t group, + uint16_t elem, + TagName const &vr ) { - BinEntry* binEntry = 0; - DocEntry* currentEntry = GetDocEntryByNumber( group, elem); - if (!currentEntry) - { - - // check if (group,element) DictEntry exists - // if it doesn't, create an entry in DictSet::VirtualEntry - // and use it - - // Find out if the tag we received is in the dictionaries: - Dict *pubDict = Global::GetDicts()->GetDefaultPubDict(); - DictEntry *dictEntry = pubDict->GetDictEntryByNumber(group, elem); + BinEntry *binEntry = 0; + DocEntry *currentEntry = GetDocEntryByNumber( group, elem); - if (!dictEntry) - { - currentEntry = NewDocEntryByNumber(group, elem, vr); - } - else - { - currentEntry = NewDocEntryByNumber(group, elem); - } - if (!currentEntry) - { - dbg.Verbose(0, "Document::ReplaceOrCreateByNumber: call to" - " NewDocEntryByNumber failed."); - return NULL; - } - binEntry = new BinEntry(currentEntry); - if ( !AddEntry(binEntry)) - { - dbg.Verbose(0, "Document::ReplaceOrCreateByNumber: AddEntry" - " failed allthough this is a creation."); - } - } - else + // Verify the currentEntry + if (currentEntry) { binEntry = dynamic_cast< BinEntry* >(currentEntry); - if ( !binEntry ) // Euuuuh? It wasn't a BinEntry - // then we change it to a BinEntry ? - // Shouldn't it be considered as an error ? + + // Verify the VR + if( binEntry ) + if( binEntry->GetVR()!=vr ) + binEntry=NULL; + + // if currentEntry doesn't correspond to the requested valEntry + if( !binEntry) { - // We need to promote the DocEntry to a BinEntry: - binEntry = new BinEntry(currentEntry); if (!RemoveEntry(currentEntry)) { - dbg.Verbose(0, "Document::ReplaceOrCreateByNumber: removal" + Debug::Verbose(0, "Document::ReplaceOrCreateByNumber: removal" " of previous DocEntry failed."); - return NULL; - } - if ( !AddEntry(binEntry)) - { - dbg.Verbose(0, "Document::ReplaceOrCreateByNumber: adding" - " promoted BinEntry failed."); + return NULL; } } } + // Create a new binEntry if necessary + if (!binEntry) + { + binEntry = NewBinEntryByNumber(group, elem, vr); + + if ( !AddEntry(binEntry)) + { + Debug::Verbose(0, "Document::ReplaceOrCreateByNumber: AddEntry" + " failed allthough this is a creation."); + + delete binEntry; + return NULL; + } + } + + // Set the binEntry value uint8_t *tmpArea; if (lgth>0 && binArea) { @@ -703,7 +663,7 @@ BinEntry* Document::ReplaceOrCreateByNumber( { tmpArea = 0; } - if (!SetEntryByNumber(tmpArea, lgth, group, elem)) + if (!SetEntry(tmpArea,lgth,binEntry)) { if (tmpArea) { @@ -714,7 +674,6 @@ BinEntry* Document::ReplaceOrCreateByNumber( return binEntry; } - /* * \brief Modifies the value of a given Header Entry (Dicom Element) * when it exists. Create it when unexistant. @@ -723,22 +682,50 @@ BinEntry* Document::ReplaceOrCreateByNumber( * \return pointer to the modified/created SeqEntry (NULL when creation * failed). */ -SeqEntry* Document::ReplaceOrCreateByNumber( uint16_t group, uint16_t elem) +SeqEntry *Document::ReplaceOrCreateByNumber( uint16_t group, uint16_t elem) { - SeqEntry* b = 0; - DocEntry* a = GetDocEntryByNumber( group, elem); - if (!a) + SeqEntry *seqEntry = 0; + DocEntry *currentEntry = GetDocEntryByNumber( group, elem); + + // Verify the currentEntry + if (currentEntry) { - a = NewSeqEntryByNumber(group, elem); - if (!a) + seqEntry = dynamic_cast< SeqEntry* >(currentEntry); + + // Verify the VR + if( seqEntry ) + if( seqEntry->GetVR()!="SQ" ) + seqEntry=NULL; + + // if currentEntry doesn't correspond to the requested valEntry + if( !seqEntry) { - return 0; + if (!RemoveEntry(currentEntry)) + { + Debug::Verbose(0, "Document::ReplaceOrCreateByNumber: removal" + " of previous DocEntry failed."); + + return NULL; + } } + } - b = new SeqEntry(a, 1); // FIXME : 1 (Depth) - AddEntry(b); - } - return b; + // Create a new seqEntry if necessary + if (!seqEntry) + { + seqEntry = NewSeqEntryByNumber(group, elem); + + if ( !AddEntry(seqEntry)) + { + Debug::Verbose(0, "Document::ReplaceOrCreateByNumber: AddEntry" + " failed allthough this is a creation."); + + delete seqEntry; + return NULL; + } + } + + return seqEntry; } /** @@ -749,7 +736,7 @@ SeqEntry* Document::ReplaceOrCreateByNumber( uint16_t group, uint16_t elem) * @param elem element number of the Entry * \return boolean */ -bool Document::ReplaceIfExistByNumber(std::string const & value, +bool Document::ReplaceIfExistByNumber(std::string const &value, uint16_t group, uint16_t elem ) { SetEntryByNumber(value, group, elem); @@ -757,6 +744,11 @@ bool Document::ReplaceIfExistByNumber(std::string const & value, return true; } +std::string Document::GetTransferSyntaxValue(TransferSyntaxType type) +{ + return TransferSyntaxStrings[type]; +} + //----------------------------------------------------------------------------- // Protected @@ -772,51 +764,6 @@ bool Document::CheckIfEntryExistByNumber(uint16_t group, uint16_t element ) return TagHT.count(key) != 0; } -/** - * \brief Searches within Header Entries (Dicom Elements) parsed with - * the public and private dictionaries - * for the element value of a given tag. - * \warning Don't use any longer : use GetPubEntryByName - * @param tagName name of the searched element. - * @return Corresponding element value when it exists, - * and the string GDCM_UNFOUND ("gdcm::Unfound") otherwise. - */ -std::string Document::GetEntryByName(TagName const & tagName) -{ - DictEntry* dictEntry = RefPubDict->GetDictEntryByName(tagName); - if( !dictEntry ) - { - return GDCM_UNFOUND; - } - - return GetEntryByNumber(dictEntry->GetGroup(),dictEntry->GetElement()); -} - -/** - * \brief Searches within Header Entries (Dicom Elements) parsed with - * the public and private dictionaries - * for the element value representation of a given tag. - * - * Obtaining the VR (Value Representation) might be needed by caller - * to convert the string typed content to caller's native type - * (think of C++ vs Python). The VR is actually of a higher level - * of semantics than just the native C++ type. - * @param tagName name of the searched element. - * @return Corresponding element value representation when it exists, - * and the string GDCM_UNFOUND ("gdcm::Unfound") otherwise. - */ -std::string Document::GetEntryVRByName(TagName const& tagName) -{ - DictEntry *dictEntry = RefPubDict->GetDictEntryByName(tagName); - if( dictEntry == NULL) - { - return GDCM_UNFOUND; - } - - DocEntry* elem = GetDocEntryByNumber(dictEntry->GetGroup(), - dictEntry->GetElement()); - return elem->GetVR(); -} /** * \brief Searches within Header Entries (Dicom Elements) parsed with @@ -830,7 +777,6 @@ std::string Document::GetEntryVRByName(TagName const& tagName) std::string Document::GetEntryByNumber(uint16_t group, uint16_t element) { TagKey key = DictEntry::TranslateToKey(group, element); - /// \todo use map methods, instead of multimap JPR if ( !TagHT.count(key)) { return GDCM_UNFOUND; @@ -855,7 +801,7 @@ std::string Document::GetEntryByNumber(uint16_t group, uint16_t element) */ std::string Document::GetEntryVRByNumber(uint16_t group, uint16_t element) { - DocEntry* elem = GetDocEntryByNumber(group, element); + DocEntry *elem = GetDocEntryByNumber(group, element); if ( !elem ) { return GDCM_UNFOUND; @@ -873,31 +819,13 @@ std::string Document::GetEntryVRByNumber(uint16_t group, uint16_t element) */ int Document::GetEntryLengthByNumber(uint16_t group, uint16_t element) { - DocEntry* elem = GetDocEntryByNumber(group, element); + DocEntry *elem = GetDocEntryByNumber(group, element); if ( !elem ) { return -2; //magic number } return elem->GetLength(); } -/** - * \brief Sets the value (string) of the Header Entry (Dicom Element) - * @param content string value of the Dicom Element - * @param tagName name of the searched Dicom Element. - * @return true when found - */ -bool Document::SetEntryByName( std::string const & content, - TagName const & tagName) -{ - DictEntry *dictEntry = RefPubDict->GetDictEntryByName(tagName); - if( !dictEntry ) - { - return false; - } - - return SetEntryByNumber(content,dictEntry->GetGroup(), - dictEntry->GetElement()); -} /** * \brief Accesses an existing DocEntry (i.e. a Dicom Element) @@ -910,42 +838,14 @@ bool Document::SetEntryByName( std::string const & content, bool Document::SetEntryByNumber(std::string const& content, uint16_t group, uint16_t element) { - int c; - int l; - - ValEntry* valEntry = GetValEntryByNumber(group, element); - if (!valEntry ) + ValEntry *entry = GetValEntryByNumber(group, element); + if (!entry ) { - dbg.Verbose(0, "Document::SetEntryByNumber: no corresponding", + Debug::Verbose(0, "Document::SetEntryByNumber: no corresponding", " ValEntry (try promotion first)."); return false; } - // Non even content must be padded with a space (020H)... - std::string finalContent = Util::DicomString( content.c_str() ); - assert( !(finalContent.size() % 2) ); - valEntry->SetValue(finalContent); - - // Integers have a special treatement for their length: - - l = finalContent.length(); - if ( l != 0) // To avoid to be cheated by 'zero length' integers - { - VRKey vr = valEntry->GetVR(); - if( vr == "US" || vr == "SS" ) - { - // for multivaluated items - c = Util::CountSubstring(content, "\\") + 1; - l = c*2; - } - else if( vr == "UL" || vr == "SL" ) - { - // for multivaluated items - c = Util::CountSubstring(content, "\\") + 1; - l = c*4;; - } - } - valEntry->SetLength(l); - return true; + return SetEntry(content,entry); } /** @@ -960,73 +860,57 @@ bool Document::SetEntryByNumber(std::string const& content, bool Document::SetEntryByNumber(uint8_t*content, int lgth, uint16_t group, uint16_t element) { - (void)lgth; //not used - TagKey key = DictEntry::TranslateToKey(group, element); - if ( !TagHT.count(key)) + BinEntry *entry = GetBinEntryByNumber(group, element); + if (!entry ) { + Debug::Verbose(0, "Document::SetEntryByNumber: no corresponding", + " ValEntry (try promotion first)."); return false; } -/* Hope Binary field length is *never* wrong - if(lgth%2) // Non even length are padded with a space (020H). - { - lgth++; - //content = content + '\0'; // fing a trick to enlarge a binary field? - } -*/ - BinEntry* entry = (BinEntry *)TagHT[key]; - entry->SetBinArea(content); - entry->SetLength(lgth); - entry->SetValue(GDCM_BINLOADED); - - return true; + return SetEntry(content,lgth,entry); } /** * \brief Accesses an existing DocEntry (i.e. a Dicom Element) - * in the PubDocEntrySet of this instance - * through it's (group, element) and modifies it's length with - * the given value. - * \warning Use with extreme caution. - * @param l new length to substitute with - * @param group group number of the Entry to modify - * @param element element number of the Entry to modify - * @return true on success, false otherwise. + * and modifies it's content with the given value. + * @param content new value (string) to substitute with + * @param entry Entry to be modified */ -bool Document::SetEntryLengthByNumber(uint32_t l, - uint16_t group, uint16_t element) +bool Document::SetEntry(std::string const &content,ValEntry *entry) { - /// \todo use map methods, instead of multimap JPR - TagKey key = DictEntry::TranslateToKey(group, element); - if ( !TagHT.count(key) ) + if(entry) { - return false; - } - if ( l % 2 ) - { - l++; // length must be even + entry->SetValue(content); + return true; } - ( ((TagHT.equal_range(key)).first)->second )->SetLength(l); - - return true ; + return false; } /** - * \brief Gets (from Header) the offset of a 'non string' element value - * (LoadElementValues has already be executed) - * @param group group number of the Entry - * @param elem element number of the Entry - * @return File Offset of the Element Value + * \brief Accesses an existing BinEntry (i.e. a Dicom Element) + * and modifies it's content with the given value. + * @param content new value (void* -> uint8_t*) to substitute with + * @param entry Entry to be modified + * @param lgth new value length */ -size_t Document::GetEntryOffsetByNumber(uint16_t group, uint16_t elem) +bool Document::SetEntry(uint8_t *content, int lgth, BinEntry *entry) { - DocEntry* entry = GetDocEntryByNumber(group, elem); - if (!entry) + if(entry) { - dbg.Verbose(1, "Document::GetDocEntryByNumber: no entry present."); - return 0; + // Hope Binary field length is *never* wrong + /*if(lgth%2) // Non even length are padded with a space (020H). + { + lgth++; + //content = content + '\0'; // fing a trick to enlarge a binary field? + }*/ + + entry->SetBinArea(content); + entry->SetLength(lgth); + entry->SetValue(GDCM_BINLOADED); + return true; } - return entry->GetOffset(); + return false; } /** @@ -1036,15 +920,15 @@ size_t Document::GetEntryOffsetByNumber(uint16_t group, uint16_t elem) * @param elem element number of the Entry * @return Pointer to the 'non string' area */ -void* Document::GetEntryBinAreaByNumber(uint16_t group, uint16_t elem) +void *Document::GetEntryBinAreaByNumber(uint16_t group, uint16_t elem) { - DocEntry* entry = GetDocEntryByNumber(group, elem); + DocEntry *entry = GetDocEntryByNumber(group, elem); if (!entry) { - dbg.Verbose(1, "Document::GetDocEntryByNumber: no entry"); + Debug::Verbose(1, "Document::GetDocEntryByNumber: no entry"); return 0; } - if ( BinEntry* binEntry = dynamic_cast(entry) ) + if ( BinEntry *binEntry = dynamic_cast(entry) ) { return binEntry->GetBinArea(); } @@ -1065,45 +949,35 @@ void Document::LoadEntryBinArea(uint16_t group, uint16_t elem) if ( !docElement ) return; - size_t o =(size_t)docElement->GetOffset(); - Fp->seekg( o, std::ios_base::beg); - size_t l = docElement->GetLength(); - uint8_t* a = new uint8_t[l]; - if(!a) - { - dbg.Verbose(0, "Document::LoadEntryBinArea cannot allocate a"); + BinEntry *binElement = dynamic_cast(docElement); + if( !binElement ) return; - } - // Read the value - Fp->read((char*)a, l); - if( Fp->fail() || Fp->eof() )//Fp->gcount() == 1 - { - delete[] a; - return; - } - - // Set the value to the DocEntry - if( !SetEntryBinAreaByNumber( a, group, elem ) ) - { - delete[] a; - dbg.Verbose(0, "Document::LoadEntryBinArea setting failed."); - } + LoadEntryBinArea(binElement); } + /** * \brief Loads (from disk) the element content * when a string is not suitable * @param element Entry whose binArea is going to be loaded */ -void Document::LoadEntryBinArea(BinEntry* element) +void Document::LoadEntryBinArea(BinEntry *element) { + if(element->GetBinArea()) + return; + + bool openFile = !Fp; + if(openFile) + OpenFile(); + size_t o =(size_t)element->GetOffset(); - Fp->seekg(o, std::ios_base::beg); + Fp->seekg(o, std::ios::beg); + size_t l = element->GetLength(); - uint8_t* a = new uint8_t[l]; + uint8_t *a = new uint8_t[l]; if( !a ) { - dbg.Verbose(0, "Document::LoadEntryBinArea cannot allocate a"); + Debug::Verbose(0, "Document::LoadEntryBinArea cannot allocate a"); return; } @@ -1116,6 +990,9 @@ void Document::LoadEntryBinArea(BinEntry* element) } element->SetBinArea(a); + + if(openFile) + CloseFile(); } /** @@ -1125,89 +1002,23 @@ void Document::LoadEntryBinArea(BinEntry* element) * @param element Element number of the searched Dicom Element * @return */ -bool Document::SetEntryBinAreaByNumber(uint8_t* area, +/*bool Document::SetEntryBinAreaByNumber(uint8_t *area, uint16_t group, uint16_t element) { - DocEntry* currentEntry = GetDocEntryByNumber(group, element); + DocEntry *currentEntry = GetDocEntryByNumber(group, element); if ( !currentEntry ) { return false; } - if ( BinEntry* binEntry = dynamic_cast(currentEntry) ) + if ( BinEntry *binEntry = dynamic_cast(currentEntry) ) { binEntry->SetBinArea( area ); return true; } return false; -} - -/** - * \brief Update the entries with the shadow dictionary. - * Only non even entries are analyzed - */ -void Document::UpdateShaEntries() -{ - //DictEntry *entry; - std::string vr; - - /// \todo TODO : still any use to explore recursively the whole structure? -/* - for(ListTag::iterator it=listEntries.begin(); - it!=listEntries.end(); - ++it) - { - // Odd group => from public dictionary - if((*it)->GetGroup()%2==0) - continue; - - // Peer group => search the corresponding dict entry - if(RefShaDict) - entry=RefShaDict->GetDictEntryByNumber((*it)->GetGroup(),(*it)->GetElement()); - else - entry=NULL; - - if((*it)->IsImplicitVR()) - vr="Implicit"; - else - vr=(*it)->GetVR(); - - (*it)->SetValue(GetDocEntryUnvalue(*it)); // to go on compiling - if(entry){ - // Set the new entry and the new value - (*it)->SetDictEntry(entry); - CheckDocEntryVR(*it,vr); - - (*it)->SetValue(GetDocEntryValue(*it)); // to go on compiling - - } - else - { - // Remove precedent value transformation - (*it)->SetDictEntry(NewVirtualDictEntry((*it)->GetGroup(),(*it)->GetElement(),vr)); - } - } -*/ -} - -/** - * \brief Searches within the Header Entries for a Dicom Element of - * a given tag. - * @param tagName name of the searched Dicom Element. - * @return Corresponding Dicom Element when it exists, and NULL - * otherwise. - */ -DocEntry* Document::GetDocEntryByName(TagName const & tagName) -{ - DictEntry *dictEntry = RefPubDict->GetDictEntryByName(tagName); - if( !dictEntry ) - { - return NULL; - } - - return GetDocEntryByNumber(dictEntry->GetGroup(),dictEntry->GetElement()); -} +}*/ /** * \brief retrieves a Dicom Element (the first one) using (group, element) @@ -1219,7 +1030,7 @@ DocEntry* Document::GetDocEntryByName(TagName const & tagName) * @param element Element number of the searched Dicom Element * @return */ -DocEntry* Document::GetDocEntryByNumber(uint16_t group, uint16_t element) +DocEntry *Document::GetDocEntryByNumber(uint16_t group, uint16_t element) { TagKey key = DictEntry::TranslateToKey(group, element); if ( !TagHT.count(key)) @@ -1235,34 +1046,59 @@ DocEntry* Document::GetDocEntryByNumber(uint16_t group, uint16_t element) * ValEntry. * @return When present, the corresponding ValEntry. */ -ValEntry* Document::GetValEntryByNumber(uint16_t group, uint16_t element) +ValEntry *Document::GetValEntryByNumber(uint16_t group, uint16_t element) +{ + DocEntry *currentEntry = GetDocEntryByNumber(group, element); + if ( !currentEntry ) + { + return 0; + } + if ( ValEntry *entry = dynamic_cast(currentEntry) ) + { + return entry; + } + Debug::Verbose(0, "Document::GetValEntryByNumber: unfound ValEntry."); + + return 0; +} + +/** + * \brief Same as \ref Document::GetDocEntryByNumber except it only + * returns a result when the corresponding entry is of type + * BinEntry. + * @return When present, the corresponding BinEntry. + */ +BinEntry *Document::GetBinEntryByNumber(uint16_t group, uint16_t element) { - DocEntry* currentEntry = GetDocEntryByNumber(group, element); + DocEntry *currentEntry = GetDocEntryByNumber(group, element); if ( !currentEntry ) { return 0; } - if ( ValEntry* valEntry = dynamic_cast(currentEntry) ) + if ( BinEntry *entry = dynamic_cast(currentEntry) ) { - return valEntry; + return entry; } - dbg.Verbose(0, "Document::GetValEntryByNumber: unfound ValEntry."); + Debug::Verbose(0, "Document::GetBinEntryByNumber: unfound BinEntry."); return 0; } /** * \brief Loads the element while preserving the current - * underlying file position indicator as opposed to + * underlying file position indicator as opposed to * to LoadDocEntry that modifies it. * @param entry Header Entry whose value shall be loaded. * @return */ -void Document::LoadDocEntrySafe(DocEntry * entry) +void Document::LoadDocEntrySafe(DocEntry *entry) { - long PositionOnEntry = Fp->tellg(); - LoadDocEntry(entry); - Fp->seekg(PositionOnEntry, std::ios_base::beg); + if(Fp) + { + long PositionOnEntry = Fp->tellg(); + LoadDocEntry(entry); + Fp->seekg(PositionOnEntry, std::ios::beg); + } } /** @@ -1290,7 +1126,7 @@ uint32_t Document::SwapLong(uint32_t a) break; default : //std::cout << "swapCode= " << SwapCode << std::endl; - dbg.Error(" Document::SwapLong : unset swap code"); + Debug::Error(" Document::SwapLong : unset swap code"); a = 0; } return a; @@ -1339,6 +1175,12 @@ void Document::ParseDES(DocEntrySet *set, long offset, long l_max, bool delim_mode) { DocEntry *newDocEntry = 0; + ValEntry *newValEntry; + BinEntry *newBinEntry; + SeqEntry *newSeqEntry; + VRKey vr; + bool used=false; + long offsetEntry,readEntry; while (true) { @@ -1346,26 +1188,64 @@ void Document::ParseDES(DocEntrySet *set, long offset, { break; } + + used=true; newDocEntry = ReadNextDocEntry( ); if ( !newDocEntry ) { break; } - VRKey vr = newDocEntry->GetVR(); - if ( vr != "SQ" ) + vr = newDocEntry->GetVR(); + newValEntry = dynamic_cast(newDocEntry); + newBinEntry = dynamic_cast(newDocEntry); + newSeqEntry = dynamic_cast(newDocEntry); + + if ( newValEntry || newBinEntry ) { + offsetEntry=newDocEntry->GetOffset(); + readEntry=newDocEntry->GetReadLength(); - if ( Global::GetVR()->IsVROfGdcmStringRepresentable(vr) ) + if ( newBinEntry ) + { + if ( ! Global::GetVR()->IsVROfBinaryRepresentable(vr) ) + { + ////// Neither ValEntry NOR BinEntry: should mean UNKOWN VR + Debug::Verbose(0, "Document::ParseDES: neither Valentry, " + "nor BinEntry. Probably unknown VR."); + } + + //////////////////// BinEntry or UNKOWN VR: + // When "this" is a Document the Key is simply of the + // form ( group, elem )... + if (Document *dummy = dynamic_cast< Document* > ( set ) ) + { + (void)dummy; + newBinEntry->SetKey( newBinEntry->GetKey() ); + } + // but when "this" is a SQItem, we are inserting this new + // valEntry in a sequence item, and the kay has the + // generalized form (refer to \ref BaseTagKey): + if (SQItem *parentSQItem = dynamic_cast< SQItem* > ( set ) ) + { + newBinEntry->SetKey( parentSQItem->GetBaseTagKey() + + newBinEntry->GetKey() ); + } + + LoadDocEntry( newBinEntry ); + if( !set->AddEntry( newBinEntry ) ) + { + //Expect big troubles if here + //delete newBinEntry; + used=false; + } + } + else { /////////////////////// ValEntry - ValEntry* newValEntry = - new ValEntry( newDocEntry->GetDictEntry() ); //LEAK - newValEntry->Copy( newDocEntry ); - // When "set" is a Document, then we are at the top of the // hierarchy and the Key is simply of the form ( group, elem )... - if (Document* dummy = dynamic_cast< Document* > ( set ) ) + if (Document *dummy = dynamic_cast< Document* > ( set ) ) { (void)dummy; newValEntry->SetKey( newValEntry->GetKey() ); @@ -1373,7 +1253,7 @@ void Document::ParseDES(DocEntrySet *set, long offset, // ...but when "set" is a SQItem, we are inserting this new // valEntry in a sequence item. Hence the key has the // generalized form (refer to \ref BaseTagKey): - if (SQItem* parentSQItem = dynamic_cast< SQItem* > ( set ) ) + if (SQItem *parentSQItem = dynamic_cast< SQItem* > ( set ) ) { newValEntry->SetKey( parentSQItem->GetBaseTagKey() + newValEntry->GetKey() ); @@ -1384,58 +1264,23 @@ void Document::ParseDES(DocEntrySet *set, long offset, if( !set->AddEntry( newValEntry ) ) { // If here expect big troubles - delete newValEntry; //otherwise mem leak + //delete newValEntry; //otherwise mem leak + used=false; } if (delimitor) { - delete newDocEntry; + if(!used) + delete newDocEntry; break; } if ( !delim_mode && ((long)(Fp->tellg())-offset) >= l_max) { - delete newDocEntry; + if(!used) + delete newDocEntry; break; } } - else - { - if ( ! Global::GetVR()->IsVROfGdcmBinaryRepresentable(vr) ) - { - ////// Neither ValEntry NOR BinEntry: should mean UNKOWN VR - dbg.Verbose(0, "Document::ParseDES: neither Valentry, " - "nor BinEntry. Probably unknown VR."); - } - - //////////////////// BinEntry or UNKOWN VR: -/* BinEntry* newBinEntry = - new BinEntry( newDocEntry->GetDictEntry() ); //LEAK - newBinEntry->Copy( newDocEntry );*/ - BinEntry* newBinEntry = new BinEntry( newDocEntry ); //LEAK - - // When "this" is a Document the Key is simply of the - // form ( group, elem )... - if (Document* dummy = dynamic_cast< Document* > ( set ) ) - { - (void)dummy; - newBinEntry->SetKey( newBinEntry->GetKey() ); - } - // but when "this" is a SQItem, we are inserting this new - // valEntry in a sequence item, and the kay has the - // generalized form (refer to \ref BaseTagKey): - if (SQItem* parentSQItem = dynamic_cast< SQItem* > ( set ) ) - { - newBinEntry->SetKey( parentSQItem->GetBaseTagKey() - + newBinEntry->GetKey() ); - } - - LoadDocEntry( newBinEntry ); - if( !set->AddEntry( newBinEntry ) ) - { - //Expect big troubles if here - delete newBinEntry; - } - } if ( ( newDocEntry->GetGroup() == 0x7fe0 ) && ( newDocEntry->GetElement() == 0x0010 ) ) @@ -1443,23 +1288,22 @@ void Document::ParseDES(DocEntrySet *set, long offset, TransferSyntaxType ts = GetTransferSyntax(); if ( ts == RLELossless ) { - long PositionOnEntry = Fp->tellg(); - Fp->seekg( newDocEntry->GetOffset(), std::ios_base::beg ); + long positionOnEntry = Fp->tellg(); + Fp->seekg( newDocEntry->GetOffset(), std::ios::beg ); ComputeRLEInfo(); - Fp->seekg( PositionOnEntry, std::ios_base::beg ); + Fp->seekg( positionOnEntry, std::ios::beg ); } else if ( IsJPEG() ) { - long PositionOnEntry = Fp->tellg(); - Fp->seekg( newDocEntry->GetOffset(), std::ios_base::beg ); + long positionOnEntry = Fp->tellg(); + Fp->seekg( newDocEntry->GetOffset(), std::ios::beg ); ComputeJPEGFragmentInfo(); - Fp->seekg( PositionOnEntry, std::ios_base::beg ); + Fp->seekg( positionOnEntry, std::ios::beg ); } } // Just to make sure we are at the beginning of next entry. - SkipToNextDocEntry(newDocEntry); - //delete newDocEntry; + SkipToNextDocEntry(offsetEntry,readEntry); } else { @@ -1477,16 +1321,13 @@ void Document::ParseDES(DocEntrySet *set, long offset, } } // no other way to create it ... - SeqEntry* newSeqEntry = - new SeqEntry( newDocEntry->GetDictEntry() ); - newSeqEntry->Copy( newDocEntry ); newSeqEntry->SetDelimitorMode( delim_mode ); // At the top of the hierarchy, stands a Document. When "set" // is a Document, then we are building the first depth level. // Hence the SeqEntry we are building simply has a depth // level of one: - if (Document* dummy = dynamic_cast< Document* > ( set ) ) + if (Document *dummy = dynamic_cast< Document* > ( set ) ) { (void)dummy; newSeqEntry->SetDepthLevel( 1 ); @@ -1495,7 +1336,7 @@ void Document::ParseDES(DocEntrySet *set, long offset, // But when "set" is allready a SQItem, we are building a nested // sequence, and hence the depth level of the new SeqEntry // we are building, is one level deeper: - if (SQItem* parentSQItem = dynamic_cast< SQItem* > ( set ) ) + if (SQItem *parentSQItem = dynamic_cast< SQItem* > ( set ) ) { newSeqEntry->SetDepthLevel( parentSQItem->GetDepthLevel() + 1 ); newSeqEntry->SetKey( parentSQItem->GetBaseTagKey() @@ -1511,11 +1352,12 @@ void Document::ParseDES(DocEntrySet *set, long offset, set->AddEntry( newSeqEntry ); if ( !delim_mode && ((long)(Fp->tellg())-offset) >= l_max) { - delete newDocEntry; break; } } - delete newDocEntry; + + if(!used) + delete newDocEntry; } } @@ -1523,7 +1365,7 @@ void Document::ParseDES(DocEntrySet *set, long offset, * \brief Parses a Sequence ( SeqEntry after SeqEntry) * @return parsed length for this level */ -void Document::ParseSQ( SeqEntry* seqEntry, +void Document::ParseSQ( SeqEntry *seqEntry, long offset, long l_max, bool delim_mode) { int SQItemNumber = 0; @@ -1531,7 +1373,7 @@ void Document::ParseSQ( SeqEntry* seqEntry, while (true) { - DocEntry* newDocEntry = ReadNextDocEntry(); + DocEntry *newDocEntry = ReadNextDocEntry(); if ( !newDocEntry ) { // FIXME Should warn user @@ -1586,13 +1428,13 @@ void Document::ParseSQ( SeqEntry* seqEntry, * the value specified with Document::SetMaxSizeLoadEntry() * @param entry Header Entry (Dicom Element) to be dealt with */ -void Document::LoadDocEntry(DocEntry* entry) +void Document::LoadDocEntry(DocEntry *entry) { uint16_t group = entry->GetGroup(); std::string vr = entry->GetVR(); uint32_t length = entry->GetLength(); - Fp->seekg((long)entry->GetOffset(), std::ios_base::beg); + Fp->seekg((long)entry->GetOffset(), std::ios::beg); // A SeQuence "contains" a set of Elements. // (fffe e000) tells us an Element is beginning @@ -1618,7 +1460,7 @@ void Document::LoadDocEntry(DocEntry* entry) std::ostringstream s; if (length > MaxSizeLoadEntry) { - if (BinEntry* binEntryPtr = dynamic_cast< BinEntry* >(entry) ) + if (BinEntry *binEntryPtr = dynamic_cast< BinEntry* >(entry) ) { //s << "gdcm::NotLoaded (BinEntry)"; s << GDCM_NOTLOADED; @@ -1628,7 +1470,7 @@ void Document::LoadDocEntry(DocEntry* entry) binEntryPtr->SetValue(s.str()); } // Be carefull : a BinEntry IS_A ValEntry ... - else if (ValEntry* valEntryPtr = dynamic_cast< ValEntry* >(entry) ) + else if (ValEntry *valEntryPtr = dynamic_cast< ValEntry* >(entry) ) { // s << "gdcm::NotLoaded. (ValEntry)"; s << GDCM_NOTLOADED; @@ -1646,12 +1488,12 @@ void Document::LoadDocEntry(DocEntry* entry) // to be sure we are at the end of the value ... Fp->seekg((long)entry->GetOffset()+(long)entry->GetLength(), - std::ios_base::beg); + std::ios::beg); return; } // When we find a BinEntry not very much can be done : - if (BinEntry* binEntryPtr = dynamic_cast< BinEntry* >(entry) ) + if (BinEntry *binEntryPtr = dynamic_cast< BinEntry* >(entry) ) { s << GDCM_BINLOADED; binEntryPtr->SetValue(s.str()); @@ -1717,8 +1559,8 @@ void Document::LoadDocEntry(DocEntry* entry) if( length % 2 ) { newValue = Util::DicomString(str, length+1); - //dbg.Verbose(0, "Warning: bad length: ", length ); - dbg.Verbose(0, "For string :", newValue.c_str()); + //Debug::Verbose(0, "Warning: bad length: ", length ); + Debug::Verbose(0, "For string :", newValue.c_str()); // Since we change the length of string update it length entry->SetReadLength(length+1); } @@ -1728,11 +1570,11 @@ void Document::LoadDocEntry(DocEntry* entry) } delete[] str; - if ( ValEntry* valEntry = dynamic_cast(entry) ) + if ( ValEntry *valEntry = dynamic_cast(entry) ) { if ( Fp->fail() || Fp->eof())//Fp->gcount() == 1 { - dbg.Verbose(1, "Document::LoadDocEntry", + Debug::Verbose(1, "Document::LoadDocEntry", "unread element value"); valEntry->SetValue(GDCM_UNREAD); return; @@ -1750,7 +1592,7 @@ void Document::LoadDocEntry(DocEntry* entry) } else { - dbg.Error(true, "Document::LoadDocEntry" + Debug::Error(true, "Document::LoadDocEntry" "Should have a ValEntry, here !"); } } @@ -1774,7 +1616,7 @@ void Document::FindDocEntryLength( DocEntry *entry ) // The following reserved two bytes (see PS 3.5-2003, section // "7.1.2 Data element structure with explicit vr", p 27) must be // skipped before proceeding on reading the length on 4 bytes. - Fp->seekg( 2L, std::ios_base::cur); + Fp->seekg( 2L, std::ios::cur); uint32_t length32 = ReadInt32(); if ( (vr == "OB" || vr == "OW") && length32 == 0xffffffff ) @@ -1794,9 +1636,9 @@ void Document::FindDocEntryLength( DocEntry *entry ) // until the end of the file. Hence we artificially fix the // the length and proceed. long currentPosition = Fp->tellg(); - Fp->seekg(0L,std::ios_base::end); + Fp->seekg(0L,std::ios::end); long lengthUntilEOF = (long)(Fp->tellg())-currentPosition; - Fp->seekg(currentPosition, std::ios_base::beg); + Fp->seekg(currentPosition, std::ios::beg); entry->SetLength(lengthUntilEOF); return; } @@ -1852,7 +1694,7 @@ void Document::FindDocEntryLength( DocEntry *entry ) // and the dictionary entry depending on them. uint16_t correctGroup = SwapShort( entry->GetGroup() ); uint16_t correctElem = SwapShort( entry->GetElement() ); - DictEntry* newTag = GetDictEntryByNumber( correctGroup, + DictEntry *newTag = GetDictEntryByNumber( correctGroup, correctElem ); if ( !newTag ) { @@ -1889,16 +1731,12 @@ void Document::FindDocEntryLength( DocEntry *entry ) /** * \brief Find the Value Representation of the current Dicom Element. - * @param entry + * @return Value Representation of the current Entry */ -void Document::FindDocEntryVR( DocEntry *entry ) +std::string Document::FindDocEntryVR() { if ( Filetype != ExplicitVR ) - { - return; - } - - char vr[3]; + return(GDCM_UNKNOWN); long positionOnEntry = Fp->tellg(); // Warning: we believe this is explicit VR (Value Representation) because @@ -1908,105 +1746,34 @@ void Document::FindDocEntryVR( DocEntry *entry ) // within an explicit VR file. Hence we make sure the present tag // is in explicit VR and try to fix things if it happens not to be // the case. - + + char vr[3]; Fp->read (vr, (size_t)2); vr[2] = 0; - if( !CheckDocEntryVR(entry, vr) ) + if( !CheckDocEntryVR(vr) ) { - Fp->seekg(positionOnEntry, std::ios_base::beg); - // When this element is known in the dictionary we shall use, e.g. for - // the semantics (see the usage of IsAnInteger), the VR proposed by the - // dictionary entry. Still we have to flag the element as implicit since - // we know now our assumption on expliciteness is not furfilled. - // avoid . - if ( entry->IsVRUnknown() ) - { - entry->SetVR("Implicit"); - } - entry->SetImplicitVR(); + Fp->seekg(positionOnEntry, std::ios::beg); + return(GDCM_UNKNOWN); } + return(vr); } /** * \brief Check the correspondance between the VR of the header entry * and the taken VR. If they are different, the header entry is * updated with the new VR. - * @param entry Header Entry to check * @param vr Dicom Value Representation * @return false if the VR is incorrect of if the VR isn't referenced * otherwise, it returns true */ -bool Document::CheckDocEntryVR(DocEntry *entry, VRKey vr) +bool Document::CheckDocEntryVR(VRKey vr) { - std::string msg; - bool realExplicit = true; - - // Assume we are reading a falsely explicit VR file i.e. we reached - // a tag where we expect reading a VR but are in fact we read the - // first to bytes of the length. Then we will interogate (through find) - // the dicom_vr dictionary with oddities like "\004\0" which crashes - // both GCC and VC++ implementations of the STL map. Hence when the - // expected VR read happens to be non-ascii characters we consider - // we hit falsely explicit VR tag. - - if ( !isalpha((unsigned char)vr[0]) && !isalpha((unsigned char)vr[1]) ) - { - realExplicit = false; - } - // CLEANME searching the dicom_vr at each occurence is expensive. // PostPone this test in an optional integrity check at the end // of parsing or only in debug mode. - if ( realExplicit && !Global::GetVR()->Count(vr) ) - { - realExplicit = false; - } - - if ( !realExplicit ) - { - // We thought this was explicit VR, but we end up with an - // implicit VR tag. Let's backtrack. - msg = Util::Format("Falsely explicit vr file (%04x,%04x)\n", - entry->GetGroup(), entry->GetElement()); - dbg.Verbose(1, "Document::FindVR: ", msg.c_str()); - - if( entry->GetGroup() % 2 && entry->GetElement() == 0x0000) - { - // Group length is UL ! - DictEntry* newEntry = NewVirtualDictEntry( - entry->GetGroup(), entry->GetElement(), - "UL", "FIXME", "Group Length"); - entry->SetDictEntry( newEntry ); - } + if ( !Global::GetVR()->IsValidVR(vr) ) return false; - } - - if ( entry->IsVRUnknown() ) - { - // When not a dictionary entry, we can safely overwrite the VR. - if( entry->GetElement() == 0x0000 ) - { - // Group length is UL ! - entry->SetVR("UL"); - } - else - { - entry->SetVR(vr); - } - } - else if ( entry->GetVR() != vr ) - { - // The VR present in the file and the dictionary disagree. We assume - // the file writer knew best and use the VR of the file. Since it would - // be unwise to overwrite the VR of a dictionary (since it would - // compromise it's next user), we need to clone the actual DictEntry - // and change the VR for the read one. - DictEntry* newEntry = NewVirtualDictEntry( - entry->GetGroup(), entry->GetElement(), - vr, "FIXME", entry->GetName()); - entry->SetDictEntry(newEntry); - } return true; } @@ -2094,7 +1861,7 @@ std::string Document::GetDocEntryValue(DocEntry *entry) * @param entry Entry to reverse transform * @return Reverse transformed entry value */ -std::string Document::GetDocEntryUnvalue(DocEntry* entry) +std::string Document::GetDocEntryUnvalue(DocEntry *entry) { if ( IsDocEntryAnInteger(entry) && entry->IsImplicitVR() ) { @@ -2155,12 +1922,14 @@ void Document::SkipDocEntry(DocEntry *entry) /** * \brief Skips to the begining of the next Header Entry * \warning NOT end user intended method ! - * @param entry entry to skip + * @param offset start of skipping + * @param readLgth length to skip + */ -void Document::SkipToNextDocEntry(DocEntry *entry) +void Document::SkipToNextDocEntry(long offset,long readLgth) { - Fp->seekg((long)(entry->GetOffset()), std::ios_base::beg); - Fp->seekg( (long)(entry->GetReadLength()), std::ios_base::cur); + Fp->seekg((long)(offset), std::ios::beg); + Fp->seekg( (long)(readLgth), std::ios::cur); } /** @@ -2188,7 +1957,7 @@ void Document::FixDocEntryFoundLength(DocEntry *entry, s << "Warning : Tag with uneven length " << foundLength << " in x(" << std::hex << gr << "," << el <<")" << std::dec; - dbg.Verbose(0, s.str().c_str()); + Debug::Verbose(0, s.str().c_str()); } //////// Fix for some naughty General Electric images. @@ -2253,7 +2022,7 @@ bool Document::IsDocEntryAnInteger(DocEntry *entry) { uint16_t element = entry->GetElement(); uint16_t group = entry->GetGroup(); - const std::string & vr = entry->GetVR(); + const std::string &vr = entry->GetVR(); uint32_t length = entry->GetLength(); // When we have some semantics on the element we just read, and if we @@ -2280,15 +2049,14 @@ bool Document::IsDocEntryAnInteger(DocEntry *entry) << std::hex << group << " , " << element << ") -before- position x(" << filePosition << ")" << "lgt : " << length; - dbg.Verbose(0, "Document::IsDocEntryAnInteger", s.str().c_str() ); + Debug::Verbose(0, "Document::IsDocEntryAnInteger", s.str().c_str() ); } } if ( vr == "UL" || vr == "US" || vr == "SL" || vr == "SS" ) { return true; - } - + } return false; } @@ -2326,9 +2094,9 @@ uint32_t Document::FindDocEntryLengthOB() if ( group != 0xfffe || ( ( elem != 0xe0dd ) && ( elem != 0xe000 ) ) ) { - dbg.Verbose(1, "Document::FindDocEntryLengthOB: neither an Item " + Debug::Verbose(1, "Document::FindDocEntryLengthOB: neither an Item " "tag nor a Sequence delimiter tag."); - Fp->seekg(positionOnEntry, std::ios_base::beg); + Fp->seekg(positionOnEntry, std::ios::beg); throw FormatUnexpected("Document::FindDocEntryLengthOB()", "Neither an Item tag nor a Sequence " "delimiter tag."); @@ -2349,7 +2117,7 @@ uint32_t Document::FindDocEntryLengthOB() break; } } - Fp->seekg( positionOnEntry, std::ios_base::beg); + Fp->seekg( positionOnEntry, std::ios::beg); return totalLength; } @@ -2405,7 +2173,7 @@ uint32_t Document::ReadInt32() void Document::SkipBytes(uint32_t nBytes) { //FIXME don't dump the returned value - Fp->seekg((long)nBytes, std::ios_base::cur); + Fp->seekg((long)nBytes, std::ios::cur); } /** @@ -2418,6 +2186,7 @@ void Document::Initialise() RefShaDict = NULL; RLEInfo = new RLEFramesInfo; JPEGInfo = new JPEGFragmentsInfo; + Filetype = Unknown; } /** @@ -2440,7 +2209,7 @@ bool Document::CheckSwap() uint32_t s32; uint16_t s16; - char deb[256]; //HEADER_LENGTH_TO_READ]; + char deb[256]; // First, compare HostByteOrder and NetworkByteOrder in order to // determine if we shall need to swap bytes (i.e. the Endian type). @@ -2455,12 +2224,12 @@ bool Document::CheckSwap() // The easiest case is the one of a DICOM header, since it possesses a // file preamble where it suffice to look for the string "DICM". - Fp->read(deb, HEADER_LENGTH_TO_READ); + Fp->read(deb, 256); char *entCur = deb + 128; if( memcmp(entCur, "DICM", (size_t)4) == 0 ) { - dbg.Verbose(1, "Document::CheckSwap:", "looks like DICOM Version3"); + Debug::Verbose(1, "Document::CheckSwap:", "looks like DICOM Version3"); // Next, determine the value representation (VR). Let's skip to the // first element (0002, 0000) and check there if we find "UL" @@ -2494,41 +2263,41 @@ bool Document::CheckSwap() // instead of just checking for UL, OB and UI !? group 0000 { Filetype = ExplicitVR; - dbg.Verbose(1, "Document::CheckSwap:", + Debug::Verbose(1, "Document::CheckSwap:", "explicit Value Representation"); } else { Filetype = ImplicitVR; - dbg.Verbose(1, "Document::CheckSwap:", + Debug::Verbose(1, "Document::CheckSwap:", "not an explicit Value Representation"); } if ( net2host ) { SwapCode = 4321; - dbg.Verbose(1, "Document::CheckSwap:", + Debug::Verbose(1, "Document::CheckSwap:", "HostByteOrder != NetworkByteOrder"); } else { SwapCode = 0; - dbg.Verbose(1, "Document::CheckSwap:", + Debug::Verbose(1, "Document::CheckSwap:", "HostByteOrder = NetworkByteOrder"); } // Position the file position indicator at first tag (i.e. // after the file preamble and the "DICM" string). - Fp->seekg(0, std::ios_base::beg); - Fp->seekg ( 132L, std::ios_base::beg); + Fp->seekg(0, std::ios::beg); + Fp->seekg ( 132L, std::ios::beg); return true; } // End of DicomV3 // Alas, this is not a DicomV3 file and whatever happens there is no file // preamble. We can reset the file position indicator to where the data // is (i.e. the beginning of the file). - dbg.Verbose(1, "Document::CheckSwap:", "not a DICOM Version3 file"); - Fp->seekg(0, std::ios_base::beg); + Debug::Verbose(1, "Document::CheckSwap:", "not a DICOM Version3 file"); + Fp->seekg(0, std::ios::beg); // Our next best chance would be to be considering a 'clean' ACR/NEMA file. // By clean we mean that the length of the first tag is written down. @@ -2540,7 +2309,7 @@ bool Document::CheckSwap() // representation of a 32 bits integer. Hence the following dirty // trick : s32 = *((uint32_t *)(entCur)); - + switch( s32 ) { case 0x00040000 : @@ -2602,7 +2371,7 @@ bool Document::CheckSwap() Filetype = ACR; return true; default : - dbg.Verbose(0, "Document::CheckSwap:", + Debug::Verbose(0, "Document::CheckSwap:", "ACR/NEMA unfound swap info (Really hopeless !)"); Filetype = Unknown; return false; @@ -2624,7 +2393,7 @@ bool Document::CheckSwap() */ void Document::SwitchSwapToBigEndian() { - dbg.Verbose(1, "Document::SwitchSwapToBigEndian", + Debug::Verbose(1, "Document::SwitchSwapToBigEndian", "Switching to BigEndian mode."); if ( SwapCode == 0 ) { @@ -2711,7 +2480,6 @@ void Document::HandleBrokenEndian(uint16_t group, uint16_t elem) reversedEndian--; SwitchSwapToBigEndian(); } - } /** @@ -2721,7 +2489,7 @@ void Document::HandleBrokenEndian(uint16_t group, uint16_t elem) * gets the VR, gets the length, gets the offset value) * @return On succes the newly created DocEntry, NULL on failure. */ -DocEntry* Document::ReadNextDocEntry() +DocEntry *Document::ReadNextDocEntry() { uint16_t group; uint16_t elem; @@ -2740,8 +2508,37 @@ DocEntry* Document::ReadNextDocEntry() } HandleBrokenEndian(group, elem); - DocEntry *newEntry = NewDocEntryByNumber(group, elem); - FindDocEntryVR(newEntry); + std::string vr = FindDocEntryVR(); + std::string realVR = vr; + + if( vr == GDCM_UNKNOWN) + { + DictEntry *dictEntry = GetDictEntryByNumber(group,elem); + if( dictEntry ) + realVR = dictEntry->GetVR(); + } + + DocEntry *newEntry; + if( Global::GetVR()->IsVROfSequence(realVR) ) + newEntry = NewSeqEntryByNumber(group, elem); + else if( Global::GetVR()->IsVROfStringRepresentable(realVR) ) + newEntry = NewValEntryByNumber(group, elem,vr); + else + newEntry = NewBinEntryByNumber(group, elem,vr); + + if( vr == GDCM_UNKNOWN ) + { + if( Filetype == ExplicitVR ) + { + // We thought this was explicit VR, but we end up with an + // implicit VR tag. Let's backtrack. + std::string msg; + msg = Util::Format("Falsely explicit vr file (%04x,%04x)\n", + newEntry->GetGroup(), newEntry->GetElement()); + Debug::Verbose(1, "Document::FindVR: ", msg.c_str()); + } + newEntry->SetImplicitVR(); + } try { @@ -2821,9 +2618,9 @@ bool Document::ReadTag(uint16_t testGroup, uint16_t testElement) s << std::hex << itemTagGroup << "," << itemTagElement << ")" << std::endl; s << " at address: " << (unsigned)currentPosition << std::endl; - dbg.Verbose(0, "Document::ReadItemTagLength: wrong Item Tag found:"); - dbg.Verbose(0, s.str().c_str()); - Fp->seekg(positionOnEntry, std::ios_base::beg); + Debug::Verbose(0, "Document::ReadItemTagLength: wrong Item Tag found:"); + Debug::Verbose(0, s.str().c_str()); + Fp->seekg(positionOnEntry, std::ios::beg); return false; } @@ -2862,7 +2659,7 @@ uint32_t Document::ReadTagLength(uint16_t testGroup, uint16_t testElement) s << "Basic Item Length is: " << itemLength << std::endl; s << " at address: " << (unsigned)currentPosition << std::endl; - dbg.Verbose(0, "Document::ReadItemTagLength: ", s.str().c_str()); + Debug::Verbose(0, "Document::ReadItemTagLength: ", s.str().c_str()); } return itemLength; } @@ -2884,7 +2681,7 @@ void Document::ReadAndSkipEncapsulatedBasicOffsetTable() // lengths, but we won't bother with such fuses for the time being. if ( itemLength != 0 ) { - char* basicOffsetTableItemValue = new char[itemLength + 1]; + char *basicOffsetTableItemValue = new char[itemLength + 1]; Fp->read(basicOffsetTableItemValue, itemLength); #ifdef GDCM_DEBUG @@ -2895,7 +2692,7 @@ void Document::ReadAndSkipEncapsulatedBasicOffsetTable() std::ostringstream s; s << " Read one length: "; s << std::hex << individualLength << std::endl; - dbg.Verbose(0, + Debug::Verbose(0, "Document::ReadAndSkipEncapsulatedBasicOffsetTable: ", s.str().c_str()); } @@ -2954,7 +2751,7 @@ void Document::ComputeRLEInfo() if ( nbRleSegments > 16 ) { // There should be at most 15 segments (refer to RLEFrame class) - dbg.Verbose(0, "Document::ComputeRLEInfo: too many segments."); + Debug::Verbose(0, "Document::ComputeRLEInfo: too many segments."); } uint32_t rleSegmentOffsetTable[16]; @@ -2983,7 +2780,7 @@ void Document::ComputeRLEInfo() SkipBytes(rleSegmentLength[nbRleSegments]); // Store the collected info - RLEFrame* newFrameInfo = new RLEFrame; + RLEFrame *newFrameInfo = new RLEFrame; newFrameInfo->NumberFragments = nbRleSegments; for( unsigned int uk = 1; uk <= nbRleSegments; uk++ ) { @@ -2997,8 +2794,8 @@ void Document::ComputeRLEInfo() // Delimiter Item': if ( !ReadTag(0xfffe, 0xe0dd) ) { - dbg.Verbose(0, "Document::ComputeRLEInfo: no sequence delimiter "); - dbg.Verbose(0, " item at end of RLE item sequence"); + Debug::Verbose(0, "Document::ComputeRLEInfo: no sequence delimiter "); + Debug::Verbose(0, " item at end of RLE item sequence"); } } @@ -3026,7 +2823,7 @@ void Document::ComputeJPEGFragmentInfo() long fragmentOffset = Fp->tellg(); // Store the collected info - JPEGFragment* newFragment = new JPEGFragment; + JPEGFragment *newFragment = new JPEGFragment; newFragment->Offset = fragmentOffset; newFragment->Length = fragmentLength; JPEGInfo->Fragments.push_back( newFragment ); @@ -3038,8 +2835,8 @@ void Document::ComputeJPEGFragmentInfo() // Delimiter Item': if ( !ReadTag(0xfffe, 0xe0dd) ) { - dbg.Verbose(0, "Document::ComputeRLEInfo: no sequence delimiter "); - dbg.Verbose(0, " item at end of JPEG item sequence"); + Debug::Verbose(0, "Document::ComputeRLEInfo: no sequence delimiter "); + Debug::Verbose(0, " item at end of JPEG item sequence"); } } @@ -3052,18 +2849,18 @@ void Document::ComputeJPEGFragmentInfo() * when recursively walking the given set. * @param set The structure to be traversed (recursively). */ -void Document::BuildFlatHashTableRecurse( TagDocEntryHT& builtHT, - DocEntrySet* set ) +void Document::BuildFlatHashTableRecurse( TagDocEntryHT &builtHT, + DocEntrySet *set ) { - if (ElementSet* elementSet = dynamic_cast< ElementSet* > ( set ) ) + if (ElementSet *elementSet = dynamic_cast< ElementSet* > ( set ) ) { - TagDocEntryHT const & currentHT = elementSet->GetTagHT(); + TagDocEntryHT const ¤tHT = elementSet->GetTagHT(); for( TagDocEntryHT::const_iterator i = currentHT.begin(); i != currentHT.end(); ++i) { - DocEntry* entry = i->second; - if ( SeqEntry* seqEntry = dynamic_cast(entry) ) + DocEntry *entry = i->second; + if ( SeqEntry *seqEntry = dynamic_cast(entry) ) { const ListSQItem& items = seqEntry->GetSQItems(); for( ListSQItem::const_iterator item = items.begin(); @@ -3079,15 +2876,15 @@ void Document::BuildFlatHashTableRecurse( TagDocEntryHT& builtHT, return; } - if (SQItem* SQItemSet = dynamic_cast< SQItem* > ( set ) ) + if (SQItem *SQItemSet = dynamic_cast< SQItem* > ( set ) ) { const ListDocEntry& currentList = SQItemSet->GetDocEntries(); for (ListDocEntry::const_iterator i = currentList.begin(); i != currentList.end(); ++i) { - DocEntry* entry = *i; - if ( SeqEntry* seqEntry = dynamic_cast(entry) ) + DocEntry *entry = *i; + if ( SeqEntry *seqEntry = dynamic_cast(entry) ) { const ListSQItem& items = seqEntry->GetSQItems(); for( ListSQItem::const_iterator item = items.begin(); @@ -3127,9 +2924,9 @@ void Document::BuildFlatHashTableRecurse( TagDocEntryHT& builtHT, * \ref BuildFlatHashTable again... * @return The flat std::map<> we juste build. */ -TagDocEntryHT* Document::BuildFlatHashTable() +TagDocEntryHT *Document::BuildFlatHashTable() { - TagDocEntryHT* FlatHT = new TagDocEntryHT; + TagDocEntryHT *FlatHT = new TagDocEntryHT; BuildFlatHashTableRecurse( *FlatHT, this ); return FlatHT; } @@ -3201,6 +2998,52 @@ bool Document::operator<(Document &document) return false; } + +/** + * \brief Re-computes the length of a ACR-NEMA/Dicom group from a DcmHeader + * @param filetype Type of the File to be written + */ +int Document::ComputeGroup0002Length( FileType filetype ) +{ + uint16_t gr, el; + std::string vr; + + int groupLength = 0; + bool found0002 = false; + + // for each zero-level Tag in the DCM Header + DocEntry *entry; + + Initialize(); + entry = GetNextEntry(); + while(entry) + { + gr = entry->GetGroup(); + + if (gr == 0x0002) + { + found0002 = true; + + el = entry->GetElement(); + vr = entry->GetVR(); + + if (filetype == ExplicitVR) + { + if ( (vr == "OB") || (vr == "OW") || (vr == "SQ") ) + { + groupLength += 4; // explicit VR AND OB, OW, SQ : 4 more bytes + } + } + groupLength += 2 + 2 + 4 + entry->GetLength(); + } + else if (found0002 ) + break; + + entry = GetNextEntry(); + } + return groupLength; +} + } // end namespace gdcm //-----------------------------------------------------------------------------