X-Git-Url: https://git.creatis.insa-lyon.fr/pubgit/?a=blobdiff_plain;f=src%2FgdcmDocument.cxx;h=a569ccac7c5d11c9649b53d9762fe03f64234130;hb=bde18845deffbd09ed1c154d28e09284ae39cd76;hp=ab150ec1196e13b5ab4c52f2f0e2dae1c8305131;hpb=5e64f1feb4d82a4da9893dca043212ac90807fe4;p=gdcm.git diff --git a/src/gdcmDocument.cxx b/src/gdcmDocument.cxx index ab150ec1..a569ccac 100644 --- a/src/gdcmDocument.cxx +++ b/src/gdcmDocument.cxx @@ -3,8 +3,8 @@ Program: gdcm Module: $RCSfile: gdcmDocument.cxx,v $ Language: C++ - Date: $Date: 2004/11/05 21:23:46 $ - Version: $Revision: 1.118 $ + Date: $Date: 2004/11/17 03:20:05 $ + Version: $Revision: 1.132 $ Copyright (c) CREATIS (Centre de Recherche et d'Applications en Traitement de l'Image). All rights reserved. See Doc/License.txt or @@ -28,7 +28,7 @@ #include // For nthos: -#ifdef _MSC_VER +#if defined(_MSC_VER) || defined(__BORLANDC__) #include #else #include @@ -90,6 +90,7 @@ Document::Document( std::string const & filename ) : ElementSet(-1) Filename = filename; Initialise(); + Fp = 0; if ( !OpenFile() ) { return; @@ -181,8 +182,12 @@ Document::Document( std::string const & filename ) : ElementSet(-1) */ Document::Document() : ElementSet(-1) { + Fp = 0; + SetMaxSizeLoadEntry(MAX_SIZE_LOAD_ELEMENT_VALUE); Initialise(); + SwapCode = 0; + Filetype = ExplicitVR; PrintLevel = 1; // 'Medium' print level by default } @@ -194,13 +199,6 @@ Document::~Document () RefPubDict = NULL; RefShaDict = NULL; - // Recursive clean up of sequences - for (TagDocEntryHT::const_iterator it = TagHT.begin(); - it != TagHT.end(); ++it ) - { - //delete it->second; //temp remove - } - TagHT.clear(); delete RLEInfo; delete JPEGInfo; } @@ -290,14 +288,11 @@ bool Document::IsReadable() return true; } - /** - * \brief Internal function that checks whether the Transfer Syntax given - * as argument is the one present in the current document. - * @param syntaxToCheck The transfert syntax we need to check against. - * @return True when SyntaxToCheck corresponds to the Transfer Syntax of - * the current document. False either when the document contains - * no Transfer Syntax, or when the Tranfer Syntaxes doesn't match. + * \brief Accessor to the Transfer Syntax (when present) of the + * current document (it internally handles reading the + * value from disk when only parsing occured). + * @return The encountered Transfer Syntax of the current document. */ TransferSyntaxType Document::GetTransferSyntax() { @@ -321,7 +316,7 @@ TransferSyntaxType Document::GetTransferSyntax() // for brain damaged headers return UnknownTS; } - while ( !isdigit(transfer[transfer.length()-1]) ) + while ( !isdigit((unsigned char)transfer[transfer.length()-1]) ) { transfer.erase(transfer.length()-1, 1); } @@ -413,6 +408,14 @@ FileType Document::GetFileType() */ std::ifstream* Document::OpenFile() { + if (Filename.length() == 0) return 0; + if(Fp) + { + dbg.Verbose( 0, + "Document::OpenFile is already opened when opening: ", + Filename.c_str()); + } + Fp = new std::ifstream(Filename.c_str(), std::ios::in | std::ios::binary); if(!Fp) @@ -426,8 +429,12 @@ std::ifstream* Document::OpenFile() uint16_t zero; Fp->read((char*)&zero, (size_t)2 ); - //ACR -- or DICOM with no Preamble -- - if( zero == 0x0008 || zero == 0x0800 || zero == 0x0002 || zero == 0x0200 ) + //ACR -- or DICOM with no Preamble; may start with a Shadow Group -- + if( + zero == 0x0001 || zero == 0x0100 || zero == 0x0002 || zero == 0x0200 || + zero == 0x0003 || zero == 0x0300 || zero == 0x0004 || zero == 0x0400 || + zero == 0x0005 || zero == 0x0500 || zero == 0x0006 || zero == 0x0600 || + zero == 0x0007 || zero == 0x0700 || zero == 0x0008 || zero == 0x0800 ) { return Fp; } @@ -441,7 +448,7 @@ std::ifstream* Document::OpenFile() return Fp; } - Fp->close(); + CloseFile(); dbg.Verbose( 0, "Document::OpenFile not DICOM/ACR (missing preamble)", Filename.c_str()); @@ -455,11 +462,14 @@ std::ifstream* Document::OpenFile() */ bool Document::CloseFile() { - Fp->close(); - delete Fp; - Fp = 0; + if( Fp ) + { + Fp->close(); + delete Fp; + Fp = 0; + } - return true; //FIXME how do we detect a non-close ifstream ? + return true; //FIXME how do we detect a non-close ifstream ? } /** @@ -526,7 +536,7 @@ void Document::Write(std::ofstream* fp, FileType filetype) * @param value (string) Value to be set * @param group Group number of the Entry * @param elem Element number of the Entry - * @param VR V(alue) R(epresentation) of the Entry -if private Entry- + * @param vr V(alue) R(epresentation) of the Entry -if private Entry- * \return pointer to the modified/created Header Entry (NULL when creation * failed). */ @@ -563,16 +573,17 @@ ValEntry* Document::ReplaceOrCreateByNumber( " NewDocEntryByNumber failed."); return NULL; } + valEntry = new ValEntry(currentEntry); + delete currentEntry; + if ( !AddEntry(valEntry)) { delete valEntry; dbg.Verbose(0, "Document::ReplaceOrCreateByNumber: AddEntry" " failed allthough this is a creation."); + return NULL; } - // This is the reason why NewDocEntryByNumber are a real - // bad habit !!! FIXME - delete currentEntry; } else { @@ -856,8 +867,8 @@ int Document::GetEntryLengthByNumber(uint16_t group, uint16_t element) * @param tagName name of the searched Dicom Element. * @return true when found */ -bool Document::SetEntryByName(std::string const & content, - TagName const & tagName) +bool Document::SetEntryByName( std::string const & content, + TagName const & tagName) { DictEntry *dictEntry = RefPubDict->GetDictEntryByName(tagName); if( !dictEntry ) @@ -944,10 +955,10 @@ bool Document::SetEntryByNumber(uint8_t*content, int lgth, //content = content + '\0'; // fing a trick to enlarge a binary field? } */ - BinEntry* a = (BinEntry *)TagHT[key]; - a->SetBinArea(content); - a->SetLength(lgth); - a->SetValue(GDCM_BINLOADED); + BinEntry* entry = (BinEntry *)TagHT[key]; + entry->SetBinArea(content); + entry->SetLength(lgth); + entry->SetValue(GDCM_BINLOADED); return true; } @@ -1028,13 +1039,13 @@ void* Document::GetEntryBinAreaByNumber(uint16_t group, uint16_t elem) * @param group group number of the Entry * @param elem element number of the Entry */ -void* Document::LoadEntryBinArea(uint16_t group, uint16_t elem) +void Document::LoadEntryBinArea(uint16_t group, uint16_t elem) { + // Search the corresponding DocEntry DocEntry *docElement = GetDocEntryByNumber(group, elem); if ( !docElement ) - { - return NULL; - } + return; + size_t o =(size_t)docElement->GetOffset(); Fp->seekg( o, std::ios_base::beg); size_t l = docElement->GetLength(); @@ -1042,27 +1053,30 @@ void* Document::LoadEntryBinArea(uint16_t group, uint16_t elem) if(!a) { dbg.Verbose(0, "Document::LoadEntryBinArea cannot allocate a"); - return NULL; + return; } + + // Read the value Fp->read((char*)a, l); if( Fp->fail() || Fp->eof() )//Fp->gcount() == 1 { delete[] a; - return NULL; + return; } - /// \todo Drop any already existing void area! JPR + + // Set the value to the DocEntry if( !SetEntryBinAreaByNumber( a, group, elem ) ) { + delete[] a; dbg.Verbose(0, "Document::LoadEntryBinArea setting failed."); } - return a; } /** * \brief Loads (from disk) the element content * when a string is not suitable * @param element Entry whose binArea is going to be loaded */ -void* Document::LoadEntryBinArea(BinEntry* element) +void Document::LoadEntryBinArea(BinEntry* element) { size_t o =(size_t)element->GetOffset(); Fp->seekg(o, std::ios_base::beg); @@ -1071,18 +1085,18 @@ void* Document::LoadEntryBinArea(BinEntry* element) if( !a ) { dbg.Verbose(0, "Document::LoadEntryBinArea cannot allocate a"); - return NULL; + return; } - element->SetBinArea((uint8_t*)a); + /// \todo check the result Fp->read((char*)a, l); if( Fp->fail() || Fp->eof()) //Fp->gcount() == 1 { delete[] a; - return NULL; + return; } - return a; + element->SetBinArea(a); } /** @@ -1100,12 +1114,14 @@ bool Document::SetEntryBinAreaByNumber(uint8_t* area, { return false; } + if ( BinEntry* binEntry = dynamic_cast(currentEntry) ) { binEntry->SetBinArea( area ); return true; } - return true; + + return false; } /** @@ -1304,10 +1320,10 @@ void Document::ParseDES(DocEntrySet *set, long offset, long l_max, bool delim_mode) { DocEntry *newDocEntry = 0; - + while (true) - { - if ( !delim_mode && (Fp->tellg()-offset) >= l_max) + { + if ( !delim_mode && ((long)(Fp->tellg())-offset) >= l_max) { break; } @@ -1325,7 +1341,7 @@ void Document::ParseDES(DocEntrySet *set, long offset, { /////////////////////// ValEntry ValEntry* newValEntry = - new ValEntry( newDocEntry->GetDictEntry() ); + new ValEntry( newDocEntry->GetDictEntry() ); //LEAK newValEntry->Copy( newDocEntry ); // When "set" is a Document, then we are at the top of the @@ -1344,13 +1360,19 @@ void Document::ParseDES(DocEntrySet *set, long offset, + newValEntry->GetKey() ); } - set->AddEntry( newValEntry ); LoadDocEntry( newValEntry ); - if (newValEntry->IsItemDelimitor()) + bool delimitor=newValEntry->IsItemDelimitor(); + if( !set->AddEntry( newValEntry ) ) + { + // If here expect big troubles + delete newValEntry; //otherwise mem leak + } + + if (delimitor) { break; } - if ( !delim_mode && (Fp->tellg()-offset) >= l_max) + if ( !delim_mode && ((long)(Fp->tellg())-offset) >= l_max) { break; } @@ -1365,9 +1387,10 @@ void Document::ParseDES(DocEntrySet *set, long offset, } //////////////////// BinEntry or UNKOWN VR: - BinEntry* newBinEntry = +/* BinEntry* newBinEntry = new BinEntry( newDocEntry->GetDictEntry() ); //LEAK - newBinEntry->Copy( newDocEntry ); + newBinEntry->Copy( newDocEntry );*/ + BinEntry* newBinEntry = new BinEntry( newDocEntry ); //LEAK // When "this" is a Document the Key is simply of the // form ( group, elem )... @@ -1385,8 +1408,12 @@ void Document::ParseDES(DocEntrySet *set, long offset, + newBinEntry->GetKey() ); } - set->AddEntry( newBinEntry ); LoadDocEntry( newBinEntry ); + if( !set->AddEntry( newBinEntry ) ) + { + //Expect big troubles if here + delete newBinEntry; + } } if ( ( newDocEntry->GetGroup() == 0x7fe0 ) @@ -1460,7 +1487,7 @@ void Document::ParseDES(DocEntrySet *set, long offset, l, delim_mode); } set->AddEntry( newSeqEntry ); - if ( !delim_mode && (Fp->tellg()-offset) >= l_max) + if ( !delim_mode && ((long)(Fp->tellg())-offset) >= l_max) { break; } @@ -1495,7 +1522,7 @@ void Document::ParseSQ( SeqEntry* seqEntry, break; } } - if ( !delim_mode && (Fp->tellg()-offset) >= l_max) + if ( !delim_mode && ((long)(Fp->tellg())-offset) >= l_max) { break; } @@ -1522,7 +1549,7 @@ void Document::ParseSQ( SeqEntry* seqEntry, seqEntry->AddEntry( itemSQ, SQItemNumber ); SQItemNumber++; - if ( !delim_mode && ( Fp->tellg() - offset ) >= l_max ) + if ( !delim_mode && ((long)(Fp->tellg())-offset ) >= l_max ) { break; } @@ -1575,7 +1602,7 @@ void Document::LoadDocEntry(DocEntry* entry) s << " x(" << std::hex << entry->GetLength() << ")"; binEntryPtr->SetValue(s.str()); } - // Be carefull : a BinEntry IS_A ValEntry ... + // Be carefull : a BinEntry IS_A ValEntry ... else if (ValEntry* valEntryPtr = dynamic_cast< ValEntry* >(entry) ) { // s << "gdcm::NotLoaded. (ValEntry)"; @@ -1743,7 +1770,7 @@ void Document::FindDocEntryLength( DocEntry *entry ) // the length and proceed. long currentPosition = Fp->tellg(); Fp->seekg(0L,std::ios_base::end); - long lengthUntilEOF = Fp->tellg() - currentPosition; + long lengthUntilEOF = (long)(Fp->tellg())-currentPosition; Fp->seekg(currentPosition, std::ios_base::beg); entry->SetLength(lengthUntilEOF); return; @@ -1898,7 +1925,7 @@ bool Document::CheckDocEntryVR(DocEntry *entry, VRKey vr) // expected VR read happens to be non-ascii characters we consider // we hit falsely explicit VR tag. - if ( !isalpha(vr[0]) && !isalpha(vr[1]) ) + if ( !isalpha((unsigned char)vr[0]) && !isalpha((unsigned char)vr[1]) ) { realExplicit = false; } @@ -2388,7 +2415,7 @@ bool Document::CheckSwap() uint32_t s32; uint16_t s16; - char deb[HEADER_LENGTH_TO_READ]; + char deb[256]; //HEADER_LENGTH_TO_READ]; // First, compare HostByteOrder and NetworkByteOrder in order to // determine if we shall need to swap bytes (i.e. the Endian type). @@ -2513,13 +2540,13 @@ bool Document::CheckSwap() // So, let's check if this file wouldn't happen to be 'dirty' ACR/NEMA, // i.e. the 'group length' element is not present : - // check the supposed to be 'group number' - // 0x0002 or 0x0004 or 0x0008 + // check the supposed-to-be 'group number' + // in ( 0x0001 .. 0x0008 ) // to determine ' SwapCode' value . // Only 0 or 4321 will be possible // (no oportunity to check for the formerly well known // ACR-NEMA 'Bad Big Endian' or 'Bad Little Endian' - // if unsuccessfull (i.e. neither 0x0002 nor 0x0200 etc -4, 8-) + // if unsuccessfull (i.e. neither 0x0002 nor 0x0200 etc -3, 4, ..., 8-) // the file IS NOT ACR-NEMA nor DICOM V3 // Find a trick to tell it the caller... @@ -2527,22 +2554,32 @@ bool Document::CheckSwap() switch ( s16 ) { + case 0x0001 : case 0x0002 : + case 0x0003 : case 0x0004 : - case 0x0008 : + case 0x0005 : + case 0x0006 : + case 0x0007 : + case 0x0008 : SwapCode = 0; Filetype = ACR; return true; + case 0x0100 : case 0x0200 : + case 0x0300 : case 0x0400 : - case 0x0800 : + case 0x0500 : + case 0x0600 : + case 0x0700 : + case 0x0800 : SwapCode = 4321; Filetype = ACR; return true; default : dbg.Verbose(0, "Document::CheckSwap:", - "ACR/NEMA unfound swap info (Really hopeless !)"); - Filetype = Unknown; + "ACR/NEMA unfound swap info (Really hopeless !)"); + Filetype = Unknown; return false; } // Then the only info we have is the net2host one. @@ -2554,6 +2591,7 @@ bool Document::CheckSwap() } } + /** * \brief Restore the unproperly loaded values i.e. the group, the element * and the dictionary entry depending on them. @@ -2621,6 +2659,35 @@ void Document::SetMaxSizePrintEntry(long newSize) +/** + * \brief Handle broken private tag from Philips NTSCAN + * where the endianess is being switch to BigEndian for no + * apparent reason + * @return no return + */ +void Document::HandleBrokenEndian(uint16_t group, uint16_t elem) +{ + // Endian reversion. Some files contain groups of tags with reversed endianess. + static int reversedEndian = 0; + // try to fix endian switching in the middle of headers + if ((group == 0xfeff) && (elem == 0x00e0)) + { + // start endian swap mark for group found + reversedEndian++; + SwitchSwapToBigEndian(); + // fix the tag + group = 0xfffe; + elem = 0xe000; + } + else if ((group == 0xfffe) && (elem == 0xe00d) && reversedEndian) + { + // end of reversed endian group + reversedEndian--; + SwitchSwapToBigEndian(); + } + +} + /** * \brief Read the next tag but WITHOUT loading it's value * (read the 'Group Number', the 'Element Number', @@ -2646,6 +2713,7 @@ DocEntry* Document::ReadNextDocEntry() return 0; } + HandleBrokenEndian(group, elem); DocEntry *newEntry = NewDocEntryByNumber(group, elem); FindDocEntryVR(newEntry); @@ -2863,7 +2931,7 @@ void Document::ComputeRLEInfo() dbg.Verbose(0, "Document::ComputeRLEInfo: too many segments."); } - uint32_t rleSegmentOffsetTable[15]; + uint32_t rleSegmentOffsetTable[16]; for( int k = 1; k <= 15; k++ ) { rleSegmentOffsetTable[k] = ReadInt32();