X-Git-Url: https://git.creatis.insa-lyon.fr/pubgit/?a=blobdiff_plain;f=src%2FgdcmDocument.cxx;h=bdf5a01c5f34398caf8704dc5d1d328b7844394e;hb=f0ea8af1179c35ddc83da32df10813899427214d;hp=eff4ffdc89a25269be33c07b408a2dca384fe4ce;hpb=fea9426f960497d2d9124ab532d2097f2915678f;p=gdcm.git diff --git a/src/gdcmDocument.cxx b/src/gdcmDocument.cxx index eff4ffdc..bdf5a01c 100644 --- a/src/gdcmDocument.cxx +++ b/src/gdcmDocument.cxx @@ -3,8 +3,8 @@ Program: gdcm Module: $RCSfile: gdcmDocument.cxx,v $ Language: C++ - Date: $Date: 2004/10/22 03:05:41 $ - Version: $Revision: 1.108 $ + Date: $Date: 2004/11/05 20:23:14 $ + Version: $Revision: 1.117 $ Copyright (c) CREATIS (Centre de Recherche et d'Applications en Traitement de l'Image). All rights reserved. See Doc/License.txt or @@ -36,38 +36,38 @@ namespace gdcm { - -// Implicit VR Little Endian -#define UI1_2_840_10008_1_2 "1.2.840.10008.1.2" -// Explicit VR Little Endian -#define UI1_2_840_10008_1_2_1 "1.2.840.10008.1.2.1" -// Deflated Explicit VR Little Endian -#define UI1_2_840_10008_1_2_1_99 "1.2.840.10008.1.2.1.99" -// Explicit VR Big Endian -#define UI1_2_840_10008_1_2_2 "1.2.840.10008.1.2.2" -// JPEG Baseline (Process 1) -#define UI1_2_840_10008_1_2_4_50 "1.2.840.10008.1.2.4.50" -// JPEG Extended (Process 2 & 4) -#define UI1_2_840_10008_1_2_4_51 "1.2.840.10008.1.2.4.51" -// JPEG Extended (Process 3 & 5) -#define UI1_2_840_10008_1_2_4_52 "1.2.840.10008.1.2.4.52" -// JPEG Spectral Selection, Non-Hierarchical (Process 6 & 8) -#define UI1_2_840_10008_1_2_4_53 "1.2.840.10008.1.2.4.53" -// JPEG Full Progression, Non-Hierarchical (Process 10 & 12) -#define UI1_2_840_10008_1_2_4_55 "1.2.840.10008.1.2.4.55" -// JPEG Lossless, Non-Hierarchical (Process 14) -#define UI1_2_840_10008_1_2_4_57 "1.2.840.10008.1.2.4.57" -// JPEG Lossless, Hierarchical, First-Order Prediction (Process 14, -// [Selection Value 1]) -#define UI1_2_840_10008_1_2_4_70 "1.2.840.10008.1.2.4.70" -// JPEG 2000 Lossless -#define UI1_2_840_10008_1_2_4_90 "1.2.840.10008.1.2.4.90" -// JPEG 2000 -#define UI1_2_840_10008_1_2_4_91 "1.2.840.10008.1.2.4.91" -// RLE Lossless -#define UI1_2_840_10008_1_2_5 "1.2.840.10008.1.2.5" -// UI1_1_2_840_10008_1_2_5 -#define str2num(str, typeNum) *((typeNum *)(str)) +static const char *TransferSyntaxStrings[] = { + // Implicit VR Little Endian + "1.2.840.10008.1.2", + // Explicit VR Little Endian + "1.2.840.10008.1.2.1", + // Deflated Explicit VR Little Endian + "1.2.840.10008.1.2.1.99", + // Explicit VR Big Endian + "1.2.840.10008.1.2.2", + // JPEG Baseline (Process 1) + "1.2.840.10008.1.2.4.50", + // JPEG Extended (Process 2 & 4) + "1.2.840.10008.1.2.4.51", + // JPEG Extended (Process 3 & 5) + "1.2.840.10008.1.2.4.52", + // JPEG Spectral Selection, Non-Hierarchical (Process 6 & 8) + "1.2.840.10008.1.2.4.53", + // JPEG Full Progression, Non-Hierarchical (Process 10 & 12) + "1.2.840.10008.1.2.4.55", + // JPEG Lossless, Non-Hierarchical (Process 14) + "1.2.840.10008.1.2.4.57", + // JPEG Lossless, Hierarchical, First-Order Prediction (Process 14, [Selection Value 1]) + "1.2.840.10008.1.2.4.70", + // JPEG 2000 Lossless + "1.2.840.10008.1.2.4.90", + // JPEG 2000 + "1.2.840.10008.1.2.4.91", + // RLE Lossless + "1.2.840.10008.1.2.5", + // Unknown + "Unknown Transfer Syntax" +}; //----------------------------------------------------------------------------- // Refer to Document::CheckSwap() @@ -84,8 +84,7 @@ const unsigned int Document::MAX_SIZE_PRINT_ELEMENT_VALUE = 0x7fffffff; * \brief constructor * @param filename file to be opened for parsing */ -Document::Document( std::string const & filename ) - : ElementSet(-1) +Document::Document( std::string const & filename ) : ElementSet(-1) { SetMaxSizeLoadEntry(MAX_SIZE_LOAD_ELEMENT_VALUE); Filename = filename; @@ -180,8 +179,7 @@ Document::Document( std::string const & filename ) * \brief This default constructor doesn't parse the file. You should * then invoke \ref Document::SetFileName and then the parsing. */ -Document::Document() - :ElementSet(-1) +Document::Document() : ElementSet(-1) { SetMaxSizeLoadEntry(MAX_SIZE_LOAD_ELEMENT_VALUE); Initialise(); @@ -299,12 +297,12 @@ bool Document::IsReadable() * the current document. False either when the document contains * no Transfer Syntax, or when the Tranfer Syntaxes doesn't match. */ -bool Document::IsGivenTransferSyntax(std::string const & syntaxToCheck) +TransferSyntaxType Document::GetTransferSyntax() { DocEntry *entry = GetDocEntryByNumber(0x0002, 0x0010); if ( !entry ) { - return false; + return UnknownTS; } // The entry might be present but not loaded (parsing and loading @@ -316,127 +314,32 @@ bool Document::IsGivenTransferSyntax(std::string const & syntaxToCheck) // The actual transfer (as read from disk) might be padded. We // first need to remove the potential padding. We can make the // weak assumption that padding was not executed with digits... - if ( transfer.length() == 0 ) { // for brain damaged headers - return false; + if ( transfer.length() == 0 ) + { + // for brain damaged headers + return UnknownTS; } - while ( ! isdigit(transfer[transfer.length()-1]) ) + while ( !isdigit(transfer[transfer.length()-1]) ) { transfer.erase(transfer.length()-1, 1); } - if ( transfer == syntaxToCheck ) + for (int i = 0; TransferSyntaxStrings[i] != NULL; i++) { - return true; + if ( TransferSyntaxStrings[i] == transfer ) + { + return TransferSyntaxType(i); + } } } - return false; + return UnknownTS; } -/** - * \brief Determines if the Transfer Syntax of the present document - * corresponds to a Implicit Value Representation of - * Little Endian. - * \sa \ref Document::IsGivenTransferSyntax. - * @return True when ImplicitVRLittleEndian found. False in all other cases. - */ -bool Document::IsImplicitVRLittleEndianTransferSyntax() -{ - return IsGivenTransferSyntax(UI1_2_840_10008_1_2); -} - -/** - * \brief Determines if the Transfer Syntax was already encountered - * and if it corresponds to a ExplicitVRLittleEndian one. - * @return True when ExplicitVRLittleEndian found. False in all other cases. - */ -bool Document::IsExplicitVRLittleEndianTransferSyntax() -{ - return IsGivenTransferSyntax(UI1_2_840_10008_1_2_1); -} - -/** - * \brief Determines if the Transfer Syntax was already encountered - * and if it corresponds to a DeflatedExplicitVRLittleEndian one. - * @return True when DeflatedExplicitVRLittleEndian found. False in all other cases. - */ -bool Document::IsDeflatedExplicitVRLittleEndianTransferSyntax() -{ - return IsGivenTransferSyntax(UI1_2_840_10008_1_2_1_99); -} - -/** - * \brief Determines if the Transfer Syntax was already encountered - * and if it corresponds to a Explicit VR Big Endian one. - * @return True when big endian found. False in all other cases. - */ -bool Document::IsExplicitVRBigEndianTransferSyntax() -{ - return IsGivenTransferSyntax(UI1_2_840_10008_1_2_2); -} - -/** - * \brief Determines if the Transfer Syntax was already encountered - * and if it corresponds to a JPEGBaseLineProcess1 one. - * @return True when JPEGBaseLineProcess1found. False in all other cases. - */ -bool Document::IsJPEGBaseLineProcess1TransferSyntax() -{ - return IsGivenTransferSyntax(UI1_2_840_10008_1_2_4_50); -} - -/** - * \brief Determines if the Transfer Syntax was already encountered - * and if it corresponds to a JPEGExtendedProcess2-4 one. - * @return True when JPEGExtendedProcess2-4 found. False in all other cases. - */ -bool Document::IsJPEGExtendedProcess2_4TransferSyntax() -{ - return IsGivenTransferSyntax(UI1_2_840_10008_1_2_4_51); -} - -/** - * \brief Determines if the Transfer Syntax was already encountered - * and if it corresponds to a JPEGExtendeProcess3-5 one. - * @return True when JPEGExtendedProcess3-5 found. False in all other cases. - */ -bool Document::IsJPEGExtendedProcess3_5TransferSyntax() -{ - return IsGivenTransferSyntax(UI1_2_840_10008_1_2_4_52); -} - -/** - * \brief Determines if the Transfer Syntax was already encountered - * and if it corresponds to a JPEGSpectralSelectionProcess6-8 one. - * @return True when JPEGSpectralSelectionProcess6-8 found. False in all - * other cases. - */ -bool Document::IsJPEGSpectralSelectionProcess6_8TransferSyntax() -{ - return IsGivenTransferSyntax(UI1_2_840_10008_1_2_4_53); -} - -/** - * \brief Determines if the Transfer Syntax was already encountered - * and if it corresponds to a RLE Lossless one. - * @return True when RLE Lossless found. False in all - * other cases. - */ -bool Document::IsRLELossLessTransferSyntax() -{ - return IsGivenTransferSyntax(UI1_2_840_10008_1_2_5); -} - -/** - * \brief Determines if Transfer Syntax was already encountered - * and if it corresponds to a JPEG Lossless one. - * @return True when RLE Lossless found. False in all - * other cases. - */ - bool Document::IsJPEGLossless() { - return ( IsGivenTransferSyntax(UI1_2_840_10008_1_2_4_55) - || IsGivenTransferSyntax(UI1_2_840_10008_1_2_4_57) - || IsGivenTransferSyntax(UI1_2_840_10008_1_2_4_70) ); + TransferSyntaxType r = GetTransferSyntax(); + return r == JPEGFullProgressionProcess10_12 + || r == JPEGLosslessProcess14 + || r == JPEGLosslessProcess14_1; } /** @@ -447,8 +350,8 @@ bool Document::IsJPEGLossless() */ bool Document::IsJPEG2000() { - return ( IsGivenTransferSyntax(UI1_2_840_10008_1_2_4_90) - || IsGivenTransferSyntax(UI1_2_840_10008_1_2_4_91) ); + TransferSyntaxType r = GetTransferSyntax(); + return r == JPEG2000Lossless || r == JPEG2000; } /** @@ -456,26 +359,26 @@ bool Document::IsJPEG2000() * of Jpeg encoded Pixel data. * @return True when any form of JPEG found. False otherwise. */ -bool Document::IsJPEGTransferSyntax() +bool Document::IsJPEG() { - return ( IsJPEGBaseLineProcess1TransferSyntax() - || IsJPEGExtendedProcess2_4TransferSyntax() - || IsJPEGExtendedProcess3_5TransferSyntax() - || IsJPEGSpectralSelectionProcess6_8TransferSyntax() - || IsJPEGLossless() - || IsJPEG2000() ); + TransferSyntaxType r = GetTransferSyntax(); + return r == JPEGBaselineProcess1 + || r == JPEGExtendedProcess2_4 + || r == JPEGExtendedProcess3_5 + || r == JPEGSpectralSelectionProcess6_8 + || IsJPEGLossless() + || IsJPEG2000(); } - /** * \brief Determines if the Transfer Syntax corresponds to encapsulated * of encoded Pixel Data (as opposed to native). * @return True when encapsulated. False when native. */ -bool Document::IsEncapsulateTransferSyntax() +bool Document::IsEncapsulate() { - return ( IsJPEGTransferSyntax() - || IsRLELossLessTransferSyntax() ); + TransferSyntaxType r = GetTransferSyntax(); + return IsJPEG() || r == RLELossless; } /** @@ -573,8 +476,9 @@ void Document::Write(std::ofstream* fp, FileType filetype) if (filetype == ImplicitVR) { - std::string implicitVRTransfertSyntax = UI1_2_840_10008_1_2; - ReplaceOrCreateByNumber(implicitVRTransfertSyntax,0x0002, 0x0010); + std::string ts = + Util::DicomString( TransferSyntaxStrings[ImplicitVRLittleEndian] ); + ReplaceOrCreateByNumber(ts, 0x0002, 0x0010); /// \todo Refer to standards on page 21, chapter 6.2 /// "Value representation": values with a VR of UI shall be @@ -586,8 +490,9 @@ void Document::Write(std::ofstream* fp, FileType filetype) if (filetype == ExplicitVR) { - std::string explicitVRTransfertSyntax = UI1_2_840_10008_1_2_1; - ReplaceOrCreateByNumber(explicitVRTransfertSyntax,0x0002, 0x0010); + std::string ts = + Util::DicomString( TransferSyntaxStrings[ExplicitVRLittleEndian] ); + ReplaceOrCreateByNumber(ts, 0x0002, 0x0010); /// \todo Refer to standards on page 21, chapter 6.2 /// "Value representation": values with a VR of UI shall be @@ -627,7 +532,7 @@ ValEntry* Document::ReplaceOrCreateByNumber( std::string const & value, uint16_t group, uint16_t elem, - std::string const & VR ) + TagName const & vr ) { ValEntry* valEntry = 0; DocEntry* currentEntry = GetDocEntryByNumber( group, elem); @@ -643,7 +548,7 @@ ValEntry* Document::ReplaceOrCreateByNumber( DictEntry* dictEntry = pubDict->GetDictEntryByNumber(group, elem); if (!dictEntry) { - currentEntry = NewDocEntryByNumber(group, elem,VR); + currentEntry = NewDocEntryByNumber(group, elem, vr); } else { @@ -706,7 +611,7 @@ BinEntry* Document::ReplaceOrCreateByNumber( int lgth, uint16_t group, uint16_t elem, - std::string const& VR ) + TagName const & vr ) { BinEntry* binEntry = 0; DocEntry* currentEntry = GetDocEntryByNumber( group, elem); @@ -723,7 +628,7 @@ BinEntry* Document::ReplaceOrCreateByNumber( if (!dictEntry) { - currentEntry = NewDocEntryByNumber(group, elem, VR); + currentEntry = NewDocEntryByNumber(group, elem, vr); } else { @@ -780,9 +685,7 @@ BinEntry* Document::ReplaceOrCreateByNumber( * \return pointer to the modified/created SeqEntry (NULL when creation * failed). */ -SeqEntry* Document::ReplaceOrCreateByNumber( - uint16_t group, - uint16_t elem) +SeqEntry* Document::ReplaceOrCreateByNumber( uint16_t group, uint16_t elem) { SeqEntry* b = 0; DocEntry* a = GetDocEntryByNumber( group, elem); @@ -809,7 +712,7 @@ SeqEntry* Document::ReplaceOrCreateByNumber( * \return boolean */ bool Document::ReplaceIfExistByNumber(std::string const & value, - uint16_t group, uint16_t elem ) + uint16_t group, uint16_t elem ) { SetEntryByNumber(value, group, elem); @@ -828,7 +731,7 @@ bool Document::ReplaceIfExistByNumber(std::string const & value, bool Document::CheckIfEntryExistByNumber(uint16_t group, uint16_t element ) { const std::string &key = DictEntry::TranslateToKey(group, element ); - return TagHT.count(key); + return TagHT.count(key) != 0; } /** @@ -840,7 +743,7 @@ bool Document::CheckIfEntryExistByNumber(uint16_t group, uint16_t element ) * @return Corresponding element value when it exists, * and the string GDCM_UNFOUND ("gdcm::Unfound") otherwise. */ -std::string Document::GetEntryByName(TagName const& tagName) +std::string Document::GetEntryByName(TagName const & tagName) { DictEntry* dictEntry = RefPubDict->GetDictEntryByName(tagName); if( !dictEntry ) @@ -873,7 +776,7 @@ std::string Document::GetEntryVRByName(TagName const& tagName) } DocEntry* elem = GetDocEntryByNumber(dictEntry->GetGroup(), - dictEntry->GetElement()); + dictEntry->GetElement()); return elem->GetVR(); } @@ -945,7 +848,8 @@ int Document::GetEntryLengthByNumber(uint16_t group, uint16_t element) * @param tagName name of the searched Dicom Element. * @return true when found */ -bool Document::SetEntryByName(std::string const & content,std::string const & tagName) +bool Document::SetEntryByName(std::string const & content, + TagName const & tagName) { DictEntry *dictEntry = RefPubDict->GetDictEntryByName(tagName); if( !dictEntry ) @@ -966,8 +870,7 @@ bool Document::SetEntryByName(std::string const & content,std::string const & ta * @param element element number of the Dicom Element to modify */ bool Document::SetEntryByNumber(std::string const& content, - uint16_t group, - uint16_t element) + uint16_t group, uint16_t element) { int c; int l; @@ -980,13 +883,10 @@ bool Document::SetEntryByNumber(std::string const& content, return false; } // Non even content must be padded with a space (020H)... - std::string finalContent = content; - if( finalContent.length() % 2 ) - { - finalContent += '\0'; // ... therefore we padd with (000H) .!?! - } + std::string finalContent = Util::DicomString( content.c_str() ); + assert( !(finalContent.size() % 2) ); valEntry->SetValue(finalContent); - + // Integers have a special treatement for their length: l = finalContent.length(); @@ -1019,10 +919,8 @@ bool Document::SetEntryByNumber(std::string const& content, * @param group group number of the Dicom Element to modify * @param element element number of the Dicom Element to modify */ -bool Document::SetEntryByNumber(uint8_t*content, - int lgth, - uint16_t group, - uint16_t element) +bool Document::SetEntryByNumber(uint8_t*content, int lgth, + uint16_t group, uint16_t element) { (void)lgth; //not used TagKey key = DictEntry::TranslateToKey(group, element); @@ -1058,8 +956,7 @@ bool Document::SetEntryByNumber(uint8_t*content, * @return true on success, false otherwise. */ bool Document::SetEntryLengthByNumber(uint32_t l, - uint16_t group, - uint16_t element) + uint16_t group, uint16_t element) { /// \todo use map methods, instead of multimap JPR TagKey key = DictEntry::TranslateToKey(group, element); @@ -1188,8 +1085,7 @@ void* Document::LoadEntryBinArea(BinEntry* element) * @return */ bool Document::SetEntryBinAreaByNumber(uint8_t* area, - uint16_t group, - uint16_t element) + uint16_t group, uint16_t element) { DocEntry* currentEntry = GetDocEntryByNumber(group, element); if ( !currentEntry ) @@ -1259,7 +1155,7 @@ void Document::UpdateShaEntries() * @return Corresponding Dicom Element when it exists, and NULL * otherwise. */ -DocEntry* Document::GetDocEntryByName(std::string const & tagName) +DocEntry* Document::GetDocEntryByName(TagName const & tagName) { DictEntry *dictEntry = RefPubDict->GetDictEntryByName(tagName); if( !dictEntry ) @@ -1280,8 +1176,7 @@ DocEntry* Document::GetDocEntryByName(std::string const & tagName) * @param element Element number of the searched Dicom Element * @return */ -DocEntry* Document::GetDocEntryByNumber(uint16_t group, - uint16_t element) +DocEntry* Document::GetDocEntryByNumber(uint16_t group, uint16_t element) { TagKey key = DictEntry::TranslateToKey(group, element); if ( !TagHT.count(key)) @@ -1297,8 +1192,7 @@ DocEntry* Document::GetDocEntryByNumber(uint16_t group, * ValEntry. * @return When present, the corresponding ValEntry. */ -ValEntry* Document::GetValEntryByNumber(uint16_t group, - uint16_t element) +ValEntry* Document::GetValEntryByNumber(uint16_t group, uint16_t element) { DocEntry* currentEntry = GetDocEntryByNumber(group, element); if ( !currentEntry ) @@ -1398,10 +1292,8 @@ uint16_t Document::UnswapShort(uint16_t a) * \brief Parses a DocEntrySet (Zero-level DocEntries or SQ Item DocEntries) * @return length of the parsed set. */ -void Document::ParseDES(DocEntrySet *set, - long offset, - long l_max, - bool delim_mode) +void Document::ParseDES(DocEntrySet *set, long offset, + long l_max, bool delim_mode) { DocEntry *newDocEntry = 0; @@ -1492,15 +1384,15 @@ void Document::ParseDES(DocEntrySet *set, if ( ( newDocEntry->GetGroup() == 0x7fe0 ) && ( newDocEntry->GetElement() == 0x0010 ) ) { - if ( IsRLELossLessTransferSyntax() ) + TransferSyntaxType ts = GetTransferSyntax(); + if ( ts == RLELossless ) { long PositionOnEntry = Fp->tellg(); Fp->seekg( newDocEntry->GetOffset(), std::ios_base::beg ); ComputeRLEInfo(); Fp->seekg( PositionOnEntry, std::ios_base::beg ); } - else - if ( IsJPEGTransferSyntax() ) + else if ( IsJPEG() ) { long PositionOnEntry = Fp->tellg(); Fp->seekg( newDocEntry->GetOffset(), std::ios_base::beg ); @@ -1574,7 +1466,7 @@ void Document::ParseDES(DocEntrySet *set, * @return parsed length for this level */ void Document::ParseSQ( SeqEntry* seqEntry, - long offset, long l_max, bool delim_mode) + long offset, long l_max, bool delim_mode) { int SQItemNumber = 0; bool dlm_mod; @@ -1693,7 +1585,8 @@ void Document::LoadDocEntry(DocEntry* entry) } // to be sure we are at the end of the value ... - Fp->seekg((long)entry->GetOffset()+(long)entry->GetLength(),std::ios_base::beg); + Fp->seekg((long)entry->GetOffset()+(long)entry->GetLength(), + std::ios_base::beg); return; } @@ -1755,15 +1648,28 @@ void Document::LoadDocEntry(DocEntry* entry) return; } - // We need an additional byte for storing \0 that is not on disk + // FIXME: We need an additional byte for storing \0 that is not on disk char *str = new char[length+1]; Fp->read(str, (size_t)length); - str[length] = '\0'; - std::string newValue = str; + str[length] = '\0'; //this is only useful when length is odd + // Special DicomString call to properly handle \0 and even length + std::string newValue; + if( length % 2 ) + { + newValue = Util::DicomString(str, length+1); + //dbg.Verbose(0, "Warning: bad length: ", length ); + dbg.Verbose(0, "For string :", newValue.c_str()); + // Since we change the length of string update it length + entry->SetReadLength(length+1); + } + else + { + newValue = Util::DicomString(str, length); + } delete[] str; if ( ValEntry* valEntry = dynamic_cast(entry) ) - { + { if ( Fp->fail() || Fp->eof())//Fp->gcount() == 1 { dbg.Verbose(1, "Document::LoadDocEntry", @@ -1873,7 +1779,8 @@ void Document::FindDocEntryLength( DocEntry *entry ) // big endian and proceed... if ( element == 0x0000 && length16 == 0x0400 ) { - if ( !IsExplicitVRBigEndianTransferSyntax() ) + TransferSyntaxType ts = GetTransferSyntax(); + if ( ts != ExplicitVRBigEndian ) { throw FormatError( "Document::FindDocEntryLength()", " not explicit VR." ); @@ -2204,7 +2111,7 @@ void Document::SkipToNextDocEntry(DocEntry *entry) * @param foundLength fist assumption about length */ void Document::FixDocEntryFoundLength(DocEntry *entry, - uint32_t foundLength) + uint32_t foundLength) { entry->SetReadLength( foundLength ); // will be updated only if a bug is found if ( foundLength == 0xffffffff) @@ -2286,7 +2193,7 @@ bool Document::IsDocEntryAnInteger(DocEntry *entry) { uint16_t element = entry->GetElement(); uint16_t group = entry->GetGroup(); - std::string vr = entry->GetVR(); + const std::string & vr = entry->GetVR(); uint32_t length = entry->GetLength(); // When we have some semantics on the element we just read, and if we @@ -2398,7 +2305,7 @@ uint16_t Document::ReadInt16() Fp->read ((char*)&g, (size_t)2); if ( Fp->fail() ) { - throw FormatError( "Document::ReadInt16()", " file error." ); + throw FormatError( "Document::ReadInt16()", " file error." ); } if( Fp->eof() ) { @@ -2791,8 +2698,18 @@ bool Document::ReadTag(uint16_t testGroup, uint16_t testElement) //// Read the Item Tag group and element, and make // sure they are what we expected: - uint16_t itemTagGroup = ReadInt16(); - uint16_t itemTagElement = ReadInt16(); + uint16_t itemTagGroup; + uint16_t itemTagElement; + try + { + itemTagGroup = ReadInt16(); + itemTagElement = ReadInt16(); + } + catch ( FormatError e ) + { + //std::cerr << e << std::endl; + return false; + } if ( itemTagGroup != testGroup || itemTagElement != testElement ) { std::ostringstream s; @@ -2893,7 +2810,8 @@ void Document::ReadAndSkipEncapsulatedBasicOffsetTable() */ void Document::ComputeRLEInfo() { - if ( ! IsRLELossLessTransferSyntax() ) + TransferSyntaxType ts = GetTransferSyntax(); + if ( ts != RLELossless ) { return; } @@ -2931,6 +2849,11 @@ void Document::ComputeRLEInfo() long frameOffset = Fp->tellg(); uint32_t nbRleSegments = ReadInt32(); + if ( nbRleSegments > 16 ) + { + // There should be at most 15 segments (refer to RLEFrame class) + dbg.Verbose(0, "Document::ComputeRLEInfo: too many segments."); + } uint32_t rleSegmentOffsetTable[15]; for( int k = 1; k <= 15; k++ ) @@ -2986,7 +2909,7 @@ void Document::ComputeRLEInfo() void Document::ComputeJPEGFragmentInfo() { // If you need to, look for comments of ComputeRLEInfo(). - if ( ! IsJPEGTransferSyntax() ) + if ( ! IsJPEG() ) { return; } @@ -3028,19 +2951,19 @@ void Document::ComputeJPEGFragmentInfo() * @param set The structure to be traversed (recursively). */ void Document::BuildFlatHashTableRecurse( TagDocEntryHT& builtHT, - DocEntrySet* set ) + DocEntrySet* set ) { if (ElementSet* elementSet = dynamic_cast< ElementSet* > ( set ) ) { - TagDocEntryHT* currentHT = elementSet->GetTagHT(); - for( TagDocEntryHT::const_iterator i = currentHT->begin(); - i != currentHT->end(); + TagDocEntryHT const & currentHT = elementSet->GetTagHT(); + for( TagDocEntryHT::const_iterator i = currentHT.begin(); + i != currentHT.end(); ++i) { DocEntry* entry = i->second; if ( SeqEntry* seqEntry = dynamic_cast(entry) ) { - ListSQItem& items = seqEntry->GetSQItems(); + const ListSQItem& items = seqEntry->GetSQItems(); for( ListSQItem::const_iterator item = items.begin(); item != items.end(); ++item) @@ -3056,15 +2979,15 @@ void Document::BuildFlatHashTableRecurse( TagDocEntryHT& builtHT, if (SQItem* SQItemSet = dynamic_cast< SQItem* > ( set ) ) { - ListDocEntry& currentList = SQItemSet->GetDocEntries(); - for (ListDocEntry::iterator i = currentList.begin(); - i != currentList.end(); - ++i) + const ListDocEntry& currentList = SQItemSet->GetDocEntries(); + for (ListDocEntry::const_iterator i = currentList.begin(); + i != currentList.end(); + ++i) { DocEntry* entry = *i; if ( SeqEntry* seqEntry = dynamic_cast(entry) ) { - ListSQItem& items = seqEntry->GetSQItems(); + const ListSQItem& items = seqEntry->GetSQItems(); for( ListSQItem::const_iterator item = items.begin(); item != items.end(); ++item)