X-Git-Url: https://git.creatis.insa-lyon.fr/pubgit/?a=blobdiff_plain;f=src%2FgdcmFile.cxx;h=1ad8c6a70c92dac89ba334c59bab418f62e7464b;hb=5e388c2be804f3d3502a2f6e1e1c0dd9457069d9;hp=189987accea4fe82f10ee617dc004136775a3ac2;hpb=4f189b7cd8d7aff962887245b7b30ede39b7856c;p=gdcm.git diff --git a/src/gdcmFile.cxx b/src/gdcmFile.cxx index 189987ac..1ad8c6a7 100644 --- a/src/gdcmFile.cxx +++ b/src/gdcmFile.cxx @@ -3,8 +3,8 @@ Program: gdcm Module: $RCSfile: gdcmFile.cxx,v $ Language: C++ - Date: $Date: 2005/10/24 16:00:48 $ - Version: $Revision: 1.290 $ + Date: $Date: 2005/11/02 10:15:04 $ + Version: $Revision: 1.299 $ Copyright (c) CREATIS (Centre de Recherche et d'Applications en Traitement de l'Image). All rights reserved. See Doc/License.txt or @@ -19,21 +19,21 @@ // // -------------- Remember ! ---------------------------------- // -// Image Position Patient (0020,0032): +// Image Position (Patient) (0020,0032): // If not found (ACR_NEMA) we try Image Position (0020,0030) // If not found (ACR-NEMA), we consider Slice Location (0020,1041) // or Location (0020,0050) // as the Z coordinate, // 0. for all the coordinates if nothing is found // -// Image Position (Patient) (0020,0032) VM=3 What is it used for? +// Image Position (Patient) (0020,0032) VM=3 // --> // The attribute Patient Orientation (0020,0020) from the General Image Module // is of type 2C and has the condition Required if image does not require // Image Orientation (0020,0037) and Image Position (0020,0032). // However, if the image does require the attributes // - Image Orientation (Patient) (0020,0037), VM=6 -// - Image Position Patient (0020,0032), VM=3 +// - Image Position (Patient) (0020,0032), VM=3 // then attribute Patient Orientation (0020,0020) should not be present // in the images. // @@ -65,7 +65,7 @@ // FFDR = Feet First-Decubitus Right // FFDL = Feet First-Decubitus Left -// we can also find +// we can also find (non standard!) // SEMIERECT // SUPINE @@ -491,7 +491,7 @@ float File::GetXSpacing() nbValue = entry->GetValueCount(); if( nbValue >= 3 ) xspacing = (float)entry->GetValue(2); - if( nbValue >= 2 ) + else if( nbValue >= 2 ) xspacing = (float)entry->GetValue(1); else xspacing = (float)entry->GetValue(0); @@ -631,7 +631,10 @@ float File::GetXOrigin() if( entry->GetValueCount() == 3 ) { - gdcmErrorMacro( entry->IsValueCountValid() ); + if (!entry->IsValueCountValid() ) + { + gdcmErrorMacro( "Invalid Value Count" ); + } return (float)entry->GetValue(0); } return 0.0f; @@ -659,7 +662,10 @@ float File::GetYOrigin() if( entry->GetValueCount() == 3 ) { - gdcmErrorMacro( entry->IsValueCountValid() ); + if (!entry->IsValueCountValid() ) + { + gdcmErrorMacro( "Invalid Value Count" ); + } return (float)entry->GetValue(1); } return 0.0f; @@ -680,7 +686,10 @@ float File::GetZOrigin() { if( entry->GetValueCount() == 3 ) { - gdcmErrorMacro( entry->IsValueCountValid() ); + if (!entry->IsValueCountValid() ) + { + gdcmErrorMacro( "Invalid Value Count" ); + } return (float)entry->GetValue(2); } gdcmWarningMacro( "Wrong Image Position Patient (0020,0032)"); @@ -692,7 +701,10 @@ float File::GetZOrigin() { if( entry->GetValueCount() == 3 ) { - gdcmErrorMacro( entry->IsValueCountValid() ); + if (!entry->IsValueCountValid() ) + { + gdcmErrorMacro( "Invalid Value Count" ); + } return (float)entry->GetValue(2); } gdcmWarningMacro( "Wrong Image Position (RET) (0020,0030)"); @@ -705,7 +717,10 @@ float File::GetZOrigin() { if( entry->GetValueCount() == 1 ) { - gdcmErrorMacro( entry->IsValueCountValid() ); + if (!entry->IsValueCountValid() ) + { + gdcmErrorMacro( "Invalid Value Count" ); + } return (float)entry->GetValue(0); // VM=1 ! } gdcmWarningMacro( "Wrong Slice Location (0020,1041)"); @@ -717,7 +732,10 @@ float File::GetZOrigin() { if( entry->GetValueCount() == 1 ) { - gdcmErrorMacro( entry->IsValueCountValid() ); + if (!entry->IsValueCountValid() ) + { + gdcmErrorMacro( "Invalid Value Count" ); + } return (float)entry->GetValue(0); } gdcmWarningMacro( "Wrong Location (0020,0050)"); @@ -845,7 +863,6 @@ int File::GetPlanarConfiguration() DataEntry *entry = GetDataEntry(0x0028,0x0006); if( !entry ) { - gdcmWarningMacro( "Not found : Planar Configuration (0028,0006)"); return 0; } return (int)entry->GetValue(0); @@ -1456,10 +1473,10 @@ bool File::Write(std::string fileName, FileType writetype) // Derma?.dcm does not have it...let's remove it FIXME FIXME if( writetype != JPEG ) - { + { int i_lgPix = GetEntryLength(GrPixel, NumPixel); if (i_lgPix != -2) - { + { // no (GrPixel, NumPixel) element std::string s_lgPix = Util::Format("%d", i_lgPix+12); s_lgPix = Util::DicomString( s_lgPix.c_str() ); @@ -1659,7 +1676,7 @@ void File::ComputeJPEGFragmentInfo() /** * \brief Assuming the internal file pointer \ref Document::Fp - * is placed at the beginning of a tag check whether this + * is placed at the beginning of a tag, check whether this * tag is (TestGroup, TestElem). * \warning On success the internal file pointer \ref Document::Fp * is modified to point after the tag. @@ -1694,15 +1711,17 @@ bool File::ReadTag(uint16_t testGroup, uint16_t testElem) return false; } if ( itemTagGroup != testGroup || itemTagElem != testElem ) - { - gdcmErrorMacro( "Wrong Item Tag found:" - << " We should have found tag (" - << DictEntry::TranslateToKey(testGroup,testElem) << ")" << std::endl - << " but instead we encountered tag (" - << DictEntry::TranslateToKey(itemTagGroup,itemTagElem) << ")" - << " at address: " << " 0x(" << std::hex - << (unsigned int)currentPosition << std::dec << ")" - ) ; + { + // in order not to pollute output we don't warn on 'delimitors' + if (itemTagGroup != 0xfffe || testGroup != 0xfffe ) + gdcmErrorMacro( "Wrong Item Tag found:" + << " We should have found tag (" + << DictEntry::TranslateToKey(testGroup,testElem) << ")" << std::endl + << " but instead we encountered tag (" + << DictEntry::TranslateToKey(itemTagGroup,itemTagElem) << ")" + << " at address: " << " 0x(" << std::hex + << (unsigned int)currentPosition << std::dec << ")" + ) ; Fp->seekg(positionOnEntry, std::ios::beg); return false; @@ -1729,7 +1748,9 @@ uint32_t File::ReadTagLength(uint16_t testGroup, uint16_t testElem) if ( !ReadTag(testGroup, testElem) ) { - gdcmErrorMacro( "ReadTag did not succeed for (" + // Avoid polutting output + if ( testGroup != 0xfffe ) + gdcmErrorMacro( "ReadTag did not succeed for (" << DictEntry::TranslateToKey(testGroup,testElem) << ")..." ); return 0; @@ -1786,21 +1807,6 @@ void File::ReadEncapsulatedBasicOffsetTable() // These are the deprecated method that one day should be removed (after the next release) #ifndef GDCM_LEGACY_REMOVE -/* - * brief Constructor (DEPRECATED : temporaryly kept not to break the API) - * param filename name of the file whose header we want to analyze - * deprecated do not use any longer - */ -File::File( std::string const &filename ) - :Document( ) -{ - RLEInfo = new RLEFramesInfo; - JPEGInfo = new JPEGFragmentsInfo; - - SetFileName( filename ); - Load( ); // gdcm::Document is first Loaded, then the 'File part' -} - /* * \ brief Loader. (DEPRECATED : temporaryly kept not to break the API) * @ param fileName file to be open for parsing