X-Git-Url: https://git.creatis.insa-lyon.fr/pubgit/?a=blobdiff_plain;f=src%2FgdcmFile.cxx;h=e2effd6364ac30f3e474a5be0c49944e66296270;hb=4c9538820452e8c3c68778df6c28ca084df6e00c;hp=5eeaab46cc3f99d11719e19b6c1f9aa6aa1806b2;hpb=f80897f63dcbc709e372abe4a248ddbff9f2b33c;p=gdcm.git diff --git a/src/gdcmFile.cxx b/src/gdcmFile.cxx index 5eeaab46..e2effd63 100644 --- a/src/gdcmFile.cxx +++ b/src/gdcmFile.cxx @@ -3,8 +3,8 @@ Program: gdcm Module: $RCSfile: gdcmFile.cxx,v $ Language: C++ - Date: $Date: 2005/11/28 11:54:51 $ - Version: $Revision: 1.310 $ + Date: $Date: 2006/02/16 20:06:14 $ + Version: $Revision: 1.315 $ Copyright (c) CREATIS (Centre de Recherche et d'Applications en Traitement de l'Image). All rights reserved. See Doc/License.txt or @@ -124,7 +124,7 @@ File::File(): /** * \brief Canonical destructor. */ -File::~File () +File::~File() { if ( RLEInfo ) delete RLEInfo; @@ -568,7 +568,6 @@ float File::GetYSpacing() * XOrigin, YOrigin, ZOrigin (of the top left image corner) * of 2 consecutive images, and the Orientation * Computing ZSpacing on a single image is not really meaningfull ! - * @return Z dimension of a voxel-to be */ float File::GetZSpacing() @@ -768,10 +767,14 @@ float File::GetZOrigin() /** * \brief gets the info from 0020,0037 : Image Orientation Patient * or from 0020 0035 : Image Orientation (RET) + * * (needed to organize DICOM files based on their x,y,z position) - * @param iop adress of the (6)float array to receive values - * @return true when one of the tag is found - * false when nothing is found + * + * @param iop adress of the (6)float array to receive values. + * (defaulted as 1.,0.,0.,0.,1.,0. if nothing -or inconsistent stuff- + * is found. + * @return true when one of the tag -with consistent values- is found + * false when nothing or inconsistent stuff - is found */ bool File::GetImageOrientationPatient( float iop[6] ) { @@ -790,6 +793,7 @@ bool File::GetImageOrientationPatient( float iop[6] ) << " Less than 6 values were found." ); return false; } + return true; } //For ACR-NEMA // 0020 0035 DS REL Image Orientation (RET) @@ -802,8 +806,9 @@ bool File::GetImageOrientationPatient( float iop[6] ) << "Less than 6 values were found." ); return false; } + return true; } - return true; + return false; } /** @@ -1153,7 +1158,7 @@ int File::GetLUTNbits() /** *\brief gets the info from 0028,1052 : Rescale Intercept - * @return Rescale Intercept + * @return Rescale Intercept. defaulted to 0.0 is not found or empty */ float File::GetRescaleIntercept() { @@ -1170,7 +1175,7 @@ float File::GetRescaleIntercept() /** *\brief gets the info from 0028,1053 : Rescale Slope - * @return Rescale Slope + * @return Rescale Slope. defaulted to 1.0 is not found or empty */ float File::GetRescaleSlope() { @@ -1496,7 +1501,7 @@ bool File::Write(std::string fileName, FileType writetype) e0000->SetString(sLen.str()); } - // FIXME : Derma?.dcm does not have it...let's remove it ?!? JPRx + /// \todo FIXME : Derma?.dcm does not have it...let's remove it ?!? JPRx if( writetype != JPEG ) { int i_lgPix = GetEntryLength(GrPixel, NumPixel); @@ -1580,7 +1585,7 @@ void File::ComputeRLEInfo() // Offset Table information on fragments of this current Frame. // Note that the fragment pixels themselves are not loaded // (but just skipped). - long frameOffset = Fp->tellg(); + long frameOffset = Fp->tellg(); // once per fragment uint32_t nbRleSegments = ReadInt32(); if ( nbRleSegments > 16 ) @@ -1627,7 +1632,7 @@ void File::ComputeRLEInfo() // Make sure that we encounter a 'Sequence Delimiter Item' // at the end of the item : - if ( !ReadTag(0xfffe, 0xe0dd) ) + if ( !ReadTag(0xfffe, 0xe0dd) ) // once per RLE File { gdcmWarningMacro( "No sequence delimiter item at end of RLE item sequence"); } @@ -1680,7 +1685,7 @@ void File::ComputeJPEGFragmentInfo() i++; } - long fragmentOffset = Fp->tellg(); + long fragmentOffset = Fp->tellg(); // Once per fragment // Store the collected info JPEGFragment *newFragment = new JPEGFragment; newFragment->SetOffset(fragmentOffset); @@ -1713,8 +1718,8 @@ void File::ComputeJPEGFragmentInfo() */ bool File::ReadTag(uint16_t testGroup, uint16_t testElem) { - long positionOnEntry = Fp->tellg(); - long currentPosition = Fp->tellg(); // On debugging purposes + long positionOnEntry = Fp->tellg(); // Only when reading fragments + //long currentPosition = positionOnEntry; // On debugging purposes // Read the Item Tag group and element, and make // sure they are what we expected: @@ -1735,7 +1740,7 @@ bool File::ReadTag(uint16_t testGroup, uint16_t testElem) return false; } if ( itemTagGroup != testGroup || itemTagElem != testElem ) - { + { // in order not to pollute output we don't warn on 'delimitors' if (itemTagGroup != 0xfffe || testGroup != 0xfffe ) gdcmWarningMacro( "Wrong Item Tag found:" @@ -1744,7 +1749,7 @@ bool File::ReadTag(uint16_t testGroup, uint16_t testElem) << " but instead we encountered tag (" << DictEntry::TranslateToKey(itemTagGroup,itemTagElem) << ")" << " at address: " << " 0x(" << std::hex - << (unsigned int)currentPosition << std::dec << ")" + << (unsigned int)positionOnEntry << std::dec << ")" ) ; Fp->seekg(positionOnEntry, std::ios::beg); @@ -1781,10 +1786,12 @@ uint32_t File::ReadTagLength(uint16_t testGroup, uint16_t testElem) } //// Then read the associated Item Length - long currentPosition = Fp->tellg(); + + // long currentPosition = Fp->tellg(); // save time // JPRx uint32_t itemLength = ReadInt32(); gdcmDebugMacro( "Basic Item Length is: " << itemLength - << " at address: " << std::hex << (unsigned int)currentPosition); +// << " at address: " << std::hex << (unsigned int)currentPosition + ); return itemLength; } @@ -1830,15 +1837,14 @@ void File::ReadEncapsulatedBasicOffsetTable() // These are the deprecated method that one day should be removed (after the next release) -//#ifndef GDCM_LEGACY_REMOVE +#ifndef GDCM_LEGACY_REMOVE /* * \ brief Loader. (DEPRECATED : temporaryly kept not to break the API) * @ param fileName file to be open for parsing * @ return false if file cannot be open or no swap info was found, * or no tag was found. - * @ deprecated Use the Load() [ + SetLoadMode() ] + SetFileName() functions instead + * @deprecated Use the Load() [ + SetLoadMode() ] + SetFileName() functions instead */ - /* bool File::Load( std::string const &fileName ) { GDCM_LEGACY_REPLACED_BODY(File::Load(std::string), "1.2", @@ -1849,8 +1855,7 @@ bool File::Load( std::string const &fileName ) return DoTheLoadingJob( ); } -*/ -//#endif +#endif //----------------------------------------------------------------------------- // Print