X-Git-Url: https://git.creatis.insa-lyon.fr/pubgit/?a=blobdiff_plain;f=src%2FgdcmFile.cxx;h=ef4814503b16b88530e0f8f05b890d40f892a784;hb=0bdb2cf3697eb9f09a5452bfb072563bc0f13e76;hp=da87e9ab9b2fd010ac2a2e53bdbf5dd72b6be98d;hpb=c003ab063e99853986884357c1284dfbabc4afff;p=gdcm.git diff --git a/src/gdcmFile.cxx b/src/gdcmFile.cxx index da87e9ab..ef481450 100644 --- a/src/gdcmFile.cxx +++ b/src/gdcmFile.cxx @@ -3,8 +3,8 @@ Program: gdcm Module: $RCSfile: gdcmFile.cxx,v $ Language: C++ - Date: $Date: 2005/10/25 12:41:30 $ - Version: $Revision: 1.293 $ + Date: $Date: 2005/10/27 09:52:33 $ + Version: $Revision: 1.298 $ Copyright (c) CREATIS (Centre de Recherche et d'Applications en Traitement de l'Image). All rights reserved. See Doc/License.txt or @@ -491,7 +491,7 @@ float File::GetXSpacing() nbValue = entry->GetValueCount(); if( nbValue >= 3 ) xspacing = (float)entry->GetValue(2); - if( nbValue >= 2 ) + else if( nbValue >= 2 ) xspacing = (float)entry->GetValue(1); else xspacing = (float)entry->GetValue(0); @@ -631,7 +631,10 @@ float File::GetXOrigin() if( entry->GetValueCount() == 3 ) { - gdcmErrorMacro( entry->IsValueCountValid() ); + if (!entry->IsValueCountValid() ) + { + gdcmErrorMacro( "Invalid Value Count" ); + } return (float)entry->GetValue(0); } return 0.0f; @@ -659,7 +662,10 @@ float File::GetYOrigin() if( entry->GetValueCount() == 3 ) { - gdcmErrorMacro( entry->IsValueCountValid() ); + if (!entry->IsValueCountValid() ) + { + gdcmErrorMacro( "Invalid Value Count" ); + } return (float)entry->GetValue(1); } return 0.0f; @@ -680,7 +686,10 @@ float File::GetZOrigin() { if( entry->GetValueCount() == 3 ) { - gdcmErrorMacro( entry->IsValueCountValid() ); + if (!entry->IsValueCountValid() ) + { + gdcmErrorMacro( "Invalid Value Count" ); + } return (float)entry->GetValue(2); } gdcmWarningMacro( "Wrong Image Position Patient (0020,0032)"); @@ -692,7 +701,10 @@ float File::GetZOrigin() { if( entry->GetValueCount() == 3 ) { - gdcmErrorMacro( entry->IsValueCountValid() ); + if (!entry->IsValueCountValid() ) + { + gdcmErrorMacro( "Invalid Value Count" ); + } return (float)entry->GetValue(2); } gdcmWarningMacro( "Wrong Image Position (RET) (0020,0030)"); @@ -705,7 +717,10 @@ float File::GetZOrigin() { if( entry->GetValueCount() == 1 ) { - gdcmErrorMacro( entry->IsValueCountValid() ); + if (!entry->IsValueCountValid() ) + { + gdcmErrorMacro( "Invalid Value Count" ); + } return (float)entry->GetValue(0); // VM=1 ! } gdcmWarningMacro( "Wrong Slice Location (0020,1041)"); @@ -717,7 +732,10 @@ float File::GetZOrigin() { if( entry->GetValueCount() == 1 ) { - gdcmErrorMacro( entry->IsValueCountValid() ); + if (!entry->IsValueCountValid() ) + { + gdcmErrorMacro( "Invalid Value Count" ); + } return (float)entry->GetValue(0); } gdcmWarningMacro( "Wrong Location (0020,0050)"); @@ -845,7 +863,6 @@ int File::GetPlanarConfiguration() DataEntry *entry = GetDataEntry(0x0028,0x0006); if( !entry ) { - gdcmWarningMacro( "Not found : Planar Configuration (0028,0006)"); return 0; } return (int)entry->GetValue(0); @@ -1456,10 +1473,10 @@ bool File::Write(std::string fileName, FileType writetype) // Derma?.dcm does not have it...let's remove it FIXME FIXME if( writetype != JPEG ) - { + { int i_lgPix = GetEntryLength(GrPixel, NumPixel); if (i_lgPix != -2) - { + { // no (GrPixel, NumPixel) element std::string s_lgPix = Util::Format("%d", i_lgPix+12); s_lgPix = Util::DicomString( s_lgPix.c_str() ); @@ -1790,21 +1807,6 @@ void File::ReadEncapsulatedBasicOffsetTable() // These are the deprecated method that one day should be removed (after the next release) #ifndef GDCM_LEGACY_REMOVE -/* - * brief Constructor (DEPRECATED : temporaryly kept not to break the API) - * param filename name of the file whose header we want to analyze - * deprecated do not use any longer - */ -File::File( std::string const &filename ) - :Document( ) -{ - RLEInfo = new RLEFramesInfo; - JPEGInfo = new JPEGFragmentsInfo; - - SetFileName( filename ); - Load( ); // gdcm::Document is first Loaded, then the 'File part' -} - /* * \ brief Loader. (DEPRECATED : temporaryly kept not to break the API) * @ param fileName file to be open for parsing