X-Git-Url: https://git.creatis.insa-lyon.fr/pubgit/?a=blobdiff_plain;f=src%2FgdcmVR.cxx;h=28bc8f5127f5c50d5db4462954ef61ea5fa41cbb;hb=df832cf7f90b4ca5aca2f628c1756fb276779fac;hp=3ce163c154a88b9413ad368634f910b7b652db2c;hpb=a59ed75f701bd4914d6ce1c21f0ec8d4c2e4f65f;p=gdcm.git diff --git a/src/gdcmVR.cxx b/src/gdcmVR.cxx index 3ce163c1..28bc8f51 100644 --- a/src/gdcmVR.cxx +++ b/src/gdcmVR.cxx @@ -3,8 +3,8 @@ Program: gdcm Module: $RCSfile: gdcmVR.cxx,v $ Language: C++ - Date: $Date: 2005/11/22 12:09:27 $ - Version: $Revision: 1.49 $ + Date: $Date: 2007/09/25 15:21:57 $ + Version: $Revision: 1.62 $ Copyright (c) CREATIS (Centre de Recherche et d'Applications en Traitement de l'Image). All rights reserved. See Doc/License.txt or @@ -25,7 +25,7 @@ #include #include -namespace gdcm +namespace GDCM_NAME_SPACE { //----------------------------------------------------------------------------- /// \brief auto generated function, to fill up the 'Value Representation' @@ -86,7 +86,7 @@ VR::~VR() /** * \brief Simple predicate that checks whether the given argument - * corresponds to the Value Representation of a \ref DataEntry . + * corresponds to the Value Representation of a DataEntry . * @param tested value representation to check for. */ bool VR::IsVROfBinaryRepresentable(VRKey const &tested) @@ -108,14 +108,13 @@ bool VR::IsVROfBinaryRepresentable(VRKey const &tested) */ bool VR::IsVROfStringRepresentable(VRKey const &tested) { - return tested == "AE" || tested == "AS" || tested == "CS" || tested == "DA" || tested == "DS" || tested == "FL" || - tested == "FD" || + tested == "FD" || tested == "IS" || tested == "LO" || tested == "LT" || @@ -160,7 +159,7 @@ unsigned short VR::GetAtomicElementLength(VRKey const &tested) if( tested == "OW" ) return 2; // Float string - if( tested == "OF" ) + if( tested == "OF" || tested == "OL") return 4; return 1; } @@ -171,6 +170,35 @@ unsigned short VR::GetAtomicElementLength(VRKey const &tested) bool VR::IsValidVR(VRKey const &key) { return vr.find(key) != vr.end(); +#ifdef USECOMPLETELYUNTESTEDCODE + // to avoid to search in a std::map of std::string, + // since each std::string is 2 characters longs, we check the array + // (29 char comparisons in the worst case!) + + // "RT" is an undocumented VR, found in some Siemens images. + // We added it here to be able to read these images. + // Dict/gdcmVR.dic, Document has to be updated, too. + static const char VRvalues[] = + "AEASATCSDADSDTFLFDISLOLTOBOWOLOFPNSHSLSQSSSTTMUIULUNUSUTRT"; + + //int nbVal = strlen(VRvalues)/2; // save CPU time. + int nbVal = 29; + + const char *pt = VRvalues; + for (int i=0;i