X-Git-Url: https://git.creatis.insa-lyon.fr/pubgit/?a=blobdiff_plain;f=src%2FgdcmVR.cxx;h=3e461697ba8c319de06d5007c58d3f486dcc807a;hb=39fbd17fa58bc80fb241a49f50aae236da7606fa;hp=66006a86f1971b9749ee32dfbca6a8e7b4f31169;hpb=251590eb8bbe0635858d05909052d11c6a7ba490;p=gdcm.git

diff --git a/src/gdcmVR.cxx b/src/gdcmVR.cxx
index 66006a86..3e461697 100644
--- a/src/gdcmVR.cxx
+++ b/src/gdcmVR.cxx
@@ -3,8 +3,8 @@
   Program:   gdcm
   Module:    $RCSfile: gdcmVR.cxx,v $
   Language:  C++
-  Date:      $Date: 2005/01/06 13:35:38 $
-  Version:   $Revision: 1.25 $
+  Date:      $Date: 2005/06/24 10:55:59 $
+  Version:   $Revision: 1.37 $
                                                                                 
   Copyright (c) CREATIS (Centre de Recherche et d'Applications en Traitement de
   l'Image). All rights reserved. See Doc/License.txt or
@@ -26,8 +26,13 @@
 
 namespace gdcm 
 {
-void FillDefaultVRDict(VRHT & vr);
 //-----------------------------------------------------------------------------
+/// \brief auto generated function, to fill up the 'Value Representation'
+///        Dictionnary, if relevant file is not found on user's disk
+void FillDefaultVRDict(VRHT &vr);
+
+//-----------------------------------------------------------------------------
+// Constructor / Destructor
 /**
  * \brief Constructor
  */
@@ -35,9 +40,9 @@ VR::VR()
 {
    std::string filename = DictSet::BuildDictPath() + DICT_VR;
    std::ifstream from(filename.c_str());
-   if(!from)
+   if ( !from )
    {
-      dbg.Verbose(2, "VR::VR: can't open dictionary", filename.c_str());
+      gdcmWarningMacro("Can't open dictionary" << filename.c_str());
       FillDefaultVRDict(vr);
    }
    else
@@ -58,7 +63,7 @@ VR::VR()
          from >> std::ws;
          from.getline(buff, 1024, '\n');
    
-         if(key != "")
+         if ( key != "" )
          {
             vr[key] = name;
          }
@@ -67,7 +72,6 @@ VR::VR()
    }
 }
 
-//-----------------------------------------------------------------------------
 /**
  * \brief Destructor
  */
@@ -76,108 +80,77 @@ VR::~VR()
    vr.clear();
 }
 
-//-----------------------------------------------------------------------------
-// Print
-/**
- * \brief   Print all 
- * @param   os The output stream to be written to.
- */
-void VR::Print(std::ostream &os) 
-{
-   std::ostringstream s;
-
-   for (VRHT::iterator it = vr.begin(); it != vr.end(); ++it)
-   {
-      s << "VR : " << it->first << " = " << it->second << std::endl;
-   }
-   os << s.str();
-}
-
 //-----------------------------------------------------------------------------
 // Public
 /**
  * \brief   Get the count for an element
  * @param   key key to count
  */
-int VR::Count(VRKey const & key) 
+int VR::Count(VRKey const &key) 
 {
    return vr.count(key);
 }
 
-//-----------------------------------------------------------------------------
 /**
- * \brief   Simple predicate that checks wether the given argument
+ * \brief   Simple predicate that checks whether the given argument
  *          corresponds to the Value Representation of a \ref BinEntry .
- *          This predicate is the negation of
- *          \ref VR::IsVROfGdcmStringRepresentable .
  * @param   tested value representation to check for.
  */
-bool VR::IsVROfGdcmBinaryRepresentable(VRKey const & tested)
+bool VR::IsVROfBinaryRepresentable(VRKey const &tested)
 {
-   //std::cout << "VR::IsVROfGdcmBinaryRepresentable===================="
-   //   << tested << std::endl;
-
    if ( tested == GDCM_UNKNOWN)
       return true;
 
-   if ( ! IsValidVR(tested) )
-   {
-      dbg.Verbose(0, "VR::IsVROfGdcmBinaryRepresentable: tested not a VR!");
+   if ( IsVROfStringRepresentable(tested) )
       return false;
-   }
 
-   if ( IsVROfGdcmStringRepresentable(tested) )
-   {
-      dbg.Verbose(0, "VR::IsVROfGdcmBinaryRepresentable: binary VR !");
+   if ( IsVROfSequence(tested) )
       return false;
-   }
 
    return true;
 }
 
-//-----------------------------------------------------------------------------
 /**
- * \brief   Simple predicate that checks wether the given argument
+ * \brief   Simple predicate that checks whether the given argument
  *          corresponds to the Value Representation of a \ref ValEntry
  *          but NOT a \ref BinEntry.
- * @param   tested value representation to check for.
+ * @param   tested value representation to be checked.
  */
-bool VR::IsVROfGdcmStringRepresentable(VRKey const & tested)
+bool VR::IsVROfStringRepresentable(VRKey const &tested)
 {
+   return tested == "AE" ||
+          tested == "AS" ||
+          tested == "CS" ||
+          tested == "DA" ||
+          tested == "DS" ||
+          tested == "IS" || 
+          tested == "LO" ||
+          tested == "LT" ||
+          tested == "PN" ||
+          tested == "SH" ||
+          tested == "SL" ||
+          tested == "SS" ||
+          tested == "ST" ||
+          tested == "TM" ||
+          tested == "UI" ||
+          tested == "UL" ||
+          tested == "UN" ||
+          tested == "US";
+}
 
-   if ( ! IsValidVR(tested) )
-   {
-      dbg.Verbose(0, "VR::IsVROfGdcmStringRepresentable: tested not a VR!");
-      return false;
-   }
-
-   if ( tested == "AE" ||
-        tested == "AS" ||
-        tested == "CS" ||
-        tested == "DA" ||
-        tested == "DS" ||
-        tested == "IS" || 
-        tested == "LO" ||
-        tested == "LT" ||
-        tested == "PN" ||
-        tested == "SH" ||
-        tested == "SL" ||
-        tested == "SS" ||
-        tested == "ST" ||
-        tested == "TM" ||
-        tested == "UI" ||
-        tested == "UL" ||
-        tested == "UN" ||
-        tested == "US" )
-   {
-      return true;
-   }
-   return false;
+/**
+ * \brief   Simple predicate that checks whether the given argument
+ *          corresponds to the Value Representation of a \ref SeqEntry
+ * @param   tested value representation to check for.
+ */
+bool VR::IsVROfSequence(VRKey const &tested)
+{
+   return tested == "SQ";
 }
 
-bool VR::IsValidVR(VRKey const & key)
+bool VR::IsValidVR(VRKey const &key)
 {
-   return(vr.find(key)!=vr.end());
+   return vr.find(key) != vr.end();
 }
 
 //-----------------------------------------------------------------------------
@@ -187,5 +160,21 @@ bool VR::IsValidVR(VRKey const & key)
 // Private
 
 //-----------------------------------------------------------------------------
+// Print
+/**
+ * \brief   Print all 
+ * @param   os The output stream to be written to.
+ */
+void VR::Print(std::ostream &os) 
+{
+   std::ostringstream s;
+
+   for (VRHT::iterator it = vr.begin(); it != vr.end(); ++it)
+   {
+      s << "VR : " << it->first << " = " << it->second << std::endl;
+   }
+   os << s.str();
+}
 
+//-----------------------------------------------------------------------------
 } // end namespace gdcm