From: jpr <jpr>
Date: Wed, 17 Mar 2004 14:45:13 +0000 (+0000)
Subject: passed some std::string as 'reference'
X-Git-Tag: Version0.5.bp~288
X-Git-Url: https://git.creatis.insa-lyon.fr/pubgit/?a=commitdiff_plain;h=fc8f963e32cfc0919160a3842d6da77e679fe320;p=gdcm.git

passed some std::string as 'reference'
---

diff --git a/src/gdcmDicomDir.cxx b/src/gdcmDicomDir.cxx
index f1c7e679..d61e5c11 100644
--- a/src/gdcmDicomDir.cxx
+++ b/src/gdcmDicomDir.cxx
@@ -37,11 +37,7 @@ gdcmDicomDir::gdcmDicomDir(const char *Name, bool parseDir,
 {
  // que l'on ai passe un root directory ou un DICOMDIR
  // et quelle que soit la valeur de parseDir,
- // on a lance gdcmParser
- 
- cout << "---------------------------------------------- " << Name <<endl;
- 
-
+ // on a lance gdcmParser 
       
    startMethod=            NULL;
    progressMethod=         NULL;
@@ -59,16 +55,16 @@ gdcmDicomDir::gdcmDicomDir(const char *Name, bool parseDir,
    metaElems=NULL;
 
 // gdcmParser already  executed
-// Si on a passe un root directory, on est assuré de n'avoir rien ramené
+// if user passed a root directory, sure we didn't get anything
 
    if( GetListEntry().begin()==GetListEntry().end() ) 
    {
-     // Si, en plus, parseDir == false, ca devrait etre une erreur
+     // if parseDir == false, it should be tagged as an error
       dbg.Verbose(0, "gdcmDicomDir::gdcmDicomDir : entry list empty");
 
       if(strlen(Name)==1 && Name[0]=='.') { // user passed '.' as Name
                                             // we get current directory name
-         char*dummy=(char*) malloc(1000); // TODO : check with Windoze
+         char*dummy=(char*) malloc(1000);   // TODO : check with Windoze
          getcwd(dummy,(size_t)1000);
          SetFileName(dummy); // will be converted into a string
          free(dummy);        // no longer needed   
diff --git a/src/gdcmDicomDirImage.cxx b/src/gdcmDicomDirImage.cxx
index 1d089869..c9fd47b7 100644
--- a/src/gdcmDicomDirImage.cxx
+++ b/src/gdcmDicomDirImage.cxx
@@ -7,7 +7,7 @@
 
 /**
  * \ingroup gdcmDicomDirImage
- * \brief   
+ * \brief  Constructor 
  * @param  begin  iterator (inside the gdcmParser chained list)
  *                on the first Header Entry (i.e Dicom Element)
  *                related to this "IMAGE" part
diff --git a/src/gdcmUtil.cxx b/src/gdcmUtil.cxx
index cfef1bee..42c176da 100644
--- a/src/gdcmUtil.cxx
+++ b/src/gdcmUtil.cxx
@@ -175,7 +175,7 @@ const std::string SEPARATOR = "/";
 /*
  * \brief   Get the (directory) path from a full path file name
  */
-std::string GetPath(std::string fullName)
+std::string GetPath(std::string &fullName)
 {
    int pos1=fullName.rfind("/");
    int pos2=fullName.rfind("\\");
@@ -190,7 +190,7 @@ std::string GetPath(std::string fullName)
 /*
  * \brief   Get the (last) name of a full path file name
  */
-std::string GetName(std::string fullName)
+std::string GetName(std::string &fullName)
 {   
   int fin=fullName.length()-1;
   char a =fullName.c_str()[fin];
diff --git a/src/gdcmUtil.h b/src/gdcmUtil.h
index 69cd609e..af4a6768 100644
--- a/src/gdcmUtil.h
+++ b/src/gdcmUtil.h
@@ -74,9 +74,9 @@ extern gdcmDebug dbg;
 char *_cleanString(char *v);
 std::string _CreateCleanString(std::string s);
 
-void NormalizePath(std::string &name);
-std::string GetPath(std::string fullName);
-std::string GetName(std::string fullName);
+void NormalizePath (std::string &name);
+std::string GetPath(std::string &fullName);
+std::string GetName(std::string &fullName);
 //-----------------------------------------------------------------------------
 #endif