malaterre [Thu, 28 Oct 2004 22:21:56 +0000 (22:21 +0000)]
ENH:
- cosmetic cleanup in TODO, we should remove entries fixed
- some other cleanup at some other places
- adding a first implementation for the binary_write function
- adding big endian flag in cmake cache
malaterre [Mon, 25 Oct 2004 04:47:41 +0000 (04:47 +0000)]
STYLE: ivars should start with a capital letter. Accessors should be const to avoid people starting modifying stuff (since this is a ref). remove virtual as style specify sub class shouldn't reuse the keyword (4)
malaterre [Mon, 25 Oct 2004 04:08:19 +0000 (04:08 +0000)]
STYLE: ivars should start with a capital letter. Accessors should be const to avoid people starting modifying stuff (since this is a ref). remove virtual as style specify sub class shouldn't reuse the keyword (3)
malaterre [Mon, 25 Oct 2004 03:35:19 +0000 (03:35 +0000)]
STYLE: ivars should start with a capital letter. Accessors should be const to avoid people starting modifying stuff (since this is a ref). remove virtual as style specify sub class shouldn't reuse the keyword (2)
malaterre [Mon, 25 Oct 2004 03:03:44 +0000 (03:03 +0000)]
STYLE: ivars should start with a capital letter. Accessors should be const to avoid people starting modifying stuff (since this is a ref). remove virtual as style specify sub class shouldn't reuse the keyword
frog [Fri, 22 Oct 2004 13:56:44 +0000 (13:56 +0000)]
* Doc/Dicom2004_Part5.pdf added (thanks to JPR).
* Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
new 2004 dictionaries added (thanks to JPR).
* FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
* CLEANUP_ROUND (15) for gdcmPixelConvert
- RLEFrame::NumberFragments is now of type unsigned int
- gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
no longer exists.
malaterre [Fri, 22 Oct 2004 04:13:24 +0000 (04:13 +0000)]
ENH: Initial work in gathering all transfer syntax accessors. clearly IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all ivars, but only one transfersyntax (class) ivar with equivalent method on the class.
malaterre [Fri, 22 Oct 2004 03:05:39 +0000 (03:05 +0000)]
ENH: Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be discussed (plus I didn't like having a 2000 lines patch not commited)
frog [Wed, 20 Oct 2004 22:31:51 +0000 (22:31 +0000)]
* src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
* CLEANUP_ROUND (14) for gdcmPixelConvert
- PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
- PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
- File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
CloseFile() anymore.
- File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
anymore and hence avoids storing a copy of PixelConvert::Decompressed
into File::Pixel_Data.
frog [Wed, 20 Oct 2004 14:30:38 +0000 (14:30 +0000)]
* src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
no longer depends on's programmers PMS = Preposterous Mood Swings ;).
* CLEANUP_ROUND (13) for gdcmPixelConvert
Substituted File::ParsePixelData() with PixelConvert::Print() new
method:
- src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
- src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
method to those classes.
- src/gdcmFile.[cxx|h]:
-- Added a ::Print() method.
-- PixelConverter is now a reference instead of a member.
-- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
gdcm_wrap.cxx to "understand" File::GetPixelConverter()
frog [Mon, 18 Oct 2004 12:49:19 +0000 (12:49 +0000)]
2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
* Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
collaboration diagram and inheritance diagram should be generated with
doxygen.
* Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
* gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
pointlessly wrapped (see
http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
* CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
- Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
- vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
- Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
- src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
-- File::Initialise: PixelConverter setup moved away to
PixelConverter::GrabInformationsFromHeader()
-- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
interpretation moved away to PixelConverter::BuildRGBImage()
frog [Fri, 15 Oct 2004 10:43:27 +0000 (10:43 +0000)]
* src/gdcmDebug.cxx last ditch attempt to get warning/error messages
displayed on Win32 when a brutal abort() occurs (because of uncatched
exception). See TODO new entry of this commit for more on this.
* TODO added new entry.
* CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
- HandleColor is no longer called from gdcmFile.cxx
- gdcmPixelConvert.cxx clean up on method arguments and internal
variable names for semantical coherence.
malaterre [Thu, 14 Oct 2004 22:35:01 +0000 (22:35 +0000)]
ENH: * Finished lossless transition, not only do we now read all lossless jpeg
images, without the need of the Cornwell lib, but we do read them properly now
* To reduce code (well to avoid code duplication), I defined a common place
for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
redefine symbols. This is not prefect but this the best solution I found for a
compilation time jpeg option.
malaterre [Thu, 14 Oct 2004 22:16:33 +0000 (22:16 +0000)]
ENH: Afterall change my mind we need a common place: gdcmJpeg to define the reading of jpeg file, then gdcmJpeg[8,12,16] are just a kludge because of this compile time option in ijg
malaterre [Thu, 14 Oct 2004 02:45:31 +0000 (02:45 +0000)]
ENH: Update the jpeg library. This patch is the result of the ijg lib + ls-patch freely available on the web under a BSD like license (aka Standford implementation) + 2 home-made patchs (one based on dcmtk bug-fixes and one from previous ijg bug-fixes in gdcm)
- Also removed all tabs using sed -i 's/\t/ /g' *.c *.h
frog [Wed, 13 Oct 2004 14:15:28 +0000 (14:15 +0000)]
* Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
* gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
matters, as stated in warning note at begining of %include section).
* src/gdcmDicomDir*.[cxx|h]: coding style
* src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
* src/gdcmJpeg8.cxx: doxygen fix.
* CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
from File:: to PixelConvert::.
frog [Tue, 12 Oct 2004 09:59:44 +0000 (09:59 +0000)]
* CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
- more code moved away from File:: to PixelConvert::
- fat setup of PixelConverter set in place in File::Initialise.
frog [Sun, 10 Oct 2004 16:43:58 +0000 (16:43 +0000)]
* CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
The JPEG fragments are now parsed at the same stage than the RLE
information. All code related to JPEG is now in gdcmPixelConvert:
- src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
- src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
export a gdcmFile:: method. Those are simply global functions
(for the time being this is better than having them attach to
either gdcmFile:: or gdcmPixelConvert::).
- src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
and stores the result in a gdcmJPEGFragmentsInfo.
- src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
code (among other stuff) moved away from gdcmFile:; to
gdcmPixelConvert::
malaterre [Sat, 9 Oct 2004 02:57:11 +0000 (02:57 +0000)]
:ENH: carefully one at a time modify gdcm src. For now rewrite gdcmDictEntry. Modify gdcmUtil to have a sprintf like method called Format. We should really do a gdcmUtil class to encapsulate all those globals fonctions.
frog [Fri, 8 Oct 2004 17:02:52 +0000 (17:02 +0000)]
* CLEANUP_ROUND (9) for gdcmPixelConvert
- src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
away from gdcmFile:: to gdcmPixelConvert::.
frog [Fri, 8 Oct 2004 16:27:19 +0000 (16:27 +0000)]
* CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
- src/gdcmRLE.cxx removed
- src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
- src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
- src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
frog [Fri, 8 Oct 2004 08:56:48 +0000 (08:56 +0000)]
* CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
- src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
clean up of RLE related code.
malaterre [Fri, 8 Oct 2004 04:43:37 +0000 (04:43 +0000)]
ENH: If possible move the stl include after the gdcm ones, to avoid vc warnings
deprecated eatwhite I wasn't able to find the ref in any c++ refs, only microsoft implement it, thus fallback to a more standart c++ approach. This is mainly to get rid of any 'c' like include header
- and some minor cleanups