]> Creatis software - gdcm.git/log
gdcm.git
18 years agoFix some comments
jpr [Fri, 17 Mar 2006 14:53:14 +0000 (14:53 +0000)]
Fix some comments

18 years agoExample a using new features .
jpr [Fri, 17 Mar 2006 14:51:46 +0000 (14:51 +0000)]
Example a using new features .
DO NOT use right now; checking not achieved !

18 years ago*** empty log message ***
jpr [Fri, 17 Mar 2006 14:46:17 +0000 (14:46 +0000)]
*** empty log message ***

18 years agoAdd ReWriteExtended.cxx to show the result of the new
jpr [Fri, 17 Mar 2006 14:40:47 +0000 (14:40 +0000)]
Add ReWriteExtended.cxx to show the result of the new
SetContentType((gdcm::ImageContentType)filecontent); method

18 years agoFix some comments
jpr [Fri, 17 Mar 2006 14:33:54 +0000 (14:33 +0000)]
Fix some comments

18 years agoinitialize enum to 1.
jpr [Fri, 17 Mar 2006 14:31:43 +0000 (14:31 +0000)]
initialize enum to 1.

18 years agoBUG: Newer version of the software on Siemens MR write proper lenght.
jpr [Tue, 14 Mar 2006 12:09:18 +0000 (12:09 +0000)]
BUG: Newer version of the software on Siemens MR write proper lenght.
GDCM was overriding without checking for wrong length first.
Can now read old (broken) and new Siemens DICOM files.
Thx to Mathieu.

18 years ago // User should ask gdcm to write an image in Explicit VR mode
jpr [Mon, 13 Mar 2006 14:44:07 +0000 (14:44 +0000)]
// User should ask gdcm to write an image in Explicit VR mode
    // only when he is sure the VR of *all* the DataElements is known.
    // i.e : when there are *only* Public Groups,
    // or *all* the Shadow Groups are fully described in
    // the relevant Shadow Dictionnary.
    // Let's just *dream* about it; *never* trust a user !
    // If he doesn't, it write process will produce an 'illegal' Dicom image.
    // (it doesn't bother most of Dicom readers, but ...
    // Therae are enought illegal Dicom image in the world.
    // Don't add illegal gdcm-written Dicom images !

In order to avoid furter troubles,
We turn to Implicit VR if at least the VR of one element is unknown.

18 years agoFix stupid and riskless) bug :
jpr [Fri, 10 Mar 2006 10:52:10 +0000 (10:52 +0000)]
Fix stupid and riskless) bug :
fffe e000 (Item) was droped out SQItem at read time
(was automatically re-added at write time)

18 years agoJust to avoid further gcm unexpected crash :
jpr [Wed, 8 Mar 2006 09:27:13 +0000 (09:27 +0000)]
Just to avoid further gcm unexpected crash :
Some G.E. private Transfert Syntax :-(

1.2.528.1.1001.4.1.1.2   Explicit VR, AMI Wavelet Progressive Lossy Compression  (G.E Private)
1.2.528.1.1001.4.2.1.1   Explicit VR, AMI JPEG Lossy Compression 8-bit (G.E Private)
1.2.528.1.1001.4.2.1.2   Explicit VR, AMI JPEG Lossy Compression 12-bit (G.E Private)
1.2.528.1.1001.4.4.1     Explicit VR, AMI ZLIB Lossless Compression (G.E Private)

18 years agoFix misstyping
jpr [Thu, 2 Mar 2006 17:12:19 +0000 (17:12 +0000)]
Fix misstyping

18 years agoFix misstyping in the comments (not in the code)
jpr [Wed, 1 Mar 2006 15:32:52 +0000 (15:32 +0000)]
Fix misstyping in the comments (not in the code)

18 years agoMinor comment fixes
jpr [Wed, 1 Mar 2006 10:15:12 +0000 (10:15 +0000)]
Minor comment fixes

18 years agoForget to commit this one !
jpr [Wed, 1 Mar 2006 09:53:24 +0000 (09:53 +0000)]
Forget to commit this one !

18 years agouse new SetContentType method.
jpr [Wed, 1 Mar 2006 09:51:56 +0000 (09:51 +0000)]
use new SetContentType method.

18 years agoSome clinical softwares refuse to perform some operations, when images are 'not
jpr [Wed, 1 Mar 2006 09:45:04 +0000 (09:45 +0000)]
Some clinical softwares refuse to perform some operations, when images are 'not
native' (i.e. SOP Class UID -> [Secondary Capture Image Storage]), and
gdcm-written images fail.

At write time, gdcm has absolutely *no way* to guess if the image is 'native' or
not.
User is now allowed to specifiy what he wants to do (*he* knows, not gdcm !)
using the method :
void FileHelper::SetContentType (ImageContentType c);
(if you find a more significant name, feel free to tell me ...)
just before writting.
We have to deal with 4 *very* different cases :
-1) user created ex nihilo his own image and wants to write it as a Dicom image.
    c : USER_OWN_IMAGE
-2) user modified the pixels of an existing image, using mathematical operations.
   c : FILTERED_IMAGE
-3) user created a new image, using existing images (eg MIP, MPR, cartography image)
   c : CREATED_IMAGE
-4) user modified/added some tags *without processing* the pixels (anonymization..
   c : UNMODIFIED_PIXELS_IMAGE

'Image Type'                  (0x0008,0x0008)
Conversion Type               (0x0008,0x0064)
are set to values supposed to be constistant (hope so)
The reminding of the private method FileHelper::CheckMandatoryElements() remains
unimpared.

18 years agoadd bool DataEntry::GetDSValue(std::vector <double> &valueVector) method.
jpr [Wed, 1 Mar 2006 09:29:29 +0000 (09:29 +0000)]
add bool DataEntry::GetDSValue(std::vector <double> &valueVector) method.

/**
 * \brief Gets a std::vector <double> holding the value(s) of a DS DataEntry
 * @param valueVector std::vector <double> of value(s)
 * \return false if VR not "DS" or DataEntry empty
 */
 Thx to Vicent Daanen for suggesting.

18 years ago> # Seems this one hangs on 64 bits processors ?!?
jpr [Tue, 28 Feb 2006 15:10:12 +0000 (15:10 +0000)]
>   # Seems this one hangs on 64 bits processors ?!?
>   # I blacklist it untill the pb is solved.
>   (to get some more green on the Dasboards)
>   "MR_Philips-Intera_BreaksNOSHADOW.dcm"

18 years agoRemove an empty line, to be sure the file is commited (and the Black list
jpr [Sun, 26 Feb 2006 15:48:48 +0000 (15:48 +0000)]
Remove an empty line, to be sure the file is commited (and the Black list
updated!)

18 years agoENH: Insert dummy value until a better solution is found
malaterre [Tue, 21 Feb 2006 15:55:41 +0000 (15:55 +0000)]
ENH: Insert dummy value until a better solution is found

18 years agoENH: One more sync with gdcm12
malaterre [Thu, 16 Feb 2006 21:27:41 +0000 (21:27 +0000)]
ENH: One more sync with gdcm12

18 years agoENH: Try to sync gdcm CVS and gdcm 1.2. ~2000 lines of changes, please be gentle...
malaterre [Thu, 16 Feb 2006 20:06:13 +0000 (20:06 +0000)]
ENH: Try to sync gdcm CVS and gdcm 1.2. ~2000 lines of changes, please be gentle if something breaks.

18 years agoUpdate comments on blacklisted images
jpr [Thu, 16 Feb 2006 17:02:38 +0000 (17:02 +0000)]
Update comments on blacklisted images

18 years agoBUG: Sync with ITK/gdcm CVS HEAD
malaterre [Wed, 15 Feb 2006 21:58:54 +0000 (21:58 +0000)]
BUG: Sync with ITK/gdcm CVS HEAD

18 years agoI Think I didn't black list the write one !
jpr [Mon, 13 Feb 2006 09:51:24 +0000 (09:51 +0000)]
I Think I didn't black list the write one !

18 years agoAdd
jpr [Mon, 13 Feb 2006 09:27:35 +0000 (09:27 +0000)]
Add
#include <typeinfo> // for typeif ,
needed by __BORLANDC__ version 6.
Thx to Luca Picello for the fix

18 years agoRevert to blacklist rle16sti.dcm
jpr [Fri, 10 Feb 2006 16:15:15 +0000 (16:15 +0000)]
Revert to blacklist rle16sti.dcm

18 years agoremove some now useless stuff
jpr [Thu, 9 Feb 2006 10:48:04 +0000 (10:48 +0000)]
remove some now useless stuff

18 years agoAdd comment on broken image
jpr [Thu, 9 Feb 2006 10:46:53 +0000 (10:46 +0000)]
Add comment on broken image

18 years ago'if then', 'or else' don't exist in C++
jpr [Wed, 8 Feb 2006 17:34:47 +0000 (17:34 +0000)]
'if then', 'or else' don't exist in C++

18 years agoForgot to blacklist :
jpr [Wed, 8 Feb 2006 14:45:51 +0000 (14:45 +0000)]
Forgot to blacklist :
 "MR_Philips_Intera_in_SQ_2001_e05f_item_wrong_lgt_use_NOSHADOWSEQ.dcm"

18 years agoAvoid dciodvfy warning when creating ex-nihilo a Dicom File
jpr [Wed, 8 Feb 2006 10:13:55 +0000 (10:13 +0000)]
Avoid dciodvfy warning when creating ex-nihilo a Dicom File

18 years agoSome more tellg seekg removal
jpr [Tue, 7 Feb 2006 17:15:28 +0000 (17:15 +0000)]
Some more tellg seekg removal

18 years agoCOMP: Fix warning on bcc551
malaterre [Tue, 7 Feb 2006 16:05:13 +0000 (16:05 +0000)]
COMP: Fix warning on bcc551

18 years agoRemove some useless seekg, tellg.
jpr [Tue, 7 Feb 2006 12:37:19 +0000 (12:37 +0000)]
Remove some useless seekg, tellg.
Add redundant comments to make the sources grepable

18 years agoENH: Redo the BUILD_SHARED_LIBS -one more time- hopefully this time for real
malaterre [Sun, 5 Feb 2006 23:13:31 +0000 (23:13 +0000)]
ENH: Redo the BUILD_SHARED_LIBS -one more time- hopefully this time for real

18 years agoENH: update to openjpeg CVS
malaterre [Sun, 5 Feb 2006 22:20:18 +0000 (22:20 +0000)]
ENH: update to openjpeg CVS

18 years agoENH: Try to keep up with the openjpeg build changes
malaterre [Sun, 5 Feb 2006 21:59:20 +0000 (21:59 +0000)]
ENH: Try to keep up with the openjpeg build changes

18 years agomisstyping
jpr [Fri, 3 Feb 2006 18:00:53 +0000 (18:00 +0000)]
misstyping

18 years agotake into account taggrid
jpr [Fri, 3 Feb 2006 17:51:13 +0000 (17:51 +0000)]
take into account taggrid

18 years agoSome minor comments modifications
jpr [Fri, 3 Feb 2006 16:37:42 +0000 (16:37 +0000)]
Some minor comments modifications

18 years agoAvoid polluting the output
jpr [Thu, 2 Feb 2006 12:52:38 +0000 (12:52 +0000)]
Avoid polluting the output

18 years agoNew fashion Patient Name, to avoid dciodvfy warning
jpr [Thu, 2 Feb 2006 11:26:02 +0000 (11:26 +0000)]
New fashion Patient Name, to avoid dciodvfy warning

18 years agoSince we don't modify pixels -> keep unchanged the following :
jpr [Wed, 1 Feb 2006 10:46:53 +0000 (10:46 +0000)]
Since we don't modify pixels -> keep unchanged the following :
      // 'Media Storage SOP Class UID' (0x0002,0x0002)
      // 'SOP Class UID'               (0x0008,0x0016)
      // 'Image Type'                  (0x0008,0x0008)
      // 'Conversion Type'             (0x0008,0x0064)
 We use :
 fh->SetKeepMediaStorageSOPClassUID(true);

18 years agoNow the names will be correctly sorted.
jpr [Tue, 31 Jan 2006 15:28:54 +0000 (15:28 +0000)]
Now the names will be correctly sorted.
eg: patName_2 vs patName_100 / patName_002 vs patName_100

18 years agoSince grid tagging is quote either 'ROW' or 'COL' (nobody can guess it !),
jpr [Tue, 31 Jan 2006 14:09:26 +0000 (14:09 +0000)]
Since grid tagging is quote either 'ROW' or 'COL' (nobody can guess it !),
user is kindly requested to supply the autoref keyword 'taggrid' when he knows.

18 years agoShould generate MatLab readable Dicom files.
jpr [Tue, 31 Jan 2006 11:45:43 +0000 (11:45 +0000)]
Should generate MatLab readable Dicom files.
(We don't mix any longer ExplicitVR and ImplicitVR within the same shadow group)

18 years agoTo avoid some warnings
jpr [Tue, 31 Jan 2006 11:42:08 +0000 (11:42 +0000)]
To avoid some warnings

18 years agoAdd the method int ElementSet::IsVRCoherent( uint16_t group )
jpr [Tue, 31 Jan 2006 11:39:47 +0000 (11:39 +0000)]
Add the method int ElementSet::IsVRCoherent( uint16_t group )

To check whether *all* the DataEntries of the group have all
       the same type for VR (ImplicitVR or ExplicitVR)
@param group group number to be checked
@return 1:ImplicitVR 2:ExplicitVR -1:NotCoherent

18 years agoThe automatic set to VR = "LO" for shadow elements that could be
jpr [Tue, 31 Jan 2006 11:32:06 +0000 (11:32 +0000)]
The automatic set to VR = "LO" for shadow elements that could be
is now commented out in order not to generate 'Shadow Groups' where some
Data Elements are Explicit VR and some other ones Implicit VR
(Stupid MatLab DICOM Reader couldn't read gdcm-written images)

18 years agothe 'FileIdentifier' is now tokenizable on %%%.
jpr [Tue, 31 Jan 2006 11:29:41 +0000 (11:29 +0000)]
the 'FileIdentifier' is now tokenizable on %%%.
(Previous tokenization on "_" failed if a field contained '_'
Of course!

18 years agoForgot to commit the Python part for GDCM_FILESEPARATOR
jpr [Tue, 31 Jan 2006 11:26:08 +0000 (11:26 +0000)]
Forgot to commit the Python part for GDCM_FILESEPARATOR

18 years agoAdd #include for BCC.
jpr [Fri, 27 Jan 2006 10:03:23 +0000 (10:03 +0000)]
Add #include for BCC.
Thx to Luca Picello for providing fix.

18 years agoAdd #include for BCC
jpr [Fri, 27 Jan 2006 10:01:33 +0000 (10:01 +0000)]
Add #include for BCC
Thx to Luca Picello for providing fix.

18 years agoCOMP: Fix comp on WIN32 os
malaterre [Thu, 26 Jan 2006 18:34:13 +0000 (18:34 +0000)]
COMP: Fix comp on WIN32 os

18 years agoCOMP: Fix comp on borland
malaterre [Thu, 26 Jan 2006 18:26:04 +0000 (18:26 +0000)]
COMP: Fix comp on borland

18 years agoENH: Some more const correctness...until I hit strtok
malaterre [Thu, 26 Jan 2006 16:01:04 +0000 (16:01 +0000)]
ENH: Some more const correctness...until I hit strtok

18 years agoENH: Finally I got ArgMgr to be const string instead of char*... strcasecmp is POSIX...
malaterre [Thu, 26 Jan 2006 15:52:38 +0000 (15:52 +0000)]
ENH: Finally I got ArgMgr to be const string instead of char*... strcasecmp is POSIX why not use it...

18 years agoTry to warn user when 'DeflatedExplicitVR' Transfer Syntax found.
jpr [Thu, 26 Jan 2006 09:22:23 +0000 (09:22 +0000)]
Try to warn user when 'DeflatedExplicitVR' Transfer Syntax found.
--> Still to be done :
find a trick to stop the processing.
--> Still to be done (*later*)
. find a trick to uncompress the whole Dataset and go on Parsing, whitout having
to create a temporary file
. find a trick not to uncompress the Pixel Group every time !

18 years agoDon't try to 'Read Pixels' when 'DeflatedExplicitVRLittleEndian' Transfer Syntax
jpr [Thu, 26 Jan 2006 09:16:41 +0000 (09:16 +0000)]
Don't try to 'Read Pixels' when 'DeflatedExplicitVRLittleEndian' Transfer Syntax

18 years agoSerieHelper::CreateUserDefinedFileIdentifier doesn't convert unfound fields
jpr [Thu, 26 Jan 2006 09:07:15 +0000 (09:07 +0000)]
SerieHelper::CreateUserDefinedFileIdentifier doesn't convert unfound fields
when convertion is asked

18 years agoENH: gdcm does not support deflate
malaterre [Wed, 25 Jan 2006 18:20:53 +0000 (18:20 +0000)]
ENH: gdcm does not support deflate

18 years agoIf TriggerTime is missing (?!?) try a desperate one : replace by last file name.
jpr [Wed, 25 Jan 2006 17:02:00 +0000 (17:02 +0000)]
If TriggerTime is missing (?!?) try a desperate one : replace by last file name.
Hope the file name is lexicographically correct :-(

18 years agoCOMP: Remove warning about unused var
malaterre [Wed, 25 Jan 2006 16:59:19 +0000 (16:59 +0000)]
COMP: Remove warning about unused var

18 years agoENH: Change the name
malaterre [Wed, 25 Jan 2006 16:20:53 +0000 (16:20 +0000)]
ENH: Change the name

18 years agoENH: Backport from openjpeg CVS
malaterre [Wed, 25 Jan 2006 16:18:47 +0000 (16:18 +0000)]
ENH: Backport from openjpeg CVS

18 years agoEnforce consistency check
jpr [Wed, 25 Jan 2006 14:48:45 +0000 (14:48 +0000)]
Enforce consistency check

18 years agoWhen Split is ON, only *one* slice in each directory
jpr [Wed, 25 Jan 2006 11:41:22 +0000 (11:41 +0000)]
When Split is ON, only *one* slice in each directory
-> number must be always 1

18 years agoAdd MagnetomVisionToBrucker
jpr [Wed, 25 Jan 2006 11:08:17 +0000 (11:08 +0000)]
Add MagnetomVisionToBrucker
Fix PhilipsToBrucker2

18 years agoBUG: Who blamed vs7.1 it actually caught a big fat bug...
malaterre [Tue, 24 Jan 2006 23:14:53 +0000 (23:14 +0000)]
BUG: Who blamed vs7.1 it actually caught a big fat bug...

18 years agoENH: Should be a little faster since no function call
malaterre [Tue, 24 Jan 2006 20:56:13 +0000 (20:56 +0000)]
ENH: Should be a little faster since no function call

18 years agoCOMP: atof return a double
malaterre [Tue, 24 Jan 2006 20:53:54 +0000 (20:53 +0000)]
COMP: atof return a double

18 years agoCOMP: Why do people use microsoft extension...
malaterre [Tue, 24 Jan 2006 20:50:00 +0000 (20:50 +0000)]
COMP: Why do people use microsoft extension...

18 years agoCOMP: Make bcc55 happy
malaterre [Tue, 24 Jan 2006 20:48:10 +0000 (20:48 +0000)]
COMP: Make bcc55 happy

18 years agoBUG: Free mem properly now that it works
malaterre [Tue, 24 Jan 2006 20:40:09 +0000 (20:40 +0000)]
BUG: Free mem properly now that it works

18 years agoBUG: Trying to get openjpeg to work
malaterre [Tue, 24 Jan 2006 20:38:43 +0000 (20:38 +0000)]
BUG: Trying to get openjpeg to work

18 years agoENH: Get openjpeg working
malaterre [Tue, 24 Jan 2006 20:25:23 +0000 (20:25 +0000)]
ENH: Get openjpeg working

18 years agoENH: Nice trick to set a prefix to the lib
malaterre [Tue, 24 Jan 2006 20:05:17 +0000 (20:05 +0000)]
ENH: Nice trick to set a prefix to the lib

18 years agoENH: Adding a unix file
malaterre [Tue, 24 Jan 2006 19:58:13 +0000 (19:58 +0000)]
ENH: Adding a unix file

18 years agoENH: Adding a dos file
malaterre [Tue, 24 Jan 2006 19:57:54 +0000 (19:57 +0000)]
ENH: Adding a dos file

18 years agoBUG: No cvs script to make sure this is unix eol
malaterre [Tue, 24 Jan 2006 19:55:32 +0000 (19:55 +0000)]
BUG: No cvs script to make sure this is unix eol

18 years agoENH: Huge update to openjpeg 1.0 (actually more CVS)...
malaterre [Tue, 24 Jan 2006 19:54:07 +0000 (19:54 +0000)]
ENH: Huge update to openjpeg 1.0 (actually more CVS)...

18 years agoCOMP: Fix compilation
malaterre [Tue, 24 Jan 2006 03:06:46 +0000 (03:06 +0000)]
COMP: Fix compilation

18 years agoUpdate News
jpr [Fri, 20 Jan 2006 09:26:04 +0000 (09:26 +0000)]
Update News

18 years agoFix Doxygenation
jpr [Fri, 20 Jan 2006 09:17:25 +0000 (09:17 +0000)]
Fix Doxygenation

18 years agoAdd comments on the way gdcm::FileHelper:CheckMandatoryElements() works
jpr [Thu, 19 Jan 2006 11:46:45 +0000 (11:46 +0000)]
Add comments on the way gdcm::FileHelper:CheckMandatoryElements() works

18 years agoAdd 'input' param to PhilipsToBrucker2
jpr [Thu, 19 Jan 2006 11:43:48 +0000 (11:43 +0000)]
Add 'input' param to PhilipsToBrucker2

18 years agoTo please M$VC6
jpr [Thu, 19 Jan 2006 11:00:28 +0000 (11:00 +0000)]
To please M$VC6

18 years agoENH: Add support for broken JPEG implementation in DICOMObjects
malaterre [Wed, 18 Jan 2006 21:08:03 +0000 (21:08 +0000)]
ENH: Add support for broken JPEG implementation in DICOMObjects

18 years agoFix stupid syntax like :
jpr [Wed, 18 Jan 2006 15:45:20 +0000 (15:45 +0000)]
Fix stupid syntax like :
 fh->gdcm::FileHelper::Delete();
 to :
fh->Delete();
to please M$VC6

18 years agoTo please M$VC6 :
jpr [Wed, 18 Jan 2006 15:25:07 +0000 (15:25 +0000)]
To please M$VC6 :
Doesn't understand syntax as follow :
       std::sort(fileList->begin(), fileList->end(),
                                          SerieHelper::ImageNumberLessThan )
Add a method like:
Sort(fileList,SerieHelper::ImageNumberLessThan);

18 years agoFix comments
jpr [Wed, 18 Jan 2006 10:21:37 +0000 (10:21 +0000)]
Fix comments

18 years agoUser may choose the name of the generated dicomdir
jpr [Wed, 18 Jan 2006 10:20:56 +0000 (10:20 +0000)]
User may choose the name of the generated dicomdir

18 years agominor misstyping
jpr [Wed, 18 Jan 2006 10:18:30 +0000 (10:18 +0000)]
minor misstyping

18 years ago(try to) solve the trouble with leading / in filenames
jpr [Wed, 18 Jan 2006 10:17:40 +0000 (10:17 +0000)]
(try to) solve the trouble with leading / in filenames

18 years agoSTYLE: Minor doc
malaterre [Tue, 17 Jan 2006 20:03:46 +0000 (20:03 +0000)]
STYLE: Minor doc

18 years agoDeal with :
jpr [Tue, 17 Jan 2006 15:59:42 +0000 (15:59 +0000)]
Deal with :
PhilipsToBrucker
PhilipsToBrucker2

18 years agoPhilipsToBrucker2 allows splitting the files into a directory tree-like
jpr [Tue, 17 Jan 2006 15:58:30 +0000 (15:58 +0000)]
PhilipsToBrucker2 allows splitting the files into a directory tree-like
structure
   " - fills a tree-like structure of directories as :                        ",
   "        - Patient                                                         ",
   "        -- Serie                                                          ",
   "        --- Position                                                      ",
   "            Images are (sorted by Trigger Time /                          ",
   "                     Encoding Direction (Row, Column)                     ",
   "      use :                                                               ",
   "           0x0021, 0x1020 : 'SLICE INDEX'                                 ",
   "           0x0021, 0x1040 : 'FRAME INDEX'                                 ",
   "           0x0020, 0x0012 : 'SESSION INDEX'  (Acquisition Number)         ",

18 years agoDisplay some more informations
jpr [Tue, 17 Jan 2006 15:36:26 +0000 (15:36 +0000)]
Display some more informations

18 years agoForgot to commit this one!
jpr [Wed, 11 Jan 2006 10:44:24 +0000 (10:44 +0000)]
Forgot to commit this one!
(declaration of const char GDCM_FILESEPARATOR)