]> Creatis software - gdcm.git/log
gdcm.git
18 years agoBUG: (0008,0041) is LO and not US
malaterre [Fri, 21 Oct 2005 15:22:26 +0000 (15:22 +0000)]
BUG: (0008,0041) is LO and not US

18 years agoBUG: 1-n VM was not handle properly
malaterre [Fri, 21 Oct 2005 15:16:52 +0000 (15:16 +0000)]
BUG: 1-n VM was not handle properly

18 years agoENH: Rearchitecture the test to test one file at a time
malaterre [Fri, 21 Oct 2005 15:16:22 +0000 (15:16 +0000)]
ENH: Rearchitecture the test to test one file at a time

18 years agoBUG: ooops
malaterre [Fri, 21 Oct 2005 15:02:31 +0000 (15:02 +0000)]
BUG: ooops

18 years agoENH: You can now do os << TagKey .... rahhhhh finally
malaterre [Fri, 21 Oct 2005 15:01:28 +0000 (15:01 +0000)]
ENH: You can now do os << TagKey .... rahhhhh finally

18 years agoBUG: TestAllPrint actually is doing something now. Update to compile TestAllVM
malaterre [Fri, 21 Oct 2005 14:51:36 +0000 (14:51 +0000)]
BUG: TestAllPrint actually is doing something now. Update to compile TestAllVM

18 years agoENH: Adding a test for VM and validity... should allow us to check our own dict :-P
malaterre [Fri, 21 Oct 2005 14:42:12 +0000 (14:42 +0000)]
ENH: Adding a test for VM and validity... should allow us to check our own dict :-P

18 years agoBUG: I believe 0020,0030 has a VM of 3 an not 1
malaterre [Fri, 21 Oct 2005 14:32:05 +0000 (14:32 +0000)]
BUG: I believe 0020,0030 has a VM of 3 an not 1

18 years agoCOMP: Fix comp, and use IsValueCountValid in an assert just for kick
malaterre [Fri, 21 Oct 2005 14:15:41 +0000 (14:15 +0000)]
COMP: Fix comp, and use IsValueCountValid in an assert just for kick

18 years agoENH: Adding IsValueCountValid. Should save a lot of time for dev, since we you really...
malaterre [Fri, 21 Oct 2005 14:09:41 +0000 (14:09 +0000)]
ENH: Adding IsValueCountValid. Should save a lot of time for dev, since we you really want to do is compare against the VM to find out if the operation is valid or not.

18 years ago * Reactivate TestVR because the problem was already solved
regrain [Fri, 21 Oct 2005 12:24:57 +0000 (12:24 +0000)]
   * Reactivate TestVR because the problem was already solved
   -- BeNours

18 years agoDoxygen
jpr [Fri, 21 Oct 2005 12:12:55 +0000 (12:12 +0000)]
Doxygen

18 years agoDoxygen disagrees with comments on deprecated methods
jpr [Fri, 21 Oct 2005 12:12:18 +0000 (12:12 +0000)]
Doxygen disagrees with comments on deprecated methods

18 years ago// -->
jpr [Fri, 21 Oct 2005 12:11:06 +0000 (12:11 +0000)]
// -->
// --> Can't understand *why* TestWriteSimple fails since the commit
// --> for dealing with GE Private Transfer Syntax.
// --> commented out, to be sure the troubles started from here.
// --> JP

18 years ago * Fix the unix installation for the python part
regrain [Fri, 21 Oct 2005 12:07:06 +0000 (12:07 +0000)]
   * Fix the unix installation for the python part
   -- BeNours

18 years agoShorten up the code, and avoid memory leaks.
jpr [Fri, 21 Oct 2005 12:06:06 +0000 (12:06 +0000)]
Shorten up the code, and avoid memory leaks.
Thx to Benoit for reporting trouble.

18 years ago * Fix compilation error for the Python part
regrain [Fri, 21 Oct 2005 11:50:02 +0000 (11:50 +0000)]
   * Fix compilation error for the Python part
   -- BeNours

18 years ago * Remove obvious Example that don't pass on Windows
regrain [Fri, 21 Oct 2005 10:54:00 +0000 (10:54 +0000)]
   * Remove obvious Example that don't pass on Windows
   -- BeNours

18 years ago * Fix bug... sorry, too quick commit when correcting memory leaks
regrain [Fri, 21 Oct 2005 10:48:16 +0000 (10:48 +0000)]
   * Fix bug... sorry, too quick commit when correcting memory leaks
   -- BeNours

18 years ago * Fix compilation errors due to the 'virtual' key-word
regrain [Fri, 21 Oct 2005 10:40:53 +0000 (10:40 +0000)]
   * Fix compilation errors due to the 'virtual' key-word
   -- BeNours

18 years ago * Fix memory leaks
regrain [Fri, 21 Oct 2005 10:29:51 +0000 (10:29 +0000)]
   * Fix memory leaks
   -- BeNours

18 years agoComment out TestVR.
jpr [Fri, 21 Oct 2005 09:47:43 +0000 (09:47 +0000)]
Comment out TestVR.
(probabely useless -except for testcoverage ?- and polutes the dashbord.
Uncomment it when the mess is fixed.

18 years agoDoxygen disagrees with commented 'deprecated' methods
jpr [Fri, 21 Oct 2005 08:49:36 +0000 (08:49 +0000)]
Doxygen disagrees with commented 'deprecated' methods

18 years agoAdd exInline.cxx, to 'visualize' the difference betwwen inline an not inline
jpr [Fri, 21 Oct 2005 08:43:31 +0000 (08:43 +0000)]
Add exInline.cxx, to 'visualize' the difference betwwen inline an not inline
functions.
Well...
We see there is no difference ?!?

18 years agoComments
jpr [Fri, 21 Oct 2005 08:39:31 +0000 (08:39 +0000)]
Comments

18 years agoNormalization
jpr [Fri, 21 Oct 2005 08:37:44 +0000 (08:37 +0000)]
Normalization

18 years agoadd comments
jpr [Fri, 21 Oct 2005 08:35:49 +0000 (08:35 +0000)]
add comments

18 years agoAdd some prints
jpr [Fri, 21 Oct 2005 08:35:13 +0000 (08:35 +0000)]
Add some prints

18 years agoUse SetLoadMode(gdcm::LD_ALL), better than 0
jpr [Fri, 21 Oct 2005 08:34:26 +0000 (08:34 +0000)]
Use SetLoadMode(gdcm::LD_ALL), better than 0

18 years ago * Fix bug when reading the DicomVR.dic file
regrain [Fri, 21 Oct 2005 08:28:01 +0000 (08:28 +0000)]
   * Fix bug when reading the DicomVR.dic file
   -- BeNours

18 years ago * bug fix in the Python demos, due to the recent changes
regrain [Fri, 21 Oct 2005 08:16:06 +0000 (08:16 +0000)]
   * bug fix in the Python demos, due to the recent changes
   -- BeNours

18 years agoComment out, using C style, C++ style comments, to avoid warnings.
jpr [Fri, 21 Oct 2005 08:14:19 +0000 (08:14 +0000)]
Comment out, using C style, C++ style comments, to avoid warnings.

18 years ago * Remove compilation warnings
regrain [Fri, 21 Oct 2005 07:40:13 +0000 (07:40 +0000)]
   * Remove compilation warnings
   -- BeNours

18 years agoDoxygenation
jpr [Fri, 21 Oct 2005 07:38:57 +0000 (07:38 +0000)]
Doxygenation

18 years agoSeems some compiler disagree with trailing semi-column at end of
jpr [Fri, 21 Oct 2005 07:38:00 +0000 (07:38 +0000)]
Seems some compiler disagree with trailing semi-column at end of
 gdcmTypeMacro( ...)

18 years agoCOMP: Fix comp on VS6... not sure what it was supposed to do
malaterre [Thu, 20 Oct 2005 15:33:18 +0000 (15:33 +0000)]
COMP: Fix comp on VS6... not sure what it was supposed to do

18 years ago * Add a RefCounter object that is deleted only when it's reference count is
regrain [Thu, 20 Oct 2005 15:24:05 +0000 (15:24 +0000)]
   * Add a RefCounter object that is deleted only when it's reference count is
     to 0.
   * DicomEntry (thus, DictEntry) inherits from RefCounter... next stage to do,
     all classes inherit from RefCounter
   * Remove the VirtualDictEntry use, now useless due to the reference
     counting. So, there will be no memory leaks.
   -- BeNours

18 years agoCOMP: I don't think this is needed
malaterre [Thu, 20 Oct 2005 15:21:30 +0000 (15:21 +0000)]
COMP: I don't think this is needed

18 years agoENH: Add a very bizarre case
malaterre [Thu, 20 Oct 2005 15:05:15 +0000 (15:05 +0000)]
ENH: Add a very bizarre case

18 years agoRemove deprecated method names 'GetFirstCoherentFileList' 'GetNextCoherentFileList'
jpr [Thu, 20 Oct 2005 14:46:29 +0000 (14:46 +0000)]
Remove deprecated method names 'GetFirstCoherentFileList' 'GetNextCoherentFileList'
replace by GetFistSingleSerieUIDFileSet, GetNextSingleSerieUIDFileSet

18 years agoENH: Fix TestVR on VS6, while preserving inline optimization on working compiler
malaterre [Thu, 20 Oct 2005 14:45:11 +0000 (14:45 +0000)]
ENH: Fix TestVR on VS6, while preserving inline optimization on working compiler

18 years agoENH: Previous code did not work on VS6
malaterre [Thu, 20 Oct 2005 14:25:47 +0000 (14:25 +0000)]
ENH: Previous code did not work on VS6

18 years agoENH: Saving a comment for a better approach in cmake 2.2 (later)
malaterre [Thu, 20 Oct 2005 14:15:39 +0000 (14:15 +0000)]
ENH: Saving a comment for a better approach in cmake 2.2 (later)

18 years agoCOMP: Fix bcc55
malaterre [Thu, 20 Oct 2005 13:58:18 +0000 (13:58 +0000)]
COMP: Fix bcc55

18 years agoENH: Saving some stuff from an explicit image...if I remember correctly
malaterre [Thu, 20 Oct 2005 13:56:24 +0000 (13:56 +0000)]
ENH: Saving some stuff from an explicit image...if I remember correctly

18 years agoSTYLE: Some minor comment
malaterre [Thu, 20 Oct 2005 13:55:05 +0000 (13:55 +0000)]
STYLE: Some minor comment

18 years ago * Remove missed FASTTAGKEY (due to the integration of the
regrain [Thu, 20 Oct 2005 09:23:24 +0000 (09:23 +0000)]
   * Remove missed FASTTAGKEY (due to the integration of the
     gdcm::TagKey class).
     Thx to Mathieu

18 years agoLast (?) stage of Private GE Syntax Transer name normalization
jpr [Thu, 20 Oct 2005 09:17:54 +0000 (09:17 +0000)]
Last (?) stage of Private GE Syntax Transer name normalization

18 years ago * Fix some compilation warnings
regrain [Thu, 20 Oct 2005 08:58:15 +0000 (08:58 +0000)]
   * Fix some compilation warnings
   * Amelioration of Test's output
   -- BeNours

18 years ago * Coding style
regrain [Thu, 20 Oct 2005 08:53:21 +0000 (08:53 +0000)]
   * Coding style
   -- BeNours

18 years agoOops.
jpr [Thu, 20 Oct 2005 08:29:50 +0000 (08:29 +0000)]
Oops.
Forgot to commit this one.
Thx, Benoit!

18 years ago-> Fix the pb of 'Private GE Transfer Syntax' for 16 bits images.
jpr [Thu, 20 Oct 2005 07:38:08 +0000 (07:38 +0000)]
-> Fix the pb of 'Private GE Transfer Syntax' for 16 bits images.
-> The expressions related to 'ImplicitVRLittleEndianDLXGE' are changed to talk
about 'Implicit VR Big Endian Transfer Syntax', that's the term commonly used in
the literature.
--> Merge ITK comments (much more detailled than mines) in the gdcm code.

18 years agoCoding style
jpr [Thu, 20 Oct 2005 07:29:43 +0000 (07:29 +0000)]
Coding style

18 years agoTry to make a more kosher Dicom Header (improve various UID consistebcy)
jpr [Thu, 20 Oct 2005 07:27:43 +0000 (07:27 +0000)]
Try to make a more kosher Dicom Header (improve various UID consistebcy)

18 years agoIn order to get UID without padding to even-length string, add a '.' before
jpr [Thu, 20 Oct 2005 07:25:10 +0000 (07:25 +0000)]
In order to get UID without padding to even-length string, add a '.' before
random number.

18 years agoFix 'delimitors' Print()
jpr [Thu, 20 Oct 2005 07:23:50 +0000 (07:23 +0000)]
Fix 'delimitors' Print()

18 years agoENH: Tons of change now support creation of basic table offset to please dicom reader...
malaterre [Wed, 19 Oct 2005 22:19:20 +0000 (22:19 +0000)]
ENH: Tons of change now support creation of basic table offset to please dicom reader like dicomworks.

18 years agoSTYLE: Imager Pixel Spacing
malaterre [Wed, 19 Oct 2005 19:36:54 +0000 (19:36 +0000)]
STYLE: Imager Pixel Spacing

18 years agoENH: Still cleaning up stuff
malaterre [Wed, 19 Oct 2005 17:56:57 +0000 (17:56 +0000)]
ENH: Still cleaning up stuff

18 years agoENH: properly return 0 when everything was ok, 1 otherwise
malaterre [Wed, 19 Oct 2005 16:55:37 +0000 (16:55 +0000)]
ENH: properly return 0 when everything was ok, 1 otherwise

18 years agoSTYLE: Fix comment
malaterre [Wed, 19 Oct 2005 16:51:11 +0000 (16:51 +0000)]
STYLE: Fix comment

18 years agoCOMP: That was simply a typo
malaterre [Wed, 19 Oct 2005 16:49:05 +0000 (16:49 +0000)]
COMP: That was simply a typo

18 years agoCOMP: remove suspend comp warn
malaterre [Wed, 19 Oct 2005 16:08:29 +0000 (16:08 +0000)]
COMP: remove suspend comp warn

18 years agoENH: Reorganize the code to prepare multiple fragments
malaterre [Wed, 19 Oct 2005 16:05:14 +0000 (16:05 +0000)]
ENH: Reorganize the code to prepare multiple fragments

18 years agoCOMP: Please VS6
malaterre [Wed, 19 Oct 2005 15:43:58 +0000 (15:43 +0000)]
COMP: Please VS6

18 years ago * Remove the Key information in Entry
regrain [Wed, 19 Oct 2005 13:17:04 +0000 (13:17 +0000)]
   * Remove the Key information in Entry
   * Create a DicomEntry parent of DictEntry
   * Remap correctly the TagKey
   -- BeNours

18 years ago * Remove memory leaks
regrain [Wed, 19 Oct 2005 13:15:36 +0000 (13:15 +0000)]
   * Remove memory leaks
   -- BeNours

18 years ago * Fix compilation errors for the Python part
regrain [Wed, 19 Oct 2005 12:01:47 +0000 (12:01 +0000)]
   * Fix compilation errors for the Python part
   * Fix errors in the Python tests
   -- BeNours

18 years ago * Amelioration of error messages
regrain [Wed, 19 Oct 2005 09:43:13 +0000 (09:43 +0000)]
   * Amelioration of error messages
   -- BeNours

18 years ago * Error message amelioration
regrain [Wed, 19 Oct 2005 09:27:24 +0000 (09:27 +0000)]
   * Error message amelioration
   -- BeNours

18 years ago*** empty log message ***
regrain [Wed, 19 Oct 2005 08:16:59 +0000 (08:16 +0000)]
*** empty log message ***

18 years ago * Fix some bugs
regrain [Wed, 19 Oct 2005 08:06:45 +0000 (08:06 +0000)]
   * Fix some bugs
   -- BeNours

18 years agoSTYLE: A Debug statement is not a warning, a warning is not an error.. you get the...
malaterre [Tue, 18 Oct 2005 21:19:57 +0000 (21:19 +0000)]
STYLE: A Debug statement is not a warning, a warning is not an error.. you get the picture...

18 years agoENH: Hoorray the first gdcm-jpeg image written from scratch :)
malaterre [Tue, 18 Oct 2005 20:49:59 +0000 (20:49 +0000)]
ENH: Hoorray the first gdcm-jpeg image written from scratch :)

18 years agoENH: Getting real close to having JPEG support in gdcm... jpeg offset table still...
malaterre [Tue, 18 Oct 2005 19:54:25 +0000 (19:54 +0000)]
ENH: Getting real close to having JPEG support in gdcm... jpeg offset table still missing

18 years agoENH: Several change, fix compilation warnings, and update to newer API...no comment
malaterre [Tue, 18 Oct 2005 19:06:28 +0000 (19:06 +0000)]
ENH: Several change, fix compilation warnings, and update to newer API...no comment

18 years agoCOMP: Fix other people warnings
malaterre [Tue, 18 Oct 2005 18:42:51 +0000 (18:42 +0000)]
COMP: Fix other people warnings

18 years agoENH: Adding *very* experimental support for writting DICOM file as JPEG
malaterre [Tue, 18 Oct 2005 18:39:49 +0000 (18:39 +0000)]
ENH: Adding *very* experimental support for writting DICOM file as JPEG

18 years agoENH: Adding example on how to write a dicom file as jpeg
malaterre [Tue, 18 Oct 2005 18:36:53 +0000 (18:36 +0000)]
ENH: Adding example on how to write a dicom file as jpeg

18 years ago * Remove bad print - sorry
regrain [Tue, 18 Oct 2005 14:37:18 +0000 (14:37 +0000)]
   * Remove bad print - sorry
   -- BeNours

18 years ago * Fix compilation error for python due to my commit on DataEntry changes
regrain [Tue, 18 Oct 2005 13:12:08 +0000 (13:12 +0000)]
   * Fix compilation error for python due to my commit on DataEntry changes
   -- BeNours

18 years ago * Correctly use the VRKey for all vr variables... instead of TagName
regrain [Tue, 18 Oct 2005 12:58:23 +0000 (12:58 +0000)]
   * Correctly use the VRKey for all vr variables... instead of TagName
     or std::string
   * Replace the definition of VRKey from std::string to a class
     containing a char[2]. All methods are inline to have no speed low
   * Create the GDCM_VRUNKNOWN = "  " for the VR values
   -- BeNours

18 years agoForce a default 'Recognition Code' when ACR-NEMA writting is required.
jpr [Tue, 18 Oct 2005 12:49:55 +0000 (12:49 +0000)]
Force a  default 'Recognition Code' when ACR-NEMA writting is required.

18 years agoCoding style : no more than 80 char per line!
jpr [Tue, 18 Oct 2005 11:35:31 +0000 (11:35 +0000)]
Coding style : no more than 80 char per line!

18 years agoFix cleanly (hope so) the mess in gdcm-MR-PHILIPS-16-Multi-Seq.dcm header
jpr [Tue, 18 Oct 2005 11:10:45 +0000 (11:10 +0000)]
Fix cleanly (hope so) the mess in gdcm-MR-PHILIPS-16-Multi-Seq.dcm header
(a fffe|0000 impossible tag + a spurious item starter!)
--> Probabely we shouls propagate this fix to yesterday branch)

18 years agoFix internal name for :
jpr [Tue, 18 Oct 2005 10:43:31 +0000 (10:43 +0000)]
Fix internal name for :
1.2.840.113619.5.2 : Implicit VR Big Endian DLX (G.E Private)
as ImplicitVRBigEndianPrivateGE

18 years agoAvoid warnings : NULL is a 'pointer';
jpr [Tue, 18 Oct 2005 10:19:27 +0000 (10:19 +0000)]
Avoid warnings : NULL is a 'pointer';
Don't assign it to a 'char'

18 years ago * Remove useless constructor of gdcm::Document
regrain [Tue, 18 Oct 2005 09:17:07 +0000 (09:17 +0000)]
   * Remove useless constructor of gdcm::Document
   * Remove useless parameter in the constructor of gdcm::ElementSet
   * Split gdcmCommon to separate the System specifications to the gdcm
     specifications
   -- BeNours

18 years ago * Minor coding-style clean up
regrain [Tue, 18 Oct 2005 08:35:42 +0000 (08:35 +0000)]
   * Minor coding-style clean up
   * Replace the ContentEntry and its derived classes (BinEntry and ValEntry)
     by the DataEntry. This unique entry considers all datas like binary datas.
     Some methods are added to interpret - at fly - the binary datas.
     Due to this important change, some methods of the DocEntrySet, concerning
     the BinEntry and ValEntry classes, are erased ; and new methods for the
     DataEntry class are created.
     Some methods to set the ValEntry or the BinEntry are renamed to
     correspond to the new DataEntry, like for example :
      - SetValEntry -> SetEntryString
      - SetBinEntry -> SetEntryBinArea
     This change will remove all useless creation of the string when working
     directly on values.
   -- BeNours

18 years ago * Prepare the modifications for a new DocEntry structuration Version1.2.bp
regrain [Tue, 18 Oct 2005 07:52:44 +0000 (07:52 +0000)]
   * Prepare the modifications for a new DocEntry structuration
   * Update the version and do a CVS branch
   -- BeNours

18 years agoTo avoid warning about shadowed variables.
jpr [Mon, 17 Oct 2005 15:45:38 +0000 (15:45 +0000)]
To avoid warning about shadowed variables.

18 years agoCOMP: Fix compilation for gdcmPython... hopefully
malaterre [Mon, 17 Oct 2005 15:09:58 +0000 (15:09 +0000)]
COMP: Fix compilation for gdcmPython... hopefully

18 years agoCOMP: Fix comp on bcc55
malaterre [Mon, 17 Oct 2005 15:05:44 +0000 (15:05 +0000)]
COMP: Fix comp on bcc55

18 years ago"UN" is an actual VR!
jpr [Mon, 17 Oct 2005 14:55:01 +0000 (14:55 +0000)]
"UN" is an actual VR!
Thx to NA-MIC for providing data to fix the bug.

18 years agoFix bug in computing XSpacing.
jpr [Mon, 17 Oct 2005 14:26:44 +0000 (14:26 +0000)]
Fix bug in computing XSpacing.
(Fortunalely, manufacturers *don't* follow the norm, and
ImagerPixelSpacing (0x0018,0x1164) never exists !)

Thx to Benoit for reviewing code and reporting possible trouble.

18 years agoUpdate News
jpr [Mon, 17 Oct 2005 13:09:31 +0000 (13:09 +0000)]
Update News

18 years agoRemove useless Example/TestFromScratch.cxx (Example/TestCopyDicom does the same jpb)
jpr [Mon, 17 Oct 2005 10:41:59 +0000 (10:41 +0000)]
Remove useless Example/TestFromScratch.cxx (Example/TestCopyDicom does the same jpb)

18 years agoRemove TestWrite
jpr [Mon, 17 Oct 2005 10:31:08 +0000 (10:31 +0000)]
Remove TestWrite

18 years agoRemove now useless Example/TestWrite.cxx
jpr [Mon, 17 Oct 2005 10:30:16 +0000 (10:30 +0000)]
Remove now useless Example/TestWrite.cxx

18 years agoMerge Example/ReWrite.cxx and Example/TestWrite.cxx
jpr [Mon, 17 Oct 2005 10:29:32 +0000 (10:29 +0000)]
Merge Example/ReWrite.cxx and Example/TestWrite.cxx