jpr [Thu, 6 Jan 2005 17:08:05 +0000 (17:08 +0000)]
Doxygenation
+ modif Coding style :
According with Benoit (and Doxygen) we shall use, just like anybody :
T *foo
or
T &foo
and NOT
T* foo
or
T & foo
(that was gdcm-special)
regrain [Thu, 6 Jan 2005 13:35:37 +0000 (13:35 +0000)]
* src/gdcmDictEntry.h : now, the IsVRUnknown is correct
* src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
a file
* src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
when specifying the VR
* src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
* src/gdcmDocEntry.cxx : amelioration of print
-- BeNours
regrain [Wed, 5 Jan 2005 15:38:27 +0000 (15:38 +0000)]
* src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
replace the different values "??", "Unkn", "Unknown".
* src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
gdcmVR.cxx : use the GDCM_UNKNOWN constant.
* Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
-- BeNours
regrain [Thu, 16 Dec 2004 13:46:36 +0000 (13:46 +0000)]
* src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
empty Print Method
* Set the gdcm::Base class to some Printable classes
-- BeNours
regrain [Thu, 16 Dec 2004 11:37:01 +0000 (11:37 +0000)]
* src/gdcmFile.[h|cxx] : add the Print method
* src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
* src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
* src/gdcmDocument.h : remove the PrintLevel informations
* Example/PrintFile.cxx : use the new gdcm::File::Print
-- BeNours
rouet [Sun, 12 Dec 2004 17:21:07 +0000 (17:21 +0000)]
* FIX: new handling of JPEG decompression, especially when dicom
frames are split into several JPEG Fragments. This makes use of
jpeg decompression from memory buffer. This solves reading for
example gdcm-JPEG-Lossless_Thoravision.dcm.
rouet [Sun, 12 Dec 2004 13:32:23 +0000 (13:32 +0000)]
* FIX: modified DirList::Explore in order to make it work under
Cygwin when GDCM_DATA_ROOT is a defined by CMake as a unix
path. The patch consists in not using the FindFirstFile win32api
function under cygwin but rather the open dir *nix method.
malaterre [Fri, 10 Dec 2004 15:50:04 +0000 (15:50 +0000)]
ENH: Adding an example that only work on linux, not on Win32. It shows how to create a DICOM image from scratch, we are only allowed to copy the string based entry from a previous DICOM
regrain [Fri, 10 Dec 2004 13:49:05 +0000 (13:49 +0000)]
* src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
Rename Decompressed to Raw
* Use the API changes in gdcm::File.
* vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
Memory leaks fixed
-- BeNours
regrain [Fri, 10 Dec 2004 08:34:06 +0000 (08:34 +0000)]
* vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
each added entry in the header. Replace the 'Planes' field by the 'Number
of Frames' field
-- BeNours
regrain [Thu, 9 Dec 2004 11:31:51 +0000 (11:31 +0000)]
* Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
At this time, this image isn't readable by e-film... waiting JPR help to
solve it.
-- BeNours
regrain [Wed, 8 Dec 2004 11:37:15 +0000 (11:37 +0000)]
* vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
* vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
* Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
* Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
test to 0.0
* Test/TestCopyRescaleDicom.cxx : remove unused variable
* Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
containing found sequences
-- BeNours
regrain [Tue, 7 Dec 2004 18:16:39 +0000 (18:16 +0000)]
* Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
not at all time
* Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
Some fields in BinEntry must be copied to not seg fault when making the :
gdcm::File *copy = new gdcm::File( copyH );
and tests are now made on good variables
-- BeNours
regrain [Tue, 7 Dec 2004 17:28:49 +0000 (17:28 +0000)]
* vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
* src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
length
* src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
* Add vtkGdcmWriter example and test
-- BeNours
malaterre [Tue, 7 Dec 2004 15:41:59 +0000 (15:41 +0000)]
ENH: Temporarily add jmemsrc. Patch suggest by Jean Michel Rouet, it enhance the jpeg lib to be able to decompress jpeg stream directly from memory + remove tabs
regrain [Tue, 7 Dec 2004 13:39:31 +0000 (13:39 +0000)]
* Test/TestUtil.cxx : reformat the source code
* vtk/vtkGdcmReader.cxx : remove and change prints
* src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
SetValue
* src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
* src/*.cxx : remove all useless call to SetLength of a ValEntry object
-- BeNours
regrain [Mon, 6 Dec 2004 12:54:40 +0000 (12:54 +0000)]
* src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
by an eof to prevent all bad read of the file... and in this case, the
file isn't readable.
-- BeNours
regrain [Mon, 6 Dec 2004 11:37:36 +0000 (11:37 +0000)]
* Example/Volume2Dicom.cxx : comment unused variables
* Test/PrintDicomDir.cxx : comment unused variables
* Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
* src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
method that is redondant with AddEntry.
* src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
SQItem
-- BeNours
malaterre [Fri, 3 Dec 2004 20:16:55 +0000 (20:16 +0000)]
ENH: * Huge cleanup:
- Remove printf / sprintf
- include iostream AFTER gdcm so we don't get warnings
- GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm source
- Also remove tons of include from header files, hopefully this should speeup the compilation time, since it was becoming a dog slow.
- Remove gdcm.h as it include way too many files and slow down compilation (plus it is not up to date)
- remove /using namespace std/ this is BAD
regrain [Fri, 3 Dec 2004 17:13:17 +0000 (17:13 +0000)]
* Remove memory leaks on the DicomDir
* Remove some useless datas in DicomDirObject
* Add usefull methods in SQItem, to be complient withe the ElementSet
-- BeNours
regrain [Fri, 3 Dec 2004 11:55:37 +0000 (11:55 +0000)]
* src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
future, with convertion)
* src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
and ImageDataSize values. Remove the method to get the PixelReadConverter
from the output of the class
-- BeNours
regrain [Thu, 2 Dec 2004 15:14:15 +0000 (15:14 +0000)]
* Test/TestCopyDicom.cxx : the new dicom created is created empty, without
file name in input
* src/gdcmSeqEntry.cxx : bug fix in destruction of an element
* src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
The string leaves only in the fonction. So when we make a .c_str(), we
get the pointeur on the first element, element that will be destroyed
immediately after thee instruction.
* src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
file has been opened : the test must be made on the content of the
pointer and not directly on the pointer !
Code formatting
-- BeNours
regrain [Tue, 30 Nov 2004 17:00:54 +0000 (17:00 +0000)]
* Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
X session is killed (for my computer... it seems to not be identic on
all linux)
-- BeNours
regrain [Tue, 30 Nov 2004 15:44:43 +0000 (15:44 +0000)]
* Test/ShowDicom.cxx : now can be used with an off-screen rendering to
avoid problems (otherwise, the difference test between the visible image
and the reference is incorrect. If the reference is greater than the
screen resolution, it's produce errors).
Can be used for only one image. Can be used with a visible flag.
* vtk/vtkGdcmReader.cxx : remove commented codes.
* vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
under windows at compilation
* vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
for grayscale images
* vtk/GdcmToBaseline.cxx : new program to easy create the reference image
-- BeNours
regrain [Tue, 30 Nov 2004 14:17:51 +0000 (14:17 +0000)]
* src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
* Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
tests on the image size X, Y, Z
-- BeNours