From 02c3660dbd1e216ea0c7779ff95cb5802af9217c Mon Sep 17 00:00:00 2001
From: jpr <jpr>
Date: Wed, 15 Sep 2004 16:05:19 +0000
Subject: [PATCH] some more comments on gdcmData images

---
 TestAllEntryVerifyReference.txt | 28 +++++++++++++++++++++++++---
 1 file changed, 25 insertions(+), 3 deletions(-)

diff --git a/TestAllEntryVerifyReference.txt b/TestAllEntryVerifyReference.txt
index 421b9d0..05c2a9c 100644
--- a/TestAllEntryVerifyReference.txt
+++ b/TestAllEntryVerifyReference.txt
@@ -496,6 +496,8 @@
    #   * allmost groups (this is not the case of group 0x0008) contain
    #     a "Group Length" tag (*, 0x0000)
    #   * Pixel data encoded on 10 bits.
+	#   * Implicit VR --> all private entries are assumed as BinEntries
+	#                    (group 0019, group 0029)
    0008|0070 "Philips Medical Systems (Netherlands) "    # Manufacturer
    0008|1090 "P H I L I P S     INTEGRIS V" # Manufacturer's Model Name
    0028|0101 "10"                         # Bits Stored
@@ -518,6 +520,8 @@
    # - Particularities:
    #   * Multiframe image (see Number of Frames tag)
    #   * the private tags are NOT in Explicit VR
+	#     --> assumed as BinEntries
+	#     ( groups 11, 15, 19)
    #   * allmost groups (this is not the case of group 0x0008) contain
    #     a "Group Length" tag (*, 0x0000)
    0008|0070 "GE MEDICAL SYSTEMS"         # Manufacturer
@@ -647,6 +651,10 @@
    # - Particularities:
    #   * old (circa 2000) ACR NEMA version 2.0 format.
    #   * wierd padding of "Series Number" tag
+	#  (ALL the -numerous- private fields are considered as 'BinEntries'
+	#        very few of them actually are :-(
+	#        groups 9, 11, 19, 21, 29, 51
+	# --> TODO : fied a trick to guess (contains non printable characters ?)
    0008|0070 "SIEMENS "                   # Manufacturer
    0008|1090 "MAGNETOM VISION "           # Manufacturer's Model Name
    0028|0101 "12"                         # Bits Stored
@@ -767,6 +775,7 @@
    #   * Highly nested sequence (6 sublevels) with an impressive size
    #     of 28808 bytes at tag (0x0029, 0x263d)
    #   * possesses many sequences in group 0x0029
+	#   * Private BinEntry (DT) 21 1007
    0008|0070 "Philips Medical Systems "   # Manufacturer
    0008|1090 "Gyroscan Intera "           # Manufacturer's Model Name
    0028|0101 "12"                         # Bits Stored
@@ -809,7 +818,9 @@
    # - Particularities:
    #   * Non rectangular pixels (see "Pixel Spacing" tag)
    #   * private tags are in explicit VR (which is normal BTW)
-   #   *screen-flaher non printable charcaters in private elements (gdcmBinEntry ?)
+   #   *screen-flaher non printable characters in private elements (gdcmBinEntry ?)
+   #   * has FD fields (0029 218b, 29 218d)
+
    0008|0070 "Philips Medical Systems "   # Manufacturer
    0008|1090 "Gyroscan Intera "           # Manufacturer's Model Name
    0028|0101 "12"                         # Bits Stored
@@ -935,6 +946,8 @@
    #   * jpeg compression [Extended Process (2,4)]
    #   * probably contains additional data after the pixels (see comments
    #     of the gdcm-JPEG-LossLess3a.dcm entry)
+	#   * contains OB private fields (19 10b0, 21 1011, 29 1008, 29 1009,
+	#             29 1010, 29 1131, 29 1134)
    0008|0070 "SIEMENS "                   # Manufacturer
    0008|1090 "Volume Zoom "               # Manufacturer's Model Name
    0028|0101 "12"                         # Bits Stored
@@ -953,9 +966,11 @@
 [ gdcm-JPEG-Extended-Allready_present.dcm
    # JPR FIXME: this image is REALLY close to gdcm-JPEG-Extended.dcm in
    #            terms of features (actually I suspect gdcm-JPEG-Extended.dcm
-   #            is the anoymized version of this one)...
+   #            is the anonymized version of this one)...
    # - Particularities:
    #   * jpeg compression [Extended Process (2,4)]
+	#   * private BinEntry (OB) in 19 10b0, 21 1011, 29 1008, 29 1009, 29 1010,
+	#                              29 1131, 29 1134
    0008|0070 "SIEMENS "                   # Manufacturer
    0008|1090 "Volume Zoom "               # Manufacturer's Model Name
    0028|0101 "12"                         # Bits Stored
@@ -1088,6 +1103,7 @@
 
 
 # dicom-sc_cs-1.dcm # Has a lot of private fields, with no VR.
+                    # (groups 9, 11, 19, 21, 29, 31)
                     # Has a 'Zero length' integer field
                     # 0020|5000 lg :0 [US][Original Image Identification (RET)]
 
@@ -1123,7 +1139,13 @@
 # QMAG0001.dcm
 # fromTheralys.dcm # has a 13 bytes length item !
 # 9000001.dcm
-# IMG00001.dcm
+# IMG00001.dcm # has many Private BinEntries (VR, DT, FD, OB)
+#        FL 19 105a, DT 19 109d, FD 23 1070, FL 27 1041, FL 27 1042, FL 27 1043,
+#        FL 27 1044,
+#        FL 27 1045, FL 27 1046, FL 27 1047, FL 27 1048, FL 27 1049, FL 27 104a,
+#        FL 27 104b, FL 27 104c, FL 27 104d, FL 27 1060, FL 27 1061, FL 27 1062,
+#        OB 43 1028 ,OB 43 1029 ,OB 43 102a ,FL 43 1033 ,FL 43 1038
+
 # lena128x128.acr # ACR-LibIDO image. gdcm *can* read it!
 # mriThruVPRO.dcm
 # MxTwinLossLess.dcm
-- 
2.45.1