From f558e91ca92b7b2b5820bebc01e000a926d0828f Mon Sep 17 00:00:00 2001 From: jpr Date: Fri, 11 Feb 2005 16:36:52 +0000 Subject: [PATCH] Comments --- src/gdcmBinEntry.cxx | 14 +++++++------- src/gdcmDicomDir.cxx | 12 ++++-------- src/gdcmDocument.cxx | 24 ++++++++---------------- src/gdcmDocument.h | 5 ++--- src/gdcmException.h | 9 ++++----- 5 files changed, 25 insertions(+), 39 deletions(-) diff --git a/src/gdcmBinEntry.cxx b/src/gdcmBinEntry.cxx index d17fe6ae..21895ef4 100644 --- a/src/gdcmBinEntry.cxx +++ b/src/gdcmBinEntry.cxx @@ -3,8 +3,8 @@ Program: gdcm Module: $RCSfile: gdcmBinEntry.cxx,v $ Language: C++ - Date: $Date: 2005/02/10 14:23:18 $ - Version: $Revision: 1.68 $ + Date: $Date: 2005/02/11 16:36:52 $ + Version: $Revision: 1.69 $ Copyright (c) CREATIS (Centre de Recherche et d'Applications en Traitement de l'Image). All rights reserved. See Doc/License.txt or @@ -79,14 +79,14 @@ void BinEntry::WriteContent(std::ofstream *fp, FileType filetype) if (binArea) // the binArea was *actually* loaded { - // TODO FIME - // Probabely, the same operation will have to be done when we want - // to write image with Big Endian Transfert Syntax, - // and we are working on Little Endian Processor + /// \todo Probabely, the same operation will have to be done when we want + /// to write image with Big Endian Transfert Syntax, + /// and we are working on Little Endian Processor #ifdef GDCM_WORDS_BIGENDIAN const int BUFFER_SIZE = 4096; - // TODO FIXME Right now, we only care of Pixels element + /// \todo FIXME Right now, we only care of Pixels element + /// we should deal with *all* the BinEntries // 8 Bits Pixels *are* OB, 16 Bits Pixels *are* OW // -value forced while Reading process- diff --git a/src/gdcmDicomDir.cxx b/src/gdcmDicomDir.cxx index 18bce3cf..40a41eef 100644 --- a/src/gdcmDicomDir.cxx +++ b/src/gdcmDicomDir.cxx @@ -3,8 +3,8 @@ Program: gdcm Module: $RCSfile: gdcmDicomDir.cxx,v $ Language: C++ - Date: $Date: 2005/02/07 14:48:34 $ - Version: $Revision: 1.130 $ + Date: $Date: 2005/02/11 16:36:52 $ + Version: $Revision: 1.131 $ Copyright (c) CREATIS (Centre de Recherche et d'Applications en Traitement de l'Image). All rights reserved. See Doc/License.txt or @@ -57,7 +57,7 @@ // Dicom PS 3.3 describes the relationship between Directory Records, as follow // // Directory Record Type Directory Record Types which may be included -// in the next lower-èlevel directory Entity +// in the next lower-level directory Entity // // (Root directory Entity) PATIENT // @@ -165,8 +165,7 @@ DicomDir::DicomDir(std::string const &fileName, bool parseDir ): } else { - /// \todo if parseDir == false, it should be tagged as an error - // NO ! user may just call ParseDirectory() *after* constructor + // user may just call ParseDirectory() *after* constructor } } // Only if user passed a DICOMDIR @@ -179,8 +178,6 @@ DicomDir::DicomDir(std::string const &fileName, bool parseDir ): { gdcmWarningMacro( "NO 'Directory record sequence' (0x0004,0x1220)" << " in file " << fileName); - /// \todo FIXME : what do we do when the parsed file IS NOT a - /// DICOMDIR file ? } else CreateDicomDir(); @@ -620,7 +617,6 @@ void DicomDir::CreateDicomDir() if ( !e ) { gdcmWarningMacro( "No Directory Record Sequence (0004,1220) found"); - /// \todo FIXME: what to do when the parsed file IS NOT a DICOMDIR file ? return; } diff --git a/src/gdcmDocument.cxx b/src/gdcmDocument.cxx index 496742f7..088c4097 100644 --- a/src/gdcmDocument.cxx +++ b/src/gdcmDocument.cxx @@ -3,8 +3,8 @@ Program: gdcm Module: $RCSfile: gdcmDocument.cxx,v $ Language: C++ - Date: $Date: 2005/02/09 21:37:45 $ - Version: $Revision: 1.226 $ + Date: $Date: 2005/02/11 16:36:52 $ + Version: $Revision: 1.227 $ Copyright (c) CREATIS (Centre de Recherche et d'Applications en Traitement de l'Image). All rights reserved. See Doc/License.txt or @@ -469,7 +469,7 @@ bool Document::CloseFile() delete Fp; Fp = 0; } - return true; //FIXME how do we detect a non-closed ifstream ? + return true; } /** @@ -558,7 +558,6 @@ void Document::LoadEntryBinArea(BinEntry *elem) return; } - /// \todo check the result Fp->read((char*)a, l); if( Fp->fail() || Fp->eof()) { @@ -997,12 +996,6 @@ void Document::ParseSQ( SeqEntry *seqEntry, { dlm_mod = false; } - // FIXME, TODO - // when we're here, element fffe,e000 is already passed. - // it's lost for the SQItem we're going to process !! - - //ParseDES(itemSQ, newDocEntry->GetOffset(), l, dlm_mod); - //delete newDocEntry; // FIXME well ... it's too late to use it ! // Let's try :------------ // remove fff0,e000, created out of the SQItem @@ -1100,7 +1093,6 @@ void Document::LoadDocEntry(DocEntry *entry) return; } - /// \todo Any compacter code suggested (?) if ( IsDocEntryAnInteger(entry) ) { uint32_t NewInt; @@ -1633,7 +1625,7 @@ void Document::FixDocEntryFoundLength(DocEntry *entry, if ( gr != 0x0008 || ( elem != 0x0070 && elem != 0x0080 ) ) { foundLength = 10; - entry->SetReadLength(10); /// \todo a bug is to be fixed !? + entry->SetReadLength(10); // a bug is to be fixed !? } } @@ -1644,7 +1636,7 @@ void Document::FixDocEntryFoundLength(DocEntry *entry, else if ( gr == 0x0009 && ( elem == 0x1113 || elem == 0x1114 ) ) { foundLength = 4; - entry->SetReadLength(4); /// \todo a bug is to be fixed !? + entry->SetReadLength(4); // a bug is to be fixed !? } else if ( entry->GetVR() == "SQ" ) @@ -1924,7 +1916,7 @@ void Document::SwitchByteSwapCode() /** * \brief during parsing, Header Elements too long are not loaded in memory - * @param newSize + * @param newSize new size */ void Document::SetMaxSizeLoadEntry(long newSize) { @@ -1942,8 +1934,8 @@ void Document::SetMaxSizeLoadEntry(long newSize) /** * \brief Header Elements too long will not be printed - * \todo See comments of \ref Document::MAX_SIZE_PRINT_ELEMENT_VALUE - * @param newSize + * See comments of \ref Document::MAX_SIZE_PRINT_ELEMENT_VALUE + * @param newSize new size */ void Document::SetMaxSizePrintEntry(long newSize) { diff --git a/src/gdcmDocument.h b/src/gdcmDocument.h index 0ced6be7..2371d996 100644 --- a/src/gdcmDocument.h +++ b/src/gdcmDocument.h @@ -3,8 +3,8 @@ Program: gdcm Module: $RCSfile: gdcmDocument.h,v $ Language: C++ - Date: $Date: 2005/02/06 14:39:35 $ - Version: $Revision: 1.105 $ + Date: $Date: 2005/02/11 16:36:52 $ + Version: $Revision: 1.106 $ Copyright (c) CREATIS (Centre de Recherche et d'Applications en Traitement de l'Image). All rights reserved. See Doc/License.txt or @@ -23,7 +23,6 @@ #include "gdcmDict.h" #include "gdcmElementSet.h" #include "gdcmException.h" -//#include "gdcmCommon.h" #include #include diff --git a/src/gdcmException.h b/src/gdcmException.h index 425ad6b9..c92034ec 100644 --- a/src/gdcmException.h +++ b/src/gdcmException.h @@ -3,8 +3,8 @@ Program: gdcm Module: $RCSfile: gdcmException.h,v $ Language: C++ - Date: $Date: 2005/01/11 15:15:38 $ - Version: $Revision: 1.21 $ + Date: $Date: 2005/02/11 16:36:52 $ + Version: $Revision: 1.22 $ Copyright (c) CREATIS (Centre de Recherche et d'Applications en Traitement de l'Image). All rights reserved. See Doc/License.txt or @@ -36,9 +36,8 @@ class GDCM_EXPORT Exception : public std::exception { public: /* - * Builds an exception with minimal information: name of the thrower - * method and error message - * + * \brief Builds an exception with minimal information: name of the thrower + * method and error message * @param from name of the thrower * @param error error description string */ -- 2.45.1