]> Creatis software - gdcm.git/log
gdcm.git
18 years agoFix comments
jpr [Fri, 28 Oct 2005 13:02:32 +0000 (13:02 +0000)]
Fix comments

18 years agoCommenting out useless code should avoid pb on Big Endian processors.
jpr [Fri, 28 Oct 2005 12:44:26 +0000 (12:44 +0000)]
Commenting out useless code should avoid pb on Big Endian processors.

18 years agoENH: Commit an old patch
malaterre [Thu, 27 Oct 2005 20:43:53 +0000 (20:43 +0000)]
ENH: Commit an old patch

18 years agoENH: Ok I believe MPEG is working.
malaterre [Thu, 27 Oct 2005 20:08:29 +0000 (20:08 +0000)]
ENH: Ok I believe MPEG is working.

18 years agoENH: Cleanup got the thing mostly working
malaterre [Thu, 27 Oct 2005 19:57:21 +0000 (19:57 +0000)]
ENH: Cleanup got the thing mostly working

18 years agoENH: Add a T_MEM mode so that lib can also write out to a mem buffer OUTMEM
malaterre [Thu, 27 Oct 2005 19:56:40 +0000 (19:56 +0000)]
ENH: Add a T_MEM mode so that lib can also write out to a mem buffer OUTMEM

18 years agoENH: gdcm can now read and extract MPEG file
malaterre [Thu, 27 Oct 2005 19:05:36 +0000 (19:05 +0000)]
ENH: gdcm can now read and extract MPEG file

18 years agoENH: Trying to write the worse hack ever...
malaterre [Thu, 27 Oct 2005 19:04:48 +0000 (19:04 +0000)]
ENH: Trying to write the worse hack ever...

18 years agoSTYLE: Remove cout
malaterre [Thu, 27 Oct 2005 18:14:01 +0000 (18:14 +0000)]
STYLE: Remove cout

18 years agoSTYLE: remove cout
malaterre [Thu, 27 Oct 2005 18:12:40 +0000 (18:12 +0000)]
STYLE: remove cout

18 years agoCOMP: second time I am fixing the very same bug, please respect other people work
malaterre [Thu, 27 Oct 2005 17:46:24 +0000 (17:46 +0000)]
COMP: second time I am fixing the very same bug, please respect other people work

18 years agoNow gdcm writes images with *also* Imager Pixel Spacing (0x0018,0x1164),
jpr [Thu, 27 Oct 2005 17:25:04 +0000 (17:25 +0000)]
Now gdcm writes images with *also* Imager Pixel Spacing (0x0018,0x1164),
that is the *legal* Dicom V3 place to store Pixel Spacing !

18 years agoRewrite the whole stuff for writting on BigEndian processors
jpr [Thu, 27 Oct 2005 17:07:24 +0000 (17:07 +0000)]
Rewrite the whole stuff for writting on BigEndian processors

18 years agoAdd binary_write(std::ostream &os, const double &val)
jpr [Thu, 27 Oct 2005 17:04:36 +0000 (17:04 +0000)]
Add binary_write(std::ostream &os, const double &val)
to deal with 64 bits (FD) entries

18 years agoAdd verbosity when trouble occur.
jpr [Thu, 27 Oct 2005 16:52:44 +0000 (16:52 +0000)]
Add verbosity when trouble occur.

18 years agoSTYLE: Remove debug
malaterre [Thu, 27 Oct 2005 15:57:14 +0000 (15:57 +0000)]
STYLE: Remove debug

18 years agoCOMP: Fix compilation with -pedantic and -Wwrite-strings
malaterre [Thu, 27 Oct 2005 15:54:39 +0000 (15:54 +0000)]
COMP: Fix compilation with -pedantic and -Wwrite-strings

18 years agoENH: IO abstract layer is finally working
malaterre [Thu, 27 Oct 2005 15:42:42 +0000 (15:42 +0000)]
ENH: IO abstract layer is finally working

18 years agoRemove useless local variable, to avoid warnings
jpr [Thu, 27 Oct 2005 14:12:24 +0000 (14:12 +0000)]
Remove useless local variable, to avoid warnings

18 years agoStill doesn't work on Big Endian processor, but we display error correctly
jpr [Thu, 27 Oct 2005 11:55:45 +0000 (11:55 +0000)]
Still doesn't work on Big Endian processor, but we display error correctly

18 years agoHow didn't I get one before?
jpr [Thu, 27 Oct 2005 11:39:34 +0000 (11:39 +0000)]
How didn't I get one before?

18 years agoMessage
jpr [Thu, 27 Oct 2005 10:18:22 +0000 (10:18 +0000)]
Message

18 years agoFix comments (due to removal of difference between ValEntry and BinEntry)
jpr [Thu, 27 Oct 2005 09:55:00 +0000 (09:55 +0000)]
Fix comments (due to removal of difference between ValEntry and BinEntry)

18 years agoMessages
jpr [Thu, 27 Oct 2005 09:52:33 +0000 (09:52 +0000)]
Messages

18 years agoAvoid useless work at reading time
jpr [Thu, 27 Oct 2005 09:51:28 +0000 (09:51 +0000)]
Avoid useless work at reading time

18 years agoImprove IsCoherent method
jpr [Thu, 27 Oct 2005 09:14:15 +0000 (09:14 +0000)]
Improve IsCoherent method

18 years agoRemove useless warning message
jpr [Thu, 27 Oct 2005 09:13:18 +0000 (09:13 +0000)]
Remove useless warning message

18 years agoDetail use of gdcmDebug, gdcmWarning, gdcmError, assert
jpr [Thu, 27 Oct 2005 09:12:20 +0000 (09:12 +0000)]
Detail use of gdcmDebug, gdcmWarning, gdcmError, assert

18 years agoTo avoid useless warnings
jpr [Thu, 27 Oct 2005 09:07:45 +0000 (09:07 +0000)]
To avoid useless warnings

18 years agoCreate Explicit VR images first.
jpr [Thu, 27 Oct 2005 09:05:44 +0000 (09:05 +0000)]
Create Explicit VR images first.

18 years agoENH: Compile now on C90 compilers
malaterre [Wed, 26 Oct 2005 20:51:54 +0000 (20:51 +0000)]
ENH: Compile now on C90 compilers

18 years agoENH: This lib was leaking like crazy...
malaterre [Wed, 26 Oct 2005 20:44:41 +0000 (20:44 +0000)]
ENH: This lib was leaking like crazy...

18 years agoENH: Continue cleaning of open/write/seek ...
malaterre [Wed, 26 Oct 2005 20:06:51 +0000 (20:06 +0000)]
ENH: Continue cleaning of open/write/seek ...

18 years agoENH: Start working again on the MPEG2 stuff. Gather the stdio mess in a single place
malaterre [Wed, 26 Oct 2005 19:17:30 +0000 (19:17 +0000)]
ENH: Start working again on the MPEG2 stuff. Gather the stdio mess in a single place

18 years agoBUG: Fix seg fault
malaterre [Wed, 26 Oct 2005 17:55:04 +0000 (17:55 +0000)]
BUG: Fix seg fault

18 years agoBUG: Fix declaration of vars within a switch/case
malaterre [Wed, 26 Oct 2005 17:06:33 +0000 (17:06 +0000)]
BUG: Fix declaration of vars within a switch/case

18 years agoForce commit, adding a space character
jpr [Wed, 26 Oct 2005 16:15:38 +0000 (16:15 +0000)]
Force commit, adding a space character

18 years agoENH: Change the unsafe type char to the full enum type. Much safer, and special flags...
malaterre [Wed, 26 Oct 2005 15:56:51 +0000 (15:56 +0000)]
ENH: Change the unsafe type char to the full enum type. Much safer, and special flags can be given to compiler to choose between using enum to be either int or char

18 years agoOops.
jpr [Wed, 26 Oct 2005 15:53:40 +0000 (15:53 +0000)]
Oops.
I forgot this one

18 years agoSwap64 deals with double (VR=FD)
jpr [Wed, 26 Oct 2005 15:49:56 +0000 (15:49 +0000)]
Swap64 deals with double (VR=FD)
Will avoid some warning (debug?) messages at run time

18 years agoTo avoid warnings
jpr [Wed, 26 Oct 2005 15:48:33 +0000 (15:48 +0000)]
To avoid warnings

18 years agoENH: If Ref count is -1, also delete the object (in case someone call twice a ->Delete()
malaterre [Wed, 26 Oct 2005 15:41:29 +0000 (15:41 +0000)]
ENH: If Ref count is -1, also delete the object (in case someone call twice a ->Delete()

18 years agoBUG: identifier are meaningful in this case...
malaterre [Wed, 26 Oct 2005 15:36:19 +0000 (15:36 +0000)]
BUG: identifier are meaningful in this case...

18 years agoENH: Add copy constructor. STYLE: inline keyword shall not be used within the class...
malaterre [Wed, 26 Oct 2005 15:34:33 +0000 (15:34 +0000)]
ENH: Add copy constructor. STYLE: inline keyword shall not be used within the class definition, it is garantee in the c++ spec that they will be eventually inlined

18 years agoENH: Remove check on value we know is true, also remove my stupid comment
malaterre [Wed, 26 Oct 2005 14:54:51 +0000 (14:54 +0000)]
ENH: Remove check on value we know is true, also remove my stupid comment

18 years agoBUG: ooops msg was removed from the macro if errno is not set
malaterre [Wed, 26 Oct 2005 14:50:30 +0000 (14:50 +0000)]
BUG: ooops msg was removed from the macro if errno is not set

18 years agoENH: Get rid of errno is op is success
malaterre [Wed, 26 Oct 2005 14:47:06 +0000 (14:47 +0000)]
ENH: Get rid of errno is op is success

18 years agoShould avoid compile error or dash8.kitware/GDCM-g++-64bits
jpr [Wed, 26 Oct 2005 13:16:45 +0000 (13:16 +0000)]
Should avoid compile error or dash8.kitware/GDCM-g++-64bits
>          //memcpy(BinArea, &(value[0]), l);
>        memcpy(BinArea, value.c_str(), l);
Message was :
/.../gdcm/src/gdcmDataEntry.cxx:382: non-lvalue in unary `&'
?!?

18 years agoAvoid warnings
jpr [Wed, 26 Oct 2005 13:00:15 +0000 (13:00 +0000)]
Avoid warnings

18 years ago * Fix bug in the Python demo
regrain [Wed, 26 Oct 2005 12:36:06 +0000 (12:36 +0000)]
   * Fix bug in the Python demo
   -- BeNours

18 years agoFix SplitOnPosition()
jpr [Wed, 26 Oct 2005 11:19:14 +0000 (11:19 +0000)]
Fix SplitOnPosition()

18 years ago--> Optional Element 0x0000 (group length) is no longer written.
jpr [Wed, 26 Oct 2005 09:15:19 +0000 (09:15 +0000)]
--> Optional Element 0x0000 (group length) is no longer written.
--> Illegal groups (0,1,3,4,5,6,7) are no longer written, (even if they were
    found in the original file)
    For gdcm::File -images- only (I don't know the illegal group for other types
    of gdcm::Document -gdcm::DicomDir, right now; more to come- )

18 years agoAdd over verbose debug message -to be removed withing a few (hope so) days-
jpr [Wed, 26 Oct 2005 09:09:31 +0000 (09:09 +0000)]
Add over verbose debug message -to be removed withing a few (hope so) days-
to try to track the 'SegFaul' reason on some distant platforms.

18 years ago * Fix memory leaks
regrain [Wed, 26 Oct 2005 08:28:56 +0000 (08:28 +0000)]
   * Fix memory leaks
   -- BeNours

18 years ago * Remove compilation warnings
regrain [Wed, 26 Oct 2005 08:04:15 +0000 (08:04 +0000)]
   * Remove compilation warnings
   -- BeNours

18 years agoUpdate CMakeLists.txt
jpr [Wed, 26 Oct 2005 07:21:11 +0000 (07:21 +0000)]
Update CMakeLists.txt

18 years agoRemove useless Example/TestChangeHeader
jpr [Wed, 26 Oct 2005 07:20:09 +0000 (07:20 +0000)]
Remove useless Example/TestChangeHeader

18 years agoRemove useless Example/TestCopyDicom
jpr [Wed, 26 Oct 2005 07:18:37 +0000 (07:18 +0000)]
Remove useless Example/TestCopyDicom

18 years agoSave some CPU time, when parsing ACR-NAMA files :
jpr [Wed, 26 Oct 2005 07:15:31 +0000 (07:15 +0000)]
Save some CPU time, when parsing ACR-NAMA files  :
Don't check inexistant Transfer Syntax field.

18 years agoNone of the ACR-NEMA file has a Transfer Syntax field.
jpr [Wed, 26 Oct 2005 06:57:02 +0000 (06:57 +0000)]
None of the ACR-NEMA file has a Transfer Syntax field.
Our purpose was to read ACR-NEMA, as well (not only DICOM V3 images)
When a file !IsDicomV3(), the pixels are considered to be a 'Raw State'
(uncompressed);
IsRaw = true, and everything goes on *normally*.

--> comment out the abort, on purpose.

18 years agoAdd comment on files with no "Transfer Syntax"
jpr [Wed, 26 Oct 2005 06:34:03 +0000 (06:34 +0000)]
Add comment on files with no "Transfer Syntax"

18 years agoTypo
jpr [Wed, 26 Oct 2005 06:23:37 +0000 (06:23 +0000)]
Typo

18 years agoComment out too much verbose warning message.
jpr [Wed, 26 Oct 2005 06:09:34 +0000 (06:09 +0000)]
Comment out too much verbose warning message.

18 years agoadd comment on Conversion Type
jpr [Wed, 26 Oct 2005 06:08:24 +0000 (06:08 +0000)]
add comment on Conversion Type

18 years agoDon't write elem 0x0000 -group length- of groups
jpr [Wed, 26 Oct 2005 06:07:26 +0000 (06:07 +0000)]
Don't write elem 0x0000 -group length- of groups
(but group 0x0002, where it's mandatory),
to avoid writing wrong images.
(Computing the length of a group with embedded Sequences is no so easy ...)

18 years agoBUG: Ok I dont understand gdcm internals anymore. Whoever broke the writting process...
malaterre [Tue, 25 Oct 2005 18:14:49 +0000 (18:14 +0000)]
BUG: Ok I dont understand gdcm internals anymore. Whoever broke the writting process should fix it. Add a barrier to never ever allow gdcm to read image without Transfer Syntax

18 years agoBUG: Ok someone messed up with the code... and I give up, fix your own bug
malaterre [Tue, 25 Oct 2005 17:54:55 +0000 (17:54 +0000)]
BUG: Ok someone messed up with the code... and I give up, fix your own bug

18 years agoENH: Fix nasty bug. Thanks to bcc55 for actually doing optimization
malaterre [Tue, 25 Oct 2005 17:51:17 +0000 (17:51 +0000)]
ENH: Fix nasty bug. Thanks to bcc55 for actually doing optimization

18 years agoModify the creation order of gdcmFileHelper / gdcmFile to avoid meaningless
jpr [Tue, 25 Oct 2005 16:43:46 +0000 (16:43 +0000)]
Modify the creation order of gdcmFileHelper / gdcmFile to avoid meaningless
warnings

18 years agoadd exXcoherentFileSet
jpr [Tue, 25 Oct 2005 15:58:32 +0000 (15:58 +0000)]
add exXcoherentFileSet

18 years agoTypo
jpr [Tue, 25 Oct 2005 15:57:52 +0000 (15:57 +0000)]
Typo

18 years agoCommit *very first* version of an example for using the splitting of a 'single
jpr [Tue, 25 Oct 2005 15:57:20 +0000 (15:57 +0000)]
Commit *very first* version of an example for using the splitting of a 'single
SerieUID' fileset depending on the 'Orientation'

18 years agoENH: When using your fancy find/replace, try using your brain to understand other...
malaterre [Tue, 25 Oct 2005 15:28:49 +0000 (15:28 +0000)]
ENH: When using your fancy find/replace, try using your brain to understand other people's code...

18 years ago * Some classes inherit now from gdcm::RefCounter
regrain [Tue, 25 Oct 2005 14:52:26 +0000 (14:52 +0000)]
   * Some classes inherit now from gdcm::RefCounter
   -- BeNours

18 years agoBUG: Wow, bcc55 actually did caught this one :) nice
malaterre [Tue, 25 Oct 2005 14:36:30 +0000 (14:36 +0000)]
BUG: Wow, bcc55 actually did caught this one :) nice

18 years agoCOMP: Fix bcc55 warnings
malaterre [Tue, 25 Oct 2005 14:27:37 +0000 (14:27 +0000)]
COMP: Fix bcc55 warnings

18 years agoCOMP: Fix comp on bcc55, CLOCKS_PER_SEC is a float on this compiler... sigh
malaterre [Tue, 25 Oct 2005 14:01:20 +0000 (14:01 +0000)]
COMP: Fix comp on bcc55, CLOCKS_PER_SEC is a float on this compiler... sigh

18 years agoDoxygenation
jpr [Tue, 25 Oct 2005 12:43:25 +0000 (12:43 +0000)]
Doxygenation

18 years agoAvoid polluting output
jpr [Tue, 25 Oct 2005 12:42:37 +0000 (12:42 +0000)]
Avoid polluting output

18 years agoHuge comment on CheckMandatoryElements
jpr [Tue, 25 Oct 2005 12:42:01 +0000 (12:42 +0000)]
Huge comment on CheckMandatoryElements

18 years agoavoid polluting output
jpr [Tue, 25 Oct 2005 12:41:30 +0000 (12:41 +0000)]
avoid polluting output

18 years agoBug fix in XCoherent filestet splitting
jpr [Tue, 25 Oct 2005 12:40:03 +0000 (12:40 +0000)]
Bug fix in XCoherent filestet splitting

18 years ago * Remove memory leaks
regrain [Tue, 25 Oct 2005 09:22:13 +0000 (09:22 +0000)]
   * Remove memory leaks
   -- BeNours

18 years agoForget this one
jpr [Tue, 25 Oct 2005 08:44:51 +0000 (08:44 +0000)]
Forget this one

18 years agoAvoid useless warnings while stepping jpeg fragments
jpr [Tue, 25 Oct 2005 08:41:35 +0000 (08:41 +0000)]
Avoid useless warnings while stepping jpeg fragments

18 years agoCOMP: Get rid of: Warning(510): friend function 'operator <<' ignored.
malaterre [Tue, 25 Oct 2005 03:32:53 +0000 (03:32 +0000)]
COMP: Get rid of: Warning(510): friend function 'operator <<' ignored.

18 years agoCOMP: Quickly fix comp on bcc55, dont understand why this was failing (put back old...
malaterre [Mon, 24 Oct 2005 22:49:57 +0000 (22:49 +0000)]
COMP: Quickly fix comp on bcc55, dont understand why this was failing (put back old patch)

18 years agoENH: ran dciodvfy on test.acr... getting closer to D. Clunie standart :)
malaterre [Mon, 24 Oct 2005 21:54:28 +0000 (21:54 +0000)]
ENH: ran dciodvfy on test.acr... getting closer to D. Clunie standart :)

18 years agoBUG: Fix first bug reported by dciodvfy (one chance out of two we had the wrong one)
malaterre [Mon, 24 Oct 2005 21:31:11 +0000 (21:31 +0000)]
BUG: Fix first bug reported by dciodvfy (one chance out of two we had the wrong one)

18 years agoSTYLE: Fix spacing, and change cerr to gdcmErrorMacor
malaterre [Mon, 24 Oct 2005 21:21:09 +0000 (21:21 +0000)]
STYLE: Fix spacing, and change cerr to gdcmErrorMacor

18 years agoCOMP: Remove call to problematic fprintf
malaterre [Mon, 24 Oct 2005 21:08:59 +0000 (21:08 +0000)]
COMP: Remove call to problematic fprintf

18 years agoCOMP: Ok coffee was bad...
malaterre [Mon, 24 Oct 2005 21:06:16 +0000 (21:06 +0000)]
COMP: Ok coffee was bad...

18 years agoCOMP: Avoid MACRO redifinition, shared and static should be exclusive
malaterre [Mon, 24 Oct 2005 20:57:36 +0000 (20:57 +0000)]
COMP: Avoid MACRO redifinition, shared and static should be exclusive

18 years agoCOMP: Fix static lib on win32, plus add a comment about conformance
malaterre [Mon, 24 Oct 2005 20:53:31 +0000 (20:53 +0000)]
COMP: Fix static lib on win32, plus add a comment about conformance

18 years agoCOMP: Fix warning
malaterre [Mon, 24 Oct 2005 20:28:40 +0000 (20:28 +0000)]
COMP: Fix warning

18 years agoBUG: Need to link agains gdcmoj
malaterre [Mon, 24 Oct 2005 18:40:55 +0000 (18:40 +0000)]
BUG: Need to link agains gdcmoj

18 years agoENH: Cleanup
malaterre [Mon, 24 Oct 2005 18:39:47 +0000 (18:39 +0000)]
ENH: Cleanup

18 years agoCOMP: comment within comment
malaterre [Mon, 24 Oct 2005 18:18:24 +0000 (18:18 +0000)]
COMP: comment within comment

18 years agoCOMP: Some compiler dont like C++ comments
malaterre [Mon, 24 Oct 2005 18:14:42 +0000 (18:14 +0000)]
COMP: Some compiler dont like C++ comments

18 years agoBUG: No comment
malaterre [Mon, 24 Oct 2005 17:43:49 +0000 (17:43 +0000)]
BUG: No comment