1 Sat Nov 12 09:59:24 EST 2005 by malaterre
2 * Some more update to the DICOMV3 dic. Tons of fix most of them should not
3 impact gdcm internal since VR/VM are not used...well except for SQ item
4 wich should explain some bizarre case :)
5 -> group 0000 is still in DICOMV3 dict whereas it should clearly be in
8 Mon Oct 24 13:34:45 EDT 2005 by malaterre
9 * Adding the OpenJPEG library. It contains a patch from Antonin compared to
10 the official release that allow us to work around the famous 16bits issues
13 Mon Oct 18 10:27:49 2005 by regrain
14 * Correctly use the VRKey for all vr variables... instead of TagName
16 * Replace the definition of VRKey from std::string to a class
17 containing a char[2]. All methods are inline to have no speed low
18 * Create the GDCM_VRUNKNOWN = " " for the VR values
20 Mon Oct 18 10:27:49 2005 by regrain
21 * Remove useless constructor of gdcm::Document
22 * Remove useless parameter in the constructor of gdcm::ElementSet
23 * Split gdcmCommon to separate the System specifications to the gdcm
26 Mon Oct 18 10:27:49 2005 by regrain
27 * Minor coding-style clean up
28 * Replace the ContentEntry and its derived classes (BinEntry and ValEntry)
29 by the DataEntry. This unique entry considers all datas like binary datas.
30 Some methods are added to interpret - at fly - the binary datas.
31 Due to this important change, some methods of the DocEntrySet, concerning
32 the BinEntry and ValEntry classes, are erased ; and new methods for the
33 DataEntry class are created.
34 Some methods to set the ValEntry or the BinEntry are renamed to
35 correspond to the new DataEntry, like for example :
36 - SetValEntry -> SetEntryString
37 - SetBinEntry -> SetEntryBinArea
38 This change will remove all useless creation of the string when working
41 Thu Aug 25 16:59:49 2005 by jpr
43 Now Print displays the BinEntry Content (if it's printable, and loaded)
44 Usefull for a lot od Implicit VR 'Bin'Entry (if we knew there VR, they wouldn't
46 Appreciate the difference having a look at PrintFile result for
47 gdcmData/SIEMENS_MAGNETOM-12-MONO2-FileSeq0.dcm.
49 Thu Aug 25 16:55:47 2005 by jpr
51 Add methods to check the 'printability' of a bin area
53 Thu Aug 25 15:45:40 2005 by jpr
55 According to Mathieu's suggestion, Print now display FL BinEntries in a human
58 Thu Aug 25 15:12:43 2005 by jpr
60 According to Mathieu's suggestion, *all* the elements 0x000
61 are now named 'Group Length' (even if they belong to a Shadow Group')
63 Wed Aug 24 14:09:13 2005 by jpr
64 gdcmDocEntry.cxx,h, gdcmDocEntrySet.cxx,h
65 Removal of QD patch for Private Sequence + Immplicit VR.
66 Add a clean solution (Backtracking if an Item Starter is found
69 Tue Aug 23 14:57:49 2005 by jpr
71 Brutal patch, waiting till we find a clever way to guess
72 if a doc entry is a Sequence,
73 - when it's odd number
74 - and the file is Implicit VR Transfert Syntax
75 It solves temporarily some Philips Medical Systems image problems
77 Mon Aug 22 18:17:54 200 by jpr
79 Save a *few* microseconds at run time : inline method Util::GetVersion()
82 Tue Aug 23 14:58:49 2005 by jpr
83 gdcmSeqEntry.cxx, gdcmDocEntry.cxx
84 Improve 'Print' methods
86 Sat Aug 20 11:10:24 2005by jpr
88 Use new style FileHelper contructor
90 Sat Aug 20 11:04:50 2005 by jpr
92 FileHelper::Initialize() doesn't call GrabInformationFromFile(),
93 in order not to do the job twice when using new style FileHelper Constructor.
95 Fri Aug 19 18:31:07 2005 by malaterre
97 ENH: Provide a GetVersion function, apparently need for python
99 Fri Aug 19 15:12:15 2005 by jpr
101 Initialize UserFunction pointer to 0, even for 'deprecated' form
104 Sat Jul 30 20:27:00 2005 by jpr
105 gdcmFileHelper.cxx, gdcmPixelReadConvertor.cxx
106 User is now allowed to pass a Pointer to a function of his own
107 to allow modification of pixel order (i.e. : Mirror, TopDown, )
108 to gdcm::FileHeleper, using SetUserFunction(userSuppliedFunction)
109 described as : void userSuppliedFunction(uint8_t *im, gdcm::File *f);
110 NB : the "uint8_t *" type of first param is just for prototyping.
111 User will Cast it according what he founds with f->GetPixelType()
112 See ctkgdcmSerieViewer for an example
114 Sat Jul 30 20:13:24 2005 by jpr
116 Add SerieHelper::IsCoherent() method to allow checking that the files with same
117 Serie UID have the same sizes and pixel type.
119 Fri Jul 29 17:07:16 2005 by jpr
122 SetSortOrderToDirect() or SetSortOrderToReverse()
123 to choose the ways the File* will be sorted.
125 Thu Jul 21 06:55:50 2005 by jpr
126 AnonymizeDicomDir.cxx, AnomymizeNoLoad.cxx, PrintFile.cxx, PrintDicomDir.cxx
129 Thu Jul 21 06:55:30 2005 by jpr
131 Add an example of use for SerieHelper
133 Thu Jul 21 07:00:15 2005 by jpr
135 Extend 'Restriction' syntax :
136 void SerieHelper::AddRestriction(uint16_t group, uint16_t elem,
137 std::string const &value, int op)
139 /// \brief comparaison operators
149 Wed Jul 20 15:39:00 2005 by jpr
151 AnonymizeNoLoad user can now ask for anonymization of 'BinEntries'
152 (e.g. Private entries when the TS is Implict VR)
153 AnonymizeNoLoad filein=... rubout=0x0009-0x0001,0x0013-0x1100
154 Thx to Luca Picello for reporting pb and supplying data to fix the bug.
156 Wed Jul 20 16:49:41 2005 by jpr
158 Use GDCM_LEGACY for DicomDir, as well
160 Wed Jul 20 15:31:01 2005 by jpr
162 We can now anonymize 'BinEntries' as well
164 Wed Jul 20 15:29:42 2005 by jpr
166 Add ArgMgrGetXInt16Enum to decode from the command line pairs of unsigned int
167 16, written in hexadecimal.
168 (usefull to allow terminal user to pass the (private) elements he wants to
171 Tue Jul 19 17:25:53 2005 by jpr
173 Add some comments on the 'Patient Position'
175 Tue Jul 19 11:04:58 2005 by jpr
177 Add SerieHelper::AddGdcmFile(File *header) method.
178 * \brief add a gdcm::File to the first (and supposed to be unique) list
179 * of the gdcm::SerieHelper.
180 * \warning : this method should be used by aware users only!
181 * User is supposed to know the files he want to deal with
182 * and consider them they belong to the same Serie
183 * (even if their Serie UID is different)
184 * user will probabely OrderFileList() this list (actually, ordering
185 * user choosen gdm::File is the sole interest of this method)
186 * Moreover, using vtkGdcmReader::SetCoherentFileList() will avoid
187 * vtkGdcmReader parsing twice the same files.
188 * *no* coherence check is performed, but those specified
189 * by SerieHelper::AddRestriction()
191 Mon Jul 18 12:20:20 2005 by jpr
193 In order to prepare the future extension of SerieHelper::AddRestriction (key,
195 operator = { EQUAL, DIFFERENT, LESS, LESSOREQUAL, GREATER, GREATEROOREQUAL}
197 bool Util::CompareDicomString(const std::string &s1, const char *s2, int op)
199 Sun Jul 17 06:27:49 2005 by jpr
201 Use new style for Loading files
203 Tue Jul 12 19:08:12 2005 by jpr
204 gdcmCommon.cxx, gdcmSQItem.cxx
205 To speed up DicomDir, instead of copying -and removing the source afterwards-
206 each entry of the SQItem (found after gdcm::Document parsing) towards
207 the gdcm::Object belonging to the gdcm::DicomDir, we just copy
208 the chained list itself.
210 Tue Jul 12 16:55:43 2005 by jpr
212 AnonymizeNoLoad has now one more option :
214 to give the (single Patient) directory name whose content we want to anonymize.
216 Mon Jul 11 10:20:25 2005 by jpr
217 gdcmDicomDirStudy.cxx
220 Fri Jul 8 21:07:12 2005 by jpr
222 Add the VISIT object within DicomDir
224 Fri Jul 8 12:15:08 2005 by jpr
226 Use new style for DicomDir loading
228 Fri Jul 8 16:36:48 2005 by jpr
230 To remain unimpared, gdcm::FileHelper class needs also its
231 void FileHelper::SetLoadMode(int loadMode)
232 void FileHelper::SetFileName(std::string const &fileName)
233 bool FileHelper::Load()
235 Thu Jul 7 19:31:53 2005 by jpr
237 Begin of kosherization of Example
240 Thu Jul 7 18:37:40 2005 by jpr
242 On the way to gdcm2 ...
243 Now, the stand way to use a file is :
244 gdcm::File *f = new gdcm::File();
245 f->SetLoadMode ( user say here what he wants *not* to load );
246 f->SetFileName("myFile.gdcm");
248 Old styles are kept, not to break the C++ API.
249 - gdcm::File *f = new gdcm::File("myFile.gdcm");
250 - f->Load("myFile.gdcm");
251 Due to the syntaxic abilities of Python maybe some troubles will occur
254 Thu Jul 7 15:55:39 2005 by jpr
256 Comment out the time consuming, never used/useless
257 'Extended tag' stuff for Sequence embedded Entries
259 Thu Jul 7 15:11:38 2005 by jpr
261 Move code lines LTTG so save some CPU time.
264 Tue Jun 7 13:12:10 2005 CEST by jpr
266 Use Argument Manager in 'utilities'
268 Thu Jul 7 12:12:32 2005 by jpr
270 Due to something stupid in the gdcm::File constructor, the file was parsed
271 twice when we used old style, e.g :
272 gdcm::File *f = new gdcm::File(fileName);
273 instead of new style, e.g. :
274 gdcm::File *f = new gdcm::File( );
275 f->SetLoadMode ( choose what you want *not* to load here );
278 Wed Jul 6 11:53:43 2005 by jpr
279 TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx
280 Now TestAllReadCompareDicom.cxx TestReadWriteReadCompare.cxx accept a third
281 param, in order not to have to recompile to gdcm::Debug::DebugOn().
283 Wed Jul 6 17:18:42 2005 by jpr
285 According to Mathieu's requirement, Load twice the same file keeps the rseult of
286 the first Load (instead of doing it twice)
288 Wed Jul 6 11:25:12 2005 by jpr
290 - Clean out the Entries if a Document is parsed more than once
291 - Uncomment (usefull) warning messages
293 Wed Jul 6 10:42:33 2005 by jpr
295 - Comment out a for the moment too much verbose warning message.
296 - Delay some statement as late as possible, to save some CPU time when they're
299 Wed Jul 6 13:01:08 2005 by jpr
301 Now gdcmFile::Load() returns false if file is not gdcm parsable
302 Only gdcmDocument::Load() did it, before.
303 Thx to Benoit for reporting bug
305 Sun Jul 3 14:42:04 2005 by jpr
307 Should avoid some troubles with 'no length' SQItems within 'true length'
309 Thx to Loic Boussel for providing data to fix the bug.
311 Sun Jul 3 14:42:04 2005 by jpr
313 Should avoid some troubles with 'no length' SQItems within 'true length'
315 Thx to Loic Boussel for providing data to fix the bug.
317 Sun Jul 3 14:47:23 2005 by jpr
321 Fri Jul 1 13:25:51 2005 by jpr
322 gdcmPixelReadConvert.cxx
323 Initialize RLEInfo and JPEGInfo to 0 a avoid further problems
324 (e.g. PrintFile on a DICOMDIR document)
326 Thu Jun 30 16:49:02 2005 by jpr
328 Enhance gdcm::File::IsReable() heuristics to be able to process some Loic
329 Boussel's Hall of Shame Dicom images
331 Wed Jun 29 17:58:33 2005 by jpr
333 Add the NO_SHADOWSEQ load mode
335 2005-06-26 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
336 * Quite a few new dictionaries were added in gdcm. The file:
337 gdcm/Dict/README should always explain were the info was found
338 (in case of double check). Also some dict are still only
339 express as 'template' (they contain 'xx'), therefore
340 a python script should be run first to generate a full dict.
341 In the longer term this python script should be replaced by
344 2005-06-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
345 * dicomV3.dic is deprecated in favor of gdcm.dic
346 There is now a dictionary per family:
347 - dicomV3.dic -> DICOM V3
348 - Papyrus.dic -> Papyrus
349 - NIH.dic -> tags that were never allowed in the main standard
351 Fri Jun 24 12:50:20 2005 CEST by jpr
353 Pixel Spacing related problems : update comments.
354 Thx to D. Clunie for providing data to check the code
356 Fri Jun 24 12:55:58 2005 by jpr
357 Summer nights are really too hot to sleep.
358 Coding style : kosherization of all the 'if's (300 amongst 900 were haram)
360 Thu Jun 23 11:20:23 2005 by jpr
362 Extend warning message, for debugging purpose
364 Wed Jun 22 10:11:23 2005 by jpr
368 Wed Jun 22 10:00:29 2005 by jpr
369 gdcmPixelReadConvert.cxx
370 Fix misstyping, while removing spurious \t characters
372 Wed Jun 22 09:52:32 2005 by jpr
373 gdcmPixelReadConvert.cxx
374 Some constructors (at least one ...) use BitsAllocated =! BitsStored for
376 That break at lot of viewers ...
377 We now *propagate the sign bit* upon the unused ones, better than masking them
379 Thx to Luca Picello for profiding data to fix the bug
381 Wed Jun 22 09:53:52 2005 by jpr
383 gdcm images are now "GDCM 1.1" built.
385 Mon Jun 20 19:10:17 2005 by jpr
387 Avoid re writing Palette Color Lookup Table UID when Palette Color is removed
389 Mon Jun 20 17:58:53 2005 by jpr
391 Preventive bug fix for LUT Data.
392 I said : LUT Date, *not* Palette Color
394 Sun Jun 19 17:57:29 2005 by jpr
396 To avoid warnings at compile time
398 Fri Jun 17 14:27:52 2005 by jpr
402 Fri Jun 17 14:36:07 2005 by jpr
406 Fri Jun 17 14:35:00 2005 by jpr
408 Add some accessors for debugging purpose
410 Tue Jun 14 15:56:41 2005 by jpr
411 gdcmPixelReadConvert.cxx
412 Now gdcm deals with 16 bits per pixel images with 16 bits Palette colors
413 (3 * 65536 short int ...)
415 "Segmented Palettes" pb still pending, but I never saw any viewer dealing with it.
417 Mon Jun 13 17:43:48 2005 by jpr
418 gdcmPixelReadConvert.cxx
419 Some more oddities dealt with.
420 Doesn't work yet with 65536 entries 16 Bits LUT (?!?), with 16 bits pixels.
421 Still looking for accurate info on the web about it
423 Fri Jun 10 16:05:38 2005 by jpr
425 Bug fix in Load method.
426 Thx to Benoit for providing fix.
427 2005-06-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
428 * src/gdcmUtil.cxx : change call to Util::Format to sprintf because of
429 lantency with the Util::Format function
431 Tue Jun 7 15:48:35 2005 by jpr
433 The highy time consuming method GetMacAdress is now called just once
435 Tue Jun 7 11:58:29 2005 by jpr
436 gdcmDicomDirElement.cxx
437 Use TranslateToKey better than Format
439 Tue Jun 7 12:07:20 by jpr
441 Remove some spurious calls to Format
442 // according to 'Purify', TranslateToKey is one of the most
443 // time consuming methods.
444 // Let's try to shorten it !
446 Mon Jun 6 14:37:58 2005
447 class ArgMgr (for Arguments Manager) is designed for
448 command line arguments management
449 (to make programmer's live easier)
450 (could be used for any kind of 'command line program')
452 2005-06-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
453 * Adding users file in CVSROOT for mail blaming
455 2005-06-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
456 * Adding potential support for JPEG-LS DICOM files.
458 Fri Jun 3 18:05:23 2005 by jpr
460 Fix VR processing, to be CP-288 conform.
461 Now we can parse any kind of DICOM SR.
463 Fri Jun 3 11:05:15 2005 by jpr
467 Thu Jun 2 15:42:18 2005 by jpr
469 Add warning about Load Mode
471 Thu Jun 2 16:20:14 2005 by jpr
473 Harden gdcm::File::IsReadable(), in order not to be confused any longer
474 by lost of Pixel Element
476 Fri May 27 12:51:00 2005 by jpr
478 To avoid pushing out twice the meta elements, wile trying to write 'ACR-NEMA-
480 And avoid some memry leaks -hope so-
482 Wed May 25 14:54:17 2005 by jpr
484 Should avoid some memory leaks
486 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
487 * Adding potential support for mpeg and jpeg2000 through two new lin
488 - JasPer for JPEG2000
489 - libmpeg2 from the MPEG consortium
490 Also adding intial work to use this lib.
492 Fri May 20 10:27:55 2005 by jpr
495 (this time, it's wasn't dangerous at run time)
497 Thu May 19 17:31:21 2005 by jpr
499 FIX possible troubles when checking
500 'Hight Bit Position' vs 'Bits Allocated' and 'Bits Stored'
501 Thx to Mathieu for reporting bug
503 Wed May 18 12:12:07 2005 by jpr
505 Fix : now dcm deals with 'No preamble', Big Endian Explicit VR group 0002.
506 Thx to Dennis Hu for providing a sample image to fix the bug.
508 Tue May 17 14:44:09 2005 by jpr
510 ENH : According to David Clunie's advice, we check now 'Imager Pixel Spacing'
511 before 'Pixel Spacing', when we want to get X or Y Spacing.
513 Tue May 17 19:10:49 2005 by jpr
515 ENH : Now, FileHelper::CheckMandatoryElements() makes some consistency checking,
516 at LTTG (Least Time To Go)
517 around Bits Allocated, Bits Stored, High Bit Position,
518 to avoid unaware user to mess up the stuff.
520 Tue May 3 11:43:04 2005 by jpr
522 Load returns now a bool (allow user not to call IsReadable() )
524 Tue May 3 11:51:06 2005by jpr
526 Now the gdcm::File remains unimpaired after writting, in any case
528 Fri Apr 29 17:10:55 2005by jpr
530 Don't abort the prog when File not open
532 Wed Apr 27 12:00:35 2005 by jpr
534 Removal of now useless lut-related stuff
536 Wed Apr 27 11:52:27 2005 by jpr
538 Pb of 'Bits Allocated = 12' is now dealt with in
539 FileHelper::CheckMandatoryElements, no longer in File::Write.
540 Thx to Mathieu for reporting bug.
542 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
546 Tue Apr 26 18:18:23 2005 by jpr
548 Should leave gdcm::Document constructor in a much quicker
549 and much cleaner way when anything wrong occurs.
551 Tue Apr 26 18:25:49 2005 by jpr
552 gdcmPixelReadConvert.cxx
553 Prepare MPEG Dicom encapsulated processing (within a loooong future)
555 Fri Apr 22 14:59:58 2005 by jpr
557 Modify Print() output
559 Fri Apr 22 15:37:57 2005 by jpr
561 Prepare (future) MPEG integration
563 Thu Apr 21 09:40:00 2005 by jpr
565 Taking into account Dicom MPEG
567 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
568 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
569 But this is a case where we should really signify the user there is
570 few chance the serie is really a serie...
572 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
573 * FIX : on X, the python part is correctly installed. All files are
574 installed in gdcm sub-directory
576 Tue Apr 19 11:58:19 2005 by jpr
578 Should suppress some warnings from Borland compiler
580 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
581 * Builder/ : add something to facilitate the RPM creation of gdcm
583 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
584 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
586 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
588 Thu Apr 14 16:26:19 2005 by jpr
590 Now, user can ask gdcm::DicomDir to skip SeqEntries or shadow groups, when
592 // Old style (still available) :
593 dcmdir = new gdcm::DicomDir(dirName, true);
595 // new style (user is allowed no to load Sequences an/or Shadow Groups)
596 dcmdir = new gdcm::DicomDir( );
597 dcmdir->SetParseDir(true);
598 dcmdir->SetLoadMode(NO_SEQ | NO_SHADOW);
599 dcmdir->Load(dirName);
601 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
602 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
604 * Fix compilation on gcc 2.96 (which does not have ios::failure)
606 Mon Apr 4 17:15:24 2005 by jpr
608 Fix stupid bug when writting ACR-NEMA image from 'ACR-LibIDO' one.
610 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
611 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
612 and it's representation name (for the NIH)
614 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
615 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
616 conversion of YBR to RGB pixels. So, now, the conversion is made using
619 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
620 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
621 format) to replace 'at-run' dicom files generated by the
622 TestAllReadCompareDicom test
624 Tue Mar 22 12:29:37 2005 by jpr
626 * FIX : element 0x0000 of shadow groups is now force to a ValEntry,
627 and it's VR is forced to UL
628 * ENH : user id now allowed to tell he doesn't want to deal with Sequences
629 and/or with Shadow groups
630 use SetLoadMode (NO_SEQ | NO-SHADOW);
632 Tue Mar 22 12:40:13 2005 by jpr
634 *FIX Restore pushed out elements
636 Fri Mar 11 12:08:31 2005 by jpr
638 Remove spurious #define MAX_SIZE_PRINT_ELEMENT_VALUE
640 Fri Mar 11 12:12:13 2005 by jpr
642 Final removal of gdcmFileHelper::InitializeDefaultFile();
644 Wed Mar 9 20:29:38 2005 by jpr
646 Add Anonymize method (not yet fully checked)
648 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
649 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
651 Wed Mar 2 18:18:32 2005by jpr
653 Fix gdcm::FileHelper::CheckMandatoryElements() to take into account David
656 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
657 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
659 Mon Feb 21 18:45:41 2005 by jpr
661 * Replace method CheckMetaElements by CheckManadatoryElements
662 To deal with the pb of UID's, and with Type 1 an Type 2 Entries
663 (probabely some stuff still missing)
664 * We shall have to decide the way we proceed to allow user 'freeze' Serie UID
665 between a given call and the next one (to add images to a Serie he just
667 * We shall have to decide the way we proceed to allow user 'freeze' Study UID
668 between a given call and the next one, or to reuse an already existing
669 Study UID (i he wants to add his own Series to an already existing Study)
671 Thu Feb 17 17:18:33 2005 by jpr
673 To avoid further pb, Initialize defaults now Photochromatic Interpretation to
674 MONOCHROME2 (low values = dark), better than MONOCHRONE1.
675 Thx to Benoit for reporting bug
677 Thu Feb 17 11:56:20 2005 by jpr
679 Prepare FileMetaInformationVersion (group 0002) management
681 Thu Feb 17 12:02:47 2005 by jpr
683 Group 0002 management
685 Thu Feb 17 12:03:32 2005 by jpr
686 gdcmDocEntryArchive.cxx
689 Wed Feb 16 11:19:19 2005 CET by jpr
690 gdcmPixelReadConvert.cxx
691 Taking into account MONOCHROME1 + Signed Pixels (?!)
693 Tue Feb 15 19:12:34 2005 by jpr
695 Taking into account the difference between MONOCHROME1 (low values = bright)
696 and MONOCHROME2 (low values = dark)
698 Mon Feb 14 11:45:04 2005by jpr
700 Remove some useless mask operations, to save CPU time
702 Mon Feb 14 15:51:10 2005 by jpr
704 *never* forget to re-compile just *before* committing!
706 Mon Feb 14 15:34:27 2005 by jpr
708 First commit on the post 1.0 (Version? / Tag? / Branch?) :
711 Mon Feb 14 11:45:47 2005 by jpr
713 remove useless comments
715 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
716 * Testing/TestMAkeIcon.cxx : complete the test
718 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
719 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memory leaks
721 Fri Feb 11 16:22:18 2005 by jpr
723 Typo, comments, doxygenation
725 Thu Feb 10 11:55:26 2005 by jpr
727 AnonymizeNoLoad improvement
729 Thu Feb 10 10:07:19 2005 by jpr
731 Duplicate Matthieu's hack to prevent bombing in Anonymize
733 Thu Feb 10 12:20:34 2005by jpr
735 The following gdcm::DocEntrySet methods, no re-definable is child classes are no
737 virtual ValEntry *GetValEntry(uint16_t group, uint16_t elem);
738 virtual BinEntry *GetBinEntry(uint16_t group, uint16_t elem);
739 virtual SeqEntry *GetSeqEntry(uint16_t group, uint16_t elem);
740 virtual bool SetValEntry(std::string const &content,
741 virtual bool SetBinEntry(uint8_t *content, int lgth,
742 virtual bool SetValEntry(std::string const &content, ValEntry *entry);
743 virtual bool SetBinEntry(uint8_t *content, int lgth, BinEntry *entry);
744 virtual ValEntry *InsertValEntry(std::string const &value,
745 virtual BinEntry *InsertBinEntry(uint8_t *binArea, int lgth,
746 virtual SeqEntry *InsertSeqEntry(uint16_t group, uint16_t elem);
748 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
749 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
752 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
753 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
755 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
756 * Test/ : accelerate tests (it's not very significant accelerations).
757 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
759 Mon Feb 7 15:48:34 2005 by jpr
761 Add some commented out lines to prepare future version of 'Full DICOMDIR' stuff
764 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
765 * Testing/TestSequence.cxx : add test for sequences of images... test that
766 we have the same serie or the same study UID
768 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
769 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
771 * src/gdcmDict.h : remove commented code
772 * src/gdcmDocument.cxx : initialize values
773 * src/gdcmFile.cxx : bug fix when reading values
774 * gdcmPython/demo/ : change file names. Remove useless files
776 Sun Feb 6 15:31:09 2005 by jpr
778 Update comments for DicomDir stuff
780 Sun Feb 6 15:39:35 2005 by jpr
782 * Add method File::AnonymizeNoLoad, to allow anomymizing files
783 even when the pixels are not gdcm Readable
784 * Add methods File::AddAnonymizeElement and File::ClearAnonymizeList
785 to allow user to choose the elements whose value
786 he wants to white out / replace
788 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
789 * src/gdcmFile.cxx : remove the default array of initialization.
790 The static array contained pointers to non-static values (comming from
791 strings). To have coherences, when creating files, these values can't be
792 static. So, the array can't be static, too ! To simplify, the array have
793 been replaced by repeted lines to insert values in the File
795 Fri Feb 4 15:49:01 2005 by jpr
797 * Add GetFirstValEntry + GetNextValEntry, for Python users
798 * Some more Doxygenation + typo fixing
800 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
801 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
802 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
804 Thu Feb 3 18:12:46 2005 by jpr
805 gdcmPixelReadConvert.cxx
808 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
809 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
810 (Dicom Element) into the Sequence Item
812 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
813 * src/*.cxx : first parss to normalize file organisation
815 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
816 * src/gdcmDirList.[h|cxx] : add method to find a directory
817 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
819 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
820 * Finish cleaning up my JPEG mess. Should be ok now.
821 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
822 contained within the RLE* class(doh!)
824 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
825 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
826 * SerieHeader::AddFileName() creates as many Coherent Files lists
827 (same Serie UID) as it founds different Serie UID
828 amongst the files instead of discarting any file
829 that doesn't match with the first one he found.
830 * SerieHeader::OrderGdcmFileList has now one parameter :
831 the Coherent Files list the user wants to sort
832 * SerieHeader::GetFirstCoherentFileList() |
833 * SerieHeader::GetLastCoherentFileList() | allow to parse
834 the set of Coherent Files lists
835 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
836 compatibility (it returns the *first* Coherent Files list,
837 since there was only one before)
838 * Test/TestSerieHeader gets gdcmData as a default root directory
840 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
841 * Remove friend between DocEntry and File classes
842 * Remove friend between PixelReadConverter and RLEFramesInfo,
845 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
846 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
847 0002|0000. The value was incorrect.
849 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
850 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
852 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
853 * src/gdcmUtil.cxx : compilation fix on Win32
854 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
855 variable, to be easy found. Add methods to change the default UID.
856 Amelioration of the CreateUniqueUID to use the correct default UID.
857 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
860 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
861 * Test/TestVR.cxx : fix memory leaks
863 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
864 * Rewrite the base 256 to base 10 conversion, using string operation only.
865 This allows us to get rid of the problematic 64bits integer type (does not
866 always exist on target platform).
868 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
869 * Add construct and destructor to class gdcm::Debug to close the debug file
871 * Don't let uset to open twice the same file
872 * gdcm has now an official UID prefix,
873 supplied by http://www.medicalconnections.co.uk
874 1.2.826.0.1.3680043.2.1143
875 (Thx to Mathieu for providing URL)
876 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
877 to be able to perform some more tests
878 * gdcm::ContentEntry : Contructors and Destructor are now protected,
879 in order to be sure no user will try to use them.
880 (at user level, only the children classes are meaningfull)
882 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
883 * move RLEInfo & JPEGInfo from Document to File
885 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
886 * FIX : remove so many friend between classes
888 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
889 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
890 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
892 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
893 In order to avoid missbehaviour :
894 . gdcm::DocEntry is now specialized in
895 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
896 - gdcm::ContentEntry (Dicom entry with a 'content')
897 . gdcm::ContentEntry is specialized in
898 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
899 characters value, or integers)
900 - gdcm::BinEntry (Dicom entry with a non strig representable value
901 (user hasn't any longer to thing about the precedence of his dynamic_casts)
903 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
904 * Test/VTKTest*.cxx : bug fix under linux
906 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
907 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
908 use with python. Some methods are moved from Document to ElementSet or
909 DocEntrySet. The equivalent methods to ElementSet have been added to
910 SQItem and are virtual in DocEntrySet. Methods that may have the same code
911 in SQItem and ElementSet is directly placed in DocEntrySet
913 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
914 * Test/VTKTest*.cxx : remove the show variable in each test method because
915 it's useless (the viewer variable replace this variable)
917 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
918 * src/gdcmDocument.cxx : bug fix on potential memory leak
919 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
920 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
921 Add ClearXxx methods to remove all the content of the list or map
922 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
924 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
925 * methods ReplaceOrCreate renamed as Insert
926 (nobody will be any longer confused by 'CreateOrReplace')
928 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
929 * Grealty simplify the JPEg decompression, no need to differenciate based on
930 the JPEG possible type (with/without fragment, with/without multiple frame).
931 Everything is done throught the JPEG IO Suspension mechanism in IJG
933 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
934 * Stage 3 of normalization :
935 in order to avoid any missunderstanding while reading method names :
936 - All the methods xxxEntry now deal with dicom Entries
937 - Methods GetEntry splitted into
940 - Method SetEntry renamed as SetEntryValue
941 - Method SetEntryBinArea let as it was
943 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
944 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
945 - Position correctly the entry points for JPEG2000 and JPEG-LS
946 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
948 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
949 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
950 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
951 with other method names
952 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
953 * Test/TestDicomDirElement.cxx : add new test
955 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
956 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
957 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
958 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
959 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
960 So can't you use __int64 in ostream at all.
962 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
963 * bug fix for compilation on MSVC6
964 * gdcmPython/gdcm.i : rename of classes missed
966 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
967 * Stage 2 of names normalization :
968 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
969 (easy to understand ...)
970 - gdcm::FileHelper replaces old class gdcm::File
972 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
973 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
974 type and not a string. So, there remove problems on the format of the
977 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
978 * Add Example/TestPapyrus.cxx
979 - reads a Papyrus file (gdcm::Header compliant),
980 - gets the pixels of all the images, using low level iterators
981 - writes an multiframes Dicom image.
982 (Just to show it's *possible* to do that)
983 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
986 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
987 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
988 Thus, DicomDirXXX are created with a flad that indicates if the created
989 object is empty or not (when not empty, the DicomDirElement is used to
992 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
993 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
994 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
996 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
997 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
999 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1000 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
1001 Remove all access to the hash-tables or lists in the objects.
1003 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1004 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
1005 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
1006 be complient with all the gdcm source code
1008 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1009 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
1010 DictEntry or the VR.
1012 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1013 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
1016 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1017 * Test/ : rename VTK tests to have a best name for the tests
1018 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
1019 GetFirstEntry/GetNextEntry use
1021 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1022 * In SerieHeader::ImagePositionPatientOrdering()
1023 // a Dicom 'Serie' may contain scout views
1024 // and images may have differents directions.
1025 // -> More than one may have the same 'pos'
1026 // Sorting has then NO meaning !
1027 Thx to Eduardo Davila for reporting bug.
1029 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1030 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
1031 test. Now it's on image content and not on the resulting visualisation...
1032 might solve the problem on linux when using the OpenGL drivers
1034 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1035 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
1036 DicomDirSerie, DicomDirImage
1037 Dict, DictSet classes :
1038 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
1039 -remove InitTraversal method.
1040 * UPD Test programs + Example programs
1042 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1043 * remove useless and never updated keyword \ingroup
1044 * Solve pb when structure (list, map, ...) is empty.
1045 Thx to Benoit for reporting bug
1047 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1048 * Taking into account of 'Transfer Syntax' value
1049 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
1052 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1053 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
1054 is no memory access violation
1055 * gdcmPython/demo : add python demos using VTK
1057 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1058 * FIX 'Dictionnary' is now spelt 'Dictionary'
1059 'wether' is now spelt 'whether'
1060 'archieve' is now spelt 'archive' ;-)
1062 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1063 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
1064 related methods, in order not to expose internal mechanisms
1067 * REM methods that exposed internal mechanisms :
1068 DicomDir::GetDicomDirPatients()
1069 DicomDirPatient::GetDicomDirStudies()
1070 DicomDirStudy::GetDicomDirSeries()
1071 DicomDirSerie::GetDicomDirImages()
1072 * UPD Test programs :
1076 * UPD Example program
1078 * ADD DictSet methods
1082 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1083 * Removed the Print/indent/default parameter mess. There is absolutely no
1084 reason to have to methods, moreover with the second taking the ostream as
1085 *SECOND* parameter. This was clearly a bad hack to get things compile.
1087 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1088 * Complete rewrite of the GetMacAddress code. Now the code is *much*
1089 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
1090 Unfortunately the main code does not work on SunOS, thus provide a specific
1091 code for this platform only (and Win32 of course). Since this seems to be
1092 working, change CreateUniqueUID to use GetMACAddress instead of the
1093 problematic GctestetIPAddress
1095 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1096 * Unfortunately to be able to test gdcmDirList I had to break the API
1097 a little. Now the class is not a std::list anymore but has a member
1098 std::vector (more ITK compatible). Allow unit testing on Win32 and
1101 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1102 * Update SerieHeader to take into account a Serie Instance UID to properly
1105 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1106 * ENH - Comment out Mathieu's (dangerous) Super Hack
1107 for dealing with BIGENDIAN processors
1108 - Move equivalent stuff to BinEntry::WriteContent
1109 When necessary, 16 Bits Pixels are swapped in a small buffer
1110 and then written. This avoid allocating a huge buffer, in
1111 PixelWriteConvertor, and avoid modifying the Pixel Area.
1113 Probabely, the same operation will have to be done when we want
1114 to write image with Big Endian Transfert Syntax,
1115 and we are working on Little Endian Processor
1117 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1118 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
1120 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
1121 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
1122 all the dict content.
1123 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
1125 * Test/TestDict.cxx : add a new test for the dict classes
1127 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1128 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
1129 file. Debug is yanked if compiled with NDEBUG
1131 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1132 * src/gdcmDictSet.h : set the default output to the os variable
1133 * src/gdcmDictEntry.[h|cxx] : add the Print method
1134 * gdcmPython/demo/ : add a new test
1136 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1137 * merging of Test/PrintDicomDir and Test/TestDicomDir
1138 * removal of now redundant Test/PrintDicomDir
1139 * enhancement of Example/PrintDicomDir
1141 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1142 * Now, python test might work on systems
1143 * Add the PrintDicomDir test
1145 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1146 * FIX : First entry following group 0002 was lost for
1147 Explicit Big Endian Transfer Syntax files
1148 (group and elem not swaped)
1150 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1151 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
1152 Big Endian Transfer Syntax supposed the group following 0002
1153 begins always by element 0000 (element 0000 is *optional*)
1154 To avoid further troubles, let's be pessimistic, and use
1155 Document::HandleOutOfGroup0002() method
1156 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
1157 (related pb not yet solved)
1159 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1160 * Bug fix for the python part use
1161 * Now, PrintHeader.py pass... but outside the ctest use. shit !
1163 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1164 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
1166 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1167 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
1168 a string and should ask the global TS dict what are the propreties of
1171 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1172 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
1173 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
1174 to swap the Swap Code, at parsing time, when we come out of group 0002
1175 and Transfer Syntax is Big Endian
1176 We should be able to read now 'true DICOM" Big Endian coded images
1177 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
1178 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
1180 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1181 * Hopefully fix the bug on MacOSX and static global initialization.
1182 This is the only -minor- patch I found that both please MacOSX and VS6.
1183 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
1184 but this would require a lot of change. Another approach would be that Global
1185 create those string and GDCM_UNFOUND becomes a pointer to a string (which
1186 gdcm::Global would destroy at exit).
1188 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1189 * Fix bug on MacOSX with static initialization in a multy threaded
1190 environment. static const string in a header file used to be ill
1191 initialized provoquing the freeze of any tests. patch should solve this
1194 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1195 * According to Benoit's suggestion, and without any objection from anybody
1196 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
1197 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
1198 - method gdcmDicomDirObject::GetEntry() renamed as
1199 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
1201 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1202 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
1203 you debug/warning message just as c++ streams which make them very convinient
1204 to use. Once this is stabilize I will change the ostringstrem to be
1205 redirected to a file (ofstream).
1206 * Properly support C99 extension: __FUNCTION__ which allow us to display
1207 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
1209 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1210 * Removal of useless and dangerous methods :
1211 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
1212 GetDocEntryByName, GetEntryByName, GetDictEntryByName
1213 * Removal of usless methods :
1214 Dict::PrintByName, Dict::GetDictEntryByName
1215 * Commenting out of probabely useless methods :
1216 Dict::GetDictEntryNames()
1217 Dict::GetDictEntryNamesByCategory()
1218 DictSet::GetPubDictEntryNames()
1219 DictSet::GetPubDictEntryNamesByCategory()
1220 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
1221 * ENH : Use dicomTS.dic as described in 2004 version
1222 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
1223 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
1224 Add Accessors on VM (Value Multiplicity), and VM related methods
1225 * ADD : Add a list of 'Dicom Attribute types', as found in
1226 http://medical.nema.org/dicom/2004/04_15PU.PDF
1228 * ADD : Add dicomGroupNameAbbreviations.dic
1229 should be used to write a method to replace the former
1230 Dict::GetDictEntryNamesByCategory()
1232 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1233 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
1234 to read in the file... and only it ! Length is the efective length of the
1235 data in the DocEntry structure
1237 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1238 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
1239 And now use a static function call instead, with a global variable. i
1240 This is much closer to the VTK approach. Hopefully should be bulletproof
1241 and easier to use...hopefully
1243 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1244 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
1246 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1247 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
1249 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1250 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
1251 ValEntry, BinEntry, SeqEntry creation or replace
1253 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1254 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
1255 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
1257 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
1258 when specifying the VR
1259 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
1260 * src/gdcmDocEntry.cxx : amelioration of print
1262 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1263 * ADD : Add the method Util::IsCurrentProcessorBigEndian
1264 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
1265 * ADD Method Document::ComputeGroupLength
1266 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
1267 in order to allow further VR modification by user
1268 * REM : removal of once-called method File::WriteBase
1269 integration of its code in formerly one-line method File::Write
1271 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1272 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
1273 replace the different values "??", "Unkn", "Unknown".
1274 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
1275 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
1276 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
1277 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
1279 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1280 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
1282 * Set the gdcm::Base class to some Printable classes
1284 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1285 * src/gdcmFile.[h|cxx] : add the Print method
1286 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
1287 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
1288 * src/gdcmDocument.h : remove the PrintLevel informations
1289 * Example/PrintFile.cxx : use the new gdcm::File::Print
1291 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1292 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
1293 problems when compiling with the python wrapping
1295 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1296 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
1297 writting in ImplicitVR
1299 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
1300 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
1301 JPEG decompression, especially when dicom frames are split into several
1302 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
1303 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
1305 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1306 * src/gdcmHeader.cxx : change the initialisation of default header.
1307 Now, this header is readable by gdm, e-film, DicomWorks
1309 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1310 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
1311 Rename Decompressed to Raw
1312 * Use the API changes in gdcm::File.
1313 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
1316 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1317 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
1318 each added entry in the header. Replace the 'Planes' field by the 'Number
1321 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1322 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
1323 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
1325 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1326 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
1327 At this time, this image isn't readable by e-film... waiting JPR help to
1330 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1331 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
1332 DocEntry. Now use methods of the Document !
1334 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1335 * Test/ShowDicomSeq.cxx : bug fix
1337 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1338 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
1339 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
1340 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
1341 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
1343 * Test/TestCopyRescaleDicom.cxx : remove unused variable
1344 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
1345 containing found sequences
1347 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1348 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
1350 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
1351 Some fields in BinEntry must be copied to not seg fault when making the :
1352 gdcm::File *copy = new gdcm::File( copyH );
1353 and tests are now made on good variables
1355 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1356 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
1357 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
1359 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
1360 * Add vtkGdcmWriter example and test
1362 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1363 * Test/TestUtil.cxx : reformat the source code
1364 * vtk/vtkGdcmReader.cxx : remove and change prints
1365 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
1367 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
1368 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
1370 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1371 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
1372 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
1374 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1375 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
1376 by an eof to prevent all bad read of the file... and in this case, the
1377 file isn't readable.
1379 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1380 * Example/Volume2Dicom.cxx : comment unused variables
1381 * Test/PrintDicomDir.cxx : comment unused variables
1382 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
1383 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
1384 method that is redondant with AddEntry.
1385 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
1388 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1389 * Bug fix due my last commit (compilation under Windows).
1390 * Example/Volume2Dicom : bug fix in the file and reformatting source code
1391 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
1393 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1395 - Remove printf / sprintf
1396 - include iostream AFTER gdcm so we don't get warnings
1397 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
1399 - Also remove tons of include from header files, hopefully this should
1400 speeup the compilation time, since it was becoming a dog slow.
1401 - Remove gdcm.h as it include way too many files and slow down compilation
1402 (plus it is not up to date)
1403 - remove 'using namespace std' this is BAD !
1405 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1406 * Remove memory leaks on the DicomDir
1407 * Remove some useless data in DicomDirObject
1408 * Add usefull methods in SQItem, to be complient withe the ElementSet
1410 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1411 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
1413 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1414 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
1415 future, with convertion)
1416 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
1417 and ImageDataSize values. Remove the method to get the PixelReadConverter
1418 from the output of the class
1420 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1421 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
1423 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1424 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
1425 and vtkErrorMacro use.
1426 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
1428 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1429 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
1431 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
1432 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
1433 The string leaves only in the fonction. So when we make a .c_str(), we
1434 get the pointeur on the first element, element that will be destroyed
1435 immediately after thee instruction.
1436 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
1437 file has been opened : the test must be made on the content of the
1438 pointer and not directly on the pointer !
1441 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1442 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
1443 the python part recompiles
1445 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1446 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
1447 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
1448 X session is killed (for my computer... it seems to not be identic on
1451 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1452 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
1453 avoid problems (otherwise, the difference test between the visible image
1454 and the reference is incorrect. If the reference is greater than the
1455 screen resolution, it's produce errors).
1456 Can be used for only one image. Can be used with a visible flag.
1457 * vtk/vtkGdcmReader.cxx : remove commented codes.
1458 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
1459 under windows at compilation
1460 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
1461 for grayscale images
1462 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
1464 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1465 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
1466 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
1467 tests on the image size X, Y, Z
1469 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1470 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
1471 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
1472 between the class name and the file name
1474 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1475 * src/ : fix compilation warnings for the Write method (2 different
1476 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
1477 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
1478 variable... create a static method in gdcm::Document to access to
1479 this variable content.
1481 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1482 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
1483 file, to be accessed by other files (like gdcmFile). Remove commented
1484 code. Move the change of the header to the gdcmFile, using the
1486 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
1487 To be sure of that (and simplify calls), the Write of the header now
1488 gets a file name and not a file pointer (std::ifstream).
1489 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
1490 DocEntryArchive. Remove all open of the written file
1492 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1493 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
1495 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1496 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
1497 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
1499 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
1500 some corresponding methods. Write correctly the file and check before
1502 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
1503 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
1504 is now on RGB data (as before my last commit
1505 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
1507 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1508 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
1509 Add a print information of the type of the entry
1510 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
1511 It was in the gdcmFile, and all write have been regrouped
1512 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
1513 Write correctly all dicom files (in decompressed mode only at this time)
1514 * Test/ : test on files are now made using Raw data and not color data if
1516 * Example/PrintFile.cxx : add more printings
1518 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1519 * Amelioration of code, remove some code copy. For the loading of
1520 BinEntry (in gdcmDocument), add the test to verify if the file is already
1523 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1524 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
1525 remove a DocEntry in the header (push an empty DocEntry)
1526 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
1527 lines. Bug fix in the initialization of the PixelConvert and the
1529 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
1530 use in TestCopyDicom (now this test can run under windows... but fails)
1531 * Test/TestCopyDicom.cxx : amelioration of the test :
1532 - test the pixels written
1533 - add test points to quickly find where is the error
1534 - can set a file name input and output in arguments
1535 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
1536 amelioration of the test output
1538 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1539 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
1540 all replaced DocEntry's
1541 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
1542 Now, each needed DocEntry to modify is duplicated, modified and inserted
1543 to the header using DocEntryArchive. Thus, after save, we can restore the
1544 header initial state.
1546 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1547 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
1549 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1550 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
1551 correct to copy it. The DictEntry is specified at the DocEntry creation,
1552 then, it musn't change in the time.
1553 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
1554 header correctly. At this time, the change is only made for the first
1555 level of the Document. In the future, it might consider sequences.
1556 The change is made by replacing a DocEntry by an other that is created
1557 outside the class. The old value is kept. When we restore the header
1558 status, the added DocEntry is deleted and replaced by the old value.
1559 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
1560 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
1561 set the write type to explicit VR, implicit VR or ACR. Add methods to set
1562 the write mode to native, decompressed or RGB (but not used at this time)
1564 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1565 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
1566 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
1568 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1569 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
1570 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
1572 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
1573 set because already copied when copying the BinEntry's of the header
1574 * Test/TestAllReadCompareDicom.cxx : remove warnings
1576 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1577 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
1578 Two problems appear when doing it :
1579 - with the gdcmFile : when the GetImageData method is called, the pixels
1580 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
1581 data (pixels). And each structure destruct the data when it's
1582 destructed. So we have two destructions for the same data. To solve it,
1583 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
1584 data or not. If it doesn't own data, then they will not destroyed by
1586 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
1587 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
1588 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
1589 create a double destruction of the same DocEntry's. So, to solve it,
1590 the TagHT is simply cleared and the DicomDir* elements are destroyed.
1591 * TODO : add an entry concerning memory leaks in the DicomDir
1593 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1594 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
1595 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
1598 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1599 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
1600 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
1601 after it have been deleted
1603 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1604 * FIX: src/* fix the doxygen warnings.
1605 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
1606 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
1607 was erroneously defined with a size of 15 instead of 16. [many thanks
1608 to Jean Michel Rouet for pointing out this bug].
1610 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1611 1. Finish merging JMR patch for writting DICOM from scratch
1612 2. Fix -hopefully- bug with MONOCHROME and space vs null character
1613 3. Use const ref when possible
1614 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
1615 5. A few more comments
1616 6. CreateUniqueUID can now be called without parameter"
1618 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1619 * ENH: Slightly bigger patch:
1620 1. Getting toward full integration of JMR patch for writting dicom from scratch
1621 2. Update Test to test part of this patch: CreateUniqueUID
1622 3. File was not close properly in gdcmDict
1623 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
1624 5. Use of const ref instead of copy (speed issue)
1625 6. Remove temporary (duplicate) string in TranslateToKey
1626 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
1627 8. Do not repeat virtual in subclasses
1628 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
1630 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1631 * Apply first patch toward better string comparison when dealing with broken
1632 DICOM files. Essentially the string could be padded with a space instead
1633 of a null character as defined by standard
1635 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1636 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
1637 because never used... and in the same time, that's remove some memory leaks
1639 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1640 * src/gdcmFile.cxx : now delete the PixelConvert instance.
1641 * In examples and tests : change the type of image data variables from void*
1642 to uint8_t*. Remmove all delete on image data variables
1644 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1645 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
1646 Verify the file pointer value before open the file, and if it's not null,
1647 a verbose message is generated.
1648 Close correctly the file when the file isn't considered dicom-like. The
1649 correctly close is a call to CloseFile.
1650 When closing the file pointer, test if its not null to close the file.
1651 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
1652 file. For an uncompressed image, the copied data correspond in the least
1653 case to the image size (calculated) or the image size specified in the
1654 header. A verbose is generated if these two size mismatch
1656 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1657 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
1658 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
1659 break under windows (with msvc6 compilation).
1661 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1662 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
1663 compiling with MSVC6)
1665 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1666 * Bugs fix for the Windows build with VC6
1667 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
1668 needed (only for projects required VTK). If the VTK is included in all
1669 projects, there is conflicts with the jpeg lib of vtk when compiling the
1670 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
1671 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
1672 when compiling the gdcm_wrap.cxx file (created by the compilation of the
1674 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
1675 (like it's already made for the cout use). Otherwise, conflict with the
1678 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1679 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
1680 * gdcmPython/gdcm.i:
1681 - comments on the DicomDir::Method related usage added.
1682 - now that we use the namespace gdcm, a lot of internal classes do
1683 NOT need to be wrapped anymore.
1684 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
1685 DicomDir::Method) new example added.
1687 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1688 * Improve string manipulation. I now inforce the notion of 'DicomString'
1689 A DicomString can contain as many \0 as they want
1690 and it is *always* of even length.
1691 We only support odd length for very rare case.
1692 And in the near future this should be removed.
1694 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1695 * /binary_write/ gdcm source. Now even on big endian we are writting
1696 little endian. This should -heopfully- fix some tests
1698 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1699 * Now the dictionary is compiled into gdcm lib. This is a default
1700 behavior, thus any dic file specified is picked before failback to
1701 the one comiled into lib
1703 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1704 * Change internals for gdcmDict. Don't use any 'new' any more.
1705 This should definitely solve any leak problem, and we should be
1706 as fast as before, as long as don't modify too much the dictionary.
1708 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1709 * STYLE: ivars should start with a capital letter.
1710 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
1711 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
1713 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1714 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1715 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1716 new 2004 dictionaries added (thanks to JPR).
1717 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1718 * CLEANUP_ROUND (15) for gdcmPixelConvert
1719 - RLEFrame::NumberFragments is now of type unsigned int
1720 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1721 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1724 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1725 * Initial work in gathering all transfer syntax accessors. clearly
1726 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1727 ivars, but only one transfersyntax (class) ivar with equivalent method on
1730 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1731 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1732 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1733 discussed (plus I didn't like having a 2000 lines patch not commited)
1735 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1736 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1737 * CLEANUP_ROUND (14) for gdcmPixelConvert
1738 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1739 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1740 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1741 CloseFile() anymore.
1742 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1743 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1744 into File::Pixel_Data.
1746 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1747 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1748 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1749 * CLEANUP_ROUND (13) for gdcmPixelConvert
1750 Substituted File::ParsePixelData() with PixelConvert::Print() new
1752 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1753 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1754 method to those classes.
1755 - src/gdcmFile.[cxx|h]:
1756 -- Added a ::Print() method.
1757 -- PixelConverter is now a reference instead of a member.
1758 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1759 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1761 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1762 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1763 collaboration diagram and inheritance diagram should be generated with
1765 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1766 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1767 pointlessly wrapped (see
1768 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1769 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1770 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1771 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1772 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1773 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1774 -- File::Initialise: PixelConverter setup moved away to
1775 PixelConverter::GrabInformationsFromHeader()
1776 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1777 interpretation moved away to PixelConverter::BuildRGBImage()
1779 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1780 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1781 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1783 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1784 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1785 displayed on Win32 when a brutal abort() occurs (because of uncatched
1786 exception). See TODO new entry of this commit for more on this.
1787 * TODO added new entry.
1788 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1789 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1790 - HandleColor is no longer called from gdcmFile.cxx
1791 - gdcmPixelConvert.cxx clean up on method arguments and internal
1792 variable names for semantical coherence.
1794 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1795 * Finished lossless transition, not only do we now read all lossless jpeg
1796 images, without the need of the Cornwell lib, but we do read them properly now
1797 * To reduce code (well to avoid code duplication), I defined a common place
1798 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1799 redefine symbols. This is not perfect but this the best solution I found for a
1800 compilation time jpeg option.
1802 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1803 * Update jpeg ijg lib to support lossless jpeg implementation
1804 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1806 * Also added a special copyright for dcmtk since we use their bugfixes.
1809 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1810 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1811 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1812 matters, as stated in warning note at beginning of %include section).
1813 * src/gdcmDicomDir*.[cxx|h]: coding style
1814 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1815 * src/gdcmJpeg8.cxx: doxygen fix.
1816 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1817 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1818 from File:: to PixelConvert::.
1820 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1821 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1822 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1823 - more code moved away from File:: to PixelConvert::
1824 - fat setup of PixelConverter set in place in File::Initialise.
1826 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1827 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1828 namespace at the file system level. So now you should convert your examples
1830 gdcmHeader -> gdcm::Header
1831 It would be nice if people keep in mind to no open the namespace, since it
1832 allows compilation on broken plateform which were defining common symbol in
1833 the standard namespace (like LP, Unknown ...)
1835 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1836 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1837 The JPEG fragments are now parsed at the same stage than the RLE
1838 information. All code related to JPEG is now in gdcmPixelConvert:
1839 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1840 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1841 export a gdcmFile:: method. Those are simply global functions
1842 (for the time being this is better than having them attach to
1843 either gdcmFile:: or gdcmPixelConvert::).
1844 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1845 and stores the result in a gdcmJPEGFragmentsInfo.
1846 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1847 code (among other stuff) moved away from gdcmFile:; to
1850 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1851 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1852 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1853 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1854 clean up of RLE related code.
1855 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1856 - src/gdcmRLE.cxx removed
1857 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1858 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1859 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1860 * CLEANUP_ROUND (9) for gdcmPixelConvert
1861 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1862 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1863 away from gdcmFile:: to gdcmPixelConvert::.
1865 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1866 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1867 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1868 This is because Parse7Fe0 used to parse the pixels to compute the
1869 length. This task was passed over to FindDocEntryLengthOB() a long
1870 time ago, EXCEPT I forgot the OW case...
1871 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1872 we just recylce the code for parsing RLE fragments and computing
1874 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1875 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1876 with the retired Parse7Fe0().
1877 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1878 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1880 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1881 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1882 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1883 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1884 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1885 * CLEANUP_ROUND (4) for gdcmPixelConvert
1886 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1887 to return an unused length.
1889 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1890 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1891 this should be cleanner from the plane view. The iostream are erally a pain
1892 to use to do simple stuff.
1894 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1895 * Redo the compilation of the ijg jpeg library. Now only one source is
1896 necesseray. No need to rename file by hand what so ever. CMake handle the
1897 copying of the file within different directory, configure header file to
1898 modify some symbol. The only addition made to ijg wasd a mangle table so
1899 that symbol are different whether we are within 8bits or 12bits.
1901 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1902 * Added documentation of vtkgdcmReader on Website:
1903 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1904 with it's binary name).
1905 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1906 the Website to be more complete.
1907 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1908 doxygenated documentation.
1909 - Doc/DoxyVtkGdcmReaderExamples.txt added
1910 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1911 DoxyVtkGdmReaderExamples.html )
1912 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1913 * CLEANUP_ROUND (3) for gdcmPixelConvert
1914 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1916 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1917 * CLEANUP_ROUND (2) for gdcmPixelConvert
1918 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1920 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1921 * CLEANUP_ROUND for gdcmPixelConvert:
1922 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1923 - src/gdcmPixelStuff[h|cxx] removed
1924 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1925 - src/CMakeLists.txt changed accordingly
1926 * GDCMHOME clean up:
1927 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1928 gdcmVersion.py moved to newly created ATTIC related
1929 gdcmPython/SetupOldies/ directory.
1930 * Autotools clean up:
1931 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1932 - autogen.sh configure.in acinclude.m4 python.m4 removed
1934 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1935 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1936 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1937 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1939 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1940 * TODO updated with Mathieu suggestions. I proposed a template for
1941 describing TODO entries and used it for new entries.
1942 * Added Doc/Website/CodingStyle.html, Developpers.html,
1943 DeveloppersPython.html, GdcmDataCvs.html and
1944 DownloadVersion0_1.html, DownloadVersion0_3.html.
1945 * Some Doc/*.txt Doxygen files (which do not really concern the
1946 documentation itself, but the website) moved to html and
1947 placed in directory Doc/Website:
1948 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1949 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1950 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1951 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1952 * CMakeLists.txt changed accordingly.
1953 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1954 DeveloppersPython.html
1955 * INSTALL nows refers to Doc/Website/Installation.html
1957 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1958 * Added Doc/Website directory, that contains a first raw version
1961 2004-09-23 Jean-Pierre Roux
1962 * FIX In order not to be poluted any longer by casting problems,
1963 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1964 we can now delete[] it safely
1965 * VoidArea is now called BinArea (less confusing name),
1966 and all the methods called ...VoidArea... are now ... BinArea...
1967 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1969 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1970 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1971 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1972 up to the destructor of gdcmElementSet to clean up TagHt and it's
1975 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1976 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1977 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1979 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1980 * ENH: added some utility method that builds a flat dictionary
1981 holding all the Dicom entries contained in the recursive structure
1982 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1983 an example of usage.
1984 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1985 BuildFlatHashTable() that build a flat dictionary.
1986 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1987 gdcmDocument is now a friend of gdcmElementSet.
1988 - src/gdcmElementSet.cxx: clean up.
1989 - Example/FlatHashTablePrint.cxx added.
1990 - Example/CmakeLists.txt changed accordingly
1992 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1993 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1994 moved away from gdcmDocEntrySet (since this class is an abstract class
1995 acting like an interface). SQDepthLevel and BaseTagKey are now
1997 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1998 and associated accessors. Doxygenation of the class.
1999 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
2001 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
2002 Use SQDepthLevel accessor instead. ::Print() adapted.
2003 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
2004 - src/gdcmDocument.cxx changed accordingly.
2006 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2007 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
2008 - The following is the doxygen comment of the typedef declaration
2009 of gdcmTagKey in src/gdcmCommon.h:
2010 gdcmTagKey is made to old an "universal" (as in URL, Universal
2011 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
2012 A dicom tag always has a group and an element, but a set of tags
2013 embeded in various (optionally nested) sequences and sharing
2014 the same group and element all share the same (group, element)
2015 "identifier". Hence the (group, element) cannot be used as an
2016 identifier (in gdcm we shall refer to a "TagKey") of a tag.
2017 In order to construct a proper tag identifier (i.e. a key) we
2018 consider the following definition of a TagKey:
2019 - let Group, Element be the string representation of the
2020 group and element dicom tag members,
2021 - let ItemNumber be the string representation of the integer
2022 index of the considered item number of a sequence,
2023 Let the key of a tag embeded in a sequence, noted SeqTag, be
2025 /ItemNumber#Group|Element
2026 where "/", "#" and "|" are characters acting as separators.
2027 Then the general form of a gdcmTagKey is given by:
2028 Group|Element<SeqTag>
2029 where <SeqTag> means NO or many instances of SeqTag.
2030 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
2033 but the gdcmTagKey of a tag "embeded" is the first item of
2034 a sequence, itself nested in the third item of a sequence is the
2036 0004|1220/2#0008|0082/0#0008|0090
2037 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
2038 order to hold the new sequence compatible key. Previously, the
2039 GetKey() method would look in the underlying gdcmDictEntry.
2040 - src/gdcmDocEntry.cxx:
2041 -- constructor now copies the underlying DictEntry key, in the local
2043 -- ::Print: displays the member Key, instead of the (group, element).
2044 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
2045 - src/gdcmDocEntrySet.h:xi
2046 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
2047 -- now has a new BaseTagKey member.
2049 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
2050 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
2052 This poses the problem with the semantics of the following lines
2053 LoadEntryVoidArea(0x0028,0x1201); // R LUT
2054 LoadEntryVoidArea(0x0028,0x1202); // G LUT
2055 LoadEntryVoidArea(0x0028,0x1203); // B LUT
2056 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
2057 to the long FIXME note for what the problem is. Nevertheless in
2058 order to get things working the dicom dictionary was altered !
2059 Please fix things urgently...
2060 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
2061 information), see above note on moving the member VoidArea. Nevertheless
2062 the following entries previously correctly set as US are now inproperly
2064 0028 1201 OW IMG Red Palette Color Lookup Table Data
2065 0028 1202 OW IMG Green Palette Color Lookup Table Data
2066 0028 1203 OW IMG Blue Palette Color Lookup Table Data
2067 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
2068 of gdcmDocEntry moved to gdcmSeqEntry.
2069 * src/gdcmSeqEntry.cxx: STYLE.
2071 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2072 * Test/TestAllEntryVerify.cxx minor fix and added comments.
2074 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2075 * gdcmPython/testSuite.py: all the test suite in python is now moved
2076 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
2077 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
2078 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
2080 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2081 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
2082 to avoid inclusion recursion until STL is reached.
2083 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
2084 mecanism. errno.h is not included in gdcm anymore.
2085 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
2086 (gdcmFormatError now inherits from gdcmFormatUnexpected).
2088 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
2089 gdcmData/TestAllEntryVerifyReference.txt
2090 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
2091 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
2092 exception_on_error parameter.
2093 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
2094 - vtk/vtkGdcmReader.cxx changed accordingly,
2095 - Example/*.cxx and Test/*.cxx changed accordingly.
2097 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2098 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
2099 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
2100 enable_sequences removed from gdcmHeader constructor and dependencies.
2101 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
2102 * gdcmPython/demo/PrintHeader.py: dummy fix.
2103 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
2104 skip_shadow removed from gdcmHeader constructor and dependencies.
2105 * Example/*.cxx and Test/*.cxx changed accordingly.
2107 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2108 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
2109 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
2111 2004-07-21 Jean-Pierre Roux
2112 * FIX Now, Parsing and Printing a DICOMDIR do work!
2113 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
2115 2004-07-20 Jean-Pierre Roux
2116 * FIX Some brain damaged headers have Zero-Lenght fields
2117 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
2119 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2120 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
2121 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
2122 variable (instance of gdcmDebug) by a definition macro, and the instance
2123 is now in static in the gdcmDebug class
2124 * src/gdcmSQItem.h : (FIXME) remove an undefined method
2125 * Test/PrintAllDocument.cxx : bug fix in the result of the test
2127 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2128 * WARNING: ctest now depends more tightly on gdcmData. You should
2129 check out gdcmData properly for things to run smoothly...
2130 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
2131 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
2132 we need the pixels not be loaded in order to use the ValEntry
2133 that displays position and size).
2134 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
2135 This is a C++ based equivalent of gdcmPython/testSuite.py that should
2136 be deprecated. If you have any doubts about the advantages of a
2137 modern scripting language (read Python) versus grass root C++ (i.e.
2138 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
2139 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
2140 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
2141 Anyhow, consider documenting the gdcmData images in
2142 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
2144 * Test/CMakeLists.txt:
2145 - now uses TestAllEntryVerify.cxx
2146 - specific comments on oldACR00001.ima (now renamed in gdcmData
2147 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
2148 gdcmData/TestAllEntryVerifyReference.txt
2151 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2152 * src/*.[h|cxx] : typedef clean up
2153 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
2154 - TagKey renamed to gdcmTagKey (for external usage)
2155 - VRKey renamed to gdcmVRKey (for external usage)
2156 - removal of typedef duplication.
2157 - Removed all unecessary inline keyword from class inline definitions.
2158 - Some method|function(void) declarations replaced with method|function().
2159 * src/jpeg/libijg12/jdhuff12.c:
2160 - printf polluting ctest removed.
2161 - TAB removal for comminting
2163 - TestAllReadCompareDicom.cxx: added a test that compares all the
2164 images in gdcmDataImages.h with corresponding images in
2165 gdcmData/BaselineDicom/. When baseline images are not present
2166 this test creates them.
2167 Note: we need to validate each reference image, but before that
2168 I'd like to rename them with a more explicit name...
2169 - CMakeLists.txt: changed accordingly.
2170 * Example/*.cxx: examples now only include gdcm.h (as opposed to
2171 including each header needed).
2173 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2174 * Test/*.cxx and Example/*.cxx: moved some examples away from the
2175 test suite to the Example directory. Are concerned:
2180 - TestWriteSimple.cxx
2181 * Test/CMakeLists.txt: added some comments on reasons for black listing
2182 image gdcmData/oldACR00001.ima
2184 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2185 * Test/CmakeList.txt: removed the following from black list (to be coherent
2186 with removal from gdcmData):
2187 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
2188 - gdcm-MR-PHILIPS-16.dcm
2190 Added the following because after last cvs update, they cause
2191 ctest -R TestReadWriteReadCompare
2193 - gdcm-MR-SIEMENS-16-1.acr
2195 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
2196 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
2197 new comments in this file) we temporarily (sigh) move to a weaker
2199 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
2200 we don't need to black list the following images anymore:
2201 - 8BitsUncompressedColor.dcm
2203 - US-PAL-8-10x-echo.dcm
2204 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
2205 fixes and the beautified code ;-)
2206 This fixes the bug introduced in version 1.42 (when beautifying)
2207 that made the parsing of 8BitsRunLengthColor.dcm unproper.
2208 Note: ctest was blind to this bug (this means we need to still
2209 improve the test suite). The bug could be detected by using
2210 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
2212 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
2213 and by displaying the (garbage) produced file temp.XDCM...
2215 2004-06-29 Jean-Pierre Roux
2216 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
2217 - replace by uggly but working old code :-(
2218 A lot of things should be OK again.
2219 It's really urgent to have a test suite that *tests*,
2220 to prevent Frog's beautifying sessions to break all the stuff
2221 (twice, withing a fortnigh ...)
2223 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2224 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
2225 redundancy) to added Test/TestReadWriteReadCompare.cxx
2226 * Test/CmakeList.txt: because the compare test of
2227 Test/TestReadWriteReadCompare.cxx fails, the following images are
2228 black listed: - 8BitsUncompressedColor.dcm
2230 - US-PAL-8-10x-echo.dcm
2231 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
2232 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
2233 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
2234 and ad-hoc kludge. This kludge is now removed, and on encountering
2235 such an image (OB field brain damaged) we set errno. Then in
2236 ::FindDocLength() we "fix" the length as being ALL what remains
2237 in the file (until EOF). We then proceed, hoping for the best...
2238 This fixes a SegFault in ShowDicom when trying to write such an
2240 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
2241 (because TestWriteRead breaks on it, after a non conformal commit?).
2242 ctest now runs properly, except for MakeDicomDir (which was always
2243 broken) and the Python related stuff (still not fixed).
2245 2004-06-24 Jean-Pierre Roux
2246 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
2247 FIX : Test/TestReadWrite now iterates on all the file names
2248 (instead of infinite loop)
2249 ENH : Test/TestWriteRead now iterates on all the file names
2251 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2252 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
2254 2004-06-24 Jean-Pierre Roux
2255 FIX : - now Write drops LUT Descriptors and LUTs (if any)
2256 when SamplesPerPixel =3
2257 - now Write is no longer confused by
2258 'BitsAllocated = 12" and 'BitsStored=12"
2259 - "UN" value representation Elements are now written correctly
2260 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
2261 ENH : - now gdcmHeader has its own Write methods
2262 (in order to split the job that has not to be done
2265 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2266 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
2267 loop on the same image until memory went out.
2268 Note: this means we still have gobs of memory loss in PrintDocument
2269 * src/gdcmDocument.cxx: fixes problem on parsing on file
2270 gdcmData/16BitsJpegLosslessGrayScale.dcm.
2272 2004-06-24 Jean-Pierre Roux
2273 FIX : Write - All the Sequences and Sequence Item are now written
2274 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
2275 is added a the end, when necessary.
2276 - A lot of brain-damaged images, that were read correctly are
2277 now written correctly
2278 - length compatible BinEntry are now loaded correctly
2279 (even for odd groups)
2280 Note : only Explicit Value Representation was checked.
2281 (question : is implicit VR really necessary for gdcm ?)
2283 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2284 * DEVELOPPER: added a proposition of coding style.
2285 * src/gdcmDocEntry.h: removed every inline declaration (for test of
2288 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2289 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
2290 Use the gdcmDocEntry::Print() and Write() instead.
2291 * src/gdcmDocument.cxx: bug fix.
2293 2004-06-22 Jean-Pierre Roux
2294 FIX : gdcmDocument.cxx
2295 - Now we do recognize the JpegLossLess format (there was a misstyping in
2296 code 'beautyfication' :-(
2297 - Now we automaticaticaly load the Luts, if any
2299 2004-06-22 Jean-Pierre Roux
2300 In order : to write Sequences, whatever their imbrication level,
2301 : to allow user to create his own Sequences
2302 a lot of modif where necessary (adding, moving, or virtualising methods)
2304 WARNING : save your own sources *before* cvs up !
2307 ADD virtual void Write(FILE *fp, FileType filetype);
2310 ADD virtual void Write(FILE *fp, FileType filetype);
2311 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
2314 ADD virtual void Write (FILE *fp, FileType filetype)=0;
2315 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
2316 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
2317 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
2318 ADD std::string GetEntryByName(TagName name);
2319 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2321 std::string vr = "unkn",
2322 std::string fourth = "unkn",
2323 std::string name = "unkn");
2324 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2325 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2326 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2327 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
2328 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
2329 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2330 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
2331 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
2334 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
2335 ADD virtual std::string GetEntryByName (TagName tagName);
2336 ADD virtual std::string GetEntryVRByName (TagName tagName);
2337 REM virtual bool Write(FILE *, FileType);
2338 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
2339 FILE *_fp, FileType type);
2340 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
2341 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
2342 REM virtual bool WriteEntries(FILE *_fp,FileType type);
2343 REM virtual std::string GetEntryByName (std::string tagName);
2344 REM virtual std::string GetEntryVRByName (std::string tagName);
2345 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
2346 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2347 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2349 std::string vr = "unkn",
2350 std::string fourth = "unkn",
2351 std::string name = "unkn");
2352 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2353 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
2354 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2355 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2358 ADD virtual void Write(FILE *fp, FileType filetype);
2361 ADD virtual void Write(FILE *fp,FileType filetype);
2364 ADD virtual void Write(FILE *fp, FileType filetype);
2365 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
2366 REM std::string GetEntryByNumber(guint16 group, guint16 element);
2367 REM std::string GetEntryByName(TagName name);
2370 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
2372 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2373 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
2374 The default constructor invoked by the line
2375 gdcmHeader *f1 = new gdcmHeader( header );
2376 was gdcmHeader::gdcmHeader(bool) instead of the expected
2377 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
2378 Hence the parsing wasn't executed... See also below.
2379 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
2380 as explicit constructor didn't do the trick to fix the above problem.
2381 Could anyone explain why ?
2382 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
2383 properly calls gdcmValEntry::Print() (that was weed out from
2384 code related to gdcmBinEntry).
2386 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2387 * In order to fix memory leaks:
2388 - Test/TestWriteSimple.cxx: added cleaning of free store through
2390 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
2391 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
2392 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
2393 (through the call to ::AddDicomDirMeta()) or the destructor
2394 would crash when deleting uninitialized ::metaElems].
2395 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
2396 - src/gdcmDocument.cxx:
2397 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
2398 from dynamic stores.
2399 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
2400 was causing memory leaks.
2401 - src/gdcmSQItem.cxx:
2402 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
2403 cleanly handled with polymophism: sorry but my milage is low).
2404 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
2405 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
2406 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
2407 This avoids SegFaulting.
2408 - src/gdcmSQItem.h: coding style.
2410 - Test/TestWriteSimple still severely sucks. The output image content
2411 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
2412 damaged when displayed with vtkgdcmViewer.
2413 - on memory leaks: TestWriteSimple leaks really less (see entry
2414 of 2004-06-18 in Changelog file for the call to valgrind).
2415 - on segfaults: ctest now passes all the tests but one (no more
2417 * Erroneous leading white fix:
2418 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
2419 white[s] (as opposed to from >> xxx, that removes it [them].
2420 - src/gdcmTS.cxx: ditto.
2421 - gdcmPython/testSuite.py: dirty related kludge removed.
2422 * src/*: remaining references to gdcmParser removed.
2423 * src/*[cxx|h]: added copy[way]left header.
2426 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2427 * In order to fix writing of dicom files:
2428 - Test/TestWriteSimple.cxx: a simpler example of writing.
2429 - Test/CMakeLists.txt changed accordingly.
2430 - src/gdcmDocument.cxx:
2431 -- The destructor now recursilvely removes potential sequences.
2432 -- Bug fix in ::IsJPEG2000()
2433 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
2434 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
2436 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
2437 to only declared) and build on top of
2438 ::GetDocEntryByNumber(guint16, guint16).
2439 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
2440 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
2441 for usage in destructor and treatement of promotion in
2442 ::ReplaceOrCreateByNumber().
2443 - src/gdcmSQItem.cxx: destructor should better handle his job.
2444 Test/TestWriteSimple now runs (or at least it DOES something).
2445 * We can now start hutting memory links. A good starting point is:
2446 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
2447 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
2448 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
2450 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2451 * Valgrind note: after Mathieu Malaterre teached me how to read
2452 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
2454 Using gcc, you can force the STL to use malloc and to free memory as
2455 soon as possible by globally disabling memory caching.
2456 With 3.2.2 and later, you should export the environment variable
2457 GLIBCPP_FORCE_NEW before running your program.
2458 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
2459 simply vanish (it is still not clear to me, whether this means that
2460 STL std::string leaks or if valgrind believes it leaks...).
2461 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
2462 running bin/gdcmTests makeDicomDir):
2463 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
2464 - Test/makeDicomDir.cxx now properly traps empty lists and returns
2466 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
2467 SegFaulting (I drowned in DicomDir related code when trying to
2468 understand why the list is empty...).
2469 * src/gdcmDocument.h: first BSD license header try.
2470 * Doc/License.txt added.
2472 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2473 * src/gdcmDocument.[h|cxx]:
2474 - Clean up of the Transfer related predicates. They are now all based
2475 on new method isGivenTransferSyntax, that (should) handle properly
2476 the padding problem.
2477 - general clean up, simplification, and coding style.
2478 - Specific clean up of Parse7FE0() (umproperly named actually).
2479 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
2481 2004-06-14 Jean-Pierre Roux
2483 - fix the display of Sequence Delimitor (SQDepthLevel pb)
2484 - fix the display of SQItem ordinal number
2485 - add the GetSQItemByOrdinalNumber method
2486 - remove some useless never written private methods
2488 2004-06-14 Jean-Pierre Roux
2490 - adding a constructor taking a gdcmDocEntry as an input param
2491 - ReplaceOrCreateByNumber now returns :
2492 a gdcmBinEntry * if a Binary (void *) value is passed as a param
2493 a gdcmValEntry * if a string value is passed as a param
2495 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
2496 according to the param type (no longer sets a gdcmDocEntry)
2497 - GetValEntryByNumber, GetBinEntryByNumber added
2498 - NewValEntryByNumber and NewBinEntryByNumber added
2500 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
2502 - GetSQItemNumber and SetSQItemNumber added, to provide
2503 a (relative) Item identier inside a given Sequence
2504 \warning : some pb remaining around this number
2506 - AddEntry now takes the Item Number as a param
2508 - adding a constructor taking a gdcmDocEntry as an input param
2510 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2511 * Memory leak hunt with the following command:
2512 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2513 --show-reachable=yes gdcmTests PrintDocument
2514 It looks like many (all?) leaks are due to the STL (or a bad usage
2515 of the STL. The lines producing the leaks now have a comment with
2516 a "MEMORY LEAK" tag: you can retrieve them with
2517 grep "MEMORY LEAK" src/*
2518 Here are two typical examples which I can't help fixing:
2523 char * test = "babo";
2524 name = test; //// <--- valgrind detects 960 bytes lost in
2525 //// call to std::string::operator=(char const*)
2526 name.clear(); //// Doesn't help !
2534 std::cout << "Type a bunch of characters followed by RETURN: ";
2535 getline(std::cin, line); //// <--- valgrind dectects a loss
2536 //// of 1320 bytes in call to
2537 /// std::basic_istream<>& std::getline<>
2543 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2544 * src/gdcmHeader.[cxx|h]:
2545 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
2546 and related, moved away to gdcmDocument.
2547 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
2548 the corresponding protected accessors of inherited class
2549 gdcmDocument, removed ! As a consequence gdcmFile had to be
2550 declared friend of class gdcmDocument (see below).
2551 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
2552 - Clean up of undefined or unused methods.
2553 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
2554 account the changes to gdcmHeader.h).
2555 * src/gdcmDocument.h:
2556 - gdcmFile is now a friend class (in order to take into account the
2557 changes to gdcmHeader.h).
2558 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
2559 (see changes to gdcmHeader.h).
2560 - Accessors (reading on the form GetEntry*) are now public.
2561 - Clean up of undefined or unused methods.
2562 * src/gdcmDocument.cxx:
2563 - adaptation to changes to gdcmDocument.h
2564 - ::OpenFile now writes a verbose message when file cannot be opened.
2565 - some std::string properly set to VRKey
2566 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
2567 references to gdcmDocument.
2568 * Test/TestFindTags.cxx: changed accordingly to above changes.
2569 * gdcmPython/testSuite.py: adapted to renaming of acr files in
2570 cvs repository gdcmData.
2572 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2573 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
2574 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
2575 conflicts with gdcmValEntry::voidArea.
2576 * src/gdcmValEntry.cxx: unmatching comment wiped out.
2577 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
2578 Value representation between StringRepresentable and BinaryRepresentable.
2579 * src/gdcmDocument.cxx:
2580 - method ParseDES: proper indentation restored and usage of
2581 gdcmVR::IsVROfGdcmStringRepresentable wired in.
2582 - method LoadDocEntry: the fingerprint left in the SetValue() of
2583 unloaded entries (length > MaxSizeLoadEntry) had curiously been
2584 removed. Reverting to previous code segment with the proper
2585 dynamic_cast< gdcmValEntry* >.
2586 Note: this was (partially) breaking the python test suite
2587 (gdcmPython/testSuite.py) that made usage of the above
2588 fingerprint to check presence of "Pixel Data".
2589 * src/gdcmDocEntry.h: coding style.
2590 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
2591 now taken into account.
2592 * gdcmPython/gdcm.i: adaptation to the new internal representation
2593 of gdcm (exit gdcmParser, hello gdcmDocument).
2594 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
2596 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
2597 anymore, but instead prints the loaded Python dictionary.
2598 * .... alas, the python testSuite is still broken.
2600 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2601 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
2603 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
2604 * src/gdcmUtil.h : export methods
2606 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2607 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
2609 * Initial addition of automatic python testing
2610 * Initial addition of automatic image comparison
2612 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2613 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
2614 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
2616 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2617 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
2618 * Test/ShowDicom.cxx : bug fix for msvc compilation
2619 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
2621 2004-05-04 Jean-Pierre Roux
2622 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
2623 new concepts (and new classes) :
2624 a 'gdcmDocument' is composed of a set of Doc Entries, that are
2625 - elementary gdcmDocEntries (former gdcmHeaderEntries)
2626 - Sequence Doc Entries (gdcmSeqEntries)
2627 a Sequence is composed of Items.
2628 Each item is a set of Doc Entries (this is recursive)
2629 The non uniqueness of the 'Dicom tag' is due to this recursivity
2630 (never taken into account)
2631 Our unability to add a new 'entry' in the header
2632 at the proper location (neither in the H-Table (map or multimap),
2633 nor in the Chained List is also due to this recursivity.
2634 Don't try, right now, to use/modify/compile these new sources :
2635 nothing is finished.
2636 We just commit all the stuff, 'as is', in order not to loose it.
2638 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2639 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
2641 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2642 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
2643 file prefix (SetFilePrefix)
2645 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2646 * Add a new test: ShowDicom, for now this is just the c++ version of
2647 checkRead.sh, later it will be able to compare the image read against a
2649 * Replace the DEBUG on the stack with a global entry in cmake interface:
2650 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
2652 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2653 * Add an example subdir, with a real example on how to read + write a
2656 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2657 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
2658 * Doc/CMakeLists.txt: the main page is now properly differentiated
2659 between the developper and user version.
2660 * Doc/doxygen.config.in: dropped search related obsolete flags
2661 * src/gdcmParser.h, gdcmHeader.h: doxygenation
2663 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2664 * DEVELOPPER: added some helpfull comments for compile/test/install
2667 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2668 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
2669 src directory, now generated in the build dir.
2670 2. Tests as mentionned smarter
2672 4. Add a new method in gdcmDict that return the PubDict by name
2673 this is interesting for 3rd party lib like ITK,
2674 where we could set the institution name / patient name...
2676 * ENH: 1. Now the test suite is working for real
2677 2. All binaries are now output in the gdcm-bin directory
2678 (this was not true before)
2680 2004-04-28 Jean-Pierre Roux
2681 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
2682 SeQuence indented printing of Dicom Header.
2683 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
2684 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
2685 Computation of SQDepthLevel is now part of gdcmHeader constructor
2686 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
2687 tree-like structure of a Dicom Header.
2688 * FIX Test code cleaning
2690 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2691 * ENH: Adding automatic testing
2692 1. Need a DartConfig.cmake to submit to public
2693 2. Add a test driver gdcmTest.cxx
2694 3. gdcmTestMain, an helper for the main test driver gdcmTest
2695 4. Files in Test don't have a main anymore, this becomes interesting
2696 when we add more and more tests, thus dsw don't have to load
2698 * ENH: Adding a GDCM_DATA_ROOT for testing
2699 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
2700 one file instead of seven + some small cleanup
2702 2004-04-22 Jean-Pierre Roux
2703 * ENH Minor changes to the Print() methods.
2704 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
2705 Header printing. Example given with :
2706 > PrintHeader fileName 2 new
2707 (SQ based tree-like structure still to be done for the Header ...)
2709 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2710 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
2711 1. I have added some unsigned where needed
2712 2. Some function parameter not used -> (void)
2713 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
2714 4. g++ don't like character '\' in comment
2715 5. #define jpeg_create_decompress jCreaDecompress
2716 this really need to be fixed
2717 6. virtualize destructor of gdcmObject ... leakage
2718 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2719 this also really need to be fixed
2720 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2721 remove compression file
2722 (as we only do decompression, right ?)
2723 * ENH: Change malloc/calloc/free with c++ equivalent
2725 2004-04-21 Jean-Pierre Roux
2726 * FIX gdcmHeaderHelper::GetXSpacing
2727 when a single value is found (bug ?), xpacing is now
2728 defaulted to yspacing
2730 2004-04-19 Jean-Pierre Roux
2731 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2732 * ENH add parameters :
2733 bool exception_on_error = false,
2734 bool enable_sequences = false,
2735 bool ignore_shadow = false
2736 to the gdcmFile constructors to be full gdcmParser compliant
2737 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2738 to allow reading of PAPYRUS 3.0 files
2740 2004-04-06 Jean-Pierre Roux
2741 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2743 2004-04-02 Jean-Pierre Roux
2744 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2745 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2746 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2748 2004-03-30 Jean-Pierre Roux
2749 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2750 for ACR file, written out as DICOM files (hope so...)
2752 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2753 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2754 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2755 moved to base class gdcmParser and only the specialisation is kept
2757 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2758 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2759 already does the job.
2760 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2761 (to be consistent with gdcmParser::WriteEntries).
2763 2004-03-30 Benoit Regrain
2764 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2765 upate of the object's instance. It's passed to 2 in the unfavorable
2766 case : one in the ExecuteInformation, one in the ExecuteData
2768 2004-03-29 Jean-Pierre Roux
2769 * ENH : Check on file type to be written moved
2770 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2771 * FIX : gdcmObject::ResetBoundaries now stops properly
2772 when end-of-list is reached
2773 : gdcmVersion modified (as Benoit Regrain asked)
2775 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2776 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2777 * src/gdcmUtil.cxx: added forgotten iostream include.
2778 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2779 equivalent to ExplicitVR in existing code).
2781 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2782 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2783 now contains all the gdcmGlobal related code.
2784 * minor coding style and doxygenation changes.
2786 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2787 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2788 now contains all the Debug related code.
2789 * minor clean-up of includes in src/*.cxx
2790 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2791 CreateCleanString) removed.
2792 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2793 * Doc/DoxyMainPageUser.txt added.
2794 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2795 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2796 src/gdcmDirList.cxx)
2798 2004-03-24 Jean-Pierre Roux
2799 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2801 2004-03-23 Jean-Pierre Roux
2802 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2803 big endian made volumes
2804 * ENH Now gdcmParser constructor and destructor are protected to forbid
2805 end user to instanciate class gdcmParser
2806 (only gdcmHeader and gdcmDicomDir are meaningfull)
2808 2004-03-22 Benoit Regrain
2809 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2810 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2811 gdcmSerie to gdcmDicomDirSerie
2813 2004-03-19 Jean-Pierre Roux
2814 * ENH Now the tree-like structure describing a DICOMDIR comming from
2815 an already existing DICOMDIR file is consistent with
2816 the home-made tree-like structure build ex-nihilo
2817 or build from the files held (recursively) in a Directory
2818 functions gdcmDicomDir::CheckBoundaries()
2819 gdcmObject::SetBoundaries() added
2821 2004-03-17 Jean-Pierre Roux
2822 * REM (Eric Boix bug) : removal of meaningless
2823 gdcmDicomDirImage::NewImage function.
2824 * FIX now file names and directory name are written properly in the
2826 * FIX now gdcmDicomDir constructor may be call without any trick
2829 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2830 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2831 of gdcmDicomDirImage::NewImage as empty function.
2833 2004-02-28 Jean-Pierre Roux
2834 * ENH add gdcmDicomDir:NewPatient
2835 add gdcmDicomDirPatient:NewStudy
2836 add gdcmDicomDirStudy:NewSerie
2837 add gdcmDicomDirSerie:NewImage
2838 to allow making gdcDicomDir object.
2839 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2840 (as opposite to the gdcmHeader chained list)
2842 2004-02-11 Benoit Regrain
2843 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2844 when using from python
2846 2004-02-10 Benoit Regrain
2847 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2848 * FIX : in gdcmDicomDir when the directory is empty
2849 * ENH : add callback and methods to get the progression of dicomDir
2852 2004-02-06 Jean-Pierre Roux
2853 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2854 - GDCM_META added to gdcmDicomDirType
2855 - class gdcmMeta created
2856 * ENH : - A brief summary is now displayed at the beginning of
2857 'testDicomDir' to help disaster magnitude estimation
2858 * REM : Now useless Test/explDICOMDIR.cxx
2860 2004-02-05 Benoit Regrain
2861 * ENH : add methods in gdcmObject to get the hash table or the list of
2863 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2864 * FIX : wrapping python for TagHeaderEntryHT
2866 2004-02-04 Benoit Regrain
2867 * FIX : even length for some strings when writting the dicom dir
2868 * FIX : sort the images in the dicom dir
2869 * FIX : Bug fix for python use of dicom dir
2870 * ADD : a python demo
2872 2004-02-04 Jean-Pierre Roux
2873 * FIX : Final solution (?) for icone embedded images
2874 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2875 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2876 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2877 gdcmData/gdcm-MR-SIEMENS-16.acr1
2878 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2879 to make full checking easier
2881 2004-02-04 Benoit Regrain
2882 * FIX : WriteEntries : coding style & logic in parameters
2883 * FIX : Set the elements to create the DicomDir in a dictionary file
2885 2004-02-03 Benoit Regrain
2886 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2887 * gdcmDicomDir : add the load of directory
2888 * Bug fix and print add-on
2890 2004-02-03 Jean-Pierre Roux
2891 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2892 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2893 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2894 * FIX gdcmParser.cxx : 'group length' elements are now considered
2895 as integers, even for shadow groups, when file is Implicit VR
2897 2004-02-02 Jean-Pierre Roux
2898 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2900 of the last synonym :-(
2901 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2903 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2904 * FIX taking into account the possible 7fe0,0010 multiplicity
2905 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2906 to allow removal of references to 7fe0,0010, to deal with
2907 ACR-NEMA images, when 0028,0200 is meaningfull
2909 2004-01-31 Jean-Pierre Roux
2910 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2911 no longer writes 'Un' on disk
2912 * FIX SQ elements with actual length are now dealt with corectly
2913 * FIX gdcmFile::WriteBase make the difference, for color images, between
2914 the length (for Palette expanded images)
2915 and Raw Length (non expanded image + Palette)
2916 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2917 (that broke Write). Replaced by UL.
2918 Aware user will reload the field if he
2919 thinks it's necesssary
2921 2004-01-30 Jean-Pierre Roux
2922 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2923 when 'dirty Acr' is found, to be compliant with the new
2924 IsReadable() methods.
2926 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2927 (no DOUBLE images in kosher DICOM,
2928 but so usefull for people that miss them ;-)
2930 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2931 DICOMDIR related utilities (not checked as Windoze compliant)
2933 2004-01-28 Jean-Pierre Roux
2934 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2936 2004-01-27 Jean-Pierre Roux
2937 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2938 to allow skipping the shadow elements, to save memory space.
2939 The TRUE value for this param has to be used
2940 with a FALSE value for the 'enable_sequence' param.
2941 ('public elements' may be embedded in 'shadow Sequences')
2942 * gdcmHeader methods now deal with 'embedded icones images' in the header
2943 (even when an 'icone image sequence' is announced by the
2944 element (0x0088,0x0200), but there is NO icone at all ...
2946 * gdcmHeader sometimes Image Location value doesn't follow
2947 the supposed processor endianity (see gdcmData/cr172241.dcm).
2950 * gdcmHeader add the method
2951 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2952 to get *all* the Header Entries with the same tag.
2953 GetHeaderEntrySameName is probabely *useless*
2954 (no meaning : Name is *not* an identifier within the Dictionary)
2956 2004-01-26 Benoit Regrain
2957 * Bug fix in the print of hexadecimal representations. Remove long fields
2958 in the print and add a third level of print to print them
2960 2004-01-23 Benoit Regrain
2961 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2962 * Bug fix on test suite after remove the strip made on not string fields
2963 * Split the IsReadable method between gdcmParser which test that the file
2964 is dicom and gdcmHeader which test that it's an image file
2966 2004-01-22 Benoit Regrain
2967 * DicomDir : clean code, add methods, set variables in protected or private
2968 * gdcmUtil : bug fix for the clean string method
2970 2004-01-19 Benoit Regrain
2971 * Add the use of shadow dictionaries
2972 * bug fix and coding style
2974 2004-01-19 Benoit Regrain
2975 * src/gdcmFile.cxx : bug fix concerning the close of file
2976 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2977 * Add the update of header entries using the shadow library
2979 2004-01-19 Benoit Regrain
2980 * removal of file gdcmHeader2.cxx
2981 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2982 inheriting from gdcmParser. This split is to prepare the integration
2983 of dicom dir parsing
2984 * bug fix under python
2986 2004-01-16 Jean-Pierre Roux
2987 * REM removal of class gdcmHeaderEntrySet
2988 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2989 * ADD add file gdcmHeader2.cxx
2990 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2992 2004-01-15 Benoit Regrain
2993 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2994 entries created while parsing the header. Thus, they will be destroyed
2995 when the gdcmDictSet will be destroyed
2996 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2999 2004-01-15 Benoit Regrain
3000 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
3001 made a fatal error because of the memory release at the end of program.
3002 The problem was in vtkGdcmReader::ExecuteData where we were allocate
3003 some memory and vtk seems to have some problems with that.
3004 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
3006 2004-01-14 Benoit Regrain
3007 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
3008 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
3009 * src/*.[h|cxx] : make changes due to class name changes
3010 * gdcmPython/demo/*.py : bug fix due to method names
3012 2004-01-13 Benoit Regrain
3013 * src/*.[h|cxx] : coding style
3014 * vtk/*.[h|cxx] : coding style
3016 2004-01-13 Benoit Regrain
3017 * gdcmPython/testSuite.py : test the readable flag of file for tests
3018 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
3019 It's lied to the stl compilation by MSVC (windows, always windows...)
3020 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
3022 2004-01-12 Benoit Regrain
3023 * src/*.h : add comments
3024 * src/gdcmDictSet.h : set the method BuildDictPath in public
3025 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
3026 directly setted in the source code
3027 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
3030 2004-01-09 Benoit Regrain
3031 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
3032 * setup.py : use a reference to gdcmVERSION
3034 2004-01-07 Benoit Regrain
3035 * Modification to compile with the distutils.
3038 2003-12-10 Benoit Regrain
3039 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
3040 can use a gdcmHeaderHelper to load data
3041 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
3042 made in the source code
3044 2003-12-10 Benoit Regrain
3045 * Update Windows projects and .cvsignore files
3047 2003-11-12 Jean-Pierre Roux
3048 * ENH gdcmHeader constructor has one more parameter (default value : false)
3049 that allows the user to 'go inside' the SeQuences only
3051 gdcmElValSet:Print takes it into account
3053 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3054 * ENH: Update gdcmPython/CMakeLists
3055 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
3056 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
3058 2003-11-10 Jean-Pierre Roux
3059 * FIX : gdcmHeader::LoadElements is now based
3060 on the ListTag listElem member,
3061 not longer on the TagElValueHT tagHt member
3062 * ENH : PrintPubElVal shows (temporarily) both results,
3063 with the tagHt member and the listElem member.
3064 (it's easier to 'see' the problems when using Printheader)
3066 * FIX : old private member LgrElem is now splitted into
3067 ReadLength : Length actually found on disk (updated only
3068 if bug fixing is necessary), for internal
3070 UsableLength : Updated by FixFoundLength, to fix a bug
3071 or to allow Parser going on.
3072 Will allow to re-write a kosher header when a SeQuence
3073 with a length (not 0000) is found
3074 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
3075 because gdcmElValSet::Add does not update ListElem
3078 2003-11-07 Jean-Pierre Roux
3079 * FIX misstyping in Transfert Syntax name table
3080 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
3081 when they have an actual length (not 0000 nor FFFFF)
3082 (Nobody should care of it, but DICOMDIR explorers)
3084 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3085 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
3087 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3088 * ENH: vtkGdcmReader now supports LUT !
3089 (vtkgdcmViewer for now is not able to use them though)
3091 2003-11-05 Jean-Pierre Roux
3092 * in testSuite.py : new files names for checking the package
3093 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
3094 that returns the pixel area size to the *aware* (vtk) user
3095 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
3097 2003-11-05 Benoit Regrain
3098 * in testSuite.py : Modify the rules for checking the paths
3099 : Explicit error messages
3100 * in __init__.py : Related modif
3102 2003-11-03 Jean-Pierre Roux
3103 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
3104 to be used by aware (vtk) users that want to manage
3105 LUT (and no to turn the PALETTE image into an RGB pixels one)
3106 * GetPixelType now returns 8U for 24 Bits images
3107 (vtkGdcmReader compliant)
3109 2003-10-31 Jean-Pierre Roux
3110 * Removal of *all* gdcmData images and add them again
3111 in order to loose the 'history' of un-anonymised images
3113 2003-10-31 Jean-Pierre Roux
3114 * RMV : removal of useless jBitsInJsample.h
3115 for both 8 and 12 Bits JPEG Lossy Libraries
3117 2003-10-31 Jean-Pierre Roux
3118 * ENH : Add the functions gdcmFile::GetImageDataRaw
3119 gdcmFile::GetImageDataIntoVectorRaw
3120 that act as GetImageData and GetImageDataIntoVector
3121 except the making of an RGB Plane from Gray Plane + LUT
3122 Intended to aware (vtk) users who know how to manage
3125 GetLUTRGBA return a R,G,B,A LUT if any
3126 lgrTotaleRaw gives the 'Raw' length
3127 GetImageDataRaw returns the gray Plane
3128 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
3129 (They stay Grey, just like with other Dicom viewers :-(
3131 2003-10-30 Jean-Pierre Roux
3132 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
3134 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3135 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
3136 being coherents dicom files.
3138 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3139 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
3141 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
3142 * ENH: Two steps is necessary to please VC++ compiler...
3143 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
3144 * ENH: Add include dir to medcon lib
3145 * FIX: only one function is being exported for now !
3146 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
3148 2003-10-29 Jean-Pierre Roux
3149 * adding gdcmHeader::GetLUTRGBA
3150 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
3151 --> Mathieu, the modif u're waiting for is not yet committed
3152 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
3154 2003-10-27 Jean-Pierre Roux
3155 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
3156 00191113.dcm DermaColorLossLess.dcm
3157 MxTwinLossLess.dcm RadBWLossLess.dcm
3158 * ENH: For version prior to vtkImageViewer2 -r 1.19
3159 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
3161 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3162 * Removal of ido stuff in CMakeLists.txt
3164 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3165 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
3166 * FIX: remove a call to ->Modified ... see comments
3167 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
3169 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3170 * FIX: Problem with path for libvtkgdcmPython
3171 * ENH: Try adding a search script for python site-package
3172 * RMV: Remove some file from medcon lib that are not necessary
3173 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
3174 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
3175 * FIX: More pragma disable fro VC++,
3176 I don't think I break something as it is also disable in VTK/ITK.
3177 But it fasten debug compilation time.
3179 2003-10-23 Jean-Pierre Roux
3180 * gdcm now deals with 16 Bits Run Length Encoded images
3181 (they are compressed as 2 planes images,
3182 one for the high Bytes, the other for low Bytes)
3184 2003-10-22 Jean-Pierre Roux
3185 * Now CheckRead takes into account :
3186 - the bugged 'Leonardo' Siemens images
3187 - the XA images, sent thru the burning VPRO station
3188 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
3191 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3192 * FIX: When copying a Makefile.am to CMakeLists.txt
3193 one should remove the '\'
3195 2003-10-22 Jean-Pierre Roux
3196 * in gdcmData adding a bugged 'Leonardo' Siemens image
3197 (wrong lengths in header)
3198 OK with gdcm, KO with the other viewers :-)
3199 * add a GE dlx XA image, thru the VEPRO burning station
3202 2003-10-21 Jean-Pierre Roux
3203 * in gdcmData add the checkvtkgdcmViewer.sh shell script
3204 for a brutal checking of vtkgdcmViewer compliance
3206 2003-10-21 Jean-Pierre Roux
3207 * add the files for 'xmedcon' Jpeg Lossless library
3208 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
3210 2003-10-21 Jean-Pierre Roux
3211 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
3213 2003-10-21 Jean-Pierre Roux
3214 * garbage Siemens 'Leonardo' images dealt with
3215 (the patch is easy to remove)
3216 * cosmetic changes to avoid warnings
3218 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3219 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
3220 no need to press 'r' now.
3222 2003-10-20 Jean-Pierre Roux
3223 * upgrade of checkRead.sh checkWrite.sh according
3224 to new Jpeg Lossless decompressor
3225 * add US.3405.1.dcm, a genuine RGB medical file ...
3226 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
3227 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
3229 2003-10-15 Jean-Pierre Roux
3230 * general anonymisation in gdcmData
3231 * adding the 'color files' from
3232 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
3233 * adding some well knowed bugged-header images
3234 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
3235 waiting for their inclusion in Python testsuite
3237 2003-10-15 Jean-Pierre Roux
3238 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
3239 no longer seg faults when file is not found
3241 2003-10-14 Jean-Pierre Roux
3242 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
3245 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3246 * TODO: *.in file to genereate a UseGDCM later
3248 2003-10-14 Jean-Pierre Roux
3249 * Some supposed-to-be Dicom Images have no preamble.
3250 OpenFile takes it into account
3251 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
3252 * Missing elements added in dicomV3.dic
3253 (just to be affraid : have a look at
3254 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
3255 and do it again next year ;->
3257 2003-10-13 Jean-Pierre Roux
3258 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
3259 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
3260 But there are NOT. It's fixed !
3262 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3263 * FIX: "jpeglib.h" was not found on VC++
3264 * FIX: vtkgdcm was not being installed
3266 2003-10-10 Jean-Pierre Roux
3267 * ENH : OpenFile closes the file if it *really* doesn't look like
3268 an ACR-NEMA / DICOM one.
3269 * FIX : testWrite no longer writes an empty file if the source file
3270 is not gdcm Readable
3271 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
3274 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3275 * FIX: CMake generate now documentation
3276 * ENH: out of source doc build !
3277 * ENH: Generate both user and dev documentation
3278 * ENH: Should work on windows too
3279 * ENH: Only one doxygen config.in file is needed
3280 * FIX: make install should be ok now on Unix plateform
3281 * FIX: PATH to dictionary was wrong (missing /)
3282 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
3284 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3285 * vtkGdcmReader is now able to read rgb dicom file.
3286 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3287 * added a gdcmViewer to vtk test, use mouse to control
3288 window level & window width
3290 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3291 * CMake-ification of gdcm, we have now two build system
3292 * FIX: on cygwin Wsock32 doesn't exist
3293 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
3295 2003-10-06 Emanuel Ollart
3296 * FIX : compilation process wad broken.
3297 Changed gdcmViewer_sources to vtkgdcmViewer_sources
3299 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3300 * change gdcmViewer -> vtkgdcmViewer
3301 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
3303 2003-10-06 Jean-Pierre Roux
3304 * FIX :A few nasty patches to allow the reading of a lot of nasty images
3305 ( e.g : well known GE images with a wrong elem length,
3306 : Philips MRI Images with a wrong Huffman table)
3307 * still to be done : allow the reading of bugged LEONARDO Siemens images
3309 2003-10-03 Jean-Pierre Roux
3310 * Odd length strings are padded with '\0' (not with spaces,
3311 to remain compliant with already defined strings,
3312 like Transfert Syntax UID and others)
3314 2003-10-03 Jean-Pierre Roux
3315 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3316 to allow displaying RGB images (not only by affim ;-)
3318 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3319 * vtkGdcmReader is now able to read rgb dicom file.
3320 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3322 2003-10-03 Jean-Pierre Roux
3323 * A few nasty patches to allow the reading of a lot of nasty images
3324 ( e.g : well known GE images with a wrong elem length,
3325 : Philips MRI Images with a wrong Huffman table)
3326 * still to be done : allow the reading of bugged LEONARDO Siemens images
3328 2003-10-03 Jean-Pierre Roux
3329 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
3331 2003-10-03 Jean-Pierre Roux
3332 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3333 to allow displaying RGB images (not only by affim ;-)
3335 2003-10-03 Jean-Pierre Roux
3336 * gdcmFile::GetImageDataIntoVector now
3337 - deals with MultiFrames MultiFragments Run Length Encoded files
3338 - deals with YcBcR (YBR_FULL) files
3339 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
3340 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
3342 (no sample found :-(
3344 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3345 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
3346 Two reasons: - clear things
3347 - third parties acces gdcm through header files, so won't
3348 suffer anymore VC++ complains
3350 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3351 * add argv[1] in testvtkGdcmReader.cxx
3354 2003-09-24 Jean-Pierre Roux
3355 * The lines are now eigthy characters long for
3356 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
3358 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3359 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
3360 char* to std::string. Thus, the use of strdup becomes useless. (see
3361 previous commis of Malaterre)
3362 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
3363 before the last Malaterre's commit.
3365 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3366 * This commit should fix the Debug building under VC++, the problem
3367 was mainly a mixture of debug and release lib being loaded at startup.
3368 * I also remove a depency to a specific C function: strdup. Because I had
3369 to force the link to msvcrtd (whereas strdup is in libc).
3371 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3372 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
3373 located in the gdcmCommon.h file. All use of reference of tha has been
3374 changed to now use the variable GDCM_UNFOUND.
3376 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3378 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
3379 Dicom dictionary. The test suite can now be run again. Note:
3380 I'm note very happy with the " (RET)" changes. I believe this
3381 RETAINED comment should be dropped when parsing the dictionary.
3382 - PACKAGER corrected
3384 - AUTHORS updated and now in alphabetical order
3385 * Makefile.am now exports gdcm.dsw for Windoze users.
3387 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3388 * cygwin complains about missing std:: in subdir Test/
3390 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3391 * remove some methods that are now in gdcmHeaderHelper
3393 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3394 * vtkGdcmReader set spacing and origin correctly
3396 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3397 * Fix a few delete/delete[] mismatch
3399 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3400 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
3401 interpretation to data given by gdcmHeader. For instance there are
3402 heuristics to get informations (look at different places).
3403 * it also include a specific class: gdcmSerieHeaderHelper devoted to
3404 sorting DICOM images based on different strategies.
3405 * modified Makefiles accordingly.
3407 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3408 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
3409 when building in debug mode
3410 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
3411 src/win32/gdcmdll.dsp
3412 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
3414 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3415 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
3418 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3419 * src/win32/libgdcmjpeg12.dsp was not dos format
3420 * src/win32/libgdcmjpeg12.dsp :
3421 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
3422 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
3424 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3425 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
3427 * src/gdcmFile.cxx : bug fix in affectation type
3428 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
3429 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
3430 * Modifs of MVSC projects to compile them. Not concerning 2 identic
3431 symbols... future problem ?
3433 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3434 * src/win32/libgdcmijpeg12.dsp was missing
3435 * modified gdcm.dsw accordingly
3437 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3438 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
3440 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3441 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
3442 commit of JPR (before his hollidays to facilitate our work).
3443 * setup.py : bug fix in code. Modifications made while the last commit
3444 of JPR. The code hasn't been tested before the commit... it's so
3445 useless to make that (for best programmer that is JPR) !!!
3447 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3448 * tagged the current version as Version0_3 (i.e. version 0.3)
3450 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3451 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
3452 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
3453 * *.dsp : modifications to use new libgdcmijpeg8 library
3454 * setup.py : bug fix on VTKPATH variable
3455 * PACKAGER : adding all concerning windows
3457 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3458 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
3460 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
3461 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
3462 test suite reported error.
3463 * PACKAGER file added (describes what a packager must do when
3464 packaging a new release).
3465 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
3466 * configure.in: upgraded version number to 0.3.0
3467 * fixing build of rpm (through rpm -ta):
3468 - Doc/Makefile.am exports proper doxygen files
3469 - src/jpeg/libijg8/Makefile.am exports the include files.
3471 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3472 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
3473 * src/gdcmHeader.h : formatting code
3475 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3476 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
3477 We were obtaining error message from vtk. Now, creation of file list
3478 is made in an internal list to prevent this problem.
3479 Bug fix when output is empty.
3480 Bug fix in update of progress value. Previous commit for this was a bad
3482 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
3484 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3485 * src/gdcmHeader.h : added method to get the file name
3486 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
3487 files. Added method to remove all files on the input
3488 Added FIXME comment concerning the bad parsing of header made by
3489 ExecuteInformation method (in ExecuteData method)
3491 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3492 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
3493 when using make instal.
3494 * src/gdcmFile.cxx : bug fix under Window after JPR commit
3495 RQ : the JPR doesn't appear in the ChangeLog... normal for him
3497 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3498 * setup.py : adding include dir of jpeg lib to compile all sources
3499 * */Win32/*.dsp : JPR fix for windows compilation
3501 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3502 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
3504 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
3505 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
3507 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3508 * setup.py is again effective on un*x (takes into account the
3509 addon of the jpeg library)
3510 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
3511 * Doc/Doxy* updated (includes above enhancements)
3512 * INSTALL now points to web documentation
3514 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3515 * src/gdcmHeader.h doesn't make unnecessary reference to
3517 * gdcmPython/Makefile.am now avoids calling the wrappers for the
3519 * src/gdcm*.[cxx|h] :
3520 - to allow compilation with gcc 3.x
3521 -- clean up of STL usage (added explicit usage of std::)
3522 -- small fixes on exceptions.
3523 Note: linking not tested !
3524 - clean of doxygen comments to avoid warnings at documentation
3526 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
3527 dependent convertion).
3529 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3530 * Clean up of previous JPR garbage commit (not even commented in the
3532 - Test/Makefile.am removed the reference to unexisting testTS.cxx
3533 - moved all jpeg related files from src to src/jpeg/libijg8, with
3534 addition/modification of Makefile.am and configure.in.
3535 - the testSuite is still brain damage (not guilty).
3537 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3538 * WrapVTK.py : modifications to get correctly vtk source files to
3540 * vtk/vtkGdcmReader.cxx : modification for an already existing name
3541 (FileName -> Filename)
3543 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3544 * vtk/vtkGdcmReader.[cxx/h]:
3545 - UpdateProgress method should now be effective
3546 - removed the limitation on having only images loaded (as opposed
3548 - when building a stack of images/volume, a lesser number of
3549 gdcmHeader and gdcmFile instances should be used (hopefully
3550 accelerating things).
3551 - when building a stack of images/volumes, files which are not
3552 loadable (wrong path-filename, wrong permissions on existing file,
3553 or file not parsable by gdcm) are replaced with a black image
3554 in the stack (for the caller to notice the problem).
3556 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3557 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
3559 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3560 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
3561 between standard library (std) and vtk library (problems are found
3562 under Windows... thanks Windows !)
3564 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3565 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
3567 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
3569 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3570 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
3572 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3573 * When compiling with distutils (see setup.py) the C++ compiler is
3574 called with different flags than the default ones (with automake).
3575 In order to fix all those warning, I compiled gdcm with the command
3576 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
3577 and went for warning fixes:
3578 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
3579 up from unused variables.
3580 - vtk/vtkGdcmReader.cxx: potential bug fix.
3581 * src/gdcmHeader.h: Doxygen warning cleanup
3583 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3584 * gdcmPython/gdcm.i:
3585 - typemaps correction to take into account the systematic replacement
3586 of "using namespace std" with std:: prefix e.g. std::list,
3587 std::string... (cf changes of 2003-05-21).
3588 - gdcmGlob global variable of type gdcmGlobal (defined in
3589 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
3590 exported to Python a as cvar.
3591 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
3592 and GetPubDictTagNamesByCategory() as a replacement for deprecated
3593 gdcmDictSet.GetPubDictTagNames() and
3594 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
3595 C++ static methods).
3596 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
3597 with the above changes.
3599 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3600 * setup.py, manifest.in : bug fix under linux
3602 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3603 * Modification of setup.py to compile vtk part too. Then, we have 2
3604 wrappers which must work with same distutils. For that, we have a
3605 generic distutils in distusiltsWrapping.py ; with :
3606 - build_extWrap class to wrap generically all extensions,
3607 - ExtensionWrap base class for all wrapping extension that contains
3609 - Wrapper interface which wrap sources
3610 + In WrapSwig.py we have extension and wrapper for Swig
3611 + In WrapVTK.py we have extension and wrapper for VTK
3612 * MANIFEST.in : modifications to consider vtk directory and new python
3613 files for compilation
3615 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
3616 * Added python wrappers of vtkGdcmReader vtk class (see the
3617 source in vtk/vtkGdcmReader.cxx) :
3618 - vtk/Makefile.am now builds a library
3619 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
3620 python library (as opposed to _gdcm.so wich are the python
3621 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
3622 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
3624 - configure.in has an additional flag --enable-vtk that needs
3625 to be set to enable compilation of vtk related code, that is:
3626 + vtk/vtkGdcmReader.so and
3627 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
3628 + gdcmPython/vtkgdcmPython.so (see above)
3629 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
3630 be read when compressed or when HighBit + 1 != BitsStored),
3631 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
3632 the usage of the python wrapper of vtkGdcmReader vtk class.
3633 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
3634 * src/*.[h] all occurences of stl classes are now prefixed with
3635 std::, and all occurences of "using namespace std;" where removed.
3636 This is to avoid pollution of global namespace in included files.
3637 Apparently vtk does not avoid this pitfall: when using both
3638 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
3639 collision of various stl members (principally cout...).
3640 * gdcmPython/testSuite.py now cleanly removes temprory generated
3642 * gdcmPython/gdcm.i now declares a typemap for std::string (to
3643 comply with above changes)
3645 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3646 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
3647 * vtk/vtkGdcmReader.cxx now properly inports the image in the
3648 vtk data structure (an image Flip was required).
3649 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
3650 * cosmetic changes in documentation.
3652 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3653 * src/gdcmHeader.cxx: the constructor no longer exits when an
3654 unexisting file is given as argument.
3655 * The subdirectory Data (containing all the images used for the
3656 test suite) is not part of this repository anymore. A new module
3657 containing those images is now available at
3658 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
3659 with the name gdcmData.
3660 All the python scripts (including the package initialisation file
3661 gdcmPython/__init__.py) were adapated to take this change into
3662 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
3664 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3665 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
3666 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
3667 demo of the usage of this class.
3668 Compilation of this vtk part is only done when using the --enable-vtk
3669 at configure (or autogen.sh) stage.
3671 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3672 * More memory link related corrections and documentation fixes.
3674 - maximum info is obtained with a command of the form:
3675 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
3676 --show-reachable=yes PrintHeader
3677 - the remaining reachable blocks seem to come from the STL
3678 allocation scheme through the usage of map and list. It looks
3679 like this memory cannot be freed but it is not a memory leak
3680 (in fact further invocation to the STL would recollect the
3681 unused memory allthough it cannot explicitely be freed).
3682 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
3683 of displaying an image parsed with gdcm and displayed with VTK.
3684 Note: some images don't seem to work e.g.
3685 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
3686 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
3687 Allthough this weakens the semantics, it is a ditch attempt to
3688 make gdcm more thread friendly.
3690 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3691 * Memory link hunt (by using valgrind through the command
3692 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
3693 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
3694 gdcmHeader::_dicom_vr.
3695 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
3696 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
3698 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
3700 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3701 * src/Makefile.am now exports all the necessary include files at
3705 * UpdateGroupLength replaced by new one
3708 * UpdateGroupLength re-written using H-Table
3709 (named UpdateGroupLengthNew untill checks are over)
3711 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3712 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
3713 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3715 - gdcmHeader::GetPubElValSet removed.
3716 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3717 UpdateGroupLength, WriteElements, Write.
3718 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3719 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3720 carried the same semantics.
3721 - src/gdcmHeaderIdo.cxx changed accordingly.
3722 - gdcmFile::WriteBase now regroups all the codes from previous
3723 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3724 - enum FileType moved to gdcmCommon.h
3725 * src/gdcmHeader.cxx AddDefault trashed
3726 * gdcmGetXSize added
3727 * getimageDataSize now calls gdcmGetXSize
3728 * Test/*.cxx changed to agree with above changes
3730 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3731 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3732 (to avoid double call by end user).
3733 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3734 by end user, since gdcmHeader::gdcmHeader now handles it.
3736 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3737 * gdcm/Doc many doxygen changes:
3738 - Doxyfile now has two different versions, DoxyfileUsers that generates
3739 the html.users end users oriented documentation and
3740 DoxyfileDeveloppers that generates the html.developper developper
3741 oriented documentation.
3742 - README changed accordingly
3743 - requirement.txt removed (old design info moved to TODO).
3744 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3745 DoxyMainPage.txt, DoxyPython.txt provide more information.
3746 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3747 be updated by simply regenerating the docs with doxygen and copying
3748 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3749 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3750 all the tests in the form "if (<map>.count() >1)" were removed.
3751 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3752 ill-formed documentation sections.
3753 * src/gdcmHeader.cxx: ditto
3755 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3756 * setup.py fixed for un*x (needed macro for stdint.h)
3757 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3758 un*ces with sh-utils test utility.
3759 * gdcmPython/demo/test.py renamed to PrintHeader.py
3760 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3761 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3762 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3763 * src/gdcm*.cxx JPR's bad inclusion fixed.
3765 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3766 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3767 * gdcmPython/demo/test.py changed accordingly.
3769 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3770 * gdcmPython/Makefile.am fixed linking against libstdc++
3771 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3772 * Swig subdir (historical tests of swig version 1.3.17++) removed
3773 * Test/testChangeEntete.cxx some lines commented out in order to make
3775 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3776 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3778 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3779 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3780 hence the user doesn't need this explicit call.
3781 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3782 i.e. LoadElements() call removed.
3783 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3784 - src/Makefile.am declares the proper flag for g++.
3785 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3786 for adding user defined new tags.
3787 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3788 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3789 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3791 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3792 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3793 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3794 src/Makefile.am : the project should properly compile and install
3795 with the autotools, included the python wrappers part.
3796 * gdcm.spec.in : added a spec file for RPM packaging.
3798 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3799 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3801 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3802 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3803 to exported to the environement (see gdcmPython/testSuite.py
3805 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3806 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3807 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3808 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3809 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3811 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3812 * gdcmPython/__init__.py doesn't crash anymore when running in
3813 in InstallMode or PreInstallMode but with an environment given
3814 value of GDCM_DICT_PATH.
3815 * src/gdcmDictSet.[cxx/h] coding style.
3817 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3818 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3819 * src/gdcm.h general comments moved to TODO, and README
3820 * src/gdcm.h should now be seen as a user commodity (including it
3821 should suffice to fully use gdcm). It is nowhere including within
3822 any of the kernel files src/*.cxx and src/*.h.
3824 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3825 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3826 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3828 * src/gdcm*.cxx only include their corresponding include file
3829 (as opposed to gdcm.h)
3830 * gdcmPython/gdcm.i changed accordingly
3831 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3832 the autogen.sh generated "make snapshot" command to work.
3833 * autogen.sh removed history related references to crea package.
3835 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3836 * distutilsSwigCPlusPlus.py work around some swig portability
3839 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3840 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3841 was done in a last ditch attempt to get setup.py _really_
3842 operationnal. The python/gdcmPython layaout add the advantage
3843 of hidding away the python related distutils specific files
3844 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3845 Alas, the src directory was out of scope (i.e. it's relative
3846 position to setup.py was ../src) which made things impossible to
3847 handle (see previous version of python/setup.py). Crossing fingers...
3849 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3850 * python/setup.py now works on Un*x. (harder than I thougth)
3851 * python/distutilsSwigCPlusPlus.py can now have include files
3852 among the list of sources.
3854 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3855 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3856 * modifications in MSVC projects
3858 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3859 * As stated by the first lines of Test/ExceptionAndPython/README, it
3860 looks like we can move back to original usage of exception within
3861 src/gdcm* and hence remove the errno stuff that was introduced
3862 as a quick and dirty fixture of this problem (added to the TODO).
3863 * Doc/Doxyfile configuration file for Doxygen and corresponding
3864 README file for usage added.
3865 * Test/testWrite.cxx added. This new test comes from a split of
3866 test.cxx that is now reverted to its original purpous i.e.
3867 testing the proper parsing of a Dicom related file.
3868 testWrite.cxx concentrates on testing the IO part of gdcm.
3869 * Test/bug1.cxx (containing a bug on WIn32) added.
3870 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3871 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3872 whose purpose is to publish the content of the TagNames of the
3873 Dicom public dictionary were not accessible without an
3874 instance of class gdcmHeader.
3875 - those methods are now static methods of gdcmDictSet and hence
3876 require no instances at all to be invocated.
3877 - within gdcmDictSet this change required to change some method
3878 to class methods (i.e. are now static) among which SetDictPath
3879 (renamed to BuildDictPath) and LoadDefaultPubDict.
3880 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3881 the above changes by calling the new method classes of gdcmDictSet.
3882 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3883 the above to be effective.
3884 * python/gdcmPython: in order to wrap properly the above changes
3885 for Python, swig version now needs to be > 1.3.17.
3886 * python/gdcmPython/Makefile fixed to adapt itself to new
3887 configure/make shema introduced by Johan Montagnat (thanks for the
3888 contribution). Alas this Makefile cannot be turned into a proper
3889 Makefile.am without some heavy changes in the configure.in
3890 (for python dectection).
3891 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3892 now avoids publishing the empty entries.
3894 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3895 * python/setup.py : bug fix concerning install under windows
3896 ExtraPath reused :-P
3897 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3899 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3900 * Dicts/dicomV3.dic : remove double spaces !!!
3901 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3902 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3905 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3906 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3907 method. Doxygenation.
3908 * src/gdcm.h clean up of JPR spurious comments.
3910 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3911 * python/distutilsSwigCPlusPlus.py now properly collects the
3912 shadow classes generated by "swig -c++" (gdcm.py in our case)
3913 when using "python setup.py install".
3914 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3915 reexports the working classes.
3916 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3917 by the classical C errno scheme. This is to prevent an obscure
3918 behavior of the python wrappers when importing wxPython.wx prior
3919 to gdcmPython (which ended up in an abort call). An illustration
3920 of this oddity can be found in the Test/ExceptionAndPython
3921 subdir (see the README file). This problem probably due to
3922 an combination of g++ and dynamic loading.
3923 * added Test/ExceptionAndPython (see above)
3925 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3926 * Changed the layout of the python part to avoid bloating main
3927 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3928 i.e. the distutils arsenal. All the python related stuff is
3929 again in a python subdir, but the package itself is now in
3931 * setup.py was cleaned up:
3932 - pythonIncludePath removed
3933 - python setup.py bdist target is now functional.
3934 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3935 collision with other packages). gdcmPython/demo/*.py changed
3938 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3939 * python subdir moved to gdcmPython (preparation of distutils packaging).
3940 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3941 distutils installer is operational.
3942 * - gdcmPython/__init__.py now properly loads the swig generated
3943 shadow classes (from gdcm.py).
3944 - gdcmPython/demo/*.py changed to import the package gdcmPython
3945 instead of gdcmPython/demo/load.py.
3946 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3948 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3949 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3950 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3951 entries within the associated public Dicom dictionary resp. the same
3952 information but sorted by the fourth field (PAT, IMG, DIR) of the
3954 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3955 are now in the "???" group.
3956 - python/gdcm.i changed accordingly,
3957 - python/demo/printGroupedPublicDict.py added, that gives an example
3958 of the above new functionalities in Python.
3960 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3961 * src/gdcm.h, gdcmHeader.cxx:
3962 - historic references to glib's g_malloc and g_free (#defined)
3963 were definitively removed.
3964 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3965 * src/gdcmElValSet.cxx:
3966 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3967 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3968 - GetElValue(string) renamed to GetElValueByName.
3969 - Added GetElementByName(string).
3970 * src/gdcmHeader.cxx: added
3971 - GetPubElValRepByNumber(guint16, guint16)
3972 - GetPubElValRepByName(string)
3973 - GetShaElValRepByNumber(guint16, guint16)
3974 - GetShaElValRepByName(string)
3975 - GetShaElValByNumber(guint16, guint16)
3976 - GetShaElValRepByName(string)
3977 - GetElValRepByNumber(guint16, guint16)
3978 - GetElValRepByName(string)
3979 - GetElValByNumber(guint16, guint16)
3980 - GetElValRepByName(string)
3981 * Doc/requirements.txt added.
3983 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3984 * Test/Makefile building now depends on the one of libgdcm.so
3985 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3986 pixel data) aware which enables finding the address (offset) of
3987 the pixel data of JPEG encoded DICOM files. This leaves only a single
3988 file in the testSuite whose pixel data address (offset) is unknown.
3989 * python/testSuite.py changed accordingly.
3991 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3992 * VC++ has some strong limitations when working with the STL, as stated
3993 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3994 "Also note that some STL containers (map, set, queue, list, deque)
3995 cannot be exported. [...]
3996 Some STL classes contain nested classes. These classes can not
3998 This is caused by a designed limitation that once a template
3999 class is instantiated, it can not be re-instantiated and
4001 Since our usage of map<> is ubiquitous in gdcm, this "designed
4002 limitation" of VC++ is a pitfall.
4003 Hence the Python wrappers of gdcm cannot be incrementally linked
4004 against the c++ dynamic library. The dirty but only workaround is
4005 to forget about incremental link of dynamic libraries and to generate
4006 the Python wrappers library with the inclusions of the underlying C++
4008 The following modifications concern this matter on Win32/VC++:
4009 - wrapping python correct with standalone wrapped dll (don't use separate
4010 dll under windows !!!!)
4011 - python21_d debug mode enabled (ask Frog how to use it :-)
4012 - NO problem with having an STL member of class for example string in C++
4013 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
4014 - Python test of dcmlib in Python is ok under windows on a large set
4016 * removed glib references
4017 * typedef's inserted in gdcm.i for correct swig type management
4019 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4020 * python/demo/*.py load.py extracted from test.py. Added explore.py
4021 that only displays required tags and testAll.py that parses all
4022 the files of the testsuite without using unittest.
4023 * python/testSuite.py other additional test on new files added.
4024 * Data/* new test files added accordingly to the testSuite.
4025 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
4026 the vr in the file differs from the one of the dictionary.
4028 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4029 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
4030 values, but limits itself to values which are below a user specified
4031 size (by default 1024 bytes).
4032 * python/gdcm.i : elements not loaded (because their size is above the
4033 user specified treshold) are exported with their TagKey as key of the
4034 python dictionary. This enables the testsuite to make some checks
4035 on the unloaded elements (since we have their offset and size).
4036 * python/testSuite.py
4037 - now tests for the existence and proper value of the pixel data
4038 - two new examples added.
4039 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
4041 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4042 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
4043 aware. See the strategy comments in gdcmHeader::FindLength().
4044 * Test/test.cxx now accepts a filename as first argument.
4045 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
4046 * python/testSuite.py changed to integrate test on above files.
4048 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4049 * Dicts/dicomV3.dic removed all the trailing (RET) when the
4050 the vr was also RET.
4051 * python/testSuite.py more tests added.
4053 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4054 * python/testSuite.py unittest test suite added (uses Data)
4055 * Data/* dcm and acr files for the test suite.
4056 * glib dependance removed from un*x version. We now use ISO C99
4057 7.18 Integer types (see stdint.h)
4058 - python/Makefile, src/Makefile src/gdcm.h
4059 * src/ when an explicit vr (like dicom files) suddenly poped an
4060 implicit element we use to mark the underlying DictEntry of the
4061 concerned ElValue with "Implicit". This strategy was damageable
4062 too the public or provite dictionaries, since some of their vr
4063 would be changed. Since Header::FindLength heavily relies on the
4064 detection by Header::FindVR of falsely explicit elements, I
4065 added an extra ImplicitVr member to ElValue (boolean).
4066 The rest of the changes we the necessary adaptations.
4068 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4069 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
4071 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
4073 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4074 * Adaptation for porting to VC++:
4076 o forced to use std namespace (for string to be known)
4077 o all class use __declspec export style on WIN32
4078 - src/gdcmUtil.cxx new Exit method that wraps the exit call
4079 (in stdlib.h on Win32 but in std:: for gcc)
4080 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
4081 variable GDCM_DICT_PATH.
4082 * src/gdcmHeader.cxx verbose comments made discrete.
4084 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4085 * python/gdcm.i: added a typemap that converts a C++ hashing table
4086 to native Python dictionary.
4087 * python/demo/test.py:
4088 - now uses the native dictionary for exploration of gdcmHeader.
4089 - takes an optional filename argument (the file to parse).
4090 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
4091 PubElVals hashing table.
4092 * Dicts/dicomV3.dic removed error prone trailing spaces.
4094 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4095 * Python wrapping process moved away from src/Makefile to
4096 newly created python/Makefile (as well as gdcm.i)
4097 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
4098 * src/gdcmHeader::FindLength only looks for current vr when necessary.
4099 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
4100 from the environement variable GDCM_DICT_PATH (when existing).
4101 * src/gdcmDict::GetTag bug fix.
4103 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4104 * Straightforward temporary fixes for swig to build the python wrappers.
4105 src/Makefile now has a python working entry [by working we mean
4106 that we can import the shadow classes without errors].
4108 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4109 * hashtest.cxx removed (since already in Test)
4110 * src/gdcmlib.h renamed to src/gdcm.h
4111 * src/dcm.i renamed to src/gdcm.i
4112 * src/Makefile prepared for python wrapping
4114 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4115 * src/gdcmHeader.cxx :
4116 - Parsing of header is now separated from loading of element values
4117 (see gdcmHeader::LoadElements).
4118 - general clean up of hopefully all file access (creation of
4119 ReadInt16 and ReadInt32)
4121 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4122 * src/gdcmHeader.cxx :
4123 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
4125 - SetLgrElem renamed to SetLength
4126 - GetLgrElem renamed to GetLength
4127 - ~gdcmHeader() made virtual to pesky warning messages at compile.
4128 * src/gdcmElValSet.cxx fixed both GetElValue methods
4129 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
4130 due to IdoDude was cleaned out.
4132 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4133 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
4134 concentrates on finding the value representation (when it exists).
4135 RecupLgr now only finds the element value length, and it avoids
4136 returning the unecessary skL (skipped length).
4137 Also, offsetCourant was simply removed (with taille_fich) since
4138 it was redundant with the File position internals (by using
4139 ftell and fseek). This also made skL (see above in RecupLgr) usage
4141 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
4142 on the libido specificities which are handled through class
4144 * Test/implicit_vr.dcm dicom v3 in implicit value representation
4147 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4148 * Truckload of changes. Parsing of header is barely functional
4149 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
4151 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4152 * src/gdcmHeader.cxx many addons of low level methods
4154 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4155 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
4156 and _IdDcmSWAP_LONG.
4158 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4159 * This corresponds to all the changes decided at the meeting of
4160 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob