1 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
3 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
5 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
6 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
7 (Dicom Element) into the Sequence Item
9 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * src/*.cxx : first parss to normalize file organisation
12 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * src/gdcmDirList.[h|cxx] : add method to find a directory
14 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
16 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
17 * Finish cleaning up my JPEG mess. Should be ok now.
18 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
19 contained within the RLE* class(doh!)
21 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
22 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
23 * SerieHeader::AddFileName() creates as many Coherent Files lists
24 (same Serie UID) as it founds different Serie UID
25 amongst the files instead of discarting any file
26 that doesn't match with the first one he found.
27 * SerieHeader::OrderGdcmFileList has now one parameter :
28 the Coherent Files list the user wants to sort
29 * SerieHeader::GetFirstCoherentFileList() |
30 * SerieHeader::GetLastCoherentFileList() | allow to parse
31 the set of Coherent Files lists
32 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
33 compatibility (it returns the *first* Coherent Files list,
34 since there was only one before)
35 * Test/TestSerieHeader gets gdcmData as a default root directory
37 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * Remove friend between DocEntry and File classes
39 * Remove friend between PixelReadConverter and RLEFramesInfo,
42 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
44 0002|0000. The value was incorrect.
46 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
49 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
50 * src/gdcmUtil.cxx : compilation fix on Win32
51 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
52 variable, to be easy found. Add methods to change the default UID.
53 Amelioration of the CreateUniqueUID to use the correct default UID.
54 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
57 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * Test/TestVR.cxx : fix memory leaks
60 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
61 * Rewrite the base 256 to base 10 conversion, using string operation only.
62 This allows us to get rid of the problematic 64bits integer type (does not
63 always exist on target platform).
65 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
66 * Add construct and destructor to class gdcm::Debug to close the debug file
68 * Don't let uset to open twice the same file
69 * gdcm has now an official UID prefix,
70 supplied by http://www.medicalconnections.co.uk
71 1.2.826.0.1.3680043.2.1143
72 (Thx to Mathieu for providing URL)
73 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
74 to be able to perform some more tests
75 * gdcm::ContentEntry : Contructors and Destructor are now protected,
76 in order to be sure no user will try to use them.
77 (at user level, only the children classes are meaningfull)
79 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
80 * move RLEInfo & JPEGInfo from Document to File
82 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
83 * FIX : remove so many friend between classes
85 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
87 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
89 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
90 In order to avoid missbehaviour :
91 . gdcm::DocEntry is now specialized in
92 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
93 - gdcm::ContentEntry (Dicom entry with a 'content')
94 . gdcm::ContentEntry is specialized in
95 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
96 characters value, or integers)
97 - gdcm::BinEntry (Dicom entry with a non strig representable value
98 (user hasn't any longer to thing about the precedence of his dynamic_casts)
100 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * Test/VTKTest*.cxx : bug fix under linux
103 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
105 use with python. Some methods are moved from Document to ElementSet or
106 DocEntrySet. The equivalent methods to ElementSet have been added to
107 SQItem and are virtual in DocEntrySet. Methods that may have the same code
108 in SQItem and ElementSet is directly placed in DocEntrySet
110 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
111 * Test/VTKTest*.cxx : remove the show variable in each test method because
112 it's useless (the viewer variable replace this variable)
114 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * src/gdcmDocument.cxx : bug fix on potential memory leak
116 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
117 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
118 Add ClearXxx methods to remove all the content of the list or map
119 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
121 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
122 * methods ReplaceOrCreate renamed as Insert
123 (nobody will be any longer confused by 'CreateOrReplace')
125 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
126 * Grealty simplify the JPEg decompression, no need to differenciate based on
127 the JPEG possible type (with/without fragment, with/without multiple frame).
128 Everything is done throught the JPEG IO Suspension mechanism in IJG
130 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
131 * Stage 3 of normalization :
132 in order to avoid any missunderstanding while reading method names :
133 - All the methods xxxEntry now deal with dicom Entries
134 - Methods GetEntry splitted into
137 - Method SetEntry renamed as SetEntryValue
138 - Method SetEntryBinArea let as it was
140 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
141 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
142 - Position correctly the entry points for JPEG2000 and JPEG-LS
143 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
145 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
147 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
148 with other method names
149 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
150 * Test/TestDicomDirElement.cxx : add new test
152 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
153 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
154 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
155 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
156 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
157 So can't you use __int64 in ostream at all.
159 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * bug fix for compilation on MSVC6
161 * gdcmPython/gdcm.i : rename of classes missed
163 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
164 * Stage 2 of names normalization :
165 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
166 (easy to understand ...)
167 - gdcm::FileHelper replaces old class gdcm::File
169 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
171 type and not a string. So, there remove problems on the format of the
174 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
175 * Add Example/TestPapyrus.cxx
176 - reads a Papyrus file (gdcm::Header compliant),
177 - gets the pixels of all the images, using low level iterators
178 - writes an multiframes Dicom image.
179 (Just to show it's *possible* to do that)
180 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
183 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
184 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
185 Thus, DicomDirXXX are created with a flad that indicates if the created
186 object is empty or not (when not empty, the DicomDirElement is used to
189 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
191 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
193 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
194 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
196 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
197 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
198 Remove all access to the hash-tables or lists in the objects.
200 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
201 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
202 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
203 be complient with all the gdcm source code
205 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
209 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
213 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
214 * Test/ : rename VTK tests to have a best name for the tests
215 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
216 GetFirstEntry/GetNextEntry use
218 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
219 * In SerieHeader::ImagePositionPatientOrdering()
220 // a Dicom 'Serie' may contain scout views
221 // and images may have differents directions.
222 // -> More than one may have the same 'pos'
223 // Sorting has then NO meaning !
224 Thx to Eduardo Davila for reporting bug.
226 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
228 test. Now it's on image content and not on the resulting visualisation...
229 might solve the problem on linux when using the OpenGL drivers
231 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
232 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
233 DicomDirSerie, DicomDirImage
234 Dict, DictSet classes :
235 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
236 -remove InitTraversal method.
237 * UPD Test programs + Example programs
239 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
240 * remove useless and never updated keyword \ingroup
241 * Solve pb when structure (list, map, ...) is empty.
242 Thx to Benoit for reporting bug
244 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
245 * Taking into account of 'Transfer Syntax' value
246 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
249 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
251 is no memory access violation
252 * gdcmPython/demo : add python demos using VTK
254 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
255 * FIX 'Dictionnary' is now spelt 'Dictionary'
256 'wether' is now spelt 'whether'
257 'archieve' is now spelt 'archive' ;-)
259 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
260 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
261 related methods, in order not to expose internal mechanisms
264 * REM methods that exposed internal mechanisms :
265 DicomDir::GetDicomDirPatients()
266 DicomDirPatient::GetDicomDirStudies()
267 DicomDirStudy::GetDicomDirSeries()
268 DicomDirSerie::GetDicomDirImages()
269 * UPD Test programs :
273 * UPD Example program
275 * ADD DictSet methods
279 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
280 * Removed the Print/indent/default parameter mess. There is absolutely no
281 reason to have to methods, moreover with the second taking the ostream as
282 *SECOND* parameter. This was clearly a bad hack to get things compile.
284 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
285 * Complete rewrite of the GetMacAddress code. Now the code is *much*
286 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
287 Unfortunately the main code does not work on SunOS, thus provide a specific
288 code for this platform only (and Win32 of course). Since this seems to be
289 working, change CreateUniqueUID to use GetMACAddress instead of the
290 problematic GctestetIPAddress
292 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
293 * Unfortunately to be able to test gdcmDirList I had to break the API
294 a little. Now the class is not a std::list anymore but has a member
295 std::vector (more ITK compatible). Allow unit testing on Win32 and
298 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
299 * Update SerieHeader to take into account a Serie Instance UID to properly
302 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
303 * ENH - Comment out Mathieu's (dangerous) Super Hack
304 for dealing with BIGENDIAN processors
305 - Move equivalent stuff to BinEntry::WriteContent
306 When necessary, 16 Bits Pixels are swapped in a small buffer
307 and then written. This avoid allocating a huge buffer, in
308 PixelWriteConvertor, and avoid modifying the Pixel Area.
310 Probabely, the same operation will have to be done when we want
311 to write image with Big Endian Transfert Syntax,
312 and we are working on Little Endian Processor
314 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
315 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
317 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
318 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
319 all the dict content.
320 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
322 * Test/TestDict.cxx : add a new test for the dict classes
324 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
325 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
326 file. Debug is yanked if compiled with NDEBUG
328 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
329 * src/gdcmDictSet.h : set the default output to the os variable
330 * src/gdcmDictEntry.[h|cxx] : add the Print method
331 * gdcmPython/demo/ : add a new test
333 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
334 * merging of Test/PrintDicomDir and Test/TestDicomDir
335 * removal of now redundant Test/PrintDicomDir
336 * enhancement of Example/PrintDicomDir
338 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
339 * Now, python test might work on systems
340 * Add the PrintDicomDir test
342 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
343 * FIX : First entry following group 0002 was lost for
344 Explicit Big Endian Transfer Syntax files
345 (group and elem not swaped)
347 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
348 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
349 Big Endian Transfer Syntax supposed the group following 0002
350 begins always by element 0000 (element 0000 is *optional*)
351 To avoid further troubles, let's be pessimistic, and use
352 Document::HandleOutOfGroup0002() method
353 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
354 (related pb not yet solved)
356 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
357 * Bug fix for the python part use
358 * Now, PrintHeader.py pass... but outside the ctest use. shit !
360 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
361 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
363 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
364 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
365 a string and should ask the global TS dict what are the propreties of
368 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
369 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
370 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
371 to swap the Swap Code, at parsing time, when we come out of group 0002
372 and Transfer Syntax is Big Endian
373 We should be able to read now 'true DICOM" Big Endian coded images
374 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
375 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
377 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
378 * Hopefully fix the bug on MacOSX and static global initialization.
379 This is the only -minor- patch I found that both please MacOSX and VS6.
380 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
381 but this would require a lot of change. Another approach would be that Global
382 create those string and GDCM_UNFOUND becomes a pointer to a string (which
383 gdcm::Global would destroy at exit).
385 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
386 * Fix bug on MacOSX with static initialization in a multy threaded
387 environment. static const string in a header file used to be ill
388 initialized provoquing the freeze of any tests. patch should solve this
391 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
392 * According to Benoit's suggestion, and without any objection from anybody
393 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
394 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
395 - method gdcmDicomDirObject::GetEntry() renamed as
396 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
398 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
399 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
400 you debug/warning message just as c++ streams which make them very convinient
401 to use. Once this is stabilize I will change the ostringstrem to be
402 redirected to a file (ofstream).
403 * Properly support C99 extension: __FUNCTION__ which allow us to display
404 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
406 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
407 * Removal of useless and dangerous methods :
408 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
409 GetDocEntryByName, GetEntryByName, GetDictEntryByName
410 * Removal of usless methods :
411 Dict::PrintByName, Dict::GetDictEntryByName
412 * Commenting out of probabely useless methods :
413 Dict::GetDictEntryNames()
414 Dict::GetDictEntryNamesByCategory()
415 DictSet::GetPubDictEntryNames()
416 DictSet::GetPubDictEntryNamesByCategory()
417 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
418 * ENH : Use dicomTS.dic as described in 2004 version
419 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
420 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
421 Add Accessors on VM (Value Multiplicity), and VM related methods
422 * ADD : Add a list of 'Dicom Attribute types', as found in
423 http://medical.nema.org/dicom/2004/04_15PU.PDF
425 * ADD : Add dicomGroupNameAbbreviations.dic
426 should be used to write a method to replace the former
427 Dict::GetDictEntryNamesByCategory()
429 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
430 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
431 to read in the file... and only it ! Length is the efective length of the
432 data in the DocEntry structure
434 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
435 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
436 And now use a static function call instead, with a global variable. i
437 This is much closer to the VTK approach. Hopefully should be bulletproof
438 and easier to use...hopefully
440 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
441 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
443 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
444 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
446 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
447 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
448 ValEntry, BinEntry, SeqEntry creation or replace
450 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
451 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
452 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
454 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
455 when specifying the VR
456 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
457 * src/gdcmDocEntry.cxx : amelioration of print
459 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
460 * ADD : Add the method Util::IsCurrentProcessorBigEndian
461 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
462 * ADD Method Document::ComputeGroupLength
463 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
464 in order to allow further VR modification by user
465 * REM : removal of once-called method File::WriteBase
466 integration of its code in formerly one-line method File::Write
468 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
470 replace the different values "??", "Unkn", "Unknown".
471 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
472 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
473 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
474 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
476 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
477 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
479 * Set the gdcm::Base class to some Printable classes
481 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
482 * src/gdcmFile.[h|cxx] : add the Print method
483 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
484 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
485 * src/gdcmDocument.h : remove the PrintLevel informations
486 * Example/PrintFile.cxx : use the new gdcm::File::Print
488 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
489 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
490 problems when compiling with the python wrapping
492 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
493 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
494 writting in ImplicitVR
496 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
497 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
498 JPEG decompression, especially when dicom frames are split into several
499 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
500 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
502 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * src/gdcmHeader.cxx : change the initialisation of default header.
504 Now, this header is readable by gdm, e-film, DicomWorks
506 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
507 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
508 Rename Decompressed to Raw
509 * Use the API changes in gdcm::File.
510 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
513 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
514 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
515 each added entry in the header. Replace the 'Planes' field by the 'Number
518 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
519 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
520 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
522 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
523 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
524 At this time, this image isn't readable by e-film... waiting JPR help to
527 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
528 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
529 DocEntry. Now use methods of the Document !
531 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
532 * Test/ShowDicomSeq.cxx : bug fix
534 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
535 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
536 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
537 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
538 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
540 * Test/TestCopyRescaleDicom.cxx : remove unused variable
541 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
542 containing found sequences
544 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
547 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
548 Some fields in BinEntry must be copied to not seg fault when making the :
549 gdcm::File *copy = new gdcm::File( copyH );
550 and tests are now made on good variables
552 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
553 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
554 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
556 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
557 * Add vtkGdcmWriter example and test
559 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
560 * Test/TestUtil.cxx : reformat the source code
561 * vtk/vtkGdcmReader.cxx : remove and change prints
562 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
564 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
565 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
567 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
568 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
569 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
571 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
572 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
573 by an eof to prevent all bad read of the file... and in this case, the
576 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
577 * Example/Volume2Dicom.cxx : comment unused variables
578 * Test/PrintDicomDir.cxx : comment unused variables
579 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
580 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
581 method that is redondant with AddEntry.
582 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
585 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
586 * Bug fix due my last commit (compilation under Windows).
587 * Example/Volume2Dicom : bug fix in the file and reformatting source code
588 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
590 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
592 - Remove printf / sprintf
593 - include iostream AFTER gdcm so we don't get warnings
594 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
596 - Also remove tons of include from header files, hopefully this should
597 speeup the compilation time, since it was becoming a dog slow.
598 - Remove gdcm.h as it include way too many files and slow down compilation
599 (plus it is not up to date)
600 - remove 'using namespace std' this is BAD !
602 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
603 * Remove memory leaks on the DicomDir
604 * Remove some useless data in DicomDirObject
605 * Add usefull methods in SQItem, to be complient withe the ElementSet
607 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
608 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
610 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
611 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
612 future, with convertion)
613 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
614 and ImageDataSize values. Remove the method to get the PixelReadConverter
615 from the output of the class
617 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
618 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
620 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
621 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
622 and vtkErrorMacro use.
623 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
625 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
628 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
629 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
630 The string leaves only in the fonction. So when we make a .c_str(), we
631 get the pointeur on the first element, element that will be destroyed
632 immediately after thee instruction.
633 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
634 file has been opened : the test must be made on the content of the
635 pointer and not directly on the pointer !
638 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
639 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
640 the python part recompiles
642 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
643 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
644 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
645 X session is killed (for my computer... it seems to not be identic on
648 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
649 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
650 avoid problems (otherwise, the difference test between the visible image
651 and the reference is incorrect. If the reference is greater than the
652 screen resolution, it's produce errors).
653 Can be used for only one image. Can be used with a visible flag.
654 * vtk/vtkGdcmReader.cxx : remove commented codes.
655 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
656 under windows at compilation
657 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
659 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
661 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
662 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
663 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
664 tests on the image size X, Y, Z
666 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
667 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
668 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
669 between the class name and the file name
671 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
672 * src/ : fix compilation warnings for the Write method (2 different
673 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
674 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
675 variable... create a static method in gdcm::Document to access to
676 this variable content.
678 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
679 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
680 file, to be accessed by other files (like gdcmFile). Remove commented
681 code. Move the change of the header to the gdcmFile, using the
683 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
684 To be sure of that (and simplify calls), the Write of the header now
685 gets a file name and not a file pointer (std::ifstream).
686 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
687 DocEntryArchive. Remove all open of the written file
689 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
690 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
692 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
693 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
694 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
696 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
697 some corresponding methods. Write correctly the file and check before
699 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
700 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
701 is now on RGB data (as before my last commit
702 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
704 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
705 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
706 Add a print information of the type of the entry
707 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
708 It was in the gdcmFile, and all write have been regrouped
709 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
710 Write correctly all dicom files (in decompressed mode only at this time)
711 * Test/ : test on files are now made using Raw data and not color data if
713 * Example/PrintFile.cxx : add more printings
715 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
716 * Amelioration of code, remove some code copy. For the loading of
717 BinEntry (in gdcmDocument), add the test to verify if the file is already
720 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
721 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
722 remove a DocEntry in the header (push an empty DocEntry)
723 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
724 lines. Bug fix in the initialization of the PixelConvert and the
726 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
727 use in TestCopyDicom (now this test can run under windows... but fails)
728 * Test/TestCopyDicom.cxx : amelioration of the test :
729 - test the pixels written
730 - add test points to quickly find where is the error
731 - can set a file name input and output in arguments
732 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
733 amelioration of the test output
735 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
736 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
737 all replaced DocEntry's
738 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
739 Now, each needed DocEntry to modify is duplicated, modified and inserted
740 to the header using DocEntryArchive. Thus, after save, we can restore the
741 header initial state.
743 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
744 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
746 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
747 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
748 correct to copy it. The DictEntry is specified at the DocEntry creation,
749 then, it musn't change in the time.
750 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
751 header correctly. At this time, the change is only made for the first
752 level of the Document. In the future, it might consider sequences.
753 The change is made by replacing a DocEntry by an other that is created
754 outside the class. The old value is kept. When we restore the header
755 status, the added DocEntry is deleted and replaced by the old value.
756 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
757 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
758 set the write type to explicit VR, implicit VR or ACR. Add methods to set
759 the write mode to native, decompressed or RGB (but not used at this time)
761 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
762 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
763 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
765 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
766 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
767 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
769 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
770 set because already copied when copying the BinEntry's of the header
771 * Test/TestAllReadCompareDicom.cxx : remove warnings
773 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
774 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
775 Two problems appear when doing it :
776 - with the gdcmFile : when the GetImageData method is called, the pixels
777 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
778 data (pixels). And each structure destruct the data when it's
779 destructed. So we have two destructions for the same data. To solve it,
780 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
781 data or not. If it doesn't own data, then they will not destroyed by
783 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
784 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
785 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
786 create a double destruction of the same DocEntry's. So, to solve it,
787 the TagHT is simply cleared and the DicomDir* elements are destroyed.
788 * TODO : add an entry concerning memory leaks in the DicomDir
790 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
791 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
792 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
795 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
796 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
797 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
798 after it have been deleted
800 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
801 * FIX: src/* fix the doxygen warnings.
802 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
803 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
804 was erroneously defined with a size of 15 instead of 16. [many thanks
805 to Jean Michel Rouet for pointing out this bug].
807 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
808 1. Finish merging JMR patch for writting DICOM from scratch
809 2. Fix -hopefully- bug with MONOCHROME and space vs null character
810 3. Use const ref when possible
811 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
812 5. A few more comments
813 6. CreateUniqueUID can now be called without parameter"
815 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
816 * ENH: Slightly bigger patch:
817 1. Getting toward full integration of JMR patch for writting dicom from scratch
818 2. Update Test to test part of this patch: CreateUniqueUID
819 3. File was not close properly in gdcmDict
820 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
821 5. Use of const ref instead of copy (speed issue)
822 6. Remove temporary (duplicate) string in TranslateToKey
823 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
824 8. Do not repeat virtual in subclasses
825 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
827 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
828 * Apply first patch toward better string comparison when dealing with broken
829 DICOM files. Essentially the string could be padded with a space instead
830 of a null character as defined by standard
832 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
833 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
834 because never used... and in the same time, that's remove some memory leaks
836 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
837 * src/gdcmFile.cxx : now delete the PixelConvert instance.
838 * In examples and tests : change the type of image data variables from void*
839 to uint8_t*. Remmove all delete on image data variables
841 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
842 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
843 Verify the file pointer value before open the file, and if it's not null,
844 a verbose message is generated.
845 Close correctly the file when the file isn't considered dicom-like. The
846 correctly close is a call to CloseFile.
847 When closing the file pointer, test if its not null to close the file.
848 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
849 file. For an uncompressed image, the copied data correspond in the least
850 case to the image size (calculated) or the image size specified in the
851 header. A verbose is generated if these two size mismatch
853 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
854 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
855 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
856 break under windows (with msvc6 compilation).
858 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
859 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
860 compiling with MSVC6)
862 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
863 * Bugs fix for the Windows build with VC6
864 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
865 needed (only for projects required VTK). If the VTK is included in all
866 projects, there is conflicts with the jpeg lib of vtk when compiling the
867 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
868 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
869 when compiling the gdcm_wrap.cxx file (created by the compilation of the
871 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
872 (like it's already made for the cout use). Otherwise, conflict with the
875 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
876 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
878 - comments on the DicomDir::Method related usage added.
879 - now that we use the namespace gdcm, a lot of internal classes do
880 NOT need to be wrapped anymore.
881 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
882 DicomDir::Method) new example added.
884 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
885 * Improve string manipulation. I now inforce the notion of 'DicomString'
886 A DicomString can contain as many \0 as they want
887 and it is *always* of even length.
888 We only support odd length for very rare case.
889 And in the near future this should be removed.
891 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
892 * /binary_write/ gdcm source. Now even on big endian we are writting
893 little endian. This should -heopfully- fix some tests
895 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
896 * Now the dictionary is compiled into gdcm lib. This is a default
897 behavior, thus any dic file specified is picked before failback to
898 the one comiled into lib
900 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
901 * Change internals for gdcmDict. Don't use any 'new' any more.
902 This should definitely solve any leak problem, and we should be
903 as fast as before, as long as don't modify too much the dictionary.
905 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
906 * STYLE: ivars should start with a capital letter.
907 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
908 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
910 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
911 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
912 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
913 new 2004 dictionaries added (thanks to JPR).
914 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
915 * CLEANUP_ROUND (15) for gdcmPixelConvert
916 - RLEFrame::NumberFragments is now of type unsigned int
917 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
918 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
921 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
922 * Initial work in gathering all transfer syntax accessors. clearly
923 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
924 ivars, but only one transfersyntax (class) ivar with equivalent method on
927 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
928 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
929 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
930 discussed (plus I didn't like having a 2000 lines patch not commited)
932 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
933 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
934 * CLEANUP_ROUND (14) for gdcmPixelConvert
935 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
936 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
937 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
939 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
940 anymore and hence avoids storing a copy of PixelConvert::Decompressed
941 into File::Pixel_Data.
943 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
944 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
945 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
946 * CLEANUP_ROUND (13) for gdcmPixelConvert
947 Substituted File::ParsePixelData() with PixelConvert::Print() new
949 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
950 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
951 method to those classes.
952 - src/gdcmFile.[cxx|h]:
953 -- Added a ::Print() method.
954 -- PixelConverter is now a reference instead of a member.
955 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
956 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
958 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
959 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
960 collaboration diagram and inheritance diagram should be generated with
962 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
963 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
964 pointlessly wrapped (see
965 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
966 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
967 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
968 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
969 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
970 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
971 -- File::Initialise: PixelConverter setup moved away to
972 PixelConverter::GrabInformationsFromHeader()
973 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
974 interpretation moved away to PixelConverter::BuildRGBImage()
976 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
977 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
978 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
980 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
981 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
982 displayed on Win32 when a brutal abort() occurs (because of uncatched
983 exception). See TODO new entry of this commit for more on this.
984 * TODO added new entry.
985 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
986 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
987 - HandleColor is no longer called from gdcmFile.cxx
988 - gdcmPixelConvert.cxx clean up on method arguments and internal
989 variable names for semantical coherence.
991 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
992 * Finished lossless transition, not only do we now read all lossless jpeg
993 images, without the need of the Cornwell lib, but we do read them properly now
994 * To reduce code (well to avoid code duplication), I defined a common place
995 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
996 redefine symbols. This is not perfect but this the best solution I found for a
997 compilation time jpeg option.
999 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1000 * Update jpeg ijg lib to support lossless jpeg implementation
1001 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1003 * Also added a special copyright for dcmtk since we use their bugfixes.
1006 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1007 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1008 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1009 matters, as stated in warning note at beginning of %include section).
1010 * src/gdcmDicomDir*.[cxx|h]: coding style
1011 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1012 * src/gdcmJpeg8.cxx: doxygen fix.
1013 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1014 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1015 from File:: to PixelConvert::.
1017 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1018 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1019 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1020 - more code moved away from File:: to PixelConvert::
1021 - fat setup of PixelConverter set in place in File::Initialise.
1023 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1024 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1025 namespace at the file system level. So now you should convert your examples
1027 gdcmHeader -> gdcm::Header
1028 It would be nice if people keep in mind to no open the namespace, since it
1029 allows compilation on broken plateform which were defining common symbol in
1030 the standart namespace (like LP, Unknown ...)
1032 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1033 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1034 The JPEG fragments are now parsed at the same stage than the RLE
1035 information. All code related to JPEG is now in gdcmPixelConvert:
1036 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1037 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1038 export a gdcmFile:: method. Those are simply global functions
1039 (for the time being this is better than having them attach to
1040 either gdcmFile:: or gdcmPixelConvert::).
1041 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1042 and stores the result in a gdcmJPEGFragmentsInfo.
1043 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1044 code (among other stuff) moved away from gdcmFile:; to
1047 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1048 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1049 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1050 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1051 clean up of RLE related code.
1052 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1053 - src/gdcmRLE.cxx removed
1054 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1055 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1056 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1057 * CLEANUP_ROUND (9) for gdcmPixelConvert
1058 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1059 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1060 away from gdcmFile:: to gdcmPixelConvert::.
1062 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1063 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1064 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1065 This is because Parse7Fe0 used to parse the pixels to compute the
1066 length. This task was passed over to FindDocEntryLengthOB() a long
1067 time ago, EXCEPT I had forgotten the OW case...
1068 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1069 we just recylce the code for parsing RLE fragments and computing
1071 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1072 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1073 with the retired Parse7Fe0().
1074 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1075 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1077 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1078 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1079 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1080 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1081 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1082 * CLEANUP_ROUND (4) for gdcmPixelConvert
1083 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1084 to return an unused length.
1086 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1087 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1088 this should be cleanner from the plane view. The iostream are erally a pain
1089 to use to do simple stuff.
1091 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1092 * Redo the compilation of the ijg jpeg library. Now only one source is
1093 necesseray. No need to rename file by hand what so ever. CMake handle the
1094 copying of the file within different directory, configure header file to
1095 modify some symbol. The only addition made to ijg wasd a mangle table so
1096 that symbol are different whether we are within 8bits or 12bits.
1098 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1099 * Added documentation of vtkgdcmReader on Website:
1100 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1101 with it's binary name).
1102 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1103 the Website to be more complete.
1104 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1105 doxygenated documentation.
1106 - Doc/DoxyVtkGdcmReaderExamples.txt added
1107 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1108 DoxyVtkGdmReaderExamples.html )
1109 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1110 * CLEANUP_ROUND (3) for gdcmPixelConvert
1111 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1113 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1114 * CLEANUP_ROUND (2) for gdcmPixelConvert
1115 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1117 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1118 * CLEANUP_ROUND for gdcmPixelConvert:
1119 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1120 - src/gdcmPixelStuff[h|cxx] removed
1121 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1122 - src/CMakeLists.txt changed accordingly
1123 * GDCMHOME clean up:
1124 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1125 gdcmVersion.py moved to newly created ATTIC related
1126 gdcmPython/SetupOldies/ directory.
1127 * Autotools clean up:
1128 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1129 - autogen.sh configure.in acinclude.m4 python.m4 removed
1131 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1132 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1133 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1134 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1136 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1137 * TODO updated with Mathieu suggestions. I proposed a template for
1138 describing TODO entries and used it for new entries.
1139 * Added Doc/Website/CodingStyle.html, Developpers.html,
1140 DeveloppersPython.html, GdcmDataCvs.html and
1141 DownloadVersion0_1.html, DownloadVersion0_3.html.
1142 * Some Doc/*.txt Doxygen files (which do not really concern the
1143 documentation itself, but the website) moved to html and
1144 placed in directory Doc/Website:
1145 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1146 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1147 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1148 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1149 * CMakeLists.txt changed accordingly.
1150 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1151 DeveloppersPython.html
1152 * INSTALL nows refers to Doc/Website/Installation.html
1154 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1155 * Added Doc/Website directory, that contains a first raw version
1158 2004-09-23 Jean-Pierre Roux
1159 * FIX In order not to be poluted any longer by casting problems,
1160 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1161 we can now delete[] it safely
1162 * VoidArea is now called BinArea (less confusing name),
1163 and all the methods called ...VoidArea... are now ... BinArea...
1164 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1166 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1167 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1168 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1169 up to the destructor of gdcmElementSet to clean up TagHt and it's
1172 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1173 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1174 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1176 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1177 * ENH: added some utility method that builds a flat dictionary
1178 holding all the Dicom entries contained in the recursive structure
1179 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1180 an example of usage.
1181 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1182 BuildFlatHashTable() that build a flat dictionary.
1183 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1184 gdcmDocument is now a friend of gdcmElementSet.
1185 - src/gdcmElementSet.cxx: clean up.
1186 - Example/FlatHashTablePrint.cxx added.
1187 - Example/CmakeLists.txt changed accordingly
1189 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1190 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1191 moved away from gdcmDocEntrySet (since this class is an abstract class
1192 acting like an interface). SQDepthLevel and BaseTagKey are now
1194 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1195 and associated accessors. Doxygenation of the class.
1196 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1198 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1199 Use SQDepthLevel accessor instead. ::Print() adapted.
1200 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1201 - src/gdcmDocument.cxx changed accordingly.
1203 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1204 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1205 - The following is the doxygen comment of the typedef declaration
1206 of gdcmTagKey in src/gdcmCommon.h:
1207 gdcmTagKey is made to old an "universal" (as in URL, Universal
1208 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1209 A dicom tag always has a group and an element, but a set of tags
1210 embeded in various (optionally nested) sequences and sharing
1211 the same group and element all share the same (group, element)
1212 "identifier". Hence the (group, element) cannot be used as an
1213 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1214 In order to construct a proper tag identifier (i.e. a key) we
1215 consider the following definition of a TagKey:
1216 - let Group, Element be the string representation of the
1217 group and element dicom tag members,
1218 - let ItemNumber be the string representation of the integer
1219 index of the considered item number of a sequence,
1220 Let the key of a tag embeded in a sequence, noted SeqTag, be
1222 /ItemNumber#Group|Element
1223 where "/", "#" and "|" are characters acting as separators.
1224 Then the general form of a gdcmTagKey is given by:
1225 Group|Element<SeqTag>
1226 where <SeqTag> means NO or many instances of SeqTag.
1227 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1230 but the gdcmTagKey of a tag "embeded" is the first item of
1231 a sequence, itself nested in the third item of a sequence is the
1233 0004|1220/2#0008|0082/0#0008|0090
1234 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1235 order to hold the new sequence compatible key. Previously, the
1236 GetKey() method would look in the underlying gdcmDictEntry.
1237 - src/gdcmDocEntry.cxx:
1238 -- constructor now copies the underlying DictEntry key, in the local
1240 -- ::Print: displays the member Key, instead of the (group, element).
1241 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1242 - src/gdcmDocEntrySet.h:xi
1243 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1244 -- now has a new BaseTagKey member.
1246 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1247 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1249 This poses the problem with the semantics of the following lines
1250 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1251 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1252 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1253 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1254 to the long FIXME note for what the problem is. Nevertheless in
1255 order to get things working the dicom dictionary was altered !
1256 Please fix things urgently...
1257 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1258 information), see above note on moving the member VoidArea. Nevertheless
1259 the following entries previously correctly set as US are now inproperly
1261 0028 1201 OW IMG Red Palette Color Lookup Table Data
1262 0028 1202 OW IMG Green Palette Color Lookup Table Data
1263 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1264 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1265 of gdcmDocEntry moved to gdcmSeqEntry.
1266 * src/gdcmSeqEntry.cxx: STYLE.
1268 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1269 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1271 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1272 * gdcmPython/testSuite.py: all the test suite in python is now moved
1273 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1274 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1275 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1277 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1278 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1279 to avoid inclusion recursion until STL is reached.
1280 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1281 mecanism. errno.h is not included in gdcm anymore.
1282 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1283 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1285 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1286 gdcmData/TestAllEntryVerifyReference.txt
1287 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1288 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1289 exception_on_error parameter.
1290 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1291 - vtk/vtkGdcmReader.cxx changed accordingly,
1292 - Example/*.cxx and Test/*.cxx changed accordingly.
1294 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1295 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1296 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1297 enable_sequences removed from gdcmHeader constructor and dependencies.
1298 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1299 * gdcmPython/demo/PrintHeader.py: dummy fix.
1300 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1301 skip_shadow removed from gdcmHeader constructor and dependencies.
1302 * Example/*.cxx and Test/*.cxx changed accordingly.
1304 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1305 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1306 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1308 2004-07-21 Jean-Pierre Roux
1309 * FIX Now, Parsing and Printing a DICOMDIR do work!
1310 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1312 2004-07-20 Jean-Pierre Roux
1313 * FIX Some brain damaged headers have Zero-Lenght fields
1314 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1316 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1317 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1318 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1319 variable (instance of gdcmDebug) by a definition macro, and the instance
1320 is now in static in the gdcmDebug class
1321 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1322 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1324 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1325 * WARNING: ctest now depends more tightly on gdcmData. You should
1326 check out gdcmData properly for things to run smoothly...
1327 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1328 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1329 we need the pixels not be loaded in order to use the ValEntry
1330 that displays position and size).
1331 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1332 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1333 be deprecated. If you have any doubts about the advantages of a
1334 modern scripting language (read Python) versus grass root C++ (i.e.
1335 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1336 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1337 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1338 Anyhow, consider documenting the gdcmData images in
1339 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1341 * Test/CMakeLists.txt:
1342 - now uses TestAllEntryVerify.cxx
1343 - specific comments on oldACR00001.ima (now renamed in gdcmData
1344 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1345 gdcmData/TestAllEntryVerifyReference.txt
1348 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1349 * src/*.[h|cxx] : typedef clean up
1350 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1351 - TagKey renamed to gdcmTagKey (for external usage)
1352 - VRKey renamed to gdcmVRKey (for external usage)
1353 - removal of typedef duplication.
1354 - Removed all unecessary inline keyword from class inline definitions.
1355 - Some method|function(void) declarations replaced with method|function().
1356 * src/jpeg/libijg12/jdhuff12.c:
1357 - printf polluting ctest removed.
1358 - TAB removal for comminting
1360 - TestAllReadCompareDicom.cxx: added a test that compares all the
1361 images in gdcmDataImages.h with corresponding images in
1362 gdcmData/BaselineDicom/. When baseline images are not present
1363 this test creates them.
1364 Note: we need to validate each reference image, but before that
1365 I'd like to rename them with a more explicit name...
1366 - CMakeLists.txt: changed accordingly.
1367 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1368 including each header needed).
1370 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1371 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1372 test suite to the Example directory. Are concerned:
1377 - TestWriteSimple.cxx
1378 * Test/CMakeLists.txt: added some comments on reasons for black listing
1379 image gdcmData/oldACR00001.ima
1381 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1382 * Test/CmakeList.txt: removed the following from black list (to be coherent
1383 with removal from gdcmData):
1384 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1385 - gdcm-MR-PHILIPS-16.dcm
1387 Added the following because after last cvs update, they cause
1388 ctest -R TestReadWriteReadCompare
1390 - gdcm-MR-SIEMENS-16-1.acr
1392 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1393 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1394 new comments in this file) we temporarily (sigh) move to a weaker
1396 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1397 we don't need to black list the following images anymore:
1398 - 8BitsUncompressedColor.dcm
1400 - US-PAL-8-10x-echo.dcm
1401 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1402 fixes and the beautified code ;-)
1403 This fixes the bug introduced in version 1.42 (when beautifying)
1404 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1405 Note: ctest was blind to this bug (this means we need to still
1406 improve the test suite). The bug could be detected by using
1407 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1409 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1410 and by displaying the (garbage) produced file temp.XDCM...
1412 2004-06-29 Jean-Pierre Roux
1413 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1414 - replace by uggly but working old code :-(
1415 A lot of things should be OK again.
1416 It's really urgent to have a test suite that *tests*,
1417 to prevent Frog's beautifying sessions to break all the stuff
1418 (twice, withing a fortnigh ...)
1420 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1421 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1422 redundancy) to added Test/TestReadWriteReadCompare.cxx
1423 * Test/CmakeList.txt: because the compare test of
1424 Test/TestReadWriteReadCompare.cxx fails, the following images are
1425 black listed: - 8BitsUncompressedColor.dcm
1427 - US-PAL-8-10x-echo.dcm
1428 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1429 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1430 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1431 and ad-hoc kludge. This kludge is now removed, and on encountering
1432 such an image (OB field brain damaged) we set errno. Then in
1433 ::FindDocLength() we "fix" the length as being ALL what remains
1434 in the file (until EOF). We then proceed, hoping for the best...
1435 This fixes a SegFault in ShowDicom when trying to write such an
1437 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1438 (because TestWriteRead breaks on it, after a non conformal commit?).
1439 ctest now runs properly, except for MakeDicomDir (which was always
1440 broken) and the Python related stuff (still not fixed).
1442 2004-06-24 Jean-Pierre Roux
1443 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1444 FIX : Test/TestReadWrite now iterates on all the file names
1445 (instead of infinite loop)
1446 ENH : Test/TestWriteRead now iterates on all the file names
1448 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1449 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1451 2004-06-24 Jean-Pierre Roux
1452 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1453 when SamplesPerPixel =3
1454 - now Write is no longer confused by
1455 'BitsAllocated = 12" and 'BitsStored=12"
1456 - "UN" value representation Elements are now written correctly
1457 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1458 ENH : - now gdcmHeader has its own Write methods
1459 (in order to split the job that has not to be done
1462 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1463 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1464 loop on the same image until memory went out.
1465 Note: this means we still have gobs of memory loss in PrintDocument
1466 * src/gdcmDocument.cxx: fixes problem on parsing on file
1467 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1469 2004-06-24 Jean-Pierre Roux
1470 FIX : Write - All the Sequences and Sequence Item are now written
1471 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1472 is added a the end, when necessary.
1473 - A lot of brain-damaged images, that were read correctly are
1474 now written correctly
1475 - length compatible BinEntry are now loaded correctly
1476 (even for odd groups)
1477 Note : only Explicit Value Representation was checked.
1478 (question : is implicit VR really necessary for gdcm ?)
1480 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1481 * DEVELOPPER: added a proposition of coding style.
1482 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1485 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1486 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1487 Use the gdcmDocEntry::Print() and Write() instead.
1488 * src/gdcmDocument.cxx: bug fix.
1490 2004-06-22 Jean-Pierre Roux
1491 FIX : gdcmDocument.cxx
1492 - Now we do recognize the JpegLossLess format (there was a misstyping in
1493 code 'beautyfication' :-(
1494 - Now we automaticaticaly load the Luts, if any
1496 2004-06-22 Jean-Pierre Roux
1497 In order : to write Sequences, whatever their imbrication level,
1498 : to allow user to create his own Sequences
1499 a lot of modif where necessary (adding, moving, or virtualising methods)
1501 WARNING : save your own sources *before* cvs up !
1504 ADD virtual void Write(FILE *fp, FileType filetype);
1507 ADD virtual void Write(FILE *fp, FileType filetype);
1508 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1511 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1512 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1513 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1514 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1515 ADD std::string GetEntryByName(TagName name);
1516 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1518 std::string vr = "unkn",
1519 std::string fourth = "unkn",
1520 std::string name = "unkn");
1521 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1522 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1523 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1524 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1525 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1526 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1527 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1528 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1531 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1532 ADD virtual std::string GetEntryByName (TagName tagName);
1533 ADD virtual std::string GetEntryVRByName (TagName tagName);
1534 REM virtual bool Write(FILE *, FileType);
1535 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1536 FILE *_fp, FileType type);
1537 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1538 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1539 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1540 REM virtual std::string GetEntryByName (std::string tagName);
1541 REM virtual std::string GetEntryVRByName (std::string tagName);
1542 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1543 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1544 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1546 std::string vr = "unkn",
1547 std::string fourth = "unkn",
1548 std::string name = "unkn");
1549 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1550 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1551 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1552 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1555 ADD virtual void Write(FILE *fp, FileType filetype);
1558 ADD virtual void Write(FILE *fp,FileType filetype);
1561 ADD virtual void Write(FILE *fp, FileType filetype);
1562 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1563 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1564 REM std::string GetEntryByName(TagName name);
1567 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1569 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1570 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1571 The default constructor invoked by the line
1572 gdcmHeader *f1 = new gdcmHeader( header );
1573 was gdcmHeader::gdcmHeader(bool) instead of the expected
1574 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1575 Hence the parsing wasn't executed... See also below.
1576 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1577 as explicit constructor didn't do the trick to fix the above problem.
1578 Could anyone explain why ?
1579 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1580 properly calls gdcmValEntry::Print() (that was weed out from
1581 code related to gdcmBinEntry).
1583 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1584 * In order to fix memory leaks:
1585 - Test/TestWriteSimple.cxx: added cleaning of free store through
1587 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1588 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1589 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1590 (through the call to ::AddDicomDirMeta()) or the destructor
1591 would crash when deleting uninitialized ::metaElems].
1592 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1593 - src/gdcmDocument.cxx:
1594 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1595 from dynamic stores.
1596 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1597 was causing memory leaks.
1598 - src/gdcmSQItem.cxx:
1599 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1600 cleanly handled with polymophism: sorry but my milage is low).
1601 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1602 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1603 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1604 This avoids SegFaulting.
1605 - src/gdcmSQItem.h: coding style.
1607 - Test/TestWriteSimple still severely sucks. The output image content
1608 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1609 damaged when displayed with vtkgdcmViewer.
1610 - on memory leaks: TestWriteSimple leaks really less (see entry
1611 of 2004-06-18 in Changelog file for the call to valgrind).
1612 - on segfaults: ctest now passes all the tests but one (no more
1614 * Erroneous leading white fix:
1615 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1616 white[s] (as opposed to from >> xxx, that removes it [them].
1617 - src/gdcmTS.cxx: ditto.
1618 - gdcmPython/testSuite.py: dirty related kludge removed.
1619 * src/*: remaining references to gdcmParser removed.
1620 * src/*[cxx|h]: added copy[way]left header.
1623 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1624 * In order to fix writing of dicom files:
1625 - Test/TestWriteSimple.cxx: a simpler example of writing.
1626 - Test/CMakeLists.txt changed accordingly.
1627 - src/gdcmDocument.cxx:
1628 -- The destructor now recursilvely removes potential sequences.
1629 -- Bug fix in ::IsJPEG2000()
1630 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1631 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1633 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1634 to only declared) and build on top of
1635 ::GetDocEntryByNumber(guint16, guint16).
1636 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1637 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1638 for usage in destructor and treatement of promotion in
1639 ::ReplaceOrCreateByNumber().
1640 - src/gdcmSQItem.cxx: destructor should better handle his job.
1641 Test/TestWriteSimple now runs (or at least it DOES something).
1642 * We can now start hutting memory links. A good starting point is:
1643 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1644 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1645 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1647 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1648 * Valgrind note: after Mathieu Malaterre teached me how to read
1649 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1651 Using gcc, you can force the STL to use malloc and to free memory as
1652 soon as possible by globally disabling memory caching.
1653 With 3.2.2 and later, you should export the environment variable
1654 GLIBCPP_FORCE_NEW before running your program.
1655 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1656 simply vanish (it is still not clear to me, whether this means that
1657 STL std::string leaks or if valgrind believes it leaks...).
1658 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1659 running bin/gdcmTests makeDicomDir):
1660 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1661 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1663 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1664 SegFaulting (I drowned in DicomDir related code when trying to
1665 understand why the list is empty...).
1666 * src/gdcmDocument.h: first BSD license header try.
1667 * Doc/License.txt added.
1669 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1670 * src/gdcmDocument.[h|cxx]:
1671 - Clean up of the Transfer related predicates. They are now all based
1672 on new method isGivenTransferSyntax, that (should) handle properly
1673 the padding problem.
1674 - general clean up, simplification, and coding style.
1675 - Specific clean up of Parse7FE0() (umproperly named actually).
1676 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1678 2004-06-14 Jean-Pierre Roux
1680 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1681 - fix the display of SQItem ordinal number
1682 - add the GetSQItemByOrdinalNumber method
1683 - remove some useless never written private methods
1685 2004-06-14 Jean-Pierre Roux
1687 - adding a constructor taking a gdcmDocEntry as an input param
1688 - ReplaceOrCreateByNumber now returns :
1689 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1690 a gdcmValEntry * if a string value is passed as a param
1692 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1693 according to the param type (no longer sets a gdcmDocEntry)
1694 - GetValEntryByNumber, GetBinEntryByNumber added
1695 - NewValEntryByNumber and NewBinEntryByNumber added
1697 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1699 - GetSQItemNumber and SetSQItemNumber added, to provide
1700 a (relative) Item identier inside a given Sequence
1701 \warning : some pb remaining around this number
1703 - AddEntry now takes the Item Number as a param
1705 - adding a constructor taking a gdcmDocEntry as an input param
1707 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1708 * Memory leak hunt with the following command:
1709 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1710 --show-reachable=yes gdcmTests PrintDocument
1711 It looks like many (all?) leaks are due to the STL (or a bad usage
1712 of the STL. The lines producing the leaks now have a comment with
1713 a "MEMORY LEAK" tag: you can retrieve them with
1714 grep "MEMORY LEAK" src/*
1715 Here are two typical examples which I can't help fixing:
1720 char * test = "babo";
1721 name = test; //// <--- valgrind detects 960 bytes lost in
1722 //// call to std::string::operator=(char const*)
1723 name.clear(); //// Doesn't help !
1731 std::cout << "Type a bunch of characters followed by RETURN: ";
1732 getline(std::cin, line); //// <--- valgrind dectects a loss
1733 //// of 1320 bytes in call to
1734 /// std::basic_istream<>& std::getline<>
1740 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1741 * src/gdcmHeader.[cxx|h]:
1742 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1743 and related, moved away to gdcmDocument.
1744 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1745 the corresponding protected accessors of inherited class
1746 gdcmDocument, removed ! As a consequence gdcmFile had to be
1747 declared friend of class gdcmDocument (see below).
1748 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1749 - Clean up of undefined or unused methods.
1750 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1751 account the changes to gdcmHeader.h).
1752 * src/gdcmDocument.h:
1753 - gdcmFile is now a friend class (in order to take into account the
1754 changes to gdcmHeader.h).
1755 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1756 (see changes to gdcmHeader.h).
1757 - Accessors (reading on the form GetEntry*) are now public.
1758 - Clean up of undefined or unused methods.
1759 * src/gdcmDocument.cxx:
1760 - adaptation to changes to gdcmDocument.h
1761 - ::OpenFile now writes a verbose message when file cannot be opened.
1762 - some std::string properly set to VRKey
1763 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1764 references to gdcmDocument.
1765 * Test/TestFindTags.cxx: changed accordingly to above changes.
1766 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1767 cvs repository gdcmData.
1769 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1770 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1771 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1772 conflicts with gdcmValEntry::voidArea.
1773 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1774 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1775 Value representation between StringRepresentable and BinaryRepresentable.
1776 * src/gdcmDocument.cxx:
1777 - method ParseDES: proper indentation restored and usage of
1778 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1779 - method LoadDocEntry: the fingerprint left in the SetValue() of
1780 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1781 removed. Reverting to previous code segment with the proper
1782 dynamic_cast< gdcmValEntry* >.
1783 Note: this was (partially) breaking the python test suite
1784 (gdcmPython/testSuite.py) that made usage of the above
1785 fingerprint to check presence of "Pixel Data".
1786 * src/gdcmDocEntry.h: coding style.
1787 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1788 now taken into account.
1789 * gdcmPython/gdcm.i: adaptation to the new internal representation
1790 of gdcm (exit gdcmParser, hello gdcmDocument).
1791 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1793 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1794 anymore, but instead prints the loaded Python dictionary.
1795 * .... alas, the python testSuite is still broken.
1797 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1798 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1800 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1801 * src/gdcmUtil.h : export methods
1803 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1804 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1806 * Initial addition of automatic python testing
1807 * Initial addition of automatic image comparison
1809 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1810 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1811 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1813 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1814 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1815 * Test/ShowDicom.cxx : bug fix for msvc compilation
1816 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1818 2004-05-04 Jean-Pierre Roux
1819 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1820 new concepts (and new classes) :
1821 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1822 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1823 - Sequence Doc Entries (gdcmSeqEntries)
1824 a Sequence is composed of Items.
1825 Each item is a set of Doc Entries (this is recursive)
1826 The non uniqueness of the 'Dicom tag' is due to this recursivity
1827 (never taken into account)
1828 Our unability to add a new 'entry' in the header
1829 at the proper location (neither in the H-Table (map or multimap),
1830 nor in the Chained List is also due to this recursivity.
1831 Don't try, right now, to use/modify/compile these new sources :
1832 nothing is finished.
1833 We just commit all the stuff, 'as is', in order not to loose it.
1835 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1836 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1838 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1839 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1840 file prefix (SetFilePrefix)
1842 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1843 * Add a new test: ShowDicom, for now this is just the c++ version of
1844 checkRead.sh, later it will be able to compare the image read against a
1846 * Replace the DEBUG on the stack with a global entry in cmake interface:
1847 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1849 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1850 * Add an example subdir, with a real example on how to read + write a
1853 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1854 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1855 * Doc/CMakeLists.txt: the main page is now properly differentiated
1856 between the developper and user version.
1857 * Doc/doxygen.config.in: dropped search related obsolete flags
1858 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1860 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1861 * DEVELOPPER: added some helpfull comments for compile/test/install
1864 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1865 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1866 src directory, now generated in the build dir.
1867 2. Tests as mentionned smarter
1869 4. Add a new method in gdcmDict that return the PubDict by name
1870 this is interesting for 3rd party lib like ITK,
1871 where we could set the institution name / patient name...
1873 * ENH: 1. Now the test suite is working for real
1874 2. All binaries are now output in the gdcm-bin directory
1875 (this was not true before)
1877 2004-04-28 Jean-Pierre Roux
1878 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1879 SeQuence indented printing of Dicom Header.
1880 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1881 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1882 Computation of SQDepthLevel is now part of gdcmHeader constructor
1883 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1884 tree-like structure of a Dicom Header.
1885 * FIX Test code cleaning
1887 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1888 * ENH: Adding automatic testing
1889 1. Need a DartConfig.cmake to submit to public
1890 2. Add a test driver gdcmTest.cxx
1891 3. gdcmTestMain, an helper for the main test driver gdcmTest
1892 4. Files in Test don't have a main anymore, this becomes interesting
1893 when we add more and more tests, thus dsw don't have to load
1895 * ENH: Adding a GDCM_DATA_ROOT for testing
1896 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1897 one file instead of seven + some small cleanup
1899 2004-04-22 Jean-Pierre Roux
1900 * ENH Minor changes to the Print() methods.
1901 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1902 Header printing. Example given with :
1903 > PrintHeader fileName 2 new
1904 (SQ based tree-like structure still to be done for the Header ...)
1906 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1907 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1908 1. I have added some unsigned where needed
1909 2. Some function parameter not used -> (void)
1910 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1911 4. g++ don't like character '\' in comment
1912 5. #define jpeg_create_decompress jCreaDecompress
1913 this really need to be fixed
1914 6. virtualize destructor of gdcmObject ... leakage
1915 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1916 this also really need to be fixed
1917 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1918 remove compression file
1919 (as we only do decompression, right ?)
1920 * ENH: Change malloc/calloc/free with c++ equivalent
1922 2004-04-21 Jean-Pierre Roux
1923 * FIX gdcmHeaderHelper::GetXSpacing
1924 when a single value is found (bug ?), xpacing is now
1925 defaulted to yspacing
1927 2004-04-19 Jean-Pierre Roux
1928 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1929 * ENH add parameters :
1930 bool exception_on_error = false,
1931 bool enable_sequences = false,
1932 bool ignore_shadow = false
1933 to the gdcmFile constructors to be full gdcmParser compliant
1934 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1935 to allow reading of PAPYRUS 3.0 files
1937 2004-04-06 Jean-Pierre Roux
1938 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1940 2004-04-02 Jean-Pierre Roux
1941 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1942 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1943 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1945 2004-03-30 Jean-Pierre Roux
1946 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1947 for ACR file, written out as DICOM files (hope so...)
1949 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1950 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1951 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1952 moved to base class gdcmParser and only the specialisation is kept
1954 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1955 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1956 already does the job.
1957 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1958 (to be consistent with gdcmParser::WriteEntries).
1960 2004-03-30 Benoit Regrain
1961 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1962 upate of the object's instance. It's passed to 2 in the unfavorable
1963 case : one in the ExecuteInformation, one in the ExecuteData
1965 2004-03-29 Jean-Pierre Roux
1966 * ENH : Check on file type to be written moved
1967 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1968 * FIX : gdcmObject::ResetBoundaries now stops properly
1969 when end-of-list is reached
1970 : gdcmVersion modified (as Benoit Regrain asked)
1972 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1973 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1974 * src/gdcmUtil.cxx: added forgotten iostream include.
1975 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1976 equivalent to ExplicitVR in existing code).
1978 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1979 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1980 now contains all the gdcmGlobal related code.
1981 * minor coding style and doxygenation changes.
1983 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1984 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1985 now contains all the Debug related code.
1986 * minor clean-up of includes in src/*.cxx
1987 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1988 CreateCleanString) removed.
1989 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1990 * Doc/DoxyMainPageUser.txt added.
1991 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1992 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1993 src/gdcmDirList.cxx)
1995 2004-03-24 Jean-Pierre Roux
1996 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1998 2004-03-23 Jean-Pierre Roux
1999 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2000 big endian made volumes
2001 * ENH Now gdcmParser constructor and destructor are protected to forbid
2002 end user to instanciate class gdcmParser
2003 (only gdcmHeader and gdcmDicomDir are meaningfull)
2005 2004-03-22 Benoit Regrain
2006 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2007 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2008 gdcmSerie to gdcmDicomDirSerie
2010 2004-03-19 Jean-Pierre Roux
2011 * ENH Now the tree-like structure describing a DICOMDIR comming from
2012 an already existing DICOMDIR file is consistent with
2013 the home-made tree-like structure build ex-nihilo
2014 or build from the files held (recursively) in a Directory
2015 functions gdcmDicomDir::CheckBoundaries()
2016 gdcmObject::SetBoundaries() added
2018 2004-03-17 Jean-Pierre Roux
2019 * REM (Eric Boix bug) : removal of meaningless
2020 gdcmDicomDirImage::NewImage function.
2021 * FIX now file names and directory name are written properly in the
2023 * FIX now gdcmDicomDir constructor may be call without any trick
2026 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2027 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2028 of gdcmDicomDirImage::NewImage as empty function.
2030 2004-02-28 Jean-Pierre Roux
2031 * ENH add gdcmDicomDir:NewPatient
2032 add gdcmDicomDirPatient:NewStudy
2033 add gdcmDicomDirStudy:NewSerie
2034 add gdcmDicomDirSerie:NewImage
2035 to allow making gdcDicomDir object.
2036 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2037 (as opposite to the gdcmHeader chained list)
2039 2004-02-11 Benoit Regrain
2040 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2041 when using from python
2043 2004-02-10 Benoit Regrain
2044 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2045 * FIX : in gdcmDicomDir when the directory is empty
2046 * ENH : add callback and methods to get the progression of dicomDir
2049 2004-02-06 Jean-Pierre Roux
2050 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2051 - GDCM_META added to gdcmDicomDirType
2052 - class gdcmMeta created
2053 * ENH : - A brief summary is now displayed at the beginning of
2054 'testDicomDir' to help disaster magnitude estimation
2055 * REM : Now useless Test/explDICOMDIR.cxx
2057 2004-02-05 Benoit Regrain
2058 * ENH : add methods in gdcmObject to get the hash table or the list of
2060 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2061 * FIX : wrapping python for TagHeaderEntryHT
2063 2004-02-04 Benoit Regrain
2064 * FIX : even length for some strings when writting the dicom dir
2065 * FIX : sort the images in the dicom dir
2066 * FIX : Bug fix for python use of dicom dir
2067 * ADD : a python demo
2069 2004-02-04 Jean-Pierre Roux
2070 * FIX : Final solution (?) for icone embedded images
2071 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2072 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2073 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2074 gdcmData/gdcm-MR-SIEMENS-16.acr1
2075 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2076 to make full checking easier
2078 2004-02-04 Benoit Regrain
2079 * FIX : WriteEntries : coding style & logic in parameters
2080 * FIX : Set the elements to create the DicomDir in a dictionary file
2082 2004-02-03 Benoit Regrain
2083 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2084 * gdcmDicomDir : add the load of directory
2085 * Bug fix and print add-on
2087 2004-02-03 Jean-Pierre Roux
2088 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2089 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2090 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2091 * FIX gdcmParser.cxx : 'group length' elements are now considered
2092 as integers, even for shadow groups, when file is Implicit VR
2094 2004-02-02 Jean-Pierre Roux
2095 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2097 of the last synonym :-(
2098 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2100 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2101 * FIX taking into account the possible 7fe0,0010 multiplicity
2102 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2103 to allow removal of references to 7fe0,0010, to deal with
2104 ACR-NEMA images, when 0028,0200 is meaningfull
2106 2004-01-31 Jean-Pierre Roux
2107 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2108 no longer writes 'Un' on disk
2109 * FIX SQ elements with actual length are now dealt with corectly
2110 * FIX gdcmFile::WriteBase make the difference, for color images, between
2111 the length (for Palette expanded images)
2112 and Raw Length (non expanded image + Palette)
2113 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2114 (that broke Write). Replaced by UL.
2115 Aware user will reload the field if he
2116 thinks it's necesssary
2118 2004-01-30 Jean-Pierre Roux
2119 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2120 when 'dirty Acr' is found, to be compliant with the new
2121 IsReadable() methods.
2123 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2124 (no DOUBLE images in kosher DICOM,
2125 but so usefull for people that miss them ;-)
2127 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2128 DICOMDIR related utilities (not checked as Windoze compliant)
2130 2004-01-28 Jean-Pierre Roux
2131 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2133 2004-01-27 Jean-Pierre Roux
2134 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2135 to allow skipping the shadow elements, to save memory space.
2136 The TRUE value for this param has to be used
2137 with a FALSE value for the 'enable_sequence' param.
2138 ('public elements' may be embedded in 'shadow Sequences')
2139 * gdcmHeader methods now deal with 'embedded icones images' in the header
2140 (even when an 'icone image sequence' is announced by the
2141 element (0x0088,0x0200), but there is NO icone at all ...
2143 * gdcmHeader sometimes Image Location value doesn't follow
2144 the supposed processor endianity (see gdcmData/cr172241.dcm).
2147 * gdcmHeader add the method
2148 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2149 to get *all* the Header Entries with the same tag.
2150 GetHeaderEntrySameName is probabely *useless*
2151 (no meaning : Name is *not* an identifier within the Dictionary)
2153 2004-01-26 Benoit Regrain
2154 * Bug fix in the print of hexadecimal representations. Remove long fields
2155 in the print and add a third level of print to print them
2157 2004-01-23 Benoit Regrain
2158 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2159 * Bug fix on test suite after remove the strip made on not string fields
2160 * Split the IsReadable method between gdcmParser which test that the file
2161 is dicom and gdcmHeader which test that it's an image file
2163 2004-01-22 Benoit Regrain
2164 * DicomDir : clean code, add methods, set variables in protected or private
2165 * gdcmUtil : bug fix for the clean string method
2167 2004-01-19 Benoit Regrain
2168 * Add the use of shadow dictionaries
2169 * bug fix and coding style
2171 2004-01-19 Benoit Regrain
2172 * src/gdcmFile.cxx : bug fix concerning the close of file
2173 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2174 * Add the update of header entries using the shadow library
2176 2004-01-19 Benoit Regrain
2177 * removal of file gdcmHeader2.cxx
2178 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2179 inheriting from gdcmParser. This split is to prepare the integration
2180 of dicom dir parsing
2181 * bug fix under python
2183 2004-01-16 Jean-Pierre Roux
2184 * REM removal of class gdcmHeaderEntrySet
2185 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2186 * ADD add file gdcmHeader2.cxx
2187 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2189 2004-01-15 Benoit Regrain
2190 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2191 entries created while parsing the header. Thus, they will be destroyed
2192 when the gdcmDictSet will be destroyed
2193 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2196 2004-01-15 Benoit Regrain
2197 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2198 made a fatal error because of the memory release at the end of program.
2199 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2200 some memory and vtk seems to have some problems with that.
2201 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2203 2004-01-14 Benoit Regrain
2204 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2205 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2206 * src/*.[h|cxx] : make changes due to class name changes
2207 * gdcmPython/demo/*.py : bug fix due to method names
2209 2004-01-13 Benoit Regrain
2210 * src/*.[h|cxx] : coding style
2211 * vtk/*.[h|cxx] : coding style
2213 2004-01-13 Benoit Regrain
2214 * gdcmPython/testSuite.py : test the readable flag of file for tests
2215 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2216 It's lied to the stl compilation by MSVC (windows, always windows...)
2217 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2219 2004-01-12 Benoit Regrain
2220 * src/*.h : add comments
2221 * src/gdcmDictSet.h : set the method BuildDictPath in public
2222 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2223 directly setted in the source code
2224 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2227 2004-01-09 Benoit Regrain
2228 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2229 * setup.py : use a reference to gdcmVERSION
2231 2004-01-07 Benoit Regrain
2232 * Modification to compile with the distutils.
2235 2003-12-10 Benoit Regrain
2236 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2237 can use a gdcmHeaderHelper to load data
2238 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2239 made in the source code
2241 2003-12-10 Benoit Regrain
2242 * Update Windows projects and .cvsignore files
2244 2003-11-12 Jean-Pierre Roux
2245 * ENH gdcmHeader constructor has one more parameter (default value : false)
2246 that allows the user to 'go inside' the SeQuences only
2248 gdcmElValSet:Print takes it into account
2250 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2251 * ENH: Update gdcmPython/CMakeLists
2252 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2253 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2255 2003-11-10 Jean-Pierre Roux
2256 * FIX : gdcmHeader::LoadElements is now based
2257 on the ListTag listElem member,
2258 not longer on the TagElValueHT tagHt member
2259 * ENH : PrintPubElVal shows (temporarily) both results,
2260 with the tagHt member and the listElem member.
2261 (it's easier to 'see' the problems when using Printheader)
2263 * FIX : old private member LgrElem is now splitted into
2264 ReadLength : Length actually found on disk (updated only
2265 if bug fixing is necessary), for internal
2267 UsableLength : Updated by FixFoundLength, to fix a bug
2268 or to allow Parser going on.
2269 Will allow to re-write a kosher header when a SeQuence
2270 with a length (not 0000) is found
2271 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2272 because gdcmElValSet::Add does not update ListElem
2275 2003-11-07 Jean-Pierre Roux
2276 * FIX misstyping in Transfert Syntax name table
2277 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2278 when they have an actual length (not 0000 nor FFFFF)
2279 (Nobody should care of it, but DICOMDIR explorers)
2281 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2282 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2284 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2285 * ENH: vtkGdcmReader now supports LUT !
2286 (vtkgdcmViewer for now is not able to use them though)
2288 2003-11-05 Jean-Pierre Roux
2289 * in testSuite.py : new files names for checking the package
2290 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2291 that returns the pixel area size to the *aware* (vtk) user
2292 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2294 2003-11-05 Benoit Regrain
2295 * in testSuite.py : Modify the rules for checking the paths
2296 : Explicit error messages
2297 * in __init__.py : Related modif
2299 2003-11-03 Jean-Pierre Roux
2300 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2301 to be used by aware (vtk) users that want to manage
2302 LUT (and no to turn the PALETTE image into an RGB pixels one)
2303 * GetPixelType now returns 8U for 24 Bits images
2304 (vtkGdcmReader compliant)
2306 2003-10-31 Jean-Pierre Roux
2307 * Removal of *all* gdcmData images and add them again
2308 in order to loose the 'history' of un-anonymised images
2310 2003-10-31 Jean-Pierre Roux
2311 * RMV : removal of useless jBitsInJsample.h
2312 for both 8 and 12 Bits JPEG Lossy Libraries
2314 2003-10-31 Jean-Pierre Roux
2315 * ENH : Add the functions gdcmFile::GetImageDataRaw
2316 gdcmFile::GetImageDataIntoVectorRaw
2317 that act as GetImageData and GetImageDataIntoVector
2318 except the making of an RGB Plane from Gray Plane + LUT
2319 Intended to aware (vtk) users who know how to manage
2322 GetLUTRGBA return a R,G,B,A LUT if any
2323 lgrTotaleRaw gives the 'Raw' length
2324 GetImageDataRaw returns the gray Plane
2325 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2326 (They stay Grey, just like with other Dicom viewers :-(
2328 2003-10-30 Jean-Pierre Roux
2329 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2331 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2332 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2333 being coherents dicom files.
2335 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2336 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2338 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2339 * ENH: Two steps is necessary to please VC++ compiler...
2340 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2341 * ENH: Add include dir to medcon lib
2342 * FIX: only one function is being exported for now !
2343 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2345 2003-10-29 Jean-Pierre Roux
2346 * adding gdcmHeader::GetLUTRGBA
2347 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2348 --> Mathieu, the modif u're waiting for is not yet committed
2349 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2351 2003-10-27 Jean-Pierre Roux
2352 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2353 00191113.dcm DermaColorLossLess.dcm
2354 MxTwinLossLess.dcm RadBWLossLess.dcm
2355 * ENH: For version prior to vtkImageViewer2 -r 1.19
2356 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2358 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2359 * Removal of ido stuff in CMakeLists.txt
2361 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2362 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2363 * FIX: remove a call to ->Modified ... see comments
2364 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2366 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2367 * FIX: Problem with path for libvtkgdcmPython
2368 * ENH: Try adding a search script for python site-package
2369 * RMV: Remove some file from medcon lib that are not necessary
2370 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2371 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2372 * FIX: More pragma disable fro VC++,
2373 I don't think I break something as it is also disable in VTK/ITK.
2374 But it fasten debug compilation time.
2376 2003-10-23 Jean-Pierre Roux
2377 * gdcm now deals with 16 Bits Run Length Encoded images
2378 (they are compressed as 2 planes images,
2379 one for the high Bytes, the other for low Bytes)
2381 2003-10-22 Jean-Pierre Roux
2382 * Now CheckRead takes into account :
2383 - the bugged 'Leonardo' Siemens images
2384 - the XA images, sent thru the burning VPRO station
2385 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2388 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2389 * FIX: When copying a Makefile.am to CMakeLists.txt
2390 one should remove the '\'
2392 2003-10-22 Jean-Pierre Roux
2393 * in gdcmData adding a bugged 'Leonardo' Siemens image
2394 (wrong lengths in header)
2395 OK with gdcm, KO with the other viewers :-)
2396 * add a GE dlx XA image, thru the VEPRO burning station
2399 2003-10-21 Jean-Pierre Roux
2400 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2401 for a brutal checking of vtkgdcmViewer compliance
2403 2003-10-21 Jean-Pierre Roux
2404 * add the files for 'xmedcon' Jpeg Lossless library
2405 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2407 2003-10-21 Jean-Pierre Roux
2408 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2410 2003-10-21 Jean-Pierre Roux
2411 * garbage Siemens 'Leonardo' images dealt with
2412 (the patch is easy to remove)
2413 * cosmetic changes to avoid warnings
2415 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2416 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2417 no need to press 'r' now.
2419 2003-10-20 Jean-Pierre Roux
2420 * upgrade of checkRead.sh checkWrite.sh according
2421 to new Jpeg Lossless decompressor
2422 * add US.3405.1.dcm, a genuine RGB medical file ...
2423 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2424 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2426 2003-10-15 Jean-Pierre Roux
2427 * general anonymisation in gdcmData
2428 * adding the 'color files' from
2429 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2430 * adding some well knowed bugged-header images
2431 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2432 waiting for their inclusion in Python testsuite
2434 2003-10-15 Jean-Pierre Roux
2435 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2436 no longer seg faults when file is not found
2438 2003-10-14 Jean-Pierre Roux
2439 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2442 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2443 * TODO: *.in file to genereate a UseGDCM later
2445 2003-10-14 Jean-Pierre Roux
2446 * Some supposed-to-be Dicom Images have no preamble.
2447 OpenFile takes it into account
2448 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2449 * Missing elements added in dicomV3.dic
2450 (just to be affraid : have a look at
2451 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2452 and do it again next year ;->
2454 2003-10-13 Jean-Pierre Roux
2455 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2456 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2457 But there are NOT. It's fixed !
2459 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2460 * FIX: "jpeglib.h" was not found on VC++
2461 * FIX: vtkgdcm was not being installed
2463 2003-10-10 Jean-Pierre Roux
2464 * ENH : OpenFile closes the file if it *really* doesn't look like
2465 an ACR-NEMA / DICOM one.
2466 * FIX : testWrite no longer writes an empty file if the source file
2467 is not gdcm Readable
2468 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2471 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2472 * FIX: CMake generate now documentation
2473 * ENH: out of source doc build !
2474 * ENH: Generate both user and dev documentation
2475 * ENH: Should work on windows too
2476 * ENH: Only one doxygen config.in file is needed
2477 * FIX: make install should be ok now on ùnix plateform
2478 * FIX: PATH to dictionary was wrong (missing /)
2479 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2481 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2482 * vtkGdcmReader is now able to read rgb dicom file.
2483 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2484 * added a gdcmViewer to vtk test, use mouse to control
2485 window level & window width
2487 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2488 * CMake-ification of gdcm, we have now two build system
2489 * FIX: on cygwin Wsock32 doesn't exist
2490 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2492 2003-10-06 Emanuel Ollart
2493 * FIX : compilation process wad broken.
2494 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2496 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2497 * change gdcmViewer -> vtkgdcmViewer
2498 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2500 2003-10-06 Jean-Pierre Roux
2501 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2502 ( e.g : well known GE images with a wrong elem length,
2503 : Philips MRI Images with a wrong Huffman table)
2504 * still to be done : allow the reading of bugged LEONARDO Siemens images
2506 2003-10-03 Jean-Pierre Roux
2507 * Odd length strings are padded with '\0' (not with spaces,
2508 to remain compliant with already defined strings,
2509 like Transfert Syntax UID and others)
2511 2003-10-03 Jean-Pierre Roux
2512 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2513 to allow displaying RGB images (not only by affim ;-)
2515 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2516 * vtkGdcmReader is now able to read rgb dicom file.
2517 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2519 2003-10-03 Jean-Pierre Roux
2520 * A few nasty patches to allow the reading of a lot of nasty images
2521 ( e.g : well known GE images with a wrong elem length,
2522 : Philips MRI Images with a wrong Huffman table)
2523 * still to be done : allow the reading of bugged LEONARDO Siemens images
2525 2003-10-03 Jean-Pierre Roux
2526 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2528 2003-10-03 Jean-Pierre Roux
2529 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2530 to allow displaying RGB images (not only by affim ;-)
2532 2003-10-03 Jean-Pierre Roux
2533 * gdcmFile::GetImageDataIntoVector now
2534 - deals with MultiFrames MultiFragments Run Length Encoded files
2535 - deals with YcBcR (YBR_FULL) files
2536 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2537 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2539 (no sample found :-(
2541 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2542 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2543 Two reasons: - clear things
2544 - third parties acces gdcm through header files, so won't
2545 suffer anymore VC++ complains
2547 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2548 * add argv[1] in testvtkGdcmReader.cxx
2551 2003-09-24 Jean-Pierre Roux
2552 * The lines are now eigthy characters long.for
2553 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2555 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2556 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2557 char* to std::string. Thus, the use of strdup becomes useless. (see
2558 previous commis of Malaterre)
2559 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2560 before the last Malaterre's commit.
2562 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2563 * This commit should fix the Debug building under VC++, the problem
2564 was mainly a mixture of debug and release lib being loaded at startup.
2565 * I also remove a depency to a specific C function: strdup. Because I had
2566 to force the link to msvcrtd (whereas strdup is in libc).
2568 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2569 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2570 located in the gdcmCommon.h file. All use of reference of tha has been
2571 changed to now use the variable GDCM_UNFOUND.
2573 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2575 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2576 Dicom dictionary. The test suite can now be run again. Note:
2577 I'm note very happy with the " (RET)" changes. I believe this
2578 RETAINED comment should be dropped when parsing the dictionary.
2579 - PACKAGER corrected
2581 - AUTHORS updated and now in alphabetical order
2582 * Makefile.am now exports gdcm.dsw for Windoze users.
2584 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2585 * cygwin complains about missing std:: in subdir Test/
2587 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2588 * remove some methods that are now in gdcmHeaderHelper
2590 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2591 * vtkGdcmReader set spacing and origin correctly
2593 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2594 * Fix a few delete/delete[] mismatch
2596 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2597 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2598 interpretation to data given by gdcmHeader. For instance there are
2599 heuristics to get informations (look at different places).
2600 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2601 sorting DICOM images based on different strategies.
2602 * modified Makefiles accordingly.
2604 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2605 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2606 when building in debug mode
2607 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2608 src/win32/gdcmdll.dsp
2609 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2611 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2612 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2615 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2616 * src/win32/libgdcmjpeg12.dsp was not dos format
2617 * src/win32/libgdcmjpeg12.dsp :
2618 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2619 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2621 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2622 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2624 * src/gdcmFile.cxx : bug fix in affectation type
2625 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2626 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2627 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2628 symbols... future problem ?
2630 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2631 * src/win32/libgdcmijpeg12.dsp was missing
2632 * modified gdcm.dsw accordingly
2634 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2635 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2637 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2638 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2639 commit of JPR (before his hollidays to facilitate our work).
2640 * setup.py : bug fix in code. Modifications made while the last commit
2641 of JPR. The code hasn't been tested before the commit... it's so
2642 useless to make that (for best programmer that is JPR) !!!
2644 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2645 * tagged the current version as Version0_3 (i.e. version 0.3)
2647 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2648 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2649 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2650 * *.dsp : modifications to use new libgdcmijpeg8 library
2651 * setup.py : bug fix on VTKPATH variable
2652 * PACKAGER : adding all concerning windows
2654 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2655 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2657 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2658 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2659 test suite reported error.
2660 * PACKAGER file added (describes what a packager must do when
2661 packaging a new release).
2662 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2663 * configure.in: upgraded version number to 0.3.0
2664 * fixing build of rpm (through rpm -ta):
2665 - Doc/Makefile.am exports proper doxygen files
2666 - src/jpeg/libijg8/Makefile.am exports the include files.
2668 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2669 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2670 * src/gdcmHeader.h : formatting code
2672 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2673 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2674 We were obtaining error message from vtk. Now, creation of file list
2675 is made in an internal list to prevent this problem.
2676 Bug fix when output is empty.
2677 Bug fix in update of progress value. Previous commit for this was a bad
2679 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2681 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2682 * src/gdcmHeader.h : added method to get the file name
2683 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2684 files. Added method to remove all files on the input
2685 Added FIXME comment concerning the bad parsing of header made by
2686 ExecuteInformation method (in ExecuteData method)
2688 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2689 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2690 when using make instal.
2691 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2692 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2694 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2695 * setup.py : adding include dir of jpeg lib to compile all sources
2696 * */Win32/*.dsp : JPR fix for windows compilation
2698 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2699 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2701 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2702 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2704 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2705 * setup.py is again effective on un*x (takes into account the
2706 addon of the jpeg library)
2707 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2708 * Doc/Doxy* updated (includes above enhancements)
2709 * INSTALL now points to web documentation
2711 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2712 * src/gdcmHeader.h doesn't make unnecessary reference to
2714 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2716 * src/gdcm*.[cxx|h] :
2717 - to allow compilation with gcc 3.x
2718 -- clean up of STL usage (added explicit usage of std::)
2719 -- small fixes on exceptions.
2720 Note: linking not tested !
2721 - clean of doxygen comments to avoid warnings at documentation
2723 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2724 dependent convertion).
2726 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2727 * Clean up of previous JPR garbage commit (not even commented in the
2729 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2730 - moved all jpeg related files from src to src/jpeg/libijg8, with
2731 addition/modification of Makefile.am and configure.in.
2732 - the testSuite is still brain damage (not guilty).
2734 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2735 * WrapVTK.py : modifications to get correctly vtk source files to
2737 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2738 (FileName -> Filename)
2740 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2741 * vtk/vtkGdcmReader.[cxx/h]:
2742 - UpdateProgress method should now be effective
2743 - removed the limitation on having only images loaded (as opposed
2745 - when building a stack of images/volume, a lesser number of
2746 gdcmHeader and gdcmFile instances should be used (hopefully
2747 accelerating things).
2748 - when building a stack of images/volumes, files which are not
2749 loadable (wrong path-filename, wrong permissions on existing file,
2750 or file not parsable by gdcm) are replaced with a black image
2751 in the stack (for the caller to notice the problem).
2753 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2754 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2756 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2757 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2758 between standard library (std) and vtk library (problems are found
2759 under Windows... thanks Windows !)
2761 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2762 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2764 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2766 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2767 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2769 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2770 * When compiling with distutils (see setup.py) the C++ compiler is
2771 called with different flags than the default ones (with automake).
2772 In order to fix all those warning, I compiled gdcm with the command
2773 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2774 and went for warning fixes:
2775 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2776 up from unused variables.
2777 - vtk/vtkGdcmReader.cxx: potential bug fix.
2778 * src/gdcmHeader.h: Doxygen warning cleanup
2780 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2781 * gdcmPython/gdcm.i:
2782 - typemaps correction to take into account the systematic replacement
2783 of "using namespace std" with std:: prefix e.g. std::list,
2784 std::string... (cf changes of 2003-05-21).
2785 - gdcmGlob global variable of type gdcmGlobal (defined in
2786 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2787 exported to Python a as cvar.
2788 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2789 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2790 gdcmDictSet.GetPubDictTagNames() and
2791 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2792 C++ static methods).
2793 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2794 with the above changes.
2796 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2797 * setup.py, manifest.in : bug fix under linux
2799 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2800 * Modification of setup.py to compile vtk part too. Then, we have 2
2801 wrappers which must work with same distutils. For that, we have a
2802 generic distutils in distusiltsWrapping.py ; with :
2803 - build_extWrap class to wrap generically all extensions,
2804 - ExtensionWrap base class for all wrapping extension that contains
2806 - Wrapper interface which wrap sources
2807 + In WrapSwig.py we have extension and wrapper for Swig
2808 + In WrapVTK.py we have extension and wrapper for VTK
2809 * MANIFEST.in : modifications to consider vtk directory and new python
2810 files for compilation
2812 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2813 * Added python wrappers of vtkGdcmReader vtk class (see the
2814 source in vtk/vtkGdcmReader.cxx) :
2815 - vtk/Makefile.am now builds a library
2816 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2817 python library (as opposed to _gdcm.so wich are the python
2818 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2819 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2821 - configure.in has an additional flag --enable-vtk that needs
2822 to be set to enable compilation of vtk related code, that is:
2823 + vtk/vtkGdcmReader.so and
2824 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2825 + gdcmPython/vtkgdcmPython.so (see above)
2826 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2827 be read when compressed or when HighBit + 1 != BitsStored),
2828 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2829 the usage of the python wrapper of vtkGdcmReader vtk class.
2830 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2831 * src/*.[h] all occurences of stl classes are now prefixed with
2832 std::, and all occurences of "using namespace std;" where removed.
2833 This is to avoid pollution of global namespace in included files.
2834 Apparently vtk does not avoid this pitfall: when using both
2835 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2836 collision of various stl members (principally cout...).
2837 * gdcmPython/testSuite.py now cleanly removes temprory generated
2839 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2840 comply with above changes)
2842 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2843 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2844 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2845 vtk data structure (an image Flip was required).
2846 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2847 * cosmetic changes in documentation.
2849 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2850 * src/gdcmHeader.cxx: the constructor no longer exits when an
2851 unexisting file is given as argument.
2852 * The subdirectory Data (containing all the images used for the
2853 test suite) is not part of this repository anymore. A new module
2854 containing those images is now available at
2855 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2856 with the name gdcmData.
2857 All the python scripts (including the package initialisation file
2858 gdcmPython/__init__.py) were adapated to take this change into
2859 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2861 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2862 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2863 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2864 demo of the usage of this class.
2865 Compilation of this vtk part is only done when using the --enable-vtk
2866 at configure (or autogen.sh) stage.
2868 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2869 * More memory link related corrections and documentation fixes.
2871 - maximum info is obtained with a command of the form:
2872 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2873 --show-reachable=yes PrintHeader
2874 - the remaining reachable blocks seem to come from the STL
2875 allocation scheme through the usage of map and list. It looks
2876 like this memory cannot be freed but it is not a memory leak
2877 (in fact further invocation to the STL would recollect the
2878 unused memory allthough it cannot explicitely be freed).
2879 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2880 of displaying an image parsed with gdcm and displayed with VTK.
2881 Note: some images don't seem to work e.g.
2882 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2883 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2884 Allthough this weakens the semantics, it is a ditch attempt to
2885 make gdcm more thread friendly.
2887 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2888 * Memory link hunt (by using valgrind through the command
2889 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2890 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2891 gdcmHeader::_dicom_vr.
2892 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2893 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2895 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2897 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2898 * src/Makefile.am now exports all the necessary include files at
2902 * UpdateGroupLength replaced by new one
2905 * UpdateGroupLength re-written using H-Table
2906 (named UpdateGroupLengthNew untill checks are over)
2908 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2909 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2910 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2912 - gdcmHeader::GetPubElValSet removed.
2913 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2914 UpdateGroupLength, WriteElements, Write.
2915 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2916 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2917 carried the same semantics.
2918 - src/gdcmHeaderIdo.cxx changed accordingly.
2919 - gdcmFile::WriteBase now regroups all the codes from previous
2920 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2921 - enum FileType moved to gdcmCommon.h
2922 * src/gdcmHeader.cxx AddDefault trashed
2923 * gdcmGetXSize added
2924 * getimageDataSize now calls gdcmGetXSize
2925 * Test/*.cxx changed to agree with above changes
2927 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2928 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2929 (to avoid double call by end user).
2930 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2931 by end user, since gdcmHeader::gdcmHeader now handles it.
2933 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2934 * gdcm/Doc many doxygen changes:
2935 - Doxyfile now has two different versions, DoxyfileUsers that generates
2936 the html.users end users oriented documentation and
2937 DoxyfileDeveloppers that generates the html.developper developper
2938 oriented documentation.
2939 - README changed accordingly
2940 - requirement.txt removed (old design info moved to TODO).
2941 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2942 DoxyMainPage.txt, DoxyPython.txt provide more information.
2943 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2944 be updated by simply regenerating the docs with doxygen and copying
2945 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2946 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2947 all the tests in the form "if (<map>.count() >1)" were removed.
2948 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2949 ill-formed documentation sections.
2950 * src/gdcmHeader.cxx: ditto
2952 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2953 * setup.py fixed for un*x (needed macro for stdint.h)
2954 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2955 un*ces with sh-utils test utility.
2956 * gdcmPython/demo/test.py renamed to PrintHeader.py
2957 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2958 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2959 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2960 * src/gdcm*.cxx JPR's bad inclusion fixed.
2962 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2963 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2964 * gdcmPython/demo/test.py changed accordingly.
2966 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2967 * gdcmPython/Makefile.am fixed linking against libstdc++
2968 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2969 * Swig subdir (historical tests of swig version 1.3.17++) removed
2970 * Test/testChangeEntete.cxx some lines commented out in order to make
2972 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2973 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2975 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2976 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2977 hence the user doesn't need this explicit call.
2978 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2979 i.e. LoadElements() call removed.
2980 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2981 - src/Makefile.am declares the proper flag for g++.
2982 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2983 for adding user defined new tags.
2984 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2985 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2986 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2988 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2989 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2990 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2991 src/Makefile.am : the project should properly compile and install
2992 with the autotools, included the python wrappers part.
2993 * gdcm.spec.in : added a spec file for RPM packaging.
2995 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2996 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2998 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2999 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3000 to exported to the environement (see gdcmPython/testSuite.py
3002 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3003 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3004 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3005 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3006 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3008 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3009 * gdcmPython/__init__.py doesn't crash anymore when running in
3010 in InstallMode or PreInstallMode but with an environment given
3011 value of GDCM_DICT_PATH.
3012 * src/gdcmDictSet.[cxx/h] coding style.
3014 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3015 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3016 * src/gdcm.h general comments moved to TODO, and README
3017 * src/gdcm.h should now be seen as a user commodity (including it
3018 should suffice to fully use gdcm). It is nowhere including within
3019 any of the kernel files src/*.cxx and src/*.h.
3021 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3022 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3023 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3025 * src/gdcm*.cxx only include their corresponding include file
3026 (as opposed to gdcm.h)
3027 * gdcmPython/gdcm.i changed accordingly
3028 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3029 the autogen.sh generated "make snapshot" command to work.
3030 * autogen.sh removed history related references to crea package.
3032 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3033 * distutilsSwigCPlusPlus.py work around some swig portability
3036 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3037 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3038 was done in a last ditch attempt to get setup.py _really_
3039 operationnal. The python/gdcmPython layaout add the advantage
3040 of hidding away the python related distutils specific files
3041 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3042 Alas, the src directory was out of scope (i.e. it's relative
3043 position to setup.py was ../src) which made things impossible to
3044 handle (see previous version of python/setup.py). Crossing fingers...
3046 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3047 * python/setup.py now works on Un*x. (harder than I thougth)
3048 * python/distutilsSwigCPlusPlus.py can now have include files
3049 among the list of sources.
3051 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3052 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3053 * modifications in MSVC projects
3055 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3056 * As stated by the first lines of Test/ExceptionAndPython/README, it
3057 looks like we can move back to original usage of exception within
3058 src/gdcm* and hence remove the errno stuff that was introduced
3059 as a quick and dirty fixture of this problem (added to the TODO).
3060 * Doc/Doxyfile configuration file for Doxygen and corresponding
3061 README file for usage added.
3062 * Test/testWrite.cxx added. This new test comes from a split of
3063 test.cxx that is now reverted to its original purpous i.e.
3064 testing the proper parsing of a Dicom related file.
3065 testWrite.cxx concentrates on testing the IO part of gdcm.
3066 * Test/bug1.cxx (containing a bug on WIn32) added.
3067 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3068 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3069 whose purpose is to publish the content of the TagNames of the
3070 Dicom public dictionary were not accessible without an
3071 instance of class gdcmHeader.
3072 - those methods are now static methods of gdcmDictSet and hence
3073 require no instances at all to be invocated.
3074 - within gdcmDictSet this change required to change some method
3075 to class methods (i.e. are now static) among which SetDictPath
3076 (renamed to BuildDictPath) and LoadDefaultPubDict.
3077 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3078 the above changes by calling the new method classes of gdcmDictSet.
3079 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3080 the above to be effective.
3081 * python/gdcmPython: in order to wrap properly the above changes
3082 for Python, swig version now needs to be > 1.3.17.
3083 * python/gdcmPython/Makefile fixed to adapt itself to new
3084 configure/make shema introduced by Johan Montagnat (thanks for the
3085 contribution). Alas this Makefile cannot be turned into a proper
3086 Makefile.am without some heavy changes in the configure.in
3087 (for python dectection).
3088 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3089 now avoids publishing the empty entries.
3091 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3092 * python/setup.py : bug fix concerning install under windows
3093 ExtraPath reused :-P
3094 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3096 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3097 * Dicts/dicomV3.dic : remove double spaces !!!
3098 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3099 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3102 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3103 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3104 method. Doxygenation.
3105 * src/gdcm.h clean up of JPR spurious comments.
3107 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3108 * python/distutilsSwigCPlusPlus.py now properly collects the
3109 shadow classes generated by "swig -c++" (gdcm.py in our case)
3110 when using "python setup.py install".
3111 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3112 reexports the working classes.
3113 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3114 by the classical C errno scheme. This is to prevent an obscure
3115 behavior of the python wrappers when importing wxPython.wx prior
3116 to gdcmPython (which ended up in an abort call). An illustration
3117 of this oddity can be found in the Test/ExceptionAndPython
3118 subdir (see the README file). This problem probably due to
3119 an combination of g++ and dynamic loading.
3120 * added Test/ExceptionAndPython (see above)
3122 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3123 * Changed the layout of the python part to avoid bloating main
3124 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3125 i.e. the distutils arsenal. All the python related stuff is
3126 again in a python subdir, but the package itself is now in
3128 * setup.py was cleaned up:
3129 - pythonIncludePath removed
3130 - python setup.py bdist target is now functional.
3131 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3132 collision with other packages). gdcmPython/demo/*.py changed
3135 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3136 * python subdir moved to gdcmPython (preparation of distutils packaging).
3137 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3138 distutils installer is operational.
3139 * - gdcmPython/__init__.py now properly loads the swig generated
3140 shadow classes (from gdcm.py).
3141 - gdcmPython/demo/*.py changed to import the package gdcmPython
3142 instead of gdcmPython/demo/load.py.
3143 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3145 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3146 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3147 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3148 entries within the associated public Dicom dictionary resp. the same
3149 information but sorted by the fourth field (PAT, IMG, DIR) of the
3151 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3152 are now in the "???" group.
3153 - python/gdcm.i changed accordingly,
3154 - python/demo/printGroupedPublicDict.py added, that gives an example
3155 of the above new functionalities in Python.
3157 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3158 * src/gdcm.h, gdcmHeader.cxx:
3159 - historic references to glib's g_malloc and g_free (#defined)
3160 were definitively removed.
3161 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3162 * src/gdcmElValSet.cxx:
3163 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3164 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3165 - GetElValue(string) renamed to GetElValueByName.
3166 - Added GetElementByName(string).
3167 * src/gdcmHeader.cxx: added
3168 - GetPubElValRepByNumber(guint16, guint16)
3169 - GetPubElValRepByName(string)
3170 - GetShaElValRepByNumber(guint16, guint16)
3171 - GetShaElValRepByName(string)
3172 - GetShaElValByNumber(guint16, guint16)
3173 - GetShaElValRepByName(string)
3174 - GetElValRepByNumber(guint16, guint16)
3175 - GetElValRepByName(string)
3176 - GetElValByNumber(guint16, guint16)
3177 - GetElValRepByName(string)
3178 * Doc/requirements.txt added.
3180 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3181 * Test/Makefile building now depends on the one of libgdcm.so
3182 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3183 pixel data) aware which enables finding the address (offset) of
3184 the pixel data of JPEG encoded DICOM files. This leaves only a single
3185 file in the testSuite whose pixel data address (offset) is unknown.
3186 * python/testSuite.py changed accordingly.
3188 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3189 * VC++ has some strong limitations when working with the STL, as stated
3190 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3191 "Also note that some STL containers (map, set, queue, list, deque)
3192 cannot be exported. [...]
3193 Some STL classes contain nested classes. These classes can not
3195 This is caused by a designed limitation that once a template
3196 class is instantiated, it can not be re-instantiated and
3198 Since our usage of map<> is ubiquitous in gdcm, this "designed
3199 limitation" of VC++ is a pitfall.
3200 Hence the Python wrappers of gdcm cannot be incrementally linked
3201 against the c++ dynamic library. The dirty but only workaround is
3202 to forget about incremental link of dynamic libraries and to generate
3203 the Python wrappers library with the inclusions of the underlying C++
3205 The following modifications concern this matter on Win32/VC++:
3206 - wrapping python correct with standalone wrapped dll (don't use separate
3207 dll under windows !!!!)
3208 - python21_d debug mode enabled (ask Frog how to use it :-)
3209 - NO problem with having an STL member of class for example string in C++
3210 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3211 - Python test of dcmlib in Python is ok under windows on a large set
3213 * removed glib references
3214 * typedef's inserted in gdcm.i for correct swig type management
3216 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3217 * python/demo/*.py load.py extracted from test.py. Added explore.py
3218 that only displays required tags and testAll.py that parses all
3219 the files of the testsuite without using unittest.
3220 * python/testSuite.py other additional test on new files added.
3221 * Data/* new test files added accordingly to the testSuite.
3222 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3223 the vr in the file differs from the one of the dictionary.
3225 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3226 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3227 values, but limits itself to values which are below a user specified
3228 size (by default 1024 bytes).
3229 * python/gdcm.i : elements not loaded (because their size is above the
3230 user specified treshold) are exported with their TagKey as key of the
3231 python dictionary. This enables the testsuite to make some checks
3232 on the unloaded elements (since we have their offset and size).
3233 * python/testSuite.py
3234 - now tests for the existence and proper value of the pixel data
3235 - two new examples added.
3236 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3238 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3239 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3240 aware. See the strategy comments in gdcmHeader::FindLength().
3241 * Test/test.cxx now accepts a filename as first argument.
3242 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3243 * python/testSuite.py changed to integrate test on above files.
3245 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3246 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3247 the vr was also RET.
3248 * python/testSuite.py more tests added.
3250 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3251 * python/testSuite.py unittest test suite added (uses Data)
3252 * Data/* dcm and acr files for the test suite.
3253 * glib dependance removed from un*x version. We now use ISO C99
3254 7.18 Integer types (see stdint.h)
3255 - python/Makefile, src/Makefile src/gdcm.h
3256 * src/ when an explicit vr (like dicom files) suddenly poped an
3257 implicit element we use to mark the underlying DictEntry of the
3258 concerned ElValue with "Implicit". This strategy was damageable
3259 too the public or provite dictionaries, since some of their vr
3260 would be changed. Since Header::FindLength heavily relies on the
3261 detection by Header::FindVR of falsely explicit elements, I
3262 added an extra ImplicitVr member to ElValue (boolean).
3263 The rest of the changes we the necessary adaptations.
3265 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3266 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3268 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3270 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3271 * Adaptation for porting to VC++:
3273 o forced to use std namespace (for string to be known)
3274 o all class use __declspec export style on WIN32
3275 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3276 (in stdlib.h on Win32 but in std:: for gcc)
3277 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3278 variable GDCM_DICT_PATH.
3279 * src/gdcmHeader.cxx verbose comments made discrete.
3281 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3282 * python/gdcm.i: added a typemap that converts a C++ hashing table
3283 to native Python dictionary.
3284 * python/demo/test.py:
3285 - now uses the native dictionary for exploration of gdcmHeader.
3286 - takes an optional filename argument (the file to parse).
3287 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3288 PubElVals hashing table.
3289 * Dicts/dicomV3.dic removed error prone trailing spaces.
3291 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3292 * Python wrapping process moved away from src/Makefile to
3293 newly created python/Makefile (as well as gdcm.i)
3294 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3295 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3296 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3297 from the environement variable GDCM_DICT_PATH (when existing).
3298 * src/gdcmDict::GetTag bug fix.
3300 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3301 * Straightforward temporary fixes for swig to build the python wrappers.
3302 src/Makefile now has a python working entry [by working we mean
3303 that we can import the shadow classes without errors].
3305 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3306 * hashtest.cxx removed (since already in Test)
3307 * src/gdcmlib.h renamed to src/gdcm.h
3308 * src/dcm.i renamed to src/gdcm.i
3309 * src/Makefile prepared for python wrapping
3311 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3312 * src/gdcmHeader.cxx :
3313 - Parsing of header is now separated from loading of element values
3314 (see gdcmHeader::LoadElements).
3315 - general clean up of hopefully all file access (creation of
3316 ReadInt16 and ReadInt32)
3318 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3319 * src/gdcmHeader.cxx :
3320 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3322 - SetLgrElem renamed to SetLength
3323 - GetLgrElem renamed to GetLength
3324 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3325 * src/gdcmElValSet.cxx fixed both GetElValue methods
3326 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3327 due to IdoDude was cleaned out.
3329 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3330 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3331 concentrates on finding the value representation (when it exists).
3332 RecupLgr now only finds the element value length, and it avoids
3333 returning the unecessary skL (skipped length).
3334 Also, offsetCourant was simply removed (with taille_fich) since
3335 it was redundant with the File position internals (by using
3336 ftell and fseek). This also made skL (see above in RecupLgr) usage
3338 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3339 on the libido specificities which are handled through class
3341 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3344 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3345 * Truckload of changes. Parsing of header is barely functional
3346 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3348 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3349 * src/gdcmHeader.cxx many addons of low level methods
3351 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3352 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3353 and _IdDcmSWAP_LONG.
3355 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3356 * This corresponds to all the changes decided at the meeting of
3357 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob