1 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
4 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * src/gdcmUtil.cxx : compilation fix on Win32
6 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
7 variable, to be easy found. Add methods to change the default UID.
8 Amelioration of the CreateUniqueUID to use the correct default UID.
9 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
12 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * Test/TestVR.cxx : fix memory leaks
15 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
16 * Rewrite the base 256 to base 10 conversion, using string operation only.
17 This allos us to get rid of the problematic 64bits integer type (does not
18 alwyas exist on target platform).
20 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
21 * Add construct and destructor to class gdcm::Debug to close the debug file
23 * Don't let uset to open twice the same file
24 * gdcm has now an official UID prefix,
25 supplied by http://www.medicalconnections.co.uk
26 1.2.826.0.1.3680043.2.1143
27 (Thx to Mathieu for providing URL)
28 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
29 to be able to perform some more tests
30 * gdcm::ContentEntry : Contructors and Destructor are now protected,
31 in order to be sure no user will try to use them.
32 (at user level, only the children classes are meaningfull)
34 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * move RLEInfo & JPEGInfo from Document to File
37 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * FIX : remove so many friend between classes
40 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
42 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
44 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
45 In order to avoid missbehaviour :
46 . gdcm::DocEntry is now specialized in
47 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
48 - gdcm::ContentEntry (Dicom entry with a 'content')
49 . gdcm::ContentEntry is specialized in
50 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
51 characters value, or integers)
52 - gdcm::BinEntry (Dicom entry with a non strig representable value
53 (user hasn't any longer to thing about the precedence of his dynamic_casts)
55 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * Test/VTKTest*.cxx : bug fix under linux
58 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
59 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
60 use with python. Some methods are moved from Document to ElementSet or
61 DocEntrySet. The equivalent methods to ElementSet have been added to
62 SQItem and are virtual in DocEntrySet. Methods that may have the same code
63 in SQItem and ElementSet is directly placed in DocEntrySet
65 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * Test/VTKTest*.cxx : remove the show variable in each test method because
67 it's useless (the viewer variable replace this variable)
69 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * src/gdcmDocument.cxx : bug fix on potential memory leak
71 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
72 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
73 Add ClearXxx methods to remove all the content of the list or map
74 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
76 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
77 * methods ReplaceOrCreate renamed as Insert
78 (nobody will be any longer confused by 'CreateOrReplace')
80 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
81 * Grealty simplify the JPEg decompression, no need to differenciate based on
82 the JPEG possible type (with/without fragment, with/without multiple frame).
83 Everything is done throught the JPEG IO Suspension mechanism in IJG
85 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
86 * Stage 3 of normalization :
87 in order to avoid any missunderstanding while reading method names :
88 - All the methods xxxEntry now deal with dicom Entries
89 - Methods GetEntry splitted into
92 - Method SetEntry renamed as SetEntryValue
93 - Method SetEntryBinArea let as it was
95 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
96 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
97 - Position correctly the entry points for JPEG2000 and JPEG-LS
98 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
100 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
102 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
103 with other method names
104 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
105 * Test/TestDicomDirElement.cxx : add new test
107 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
108 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
109 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
110 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
111 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
112 So can't you use __int64 in ostream at all.
114 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * bug fix for compilation on MSVC6
116 * gdcmPython/gdcm.i : rename of classes missed
118 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
119 * Stage 2 of names normalization :
120 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
121 (easy to understand ...)
122 - gdcm::FileHelper replaces old class gdcm::File
124 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
126 type and not a string. So, there remove problems on the format of the
129 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
130 * Add Example/TestPapyrus.cxx
131 - reads a Papyrus file (gdcm::Header compliant),
132 - gets the pixels of all the images, using low level iterators
133 - writes an multiframes Dicom image.
134 (Just to show it's *possible* to do that)
135 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
138 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
139 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
140 Thus, DicomDirXXX are created with a flad that indicates if the created
141 object is empty or not (when not empty, the DicomDirElement is used to
144 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
145 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
146 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
148 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
149 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
151 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
153 Remove all access to the hash-tables or lists in the objects.
155 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
157 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
158 be complient with all the gdcm source code
160 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
164 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
168 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * Test/ : rename VTK tests to have a best name for the tests
170 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
171 GetFirstEntry/GetNextEntry use
173 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
174 * In SerieHeader::ImagePositionPatientOrdering()
175 // a Dicom 'Serie' may contain scout views
176 // and images may have differents directions.
177 // -> More than one may have the same 'pos'
178 // Sorting has then NO meaning !
179 Thx to Eduardo Davila for reporting bug.
181 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
183 test. Now it's on image content and not on the resulting visualisation...
184 might solve the problem on linux when using the OpenGL drivers
186 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
187 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
188 DicomDirSerie, DicomDirImage
189 Dict, DictSet classes :
190 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
191 -remove InitTraversal method.
192 * UPD Test programs + Example programs
194 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
195 * remove useless and never updated keyword \ingroup
196 * Solve pb when structure (list, map, ...) is empty.
197 Thx to Benoit for reporting bug
199 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
200 * Taking into account of 'Transfer Syntax' value
201 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
204 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
205 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
206 is no memory access violation
207 * gdcmPython/demo : add python demos using VTK
209 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
210 * FIX 'Dictionnary' is now spelt 'Dictionary'
211 'wether' is now spelt 'whether'
212 'archieve' is now spelt 'archive' ;-)
214 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
215 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
216 related methods, in order not to expose internal mechanisms
219 * REM methods that exposed internal mechanisms :
220 DicomDir::GetDicomDirPatients()
221 DicomDirPatient::GetDicomDirStudies()
222 DicomDirStudy::GetDicomDirSeries()
223 DicomDirSerie::GetDicomDirImages()
224 * UPD Test programs :
228 * UPD Example program
230 * ADD DictSet methods
234 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
235 * Removed the Print/indent/default parameter mess. There is absolutely no
236 reason to have to methods, moreover with the second taking the ostream as
237 *SECOND* parameter. This was clearly a bad hack to get things compile.
239 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
240 * Complete rewrite of the GetMacAddress code. Now the code is *much*
241 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
242 Unfortunately the main code does not work on SunOS, thus provide a specific
243 code for this platform only (and Win32 of course). Since this seems to be
244 working, change CreateUniqueUID to use GetMACAddress instead of the
245 problematic GctestetIPAddress
247 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
248 * Unfortunately to be able to test gdcmDirList I had to break the API
249 a little. Now the class is not a std::list anymore but has a member
250 std::vector (more ITK compatible). Allow unit testing on Win32 and
253 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
254 * Update SerieHeader to take into account a Serie Instance UID to properly
257 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
258 * ENH - Comment out Mathieu's (dangerous) Super Hack
259 for dealing with BIGENDIAN processors
260 - Move equivalent stuff to BinEntry::WriteContent
261 When necessary, 16 Bits Pixels are swapped in a small buffer
262 and then written. This avoid allocating a huge buffer, in
263 PixelWriteConvertor, and avoid modifying the Pixel Area.
265 Probabely, the same operation will have to be done when we want
266 to write image with Big Endian Transfert Syntax,
267 and we are working on Little Endian Processor
269 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
272 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
273 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
274 all the dict content.
275 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
277 * Test/TestDict.cxx : add a new test for the dict classes
279 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
280 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
281 file. Debug is yanked if compiled with NDEBUG
283 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * src/gdcmDictSet.h : set the default output to the os variable
285 * src/gdcmDictEntry.[h|cxx] : add the Print method
286 * gdcmPython/demo/ : add a new test
288 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
289 * merging of Test/PrintDicomDir and Test/TestDicomDir
290 * removal of now redundant Test/PrintDicomDir
291 * enhancement of Example/PrintDicomDir
293 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
294 * Now, python test might work on systems
295 * Add the PrintDicomDir test
297 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
298 * FIX : First entry following group 0002 was lost for
299 Explicit Big Endian Transfer Syntax files
300 (group and elem not swaped)
302 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
303 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
304 Big Endian Transfer Syntax supposed the group following 0002
305 begins always by element 0000 (element 0000 is *optional*)
306 To avoid further troubles, let's be pessimistic, and use
307 Document::HandleOutOfGroup0002() method
308 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
309 (related pb not yet solved)
311 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * Bug fix for the python part use
313 * Now, PrintHeader.py pass... but outside the ctest use. shit !
315 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
318 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
319 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
320 a string and should ask the global TS dict what are the propreties of
323 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
324 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
325 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
326 to swap the Swap Code, at parsing time, when we come out of group 0002
327 and Transfer Syntax is Big Endian
328 We should be able to read now 'true DICOM" Big Endian coded images
329 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
330 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
332 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
333 * Hopefully fix the bug on MacOSX and static global initialization.
334 This is the only -minor- patch I found that both please MacOSX and VS6.
335 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
336 but this would require a lot of change. Another approach would be that Global
337 create those string and GDCM_UNFOUND becomes a pointer to a string (which
338 gdcm::Global would destroy at exit).
340 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
341 * Fix bug on MacOSX with static initialization in a multy threaded
342 environment. static const string in a header file used to be ill
343 initialized provoquing the freeze of any tests. patch should solve this
346 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
347 * According to Benoit's suggestion, and without any objection from anybody
348 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
349 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
350 - method gdcmDicomDirObject::GetEntry() renamed as
351 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
353 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
354 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
355 you debug/warning message just as c++ streams which make them very convinient
356 to use. Once this is stabilize I will change the ostringstrem to be
357 redirected to a file (ofstream).
358 * Properly support C99 extension: __FUNCTION__ which allow us to display
359 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
361 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
362 * Removal of useless and dangerous methods :
363 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
364 GetDocEntryByName, GetEntryByName, GetDictEntryByName
365 * Removal of usless methods :
366 Dict::PrintByName, Dict::GetDictEntryByName
367 * Commenting out of probabely useless methods :
368 Dict::GetDictEntryNames()
369 Dict::GetDictEntryNamesByCategory()
370 DictSet::GetPubDictEntryNames()
371 DictSet::GetPubDictEntryNamesByCategory()
372 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
373 * ENH : Use dicomTS.dic as described in 2004 version
374 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
375 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
376 Add Accessors on VM (Value Multiplicity), and VM related methods
377 * ADD : Add a list of 'Dicom Attribute types', as found in
378 http://medical.nema.org/dicom/2004/04_15PU.PDF
380 * ADD : Add dicomGroupNameAbbreviations.dic
381 should be used to write a method to replace the former
382 Dict::GetDictEntryNamesByCategory()
384 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
385 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
386 to read in the file... and only it ! Length is the efective length of the
387 data in the DocEntry structure
389 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
390 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
391 And now use a static function call instead, with a global variable. i
392 This is much closer to the VTK approach. Hopefully should be bulletproof
393 and easier to use...hopefully
395 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
396 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
398 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
399 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
401 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
402 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
403 ValEntry, BinEntry, SeqEntry creation or replace
405 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
406 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
407 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
409 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
410 when specifying the VR
411 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
412 * src/gdcmDocEntry.cxx : amelioration of print
414 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
415 * ADD : Add the method Util::IsCurrentProcessorBigEndian
416 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
417 * ADD Method Document::ComputeGroupLength
418 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
419 in order to allow further VR modification by user
420 * REM : removal of once-called method File::WriteBase
421 integration of its code in formerly one-line method File::Write
423 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
424 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
425 replace the different values "??", "Unkn", "Unknown".
426 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
427 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
428 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
429 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
431 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
432 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
434 * Set the gdcm::Base class to some Printable classes
436 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
437 * src/gdcmFile.[h|cxx] : add the Print method
438 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
439 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
440 * src/gdcmDocument.h : remove the PrintLevel informations
441 * Example/PrintFile.cxx : use the new gdcm::File::Print
443 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
444 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
445 problems when compiling with the python wrapping
447 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
448 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
449 writting in ImplicitVR
451 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
452 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
453 JPEG decompression, especially when dicom frames are split into several
454 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
455 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
457 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
458 * src/gdcmHeader.cxx : change the initialisation of default header.
459 Now, this header is readable by gdm, e-film, DicomWorks
461 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
462 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
463 Rename Decompressed to Raw
464 * Use the API changes in gdcm::File.
465 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
468 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
470 each added entry in the header. Replace the 'Planes' field by the 'Number
473 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
474 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
475 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
477 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
478 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
479 At this time, this image isn't readable by e-film... waiting JPR help to
482 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
483 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
484 DocEntry. Now use methods of the Document !
486 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * Test/ShowDicomSeq.cxx : bug fix
489 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
490 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
491 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
492 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
493 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
495 * Test/TestCopyRescaleDicom.cxx : remove unused variable
496 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
497 containing found sequences
499 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
500 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
502 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
503 Some fields in BinEntry must be copied to not seg fault when making the :
504 gdcm::File *copy = new gdcm::File( copyH );
505 and tests are now made on good variables
507 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
509 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
511 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
512 * Add vtkGdcmWriter example and test
514 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
515 * Test/TestUtil.cxx : reformat the source code
516 * vtk/vtkGdcmReader.cxx : remove and change prints
517 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
519 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
520 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
522 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
523 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
524 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
526 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
527 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
528 by an eof to prevent all bad read of the file... and in this case, the
531 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
532 * Example/Volume2Dicom.cxx : comment unused variables
533 * Test/PrintDicomDir.cxx : comment unused variables
534 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
535 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
536 method that is redondant with AddEntry.
537 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
540 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
541 * Bug fix due my last commit (compilation under Windows).
542 * Example/Volume2Dicom : bug fix in the file and reformatting source code
543 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
545 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
547 - Remove printf / sprintf
548 - include iostream AFTER gdcm so we don't get warnings
549 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
551 - Also remove tons of include from header files, hopefully this should
552 speeup the compilation time, since it was becoming a dog slow.
553 - Remove gdcm.h as it include way too many files and slow down compilation
554 (plus it is not up to date)
555 - remove 'using namespace std' this is BAD !
557 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
558 * Remove memory leaks on the DicomDir
559 * Remove some useless data in DicomDirObject
560 * Add usefull methods in SQItem, to be complient withe the ElementSet
562 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
563 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
565 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
566 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
567 future, with convertion)
568 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
569 and ImageDataSize values. Remove the method to get the PixelReadConverter
570 from the output of the class
572 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
573 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
575 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
576 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
577 and vtkErrorMacro use.
578 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
580 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
581 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
583 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
584 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
585 The string leaves only in the fonction. So when we make a .c_str(), we
586 get the pointeur on the first element, element that will be destroyed
587 immediately after thee instruction.
588 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
589 file has been opened : the test must be made on the content of the
590 pointer and not directly on the pointer !
593 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
594 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
595 the python part recompiles
597 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
598 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
599 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
600 X session is killed (for my computer... it seems to not be identic on
603 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
604 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
605 avoid problems (otherwise, the difference test between the visible image
606 and the reference is incorrect. If the reference is greater than the
607 screen resolution, it's produce errors).
608 Can be used for only one image. Can be used with a visible flag.
609 * vtk/vtkGdcmReader.cxx : remove commented codes.
610 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
611 under windows at compilation
612 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
614 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
616 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
617 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
618 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
619 tests on the image size X, Y, Z
621 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
622 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
623 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
624 between the class name and the file name
626 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
627 * src/ : fix compilation warnings for the Write method (2 different
628 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
629 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
630 variable... create a static method in gdcm::Document to access to
631 this variable content.
633 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
634 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
635 file, to be accessed by other files (like gdcmFile). Remove commented
636 code. Move the change of the header to the gdcmFile, using the
638 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
639 To be sure of that (and simplify calls), the Write of the header now
640 gets a file name and not a file pointer (std::ifstream).
641 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
642 DocEntryArchive. Remove all open of the written file
644 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
647 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
648 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
649 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
651 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
652 some corresponding methods. Write correctly the file and check before
654 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
655 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
656 is now on RGB data (as before my last commit
657 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
659 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
660 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
661 Add a print information of the type of the entry
662 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
663 It was in the gdcmFile, and all write have been regrouped
664 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
665 Write correctly all dicom files (in decompressed mode only at this time)
666 * Test/ : test on files are now made using Raw data and not color data if
668 * Example/PrintFile.cxx : add more printings
670 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
671 * Amelioration of code, remove some code copy. For the loading of
672 BinEntry (in gdcmDocument), add the test to verify if the file is already
675 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
676 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
677 remove a DocEntry in the header (push an empty DocEntry)
678 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
679 lines. Bug fix in the initialization of the PixelConvert and the
681 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
682 use in TestCopyDicom (now this test can run under windows... but fails)
683 * Test/TestCopyDicom.cxx : amelioration of the test :
684 - test the pixels written
685 - add test points to quickly find where is the error
686 - can set a file name input and output in arguments
687 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
688 amelioration of the test output
690 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
691 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
692 all replaced DocEntry's
693 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
694 Now, each needed DocEntry to modify is duplicated, modified and inserted
695 to the header using DocEntryArchive. Thus, after save, we can restore the
696 header initial state.
698 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
699 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
701 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
702 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
703 correct to copy it. The DictEntry is specified at the DocEntry creation,
704 then, it musn't change in the time.
705 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
706 header correctly. At this time, the change is only made for the first
707 level of the Document. In the future, it might consider sequences.
708 The change is made by replacing a DocEntry by an other that is created
709 outside the class. The old value is kept. When we restore the header
710 status, the added DocEntry is deleted and replaced by the old value.
711 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
712 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
713 set the write type to explicit VR, implicit VR or ACR. Add methods to set
714 the write mode to native, decompressed or RGB (but not used at this time)
716 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
717 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
718 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
720 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
721 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
722 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
724 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
725 set because already copied when copying the BinEntry's of the header
726 * Test/TestAllReadCompareDicom.cxx : remove warnings
728 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
729 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
730 Two problems appear when doing it :
731 - with the gdcmFile : when the GetImageData method is called, the pixels
732 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
733 data (pixels). And each structure destruct the data when it's
734 destructed. So we have two destructions for the same data. To solve it,
735 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
736 data or not. If it doesn't own data, then they will not destroyed by
738 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
739 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
740 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
741 create a double destruction of the same DocEntry's. So, to solve it,
742 the TagHT is simply cleared and the DicomDir* elements are destroyed.
743 * TODO : add an entry concerning memory leaks in the DicomDir
745 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
746 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
747 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
750 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
751 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
752 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
753 after it have been deleted
755 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
756 * FIX: src/* fix the doxygen warnings.
757 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
758 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
759 was erroneously defined with a size of 15 instead of 16. [many thanks
760 to Jean Michel Rouet for pointing out this bug].
762 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
763 1. Finish merging JMR patch for writting DICOM from scratch
764 2. Fix -hopefully- bug with MONOCHROME and space vs null character
765 3. Use const ref when possible
766 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
767 5. A few more comments
768 6. CreateUniqueUID can now be called without parameter"
770 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
771 * ENH: Slightly bigger patch:
772 1. Getting toward full integration of JMR patch for writting dicom from scratch
773 2. Update Test to test part of this patch: CreateUniqueUID
774 3. File was not close properly in gdcmDict
775 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
776 5. Use of const ref instead of copy (speed issue)
777 6. Remove temporary (duplicate) string in TranslateToKey
778 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
779 8. Do not repeat virtual in subclasses
780 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
782 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
783 * Apply first patch toward better string comparison when dealing with broken
784 DICOM files. Essentially the string could be padded with a space instead
785 of a null character as defined by standard
787 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
788 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
789 because never used... and in the same time, that's remove some memory leaks
791 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
792 * src/gdcmFile.cxx : now delete the PixelConvert instance.
793 * In examples and tests : change the type of image data variables from void*
794 to uint8_t*. Remmove all delete on image data variables
796 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
797 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
798 Verify the file pointer value before open the file, and if it's not null,
799 a verbose message is generated.
800 Close correctly the file when the file isn't considered dicom-like. The
801 correctly close is a call to CloseFile.
802 When closing the file pointer, test if its not null to close the file.
803 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
804 file. For an uncompressed image, the copied data correspond in the least
805 case to the image size (calculated) or the image size specified in the
806 header. A verbose is generated if these two size mismatch
808 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
809 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
810 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
811 break under windows (with msvc6 compilation).
813 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
814 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
815 compiling with MSVC6)
817 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
818 * Bugs fix for the Windows build with VC6
819 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
820 needed (only for projects required VTK). If the VTK is included in all
821 projects, there is conflicts with the jpeg lib of vtk when compiling the
822 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
823 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
824 when compiling the gdcm_wrap.cxx file (created by the compilation of the
826 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
827 (like it's already made for the cout use). Otherwise, conflict with the
830 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
831 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
833 - comments on the DicomDir::Method related usage added.
834 - now that we use the namespace gdcm, a lot of internal classes do
835 NOT need to be wrapped anymore.
836 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
837 DicomDir::Method) new example added.
839 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
840 * Improve string manipulation. I now inforce the notion of 'DicomString'
841 A DicomString can contain as many \0 as they want
842 and it is *always* of even length.
843 We only support odd length for very rare case.
844 And in the near future this should be removed.
846 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
847 * /binary_write/ gdcm source. Now even on big endian we are writting
848 little endian. This should -heopfully- fix some tests
850 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
851 * Now the dictionary is compiled into gdcm lib. This is a default
852 behavior, thus any dic file specified is picked before failback to
853 the one comiled into lib
855 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
856 * Change internals for gdcmDict. Don't use any 'new' any more.
857 This should definitely solve any leak problem, and we should be
858 as fast as before, as long as don't modify too much the dictionary.
860 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
861 * STYLE: ivars should start with a capital letter.
862 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
863 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
865 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
866 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
867 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
868 new 2004 dictionaries added (thanks to JPR).
869 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
870 * CLEANUP_ROUND (15) for gdcmPixelConvert
871 - RLEFrame::NumberFragments is now of type unsigned int
872 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
873 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
876 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
877 * Initial work in gathering all transfer syntax accessors. clearly
878 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
879 ivars, but only one transfersyntax (class) ivar with equivalent method on
882 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
883 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
884 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
885 discussed (plus I didn't like having a 2000 lines patch not commited)
887 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
888 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
889 * CLEANUP_ROUND (14) for gdcmPixelConvert
890 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
891 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
892 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
894 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
895 anymore and hence avoids storing a copy of PixelConvert::Decompressed
896 into File::Pixel_Data.
898 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
899 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
900 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
901 * CLEANUP_ROUND (13) for gdcmPixelConvert
902 Substituted File::ParsePixelData() with PixelConvert::Print() new
904 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
905 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
906 method to those classes.
907 - src/gdcmFile.[cxx|h]:
908 -- Added a ::Print() method.
909 -- PixelConverter is now a reference instead of a member.
910 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
911 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
913 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
914 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
915 collaboration diagram and inheritance diagram should be generated with
917 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
918 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
919 pointlessly wrapped (see
920 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
921 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
922 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
923 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
924 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
925 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
926 -- File::Initialise: PixelConverter setup moved away to
927 PixelConverter::GrabInformationsFromHeader()
928 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
929 interpretation moved away to PixelConverter::BuildRGBImage()
931 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
932 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
933 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
935 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
936 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
937 displayed on Win32 when a brutal abort() occurs (because of uncatched
938 exception). See TODO new entry of this commit for more on this.
939 * TODO added new entry.
940 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
941 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
942 - HandleColor is no longer called from gdcmFile.cxx
943 - gdcmPixelConvert.cxx clean up on method arguments and internal
944 variable names for semantical coherence.
946 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
947 * Finished lossless transition, not only do we now read all lossless jpeg
948 images, without the need of the Cornwell lib, but we do read them properly now
949 * To reduce code (well to avoid code duplication), I defined a common place
950 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
951 redefine symbols. This is not perfect but this the best solution I found for a
952 compilation time jpeg option.
954 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
955 * Update jpeg ijg lib to support lossless jpeg implementation
956 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
958 * Also added a special copyright for dcmtk since we use their bugfixes.
961 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
962 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
963 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
964 matters, as stated in warning note at begining of %include section).
965 * src/gdcmDicomDir*.[cxx|h]: coding style
966 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
967 * src/gdcmJpeg8.cxx: doxygen fix.
968 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
969 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
970 from File:: to PixelConvert::.
972 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
973 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
974 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
975 - more code moved away from File:: to PixelConvert::
976 - fat setup of PixelConverter set in place in File::Initialise.
978 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
979 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
980 namespace at the file system level. So now you should convert your examples
982 gdcmHeader -> gdcm::Header
983 It would be nice if people keep in mind to no open the namespace, since it
984 allows compilation on broken plateform which were defining common symbol in
985 the standart namespace (like LP, Unknown ...)
987 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
988 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
989 The JPEG fragments are now parsed at the same stage than the RLE
990 information. All code related to JPEG is now in gdcmPixelConvert:
991 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
992 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
993 export a gdcmFile:: method. Those are simply global functions
994 (for the time being this is better than having them attach to
995 either gdcmFile:: or gdcmPixelConvert::).
996 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
997 and stores the result in a gdcmJPEGFragmentsInfo.
998 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
999 code (among other stuff) moved away from gdcmFile:; to
1002 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1003 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1004 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1005 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1006 clean up of RLE related code.
1007 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1008 - src/gdcmRLE.cxx removed
1009 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1010 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1011 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1012 * CLEANUP_ROUND (9) for gdcmPixelConvert
1013 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1014 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1015 away from gdcmFile:: to gdcmPixelConvert::.
1017 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1018 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1019 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1020 This is because Parse7Fe0 used to parse the pixels to compute the
1021 length. This task was passed over to FindDocEntryLengthOB() a long
1022 time ago, EXCEPT I had forgotten the OW case...
1023 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1024 we just recylce the code for parsing RLE fragments and computing
1026 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1027 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1028 with the retired Parse7Fe0().
1029 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1030 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1032 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1033 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1034 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1035 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1036 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1037 * CLEANUP_ROUND (4) for gdcmPixelConvert
1038 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1039 to return an unused length.
1041 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1042 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1043 this should be cleanner from the plane view. The iostream are erally a pain
1044 to use to do simple stuff.
1046 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1047 * Redo the compilation of the ijg jpeg library. Now only one source is
1048 necesseray. No need to rename file by hand what so ever. CMake handle the
1049 copying of the file within different directory, configure header file to
1050 modify some symbol. The only addition made to ijg wasd a mangle table so
1051 that symbol are different whether we are within 8bits or 12bits.
1053 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1054 * Added documentation of vtkgdcmReader on Website:
1055 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1056 with it's binary name).
1057 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1058 the Website to be more complete.
1059 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1060 doxygenated documentation.
1061 - Doc/DoxyVtkGdcmReaderExamples.txt added
1062 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1063 DoxyVtkGdmReaderExamples.html )
1064 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1065 * CLEANUP_ROUND (3) for gdcmPixelConvert
1066 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1068 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1069 * CLEANUP_ROUND (2) for gdcmPixelConvert
1070 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1072 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1073 * CLEANUP_ROUND for gdcmPixelConvert:
1074 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1075 - src/gdcmPixelStuff[h|cxx] removed
1076 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1077 - src/CMakeLists.txt changed accordingly
1078 * GDCMHOME clean up:
1079 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1080 gdcmVersion.py moved to newly created ATTIC related
1081 gdcmPython/SetupOldies/ directory.
1082 * Autotools clean up:
1083 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1084 - autogen.sh configure.in acinclude.m4 python.m4 removed
1086 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1087 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1088 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1089 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1091 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1092 * TODO updated with Mathieu suggestions. I proposed a template for
1093 describing TODO entries and used it for new entries.
1094 * Added Doc/Website/CodingStyle.html, Developpers.html,
1095 DeveloppersPython.html, GdcmDataCvs.html and
1096 DownloadVersion0_1.html, DownloadVersion0_3.html.
1097 * Some Doc/*.txt Doxygen files (which do not really concern the
1098 documentation itself, but the website) moved to html and
1099 placed in directory Doc/Website:
1100 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1101 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1102 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1103 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1104 * CMakeLists.txt changed accordingly.
1105 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1106 DeveloppersPython.html
1107 * INSTALL nows refers to Doc/Website/Installation.html
1109 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1110 * Added Doc/Website directory, that contains a first raw version
1113 2004-09-23 Jean-Pierre Roux
1114 * FIX In order not to be poluted any longer by casting problems,
1115 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1116 we can now delete[] it safely
1117 * VoidArea is now called BinArea (less confusing name),
1118 and all the methods called ...VoidArea... are now ... BinArea...
1119 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1121 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1122 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1123 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1124 up to the destructor of gdcmElementSet to clean up TagHt and it's
1127 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1128 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1129 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1131 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1132 * ENH: added some utility method that builds a flat dictionary
1133 holding all the Dicom entries contained in the recursive structure
1134 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1135 an example of usage.
1136 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1137 BuildFlatHashTable() that build a flat dictionary.
1138 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1139 gdcmDocument is now a friend of gdcmElementSet.
1140 - src/gdcmElementSet.cxx: clean up.
1141 - Example/FlatHashTablePrint.cxx added.
1142 - Example/CmakeLists.txt changed accordingly
1144 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1145 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1146 moved away from gdcmDocEntrySet (since this class is an abstract class
1147 acting like an interface). SQDepthLevel and BaseTagKey are now
1149 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1150 and associated accessors. Doxygenation of the class.
1151 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1153 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1154 Use SQDepthLevel accessor instead. ::Print() adapted.
1155 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1156 - src/gdcmDocument.cxx changed accordingly.
1158 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1159 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1160 - The following is the doxygen comment of the typedef declaration
1161 of gdcmTagKey in src/gdcmCommon.h:
1162 gdcmTagKey is made to old an "universal" (as in URL, Universal
1163 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1164 A dicom tag always has a group and an element, but a set of tags
1165 embeded in various (optionally nested) sequences and sharing
1166 the same group and element all share the same (group, element)
1167 "identifier". Hence the (group, element) cannot be used as an
1168 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1169 In order to construct a proper tag identifier (i.e. a key) we
1170 consider the following definition of a TagKey:
1171 - let Group, Element be the string representation of the
1172 group and element dicom tag members,
1173 - let ItemNumber be the string representation of the integer
1174 index of the considered item number of a sequence,
1175 Let the key of a tag embeded in a sequence, noted SeqTag, be
1177 /ItemNumber#Group|Element
1178 where "/", "#" and "|" are characters acting as separators.
1179 Then the general form of a gdcmTagKey is given by:
1180 Group|Element<SeqTag>
1181 where <SeqTag> means NO or many instances of SeqTag.
1182 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1185 but the gdcmTagKey of a tag "embeded" is the first item of
1186 a sequence, itself nested in the third item of a sequence is the
1188 0004|1220/2#0008|0082/0#0008|0090
1189 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1190 order to hold the new sequence compatible key. Previously, the
1191 GetKey() method would look in the underlying gdcmDictEntry.
1192 - src/gdcmDocEntry.cxx:
1193 -- constructor now copies the underlying DictEntry key, in the local
1195 -- ::Print: displays the member Key, instead of the (group, element).
1196 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1197 - src/gdcmDocEntrySet.h:xi
1198 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1199 -- now has a new BaseTagKey member.
1201 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1202 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1204 This poses the problem with the semantics of the following lines
1205 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1206 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1207 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1208 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1209 to the long FIXME note for what the problem is. Nevertheless in
1210 order to get things working the dicom dictionary was altered !
1211 Please fix things urgently...
1212 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1213 information), see above note on moving the member VoidArea. Nevertheless
1214 the following entries previously correctly set as US are now inproperly
1216 0028 1201 OW IMG Red Palette Color Lookup Table Data
1217 0028 1202 OW IMG Green Palette Color Lookup Table Data
1218 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1219 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1220 of gdcmDocEntry moved to gdcmSeqEntry.
1221 * src/gdcmSeqEntry.cxx: STYLE.
1223 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1224 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1226 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1227 * gdcmPython/testSuite.py: all the test suite in python is now moved
1228 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1229 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1230 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1232 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1233 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1234 to avoid inclusion recursion until STL is reached.
1235 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1236 mecanism. errno.h is not included in gdcm anymore.
1237 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1238 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1240 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1241 gdcmData/TestAllEntryVerifyReference.txt
1242 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1243 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1244 exception_on_error parameter.
1245 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1246 - vtk/vtkGdcmReader.cxx changed accordingly,
1247 - Example/*.cxx and Test/*.cxx changed accordingly.
1249 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1250 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1251 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1252 enable_sequences removed from gdcmHeader constructor and dependencies.
1253 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1254 * gdcmPython/demo/PrintHeader.py: dummy fix.
1255 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1256 skip_shadow removed from gdcmHeader constructor and dependencies.
1257 * Example/*.cxx and Test/*.cxx changed accordingly.
1259 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1260 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1261 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1263 2004-07-21 Jean-Pierre Roux
1264 * FIX Now, Parsing and Printing a DICOMDIR do work!
1265 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1267 2004-07-20 Jean-Pierre Roux
1268 * FIX Some brain damaged headers have Zero-Lenght fields
1269 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1271 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1272 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1273 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1274 variable (instance of gdcmDebug) by a definition macro, and the instance
1275 is now in static in the gdcmDebug class
1276 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1277 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1279 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1280 * WARNING: ctest now depends more tightly on gdcmData. You should
1281 check out gdcmData properly for things to run smoothly...
1282 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1283 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1284 we need the pixels not be loaded in order to use the ValEntry
1285 that displays position and size).
1286 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1287 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1288 be deprecated. If you have any doubts about the advantages of a
1289 modern scripting language (read Python) versus grass root C++ (i.e.
1290 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1291 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1292 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1293 Anyhow, consider documenting the gdcmData images in
1294 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1296 * Test/CMakeLists.txt:
1297 - now uses TestAllEntryVerify.cxx
1298 - specific comments on oldACR00001.ima (now renamed in gdcmData
1299 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1300 gdcmData/TestAllEntryVerifyReference.txt
1303 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1304 * src/*.[h|cxx] : typedef clean up
1305 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1306 - TagKey renamed to gdcmTagKey (for external usage)
1307 - VRKey renamed to gdcmVRKey (for external usage)
1308 - removal of typedef duplication.
1309 - Removed all unecessary inline keyword from class inline definitions.
1310 - Some method|function(void) declarations replaced with method|function().
1311 * src/jpeg/libijg12/jdhuff12.c:
1312 - printf polluting ctest removed.
1313 - TAB removal for comminting
1315 - TestAllReadCompareDicom.cxx: added a test that compares all the
1316 images in gdcmDataImages.h with corresponding images in
1317 gdcmData/BaselineDicom/. When baseline images are not present
1318 this test creates them.
1319 Note: we need to validate each reference image, but before that
1320 I'd like to rename them with a more explicit name...
1321 - CMakeLists.txt: changed accordingly.
1322 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1323 including each header needed).
1325 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1326 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1327 test suite to the Example directory. Are concerned:
1332 - TestWriteSimple.cxx
1333 * Test/CMakeLists.txt: added some comments on reasons for black listing
1334 image gdcmData/oldACR00001.ima
1336 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1337 * Test/CmakeList.txt: removed the following from black list (to be coherent
1338 with removal from gdcmData):
1339 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1340 - gdcm-MR-PHILIPS-16.dcm
1342 Added the following because after last cvs update, they cause
1343 ctest -R TestReadWriteReadCompare
1345 - gdcm-MR-SIEMENS-16-1.acr
1347 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1348 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1349 new comments in this file) we temporarily (sigh) move to a weaker
1351 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1352 we don't need to black list the following images anymore:
1353 - 8BitsUncompressedColor.dcm
1355 - US-PAL-8-10x-echo.dcm
1356 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1357 fixes and the beautified code ;-)
1358 This fixes the bug introduced in version 1.42 (when beautifying)
1359 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1360 Note: ctest was blind to this bug (this means we need to still
1361 improve the test suite). The bug could be detected by using
1362 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1364 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1365 and by displaying the (garbage) produced file temp.XDCM...
1367 2004-06-29 Jean-Pierre Roux
1368 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1369 - replace by uggly but working old code :-(
1370 A lot of things should be OK again.
1371 It's really urgent to have a test suite that *tests*,
1372 to prevent Frog's beautifying sessions to break all the stuff
1373 (twice, withing a fortnigh ...)
1375 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1376 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1377 redundancy) to added Test/TestReadWriteReadCompare.cxx
1378 * Test/CmakeList.txt: because the compare test of
1379 Test/TestReadWriteReadCompare.cxx fails, the following images are
1380 black listed: - 8BitsUncompressedColor.dcm
1382 - US-PAL-8-10x-echo.dcm
1383 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1384 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1385 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1386 and ad-hoc kludge. This kludge is now removed, and on encountering
1387 such an image (OB field brain damaged) we set errno. Then in
1388 ::FindDocLength() we "fix" the length as being ALL what remains
1389 in the file (until EOF). We then proceed, hoping for the best...
1390 This fixes a SegFault in ShowDicom when trying to write such an
1392 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1393 (because TestWriteRead breaks on it, after a non conformal commit?).
1394 ctest now runs properly, except for MakeDicomDir (which was always
1395 broken) and the Python related stuff (still not fixed).
1397 2004-06-24 Jean-Pierre Roux
1398 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1399 FIX : Test/TestReadWrite now iterates on all the file names
1400 (instead of infinite loop)
1401 ENH : Test/TestWriteRead now iterates on all the file names
1403 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1404 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1406 2004-06-24 Jean-Pierre Roux
1407 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1408 when SamplesPerPixel =3
1409 - now Write is no longer confused by
1410 'BitsAllocated = 12" and 'BitsStored=12"
1411 - "UN" value representation Elements are now written correctly
1412 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1413 ENH : - now gdcmHeader has its own Write methods
1414 (in order to split the job that has not to be done
1417 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1418 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1419 loop on the same image until memory went out.
1420 Note: this means we still have gobs of memory loss in PrintDocument
1421 * src/gdcmDocument.cxx: fixes problem on parsing on file
1422 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1424 2004-06-24 Jean-Pierre Roux
1425 FIX : Write - All the Sequences and Sequence Item are now written
1426 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1427 is added a the end, when necessary.
1428 - A lot of brain-damaged images, that were read correctly are
1429 now written correctly
1430 - length compatible BinEntry are now loaded correctly
1431 (even for odd groups)
1432 Note : only Explicit Value Representation was checked.
1433 (question : is implicit VR really necessary for gdcm ?)
1435 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1436 * DEVELOPPER: added a proposition of coding style.
1437 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1440 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1441 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1442 Use the gdcmDocEntry::Print() and Write() instead.
1443 * src/gdcmDocument.cxx: bug fix.
1445 2004-06-22 Jean-Pierre Roux
1446 FIX : gdcmDocument.cxx
1447 - Now we do recognize the JpegLossLess format (there was a misstyping in
1448 code 'beautyfication' :-(
1449 - Now we automaticaticaly load the Luts, if any
1451 2004-06-22 Jean-Pierre Roux
1452 In order : to write Sequences, whatever their imbrication level,
1453 : to allow user to create his own Sequences
1454 a lot of modif where necessary (adding, moving, or virtualising methods)
1456 WARNING : save your own sources *before* cvs up !
1459 ADD virtual void Write(FILE *fp, FileType filetype);
1462 ADD virtual void Write(FILE *fp, FileType filetype);
1463 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1466 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1467 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1468 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1469 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1470 ADD std::string GetEntryByName(TagName name);
1471 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1473 std::string vr = "unkn",
1474 std::string fourth = "unkn",
1475 std::string name = "unkn");
1476 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1477 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1478 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1479 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1480 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1481 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1482 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1483 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1486 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1487 ADD virtual std::string GetEntryByName (TagName tagName);
1488 ADD virtual std::string GetEntryVRByName (TagName tagName);
1489 REM virtual bool Write(FILE *, FileType);
1490 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1491 FILE *_fp, FileType type);
1492 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1493 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1494 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1495 REM virtual std::string GetEntryByName (std::string tagName);
1496 REM virtual std::string GetEntryVRByName (std::string tagName);
1497 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1498 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1499 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1501 std::string vr = "unkn",
1502 std::string fourth = "unkn",
1503 std::string name = "unkn");
1504 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1505 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1506 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1507 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1510 ADD virtual void Write(FILE *fp, FileType filetype);
1513 ADD virtual void Write(FILE *fp,FileType filetype);
1516 ADD virtual void Write(FILE *fp, FileType filetype);
1517 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1518 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1519 REM std::string GetEntryByName(TagName name);
1522 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1524 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1525 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1526 The default constructor invoked by the line
1527 gdcmHeader *f1 = new gdcmHeader( header );
1528 was gdcmHeader::gdcmHeader(bool) instead of the expected
1529 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1530 Hence the parsing wasn't executed... See also below.
1531 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1532 as explicit constructor didn't do the trick to fix the above problem.
1533 Could anyone explain why ?
1534 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1535 properly calls gdcmValEntry::Print() (that was weed out from
1536 code related to gdcmBinEntry).
1538 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1539 * In order to fix memory leaks:
1540 - Test/TestWriteSimple.cxx: added cleaning of free store through
1542 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1543 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1544 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1545 (through the call to ::AddDicomDirMeta()) or the destructor
1546 would crash when deleting uninitialized ::metaElems].
1547 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1548 - src/gdcmDocument.cxx:
1549 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1550 from dynamic stores.
1551 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1552 was causing memory leaks.
1553 - src/gdcmSQItem.cxx:
1554 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1555 cleanly handled with polymophism: sorry but my milage is low).
1556 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1557 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1558 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1559 This avoids SegFaulting.
1560 - src/gdcmSQItem.h: coding style.
1562 - Test/TestWriteSimple still severely sucks. The output image content
1563 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1564 damaged when displayed with vtkgdcmViewer.
1565 - on memory leaks: TestWriteSimple leaks really less (see entry
1566 of 2004-06-18 in Changelog file for the call to valgrind).
1567 - on segfaults: ctest now passes all the tests but one (no more
1569 * Erroneous leading white fix:
1570 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1571 white[s] (as opposed to from >> xxx, that removes it [them].
1572 - src/gdcmTS.cxx: ditto.
1573 - gdcmPython/testSuite.py: dirty related kludge removed.
1574 * src/*: remaining references to gdcmParser removed.
1575 * src/*[cxx|h]: added copy[way]left header.
1578 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1579 * In order to fix writing of dicom files:
1580 - Test/TestWriteSimple.cxx: a simpler example of writing.
1581 - Test/CMakeLists.txt changed accordingly.
1582 - src/gdcmDocument.cxx:
1583 -- The destructor now recursilvely removes potential sequences.
1584 -- Bug fix in ::IsJPEG2000()
1585 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1586 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1588 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1589 to only declared) and build on top of
1590 ::GetDocEntryByNumber(guint16, guint16).
1591 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1592 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1593 for usage in destructor and treatement of promotion in
1594 ::ReplaceOrCreateByNumber().
1595 - src/gdcmSQItem.cxx: destructor should better handle his job.
1596 Test/TestWriteSimple now runs (or at least it DOES something).
1597 * We can now start hutting memory links. A good starting point is:
1598 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1599 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1600 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1602 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1603 * Valgrind note: after Mathieu Malaterre teached me how to read
1604 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1606 Using gcc, you can force the STL to use malloc and to free memory as
1607 soon as possible by globally disabling memory caching.
1608 With 3.2.2 and later, you should export the environment variable
1609 GLIBCPP_FORCE_NEW before running your program.
1610 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1611 simply vanish (it is still not clear to me, whether this means that
1612 STL std::string leaks or if valgrind believes it leaks...).
1613 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1614 running bin/gdcmTests makeDicomDir):
1615 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1616 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1618 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1619 SegFaulting (I drowned in DicomDir related code when trying to
1620 understand why the list is empty...).
1621 * src/gdcmDocument.h: first BSD license header try.
1622 * Doc/License.txt added.
1624 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1625 * src/gdcmDocument.[h|cxx]:
1626 - Clean up of the Transfer related predicates. They are now all based
1627 on new method isGivenTransferSyntax, that (should) handle properly
1628 the padding problem.
1629 - general clean up, simplification, and coding style.
1630 - Specific clean up of Parse7FE0() (umproperly named actually).
1631 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1633 2004-06-14 Jean-Pierre Roux
1635 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1636 - fix the display of SQItem ordinal number
1637 - add the GetSQItemByOrdinalNumber method
1638 - remove some useless never written private methods
1640 2004-06-14 Jean-Pierre Roux
1642 - adding a constructor taking a gdcmDocEntry as an input param
1643 - ReplaceOrCreateByNumber now returns :
1644 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1645 a gdcmValEntry * if a string value is passed as a param
1647 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1648 according to the param type (no longer sets a gdcmDocEntry)
1649 - GetValEntryByNumber, GetBinEntryByNumber added
1650 - NewValEntryByNumber and NewBinEntryByNumber added
1652 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1654 - GetSQItemNumber and SetSQItemNumber added, to provide
1655 a (relative) Item identier inside a given Sequence
1656 \warning : some pb remaining around this number
1658 - AddEntry now takes the Item Number as a param
1660 - adding a constructor taking a gdcmDocEntry as an input param
1662 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1663 * Memory leak hunt with the following command:
1664 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1665 --show-reachable=yes gdcmTests PrintDocument
1666 It looks like many (all?) leaks are due to the STL (or a bad usage
1667 of the STL. The lines producing the leaks now have a comment with
1668 a "MEMORY LEAK" tag: you can retrieve them with
1669 grep "MEMORY LEAK" src/*
1670 Here are two typical examples which I can't help fixing:
1675 char * test = "babo";
1676 name = test; //// <--- valgrind detects 960 bytes lost in
1677 //// call to std::string::operator=(char const*)
1678 name.clear(); //// Doesn't help !
1686 std::cout << "Type a bunch of characters followed by RETURN: ";
1687 getline(std::cin, line); //// <--- valgrind dectects a loss
1688 //// of 1320 bytes in call to
1689 /// std::basic_istream<>& std::getline<>
1695 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1696 * src/gdcmHeader.[cxx|h]:
1697 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1698 and related, moved away to gdcmDocument.
1699 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1700 the corresponding protected accessors of inherited class
1701 gdcmDocument, removed ! As a consequence gdcmFile had to be
1702 declared friend of class gdcmDocument (see below).
1703 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1704 - Clean up of undefined or unused methods.
1705 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1706 account the changes to gdcmHeader.h).
1707 * src/gdcmDocument.h:
1708 - gdcmFile is now a friend class (in order to take into account the
1709 changes to gdcmHeader.h).
1710 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1711 (see changes to gdcmHeader.h).
1712 - Accessors (reading on the form GetEntry*) are now public.
1713 - Clean up of undefined or unused methods.
1714 * src/gdcmDocument.cxx:
1715 - adaptation to changes to gdcmDocument.h
1716 - ::OpenFile now writes a verbose message when file cannot be opened.
1717 - some std::string properly set to VRKey
1718 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1719 references to gdcmDocument.
1720 * Test/TestFindTags.cxx: changed accordingly to above changes.
1721 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1722 cvs repository gdcmData.
1724 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1725 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1726 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1727 conflicts with gdcmValEntry::voidArea.
1728 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1729 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1730 Value representation between StringRepresentable and BinaryRepresentable.
1731 * src/gdcmDocument.cxx:
1732 - method ParseDES: proper indentation restored and usage of
1733 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1734 - method LoadDocEntry: the fingerprint left in the SetValue() of
1735 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1736 removed. Reverting to previous code segment with the proper
1737 dynamic_cast< gdcmValEntry* >.
1738 Note: this was (partially) breaking the python test suite
1739 (gdcmPython/testSuite.py) that made usage of the above
1740 fingerprint to check presence of "Pixel Data".
1741 * src/gdcmDocEntry.h: coding style.
1742 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1743 now taken into account.
1744 * gdcmPython/gdcm.i: adaptation to the new internal representation
1745 of gdcm (exit gdcmParser, hello gdcmDocument).
1746 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1748 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1749 anymore, but instead prints the loaded Python dictionary.
1750 * .... alas, the python testSuite is still broken.
1752 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1753 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1755 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1756 * src/gdcmUtil.h : export methods
1758 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1759 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1761 * Initial addition of automatic python testing
1762 * Initial addition of automatic image comparison
1764 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1765 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1766 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1768 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1769 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1770 * Test/ShowDicom.cxx : bug fix for msvc compilation
1771 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1773 2004-05-04 Jean-Pierre Roux
1774 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1775 new concepts (and new classes) :
1776 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1777 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1778 - Sequence Doc Entries (gdcmSeqEntries)
1779 a Sequence is composed of Items.
1780 Each item is a set of Doc Entries (this is recursive)
1781 The non uniqueness of the 'Dicom tag' is due to this recursivity
1782 (never taken into account)
1783 Our unability to add a new 'entry' in the header
1784 at the proper location (neither in the H-Table (map or multimap),
1785 nor in the Chained List is also due to this recursivity.
1786 Don't try, right now, to use/modify/compile these new sources :
1787 nothing is finished.
1788 We just commit all the stuff, 'as is', in order not to loose it.
1790 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1791 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1793 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1794 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1795 file prefix (SetFilePrefix)
1797 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1798 * Add a new test: ShowDicom, for now this is just the c++ version of
1799 checkRead.sh, later it will be able to compare the image read against a
1801 * Replace the DEBUG on the stack with a global entry in cmake interface:
1802 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1804 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1805 * Add an example subdir, with a real example on how to read + write a
1808 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1809 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1810 * Doc/CMakeLists.txt: the main page is now properly differentiated
1811 between the developper and user version.
1812 * Doc/doxygen.config.in: dropped search related obsolete flags
1813 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1815 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1816 * DEVELOPPER: added some helpfull comments for compile/test/install
1819 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1820 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1821 src directory, now generated in the build dir.
1822 2. Tests as mentionned smarter
1824 4. Add a new method in gdcmDict that return the PubDict by name
1825 this is interesting for 3rd party lib like ITK,
1826 where we could set the institution name / patient name...
1828 * ENH: 1. Now the test suite is working for real
1829 2. All binaries are now output in the gdcm-bin directory
1830 (this was not true before)
1832 2004-04-28 Jean-Pierre Roux
1833 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1834 SeQuence indented printing of Dicom Header.
1835 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1836 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1837 Computation of SQDepthLevel is now part of gdcmHeader constructor
1838 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1839 tree-like structure of a Dicom Header.
1840 * FIX Test code cleaning
1842 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1843 * ENH: Adding automatic testing
1844 1. Need a DartConfig.cmake to submit to public
1845 2. Add a test driver gdcmTest.cxx
1846 3. gdcmTestMain, an helper for the main test driver gdcmTest
1847 4. Files in Test don't have a main anymore, this becomes interesting
1848 when we add more and more tests, thus dsw don't have to load
1850 * ENH: Adding a GDCM_DATA_ROOT for testing
1851 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1852 one file instead of seven + some small cleanup
1854 2004-04-22 Jean-Pierre Roux
1855 * ENH Minor changes to the Print() methods.
1856 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1857 Header printing. Example given with :
1858 > PrintHeader fileName 2 new
1859 (SQ based tree-like structure still to be done for the Header ...)
1861 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1862 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1863 1. I have added some unsigned where needed
1864 2. Some function parameter not used -> (void)
1865 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1866 4. g++ don't like character '\' in comment
1867 5. #define jpeg_create_decompress jCreaDecompress
1868 this really need to be fixed
1869 6. virtualize destructor of gdcmObject ... leakage
1870 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1871 this also really need to be fixed
1872 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1873 remove compression file
1874 (as we only do decompression, right ?)
1875 * ENH: Change malloc/calloc/free with c++ equivalent
1877 2004-04-21 Jean-Pierre Roux
1878 * FIX gdcmHeaderHelper::GetXSpacing
1879 when a single value is found (bug ?), xpacing is now
1880 defaulted to yspacing
1882 2004-04-19 Jean-Pierre Roux
1883 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1884 * ENH add parameters :
1885 bool exception_on_error = false,
1886 bool enable_sequences = false,
1887 bool ignore_shadow = false
1888 to the gdcmFile constructors to be full gdcmParser compliant
1889 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1890 to allow reading of PAPYRUS 3.0 files
1892 2004-04-06 Jean-Pierre Roux
1893 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1895 2004-04-02 Jean-Pierre Roux
1896 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1897 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1898 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1900 2004-03-30 Jean-Pierre Roux
1901 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1902 for ACR file, written out as DICOM files (hope so...)
1904 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1905 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1906 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1907 moved to base class gdcmParser and only the specialisation is kept
1909 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1910 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1911 already does the job.
1912 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1913 (to be consistent with gdcmParser::WriteEntries).
1915 2004-03-30 Benoit Regrain
1916 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1917 upate of the object's instance. It's passed to 2 in the unfavorable
1918 case : one in the ExecuteInformation, one in the ExecuteData
1920 2004-03-29 Jean-Pierre Roux
1921 * ENH : Check on file type to be written moved
1922 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1923 * FIX : gdcmObject::ResetBoundaries now stops properly
1924 when end-of-list is reached
1925 : gdcmVersion modified (as Benoit Regrain asked)
1927 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1928 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1929 * src/gdcmUtil.cxx: added forgotten iostream include.
1930 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1931 equivalent to ExplicitVR in existing code).
1933 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1934 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1935 now contains all the gdcmGlobal related code.
1936 * minor coding style and doxygenation changes.
1938 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1939 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1940 now contains all the Debug related code.
1941 * minor clean-up of includes in src/*.cxx
1942 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1943 CreateCleanString) removed.
1944 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1945 * Doc/DoxyMainPageUser.txt added.
1946 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1947 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1948 src/gdcmDirList.cxx)
1950 2004-03-24 Jean-Pierre Roux
1951 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1953 2004-03-23 Jean-Pierre Roux
1954 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1955 big endian made volumes
1956 * ENH Now gdcmParser constructor and destructor are protected to forbid
1957 end user to instanciate class gdcmParser
1958 (only gdcmHeader and gdcmDicomDir are meaningfull)
1960 2004-03-22 Benoit Regrain
1961 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1962 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1963 gdcmSerie to gdcmDicomDirSerie
1965 2004-03-19 Jean-Pierre Roux
1966 * ENH Now the tree-like structure describing a DICOMDIR comming from
1967 an already existing DICOMDIR file is consistent with
1968 the home-made tree-like structure build ex-nihilo
1969 or build from the files held (recursively) in a Directory
1970 functions gdcmDicomDir::CheckBoundaries()
1971 gdcmObject::SetBoundaries() added
1973 2004-03-17 Jean-Pierre Roux
1974 * REM (Eric Boix bug) : removal of meaningless
1975 gdcmDicomDirImage::NewImage function.
1976 * FIX now file names and directory name are written properly in the
1978 * FIX now gdcmDicomDir constructor may be call without any trick
1981 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1982 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1983 of gdcmDicomDirImage::NewImage as empty function.
1985 2004-02-28 Jean-Pierre Roux
1986 * ENH add gdcmDicomDir:NewPatient
1987 add gdcmDicomDirPatient:NewStudy
1988 add gdcmDicomDirStudy:NewSerie
1989 add gdcmDicomDirSerie:NewImage
1990 to allow making gdcDicomDir object.
1991 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1992 (as opposite to the gdcmHeader chained list)
1994 2004-02-11 Benoit Regrain
1995 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1996 when using from python
1998 2004-02-10 Benoit Regrain
1999 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2000 * FIX : in gdcmDicomDir when the directory is empty
2001 * ENH : add callback and methods to get the progression of dicomDir
2004 2004-02-06 Jean-Pierre Roux
2005 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2006 - GDCM_META added to gdcmDicomDirType
2007 - class gdcmMeta created
2008 * ENH : - A brief summary is now displayed at the beginning of
2009 'testDicomDir' to help disaster magnitude estimation
2010 * REM : Now useless Test/explDICOMDIR.cxx
2012 2004-02-05 Benoit Regrain
2013 * ENH : add methods in gdcmObject to get the hash table or the list of
2015 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2016 * FIX : wrapping python for TagHeaderEntryHT
2018 2004-02-04 Benoit Regrain
2019 * FIX : even length for some strings when writting the dicom dir
2020 * FIX : sort the images in the dicom dir
2021 * FIX : Bug fix for python use of dicom dir
2022 * ADD : a python demo
2024 2004-02-04 Jean-Pierre Roux
2025 * FIX : Final solution (?) for icone embedded images
2026 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2027 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2028 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2029 gdcmData/gdcm-MR-SIEMENS-16.acr1
2030 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2031 to make full checking easier
2033 2004-02-04 Benoit Regrain
2034 * FIX : WriteEntries : coding style & logic in parameters
2035 * FIX : Set the elements to create the DicomDir in a dictionary file
2037 2004-02-03 Benoit Regrain
2038 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2039 * gdcmDicomDir : add the load of directory
2040 * Bug fix and print add-on
2042 2004-02-03 Jean-Pierre Roux
2043 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2044 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2045 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2046 * FIX gdcmParser.cxx : 'group length' elements are now considered
2047 as integers, even for shadow groups, when file is Implicit VR
2049 2004-02-02 Jean-Pierre Roux
2050 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2052 of the last synonym :-(
2053 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2055 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2056 * FIX taking into account the possible 7fe0,0010 multiplicity
2057 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2058 to allow removal of references to 7fe0,0010, to deal with
2059 ACR-NEMA images, when 0028,0200 is meaningfull
2061 2004-01-31 Jean-Pierre Roux
2062 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2063 no longer writes 'Un' on disk
2064 * FIX SQ elements with actual length are now dealt with corectly
2065 * FIX gdcmFile::WriteBase make the difference, for color images, between
2066 the length (for Palette expanded images)
2067 and Raw Length (non expanded image + Palette)
2068 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2069 (that broke Write). Replaced by UL.
2070 Aware user will reload the field if he
2071 thinks it's necesssary
2073 2004-01-30 Jean-Pierre Roux
2074 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2075 when 'dirty Acr' is found, to be compliant with the new
2076 IsReadable() methods.
2078 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2079 (no DOUBLE images in kosher DICOM,
2080 but so usefull for people that miss them ;-)
2082 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2083 DICOMDIR related utilities (not checked as Windoze compliant)
2085 2004-01-28 Jean-Pierre Roux
2086 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2088 2004-01-27 Jean-Pierre Roux
2089 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2090 to allow skipping the shadow elements, to save memory space.
2091 The TRUE value for this param has to be used
2092 with a FALSE value for the 'enable_sequence' param.
2093 ('public elements' may be embedded in 'shadow Sequences')
2094 * gdcmHeader methods now deal with 'embedded icones images' in the header
2095 (even when an 'icone image sequence' is announced by the
2096 element (0x0088,0x0200), but there is NO icone at all ...
2098 * gdcmHeader sometimes Image Location value doesn't follow
2099 the supposed processor endianity (see gdcmData/cr172241.dcm).
2102 * gdcmHeader add the method
2103 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2104 to get *all* the Header Entries with the same tag.
2105 GetHeaderEntrySameName is probabely *useless*
2106 (no meaning : Name is *not* an identifier within the Dictionary)
2108 2004-01-26 Benoit Regrain
2109 * Bug fix in the print of hexadecimal representations. Remove long fields
2110 in the print and add a third level of print to print them
2112 2004-01-23 Benoit Regrain
2113 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2114 * Bug fix on test suite after remove the strip made on not string fields
2115 * Split the IsReadable method between gdcmParser which test that the file
2116 is dicom and gdcmHeader which test that it's an image file
2118 2004-01-22 Benoit Regrain
2119 * DicomDir : clean code, add methods, set variables in protected or private
2120 * gdcmUtil : bug fix for the clean string method
2122 2004-01-19 Benoit Regrain
2123 * Add the use of shadow dictionaries
2124 * bug fix and coding style
2126 2004-01-19 Benoit Regrain
2127 * src/gdcmFile.cxx : bug fix concerning the close of file
2128 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2129 * Add the update of header entries using the shadow library
2131 2004-01-19 Benoit Regrain
2132 * removal of file gdcmHeader2.cxx
2133 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2134 inheriting from gdcmParser. This split is to prepare the integration
2135 of dicom dir parsing
2136 * bug fix under python
2138 2004-01-16 Jean-Pierre Roux
2139 * REM removal of class gdcmHeaderEntrySet
2140 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2141 * ADD add file gdcmHeader2.cxx
2142 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2144 2004-01-15 Benoit Regrain
2145 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2146 entries created while parsing the header. Thus, they will be destroyed
2147 when the gdcmDictSet will be destroyed
2148 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2151 2004-01-15 Benoit Regrain
2152 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2153 made a fatal error because of the memory release at the end of program.
2154 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2155 some memory and vtk seems to have some problems with that.
2156 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2158 2004-01-14 Benoit Regrain
2159 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2160 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2161 * src/*.[h|cxx] : make changes due to class name changes
2162 * gdcmPython/demo/*.py : bug fix due to method names
2164 2004-01-13 Benoit Regrain
2165 * src/*.[h|cxx] : coding style
2166 * vtk/*.[h|cxx] : coding style
2168 2004-01-13 Benoit Regrain
2169 * gdcmPython/testSuite.py : test the readable flag of file for tests
2170 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2171 It's lied to the stl compilation by MSVC (windows, always windows...)
2172 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2174 2004-01-12 Benoit Regrain
2175 * src/*.h : add comments
2176 * src/gdcmDictSet.h : set the method BuildDictPath in public
2177 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2178 directly setted in the source code
2179 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2182 2004-01-09 Benoit Regrain
2183 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2184 * setup.py : use a reference to gdcmVERSION
2186 2004-01-07 Benoit Regrain
2187 * Modification to compile with the distutils.
2190 2003-12-10 Benoit Regrain
2191 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2192 can use a gdcmHeaderHelper to load data
2193 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2194 made in the source code
2196 2003-12-10 Benoit Regrain
2197 * Update Windows projects and .cvsignore files
2199 2003-11-12 Jean-Pierre Roux
2200 * ENH gdcmHeader constructor has one more parameter (default value : false)
2201 that allows the user to 'go inside' the SeQuences only
2203 gdcmElValSet:Print takes it into account
2205 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2206 * ENH: Update gdcmPython/CMakeLists
2207 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2208 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2210 2003-11-10 Jean-Pierre Roux
2211 * FIX : gdcmHeader::LoadElements is now based
2212 on the ListTag listElem member,
2213 not longer on the TagElValueHT tagHt member
2214 * ENH : PrintPubElVal shows (temporarily) both results,
2215 with the tagHt member and the listElem member.
2216 (it's easier to 'see' the problems when using Printheader)
2218 * FIX : old private member LgrElem is now splitted into
2219 ReadLength : Length actually found on disk (updated only
2220 if bug fixing is necessary), for internal
2222 UsableLength : Updated by FixFoundLength, to fix a bug
2223 or to allow Parser going on.
2224 Will allow to re-write a kosher header when a SeQuence
2225 with a length (not 0000) is found
2226 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2227 because gdcmElValSet::Add does not update ListElem
2230 2003-11-07 Jean-Pierre Roux
2231 * FIX misstyping in Transfert Syntax name table
2232 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2233 when they have an actual length (not 0000 nor FFFFF)
2234 (Nobody should care of it, but DICOMDIR explorers)
2236 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2237 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2239 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2240 * ENH: vtkGdcmReader now supports LUT !
2241 (vtkgdcmViewer for now is not able to use them though)
2243 2003-11-05 Jean-Pierre Roux
2244 * in testSuite.py : new files names for checking the package
2245 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2246 that returns the pixel area size to the *aware* (vtk) user
2247 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2249 2003-11-05 Benoit Regrain
2250 * in testSuite.py : Modify the rules for checking the paths
2251 : Explicit error messages
2252 * in __init__.py : Related modif
2254 2003-11-03 Jean-Pierre Roux
2255 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2256 to be used by aware (vtk) users that want to manage
2257 LUT (and no to turn the PALETTE image into an RGB pixels one)
2258 * GetPixelType now returns 8U for 24 Bits images
2259 (vtkGdcmReader compliant)
2261 2003-10-31 Jean-Pierre Roux
2262 * Removal of *all* gdcmData images and add them again
2263 in order to loose the 'history' of un-anonymised images
2265 2003-10-31 Jean-Pierre Roux
2266 * RMV : removal of useless jBitsInJsample.h
2267 for both 8 and 12 Bits JPEG Lossy Libraries
2269 2003-10-31 Jean-Pierre Roux
2270 * ENH : Add the functions gdcmFile::GetImageDataRaw
2271 gdcmFile::GetImageDataIntoVectorRaw
2272 that act as GetImageData and GetImageDataIntoVector
2273 except the making of an RGB Plane from Gray Plane + LUT
2274 Intended to aware (vtk) users who know how to manage
2277 GetLUTRGBA return a R,G,B,A LUT if any
2278 lgrTotaleRaw gives the 'Raw' length
2279 GetImageDataRaw returns the gray Plane
2280 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2281 (They stay Grey, just like with other Dicom viewers :-(
2283 2003-10-30 Jean-Pierre Roux
2284 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2286 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2287 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2288 being coherents dicom files.
2290 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2291 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2293 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2294 * ENH: Two steps is necessary to please VC++ compiler...
2295 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2296 * ENH: Add include dir to medcon lib
2297 * FIX: only one function is being exported for now !
2298 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2300 2003-10-29 Jean-Pierre Roux
2301 * adding gdcmHeader::GetLUTRGBA
2302 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2303 --> Mathieu, the modif u're waiting for is not yet committed
2304 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2306 2003-10-27 Jean-Pierre Roux
2307 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2308 00191113.dcm DermaColorLossLess.dcm
2309 MxTwinLossLess.dcm RadBWLossLess.dcm
2310 * ENH: For version prior to vtkImageViewer2 -r 1.19
2311 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2313 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2314 * Removal of ido stuff in CMakeLists.txt
2316 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2317 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2318 * FIX: remove a call to ->Modified ... see comments
2319 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2321 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2322 * FIX: Problem with path for libvtkgdcmPython
2323 * ENH: Try adding a search script for python site-package
2324 * RMV: Remove some file from medcon lib that are not necessary
2325 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2326 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2327 * FIX: More pragma disable fro VC++,
2328 I don't think I break something as it is also disable in VTK/ITK.
2329 But it fasten debug compilation time.
2331 2003-10-23 Jean-Pierre Roux
2332 * gdcm now deals with 16 Bits Run Length Encoded images
2333 (they are compressed as 2 planes images,
2334 one for the high Bytes, the other for low Bytes)
2336 2003-10-22 Jean-Pierre Roux
2337 * Now CheckRead takes into account :
2338 - the bugged 'Leonardo' Siemens images
2339 - the XA images, sent thru the burning VPRO station
2340 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2343 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2344 * FIX: When copying a Makefile.am to CMakeLists.txt
2345 one should remove the '\'
2347 2003-10-22 Jean-Pierre Roux
2348 * in gdcmData adding a bugged 'Leonardo' Siemens image
2349 (wrong lengths in header)
2350 OK with gdcm, KO with the other viewers :-)
2351 * add a GE dlx XA image, thru the VEPRO burning station
2354 2003-10-21 Jean-Pierre Roux
2355 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2356 for a brutal checking of vtkgdcmViewer compliance
2358 2003-10-21 Jean-Pierre Roux
2359 * add the files for 'xmedcon' Jpeg Lossless library
2360 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2362 2003-10-21 Jean-Pierre Roux
2363 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2365 2003-10-21 Jean-Pierre Roux
2366 * garbage Siemens 'Leonardo' images dealt with
2367 (the patch is easy to remove)
2368 * cosmetic changes to avoid warnings
2370 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2371 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2372 no need to press 'r' now.
2374 2003-10-20 Jean-Pierre Roux
2375 * upgrade of checkRead.sh checkWrite.sh according
2376 to new Jpeg Lossless decompressor
2377 * add US.3405.1.dcm, a genuine RGB medical file ...
2378 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2379 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2381 2003-10-15 Jean-Pierre Roux
2382 * general anonymisation in gdcmData
2383 * adding the 'color files' from
2384 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2385 * adding some well knowed bugged-header images
2386 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2387 waiting for their inclusion in Python testsuite
2389 2003-10-15 Jean-Pierre Roux
2390 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2391 no longer seg faults when file is not found
2393 2003-10-14 Jean-Pierre Roux
2394 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2397 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2398 * TODO: *.in file to genereate a UseGDCM later
2400 2003-10-14 Jean-Pierre Roux
2401 * Some supposed-to-be Dicom Images have no preamble.
2402 OpenFile takes it into account
2403 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2404 * Missing elements added in dicomV3.dic
2405 (just to be affraid : have a look at
2406 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2407 and do it again next year ;->
2409 2003-10-13 Jean-Pierre Roux
2410 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2411 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2412 But there are NOT. It's fixed !
2414 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2415 * FIX: "jpeglib.h" was not found on VC++
2416 * FIX: vtkgdcm was not being installed
2418 2003-10-10 Jean-Pierre Roux
2419 * ENH : OpenFile closes the file if it *really* doesn't look like
2420 an ACR-NEMA / DICOM one.
2421 * FIX : testWrite no longer writes an empty file if the source file
2422 is not gdcm Readable
2423 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2426 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2427 * FIX: CMake generate now documentation
2428 * ENH: out of source doc build !
2429 * ENH: Generate both user and dev documentation
2430 * ENH: Should work on windows too
2431 * ENH: Only one doxygen config.in file is needed
2432 * FIX: make install should be ok now on ùnix plateform
2433 * FIX: PATH to dictionary was wrong (missing /)
2434 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2436 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2437 * vtkGdcmReader is now able to read rgb dicom file.
2438 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2439 * added a gdcmViewer to vtk test, use mouse to control
2440 window level & window width
2442 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2443 * CMake-ification of gdcm, we have now two build system
2444 * FIX: on cygwin Wsock32 doesn't exist
2445 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2447 2003-10-06 Emanuel Ollart
2448 * FIX : compilation process wad broken.
2449 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2451 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2452 * change gdcmViewer -> vtkgdcmViewer
2453 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2455 2003-10-06 Jean-Pierre Roux
2456 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2457 ( e.g : well known GE images with a wrong elem length,
2458 : Philips MRI Images with a wrong Huffman table)
2459 * still to be done : allow the reading of bugged LEONARDO Siemens images
2461 2003-10-03 Jean-Pierre Roux
2462 * Odd length strings are padded with '\0' (not with spaces,
2463 to remain compliant with already defined strings,
2464 like Transfert Syntax UID and others)
2466 2003-10-03 Jean-Pierre Roux
2467 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2468 to allow displaying RGB images (not only by affim ;-)
2470 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2471 * vtkGdcmReader is now able to read rgb dicom file.
2472 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2474 2003-10-03 Jean-Pierre Roux
2475 * A few nasty patches to allow the reading of a lot of nasty images
2476 ( e.g : well known GE images with a wrong elem length,
2477 : Philips MRI Images with a wrong Huffman table)
2478 * still to be done : allow the reading of bugged LEONARDO Siemens images
2480 2003-10-03 Jean-Pierre Roux
2481 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2483 2003-10-03 Jean-Pierre Roux
2484 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2485 to allow displaying RGB images (not only by affim ;-)
2487 2003-10-03 Jean-Pierre Roux
2488 * gdcmFile::GetImageDataIntoVector now
2489 - deals with MultiFrames MultiFragments Run Length Encoded files
2490 - deals with YcBcR (YBR_FULL) files
2491 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2492 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2494 (no sample found :-(
2496 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2497 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2498 Two reasons: - clear things
2499 - third parties acces gdcm through header files, so won't
2500 suffer anymore VC++ complains
2502 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2503 * add argv[1] in testvtkGdcmReader.cxx
2506 2003-09-24 Jean-Pierre Roux
2507 * The lines are now eigthy characters long.for
2508 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2510 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2511 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2512 char* to std::string. Thus, the use of strdup becomes useless. (see
2513 previous commis of Malaterre)
2514 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2515 before the last Malaterre's commit.
2517 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2518 * This commit should fix the Debug building under VC++, the problem
2519 was mainly a mixture of debug and release lib being loaded at startup.
2520 * I also remove a depency to a specific C function: strdup. Because I had
2521 to force the link to msvcrtd (whereas strdup is in libc).
2523 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2524 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2525 located in the gdcmCommon.h file. All use of reference of tha has been
2526 changed to now use the variable GDCM_UNFOUND.
2528 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2530 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2531 Dicom dictionary. The test suite can now be run again. Note:
2532 I'm note very happy with the " (RET)" changes. I believe this
2533 RETAINED comment should be dropped when parsing the dictionary.
2534 - PACKAGER corrected
2536 - AUTHORS updated and now in alphabetical order
2537 * Makefile.am now exports gdcm.dsw for Windoze users.
2539 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2540 * cygwin complains about missing std:: in subdir Test/
2542 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2543 * remove some methods that are now in gdcmHeaderHelper
2545 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2546 * vtkGdcmReader set spacing and origin correctly
2548 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2549 * Fix a few delete/delete[] mismatch
2551 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2552 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2553 interpretation to data given by gdcmHeader. For instance there are
2554 heuristics to get informations (look at different places).
2555 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2556 sorting DICOM images based on different strategies.
2557 * modified Makefiles accordingly.
2559 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2560 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2561 when building in debug mode
2562 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2563 src/win32/gdcmdll.dsp
2564 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2566 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2567 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2570 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2571 * src/win32/libgdcmjpeg12.dsp was not dos format
2572 * src/win32/libgdcmjpeg12.dsp :
2573 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2574 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2576 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2577 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2579 * src/gdcmFile.cxx : bug fix in affectation type
2580 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2581 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2582 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2583 symbols... future problem ?
2585 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2586 * src/win32/libgdcmijpeg12.dsp was missing
2587 * modified gdcm.dsw accordingly
2589 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2590 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2592 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2593 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2594 commit of JPR (before his hollidays to facilitate our work).
2595 * setup.py : bug fix in code. Modifications made while the last commit
2596 of JPR. The code hasn't been tested before the commit... it's so
2597 useless to make that (for best programmer that is JPR) !!!
2599 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2600 * tagged the current version as Version0_3 (i.e. version 0.3)
2602 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2603 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2604 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2605 * *.dsp : modifications to use new libgdcmijpeg8 library
2606 * setup.py : bug fix on VTKPATH variable
2607 * PACKAGER : adding all concerning windows
2609 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2610 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2612 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2613 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2614 test suite reported error.
2615 * PACKAGER file added (describes what a packager must do when
2616 packaging a new release).
2617 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2618 * configure.in: upgraded version number to 0.3.0
2619 * fixing build of rpm (through rpm -ta):
2620 - Doc/Makefile.am exports proper doxygen files
2621 - src/jpeg/libijg8/Makefile.am exports the include files.
2623 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2624 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2625 * src/gdcmHeader.h : formatting code
2627 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2628 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2629 We were obtaining error message from vtk. Now, creation of file list
2630 is made in an internal list to prevent this problem.
2631 Bug fix when output is empty.
2632 Bug fix in update of progress value. Previous commit for this was a bad
2634 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2636 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2637 * src/gdcmHeader.h : added method to get the file name
2638 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2639 files. Added method to remove all files on the input
2640 Added FIXME comment concerning the bad parsing of header made by
2641 ExecuteInformation method (in ExecuteData method)
2643 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2644 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2645 when using make instal.
2646 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2647 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2649 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2650 * setup.py : adding include dir of jpeg lib to compile all sources
2651 * */Win32/*.dsp : JPR fix for windows compilation
2653 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2654 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2656 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2657 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2659 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2660 * setup.py is again effective on un*x (takes into account the
2661 addon of the jpeg library)
2662 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2663 * Doc/Doxy* updated (includes above enhancements)
2664 * INSTALL now points to web documentation
2666 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2667 * src/gdcmHeader.h doesn't make unnecessary reference to
2669 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2671 * src/gdcm*.[cxx|h] :
2672 - to allow compilation with gcc 3.x
2673 -- clean up of STL usage (added explicit usage of std::)
2674 -- small fixes on exceptions.
2675 Note: linking not tested !
2676 - clean of doxygen comments to avoid warnings at documentation
2678 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2679 dependent convertion).
2681 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2682 * Clean up of previous JPR garbage commit (not even commented in the
2684 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2685 - moved all jpeg related files from src to src/jpeg/libijg8, with
2686 addition/modification of Makefile.am and configure.in.
2687 - the testSuite is still brain damage (not guilty).
2689 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2690 * WrapVTK.py : modifications to get correctly vtk source files to
2692 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2693 (FileName -> Filename)
2695 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2696 * vtk/vtkGdcmReader.[cxx/h]:
2697 - UpdateProgress method should now be effective
2698 - removed the limitation on having only images loaded (as opposed
2700 - when building a stack of images/volume, a lesser number of
2701 gdcmHeader and gdcmFile instances should be used (hopefully
2702 accelerating things).
2703 - when building a stack of images/volumes, files which are not
2704 loadable (wrong path-filename, wrong permissions on existing file,
2705 or file not parsable by gdcm) are replaced with a black image
2706 in the stack (for the caller to notice the problem).
2708 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2709 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2711 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2712 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2713 between standard library (std) and vtk library (problems are found
2714 under Windows... thanks Windows !)
2716 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2717 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2719 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2721 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2722 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2724 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2725 * When compiling with distutils (see setup.py) the C++ compiler is
2726 called with different flags than the default ones (with automake).
2727 In order to fix all those warning, I compiled gdcm with the command
2728 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2729 and went for warning fixes:
2730 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2731 up from unused variables.
2732 - vtk/vtkGdcmReader.cxx: potential bug fix.
2733 * src/gdcmHeader.h: Doxygen warning cleanup
2735 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2736 * gdcmPython/gdcm.i:
2737 - typemaps correction to take into account the systematic replacement
2738 of "using namespace std" with std:: prefix e.g. std::list,
2739 std::string... (cf changes of 2003-05-21).
2740 - gdcmGlob global variable of type gdcmGlobal (defined in
2741 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2742 exported to Python a as cvar.
2743 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2744 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2745 gdcmDictSet.GetPubDictTagNames() and
2746 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2747 C++ static methods).
2748 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2749 with the above changes.
2751 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2752 * setup.py, manifest.in : bug fix under linux
2754 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2755 * Modification of setup.py to compile vtk part too. Then, we have 2
2756 wrappers which must work with same distutils. For that, we have a
2757 generic distutils in distusiltsWrapping.py ; with :
2758 - build_extWrap class to wrap generically all extensions,
2759 - ExtensionWrap base class for all wrapping extension that contains
2761 - Wrapper interface which wrap sources
2762 + In WrapSwig.py we have extension and wrapper for Swig
2763 + In WrapVTK.py we have extension and wrapper for VTK
2764 * MANIFEST.in : modifications to consider vtk directory and new python
2765 files for compilation
2767 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2768 * Added python wrappers of vtkGdcmReader vtk class (see the
2769 source in vtk/vtkGdcmReader.cxx) :
2770 - vtk/Makefile.am now builds a library
2771 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2772 python library (as opposed to _gdcm.so wich are the python
2773 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2774 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2776 - configure.in has an additional flag --enable-vtk that needs
2777 to be set to enable compilation of vtk related code, that is:
2778 + vtk/vtkGdcmReader.so and
2779 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2780 + gdcmPython/vtkgdcmPython.so (see above)
2781 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2782 be read when compressed or when HighBit + 1 != BitsStored),
2783 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2784 the usage of the python wrapper of vtkGdcmReader vtk class.
2785 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2786 * src/*.[h] all occurences of stl classes are now prefixed with
2787 std::, and all occurences of "using namespace std;" where removed.
2788 This is to avoid pollution of global namespace in included files.
2789 Apparently vtk does not avoid this pitfall: when using both
2790 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2791 collision of various stl members (principally cout...).
2792 * gdcmPython/testSuite.py now cleanly removes temprory generated
2794 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2795 comply with above changes)
2797 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2798 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2799 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2800 vtk data structure (an image Flip was required).
2801 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2802 * cosmetic changes in documentation.
2804 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2805 * src/gdcmHeader.cxx: the constructor no longer exits when an
2806 unexisting file is given as argument.
2807 * The subdirectory Data (containing all the images used for the
2808 test suite) is not part of this repository anymore. A new module
2809 containing those images is now available at
2810 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2811 with the name gdcmData.
2812 All the python scripts (including the package initialisation file
2813 gdcmPython/__init__.py) were adapated to take this change into
2814 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2816 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2817 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2818 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2819 demo of the usage of this class.
2820 Compilation of this vtk part is only done when using the --enable-vtk
2821 at configure (or autogen.sh) stage.
2823 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2824 * More memory link related corrections and documentation fixes.
2826 - maximum info is obtained with a command of the form:
2827 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2828 --show-reachable=yes PrintHeader
2829 - the remaining reachable blocks seem to come from the STL
2830 allocation scheme through the usage of map and list. It looks
2831 like this memory cannot be freed but it is not a memory leak
2832 (in fact further invocation to the STL would recollect the
2833 unused memory allthough it cannot explicitely be freed).
2834 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2835 of displaying an image parsed with gdcm and displayed with VTK.
2836 Note: some images don't seem to work e.g.
2837 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2838 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2839 Allthough this weakens the semantics, it is a ditch attempt to
2840 make gdcm more thread friendly.
2842 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2843 * Memory link hunt (by using valgrind through the command
2844 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2845 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2846 gdcmHeader::_dicom_vr.
2847 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2848 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2850 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2852 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2853 * src/Makefile.am now exports all the necessary include files at
2857 * UpdateGroupLength replaced by new one
2860 * UpdateGroupLength re-written using H-Table
2861 (named UpdateGroupLengthNew untill checks are over)
2863 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2864 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2865 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2867 - gdcmHeader::GetPubElValSet removed.
2868 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2869 UpdateGroupLength, WriteElements, Write.
2870 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2871 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2872 carried the same semantics.
2873 - src/gdcmHeaderIdo.cxx changed accordingly.
2874 - gdcmFile::WriteBase now regroups all the codes from previous
2875 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2876 - enum FileType moved to gdcmCommon.h
2877 * src/gdcmHeader.cxx AddDefault trashed
2878 * gdcmGetXSize added
2879 * getimageDataSize now calls gdcmGetXSize
2880 * Test/*.cxx changed to agree with above changes
2882 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2883 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2884 (to avoid double call by end user).
2885 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2886 by end user, since gdcmHeader::gdcmHeader now handles it.
2888 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2889 * gdcm/Doc many doxygen changes:
2890 - Doxyfile now has two different versions, DoxyfileUsers that generates
2891 the html.users end users oriented documentation and
2892 DoxyfileDeveloppers that generates the html.developper developper
2893 oriented documentation.
2894 - README changed accordingly
2895 - requirement.txt removed (old design info moved to TODO).
2896 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2897 DoxyMainPage.txt, DoxyPython.txt provide more information.
2898 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2899 be updated by simply regenerating the docs with doxygen and copying
2900 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2901 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2902 all the tests in the form "if (<map>.count() >1)" were removed.
2903 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2904 ill-formed documentation sections.
2905 * src/gdcmHeader.cxx: ditto
2907 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2908 * setup.py fixed for un*x (needed macro for stdint.h)
2909 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2910 un*ces with sh-utils test utility.
2911 * gdcmPython/demo/test.py renamed to PrintHeader.py
2912 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2913 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2914 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2915 * src/gdcm*.cxx JPR's bad inclusion fixed.
2917 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2918 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2919 * gdcmPython/demo/test.py changed accordingly.
2921 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2922 * gdcmPython/Makefile.am fixed linking against libstdc++
2923 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2924 * Swig subdir (historical tests of swig version 1.3.17++) removed
2925 * Test/testChangeEntete.cxx some lines commented out in order to make
2927 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2928 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2930 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2931 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2932 hence the user doesn't need this explicit call.
2933 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2934 i.e. LoadElements() call removed.
2935 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2936 - src/Makefile.am declares the proper flag for g++.
2937 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2938 for adding user defined new tags.
2939 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2940 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2941 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2943 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2944 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2945 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2946 src/Makefile.am : the project should properly compile and install
2947 with the autotools, included the python wrappers part.
2948 * gdcm.spec.in : added a spec file for RPM packaging.
2950 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2951 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2953 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2954 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2955 to exported to the environement (see gdcmPython/testSuite.py
2957 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2958 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2959 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2960 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2961 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2963 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2964 * gdcmPython/__init__.py doesn't crash anymore when running in
2965 in InstallMode or PreInstallMode but with an environment given
2966 value of GDCM_DICT_PATH.
2967 * src/gdcmDictSet.[cxx/h] coding style.
2969 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2970 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2971 * src/gdcm.h general comments moved to TODO, and README
2972 * src/gdcm.h should now be seen as a user commodity (including it
2973 should suffice to fully use gdcm). It is nowhere including within
2974 any of the kernel files src/*.cxx and src/*.h.
2976 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2977 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2978 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2980 * src/gdcm*.cxx only include their corresponding include file
2981 (as opposed to gdcm.h)
2982 * gdcmPython/gdcm.i changed accordingly
2983 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2984 the autogen.sh generated "make snapshot" command to work.
2985 * autogen.sh removed history related references to crea package.
2987 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2988 * distutilsSwigCPlusPlus.py work around some swig portability
2991 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2992 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2993 was done in a last ditch attempt to get setup.py _really_
2994 operationnal. The python/gdcmPython layaout add the advantage
2995 of hidding away the python related distutils specific files
2996 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2997 Alas, the src directory was out of scope (i.e. it's relative
2998 position to setup.py was ../src) which made things impossible to
2999 handle (see previous version of python/setup.py). Crossing fingers...
3001 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3002 * python/setup.py now works on Un*x. (harder than I thougth)
3003 * python/distutilsSwigCPlusPlus.py can now have include files
3004 among the list of sources.
3006 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3007 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3008 * modifications in MSVC projects
3010 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3011 * As stated by the first lines of Test/ExceptionAndPython/README, it
3012 looks like we can move back to original usage of exception within
3013 src/gdcm* and hence remove the errno stuff that was introduced
3014 as a quick and dirty fixture of this problem (added to the TODO).
3015 * Doc/Doxyfile configuration file for Doxygen and corresponding
3016 README file for usage added.
3017 * Test/testWrite.cxx added. This new test comes from a split of
3018 test.cxx that is now reverted to its original purpous i.e.
3019 testing the proper parsing of a Dicom related file.
3020 testWrite.cxx concentrates on testing the IO part of gdcm.
3021 * Test/bug1.cxx (containing a bug on WIn32) added.
3022 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3023 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3024 whose purpose is to publish the content of the TagNames of the
3025 Dicom public dictionary were not accessible without an
3026 instance of class gdcmHeader.
3027 - those methods are now static methods of gdcmDictSet and hence
3028 require no instances at all to be invocated.
3029 - within gdcmDictSet this change required to change some method
3030 to class methods (i.e. are now static) among which SetDictPath
3031 (renamed to BuildDictPath) and LoadDefaultPubDict.
3032 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3033 the above changes by calling the new method classes of gdcmDictSet.
3034 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3035 the above to be effective.
3036 * python/gdcmPython: in order to wrap properly the above changes
3037 for Python, swig version now needs to be > 1.3.17.
3038 * python/gdcmPython/Makefile fixed to adapt itself to new
3039 configure/make shema introduced by Johan Montagnat (thanks for the
3040 contribution). Alas this Makefile cannot be turned into a proper
3041 Makefile.am without some heavy changes in the configure.in
3042 (for python dectection).
3043 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3044 now avoids publishing the empty entries.
3046 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3047 * python/setup.py : bug fix concerning install under windows
3048 ExtraPath reused :-P
3049 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3051 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3052 * Dicts/dicomV3.dic : remove double spaces !!!
3053 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3054 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3057 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3058 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3059 method. Doxygenation.
3060 * src/gdcm.h clean up of JPR spurious comments.
3062 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3063 * python/distutilsSwigCPlusPlus.py now properly collects the
3064 shadow classes generated by "swig -c++" (gdcm.py in our case)
3065 when using "python setup.py install".
3066 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3067 reexports the working classes.
3068 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3069 by the classical C errno scheme. This is to prevent an obscure
3070 behavior of the python wrappers when importing wxPython.wx prior
3071 to gdcmPython (which ended up in an abort call). An illustration
3072 of this oddity can be found in the Test/ExceptionAndPython
3073 subdir (see the README file). This problem probably due to
3074 an combination of g++ and dynamic loading.
3075 * added Test/ExceptionAndPython (see above)
3077 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3078 * Changed the layout of the python part to avoid bloating main
3079 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3080 i.e. the distutils arsenal. All the python related stuff is
3081 again in a python subdir, but the package itself is now in
3083 * setup.py was cleaned up:
3084 - pythonIncludePath removed
3085 - python setup.py bdist target is now functional.
3086 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3087 collision with other packages). gdcmPython/demo/*.py changed
3090 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3091 * python subdir moved to gdcmPython (preparation of distutils packaging).
3092 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3093 distutils installer is operational.
3094 * - gdcmPython/__init__.py now properly loads the swig generated
3095 shadow classes (from gdcm.py).
3096 - gdcmPython/demo/*.py changed to import the package gdcmPython
3097 instead of gdcmPython/demo/load.py.
3098 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3100 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3101 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3102 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3103 entries within the associated public Dicom dictionary resp. the same
3104 information but sorted by the fourth field (PAT, IMG, DIR) of the
3106 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3107 are now in the "???" group.
3108 - python/gdcm.i changed accordingly,
3109 - python/demo/printGroupedPublicDict.py added, that gives an example
3110 of the above new functionalities in Python.
3112 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3113 * src/gdcm.h, gdcmHeader.cxx:
3114 - historic references to glib's g_malloc and g_free (#defined)
3115 were definitively removed.
3116 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3117 * src/gdcmElValSet.cxx:
3118 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3119 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3120 - GetElValue(string) renamed to GetElValueByName.
3121 - Added GetElementByName(string).
3122 * src/gdcmHeader.cxx: added
3123 - GetPubElValRepByNumber(guint16, guint16)
3124 - GetPubElValRepByName(string)
3125 - GetShaElValRepByNumber(guint16, guint16)
3126 - GetShaElValRepByName(string)
3127 - GetShaElValByNumber(guint16, guint16)
3128 - GetShaElValRepByName(string)
3129 - GetElValRepByNumber(guint16, guint16)
3130 - GetElValRepByName(string)
3131 - GetElValByNumber(guint16, guint16)
3132 - GetElValRepByName(string)
3133 * Doc/requirements.txt added.
3135 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3136 * Test/Makefile building now depends on the one of libgdcm.so
3137 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3138 pixel data) aware which enables finding the address (offset) of
3139 the pixel data of JPEG encoded DICOM files. This leaves only a single
3140 file in the testSuite whose pixel data address (offset) is unknown.
3141 * python/testSuite.py changed accordingly.
3143 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3144 * VC++ has some strong limitations when working with the STL, as stated
3145 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3146 "Also note that some STL containers (map, set, queue, list, deque)
3147 cannot be exported. [...]
3148 Some STL classes contain nested classes. These classes can not
3150 This is caused by a designed limitation that once a template
3151 class is instantiated, it can not be re-instantiated and
3153 Since our usage of map<> is ubiquitous in gdcm, this "designed
3154 limitation" of VC++ is a pitfall.
3155 Hence the Python wrappers of gdcm cannot be incrementally linked
3156 against the c++ dynamic library. The dirty but only workaround is
3157 to forget about incremental link of dynamic libraries and to generate
3158 the Python wrappers library with the inclusions of the underlying C++
3160 The following modifications concern this matter on Win32/VC++:
3161 - wrapping python correct with standalone wrapped dll (don't use separate
3162 dll under windows !!!!)
3163 - python21_d debug mode enabled (ask Frog how to use it :-)
3164 - NO problem with having an STL member of class for example string in C++
3165 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3166 - Python test of dcmlib in Python is ok under windows on a large set
3168 * removed glib references
3169 * typedef's inserted in gdcm.i for correct swig type management
3171 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3172 * python/demo/*.py load.py extracted from test.py. Added explore.py
3173 that only displays required tags and testAll.py that parses all
3174 the files of the testsuite without using unittest.
3175 * python/testSuite.py other additional test on new files added.
3176 * Data/* new test files added accordingly to the testSuite.
3177 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3178 the vr in the file differs from the one of the dictionary.
3180 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3181 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3182 values, but limits itself to values which are below a user specified
3183 size (by default 1024 bytes).
3184 * python/gdcm.i : elements not loaded (because their size is above the
3185 user specified treshold) are exported with their TagKey as key of the
3186 python dictionary. This enables the testsuite to make some checks
3187 on the unloaded elements (since we have their offset and size).
3188 * python/testSuite.py
3189 - now tests for the existence and proper value of the pixel data
3190 - two new examples added.
3191 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3193 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3194 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3195 aware. See the strategy comments in gdcmHeader::FindeLength().
3196 * Test/test.cxx now accepts a filename as first argument.
3197 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3198 * python/testSuite.py changed to integrate test on above files.
3200 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3201 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3202 the vr was also RET.
3203 * python/testSuite.py more tests added.
3205 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3206 * python/testSuite.py unittest test suite added (uses Data)
3207 * Data/* dcm and acr files for the test suite.
3208 * glib dependance removed from un*x version. We now use ISO C99
3209 7.18 Integer types (see stdint.h)
3210 - python/Makefile, src/Makefile src/gdcm.h
3211 * src/ when an explicit vr (like dicom files) suddenly poped an
3212 implicit element we use to mark the underlying DictEntry of the
3213 concerned ElValue with "Implicit". This strategy was damageable
3214 too the public or provite dictionaries, since some of their vr
3215 would be changed. Since Header::FindLength heavily relies on the
3216 detection by Header::FindVR of falsely explicit elements, I
3217 added an extra ImplicitVr member to ElValue (boolean).
3218 The rest of the changes we the necessary adaptations.
3220 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3221 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3223 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3225 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3226 * Adaptation for porting to VC++:
3228 o forced to use std namespace (for string to be known)
3229 o all class use __declspec export style on WIN32
3230 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3231 (in stdlib.h on Win32 but in std:: for gcc)
3232 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3233 variable GDCM_DICT_PATH.
3234 * src/gdcmHeader.cxx verbose comments made discrete.
3236 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3237 * python/gdcm.i: added a typemap that converts a C++ hashing table
3238 to native Python dictionary.
3239 * python/demo/test.py:
3240 - now uses the native dictionary for exploration of gdcmHeader.
3241 - takes an optional filename argument (the file to parse).
3242 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3243 PubElVals hashing table.
3244 * Dicts/dicomV3.dic removed error prone trailing spaces.
3246 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3247 * Python wrapping process moved away from src/Makefile to
3248 newly created python/Makefile (as well as gdcm.i)
3249 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3250 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3251 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3252 from the environement variable GDCM_DICT_PATH (when existing).
3253 * src/gdcmDict::GetTag bug fix.
3255 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3256 * Straightforward temporary fixes for swig to build the python wrappers.
3257 src/Makefile now has a python working entry [by working we mean
3258 that we can import de shadow classes without errors].
3260 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3261 * hashtest.cxx removed (since already in Test)
3262 * src/gdcmlib.h renamed to src/gdcm.h
3263 * src/dcm.i renamed to src/gdcm.i
3264 * src/Makefile prepared for python wrapping
3266 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3267 * src/gdcmHeader.cxx :
3268 - Parsing of header is now separated from loading of element values
3269 (see gdcmHeader::LoadElements).
3270 - general clean up of hopefully all file access (creation of
3271 ReadInt16 and ReadInt32)
3273 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3274 * src/gdcmHeader.cxx :
3275 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3277 - SetLgrElem renamed to SetLength
3278 - GetLgrElem renamed to GetLength
3279 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3280 * src/gdcmElValSet.cxx fixed both GetElValue methods
3281 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3282 due to IdoDude was cleaned out.
3284 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3285 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3286 concentrates on finding the value representation (when it exists).
3287 RecupLgr now only finds the element value length, and it avoids
3288 returning the unecessary skL (skipped length).
3289 Also, offsetCourant was simply removed (with taille_fich) since
3290 it was redundant with the File position internals (by using
3291 ftell and fseek). This also made skL (see above in RecupLgr) usage
3293 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3294 on the libido specificities which are handled through class
3296 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3299 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3300 * Truckload of changes. Parsing of header is barely functional
3301 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3303 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3304 * src/gdcmHeader.cxx many addons of low level methods
3306 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3307 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3308 and _IdDcmSWAP_LONG.
3310 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3311 * This corresponds to all the changes decided at the meeting of
3312 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob