1 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
3 Remove all access to the hash-tables or lists in the objects.
5 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
7 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
8 be complient with all the gdcm source code
10 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
14 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
18 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * Test/ : rename VTK tests to have a best name for the tests
20 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
21 GetFirstEntry/GetNextEntry use
23 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
25 test. Now it's on image content and not on the resulting visualisation...
26 might solve the problem on linux when using the OpenGL drivers
28 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
29 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
30 DicomDirSerie, DicomDirImage
31 Dict, DictSet classes :
32 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
33 -remove InitTraversal method.
34 * UPD Test programs + Example programs
36 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
37 remove useless and never updated keyword \ingroup
39 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
41 is no memory access violation
42 * gdcmPython/demo : add python demos using VTK
44 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
45 * FIX 'Dictionnary' is now spelt 'Dictionary'
46 'wether' is now spelt 'whether'
47 'archieve' is now spelt 'archive' ;-)
49 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
50 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
51 related methods, in order not to expose internal mechanisms
54 * REM methods that exposed internal mechanisms :
55 DicomDir::GetDicomDirPatients()
56 DicomDirPatient::GetDicomDirStudies()
57 DicomDirStudy::GetDicomDirSeries()
58 DicomDirSerie::GetDicomDirImages()
69 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
70 * Removed the Print/indent/default parameter mess. There is absolutely no
71 reason to have to methods, moreover with the second taking the ostream as
72 *SECOND* parameter. This was clearly a bad hack to get things compile.
74 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
75 * Complete rewrite of the GetMacAddress code. Now the code is *much*
76 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
77 Unfortunately the main code does not work on SunOS, thus provide a specific
78 code for this platform only (and Win32 of course). Since this seems to be
79 working, change CreateUniqueUID to use GetMACAddress instead of the
80 problematic GctestetIPAddress
82 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
83 * Unfortunately to be able to test gdcmDirList I had to break the API
84 a little. Now the class is not a std::list anymore but has a member
85 std::vector (more ITK compatible). Allow unit testing on Win32 and
88 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
89 * Update SerieHeader to take into account a Serie Instance UID to properly
92 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
93 * ENH - Comment out Mathieu's (dangerous) Super Hack
94 for dealing with BIGENDIAN processors
95 - Move equivalent stuff to BinEntry::WriteContent
96 When necessary, 16 Bits Pixels are swapped in a small buffer
97 and then written. This avoid allocating a huge buffer, in
98 PixelWriteConvertor, and avoid modifying the Pixel Area.
100 Probabely, the same operation will have to be done when we want
101 to write image with Big Endian Transfert Syntax,
102 and we are working on Little Endian Processor
104 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
105 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
107 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
108 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
109 all the dict content.
110 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
112 * Test/TestDict.cxx : add a new test for the dict classes
114 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
115 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
116 file. Debug is yanked if compiled with NDEBUG
118 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * src/gdcmDictSet.h : set the default output to the os variable
120 * src/gdcmDictEntry.[h|cxx] : add the Print method
121 * gdcmPython/demo/ : add a new test
123 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
124 * merging of Test/PrintDicomDir and Test/TestDicomDir
125 * removal of now redundant Test/PrintDicomDir
126 * enhancement of Example/PrintDicomDir
128 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * Now, python test might work on systems
130 * Add the PrintDicomDir test
132 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
133 * FIX : First entry following group 0002 was lost for
134 Explicit Big Endian Transfer Syntax files
135 (group and elem not swaped)
137 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
138 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
139 Big Endian Transfer Syntax supposed the group following 0002
140 begins always by element 0000 (element 0000 is *optional*)
141 To avoid further troubles, let's be pessimistic, and use
142 Document::HandleOutOfGroup0002() method
143 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
144 (related pb not yet solved)
146 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * Bug fix for the python part use
148 * Now, PrintHeader.py pass... but outside the ctest use. shit !
150 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
153 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
154 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
155 a string and should ask the global TS dict what are the propreties of
158 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
159 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
160 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
161 to swap the Swap Code, at parsing time, when we come out of group 0002
162 and Transfer Syntax is Big Endian
163 We should be able to read now 'true DICOM" Big Endian coded images
164 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
165 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
167 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
168 * Hopefully fix the bug on MacOSX and static global initialization.
169 This is the only -minor- patch I found that both please MacOSX and VS6.
170 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
171 but this would require a lot of change. Another approach would be that Global
172 create those string and GDCM_UNFOUND becomes a pointer to a string (which
173 gdcm::Global would destroy at exit).
175 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
176 * Fix bug on MacOSX with static initialization in a multy threaded
177 environment. static const string in a header file used to be ill
178 initialized provoquing the freeze of any tests. patch should solve this
181 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
182 * According to Benoit's suggestion, and without any objection from anybody
183 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
184 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
185 - method gdcmDicomDirObject::GetEntry() renamed as
186 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
188 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
189 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
190 you debug/warning message just as c++ streams which make them very convinient
191 to use. Once this is stabilize I will change the ostringstrem to be
192 redirected to a file (ofstream).
193 * Properly support C99 extension: __FUNCTION__ which allow us to display
194 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
196 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
197 * Removal of useless and dangerous methods :
198 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
199 GetDocEntryByName, GetEntryByName, GetDictEntryByName
200 * Removal of usless methods :
201 Dict::PrintByName, Dict::GetDictEntryByName
202 * Commenting out of probabely useless methods :
203 Dict::GetDictEntryNames()
204 Dict::GetDictEntryNamesByCategory()
205 DictSet::GetPubDictEntryNames()
206 DictSet::GetPubDictEntryNamesByCategory()
207 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
208 * ENH : Use dicomTS.dic as described in 2004 version
209 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
210 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
211 Add Accessors on VM (Value Multiplicity), and VM related methods
212 * ADD : Add a list of 'Dicom Attribute types', as found in
213 http://medical.nema.org/dicom/2004/04_15PU.PDF
215 * ADD : Add dicomGroupNameAbbreviations.dic
216 should be used to write a method to replace the former
217 Dict::GetDictEntryNamesByCategory()
219 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
220 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
221 to read in the file... and only it ! Length is the efective length of the
222 data in the DocEntry structure
224 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
225 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
226 And now use a static function call instead, with a global variable. i
227 This is much closer to the VTK approach. Hopefully should be bulletproof
228 and easier to use...hopefully
230 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
231 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
233 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
234 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
236 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
237 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
238 ValEntry, BinEntry, SeqEntry creation or replace
240 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
242 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
244 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
245 when specifying the VR
246 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
247 * src/gdcmDocEntry.cxx : amelioration of print
249 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
250 * ADD : Add the method Util::IsCurrentProcessorBigEndian
251 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
252 * ADD Method Document::ComputeGroupLength
253 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
254 in order to allow further VR modification by user
255 * REM : removal of once-called method File::WriteBase
256 integration of its code in formerly one-line method File::Write
258 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
260 replace the different values "??", "Unkn", "Unknown".
261 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
262 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
263 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
264 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
266 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
269 * Set the gdcm::Base class to some Printable classes
271 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
272 * src/gdcmFile.[h|cxx] : add the Print method
273 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
274 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
275 * src/gdcmDocument.h : remove the PrintLevel informations
276 * Example/PrintFile.cxx : use the new gdcm::File::Print
278 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
280 problems when compiling with the python wrapping
282 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
283 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
284 writting in ImplicitVR
286 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
287 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
288 JPEG decompression, especially when dicom frames are split into several
289 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
290 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
292 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
293 * src/gdcmHeader.cxx : change the initialisation of default header.
294 Now, this header is readable by gdm, e-film, DicomWorks
296 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
297 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
298 Rename Decompressed to Raw
299 * Use the API changes in gdcm::File.
300 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
303 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
304 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
305 each added entry in the header. Replace the 'Planes' field by the 'Number
308 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
309 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
310 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
312 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
313 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
314 At this time, this image isn't readable by e-film... waiting JPR help to
317 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
318 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
319 DocEntry. Now use methods of the Document !
321 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
322 * Test/ShowDicomSeq.cxx : bug fix
324 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
325 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
326 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
327 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
328 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
330 * Test/TestCopyRescaleDicom.cxx : remove unused variable
331 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
332 containing found sequences
334 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
335 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
337 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
338 Some fields in BinEntry must be copied to not seg fault when making the :
339 gdcm::File *copy = new gdcm::File( copyH );
340 and tests are now made on good variables
342 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
343 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
344 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
346 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
347 * Add vtkGdcmWriter example and test
349 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
350 * Test/TestUtil.cxx : reformat the source code
351 * vtk/vtkGdcmReader.cxx : remove and change prints
352 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
354 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
355 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
357 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
358 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
359 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
361 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
362 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
363 by an eof to prevent all bad read of the file... and in this case, the
366 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
367 * Example/Volume2Dicom.cxx : comment unused variables
368 * Test/PrintDicomDir.cxx : comment unused variables
369 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
370 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
371 method that is redondant with AddEntry.
372 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
375 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
376 * Bug fix due my last commit (compilation under Windows).
377 * Example/Volume2Dicom : bug fix in the file and reformatting source code
378 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
380 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
382 - Remove printf / sprintf
383 - include iostream AFTER gdcm so we don't get warnings
384 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
386 - Also remove tons of include from header files, hopefully this should
387 speeup the compilation time, since it was becoming a dog slow.
388 - Remove gdcm.h as it include way too many files and slow down compilation
389 (plus it is not up to date)
390 - remove 'using namespace std' this is BAD !
392 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
393 * Remove memory leaks on the DicomDir
394 * Remove some useless data in DicomDirObject
395 * Add usefull methods in SQItem, to be complient withe the ElementSet
397 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
398 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
400 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
401 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
402 future, with convertion)
403 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
404 and ImageDataSize values. Remove the method to get the PixelReadConverter
405 from the output of the class
407 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
408 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
410 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
411 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
412 and vtkErrorMacro use.
413 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
415 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
416 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
418 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
419 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
420 The string leaves only in the fonction. So when we make a .c_str(), we
421 get the pointeur on the first element, element that will be destroyed
422 immediately after thee instruction.
423 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
424 file has been opened : the test must be made on the content of the
425 pointer and not directly on the pointer !
428 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
430 the python part recompiles
432 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
433 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
434 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
435 X session is killed (for my computer... it seems to not be identic on
438 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
440 avoid problems (otherwise, the difference test between the visible image
441 and the reference is incorrect. If the reference is greater than the
442 screen resolution, it's produce errors).
443 Can be used for only one image. Can be used with a visible flag.
444 * vtk/vtkGdcmReader.cxx : remove commented codes.
445 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
446 under windows at compilation
447 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
449 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
451 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
452 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
453 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
454 tests on the image size X, Y, Z
456 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
457 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
458 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
459 between the class name and the file name
461 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
462 * src/ : fix compilation warnings for the Write method (2 different
463 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
464 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
465 variable... create a static method in gdcm::Document to access to
466 this variable content.
468 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
470 file, to be accessed by other files (like gdcmFile). Remove commented
471 code. Move the change of the header to the gdcmFile, using the
473 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
474 To be sure of that (and simplify calls), the Write of the header now
475 gets a file name and not a file pointer (std::ifstream).
476 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
477 DocEntryArchive. Remove all open of the written file
479 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
480 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
482 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
483 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
484 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
486 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
487 some corresponding methods. Write correctly the file and check before
489 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
490 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
491 is now on RGB data (as before my last commit
492 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
494 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
495 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
496 Add a print information of the type of the entry
497 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
498 It was in the gdcmFile, and all write have been regrouped
499 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
500 Write correctly all dicom files (in decompressed mode only at this time)
501 * Test/ : test on files are now made using Raw data and not color data if
503 * Example/PrintFile.cxx : add more printings
505 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
506 * Amelioration of code, remove some code copy. For the loading of
507 BinEntry (in gdcmDocument), add the test to verify if the file is already
510 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
511 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
512 remove a DocEntry in the header (push an empty DocEntry)
513 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
514 lines. Bug fix in the initialization of the PixelConvert and the
516 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
517 use in TestCopyDicom (now this test can run under windows... but fails)
518 * Test/TestCopyDicom.cxx : amelioration of the test :
519 - test the pixels written
520 - add test points to quickly find where is the error
521 - can set a file name input and output in arguments
522 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
523 amelioration of the test output
525 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
526 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
527 all replaced DocEntry's
528 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
529 Now, each needed DocEntry to modify is duplicated, modified and inserted
530 to the header using DocEntryArchive. Thus, after save, we can restore the
531 header initial state.
533 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
534 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
536 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
537 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
538 correct to copy it. The DictEntry is specified at the DocEntry creation,
539 then, it musn't change in the time.
540 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
541 header correctly. At this time, the change is only made for the first
542 level of the Document. In the future, it might consider sequences.
543 The change is made by replacing a DocEntry by an other that is created
544 outside the class. The old value is kept. When we restore the header
545 status, the added DocEntry is deleted and replaced by the old value.
546 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
547 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
548 set the write type to explicit VR, implicit VR or ACR. Add methods to set
549 the write mode to native, decompressed or RGB (but not used at this time)
551 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
552 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
553 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
555 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
556 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
557 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
559 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
560 set because already copied when copying the BinEntry's of the header
561 * Test/TestAllReadCompareDicom.cxx : remove warnings
563 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
564 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
565 Two problems appear when doing it :
566 - with the gdcmFile : when the GetImageData method is called, the pixels
567 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
568 data (pixels). And each structure destruct the data when it's
569 destructed. So we have two destructions for the same data. To solve it,
570 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
571 data or not. If it doesn't own data, then they will not destroyed by
573 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
574 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
575 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
576 create a double destruction of the same DocEntry's. So, to solve it,
577 the TagHT is simply cleared and the DicomDir* elements are destroyed.
578 * TODO : add an entry concerning memory leaks in the DicomDir
580 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
581 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
582 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
585 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
586 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
587 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
588 after it have been deleted
590 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
591 * FIX: src/* fix the doxygen warnings.
592 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
593 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
594 was erroneously defined with a size of 15 instead of 16. [many thanks
595 to Jean Michel Rouet for pointing out this bug].
597 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
598 1. Finish merging JMR patch for writting DICOM from scratch
599 2. Fix -hopefully- bug with MONOCHROME and space vs null character
600 3. Use const ref when possible
601 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
602 5. A few more comments
603 6. CreateUniqueUID can now be called without parameter"
605 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
606 * ENH: Slightly bigger patch:
607 1. Getting toward full integration of JMR patch for writting dicom from scratch
608 2. Update Test to test part of this patch: CreateUniqueUID
609 3. File was not close properly in gdcmDict
610 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
611 5. Use of const ref instead of copy (speed issue)
612 6. Remove temporary (duplicate) string in TranslateToKey
613 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
614 8. Do not repeat virtual in subclasses
615 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
617 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
618 * Apply first patch toward better string comparison when dealing with broken
619 DICOM files. Essentially the string could be padded with a space instead
620 of a null character as defined by standard
622 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
623 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
624 because never used... and in the same time, that's remove some memory leaks
626 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
627 * src/gdcmFile.cxx : now delete the PixelConvert instance.
628 * In examples and tests : change the type of image data variables from void*
629 to uint8_t*. Remmove all delete on image data variables
631 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
632 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
633 Verify the file pointer value before open the file, and if it's not null,
634 a verbose message is generated.
635 Close correctly the file when the file isn't considered dicom-like. The
636 correctly close is a call to CloseFile.
637 When closing the file pointer, test if its not null to close the file.
638 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
639 file. For an uncompressed image, the copied data correspond in the least
640 case to the image size (calculated) or the image size specified in the
641 header. A verbose is generated if these two size mismatch
643 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
644 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
645 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
646 break under windows (with msvc6 compilation).
648 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
649 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
650 compiling with MSVC6)
652 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
653 * Bugs fix for the Windows build with VC6
654 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
655 needed (only for projects required VTK). If the VTK is included in all
656 projects, there is conflicts with the jpeg lib of vtk when compiling the
657 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
658 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
659 when compiling the gdcm_wrap.cxx file (created by the compilation of the
661 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
662 (like it's already made for the cout use). Otherwise, conflict with the
665 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
666 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
668 - comments on the DicomDir::Method related usage added.
669 - now that we use the namespace gdcm, a lot of internal classes do
670 NOT need to be wrapped anymore.
671 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
672 DicomDir::Method) new example added.
674 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
675 * Improve string manipulation. I now inforce the notion of 'DicomString'
676 A DicomString can contain as many \0 as they want
677 and it is *always* of even length.
678 We only support odd length for very rare case.
679 And in the near future this should be removed.
681 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
682 * /binary_write/ gdcm source. Now even on big endian we are writting
683 little endian. This should -heopfully- fix some tests
685 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
686 * Now the dictionary is compiled into gdcm lib. This is a default
687 behavior, thus any dic file specified is picked before failback to
688 the one comiled into lib
690 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
691 * Change internals for gdcmDict. Don't use any 'new' any more.
692 This should definitely solve any leak problem, and we should be
693 as fast as before, as long as don't modify too much the dictionary.
695 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
696 * STYLE: ivars should start with a capital letter.
697 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
698 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
700 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
701 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
702 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
703 new 2004 dictionaries added (thanks to JPR).
704 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
705 * CLEANUP_ROUND (15) for gdcmPixelConvert
706 - RLEFrame::NumberFragments is now of type unsigned int
707 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
708 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
711 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
712 * Initial work in gathering all transfer syntax accessors. clearly
713 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
714 ivars, but only one transfersyntax (class) ivar with equivalent method on
717 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
718 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
719 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
720 discussed (plus I didn't like having a 2000 lines patch not commited)
722 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
723 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
724 * CLEANUP_ROUND (14) for gdcmPixelConvert
725 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
726 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
727 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
729 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
730 anymore and hence avoids storing a copy of PixelConvert::Decompressed
731 into File::Pixel_Data.
733 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
734 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
735 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
736 * CLEANUP_ROUND (13) for gdcmPixelConvert
737 Substituted File::ParsePixelData() with PixelConvert::Print() new
739 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
740 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
741 method to those classes.
742 - src/gdcmFile.[cxx|h]:
743 -- Added a ::Print() method.
744 -- PixelConverter is now a reference instead of a member.
745 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
746 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
748 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
749 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
750 collaboration diagram and inheritance diagram should be generated with
752 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
753 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
754 pointlessly wrapped (see
755 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
756 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
757 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
758 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
759 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
760 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
761 -- File::Initialise: PixelConverter setup moved away to
762 PixelConverter::GrabInformationsFromHeader()
763 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
764 interpretation moved away to PixelConverter::BuildRGBImage()
766 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
767 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
768 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
770 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
771 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
772 displayed on Win32 when a brutal abort() occurs (because of uncatched
773 exception). See TODO new entry of this commit for more on this.
774 * TODO added new entry.
775 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
776 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
777 - HandleColor is no longer called from gdcmFile.cxx
778 - gdcmPixelConvert.cxx clean up on method arguments and internal
779 variable names for semantical coherence.
781 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
782 * Finished lossless transition, not only do we now read all lossless jpeg
783 images, without the need of the Cornwell lib, but we do read them properly now
784 * To reduce code (well to avoid code duplication), I defined a common place
785 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
786 redefine symbols. This is not perfect but this the best solution I found for a
787 compilation time jpeg option.
789 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
790 * Update jpeg ijg lib to support lossless jpeg implementation
791 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
793 * Also added a special copyright for dcmtk since we use their bugfixes.
796 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
797 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
798 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
799 matters, as stated in warning note at begining of %include section).
800 * src/gdcmDicomDir*.[cxx|h]: coding style
801 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
802 * src/gdcmJpeg8.cxx: doxygen fix.
803 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
804 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
805 from File:: to PixelConvert::.
807 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
808 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
809 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
810 - more code moved away from File:: to PixelConvert::
811 - fat setup of PixelConverter set in place in File::Initialise.
813 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
814 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
815 namespace at the file system level. So now you should convert your examples
817 gdcmHeader -> gdcm::Header
818 It would be nice if people keep in mind to no open the namespace, since it
819 allows compilation on broken plateform which were defining common symbol in
820 the standart namespace (like LP, Unknown ...)
822 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
823 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
824 The JPEG fragments are now parsed at the same stage than the RLE
825 information. All code related to JPEG is now in gdcmPixelConvert:
826 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
827 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
828 export a gdcmFile:: method. Those are simply global functions
829 (for the time being this is better than having them attach to
830 either gdcmFile:: or gdcmPixelConvert::).
831 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
832 and stores the result in a gdcmJPEGFragmentsInfo.
833 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
834 code (among other stuff) moved away from gdcmFile:; to
837 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
838 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
839 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
840 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
841 clean up of RLE related code.
842 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
843 - src/gdcmRLE.cxx removed
844 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
845 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
846 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
847 * CLEANUP_ROUND (9) for gdcmPixelConvert
848 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
849 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
850 away from gdcmFile:: to gdcmPixelConvert::.
852 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
853 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
854 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
855 This is because Parse7Fe0 used to parse the pixels to compute the
856 length. This task was passed over to FindDocEntryLengthOB() a long
857 time ago, EXCEPT I had forgotten the OW case...
858 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
859 we just recylce the code for parsing RLE fragments and computing
861 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
862 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
863 with the retired Parse7Fe0().
864 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
865 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
867 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
868 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
869 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
870 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
871 - src/CMakeLists.txt: alphabetic order reodering + new entries.
872 * CLEANUP_ROUND (4) for gdcmPixelConvert
873 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
874 to return an unused length.
876 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
877 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
878 this should be cleanner from the plane view. The iostream are erally a pain
879 to use to do simple stuff.
881 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
882 * Redo the compilation of the ijg jpeg library. Now only one source is
883 necesseray. No need to rename file by hand what so ever. CMake handle the
884 copying of the file within different directory, configure header file to
885 modify some symbol. The only addition made to ijg wasd a mangle table so
886 that symbol are different whether we are within 8bits or 12bits.
888 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
889 * Added documentation of vtkgdcmReader on Website:
890 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
891 with it's binary name).
892 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
893 the Website to be more complete.
894 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
895 doxygenated documentation.
896 - Doc/DoxyVtkGdcmReaderExamples.txt added
897 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
898 DoxyVtkGdmReaderExamples.html )
899 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
900 * CLEANUP_ROUND (3) for gdcmPixelConvert
901 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
903 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
904 * CLEANUP_ROUND (2) for gdcmPixelConvert
905 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
907 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
908 * CLEANUP_ROUND for gdcmPixelConvert:
909 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
910 - src/gdcmPixelStuff[h|cxx] removed
911 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
912 - src/CMakeLists.txt changed accordingly
914 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
915 gdcmVersion.py moved to newly created ATTIC related
916 gdcmPython/SetupOldies/ directory.
917 * Autotools clean up:
918 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
919 - autogen.sh configure.in acinclude.m4 python.m4 removed
921 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
922 * src/*.cxx *.h Reference to License.htm fixed to License.html.
923 * Doc/CMakeLists.txt, doxygen.config.in: fix.
924 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
926 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
927 * TODO updated with Mathieu suggestions. I proposed a template for
928 describing TODO entries and used it for new entries.
929 * Added Doc/Website/CodingStyle.html, Developpers.html,
930 DeveloppersPython.html, GdcmDataCvs.html and
931 DownloadVersion0_1.html, DownloadVersion0_3.html.
932 * Some Doc/*.txt Doxygen files (which do not really concern the
933 documentation itself, but the website) moved to html and
934 placed in directory Doc/Website:
935 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
936 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
937 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
938 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
939 * CMakeLists.txt changed accordingly.
940 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
941 DeveloppersPython.html
942 * INSTALL nows refers to Doc/Website/Installation.html
944 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
945 * Added Doc/Website directory, that contains a first raw version
948 2004-09-23 Jean-Pierre Roux
949 * FIX In order not to be poluted any longer by casting problems,
950 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
951 we can now delete[] it safely
952 * VoidArea is now called BinArea (less confusing name),
953 and all the methods called ...VoidArea... are now ... BinArea...
954 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
956 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
957 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
958 clear) TagHT, which is an inherited member of gdcmElementSet. It is
959 up to the destructor of gdcmElementSet to clean up TagHt and it's
962 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * Test/CMakeLists.txt: update to follow gdcmData renamings.
964 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
966 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
967 * ENH: added some utility method that builds a flat dictionary
968 holding all the Dicom entries contained in the recursive structure
969 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
971 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
972 BuildFlatHashTable() that build a flat dictionary.
973 - src/gdcmElementSet.h: added a new private GetTag() accessor.
974 gdcmDocument is now a friend of gdcmElementSet.
975 - src/gdcmElementSet.cxx: clean up.
976 - Example/FlatHashTablePrint.cxx added.
977 - Example/CmakeLists.txt changed accordingly
979 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
980 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
981 moved away from gdcmDocEntrySet (since this class is an abstract class
982 acting like an interface). SQDepthLevel and BaseTagKey are now
984 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
985 and associated accessors. Doxygenation of the class.
986 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
988 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
989 Use SQDepthLevel accessor instead. ::Print() adapted.
990 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
991 - src/gdcmDocument.cxx changed accordingly.
993 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
994 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
995 - The following is the doxygen comment of the typedef declaration
996 of gdcmTagKey in src/gdcmCommon.h:
997 gdcmTagKey is made to old an "universal" (as in URL, Universal
998 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
999 A dicom tag always has a group and an element, but a set of tags
1000 embeded in various (optionally nested) sequences and sharing
1001 the same group and element all share the same (group, element)
1002 "identifier". Hence the (group, element) cannot be used as an
1003 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1004 In order to construct a proper tag identifier (i.e. a key) we
1005 consider the following definition of a TagKey:
1006 - let Group, Element be the string representation of the
1007 group and element dicom tag members,
1008 - let ItemNumber be the string representation of the integer
1009 index of the considered item number of a sequence,
1010 Let the key of a tag embeded in a sequence, noted SeqTag, be
1012 /ItemNumber#Group|Element
1013 where "/", "#" and "|" are characters acting as separators.
1014 Then the general form of a gdcmTagKey is given by:
1015 Group|Element<SeqTag>
1016 where <SeqTag> means NO or many instances of SeqTag.
1017 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1020 but the gdcmTagKey of a tag "embeded" is the first item of
1021 a sequence, itself nested in the third item of a sequence is the
1023 0004|1220/2#0008|0082/0#0008|0090
1024 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1025 order to hold the new sequence compatible key. Previously, the
1026 GetKey() method would look in the underlying gdcmDictEntry.
1027 - src/gdcmDocEntry.cxx:
1028 -- constructor now copies the underlying DictEntry key, in the local
1030 -- ::Print: displays the member Key, instead of the (group, element).
1031 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1032 - src/gdcmDocEntrySet.h:xi
1033 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1034 -- now has a new BaseTagKey member.
1036 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1037 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1039 This poses the problem with the semantics of the following lines
1040 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1041 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1042 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1043 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1044 to the long FIXME note for what the problem is. Nevertheless in
1045 order to get things working the dicom dictionary was altered !
1046 Please fix things urgently...
1047 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1048 information), see above note on moving the member VoidArea. Nevertheless
1049 the following entries previously correctly set as US are now inproperly
1051 0028 1201 OW IMG Red Palette Color Lookup Table Data
1052 0028 1202 OW IMG Green Palette Color Lookup Table Data
1053 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1054 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1055 of gdcmDocEntry moved to gdcmSeqEntry.
1056 * src/gdcmSeqEntry.cxx: STYLE.
1058 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1059 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1061 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1062 * gdcmPython/testSuite.py: all the test suite in python is now moved
1063 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1064 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1065 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1067 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1068 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1069 to avoid inclusion recursion until STL is reached.
1070 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1071 mecanism. errno.h is not included in gdcm anymore.
1072 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1073 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1075 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1076 gdcmData/TestAllEntryVerifyReference.txt
1077 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1078 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1079 exception_on_error parameter.
1080 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1081 - vtk/vtkGdcmReader.cxx changed accordingly,
1082 - Example/*.cxx and Test/*.cxx changed accordingly.
1084 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1085 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1086 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1087 enable_sequences removed from gdcmHeader constructor and dependencies.
1088 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1089 * gdcmPython/demo/PrintHeader.py: dummy fix.
1090 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1091 skip_shadow removed from gdcmHeader constructor and dependencies.
1092 * Example/*.cxx and Test/*.cxx changed accordingly.
1094 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1095 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1096 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1098 2004-07-21 Jean-Pierre Roux
1099 * FIX Now, Parsing and Printing a DICOMDIR do work!
1100 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1102 2004-07-20 Jean-Pierre Roux
1103 * FIX Some brain damaged headers have Zero-Lenght fields
1104 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1106 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1107 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1108 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1109 variable (instance of gdcmDebug) by a definition macro, and the instance
1110 is now in static in the gdcmDebug class
1111 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1112 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1114 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1115 * WARNING: ctest now depends more tightly on gdcmData. You should
1116 check out gdcmData properly for things to run smoothly...
1117 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1118 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1119 we need the pixels not be loaded in order to use the ValEntry
1120 that displays position and size).
1121 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1122 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1123 be deprecated. If you have any doubts about the advantages of a
1124 modern scripting language (read Python) versus grass root C++ (i.e.
1125 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1126 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1127 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1128 Anyhow, consider documenting the gdcmData images in
1129 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1131 * Test/CMakeLists.txt:
1132 - now uses TestAllEntryVerify.cxx
1133 - specific comments on oldACR00001.ima (now renamed in gdcmData
1134 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1135 gdcmData/TestAllEntryVerifyReference.txt
1138 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1139 * src/*.[h|cxx] : typedef clean up
1140 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1141 - TagKey renamed to gdcmTagKey (for external usage)
1142 - VRKey renamed to gdcmVRKey (for external usage)
1143 - removal of typedef duplication.
1144 - Removed all unecessary inline keyword from class inline definitions.
1145 - Some method|function(void) declarations replaced with method|function().
1146 * src/jpeg/libijg12/jdhuff12.c:
1147 - printf polluting ctest removed.
1148 - TAB removal for comminting
1150 - TestAllReadCompareDicom.cxx: added a test that compares all the
1151 images in gdcmDataImages.h with corresponding images in
1152 gdcmData/BaselineDicom/. When baseline images are not present
1153 this test creates them.
1154 Note: we need to validate each reference image, but before that
1155 I'd like to rename them with a more explicit name...
1156 - CMakeLists.txt: changed accordingly.
1157 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1158 including each header needed).
1160 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1161 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1162 test suite to the Example directory. Are concerned:
1167 - TestWriteSimple.cxx
1168 * Test/CMakeLists.txt: added some comments on reasons for black listing
1169 image gdcmData/oldACR00001.ima
1171 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1172 * Test/CmakeList.txt: removed the following from black list (to be coherent
1173 with removal from gdcmData):
1174 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1175 - gdcm-MR-PHILIPS-16.dcm
1177 Added the following because after last cvs update, they cause
1178 ctest -R TestReadWriteReadCompare
1180 - gdcm-MR-SIEMENS-16-1.acr
1182 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1183 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1184 new comments in this file) we temporarily (sigh) move to a weaker
1186 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1187 we don't need to black list the following images anymore:
1188 - 8BitsUncompressedColor.dcm
1190 - US-PAL-8-10x-echo.dcm
1191 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1192 fixes and the beautified code ;-)
1193 This fixes the bug introduced in version 1.42 (when beautifying)
1194 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1195 Note: ctest was blind to this bug (this means we need to still
1196 improve the test suite). The bug could be detected by using
1197 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1199 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1200 and by displaying the (garbage) produced file temp.XDCM...
1202 2004-06-29 Jean-Pierre Roux
1203 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1204 - replace by uggly but working old code :-(
1205 A lot of things should be OK again.
1206 It's really urgent to have a test suite that *tests*,
1207 to prevent Frog's beautifying sessions to break all the stuff
1208 (twice, withing a fortnigh ...)
1210 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1211 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1212 redundancy) to added Test/TestReadWriteReadCompare.cxx
1213 * Test/CmakeList.txt: because the compare test of
1214 Test/TestReadWriteReadCompare.cxx fails, the following images are
1215 black listed: - 8BitsUncompressedColor.dcm
1217 - US-PAL-8-10x-echo.dcm
1218 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1219 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1220 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1221 and ad-hoc kludge. This kludge is now removed, and on encountering
1222 such an image (OB field brain damaged) we set errno. Then in
1223 ::FindDocLength() we "fix" the length as being ALL what remains
1224 in the file (until EOF). We then proceed, hoping for the best...
1225 This fixes a SegFault in ShowDicom when trying to write such an
1227 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1228 (because TestWriteRead breaks on it, after a non conformal commit?).
1229 ctest now runs properly, except for MakeDicomDir (which was always
1230 broken) and the Python related stuff (still not fixed).
1232 2004-06-24 Jean-Pierre Roux
1233 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1234 FIX : Test/TestReadWrite now iterates on all the file names
1235 (instead of infinite loop)
1236 ENH : Test/TestWriteRead now iterates on all the file names
1238 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1239 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1241 2004-06-24 Jean-Pierre Roux
1242 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1243 when SamplesPerPixel =3
1244 - now Write is no longer confused by
1245 'BitsAllocated = 12" and 'BitsStored=12"
1246 - "UN" value representation Elements are now written correctly
1247 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1248 ENH : - now gdcmHeader has its own Write methods
1249 (in order to split the job that has not to be done
1252 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1253 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1254 loop on the same image until memory went out.
1255 Note: this means we still have gobs of memory loss in PrintDocument
1256 * src/gdcmDocument.cxx: fixes problem on parsing on file
1257 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1259 2004-06-24 Jean-Pierre Roux
1260 FIX : Write - All the Sequences and Sequence Item are now written
1261 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1262 is added a the end, when necessary.
1263 - A lot of brain-damaged images, that were read correctly are
1264 now written correctly
1265 - length compatible BinEntry are now loaded correctly
1266 (even for odd groups)
1267 Note : only Explicit Value Representation was checked.
1268 (question : is implicit VR really necessary for gdcm ?)
1270 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1271 * DEVELOPPER: added a proposition of coding style.
1272 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1275 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1276 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1277 Use the gdcmDocEntry::Print() and Write() instead.
1278 * src/gdcmDocument.cxx: bug fix.
1280 2004-06-22 Jean-Pierre Roux
1281 FIX : gdcmDocument.cxx
1282 - Now we do recognize the JpegLossLess format (there was a misstyping in
1283 code 'beautyfication' :-(
1284 - Now we automaticaticaly load the Luts, if any
1286 2004-06-22 Jean-Pierre Roux
1287 In order : to write Sequences, whatever their imbrication level,
1288 : to allow user to create his own Sequences
1289 a lot of modif where necessary (adding, moving, or virtualising methods)
1291 WARNING : save your own sources *before* cvs up !
1294 ADD virtual void Write(FILE *fp, FileType filetype);
1297 ADD virtual void Write(FILE *fp, FileType filetype);
1298 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1301 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1302 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1303 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1304 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1305 ADD std::string GetEntryByName(TagName name);
1306 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1308 std::string vr = "unkn",
1309 std::string fourth = "unkn",
1310 std::string name = "unkn");
1311 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1312 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1313 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1314 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1315 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1316 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1317 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1318 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1321 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1322 ADD virtual std::string GetEntryByName (TagName tagName);
1323 ADD virtual std::string GetEntryVRByName (TagName tagName);
1324 REM virtual bool Write(FILE *, FileType);
1325 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1326 FILE *_fp, FileType type);
1327 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1328 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1329 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1330 REM virtual std::string GetEntryByName (std::string tagName);
1331 REM virtual std::string GetEntryVRByName (std::string tagName);
1332 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1333 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1334 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1336 std::string vr = "unkn",
1337 std::string fourth = "unkn",
1338 std::string name = "unkn");
1339 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1340 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1341 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1342 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1345 ADD virtual void Write(FILE *fp, FileType filetype);
1348 ADD virtual void Write(FILE *fp,FileType filetype);
1351 ADD virtual void Write(FILE *fp, FileType filetype);
1352 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1353 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1354 REM std::string GetEntryByName(TagName name);
1357 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1359 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1360 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1361 The default constructor invoked by the line
1362 gdcmHeader *f1 = new gdcmHeader( header );
1363 was gdcmHeader::gdcmHeader(bool) instead of the expected
1364 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1365 Hence the parsing wasn't executed... See also below.
1366 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1367 as explicit constructor didn't do the trick to fix the above problem.
1368 Could anyone explain why ?
1369 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1370 properly calls gdcmValEntry::Print() (that was weed out from
1371 code related to gdcmBinEntry).
1373 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1374 * In order to fix memory leaks:
1375 - Test/TestWriteSimple.cxx: added cleaning of free store through
1377 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1378 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1379 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1380 (through the call to ::AddDicomDirMeta()) or the destructor
1381 would crash when deleting uninitialized ::metaElems].
1382 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1383 - src/gdcmDocument.cxx:
1384 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1385 from dynamic stores.
1386 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1387 was causing memory leaks.
1388 - src/gdcmSQItem.cxx:
1389 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1390 cleanly handled with polymophism: sorry but my milage is low).
1391 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1392 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1393 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1394 This avoids SegFaulting.
1395 - src/gdcmSQItem.h: coding style.
1397 - Test/TestWriteSimple still severely sucks. The output image content
1398 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1399 damaged when displayed with vtkgdcmViewer.
1400 - on memory leaks: TestWriteSimple leaks really less (see entry
1401 of 2004-06-18 in Changelog file for the call to valgrind).
1402 - on segfaults: ctest now passes all the tests but one (no more
1404 * Erroneous leading white fix:
1405 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1406 white[s] (as opposed to from >> xxx, that removes it [them].
1407 - src/gdcmTS.cxx: ditto.
1408 - gdcmPython/testSuite.py: dirty related kludge removed.
1409 * src/*: remaining references to gdcmParser removed.
1410 * src/*[cxx|h]: added copy[way]left header.
1413 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1414 * In order to fix writing of dicom files:
1415 - Test/TestWriteSimple.cxx: a simpler example of writing.
1416 - Test/CMakeLists.txt changed accordingly.
1417 - src/gdcmDocument.cxx:
1418 -- The destructor now recursilvely removes potential sequences.
1419 -- Bug fix in ::IsJPEG2000()
1420 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1421 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1423 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1424 to only declared) and build on top of
1425 ::GetDocEntryByNumber(guint16, guint16).
1426 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1427 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1428 for usage in destructor and treatement of promotion in
1429 ::ReplaceOrCreateByNumber().
1430 - src/gdcmSQItem.cxx: destructor should better handle his job.
1431 Test/TestWriteSimple now runs (or at least it DOES something).
1432 * We can now start hutting memory links. A good starting point is:
1433 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1434 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1435 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1437 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1438 * Valgrind note: after Mathieu Malaterre teached me how to read
1439 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1441 Using gcc, you can force the STL to use malloc and to free memory as
1442 soon as possible by globally disabling memory caching.
1443 With 3.2.2 and later, you should export the environment variable
1444 GLIBCPP_FORCE_NEW before running your program.
1445 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1446 simply vanish (it is still not clear to me, whether this means that
1447 STL std::string leaks or if valgrind believes it leaks...).
1448 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1449 running bin/gdcmTests makeDicomDir):
1450 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1451 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1453 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1454 SegFaulting (I drowned in DicomDir related code when trying to
1455 understand why the list is empty...).
1456 * src/gdcmDocument.h: first BSD license header try.
1457 * Doc/License.txt added.
1459 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1460 * src/gdcmDocument.[h|cxx]:
1461 - Clean up of the Transfer related predicates. They are now all based
1462 on new method isGivenTransferSyntax, that (should) handle properly
1463 the padding problem.
1464 - general clean up, simplification, and coding style.
1465 - Specific clean up of Parse7FE0() (umproperly named actually).
1466 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1468 2004-06-14 Jean-Pierre Roux
1470 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1471 - fix the display of SQItem ordinal number
1472 - add the GetSQItemByOrdinalNumber method
1473 - remove some useless never written private methods
1475 2004-06-14 Jean-Pierre Roux
1477 - adding a constructor taking a gdcmDocEntry as an input param
1478 - ReplaceOrCreateByNumber now returns :
1479 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1480 a gdcmValEntry * if a string value is passed as a param
1482 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1483 according to the param type (no longer sets a gdcmDocEntry)
1484 - GetValEntryByNumber, GetBinEntryByNumber added
1485 - NewValEntryByNumber and NewBinEntryByNumber added
1487 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1489 - GetSQItemNumber and SetSQItemNumber added, to provide
1490 a (relative) Item identier inside a given Sequence
1491 \warning : some pb remaining around this number
1493 - AddEntry now takes the Item Number as a param
1495 - adding a constructor taking a gdcmDocEntry as an input param
1497 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1498 * Memory leak hunt with the following command:
1499 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1500 --show-reachable=yes gdcmTests PrintDocument
1501 It looks like many (all?) leaks are due to the STL (or a bad usage
1502 of the STL. The lines producing the leaks now have a comment with
1503 a "MEMORY LEAK" tag: you can retrieve them with
1504 grep "MEMORY LEAK" src/*
1505 Here are two typical examples which I can't help fixing:
1510 char * test = "babo";
1511 name = test; //// <--- valgrind detects 960 bytes lost in
1512 //// call to std::string::operator=(char const*)
1513 name.clear(); //// Doesn't help !
1521 std::cout << "Type a bunch of characters followed by RETURN: ";
1522 getline(std::cin, line); //// <--- valgrind dectects a loss
1523 //// of 1320 bytes in call to
1524 /// std::basic_istream<>& std::getline<>
1530 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1531 * src/gdcmHeader.[cxx|h]:
1532 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1533 and related, moved away to gdcmDocument.
1534 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1535 the corresponding protected accessors of inherited class
1536 gdcmDocument, removed ! As a consequence gdcmFile had to be
1537 declared friend of class gdcmDocument (see below).
1538 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1539 - Clean up of undefined or unused methods.
1540 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1541 account the changes to gdcmHeader.h).
1542 * src/gdcmDocument.h:
1543 - gdcmFile is now a friend class (in order to take into account the
1544 changes to gdcmHeader.h).
1545 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1546 (see changes to gdcmHeader.h).
1547 - Accessors (reading on the form GetEntry*) are now public.
1548 - Clean up of undefined or unused methods.
1549 * src/gdcmDocument.cxx:
1550 - adaptation to changes to gdcmDocument.h
1551 - ::OpenFile now writes a verbose message when file cannot be opened.
1552 - some std::string properly set to VRKey
1553 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1554 references to gdcmDocument.
1555 * Test/TestFindTags.cxx: changed accordingly to above changes.
1556 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1557 cvs repository gdcmData.
1559 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1560 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1561 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1562 conflicts with gdcmValEntry::voidArea.
1563 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1564 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1565 Value representation between StringRepresentable and BinaryRepresentable.
1566 * src/gdcmDocument.cxx:
1567 - method ParseDES: proper indentation restored and usage of
1568 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1569 - method LoadDocEntry: the fingerprint left in the SetValue() of
1570 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1571 removed. Reverting to previous code segment with the proper
1572 dynamic_cast< gdcmValEntry* >.
1573 Note: this was (partially) breaking the python test suite
1574 (gdcmPython/testSuite.py) that made usage of the above
1575 fingerprint to check presence of "Pixel Data".
1576 * src/gdcmDocEntry.h: coding style.
1577 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1578 now taken into account.
1579 * gdcmPython/gdcm.i: adaptation to the new internal representation
1580 of gdcm (exit gdcmParser, hello gdcmDocument).
1581 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1583 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1584 anymore, but instead prints the loaded Python dictionary.
1585 * .... alas, the python testSuite is still broken.
1587 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1588 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1590 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1591 * src/gdcmUtil.h : export methods
1593 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1594 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1596 * Initial addition of automatic python testing
1597 * Initial addition of automatic image comparison
1599 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1600 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1601 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1603 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1604 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1605 * Test/ShowDicom.cxx : bug fix for msvc compilation
1606 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1608 2004-05-04 Jean-Pierre Roux
1609 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1610 new concepts (and new classes) :
1611 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1612 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1613 - Sequence Doc Entries (gdcmSeqEntries)
1614 a Sequence is composed of Items.
1615 Each item is a set of Doc Entries (this is recursive)
1616 The non uniqueness of the 'Dicom tag' is due to this recursivity
1617 (never taken into account)
1618 Our unability to add a new 'entry' in the header
1619 at the proper location (neither in the H-Table (map or multimap),
1620 nor in the Chained List is also due to this recursivity.
1621 Don't try, right now, to use/modify/compile these new sources :
1622 nothing is finished.
1623 We just commit all the stuff, 'as is', in order not to loose it.
1625 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1626 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1628 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1629 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1630 file prefix (SetFilePrefix)
1632 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1633 * Add a new test: ShowDicom, for now this is just the c++ version of
1634 checkRead.sh, later it will be able to compare the image read against a
1636 * Replace the DEBUG on the stack with a global entry in cmake interface:
1637 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1639 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1640 * Add an example subdir, with a real example on how to read + write a
1643 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1644 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1645 * Doc/CMakeLists.txt: the main page is now properly differentiated
1646 between the developper and user version.
1647 * Doc/doxygen.config.in: dropped search related obsolete flags
1648 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1650 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1651 * DEVELOPPER: added some helpfull comments for compile/test/install
1654 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1655 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1656 src directory, now generated in the build dir.
1657 2. Tests as mentionned smarter
1659 4. Add a new method in gdcmDict that return the PubDict by name
1660 this is interesting for 3rd party lib like ITK,
1661 where we could set the institution name / patient name...
1663 * ENH: 1. Now the test suite is working for real
1664 2. All binaries are now output in the gdcm-bin directory
1665 (this was not true before)
1667 2004-04-28 Jean-Pierre Roux
1668 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1669 SeQuence indented printing of Dicom Header.
1670 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1671 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1672 Computation of SQDepthLevel is now part of gdcmHeader constructor
1673 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1674 tree-like structure of a Dicom Header.
1675 * FIX Test code cleaning
1677 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1678 * ENH: Adding automatic testing
1679 1. Need a DartConfig.cmake to submit to public
1680 2. Add a test driver gdcmTest.cxx
1681 3. gdcmTestMain, an helper for the main test driver gdcmTest
1682 4. Files in Test don't have a main anymore, this becomes interesting
1683 when we add more and more tests, thus dsw don't have to load
1685 * ENH: Adding a GDCM_DATA_ROOT for testing
1686 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1687 one file instead of seven + some small cleanup
1689 2004-04-22 Jean-Pierre Roux
1690 * ENH Minor changes to the Print() methods.
1691 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1692 Header printing. Example given with :
1693 > PrintHeader fileName 2 new
1694 (SQ based tree-like structure still to be done for the Header ...)
1696 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1697 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1698 1. I have added some unsigned where needed
1699 2. Some function parameter not used -> (void)
1700 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1701 4. g++ don't like character '\' in comment
1702 5. #define jpeg_create_decompress jCreaDecompress
1703 this really need to be fixed
1704 6. virtualize destructor of gdcmObject ... leakage
1705 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1706 this also really need to be fixed
1707 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1708 remove compression file
1709 (as we only do decompression, right ?)
1710 * ENH: Change malloc/calloc/free with c++ equivalent
1712 2004-04-21 Jean-Pierre Roux
1713 * FIX gdcmHeaderHelper::GetXSpacing
1714 when a single value is found (bug ?), xpacing is now
1715 defaulted to yspacing
1717 2004-04-19 Jean-Pierre Roux
1718 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1719 * ENH add parameters :
1720 bool exception_on_error = false,
1721 bool enable_sequences = false,
1722 bool ignore_shadow = false
1723 to the gdcmFile constructors to be full gdcmParser compliant
1724 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1725 to allow reading of PAPYRUS 3.0 files
1727 2004-04-06 Jean-Pierre Roux
1728 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1730 2004-04-02 Jean-Pierre Roux
1731 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1732 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1733 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1735 2004-03-30 Jean-Pierre Roux
1736 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1737 for ACR file, written out as DICOM files (hope so...)
1739 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1740 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1741 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1742 moved to base class gdcmParser and only the specialisation is kept
1744 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1745 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1746 already does the job.
1747 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1748 (to be consistent with gdcmParser::WriteEntries).
1750 2004-03-30 Benoit Regrain
1751 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1752 upate of the object's instance. It's passed to 2 in the unfavorable
1753 case : one in the ExecuteInformation, one in the ExecuteData
1755 2004-03-29 Jean-Pierre Roux
1756 * ENH : Check on file type to be written moved
1757 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1758 * FIX : gdcmObject::ResetBoundaries now stops properly
1759 when end-of-list is reached
1760 : gdcmVersion modified (as Benoit Regrain asked)
1762 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1763 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1764 * src/gdcmUtil.cxx: added forgotten iostream include.
1765 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1766 equivalent to ExplicitVR in existing code).
1768 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1769 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1770 now contains all the gdcmGlobal related code.
1771 * minor coding style and doxygenation changes.
1773 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1774 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1775 now contains all the Debug related code.
1776 * minor clean-up of includes in src/*.cxx
1777 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1778 CreateCleanString) removed.
1779 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1780 * Doc/DoxyMainPageUser.txt added.
1781 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1782 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1783 src/gdcmDirList.cxx)
1785 2004-03-24 Jean-Pierre Roux
1786 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1788 2004-03-23 Jean-Pierre Roux
1789 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1790 big endian made volumes
1791 * ENH Now gdcmParser constructor and destructor are protected to forbid
1792 end user to instanciate class gdcmParser
1793 (only gdcmHeader and gdcmDicomDir are meaningfull)
1795 2004-03-22 Benoit Regrain
1796 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1797 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1798 gdcmSerie to gdcmDicomDirSerie
1800 2004-03-19 Jean-Pierre Roux
1801 * ENH Now the tree-like structure describing a DICOMDIR comming from
1802 an already existing DICOMDIR file is consistent with
1803 the home-made tree-like structure build ex-nihilo
1804 or build from the files held (recursively) in a Directory
1805 functions gdcmDicomDir::CheckBoundaries()
1806 gdcmObject::SetBoundaries() added
1808 2004-03-17 Jean-Pierre Roux
1809 * REM (Eric Boix bug) : removal of meaningless
1810 gdcmDicomDirImage::NewImage function.
1811 * FIX now file names and directory name are written properly in the
1813 * FIX now gdcmDicomDir constructor may be call without any trick
1816 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1817 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1818 of gdcmDicomDirImage::NewImage as empty function.
1820 2004-02-28 Jean-Pierre Roux
1821 * ENH add gdcmDicomDir:NewPatient
1822 add gdcmDicomDirPatient:NewStudy
1823 add gdcmDicomDirStudy:NewSerie
1824 add gdcmDicomDirSerie:NewImage
1825 to allow making gdcDicomDir object.
1826 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1827 (as opposite to the gdcmHeader chained list)
1829 2004-02-11 Benoit Regrain
1830 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1831 when using from python
1833 2004-02-10 Benoit Regrain
1834 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1835 * FIX : in gdcmDicomDir when the directory is empty
1836 * ENH : add callback and methods to get the progression of dicomDir
1839 2004-02-06 Jean-Pierre Roux
1840 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1841 - GDCM_META added to gdcmDicomDirType
1842 - class gdcmMeta created
1843 * ENH : - A brief summary is now displayed at the beginning of
1844 'testDicomDir' to help disaster magnitude estimation
1845 * REM : Now useless Test/explDICOMDIR.cxx
1847 2004-02-05 Benoit Regrain
1848 * ENH : add methods in gdcmObject to get the hash table or the list of
1850 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1851 * FIX : wrapping python for TagHeaderEntryHT
1853 2004-02-04 Benoit Regrain
1854 * FIX : even length for some strings when writting the dicom dir
1855 * FIX : sort the images in the dicom dir
1856 * FIX : Bug fix for python use of dicom dir
1857 * ADD : a python demo
1859 2004-02-04 Jean-Pierre Roux
1860 * FIX : Final solution (?) for icone embedded images
1861 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1862 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1863 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1864 gdcmData/gdcm-MR-SIEMENS-16.acr1
1865 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1866 to make full checking easier
1868 2004-02-04 Benoit Regrain
1869 * FIX : WriteEntries : coding style & logic in parameters
1870 * FIX : Set the elements to create the DicomDir in a dictionary file
1872 2004-02-03 Benoit Regrain
1873 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1874 * gdcmDicomDir : add the load of directory
1875 * Bug fix and print add-on
1877 2004-02-03 Jean-Pierre Roux
1878 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1879 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1880 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1881 * FIX gdcmParser.cxx : 'group length' elements are now considered
1882 as integers, even for shadow groups, when file is Implicit VR
1884 2004-02-02 Jean-Pierre Roux
1885 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1887 of the last synonym :-(
1888 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1890 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1891 * FIX taking into account the possible 7fe0,0010 multiplicity
1892 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1893 to allow removal of references to 7fe0,0010, to deal with
1894 ACR-NEMA images, when 0028,0200 is meaningfull
1896 2004-01-31 Jean-Pierre Roux
1897 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1898 no longer writes 'Un' on disk
1899 * FIX SQ elements with actual length are now dealt with corectly
1900 * FIX gdcmFile::WriteBase make the difference, for color images, between
1901 the length (for Palette expanded images)
1902 and Raw Length (non expanded image + Palette)
1903 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1904 (that broke Write). Replaced by UL.
1905 Aware user will reload the field if he
1906 thinks it's necesssary
1908 2004-01-30 Jean-Pierre Roux
1909 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1910 when 'dirty Acr' is found, to be compliant with the new
1911 IsReadable() methods.
1913 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1914 (no DOUBLE images in kosher DICOM,
1915 but so usefull for people that miss them ;-)
1917 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1918 DICOMDIR related utilities (not checked as Windoze compliant)
1920 2004-01-28 Jean-Pierre Roux
1921 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1923 2004-01-27 Jean-Pierre Roux
1924 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1925 to allow skipping the shadow elements, to save memory space.
1926 The TRUE value for this param has to be used
1927 with a FALSE value for the 'enable_sequence' param.
1928 ('public elements' may be embedded in 'shadow Sequences')
1929 * gdcmHeader methods now deal with 'embedded icones images' in the header
1930 (even when an 'icone image sequence' is announced by the
1931 element (0x0088,0x0200), but there is NO icone at all ...
1933 * gdcmHeader sometimes Image Location value doesn't follow
1934 the supposed processor endianity (see gdcmData/cr172241.dcm).
1937 * gdcmHeader add the method
1938 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1939 to get *all* the Header Entries with the same tag.
1940 GetHeaderEntrySameName is probabely *useless*
1941 (no meaning : Name is *not* an identifier within the Dictionary)
1943 2004-01-26 Benoit Regrain
1944 * Bug fix in the print of hexadecimal representations. Remove long fields
1945 in the print and add a third level of print to print them
1947 2004-01-23 Benoit Regrain
1948 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1949 * Bug fix on test suite after remove the strip made on not string fields
1950 * Split the IsReadable method between gdcmParser which test that the file
1951 is dicom and gdcmHeader which test that it's an image file
1953 2004-01-22 Benoit Regrain
1954 * DicomDir : clean code, add methods, set variables in protected or private
1955 * gdcmUtil : bug fix for the clean string method
1957 2004-01-19 Benoit Regrain
1958 * Add the use of shadow dictionaries
1959 * bug fix and coding style
1961 2004-01-19 Benoit Regrain
1962 * src/gdcmFile.cxx : bug fix concerning the close of file
1963 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1964 * Add the update of header entries using the shadow library
1966 2004-01-19 Benoit Regrain
1967 * removal of file gdcmHeader2.cxx
1968 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1969 inheriting from gdcmParser. This split is to prepare the integration
1970 of dicom dir parsing
1971 * bug fix under python
1973 2004-01-16 Jean-Pierre Roux
1974 * REM removal of class gdcmHeaderEntrySet
1975 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1976 * ADD add file gdcmHeader2.cxx
1977 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1979 2004-01-15 Benoit Regrain
1980 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1981 entries created while parsing the header. Thus, they will be destroyed
1982 when the gdcmDictSet will be destroyed
1983 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1986 2004-01-15 Benoit Regrain
1987 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1988 made a fatal error because of the memory release at the end of program.
1989 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1990 some memory and vtk seems to have some problems with that.
1991 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1993 2004-01-14 Benoit Regrain
1994 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1995 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1996 * src/*.[h|cxx] : make changes due to class name changes
1997 * gdcmPython/demo/*.py : bug fix due to method names
1999 2004-01-13 Benoit Regrain
2000 * src/*.[h|cxx] : coding style
2001 * vtk/*.[h|cxx] : coding style
2003 2004-01-13 Benoit Regrain
2004 * gdcmPython/testSuite.py : test the readable flag of file for tests
2005 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2006 It's lied to the stl compilation by MSVC (windows, always windows...)
2007 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2009 2004-01-12 Benoit Regrain
2010 * src/*.h : add comments
2011 * src/gdcmDictSet.h : set the method BuildDictPath in public
2012 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2013 directly setted in the source code
2014 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2017 2004-01-09 Benoit Regrain
2018 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2019 * setup.py : use a reference to gdcmVERSION
2021 2004-01-07 Benoit Regrain
2022 * Modification to compile with the distutils.
2025 2003-12-10 Benoit Regrain
2026 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2027 can use a gdcmHeaderHelper to load data
2028 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2029 made in the source code
2031 2003-12-10 Benoit Regrain
2032 * Update Windows projects and .cvsignore files
2034 2003-11-12 Jean-Pierre Roux
2035 * ENH gdcmHeader constructor has one more parameter (default value : false)
2036 that allows the user to 'go inside' the SeQuences only
2038 gdcmElValSet:Print takes it into account
2040 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2041 * ENH: Update gdcmPython/CMakeLists
2042 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2043 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2045 2003-11-10 Jean-Pierre Roux
2046 * FIX : gdcmHeader::LoadElements is now based
2047 on the ListTag listElem member,
2048 not longer on the TagElValueHT tagHt member
2049 * ENH : PrintPubElVal shows (temporarily) both results,
2050 with the tagHt member and the listElem member.
2051 (it's easier to 'see' the problems when using Printheader)
2053 * FIX : old private member LgrElem is now splitted into
2054 ReadLength : Length actually found on disk (updated only
2055 if bug fixing is necessary), for internal
2057 UsableLength : Updated by FixFoundLength, to fix a bug
2058 or to allow Parser going on.
2059 Will allow to re-write a kosher header when a SeQuence
2060 with a length (not 0000) is found
2061 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2062 because gdcmElValSet::Add does not update ListElem
2065 2003-11-07 Jean-Pierre Roux
2066 * FIX misstyping in Transfert Syntax name table
2067 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2068 when they have an actual length (not 0000 nor FFFFF)
2069 (Nobody should care of it, but DICOMDIR explorers)
2071 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2072 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2074 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2075 * ENH: vtkGdcmReader now supports LUT !
2076 (vtkgdcmViewer for now is not able to use them though)
2078 2003-11-05 Jean-Pierre Roux
2079 * in testSuite.py : new files names for checking the package
2080 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2081 that returns the pixel area size to the *aware* (vtk) user
2082 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2084 2003-11-05 Benoit Regrain
2085 * in testSuite.py : Modify the rules for checking the paths
2086 : Explicit error messages
2087 * in __init__.py : Related modif
2089 2003-11-03 Jean-Pierre Roux
2090 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2091 to be used by aware (vtk) users that want to manage
2092 LUT (and no to turn the PALETTE image into an RGB pixels one)
2093 * GetPixelType now returns 8U for 24 Bits images
2094 (vtkGdcmReader compliant)
2096 2003-10-31 Jean-Pierre Roux
2097 * Removal of *all* gdcmData images and add them again
2098 in order to loose the 'history' of un-anonymised images
2100 2003-10-31 Jean-Pierre Roux
2101 * RMV : removal of useless jBitsInJsample.h
2102 for both 8 and 12 Bits JPEG Lossy Libraries
2104 2003-10-31 Jean-Pierre Roux
2105 * ENH : Add the functions gdcmFile::GetImageDataRaw
2106 gdcmFile::GetImageDataIntoVectorRaw
2107 that act as GetImageData and GetImageDataIntoVector
2108 except the making of an RGB Plane from Gray Plane + LUT
2109 Intended to aware (vtk) users who know how to manage
2112 GetLUTRGBA return a R,G,B,A LUT if any
2113 lgrTotaleRaw gives the 'Raw' length
2114 GetImageDataRaw returns the gray Plane
2115 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2116 (They stay Grey, just like with other Dicom viewers :-(
2118 2003-10-30 Jean-Pierre Roux
2119 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2121 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2122 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2123 being coherents dicom files.
2125 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2126 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2128 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2129 * ENH: Two steps is necessary to please VC++ compiler...
2130 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2131 * ENH: Add include dir to medcon lib
2132 * FIX: only one function is being exported for now !
2133 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2135 2003-10-29 Jean-Pierre Roux
2136 * adding gdcmHeader::GetLUTRGBA
2137 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2138 --> Mathieu, the modif u're waiting for is not yet committed
2139 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2141 2003-10-27 Jean-Pierre Roux
2142 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2143 00191113.dcm DermaColorLossLess.dcm
2144 MxTwinLossLess.dcm RadBWLossLess.dcm
2145 * ENH: For version prior to vtkImageViewer2 -r 1.19
2146 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2148 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2149 * Removal of ido stuff in CMakeLists.txt
2151 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2152 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2153 * FIX: remove a call to ->Modified ... see comments
2154 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2156 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2157 * FIX: Problem with path for libvtkgdcmPython
2158 * ENH: Try adding a search script for python site-package
2159 * RMV: Remove some file from medcon lib that are not necessary
2160 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2161 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2162 * FIX: More pragma disable fro VC++,
2163 I don't think I break something as it is also disable in VTK/ITK.
2164 But it fasten debug compilation time.
2166 2003-10-23 Jean-Pierre Roux
2167 * gdcm now deals with 16 Bits Run Length Encoded images
2168 (they are compressed as 2 planes images,
2169 one for the high Bytes, the other for low Bytes)
2171 2003-10-22 Jean-Pierre Roux
2172 * Now CheckRead takes into account :
2173 - the bugged 'Leonardo' Siemens images
2174 - the XA images, sent thru the burning VPRO station
2175 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2178 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2179 * FIX: When copying a Makefile.am to CMakeLists.txt
2180 one should remove the '\'
2182 2003-10-22 Jean-Pierre Roux
2183 * in gdcmData adding a bugged 'Leonardo' Siemens image
2184 (wrong lengths in header)
2185 OK with gdcm, KO with the other viewers :-)
2186 * add a GE dlx XA image, thru the VEPRO burning station
2189 2003-10-21 Jean-Pierre Roux
2190 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2191 for a brutal checking of vtkgdcmViewer compliance
2193 2003-10-21 Jean-Pierre Roux
2194 * add the files for 'xmedcon' Jpeg Lossless library
2195 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2197 2003-10-21 Jean-Pierre Roux
2198 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2200 2003-10-21 Jean-Pierre Roux
2201 * garbage Siemens 'Leonardo' images dealt with
2202 (the patch is easy to remove)
2203 * cosmetic changes to avoid warnings
2205 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2206 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2207 no need to press 'r' now.
2209 2003-10-20 Jean-Pierre Roux
2210 * upgrade of checkRead.sh checkWrite.sh according
2211 to new Jpeg Lossless decompressor
2212 * add US.3405.1.dcm, a genuine RGB medical file ...
2213 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2214 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2216 2003-10-15 Jean-Pierre Roux
2217 * general anonymisation in gdcmData
2218 * adding the 'color files' from
2219 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2220 * adding some well knowed bugged-header images
2221 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2222 waiting for their inclusion in Python testsuite
2224 2003-10-15 Jean-Pierre Roux
2225 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2226 no longer seg faults when file is not found
2228 2003-10-14 Jean-Pierre Roux
2229 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2232 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2233 * TODO: *.in file to genereate a UseGDCM later
2235 2003-10-14 Jean-Pierre Roux
2236 * Some supposed-to-be Dicom Images have no preamble.
2237 OpenFile takes it into account
2238 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2239 * Missing elements added in dicomV3.dic
2240 (just to be affraid : have a look at
2241 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2242 and do it again next year ;->
2244 2003-10-13 Jean-Pierre Roux
2245 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2246 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2247 But there are NOT. It's fixed !
2249 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2250 * FIX: "jpeglib.h" was not found on VC++
2251 * FIX: vtkgdcm was not being installed
2253 2003-10-10 Jean-Pierre Roux
2254 * ENH : OpenFile closes the file if it *really* doesn't look like
2255 an ACR-NEMA / DICOM one.
2256 * FIX : testWrite no longer writes an empty file if the source file
2257 is not gdcm Readable
2258 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2261 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2262 * FIX: CMake generate now documentation
2263 * ENH: out of source doc build !
2264 * ENH: Generate both user and dev documentation
2265 * ENH: Should work on windows too
2266 * ENH: Only one doxygen config.in file is needed
2267 * FIX: make install should be ok now on ùnix plateform
2268 * FIX: PATH to dictionary was wrong (missing /)
2269 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2271 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2272 * vtkGdcmReader is now able to read rgb dicom file.
2273 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2274 * added a gdcmViewer to vtk test, use mouse to control
2275 window level & window width
2277 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2278 * CMake-ification of gdcm, we have now two build system
2279 * FIX: on cygwin Wsock32 doesn't exist
2280 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2282 2003-10-06 Emanuel Ollart
2283 * FIX : compilation process wad broken.
2284 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2286 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2287 * change gdcmViewer -> vtkgdcmViewer
2288 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2290 2003-10-06 Jean-Pierre Roux
2291 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2292 ( e.g : well known GE images with a wrong elem length,
2293 : Philips MRI Images with a wrong Huffman table)
2294 * still to be done : allow the reading of bugged LEONARDO Siemens images
2296 2003-10-03 Jean-Pierre Roux
2297 * Odd length strings are padded with '\0' (not with spaces,
2298 to remain compliant with already defined strings,
2299 like Transfert Syntax UID and others)
2301 2003-10-03 Jean-Pierre Roux
2302 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2303 to allow displaying RGB images (not only by affim ;-)
2305 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2306 * vtkGdcmReader is now able to read rgb dicom file.
2307 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2309 2003-10-03 Jean-Pierre Roux
2310 * A few nasty patches to allow the reading of a lot of nasty images
2311 ( e.g : well known GE images with a wrong elem length,
2312 : Philips MRI Images with a wrong Huffman table)
2313 * still to be done : allow the reading of bugged LEONARDO Siemens images
2315 2003-10-03 Jean-Pierre Roux
2316 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2318 2003-10-03 Jean-Pierre Roux
2319 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2320 to allow displaying RGB images (not only by affim ;-)
2322 2003-10-03 Jean-Pierre Roux
2323 * gdcmFile::GetImageDataIntoVector now
2324 - deals with MultiFrames MultiFragments Run Length Encoded files
2325 - deals with YcBcR (YBR_FULL) files
2326 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2327 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2329 (no sample found :-(
2331 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2332 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2333 Two reasons: - clear things
2334 - third parties acces gdcm through header files, so won't
2335 suffer anymore VC++ complains
2337 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2338 * add argv[1] in testvtkGdcmReader.cxx
2341 2003-09-24 Jean-Pierre Roux
2342 * The lines are now eigthy characters long.for
2343 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2345 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2346 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2347 char* to std::string. Thus, the use of strdup becomes useless. (see
2348 previous commis of Malaterre)
2349 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2350 before the last Malaterre's commit.
2352 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2353 * This commit should fix the Debug building under VC++, the problem
2354 was mainly a mixture of debug and release lib being loaded at startup.
2355 * I also remove a depency to a specific C function: strdup. Because I had
2356 to force the link to msvcrtd (whereas strdup is in libc).
2358 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2359 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2360 located in the gdcmCommon.h file. All use of reference of tha has been
2361 changed to now use the variable GDCM_UNFOUND.
2363 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2365 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2366 Dicom dictionary. The test suite can now be run again. Note:
2367 I'm note very happy with the " (RET)" changes. I believe this
2368 RETAINED comment should be dropped when parsing the dictionary.
2369 - PACKAGER corrected
2371 - AUTHORS updated and now in alphabetical order
2372 * Makefile.am now exports gdcm.dsw for Windoze users.
2374 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2375 * cygwin complains about missing std:: in subdir Test/
2377 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2378 * remove some methods that are now in gdcmHeaderHelper
2380 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2381 * vtkGdcmReader set spacing and origin correctly
2383 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2384 * Fix a few delete/delete[] mismatch
2386 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2387 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2388 interpretation to data given by gdcmHeader. For instance there are
2389 heuristics to get informations (look at different places).
2390 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2391 sorting DICOM images based on different strategies.
2392 * modified Makefiles accordingly.
2394 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2395 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2396 when building in debug mode
2397 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2398 src/win32/gdcmdll.dsp
2399 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2401 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2402 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2405 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2406 * src/win32/libgdcmjpeg12.dsp was not dos format
2407 * src/win32/libgdcmjpeg12.dsp :
2408 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2409 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2411 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2412 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2414 * src/gdcmFile.cxx : bug fix in affectation type
2415 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2416 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2417 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2418 symbols... future problem ?
2420 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2421 * src/win32/libgdcmijpeg12.dsp was missing
2422 * modified gdcm.dsw accordingly
2424 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2425 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2427 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2428 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2429 commit of JPR (before his hollidays to facilitate our work).
2430 * setup.py : bug fix in code. Modifications made while the last commit
2431 of JPR. The code hasn't been tested before the commit... it's so
2432 useless to make that (for best programmer that is JPR) !!!
2434 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2435 * tagged the current version as Version0_3 (i.e. version 0.3)
2437 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2438 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2439 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2440 * *.dsp : modifications to use new libgdcmijpeg8 library
2441 * setup.py : bug fix on VTKPATH variable
2442 * PACKAGER : adding all concerning windows
2444 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2445 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2447 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2448 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2449 test suite reported error.
2450 * PACKAGER file added (describes what a packager must do when
2451 packaging a new release).
2452 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2453 * configure.in: upgraded version number to 0.3.0
2454 * fixing build of rpm (through rpm -ta):
2455 - Doc/Makefile.am exports proper doxygen files
2456 - src/jpeg/libijg8/Makefile.am exports the include files.
2458 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2459 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2460 * src/gdcmHeader.h : formatting code
2462 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2463 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2464 We were obtaining error message from vtk. Now, creation of file list
2465 is made in an internal list to prevent this problem.
2466 Bug fix when output is empty.
2467 Bug fix in update of progress value. Previous commit for this was a bad
2469 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2471 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2472 * src/gdcmHeader.h : added method to get the file name
2473 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2474 files. Added method to remove all files on the input
2475 Added FIXME comment concerning the bad parsing of header made by
2476 ExecuteInformation method (in ExecuteData method)
2478 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2479 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2480 when using make instal.
2481 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2482 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2484 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2485 * setup.py : adding include dir of jpeg lib to compile all sources
2486 * */Win32/*.dsp : JPR fix for windows compilation
2488 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2489 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2491 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2492 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2494 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2495 * setup.py is again effective on un*x (takes into account the
2496 addon of the jpeg library)
2497 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2498 * Doc/Doxy* updated (includes above enhancements)
2499 * INSTALL now points to web documentation
2501 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2502 * src/gdcmHeader.h doesn't make unnecessary reference to
2504 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2506 * src/gdcm*.[cxx|h] :
2507 - to allow compilation with gcc 3.x
2508 -- clean up of STL usage (added explicit usage of std::)
2509 -- small fixes on exceptions.
2510 Note: linking not tested !
2511 - clean of doxygen comments to avoid warnings at documentation
2513 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2514 dependent convertion).
2516 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2517 * Clean up of previous JPR garbage commit (not even commented in the
2519 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2520 - moved all jpeg related files from src to src/jpeg/libijg8, with
2521 addition/modification of Makefile.am and configure.in.
2522 - the testSuite is still brain damage (not guilty).
2524 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2525 * WrapVTK.py : modifications to get correctly vtk source files to
2527 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2528 (FileName -> Filename)
2530 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2531 * vtk/vtkGdcmReader.[cxx/h]:
2532 - UpdateProgress method should now be effective
2533 - removed the limitation on having only images loaded (as opposed
2535 - when building a stack of images/volume, a lesser number of
2536 gdcmHeader and gdcmFile instances should be used (hopefully
2537 accelerating things).
2538 - when building a stack of images/volumes, files which are not
2539 loadable (wrong path-filename, wrong permissions on existing file,
2540 or file not parsable by gdcm) are replaced with a black image
2541 in the stack (for the caller to notice the problem).
2543 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2544 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2546 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2547 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2548 between standard library (std) and vtk library (problems are found
2549 under Windows... thanks Windows !)
2551 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2552 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2554 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2556 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2557 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2559 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2560 * When compiling with distutils (see setup.py) the C++ compiler is
2561 called with different flags than the default ones (with automake).
2562 In order to fix all those warning, I compiled gdcm with the command
2563 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2564 and went for warning fixes:
2565 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2566 up from unused variables.
2567 - vtk/vtkGdcmReader.cxx: potential bug fix.
2568 * src/gdcmHeader.h: Doxygen warning cleanup
2570 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2571 * gdcmPython/gdcm.i:
2572 - typemaps correction to take into account the systematic replacement
2573 of "using namespace std" with std:: prefix e.g. std::list,
2574 std::string... (cf changes of 2003-05-21).
2575 - gdcmGlob global variable of type gdcmGlobal (defined in
2576 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2577 exported to Python a as cvar.
2578 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2579 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2580 gdcmDictSet.GetPubDictTagNames() and
2581 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2582 C++ static methods).
2583 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2584 with the above changes.
2586 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2587 * setup.py, manifest.in : bug fix under linux
2589 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2590 * Modification of setup.py to compile vtk part too. Then, we have 2
2591 wrappers which must work with same distutils. For that, we have a
2592 generic distutils in distusiltsWrapping.py ; with :
2593 - build_extWrap class to wrap generically all extensions,
2594 - ExtensionWrap base class for all wrapping extension that contains
2596 - Wrapper interface which wrap sources
2597 + In WrapSwig.py we have extension and wrapper for Swig
2598 + In WrapVTK.py we have extension and wrapper for VTK
2599 * MANIFEST.in : modifications to consider vtk directory and new python
2600 files for compilation
2602 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2603 * Added python wrappers of vtkGdcmReader vtk class (see the
2604 source in vtk/vtkGdcmReader.cxx) :
2605 - vtk/Makefile.am now builds a library
2606 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2607 python library (as opposed to _gdcm.so wich are the python
2608 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2609 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2611 - configure.in has an additional flag --enable-vtk that needs
2612 to be set to enable compilation of vtk related code, that is:
2613 + vtk/vtkGdcmReader.so and
2614 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2615 + gdcmPython/vtkgdcmPython.so (see above)
2616 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2617 be read when compressed or when HighBit + 1 != BitsStored),
2618 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2619 the usage of the python wrapper of vtkGdcmReader vtk class.
2620 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2621 * src/*.[h] all occurences of stl classes are now prefixed with
2622 std::, and all occurences of "using namespace std;" where removed.
2623 This is to avoid pollution of global namespace in included files.
2624 Apparently vtk does not avoid this pitfall: when using both
2625 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2626 collision of various stl members (principally cout...).
2627 * gdcmPython/testSuite.py now cleanly removes temprory generated
2629 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2630 comply with above changes)
2632 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2633 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2634 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2635 vtk data structure (an image Flip was required).
2636 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2637 * cosmetic changes in documentation.
2639 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2640 * src/gdcmHeader.cxx: the constructor no longer exits when an
2641 unexisting file is given as argument.
2642 * The subdirectory Data (containing all the images used for the
2643 test suite) is not part of this repository anymore. A new module
2644 containing those images is now available at
2645 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2646 with the name gdcmData.
2647 All the python scripts (including the package initialisation file
2648 gdcmPython/__init__.py) were adapated to take this change into
2649 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2651 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2652 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2653 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2654 demo of the usage of this class.
2655 Compilation of this vtk part is only done when using the --enable-vtk
2656 at configure (or autogen.sh) stage.
2658 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2659 * More memory link related corrections and documentation fixes.
2661 - maximum info is obtained with a command of the form:
2662 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2663 --show-reachable=yes PrintHeader
2664 - the remaining reachable blocks seem to come from the STL
2665 allocation scheme through the usage of map and list. It looks
2666 like this memory cannot be freed but it is not a memory leak
2667 (in fact further invocation to the STL would recollect the
2668 unused memory allthough it cannot explicitely be freed).
2669 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2670 of displaying an image parsed with gdcm and displayed with VTK.
2671 Note: some images don't seem to work e.g.
2672 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2673 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2674 Allthough this weakens the semantics, it is a ditch attempt to
2675 make gdcm more thread friendly.
2677 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2678 * Memory link hunt (by using valgrind through the command
2679 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2680 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2681 gdcmHeader::_dicom_vr.
2682 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2683 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2685 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2687 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2688 * src/Makefile.am now exports all the necessary include files at
2692 * UpdateGroupLength replaced by new one
2695 * UpdateGroupLength re-written using H-Table
2696 (named UpdateGroupLengthNew untill checks are over)
2698 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2699 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2700 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2702 - gdcmHeader::GetPubElValSet removed.
2703 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2704 UpdateGroupLength, WriteElements, Write.
2705 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2706 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2707 carried the same semantics.
2708 - src/gdcmHeaderIdo.cxx changed accordingly.
2709 - gdcmFile::WriteBase now regroups all the codes from previous
2710 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2711 - enum FileType moved to gdcmCommon.h
2712 * src/gdcmHeader.cxx AddDefault trashed
2713 * gdcmGetXSize added
2714 * getimageDataSize now calls gdcmGetXSize
2715 * Test/*.cxx changed to agree with above changes
2717 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2718 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2719 (to avoid double call by end user).
2720 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2721 by end user, since gdcmHeader::gdcmHeader now handles it.
2723 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2724 * gdcm/Doc many doxygen changes:
2725 - Doxyfile now has two different versions, DoxyfileUsers that generates
2726 the html.users end users oriented documentation and
2727 DoxyfileDeveloppers that generates the html.developper developper
2728 oriented documentation.
2729 - README changed accordingly
2730 - requirement.txt removed (old design info moved to TODO).
2731 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2732 DoxyMainPage.txt, DoxyPython.txt provide more information.
2733 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2734 be updated by simply regenerating the docs with doxygen and copying
2735 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2736 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2737 all the tests in the form "if (<map>.count() >1)" were removed.
2738 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2739 ill-formed documentation sections.
2740 * src/gdcmHeader.cxx: ditto
2742 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2743 * setup.py fixed for un*x (needed macro for stdint.h)
2744 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2745 un*ces with sh-utils test utility.
2746 * gdcmPython/demo/test.py renamed to PrintHeader.py
2747 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2748 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2749 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2750 * src/gdcm*.cxx JPR's bad inclusion fixed.
2752 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2753 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2754 * gdcmPython/demo/test.py changed accordingly.
2756 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2757 * gdcmPython/Makefile.am fixed linking against libstdc++
2758 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2759 * Swig subdir (historical tests of swig version 1.3.17++) removed
2760 * Test/testChangeEntete.cxx some lines commented out in order to make
2762 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2763 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2765 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2766 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2767 hence the user doesn't need this explicit call.
2768 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2769 i.e. LoadElements() call removed.
2770 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2771 - src/Makefile.am declares the proper flag for g++.
2772 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2773 for adding user defined new tags.
2774 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2775 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2776 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2778 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2779 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2780 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2781 src/Makefile.am : the project should properly compile and install
2782 with the autotools, included the python wrappers part.
2783 * gdcm.spec.in : added a spec file for RPM packaging.
2785 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2786 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2788 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2789 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2790 to exported to the environement (see gdcmPython/testSuite.py
2792 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2793 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2794 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2795 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2796 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2798 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2799 * gdcmPython/__init__.py doesn't crash anymore when running in
2800 in InstallMode or PreInstallMode but with an environment given
2801 value of GDCM_DICT_PATH.
2802 * src/gdcmDictSet.[cxx/h] coding style.
2804 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2805 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2806 * src/gdcm.h general comments moved to TODO, and README
2807 * src/gdcm.h should now be seen as a user commodity (including it
2808 should suffice to fully use gdcm). It is nowhere including within
2809 any of the kernel files src/*.cxx and src/*.h.
2811 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2812 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2813 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2815 * src/gdcm*.cxx only include their corresponding include file
2816 (as opposed to gdcm.h)
2817 * gdcmPython/gdcm.i changed accordingly
2818 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2819 the autogen.sh generated "make snapshot" command to work.
2820 * autogen.sh removed history related references to crea package.
2822 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * distutilsSwigCPlusPlus.py work around some swig portability
2826 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2827 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2828 was done in a last ditch attempt to get setup.py _really_
2829 operationnal. The python/gdcmPython layaout add the advantage
2830 of hidding away the python related distutils specific files
2831 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2832 Alas, the src directory was out of scope (i.e. it's relative
2833 position to setup.py was ../src) which made things impossible to
2834 handle (see previous version of python/setup.py). Crossing fingers...
2836 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2837 * python/setup.py now works on Un*x. (harder than I thougth)
2838 * python/distutilsSwigCPlusPlus.py can now have include files
2839 among the list of sources.
2841 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2842 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2843 * modifications in MSVC projects
2845 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2846 * As stated by the first lines of Test/ExceptionAndPython/README, it
2847 looks like we can move back to original usage of exception within
2848 src/gdcm* and hence remove the errno stuff that was introduced
2849 as a quick and dirty fixture of this problem (added to the TODO).
2850 * Doc/Doxyfile configuration file for Doxygen and corresponding
2851 README file for usage added.
2852 * Test/testWrite.cxx added. This new test comes from a split of
2853 test.cxx that is now reverted to its original purpous i.e.
2854 testing the proper parsing of a Dicom related file.
2855 testWrite.cxx concentrates on testing the IO part of gdcm.
2856 * Test/bug1.cxx (containing a bug on WIn32) added.
2857 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2858 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2859 whose purpose is to publish the content of the TagNames of the
2860 Dicom public dictionary were not accessible without an
2861 instance of class gdcmHeader.
2862 - those methods are now static methods of gdcmDictSet and hence
2863 require no instances at all to be invocated.
2864 - within gdcmDictSet this change required to change some method
2865 to class methods (i.e. are now static) among which SetDictPath
2866 (renamed to BuildDictPath) and LoadDefaultPubDict.
2867 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2868 the above changes by calling the new method classes of gdcmDictSet.
2869 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2870 the above to be effective.
2871 * python/gdcmPython: in order to wrap properly the above changes
2872 for Python, swig version now needs to be > 1.3.17.
2873 * python/gdcmPython/Makefile fixed to adapt itself to new
2874 configure/make shema introduced by Johan Montagnat (thanks for the
2875 contribution). Alas this Makefile cannot be turned into a proper
2876 Makefile.am without some heavy changes in the configure.in
2877 (for python dectection).
2878 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2879 now avoids publishing the empty entries.
2881 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2882 * python/setup.py : bug fix concerning install under windows
2883 ExtraPath reused :-P
2884 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2886 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2887 * Dicts/dicomV3.dic : remove double spaces !!!
2888 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2889 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2892 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2893 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2894 method. Doxygenation.
2895 * src/gdcm.h clean up of JPR spurious comments.
2897 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2898 * python/distutilsSwigCPlusPlus.py now properly collects the
2899 shadow classes generated by "swig -c++" (gdcm.py in our case)
2900 when using "python setup.py install".
2901 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2902 reexports the working classes.
2903 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2904 by the classical C errno scheme. This is to prevent an obscure
2905 behavior of the python wrappers when importing wxPython.wx prior
2906 to gdcmPython (which ended up in an abort call). An illustration
2907 of this oddity can be found in the Test/ExceptionAndPython
2908 subdir (see the README file). This problem probably due to
2909 an combination of g++ and dynamic loading.
2910 * added Test/ExceptionAndPython (see above)
2912 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2913 * Changed the layout of the python part to avoid bloating main
2914 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2915 i.e. the distutils arsenal. All the python related stuff is
2916 again in a python subdir, but the package itself is now in
2918 * setup.py was cleaned up:
2919 - pythonIncludePath removed
2920 - python setup.py bdist target is now functional.
2921 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2922 collision with other packages). gdcmPython/demo/*.py changed
2925 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2926 * python subdir moved to gdcmPython (preparation of distutils packaging).
2927 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2928 distutils installer is operational.
2929 * - gdcmPython/__init__.py now properly loads the swig generated
2930 shadow classes (from gdcm.py).
2931 - gdcmPython/demo/*.py changed to import the package gdcmPython
2932 instead of gdcmPython/demo/load.py.
2933 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2935 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2936 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2937 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2938 entries within the associated public Dicom dictionary resp. the same
2939 information but sorted by the fourth field (PAT, IMG, DIR) of the
2941 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2942 are now in the "???" group.
2943 - python/gdcm.i changed accordingly,
2944 - python/demo/printGroupedPublicDict.py added, that gives an example
2945 of the above new functionalities in Python.
2947 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2948 * src/gdcm.h, gdcmHeader.cxx:
2949 - historic references to glib's g_malloc and g_free (#defined)
2950 were definitively removed.
2951 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2952 * src/gdcmElValSet.cxx:
2953 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2954 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2955 - GetElValue(string) renamed to GetElValueByName.
2956 - Added GetElementByName(string).
2957 * src/gdcmHeader.cxx: added
2958 - GetPubElValRepByNumber(guint16, guint16)
2959 - GetPubElValRepByName(string)
2960 - GetShaElValRepByNumber(guint16, guint16)
2961 - GetShaElValRepByName(string)
2962 - GetShaElValByNumber(guint16, guint16)
2963 - GetShaElValRepByName(string)
2964 - GetElValRepByNumber(guint16, guint16)
2965 - GetElValRepByName(string)
2966 - GetElValByNumber(guint16, guint16)
2967 - GetElValRepByName(string)
2968 * Doc/requirements.txt added.
2970 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2971 * Test/Makefile building now depends on the one of libgdcm.so
2972 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2973 pixel data) aware which enables finding the address (offset) of
2974 the pixel data of JPEG encoded DICOM files. This leaves only a single
2975 file in the testSuite whose pixel data address (offset) is unknown.
2976 * python/testSuite.py changed accordingly.
2978 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2979 * VC++ has some strong limitations when working with the STL, as stated
2980 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2981 "Also note that some STL containers (map, set, queue, list, deque)
2982 cannot be exported. [...]
2983 Some STL classes contain nested classes. These classes can not
2985 This is caused by a designed limitation that once a template
2986 class is instantiated, it can not be re-instantiated and
2988 Since our usage of map<> is ubiquitous in gdcm, this "designed
2989 limitation" of VC++ is a pitfall.
2990 Hence the Python wrappers of gdcm cannot be incrementally linked
2991 against the c++ dynamic library. The dirty but only workaround is
2992 to forget about incremental link of dynamic libraries and to generate
2993 the Python wrappers library with the inclusions of the underlying C++
2995 The following modifications concern this matter on Win32/VC++:
2996 - wrapping python correct with standalone wrapped dll (don't use separate
2997 dll under windows !!!!)
2998 - python21_d debug mode enabled (ask Frog how to use it :-)
2999 - NO problem with having an STL member of class for example string in C++
3000 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3001 - Python test of dcmlib in Python is ok under windows on a large set
3003 * removed glib references
3004 * typedef's inserted in gdcm.i for correct swig type management
3006 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3007 * python/demo/*.py load.py extracted from test.py. Added explore.py
3008 that only displays required tags and testAll.py that parses all
3009 the files of the testsuite without using unittest.
3010 * python/testSuite.py other additional test on new files added.
3011 * Data/* new test files added accordingly to the testSuite.
3012 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3013 the vr in the file differs from the one of the dictionary.
3015 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3016 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3017 values, but limits itself to values which are below a user specified
3018 size (by default 1024 bytes).
3019 * python/gdcm.i : elements not loaded (because their size is above the
3020 user specified treshold) are exported with their TagKey as key of the
3021 python dictionary. This enables the testsuite to make some checks
3022 on the unloaded elements (since we have their offset and size).
3023 * python/testSuite.py
3024 - now tests for the existence and proper value of the pixel data
3025 - two new examples added.
3026 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3028 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3029 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3030 aware. See the strategy comments in gdcmHeader::FindeLength().
3031 * Test/test.cxx now accepts a filename as first argument.
3032 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3033 * python/testSuite.py changed to integrate test on above files.
3035 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3036 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3037 the vr was also RET.
3038 * python/testSuite.py more tests added.
3040 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3041 * python/testSuite.py unittest test suite added (uses Data)
3042 * Data/* dcm and acr files for the test suite.
3043 * glib dependance removed from un*x version. We now use ISO C99
3044 7.18 Integer types (see stdint.h)
3045 - python/Makefile, src/Makefile src/gdcm.h
3046 * src/ when an explicit vr (like dicom files) suddenly poped an
3047 implicit element we use to mark the underlying DictEntry of the
3048 concerned ElValue with "Implicit". This strategy was damageable
3049 too the public or provite dictionaries, since some of their vr
3050 would be changed. Since Header::FindLength heavily relies on the
3051 detection by Header::FindVR of falsely explicit elements, I
3052 added an extra ImplicitVr member to ElValue (boolean).
3053 The rest of the changes we the necessary adaptations.
3055 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3056 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3058 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3060 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3061 * Adaptation for porting to VC++:
3063 o forced to use std namespace (for string to be known)
3064 o all class use __declspec export style on WIN32
3065 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3066 (in stdlib.h on Win32 but in std:: for gcc)
3067 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3068 variable GDCM_DICT_PATH.
3069 * src/gdcmHeader.cxx verbose comments made discrete.
3071 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3072 * python/gdcm.i: added a typemap that converts a C++ hashing table
3073 to native Python dictionary.
3074 * python/demo/test.py:
3075 - now uses the native dictionary for exploration of gdcmHeader.
3076 - takes an optional filename argument (the file to parse).
3077 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3078 PubElVals hashing table.
3079 * Dicts/dicomV3.dic removed error prone trailing spaces.
3081 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3082 * Python wrapping process moved away from src/Makefile to
3083 newly created python/Makefile (as well as gdcm.i)
3084 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3085 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3086 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3087 from the environement variable GDCM_DICT_PATH (when existing).
3088 * src/gdcmDict::GetTag bug fix.
3090 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3091 * Straightforward temporary fixes for swig to build the python wrappers.
3092 src/Makefile now has a python working entry [by working we mean
3093 that we can import de shadow classes without errors].
3095 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3096 * hashtest.cxx removed (since already in Test)
3097 * src/gdcmlib.h renamed to src/gdcm.h
3098 * src/dcm.i renamed to src/gdcm.i
3099 * src/Makefile prepared for python wrapping
3101 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3102 * src/gdcmHeader.cxx :
3103 - Parsing of header is now separated from loading of element values
3104 (see gdcmHeader::LoadElements).
3105 - general clean up of hopefully all file access (creation of
3106 ReadInt16 and ReadInt32)
3108 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3109 * src/gdcmHeader.cxx :
3110 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3112 - SetLgrElem renamed to SetLength
3113 - GetLgrElem renamed to GetLength
3114 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3115 * src/gdcmElValSet.cxx fixed both GetElValue methods
3116 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3117 due to IdoDude was cleaned out.
3119 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3120 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3121 concentrates on finding the value representation (when it exists).
3122 RecupLgr now only finds the element value length, and it avoids
3123 returning the unecessary skL (skipped length).
3124 Also, offsetCourant was simply removed (with taille_fich) since
3125 it was redundant with the File position internals (by using
3126 ftell and fseek). This also made skL (see above in RecupLgr) usage
3128 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3129 on the libido specificities which are handled through class
3131 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3134 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3135 * Truckload of changes. Parsing of header is barely functional
3136 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3138 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3139 * src/gdcmHeader.cxx many addons of low level methods
3141 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3142 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3143 and _IdDcmSWAP_LONG.
3145 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3146 * This corresponds to all the changes decided at the meeting of
3147 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob