1 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
2 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
3 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
4 to swap the Swap Code, at parsing time, when we come out of group 0002
5 and Transfer Syntax is Big Endian
6 We should be able to read now 'true DICOM" Big Endian coded images
7 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
8 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
10 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
11 * Hopefully fix the bug on MacOSX and static global initialization.
12 This is the only -minor- patch I found that both please MacOSX and VS6.
13 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
14 but this would require a lot of change. Another approach would be that Global
15 create those string and GDCM_UNFOUND becomes a pointer to a string (which
16 gdcm::Global would destroy at exit).
18 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
19 * Fix bug on MacOSX with static initialization in a multy threaded
20 environment. static const string in a header file used to be ill
21 initialized provoquing the freeze of any tests. patch should solve this
24 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
25 * According to Benoit's suggestion, and without any objection from anybody
26 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
27 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
28 - method gdcmDicomDirObject::GetEntry() renamed as
29 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
31 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
32 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
33 you debug/warning message just as c++ streams which make them very convinient
34 to use. Once this is stabilize I will change the ostringstrem to be
35 redirected to a file (ofstream).
36 * Properly support C99 extension: __FUNCTION__ which allow us to display
37 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
39 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
40 * Removal of useless and dangerous methods :
41 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
42 GetDocEntryByName, GetEntryByName, GetDictEntryByName
43 * Removal of usless methods :
44 Dict::PrintByName, Dict::GetDictEntryByName
45 * Commenting out of probabely useless methods :
46 Dict::GetDictEntryNames()
47 Dict::GetDictEntryNamesByCategory()
48 DictSet::GetPubDictEntryNames()
49 DictSet::GetPubDictEntryNamesByCategory()
50 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
51 * ENH : Use dicomTS.dic as described in 2004 version
52 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
53 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
54 Add Accessors on VM (Value Multiplicity), and VM related methods
55 * ADD : Add a list of 'Dicom Attribute types', as found in
56 http://medical.nema.org/dicom/2004/04_15PU.PDF
58 * ADD : Add dicomGroupNameAbbreviations.dic
59 should be used to write a method to replace the former
60 Dict::GetDictEntryNamesByCategory()
62 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
64 to read in the file... and only it ! Length is the efective length of the
65 data in the DocEntry structure
67 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
68 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
69 And now use a static function call instead, with a global variable. i
70 This is much closer to the VTK approach. Hopefully should be bulletproof
71 and easier to use...hopefully
73 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
74 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
76 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
79 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
80 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
81 ValEntry, BinEntry, SeqEntry creation or replace
83 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
84 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
85 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
87 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
88 when specifying the VR
89 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
90 * src/gdcmDocEntry.cxx : amelioration of print
92 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
93 * ADD : Add the method Util::IsCurrentProcessorBigEndian
94 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
95 * ADD Method Document::ComputeGroupLength
96 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
97 in order to allow further VR modification by user
98 * REM : removal of once-called method File::WriteBase
99 integration of its code in formerly one-line method File::Write
101 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
103 replace the different values "??", "Unkn", "Unknown".
104 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
105 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
106 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
107 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
109 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
112 * Set the gdcm::Base class to some Printable classes
114 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * src/gdcmFile.[h|cxx] : add the Print method
116 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
117 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
118 * src/gdcmDocument.h : remove the PrintLevel informations
119 * Example/PrintFile.cxx : use the new gdcm::File::Print
121 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
123 problems when compiling with the python wrapping
125 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
127 writting in ImplicitVR
129 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
130 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
131 JPEG decompression, especially when dicom frames are split into several
132 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
133 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
135 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * src/gdcmHeader.cxx : change the initialisation of default header.
137 Now, this header is readable by gdm, e-film, DicomWorks
139 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
140 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
141 Rename Decompressed to Raw
142 * Use the API changes in gdcm::File.
143 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
146 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
148 each added entry in the header. Replace the 'Planes' field by the 'Number
151 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
153 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
155 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
157 At this time, this image isn't readable by e-film... waiting JPR help to
160 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
162 DocEntry. Now use methods of the Document !
164 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * Test/ShowDicomSeq.cxx : bug fix
167 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
168 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
169 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
170 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
171 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
173 * Test/TestCopyRescaleDicom.cxx : remove unused variable
174 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
175 containing found sequences
177 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
180 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
181 Some fields in BinEntry must be copied to not seg fault when making the :
182 gdcm::File *copy = new gdcm::File( copyH );
183 and tests are now made on good variables
185 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
187 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
189 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
190 * Add vtkGdcmWriter example and test
192 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * Test/TestUtil.cxx : reformat the source code
194 * vtk/vtkGdcmReader.cxx : remove and change prints
195 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
197 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
198 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
200 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
201 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
202 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
204 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
205 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
206 by an eof to prevent all bad read of the file... and in this case, the
209 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * Example/Volume2Dicom.cxx : comment unused variables
211 * Test/PrintDicomDir.cxx : comment unused variables
212 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
213 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
214 method that is redondant with AddEntry.
215 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
218 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
219 * Bug fix due my last commit (compilation under Windows).
220 * Example/Volume2Dicom : bug fix in the file and reformatting source code
221 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
223 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
225 - Remove printf / sprintf
226 - include iostream AFTER gdcm so we don't get warnings
227 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
229 - Also remove tons of include from header files, hopefully this should
230 speeup the compilation time, since it was becoming a dog slow.
231 - Remove gdcm.h as it include way too many files and slow down compilation
232 (plus it is not up to date)
233 - remove 'using namespace std' this is BAD !
235 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * Remove memory leaks on the DicomDir
237 * Remove some useless data in DicomDirObject
238 * Add usefull methods in SQItem, to be complient withe the ElementSet
240 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
243 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
245 future, with convertion)
246 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
247 and ImageDataSize values. Remove the method to get the PixelReadConverter
248 from the output of the class
250 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
251 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
253 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
254 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
255 and vtkErrorMacro use.
256 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
258 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
261 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
262 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
263 The string leaves only in the fonction. So when we make a .c_str(), we
264 get the pointeur on the first element, element that will be destroyed
265 immediately after thee instruction.
266 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
267 file has been opened : the test must be made on the content of the
268 pointer and not directly on the pointer !
271 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
272 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
273 the python part recompiles
275 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
276 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
277 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
278 X session is killed (for my computer... it seems to not be identic on
281 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
283 avoid problems (otherwise, the difference test between the visible image
284 and the reference is incorrect. If the reference is greater than the
285 screen resolution, it's produce errors).
286 Can be used for only one image. Can be used with a visible flag.
287 * vtk/vtkGdcmReader.cxx : remove commented codes.
288 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
289 under windows at compilation
290 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
292 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
294 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
296 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
297 tests on the image size X, Y, Z
299 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
301 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
302 between the class name and the file name
304 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * src/ : fix compilation warnings for the Write method (2 different
306 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
307 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
308 variable... create a static method in gdcm::Document to access to
309 this variable content.
311 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
313 file, to be accessed by other files (like gdcmFile). Remove commented
314 code. Move the change of the header to the gdcmFile, using the
316 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
317 To be sure of that (and simplify calls), the Write of the header now
318 gets a file name and not a file pointer (std::ifstream).
319 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
320 DocEntryArchive. Remove all open of the written file
322 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
323 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
325 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
326 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
327 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
329 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
330 some corresponding methods. Write correctly the file and check before
332 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
333 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
334 is now on RGB data (as before my last commit
335 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
337 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
339 Add a print information of the type of the entry
340 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
341 It was in the gdcmFile, and all write have been regrouped
342 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
343 Write correctly all dicom files (in decompressed mode only at this time)
344 * Test/ : test on files are now made using Raw data and not color data if
346 * Example/PrintFile.cxx : add more printings
348 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * Amelioration of code, remove some code copy. For the loading of
350 BinEntry (in gdcmDocument), add the test to verify if the file is already
353 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
354 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
355 remove a DocEntry in the header (push an empty DocEntry)
356 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
357 lines. Bug fix in the initialization of the PixelConvert and the
359 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
360 use in TestCopyDicom (now this test can run under windows... but fails)
361 * Test/TestCopyDicom.cxx : amelioration of the test :
362 - test the pixels written
363 - add test points to quickly find where is the error
364 - can set a file name input and output in arguments
365 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
366 amelioration of the test output
368 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
369 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
370 all replaced DocEntry's
371 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
372 Now, each needed DocEntry to modify is duplicated, modified and inserted
373 to the header using DocEntryArchive. Thus, after save, we can restore the
374 header initial state.
376 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
377 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
379 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
380 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
381 correct to copy it. The DictEntry is specified at the DocEntry creation,
382 then, it musn't change in the time.
383 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
384 header correctly. At this time, the change is only made for the first
385 level of the Document. In the future, it might consider sequences.
386 The change is made by replacing a DocEntry by an other that is created
387 outside the class. The old value is kept. When we restore the header
388 status, the added DocEntry is deleted and replaced by the old value.
389 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
390 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
391 set the write type to explicit VR, implicit VR or ACR. Add methods to set
392 the write mode to native, decompressed or RGB (but not used at this time)
394 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
395 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
396 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
398 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
399 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
400 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
402 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
403 set because already copied when copying the BinEntry's of the header
404 * Test/TestAllReadCompareDicom.cxx : remove warnings
406 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
407 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
408 Two problems appear when doing it :
409 - with the gdcmFile : when the GetImageData method is called, the pixels
410 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
411 data (pixels). And each structure destruct the data when it's
412 destructed. So we have two destructions for the same data. To solve it,
413 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
414 data or not. If it doesn't own data, then they will not destroyed by
416 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
417 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
418 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
419 create a double destruction of the same DocEntry's. So, to solve it,
420 the TagHT is simply cleared and the DicomDir* elements are destroyed.
421 * TODO : add an entry concerning memory leaks in the DicomDir
423 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
424 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
425 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
428 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
430 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
431 after it have been deleted
433 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
434 * FIX: src/* fix the doxygen warnings.
435 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
436 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
437 was erroneously defined with a size of 15 instead of 16. [many thanks
438 to Jean Michel Rouet for pointing out this bug].
440 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
441 1. Finish merging JMR patch for writting DICOM from scratch
442 2. Fix -hopefully- bug with MONOCHROME and space vs null character
443 3. Use const ref when possible
444 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
445 5. A few more comments
446 6. CreateUniqueUID can now be called without parameter"
448 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
449 * ENH: Slightly bigger patch:
450 1. Getting toward full integration of JMR patch for writting dicom from scratch
451 2. Update Test to test part of this patch: CreateUniqueUID
452 3. File was not close properly in gdcmDict
453 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
454 5. Use of const ref instead of copy (speed issue)
455 6. Remove temporary (duplicate) string in TranslateToKey
456 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
457 8. Do not repeat virtual in subclasses
458 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
460 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
461 * Apply first patch toward better string comparison when dealing with broken
462 DICOM files. Essentially the string could be padded with a space instead
463 of a null character as defined by standard
465 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
466 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
467 because never used... and in the same time, that's remove some memory leaks
469 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
470 * src/gdcmFile.cxx : now delete the PixelConvert instance.
471 * In examples and tests : change the type of image data variables from void*
472 to uint8_t*. Remmove all delete on image data variables
474 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
475 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
476 Verify the file pointer value before open the file, and if it's not null,
477 a verbose message is generated.
478 Close correctly the file when the file isn't considered dicom-like. The
479 correctly close is a call to CloseFile.
480 When closing the file pointer, test if its not null to close the file.
481 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
482 file. For an uncompressed image, the copied data correspond in the least
483 case to the image size (calculated) or the image size specified in the
484 header. A verbose is generated if these two size mismatch
486 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
488 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
489 break under windows (with msvc6 compilation).
491 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
492 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
493 compiling with MSVC6)
495 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * Bugs fix for the Windows build with VC6
497 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
498 needed (only for projects required VTK). If the VTK is included in all
499 projects, there is conflicts with the jpeg lib of vtk when compiling the
500 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
501 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
502 when compiling the gdcm_wrap.cxx file (created by the compilation of the
504 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
505 (like it's already made for the cout use). Otherwise, conflict with the
508 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
509 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
511 - comments on the DicomDir::Method related usage added.
512 - now that we use the namespace gdcm, a lot of internal classes do
513 NOT need to be wrapped anymore.
514 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
515 DicomDir::Method) new example added.
517 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
518 * Improve string manipulation. I now inforce the notion of 'DicomString'
519 A DicomString can contain as many \0 as they want
520 and it is *always* of even length.
521 We only support odd length for very rare case.
522 And in the near future this should be removed.
524 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
525 * /binary_write/ gdcm source. Now even on big endian we are writting
526 little endian. This should -heopfully- fix some tests
528 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
529 * Now the dictionary is compiled into gdcm lib. This is a default
530 behavior, thus any dic file specified is picked before failback to
531 the one comiled into lib
533 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
534 * Change internals for gdcmDict. Don't use any 'new' any more.
535 This should definitely solve any leak problem, and we should be
536 as fast as before, as long as don't modify too much the dictionary.
538 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
539 * STYLE: ivars should start with a capital letter.
540 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
541 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
543 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
544 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
545 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
546 new 2004 dictionaries added (thanks to JPR).
547 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
548 * CLEANUP_ROUND (15) for gdcmPixelConvert
549 - RLEFrame::NumberFragments is now of type unsigned int
550 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
551 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
554 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
555 * Initial work in gathering all transfer syntax accessors. clearly
556 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
557 ivars, but only one transfersyntax (class) ivar with equivalent method on
560 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
561 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
562 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
563 discussed (plus I didn't like having a 2000 lines patch not commited)
565 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
566 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
567 * CLEANUP_ROUND (14) for gdcmPixelConvert
568 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
569 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
570 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
572 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
573 anymore and hence avoids storing a copy of PixelConvert::Decompressed
574 into File::Pixel_Data.
576 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
577 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
578 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
579 * CLEANUP_ROUND (13) for gdcmPixelConvert
580 Substituted File::ParsePixelData() with PixelConvert::Print() new
582 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
583 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
584 method to those classes.
585 - src/gdcmFile.[cxx|h]:
586 -- Added a ::Print() method.
587 -- PixelConverter is now a reference instead of a member.
588 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
589 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
591 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
592 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
593 collaboration diagram and inheritance diagram should be generated with
595 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
596 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
597 pointlessly wrapped (see
598 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
599 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
600 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
601 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
602 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
603 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
604 -- File::Initialise: PixelConverter setup moved away to
605 PixelConverter::GrabInformationsFromHeader()
606 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
607 interpretation moved away to PixelConverter::BuildRGBImage()
609 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
610 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
611 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
613 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
614 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
615 displayed on Win32 when a brutal abort() occurs (because of uncatched
616 exception). See TODO new entry of this commit for more on this.
617 * TODO added new entry.
618 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
619 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
620 - HandleColor is no longer called from gdcmFile.cxx
621 - gdcmPixelConvert.cxx clean up on method arguments and internal
622 variable names for semantical coherence.
624 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
625 * Finished lossless transition, not only do we now read all lossless jpeg
626 images, without the need of the Cornwell lib, but we do read them properly now
627 * To reduce code (well to avoid code duplication), I defined a common place
628 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
629 redefine symbols. This is not perfect but this the best solution I found for a
630 compilation time jpeg option.
632 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
633 * Update jpeg ijg lib to support lossless jpeg implementation
634 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
636 * Also added a special copyright for dcmtk since we use their bugfixes.
639 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
640 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
641 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
642 matters, as stated in warning note at begining of %include section).
643 * src/gdcmDicomDir*.[cxx|h]: coding style
644 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
645 * src/gdcmJpeg8.cxx: doxygen fix.
646 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
647 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
648 from File:: to PixelConvert::.
650 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
651 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
652 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
653 - more code moved away from File:: to PixelConvert::
654 - fat setup of PixelConverter set in place in File::Initialise.
656 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
657 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
658 namespace at the file system level. So now you should convert your examples
660 gdcmHeader -> gdcm::Header
661 It would be nice if people keep in mind to no open the namespace, since it
662 allows compilation on broken plateform which were defining common symbol in
663 the standart namespace (like LP, Unknown ...)
665 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
666 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
667 The JPEG fragments are now parsed at the same stage than the RLE
668 information. All code related to JPEG is now in gdcmPixelConvert:
669 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
670 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
671 export a gdcmFile:: method. Those are simply global functions
672 (for the time being this is better than having them attach to
673 either gdcmFile:: or gdcmPixelConvert::).
674 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
675 and stores the result in a gdcmJPEGFragmentsInfo.
676 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
677 code (among other stuff) moved away from gdcmFile:; to
680 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
681 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
682 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
683 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
684 clean up of RLE related code.
685 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
686 - src/gdcmRLE.cxx removed
687 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
688 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
689 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
690 * CLEANUP_ROUND (9) for gdcmPixelConvert
691 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
692 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
693 away from gdcmFile:: to gdcmPixelConvert::.
695 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
696 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
697 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
698 This is because Parse7Fe0 used to parse the pixels to compute the
699 length. This task was passed over to FindDocEntryLengthOB() a long
700 time ago, EXCEPT I had forgotten the OW case...
701 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
702 we just recylce the code for parsing RLE fragments and computing
704 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
705 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
706 with the retired Parse7Fe0().
707 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
708 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
710 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
711 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
712 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
713 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
714 - src/CMakeLists.txt: alphabetic order reodering + new entries.
715 * CLEANUP_ROUND (4) for gdcmPixelConvert
716 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
717 to return an unused length.
719 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
720 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
721 this should be cleanner from the plane view. The iostream are erally a pain
722 to use to do simple stuff.
724 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
725 * Redo the compilation of the ijg jpeg library. Now only one source is
726 necesseray. No need to rename file by hand what so ever. CMake handle the
727 copying of the file within different directory, configure header file to
728 modify some symbol. The only addition made to ijg wasd a mangle table so
729 that symbol are different wether we are within 8bits or 12bits.
731 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
732 * Added documentation of vtkgdcmReader on Website:
733 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
734 with it's binary name).
735 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
736 the Website to be more complete.
737 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
738 doxygenated documentation.
739 - Doc/DoxyVtkGdcmReaderExamples.txt added
740 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
741 DoxyVtkGdmReaderExamples.html )
742 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
743 * CLEANUP_ROUND (3) for gdcmPixelConvert
744 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
746 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
747 * CLEANUP_ROUND (2) for gdcmPixelConvert
748 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
750 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
751 * CLEANUP_ROUND for gdcmPixelConvert:
752 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
753 - src/gdcmPixelStuff[h|cxx] removed
754 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
755 - src/CMakeLists.txt changed accordingly
757 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
758 gdcmVersion.py moved to newly created ATTIC related
759 gdcmPython/SetupOldies/ directory.
760 * Autotools clean up:
761 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
762 - autogen.sh configure.in acinclude.m4 python.m4 removed
764 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
765 * src/*.cxx *.h Reference to License.htm fixed to License.html.
766 * Doc/CMakeLists.txt, doxygen.config.in: fix.
767 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
769 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
770 * TODO updated with Mathieu suggestions. I proposed a template for
771 describing TODO entries and used it for new entries.
772 * Added Doc/Website/CodingStyle.html, Developpers.html,
773 DeveloppersPython.html, GdcmDataCvs.html and
774 DownloadVersion0_1.html, DownloadVersion0_3.html.
775 * Some Doc/*.txt Doxygen files (which do not really concern the
776 documentation itself, but the website) moved to html and
777 placed in directory Doc/Website:
778 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
779 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
780 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
781 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
782 * CMakeLists.txt changed accordingly.
783 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
784 DeveloppersPython.html
785 * INSTALL nows refers to Doc/Website/Installation.html
787 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
788 * Added Doc/Website directory, that contains a first raw version
791 2004-09-23 Jean-Pierre Roux
792 * FIX In order not to be poluted any longer by casting problems,
793 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
794 we can now delete[] it safely
795 * VoidArea is now called BinArea (less confusing name),
796 and all the methods called ...VoidArea... are now ... BinArea...
797 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
799 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
800 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
801 clear) TagHT, which is an inherited member of gdcmElementSet. It is
802 up to the destructor of gdcmElementSet to clean up TagHt and it's
805 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
806 * Test/CMakeLists.txt: update to follow gdcmData renamings.
807 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
809 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
810 * ENH: added some utility method that builds a flat dictionnary
811 holding all the Dicom entries contained in the recursive structure
812 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
814 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
815 BuildFlatHashTable() that build a flat dictionary.
816 - src/gdcmElementSet.h: added a new private GetTag() accessor.
817 gdcmDocument is now a friend of gdcmElementSet.
818 - src/gdcmElementSet.cxx: clean up.
819 - Example/FlatHashTablePrint.cxx added.
820 - Example/CmakeLists.txt changed accordingly
822 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
823 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
824 moved away from gdcmDocEntrySet (since this class is an abstract class
825 acting like an interface). SQDepthLevel and BaseTagKey are now
827 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
828 and associated accessors. Doxygenation of the class.
829 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
831 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
832 Use SQDepthLevel accessor instead. ::Print() adapted.
833 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
834 - src/gdcmDocument.cxx changed accordingly.
836 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
837 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
838 - The following is the doxygen comment of the typedef declaration
839 of gdcmagKey in src/gdcmCommon.h:
840 gdcmTagKey is made to old an "universal" (as in URL, Universal
841 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
842 A dicom tag allways has a group and an element, but a set of tags
843 embeded in various (optionally nested) sequences and sharing
844 the same group and element all share the same (group, element)
845 "identifier". Hence the (group, element) cannot be used as an
846 identifier (in gdcm we shall refer to a "TagKey") of a tag.
847 In order to construct a proper tag identifier (i.e. a key) we
848 consider the following definition of a TagKey:
849 - let Group, Element be the string representation of the
850 group and element dicom tag members,
851 - let ItemNumber be the string representation of the integer
852 index of the considered item number of a sequence,
853 Let the key of a tag embeded in a sequence, noted SeqTag, be
855 /ItemNumber#Group|Element
856 where "/", "#" and "|" are characters acting as separators.
857 Then the general form of a gdcmTagKey is given by:
858 Group|Element<SeqTag>
859 where <SeqTag> means NO or many instances of SeqTag.
860 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
863 but the gdcmTagKey of a tag "embeded" is the first item of
864 a sequence, itself nested in the third item of a sequence is the
866 0004|1220/2#0008|0082/0#0008|0090
867 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
868 order to hold the new sequence compatible key. Previously, the
869 GetKey() method would look in the underlying gdcmDictEntry.
870 - src/gdcmDocEntry.cxx:
871 -- constructor now copies the underlying DictEntry key, in the local
873 -- ::Print: displays the member Key, instead of the (group, element).
874 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
875 - src/gdcmDocEntrySet.h:xi
876 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
877 -- now has a new BaseTagKey member.
879 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
880 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
882 This poses the problem with the semantics of the following lines
883 LoadEntryVoidArea(0x0028,0x1201); // R LUT
884 LoadEntryVoidArea(0x0028,0x1202); // G LUT
885 LoadEntryVoidArea(0x0028,0x1203); // B LUT
886 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
887 to the long FIXME note for what the problem is. Nevertheless in
888 order to get things working the dicom dictionary was altered !
889 Please fix things urgently...
890 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
891 information), see above note on moving the member VoidArea. Nevertheless
892 the following entries previously correctly set as US are now inproperly
894 0028 1201 OW IMG Red Palette Color Lookup Table Data
895 0028 1202 OW IMG Green Palette Color Lookup Table Data
896 0028 1203 OW IMG Blue Palette Color Lookup Table Data
897 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
898 of gdcmDocEntry moved to gdcmSeqEntry.
899 * src/gdcmSeqEntry.cxx: STYLE.
901 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
902 * Test/TestAllEntryVerify.cxx minor fix and added comments.
904 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
905 * gdcmPython/testSuite.py: all the test suite in python is now moved
906 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
907 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
908 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
910 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
911 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
912 to avoid inclusion recursion until STL is reached.
913 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
914 mecanism. errno.h is not included in gdcm anymore.
915 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
916 (gdcmFormatError now inherits from gdcmFormatUnexpected).
918 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
919 gdcmData/TestAllEntryVerifyReference.txt
920 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
921 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
922 exception_on_error parameter.
923 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
924 - vtk/vtkGdcmReader.cxx changed accordingly,
925 - Example/*.cxx and Test/*.cxx changed accordingly.
927 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
928 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
929 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
930 enable_sequences removed from gdcmHeader constructor and dependencies.
931 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
932 * gdcmPython/demo/PrintHeader.py: dummy fix.
933 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
934 skip_shadow removed from gdcmHeader constructor and dependencies.
935 * Example/*.cxx and Test/*.cxx changed accordingly.
937 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
938 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
939 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
941 2004-07-21 Jean-Pierre Roux
942 * FIX Now, Parsing and Printing a DICOMDIR do work!
943 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
945 2004-07-20 Jean-Pierre Roux
946 * FIX Some brain damaged headers have Zero-Lenght fields
947 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
949 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
950 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
951 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
952 variable (instance of gdcmDebug) by a definition macro, and the instance
953 is now in static in the gdcmDebug class
954 * src/gdcmSQItem.h : (FIXME) remove an undefined method
955 * Test/PrintAllDocument.cxx : bug fix in the result of the test
957 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
958 * WARNING: ctest now depends more tightly on gdcmData. You should
959 check out gdcmData properly for things to run smoothly...
960 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
961 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
962 we need the pixels not be loaded in order to use the ValEntry
963 that displays position and size).
964 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
965 This is a C++ based equivalent of gdcmPython/testSuite.py that should
966 be deprecated. If you have any doubts about the advantages of a
967 modern scripting language (read Python) versus grass root C++ (i.e.
968 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
969 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
970 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
971 Anyhow, consider documenting the gdcmData images in
972 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
974 * Test/CMakeLists.txt:
975 - now uses TestAllEntryVerify.cxx
976 - specific comments on oldACR00001.ima (now renamed in gdcmData
977 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
978 gdcmData/TestAllEntryVerifyReference.txt
981 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
982 * src/*.[h|cxx] : typedef clean up
983 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
984 - TagKey renamed to gdcmTagKey (for external usage)
985 - VRKey renamed to gdcmVRKey (for external usage)
986 - removal of typedef duplication.
987 - Removed all unecessary inline keyword from class inline definitions.
988 - Some method|function(void) declarations replaced with method|function().
989 * src/jpeg/libijg12/jdhuff12.c:
990 - printf polluting ctest removed.
991 - TAB removal for comminting
993 - TestAllReadCompareDicom.cxx: added a test that compares all the
994 images in gdcmDataImages.h with corresponding images in
995 gdcmData/BaselineDicom/. When baseline images are not present
996 this test creates them.
997 Note: we need to validate each reference image, but before that
998 I'd like to rename them with a more explicit name...
999 - CMakeLists.txt: changed accordingly.
1000 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1001 including each header needed).
1003 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1004 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1005 test suite to the Example directory. Are concerned:
1010 - TestWriteSimple.cxx
1011 * Test/CMakeLists.txt: added some comments on reasons for black listing
1012 image gdcmData/oldACR00001.ima
1014 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1015 * Test/CmakeList.txt: removed the following from black list (to be coherent
1016 with removal from gdcmData):
1017 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1018 - gdcm-MR-PHILIPS-16.dcm
1020 Added the following because after last cvs update, they cause
1021 ctest -R TestReadWriteReadCompare
1023 - gdcm-MR-SIEMENS-16-1.acr
1025 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1026 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1027 new comments in this file) we temporarily (sigh) move to a weaker
1029 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1030 we don't need to black list the following images anymore:
1031 - 8BitsUncompressedColor.dcm
1033 - US-PAL-8-10x-echo.dcm
1034 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1035 fixes and the beautified code ;-)
1036 This fixes the bug introduced in version 1.42 (when beautifying)
1037 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1038 Note: ctest was blind to this bug (this means we need to still
1039 improve the test suite). The bug could be detected by using
1040 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1042 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1043 and by displaying the (garbage) produced file temp.XDCM...
1045 2004-06-29 Jean-Pierre Roux
1046 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1047 - replace by uggly but working old code :-(
1048 A lot of things should be OK again.
1049 It's really urgent to have a test suite that *tests*,
1050 to prevent Frog's beautifying sessions to break all the stuff
1051 (twice, withing a fortnigh ...)
1053 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1054 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1055 redundancy) to added Test/TestReadWriteReadCompare.cxx
1056 * Test/CmakeList.txt: because the compare test of
1057 Test/TestReadWriteReadCompare.cxx fails, the following images are
1058 black listed: - 8BitsUncompressedColor.dcm
1060 - US-PAL-8-10x-echo.dcm
1061 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1062 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1063 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1064 and ad-hoc kludge. This kludge is now removed, and on encountering
1065 such an image (OB field brain damaged) we set errno. Then in
1066 ::FindDocLength() we "fix" the length as being ALL what remains
1067 in the file (until EOF). We then proceed, hoping for the best...
1068 This fixes a SegFault in ShowDicom when trying to write such an
1070 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1071 (because TestWriteRead breaks on it, after a non conformal commit?).
1072 ctest now runs properly, except for MakeDicomDir (which was allways
1073 broken) and the Python related stuff (still not fixed).
1075 2004-06-24 Jean-Pierre Roux
1076 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1077 FIX : Test/TestReadWrite now iterates on all the file names
1078 (instead of infinite loop)
1079 ENH : Test/TestWriteRead now iterates on all the file names
1081 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1082 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1084 2004-06-24 Jean-Pierre Roux
1085 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1086 when SamplesPerPixel =3
1087 - now Write is no longer confused by
1088 'BitsAllocated = 12" and 'BitsStored=12"
1089 - "UN" value representation Elements are now written correctly
1090 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1091 ENH : - now gdcmHeader has its own Write methods
1092 (in order to split the job that has not to be done
1095 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1096 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1097 loop on the same image until memory went out.
1098 Note: this means we still have gobs of memory loss in PrintDocument
1099 * src/gdcmDocument.cxx: fixes problem on parsing on file
1100 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1102 2004-06-24 Jean-Pierre Roux
1103 FIX : Write - All the Sequences and Sequence Item are now written
1104 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1105 is added a the end, when necessary.
1106 - A lot of brain-damaged images, that were read correctly are
1107 now written correctly
1108 - length compatible BinEntry are now loaded correctly
1109 (even for odd groups)
1110 Note : only Explicit Value Representation was checked.
1111 (question : is implicit VR really necessary for gdcm ?)
1113 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1114 * DEVELOPPER: added a proposition of coding style.
1115 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1118 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1119 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1120 Use the gdcmDocEntry::Print() and Write() instead.
1121 * src/gdcmDocument.cxx: bug fix.
1123 2004-06-22 Jean-Pierre Roux
1124 FIX : gdcmDocument.cxx
1125 - Now we do recognize the JpegLossLess format (there was a misstyping in
1126 code 'beautyfication' :-(
1127 - Now we automaticaticaly load the Luts, if any
1129 2004-06-22 Jean-Pierre Roux
1130 In order : to write Sequences, whatever their imbrication level,
1131 : to allow user to create his own Sequences
1132 a lot of modif where necessary (adding, moving, or virtualising methods)
1134 WARNING : save your own sources *before* cvs up !
1137 ADD virtual void Write(FILE *fp, FileType filetype);
1140 ADD virtual void Write(FILE *fp, FileType filetype);
1141 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1144 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1145 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1146 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1147 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1148 ADD std::string GetEntryByName(TagName name);
1149 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1151 std::string vr = "unkn",
1152 std::string fourth = "unkn",
1153 std::string name = "unkn");
1154 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1155 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1156 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1157 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1158 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1159 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1160 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1161 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1164 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1165 ADD virtual std::string GetEntryByName (TagName tagName);
1166 ADD virtual std::string GetEntryVRByName (TagName tagName);
1167 REM virtual bool Write(FILE *, FileType);
1168 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1169 FILE *_fp, FileType type);
1170 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1171 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1172 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1173 REM virtual std::string GetEntryByName (std::string tagName);
1174 REM virtual std::string GetEntryVRByName (std::string tagName);
1175 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1176 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1177 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1179 std::string vr = "unkn",
1180 std::string fourth = "unkn",
1181 std::string name = "unkn");
1182 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1183 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1184 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1185 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1188 ADD virtual void Write(FILE *fp, FileType filetype);
1191 ADD virtual void Write(FILE *fp,FileType filetype);
1194 ADD virtual void Write(FILE *fp, FileType filetype);
1195 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1196 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1197 REM std::string GetEntryByName(TagName name);
1200 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1202 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1203 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1204 The default constructor invoked by the line
1205 gdcmHeader *f1 = new gdcmHeader( header );
1206 was gdcmHeader::gdcmHeader(bool) instead of the expected
1207 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1208 Hence the parsing wasn't executed... See also below.
1209 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1210 as explicit constructor didn't do the trick to fix the above problem.
1211 Could anyone explain why ?
1212 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1213 properly calls gdcmValEntry::Print() (that was weed out from
1214 code related to gdcmBinEntry).
1216 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1217 * In order to fix memory leaks:
1218 - Test/TestWriteSimple.cxx: added cleaning of free store through
1220 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1221 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1222 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1223 (through the call to ::AddDicomDirMeta()) or the destructor
1224 would crash when deleting uninitialized ::metaElems].
1225 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1226 - src/gdcmDocument.cxx:
1227 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1228 from dynamic stores.
1229 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1230 was causing memory leaks.
1231 - src/gdcmSQItem.cxx:
1232 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1233 cleanly handled with polymophism: sorry but my milage is low).
1234 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1235 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1236 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1237 This avoids SegFaulting.
1238 - src/gdcmSQItem.h: coding style.
1240 - Test/TestWriteSimple still severely sucks. The output image content
1241 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1242 damaged when displayed with vtkgdcmViewer.
1243 - on memory leaks: TestWriteSimple leaks really less (see entry
1244 of 2004-06-18 in Changelog file for the call to valgrind).
1245 - on segfaults: ctest now passes all the tests but one (no more
1247 * Erroneous leading white fix:
1248 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1249 white[s] (as opposed to from >> xxx, that removes it [them].
1250 - src/gdcmTS.cxx: ditto.
1251 - gdcmPython/testSuite.py: dirty related kludge removed.
1252 * src/*: remaining references to gdcmParser removed.
1253 * src/*[cxx|h]: added copy[way]left header.
1256 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1257 * In order to fix writing of dicom files:
1258 - Test/TestWriteSimple.cxx: a simpler example of writing.
1259 - Test/CMakeLists.txt changed accordingly.
1260 - src/gdcmDocument.cxx:
1261 -- The destructor now recursilvely removes potential sequences.
1262 -- Bug fix in ::IsJPEG2000()
1263 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1264 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1266 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1267 to only declared) and build on top of
1268 ::GetDocEntryByNumber(guint16, guint16).
1269 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1270 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1271 for usage in destructor and treatement of promotion in
1272 ::ReplaceOrCreateByNumber().
1273 - src/gdcmSQItem.cxx: destructor should better handle his job.
1274 Test/TestWriteSimple now runs (or at least it DOES something).
1275 * We can now start hutting memory links. A good starting point is:
1276 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1277 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1278 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1280 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1281 * Valgrind note: after Mathieu Malaterre teached me how to read
1282 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1284 Using gcc, you can force the STL to use malloc and to free memory as
1285 soon as possible by globally disabling memory caching.
1286 With 3.2.2 and later, you should export the environment variable
1287 GLIBCPP_FORCE_NEW before running your program.
1288 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1289 simply vanish (it is still not clear to me, whether this means that
1290 STL std::string leaks or if valgrind believes it leaks...).
1291 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1292 running bin/gdcmTests makeDicomDir):
1293 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1294 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1296 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1297 SegFaulting (I drowned in DicomDir related code when trying to
1298 understand why the list is empty...).
1299 * src/gdcmDocument.h: first BSD license header try.
1300 * Doc/License.txt added.
1302 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1303 * src/gdcmDocument.[h|cxx]:
1304 - Clean up of the Transfer related predicates. They are now all based
1305 on new method isGivenTransferSyntax, that (should) handle properly
1306 the padding problem.
1307 - general clean up, simplification, and coding style.
1308 - Specific clean up of Parse7FE0() (umproperly named actually).
1309 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1311 2004-06-14 Jean-Pierre Roux
1313 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1314 - fix the display of SQItem ordinal number
1315 - add the GetSQItemByOrdinalNumber method
1316 - remove some useless never written private methods
1318 2004-06-14 Jean-Pierre Roux
1320 - adding a constructor taking a gdcmDocEntry as an input param
1321 - ReplaceOrCreateByNumber now returns :
1322 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1323 a gdcmValEntry * if a string value is passed as a param
1325 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1326 according to the param type (no longer sets a gdcmDocEntry)
1327 - GetValEntryByNumber, GetBinEntryByNumber added
1328 - NewValEntryByNumber and NewBinEntryByNumber added
1330 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1332 - GetSQItemNumber and SetSQItemNumber added, to provide
1333 a (relative) Item identier inside a given Sequence
1334 \warning : some pb remaining around this number
1336 - AddEntry now takes the Item Number as a param
1338 - adding a constructor taking a gdcmDocEntry as an input param
1340 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1341 * Memory leak hunt with the following command:
1342 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1343 --show-reachable=yes gdcmTests PrintDocument
1344 It looks like many (all?) leaks are due to the STL (or a bad usage
1345 of the STL. The lines producing the leaks now have a comment with
1346 a "MEMORY LEAK" tag: you can retrieve them with
1347 grep "MEMORY LEAK" src/*
1348 Here are two typical examples which I can't help fixing:
1353 char * test = "babo";
1354 name = test; //// <--- valgrind detects 960 bytes lost in
1355 //// call to std::string::operator=(char const*)
1356 name.clear(); //// Doesn't help !
1364 std::cout << "Type a bunch of characters followed by RETURN: ";
1365 getline(std::cin, line); //// <--- valgrind dectects a loss
1366 //// of 1320 bytes in call to
1367 /// std::basic_istream<>& std::getline<>
1373 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1374 * src/gdcmHeader.[cxx|h]:
1375 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1376 and related, moved away to gdcmDocument.
1377 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1378 the corresponding protected accessors of inherited class
1379 gdcmDocument, removed ! As a consequence gdcmFile had to be
1380 declared friend of class gdcmDocument (see below).
1381 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1382 - Clean up of undefined or unused methods.
1383 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1384 account the changes to gdcmHeader.h).
1385 * src/gdcmDocument.h:
1386 - gdcmFile is now a friend class (in order to take into account the
1387 changes to gdcmHeader.h).
1388 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1389 (see changes to gdcmHeader.h).
1390 - Accessors (reading on the form GetEntry*) are now public.
1391 - Clean up of undefined or unused methods.
1392 * src/gdcmDocument.cxx:
1393 - adaptation to changes to gdcmDocument.h
1394 - ::OpenFile now writes a verbose message when file cannot be opened.
1395 - some std::string properly set to VRKey
1396 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1397 references to gdcmDocument.
1398 * Test/TestFindTags.cxx: changed accordingly to above changes.
1399 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1400 cvs repository gdcmData.
1402 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1403 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1404 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1405 conflicts with gdcmValEntry::voidArea.
1406 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1407 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1408 Value representation between StringRepresentable and BinaryRepresentable.
1409 * src/gdcmDocument.cxx:
1410 - method ParseDES: proper indentation restored and usage of
1411 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1412 - method LoadDocEntry: the fingerprint left in the SetValue() of
1413 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1414 removed. Reverting to previous code segment with the proper
1415 dynamic_cast< gdcmValEntry* >.
1416 Note: this was (partially) breaking the python test suite
1417 (gdcmPython/testSuite.py) that made usage of the above
1418 fingerprint to check presence of "Pixel Data".
1419 * src/gdcmDocEntry.h: coding style.
1420 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1421 now taken into account.
1422 * gdcmPython/gdcm.i: adaptation to the new internal representation
1423 of gdcm (exit gdcmParser, hello gdcmDocument).
1424 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1426 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1427 anymore, but instead prints the loaded Python dictionary.
1428 * .... alas, the python testSuite is still broken.
1430 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1431 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1433 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1434 * src/gdcmUtil.h : export methods
1436 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1437 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1439 * Initial addition of automatic python testing
1440 * Initial addition of automatic image comparison
1442 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1443 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1444 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1446 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1447 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1448 * Test/ShowDicom.cxx : bug fix for msvc compilation
1449 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1451 2004-05-04 Jean-Pierre Roux
1452 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1453 new concepts (and new classes) :
1454 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1455 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1456 - Sequence Doc Entries (gdcmSeqEntries)
1457 a Sequence is composed of Items.
1458 Each item is a set of Doc Entries (this is recursive)
1459 The non uniqueness of the 'Dicom tag' is due to this recursivity
1460 (never taken into account)
1461 Our unability to add a new 'entry' in the header
1462 at the proper location (neither in the H-Table (map or multimap),
1463 nor in the Chained List is also due to this recursivity.
1464 Don't try, right now, to use/modify/compile these new sources :
1465 nothing is finished.
1466 We just commit all the stuff, 'as is', in order not to loose it.
1468 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1469 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1471 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1472 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1473 file prefix (SetFilePrefix)
1475 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1476 * Add a new test: ShowDicom, for now this is just the c++ version of
1477 checkRead.sh, later it will be able to compare the image read against a
1479 * Replace the DEBUG on the stack with a global entry in cmake interface:
1480 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1482 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1483 * Add an example subdir, with a real example on how to read + write a
1486 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1487 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1488 * Doc/CMakeLists.txt: the main page is now properly differentiated
1489 between the developper and user version.
1490 * Doc/doxygen.config.in: dropped search related obsolete flags
1491 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1493 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1494 * DEVELOPPER: added some helpfull comments for compile/test/install
1497 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1498 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1499 src directory, now generated in the build dir.
1500 2. Tests as mentionned smarter
1502 4. Add a new method in gdcmDict that return the PubDict by name
1503 this is interesting for 3rd party lib like ITK,
1504 where we could set the institution name / patient name...
1506 * ENH: 1. Now the test suite is working for real
1507 2. All binaries are now output in the gdcm-bin directory
1508 (this was not true before)
1510 2004-04-28 Jean-Pierre Roux
1511 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1512 SeQuence indented printing of Dicom Header.
1513 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1514 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1515 Computation of SQDepthLevel is now part of gdcmHeader constructor
1516 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1517 tree-like structure of a Dicom Header.
1518 * FIX Test code cleaning
1520 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1521 * ENH: Adding automatic testing
1522 1. Need a DartConfig.cmake to submit to public
1523 2. Add a test driver gdcmTest.cxx
1524 3. gdcmTestMain, an helper for the main test driver gdcmTest
1525 4. Files in Test don't have a main anymore, this becomes interesting
1526 when we add more and more tests, thus dsw don't have to load
1528 * ENH: Adding a GDCM_DATA_ROOT for testing
1529 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1530 one file instead of seven + some small cleanup
1532 2004-04-22 Jean-Pierre Roux
1533 * ENH Minor changes to the Print() methods.
1534 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1535 Header printing. Example given with :
1536 > PrintHeader fileName 2 new
1537 (SQ based tree-like structure still to be done for the Header ...)
1539 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1540 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1541 1. I have added some unsigned where needed
1542 2. Some function parameter not used -> (void)
1543 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1544 4. g++ don't like character '\' in comment
1545 5. #define jpeg_create_decompress jCreaDecompress
1546 this really need to be fixed
1547 6. virtualize destructor of gdcmObject ... leakage
1548 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1549 this also really need to be fixed
1550 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1551 remove compression file
1552 (as we only do decompression, right ?)
1553 * ENH: Change malloc/calloc/free with c++ equivalent
1555 2004-04-21 Jean-Pierre Roux
1556 * FIX gdcmHeaderHelper::GetXSpacing
1557 when a single value is found (bug ?), xpacing is now
1558 defaulted to yspacing
1560 2004-04-19 Jean-Pierre Roux
1561 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1562 * ENH add parameters :
1563 bool exception_on_error = false,
1564 bool enable_sequences = false,
1565 bool ignore_shadow = false
1566 to the gdcmFile constructors to be full gdcmParser compliant
1567 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1568 to allow reading of PAPYRUS 3.0 files
1570 2004-04-06 Jean-Pierre Roux
1571 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1573 2004-04-02 Jean-Pierre Roux
1574 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1575 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1576 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1578 2004-03-30 Jean-Pierre Roux
1579 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1580 for ACR file, written out as DICOM files (hope so...)
1582 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1583 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1584 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1585 moved to base class gdcmParser and only the specialisation is kept
1587 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1588 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1589 already does the job.
1590 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1591 (to be consistent with gdcmParser::WriteEntries).
1593 2004-03-30 Benoit Regrain
1594 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1595 upate of the object's instance. It's passed to 2 in the unfavorable
1596 case : one in the ExecuteInformation, one in the ExecuteData
1598 2004-03-29 Jean-Pierre Roux
1599 * ENH : Check on file type to be written moved
1600 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1601 * FIX : gdcmObject::ResetBoundaries now stops properly
1602 when end-of-list is reached
1603 : gdcmVersion modified (as Benoit Regrain asked)
1605 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1606 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1607 * src/gdcmUtil.cxx: added forgotten iostream include.
1608 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1609 equivalent to ExplicitVR in existing code).
1611 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1612 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1613 now contains all the gdcmGlobal related code.
1614 * minor coding style and doxygenation changes.
1616 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1617 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1618 now contains all the Debug related code.
1619 * minor clean-up of includes in src/*.cxx
1620 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1621 CreateCleanString) removed.
1622 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1623 * Doc/DoxyMainPageUser.txt added.
1624 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1625 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1626 src/gdcmDirList.cxx)
1628 2004-03-24 Jean-Pierre Roux
1629 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1631 2004-03-23 Jean-Pierre Roux
1632 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1633 big endian made volumes
1634 * ENH Now gdcmParser constructor and destructor are protected to forbid
1635 end user to instanciate class gdcmParser
1636 (only gdcmHeader and gdcmDicomDir are meaningfull)
1638 2004-03-22 Benoit Regrain
1639 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1640 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1641 gdcmSerie to gdcmDicomDirSerie
1643 2004-03-19 Jean-Pierre Roux
1644 * ENH Now the tree-like structure describing a DICOMDIR comming from
1645 an already existing DICOMDIR file is consistent with
1646 the home-made tree-like structure build ex-nihilo
1647 or build from the files held (recursively) in a Directory
1648 functions gdcmDicomDir::CheckBoundaries()
1649 gdcmObject::SetBoundaries() added
1651 2004-03-17 Jean-Pierre Roux
1652 * REM (Eric Boix bug) : removal of meaningless
1653 gdcmDicomDirImage::NewImage function.
1654 * FIX now file names and directory name are written properly in the
1656 * FIX now gdcmDicomDir constructor may be call without any trick
1659 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1660 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1661 of gdcmDicomDirImage::NewImage as empty function.
1663 2004-02-28 Jean-Pierre Roux
1664 * ENH add gdcmDicomDir:NewPatient
1665 add gdcmDicomDirPatient:NewStudy
1666 add gdcmDicomDirStudy:NewSerie
1667 add gdcmDicomDirSerie:NewImage
1668 to allow making gdcDicomDir object.
1669 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1670 (as opposite to the gdcmHeader chained list)
1672 2004-02-11 Benoit Regrain
1673 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1674 when using from python
1676 2004-02-10 Benoit Regrain
1677 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1678 * FIX : in gdcmDicomDir when the directory is empty
1679 * ENH : add callback and methods to get the progression of dicomDir
1682 2004-02-06 Jean-Pierre Roux
1683 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1684 - GDCM_META added to gdcmDicomDirType
1685 - class gdcmMeta created
1686 * ENH : - A brief summary is now displayed at the beginning of
1687 'testDicomDir' to help disaster magnitude estimation
1688 * REM : Now useless Test/explDICOMDIR.cxx
1690 2004-02-05 Benoit Regrain
1691 * ENH : add methods in gdcmObject to get the hash table or the list of
1693 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1694 * FIX : wrapping python for TagHeaderEntryHT
1696 2004-02-04 Benoit Regrain
1697 * FIX : even length for some strings when writting the dicom dir
1698 * FIX : sort the images in the dicom dir
1699 * FIX : Bug fix for python use of dicom dir
1700 * ADD : a python demo
1702 2004-02-04 Jean-Pierre Roux
1703 * FIX : Final solution (?) for icone embedded images
1704 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1705 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1706 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1707 gdcmData/gdcm-MR-SIEMENS-16.acr1
1708 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1709 to make full checking easier
1711 2004-02-04 Benoit Regrain
1712 * FIX : WriteEntries : coding style & logic in parameters
1713 * FIX : Set the elements to create the DicomDir in a dictionary file
1715 2004-02-03 Benoit Regrain
1716 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1717 * gdcmDicomDir : add the load of directory
1718 * Bug fix and print add-on
1720 2004-02-03 Jean-Pierre Roux
1721 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1722 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1723 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1724 * FIX gdcmParser.cxx : 'group length' elements are now considered
1725 as integers, even for shadow groups, when file is Implicit VR
1727 2004-02-02 Jean-Pierre Roux
1728 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1730 of the last synonym :-(
1731 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1733 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1734 * FIX taking into account the possible 7fe0,0010 multiplicity
1735 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1736 to allow removal of references to 7fe0,0010, to deal with
1737 ACR-NEMA images, when 0028,0200 is meaningfull
1739 2004-01-31 Jean-Pierre Roux
1740 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1741 no longer writes 'Un' on disk
1742 * FIX SQ elements with actual length are now dealt with corectly
1743 * FIX gdcmFile::WriteBase make the difference, for color images, between
1744 the length (for Palette expanded images)
1745 and Raw Length (non expanded image + Palette)
1746 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1747 (that broke Write). Replaced by UL.
1748 Aware user will reload the field if he
1749 thinks it's necesssary
1751 2004-01-30 Jean-Pierre Roux
1752 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1753 when 'dirty Acr' is found, to be compliant with the new
1754 IsReadable() methods.
1756 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1757 (no DOUBLE images in kosher DICOM,
1758 but so usefull for people that miss them ;-)
1760 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1761 DICOMDIR related utilities (not checked as Windoze compliant)
1763 2004-01-28 Jean-Pierre Roux
1764 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1766 2004-01-27 Jean-Pierre Roux
1767 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1768 to allow skipping the shadow elements, to save memory space.
1769 The TRUE value for this param has to be used
1770 with a FALSE value for the 'enable_sequence' param.
1771 ('public elements' may be embedded in 'shadow Sequences')
1772 * gdcmHeader methods now deal with 'embedded icones images' in the header
1773 (even when an 'icone image sequence' is announced by the
1774 element (0x0088,0x0200), but there is NO icone at all ...
1776 * gdcmHeader sometimes Image Location value doesn't follow
1777 the supposed processor endianity (see gdcmData/cr172241.dcm).
1780 * gdcmHeader add the method
1781 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1782 to get *all* the Header Entries with the same tag.
1783 GetHeaderEntrySameName is probabely *useless*
1784 (no meaning : Name is *not* an identifier within the Dictionnary)
1786 2004-01-26 Benoit Regrain
1787 * Bug fix in the print of hexadecimal representations. Remove long fields
1788 in the print and add a third level of print to print them
1790 2004-01-23 Benoit Regrain
1791 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1792 * Bug fix on test suite after remove the strip made on not string fields
1793 * Split the IsReadable method between gdcmParser which test that the file
1794 is dicom and gdcmHeader which test that it's an image file
1796 2004-01-22 Benoit Regrain
1797 * DicomDir : clean code, add methods, set variables in protected or private
1798 * gdcmUtil : bug fix for the clean string method
1800 2004-01-19 Benoit Regrain
1801 * Add the use of shadow dictionaries
1802 * bug fix and coding style
1804 2004-01-19 Benoit Regrain
1805 * src/gdcmFile.cxx : bug fix concerning the close of file
1806 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1807 * Add the update of header entries using the shadow library
1809 2004-01-19 Benoit Regrain
1810 * removal of file gdcmHeader2.cxx
1811 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1812 inheriting from gdcmParser. This split is to prepare the integration
1813 of dicom dir parsing
1814 * bug fix under python
1816 2004-01-16 Jean-Pierre Roux
1817 * REM removal of class gdcmHeaderEntrySet
1818 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1819 * ADD add file gdcmHeader2.cxx
1820 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1822 2004-01-15 Benoit Regrain
1823 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1824 entries created while parsing the header. Thus, they will be destroyed
1825 when the gdcmDictSet will be destroyed
1826 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1829 2004-01-15 Benoit Regrain
1830 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1831 made a fatal error because of the memory release at the end of program.
1832 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1833 some memory and vtk seems to have some problems with that.
1834 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1836 2004-01-14 Benoit Regrain
1837 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1838 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1839 * src/*.[h|cxx] : make changes due to class name changes
1840 * gdcmPython/demo/*.py : bug fix due to method names
1842 2004-01-13 Benoit Regrain
1843 * src/*.[h|cxx] : coding style
1844 * vtk/*.[h|cxx] : coding style
1846 2004-01-13 Benoit Regrain
1847 * gdcmPython/testSuite.py : test the readable flag of file for tests
1848 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1849 It's lied to the stl compilation by MSVC (windows, always windows...)
1850 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1852 2004-01-12 Benoit Regrain
1853 * src/*.h : add comments
1854 * src/gdcmDictSet.h : set the method BuildDictPath in public
1855 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1856 directly setted in the source code
1857 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1860 2004-01-09 Benoit Regrain
1861 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1862 * setup.py : use a reference to gdcmVERSION
1864 2004-01-07 Benoit Regrain
1865 * Modification to compile with the distutils.
1868 2003-12-10 Benoit Regrain
1869 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1870 can use a gdcmHeaderHelper to load data
1871 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1872 made in the source code
1874 2003-12-10 Benoit Regrain
1875 * Update Windows projects and .cvsignore files
1877 2003-11-12 Jean-Pierre Roux
1878 * ENH gdcmHeader constructor has one more parameter (default value : false)
1879 that allows the user to 'go inside' the SeQuences only
1881 gdcmElValSet:Print takes it into account
1883 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1884 * ENH: Update gdcmPython/CMakeLists
1885 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1886 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1888 2003-11-10 Jean-Pierre Roux
1889 * FIX : gdcmHeader::LoadElements is now based
1890 on the ListTag listElem member,
1891 not longer on the TagElValueHT tagHt member
1892 * ENH : PrintPubElVal shows (temporarily) both results,
1893 with the tagHt member and the listElem member.
1894 (it's easier to 'see' the problems when using Printheader)
1896 * FIX : old private member LgrElem is now splitted into
1897 ReadLength : Length actually found on disk (updated only
1898 if bug fixing is necessary), for internal
1900 UsableLength : Updated by FixFoundLength, to fix a bug
1901 or to allow Parser going on.
1902 Will allow to re-write a kosher header when a SeQuence
1903 with a length (not 0000) is found
1904 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1905 because gdcmElValSet::Add does not update ListElem
1908 2003-11-07 Jean-Pierre Roux
1909 * FIX misstyping in Transfert Syntax name table
1910 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1911 when they have an actual length (not 0000 nor FFFFF)
1912 (Nobody should care of it, but DICOMDIR explorers)
1914 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1915 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1917 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1918 * ENH: vtkGdcmReader now supports LUT !
1919 (vtkgdcmViewer for now is not able to use them though)
1921 2003-11-05 Jean-Pierre Roux
1922 * in testSuite.py : new files names for checking the package
1923 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1924 that returns the pixel area size to the *aware* (vtk) user
1925 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1927 2003-11-05 Benoit Regrain
1928 * in testSuite.py : Modify the rules for checking the paths
1929 : Explicit error messages
1930 * in __init__.py : Related modif
1932 2003-11-03 Jean-Pierre Roux
1933 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1934 to be used by aware (vtk) users that want to manage
1935 LUT (and no to turn the PALETTE image into an RGB pixels one)
1936 * GetPixelType now returns 8U for 24 Bits images
1937 (vtkGdcmReader compliant)
1939 2003-10-31 Jean-Pierre Roux
1940 * Removal of *all* gdcmData images and add them again
1941 in order to loose the 'history' of un-anonymised images
1943 2003-10-31 Jean-Pierre Roux
1944 * RMV : removal of useless jBitsInJsample.h
1945 for both 8 and 12 Bits JPEG Lossy Libraries
1947 2003-10-31 Jean-Pierre Roux
1948 * ENH : Add the functions gdcmFile::GetImageDataRaw
1949 gdcmFile::GetImageDataIntoVectorRaw
1950 that act as GetImageData and GetImageDataIntoVector
1951 except the making of an RGB Plane from Gray Plane + LUT
1952 Intended to aware (vtk) users who know how to manage
1955 GetLUTRGBA return a R,G,B,A LUT if any
1956 lgrTotaleRaw gives the 'Raw' length
1957 GetImageDataRaw returns the gray Plane
1958 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1959 (They stay Grey, just like with other Dicom viewers :-(
1961 2003-10-30 Jean-Pierre Roux
1962 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1964 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1965 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1966 being coherents dicom files.
1968 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1969 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1971 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1972 * ENH: Two steps is necessary to please VC++ compiler...
1973 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1974 * ENH: Add include dir to medcon lib
1975 * FIX: only one function is being exported for now !
1976 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1978 2003-10-29 Jean-Pierre Roux
1979 * adding gdcmHeader::GetLUTRGBA
1980 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1981 --> Mathieu, the modif u're waiting for is not yet committed
1982 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1984 2003-10-27 Jean-Pierre Roux
1985 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1986 00191113.dcm DermaColorLossLess.dcm
1987 MxTwinLossLess.dcm RadBWLossLess.dcm
1988 * ENH: For version prior to vtkImageViewer2 -r 1.19
1989 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1991 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1992 * Removal of ido stuff in CMakeLists.txt
1994 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1995 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1996 * FIX: remove a call to ->Modified ... see comments
1997 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1999 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2000 * FIX: Problem with path for libvtkgdcmPython
2001 * ENH: Try adding a search script for python site-package
2002 * RMV: Remove some file from medcon lib that are not necessary
2003 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2004 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2005 * FIX: More pragma disable fro VC++,
2006 I don't think I break something as it is also disable in VTK/ITK.
2007 But it fasten debug compilation time.
2009 2003-10-23 Jean-Pierre Roux
2010 * gdcm now deals with 16 Bits Run Length Encoded images
2011 (they are compressed as 2 planes images,
2012 one for the high Bytes, the other for low Bytes)
2014 2003-10-22 Jean-Pierre Roux
2015 * Now CheckRead takes into account :
2016 - the bugged 'Leonardo' Siemens images
2017 - the XA images, sent thru the burning VPRO station
2018 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2021 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2022 * FIX: When copying a Makefile.am to CMakeLists.txt
2023 one should remove the '\'
2025 2003-10-22 Jean-Pierre Roux
2026 * in gdcmData adding a bugged 'Leonardo' Siemens image
2027 (wrong lengths in header)
2028 OK with gdcm, KO with the other viewers :-)
2029 * add a GE dlx XA image, thru the VEPRO burning station
2032 2003-10-21 Jean-Pierre Roux
2033 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2034 for a brutal checking of vtkgdcmViewer compliance
2036 2003-10-21 Jean-Pierre Roux
2037 * add the files for 'xmedcon' Jpeg Lossless library
2038 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2040 2003-10-21 Jean-Pierre Roux
2041 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2043 2003-10-21 Jean-Pierre Roux
2044 * garbage Siemens 'Leonardo' images dealt with
2045 (the patch is easy to remove)
2046 * cosmetic changes to avoid warnings
2048 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2049 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2050 no need to press 'r' now.
2052 2003-10-20 Jean-Pierre Roux
2053 * upgrade of checkRead.sh checkWrite.sh according
2054 to new Jpeg Lossless decompressor
2055 * add US.3405.1.dcm, a genuine RGB medical file ...
2056 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2057 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2059 2003-10-15 Jean-Pierre Roux
2060 * general anonymisation in gdcmData
2061 * adding the 'color files' from
2062 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2063 * adding some well knowed bugged-header images
2064 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2065 waiting for their inclusion in Python testsuite
2067 2003-10-15 Jean-Pierre Roux
2068 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2069 no longer seg faults when file is not found
2071 2003-10-14 Jean-Pierre Roux
2072 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2075 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2076 * TODO: *.in file to genereate a UseGDCM later
2078 2003-10-14 Jean-Pierre Roux
2079 * Some supposed-to-be Dicom Images have no preamble.
2080 OpenFile takes it into account
2081 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2082 * Missing elements added in dicomV3.dic
2083 (just to be affraid : have a look at
2084 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2085 and do it again next year ;->
2087 2003-10-13 Jean-Pierre Roux
2088 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2089 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2090 But there are NOT. It's fixed !
2092 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2093 * FIX: "jpeglib.h" was not found on VC++
2094 * FIX: vtkgdcm was not being installed
2096 2003-10-10 Jean-Pierre Roux
2097 * ENH : OpenFile closes the file if it *really* doesn't look like
2098 an ACR-NEMA / DICOM one.
2099 * FIX : testWrite no longer writes an empty file if the source file
2100 is not gdcm Readable
2101 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2104 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2105 * FIX: CMake generate now documentation
2106 * ENH: out of source doc build !
2107 * ENH: Generate both user and dev documentation
2108 * ENH: Should work on windows too
2109 * ENH: Only one doxygen config.in file is needed
2110 * FIX: make install should be ok now on ùnix plateform
2111 * FIX: PATH to dictionary was wrong (missing /)
2112 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2114 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2115 * vtkGdcmReader is now able to read rgb dicom file.
2116 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2117 * added a gdcmViewer to vtk test, use mouse to control
2118 window level & window width
2120 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2121 * CMake-ification of gdcm, we have now two build system
2122 * FIX: on cygwin Wsock32 doesn't exist
2123 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2125 2003-10-06 Emanuel Ollart
2126 * FIX : compilation process wad broken.
2127 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2129 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2130 * change gdcmViewer -> vtkgdcmViewer
2131 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2133 2003-10-06 Jean-Pierre Roux
2134 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2135 ( e.g : well known GE images with a wrong elem length,
2136 : Philips MRI Images with a wrong Huffman table)
2137 * still to be done : allow the reading of bugged LEONARDO Siemens images
2139 2003-10-03 Jean-Pierre Roux
2140 * Odd length strings are padded with '\0' (not with spaces,
2141 to remain compliant with already defined strings,
2142 like Transfert Syntax UID and others)
2144 2003-10-03 Jean-Pierre Roux
2145 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2146 to allow displaying RGB images (not only by affim ;-)
2148 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2149 * vtkGdcmReader is now able to read rgb dicom file.
2150 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2152 2003-10-03 Jean-Pierre Roux
2153 * A few nasty patches to allow the reading of a lot of nasty images
2154 ( e.g : well known GE images with a wrong elem length,
2155 : Philips MRI Images with a wrong Huffman table)
2156 * still to be done : allow the reading of bugged LEONARDO Siemens images
2158 2003-10-03 Jean-Pierre Roux
2159 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2161 2003-10-03 Jean-Pierre Roux
2162 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2163 to allow displaying RGB images (not only by affim ;-)
2165 2003-10-03 Jean-Pierre Roux
2166 * gdcmFile::GetImageDataIntoVector now
2167 - deals with MultiFrames MultiFragments Run Length Encoded files
2168 - deals with YcBcR (YBR_FULL) files
2169 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2170 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2172 (no sample found :-(
2174 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2175 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2176 Two reasons: - clear things
2177 - third parties acces gdcm through header files, so won't
2178 suffer anymore VC++ complains
2180 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2181 * add argv[1] in testvtkGdcmReader.cxx
2184 2003-09-24 Jean-Pierre Roux
2185 * The lines are now eigthy characters long.for
2186 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2188 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2189 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2190 char* to std::string. Thus, the use of strdup becomes useless. (see
2191 previous commis of Malaterre)
2192 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2193 before the last Malaterre's commit.
2195 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2196 * This commit should fix the Debug building under VC++, the problem
2197 was mainly a mixture of debug and release lib being loaded at startup.
2198 * I also remove a depency to a specific C function: strdup. Because I had
2199 to force the link to msvcrtd (whereas strdup is in libc).
2201 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2202 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2203 located in the gdcmCommon.h file. All use of reference of tha has been
2204 changed to now use the variable GDCM_UNFOUND.
2206 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2208 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2209 Dicom dictionary. The test suite can now be run again. Note:
2210 I'm note very happy with the " (RET)" changes. I believe this
2211 RETAINED comment should be dropped when parsing the dictionary.
2212 - PACKAGER corrected
2214 - AUTHORS updated and now in alphabetical order
2215 * Makefile.am now exports gdcm.dsw for Windoze users.
2217 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2218 * cygwin complains about missing std:: in subdir Test/
2220 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2221 * remove some methods that are now in gdcmHeaderHelper
2223 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2224 * vtkGdcmReader set spacing and origin correctly
2226 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2227 * Fix a few delete/delete[] mismatch
2229 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2230 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2231 interpretation to data given by gdcmHeader. For instance there are
2232 heuristics to get informations (look at different places).
2233 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2234 sorting DICOM images based on different strategies.
2235 * modified Makefiles accordingly.
2237 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2238 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2239 when building in debug mode
2240 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2241 src/win32/gdcmdll.dsp
2242 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2244 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2245 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2248 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2249 * src/win32/libgdcmjpeg12.dsp was not dos format
2250 * src/win32/libgdcmjpeg12.dsp :
2251 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2252 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2254 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2255 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2257 * src/gdcmFile.cxx : bug fix in affectation type
2258 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2259 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2260 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2261 symbols... future problem ?
2263 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2264 * src/win32/libgdcmijpeg12.dsp was missing
2265 * modified gdcm.dsw accordingly
2267 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2268 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2270 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2271 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2272 commit of JPR (before his hollidays to facilitate our work).
2273 * setup.py : bug fix in code. Modifications made while the last commit
2274 of JPR. The code hasn't been tested before the commit... it's so
2275 useless to make that (for best programmer that is JPR) !!!
2277 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2278 * tagged the current version as Version0_3 (i.e. version 0.3)
2280 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2281 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2282 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2283 * *.dsp : modifications to use new libgdcmijpeg8 library
2284 * setup.py : bug fix on VTKPATH variable
2285 * PACKAGER : adding all concerning windows
2287 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2288 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2290 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2291 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2292 test suite reported error.
2293 * PACKAGER file added (describes what a packager must do when
2294 packaging a new release).
2295 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2296 * configure.in: upgraded version number to 0.3.0
2297 * fixing build of rpm (through rpm -ta):
2298 - Doc/Makefile.am exports proper doxygen files
2299 - src/jpeg/libijg8/Makefile.am exports the include files.
2301 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2302 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2303 * src/gdcmHeader.h : formatting code
2305 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2306 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2307 We were obtaining error message from vtk. Now, creation of file list
2308 is made in an internal list to prevent this problem.
2309 Bug fix when output is empty.
2310 Bug fix in update of progress value. Previous commit for this was a bad
2312 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2314 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2315 * src/gdcmHeader.h : added method to get the file name
2316 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2317 files. Added method to remove all files on the input
2318 Added FIXME comment concerning the bad parsing of header made by
2319 ExecuteInformation method (in ExecuteData method)
2321 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2322 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2323 when using make instal.
2324 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2325 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2327 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2328 * setup.py : adding include dir of jpeg lib to compile all sources
2329 * */Win32/*.dsp : JPR fix for windows compilation
2331 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2332 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2334 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2335 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2337 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2338 * setup.py is again effective on un*x (takes into account the
2339 addon of the jpeg library)
2340 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2341 * Doc/Doxy* updated (includes above enhancements)
2342 * INSTALL now points to web documentation
2344 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2345 * src/gdcmHeader.h doesn't make unnecessary reference to
2347 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2349 * src/gdcm*.[cxx|h] :
2350 - to allow compilation with gcc 3.x
2351 -- clean up of STL usage (added explicit usage of std::)
2352 -- small fixes on exceptions.
2353 Note: linking not tested !
2354 - clean of doxygen comments to avoid warnings at documentation
2356 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2357 dependent convertion).
2359 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2360 * Clean up of previous JPR garbage commit (not even commented in the
2362 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2363 - moved all jpeg related files from src to src/jpeg/libijg8, with
2364 addition/modification of Makefile.am and configure.in.
2365 - the testSuite is still brain damage (not guilty).
2367 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2368 * WrapVTK.py : modifications to get correctly vtk source files to
2370 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2371 (FileName -> Filename)
2373 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2374 * vtk/vtkGdcmReader.[cxx/h]:
2375 - UpdateProgress method should now be effective
2376 - removed the limitation on having only images loaded (as opposed
2378 - when building a stack of images/volume, a lesser number of
2379 gdcmHeader and gdcmFile instances should be used (hopefully
2380 accelerating things).
2381 - when building a stack of images/volumes, files which are not
2382 loadable (wrong path-filename, wrong permissions on existing file,
2383 or file not parsable by gdcm) are replaced with a black image
2384 in the stack (for the caller to notice the problem).
2386 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2387 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2389 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2390 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2391 between standard library (std) and vtk library (problems are found
2392 under Windows... thanks Windows !)
2394 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2395 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2397 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2399 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2400 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2402 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2403 * When compiling with distutils (see setup.py) the C++ compiler is
2404 called with different flags than the default ones (with automake).
2405 In order to fix all those warning, I compiled gdcm with the command
2406 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2407 and went for warning fixes:
2408 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2409 up from unused variables.
2410 - vtk/vtkGdcmReader.cxx: potential bug fix.
2411 * src/gdcmHeader.h: Doxygen warning cleanup
2413 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2414 * gdcmPython/gdcm.i:
2415 - typemaps correction to take into account the systematic replacement
2416 of "using namespace std" with std:: prefix e.g. std::list,
2417 std::string... (cf changes of 2003-05-21).
2418 - gdcmGlob global variable of type gdcmGlobal (defined in
2419 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2420 exported to Python a as cvar.
2421 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2422 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2423 gdcmDictSet.GetPubDictTagNames() and
2424 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2425 C++ static methods).
2426 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2427 with the above changes.
2429 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2430 * setup.py, manifest.in : bug fix under linux
2432 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2433 * Modification of setup.py to compile vtk part too. Then, we have 2
2434 wrappers which must work with same distutils. For that, we have a
2435 generic distutils in distusiltsWrapping.py ; with :
2436 - build_extWrap class to wrap generically all extensions,
2437 - ExtensionWrap base class for all wrapping extension that contains
2439 - Wrapper interface which wrap sources
2440 + In WrapSwig.py we have extension and wrapper for Swig
2441 + In WrapVTK.py we have extension and wrapper for VTK
2442 * MANIFEST.in : modifications to consider vtk directory and new python
2443 files for compilation
2445 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2446 * Added python wrappers of vtkGdcmReader vtk class (see the
2447 source in vtk/vtkGdcmReader.cxx) :
2448 - vtk/Makefile.am now builds a library
2449 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2450 python library (as opposed to _gdcm.so wich are the python
2451 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2452 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2454 - configure.in has an additional flag --enable-vtk that needs
2455 to be set to enable compilation of vtk related code, that is:
2456 + vtk/vtkGdcmReader.so and
2457 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2458 + gdcmPython/vtkgdcmPython.so (see above)
2459 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2460 be read when compressed or when HighBit + 1 != BitsStored),
2461 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2462 the usage of the python wrapper of vtkGdcmReader vtk class.
2463 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2464 * src/*.[h] all occurences of stl classes are now prefixed with
2465 std::, and all occurences of "using namespace std;" where removed.
2466 This is to avoid pollution of global namespace in included files.
2467 Apparently vtk does not avoid this pitfall: when using both
2468 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2469 collision of various stl members (principally cout...).
2470 * gdcmPython/testSuite.py now cleanly removes temprory generated
2472 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2473 comply with above changes)
2475 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2476 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2477 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2478 vtk data structure (an image Flip was required).
2479 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2480 * cosmetic changes in documentation.
2482 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2483 * src/gdcmHeader.cxx: the constructor no longer exits when an
2484 unexisting file is given as argument.
2485 * The subdirectory Data (containing all the images used for the
2486 test suite) is not part of this repository anymore. A new module
2487 containing those images is now available at
2488 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2489 with the name gdcmData.
2490 All the python scripts (including the package initialisation file
2491 gdcmPython/__init__.py) were adapated to take this change into
2492 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2494 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2495 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2496 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2497 demo of the usage of this class.
2498 Compilation of this vtk part is only done when using the --enable-vtk
2499 at configure (or autogen.sh) stage.
2501 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2502 * More memory link related corrections and documentation fixes.
2504 - maximum info is obtained with a command of the form:
2505 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2506 --show-reachable=yes PrintHeader
2507 - the remaining reachable blocks seem to come from the STL
2508 allocation scheme through the usage of map and list. It looks
2509 like this memory cannot be freed but it is not a memory leak
2510 (in fact further invocation to the STL would recollect the
2511 unused memory allthough it cannot explicitely be freed).
2512 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2513 of displaying an image parsed with gdcm and displayed with VTK.
2514 Note: some images don't seem to work e.g.
2515 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2516 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2517 Allthough this weakens the semantics, it is a ditch attempt to
2518 make gdcm more thread friendly.
2520 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2521 * Memory link hunt (by using valgrind through the command
2522 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2523 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2524 gdcmHeader::_dicom_vr.
2525 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2526 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2528 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2530 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2531 * src/Makefile.am now exports all the necessary include files at
2535 * UpdateGroupLength replaced by new one
2538 * UpdateGroupLength re-written using H-Table
2539 (named UpdateGroupLengthNew untill checks are over)
2541 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2542 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2543 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2545 - gdcmHeader::GetPubElValSet removed.
2546 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2547 UpdateGroupLength, WriteElements, Write.
2548 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2549 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2550 carried the same semantics.
2551 - src/gdcmHeaderIdo.cxx changed accordingly.
2552 - gdcmFile::WriteBase now regroups all the codes from previous
2553 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2554 - enum FileType moved to gdcmCommon.h
2555 * src/gdcmHeader.cxx AddDefault trashed
2556 * gdcmGetXSize added
2557 * getimageDataSize now calls gdcmGetXSize
2558 * Test/*.cxx changed to agree with above changes
2560 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2561 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2562 (to avoid double call by end user).
2563 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2564 by end user, since gdcmHeader::gdcmHeader now handles it.
2566 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2567 * gdcm/Doc many doxygen changes:
2568 - Doxyfile now has two different versions, DoxyfileUsers that generates
2569 the html.users end users oriented documentation and
2570 DoxyfileDeveloppers that generates the html.developper developper
2571 oriented documentation.
2572 - README changed accordingly
2573 - requirement.txt removed (old design info moved to TODO).
2574 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2575 DoxyMainPage.txt, DoxyPython.txt provide more information.
2576 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2577 be updated by simply regenerating the docs with doxygen and copying
2578 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2579 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2580 all the tests in the form "if (<map>.count() >1)" were removed.
2581 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2582 ill-formed documentation sections.
2583 * src/gdcmHeader.cxx: ditto
2585 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2586 * setup.py fixed for un*x (needed macro for stdint.h)
2587 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2588 un*ces with sh-utils test utility.
2589 * gdcmPython/demo/test.py renamed to PrintHeader.py
2590 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2591 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2592 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2593 * src/gdcm*.cxx JPR's bad inclusion fixed.
2595 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2596 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2597 * gdcmPython/demo/test.py changed accordingly.
2599 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2600 * gdcmPython/Makefile.am fixed linking against libstdc++
2601 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2602 * Swig subdir (historical tests of swig version 1.3.17++) removed
2603 * Test/testChangeEntete.cxx some lines commented out in order to make
2605 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2606 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2608 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2609 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2610 hence the user doesn't need this explicit call.
2611 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2612 i.e. LoadElements() call removed.
2613 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2614 - src/Makefile.am declares the proper flag for g++.
2615 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2616 for adding user defined new tags.
2617 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2618 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2619 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2621 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2622 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2623 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2624 src/Makefile.am : the project should properly compile and install
2625 with the autotools, included the python wrappers part.
2626 * gdcm.spec.in : added a spec file for RPM packaging.
2628 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2629 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2631 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2632 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2633 to exported to the environement (see gdcmPython/testSuite.py
2635 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2636 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2637 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2638 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2639 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2641 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2642 * gdcmPython/__init__.py doesn't crash anymore when running in
2643 in InstallMode or PreInstallMode but with an environement given
2644 value of GDCM_DICT_PATH.
2645 * src/gdcmDictSet.[cxx/h] coding style.
2647 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2648 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2649 * src/gdcm.h general comments moved to TODO, and README
2650 * src/gdcm.h should now be seen as a user commodity (including it
2651 should suffice to fully use gdcm). It is nowhere including within
2652 any of the kernel files src/*.cxx and src/*.h.
2654 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2655 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2656 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2658 * src/gdcm*.cxx only include their corresponding include file
2659 (as opposed to gdcm.h)
2660 * gdcmPython/gdcm.i changed accordingly
2661 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2662 the autogen.sh generated "make snapshot" command to work.
2663 * autogen.sh removed history related references to crea package.
2665 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2666 * distutilsSwigCPlusPlus.py work around some swig portability
2669 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2670 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2671 was done in a last ditch attempt to get setup.py _really_
2672 operationnal. The python/gdcmPython layaout add the advantage
2673 of hidding away the python related distutils specific files
2674 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2675 Alas, the src directory was out of scope (i.e. it's relative
2676 position to setup.py was ../src) which made things impossible to
2677 handle (see previous version of python/setup.py). Crossing fingers...
2679 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2680 * python/setup.py now works on Un*x. (harder than I thougth)
2681 * python/distutilsSwigCPlusPlus.py can now have include files
2682 among the list of sources.
2684 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2685 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2686 * modifications in MSVC projects
2688 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2689 * As stated by the first lines of Test/ExceptionAndPython/README, it
2690 looks like we can move back to original usage of exception within
2691 src/gdcm* and hence remove the errno stuff that was introduced
2692 as a quick and dirty fixture of this problem (added to the TODO).
2693 * Doc/Doxyfile configuration file for Doxygen and corresponding
2694 README file for usage added.
2695 * Test/testWrite.cxx added. This new test comes from a split of
2696 test.cxx that is now reverted to its original purpous i.e.
2697 testing the proper parsing of a Dicom related file.
2698 testWrite.cxx concentrates on testing the IO part of gdcm.
2699 * Test/bug1.cxx (containing a bug on WIn32) added.
2700 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2701 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2702 whose purpose is to publish the content of the TagNames of the
2703 Dicom public dictionnary were not accessible without an
2704 instance of class gdcmHeader.
2705 - those methods are now static methods of gdcmDictSet and hence
2706 require no instances at all to be invocated.
2707 - within gdcmDictSet this change required to change some method
2708 to class methods (i.e. are now static) among which SetDictPath
2709 (renamed to BuildDictPath) and LoadDefaultPubDict.
2710 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2711 the above changes by calling the new method classes of gdcmDictSet.
2712 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2713 the above to be effective.
2714 * python/gdcmPython: in order to wrap properly the above changes
2715 for Python, swig version now needs to be > 1.3.17.
2716 * python/gdcmPython/Makefile fixed to adapt itself to new
2717 configure/make shema introduced by Johan Montagnat (thanks for the
2718 contribution). Alas this Makefile cannot be turned into a proper
2719 Makefile.am without some heavy changes in the configure.in
2720 (for python dectection).
2721 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2722 now avoids publishing the empty entries.
2724 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2725 * python/setup.py : bug fix concerning install under windows
2726 ExtraPath reused :-P
2727 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2729 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2730 * Dicts/dicomV3.dic : remove double spaces !!!
2731 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2732 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2735 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2736 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2737 method. Doxygenation.
2738 * src/gdcm.h clean up of JPR spurious comments.
2740 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2741 * python/distutilsSwigCPlusPlus.py now properly collects the
2742 shadow classes generated by "swig -c++" (gdcm.py in our case)
2743 when using "python setup.py install".
2744 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2745 reexports the working classes.
2746 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2747 by the classical C errno scheme. This is to prevent an obscure
2748 behavior of the python wrappers when importing wxPython.wx prior
2749 to gdcmPython (which ended up in an abort call). An illustration
2750 of this oddity can be found in the Test/ExceptionAndPython
2751 subdir (see the README file). This problem probably due to
2752 an combination of g++ and dynamic loading.
2753 * added Test/ExceptionAndPython (see above)
2755 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2756 * Changed the layout of the python part to avoid bloating main
2757 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2758 i.e. the distutils arsenal. All the python related stuff is
2759 again in a python subdir, but the package itself is now in
2761 * setup.py was cleaned up:
2762 - pythonIncludePath removed
2763 - python setup.py bdist target is now functional.
2764 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2765 collision with other packages). gdcmPython/demo/*.py changed
2768 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2769 * python subdir moved to gdcmPython (preparation of distutils packaging).
2770 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2771 distutils installer is operational.
2772 * - gdcmPython/__init__.py now properly loads the swig generated
2773 shadow classes (from gdcm.py).
2774 - gdcmPython/demo/*.py changed to import the package gdcmPython
2775 instead of gdcmPython/demo/load.py.
2776 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2778 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2779 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2780 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2781 entries within the associated public Dicom dictionary resp. the same
2782 information but sorted by the fourth field (PAT, IMG, DIR) of the
2784 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2785 are now in the "???" group.
2786 - python/gdcm.i changed accordingly,
2787 - python/demo/printGroupedPublicDict.py added, that gives an example
2788 of the above new functionalities in Python.
2790 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2791 * src/gdcm.h, gdcmHeader.cxx:
2792 - historic references to glib's g_malloc and g_free (#defined)
2793 were definitively removed.
2794 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2795 * src/gdcmElValSet.cxx:
2796 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2797 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2798 - GetElValue(string) renamed to GetElValueByName.
2799 - Added GetElementByName(string).
2800 * src/gdcmHeader.cxx: added
2801 - GetPubElValRepByNumber(guint16, guint16)
2802 - GetPubElValRepByName(string)
2803 - GetShaElValRepByNumber(guint16, guint16)
2804 - GetShaElValRepByName(string)
2805 - GetShaElValByNumber(guint16, guint16)
2806 - GetShaElValRepByName(string)
2807 - GetElValRepByNumber(guint16, guint16)
2808 - GetElValRepByName(string)
2809 - GetElValByNumber(guint16, guint16)
2810 - GetElValRepByName(string)
2811 * Doc/requirements.txt added.
2813 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2814 * Test/Makefile building now depends on the one of libgdcm.so
2815 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2816 pixel data) aware which enables finding the address (offset) of
2817 the pixel data of JPEG encoded DICOM files. This leaves only a single
2818 file in the testSuite whose pixel data address (offset) is unknown.
2819 * python/testSuite.py changed accordingly.
2821 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2822 * VC++ has some strong limitations when working with the STL, as stated
2823 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2824 "Also note that some STL containers (map, set, queue, list, deque)
2825 cannot be exported. [...]
2826 Some STL classes contain nested classes. These classes can not
2828 This is caused by a designed limitation that once a template
2829 class is instantiated, it can not be re-instantiated and
2831 Since our usage of map<> is ubiquitous in gdcm, this "designed
2832 limitation" of VC++ is a pitfall.
2833 Hence the Python wrappers of gdcm cannot be incrementally linked
2834 against the c++ dynamic library. The dirty but only workaround is
2835 to forget about incremental link of dynamic libraries and to generate
2836 the Python wrappers library with the inclusions of the underlying C++
2838 The following modifications concern this matter on Win32/VC++:
2839 - wrapping python correct with standalone wrapped dll (don't use separate
2840 dll under windows !!!!)
2841 - python21_d debug mode enabled (ask Frog how to use it :-)
2842 - NO problem with having an STL member of class for example string in C++
2843 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2844 - Python test of dcmlib in Python is ok under windows on a large set
2846 * removed glib references
2847 * typedef's inserted in gdcm.i for correct swig type management
2849 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2850 * python/demo/*.py load.py extracted from test.py. Added explore.py
2851 that only displays required tags and testAll.py that parses all
2852 the files of the testsuite without using unittest.
2853 * python/testSuite.py other additional test on new files added.
2854 * Data/* new test files added accordingly to the testSuite.
2855 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2856 the vr in the file differs from the one of the dictionary.
2858 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2859 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2860 values, but limits itself to values which are below a user specified
2861 size (by default 1024 bytes).
2862 * python/gdcm.i : elements not loaded (because their size is above the
2863 user specified treshold) are exported with their TagKey as key of the
2864 python dictionary. This enables the testsuite to make some checks
2865 on the unloaded elements (since we have their offset and size).
2866 * python/testSuite.py
2867 - now tests for the existence and proper value of the pixel data
2868 - two new examples added.
2869 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2871 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2872 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2873 aware. See the strategy comments in gdcmHeader::FindeLength().
2874 * Test/test.cxx now accepts a filename as first argument.
2875 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2876 * python/testSuite.py changed to integrate test on above files.
2878 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2879 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2880 the vr was also RET.
2881 * python/testSuite.py more tests added.
2883 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2884 * python/testSuite.py unittest test suite added (uses Data)
2885 * Data/* dcm and acr files for the test suite.
2886 * glib dependance removed from un*x version. We now use ISO C99
2887 7.18 Integer types (see stdint.h)
2888 - python/Makefile, src/Makefile src/gdcm.h
2889 * src/ when an explicit vr (like dicom files) suddenly poped an
2890 implicit element we use to mark the underlying DictEntry of the
2891 concerned ElValue with "Implicit". This strategy was damageable
2892 too the public or provite dictionaries, since some of their vr
2893 would be changed. Since Header::FindLength heavily relies on the
2894 detection by Header::FindVR of falsely explicit elements, I
2895 added an extra ImplicitVr member to ElValue (boolean).
2896 The rest of the changes we the necessary adaptations.
2898 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2899 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2901 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2903 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2904 * Adaptation for porting to VC++:
2906 o forced to use std namespace (for string to be known)
2907 o all class use __declspec export style on WIN32
2908 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2909 (in stdlib.h on Win32 but in std:: for gcc)
2910 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2911 variable GDCM_DICT_PATH.
2912 * src/gdcmHeader.cxx verbose comments made discrete.
2914 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2915 * python/gdcm.i: added a typemap that converts a C++ hashing table
2916 to native Python dictionary.
2917 * python/demo/test.py:
2918 - now uses the native dictionary for exploration of gdcmHeader.
2919 - takes an optional filename argument (the file to parse).
2920 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2921 PubElVals hashing table.
2922 * Dicts/dicomV3.dic removed error prone trailing spaces.
2924 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2925 * Python wrapping process moved away from src/Makefile to
2926 newly created python/Makefile (as well as gdcm.i)
2927 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2928 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2929 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2930 from the environement variable GDCM_DICT_PATH (when existing).
2931 * src/gdcmDict::GetTag bug fix.
2933 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2934 * Straightforward temporary fixes for swig to build the python wrappers.
2935 src/Makefile now has a python working entry [by working we mean
2936 that we can import de shadow classes without errors].
2938 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2939 * hashtest.cxx removed (since allready in Test)
2940 * src/gdcmlib.h renamed to src/gdcm.h
2941 * src/dcm.i renamed to src/gdcm.i
2942 * src/Makefile prepared for python wrapping
2944 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2945 * src/gdcmHeader.cxx :
2946 - Parsing of header is now separated from loading of element values
2947 (see gdcmHeader::LoadElements).
2948 - general clean up of hopefully all file access (creation of
2949 ReadInt16 and ReadInt32)
2951 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2952 * src/gdcmHeader.cxx :
2953 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2955 - SetLgrElem renamed to SetLength
2956 - GetLgrElem renamed to GetLength
2957 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2958 * src/gdcmElValSet.cxx fixed both GetElValue methods
2959 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2960 due to IdoDude was cleaned out.
2962 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2963 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2964 concentrates on finding the value representation (when it exists).
2965 RecupLgr now only finds the element value length, and it avoids
2966 returning the unecessary skL (skipped length).
2967 Also, offsetCourant was simply removed (with taille_fich) since
2968 it was redundant with the File position internals (by using
2969 ftell and fseek). This also made skL (see above in RecupLgr) usage
2971 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2972 on the libido specificities which are handled through class
2974 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2977 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2978 * Truckload of changes. Parsing of header is barely functional
2979 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2981 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2982 * src/gdcmHeader.cxx many addons of low level methods
2984 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2985 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2986 and _IdDcmSWAP_LONG.
2988 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2989 * This corresponds to all the changes decided at the meeting of
2990 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob