1 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
2 * ENH - Comment out Mathieu's (dangerous) Super Hack
3 for dealing with BIGENDIAN processors
4 - Move equivalent stuff to BinEntry::WriteContent
5 When necessary, 16 Bits Pixels are swapped in a small buffer
6 and then written. This avoid allocating a huge buffer, in
7 PixelWriteConveror, and avoid modifying the Pixel Area.
9 Probabely, the same operation will have to be done when we want
10 to write image with Big Endian Transfert Syntax,
11 and we are working onj Little Endian Processor
13 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
16 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
17 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
19 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
21 * Test/TestDict.cxx : add a new test for the dict classes
23 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
24 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
25 file. Debug is yanked if compiled with NDEBUG
27 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmDictSet.h : set the default output to the os variable
29 * src/gdcmDictEntry.[h|cxx] : add the Print method
30 * gdcmPython/demo/ : add a new test
32 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
33 * merging of Test/PrintDicomDir and Test/TestDicomDir
34 * removal of now redundant Test/PrintDicomDir
35 * enhancement of Example/PrintDicomDir
37 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * Now, python test might work on systems
39 * Add the PrintDicomDir test
41 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
42 * FIX : First entry following group 0002 was lost for
43 Explicit Big Endian Transfer Syntax files
44 (group and elem not swaped)
46 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
47 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
48 Big Endian Transfer Syntax supposed the group following 0002
49 begins always by element 0000 (element 0000 is *optional*)
50 To avoid further troubles, let's be pessimistic, and use
51 Document::HandleOutOfGroup0002() method
52 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
53 (related pb not yet solved)
55 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * Bug fix for the python part use
57 * Now, PrintHeader.py pass... but outside the ctest use. shit !
59 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
62 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
63 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
64 a string and should ask the global TS dict what are the propreties of
67 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
68 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
69 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
70 to swap the Swap Code, at parsing time, when we come out of group 0002
71 and Transfer Syntax is Big Endian
72 We should be able to read now 'true DICOM" Big Endian coded images
73 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
74 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
76 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
77 * Hopefully fix the bug on MacOSX and static global initialization.
78 This is the only -minor- patch I found that both please MacOSX and VS6.
79 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
80 but this would require a lot of change. Another approach would be that Global
81 create those string and GDCM_UNFOUND becomes a pointer to a string (which
82 gdcm::Global would destroy at exit).
84 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
85 * Fix bug on MacOSX with static initialization in a multy threaded
86 environment. static const string in a header file used to be ill
87 initialized provoquing the freeze of any tests. patch should solve this
90 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
91 * According to Benoit's suggestion, and without any objection from anybody
92 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
93 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
94 - method gdcmDicomDirObject::GetEntry() renamed as
95 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
97 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
98 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
99 you debug/warning message just as c++ streams which make them very convinient
100 to use. Once this is stabilize I will change the ostringstrem to be
101 redirected to a file (ofstream).
102 * Properly support C99 extension: __FUNCTION__ which allow us to display
103 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
105 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
106 * Removal of useless and dangerous methods :
107 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
108 GetDocEntryByName, GetEntryByName, GetDictEntryByName
109 * Removal of usless methods :
110 Dict::PrintByName, Dict::GetDictEntryByName
111 * Commenting out of probabely useless methods :
112 Dict::GetDictEntryNames()
113 Dict::GetDictEntryNamesByCategory()
114 DictSet::GetPubDictEntryNames()
115 DictSet::GetPubDictEntryNamesByCategory()
116 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
117 * ENH : Use dicomTS.dic as described in 2004 version
118 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
119 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
120 Add Accessors on VM (Value Multiplicity), and VM related methods
121 * ADD : Add a list of 'Dicom Attribute types', as found in
122 http://medical.nema.org/dicom/2004/04_15PU.PDF
124 * ADD : Add dicomGroupNameAbbreviations.dic
125 should be used to write a method to replace the former
126 Dict::GetDictEntryNamesByCategory()
128 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
130 to read in the file... and only it ! Length is the efective length of the
131 data in the DocEntry structure
133 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
134 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
135 And now use a static function call instead, with a global variable. i
136 This is much closer to the VTK approach. Hopefully should be bulletproof
137 and easier to use...hopefully
139 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
140 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
142 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
143 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
145 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
147 ValEntry, BinEntry, SeqEntry creation or replace
149 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
151 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
153 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
154 when specifying the VR
155 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
156 * src/gdcmDocEntry.cxx : amelioration of print
158 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
159 * ADD : Add the method Util::IsCurrentProcessorBigEndian
160 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
161 * ADD Method Document::ComputeGroupLength
162 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
163 in order to allow further VR modification by user
164 * REM : removal of once-called method File::WriteBase
165 integration of its code in formerly one-line method File::Write
167 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
168 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
169 replace the different values "??", "Unkn", "Unknown".
170 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
171 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
172 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
173 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
175 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
178 * Set the gdcm::Base class to some Printable classes
180 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * src/gdcmFile.[h|cxx] : add the Print method
182 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
183 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
184 * src/gdcmDocument.h : remove the PrintLevel informations
185 * Example/PrintFile.cxx : use the new gdcm::File::Print
187 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
188 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
189 problems when compiling with the python wrapping
191 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
193 writting in ImplicitVR
195 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
196 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
197 JPEG decompression, especially when dicom frames are split into several
198 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
199 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
201 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
202 * src/gdcmHeader.cxx : change the initialisation of default header.
203 Now, this header is readable by gdm, e-film, DicomWorks
205 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
207 Rename Decompressed to Raw
208 * Use the API changes in gdcm::File.
209 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
212 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
214 each added entry in the header. Replace the 'Planes' field by the 'Number
217 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
218 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
219 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
221 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
222 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
223 At this time, this image isn't readable by e-film... waiting JPR help to
226 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
228 DocEntry. Now use methods of the Document !
230 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * Test/ShowDicomSeq.cxx : bug fix
233 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
234 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
235 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
236 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
237 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
239 * Test/TestCopyRescaleDicom.cxx : remove unused variable
240 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
241 containing found sequences
243 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
246 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
247 Some fields in BinEntry must be copied to not seg fault when making the :
248 gdcm::File *copy = new gdcm::File( copyH );
249 and tests are now made on good variables
251 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
252 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
253 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
255 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
256 * Add vtkGdcmWriter example and test
258 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * Test/TestUtil.cxx : reformat the source code
260 * vtk/vtkGdcmReader.cxx : remove and change prints
261 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
263 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
264 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
266 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
268 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
270 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
271 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
272 by an eof to prevent all bad read of the file... and in this case, the
275 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
276 * Example/Volume2Dicom.cxx : comment unused variables
277 * Test/PrintDicomDir.cxx : comment unused variables
278 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
279 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
280 method that is redondant with AddEntry.
281 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
284 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
285 * Bug fix due my last commit (compilation under Windows).
286 * Example/Volume2Dicom : bug fix in the file and reformatting source code
287 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
289 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
291 - Remove printf / sprintf
292 - include iostream AFTER gdcm so we don't get warnings
293 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
295 - Also remove tons of include from header files, hopefully this should
296 speeup the compilation time, since it was becoming a dog slow.
297 - Remove gdcm.h as it include way too many files and slow down compilation
298 (plus it is not up to date)
299 - remove 'using namespace std' this is BAD !
301 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
302 * Remove memory leaks on the DicomDir
303 * Remove some useless data in DicomDirObject
304 * Add usefull methods in SQItem, to be complient withe the ElementSet
306 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
307 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
309 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
310 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
311 future, with convertion)
312 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
313 and ImageDataSize values. Remove the method to get the PixelReadConverter
314 from the output of the class
316 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
317 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
319 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
320 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
321 and vtkErrorMacro use.
322 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
324 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
325 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
327 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
328 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
329 The string leaves only in the fonction. So when we make a .c_str(), we
330 get the pointeur on the first element, element that will be destroyed
331 immediately after thee instruction.
332 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
333 file has been opened : the test must be made on the content of the
334 pointer and not directly on the pointer !
337 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
339 the python part recompiles
341 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
343 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
344 X session is killed (for my computer... it seems to not be identic on
347 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
348 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
349 avoid problems (otherwise, the difference test between the visible image
350 and the reference is incorrect. If the reference is greater than the
351 screen resolution, it's produce errors).
352 Can be used for only one image. Can be used with a visible flag.
353 * vtk/vtkGdcmReader.cxx : remove commented codes.
354 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
355 under windows at compilation
356 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
358 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
360 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
361 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
362 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
363 tests on the image size X, Y, Z
365 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
366 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
367 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
368 between the class name and the file name
370 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
371 * src/ : fix compilation warnings for the Write method (2 different
372 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
373 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
374 variable... create a static method in gdcm::Document to access to
375 this variable content.
377 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
378 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
379 file, to be accessed by other files (like gdcmFile). Remove commented
380 code. Move the change of the header to the gdcmFile, using the
382 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
383 To be sure of that (and simplify calls), the Write of the header now
384 gets a file name and not a file pointer (std::ifstream).
385 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
386 DocEntryArchive. Remove all open of the written file
388 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
389 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
391 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
392 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
393 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
395 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
396 some corresponding methods. Write correctly the file and check before
398 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
399 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
400 is now on RGB data (as before my last commit
401 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
403 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
404 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
405 Add a print information of the type of the entry
406 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
407 It was in the gdcmFile, and all write have been regrouped
408 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
409 Write correctly all dicom files (in decompressed mode only at this time)
410 * Test/ : test on files are now made using Raw data and not color data if
412 * Example/PrintFile.cxx : add more printings
414 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
415 * Amelioration of code, remove some code copy. For the loading of
416 BinEntry (in gdcmDocument), add the test to verify if the file is already
419 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
420 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
421 remove a DocEntry in the header (push an empty DocEntry)
422 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
423 lines. Bug fix in the initialization of the PixelConvert and the
425 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
426 use in TestCopyDicom (now this test can run under windows... but fails)
427 * Test/TestCopyDicom.cxx : amelioration of the test :
428 - test the pixels written
429 - add test points to quickly find where is the error
430 - can set a file name input and output in arguments
431 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
432 amelioration of the test output
434 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
435 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
436 all replaced DocEntry's
437 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
438 Now, each needed DocEntry to modify is duplicated, modified and inserted
439 to the header using DocEntryArchive. Thus, after save, we can restore the
440 header initial state.
442 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
443 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
445 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
446 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
447 correct to copy it. The DictEntry is specified at the DocEntry creation,
448 then, it musn't change in the time.
449 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
450 header correctly. At this time, the change is only made for the first
451 level of the Document. In the future, it might consider sequences.
452 The change is made by replacing a DocEntry by an other that is created
453 outside the class. The old value is kept. When we restore the header
454 status, the added DocEntry is deleted and replaced by the old value.
455 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
456 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
457 set the write type to explicit VR, implicit VR or ACR. Add methods to set
458 the write mode to native, decompressed or RGB (but not used at this time)
460 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
461 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
462 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
464 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
465 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
466 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
468 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
469 set because already copied when copying the BinEntry's of the header
470 * Test/TestAllReadCompareDicom.cxx : remove warnings
472 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
473 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
474 Two problems appear when doing it :
475 - with the gdcmFile : when the GetImageData method is called, the pixels
476 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
477 data (pixels). And each structure destruct the data when it's
478 destructed. So we have two destructions for the same data. To solve it,
479 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
480 data or not. If it doesn't own data, then they will not destroyed by
482 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
483 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
484 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
485 create a double destruction of the same DocEntry's. So, to solve it,
486 the TagHT is simply cleared and the DicomDir* elements are destroyed.
487 * TODO : add an entry concerning memory leaks in the DicomDir
489 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
490 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
491 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
494 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
495 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
496 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
497 after it have been deleted
499 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
500 * FIX: src/* fix the doxygen warnings.
501 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
502 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
503 was erroneously defined with a size of 15 instead of 16. [many thanks
504 to Jean Michel Rouet for pointing out this bug].
506 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
507 1. Finish merging JMR patch for writting DICOM from scratch
508 2. Fix -hopefully- bug with MONOCHROME and space vs null character
509 3. Use const ref when possible
510 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
511 5. A few more comments
512 6. CreateUniqueUID can now be called without parameter"
514 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
515 * ENH: Slightly bigger patch:
516 1. Getting toward full integration of JMR patch for writting dicom from scratch
517 2. Update Test to test part of this patch: CreateUniqueUID
518 3. File was not close properly in gdcmDict
519 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
520 5. Use of const ref instead of copy (speed issue)
521 6. Remove temporary (duplicate) string in TranslateToKey
522 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
523 8. Do not repeat virtual in subclasses
524 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
526 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
527 * Apply first patch toward better string comparison when dealing with broken
528 DICOM files. Essentially the string could be padded with a space instead
529 of a null character as defined by standard
531 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
532 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
533 because never used... and in the same time, that's remove some memory leaks
535 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
536 * src/gdcmFile.cxx : now delete the PixelConvert instance.
537 * In examples and tests : change the type of image data variables from void*
538 to uint8_t*. Remmove all delete on image data variables
540 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
541 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
542 Verify the file pointer value before open the file, and if it's not null,
543 a verbose message is generated.
544 Close correctly the file when the file isn't considered dicom-like. The
545 correctly close is a call to CloseFile.
546 When closing the file pointer, test if its not null to close the file.
547 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
548 file. For an uncompressed image, the copied data correspond in the least
549 case to the image size (calculated) or the image size specified in the
550 header. A verbose is generated if these two size mismatch
552 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
553 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
554 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
555 break under windows (with msvc6 compilation).
557 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
558 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
559 compiling with MSVC6)
561 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * Bugs fix for the Windows build with VC6
563 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
564 needed (only for projects required VTK). If the VTK is included in all
565 projects, there is conflicts with the jpeg lib of vtk when compiling the
566 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
567 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
568 when compiling the gdcm_wrap.cxx file (created by the compilation of the
570 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
571 (like it's already made for the cout use). Otherwise, conflict with the
574 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
575 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
577 - comments on the DicomDir::Method related usage added.
578 - now that we use the namespace gdcm, a lot of internal classes do
579 NOT need to be wrapped anymore.
580 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
581 DicomDir::Method) new example added.
583 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
584 * Improve string manipulation. I now inforce the notion of 'DicomString'
585 A DicomString can contain as many \0 as they want
586 and it is *always* of even length.
587 We only support odd length for very rare case.
588 And in the near future this should be removed.
590 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
591 * /binary_write/ gdcm source. Now even on big endian we are writting
592 little endian. This should -heopfully- fix some tests
594 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
595 * Now the dictionary is compiled into gdcm lib. This is a default
596 behavior, thus any dic file specified is picked before failback to
597 the one comiled into lib
599 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
600 * Change internals for gdcmDict. Don't use any 'new' any more.
601 This should definitely solve any leak problem, and we should be
602 as fast as before, as long as don't modify too much the dictionary.
604 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
605 * STYLE: ivars should start with a capital letter.
606 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
607 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
609 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
610 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
611 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
612 new 2004 dictionaries added (thanks to JPR).
613 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
614 * CLEANUP_ROUND (15) for gdcmPixelConvert
615 - RLEFrame::NumberFragments is now of type unsigned int
616 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
617 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
620 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
621 * Initial work in gathering all transfer syntax accessors. clearly
622 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
623 ivars, but only one transfersyntax (class) ivar with equivalent method on
626 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
627 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
628 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
629 discussed (plus I didn't like having a 2000 lines patch not commited)
631 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
632 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
633 * CLEANUP_ROUND (14) for gdcmPixelConvert
634 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
635 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
636 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
638 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
639 anymore and hence avoids storing a copy of PixelConvert::Decompressed
640 into File::Pixel_Data.
642 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
643 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
644 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
645 * CLEANUP_ROUND (13) for gdcmPixelConvert
646 Substituted File::ParsePixelData() with PixelConvert::Print() new
648 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
649 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
650 method to those classes.
651 - src/gdcmFile.[cxx|h]:
652 -- Added a ::Print() method.
653 -- PixelConverter is now a reference instead of a member.
654 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
655 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
657 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
658 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
659 collaboration diagram and inheritance diagram should be generated with
661 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
662 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
663 pointlessly wrapped (see
664 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
665 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
666 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
667 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
668 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
669 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
670 -- File::Initialise: PixelConverter setup moved away to
671 PixelConverter::GrabInformationsFromHeader()
672 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
673 interpretation moved away to PixelConverter::BuildRGBImage()
675 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
676 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
677 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
679 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
680 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
681 displayed on Win32 when a brutal abort() occurs (because of uncatched
682 exception). See TODO new entry of this commit for more on this.
683 * TODO added new entry.
684 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
685 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
686 - HandleColor is no longer called from gdcmFile.cxx
687 - gdcmPixelConvert.cxx clean up on method arguments and internal
688 variable names for semantical coherence.
690 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
691 * Finished lossless transition, not only do we now read all lossless jpeg
692 images, without the need of the Cornwell lib, but we do read them properly now
693 * To reduce code (well to avoid code duplication), I defined a common place
694 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
695 redefine symbols. This is not perfect but this the best solution I found for a
696 compilation time jpeg option.
698 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
699 * Update jpeg ijg lib to support lossless jpeg implementation
700 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
702 * Also added a special copyright for dcmtk since we use their bugfixes.
705 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
706 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
707 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
708 matters, as stated in warning note at begining of %include section).
709 * src/gdcmDicomDir*.[cxx|h]: coding style
710 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
711 * src/gdcmJpeg8.cxx: doxygen fix.
712 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
713 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
714 from File:: to PixelConvert::.
716 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
717 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
718 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
719 - more code moved away from File:: to PixelConvert::
720 - fat setup of PixelConverter set in place in File::Initialise.
722 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
723 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
724 namespace at the file system level. So now you should convert your examples
726 gdcmHeader -> gdcm::Header
727 It would be nice if people keep in mind to no open the namespace, since it
728 allows compilation on broken plateform which were defining common symbol in
729 the standart namespace (like LP, Unknown ...)
731 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
732 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
733 The JPEG fragments are now parsed at the same stage than the RLE
734 information. All code related to JPEG is now in gdcmPixelConvert:
735 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
736 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
737 export a gdcmFile:: method. Those are simply global functions
738 (for the time being this is better than having them attach to
739 either gdcmFile:: or gdcmPixelConvert::).
740 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
741 and stores the result in a gdcmJPEGFragmentsInfo.
742 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
743 code (among other stuff) moved away from gdcmFile:; to
746 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
747 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
748 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
749 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
750 clean up of RLE related code.
751 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
752 - src/gdcmRLE.cxx removed
753 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
754 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
755 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
756 * CLEANUP_ROUND (9) for gdcmPixelConvert
757 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
758 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
759 away from gdcmFile:: to gdcmPixelConvert::.
761 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
763 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
764 This is because Parse7Fe0 used to parse the pixels to compute the
765 length. This task was passed over to FindDocEntryLengthOB() a long
766 time ago, EXCEPT I had forgotten the OW case...
767 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
768 we just recylce the code for parsing RLE fragments and computing
770 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
771 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
772 with the retired Parse7Fe0().
773 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
774 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
776 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
777 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
778 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
779 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
780 - src/CMakeLists.txt: alphabetic order reodering + new entries.
781 * CLEANUP_ROUND (4) for gdcmPixelConvert
782 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
783 to return an unused length.
785 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
786 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
787 this should be cleanner from the plane view. The iostream are erally a pain
788 to use to do simple stuff.
790 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
791 * Redo the compilation of the ijg jpeg library. Now only one source is
792 necesseray. No need to rename file by hand what so ever. CMake handle the
793 copying of the file within different directory, configure header file to
794 modify some symbol. The only addition made to ijg wasd a mangle table so
795 that symbol are different wether we are within 8bits or 12bits.
797 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
798 * Added documentation of vtkgdcmReader on Website:
799 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
800 with it's binary name).
801 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
802 the Website to be more complete.
803 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
804 doxygenated documentation.
805 - Doc/DoxyVtkGdcmReaderExamples.txt added
806 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
807 DoxyVtkGdmReaderExamples.html )
808 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
809 * CLEANUP_ROUND (3) for gdcmPixelConvert
810 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
812 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
813 * CLEANUP_ROUND (2) for gdcmPixelConvert
814 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
816 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
817 * CLEANUP_ROUND for gdcmPixelConvert:
818 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
819 - src/gdcmPixelStuff[h|cxx] removed
820 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
821 - src/CMakeLists.txt changed accordingly
823 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
824 gdcmVersion.py moved to newly created ATTIC related
825 gdcmPython/SetupOldies/ directory.
826 * Autotools clean up:
827 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
828 - autogen.sh configure.in acinclude.m4 python.m4 removed
830 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
831 * src/*.cxx *.h Reference to License.htm fixed to License.html.
832 * Doc/CMakeLists.txt, doxygen.config.in: fix.
833 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
835 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
836 * TODO updated with Mathieu suggestions. I proposed a template for
837 describing TODO entries and used it for new entries.
838 * Added Doc/Website/CodingStyle.html, Developpers.html,
839 DeveloppersPython.html, GdcmDataCvs.html and
840 DownloadVersion0_1.html, DownloadVersion0_3.html.
841 * Some Doc/*.txt Doxygen files (which do not really concern the
842 documentation itself, but the website) moved to html and
843 placed in directory Doc/Website:
844 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
845 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
846 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
847 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
848 * CMakeLists.txt changed accordingly.
849 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
850 DeveloppersPython.html
851 * INSTALL nows refers to Doc/Website/Installation.html
853 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
854 * Added Doc/Website directory, that contains a first raw version
857 2004-09-23 Jean-Pierre Roux
858 * FIX In order not to be poluted any longer by casting problems,
859 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
860 we can now delete[] it safely
861 * VoidArea is now called BinArea (less confusing name),
862 and all the methods called ...VoidArea... are now ... BinArea...
863 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
865 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
866 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
867 clear) TagHT, which is an inherited member of gdcmElementSet. It is
868 up to the destructor of gdcmElementSet to clean up TagHt and it's
871 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
872 * Test/CMakeLists.txt: update to follow gdcmData renamings.
873 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
875 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
876 * ENH: added some utility method that builds a flat dictionnary
877 holding all the Dicom entries contained in the recursive structure
878 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
880 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
881 BuildFlatHashTable() that build a flat dictionary.
882 - src/gdcmElementSet.h: added a new private GetTag() accessor.
883 gdcmDocument is now a friend of gdcmElementSet.
884 - src/gdcmElementSet.cxx: clean up.
885 - Example/FlatHashTablePrint.cxx added.
886 - Example/CmakeLists.txt changed accordingly
888 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
889 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
890 moved away from gdcmDocEntrySet (since this class is an abstract class
891 acting like an interface). SQDepthLevel and BaseTagKey are now
893 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
894 and associated accessors. Doxygenation of the class.
895 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
897 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
898 Use SQDepthLevel accessor instead. ::Print() adapted.
899 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
900 - src/gdcmDocument.cxx changed accordingly.
902 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
903 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
904 - The following is the doxygen comment of the typedef declaration
905 of gdcmTagKey in src/gdcmCommon.h:
906 gdcmTagKey is made to old an "universal" (as in URL, Universal
907 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
908 A dicom tag always has a group and an element, but a set of tags
909 embeded in various (optionally nested) sequences and sharing
910 the same group and element all share the same (group, element)
911 "identifier". Hence the (group, element) cannot be used as an
912 identifier (in gdcm we shall refer to a "TagKey") of a tag.
913 In order to construct a proper tag identifier (i.e. a key) we
914 consider the following definition of a TagKey:
915 - let Group, Element be the string representation of the
916 group and element dicom tag members,
917 - let ItemNumber be the string representation of the integer
918 index of the considered item number of a sequence,
919 Let the key of a tag embeded in a sequence, noted SeqTag, be
921 /ItemNumber#Group|Element
922 where "/", "#" and "|" are characters acting as separators.
923 Then the general form of a gdcmTagKey is given by:
924 Group|Element<SeqTag>
925 where <SeqTag> means NO or many instances of SeqTag.
926 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
929 but the gdcmTagKey of a tag "embeded" is the first item of
930 a sequence, itself nested in the third item of a sequence is the
932 0004|1220/2#0008|0082/0#0008|0090
933 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
934 order to hold the new sequence compatible key. Previously, the
935 GetKey() method would look in the underlying gdcmDictEntry.
936 - src/gdcmDocEntry.cxx:
937 -- constructor now copies the underlying DictEntry key, in the local
939 -- ::Print: displays the member Key, instead of the (group, element).
940 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
941 - src/gdcmDocEntrySet.h:xi
942 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
943 -- now has a new BaseTagKey member.
945 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
946 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
948 This poses the problem with the semantics of the following lines
949 LoadEntryVoidArea(0x0028,0x1201); // R LUT
950 LoadEntryVoidArea(0x0028,0x1202); // G LUT
951 LoadEntryVoidArea(0x0028,0x1203); // B LUT
952 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
953 to the long FIXME note for what the problem is. Nevertheless in
954 order to get things working the dicom dictionary was altered !
955 Please fix things urgently...
956 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
957 information), see above note on moving the member VoidArea. Nevertheless
958 the following entries previously correctly set as US are now inproperly
960 0028 1201 OW IMG Red Palette Color Lookup Table Data
961 0028 1202 OW IMG Green Palette Color Lookup Table Data
962 0028 1203 OW IMG Blue Palette Color Lookup Table Data
963 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
964 of gdcmDocEntry moved to gdcmSeqEntry.
965 * src/gdcmSeqEntry.cxx: STYLE.
967 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
968 * Test/TestAllEntryVerify.cxx minor fix and added comments.
970 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
971 * gdcmPython/testSuite.py: all the test suite in python is now moved
972 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
973 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
974 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
976 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
977 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
978 to avoid inclusion recursion until STL is reached.
979 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
980 mecanism. errno.h is not included in gdcm anymore.
981 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
982 (gdcmFormatError now inherits from gdcmFormatUnexpected).
984 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
985 gdcmData/TestAllEntryVerifyReference.txt
986 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
987 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
988 exception_on_error parameter.
989 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
990 - vtk/vtkGdcmReader.cxx changed accordingly,
991 - Example/*.cxx and Test/*.cxx changed accordingly.
993 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
994 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
995 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
996 enable_sequences removed from gdcmHeader constructor and dependencies.
997 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
998 * gdcmPython/demo/PrintHeader.py: dummy fix.
999 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1000 skip_shadow removed from gdcmHeader constructor and dependencies.
1001 * Example/*.cxx and Test/*.cxx changed accordingly.
1003 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1004 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1005 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1007 2004-07-21 Jean-Pierre Roux
1008 * FIX Now, Parsing and Printing a DICOMDIR do work!
1009 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1011 2004-07-20 Jean-Pierre Roux
1012 * FIX Some brain damaged headers have Zero-Lenght fields
1013 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1015 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1016 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1017 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1018 variable (instance of gdcmDebug) by a definition macro, and the instance
1019 is now in static in the gdcmDebug class
1020 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1021 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1023 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1024 * WARNING: ctest now depends more tightly on gdcmData. You should
1025 check out gdcmData properly for things to run smoothly...
1026 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1027 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1028 we need the pixels not be loaded in order to use the ValEntry
1029 that displays position and size).
1030 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1031 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1032 be deprecated. If you have any doubts about the advantages of a
1033 modern scripting language (read Python) versus grass root C++ (i.e.
1034 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1035 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1036 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1037 Anyhow, consider documenting the gdcmData images in
1038 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1040 * Test/CMakeLists.txt:
1041 - now uses TestAllEntryVerify.cxx
1042 - specific comments on oldACR00001.ima (now renamed in gdcmData
1043 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1044 gdcmData/TestAllEntryVerifyReference.txt
1047 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1048 * src/*.[h|cxx] : typedef clean up
1049 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1050 - TagKey renamed to gdcmTagKey (for external usage)
1051 - VRKey renamed to gdcmVRKey (for external usage)
1052 - removal of typedef duplication.
1053 - Removed all unecessary inline keyword from class inline definitions.
1054 - Some method|function(void) declarations replaced with method|function().
1055 * src/jpeg/libijg12/jdhuff12.c:
1056 - printf polluting ctest removed.
1057 - TAB removal for comminting
1059 - TestAllReadCompareDicom.cxx: added a test that compares all the
1060 images in gdcmDataImages.h with corresponding images in
1061 gdcmData/BaselineDicom/. When baseline images are not present
1062 this test creates them.
1063 Note: we need to validate each reference image, but before that
1064 I'd like to rename them with a more explicit name...
1065 - CMakeLists.txt: changed accordingly.
1066 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1067 including each header needed).
1069 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1070 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1071 test suite to the Example directory. Are concerned:
1076 - TestWriteSimple.cxx
1077 * Test/CMakeLists.txt: added some comments on reasons for black listing
1078 image gdcmData/oldACR00001.ima
1080 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1081 * Test/CmakeList.txt: removed the following from black list (to be coherent
1082 with removal from gdcmData):
1083 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1084 - gdcm-MR-PHILIPS-16.dcm
1086 Added the following because after last cvs update, they cause
1087 ctest -R TestReadWriteReadCompare
1089 - gdcm-MR-SIEMENS-16-1.acr
1091 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1092 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1093 new comments in this file) we temporarily (sigh) move to a weaker
1095 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1096 we don't need to black list the following images anymore:
1097 - 8BitsUncompressedColor.dcm
1099 - US-PAL-8-10x-echo.dcm
1100 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1101 fixes and the beautified code ;-)
1102 This fixes the bug introduced in version 1.42 (when beautifying)
1103 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1104 Note: ctest was blind to this bug (this means we need to still
1105 improve the test suite). The bug could be detected by using
1106 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1108 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1109 and by displaying the (garbage) produced file temp.XDCM...
1111 2004-06-29 Jean-Pierre Roux
1112 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1113 - replace by uggly but working old code :-(
1114 A lot of things should be OK again.
1115 It's really urgent to have a test suite that *tests*,
1116 to prevent Frog's beautifying sessions to break all the stuff
1117 (twice, withing a fortnigh ...)
1119 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1120 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1121 redundancy) to added Test/TestReadWriteReadCompare.cxx
1122 * Test/CmakeList.txt: because the compare test of
1123 Test/TestReadWriteReadCompare.cxx fails, the following images are
1124 black listed: - 8BitsUncompressedColor.dcm
1126 - US-PAL-8-10x-echo.dcm
1127 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1128 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1129 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1130 and ad-hoc kludge. This kludge is now removed, and on encountering
1131 such an image (OB field brain damaged) we set errno. Then in
1132 ::FindDocLength() we "fix" the length as being ALL what remains
1133 in the file (until EOF). We then proceed, hoping for the best...
1134 This fixes a SegFault in ShowDicom when trying to write such an
1136 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1137 (because TestWriteRead breaks on it, after a non conformal commit?).
1138 ctest now runs properly, except for MakeDicomDir (which was always
1139 broken) and the Python related stuff (still not fixed).
1141 2004-06-24 Jean-Pierre Roux
1142 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1143 FIX : Test/TestReadWrite now iterates on all the file names
1144 (instead of infinite loop)
1145 ENH : Test/TestWriteRead now iterates on all the file names
1147 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1148 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1150 2004-06-24 Jean-Pierre Roux
1151 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1152 when SamplesPerPixel =3
1153 - now Write is no longer confused by
1154 'BitsAllocated = 12" and 'BitsStored=12"
1155 - "UN" value representation Elements are now written correctly
1156 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1157 ENH : - now gdcmHeader has its own Write methods
1158 (in order to split the job that has not to be done
1161 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1162 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1163 loop on the same image until memory went out.
1164 Note: this means we still have gobs of memory loss in PrintDocument
1165 * src/gdcmDocument.cxx: fixes problem on parsing on file
1166 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1168 2004-06-24 Jean-Pierre Roux
1169 FIX : Write - All the Sequences and Sequence Item are now written
1170 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1171 is added a the end, when necessary.
1172 - A lot of brain-damaged images, that were read correctly are
1173 now written correctly
1174 - length compatible BinEntry are now loaded correctly
1175 (even for odd groups)
1176 Note : only Explicit Value Representation was checked.
1177 (question : is implicit VR really necessary for gdcm ?)
1179 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1180 * DEVELOPPER: added a proposition of coding style.
1181 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1184 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1185 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1186 Use the gdcmDocEntry::Print() and Write() instead.
1187 * src/gdcmDocument.cxx: bug fix.
1189 2004-06-22 Jean-Pierre Roux
1190 FIX : gdcmDocument.cxx
1191 - Now we do recognize the JpegLossLess format (there was a misstyping in
1192 code 'beautyfication' :-(
1193 - Now we automaticaticaly load the Luts, if any
1195 2004-06-22 Jean-Pierre Roux
1196 In order : to write Sequences, whatever their imbrication level,
1197 : to allow user to create his own Sequences
1198 a lot of modif where necessary (adding, moving, or virtualising methods)
1200 WARNING : save your own sources *before* cvs up !
1203 ADD virtual void Write(FILE *fp, FileType filetype);
1206 ADD virtual void Write(FILE *fp, FileType filetype);
1207 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1210 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1211 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1212 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1213 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1214 ADD std::string GetEntryByName(TagName name);
1215 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1217 std::string vr = "unkn",
1218 std::string fourth = "unkn",
1219 std::string name = "unkn");
1220 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1221 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1222 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1223 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1224 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1225 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1226 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1227 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1230 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1231 ADD virtual std::string GetEntryByName (TagName tagName);
1232 ADD virtual std::string GetEntryVRByName (TagName tagName);
1233 REM virtual bool Write(FILE *, FileType);
1234 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1235 FILE *_fp, FileType type);
1236 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1237 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1238 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1239 REM virtual std::string GetEntryByName (std::string tagName);
1240 REM virtual std::string GetEntryVRByName (std::string tagName);
1241 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1242 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1243 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1245 std::string vr = "unkn",
1246 std::string fourth = "unkn",
1247 std::string name = "unkn");
1248 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1249 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1250 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1251 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1254 ADD virtual void Write(FILE *fp, FileType filetype);
1257 ADD virtual void Write(FILE *fp,FileType filetype);
1260 ADD virtual void Write(FILE *fp, FileType filetype);
1261 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1262 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1263 REM std::string GetEntryByName(TagName name);
1266 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1268 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1269 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1270 The default constructor invoked by the line
1271 gdcmHeader *f1 = new gdcmHeader( header );
1272 was gdcmHeader::gdcmHeader(bool) instead of the expected
1273 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1274 Hence the parsing wasn't executed... See also below.
1275 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1276 as explicit constructor didn't do the trick to fix the above problem.
1277 Could anyone explain why ?
1278 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1279 properly calls gdcmValEntry::Print() (that was weed out from
1280 code related to gdcmBinEntry).
1282 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1283 * In order to fix memory leaks:
1284 - Test/TestWriteSimple.cxx: added cleaning of free store through
1286 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1287 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1288 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1289 (through the call to ::AddDicomDirMeta()) or the destructor
1290 would crash when deleting uninitialized ::metaElems].
1291 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1292 - src/gdcmDocument.cxx:
1293 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1294 from dynamic stores.
1295 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1296 was causing memory leaks.
1297 - src/gdcmSQItem.cxx:
1298 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1299 cleanly handled with polymophism: sorry but my milage is low).
1300 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1301 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1302 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1303 This avoids SegFaulting.
1304 - src/gdcmSQItem.h: coding style.
1306 - Test/TestWriteSimple still severely sucks. The output image content
1307 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1308 damaged when displayed with vtkgdcmViewer.
1309 - on memory leaks: TestWriteSimple leaks really less (see entry
1310 of 2004-06-18 in Changelog file for the call to valgrind).
1311 - on segfaults: ctest now passes all the tests but one (no more
1313 * Erroneous leading white fix:
1314 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1315 white[s] (as opposed to from >> xxx, that removes it [them].
1316 - src/gdcmTS.cxx: ditto.
1317 - gdcmPython/testSuite.py: dirty related kludge removed.
1318 * src/*: remaining references to gdcmParser removed.
1319 * src/*[cxx|h]: added copy[way]left header.
1322 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1323 * In order to fix writing of dicom files:
1324 - Test/TestWriteSimple.cxx: a simpler example of writing.
1325 - Test/CMakeLists.txt changed accordingly.
1326 - src/gdcmDocument.cxx:
1327 -- The destructor now recursilvely removes potential sequences.
1328 -- Bug fix in ::IsJPEG2000()
1329 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1330 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1332 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1333 to only declared) and build on top of
1334 ::GetDocEntryByNumber(guint16, guint16).
1335 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1336 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1337 for usage in destructor and treatement of promotion in
1338 ::ReplaceOrCreateByNumber().
1339 - src/gdcmSQItem.cxx: destructor should better handle his job.
1340 Test/TestWriteSimple now runs (or at least it DOES something).
1341 * We can now start hutting memory links. A good starting point is:
1342 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1343 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1344 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1346 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1347 * Valgrind note: after Mathieu Malaterre teached me how to read
1348 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1350 Using gcc, you can force the STL to use malloc and to free memory as
1351 soon as possible by globally disabling memory caching.
1352 With 3.2.2 and later, you should export the environment variable
1353 GLIBCPP_FORCE_NEW before running your program.
1354 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1355 simply vanish (it is still not clear to me, whether this means that
1356 STL std::string leaks or if valgrind believes it leaks...).
1357 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1358 running bin/gdcmTests makeDicomDir):
1359 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1360 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1362 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1363 SegFaulting (I drowned in DicomDir related code when trying to
1364 understand why the list is empty...).
1365 * src/gdcmDocument.h: first BSD license header try.
1366 * Doc/License.txt added.
1368 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1369 * src/gdcmDocument.[h|cxx]:
1370 - Clean up of the Transfer related predicates. They are now all based
1371 on new method isGivenTransferSyntax, that (should) handle properly
1372 the padding problem.
1373 - general clean up, simplification, and coding style.
1374 - Specific clean up of Parse7FE0() (umproperly named actually).
1375 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1377 2004-06-14 Jean-Pierre Roux
1379 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1380 - fix the display of SQItem ordinal number
1381 - add the GetSQItemByOrdinalNumber method
1382 - remove some useless never written private methods
1384 2004-06-14 Jean-Pierre Roux
1386 - adding a constructor taking a gdcmDocEntry as an input param
1387 - ReplaceOrCreateByNumber now returns :
1388 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1389 a gdcmValEntry * if a string value is passed as a param
1391 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1392 according to the param type (no longer sets a gdcmDocEntry)
1393 - GetValEntryByNumber, GetBinEntryByNumber added
1394 - NewValEntryByNumber and NewBinEntryByNumber added
1396 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1398 - GetSQItemNumber and SetSQItemNumber added, to provide
1399 a (relative) Item identier inside a given Sequence
1400 \warning : some pb remaining around this number
1402 - AddEntry now takes the Item Number as a param
1404 - adding a constructor taking a gdcmDocEntry as an input param
1406 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1407 * Memory leak hunt with the following command:
1408 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1409 --show-reachable=yes gdcmTests PrintDocument
1410 It looks like many (all?) leaks are due to the STL (or a bad usage
1411 of the STL. The lines producing the leaks now have a comment with
1412 a "MEMORY LEAK" tag: you can retrieve them with
1413 grep "MEMORY LEAK" src/*
1414 Here are two typical examples which I can't help fixing:
1419 char * test = "babo";
1420 name = test; //// <--- valgrind detects 960 bytes lost in
1421 //// call to std::string::operator=(char const*)
1422 name.clear(); //// Doesn't help !
1430 std::cout << "Type a bunch of characters followed by RETURN: ";
1431 getline(std::cin, line); //// <--- valgrind dectects a loss
1432 //// of 1320 bytes in call to
1433 /// std::basic_istream<>& std::getline<>
1439 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1440 * src/gdcmHeader.[cxx|h]:
1441 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1442 and related, moved away to gdcmDocument.
1443 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1444 the corresponding protected accessors of inherited class
1445 gdcmDocument, removed ! As a consequence gdcmFile had to be
1446 declared friend of class gdcmDocument (see below).
1447 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1448 - Clean up of undefined or unused methods.
1449 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1450 account the changes to gdcmHeader.h).
1451 * src/gdcmDocument.h:
1452 - gdcmFile is now a friend class (in order to take into account the
1453 changes to gdcmHeader.h).
1454 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1455 (see changes to gdcmHeader.h).
1456 - Accessors (reading on the form GetEntry*) are now public.
1457 - Clean up of undefined or unused methods.
1458 * src/gdcmDocument.cxx:
1459 - adaptation to changes to gdcmDocument.h
1460 - ::OpenFile now writes a verbose message when file cannot be opened.
1461 - some std::string properly set to VRKey
1462 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1463 references to gdcmDocument.
1464 * Test/TestFindTags.cxx: changed accordingly to above changes.
1465 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1466 cvs repository gdcmData.
1468 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1469 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1470 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1471 conflicts with gdcmValEntry::voidArea.
1472 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1473 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1474 Value representation between StringRepresentable and BinaryRepresentable.
1475 * src/gdcmDocument.cxx:
1476 - method ParseDES: proper indentation restored and usage of
1477 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1478 - method LoadDocEntry: the fingerprint left in the SetValue() of
1479 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1480 removed. Reverting to previous code segment with the proper
1481 dynamic_cast< gdcmValEntry* >.
1482 Note: this was (partially) breaking the python test suite
1483 (gdcmPython/testSuite.py) that made usage of the above
1484 fingerprint to check presence of "Pixel Data".
1485 * src/gdcmDocEntry.h: coding style.
1486 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1487 now taken into account.
1488 * gdcmPython/gdcm.i: adaptation to the new internal representation
1489 of gdcm (exit gdcmParser, hello gdcmDocument).
1490 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1492 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1493 anymore, but instead prints the loaded Python dictionary.
1494 * .... alas, the python testSuite is still broken.
1496 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1497 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1499 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1500 * src/gdcmUtil.h : export methods
1502 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1503 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1505 * Initial addition of automatic python testing
1506 * Initial addition of automatic image comparison
1508 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1509 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1510 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1512 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1513 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1514 * Test/ShowDicom.cxx : bug fix for msvc compilation
1515 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1517 2004-05-04 Jean-Pierre Roux
1518 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1519 new concepts (and new classes) :
1520 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1521 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1522 - Sequence Doc Entries (gdcmSeqEntries)
1523 a Sequence is composed of Items.
1524 Each item is a set of Doc Entries (this is recursive)
1525 The non uniqueness of the 'Dicom tag' is due to this recursivity
1526 (never taken into account)
1527 Our unability to add a new 'entry' in the header
1528 at the proper location (neither in the H-Table (map or multimap),
1529 nor in the Chained List is also due to this recursivity.
1530 Don't try, right now, to use/modify/compile these new sources :
1531 nothing is finished.
1532 We just commit all the stuff, 'as is', in order not to loose it.
1534 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1535 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1537 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1538 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1539 file prefix (SetFilePrefix)
1541 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1542 * Add a new test: ShowDicom, for now this is just the c++ version of
1543 checkRead.sh, later it will be able to compare the image read against a
1545 * Replace the DEBUG on the stack with a global entry in cmake interface:
1546 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1548 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1549 * Add an example subdir, with a real example on how to read + write a
1552 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1553 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1554 * Doc/CMakeLists.txt: the main page is now properly differentiated
1555 between the developper and user version.
1556 * Doc/doxygen.config.in: dropped search related obsolete flags
1557 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1559 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1560 * DEVELOPPER: added some helpfull comments for compile/test/install
1563 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1564 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1565 src directory, now generated in the build dir.
1566 2. Tests as mentionned smarter
1568 4. Add a new method in gdcmDict that return the PubDict by name
1569 this is interesting for 3rd party lib like ITK,
1570 where we could set the institution name / patient name...
1572 * ENH: 1. Now the test suite is working for real
1573 2. All binaries are now output in the gdcm-bin directory
1574 (this was not true before)
1576 2004-04-28 Jean-Pierre Roux
1577 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1578 SeQuence indented printing of Dicom Header.
1579 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1580 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1581 Computation of SQDepthLevel is now part of gdcmHeader constructor
1582 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1583 tree-like structure of a Dicom Header.
1584 * FIX Test code cleaning
1586 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1587 * ENH: Adding automatic testing
1588 1. Need a DartConfig.cmake to submit to public
1589 2. Add a test driver gdcmTest.cxx
1590 3. gdcmTestMain, an helper for the main test driver gdcmTest
1591 4. Files in Test don't have a main anymore, this becomes interesting
1592 when we add more and more tests, thus dsw don't have to load
1594 * ENH: Adding a GDCM_DATA_ROOT for testing
1595 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1596 one file instead of seven + some small cleanup
1598 2004-04-22 Jean-Pierre Roux
1599 * ENH Minor changes to the Print() methods.
1600 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1601 Header printing. Example given with :
1602 > PrintHeader fileName 2 new
1603 (SQ based tree-like structure still to be done for the Header ...)
1605 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1606 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1607 1. I have added some unsigned where needed
1608 2. Some function parameter not used -> (void)
1609 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1610 4. g++ don't like character '\' in comment
1611 5. #define jpeg_create_decompress jCreaDecompress
1612 this really need to be fixed
1613 6. virtualize destructor of gdcmObject ... leakage
1614 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1615 this also really need to be fixed
1616 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1617 remove compression file
1618 (as we only do decompression, right ?)
1619 * ENH: Change malloc/calloc/free with c++ equivalent
1621 2004-04-21 Jean-Pierre Roux
1622 * FIX gdcmHeaderHelper::GetXSpacing
1623 when a single value is found (bug ?), xpacing is now
1624 defaulted to yspacing
1626 2004-04-19 Jean-Pierre Roux
1627 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1628 * ENH add parameters :
1629 bool exception_on_error = false,
1630 bool enable_sequences = false,
1631 bool ignore_shadow = false
1632 to the gdcmFile constructors to be full gdcmParser compliant
1633 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1634 to allow reading of PAPYRUS 3.0 files
1636 2004-04-06 Jean-Pierre Roux
1637 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1639 2004-04-02 Jean-Pierre Roux
1640 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1641 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1642 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1644 2004-03-30 Jean-Pierre Roux
1645 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1646 for ACR file, written out as DICOM files (hope so...)
1648 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1649 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1650 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1651 moved to base class gdcmParser and only the specialisation is kept
1653 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1654 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1655 already does the job.
1656 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1657 (to be consistent with gdcmParser::WriteEntries).
1659 2004-03-30 Benoit Regrain
1660 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1661 upate of the object's instance. It's passed to 2 in the unfavorable
1662 case : one in the ExecuteInformation, one in the ExecuteData
1664 2004-03-29 Jean-Pierre Roux
1665 * ENH : Check on file type to be written moved
1666 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1667 * FIX : gdcmObject::ResetBoundaries now stops properly
1668 when end-of-list is reached
1669 : gdcmVersion modified (as Benoit Regrain asked)
1671 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1672 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1673 * src/gdcmUtil.cxx: added forgotten iostream include.
1674 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1675 equivalent to ExplicitVR in existing code).
1677 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1678 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1679 now contains all the gdcmGlobal related code.
1680 * minor coding style and doxygenation changes.
1682 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1683 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1684 now contains all the Debug related code.
1685 * minor clean-up of includes in src/*.cxx
1686 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1687 CreateCleanString) removed.
1688 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1689 * Doc/DoxyMainPageUser.txt added.
1690 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1691 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1692 src/gdcmDirList.cxx)
1694 2004-03-24 Jean-Pierre Roux
1695 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1697 2004-03-23 Jean-Pierre Roux
1698 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1699 big endian made volumes
1700 * ENH Now gdcmParser constructor and destructor are protected to forbid
1701 end user to instanciate class gdcmParser
1702 (only gdcmHeader and gdcmDicomDir are meaningfull)
1704 2004-03-22 Benoit Regrain
1705 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1706 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1707 gdcmSerie to gdcmDicomDirSerie
1709 2004-03-19 Jean-Pierre Roux
1710 * ENH Now the tree-like structure describing a DICOMDIR comming from
1711 an already existing DICOMDIR file is consistent with
1712 the home-made tree-like structure build ex-nihilo
1713 or build from the files held (recursively) in a Directory
1714 functions gdcmDicomDir::CheckBoundaries()
1715 gdcmObject::SetBoundaries() added
1717 2004-03-17 Jean-Pierre Roux
1718 * REM (Eric Boix bug) : removal of meaningless
1719 gdcmDicomDirImage::NewImage function.
1720 * FIX now file names and directory name are written properly in the
1722 * FIX now gdcmDicomDir constructor may be call without any trick
1725 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1726 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1727 of gdcmDicomDirImage::NewImage as empty function.
1729 2004-02-28 Jean-Pierre Roux
1730 * ENH add gdcmDicomDir:NewPatient
1731 add gdcmDicomDirPatient:NewStudy
1732 add gdcmDicomDirStudy:NewSerie
1733 add gdcmDicomDirSerie:NewImage
1734 to allow making gdcDicomDir object.
1735 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1736 (as opposite to the gdcmHeader chained list)
1738 2004-02-11 Benoit Regrain
1739 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1740 when using from python
1742 2004-02-10 Benoit Regrain
1743 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1744 * FIX : in gdcmDicomDir when the directory is empty
1745 * ENH : add callback and methods to get the progression of dicomDir
1748 2004-02-06 Jean-Pierre Roux
1749 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1750 - GDCM_META added to gdcmDicomDirType
1751 - class gdcmMeta created
1752 * ENH : - A brief summary is now displayed at the beginning of
1753 'testDicomDir' to help disaster magnitude estimation
1754 * REM : Now useless Test/explDICOMDIR.cxx
1756 2004-02-05 Benoit Regrain
1757 * ENH : add methods in gdcmObject to get the hash table or the list of
1759 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1760 * FIX : wrapping python for TagHeaderEntryHT
1762 2004-02-04 Benoit Regrain
1763 * FIX : even length for some strings when writting the dicom dir
1764 * FIX : sort the images in the dicom dir
1765 * FIX : Bug fix for python use of dicom dir
1766 * ADD : a python demo
1768 2004-02-04 Jean-Pierre Roux
1769 * FIX : Final solution (?) for icone embedded images
1770 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1771 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1772 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1773 gdcmData/gdcm-MR-SIEMENS-16.acr1
1774 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1775 to make full checking easier
1777 2004-02-04 Benoit Regrain
1778 * FIX : WriteEntries : coding style & logic in parameters
1779 * FIX : Set the elements to create the DicomDir in a dictionary file
1781 2004-02-03 Benoit Regrain
1782 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1783 * gdcmDicomDir : add the load of directory
1784 * Bug fix and print add-on
1786 2004-02-03 Jean-Pierre Roux
1787 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1788 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1789 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1790 * FIX gdcmParser.cxx : 'group length' elements are now considered
1791 as integers, even for shadow groups, when file is Implicit VR
1793 2004-02-02 Jean-Pierre Roux
1794 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1796 of the last synonym :-(
1797 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1799 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1800 * FIX taking into account the possible 7fe0,0010 multiplicity
1801 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1802 to allow removal of references to 7fe0,0010, to deal with
1803 ACR-NEMA images, when 0028,0200 is meaningfull
1805 2004-01-31 Jean-Pierre Roux
1806 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1807 no longer writes 'Un' on disk
1808 * FIX SQ elements with actual length are now dealt with corectly
1809 * FIX gdcmFile::WriteBase make the difference, for color images, between
1810 the length (for Palette expanded images)
1811 and Raw Length (non expanded image + Palette)
1812 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1813 (that broke Write). Replaced by UL.
1814 Aware user will reload the field if he
1815 thinks it's necesssary
1817 2004-01-30 Jean-Pierre Roux
1818 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1819 when 'dirty Acr' is found, to be compliant with the new
1820 IsReadable() methods.
1822 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1823 (no DOUBLE images in kosher DICOM,
1824 but so usefull for people that miss them ;-)
1826 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1827 DICOMDIR related utilities (not checked as Windoze compliant)
1829 2004-01-28 Jean-Pierre Roux
1830 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1832 2004-01-27 Jean-Pierre Roux
1833 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1834 to allow skipping the shadow elements, to save memory space.
1835 The TRUE value for this param has to be used
1836 with a FALSE value for the 'enable_sequence' param.
1837 ('public elements' may be embedded in 'shadow Sequences')
1838 * gdcmHeader methods now deal with 'embedded icones images' in the header
1839 (even when an 'icone image sequence' is announced by the
1840 element (0x0088,0x0200), but there is NO icone at all ...
1842 * gdcmHeader sometimes Image Location value doesn't follow
1843 the supposed processor endianity (see gdcmData/cr172241.dcm).
1846 * gdcmHeader add the method
1847 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1848 to get *all* the Header Entries with the same tag.
1849 GetHeaderEntrySameName is probabely *useless*
1850 (no meaning : Name is *not* an identifier within the Dictionnary)
1852 2004-01-26 Benoit Regrain
1853 * Bug fix in the print of hexadecimal representations. Remove long fields
1854 in the print and add a third level of print to print them
1856 2004-01-23 Benoit Regrain
1857 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1858 * Bug fix on test suite after remove the strip made on not string fields
1859 * Split the IsReadable method between gdcmParser which test that the file
1860 is dicom and gdcmHeader which test that it's an image file
1862 2004-01-22 Benoit Regrain
1863 * DicomDir : clean code, add methods, set variables in protected or private
1864 * gdcmUtil : bug fix for the clean string method
1866 2004-01-19 Benoit Regrain
1867 * Add the use of shadow dictionaries
1868 * bug fix and coding style
1870 2004-01-19 Benoit Regrain
1871 * src/gdcmFile.cxx : bug fix concerning the close of file
1872 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1873 * Add the update of header entries using the shadow library
1875 2004-01-19 Benoit Regrain
1876 * removal of file gdcmHeader2.cxx
1877 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1878 inheriting from gdcmParser. This split is to prepare the integration
1879 of dicom dir parsing
1880 * bug fix under python
1882 2004-01-16 Jean-Pierre Roux
1883 * REM removal of class gdcmHeaderEntrySet
1884 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1885 * ADD add file gdcmHeader2.cxx
1886 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1888 2004-01-15 Benoit Regrain
1889 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1890 entries created while parsing the header. Thus, they will be destroyed
1891 when the gdcmDictSet will be destroyed
1892 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1895 2004-01-15 Benoit Regrain
1896 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1897 made a fatal error because of the memory release at the end of program.
1898 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1899 some memory and vtk seems to have some problems with that.
1900 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1902 2004-01-14 Benoit Regrain
1903 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1904 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1905 * src/*.[h|cxx] : make changes due to class name changes
1906 * gdcmPython/demo/*.py : bug fix due to method names
1908 2004-01-13 Benoit Regrain
1909 * src/*.[h|cxx] : coding style
1910 * vtk/*.[h|cxx] : coding style
1912 2004-01-13 Benoit Regrain
1913 * gdcmPython/testSuite.py : test the readable flag of file for tests
1914 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1915 It's lied to the stl compilation by MSVC (windows, always windows...)
1916 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1918 2004-01-12 Benoit Regrain
1919 * src/*.h : add comments
1920 * src/gdcmDictSet.h : set the method BuildDictPath in public
1921 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1922 directly setted in the source code
1923 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1926 2004-01-09 Benoit Regrain
1927 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1928 * setup.py : use a reference to gdcmVERSION
1930 2004-01-07 Benoit Regrain
1931 * Modification to compile with the distutils.
1934 2003-12-10 Benoit Regrain
1935 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1936 can use a gdcmHeaderHelper to load data
1937 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1938 made in the source code
1940 2003-12-10 Benoit Regrain
1941 * Update Windows projects and .cvsignore files
1943 2003-11-12 Jean-Pierre Roux
1944 * ENH gdcmHeader constructor has one more parameter (default value : false)
1945 that allows the user to 'go inside' the SeQuences only
1947 gdcmElValSet:Print takes it into account
1949 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1950 * ENH: Update gdcmPython/CMakeLists
1951 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1952 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1954 2003-11-10 Jean-Pierre Roux
1955 * FIX : gdcmHeader::LoadElements is now based
1956 on the ListTag listElem member,
1957 not longer on the TagElValueHT tagHt member
1958 * ENH : PrintPubElVal shows (temporarily) both results,
1959 with the tagHt member and the listElem member.
1960 (it's easier to 'see' the problems when using Printheader)
1962 * FIX : old private member LgrElem is now splitted into
1963 ReadLength : Length actually found on disk (updated only
1964 if bug fixing is necessary), for internal
1966 UsableLength : Updated by FixFoundLength, to fix a bug
1967 or to allow Parser going on.
1968 Will allow to re-write a kosher header when a SeQuence
1969 with a length (not 0000) is found
1970 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1971 because gdcmElValSet::Add does not update ListElem
1974 2003-11-07 Jean-Pierre Roux
1975 * FIX misstyping in Transfert Syntax name table
1976 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1977 when they have an actual length (not 0000 nor FFFFF)
1978 (Nobody should care of it, but DICOMDIR explorers)
1980 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1981 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1983 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1984 * ENH: vtkGdcmReader now supports LUT !
1985 (vtkgdcmViewer for now is not able to use them though)
1987 2003-11-05 Jean-Pierre Roux
1988 * in testSuite.py : new files names for checking the package
1989 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1990 that returns the pixel area size to the *aware* (vtk) user
1991 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1993 2003-11-05 Benoit Regrain
1994 * in testSuite.py : Modify the rules for checking the paths
1995 : Explicit error messages
1996 * in __init__.py : Related modif
1998 2003-11-03 Jean-Pierre Roux
1999 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2000 to be used by aware (vtk) users that want to manage
2001 LUT (and no to turn the PALETTE image into an RGB pixels one)
2002 * GetPixelType now returns 8U for 24 Bits images
2003 (vtkGdcmReader compliant)
2005 2003-10-31 Jean-Pierre Roux
2006 * Removal of *all* gdcmData images and add them again
2007 in order to loose the 'history' of un-anonymised images
2009 2003-10-31 Jean-Pierre Roux
2010 * RMV : removal of useless jBitsInJsample.h
2011 for both 8 and 12 Bits JPEG Lossy Libraries
2013 2003-10-31 Jean-Pierre Roux
2014 * ENH : Add the functions gdcmFile::GetImageDataRaw
2015 gdcmFile::GetImageDataIntoVectorRaw
2016 that act as GetImageData and GetImageDataIntoVector
2017 except the making of an RGB Plane from Gray Plane + LUT
2018 Intended to aware (vtk) users who know how to manage
2021 GetLUTRGBA return a R,G,B,A LUT if any
2022 lgrTotaleRaw gives the 'Raw' length
2023 GetImageDataRaw returns the gray Plane
2024 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2025 (They stay Grey, just like with other Dicom viewers :-(
2027 2003-10-30 Jean-Pierre Roux
2028 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2030 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2031 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2032 being coherents dicom files.
2034 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2035 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2037 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2038 * ENH: Two steps is necessary to please VC++ compiler...
2039 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2040 * ENH: Add include dir to medcon lib
2041 * FIX: only one function is being exported for now !
2042 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2044 2003-10-29 Jean-Pierre Roux
2045 * adding gdcmHeader::GetLUTRGBA
2046 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2047 --> Mathieu, the modif u're waiting for is not yet committed
2048 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2050 2003-10-27 Jean-Pierre Roux
2051 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2052 00191113.dcm DermaColorLossLess.dcm
2053 MxTwinLossLess.dcm RadBWLossLess.dcm
2054 * ENH: For version prior to vtkImageViewer2 -r 1.19
2055 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2057 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2058 * Removal of ido stuff in CMakeLists.txt
2060 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2061 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2062 * FIX: remove a call to ->Modified ... see comments
2063 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2065 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2066 * FIX: Problem with path for libvtkgdcmPython
2067 * ENH: Try adding a search script for python site-package
2068 * RMV: Remove some file from medcon lib that are not necessary
2069 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2070 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2071 * FIX: More pragma disable fro VC++,
2072 I don't think I break something as it is also disable in VTK/ITK.
2073 But it fasten debug compilation time.
2075 2003-10-23 Jean-Pierre Roux
2076 * gdcm now deals with 16 Bits Run Length Encoded images
2077 (they are compressed as 2 planes images,
2078 one for the high Bytes, the other for low Bytes)
2080 2003-10-22 Jean-Pierre Roux
2081 * Now CheckRead takes into account :
2082 - the bugged 'Leonardo' Siemens images
2083 - the XA images, sent thru the burning VPRO station
2084 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2087 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2088 * FIX: When copying a Makefile.am to CMakeLists.txt
2089 one should remove the '\'
2091 2003-10-22 Jean-Pierre Roux
2092 * in gdcmData adding a bugged 'Leonardo' Siemens image
2093 (wrong lengths in header)
2094 OK with gdcm, KO with the other viewers :-)
2095 * add a GE dlx XA image, thru the VEPRO burning station
2098 2003-10-21 Jean-Pierre Roux
2099 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2100 for a brutal checking of vtkgdcmViewer compliance
2102 2003-10-21 Jean-Pierre Roux
2103 * add the files for 'xmedcon' Jpeg Lossless library
2104 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2106 2003-10-21 Jean-Pierre Roux
2107 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2109 2003-10-21 Jean-Pierre Roux
2110 * garbage Siemens 'Leonardo' images dealt with
2111 (the patch is easy to remove)
2112 * cosmetic changes to avoid warnings
2114 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2115 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2116 no need to press 'r' now.
2118 2003-10-20 Jean-Pierre Roux
2119 * upgrade of checkRead.sh checkWrite.sh according
2120 to new Jpeg Lossless decompressor
2121 * add US.3405.1.dcm, a genuine RGB medical file ...
2122 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2123 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2125 2003-10-15 Jean-Pierre Roux
2126 * general anonymisation in gdcmData
2127 * adding the 'color files' from
2128 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2129 * adding some well knowed bugged-header images
2130 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2131 waiting for their inclusion in Python testsuite
2133 2003-10-15 Jean-Pierre Roux
2134 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2135 no longer seg faults when file is not found
2137 2003-10-14 Jean-Pierre Roux
2138 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2141 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2142 * TODO: *.in file to genereate a UseGDCM later
2144 2003-10-14 Jean-Pierre Roux
2145 * Some supposed-to-be Dicom Images have no preamble.
2146 OpenFile takes it into account
2147 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2148 * Missing elements added in dicomV3.dic
2149 (just to be affraid : have a look at
2150 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2151 and do it again next year ;->
2153 2003-10-13 Jean-Pierre Roux
2154 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2155 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2156 But there are NOT. It's fixed !
2158 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2159 * FIX: "jpeglib.h" was not found on VC++
2160 * FIX: vtkgdcm was not being installed
2162 2003-10-10 Jean-Pierre Roux
2163 * ENH : OpenFile closes the file if it *really* doesn't look like
2164 an ACR-NEMA / DICOM one.
2165 * FIX : testWrite no longer writes an empty file if the source file
2166 is not gdcm Readable
2167 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2170 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2171 * FIX: CMake generate now documentation
2172 * ENH: out of source doc build !
2173 * ENH: Generate both user and dev documentation
2174 * ENH: Should work on windows too
2175 * ENH: Only one doxygen config.in file is needed
2176 * FIX: make install should be ok now on ùnix plateform
2177 * FIX: PATH to dictionary was wrong (missing /)
2178 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2180 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2181 * vtkGdcmReader is now able to read rgb dicom file.
2182 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2183 * added a gdcmViewer to vtk test, use mouse to control
2184 window level & window width
2186 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2187 * CMake-ification of gdcm, we have now two build system
2188 * FIX: on cygwin Wsock32 doesn't exist
2189 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2191 2003-10-06 Emanuel Ollart
2192 * FIX : compilation process wad broken.
2193 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2195 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2196 * change gdcmViewer -> vtkgdcmViewer
2197 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2199 2003-10-06 Jean-Pierre Roux
2200 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2201 ( e.g : well known GE images with a wrong elem length,
2202 : Philips MRI Images with a wrong Huffman table)
2203 * still to be done : allow the reading of bugged LEONARDO Siemens images
2205 2003-10-03 Jean-Pierre Roux
2206 * Odd length strings are padded with '\0' (not with spaces,
2207 to remain compliant with already defined strings,
2208 like Transfert Syntax UID and others)
2210 2003-10-03 Jean-Pierre Roux
2211 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2212 to allow displaying RGB images (not only by affim ;-)
2214 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2215 * vtkGdcmReader is now able to read rgb dicom file.
2216 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2218 2003-10-03 Jean-Pierre Roux
2219 * A few nasty patches to allow the reading of a lot of nasty images
2220 ( e.g : well known GE images with a wrong elem length,
2221 : Philips MRI Images with a wrong Huffman table)
2222 * still to be done : allow the reading of bugged LEONARDO Siemens images
2224 2003-10-03 Jean-Pierre Roux
2225 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2227 2003-10-03 Jean-Pierre Roux
2228 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2229 to allow displaying RGB images (not only by affim ;-)
2231 2003-10-03 Jean-Pierre Roux
2232 * gdcmFile::GetImageDataIntoVector now
2233 - deals with MultiFrames MultiFragments Run Length Encoded files
2234 - deals with YcBcR (YBR_FULL) files
2235 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2236 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2238 (no sample found :-(
2240 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2241 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2242 Two reasons: - clear things
2243 - third parties acces gdcm through header files, so won't
2244 suffer anymore VC++ complains
2246 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2247 * add argv[1] in testvtkGdcmReader.cxx
2250 2003-09-24 Jean-Pierre Roux
2251 * The lines are now eigthy characters long.for
2252 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2254 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2255 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2256 char* to std::string. Thus, the use of strdup becomes useless. (see
2257 previous commis of Malaterre)
2258 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2259 before the last Malaterre's commit.
2261 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2262 * This commit should fix the Debug building under VC++, the problem
2263 was mainly a mixture of debug and release lib being loaded at startup.
2264 * I also remove a depency to a specific C function: strdup. Because I had
2265 to force the link to msvcrtd (whereas strdup is in libc).
2267 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2268 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2269 located in the gdcmCommon.h file. All use of reference of tha has been
2270 changed to now use the variable GDCM_UNFOUND.
2272 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2274 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2275 Dicom dictionary. The test suite can now be run again. Note:
2276 I'm note very happy with the " (RET)" changes. I believe this
2277 RETAINED comment should be dropped when parsing the dictionary.
2278 - PACKAGER corrected
2280 - AUTHORS updated and now in alphabetical order
2281 * Makefile.am now exports gdcm.dsw for Windoze users.
2283 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2284 * cygwin complains about missing std:: in subdir Test/
2286 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2287 * remove some methods that are now in gdcmHeaderHelper
2289 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2290 * vtkGdcmReader set spacing and origin correctly
2292 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2293 * Fix a few delete/delete[] mismatch
2295 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2296 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2297 interpretation to data given by gdcmHeader. For instance there are
2298 heuristics to get informations (look at different places).
2299 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2300 sorting DICOM images based on different strategies.
2301 * modified Makefiles accordingly.
2303 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2304 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2305 when building in debug mode
2306 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2307 src/win32/gdcmdll.dsp
2308 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2310 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2311 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2314 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2315 * src/win32/libgdcmjpeg12.dsp was not dos format
2316 * src/win32/libgdcmjpeg12.dsp :
2317 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2318 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2320 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2321 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2323 * src/gdcmFile.cxx : bug fix in affectation type
2324 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2325 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2326 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2327 symbols... future problem ?
2329 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2330 * src/win32/libgdcmijpeg12.dsp was missing
2331 * modified gdcm.dsw accordingly
2333 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2334 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2336 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2337 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2338 commit of JPR (before his hollidays to facilitate our work).
2339 * setup.py : bug fix in code. Modifications made while the last commit
2340 of JPR. The code hasn't been tested before the commit... it's so
2341 useless to make that (for best programmer that is JPR) !!!
2343 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2344 * tagged the current version as Version0_3 (i.e. version 0.3)
2346 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2347 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2348 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2349 * *.dsp : modifications to use new libgdcmijpeg8 library
2350 * setup.py : bug fix on VTKPATH variable
2351 * PACKAGER : adding all concerning windows
2353 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2354 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2356 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2357 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2358 test suite reported error.
2359 * PACKAGER file added (describes what a packager must do when
2360 packaging a new release).
2361 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2362 * configure.in: upgraded version number to 0.3.0
2363 * fixing build of rpm (through rpm -ta):
2364 - Doc/Makefile.am exports proper doxygen files
2365 - src/jpeg/libijg8/Makefile.am exports the include files.
2367 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2368 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2369 * src/gdcmHeader.h : formatting code
2371 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2372 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2373 We were obtaining error message from vtk. Now, creation of file list
2374 is made in an internal list to prevent this problem.
2375 Bug fix when output is empty.
2376 Bug fix in update of progress value. Previous commit for this was a bad
2378 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2380 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2381 * src/gdcmHeader.h : added method to get the file name
2382 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2383 files. Added method to remove all files on the input
2384 Added FIXME comment concerning the bad parsing of header made by
2385 ExecuteInformation method (in ExecuteData method)
2387 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2388 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2389 when using make instal.
2390 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2391 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2393 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2394 * setup.py : adding include dir of jpeg lib to compile all sources
2395 * */Win32/*.dsp : JPR fix for windows compilation
2397 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2398 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2400 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2401 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2403 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2404 * setup.py is again effective on un*x (takes into account the
2405 addon of the jpeg library)
2406 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2407 * Doc/Doxy* updated (includes above enhancements)
2408 * INSTALL now points to web documentation
2410 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2411 * src/gdcmHeader.h doesn't make unnecessary reference to
2413 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2415 * src/gdcm*.[cxx|h] :
2416 - to allow compilation with gcc 3.x
2417 -- clean up of STL usage (added explicit usage of std::)
2418 -- small fixes on exceptions.
2419 Note: linking not tested !
2420 - clean of doxygen comments to avoid warnings at documentation
2422 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2423 dependent convertion).
2425 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2426 * Clean up of previous JPR garbage commit (not even commented in the
2428 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2429 - moved all jpeg related files from src to src/jpeg/libijg8, with
2430 addition/modification of Makefile.am and configure.in.
2431 - the testSuite is still brain damage (not guilty).
2433 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2434 * WrapVTK.py : modifications to get correctly vtk source files to
2436 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2437 (FileName -> Filename)
2439 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2440 * vtk/vtkGdcmReader.[cxx/h]:
2441 - UpdateProgress method should now be effective
2442 - removed the limitation on having only images loaded (as opposed
2444 - when building a stack of images/volume, a lesser number of
2445 gdcmHeader and gdcmFile instances should be used (hopefully
2446 accelerating things).
2447 - when building a stack of images/volumes, files which are not
2448 loadable (wrong path-filename, wrong permissions on existing file,
2449 or file not parsable by gdcm) are replaced with a black image
2450 in the stack (for the caller to notice the problem).
2452 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2453 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2455 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2456 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2457 between standard library (std) and vtk library (problems are found
2458 under Windows... thanks Windows !)
2460 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2461 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2463 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2465 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2468 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2469 * When compiling with distutils (see setup.py) the C++ compiler is
2470 called with different flags than the default ones (with automake).
2471 In order to fix all those warning, I compiled gdcm with the command
2472 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2473 and went for warning fixes:
2474 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2475 up from unused variables.
2476 - vtk/vtkGdcmReader.cxx: potential bug fix.
2477 * src/gdcmHeader.h: Doxygen warning cleanup
2479 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2480 * gdcmPython/gdcm.i:
2481 - typemaps correction to take into account the systematic replacement
2482 of "using namespace std" with std:: prefix e.g. std::list,
2483 std::string... (cf changes of 2003-05-21).
2484 - gdcmGlob global variable of type gdcmGlobal (defined in
2485 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2486 exported to Python a as cvar.
2487 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2488 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2489 gdcmDictSet.GetPubDictTagNames() and
2490 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2491 C++ static methods).
2492 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2493 with the above changes.
2495 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2496 * setup.py, manifest.in : bug fix under linux
2498 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2499 * Modification of setup.py to compile vtk part too. Then, we have 2
2500 wrappers which must work with same distutils. For that, we have a
2501 generic distutils in distusiltsWrapping.py ; with :
2502 - build_extWrap class to wrap generically all extensions,
2503 - ExtensionWrap base class for all wrapping extension that contains
2505 - Wrapper interface which wrap sources
2506 + In WrapSwig.py we have extension and wrapper for Swig
2507 + In WrapVTK.py we have extension and wrapper for VTK
2508 * MANIFEST.in : modifications to consider vtk directory and new python
2509 files for compilation
2511 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2512 * Added python wrappers of vtkGdcmReader vtk class (see the
2513 source in vtk/vtkGdcmReader.cxx) :
2514 - vtk/Makefile.am now builds a library
2515 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2516 python library (as opposed to _gdcm.so wich are the python
2517 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2518 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2520 - configure.in has an additional flag --enable-vtk that needs
2521 to be set to enable compilation of vtk related code, that is:
2522 + vtk/vtkGdcmReader.so and
2523 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2524 + gdcmPython/vtkgdcmPython.so (see above)
2525 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2526 be read when compressed or when HighBit + 1 != BitsStored),
2527 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2528 the usage of the python wrapper of vtkGdcmReader vtk class.
2529 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2530 * src/*.[h] all occurences of stl classes are now prefixed with
2531 std::, and all occurences of "using namespace std;" where removed.
2532 This is to avoid pollution of global namespace in included files.
2533 Apparently vtk does not avoid this pitfall: when using both
2534 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2535 collision of various stl members (principally cout...).
2536 * gdcmPython/testSuite.py now cleanly removes temprory generated
2538 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2539 comply with above changes)
2541 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2542 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2543 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2544 vtk data structure (an image Flip was required).
2545 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2546 * cosmetic changes in documentation.
2548 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2549 * src/gdcmHeader.cxx: the constructor no longer exits when an
2550 unexisting file is given as argument.
2551 * The subdirectory Data (containing all the images used for the
2552 test suite) is not part of this repository anymore. A new module
2553 containing those images is now available at
2554 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2555 with the name gdcmData.
2556 All the python scripts (including the package initialisation file
2557 gdcmPython/__init__.py) were adapated to take this change into
2558 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2560 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2561 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2562 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2563 demo of the usage of this class.
2564 Compilation of this vtk part is only done when using the --enable-vtk
2565 at configure (or autogen.sh) stage.
2567 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2568 * More memory link related corrections and documentation fixes.
2570 - maximum info is obtained with a command of the form:
2571 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2572 --show-reachable=yes PrintHeader
2573 - the remaining reachable blocks seem to come from the STL
2574 allocation scheme through the usage of map and list. It looks
2575 like this memory cannot be freed but it is not a memory leak
2576 (in fact further invocation to the STL would recollect the
2577 unused memory allthough it cannot explicitely be freed).
2578 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2579 of displaying an image parsed with gdcm and displayed with VTK.
2580 Note: some images don't seem to work e.g.
2581 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2582 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2583 Allthough this weakens the semantics, it is a ditch attempt to
2584 make gdcm more thread friendly.
2586 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2587 * Memory link hunt (by using valgrind through the command
2588 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2589 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2590 gdcmHeader::_dicom_vr.
2591 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2592 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2594 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2596 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2597 * src/Makefile.am now exports all the necessary include files at
2601 * UpdateGroupLength replaced by new one
2604 * UpdateGroupLength re-written using H-Table
2605 (named UpdateGroupLengthNew untill checks are over)
2607 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2608 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2609 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2611 - gdcmHeader::GetPubElValSet removed.
2612 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2613 UpdateGroupLength, WriteElements, Write.
2614 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2615 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2616 carried the same semantics.
2617 - src/gdcmHeaderIdo.cxx changed accordingly.
2618 - gdcmFile::WriteBase now regroups all the codes from previous
2619 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2620 - enum FileType moved to gdcmCommon.h
2621 * src/gdcmHeader.cxx AddDefault trashed
2622 * gdcmGetXSize added
2623 * getimageDataSize now calls gdcmGetXSize
2624 * Test/*.cxx changed to agree with above changes
2626 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2627 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2628 (to avoid double call by end user).
2629 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2630 by end user, since gdcmHeader::gdcmHeader now handles it.
2632 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2633 * gdcm/Doc many doxygen changes:
2634 - Doxyfile now has two different versions, DoxyfileUsers that generates
2635 the html.users end users oriented documentation and
2636 DoxyfileDeveloppers that generates the html.developper developper
2637 oriented documentation.
2638 - README changed accordingly
2639 - requirement.txt removed (old design info moved to TODO).
2640 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2641 DoxyMainPage.txt, DoxyPython.txt provide more information.
2642 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2643 be updated by simply regenerating the docs with doxygen and copying
2644 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2645 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2646 all the tests in the form "if (<map>.count() >1)" were removed.
2647 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2648 ill-formed documentation sections.
2649 * src/gdcmHeader.cxx: ditto
2651 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2652 * setup.py fixed for un*x (needed macro for stdint.h)
2653 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2654 un*ces with sh-utils test utility.
2655 * gdcmPython/demo/test.py renamed to PrintHeader.py
2656 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2657 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2658 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2659 * src/gdcm*.cxx JPR's bad inclusion fixed.
2661 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2662 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2663 * gdcmPython/demo/test.py changed accordingly.
2665 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2666 * gdcmPython/Makefile.am fixed linking against libstdc++
2667 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2668 * Swig subdir (historical tests of swig version 1.3.17++) removed
2669 * Test/testChangeEntete.cxx some lines commented out in order to make
2671 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2672 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2674 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2675 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2676 hence the user doesn't need this explicit call.
2677 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2678 i.e. LoadElements() call removed.
2679 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2680 - src/Makefile.am declares the proper flag for g++.
2681 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2682 for adding user defined new tags.
2683 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2684 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2685 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2687 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2688 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2689 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2690 src/Makefile.am : the project should properly compile and install
2691 with the autotools, included the python wrappers part.
2692 * gdcm.spec.in : added a spec file for RPM packaging.
2694 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2695 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2697 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2698 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2699 to exported to the environement (see gdcmPython/testSuite.py
2701 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2702 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2703 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2704 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2705 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2707 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2708 * gdcmPython/__init__.py doesn't crash anymore when running in
2709 in InstallMode or PreInstallMode but with an environement given
2710 value of GDCM_DICT_PATH.
2711 * src/gdcmDictSet.[cxx/h] coding style.
2713 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2714 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2715 * src/gdcm.h general comments moved to TODO, and README
2716 * src/gdcm.h should now be seen as a user commodity (including it
2717 should suffice to fully use gdcm). It is nowhere including within
2718 any of the kernel files src/*.cxx and src/*.h.
2720 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2721 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2722 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2724 * src/gdcm*.cxx only include their corresponding include file
2725 (as opposed to gdcm.h)
2726 * gdcmPython/gdcm.i changed accordingly
2727 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2728 the autogen.sh generated "make snapshot" command to work.
2729 * autogen.sh removed history related references to crea package.
2731 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2732 * distutilsSwigCPlusPlus.py work around some swig portability
2735 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2736 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2737 was done in a last ditch attempt to get setup.py _really_
2738 operationnal. The python/gdcmPython layaout add the advantage
2739 of hidding away the python related distutils specific files
2740 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2741 Alas, the src directory was out of scope (i.e. it's relative
2742 position to setup.py was ../src) which made things impossible to
2743 handle (see previous version of python/setup.py). Crossing fingers...
2745 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * python/setup.py now works on Un*x. (harder than I thougth)
2747 * python/distutilsSwigCPlusPlus.py can now have include files
2748 among the list of sources.
2750 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2751 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2752 * modifications in MSVC projects
2754 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2755 * As stated by the first lines of Test/ExceptionAndPython/README, it
2756 looks like we can move back to original usage of exception within
2757 src/gdcm* and hence remove the errno stuff that was introduced
2758 as a quick and dirty fixture of this problem (added to the TODO).
2759 * Doc/Doxyfile configuration file for Doxygen and corresponding
2760 README file for usage added.
2761 * Test/testWrite.cxx added. This new test comes from a split of
2762 test.cxx that is now reverted to its original purpous i.e.
2763 testing the proper parsing of a Dicom related file.
2764 testWrite.cxx concentrates on testing the IO part of gdcm.
2765 * Test/bug1.cxx (containing a bug on WIn32) added.
2766 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2767 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2768 whose purpose is to publish the content of the TagNames of the
2769 Dicom public dictionnary were not accessible without an
2770 instance of class gdcmHeader.
2771 - those methods are now static methods of gdcmDictSet and hence
2772 require no instances at all to be invocated.
2773 - within gdcmDictSet this change required to change some method
2774 to class methods (i.e. are now static) among which SetDictPath
2775 (renamed to BuildDictPath) and LoadDefaultPubDict.
2776 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2777 the above changes by calling the new method classes of gdcmDictSet.
2778 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2779 the above to be effective.
2780 * python/gdcmPython: in order to wrap properly the above changes
2781 for Python, swig version now needs to be > 1.3.17.
2782 * python/gdcmPython/Makefile fixed to adapt itself to new
2783 configure/make shema introduced by Johan Montagnat (thanks for the
2784 contribution). Alas this Makefile cannot be turned into a proper
2785 Makefile.am without some heavy changes in the configure.in
2786 (for python dectection).
2787 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2788 now avoids publishing the empty entries.
2790 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2791 * python/setup.py : bug fix concerning install under windows
2792 ExtraPath reused :-P
2793 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2795 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2796 * Dicts/dicomV3.dic : remove double spaces !!!
2797 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2798 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2801 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2802 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2803 method. Doxygenation.
2804 * src/gdcm.h clean up of JPR spurious comments.
2806 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2807 * python/distutilsSwigCPlusPlus.py now properly collects the
2808 shadow classes generated by "swig -c++" (gdcm.py in our case)
2809 when using "python setup.py install".
2810 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2811 reexports the working classes.
2812 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2813 by the classical C errno scheme. This is to prevent an obscure
2814 behavior of the python wrappers when importing wxPython.wx prior
2815 to gdcmPython (which ended up in an abort call). An illustration
2816 of this oddity can be found in the Test/ExceptionAndPython
2817 subdir (see the README file). This problem probably due to
2818 an combination of g++ and dynamic loading.
2819 * added Test/ExceptionAndPython (see above)
2821 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2822 * Changed the layout of the python part to avoid bloating main
2823 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2824 i.e. the distutils arsenal. All the python related stuff is
2825 again in a python subdir, but the package itself is now in
2827 * setup.py was cleaned up:
2828 - pythonIncludePath removed
2829 - python setup.py bdist target is now functional.
2830 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2831 collision with other packages). gdcmPython/demo/*.py changed
2834 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2835 * python subdir moved to gdcmPython (preparation of distutils packaging).
2836 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2837 distutils installer is operational.
2838 * - gdcmPython/__init__.py now properly loads the swig generated
2839 shadow classes (from gdcm.py).
2840 - gdcmPython/demo/*.py changed to import the package gdcmPython
2841 instead of gdcmPython/demo/load.py.
2842 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2844 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2845 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2846 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2847 entries within the associated public Dicom dictionary resp. the same
2848 information but sorted by the fourth field (PAT, IMG, DIR) of the
2850 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2851 are now in the "???" group.
2852 - python/gdcm.i changed accordingly,
2853 - python/demo/printGroupedPublicDict.py added, that gives an example
2854 of the above new functionalities in Python.
2856 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2857 * src/gdcm.h, gdcmHeader.cxx:
2858 - historic references to glib's g_malloc and g_free (#defined)
2859 were definitively removed.
2860 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2861 * src/gdcmElValSet.cxx:
2862 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2863 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2864 - GetElValue(string) renamed to GetElValueByName.
2865 - Added GetElementByName(string).
2866 * src/gdcmHeader.cxx: added
2867 - GetPubElValRepByNumber(guint16, guint16)
2868 - GetPubElValRepByName(string)
2869 - GetShaElValRepByNumber(guint16, guint16)
2870 - GetShaElValRepByName(string)
2871 - GetShaElValByNumber(guint16, guint16)
2872 - GetShaElValRepByName(string)
2873 - GetElValRepByNumber(guint16, guint16)
2874 - GetElValRepByName(string)
2875 - GetElValByNumber(guint16, guint16)
2876 - GetElValRepByName(string)
2877 * Doc/requirements.txt added.
2879 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2880 * Test/Makefile building now depends on the one of libgdcm.so
2881 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2882 pixel data) aware which enables finding the address (offset) of
2883 the pixel data of JPEG encoded DICOM files. This leaves only a single
2884 file in the testSuite whose pixel data address (offset) is unknown.
2885 * python/testSuite.py changed accordingly.
2887 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2888 * VC++ has some strong limitations when working with the STL, as stated
2889 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2890 "Also note that some STL containers (map, set, queue, list, deque)
2891 cannot be exported. [...]
2892 Some STL classes contain nested classes. These classes can not
2894 This is caused by a designed limitation that once a template
2895 class is instantiated, it can not be re-instantiated and
2897 Since our usage of map<> is ubiquitous in gdcm, this "designed
2898 limitation" of VC++ is a pitfall.
2899 Hence the Python wrappers of gdcm cannot be incrementally linked
2900 against the c++ dynamic library. The dirty but only workaround is
2901 to forget about incremental link of dynamic libraries and to generate
2902 the Python wrappers library with the inclusions of the underlying C++
2904 The following modifications concern this matter on Win32/VC++:
2905 - wrapping python correct with standalone wrapped dll (don't use separate
2906 dll under windows !!!!)
2907 - python21_d debug mode enabled (ask Frog how to use it :-)
2908 - NO problem with having an STL member of class for example string in C++
2909 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2910 - Python test of dcmlib in Python is ok under windows on a large set
2912 * removed glib references
2913 * typedef's inserted in gdcm.i for correct swig type management
2915 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2916 * python/demo/*.py load.py extracted from test.py. Added explore.py
2917 that only displays required tags and testAll.py that parses all
2918 the files of the testsuite without using unittest.
2919 * python/testSuite.py other additional test on new files added.
2920 * Data/* new test files added accordingly to the testSuite.
2921 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2922 the vr in the file differs from the one of the dictionary.
2924 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2925 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2926 values, but limits itself to values which are below a user specified
2927 size (by default 1024 bytes).
2928 * python/gdcm.i : elements not loaded (because their size is above the
2929 user specified treshold) are exported with their TagKey as key of the
2930 python dictionary. This enables the testsuite to make some checks
2931 on the unloaded elements (since we have their offset and size).
2932 * python/testSuite.py
2933 - now tests for the existence and proper value of the pixel data
2934 - two new examples added.
2935 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2937 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2938 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2939 aware. See the strategy comments in gdcmHeader::FindeLength().
2940 * Test/test.cxx now accepts a filename as first argument.
2941 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2942 * python/testSuite.py changed to integrate test on above files.
2944 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2945 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2946 the vr was also RET.
2947 * python/testSuite.py more tests added.
2949 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2950 * python/testSuite.py unittest test suite added (uses Data)
2951 * Data/* dcm and acr files for the test suite.
2952 * glib dependance removed from un*x version. We now use ISO C99
2953 7.18 Integer types (see stdint.h)
2954 - python/Makefile, src/Makefile src/gdcm.h
2955 * src/ when an explicit vr (like dicom files) suddenly poped an
2956 implicit element we use to mark the underlying DictEntry of the
2957 concerned ElValue with "Implicit". This strategy was damageable
2958 too the public or provite dictionaries, since some of their vr
2959 would be changed. Since Header::FindLength heavily relies on the
2960 detection by Header::FindVR of falsely explicit elements, I
2961 added an extra ImplicitVr member to ElValue (boolean).
2962 The rest of the changes we the necessary adaptations.
2964 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2965 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2967 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2969 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2970 * Adaptation for porting to VC++:
2972 o forced to use std namespace (for string to be known)
2973 o all class use __declspec export style on WIN32
2974 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2975 (in stdlib.h on Win32 but in std:: for gcc)
2976 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2977 variable GDCM_DICT_PATH.
2978 * src/gdcmHeader.cxx verbose comments made discrete.
2980 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2981 * python/gdcm.i: added a typemap that converts a C++ hashing table
2982 to native Python dictionary.
2983 * python/demo/test.py:
2984 - now uses the native dictionary for exploration of gdcmHeader.
2985 - takes an optional filename argument (the file to parse).
2986 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2987 PubElVals hashing table.
2988 * Dicts/dicomV3.dic removed error prone trailing spaces.
2990 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2991 * Python wrapping process moved away from src/Makefile to
2992 newly created python/Makefile (as well as gdcm.i)
2993 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2994 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2995 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2996 from the environement variable GDCM_DICT_PATH (when existing).
2997 * src/gdcmDict::GetTag bug fix.
2999 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3000 * Straightforward temporary fixes for swig to build the python wrappers.
3001 src/Makefile now has a python working entry [by working we mean
3002 that we can import de shadow classes without errors].
3004 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3005 * hashtest.cxx removed (since already in Test)
3006 * src/gdcmlib.h renamed to src/gdcm.h
3007 * src/dcm.i renamed to src/gdcm.i
3008 * src/Makefile prepared for python wrapping
3010 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3011 * src/gdcmHeader.cxx :
3012 - Parsing of header is now separated from loading of element values
3013 (see gdcmHeader::LoadElements).
3014 - general clean up of hopefully all file access (creation of
3015 ReadInt16 and ReadInt32)
3017 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3018 * src/gdcmHeader.cxx :
3019 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3021 - SetLgrElem renamed to SetLength
3022 - GetLgrElem renamed to GetLength
3023 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3024 * src/gdcmElValSet.cxx fixed both GetElValue methods
3025 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3026 due to IdoDude was cleaned out.
3028 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3029 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3030 concentrates on finding the value representation (when it exists).
3031 RecupLgr now only finds the element value length, and it avoids
3032 returning the unecessary skL (skipped length).
3033 Also, offsetCourant was simply removed (with taille_fich) since
3034 it was redundant with the File position internals (by using
3035 ftell and fseek). This also made skL (see above in RecupLgr) usage
3037 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3038 on the libido specificities which are handled through class
3040 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3043 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3044 * Truckload of changes. Parsing of header is barely functional
3045 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3047 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * src/gdcmHeader.cxx many addons of low level methods
3050 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3051 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3052 and _IdDcmSWAP_LONG.
3054 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3055 * This corresponds to all the changes decided at the meeting of
3056 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob