1 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
3 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
4 with other method names
5 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
6 * Test/TestDicomDirElement.cxx : add new test
8 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
9 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
10 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
11 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
12 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
13 So can't you use __int64 in ostream at all.
15 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * bug fix for compilation on MSVC6
17 * gdcmPython/gdcm.i : rename of classes missed
19 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
21 type and not a string. So, there remove problems on the format of the
24 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
26 Thus, DicomDirXXX are created with a flad that indicates if the created
27 object is empty or not (when not empty, the DicomDirElement is used to
30 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
32 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
34 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
37 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
39 Remove all access to the hash-tables or lists in the objects.
41 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
43 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
44 be complient with all the gdcm source code
46 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
50 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
54 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
55 * Test/ : rename VTK tests to have a best name for the tests
56 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
57 GetFirstEntry/GetNextEntry use
59 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
61 test. Now it's on image content and not on the resulting visualisation...
62 might solve the problem on linux when using the OpenGL drivers
64 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
65 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
66 DicomDirSerie, DicomDirImage
67 Dict, DictSet classes :
68 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
69 -remove InitTraversal method.
70 * UPD Test programs + Example programs
72 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
73 remove useless and never updated keyword \ingroup
75 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
76 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
77 is no memory access violation
78 * gdcmPython/demo : add python demos using VTK
80 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
81 * FIX 'Dictionnary' is now spelt 'Dictionary'
82 'wether' is now spelt 'whether'
83 'archieve' is now spelt 'archive' ;-)
85 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
86 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
87 related methods, in order not to expose internal mechanisms
90 * REM methods that exposed internal mechanisms :
91 DicomDir::GetDicomDirPatients()
92 DicomDirPatient::GetDicomDirStudies()
93 DicomDirStudy::GetDicomDirSeries()
94 DicomDirSerie::GetDicomDirImages()
101 * ADD DictSet methods
105 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
106 * Removed the Print/indent/default parameter mess. There is absolutely no
107 reason to have to methods, moreover with the second taking the ostream as
108 *SECOND* parameter. This was clearly a bad hack to get things compile.
110 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
111 * Complete rewrite of the GetMacAddress code. Now the code is *much*
112 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
113 Unfortunately the main code does not work on SunOS, thus provide a specific
114 code for this platform only (and Win32 of course). Since this seems to be
115 working, change CreateUniqueUID to use GetMACAddress instead of the
116 problematic GctestetIPAddress
118 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
119 * Unfortunately to be able to test gdcmDirList I had to break the API
120 a little. Now the class is not a std::list anymore but has a member
121 std::vector (more ITK compatible). Allow unit testing on Win32 and
124 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
125 * Update SerieHeader to take into account a Serie Instance UID to properly
128 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
129 * ENH - Comment out Mathieu's (dangerous) Super Hack
130 for dealing with BIGENDIAN processors
131 - Move equivalent stuff to BinEntry::WriteContent
132 When necessary, 16 Bits Pixels are swapped in a small buffer
133 and then written. This avoid allocating a huge buffer, in
134 PixelWriteConvertor, and avoid modifying the Pixel Area.
136 Probabely, the same operation will have to be done when we want
137 to write image with Big Endian Transfert Syntax,
138 and we are working on Little Endian Processor
140 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
143 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
144 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
145 all the dict content.
146 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
148 * Test/TestDict.cxx : add a new test for the dict classes
150 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
151 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
152 file. Debug is yanked if compiled with NDEBUG
154 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * src/gdcmDictSet.h : set the default output to the os variable
156 * src/gdcmDictEntry.[h|cxx] : add the Print method
157 * gdcmPython/demo/ : add a new test
159 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
160 * merging of Test/PrintDicomDir and Test/TestDicomDir
161 * removal of now redundant Test/PrintDicomDir
162 * enhancement of Example/PrintDicomDir
164 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * Now, python test might work on systems
166 * Add the PrintDicomDir test
168 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
169 * FIX : First entry following group 0002 was lost for
170 Explicit Big Endian Transfer Syntax files
171 (group and elem not swaped)
173 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
174 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
175 Big Endian Transfer Syntax supposed the group following 0002
176 begins always by element 0000 (element 0000 is *optional*)
177 To avoid further troubles, let's be pessimistic, and use
178 Document::HandleOutOfGroup0002() method
179 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
180 (related pb not yet solved)
182 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
183 * Bug fix for the python part use
184 * Now, PrintHeader.py pass... but outside the ctest use. shit !
186 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
187 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
189 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
190 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
191 a string and should ask the global TS dict what are the propreties of
194 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
195 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
196 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
197 to swap the Swap Code, at parsing time, when we come out of group 0002
198 and Transfer Syntax is Big Endian
199 We should be able to read now 'true DICOM" Big Endian coded images
200 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
201 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
203 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
204 * Hopefully fix the bug on MacOSX and static global initialization.
205 This is the only -minor- patch I found that both please MacOSX and VS6.
206 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
207 but this would require a lot of change. Another approach would be that Global
208 create those string and GDCM_UNFOUND becomes a pointer to a string (which
209 gdcm::Global would destroy at exit).
211 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
212 * Fix bug on MacOSX with static initialization in a multy threaded
213 environment. static const string in a header file used to be ill
214 initialized provoquing the freeze of any tests. patch should solve this
217 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
218 * According to Benoit's suggestion, and without any objection from anybody
219 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
220 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
221 - method gdcmDicomDirObject::GetEntry() renamed as
222 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
224 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
225 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
226 you debug/warning message just as c++ streams which make them very convinient
227 to use. Once this is stabilize I will change the ostringstrem to be
228 redirected to a file (ofstream).
229 * Properly support C99 extension: __FUNCTION__ which allow us to display
230 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
232 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
233 * Removal of useless and dangerous methods :
234 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
235 GetDocEntryByName, GetEntryByName, GetDictEntryByName
236 * Removal of usless methods :
237 Dict::PrintByName, Dict::GetDictEntryByName
238 * Commenting out of probabely useless methods :
239 Dict::GetDictEntryNames()
240 Dict::GetDictEntryNamesByCategory()
241 DictSet::GetPubDictEntryNames()
242 DictSet::GetPubDictEntryNamesByCategory()
243 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
244 * ENH : Use dicomTS.dic as described in 2004 version
245 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
246 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
247 Add Accessors on VM (Value Multiplicity), and VM related methods
248 * ADD : Add a list of 'Dicom Attribute types', as found in
249 http://medical.nema.org/dicom/2004/04_15PU.PDF
251 * ADD : Add dicomGroupNameAbbreviations.dic
252 should be used to write a method to replace the former
253 Dict::GetDictEntryNamesByCategory()
255 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
257 to read in the file... and only it ! Length is the efective length of the
258 data in the DocEntry structure
260 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
261 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
262 And now use a static function call instead, with a global variable. i
263 This is much closer to the VTK approach. Hopefully should be bulletproof
264 and easier to use...hopefully
266 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
267 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
269 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
272 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
273 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
274 ValEntry, BinEntry, SeqEntry creation or replace
276 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
277 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
278 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
280 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
281 when specifying the VR
282 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
283 * src/gdcmDocEntry.cxx : amelioration of print
285 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
286 * ADD : Add the method Util::IsCurrentProcessorBigEndian
287 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
288 * ADD Method Document::ComputeGroupLength
289 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
290 in order to allow further VR modification by user
291 * REM : removal of once-called method File::WriteBase
292 integration of its code in formerly one-line method File::Write
294 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
296 replace the different values "??", "Unkn", "Unknown".
297 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
298 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
299 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
300 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
302 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
303 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
305 * Set the gdcm::Base class to some Printable classes
307 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * src/gdcmFile.[h|cxx] : add the Print method
309 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
310 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
311 * src/gdcmDocument.h : remove the PrintLevel informations
312 * Example/PrintFile.cxx : use the new gdcm::File::Print
314 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
315 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
316 problems when compiling with the python wrapping
318 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
319 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
320 writting in ImplicitVR
322 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
323 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
324 JPEG decompression, especially when dicom frames are split into several
325 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
326 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
328 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
329 * src/gdcmHeader.cxx : change the initialisation of default header.
330 Now, this header is readable by gdm, e-film, DicomWorks
332 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
333 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
334 Rename Decompressed to Raw
335 * Use the API changes in gdcm::File.
336 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
339 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
340 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
341 each added entry in the header. Replace the 'Planes' field by the 'Number
344 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
345 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
346 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
348 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
350 At this time, this image isn't readable by e-film... waiting JPR help to
353 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
354 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
355 DocEntry. Now use methods of the Document !
357 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
358 * Test/ShowDicomSeq.cxx : bug fix
360 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
361 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
362 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
363 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
364 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
366 * Test/TestCopyRescaleDicom.cxx : remove unused variable
367 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
368 containing found sequences
370 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
371 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
373 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
374 Some fields in BinEntry must be copied to not seg fault when making the :
375 gdcm::File *copy = new gdcm::File( copyH );
376 and tests are now made on good variables
378 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
379 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
380 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
382 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
383 * Add vtkGdcmWriter example and test
385 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
386 * Test/TestUtil.cxx : reformat the source code
387 * vtk/vtkGdcmReader.cxx : remove and change prints
388 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
390 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
391 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
393 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
394 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
395 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
397 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
398 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
399 by an eof to prevent all bad read of the file... and in this case, the
402 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
403 * Example/Volume2Dicom.cxx : comment unused variables
404 * Test/PrintDicomDir.cxx : comment unused variables
405 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
406 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
407 method that is redondant with AddEntry.
408 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
411 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
412 * Bug fix due my last commit (compilation under Windows).
413 * Example/Volume2Dicom : bug fix in the file and reformatting source code
414 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
416 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
418 - Remove printf / sprintf
419 - include iostream AFTER gdcm so we don't get warnings
420 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
422 - Also remove tons of include from header files, hopefully this should
423 speeup the compilation time, since it was becoming a dog slow.
424 - Remove gdcm.h as it include way too many files and slow down compilation
425 (plus it is not up to date)
426 - remove 'using namespace std' this is BAD !
428 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * Remove memory leaks on the DicomDir
430 * Remove some useless data in DicomDirObject
431 * Add usefull methods in SQItem, to be complient withe the ElementSet
433 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
434 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
436 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
437 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
438 future, with convertion)
439 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
440 and ImageDataSize values. Remove the method to get the PixelReadConverter
441 from the output of the class
443 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
444 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
446 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
447 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
448 and vtkErrorMacro use.
449 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
451 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
452 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
454 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
455 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
456 The string leaves only in the fonction. So when we make a .c_str(), we
457 get the pointeur on the first element, element that will be destroyed
458 immediately after thee instruction.
459 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
460 file has been opened : the test must be made on the content of the
461 pointer and not directly on the pointer !
464 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
465 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
466 the python part recompiles
468 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
470 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
471 X session is killed (for my computer... it seems to not be identic on
474 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
475 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
476 avoid problems (otherwise, the difference test between the visible image
477 and the reference is incorrect. If the reference is greater than the
478 screen resolution, it's produce errors).
479 Can be used for only one image. Can be used with a visible flag.
480 * vtk/vtkGdcmReader.cxx : remove commented codes.
481 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
482 under windows at compilation
483 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
485 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
487 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
488 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
489 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
490 tests on the image size X, Y, Z
492 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
493 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
494 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
495 between the class name and the file name
497 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
498 * src/ : fix compilation warnings for the Write method (2 different
499 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
500 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
501 variable... create a static method in gdcm::Document to access to
502 this variable content.
504 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
505 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
506 file, to be accessed by other files (like gdcmFile). Remove commented
507 code. Move the change of the header to the gdcmFile, using the
509 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
510 To be sure of that (and simplify calls), the Write of the header now
511 gets a file name and not a file pointer (std::ifstream).
512 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
513 DocEntryArchive. Remove all open of the written file
515 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
516 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
518 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
519 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
520 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
522 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
523 some corresponding methods. Write correctly the file and check before
525 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
526 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
527 is now on RGB data (as before my last commit
528 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
530 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
531 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
532 Add a print information of the type of the entry
533 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
534 It was in the gdcmFile, and all write have been regrouped
535 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
536 Write correctly all dicom files (in decompressed mode only at this time)
537 * Test/ : test on files are now made using Raw data and not color data if
539 * Example/PrintFile.cxx : add more printings
541 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * Amelioration of code, remove some code copy. For the loading of
543 BinEntry (in gdcmDocument), add the test to verify if the file is already
546 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
547 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
548 remove a DocEntry in the header (push an empty DocEntry)
549 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
550 lines. Bug fix in the initialization of the PixelConvert and the
552 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
553 use in TestCopyDicom (now this test can run under windows... but fails)
554 * Test/TestCopyDicom.cxx : amelioration of the test :
555 - test the pixels written
556 - add test points to quickly find where is the error
557 - can set a file name input and output in arguments
558 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
559 amelioration of the test output
561 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
563 all replaced DocEntry's
564 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
565 Now, each needed DocEntry to modify is duplicated, modified and inserted
566 to the header using DocEntryArchive. Thus, after save, we can restore the
567 header initial state.
569 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
570 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
572 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
573 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
574 correct to copy it. The DictEntry is specified at the DocEntry creation,
575 then, it musn't change in the time.
576 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
577 header correctly. At this time, the change is only made for the first
578 level of the Document. In the future, it might consider sequences.
579 The change is made by replacing a DocEntry by an other that is created
580 outside the class. The old value is kept. When we restore the header
581 status, the added DocEntry is deleted and replaced by the old value.
582 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
583 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
584 set the write type to explicit VR, implicit VR or ACR. Add methods to set
585 the write mode to native, decompressed or RGB (but not used at this time)
587 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
588 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
589 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
591 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
592 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
593 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
595 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
596 set because already copied when copying the BinEntry's of the header
597 * Test/TestAllReadCompareDicom.cxx : remove warnings
599 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
600 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
601 Two problems appear when doing it :
602 - with the gdcmFile : when the GetImageData method is called, the pixels
603 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
604 data (pixels). And each structure destruct the data when it's
605 destructed. So we have two destructions for the same data. To solve it,
606 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
607 data or not. If it doesn't own data, then they will not destroyed by
609 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
610 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
611 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
612 create a double destruction of the same DocEntry's. So, to solve it,
613 the TagHT is simply cleared and the DicomDir* elements are destroyed.
614 * TODO : add an entry concerning memory leaks in the DicomDir
616 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
617 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
618 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
621 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
622 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
623 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
624 after it have been deleted
626 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
627 * FIX: src/* fix the doxygen warnings.
628 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
629 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
630 was erroneously defined with a size of 15 instead of 16. [many thanks
631 to Jean Michel Rouet for pointing out this bug].
633 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
634 1. Finish merging JMR patch for writting DICOM from scratch
635 2. Fix -hopefully- bug with MONOCHROME and space vs null character
636 3. Use const ref when possible
637 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
638 5. A few more comments
639 6. CreateUniqueUID can now be called without parameter"
641 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
642 * ENH: Slightly bigger patch:
643 1. Getting toward full integration of JMR patch for writting dicom from scratch
644 2. Update Test to test part of this patch: CreateUniqueUID
645 3. File was not close properly in gdcmDict
646 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
647 5. Use of const ref instead of copy (speed issue)
648 6. Remove temporary (duplicate) string in TranslateToKey
649 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
650 8. Do not repeat virtual in subclasses
651 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
653 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
654 * Apply first patch toward better string comparison when dealing with broken
655 DICOM files. Essentially the string could be padded with a space instead
656 of a null character as defined by standard
658 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
659 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
660 because never used... and in the same time, that's remove some memory leaks
662 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
663 * src/gdcmFile.cxx : now delete the PixelConvert instance.
664 * In examples and tests : change the type of image data variables from void*
665 to uint8_t*. Remmove all delete on image data variables
667 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
668 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
669 Verify the file pointer value before open the file, and if it's not null,
670 a verbose message is generated.
671 Close correctly the file when the file isn't considered dicom-like. The
672 correctly close is a call to CloseFile.
673 When closing the file pointer, test if its not null to close the file.
674 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
675 file. For an uncompressed image, the copied data correspond in the least
676 case to the image size (calculated) or the image size specified in the
677 header. A verbose is generated if these two size mismatch
679 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
680 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
681 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
682 break under windows (with msvc6 compilation).
684 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
685 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
686 compiling with MSVC6)
688 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
689 * Bugs fix for the Windows build with VC6
690 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
691 needed (only for projects required VTK). If the VTK is included in all
692 projects, there is conflicts with the jpeg lib of vtk when compiling the
693 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
694 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
695 when compiling the gdcm_wrap.cxx file (created by the compilation of the
697 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
698 (like it's already made for the cout use). Otherwise, conflict with the
701 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
702 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
704 - comments on the DicomDir::Method related usage added.
705 - now that we use the namespace gdcm, a lot of internal classes do
706 NOT need to be wrapped anymore.
707 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
708 DicomDir::Method) new example added.
710 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
711 * Improve string manipulation. I now inforce the notion of 'DicomString'
712 A DicomString can contain as many \0 as they want
713 and it is *always* of even length.
714 We only support odd length for very rare case.
715 And in the near future this should be removed.
717 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
718 * /binary_write/ gdcm source. Now even on big endian we are writting
719 little endian. This should -heopfully- fix some tests
721 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
722 * Now the dictionary is compiled into gdcm lib. This is a default
723 behavior, thus any dic file specified is picked before failback to
724 the one comiled into lib
726 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
727 * Change internals for gdcmDict. Don't use any 'new' any more.
728 This should definitely solve any leak problem, and we should be
729 as fast as before, as long as don't modify too much the dictionary.
731 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
732 * STYLE: ivars should start with a capital letter.
733 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
734 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
736 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
737 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
738 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
739 new 2004 dictionaries added (thanks to JPR).
740 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
741 * CLEANUP_ROUND (15) for gdcmPixelConvert
742 - RLEFrame::NumberFragments is now of type unsigned int
743 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
744 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
747 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
748 * Initial work in gathering all transfer syntax accessors. clearly
749 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
750 ivars, but only one transfersyntax (class) ivar with equivalent method on
753 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
754 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
755 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
756 discussed (plus I didn't like having a 2000 lines patch not commited)
758 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
759 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
760 * CLEANUP_ROUND (14) for gdcmPixelConvert
761 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
762 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
763 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
765 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
766 anymore and hence avoids storing a copy of PixelConvert::Decompressed
767 into File::Pixel_Data.
769 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
770 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
771 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
772 * CLEANUP_ROUND (13) for gdcmPixelConvert
773 Substituted File::ParsePixelData() with PixelConvert::Print() new
775 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
776 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
777 method to those classes.
778 - src/gdcmFile.[cxx|h]:
779 -- Added a ::Print() method.
780 -- PixelConverter is now a reference instead of a member.
781 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
782 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
784 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
785 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
786 collaboration diagram and inheritance diagram should be generated with
788 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
789 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
790 pointlessly wrapped (see
791 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
792 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
793 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
794 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
795 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
796 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
797 -- File::Initialise: PixelConverter setup moved away to
798 PixelConverter::GrabInformationsFromHeader()
799 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
800 interpretation moved away to PixelConverter::BuildRGBImage()
802 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
803 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
804 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
806 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
807 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
808 displayed on Win32 when a brutal abort() occurs (because of uncatched
809 exception). See TODO new entry of this commit for more on this.
810 * TODO added new entry.
811 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
812 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
813 - HandleColor is no longer called from gdcmFile.cxx
814 - gdcmPixelConvert.cxx clean up on method arguments and internal
815 variable names for semantical coherence.
817 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
818 * Finished lossless transition, not only do we now read all lossless jpeg
819 images, without the need of the Cornwell lib, but we do read them properly now
820 * To reduce code (well to avoid code duplication), I defined a common place
821 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
822 redefine symbols. This is not perfect but this the best solution I found for a
823 compilation time jpeg option.
825 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
826 * Update jpeg ijg lib to support lossless jpeg implementation
827 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
829 * Also added a special copyright for dcmtk since we use their bugfixes.
832 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
833 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
834 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
835 matters, as stated in warning note at begining of %include section).
836 * src/gdcmDicomDir*.[cxx|h]: coding style
837 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
838 * src/gdcmJpeg8.cxx: doxygen fix.
839 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
840 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
841 from File:: to PixelConvert::.
843 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
844 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
845 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
846 - more code moved away from File:: to PixelConvert::
847 - fat setup of PixelConverter set in place in File::Initialise.
849 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
850 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
851 namespace at the file system level. So now you should convert your examples
853 gdcmHeader -> gdcm::Header
854 It would be nice if people keep in mind to no open the namespace, since it
855 allows compilation on broken plateform which were defining common symbol in
856 the standart namespace (like LP, Unknown ...)
858 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
859 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
860 The JPEG fragments are now parsed at the same stage than the RLE
861 information. All code related to JPEG is now in gdcmPixelConvert:
862 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
863 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
864 export a gdcmFile:: method. Those are simply global functions
865 (for the time being this is better than having them attach to
866 either gdcmFile:: or gdcmPixelConvert::).
867 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
868 and stores the result in a gdcmJPEGFragmentsInfo.
869 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
870 code (among other stuff) moved away from gdcmFile:; to
873 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
874 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
875 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
876 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
877 clean up of RLE related code.
878 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
879 - src/gdcmRLE.cxx removed
880 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
881 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
882 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
883 * CLEANUP_ROUND (9) for gdcmPixelConvert
884 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
885 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
886 away from gdcmFile:: to gdcmPixelConvert::.
888 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
889 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
890 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
891 This is because Parse7Fe0 used to parse the pixels to compute the
892 length. This task was passed over to FindDocEntryLengthOB() a long
893 time ago, EXCEPT I had forgotten the OW case...
894 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
895 we just recylce the code for parsing RLE fragments and computing
897 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
898 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
899 with the retired Parse7Fe0().
900 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
901 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
903 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
904 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
905 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
906 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
907 - src/CMakeLists.txt: alphabetic order reodering + new entries.
908 * CLEANUP_ROUND (4) for gdcmPixelConvert
909 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
910 to return an unused length.
912 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
913 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
914 this should be cleanner from the plane view. The iostream are erally a pain
915 to use to do simple stuff.
917 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
918 * Redo the compilation of the ijg jpeg library. Now only one source is
919 necesseray. No need to rename file by hand what so ever. CMake handle the
920 copying of the file within different directory, configure header file to
921 modify some symbol. The only addition made to ijg wasd a mangle table so
922 that symbol are different whether we are within 8bits or 12bits.
924 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
925 * Added documentation of vtkgdcmReader on Website:
926 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
927 with it's binary name).
928 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
929 the Website to be more complete.
930 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
931 doxygenated documentation.
932 - Doc/DoxyVtkGdcmReaderExamples.txt added
933 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
934 DoxyVtkGdmReaderExamples.html )
935 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
936 * CLEANUP_ROUND (3) for gdcmPixelConvert
937 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
939 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
940 * CLEANUP_ROUND (2) for gdcmPixelConvert
941 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
943 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
944 * CLEANUP_ROUND for gdcmPixelConvert:
945 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
946 - src/gdcmPixelStuff[h|cxx] removed
947 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
948 - src/CMakeLists.txt changed accordingly
950 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
951 gdcmVersion.py moved to newly created ATTIC related
952 gdcmPython/SetupOldies/ directory.
953 * Autotools clean up:
954 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
955 - autogen.sh configure.in acinclude.m4 python.m4 removed
957 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
958 * src/*.cxx *.h Reference to License.htm fixed to License.html.
959 * Doc/CMakeLists.txt, doxygen.config.in: fix.
960 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
962 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * TODO updated with Mathieu suggestions. I proposed a template for
964 describing TODO entries and used it for new entries.
965 * Added Doc/Website/CodingStyle.html, Developpers.html,
966 DeveloppersPython.html, GdcmDataCvs.html and
967 DownloadVersion0_1.html, DownloadVersion0_3.html.
968 * Some Doc/*.txt Doxygen files (which do not really concern the
969 documentation itself, but the website) moved to html and
970 placed in directory Doc/Website:
971 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
972 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
973 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
974 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
975 * CMakeLists.txt changed accordingly.
976 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
977 DeveloppersPython.html
978 * INSTALL nows refers to Doc/Website/Installation.html
980 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
981 * Added Doc/Website directory, that contains a first raw version
984 2004-09-23 Jean-Pierre Roux
985 * FIX In order not to be poluted any longer by casting problems,
986 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
987 we can now delete[] it safely
988 * VoidArea is now called BinArea (less confusing name),
989 and all the methods called ...VoidArea... are now ... BinArea...
990 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
992 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
993 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
994 clear) TagHT, which is an inherited member of gdcmElementSet. It is
995 up to the destructor of gdcmElementSet to clean up TagHt and it's
998 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
999 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1000 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1002 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1003 * ENH: added some utility method that builds a flat dictionary
1004 holding all the Dicom entries contained in the recursive structure
1005 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1006 an example of usage.
1007 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1008 BuildFlatHashTable() that build a flat dictionary.
1009 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1010 gdcmDocument is now a friend of gdcmElementSet.
1011 - src/gdcmElementSet.cxx: clean up.
1012 - Example/FlatHashTablePrint.cxx added.
1013 - Example/CmakeLists.txt changed accordingly
1015 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1016 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1017 moved away from gdcmDocEntrySet (since this class is an abstract class
1018 acting like an interface). SQDepthLevel and BaseTagKey are now
1020 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1021 and associated accessors. Doxygenation of the class.
1022 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1024 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1025 Use SQDepthLevel accessor instead. ::Print() adapted.
1026 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1027 - src/gdcmDocument.cxx changed accordingly.
1029 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1030 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1031 - The following is the doxygen comment of the typedef declaration
1032 of gdcmTagKey in src/gdcmCommon.h:
1033 gdcmTagKey is made to old an "universal" (as in URL, Universal
1034 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1035 A dicom tag always has a group and an element, but a set of tags
1036 embeded in various (optionally nested) sequences and sharing
1037 the same group and element all share the same (group, element)
1038 "identifier". Hence the (group, element) cannot be used as an
1039 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1040 In order to construct a proper tag identifier (i.e. a key) we
1041 consider the following definition of a TagKey:
1042 - let Group, Element be the string representation of the
1043 group and element dicom tag members,
1044 - let ItemNumber be the string representation of the integer
1045 index of the considered item number of a sequence,
1046 Let the key of a tag embeded in a sequence, noted SeqTag, be
1048 /ItemNumber#Group|Element
1049 where "/", "#" and "|" are characters acting as separators.
1050 Then the general form of a gdcmTagKey is given by:
1051 Group|Element<SeqTag>
1052 where <SeqTag> means NO or many instances of SeqTag.
1053 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1056 but the gdcmTagKey of a tag "embeded" is the first item of
1057 a sequence, itself nested in the third item of a sequence is the
1059 0004|1220/2#0008|0082/0#0008|0090
1060 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1061 order to hold the new sequence compatible key. Previously, the
1062 GetKey() method would look in the underlying gdcmDictEntry.
1063 - src/gdcmDocEntry.cxx:
1064 -- constructor now copies the underlying DictEntry key, in the local
1066 -- ::Print: displays the member Key, instead of the (group, element).
1067 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1068 - src/gdcmDocEntrySet.h:xi
1069 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1070 -- now has a new BaseTagKey member.
1072 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1073 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1075 This poses the problem with the semantics of the following lines
1076 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1077 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1078 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1079 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1080 to the long FIXME note for what the problem is. Nevertheless in
1081 order to get things working the dicom dictionary was altered !
1082 Please fix things urgently...
1083 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1084 information), see above note on moving the member VoidArea. Nevertheless
1085 the following entries previously correctly set as US are now inproperly
1087 0028 1201 OW IMG Red Palette Color Lookup Table Data
1088 0028 1202 OW IMG Green Palette Color Lookup Table Data
1089 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1090 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1091 of gdcmDocEntry moved to gdcmSeqEntry.
1092 * src/gdcmSeqEntry.cxx: STYLE.
1094 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1095 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1097 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1098 * gdcmPython/testSuite.py: all the test suite in python is now moved
1099 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1100 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1101 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1103 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1104 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1105 to avoid inclusion recursion until STL is reached.
1106 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1107 mecanism. errno.h is not included in gdcm anymore.
1108 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1109 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1111 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1112 gdcmData/TestAllEntryVerifyReference.txt
1113 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1114 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1115 exception_on_error parameter.
1116 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1117 - vtk/vtkGdcmReader.cxx changed accordingly,
1118 - Example/*.cxx and Test/*.cxx changed accordingly.
1120 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1121 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1122 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1123 enable_sequences removed from gdcmHeader constructor and dependencies.
1124 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1125 * gdcmPython/demo/PrintHeader.py: dummy fix.
1126 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1127 skip_shadow removed from gdcmHeader constructor and dependencies.
1128 * Example/*.cxx and Test/*.cxx changed accordingly.
1130 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1131 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1132 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1134 2004-07-21 Jean-Pierre Roux
1135 * FIX Now, Parsing and Printing a DICOMDIR do work!
1136 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1138 2004-07-20 Jean-Pierre Roux
1139 * FIX Some brain damaged headers have Zero-Lenght fields
1140 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1142 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1143 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1144 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1145 variable (instance of gdcmDebug) by a definition macro, and the instance
1146 is now in static in the gdcmDebug class
1147 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1148 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1150 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1151 * WARNING: ctest now depends more tightly on gdcmData. You should
1152 check out gdcmData properly for things to run smoothly...
1153 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1154 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1155 we need the pixels not be loaded in order to use the ValEntry
1156 that displays position and size).
1157 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1158 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1159 be deprecated. If you have any doubts about the advantages of a
1160 modern scripting language (read Python) versus grass root C++ (i.e.
1161 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1162 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1163 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1164 Anyhow, consider documenting the gdcmData images in
1165 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1167 * Test/CMakeLists.txt:
1168 - now uses TestAllEntryVerify.cxx
1169 - specific comments on oldACR00001.ima (now renamed in gdcmData
1170 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1171 gdcmData/TestAllEntryVerifyReference.txt
1174 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1175 * src/*.[h|cxx] : typedef clean up
1176 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1177 - TagKey renamed to gdcmTagKey (for external usage)
1178 - VRKey renamed to gdcmVRKey (for external usage)
1179 - removal of typedef duplication.
1180 - Removed all unecessary inline keyword from class inline definitions.
1181 - Some method|function(void) declarations replaced with method|function().
1182 * src/jpeg/libijg12/jdhuff12.c:
1183 - printf polluting ctest removed.
1184 - TAB removal for comminting
1186 - TestAllReadCompareDicom.cxx: added a test that compares all the
1187 images in gdcmDataImages.h with corresponding images in
1188 gdcmData/BaselineDicom/. When baseline images are not present
1189 this test creates them.
1190 Note: we need to validate each reference image, but before that
1191 I'd like to rename them with a more explicit name...
1192 - CMakeLists.txt: changed accordingly.
1193 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1194 including each header needed).
1196 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1197 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1198 test suite to the Example directory. Are concerned:
1203 - TestWriteSimple.cxx
1204 * Test/CMakeLists.txt: added some comments on reasons for black listing
1205 image gdcmData/oldACR00001.ima
1207 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1208 * Test/CmakeList.txt: removed the following from black list (to be coherent
1209 with removal from gdcmData):
1210 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1211 - gdcm-MR-PHILIPS-16.dcm
1213 Added the following because after last cvs update, they cause
1214 ctest -R TestReadWriteReadCompare
1216 - gdcm-MR-SIEMENS-16-1.acr
1218 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1219 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1220 new comments in this file) we temporarily (sigh) move to a weaker
1222 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1223 we don't need to black list the following images anymore:
1224 - 8BitsUncompressedColor.dcm
1226 - US-PAL-8-10x-echo.dcm
1227 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1228 fixes and the beautified code ;-)
1229 This fixes the bug introduced in version 1.42 (when beautifying)
1230 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1231 Note: ctest was blind to this bug (this means we need to still
1232 improve the test suite). The bug could be detected by using
1233 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1235 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1236 and by displaying the (garbage) produced file temp.XDCM...
1238 2004-06-29 Jean-Pierre Roux
1239 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1240 - replace by uggly but working old code :-(
1241 A lot of things should be OK again.
1242 It's really urgent to have a test suite that *tests*,
1243 to prevent Frog's beautifying sessions to break all the stuff
1244 (twice, withing a fortnigh ...)
1246 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1247 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1248 redundancy) to added Test/TestReadWriteReadCompare.cxx
1249 * Test/CmakeList.txt: because the compare test of
1250 Test/TestReadWriteReadCompare.cxx fails, the following images are
1251 black listed: - 8BitsUncompressedColor.dcm
1253 - US-PAL-8-10x-echo.dcm
1254 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1255 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1256 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1257 and ad-hoc kludge. This kludge is now removed, and on encountering
1258 such an image (OB field brain damaged) we set errno. Then in
1259 ::FindDocLength() we "fix" the length as being ALL what remains
1260 in the file (until EOF). We then proceed, hoping for the best...
1261 This fixes a SegFault in ShowDicom when trying to write such an
1263 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1264 (because TestWriteRead breaks on it, after a non conformal commit?).
1265 ctest now runs properly, except for MakeDicomDir (which was always
1266 broken) and the Python related stuff (still not fixed).
1268 2004-06-24 Jean-Pierre Roux
1269 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1270 FIX : Test/TestReadWrite now iterates on all the file names
1271 (instead of infinite loop)
1272 ENH : Test/TestWriteRead now iterates on all the file names
1274 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1275 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1277 2004-06-24 Jean-Pierre Roux
1278 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1279 when SamplesPerPixel =3
1280 - now Write is no longer confused by
1281 'BitsAllocated = 12" and 'BitsStored=12"
1282 - "UN" value representation Elements are now written correctly
1283 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1284 ENH : - now gdcmHeader has its own Write methods
1285 (in order to split the job that has not to be done
1288 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1289 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1290 loop on the same image until memory went out.
1291 Note: this means we still have gobs of memory loss in PrintDocument
1292 * src/gdcmDocument.cxx: fixes problem on parsing on file
1293 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1295 2004-06-24 Jean-Pierre Roux
1296 FIX : Write - All the Sequences and Sequence Item are now written
1297 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1298 is added a the end, when necessary.
1299 - A lot of brain-damaged images, that were read correctly are
1300 now written correctly
1301 - length compatible BinEntry are now loaded correctly
1302 (even for odd groups)
1303 Note : only Explicit Value Representation was checked.
1304 (question : is implicit VR really necessary for gdcm ?)
1306 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1307 * DEVELOPPER: added a proposition of coding style.
1308 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1311 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1312 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1313 Use the gdcmDocEntry::Print() and Write() instead.
1314 * src/gdcmDocument.cxx: bug fix.
1316 2004-06-22 Jean-Pierre Roux
1317 FIX : gdcmDocument.cxx
1318 - Now we do recognize the JpegLossLess format (there was a misstyping in
1319 code 'beautyfication' :-(
1320 - Now we automaticaticaly load the Luts, if any
1322 2004-06-22 Jean-Pierre Roux
1323 In order : to write Sequences, whatever their imbrication level,
1324 : to allow user to create his own Sequences
1325 a lot of modif where necessary (adding, moving, or virtualising methods)
1327 WARNING : save your own sources *before* cvs up !
1330 ADD virtual void Write(FILE *fp, FileType filetype);
1333 ADD virtual void Write(FILE *fp, FileType filetype);
1334 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1337 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1338 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1339 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1340 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1341 ADD std::string GetEntryByName(TagName name);
1342 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1344 std::string vr = "unkn",
1345 std::string fourth = "unkn",
1346 std::string name = "unkn");
1347 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1348 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1349 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1350 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1351 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1352 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1353 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1354 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1357 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1358 ADD virtual std::string GetEntryByName (TagName tagName);
1359 ADD virtual std::string GetEntryVRByName (TagName tagName);
1360 REM virtual bool Write(FILE *, FileType);
1361 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1362 FILE *_fp, FileType type);
1363 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1364 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1365 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1366 REM virtual std::string GetEntryByName (std::string tagName);
1367 REM virtual std::string GetEntryVRByName (std::string tagName);
1368 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1369 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1370 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1372 std::string vr = "unkn",
1373 std::string fourth = "unkn",
1374 std::string name = "unkn");
1375 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1376 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1377 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1378 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1381 ADD virtual void Write(FILE *fp, FileType filetype);
1384 ADD virtual void Write(FILE *fp,FileType filetype);
1387 ADD virtual void Write(FILE *fp, FileType filetype);
1388 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1389 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1390 REM std::string GetEntryByName(TagName name);
1393 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1395 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1396 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1397 The default constructor invoked by the line
1398 gdcmHeader *f1 = new gdcmHeader( header );
1399 was gdcmHeader::gdcmHeader(bool) instead of the expected
1400 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1401 Hence the parsing wasn't executed... See also below.
1402 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1403 as explicit constructor didn't do the trick to fix the above problem.
1404 Could anyone explain why ?
1405 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1406 properly calls gdcmValEntry::Print() (that was weed out from
1407 code related to gdcmBinEntry).
1409 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1410 * In order to fix memory leaks:
1411 - Test/TestWriteSimple.cxx: added cleaning of free store through
1413 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1414 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1415 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1416 (through the call to ::AddDicomDirMeta()) or the destructor
1417 would crash when deleting uninitialized ::metaElems].
1418 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1419 - src/gdcmDocument.cxx:
1420 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1421 from dynamic stores.
1422 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1423 was causing memory leaks.
1424 - src/gdcmSQItem.cxx:
1425 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1426 cleanly handled with polymophism: sorry but my milage is low).
1427 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1428 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1429 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1430 This avoids SegFaulting.
1431 - src/gdcmSQItem.h: coding style.
1433 - Test/TestWriteSimple still severely sucks. The output image content
1434 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1435 damaged when displayed with vtkgdcmViewer.
1436 - on memory leaks: TestWriteSimple leaks really less (see entry
1437 of 2004-06-18 in Changelog file for the call to valgrind).
1438 - on segfaults: ctest now passes all the tests but one (no more
1440 * Erroneous leading white fix:
1441 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1442 white[s] (as opposed to from >> xxx, that removes it [them].
1443 - src/gdcmTS.cxx: ditto.
1444 - gdcmPython/testSuite.py: dirty related kludge removed.
1445 * src/*: remaining references to gdcmParser removed.
1446 * src/*[cxx|h]: added copy[way]left header.
1449 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1450 * In order to fix writing of dicom files:
1451 - Test/TestWriteSimple.cxx: a simpler example of writing.
1452 - Test/CMakeLists.txt changed accordingly.
1453 - src/gdcmDocument.cxx:
1454 -- The destructor now recursilvely removes potential sequences.
1455 -- Bug fix in ::IsJPEG2000()
1456 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1457 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1459 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1460 to only declared) and build on top of
1461 ::GetDocEntryByNumber(guint16, guint16).
1462 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1463 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1464 for usage in destructor and treatement of promotion in
1465 ::ReplaceOrCreateByNumber().
1466 - src/gdcmSQItem.cxx: destructor should better handle his job.
1467 Test/TestWriteSimple now runs (or at least it DOES something).
1468 * We can now start hutting memory links. A good starting point is:
1469 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1470 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1471 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1473 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1474 * Valgrind note: after Mathieu Malaterre teached me how to read
1475 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1477 Using gcc, you can force the STL to use malloc and to free memory as
1478 soon as possible by globally disabling memory caching.
1479 With 3.2.2 and later, you should export the environment variable
1480 GLIBCPP_FORCE_NEW before running your program.
1481 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1482 simply vanish (it is still not clear to me, whether this means that
1483 STL std::string leaks or if valgrind believes it leaks...).
1484 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1485 running bin/gdcmTests makeDicomDir):
1486 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1487 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1489 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1490 SegFaulting (I drowned in DicomDir related code when trying to
1491 understand why the list is empty...).
1492 * src/gdcmDocument.h: first BSD license header try.
1493 * Doc/License.txt added.
1495 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1496 * src/gdcmDocument.[h|cxx]:
1497 - Clean up of the Transfer related predicates. They are now all based
1498 on new method isGivenTransferSyntax, that (should) handle properly
1499 the padding problem.
1500 - general clean up, simplification, and coding style.
1501 - Specific clean up of Parse7FE0() (umproperly named actually).
1502 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1504 2004-06-14 Jean-Pierre Roux
1506 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1507 - fix the display of SQItem ordinal number
1508 - add the GetSQItemByOrdinalNumber method
1509 - remove some useless never written private methods
1511 2004-06-14 Jean-Pierre Roux
1513 - adding a constructor taking a gdcmDocEntry as an input param
1514 - ReplaceOrCreateByNumber now returns :
1515 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1516 a gdcmValEntry * if a string value is passed as a param
1518 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1519 according to the param type (no longer sets a gdcmDocEntry)
1520 - GetValEntryByNumber, GetBinEntryByNumber added
1521 - NewValEntryByNumber and NewBinEntryByNumber added
1523 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1525 - GetSQItemNumber and SetSQItemNumber added, to provide
1526 a (relative) Item identier inside a given Sequence
1527 \warning : some pb remaining around this number
1529 - AddEntry now takes the Item Number as a param
1531 - adding a constructor taking a gdcmDocEntry as an input param
1533 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1534 * Memory leak hunt with the following command:
1535 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1536 --show-reachable=yes gdcmTests PrintDocument
1537 It looks like many (all?) leaks are due to the STL (or a bad usage
1538 of the STL. The lines producing the leaks now have a comment with
1539 a "MEMORY LEAK" tag: you can retrieve them with
1540 grep "MEMORY LEAK" src/*
1541 Here are two typical examples which I can't help fixing:
1546 char * test = "babo";
1547 name = test; //// <--- valgrind detects 960 bytes lost in
1548 //// call to std::string::operator=(char const*)
1549 name.clear(); //// Doesn't help !
1557 std::cout << "Type a bunch of characters followed by RETURN: ";
1558 getline(std::cin, line); //// <--- valgrind dectects a loss
1559 //// of 1320 bytes in call to
1560 /// std::basic_istream<>& std::getline<>
1566 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1567 * src/gdcmHeader.[cxx|h]:
1568 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1569 and related, moved away to gdcmDocument.
1570 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1571 the corresponding protected accessors of inherited class
1572 gdcmDocument, removed ! As a consequence gdcmFile had to be
1573 declared friend of class gdcmDocument (see below).
1574 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1575 - Clean up of undefined or unused methods.
1576 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1577 account the changes to gdcmHeader.h).
1578 * src/gdcmDocument.h:
1579 - gdcmFile is now a friend class (in order to take into account the
1580 changes to gdcmHeader.h).
1581 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1582 (see changes to gdcmHeader.h).
1583 - Accessors (reading on the form GetEntry*) are now public.
1584 - Clean up of undefined or unused methods.
1585 * src/gdcmDocument.cxx:
1586 - adaptation to changes to gdcmDocument.h
1587 - ::OpenFile now writes a verbose message when file cannot be opened.
1588 - some std::string properly set to VRKey
1589 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1590 references to gdcmDocument.
1591 * Test/TestFindTags.cxx: changed accordingly to above changes.
1592 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1593 cvs repository gdcmData.
1595 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1596 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1597 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1598 conflicts with gdcmValEntry::voidArea.
1599 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1600 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1601 Value representation between StringRepresentable and BinaryRepresentable.
1602 * src/gdcmDocument.cxx:
1603 - method ParseDES: proper indentation restored and usage of
1604 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1605 - method LoadDocEntry: the fingerprint left in the SetValue() of
1606 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1607 removed. Reverting to previous code segment with the proper
1608 dynamic_cast< gdcmValEntry* >.
1609 Note: this was (partially) breaking the python test suite
1610 (gdcmPython/testSuite.py) that made usage of the above
1611 fingerprint to check presence of "Pixel Data".
1612 * src/gdcmDocEntry.h: coding style.
1613 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1614 now taken into account.
1615 * gdcmPython/gdcm.i: adaptation to the new internal representation
1616 of gdcm (exit gdcmParser, hello gdcmDocument).
1617 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1619 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1620 anymore, but instead prints the loaded Python dictionary.
1621 * .... alas, the python testSuite is still broken.
1623 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1624 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1626 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1627 * src/gdcmUtil.h : export methods
1629 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1630 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1632 * Initial addition of automatic python testing
1633 * Initial addition of automatic image comparison
1635 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1636 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1637 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1639 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1640 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1641 * Test/ShowDicom.cxx : bug fix for msvc compilation
1642 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1644 2004-05-04 Jean-Pierre Roux
1645 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1646 new concepts (and new classes) :
1647 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1648 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1649 - Sequence Doc Entries (gdcmSeqEntries)
1650 a Sequence is composed of Items.
1651 Each item is a set of Doc Entries (this is recursive)
1652 The non uniqueness of the 'Dicom tag' is due to this recursivity
1653 (never taken into account)
1654 Our unability to add a new 'entry' in the header
1655 at the proper location (neither in the H-Table (map or multimap),
1656 nor in the Chained List is also due to this recursivity.
1657 Don't try, right now, to use/modify/compile these new sources :
1658 nothing is finished.
1659 We just commit all the stuff, 'as is', in order not to loose it.
1661 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1662 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1664 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1665 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1666 file prefix (SetFilePrefix)
1668 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1669 * Add a new test: ShowDicom, for now this is just the c++ version of
1670 checkRead.sh, later it will be able to compare the image read against a
1672 * Replace the DEBUG on the stack with a global entry in cmake interface:
1673 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1675 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1676 * Add an example subdir, with a real example on how to read + write a
1679 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1680 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1681 * Doc/CMakeLists.txt: the main page is now properly differentiated
1682 between the developper and user version.
1683 * Doc/doxygen.config.in: dropped search related obsolete flags
1684 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1686 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1687 * DEVELOPPER: added some helpfull comments for compile/test/install
1690 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1691 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1692 src directory, now generated in the build dir.
1693 2. Tests as mentionned smarter
1695 4. Add a new method in gdcmDict that return the PubDict by name
1696 this is interesting for 3rd party lib like ITK,
1697 where we could set the institution name / patient name...
1699 * ENH: 1. Now the test suite is working for real
1700 2. All binaries are now output in the gdcm-bin directory
1701 (this was not true before)
1703 2004-04-28 Jean-Pierre Roux
1704 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1705 SeQuence indented printing of Dicom Header.
1706 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1707 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1708 Computation of SQDepthLevel is now part of gdcmHeader constructor
1709 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1710 tree-like structure of a Dicom Header.
1711 * FIX Test code cleaning
1713 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1714 * ENH: Adding automatic testing
1715 1. Need a DartConfig.cmake to submit to public
1716 2. Add a test driver gdcmTest.cxx
1717 3. gdcmTestMain, an helper for the main test driver gdcmTest
1718 4. Files in Test don't have a main anymore, this becomes interesting
1719 when we add more and more tests, thus dsw don't have to load
1721 * ENH: Adding a GDCM_DATA_ROOT for testing
1722 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1723 one file instead of seven + some small cleanup
1725 2004-04-22 Jean-Pierre Roux
1726 * ENH Minor changes to the Print() methods.
1727 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1728 Header printing. Example given with :
1729 > PrintHeader fileName 2 new
1730 (SQ based tree-like structure still to be done for the Header ...)
1732 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1733 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1734 1. I have added some unsigned where needed
1735 2. Some function parameter not used -> (void)
1736 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1737 4. g++ don't like character '\' in comment
1738 5. #define jpeg_create_decompress jCreaDecompress
1739 this really need to be fixed
1740 6. virtualize destructor of gdcmObject ... leakage
1741 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1742 this also really need to be fixed
1743 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1744 remove compression file
1745 (as we only do decompression, right ?)
1746 * ENH: Change malloc/calloc/free with c++ equivalent
1748 2004-04-21 Jean-Pierre Roux
1749 * FIX gdcmHeaderHelper::GetXSpacing
1750 when a single value is found (bug ?), xpacing is now
1751 defaulted to yspacing
1753 2004-04-19 Jean-Pierre Roux
1754 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1755 * ENH add parameters :
1756 bool exception_on_error = false,
1757 bool enable_sequences = false,
1758 bool ignore_shadow = false
1759 to the gdcmFile constructors to be full gdcmParser compliant
1760 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1761 to allow reading of PAPYRUS 3.0 files
1763 2004-04-06 Jean-Pierre Roux
1764 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1766 2004-04-02 Jean-Pierre Roux
1767 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1768 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1769 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1771 2004-03-30 Jean-Pierre Roux
1772 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1773 for ACR file, written out as DICOM files (hope so...)
1775 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1776 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1777 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1778 moved to base class gdcmParser and only the specialisation is kept
1780 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1781 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1782 already does the job.
1783 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1784 (to be consistent with gdcmParser::WriteEntries).
1786 2004-03-30 Benoit Regrain
1787 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1788 upate of the object's instance. It's passed to 2 in the unfavorable
1789 case : one in the ExecuteInformation, one in the ExecuteData
1791 2004-03-29 Jean-Pierre Roux
1792 * ENH : Check on file type to be written moved
1793 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1794 * FIX : gdcmObject::ResetBoundaries now stops properly
1795 when end-of-list is reached
1796 : gdcmVersion modified (as Benoit Regrain asked)
1798 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1799 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1800 * src/gdcmUtil.cxx: added forgotten iostream include.
1801 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1802 equivalent to ExplicitVR in existing code).
1804 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1805 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1806 now contains all the gdcmGlobal related code.
1807 * minor coding style and doxygenation changes.
1809 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1810 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1811 now contains all the Debug related code.
1812 * minor clean-up of includes in src/*.cxx
1813 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1814 CreateCleanString) removed.
1815 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1816 * Doc/DoxyMainPageUser.txt added.
1817 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1818 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1819 src/gdcmDirList.cxx)
1821 2004-03-24 Jean-Pierre Roux
1822 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1824 2004-03-23 Jean-Pierre Roux
1825 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1826 big endian made volumes
1827 * ENH Now gdcmParser constructor and destructor are protected to forbid
1828 end user to instanciate class gdcmParser
1829 (only gdcmHeader and gdcmDicomDir are meaningfull)
1831 2004-03-22 Benoit Regrain
1832 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1833 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1834 gdcmSerie to gdcmDicomDirSerie
1836 2004-03-19 Jean-Pierre Roux
1837 * ENH Now the tree-like structure describing a DICOMDIR comming from
1838 an already existing DICOMDIR file is consistent with
1839 the home-made tree-like structure build ex-nihilo
1840 or build from the files held (recursively) in a Directory
1841 functions gdcmDicomDir::CheckBoundaries()
1842 gdcmObject::SetBoundaries() added
1844 2004-03-17 Jean-Pierre Roux
1845 * REM (Eric Boix bug) : removal of meaningless
1846 gdcmDicomDirImage::NewImage function.
1847 * FIX now file names and directory name are written properly in the
1849 * FIX now gdcmDicomDir constructor may be call without any trick
1852 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1853 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1854 of gdcmDicomDirImage::NewImage as empty function.
1856 2004-02-28 Jean-Pierre Roux
1857 * ENH add gdcmDicomDir:NewPatient
1858 add gdcmDicomDirPatient:NewStudy
1859 add gdcmDicomDirStudy:NewSerie
1860 add gdcmDicomDirSerie:NewImage
1861 to allow making gdcDicomDir object.
1862 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1863 (as opposite to the gdcmHeader chained list)
1865 2004-02-11 Benoit Regrain
1866 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1867 when using from python
1869 2004-02-10 Benoit Regrain
1870 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1871 * FIX : in gdcmDicomDir when the directory is empty
1872 * ENH : add callback and methods to get the progression of dicomDir
1875 2004-02-06 Jean-Pierre Roux
1876 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1877 - GDCM_META added to gdcmDicomDirType
1878 - class gdcmMeta created
1879 * ENH : - A brief summary is now displayed at the beginning of
1880 'testDicomDir' to help disaster magnitude estimation
1881 * REM : Now useless Test/explDICOMDIR.cxx
1883 2004-02-05 Benoit Regrain
1884 * ENH : add methods in gdcmObject to get the hash table or the list of
1886 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1887 * FIX : wrapping python for TagHeaderEntryHT
1889 2004-02-04 Benoit Regrain
1890 * FIX : even length for some strings when writting the dicom dir
1891 * FIX : sort the images in the dicom dir
1892 * FIX : Bug fix for python use of dicom dir
1893 * ADD : a python demo
1895 2004-02-04 Jean-Pierre Roux
1896 * FIX : Final solution (?) for icone embedded images
1897 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1898 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1899 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1900 gdcmData/gdcm-MR-SIEMENS-16.acr1
1901 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1902 to make full checking easier
1904 2004-02-04 Benoit Regrain
1905 * FIX : WriteEntries : coding style & logic in parameters
1906 * FIX : Set the elements to create the DicomDir in a dictionary file
1908 2004-02-03 Benoit Regrain
1909 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1910 * gdcmDicomDir : add the load of directory
1911 * Bug fix and print add-on
1913 2004-02-03 Jean-Pierre Roux
1914 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1915 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1916 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1917 * FIX gdcmParser.cxx : 'group length' elements are now considered
1918 as integers, even for shadow groups, when file is Implicit VR
1920 2004-02-02 Jean-Pierre Roux
1921 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1923 of the last synonym :-(
1924 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1926 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1927 * FIX taking into account the possible 7fe0,0010 multiplicity
1928 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1929 to allow removal of references to 7fe0,0010, to deal with
1930 ACR-NEMA images, when 0028,0200 is meaningfull
1932 2004-01-31 Jean-Pierre Roux
1933 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1934 no longer writes 'Un' on disk
1935 * FIX SQ elements with actual length are now dealt with corectly
1936 * FIX gdcmFile::WriteBase make the difference, for color images, between
1937 the length (for Palette expanded images)
1938 and Raw Length (non expanded image + Palette)
1939 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1940 (that broke Write). Replaced by UL.
1941 Aware user will reload the field if he
1942 thinks it's necesssary
1944 2004-01-30 Jean-Pierre Roux
1945 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1946 when 'dirty Acr' is found, to be compliant with the new
1947 IsReadable() methods.
1949 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1950 (no DOUBLE images in kosher DICOM,
1951 but so usefull for people that miss them ;-)
1953 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1954 DICOMDIR related utilities (not checked as Windoze compliant)
1956 2004-01-28 Jean-Pierre Roux
1957 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1959 2004-01-27 Jean-Pierre Roux
1960 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1961 to allow skipping the shadow elements, to save memory space.
1962 The TRUE value for this param has to be used
1963 with a FALSE value for the 'enable_sequence' param.
1964 ('public elements' may be embedded in 'shadow Sequences')
1965 * gdcmHeader methods now deal with 'embedded icones images' in the header
1966 (even when an 'icone image sequence' is announced by the
1967 element (0x0088,0x0200), but there is NO icone at all ...
1969 * gdcmHeader sometimes Image Location value doesn't follow
1970 the supposed processor endianity (see gdcmData/cr172241.dcm).
1973 * gdcmHeader add the method
1974 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1975 to get *all* the Header Entries with the same tag.
1976 GetHeaderEntrySameName is probabely *useless*
1977 (no meaning : Name is *not* an identifier within the Dictionary)
1979 2004-01-26 Benoit Regrain
1980 * Bug fix in the print of hexadecimal representations. Remove long fields
1981 in the print and add a third level of print to print them
1983 2004-01-23 Benoit Regrain
1984 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1985 * Bug fix on test suite after remove the strip made on not string fields
1986 * Split the IsReadable method between gdcmParser which test that the file
1987 is dicom and gdcmHeader which test that it's an image file
1989 2004-01-22 Benoit Regrain
1990 * DicomDir : clean code, add methods, set variables in protected or private
1991 * gdcmUtil : bug fix for the clean string method
1993 2004-01-19 Benoit Regrain
1994 * Add the use of shadow dictionaries
1995 * bug fix and coding style
1997 2004-01-19 Benoit Regrain
1998 * src/gdcmFile.cxx : bug fix concerning the close of file
1999 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2000 * Add the update of header entries using the shadow library
2002 2004-01-19 Benoit Regrain
2003 * removal of file gdcmHeader2.cxx
2004 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2005 inheriting from gdcmParser. This split is to prepare the integration
2006 of dicom dir parsing
2007 * bug fix under python
2009 2004-01-16 Jean-Pierre Roux
2010 * REM removal of class gdcmHeaderEntrySet
2011 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2012 * ADD add file gdcmHeader2.cxx
2013 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2015 2004-01-15 Benoit Regrain
2016 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2017 entries created while parsing the header. Thus, they will be destroyed
2018 when the gdcmDictSet will be destroyed
2019 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2022 2004-01-15 Benoit Regrain
2023 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2024 made a fatal error because of the memory release at the end of program.
2025 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2026 some memory and vtk seems to have some problems with that.
2027 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2029 2004-01-14 Benoit Regrain
2030 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2031 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2032 * src/*.[h|cxx] : make changes due to class name changes
2033 * gdcmPython/demo/*.py : bug fix due to method names
2035 2004-01-13 Benoit Regrain
2036 * src/*.[h|cxx] : coding style
2037 * vtk/*.[h|cxx] : coding style
2039 2004-01-13 Benoit Regrain
2040 * gdcmPython/testSuite.py : test the readable flag of file for tests
2041 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2042 It's lied to the stl compilation by MSVC (windows, always windows...)
2043 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2045 2004-01-12 Benoit Regrain
2046 * src/*.h : add comments
2047 * src/gdcmDictSet.h : set the method BuildDictPath in public
2048 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2049 directly setted in the source code
2050 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2053 2004-01-09 Benoit Regrain
2054 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2055 * setup.py : use a reference to gdcmVERSION
2057 2004-01-07 Benoit Regrain
2058 * Modification to compile with the distutils.
2061 2003-12-10 Benoit Regrain
2062 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2063 can use a gdcmHeaderHelper to load data
2064 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2065 made in the source code
2067 2003-12-10 Benoit Regrain
2068 * Update Windows projects and .cvsignore files
2070 2003-11-12 Jean-Pierre Roux
2071 * ENH gdcmHeader constructor has one more parameter (default value : false)
2072 that allows the user to 'go inside' the SeQuences only
2074 gdcmElValSet:Print takes it into account
2076 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2077 * ENH: Update gdcmPython/CMakeLists
2078 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2079 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2081 2003-11-10 Jean-Pierre Roux
2082 * FIX : gdcmHeader::LoadElements is now based
2083 on the ListTag listElem member,
2084 not longer on the TagElValueHT tagHt member
2085 * ENH : PrintPubElVal shows (temporarily) both results,
2086 with the tagHt member and the listElem member.
2087 (it's easier to 'see' the problems when using Printheader)
2089 * FIX : old private member LgrElem is now splitted into
2090 ReadLength : Length actually found on disk (updated only
2091 if bug fixing is necessary), for internal
2093 UsableLength : Updated by FixFoundLength, to fix a bug
2094 or to allow Parser going on.
2095 Will allow to re-write a kosher header when a SeQuence
2096 with a length (not 0000) is found
2097 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2098 because gdcmElValSet::Add does not update ListElem
2101 2003-11-07 Jean-Pierre Roux
2102 * FIX misstyping in Transfert Syntax name table
2103 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2104 when they have an actual length (not 0000 nor FFFFF)
2105 (Nobody should care of it, but DICOMDIR explorers)
2107 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2108 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2110 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2111 * ENH: vtkGdcmReader now supports LUT !
2112 (vtkgdcmViewer for now is not able to use them though)
2114 2003-11-05 Jean-Pierre Roux
2115 * in testSuite.py : new files names for checking the package
2116 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2117 that returns the pixel area size to the *aware* (vtk) user
2118 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2120 2003-11-05 Benoit Regrain
2121 * in testSuite.py : Modify the rules for checking the paths
2122 : Explicit error messages
2123 * in __init__.py : Related modif
2125 2003-11-03 Jean-Pierre Roux
2126 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2127 to be used by aware (vtk) users that want to manage
2128 LUT (and no to turn the PALETTE image into an RGB pixels one)
2129 * GetPixelType now returns 8U for 24 Bits images
2130 (vtkGdcmReader compliant)
2132 2003-10-31 Jean-Pierre Roux
2133 * Removal of *all* gdcmData images and add them again
2134 in order to loose the 'history' of un-anonymised images
2136 2003-10-31 Jean-Pierre Roux
2137 * RMV : removal of useless jBitsInJsample.h
2138 for both 8 and 12 Bits JPEG Lossy Libraries
2140 2003-10-31 Jean-Pierre Roux
2141 * ENH : Add the functions gdcmFile::GetImageDataRaw
2142 gdcmFile::GetImageDataIntoVectorRaw
2143 that act as GetImageData and GetImageDataIntoVector
2144 except the making of an RGB Plane from Gray Plane + LUT
2145 Intended to aware (vtk) users who know how to manage
2148 GetLUTRGBA return a R,G,B,A LUT if any
2149 lgrTotaleRaw gives the 'Raw' length
2150 GetImageDataRaw returns the gray Plane
2151 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2152 (They stay Grey, just like with other Dicom viewers :-(
2154 2003-10-30 Jean-Pierre Roux
2155 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2157 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2158 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2159 being coherents dicom files.
2161 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2162 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2164 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2165 * ENH: Two steps is necessary to please VC++ compiler...
2166 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2167 * ENH: Add include dir to medcon lib
2168 * FIX: only one function is being exported for now !
2169 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2171 2003-10-29 Jean-Pierre Roux
2172 * adding gdcmHeader::GetLUTRGBA
2173 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2174 --> Mathieu, the modif u're waiting for is not yet committed
2175 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2177 2003-10-27 Jean-Pierre Roux
2178 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2179 00191113.dcm DermaColorLossLess.dcm
2180 MxTwinLossLess.dcm RadBWLossLess.dcm
2181 * ENH: For version prior to vtkImageViewer2 -r 1.19
2182 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2184 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2185 * Removal of ido stuff in CMakeLists.txt
2187 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2188 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2189 * FIX: remove a call to ->Modified ... see comments
2190 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2192 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2193 * FIX: Problem with path for libvtkgdcmPython
2194 * ENH: Try adding a search script for python site-package
2195 * RMV: Remove some file from medcon lib that are not necessary
2196 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2197 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2198 * FIX: More pragma disable fro VC++,
2199 I don't think I break something as it is also disable in VTK/ITK.
2200 But it fasten debug compilation time.
2202 2003-10-23 Jean-Pierre Roux
2203 * gdcm now deals with 16 Bits Run Length Encoded images
2204 (they are compressed as 2 planes images,
2205 one for the high Bytes, the other for low Bytes)
2207 2003-10-22 Jean-Pierre Roux
2208 * Now CheckRead takes into account :
2209 - the bugged 'Leonardo' Siemens images
2210 - the XA images, sent thru the burning VPRO station
2211 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2214 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2215 * FIX: When copying a Makefile.am to CMakeLists.txt
2216 one should remove the '\'
2218 2003-10-22 Jean-Pierre Roux
2219 * in gdcmData adding a bugged 'Leonardo' Siemens image
2220 (wrong lengths in header)
2221 OK with gdcm, KO with the other viewers :-)
2222 * add a GE dlx XA image, thru the VEPRO burning station
2225 2003-10-21 Jean-Pierre Roux
2226 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2227 for a brutal checking of vtkgdcmViewer compliance
2229 2003-10-21 Jean-Pierre Roux
2230 * add the files for 'xmedcon' Jpeg Lossless library
2231 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2233 2003-10-21 Jean-Pierre Roux
2234 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2236 2003-10-21 Jean-Pierre Roux
2237 * garbage Siemens 'Leonardo' images dealt with
2238 (the patch is easy to remove)
2239 * cosmetic changes to avoid warnings
2241 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2242 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2243 no need to press 'r' now.
2245 2003-10-20 Jean-Pierre Roux
2246 * upgrade of checkRead.sh checkWrite.sh according
2247 to new Jpeg Lossless decompressor
2248 * add US.3405.1.dcm, a genuine RGB medical file ...
2249 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2250 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2252 2003-10-15 Jean-Pierre Roux
2253 * general anonymisation in gdcmData
2254 * adding the 'color files' from
2255 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2256 * adding some well knowed bugged-header images
2257 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2258 waiting for their inclusion in Python testsuite
2260 2003-10-15 Jean-Pierre Roux
2261 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2262 no longer seg faults when file is not found
2264 2003-10-14 Jean-Pierre Roux
2265 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2268 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2269 * TODO: *.in file to genereate a UseGDCM later
2271 2003-10-14 Jean-Pierre Roux
2272 * Some supposed-to-be Dicom Images have no preamble.
2273 OpenFile takes it into account
2274 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2275 * Missing elements added in dicomV3.dic
2276 (just to be affraid : have a look at
2277 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2278 and do it again next year ;->
2280 2003-10-13 Jean-Pierre Roux
2281 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2282 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2283 But there are NOT. It's fixed !
2285 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2286 * FIX: "jpeglib.h" was not found on VC++
2287 * FIX: vtkgdcm was not being installed
2289 2003-10-10 Jean-Pierre Roux
2290 * ENH : OpenFile closes the file if it *really* doesn't look like
2291 an ACR-NEMA / DICOM one.
2292 * FIX : testWrite no longer writes an empty file if the source file
2293 is not gdcm Readable
2294 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2297 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2298 * FIX: CMake generate now documentation
2299 * ENH: out of source doc build !
2300 * ENH: Generate both user and dev documentation
2301 * ENH: Should work on windows too
2302 * ENH: Only one doxygen config.in file is needed
2303 * FIX: make install should be ok now on ùnix plateform
2304 * FIX: PATH to dictionary was wrong (missing /)
2305 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2307 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2308 * vtkGdcmReader is now able to read rgb dicom file.
2309 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2310 * added a gdcmViewer to vtk test, use mouse to control
2311 window level & window width
2313 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2314 * CMake-ification of gdcm, we have now two build system
2315 * FIX: on cygwin Wsock32 doesn't exist
2316 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2318 2003-10-06 Emanuel Ollart
2319 * FIX : compilation process wad broken.
2320 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2322 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2323 * change gdcmViewer -> vtkgdcmViewer
2324 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2326 2003-10-06 Jean-Pierre Roux
2327 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2328 ( e.g : well known GE images with a wrong elem length,
2329 : Philips MRI Images with a wrong Huffman table)
2330 * still to be done : allow the reading of bugged LEONARDO Siemens images
2332 2003-10-03 Jean-Pierre Roux
2333 * Odd length strings are padded with '\0' (not with spaces,
2334 to remain compliant with already defined strings,
2335 like Transfert Syntax UID and others)
2337 2003-10-03 Jean-Pierre Roux
2338 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2339 to allow displaying RGB images (not only by affim ;-)
2341 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2342 * vtkGdcmReader is now able to read rgb dicom file.
2343 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2345 2003-10-03 Jean-Pierre Roux
2346 * A few nasty patches to allow the reading of a lot of nasty images
2347 ( e.g : well known GE images with a wrong elem length,
2348 : Philips MRI Images with a wrong Huffman table)
2349 * still to be done : allow the reading of bugged LEONARDO Siemens images
2351 2003-10-03 Jean-Pierre Roux
2352 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2354 2003-10-03 Jean-Pierre Roux
2355 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2356 to allow displaying RGB images (not only by affim ;-)
2358 2003-10-03 Jean-Pierre Roux
2359 * gdcmFile::GetImageDataIntoVector now
2360 - deals with MultiFrames MultiFragments Run Length Encoded files
2361 - deals with YcBcR (YBR_FULL) files
2362 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2363 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2365 (no sample found :-(
2367 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2368 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2369 Two reasons: - clear things
2370 - third parties acces gdcm through header files, so won't
2371 suffer anymore VC++ complains
2373 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2374 * add argv[1] in testvtkGdcmReader.cxx
2377 2003-09-24 Jean-Pierre Roux
2378 * The lines are now eigthy characters long.for
2379 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2381 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2382 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2383 char* to std::string. Thus, the use of strdup becomes useless. (see
2384 previous commis of Malaterre)
2385 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2386 before the last Malaterre's commit.
2388 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2389 * This commit should fix the Debug building under VC++, the problem
2390 was mainly a mixture of debug and release lib being loaded at startup.
2391 * I also remove a depency to a specific C function: strdup. Because I had
2392 to force the link to msvcrtd (whereas strdup is in libc).
2394 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2395 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2396 located in the gdcmCommon.h file. All use of reference of tha has been
2397 changed to now use the variable GDCM_UNFOUND.
2399 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2401 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2402 Dicom dictionary. The test suite can now be run again. Note:
2403 I'm note very happy with the " (RET)" changes. I believe this
2404 RETAINED comment should be dropped when parsing the dictionary.
2405 - PACKAGER corrected
2407 - AUTHORS updated and now in alphabetical order
2408 * Makefile.am now exports gdcm.dsw for Windoze users.
2410 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2411 * cygwin complains about missing std:: in subdir Test/
2413 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2414 * remove some methods that are now in gdcmHeaderHelper
2416 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2417 * vtkGdcmReader set spacing and origin correctly
2419 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2420 * Fix a few delete/delete[] mismatch
2422 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2423 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2424 interpretation to data given by gdcmHeader. For instance there are
2425 heuristics to get informations (look at different places).
2426 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2427 sorting DICOM images based on different strategies.
2428 * modified Makefiles accordingly.
2430 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2431 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2432 when building in debug mode
2433 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2434 src/win32/gdcmdll.dsp
2435 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2437 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2438 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2441 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2442 * src/win32/libgdcmjpeg12.dsp was not dos format
2443 * src/win32/libgdcmjpeg12.dsp :
2444 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2445 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2447 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2448 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2450 * src/gdcmFile.cxx : bug fix in affectation type
2451 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2452 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2453 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2454 symbols... future problem ?
2456 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2457 * src/win32/libgdcmijpeg12.dsp was missing
2458 * modified gdcm.dsw accordingly
2460 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2461 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2463 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2464 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2465 commit of JPR (before his hollidays to facilitate our work).
2466 * setup.py : bug fix in code. Modifications made while the last commit
2467 of JPR. The code hasn't been tested before the commit... it's so
2468 useless to make that (for best programmer that is JPR) !!!
2470 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2471 * tagged the current version as Version0_3 (i.e. version 0.3)
2473 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2474 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2475 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2476 * *.dsp : modifications to use new libgdcmijpeg8 library
2477 * setup.py : bug fix on VTKPATH variable
2478 * PACKAGER : adding all concerning windows
2480 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2481 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2483 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2484 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2485 test suite reported error.
2486 * PACKAGER file added (describes what a packager must do when
2487 packaging a new release).
2488 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2489 * configure.in: upgraded version number to 0.3.0
2490 * fixing build of rpm (through rpm -ta):
2491 - Doc/Makefile.am exports proper doxygen files
2492 - src/jpeg/libijg8/Makefile.am exports the include files.
2494 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2495 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2496 * src/gdcmHeader.h : formatting code
2498 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2499 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2500 We were obtaining error message from vtk. Now, creation of file list
2501 is made in an internal list to prevent this problem.
2502 Bug fix when output is empty.
2503 Bug fix in update of progress value. Previous commit for this was a bad
2505 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2507 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2508 * src/gdcmHeader.h : added method to get the file name
2509 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2510 files. Added method to remove all files on the input
2511 Added FIXME comment concerning the bad parsing of header made by
2512 ExecuteInformation method (in ExecuteData method)
2514 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2515 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2516 when using make instal.
2517 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2518 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2520 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2521 * setup.py : adding include dir of jpeg lib to compile all sources
2522 * */Win32/*.dsp : JPR fix for windows compilation
2524 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2525 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2527 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2528 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2530 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2531 * setup.py is again effective on un*x (takes into account the
2532 addon of the jpeg library)
2533 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2534 * Doc/Doxy* updated (includes above enhancements)
2535 * INSTALL now points to web documentation
2537 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2538 * src/gdcmHeader.h doesn't make unnecessary reference to
2540 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2542 * src/gdcm*.[cxx|h] :
2543 - to allow compilation with gcc 3.x
2544 -- clean up of STL usage (added explicit usage of std::)
2545 -- small fixes on exceptions.
2546 Note: linking not tested !
2547 - clean of doxygen comments to avoid warnings at documentation
2549 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2550 dependent convertion).
2552 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2553 * Clean up of previous JPR garbage commit (not even commented in the
2555 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2556 - moved all jpeg related files from src to src/jpeg/libijg8, with
2557 addition/modification of Makefile.am and configure.in.
2558 - the testSuite is still brain damage (not guilty).
2560 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2561 * WrapVTK.py : modifications to get correctly vtk source files to
2563 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2564 (FileName -> Filename)
2566 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2567 * vtk/vtkGdcmReader.[cxx/h]:
2568 - UpdateProgress method should now be effective
2569 - removed the limitation on having only images loaded (as opposed
2571 - when building a stack of images/volume, a lesser number of
2572 gdcmHeader and gdcmFile instances should be used (hopefully
2573 accelerating things).
2574 - when building a stack of images/volumes, files which are not
2575 loadable (wrong path-filename, wrong permissions on existing file,
2576 or file not parsable by gdcm) are replaced with a black image
2577 in the stack (for the caller to notice the problem).
2579 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2580 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2582 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2583 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2584 between standard library (std) and vtk library (problems are found
2585 under Windows... thanks Windows !)
2587 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2588 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2590 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2592 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2593 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2595 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2596 * When compiling with distutils (see setup.py) the C++ compiler is
2597 called with different flags than the default ones (with automake).
2598 In order to fix all those warning, I compiled gdcm with the command
2599 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2600 and went for warning fixes:
2601 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2602 up from unused variables.
2603 - vtk/vtkGdcmReader.cxx: potential bug fix.
2604 * src/gdcmHeader.h: Doxygen warning cleanup
2606 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2607 * gdcmPython/gdcm.i:
2608 - typemaps correction to take into account the systematic replacement
2609 of "using namespace std" with std:: prefix e.g. std::list,
2610 std::string... (cf changes of 2003-05-21).
2611 - gdcmGlob global variable of type gdcmGlobal (defined in
2612 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2613 exported to Python a as cvar.
2614 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2615 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2616 gdcmDictSet.GetPubDictTagNames() and
2617 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2618 C++ static methods).
2619 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2620 with the above changes.
2622 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2623 * setup.py, manifest.in : bug fix under linux
2625 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2626 * Modification of setup.py to compile vtk part too. Then, we have 2
2627 wrappers which must work with same distutils. For that, we have a
2628 generic distutils in distusiltsWrapping.py ; with :
2629 - build_extWrap class to wrap generically all extensions,
2630 - ExtensionWrap base class for all wrapping extension that contains
2632 - Wrapper interface which wrap sources
2633 + In WrapSwig.py we have extension and wrapper for Swig
2634 + In WrapVTK.py we have extension and wrapper for VTK
2635 * MANIFEST.in : modifications to consider vtk directory and new python
2636 files for compilation
2638 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2639 * Added python wrappers of vtkGdcmReader vtk class (see the
2640 source in vtk/vtkGdcmReader.cxx) :
2641 - vtk/Makefile.am now builds a library
2642 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2643 python library (as opposed to _gdcm.so wich are the python
2644 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2645 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2647 - configure.in has an additional flag --enable-vtk that needs
2648 to be set to enable compilation of vtk related code, that is:
2649 + vtk/vtkGdcmReader.so and
2650 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2651 + gdcmPython/vtkgdcmPython.so (see above)
2652 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2653 be read when compressed or when HighBit + 1 != BitsStored),
2654 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2655 the usage of the python wrapper of vtkGdcmReader vtk class.
2656 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2657 * src/*.[h] all occurences of stl classes are now prefixed with
2658 std::, and all occurences of "using namespace std;" where removed.
2659 This is to avoid pollution of global namespace in included files.
2660 Apparently vtk does not avoid this pitfall: when using both
2661 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2662 collision of various stl members (principally cout...).
2663 * gdcmPython/testSuite.py now cleanly removes temprory generated
2665 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2666 comply with above changes)
2668 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2669 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2670 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2671 vtk data structure (an image Flip was required).
2672 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2673 * cosmetic changes in documentation.
2675 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2676 * src/gdcmHeader.cxx: the constructor no longer exits when an
2677 unexisting file is given as argument.
2678 * The subdirectory Data (containing all the images used for the
2679 test suite) is not part of this repository anymore. A new module
2680 containing those images is now available at
2681 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2682 with the name gdcmData.
2683 All the python scripts (including the package initialisation file
2684 gdcmPython/__init__.py) were adapated to take this change into
2685 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2687 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2688 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2689 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2690 demo of the usage of this class.
2691 Compilation of this vtk part is only done when using the --enable-vtk
2692 at configure (or autogen.sh) stage.
2694 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2695 * More memory link related corrections and documentation fixes.
2697 - maximum info is obtained with a command of the form:
2698 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2699 --show-reachable=yes PrintHeader
2700 - the remaining reachable blocks seem to come from the STL
2701 allocation scheme through the usage of map and list. It looks
2702 like this memory cannot be freed but it is not a memory leak
2703 (in fact further invocation to the STL would recollect the
2704 unused memory allthough it cannot explicitely be freed).
2705 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2706 of displaying an image parsed with gdcm and displayed with VTK.
2707 Note: some images don't seem to work e.g.
2708 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2709 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2710 Allthough this weakens the semantics, it is a ditch attempt to
2711 make gdcm more thread friendly.
2713 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2714 * Memory link hunt (by using valgrind through the command
2715 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2716 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2717 gdcmHeader::_dicom_vr.
2718 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2719 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2721 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2723 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2724 * src/Makefile.am now exports all the necessary include files at
2728 * UpdateGroupLength replaced by new one
2731 * UpdateGroupLength re-written using H-Table
2732 (named UpdateGroupLengthNew untill checks are over)
2734 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2735 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2736 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2738 - gdcmHeader::GetPubElValSet removed.
2739 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2740 UpdateGroupLength, WriteElements, Write.
2741 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2742 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2743 carried the same semantics.
2744 - src/gdcmHeaderIdo.cxx changed accordingly.
2745 - gdcmFile::WriteBase now regroups all the codes from previous
2746 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2747 - enum FileType moved to gdcmCommon.h
2748 * src/gdcmHeader.cxx AddDefault trashed
2749 * gdcmGetXSize added
2750 * getimageDataSize now calls gdcmGetXSize
2751 * Test/*.cxx changed to agree with above changes
2753 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2754 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2755 (to avoid double call by end user).
2756 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2757 by end user, since gdcmHeader::gdcmHeader now handles it.
2759 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2760 * gdcm/Doc many doxygen changes:
2761 - Doxyfile now has two different versions, DoxyfileUsers that generates
2762 the html.users end users oriented documentation and
2763 DoxyfileDeveloppers that generates the html.developper developper
2764 oriented documentation.
2765 - README changed accordingly
2766 - requirement.txt removed (old design info moved to TODO).
2767 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2768 DoxyMainPage.txt, DoxyPython.txt provide more information.
2769 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2770 be updated by simply regenerating the docs with doxygen and copying
2771 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2772 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2773 all the tests in the form "if (<map>.count() >1)" were removed.
2774 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2775 ill-formed documentation sections.
2776 * src/gdcmHeader.cxx: ditto
2778 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2779 * setup.py fixed for un*x (needed macro for stdint.h)
2780 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2781 un*ces with sh-utils test utility.
2782 * gdcmPython/demo/test.py renamed to PrintHeader.py
2783 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2784 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2785 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2786 * src/gdcm*.cxx JPR's bad inclusion fixed.
2788 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2789 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2790 * gdcmPython/demo/test.py changed accordingly.
2792 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2793 * gdcmPython/Makefile.am fixed linking against libstdc++
2794 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2795 * Swig subdir (historical tests of swig version 1.3.17++) removed
2796 * Test/testChangeEntete.cxx some lines commented out in order to make
2798 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2799 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2801 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2802 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2803 hence the user doesn't need this explicit call.
2804 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2805 i.e. LoadElements() call removed.
2806 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2807 - src/Makefile.am declares the proper flag for g++.
2808 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2809 for adding user defined new tags.
2810 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2811 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2812 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2814 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2815 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2816 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2817 src/Makefile.am : the project should properly compile and install
2818 with the autotools, included the python wrappers part.
2819 * gdcm.spec.in : added a spec file for RPM packaging.
2821 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2822 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2824 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2825 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2826 to exported to the environement (see gdcmPython/testSuite.py
2828 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2829 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2830 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2831 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2832 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2834 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2835 * gdcmPython/__init__.py doesn't crash anymore when running in
2836 in InstallMode or PreInstallMode but with an environment given
2837 value of GDCM_DICT_PATH.
2838 * src/gdcmDictSet.[cxx/h] coding style.
2840 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2841 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2842 * src/gdcm.h general comments moved to TODO, and README
2843 * src/gdcm.h should now be seen as a user commodity (including it
2844 should suffice to fully use gdcm). It is nowhere including within
2845 any of the kernel files src/*.cxx and src/*.h.
2847 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2848 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2849 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2851 * src/gdcm*.cxx only include their corresponding include file
2852 (as opposed to gdcm.h)
2853 * gdcmPython/gdcm.i changed accordingly
2854 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2855 the autogen.sh generated "make snapshot" command to work.
2856 * autogen.sh removed history related references to crea package.
2858 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2859 * distutilsSwigCPlusPlus.py work around some swig portability
2862 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2863 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2864 was done in a last ditch attempt to get setup.py _really_
2865 operationnal. The python/gdcmPython layaout add the advantage
2866 of hidding away the python related distutils specific files
2867 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2868 Alas, the src directory was out of scope (i.e. it's relative
2869 position to setup.py was ../src) which made things impossible to
2870 handle (see previous version of python/setup.py). Crossing fingers...
2872 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2873 * python/setup.py now works on Un*x. (harder than I thougth)
2874 * python/distutilsSwigCPlusPlus.py can now have include files
2875 among the list of sources.
2877 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2878 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2879 * modifications in MSVC projects
2881 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2882 * As stated by the first lines of Test/ExceptionAndPython/README, it
2883 looks like we can move back to original usage of exception within
2884 src/gdcm* and hence remove the errno stuff that was introduced
2885 as a quick and dirty fixture of this problem (added to the TODO).
2886 * Doc/Doxyfile configuration file for Doxygen and corresponding
2887 README file for usage added.
2888 * Test/testWrite.cxx added. This new test comes from a split of
2889 test.cxx that is now reverted to its original purpous i.e.
2890 testing the proper parsing of a Dicom related file.
2891 testWrite.cxx concentrates on testing the IO part of gdcm.
2892 * Test/bug1.cxx (containing a bug on WIn32) added.
2893 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2894 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2895 whose purpose is to publish the content of the TagNames of the
2896 Dicom public dictionary were not accessible without an
2897 instance of class gdcmHeader.
2898 - those methods are now static methods of gdcmDictSet and hence
2899 require no instances at all to be invocated.
2900 - within gdcmDictSet this change required to change some method
2901 to class methods (i.e. are now static) among which SetDictPath
2902 (renamed to BuildDictPath) and LoadDefaultPubDict.
2903 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2904 the above changes by calling the new method classes of gdcmDictSet.
2905 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2906 the above to be effective.
2907 * python/gdcmPython: in order to wrap properly the above changes
2908 for Python, swig version now needs to be > 1.3.17.
2909 * python/gdcmPython/Makefile fixed to adapt itself to new
2910 configure/make shema introduced by Johan Montagnat (thanks for the
2911 contribution). Alas this Makefile cannot be turned into a proper
2912 Makefile.am without some heavy changes in the configure.in
2913 (for python dectection).
2914 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2915 now avoids publishing the empty entries.
2917 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2918 * python/setup.py : bug fix concerning install under windows
2919 ExtraPath reused :-P
2920 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2922 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2923 * Dicts/dicomV3.dic : remove double spaces !!!
2924 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2925 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2928 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2929 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2930 method. Doxygenation.
2931 * src/gdcm.h clean up of JPR spurious comments.
2933 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2934 * python/distutilsSwigCPlusPlus.py now properly collects the
2935 shadow classes generated by "swig -c++" (gdcm.py in our case)
2936 when using "python setup.py install".
2937 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2938 reexports the working classes.
2939 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2940 by the classical C errno scheme. This is to prevent an obscure
2941 behavior of the python wrappers when importing wxPython.wx prior
2942 to gdcmPython (which ended up in an abort call). An illustration
2943 of this oddity can be found in the Test/ExceptionAndPython
2944 subdir (see the README file). This problem probably due to
2945 an combination of g++ and dynamic loading.
2946 * added Test/ExceptionAndPython (see above)
2948 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2949 * Changed the layout of the python part to avoid bloating main
2950 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2951 i.e. the distutils arsenal. All the python related stuff is
2952 again in a python subdir, but the package itself is now in
2954 * setup.py was cleaned up:
2955 - pythonIncludePath removed
2956 - python setup.py bdist target is now functional.
2957 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2958 collision with other packages). gdcmPython/demo/*.py changed
2961 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2962 * python subdir moved to gdcmPython (preparation of distutils packaging).
2963 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2964 distutils installer is operational.
2965 * - gdcmPython/__init__.py now properly loads the swig generated
2966 shadow classes (from gdcm.py).
2967 - gdcmPython/demo/*.py changed to import the package gdcmPython
2968 instead of gdcmPython/demo/load.py.
2969 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2971 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2972 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2973 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2974 entries within the associated public Dicom dictionary resp. the same
2975 information but sorted by the fourth field (PAT, IMG, DIR) of the
2977 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2978 are now in the "???" group.
2979 - python/gdcm.i changed accordingly,
2980 - python/demo/printGroupedPublicDict.py added, that gives an example
2981 of the above new functionalities in Python.
2983 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2984 * src/gdcm.h, gdcmHeader.cxx:
2985 - historic references to glib's g_malloc and g_free (#defined)
2986 were definitively removed.
2987 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2988 * src/gdcmElValSet.cxx:
2989 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2990 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2991 - GetElValue(string) renamed to GetElValueByName.
2992 - Added GetElementByName(string).
2993 * src/gdcmHeader.cxx: added
2994 - GetPubElValRepByNumber(guint16, guint16)
2995 - GetPubElValRepByName(string)
2996 - GetShaElValRepByNumber(guint16, guint16)
2997 - GetShaElValRepByName(string)
2998 - GetShaElValByNumber(guint16, guint16)
2999 - GetShaElValRepByName(string)
3000 - GetElValRepByNumber(guint16, guint16)
3001 - GetElValRepByName(string)
3002 - GetElValByNumber(guint16, guint16)
3003 - GetElValRepByName(string)
3004 * Doc/requirements.txt added.
3006 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3007 * Test/Makefile building now depends on the one of libgdcm.so
3008 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3009 pixel data) aware which enables finding the address (offset) of
3010 the pixel data of JPEG encoded DICOM files. This leaves only a single
3011 file in the testSuite whose pixel data address (offset) is unknown.
3012 * python/testSuite.py changed accordingly.
3014 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3015 * VC++ has some strong limitations when working with the STL, as stated
3016 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3017 "Also note that some STL containers (map, set, queue, list, deque)
3018 cannot be exported. [...]
3019 Some STL classes contain nested classes. These classes can not
3021 This is caused by a designed limitation that once a template
3022 class is instantiated, it can not be re-instantiated and
3024 Since our usage of map<> is ubiquitous in gdcm, this "designed
3025 limitation" of VC++ is a pitfall.
3026 Hence the Python wrappers of gdcm cannot be incrementally linked
3027 against the c++ dynamic library. The dirty but only workaround is
3028 to forget about incremental link of dynamic libraries and to generate
3029 the Python wrappers library with the inclusions of the underlying C++
3031 The following modifications concern this matter on Win32/VC++:
3032 - wrapping python correct with standalone wrapped dll (don't use separate
3033 dll under windows !!!!)
3034 - python21_d debug mode enabled (ask Frog how to use it :-)
3035 - NO problem with having an STL member of class for example string in C++
3036 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3037 - Python test of dcmlib in Python is ok under windows on a large set
3039 * removed glib references
3040 * typedef's inserted in gdcm.i for correct swig type management
3042 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3043 * python/demo/*.py load.py extracted from test.py. Added explore.py
3044 that only displays required tags and testAll.py that parses all
3045 the files of the testsuite without using unittest.
3046 * python/testSuite.py other additional test on new files added.
3047 * Data/* new test files added accordingly to the testSuite.
3048 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3049 the vr in the file differs from the one of the dictionary.
3051 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3052 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3053 values, but limits itself to values which are below a user specified
3054 size (by default 1024 bytes).
3055 * python/gdcm.i : elements not loaded (because their size is above the
3056 user specified treshold) are exported with their TagKey as key of the
3057 python dictionary. This enables the testsuite to make some checks
3058 on the unloaded elements (since we have their offset and size).
3059 * python/testSuite.py
3060 - now tests for the existence and proper value of the pixel data
3061 - two new examples added.
3062 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3064 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3065 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3066 aware. See the strategy comments in gdcmHeader::FindeLength().
3067 * Test/test.cxx now accepts a filename as first argument.
3068 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3069 * python/testSuite.py changed to integrate test on above files.
3071 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3072 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3073 the vr was also RET.
3074 * python/testSuite.py more tests added.
3076 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3077 * python/testSuite.py unittest test suite added (uses Data)
3078 * Data/* dcm and acr files for the test suite.
3079 * glib dependance removed from un*x version. We now use ISO C99
3080 7.18 Integer types (see stdint.h)
3081 - python/Makefile, src/Makefile src/gdcm.h
3082 * src/ when an explicit vr (like dicom files) suddenly poped an
3083 implicit element we use to mark the underlying DictEntry of the
3084 concerned ElValue with "Implicit". This strategy was damageable
3085 too the public or provite dictionaries, since some of their vr
3086 would be changed. Since Header::FindLength heavily relies on the
3087 detection by Header::FindVR of falsely explicit elements, I
3088 added an extra ImplicitVr member to ElValue (boolean).
3089 The rest of the changes we the necessary adaptations.
3091 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3092 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3094 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3096 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3097 * Adaptation for porting to VC++:
3099 o forced to use std namespace (for string to be known)
3100 o all class use __declspec export style on WIN32
3101 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3102 (in stdlib.h on Win32 but in std:: for gcc)
3103 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3104 variable GDCM_DICT_PATH.
3105 * src/gdcmHeader.cxx verbose comments made discrete.
3107 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3108 * python/gdcm.i: added a typemap that converts a C++ hashing table
3109 to native Python dictionary.
3110 * python/demo/test.py:
3111 - now uses the native dictionary for exploration of gdcmHeader.
3112 - takes an optional filename argument (the file to parse).
3113 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3114 PubElVals hashing table.
3115 * Dicts/dicomV3.dic removed error prone trailing spaces.
3117 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3118 * Python wrapping process moved away from src/Makefile to
3119 newly created python/Makefile (as well as gdcm.i)
3120 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3121 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3122 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3123 from the environement variable GDCM_DICT_PATH (when existing).
3124 * src/gdcmDict::GetTag bug fix.
3126 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3127 * Straightforward temporary fixes for swig to build the python wrappers.
3128 src/Makefile now has a python working entry [by working we mean
3129 that we can import de shadow classes without errors].
3131 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3132 * hashtest.cxx removed (since already in Test)
3133 * src/gdcmlib.h renamed to src/gdcm.h
3134 * src/dcm.i renamed to src/gdcm.i
3135 * src/Makefile prepared for python wrapping
3137 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * src/gdcmHeader.cxx :
3139 - Parsing of header is now separated from loading of element values
3140 (see gdcmHeader::LoadElements).
3141 - general clean up of hopefully all file access (creation of
3142 ReadInt16 and ReadInt32)
3144 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3145 * src/gdcmHeader.cxx :
3146 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3148 - SetLgrElem renamed to SetLength
3149 - GetLgrElem renamed to GetLength
3150 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3151 * src/gdcmElValSet.cxx fixed both GetElValue methods
3152 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3153 due to IdoDude was cleaned out.
3155 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3156 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3157 concentrates on finding the value representation (when it exists).
3158 RecupLgr now only finds the element value length, and it avoids
3159 returning the unecessary skL (skipped length).
3160 Also, offsetCourant was simply removed (with taille_fich) since
3161 it was redundant with the File position internals (by using
3162 ftell and fseek). This also made skL (see above in RecupLgr) usage
3164 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3165 on the libido specificities which are handled through class
3167 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3170 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3171 * Truckload of changes. Parsing of header is barely functional
3172 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3174 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3175 * src/gdcmHeader.cxx many addons of low level methods
3177 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3178 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3179 and _IdDcmSWAP_LONG.
3181 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3182 * This corresponds to all the changes decided at the meeting of
3183 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob