1 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
3 format) to replace 'at-run' dicom files generated by the
4 TestAllReadCompareDicom test
6 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
9 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
12 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * Testing/TestMAkeIcon.cxx : complete the test
15 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
18 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
22 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
25 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
26 * Test/ : accelerate tests (it's not very significant accelerations).
27 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
29 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * Testing/TestSequence.cxx : add test for sequences of images... test that
31 we have the same serie or the same study UID
33 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
36 * src/gdcmDict.h : remove commented code
37 * src/gdcmDocument.cxx : initialize values
38 * src/gdcmFile.cxx : bug fix when reading values
39 * gdcmPython/demo/ : change file names. Remove useless files
41 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * src/gdcmFile.cxx : remove the default array of initialization.
43 The static array contained pointers to non-static values (comming from
44 strings). To have coherences, when creating files, these values can't be
45 static. So, the array can't be static, too ! To simplify, the array have
46 been replaced by repeted lines to insert values in the File
48 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
49 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
50 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
52 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
53 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
54 (Dicom Element) into the Sequence Item
56 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * src/*.cxx : first parss to normalize file organisation
59 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * src/gdcmDirList.[h|cxx] : add method to find a directory
61 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
63 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
64 * Finish cleaning up my JPEG mess. Should be ok now.
65 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
66 contained within the RLE* class(doh!)
68 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
69 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
70 * SerieHeader::AddFileName() creates as many Coherent Files lists
71 (same Serie UID) as it founds different Serie UID
72 amongst the files instead of discarting any file
73 that doesn't match with the first one he found.
74 * SerieHeader::OrderGdcmFileList has now one parameter :
75 the Coherent Files list the user wants to sort
76 * SerieHeader::GetFirstCoherentFileList() |
77 * SerieHeader::GetLastCoherentFileList() | allow to parse
78 the set of Coherent Files lists
79 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
80 compatibility (it returns the *first* Coherent Files list,
81 since there was only one before)
82 * Test/TestSerieHeader gets gdcmData as a default root directory
84 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * Remove friend between DocEntry and File classes
86 * Remove friend between PixelReadConverter and RLEFramesInfo,
89 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
91 0002|0000. The value was incorrect.
93 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
94 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
96 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * src/gdcmUtil.cxx : compilation fix on Win32
98 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
99 variable, to be easy found. Add methods to change the default UID.
100 Amelioration of the CreateUniqueUID to use the correct default UID.
101 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
104 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
105 * Test/TestVR.cxx : fix memory leaks
107 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
108 * Rewrite the base 256 to base 10 conversion, using string operation only.
109 This allows us to get rid of the problematic 64bits integer type (does not
110 always exist on target platform).
112 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
113 * Add construct and destructor to class gdcm::Debug to close the debug file
115 * Don't let uset to open twice the same file
116 * gdcm has now an official UID prefix,
117 supplied by http://www.medicalconnections.co.uk
118 1.2.826.0.1.3680043.2.1143
119 (Thx to Mathieu for providing URL)
120 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
121 to be able to perform some more tests
122 * gdcm::ContentEntry : Contructors and Destructor are now protected,
123 in order to be sure no user will try to use them.
124 (at user level, only the children classes are meaningfull)
126 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * move RLEInfo & JPEGInfo from Document to File
129 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * FIX : remove so many friend between classes
132 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
133 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
134 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
136 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
137 In order to avoid missbehaviour :
138 . gdcm::DocEntry is now specialized in
139 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
140 - gdcm::ContentEntry (Dicom entry with a 'content')
141 . gdcm::ContentEntry is specialized in
142 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
143 characters value, or integers)
144 - gdcm::BinEntry (Dicom entry with a non strig representable value
145 (user hasn't any longer to thing about the precedence of his dynamic_casts)
147 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * Test/VTKTest*.cxx : bug fix under linux
150 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
152 use with python. Some methods are moved from Document to ElementSet or
153 DocEntrySet. The equivalent methods to ElementSet have been added to
154 SQItem and are virtual in DocEntrySet. Methods that may have the same code
155 in SQItem and ElementSet is directly placed in DocEntrySet
157 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * Test/VTKTest*.cxx : remove the show variable in each test method because
159 it's useless (the viewer variable replace this variable)
161 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * src/gdcmDocument.cxx : bug fix on potential memory leak
163 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
164 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
165 Add ClearXxx methods to remove all the content of the list or map
166 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
168 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
169 * methods ReplaceOrCreate renamed as Insert
170 (nobody will be any longer confused by 'CreateOrReplace')
172 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
173 * Grealty simplify the JPEg decompression, no need to differenciate based on
174 the JPEG possible type (with/without fragment, with/without multiple frame).
175 Everything is done throught the JPEG IO Suspension mechanism in IJG
177 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
178 * Stage 3 of normalization :
179 in order to avoid any missunderstanding while reading method names :
180 - All the methods xxxEntry now deal with dicom Entries
181 - Methods GetEntry splitted into
184 - Method SetEntry renamed as SetEntryValue
185 - Method SetEntryBinArea let as it was
187 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
188 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
189 - Position correctly the entry points for JPEG2000 and JPEG-LS
190 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
192 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
194 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
195 with other method names
196 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
197 * Test/TestDicomDirElement.cxx : add new test
199 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
200 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
201 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
202 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
203 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
204 So can't you use __int64 in ostream at all.
206 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
207 * bug fix for compilation on MSVC6
208 * gdcmPython/gdcm.i : rename of classes missed
210 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
211 * Stage 2 of names normalization :
212 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
213 (easy to understand ...)
214 - gdcm::FileHelper replaces old class gdcm::File
216 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
217 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
218 type and not a string. So, there remove problems on the format of the
221 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
222 * Add Example/TestPapyrus.cxx
223 - reads a Papyrus file (gdcm::Header compliant),
224 - gets the pixels of all the images, using low level iterators
225 - writes an multiframes Dicom image.
226 (Just to show it's *possible* to do that)
227 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
230 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
232 Thus, DicomDirXXX are created with a flad that indicates if the created
233 object is empty or not (when not empty, the DicomDirElement is used to
236 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
237 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
238 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
240 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
243 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
245 Remove all access to the hash-tables or lists in the objects.
247 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
249 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
250 be complient with all the gdcm source code
252 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
256 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
257 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
260 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
261 * Test/ : rename VTK tests to have a best name for the tests
262 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
263 GetFirstEntry/GetNextEntry use
265 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
266 * In SerieHeader::ImagePositionPatientOrdering()
267 // a Dicom 'Serie' may contain scout views
268 // and images may have differents directions.
269 // -> More than one may have the same 'pos'
270 // Sorting has then NO meaning !
271 Thx to Eduardo Davila for reporting bug.
273 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
274 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
275 test. Now it's on image content and not on the resulting visualisation...
276 might solve the problem on linux when using the OpenGL drivers
278 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
279 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
280 DicomDirSerie, DicomDirImage
281 Dict, DictSet classes :
282 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
283 -remove InitTraversal method.
284 * UPD Test programs + Example programs
286 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
287 * remove useless and never updated keyword \ingroup
288 * Solve pb when structure (list, map, ...) is empty.
289 Thx to Benoit for reporting bug
291 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
292 * Taking into account of 'Transfer Syntax' value
293 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
296 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
297 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
298 is no memory access violation
299 * gdcmPython/demo : add python demos using VTK
301 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
302 * FIX 'Dictionnary' is now spelt 'Dictionary'
303 'wether' is now spelt 'whether'
304 'archieve' is now spelt 'archive' ;-)
306 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
307 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
308 related methods, in order not to expose internal mechanisms
311 * REM methods that exposed internal mechanisms :
312 DicomDir::GetDicomDirPatients()
313 DicomDirPatient::GetDicomDirStudies()
314 DicomDirStudy::GetDicomDirSeries()
315 DicomDirSerie::GetDicomDirImages()
316 * UPD Test programs :
320 * UPD Example program
322 * ADD DictSet methods
326 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
327 * Removed the Print/indent/default parameter mess. There is absolutely no
328 reason to have to methods, moreover with the second taking the ostream as
329 *SECOND* parameter. This was clearly a bad hack to get things compile.
331 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
332 * Complete rewrite of the GetMacAddress code. Now the code is *much*
333 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
334 Unfortunately the main code does not work on SunOS, thus provide a specific
335 code for this platform only (and Win32 of course). Since this seems to be
336 working, change CreateUniqueUID to use GetMACAddress instead of the
337 problematic GctestetIPAddress
339 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
340 * Unfortunately to be able to test gdcmDirList I had to break the API
341 a little. Now the class is not a std::list anymore but has a member
342 std::vector (more ITK compatible). Allow unit testing on Win32 and
345 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
346 * Update SerieHeader to take into account a Serie Instance UID to properly
349 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
350 * ENH - Comment out Mathieu's (dangerous) Super Hack
351 for dealing with BIGENDIAN processors
352 - Move equivalent stuff to BinEntry::WriteContent
353 When necessary, 16 Bits Pixels are swapped in a small buffer
354 and then written. This avoid allocating a huge buffer, in
355 PixelWriteConvertor, and avoid modifying the Pixel Area.
357 Probabely, the same operation will have to be done when we want
358 to write image with Big Endian Transfert Syntax,
359 and we are working on Little Endian Processor
361 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
362 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
364 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
365 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
366 all the dict content.
367 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
369 * Test/TestDict.cxx : add a new test for the dict classes
371 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
372 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
373 file. Debug is yanked if compiled with NDEBUG
375 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
376 * src/gdcmDictSet.h : set the default output to the os variable
377 * src/gdcmDictEntry.[h|cxx] : add the Print method
378 * gdcmPython/demo/ : add a new test
380 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
381 * merging of Test/PrintDicomDir and Test/TestDicomDir
382 * removal of now redundant Test/PrintDicomDir
383 * enhancement of Example/PrintDicomDir
385 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
386 * Now, python test might work on systems
387 * Add the PrintDicomDir test
389 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
390 * FIX : First entry following group 0002 was lost for
391 Explicit Big Endian Transfer Syntax files
392 (group and elem not swaped)
394 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
395 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
396 Big Endian Transfer Syntax supposed the group following 0002
397 begins always by element 0000 (element 0000 is *optional*)
398 To avoid further troubles, let's be pessimistic, and use
399 Document::HandleOutOfGroup0002() method
400 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
401 (related pb not yet solved)
403 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
404 * Bug fix for the python part use
405 * Now, PrintHeader.py pass... but outside the ctest use. shit !
407 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
408 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
410 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
411 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
412 a string and should ask the global TS dict what are the propreties of
415 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
416 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
417 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
418 to swap the Swap Code, at parsing time, when we come out of group 0002
419 and Transfer Syntax is Big Endian
420 We should be able to read now 'true DICOM" Big Endian coded images
421 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
422 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
424 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
425 * Hopefully fix the bug on MacOSX and static global initialization.
426 This is the only -minor- patch I found that both please MacOSX and VS6.
427 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
428 but this would require a lot of change. Another approach would be that Global
429 create those string and GDCM_UNFOUND becomes a pointer to a string (which
430 gdcm::Global would destroy at exit).
432 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
433 * Fix bug on MacOSX with static initialization in a multy threaded
434 environment. static const string in a header file used to be ill
435 initialized provoquing the freeze of any tests. patch should solve this
438 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
439 * According to Benoit's suggestion, and without any objection from anybody
440 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
441 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
442 - method gdcmDicomDirObject::GetEntry() renamed as
443 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
445 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
446 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
447 you debug/warning message just as c++ streams which make them very convinient
448 to use. Once this is stabilize I will change the ostringstrem to be
449 redirected to a file (ofstream).
450 * Properly support C99 extension: __FUNCTION__ which allow us to display
451 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
453 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
454 * Removal of useless and dangerous methods :
455 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
456 GetDocEntryByName, GetEntryByName, GetDictEntryByName
457 * Removal of usless methods :
458 Dict::PrintByName, Dict::GetDictEntryByName
459 * Commenting out of probabely useless methods :
460 Dict::GetDictEntryNames()
461 Dict::GetDictEntryNamesByCategory()
462 DictSet::GetPubDictEntryNames()
463 DictSet::GetPubDictEntryNamesByCategory()
464 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
465 * ENH : Use dicomTS.dic as described in 2004 version
466 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
467 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
468 Add Accessors on VM (Value Multiplicity), and VM related methods
469 * ADD : Add a list of 'Dicom Attribute types', as found in
470 http://medical.nema.org/dicom/2004/04_15PU.PDF
472 * ADD : Add dicomGroupNameAbbreviations.dic
473 should be used to write a method to replace the former
474 Dict::GetDictEntryNamesByCategory()
476 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
477 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
478 to read in the file... and only it ! Length is the efective length of the
479 data in the DocEntry structure
481 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
482 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
483 And now use a static function call instead, with a global variable. i
484 This is much closer to the VTK approach. Hopefully should be bulletproof
485 and easier to use...hopefully
487 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
488 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
490 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
493 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
494 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
495 ValEntry, BinEntry, SeqEntry creation or replace
497 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
498 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
499 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
501 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
502 when specifying the VR
503 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
504 * src/gdcmDocEntry.cxx : amelioration of print
506 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
507 * ADD : Add the method Util::IsCurrentProcessorBigEndian
508 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
509 * ADD Method Document::ComputeGroupLength
510 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
511 in order to allow further VR modification by user
512 * REM : removal of once-called method File::WriteBase
513 integration of its code in formerly one-line method File::Write
515 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
516 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
517 replace the different values "??", "Unkn", "Unknown".
518 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
519 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
520 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
521 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
523 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
526 * Set the gdcm::Base class to some Printable classes
528 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
529 * src/gdcmFile.[h|cxx] : add the Print method
530 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
531 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
532 * src/gdcmDocument.h : remove the PrintLevel informations
533 * Example/PrintFile.cxx : use the new gdcm::File::Print
535 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
536 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
537 problems when compiling with the python wrapping
539 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
540 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
541 writting in ImplicitVR
543 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
544 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
545 JPEG decompression, especially when dicom frames are split into several
546 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
547 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
549 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
550 * src/gdcmHeader.cxx : change the initialisation of default header.
551 Now, this header is readable by gdm, e-film, DicomWorks
553 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
554 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
555 Rename Decompressed to Raw
556 * Use the API changes in gdcm::File.
557 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
560 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
561 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
562 each added entry in the header. Replace the 'Planes' field by the 'Number
565 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
566 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
567 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
569 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
570 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
571 At this time, this image isn't readable by e-film... waiting JPR help to
574 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
576 DocEntry. Now use methods of the Document !
578 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
579 * Test/ShowDicomSeq.cxx : bug fix
581 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
582 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
583 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
584 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
585 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
587 * Test/TestCopyRescaleDicom.cxx : remove unused variable
588 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
589 containing found sequences
591 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
592 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
594 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
595 Some fields in BinEntry must be copied to not seg fault when making the :
596 gdcm::File *copy = new gdcm::File( copyH );
597 and tests are now made on good variables
599 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
600 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
601 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
603 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
604 * Add vtkGdcmWriter example and test
606 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
607 * Test/TestUtil.cxx : reformat the source code
608 * vtk/vtkGdcmReader.cxx : remove and change prints
609 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
611 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
612 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
614 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
615 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
616 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
618 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
619 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
620 by an eof to prevent all bad read of the file... and in this case, the
623 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
624 * Example/Volume2Dicom.cxx : comment unused variables
625 * Test/PrintDicomDir.cxx : comment unused variables
626 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
627 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
628 method that is redondant with AddEntry.
629 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
632 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * Bug fix due my last commit (compilation under Windows).
634 * Example/Volume2Dicom : bug fix in the file and reformatting source code
635 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
637 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
639 - Remove printf / sprintf
640 - include iostream AFTER gdcm so we don't get warnings
641 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
643 - Also remove tons of include from header files, hopefully this should
644 speeup the compilation time, since it was becoming a dog slow.
645 - Remove gdcm.h as it include way too many files and slow down compilation
646 (plus it is not up to date)
647 - remove 'using namespace std' this is BAD !
649 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
650 * Remove memory leaks on the DicomDir
651 * Remove some useless data in DicomDirObject
652 * Add usefull methods in SQItem, to be complient withe the ElementSet
654 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
655 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
657 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
658 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
659 future, with convertion)
660 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
661 and ImageDataSize values. Remove the method to get the PixelReadConverter
662 from the output of the class
664 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
665 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
667 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
668 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
669 and vtkErrorMacro use.
670 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
672 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
673 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
675 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
676 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
677 The string leaves only in the fonction. So when we make a .c_str(), we
678 get the pointeur on the first element, element that will be destroyed
679 immediately after thee instruction.
680 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
681 file has been opened : the test must be made on the content of the
682 pointer and not directly on the pointer !
685 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
686 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
687 the python part recompiles
689 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
690 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
691 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
692 X session is killed (for my computer... it seems to not be identic on
695 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
696 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
697 avoid problems (otherwise, the difference test between the visible image
698 and the reference is incorrect. If the reference is greater than the
699 screen resolution, it's produce errors).
700 Can be used for only one image. Can be used with a visible flag.
701 * vtk/vtkGdcmReader.cxx : remove commented codes.
702 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
703 under windows at compilation
704 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
706 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
708 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
709 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
710 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
711 tests on the image size X, Y, Z
713 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
714 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
715 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
716 between the class name and the file name
718 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
719 * src/ : fix compilation warnings for the Write method (2 different
720 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
721 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
722 variable... create a static method in gdcm::Document to access to
723 this variable content.
725 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
726 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
727 file, to be accessed by other files (like gdcmFile). Remove commented
728 code. Move the change of the header to the gdcmFile, using the
730 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
731 To be sure of that (and simplify calls), the Write of the header now
732 gets a file name and not a file pointer (std::ifstream).
733 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
734 DocEntryArchive. Remove all open of the written file
736 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
737 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
739 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
740 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
741 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
743 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
744 some corresponding methods. Write correctly the file and check before
746 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
747 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
748 is now on RGB data (as before my last commit
749 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
751 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
752 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
753 Add a print information of the type of the entry
754 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
755 It was in the gdcmFile, and all write have been regrouped
756 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
757 Write correctly all dicom files (in decompressed mode only at this time)
758 * Test/ : test on files are now made using Raw data and not color data if
760 * Example/PrintFile.cxx : add more printings
762 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
763 * Amelioration of code, remove some code copy. For the loading of
764 BinEntry (in gdcmDocument), add the test to verify if the file is already
767 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
768 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
769 remove a DocEntry in the header (push an empty DocEntry)
770 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
771 lines. Bug fix in the initialization of the PixelConvert and the
773 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
774 use in TestCopyDicom (now this test can run under windows... but fails)
775 * Test/TestCopyDicom.cxx : amelioration of the test :
776 - test the pixels written
777 - add test points to quickly find where is the error
778 - can set a file name input and output in arguments
779 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
780 amelioration of the test output
782 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
783 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
784 all replaced DocEntry's
785 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
786 Now, each needed DocEntry to modify is duplicated, modified and inserted
787 to the header using DocEntryArchive. Thus, after save, we can restore the
788 header initial state.
790 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
791 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
793 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
794 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
795 correct to copy it. The DictEntry is specified at the DocEntry creation,
796 then, it musn't change in the time.
797 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
798 header correctly. At this time, the change is only made for the first
799 level of the Document. In the future, it might consider sequences.
800 The change is made by replacing a DocEntry by an other that is created
801 outside the class. The old value is kept. When we restore the header
802 status, the added DocEntry is deleted and replaced by the old value.
803 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
804 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
805 set the write type to explicit VR, implicit VR or ACR. Add methods to set
806 the write mode to native, decompressed or RGB (but not used at this time)
808 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
809 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
810 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
812 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
813 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
814 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
816 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
817 set because already copied when copying the BinEntry's of the header
818 * Test/TestAllReadCompareDicom.cxx : remove warnings
820 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
821 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
822 Two problems appear when doing it :
823 - with the gdcmFile : when the GetImageData method is called, the pixels
824 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
825 data (pixels). And each structure destruct the data when it's
826 destructed. So we have two destructions for the same data. To solve it,
827 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
828 data or not. If it doesn't own data, then they will not destroyed by
830 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
831 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
832 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
833 create a double destruction of the same DocEntry's. So, to solve it,
834 the TagHT is simply cleared and the DicomDir* elements are destroyed.
835 * TODO : add an entry concerning memory leaks in the DicomDir
837 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
838 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
839 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
842 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
843 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
844 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
845 after it have been deleted
847 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
848 * FIX: src/* fix the doxygen warnings.
849 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
850 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
851 was erroneously defined with a size of 15 instead of 16. [many thanks
852 to Jean Michel Rouet for pointing out this bug].
854 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
855 1. Finish merging JMR patch for writting DICOM from scratch
856 2. Fix -hopefully- bug with MONOCHROME and space vs null character
857 3. Use const ref when possible
858 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
859 5. A few more comments
860 6. CreateUniqueUID can now be called without parameter"
862 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
863 * ENH: Slightly bigger patch:
864 1. Getting toward full integration of JMR patch for writting dicom from scratch
865 2. Update Test to test part of this patch: CreateUniqueUID
866 3. File was not close properly in gdcmDict
867 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
868 5. Use of const ref instead of copy (speed issue)
869 6. Remove temporary (duplicate) string in TranslateToKey
870 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
871 8. Do not repeat virtual in subclasses
872 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
874 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
875 * Apply first patch toward better string comparison when dealing with broken
876 DICOM files. Essentially the string could be padded with a space instead
877 of a null character as defined by standard
879 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
880 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
881 because never used... and in the same time, that's remove some memory leaks
883 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
884 * src/gdcmFile.cxx : now delete the PixelConvert instance.
885 * In examples and tests : change the type of image data variables from void*
886 to uint8_t*. Remmove all delete on image data variables
888 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
889 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
890 Verify the file pointer value before open the file, and if it's not null,
891 a verbose message is generated.
892 Close correctly the file when the file isn't considered dicom-like. The
893 correctly close is a call to CloseFile.
894 When closing the file pointer, test if its not null to close the file.
895 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
896 file. For an uncompressed image, the copied data correspond in the least
897 case to the image size (calculated) or the image size specified in the
898 header. A verbose is generated if these two size mismatch
900 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
901 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
902 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
903 break under windows (with msvc6 compilation).
905 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
906 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
907 compiling with MSVC6)
909 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
910 * Bugs fix for the Windows build with VC6
911 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
912 needed (only for projects required VTK). If the VTK is included in all
913 projects, there is conflicts with the jpeg lib of vtk when compiling the
914 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
915 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
916 when compiling the gdcm_wrap.cxx file (created by the compilation of the
918 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
919 (like it's already made for the cout use). Otherwise, conflict with the
922 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
923 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
925 - comments on the DicomDir::Method related usage added.
926 - now that we use the namespace gdcm, a lot of internal classes do
927 NOT need to be wrapped anymore.
928 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
929 DicomDir::Method) new example added.
931 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
932 * Improve string manipulation. I now inforce the notion of 'DicomString'
933 A DicomString can contain as many \0 as they want
934 and it is *always* of even length.
935 We only support odd length for very rare case.
936 And in the near future this should be removed.
938 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
939 * /binary_write/ gdcm source. Now even on big endian we are writting
940 little endian. This should -heopfully- fix some tests
942 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
943 * Now the dictionary is compiled into gdcm lib. This is a default
944 behavior, thus any dic file specified is picked before failback to
945 the one comiled into lib
947 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
948 * Change internals for gdcmDict. Don't use any 'new' any more.
949 This should definitely solve any leak problem, and we should be
950 as fast as before, as long as don't modify too much the dictionary.
952 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
953 * STYLE: ivars should start with a capital letter.
954 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
955 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
957 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
958 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
959 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
960 new 2004 dictionaries added (thanks to JPR).
961 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
962 * CLEANUP_ROUND (15) for gdcmPixelConvert
963 - RLEFrame::NumberFragments is now of type unsigned int
964 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
965 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
968 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
969 * Initial work in gathering all transfer syntax accessors. clearly
970 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
971 ivars, but only one transfersyntax (class) ivar with equivalent method on
974 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
975 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
976 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
977 discussed (plus I didn't like having a 2000 lines patch not commited)
979 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
980 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
981 * CLEANUP_ROUND (14) for gdcmPixelConvert
982 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
983 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
984 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
986 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
987 anymore and hence avoids storing a copy of PixelConvert::Decompressed
988 into File::Pixel_Data.
990 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
991 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
992 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
993 * CLEANUP_ROUND (13) for gdcmPixelConvert
994 Substituted File::ParsePixelData() with PixelConvert::Print() new
996 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
997 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
998 method to those classes.
999 - src/gdcmFile.[cxx|h]:
1000 -- Added a ::Print() method.
1001 -- PixelConverter is now a reference instead of a member.
1002 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1003 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1005 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1006 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1007 collaboration diagram and inheritance diagram should be generated with
1009 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1010 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1011 pointlessly wrapped (see
1012 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1013 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1014 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1015 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1016 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1017 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1018 -- File::Initialise: PixelConverter setup moved away to
1019 PixelConverter::GrabInformationsFromHeader()
1020 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1021 interpretation moved away to PixelConverter::BuildRGBImage()
1023 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1024 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1025 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1027 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1028 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1029 displayed on Win32 when a brutal abort() occurs (because of uncatched
1030 exception). See TODO new entry of this commit for more on this.
1031 * TODO added new entry.
1032 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1033 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1034 - HandleColor is no longer called from gdcmFile.cxx
1035 - gdcmPixelConvert.cxx clean up on method arguments and internal
1036 variable names for semantical coherence.
1038 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1039 * Finished lossless transition, not only do we now read all lossless jpeg
1040 images, without the need of the Cornwell lib, but we do read them properly now
1041 * To reduce code (well to avoid code duplication), I defined a common place
1042 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1043 redefine symbols. This is not perfect but this the best solution I found for a
1044 compilation time jpeg option.
1046 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1047 * Update jpeg ijg lib to support lossless jpeg implementation
1048 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1050 * Also added a special copyright for dcmtk since we use their bugfixes.
1053 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1054 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1055 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1056 matters, as stated in warning note at beginning of %include section).
1057 * src/gdcmDicomDir*.[cxx|h]: coding style
1058 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1059 * src/gdcmJpeg8.cxx: doxygen fix.
1060 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1061 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1062 from File:: to PixelConvert::.
1064 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1065 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1066 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1067 - more code moved away from File:: to PixelConvert::
1068 - fat setup of PixelConverter set in place in File::Initialise.
1070 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1071 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1072 namespace at the file system level. So now you should convert your examples
1074 gdcmHeader -> gdcm::Header
1075 It would be nice if people keep in mind to no open the namespace, since it
1076 allows compilation on broken plateform which were defining common symbol in
1077 the standart namespace (like LP, Unknown ...)
1079 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1080 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1081 The JPEG fragments are now parsed at the same stage than the RLE
1082 information. All code related to JPEG is now in gdcmPixelConvert:
1083 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1084 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1085 export a gdcmFile:: method. Those are simply global functions
1086 (for the time being this is better than having them attach to
1087 either gdcmFile:: or gdcmPixelConvert::).
1088 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1089 and stores the result in a gdcmJPEGFragmentsInfo.
1090 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1091 code (among other stuff) moved away from gdcmFile:; to
1094 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1095 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1096 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1097 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1098 clean up of RLE related code.
1099 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1100 - src/gdcmRLE.cxx removed
1101 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1102 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1103 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1104 * CLEANUP_ROUND (9) for gdcmPixelConvert
1105 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1106 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1107 away from gdcmFile:: to gdcmPixelConvert::.
1109 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1110 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1111 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1112 This is because Parse7Fe0 used to parse the pixels to compute the
1113 length. This task was passed over to FindDocEntryLengthOB() a long
1114 time ago, EXCEPT I had forgotten the OW case...
1115 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1116 we just recylce the code for parsing RLE fragments and computing
1118 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1119 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1120 with the retired Parse7Fe0().
1121 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1122 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1124 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1125 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1126 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1127 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1128 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1129 * CLEANUP_ROUND (4) for gdcmPixelConvert
1130 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1131 to return an unused length.
1133 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1134 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1135 this should be cleanner from the plane view. The iostream are erally a pain
1136 to use to do simple stuff.
1138 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1139 * Redo the compilation of the ijg jpeg library. Now only one source is
1140 necesseray. No need to rename file by hand what so ever. CMake handle the
1141 copying of the file within different directory, configure header file to
1142 modify some symbol. The only addition made to ijg wasd a mangle table so
1143 that symbol are different whether we are within 8bits or 12bits.
1145 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1146 * Added documentation of vtkgdcmReader on Website:
1147 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1148 with it's binary name).
1149 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1150 the Website to be more complete.
1151 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1152 doxygenated documentation.
1153 - Doc/DoxyVtkGdcmReaderExamples.txt added
1154 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1155 DoxyVtkGdmReaderExamples.html )
1156 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1157 * CLEANUP_ROUND (3) for gdcmPixelConvert
1158 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1160 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1161 * CLEANUP_ROUND (2) for gdcmPixelConvert
1162 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1164 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1165 * CLEANUP_ROUND for gdcmPixelConvert:
1166 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1167 - src/gdcmPixelStuff[h|cxx] removed
1168 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1169 - src/CMakeLists.txt changed accordingly
1170 * GDCMHOME clean up:
1171 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1172 gdcmVersion.py moved to newly created ATTIC related
1173 gdcmPython/SetupOldies/ directory.
1174 * Autotools clean up:
1175 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1176 - autogen.sh configure.in acinclude.m4 python.m4 removed
1178 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1179 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1180 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1181 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1183 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1184 * TODO updated with Mathieu suggestions. I proposed a template for
1185 describing TODO entries and used it for new entries.
1186 * Added Doc/Website/CodingStyle.html, Developpers.html,
1187 DeveloppersPython.html, GdcmDataCvs.html and
1188 DownloadVersion0_1.html, DownloadVersion0_3.html.
1189 * Some Doc/*.txt Doxygen files (which do not really concern the
1190 documentation itself, but the website) moved to html and
1191 placed in directory Doc/Website:
1192 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1193 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1194 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1195 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1196 * CMakeLists.txt changed accordingly.
1197 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1198 DeveloppersPython.html
1199 * INSTALL nows refers to Doc/Website/Installation.html
1201 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1202 * Added Doc/Website directory, that contains a first raw version
1205 2004-09-23 Jean-Pierre Roux
1206 * FIX In order not to be poluted any longer by casting problems,
1207 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1208 we can now delete[] it safely
1209 * VoidArea is now called BinArea (less confusing name),
1210 and all the methods called ...VoidArea... are now ... BinArea...
1211 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1213 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1214 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1215 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1216 up to the destructor of gdcmElementSet to clean up TagHt and it's
1219 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1220 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1221 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1223 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1224 * ENH: added some utility method that builds a flat dictionary
1225 holding all the Dicom entries contained in the recursive structure
1226 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1227 an example of usage.
1228 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1229 BuildFlatHashTable() that build a flat dictionary.
1230 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1231 gdcmDocument is now a friend of gdcmElementSet.
1232 - src/gdcmElementSet.cxx: clean up.
1233 - Example/FlatHashTablePrint.cxx added.
1234 - Example/CmakeLists.txt changed accordingly
1236 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1237 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1238 moved away from gdcmDocEntrySet (since this class is an abstract class
1239 acting like an interface). SQDepthLevel and BaseTagKey are now
1241 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1242 and associated accessors. Doxygenation of the class.
1243 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1245 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1246 Use SQDepthLevel accessor instead. ::Print() adapted.
1247 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1248 - src/gdcmDocument.cxx changed accordingly.
1250 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1251 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1252 - The following is the doxygen comment of the typedef declaration
1253 of gdcmTagKey in src/gdcmCommon.h:
1254 gdcmTagKey is made to old an "universal" (as in URL, Universal
1255 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1256 A dicom tag always has a group and an element, but a set of tags
1257 embeded in various (optionally nested) sequences and sharing
1258 the same group and element all share the same (group, element)
1259 "identifier". Hence the (group, element) cannot be used as an
1260 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1261 In order to construct a proper tag identifier (i.e. a key) we
1262 consider the following definition of a TagKey:
1263 - let Group, Element be the string representation of the
1264 group and element dicom tag members,
1265 - let ItemNumber be the string representation of the integer
1266 index of the considered item number of a sequence,
1267 Let the key of a tag embeded in a sequence, noted SeqTag, be
1269 /ItemNumber#Group|Element
1270 where "/", "#" and "|" are characters acting as separators.
1271 Then the general form of a gdcmTagKey is given by:
1272 Group|Element<SeqTag>
1273 where <SeqTag> means NO or many instances of SeqTag.
1274 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1277 but the gdcmTagKey of a tag "embeded" is the first item of
1278 a sequence, itself nested in the third item of a sequence is the
1280 0004|1220/2#0008|0082/0#0008|0090
1281 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1282 order to hold the new sequence compatible key. Previously, the
1283 GetKey() method would look in the underlying gdcmDictEntry.
1284 - src/gdcmDocEntry.cxx:
1285 -- constructor now copies the underlying DictEntry key, in the local
1287 -- ::Print: displays the member Key, instead of the (group, element).
1288 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1289 - src/gdcmDocEntrySet.h:xi
1290 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1291 -- now has a new BaseTagKey member.
1293 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1294 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1296 This poses the problem with the semantics of the following lines
1297 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1298 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1299 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1300 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1301 to the long FIXME note for what the problem is. Nevertheless in
1302 order to get things working the dicom dictionary was altered !
1303 Please fix things urgently...
1304 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1305 information), see above note on moving the member VoidArea. Nevertheless
1306 the following entries previously correctly set as US are now inproperly
1308 0028 1201 OW IMG Red Palette Color Lookup Table Data
1309 0028 1202 OW IMG Green Palette Color Lookup Table Data
1310 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1311 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1312 of gdcmDocEntry moved to gdcmSeqEntry.
1313 * src/gdcmSeqEntry.cxx: STYLE.
1315 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1316 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1318 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1319 * gdcmPython/testSuite.py: all the test suite in python is now moved
1320 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1321 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1322 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1324 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1325 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1326 to avoid inclusion recursion until STL is reached.
1327 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1328 mecanism. errno.h is not included in gdcm anymore.
1329 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1330 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1332 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1333 gdcmData/TestAllEntryVerifyReference.txt
1334 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1335 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1336 exception_on_error parameter.
1337 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1338 - vtk/vtkGdcmReader.cxx changed accordingly,
1339 - Example/*.cxx and Test/*.cxx changed accordingly.
1341 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1342 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1343 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1344 enable_sequences removed from gdcmHeader constructor and dependencies.
1345 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1346 * gdcmPython/demo/PrintHeader.py: dummy fix.
1347 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1348 skip_shadow removed from gdcmHeader constructor and dependencies.
1349 * Example/*.cxx and Test/*.cxx changed accordingly.
1351 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1352 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1353 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1355 2004-07-21 Jean-Pierre Roux
1356 * FIX Now, Parsing and Printing a DICOMDIR do work!
1357 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1359 2004-07-20 Jean-Pierre Roux
1360 * FIX Some brain damaged headers have Zero-Lenght fields
1361 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1363 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1364 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1365 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1366 variable (instance of gdcmDebug) by a definition macro, and the instance
1367 is now in static in the gdcmDebug class
1368 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1369 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1371 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1372 * WARNING: ctest now depends more tightly on gdcmData. You should
1373 check out gdcmData properly for things to run smoothly...
1374 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1375 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1376 we need the pixels not be loaded in order to use the ValEntry
1377 that displays position and size).
1378 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1379 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1380 be deprecated. If you have any doubts about the advantages of a
1381 modern scripting language (read Python) versus grass root C++ (i.e.
1382 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1383 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1384 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1385 Anyhow, consider documenting the gdcmData images in
1386 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1388 * Test/CMakeLists.txt:
1389 - now uses TestAllEntryVerify.cxx
1390 - specific comments on oldACR00001.ima (now renamed in gdcmData
1391 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1392 gdcmData/TestAllEntryVerifyReference.txt
1395 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1396 * src/*.[h|cxx] : typedef clean up
1397 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1398 - TagKey renamed to gdcmTagKey (for external usage)
1399 - VRKey renamed to gdcmVRKey (for external usage)
1400 - removal of typedef duplication.
1401 - Removed all unecessary inline keyword from class inline definitions.
1402 - Some method|function(void) declarations replaced with method|function().
1403 * src/jpeg/libijg12/jdhuff12.c:
1404 - printf polluting ctest removed.
1405 - TAB removal for comminting
1407 - TestAllReadCompareDicom.cxx: added a test that compares all the
1408 images in gdcmDataImages.h with corresponding images in
1409 gdcmData/BaselineDicom/. When baseline images are not present
1410 this test creates them.
1411 Note: we need to validate each reference image, but before that
1412 I'd like to rename them with a more explicit name...
1413 - CMakeLists.txt: changed accordingly.
1414 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1415 including each header needed).
1417 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1418 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1419 test suite to the Example directory. Are concerned:
1424 - TestWriteSimple.cxx
1425 * Test/CMakeLists.txt: added some comments on reasons for black listing
1426 image gdcmData/oldACR00001.ima
1428 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1429 * Test/CmakeList.txt: removed the following from black list (to be coherent
1430 with removal from gdcmData):
1431 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1432 - gdcm-MR-PHILIPS-16.dcm
1434 Added the following because after last cvs update, they cause
1435 ctest -R TestReadWriteReadCompare
1437 - gdcm-MR-SIEMENS-16-1.acr
1439 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1440 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1441 new comments in this file) we temporarily (sigh) move to a weaker
1443 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1444 we don't need to black list the following images anymore:
1445 - 8BitsUncompressedColor.dcm
1447 - US-PAL-8-10x-echo.dcm
1448 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1449 fixes and the beautified code ;-)
1450 This fixes the bug introduced in version 1.42 (when beautifying)
1451 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1452 Note: ctest was blind to this bug (this means we need to still
1453 improve the test suite). The bug could be detected by using
1454 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1456 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1457 and by displaying the (garbage) produced file temp.XDCM...
1459 2004-06-29 Jean-Pierre Roux
1460 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1461 - replace by uggly but working old code :-(
1462 A lot of things should be OK again.
1463 It's really urgent to have a test suite that *tests*,
1464 to prevent Frog's beautifying sessions to break all the stuff
1465 (twice, withing a fortnigh ...)
1467 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1468 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1469 redundancy) to added Test/TestReadWriteReadCompare.cxx
1470 * Test/CmakeList.txt: because the compare test of
1471 Test/TestReadWriteReadCompare.cxx fails, the following images are
1472 black listed: - 8BitsUncompressedColor.dcm
1474 - US-PAL-8-10x-echo.dcm
1475 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1476 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1477 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1478 and ad-hoc kludge. This kludge is now removed, and on encountering
1479 such an image (OB field brain damaged) we set errno. Then in
1480 ::FindDocLength() we "fix" the length as being ALL what remains
1481 in the file (until EOF). We then proceed, hoping for the best...
1482 This fixes a SegFault in ShowDicom when trying to write such an
1484 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1485 (because TestWriteRead breaks on it, after a non conformal commit?).
1486 ctest now runs properly, except for MakeDicomDir (which was always
1487 broken) and the Python related stuff (still not fixed).
1489 2004-06-24 Jean-Pierre Roux
1490 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1491 FIX : Test/TestReadWrite now iterates on all the file names
1492 (instead of infinite loop)
1493 ENH : Test/TestWriteRead now iterates on all the file names
1495 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1496 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1498 2004-06-24 Jean-Pierre Roux
1499 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1500 when SamplesPerPixel =3
1501 - now Write is no longer confused by
1502 'BitsAllocated = 12" and 'BitsStored=12"
1503 - "UN" value representation Elements are now written correctly
1504 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1505 ENH : - now gdcmHeader has its own Write methods
1506 (in order to split the job that has not to be done
1509 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1510 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1511 loop on the same image until memory went out.
1512 Note: this means we still have gobs of memory loss in PrintDocument
1513 * src/gdcmDocument.cxx: fixes problem on parsing on file
1514 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1516 2004-06-24 Jean-Pierre Roux
1517 FIX : Write - All the Sequences and Sequence Item are now written
1518 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1519 is added a the end, when necessary.
1520 - A lot of brain-damaged images, that were read correctly are
1521 now written correctly
1522 - length compatible BinEntry are now loaded correctly
1523 (even for odd groups)
1524 Note : only Explicit Value Representation was checked.
1525 (question : is implicit VR really necessary for gdcm ?)
1527 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1528 * DEVELOPPER: added a proposition of coding style.
1529 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1532 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1533 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1534 Use the gdcmDocEntry::Print() and Write() instead.
1535 * src/gdcmDocument.cxx: bug fix.
1537 2004-06-22 Jean-Pierre Roux
1538 FIX : gdcmDocument.cxx
1539 - Now we do recognize the JpegLossLess format (there was a misstyping in
1540 code 'beautyfication' :-(
1541 - Now we automaticaticaly load the Luts, if any
1543 2004-06-22 Jean-Pierre Roux
1544 In order : to write Sequences, whatever their imbrication level,
1545 : to allow user to create his own Sequences
1546 a lot of modif where necessary (adding, moving, or virtualising methods)
1548 WARNING : save your own sources *before* cvs up !
1551 ADD virtual void Write(FILE *fp, FileType filetype);
1554 ADD virtual void Write(FILE *fp, FileType filetype);
1555 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1558 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1559 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1560 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1561 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1562 ADD std::string GetEntryByName(TagName name);
1563 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1565 std::string vr = "unkn",
1566 std::string fourth = "unkn",
1567 std::string name = "unkn");
1568 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1569 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1570 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1571 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1572 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1573 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1574 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1575 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1578 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1579 ADD virtual std::string GetEntryByName (TagName tagName);
1580 ADD virtual std::string GetEntryVRByName (TagName tagName);
1581 REM virtual bool Write(FILE *, FileType);
1582 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1583 FILE *_fp, FileType type);
1584 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1585 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1586 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1587 REM virtual std::string GetEntryByName (std::string tagName);
1588 REM virtual std::string GetEntryVRByName (std::string tagName);
1589 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1590 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1591 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1593 std::string vr = "unkn",
1594 std::string fourth = "unkn",
1595 std::string name = "unkn");
1596 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1597 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1598 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1599 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1602 ADD virtual void Write(FILE *fp, FileType filetype);
1605 ADD virtual void Write(FILE *fp,FileType filetype);
1608 ADD virtual void Write(FILE *fp, FileType filetype);
1609 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1610 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1611 REM std::string GetEntryByName(TagName name);
1614 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1616 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1617 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1618 The default constructor invoked by the line
1619 gdcmHeader *f1 = new gdcmHeader( header );
1620 was gdcmHeader::gdcmHeader(bool) instead of the expected
1621 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1622 Hence the parsing wasn't executed... See also below.
1623 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1624 as explicit constructor didn't do the trick to fix the above problem.
1625 Could anyone explain why ?
1626 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1627 properly calls gdcmValEntry::Print() (that was weed out from
1628 code related to gdcmBinEntry).
1630 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1631 * In order to fix memory leaks:
1632 - Test/TestWriteSimple.cxx: added cleaning of free store through
1634 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1635 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1636 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1637 (through the call to ::AddDicomDirMeta()) or the destructor
1638 would crash when deleting uninitialized ::metaElems].
1639 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1640 - src/gdcmDocument.cxx:
1641 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1642 from dynamic stores.
1643 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1644 was causing memory leaks.
1645 - src/gdcmSQItem.cxx:
1646 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1647 cleanly handled with polymophism: sorry but my milage is low).
1648 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1649 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1650 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1651 This avoids SegFaulting.
1652 - src/gdcmSQItem.h: coding style.
1654 - Test/TestWriteSimple still severely sucks. The output image content
1655 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1656 damaged when displayed with vtkgdcmViewer.
1657 - on memory leaks: TestWriteSimple leaks really less (see entry
1658 of 2004-06-18 in Changelog file for the call to valgrind).
1659 - on segfaults: ctest now passes all the tests but one (no more
1661 * Erroneous leading white fix:
1662 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1663 white[s] (as opposed to from >> xxx, that removes it [them].
1664 - src/gdcmTS.cxx: ditto.
1665 - gdcmPython/testSuite.py: dirty related kludge removed.
1666 * src/*: remaining references to gdcmParser removed.
1667 * src/*[cxx|h]: added copy[way]left header.
1670 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1671 * In order to fix writing of dicom files:
1672 - Test/TestWriteSimple.cxx: a simpler example of writing.
1673 - Test/CMakeLists.txt changed accordingly.
1674 - src/gdcmDocument.cxx:
1675 -- The destructor now recursilvely removes potential sequences.
1676 -- Bug fix in ::IsJPEG2000()
1677 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1678 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1680 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1681 to only declared) and build on top of
1682 ::GetDocEntryByNumber(guint16, guint16).
1683 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1684 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1685 for usage in destructor and treatement of promotion in
1686 ::ReplaceOrCreateByNumber().
1687 - src/gdcmSQItem.cxx: destructor should better handle his job.
1688 Test/TestWriteSimple now runs (or at least it DOES something).
1689 * We can now start hutting memory links. A good starting point is:
1690 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1691 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1692 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1694 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1695 * Valgrind note: after Mathieu Malaterre teached me how to read
1696 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1698 Using gcc, you can force the STL to use malloc and to free memory as
1699 soon as possible by globally disabling memory caching.
1700 With 3.2.2 and later, you should export the environment variable
1701 GLIBCPP_FORCE_NEW before running your program.
1702 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1703 simply vanish (it is still not clear to me, whether this means that
1704 STL std::string leaks or if valgrind believes it leaks...).
1705 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1706 running bin/gdcmTests makeDicomDir):
1707 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1708 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1710 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1711 SegFaulting (I drowned in DicomDir related code when trying to
1712 understand why the list is empty...).
1713 * src/gdcmDocument.h: first BSD license header try.
1714 * Doc/License.txt added.
1716 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1717 * src/gdcmDocument.[h|cxx]:
1718 - Clean up of the Transfer related predicates. They are now all based
1719 on new method isGivenTransferSyntax, that (should) handle properly
1720 the padding problem.
1721 - general clean up, simplification, and coding style.
1722 - Specific clean up of Parse7FE0() (umproperly named actually).
1723 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1725 2004-06-14 Jean-Pierre Roux
1727 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1728 - fix the display of SQItem ordinal number
1729 - add the GetSQItemByOrdinalNumber method
1730 - remove some useless never written private methods
1732 2004-06-14 Jean-Pierre Roux
1734 - adding a constructor taking a gdcmDocEntry as an input param
1735 - ReplaceOrCreateByNumber now returns :
1736 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1737 a gdcmValEntry * if a string value is passed as a param
1739 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1740 according to the param type (no longer sets a gdcmDocEntry)
1741 - GetValEntryByNumber, GetBinEntryByNumber added
1742 - NewValEntryByNumber and NewBinEntryByNumber added
1744 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1746 - GetSQItemNumber and SetSQItemNumber added, to provide
1747 a (relative) Item identier inside a given Sequence
1748 \warning : some pb remaining around this number
1750 - AddEntry now takes the Item Number as a param
1752 - adding a constructor taking a gdcmDocEntry as an input param
1754 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1755 * Memory leak hunt with the following command:
1756 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1757 --show-reachable=yes gdcmTests PrintDocument
1758 It looks like many (all?) leaks are due to the STL (or a bad usage
1759 of the STL. The lines producing the leaks now have a comment with
1760 a "MEMORY LEAK" tag: you can retrieve them with
1761 grep "MEMORY LEAK" src/*
1762 Here are two typical examples which I can't help fixing:
1767 char * test = "babo";
1768 name = test; //// <--- valgrind detects 960 bytes lost in
1769 //// call to std::string::operator=(char const*)
1770 name.clear(); //// Doesn't help !
1778 std::cout << "Type a bunch of characters followed by RETURN: ";
1779 getline(std::cin, line); //// <--- valgrind dectects a loss
1780 //// of 1320 bytes in call to
1781 /// std::basic_istream<>& std::getline<>
1787 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1788 * src/gdcmHeader.[cxx|h]:
1789 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1790 and related, moved away to gdcmDocument.
1791 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1792 the corresponding protected accessors of inherited class
1793 gdcmDocument, removed ! As a consequence gdcmFile had to be
1794 declared friend of class gdcmDocument (see below).
1795 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1796 - Clean up of undefined or unused methods.
1797 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1798 account the changes to gdcmHeader.h).
1799 * src/gdcmDocument.h:
1800 - gdcmFile is now a friend class (in order to take into account the
1801 changes to gdcmHeader.h).
1802 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1803 (see changes to gdcmHeader.h).
1804 - Accessors (reading on the form GetEntry*) are now public.
1805 - Clean up of undefined or unused methods.
1806 * src/gdcmDocument.cxx:
1807 - adaptation to changes to gdcmDocument.h
1808 - ::OpenFile now writes a verbose message when file cannot be opened.
1809 - some std::string properly set to VRKey
1810 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1811 references to gdcmDocument.
1812 * Test/TestFindTags.cxx: changed accordingly to above changes.
1813 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1814 cvs repository gdcmData.
1816 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1817 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1818 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1819 conflicts with gdcmValEntry::voidArea.
1820 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1821 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1822 Value representation between StringRepresentable and BinaryRepresentable.
1823 * src/gdcmDocument.cxx:
1824 - method ParseDES: proper indentation restored and usage of
1825 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1826 - method LoadDocEntry: the fingerprint left in the SetValue() of
1827 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1828 removed. Reverting to previous code segment with the proper
1829 dynamic_cast< gdcmValEntry* >.
1830 Note: this was (partially) breaking the python test suite
1831 (gdcmPython/testSuite.py) that made usage of the above
1832 fingerprint to check presence of "Pixel Data".
1833 * src/gdcmDocEntry.h: coding style.
1834 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1835 now taken into account.
1836 * gdcmPython/gdcm.i: adaptation to the new internal representation
1837 of gdcm (exit gdcmParser, hello gdcmDocument).
1838 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1840 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1841 anymore, but instead prints the loaded Python dictionary.
1842 * .... alas, the python testSuite is still broken.
1844 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1845 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1847 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1848 * src/gdcmUtil.h : export methods
1850 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1851 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1853 * Initial addition of automatic python testing
1854 * Initial addition of automatic image comparison
1856 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1857 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1858 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1860 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1861 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1862 * Test/ShowDicom.cxx : bug fix for msvc compilation
1863 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1865 2004-05-04 Jean-Pierre Roux
1866 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1867 new concepts (and new classes) :
1868 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1869 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1870 - Sequence Doc Entries (gdcmSeqEntries)
1871 a Sequence is composed of Items.
1872 Each item is a set of Doc Entries (this is recursive)
1873 The non uniqueness of the 'Dicom tag' is due to this recursivity
1874 (never taken into account)
1875 Our unability to add a new 'entry' in the header
1876 at the proper location (neither in the H-Table (map or multimap),
1877 nor in the Chained List is also due to this recursivity.
1878 Don't try, right now, to use/modify/compile these new sources :
1879 nothing is finished.
1880 We just commit all the stuff, 'as is', in order not to loose it.
1882 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1883 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1885 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1886 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1887 file prefix (SetFilePrefix)
1889 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1890 * Add a new test: ShowDicom, for now this is just the c++ version of
1891 checkRead.sh, later it will be able to compare the image read against a
1893 * Replace the DEBUG on the stack with a global entry in cmake interface:
1894 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1896 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1897 * Add an example subdir, with a real example on how to read + write a
1900 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1901 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1902 * Doc/CMakeLists.txt: the main page is now properly differentiated
1903 between the developper and user version.
1904 * Doc/doxygen.config.in: dropped search related obsolete flags
1905 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1907 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1908 * DEVELOPPER: added some helpfull comments for compile/test/install
1911 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1912 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1913 src directory, now generated in the build dir.
1914 2. Tests as mentionned smarter
1916 4. Add a new method in gdcmDict that return the PubDict by name
1917 this is interesting for 3rd party lib like ITK,
1918 where we could set the institution name / patient name...
1920 * ENH: 1. Now the test suite is working for real
1921 2. All binaries are now output in the gdcm-bin directory
1922 (this was not true before)
1924 2004-04-28 Jean-Pierre Roux
1925 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1926 SeQuence indented printing of Dicom Header.
1927 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1928 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1929 Computation of SQDepthLevel is now part of gdcmHeader constructor
1930 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1931 tree-like structure of a Dicom Header.
1932 * FIX Test code cleaning
1934 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1935 * ENH: Adding automatic testing
1936 1. Need a DartConfig.cmake to submit to public
1937 2. Add a test driver gdcmTest.cxx
1938 3. gdcmTestMain, an helper for the main test driver gdcmTest
1939 4. Files in Test don't have a main anymore, this becomes interesting
1940 when we add more and more tests, thus dsw don't have to load
1942 * ENH: Adding a GDCM_DATA_ROOT for testing
1943 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1944 one file instead of seven + some small cleanup
1946 2004-04-22 Jean-Pierre Roux
1947 * ENH Minor changes to the Print() methods.
1948 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1949 Header printing. Example given with :
1950 > PrintHeader fileName 2 new
1951 (SQ based tree-like structure still to be done for the Header ...)
1953 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1954 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1955 1. I have added some unsigned where needed
1956 2. Some function parameter not used -> (void)
1957 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1958 4. g++ don't like character '\' in comment
1959 5. #define jpeg_create_decompress jCreaDecompress
1960 this really need to be fixed
1961 6. virtualize destructor of gdcmObject ... leakage
1962 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1963 this also really need to be fixed
1964 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1965 remove compression file
1966 (as we only do decompression, right ?)
1967 * ENH: Change malloc/calloc/free with c++ equivalent
1969 2004-04-21 Jean-Pierre Roux
1970 * FIX gdcmHeaderHelper::GetXSpacing
1971 when a single value is found (bug ?), xpacing is now
1972 defaulted to yspacing
1974 2004-04-19 Jean-Pierre Roux
1975 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1976 * ENH add parameters :
1977 bool exception_on_error = false,
1978 bool enable_sequences = false,
1979 bool ignore_shadow = false
1980 to the gdcmFile constructors to be full gdcmParser compliant
1981 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1982 to allow reading of PAPYRUS 3.0 files
1984 2004-04-06 Jean-Pierre Roux
1985 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1987 2004-04-02 Jean-Pierre Roux
1988 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1989 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1990 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1992 2004-03-30 Jean-Pierre Roux
1993 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1994 for ACR file, written out as DICOM files (hope so...)
1996 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1997 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1998 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1999 moved to base class gdcmParser and only the specialisation is kept
2001 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2002 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2003 already does the job.
2004 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2005 (to be consistent with gdcmParser::WriteEntries).
2007 2004-03-30 Benoit Regrain
2008 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2009 upate of the object's instance. It's passed to 2 in the unfavorable
2010 case : one in the ExecuteInformation, one in the ExecuteData
2012 2004-03-29 Jean-Pierre Roux
2013 * ENH : Check on file type to be written moved
2014 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2015 * FIX : gdcmObject::ResetBoundaries now stops properly
2016 when end-of-list is reached
2017 : gdcmVersion modified (as Benoit Regrain asked)
2019 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2020 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2021 * src/gdcmUtil.cxx: added forgotten iostream include.
2022 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2023 equivalent to ExplicitVR in existing code).
2025 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2026 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2027 now contains all the gdcmGlobal related code.
2028 * minor coding style and doxygenation changes.
2030 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2031 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2032 now contains all the Debug related code.
2033 * minor clean-up of includes in src/*.cxx
2034 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2035 CreateCleanString) removed.
2036 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2037 * Doc/DoxyMainPageUser.txt added.
2038 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2039 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2040 src/gdcmDirList.cxx)
2042 2004-03-24 Jean-Pierre Roux
2043 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2045 2004-03-23 Jean-Pierre Roux
2046 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2047 big endian made volumes
2048 * ENH Now gdcmParser constructor and destructor are protected to forbid
2049 end user to instanciate class gdcmParser
2050 (only gdcmHeader and gdcmDicomDir are meaningfull)
2052 2004-03-22 Benoit Regrain
2053 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2054 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2055 gdcmSerie to gdcmDicomDirSerie
2057 2004-03-19 Jean-Pierre Roux
2058 * ENH Now the tree-like structure describing a DICOMDIR comming from
2059 an already existing DICOMDIR file is consistent with
2060 the home-made tree-like structure build ex-nihilo
2061 or build from the files held (recursively) in a Directory
2062 functions gdcmDicomDir::CheckBoundaries()
2063 gdcmObject::SetBoundaries() added
2065 2004-03-17 Jean-Pierre Roux
2066 * REM (Eric Boix bug) : removal of meaningless
2067 gdcmDicomDirImage::NewImage function.
2068 * FIX now file names and directory name are written properly in the
2070 * FIX now gdcmDicomDir constructor may be call without any trick
2073 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2074 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2075 of gdcmDicomDirImage::NewImage as empty function.
2077 2004-02-28 Jean-Pierre Roux
2078 * ENH add gdcmDicomDir:NewPatient
2079 add gdcmDicomDirPatient:NewStudy
2080 add gdcmDicomDirStudy:NewSerie
2081 add gdcmDicomDirSerie:NewImage
2082 to allow making gdcDicomDir object.
2083 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2084 (as opposite to the gdcmHeader chained list)
2086 2004-02-11 Benoit Regrain
2087 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2088 when using from python
2090 2004-02-10 Benoit Regrain
2091 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2092 * FIX : in gdcmDicomDir when the directory is empty
2093 * ENH : add callback and methods to get the progression of dicomDir
2096 2004-02-06 Jean-Pierre Roux
2097 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2098 - GDCM_META added to gdcmDicomDirType
2099 - class gdcmMeta created
2100 * ENH : - A brief summary is now displayed at the beginning of
2101 'testDicomDir' to help disaster magnitude estimation
2102 * REM : Now useless Test/explDICOMDIR.cxx
2104 2004-02-05 Benoit Regrain
2105 * ENH : add methods in gdcmObject to get the hash table or the list of
2107 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2108 * FIX : wrapping python for TagHeaderEntryHT
2110 2004-02-04 Benoit Regrain
2111 * FIX : even length for some strings when writting the dicom dir
2112 * FIX : sort the images in the dicom dir
2113 * FIX : Bug fix for python use of dicom dir
2114 * ADD : a python demo
2116 2004-02-04 Jean-Pierre Roux
2117 * FIX : Final solution (?) for icone embedded images
2118 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2119 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2120 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2121 gdcmData/gdcm-MR-SIEMENS-16.acr1
2122 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2123 to make full checking easier
2125 2004-02-04 Benoit Regrain
2126 * FIX : WriteEntries : coding style & logic in parameters
2127 * FIX : Set the elements to create the DicomDir in a dictionary file
2129 2004-02-03 Benoit Regrain
2130 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2131 * gdcmDicomDir : add the load of directory
2132 * Bug fix and print add-on
2134 2004-02-03 Jean-Pierre Roux
2135 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2136 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2137 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2138 * FIX gdcmParser.cxx : 'group length' elements are now considered
2139 as integers, even for shadow groups, when file is Implicit VR
2141 2004-02-02 Jean-Pierre Roux
2142 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2144 of the last synonym :-(
2145 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2147 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2148 * FIX taking into account the possible 7fe0,0010 multiplicity
2149 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2150 to allow removal of references to 7fe0,0010, to deal with
2151 ACR-NEMA images, when 0028,0200 is meaningfull
2153 2004-01-31 Jean-Pierre Roux
2154 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2155 no longer writes 'Un' on disk
2156 * FIX SQ elements with actual length are now dealt with corectly
2157 * FIX gdcmFile::WriteBase make the difference, for color images, between
2158 the length (for Palette expanded images)
2159 and Raw Length (non expanded image + Palette)
2160 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2161 (that broke Write). Replaced by UL.
2162 Aware user will reload the field if he
2163 thinks it's necesssary
2165 2004-01-30 Jean-Pierre Roux
2166 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2167 when 'dirty Acr' is found, to be compliant with the new
2168 IsReadable() methods.
2170 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2171 (no DOUBLE images in kosher DICOM,
2172 but so usefull for people that miss them ;-)
2174 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2175 DICOMDIR related utilities (not checked as Windoze compliant)
2177 2004-01-28 Jean-Pierre Roux
2178 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2180 2004-01-27 Jean-Pierre Roux
2181 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2182 to allow skipping the shadow elements, to save memory space.
2183 The TRUE value for this param has to be used
2184 with a FALSE value for the 'enable_sequence' param.
2185 ('public elements' may be embedded in 'shadow Sequences')
2186 * gdcmHeader methods now deal with 'embedded icones images' in the header
2187 (even when an 'icone image sequence' is announced by the
2188 element (0x0088,0x0200), but there is NO icone at all ...
2190 * gdcmHeader sometimes Image Location value doesn't follow
2191 the supposed processor endianity (see gdcmData/cr172241.dcm).
2194 * gdcmHeader add the method
2195 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2196 to get *all* the Header Entries with the same tag.
2197 GetHeaderEntrySameName is probabely *useless*
2198 (no meaning : Name is *not* an identifier within the Dictionary)
2200 2004-01-26 Benoit Regrain
2201 * Bug fix in the print of hexadecimal representations. Remove long fields
2202 in the print and add a third level of print to print them
2204 2004-01-23 Benoit Regrain
2205 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2206 * Bug fix on test suite after remove the strip made on not string fields
2207 * Split the IsReadable method between gdcmParser which test that the file
2208 is dicom and gdcmHeader which test that it's an image file
2210 2004-01-22 Benoit Regrain
2211 * DicomDir : clean code, add methods, set variables in protected or private
2212 * gdcmUtil : bug fix for the clean string method
2214 2004-01-19 Benoit Regrain
2215 * Add the use of shadow dictionaries
2216 * bug fix and coding style
2218 2004-01-19 Benoit Regrain
2219 * src/gdcmFile.cxx : bug fix concerning the close of file
2220 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2221 * Add the update of header entries using the shadow library
2223 2004-01-19 Benoit Regrain
2224 * removal of file gdcmHeader2.cxx
2225 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2226 inheriting from gdcmParser. This split is to prepare the integration
2227 of dicom dir parsing
2228 * bug fix under python
2230 2004-01-16 Jean-Pierre Roux
2231 * REM removal of class gdcmHeaderEntrySet
2232 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2233 * ADD add file gdcmHeader2.cxx
2234 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2236 2004-01-15 Benoit Regrain
2237 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2238 entries created while parsing the header. Thus, they will be destroyed
2239 when the gdcmDictSet will be destroyed
2240 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2243 2004-01-15 Benoit Regrain
2244 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2245 made a fatal error because of the memory release at the end of program.
2246 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2247 some memory and vtk seems to have some problems with that.
2248 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2250 2004-01-14 Benoit Regrain
2251 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2252 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2253 * src/*.[h|cxx] : make changes due to class name changes
2254 * gdcmPython/demo/*.py : bug fix due to method names
2256 2004-01-13 Benoit Regrain
2257 * src/*.[h|cxx] : coding style
2258 * vtk/*.[h|cxx] : coding style
2260 2004-01-13 Benoit Regrain
2261 * gdcmPython/testSuite.py : test the readable flag of file for tests
2262 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2263 It's lied to the stl compilation by MSVC (windows, always windows...)
2264 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2266 2004-01-12 Benoit Regrain
2267 * src/*.h : add comments
2268 * src/gdcmDictSet.h : set the method BuildDictPath in public
2269 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2270 directly setted in the source code
2271 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2274 2004-01-09 Benoit Regrain
2275 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2276 * setup.py : use a reference to gdcmVERSION
2278 2004-01-07 Benoit Regrain
2279 * Modification to compile with the distutils.
2282 2003-12-10 Benoit Regrain
2283 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2284 can use a gdcmHeaderHelper to load data
2285 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2286 made in the source code
2288 2003-12-10 Benoit Regrain
2289 * Update Windows projects and .cvsignore files
2291 2003-11-12 Jean-Pierre Roux
2292 * ENH gdcmHeader constructor has one more parameter (default value : false)
2293 that allows the user to 'go inside' the SeQuences only
2295 gdcmElValSet:Print takes it into account
2297 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2298 * ENH: Update gdcmPython/CMakeLists
2299 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2300 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2302 2003-11-10 Jean-Pierre Roux
2303 * FIX : gdcmHeader::LoadElements is now based
2304 on the ListTag listElem member,
2305 not longer on the TagElValueHT tagHt member
2306 * ENH : PrintPubElVal shows (temporarily) both results,
2307 with the tagHt member and the listElem member.
2308 (it's easier to 'see' the problems when using Printheader)
2310 * FIX : old private member LgrElem is now splitted into
2311 ReadLength : Length actually found on disk (updated only
2312 if bug fixing is necessary), for internal
2314 UsableLength : Updated by FixFoundLength, to fix a bug
2315 or to allow Parser going on.
2316 Will allow to re-write a kosher header when a SeQuence
2317 with a length (not 0000) is found
2318 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2319 because gdcmElValSet::Add does not update ListElem
2322 2003-11-07 Jean-Pierre Roux
2323 * FIX misstyping in Transfert Syntax name table
2324 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2325 when they have an actual length (not 0000 nor FFFFF)
2326 (Nobody should care of it, but DICOMDIR explorers)
2328 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2329 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2331 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2332 * ENH: vtkGdcmReader now supports LUT !
2333 (vtkgdcmViewer for now is not able to use them though)
2335 2003-11-05 Jean-Pierre Roux
2336 * in testSuite.py : new files names for checking the package
2337 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2338 that returns the pixel area size to the *aware* (vtk) user
2339 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2341 2003-11-05 Benoit Regrain
2342 * in testSuite.py : Modify the rules for checking the paths
2343 : Explicit error messages
2344 * in __init__.py : Related modif
2346 2003-11-03 Jean-Pierre Roux
2347 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2348 to be used by aware (vtk) users that want to manage
2349 LUT (and no to turn the PALETTE image into an RGB pixels one)
2350 * GetPixelType now returns 8U for 24 Bits images
2351 (vtkGdcmReader compliant)
2353 2003-10-31 Jean-Pierre Roux
2354 * Removal of *all* gdcmData images and add them again
2355 in order to loose the 'history' of un-anonymised images
2357 2003-10-31 Jean-Pierre Roux
2358 * RMV : removal of useless jBitsInJsample.h
2359 for both 8 and 12 Bits JPEG Lossy Libraries
2361 2003-10-31 Jean-Pierre Roux
2362 * ENH : Add the functions gdcmFile::GetImageDataRaw
2363 gdcmFile::GetImageDataIntoVectorRaw
2364 that act as GetImageData and GetImageDataIntoVector
2365 except the making of an RGB Plane from Gray Plane + LUT
2366 Intended to aware (vtk) users who know how to manage
2369 GetLUTRGBA return a R,G,B,A LUT if any
2370 lgrTotaleRaw gives the 'Raw' length
2371 GetImageDataRaw returns the gray Plane
2372 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2373 (They stay Grey, just like with other Dicom viewers :-(
2375 2003-10-30 Jean-Pierre Roux
2376 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2378 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2379 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2380 being coherents dicom files.
2382 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2383 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2385 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2386 * ENH: Two steps is necessary to please VC++ compiler...
2387 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2388 * ENH: Add include dir to medcon lib
2389 * FIX: only one function is being exported for now !
2390 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2392 2003-10-29 Jean-Pierre Roux
2393 * adding gdcmHeader::GetLUTRGBA
2394 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2395 --> Mathieu, the modif u're waiting for is not yet committed
2396 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2398 2003-10-27 Jean-Pierre Roux
2399 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2400 00191113.dcm DermaColorLossLess.dcm
2401 MxTwinLossLess.dcm RadBWLossLess.dcm
2402 * ENH: For version prior to vtkImageViewer2 -r 1.19
2403 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2405 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2406 * Removal of ido stuff in CMakeLists.txt
2408 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2409 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2410 * FIX: remove a call to ->Modified ... see comments
2411 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2413 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2414 * FIX: Problem with path for libvtkgdcmPython
2415 * ENH: Try adding a search script for python site-package
2416 * RMV: Remove some file from medcon lib that are not necessary
2417 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2418 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2419 * FIX: More pragma disable fro VC++,
2420 I don't think I break something as it is also disable in VTK/ITK.
2421 But it fasten debug compilation time.
2423 2003-10-23 Jean-Pierre Roux
2424 * gdcm now deals with 16 Bits Run Length Encoded images
2425 (they are compressed as 2 planes images,
2426 one for the high Bytes, the other for low Bytes)
2428 2003-10-22 Jean-Pierre Roux
2429 * Now CheckRead takes into account :
2430 - the bugged 'Leonardo' Siemens images
2431 - the XA images, sent thru the burning VPRO station
2432 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2435 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2436 * FIX: When copying a Makefile.am to CMakeLists.txt
2437 one should remove the '\'
2439 2003-10-22 Jean-Pierre Roux
2440 * in gdcmData adding a bugged 'Leonardo' Siemens image
2441 (wrong lengths in header)
2442 OK with gdcm, KO with the other viewers :-)
2443 * add a GE dlx XA image, thru the VEPRO burning station
2446 2003-10-21 Jean-Pierre Roux
2447 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2448 for a brutal checking of vtkgdcmViewer compliance
2450 2003-10-21 Jean-Pierre Roux
2451 * add the files for 'xmedcon' Jpeg Lossless library
2452 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2454 2003-10-21 Jean-Pierre Roux
2455 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2457 2003-10-21 Jean-Pierre Roux
2458 * garbage Siemens 'Leonardo' images dealt with
2459 (the patch is easy to remove)
2460 * cosmetic changes to avoid warnings
2462 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2463 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2464 no need to press 'r' now.
2466 2003-10-20 Jean-Pierre Roux
2467 * upgrade of checkRead.sh checkWrite.sh according
2468 to new Jpeg Lossless decompressor
2469 * add US.3405.1.dcm, a genuine RGB medical file ...
2470 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2471 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2473 2003-10-15 Jean-Pierre Roux
2474 * general anonymisation in gdcmData
2475 * adding the 'color files' from
2476 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2477 * adding some well knowed bugged-header images
2478 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2479 waiting for their inclusion in Python testsuite
2481 2003-10-15 Jean-Pierre Roux
2482 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2483 no longer seg faults when file is not found
2485 2003-10-14 Jean-Pierre Roux
2486 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2489 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2490 * TODO: *.in file to genereate a UseGDCM later
2492 2003-10-14 Jean-Pierre Roux
2493 * Some supposed-to-be Dicom Images have no preamble.
2494 OpenFile takes it into account
2495 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2496 * Missing elements added in dicomV3.dic
2497 (just to be affraid : have a look at
2498 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2499 and do it again next year ;->
2501 2003-10-13 Jean-Pierre Roux
2502 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2503 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2504 But there are NOT. It's fixed !
2506 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2507 * FIX: "jpeglib.h" was not found on VC++
2508 * FIX: vtkgdcm was not being installed
2510 2003-10-10 Jean-Pierre Roux
2511 * ENH : OpenFile closes the file if it *really* doesn't look like
2512 an ACR-NEMA / DICOM one.
2513 * FIX : testWrite no longer writes an empty file if the source file
2514 is not gdcm Readable
2515 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2518 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2519 * FIX: CMake generate now documentation
2520 * ENH: out of source doc build !
2521 * ENH: Generate both user and dev documentation
2522 * ENH: Should work on windows too
2523 * ENH: Only one doxygen config.in file is needed
2524 * FIX: make install should be ok now on ùnix plateform
2525 * FIX: PATH to dictionary was wrong (missing /)
2526 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2528 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2529 * vtkGdcmReader is now able to read rgb dicom file.
2530 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2531 * added a gdcmViewer to vtk test, use mouse to control
2532 window level & window width
2534 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2535 * CMake-ification of gdcm, we have now two build system
2536 * FIX: on cygwin Wsock32 doesn't exist
2537 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2539 2003-10-06 Emanuel Ollart
2540 * FIX : compilation process wad broken.
2541 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2543 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2544 * change gdcmViewer -> vtkgdcmViewer
2545 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2547 2003-10-06 Jean-Pierre Roux
2548 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2549 ( e.g : well known GE images with a wrong elem length,
2550 : Philips MRI Images with a wrong Huffman table)
2551 * still to be done : allow the reading of bugged LEONARDO Siemens images
2553 2003-10-03 Jean-Pierre Roux
2554 * Odd length strings are padded with '\0' (not with spaces,
2555 to remain compliant with already defined strings,
2556 like Transfert Syntax UID and others)
2558 2003-10-03 Jean-Pierre Roux
2559 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2560 to allow displaying RGB images (not only by affim ;-)
2562 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2563 * vtkGdcmReader is now able to read rgb dicom file.
2564 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2566 2003-10-03 Jean-Pierre Roux
2567 * A few nasty patches to allow the reading of a lot of nasty images
2568 ( e.g : well known GE images with a wrong elem length,
2569 : Philips MRI Images with a wrong Huffman table)
2570 * still to be done : allow the reading of bugged LEONARDO Siemens images
2572 2003-10-03 Jean-Pierre Roux
2573 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2575 2003-10-03 Jean-Pierre Roux
2576 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2577 to allow displaying RGB images (not only by affim ;-)
2579 2003-10-03 Jean-Pierre Roux
2580 * gdcmFile::GetImageDataIntoVector now
2581 - deals with MultiFrames MultiFragments Run Length Encoded files
2582 - deals with YcBcR (YBR_FULL) files
2583 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2584 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2586 (no sample found :-(
2588 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2589 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2590 Two reasons: - clear things
2591 - third parties acces gdcm through header files, so won't
2592 suffer anymore VC++ complains
2594 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2595 * add argv[1] in testvtkGdcmReader.cxx
2598 2003-09-24 Jean-Pierre Roux
2599 * The lines are now eigthy characters long.for
2600 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2602 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2603 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2604 char* to std::string. Thus, the use of strdup becomes useless. (see
2605 previous commis of Malaterre)
2606 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2607 before the last Malaterre's commit.
2609 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2610 * This commit should fix the Debug building under VC++, the problem
2611 was mainly a mixture of debug and release lib being loaded at startup.
2612 * I also remove a depency to a specific C function: strdup. Because I had
2613 to force the link to msvcrtd (whereas strdup is in libc).
2615 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2616 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2617 located in the gdcmCommon.h file. All use of reference of tha has been
2618 changed to now use the variable GDCM_UNFOUND.
2620 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2622 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2623 Dicom dictionary. The test suite can now be run again. Note:
2624 I'm note very happy with the " (RET)" changes. I believe this
2625 RETAINED comment should be dropped when parsing the dictionary.
2626 - PACKAGER corrected
2628 - AUTHORS updated and now in alphabetical order
2629 * Makefile.am now exports gdcm.dsw for Windoze users.
2631 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2632 * cygwin complains about missing std:: in subdir Test/
2634 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2635 * remove some methods that are now in gdcmHeaderHelper
2637 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2638 * vtkGdcmReader set spacing and origin correctly
2640 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2641 * Fix a few delete/delete[] mismatch
2643 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2644 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2645 interpretation to data given by gdcmHeader. For instance there are
2646 heuristics to get informations (look at different places).
2647 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2648 sorting DICOM images based on different strategies.
2649 * modified Makefiles accordingly.
2651 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2652 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2653 when building in debug mode
2654 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2655 src/win32/gdcmdll.dsp
2656 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2658 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2659 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2662 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2663 * src/win32/libgdcmjpeg12.dsp was not dos format
2664 * src/win32/libgdcmjpeg12.dsp :
2665 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2666 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2668 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2669 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2671 * src/gdcmFile.cxx : bug fix in affectation type
2672 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2673 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2674 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2675 symbols... future problem ?
2677 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2678 * src/win32/libgdcmijpeg12.dsp was missing
2679 * modified gdcm.dsw accordingly
2681 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2682 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2684 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2685 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2686 commit of JPR (before his hollidays to facilitate our work).
2687 * setup.py : bug fix in code. Modifications made while the last commit
2688 of JPR. The code hasn't been tested before the commit... it's so
2689 useless to make that (for best programmer that is JPR) !!!
2691 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2692 * tagged the current version as Version0_3 (i.e. version 0.3)
2694 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2695 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2696 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2697 * *.dsp : modifications to use new libgdcmijpeg8 library
2698 * setup.py : bug fix on VTKPATH variable
2699 * PACKAGER : adding all concerning windows
2701 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2702 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2704 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2705 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2706 test suite reported error.
2707 * PACKAGER file added (describes what a packager must do when
2708 packaging a new release).
2709 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2710 * configure.in: upgraded version number to 0.3.0
2711 * fixing build of rpm (through rpm -ta):
2712 - Doc/Makefile.am exports proper doxygen files
2713 - src/jpeg/libijg8/Makefile.am exports the include files.
2715 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2716 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2717 * src/gdcmHeader.h : formatting code
2719 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2720 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2721 We were obtaining error message from vtk. Now, creation of file list
2722 is made in an internal list to prevent this problem.
2723 Bug fix when output is empty.
2724 Bug fix in update of progress value. Previous commit for this was a bad
2726 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2728 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2729 * src/gdcmHeader.h : added method to get the file name
2730 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2731 files. Added method to remove all files on the input
2732 Added FIXME comment concerning the bad parsing of header made by
2733 ExecuteInformation method (in ExecuteData method)
2735 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2736 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2737 when using make instal.
2738 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2739 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2741 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2742 * setup.py : adding include dir of jpeg lib to compile all sources
2743 * */Win32/*.dsp : JPR fix for windows compilation
2745 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2746 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2748 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2749 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2751 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2752 * setup.py is again effective on un*x (takes into account the
2753 addon of the jpeg library)
2754 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2755 * Doc/Doxy* updated (includes above enhancements)
2756 * INSTALL now points to web documentation
2758 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2759 * src/gdcmHeader.h doesn't make unnecessary reference to
2761 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2763 * src/gdcm*.[cxx|h] :
2764 - to allow compilation with gcc 3.x
2765 -- clean up of STL usage (added explicit usage of std::)
2766 -- small fixes on exceptions.
2767 Note: linking not tested !
2768 - clean of doxygen comments to avoid warnings at documentation
2770 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2771 dependent convertion).
2773 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2774 * Clean up of previous JPR garbage commit (not even commented in the
2776 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2777 - moved all jpeg related files from src to src/jpeg/libijg8, with
2778 addition/modification of Makefile.am and configure.in.
2779 - the testSuite is still brain damage (not guilty).
2781 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2782 * WrapVTK.py : modifications to get correctly vtk source files to
2784 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2785 (FileName -> Filename)
2787 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2788 * vtk/vtkGdcmReader.[cxx/h]:
2789 - UpdateProgress method should now be effective
2790 - removed the limitation on having only images loaded (as opposed
2792 - when building a stack of images/volume, a lesser number of
2793 gdcmHeader and gdcmFile instances should be used (hopefully
2794 accelerating things).
2795 - when building a stack of images/volumes, files which are not
2796 loadable (wrong path-filename, wrong permissions on existing file,
2797 or file not parsable by gdcm) are replaced with a black image
2798 in the stack (for the caller to notice the problem).
2800 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2801 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2803 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2804 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2805 between standard library (std) and vtk library (problems are found
2806 under Windows... thanks Windows !)
2808 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2809 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2811 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2813 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2814 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2816 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2817 * When compiling with distutils (see setup.py) the C++ compiler is
2818 called with different flags than the default ones (with automake).
2819 In order to fix all those warning, I compiled gdcm with the command
2820 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2821 and went for warning fixes:
2822 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2823 up from unused variables.
2824 - vtk/vtkGdcmReader.cxx: potential bug fix.
2825 * src/gdcmHeader.h: Doxygen warning cleanup
2827 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2828 * gdcmPython/gdcm.i:
2829 - typemaps correction to take into account the systematic replacement
2830 of "using namespace std" with std:: prefix e.g. std::list,
2831 std::string... (cf changes of 2003-05-21).
2832 - gdcmGlob global variable of type gdcmGlobal (defined in
2833 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2834 exported to Python a as cvar.
2835 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2836 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2837 gdcmDictSet.GetPubDictTagNames() and
2838 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2839 C++ static methods).
2840 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2841 with the above changes.
2843 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2844 * setup.py, manifest.in : bug fix under linux
2846 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2847 * Modification of setup.py to compile vtk part too. Then, we have 2
2848 wrappers which must work with same distutils. For that, we have a
2849 generic distutils in distusiltsWrapping.py ; with :
2850 - build_extWrap class to wrap generically all extensions,
2851 - ExtensionWrap base class for all wrapping extension that contains
2853 - Wrapper interface which wrap sources
2854 + In WrapSwig.py we have extension and wrapper for Swig
2855 + In WrapVTK.py we have extension and wrapper for VTK
2856 * MANIFEST.in : modifications to consider vtk directory and new python
2857 files for compilation
2859 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2860 * Added python wrappers of vtkGdcmReader vtk class (see the
2861 source in vtk/vtkGdcmReader.cxx) :
2862 - vtk/Makefile.am now builds a library
2863 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2864 python library (as opposed to _gdcm.so wich are the python
2865 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2866 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2868 - configure.in has an additional flag --enable-vtk that needs
2869 to be set to enable compilation of vtk related code, that is:
2870 + vtk/vtkGdcmReader.so and
2871 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2872 + gdcmPython/vtkgdcmPython.so (see above)
2873 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2874 be read when compressed or when HighBit + 1 != BitsStored),
2875 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2876 the usage of the python wrapper of vtkGdcmReader vtk class.
2877 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2878 * src/*.[h] all occurences of stl classes are now prefixed with
2879 std::, and all occurences of "using namespace std;" where removed.
2880 This is to avoid pollution of global namespace in included files.
2881 Apparently vtk does not avoid this pitfall: when using both
2882 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2883 collision of various stl members (principally cout...).
2884 * gdcmPython/testSuite.py now cleanly removes temprory generated
2886 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2887 comply with above changes)
2889 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2890 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2891 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2892 vtk data structure (an image Flip was required).
2893 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2894 * cosmetic changes in documentation.
2896 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2897 * src/gdcmHeader.cxx: the constructor no longer exits when an
2898 unexisting file is given as argument.
2899 * The subdirectory Data (containing all the images used for the
2900 test suite) is not part of this repository anymore. A new module
2901 containing those images is now available at
2902 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2903 with the name gdcmData.
2904 All the python scripts (including the package initialisation file
2905 gdcmPython/__init__.py) were adapated to take this change into
2906 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2908 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2909 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2910 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2911 demo of the usage of this class.
2912 Compilation of this vtk part is only done when using the --enable-vtk
2913 at configure (or autogen.sh) stage.
2915 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2916 * More memory link related corrections and documentation fixes.
2918 - maximum info is obtained with a command of the form:
2919 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2920 --show-reachable=yes PrintHeader
2921 - the remaining reachable blocks seem to come from the STL
2922 allocation scheme through the usage of map and list. It looks
2923 like this memory cannot be freed but it is not a memory leak
2924 (in fact further invocation to the STL would recollect the
2925 unused memory allthough it cannot explicitely be freed).
2926 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2927 of displaying an image parsed with gdcm and displayed with VTK.
2928 Note: some images don't seem to work e.g.
2929 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2930 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2931 Allthough this weakens the semantics, it is a ditch attempt to
2932 make gdcm more thread friendly.
2934 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2935 * Memory link hunt (by using valgrind through the command
2936 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2937 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2938 gdcmHeader::_dicom_vr.
2939 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2940 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2942 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2944 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2945 * src/Makefile.am now exports all the necessary include files at
2949 * UpdateGroupLength replaced by new one
2952 * UpdateGroupLength re-written using H-Table
2953 (named UpdateGroupLengthNew untill checks are over)
2955 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2956 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2957 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2959 - gdcmHeader::GetPubElValSet removed.
2960 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2961 UpdateGroupLength, WriteElements, Write.
2962 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2963 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2964 carried the same semantics.
2965 - src/gdcmHeaderIdo.cxx changed accordingly.
2966 - gdcmFile::WriteBase now regroups all the codes from previous
2967 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2968 - enum FileType moved to gdcmCommon.h
2969 * src/gdcmHeader.cxx AddDefault trashed
2970 * gdcmGetXSize added
2971 * getimageDataSize now calls gdcmGetXSize
2972 * Test/*.cxx changed to agree with above changes
2974 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2975 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2976 (to avoid double call by end user).
2977 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2978 by end user, since gdcmHeader::gdcmHeader now handles it.
2980 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2981 * gdcm/Doc many doxygen changes:
2982 - Doxyfile now has two different versions, DoxyfileUsers that generates
2983 the html.users end users oriented documentation and
2984 DoxyfileDeveloppers that generates the html.developper developper
2985 oriented documentation.
2986 - README changed accordingly
2987 - requirement.txt removed (old design info moved to TODO).
2988 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2989 DoxyMainPage.txt, DoxyPython.txt provide more information.
2990 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2991 be updated by simply regenerating the docs with doxygen and copying
2992 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2993 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2994 all the tests in the form "if (<map>.count() >1)" were removed.
2995 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2996 ill-formed documentation sections.
2997 * src/gdcmHeader.cxx: ditto
2999 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3000 * setup.py fixed for un*x (needed macro for stdint.h)
3001 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3002 un*ces with sh-utils test utility.
3003 * gdcmPython/demo/test.py renamed to PrintHeader.py
3004 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3005 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3006 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3007 * src/gdcm*.cxx JPR's bad inclusion fixed.
3009 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3010 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3011 * gdcmPython/demo/test.py changed accordingly.
3013 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3014 * gdcmPython/Makefile.am fixed linking against libstdc++
3015 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3016 * Swig subdir (historical tests of swig version 1.3.17++) removed
3017 * Test/testChangeEntete.cxx some lines commented out in order to make
3019 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3020 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3022 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3023 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3024 hence the user doesn't need this explicit call.
3025 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3026 i.e. LoadElements() call removed.
3027 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3028 - src/Makefile.am declares the proper flag for g++.
3029 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3030 for adding user defined new tags.
3031 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3032 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3033 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3035 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3036 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3037 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3038 src/Makefile.am : the project should properly compile and install
3039 with the autotools, included the python wrappers part.
3040 * gdcm.spec.in : added a spec file for RPM packaging.
3042 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3043 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3045 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3046 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3047 to exported to the environement (see gdcmPython/testSuite.py
3049 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3050 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3051 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3052 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3053 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3055 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3056 * gdcmPython/__init__.py doesn't crash anymore when running in
3057 in InstallMode or PreInstallMode but with an environment given
3058 value of GDCM_DICT_PATH.
3059 * src/gdcmDictSet.[cxx/h] coding style.
3061 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3062 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3063 * src/gdcm.h general comments moved to TODO, and README
3064 * src/gdcm.h should now be seen as a user commodity (including it
3065 should suffice to fully use gdcm). It is nowhere including within
3066 any of the kernel files src/*.cxx and src/*.h.
3068 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3069 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3070 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3072 * src/gdcm*.cxx only include their corresponding include file
3073 (as opposed to gdcm.h)
3074 * gdcmPython/gdcm.i changed accordingly
3075 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3076 the autogen.sh generated "make snapshot" command to work.
3077 * autogen.sh removed history related references to crea package.
3079 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3080 * distutilsSwigCPlusPlus.py work around some swig portability
3083 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3084 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3085 was done in a last ditch attempt to get setup.py _really_
3086 operationnal. The python/gdcmPython layaout add the advantage
3087 of hidding away the python related distutils specific files
3088 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3089 Alas, the src directory was out of scope (i.e. it's relative
3090 position to setup.py was ../src) which made things impossible to
3091 handle (see previous version of python/setup.py). Crossing fingers...
3093 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3094 * python/setup.py now works on Un*x. (harder than I thougth)
3095 * python/distutilsSwigCPlusPlus.py can now have include files
3096 among the list of sources.
3098 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3099 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3100 * modifications in MSVC projects
3102 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3103 * As stated by the first lines of Test/ExceptionAndPython/README, it
3104 looks like we can move back to original usage of exception within
3105 src/gdcm* and hence remove the errno stuff that was introduced
3106 as a quick and dirty fixture of this problem (added to the TODO).
3107 * Doc/Doxyfile configuration file for Doxygen and corresponding
3108 README file for usage added.
3109 * Test/testWrite.cxx added. This new test comes from a split of
3110 test.cxx that is now reverted to its original purpous i.e.
3111 testing the proper parsing of a Dicom related file.
3112 testWrite.cxx concentrates on testing the IO part of gdcm.
3113 * Test/bug1.cxx (containing a bug on WIn32) added.
3114 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3115 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3116 whose purpose is to publish the content of the TagNames of the
3117 Dicom public dictionary were not accessible without an
3118 instance of class gdcmHeader.
3119 - those methods are now static methods of gdcmDictSet and hence
3120 require no instances at all to be invocated.
3121 - within gdcmDictSet this change required to change some method
3122 to class methods (i.e. are now static) among which SetDictPath
3123 (renamed to BuildDictPath) and LoadDefaultPubDict.
3124 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3125 the above changes by calling the new method classes of gdcmDictSet.
3126 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3127 the above to be effective.
3128 * python/gdcmPython: in order to wrap properly the above changes
3129 for Python, swig version now needs to be > 1.3.17.
3130 * python/gdcmPython/Makefile fixed to adapt itself to new
3131 configure/make shema introduced by Johan Montagnat (thanks for the
3132 contribution). Alas this Makefile cannot be turned into a proper
3133 Makefile.am without some heavy changes in the configure.in
3134 (for python dectection).
3135 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3136 now avoids publishing the empty entries.
3138 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3139 * python/setup.py : bug fix concerning install under windows
3140 ExtraPath reused :-P
3141 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3143 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3144 * Dicts/dicomV3.dic : remove double spaces !!!
3145 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3146 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3149 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3150 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3151 method. Doxygenation.
3152 * src/gdcm.h clean up of JPR spurious comments.
3154 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3155 * python/distutilsSwigCPlusPlus.py now properly collects the
3156 shadow classes generated by "swig -c++" (gdcm.py in our case)
3157 when using "python setup.py install".
3158 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3159 reexports the working classes.
3160 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3161 by the classical C errno scheme. This is to prevent an obscure
3162 behavior of the python wrappers when importing wxPython.wx prior
3163 to gdcmPython (which ended up in an abort call). An illustration
3164 of this oddity can be found in the Test/ExceptionAndPython
3165 subdir (see the README file). This problem probably due to
3166 an combination of g++ and dynamic loading.
3167 * added Test/ExceptionAndPython (see above)
3169 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3170 * Changed the layout of the python part to avoid bloating main
3171 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3172 i.e. the distutils arsenal. All the python related stuff is
3173 again in a python subdir, but the package itself is now in
3175 * setup.py was cleaned up:
3176 - pythonIncludePath removed
3177 - python setup.py bdist target is now functional.
3178 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3179 collision with other packages). gdcmPython/demo/*.py changed
3182 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3183 * python subdir moved to gdcmPython (preparation of distutils packaging).
3184 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3185 distutils installer is operational.
3186 * - gdcmPython/__init__.py now properly loads the swig generated
3187 shadow classes (from gdcm.py).
3188 - gdcmPython/demo/*.py changed to import the package gdcmPython
3189 instead of gdcmPython/demo/load.py.
3190 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3192 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3193 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3194 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3195 entries within the associated public Dicom dictionary resp. the same
3196 information but sorted by the fourth field (PAT, IMG, DIR) of the
3198 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3199 are now in the "???" group.
3200 - python/gdcm.i changed accordingly,
3201 - python/demo/printGroupedPublicDict.py added, that gives an example
3202 of the above new functionalities in Python.
3204 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3205 * src/gdcm.h, gdcmHeader.cxx:
3206 - historic references to glib's g_malloc and g_free (#defined)
3207 were definitively removed.
3208 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3209 * src/gdcmElValSet.cxx:
3210 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3211 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3212 - GetElValue(string) renamed to GetElValueByName.
3213 - Added GetElementByName(string).
3214 * src/gdcmHeader.cxx: added
3215 - GetPubElValRepByNumber(guint16, guint16)
3216 - GetPubElValRepByName(string)
3217 - GetShaElValRepByNumber(guint16, guint16)
3218 - GetShaElValRepByName(string)
3219 - GetShaElValByNumber(guint16, guint16)
3220 - GetShaElValRepByName(string)
3221 - GetElValRepByNumber(guint16, guint16)
3222 - GetElValRepByName(string)
3223 - GetElValByNumber(guint16, guint16)
3224 - GetElValRepByName(string)
3225 * Doc/requirements.txt added.
3227 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3228 * Test/Makefile building now depends on the one of libgdcm.so
3229 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3230 pixel data) aware which enables finding the address (offset) of
3231 the pixel data of JPEG encoded DICOM files. This leaves only a single
3232 file in the testSuite whose pixel data address (offset) is unknown.
3233 * python/testSuite.py changed accordingly.
3235 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3236 * VC++ has some strong limitations when working with the STL, as stated
3237 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3238 "Also note that some STL containers (map, set, queue, list, deque)
3239 cannot be exported. [...]
3240 Some STL classes contain nested classes. These classes can not
3242 This is caused by a designed limitation that once a template
3243 class is instantiated, it can not be re-instantiated and
3245 Since our usage of map<> is ubiquitous in gdcm, this "designed
3246 limitation" of VC++ is a pitfall.
3247 Hence the Python wrappers of gdcm cannot be incrementally linked
3248 against the c++ dynamic library. The dirty but only workaround is
3249 to forget about incremental link of dynamic libraries and to generate
3250 the Python wrappers library with the inclusions of the underlying C++
3252 The following modifications concern this matter on Win32/VC++:
3253 - wrapping python correct with standalone wrapped dll (don't use separate
3254 dll under windows !!!!)
3255 - python21_d debug mode enabled (ask Frog how to use it :-)
3256 - NO problem with having an STL member of class for example string in C++
3257 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3258 - Python test of dcmlib in Python is ok under windows on a large set
3260 * removed glib references
3261 * typedef's inserted in gdcm.i for correct swig type management
3263 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3264 * python/demo/*.py load.py extracted from test.py. Added explore.py
3265 that only displays required tags and testAll.py that parses all
3266 the files of the testsuite without using unittest.
3267 * python/testSuite.py other additional test on new files added.
3268 * Data/* new test files added accordingly to the testSuite.
3269 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3270 the vr in the file differs from the one of the dictionary.
3272 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3273 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3274 values, but limits itself to values which are below a user specified
3275 size (by default 1024 bytes).
3276 * python/gdcm.i : elements not loaded (because their size is above the
3277 user specified treshold) are exported with their TagKey as key of the
3278 python dictionary. This enables the testsuite to make some checks
3279 on the unloaded elements (since we have their offset and size).
3280 * python/testSuite.py
3281 - now tests for the existence and proper value of the pixel data
3282 - two new examples added.
3283 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3285 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3286 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3287 aware. See the strategy comments in gdcmHeader::FindLength().
3288 * Test/test.cxx now accepts a filename as first argument.
3289 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3290 * python/testSuite.py changed to integrate test on above files.
3292 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3293 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3294 the vr was also RET.
3295 * python/testSuite.py more tests added.
3297 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3298 * python/testSuite.py unittest test suite added (uses Data)
3299 * Data/* dcm and acr files for the test suite.
3300 * glib dependance removed from un*x version. We now use ISO C99
3301 7.18 Integer types (see stdint.h)
3302 - python/Makefile, src/Makefile src/gdcm.h
3303 * src/ when an explicit vr (like dicom files) suddenly poped an
3304 implicit element we use to mark the underlying DictEntry of the
3305 concerned ElValue with "Implicit". This strategy was damageable
3306 too the public or provite dictionaries, since some of their vr
3307 would be changed. Since Header::FindLength heavily relies on the
3308 detection by Header::FindVR of falsely explicit elements, I
3309 added an extra ImplicitVr member to ElValue (boolean).
3310 The rest of the changes we the necessary adaptations.
3312 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3313 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3315 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3317 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3318 * Adaptation for porting to VC++:
3320 o forced to use std namespace (for string to be known)
3321 o all class use __declspec export style on WIN32
3322 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3323 (in stdlib.h on Win32 but in std:: for gcc)
3324 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3325 variable GDCM_DICT_PATH.
3326 * src/gdcmHeader.cxx verbose comments made discrete.
3328 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3329 * python/gdcm.i: added a typemap that converts a C++ hashing table
3330 to native Python dictionary.
3331 * python/demo/test.py:
3332 - now uses the native dictionary for exploration of gdcmHeader.
3333 - takes an optional filename argument (the file to parse).
3334 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3335 PubElVals hashing table.
3336 * Dicts/dicomV3.dic removed error prone trailing spaces.
3338 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3339 * Python wrapping process moved away from src/Makefile to
3340 newly created python/Makefile (as well as gdcm.i)
3341 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3342 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3343 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3344 from the environement variable GDCM_DICT_PATH (when existing).
3345 * src/gdcmDict::GetTag bug fix.
3347 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3348 * Straightforward temporary fixes for swig to build the python wrappers.
3349 src/Makefile now has a python working entry [by working we mean
3350 that we can import the shadow classes without errors].
3352 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3353 * hashtest.cxx removed (since already in Test)
3354 * src/gdcmlib.h renamed to src/gdcm.h
3355 * src/dcm.i renamed to src/gdcm.i
3356 * src/Makefile prepared for python wrapping
3358 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3359 * src/gdcmHeader.cxx :
3360 - Parsing of header is now separated from loading of element values
3361 (see gdcmHeader::LoadElements).
3362 - general clean up of hopefully all file access (creation of
3363 ReadInt16 and ReadInt32)
3365 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3366 * src/gdcmHeader.cxx :
3367 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3369 - SetLgrElem renamed to SetLength
3370 - GetLgrElem renamed to GetLength
3371 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3372 * src/gdcmElValSet.cxx fixed both GetElValue methods
3373 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3374 due to IdoDude was cleaned out.
3376 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3377 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3378 concentrates on finding the value representation (when it exists).
3379 RecupLgr now only finds the element value length, and it avoids
3380 returning the unecessary skL (skipped length).
3381 Also, offsetCourant was simply removed (with taille_fich) since
3382 it was redundant with the File position internals (by using
3383 ftell and fseek). This also made skL (see above in RecupLgr) usage
3385 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3386 on the libido specificities which are handled through class
3388 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3391 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3392 * Truckload of changes. Parsing of header is barely functional
3393 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3395 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3396 * src/gdcmHeader.cxx many addons of low level methods
3398 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3399 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3400 and _IdDcmSWAP_LONG.
3402 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3403 * This corresponds to all the changes decided at the meeting of
3404 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob