1 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Remove friend between DocEntry and File classes
3 * Remove friend between PixelReadConverter and RLEFramesInfo,
6 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
8 0002|0000. The value was incorrect.
10 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
13 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * src/gdcmUtil.cxx : compilation fix on Win32
15 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
16 variable, to be easy found. Add methods to change the default UID.
17 Amelioration of the CreateUniqueUID to use the correct default UID.
18 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
21 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
22 * Test/TestVR.cxx : fix memory leaks
24 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
25 * Rewrite the base 256 to base 10 conversion, using string operation only.
26 This allos us to get rid of the problematic 64bits integer type (does not
27 alwyas exist on target platform).
29 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
30 * Add construct and destructor to class gdcm::Debug to close the debug file
32 * Don't let uset to open twice the same file
33 * gdcm has now an official UID prefix,
34 supplied by http://www.medicalconnections.co.uk
35 1.2.826.0.1.3680043.2.1143
36 (Thx to Mathieu for providing URL)
37 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
38 to be able to perform some more tests
39 * gdcm::ContentEntry : Contructors and Destructor are now protected,
40 in order to be sure no user will try to use them.
41 (at user level, only the children classes are meaningfull)
43 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * move RLEInfo & JPEGInfo from Document to File
46 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * FIX : remove so many friend between classes
49 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
50 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
51 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
53 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
54 In order to avoid missbehaviour :
55 . gdcm::DocEntry is now specialized in
56 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
57 - gdcm::ContentEntry (Dicom entry with a 'content')
58 . gdcm::ContentEntry is specialized in
59 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
60 characters value, or integers)
61 - gdcm::BinEntry (Dicom entry with a non strig representable value
62 (user hasn't any longer to thing about the precedence of his dynamic_casts)
64 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * Test/VTKTest*.cxx : bug fix under linux
67 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
69 use with python. Some methods are moved from Document to ElementSet or
70 DocEntrySet. The equivalent methods to ElementSet have been added to
71 SQItem and are virtual in DocEntrySet. Methods that may have the same code
72 in SQItem and ElementSet is directly placed in DocEntrySet
74 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * Test/VTKTest*.cxx : remove the show variable in each test method because
76 it's useless (the viewer variable replace this variable)
78 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
79 * src/gdcmDocument.cxx : bug fix on potential memory leak
80 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
81 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
82 Add ClearXxx methods to remove all the content of the list or map
83 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
85 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
86 * methods ReplaceOrCreate renamed as Insert
87 (nobody will be any longer confused by 'CreateOrReplace')
89 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
90 * Grealty simplify the JPEg decompression, no need to differenciate based on
91 the JPEG possible type (with/without fragment, with/without multiple frame).
92 Everything is done throught the JPEG IO Suspension mechanism in IJG
94 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
95 * Stage 3 of normalization :
96 in order to avoid any missunderstanding while reading method names :
97 - All the methods xxxEntry now deal with dicom Entries
98 - Methods GetEntry splitted into
101 - Method SetEntry renamed as SetEntryValue
102 - Method SetEntryBinArea let as it was
104 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
105 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
106 - Position correctly the entry points for JPEG2000 and JPEG-LS
107 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
109 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
111 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
112 with other method names
113 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
114 * Test/TestDicomDirElement.cxx : add new test
116 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
117 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
118 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
119 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
120 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
121 So can't you use __int64 in ostream at all.
123 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * bug fix for compilation on MSVC6
125 * gdcmPython/gdcm.i : rename of classes missed
127 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
128 * Stage 2 of names normalization :
129 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
130 (easy to understand ...)
131 - gdcm::FileHelper replaces old class gdcm::File
133 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
135 type and not a string. So, there remove problems on the format of the
138 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
139 * Add Example/TestPapyrus.cxx
140 - reads a Papyrus file (gdcm::Header compliant),
141 - gets the pixels of all the images, using low level iterators
142 - writes an multiframes Dicom image.
143 (Just to show it's *possible* to do that)
144 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
147 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
149 Thus, DicomDirXXX are created with a flad that indicates if the created
150 object is empty or not (when not empty, the DicomDirElement is used to
153 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
155 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
157 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
160 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
162 Remove all access to the hash-tables or lists in the objects.
164 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
166 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
167 be complient with all the gdcm source code
169 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
173 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
174 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
177 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * Test/ : rename VTK tests to have a best name for the tests
179 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
180 GetFirstEntry/GetNextEntry use
182 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
183 * In SerieHeader::ImagePositionPatientOrdering()
184 // a Dicom 'Serie' may contain scout views
185 // and images may have differents directions.
186 // -> More than one may have the same 'pos'
187 // Sorting has then NO meaning !
188 Thx to Eduardo Davila for reporting bug.
190 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
192 test. Now it's on image content and not on the resulting visualisation...
193 might solve the problem on linux when using the OpenGL drivers
195 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
196 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
197 DicomDirSerie, DicomDirImage
198 Dict, DictSet classes :
199 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
200 -remove InitTraversal method.
201 * UPD Test programs + Example programs
203 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
204 * remove useless and never updated keyword \ingroup
205 * Solve pb when structure (list, map, ...) is empty.
206 Thx to Benoit for reporting bug
208 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
209 * Taking into account of 'Transfer Syntax' value
210 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
213 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
214 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
215 is no memory access violation
216 * gdcmPython/demo : add python demos using VTK
218 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
219 * FIX 'Dictionnary' is now spelt 'Dictionary'
220 'wether' is now spelt 'whether'
221 'archieve' is now spelt 'archive' ;-)
223 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
224 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
225 related methods, in order not to expose internal mechanisms
228 * REM methods that exposed internal mechanisms :
229 DicomDir::GetDicomDirPatients()
230 DicomDirPatient::GetDicomDirStudies()
231 DicomDirStudy::GetDicomDirSeries()
232 DicomDirSerie::GetDicomDirImages()
233 * UPD Test programs :
237 * UPD Example program
239 * ADD DictSet methods
243 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
244 * Removed the Print/indent/default parameter mess. There is absolutely no
245 reason to have to methods, moreover with the second taking the ostream as
246 *SECOND* parameter. This was clearly a bad hack to get things compile.
248 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
249 * Complete rewrite of the GetMacAddress code. Now the code is *much*
250 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
251 Unfortunately the main code does not work on SunOS, thus provide a specific
252 code for this platform only (and Win32 of course). Since this seems to be
253 working, change CreateUniqueUID to use GetMACAddress instead of the
254 problematic GctestetIPAddress
256 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
257 * Unfortunately to be able to test gdcmDirList I had to break the API
258 a little. Now the class is not a std::list anymore but has a member
259 std::vector (more ITK compatible). Allow unit testing on Win32 and
262 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
263 * Update SerieHeader to take into account a Serie Instance UID to properly
266 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
267 * ENH - Comment out Mathieu's (dangerous) Super Hack
268 for dealing with BIGENDIAN processors
269 - Move equivalent stuff to BinEntry::WriteContent
270 When necessary, 16 Bits Pixels are swapped in a small buffer
271 and then written. This avoid allocating a huge buffer, in
272 PixelWriteConvertor, and avoid modifying the Pixel Area.
274 Probabely, the same operation will have to be done when we want
275 to write image with Big Endian Transfert Syntax,
276 and we are working on Little Endian Processor
278 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
281 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
282 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
283 all the dict content.
284 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
286 * Test/TestDict.cxx : add a new test for the dict classes
288 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
289 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
290 file. Debug is yanked if compiled with NDEBUG
292 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
293 * src/gdcmDictSet.h : set the default output to the os variable
294 * src/gdcmDictEntry.[h|cxx] : add the Print method
295 * gdcmPython/demo/ : add a new test
297 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
298 * merging of Test/PrintDicomDir and Test/TestDicomDir
299 * removal of now redundant Test/PrintDicomDir
300 * enhancement of Example/PrintDicomDir
302 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
303 * Now, python test might work on systems
304 * Add the PrintDicomDir test
306 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
307 * FIX : First entry following group 0002 was lost for
308 Explicit Big Endian Transfer Syntax files
309 (group and elem not swaped)
311 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
312 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
313 Big Endian Transfer Syntax supposed the group following 0002
314 begins always by element 0000 (element 0000 is *optional*)
315 To avoid further troubles, let's be pessimistic, and use
316 Document::HandleOutOfGroup0002() method
317 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
318 (related pb not yet solved)
320 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * Bug fix for the python part use
322 * Now, PrintHeader.py pass... but outside the ctest use. shit !
324 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
325 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
327 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
328 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
329 a string and should ask the global TS dict what are the propreties of
332 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
333 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
334 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
335 to swap the Swap Code, at parsing time, when we come out of group 0002
336 and Transfer Syntax is Big Endian
337 We should be able to read now 'true DICOM" Big Endian coded images
338 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
339 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
341 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
342 * Hopefully fix the bug on MacOSX and static global initialization.
343 This is the only -minor- patch I found that both please MacOSX and VS6.
344 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
345 but this would require a lot of change. Another approach would be that Global
346 create those string and GDCM_UNFOUND becomes a pointer to a string (which
347 gdcm::Global would destroy at exit).
349 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
350 * Fix bug on MacOSX with static initialization in a multy threaded
351 environment. static const string in a header file used to be ill
352 initialized provoquing the freeze of any tests. patch should solve this
355 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
356 * According to Benoit's suggestion, and without any objection from anybody
357 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
358 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
359 - method gdcmDicomDirObject::GetEntry() renamed as
360 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
362 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
363 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
364 you debug/warning message just as c++ streams which make them very convinient
365 to use. Once this is stabilize I will change the ostringstrem to be
366 redirected to a file (ofstream).
367 * Properly support C99 extension: __FUNCTION__ which allow us to display
368 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
370 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
371 * Removal of useless and dangerous methods :
372 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
373 GetDocEntryByName, GetEntryByName, GetDictEntryByName
374 * Removal of usless methods :
375 Dict::PrintByName, Dict::GetDictEntryByName
376 * Commenting out of probabely useless methods :
377 Dict::GetDictEntryNames()
378 Dict::GetDictEntryNamesByCategory()
379 DictSet::GetPubDictEntryNames()
380 DictSet::GetPubDictEntryNamesByCategory()
381 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
382 * ENH : Use dicomTS.dic as described in 2004 version
383 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
384 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
385 Add Accessors on VM (Value Multiplicity), and VM related methods
386 * ADD : Add a list of 'Dicom Attribute types', as found in
387 http://medical.nema.org/dicom/2004/04_15PU.PDF
389 * ADD : Add dicomGroupNameAbbreviations.dic
390 should be used to write a method to replace the former
391 Dict::GetDictEntryNamesByCategory()
393 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
394 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
395 to read in the file... and only it ! Length is the efective length of the
396 data in the DocEntry structure
398 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
399 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
400 And now use a static function call instead, with a global variable. i
401 This is much closer to the VTK approach. Hopefully should be bulletproof
402 and easier to use...hopefully
404 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
405 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
407 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
408 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
410 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
411 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
412 ValEntry, BinEntry, SeqEntry creation or replace
414 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
415 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
416 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
418 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
419 when specifying the VR
420 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
421 * src/gdcmDocEntry.cxx : amelioration of print
423 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
424 * ADD : Add the method Util::IsCurrentProcessorBigEndian
425 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
426 * ADD Method Document::ComputeGroupLength
427 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
428 in order to allow further VR modification by user
429 * REM : removal of once-called method File::WriteBase
430 integration of its code in formerly one-line method File::Write
432 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
433 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
434 replace the different values "??", "Unkn", "Unknown".
435 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
436 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
437 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
438 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
440 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
441 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
443 * Set the gdcm::Base class to some Printable classes
445 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
446 * src/gdcmFile.[h|cxx] : add the Print method
447 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
448 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
449 * src/gdcmDocument.h : remove the PrintLevel informations
450 * Example/PrintFile.cxx : use the new gdcm::File::Print
452 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
453 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
454 problems when compiling with the python wrapping
456 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
457 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
458 writting in ImplicitVR
460 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
461 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
462 JPEG decompression, especially when dicom frames are split into several
463 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
464 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
466 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
467 * src/gdcmHeader.cxx : change the initialisation of default header.
468 Now, this header is readable by gdm, e-film, DicomWorks
470 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
471 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
472 Rename Decompressed to Raw
473 * Use the API changes in gdcm::File.
474 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
477 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
478 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
479 each added entry in the header. Replace the 'Planes' field by the 'Number
482 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
483 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
484 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
486 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
488 At this time, this image isn't readable by e-film... waiting JPR help to
491 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
492 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
493 DocEntry. Now use methods of the Document !
495 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * Test/ShowDicomSeq.cxx : bug fix
498 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
500 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
501 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
502 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
504 * Test/TestCopyRescaleDicom.cxx : remove unused variable
505 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
506 containing found sequences
508 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
509 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
511 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
512 Some fields in BinEntry must be copied to not seg fault when making the :
513 gdcm::File *copy = new gdcm::File( copyH );
514 and tests are now made on good variables
516 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
517 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
518 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
520 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
521 * Add vtkGdcmWriter example and test
523 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * Test/TestUtil.cxx : reformat the source code
525 * vtk/vtkGdcmReader.cxx : remove and change prints
526 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
528 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
529 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
531 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
532 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
533 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
535 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
536 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
537 by an eof to prevent all bad read of the file... and in this case, the
540 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
541 * Example/Volume2Dicom.cxx : comment unused variables
542 * Test/PrintDicomDir.cxx : comment unused variables
543 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
544 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
545 method that is redondant with AddEntry.
546 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
549 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
550 * Bug fix due my last commit (compilation under Windows).
551 * Example/Volume2Dicom : bug fix in the file and reformatting source code
552 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
554 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
556 - Remove printf / sprintf
557 - include iostream AFTER gdcm so we don't get warnings
558 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
560 - Also remove tons of include from header files, hopefully this should
561 speeup the compilation time, since it was becoming a dog slow.
562 - Remove gdcm.h as it include way too many files and slow down compilation
563 (plus it is not up to date)
564 - remove 'using namespace std' this is BAD !
566 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
567 * Remove memory leaks on the DicomDir
568 * Remove some useless data in DicomDirObject
569 * Add usefull methods in SQItem, to be complient withe the ElementSet
571 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
572 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
574 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
576 future, with convertion)
577 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
578 and ImageDataSize values. Remove the method to get the PixelReadConverter
579 from the output of the class
581 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
582 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
584 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
585 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
586 and vtkErrorMacro use.
587 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
589 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
590 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
592 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
593 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
594 The string leaves only in the fonction. So when we make a .c_str(), we
595 get the pointeur on the first element, element that will be destroyed
596 immediately after thee instruction.
597 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
598 file has been opened : the test must be made on the content of the
599 pointer and not directly on the pointer !
602 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
603 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
604 the python part recompiles
606 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
607 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
608 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
609 X session is killed (for my computer... it seems to not be identic on
612 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
613 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
614 avoid problems (otherwise, the difference test between the visible image
615 and the reference is incorrect. If the reference is greater than the
616 screen resolution, it's produce errors).
617 Can be used for only one image. Can be used with a visible flag.
618 * vtk/vtkGdcmReader.cxx : remove commented codes.
619 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
620 under windows at compilation
621 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
623 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
625 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
627 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
628 tests on the image size X, Y, Z
630 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
631 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
632 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
633 between the class name and the file name
635 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
636 * src/ : fix compilation warnings for the Write method (2 different
637 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
638 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
639 variable... create a static method in gdcm::Document to access to
640 this variable content.
642 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
643 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
644 file, to be accessed by other files (like gdcmFile). Remove commented
645 code. Move the change of the header to the gdcmFile, using the
647 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
648 To be sure of that (and simplify calls), the Write of the header now
649 gets a file name and not a file pointer (std::ifstream).
650 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
651 DocEntryArchive. Remove all open of the written file
653 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
654 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
656 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
657 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
658 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
660 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
661 some corresponding methods. Write correctly the file and check before
663 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
664 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
665 is now on RGB data (as before my last commit
666 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
668 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
669 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
670 Add a print information of the type of the entry
671 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
672 It was in the gdcmFile, and all write have been regrouped
673 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
674 Write correctly all dicom files (in decompressed mode only at this time)
675 * Test/ : test on files are now made using Raw data and not color data if
677 * Example/PrintFile.cxx : add more printings
679 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
680 * Amelioration of code, remove some code copy. For the loading of
681 BinEntry (in gdcmDocument), add the test to verify if the file is already
684 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
685 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
686 remove a DocEntry in the header (push an empty DocEntry)
687 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
688 lines. Bug fix in the initialization of the PixelConvert and the
690 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
691 use in TestCopyDicom (now this test can run under windows... but fails)
692 * Test/TestCopyDicom.cxx : amelioration of the test :
693 - test the pixels written
694 - add test points to quickly find where is the error
695 - can set a file name input and output in arguments
696 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
697 amelioration of the test output
699 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
700 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
701 all replaced DocEntry's
702 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
703 Now, each needed DocEntry to modify is duplicated, modified and inserted
704 to the header using DocEntryArchive. Thus, after save, we can restore the
705 header initial state.
707 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
708 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
710 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
711 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
712 correct to copy it. The DictEntry is specified at the DocEntry creation,
713 then, it musn't change in the time.
714 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
715 header correctly. At this time, the change is only made for the first
716 level of the Document. In the future, it might consider sequences.
717 The change is made by replacing a DocEntry by an other that is created
718 outside the class. The old value is kept. When we restore the header
719 status, the added DocEntry is deleted and replaced by the old value.
720 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
721 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
722 set the write type to explicit VR, implicit VR or ACR. Add methods to set
723 the write mode to native, decompressed or RGB (but not used at this time)
725 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
726 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
727 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
729 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
730 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
731 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
733 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
734 set because already copied when copying the BinEntry's of the header
735 * Test/TestAllReadCompareDicom.cxx : remove warnings
737 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
738 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
739 Two problems appear when doing it :
740 - with the gdcmFile : when the GetImageData method is called, the pixels
741 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
742 data (pixels). And each structure destruct the data when it's
743 destructed. So we have two destructions for the same data. To solve it,
744 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
745 data or not. If it doesn't own data, then they will not destroyed by
747 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
748 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
749 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
750 create a double destruction of the same DocEntry's. So, to solve it,
751 the TagHT is simply cleared and the DicomDir* elements are destroyed.
752 * TODO : add an entry concerning memory leaks in the DicomDir
754 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
755 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
756 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
759 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
760 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
761 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
762 after it have been deleted
764 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
765 * FIX: src/* fix the doxygen warnings.
766 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
767 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
768 was erroneously defined with a size of 15 instead of 16. [many thanks
769 to Jean Michel Rouet for pointing out this bug].
771 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
772 1. Finish merging JMR patch for writting DICOM from scratch
773 2. Fix -hopefully- bug with MONOCHROME and space vs null character
774 3. Use const ref when possible
775 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
776 5. A few more comments
777 6. CreateUniqueUID can now be called without parameter"
779 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
780 * ENH: Slightly bigger patch:
781 1. Getting toward full integration of JMR patch for writting dicom from scratch
782 2. Update Test to test part of this patch: CreateUniqueUID
783 3. File was not close properly in gdcmDict
784 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
785 5. Use of const ref instead of copy (speed issue)
786 6. Remove temporary (duplicate) string in TranslateToKey
787 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
788 8. Do not repeat virtual in subclasses
789 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
791 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
792 * Apply first patch toward better string comparison when dealing with broken
793 DICOM files. Essentially the string could be padded with a space instead
794 of a null character as defined by standard
796 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
797 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
798 because never used... and in the same time, that's remove some memory leaks
800 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
801 * src/gdcmFile.cxx : now delete the PixelConvert instance.
802 * In examples and tests : change the type of image data variables from void*
803 to uint8_t*. Remmove all delete on image data variables
805 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
806 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
807 Verify the file pointer value before open the file, and if it's not null,
808 a verbose message is generated.
809 Close correctly the file when the file isn't considered dicom-like. The
810 correctly close is a call to CloseFile.
811 When closing the file pointer, test if its not null to close the file.
812 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
813 file. For an uncompressed image, the copied data correspond in the least
814 case to the image size (calculated) or the image size specified in the
815 header. A verbose is generated if these two size mismatch
817 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
818 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
819 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
820 break under windows (with msvc6 compilation).
822 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
823 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
824 compiling with MSVC6)
826 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
827 * Bugs fix for the Windows build with VC6
828 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
829 needed (only for projects required VTK). If the VTK is included in all
830 projects, there is conflicts with the jpeg lib of vtk when compiling the
831 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
832 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
833 when compiling the gdcm_wrap.cxx file (created by the compilation of the
835 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
836 (like it's already made for the cout use). Otherwise, conflict with the
839 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
840 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
842 - comments on the DicomDir::Method related usage added.
843 - now that we use the namespace gdcm, a lot of internal classes do
844 NOT need to be wrapped anymore.
845 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
846 DicomDir::Method) new example added.
848 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
849 * Improve string manipulation. I now inforce the notion of 'DicomString'
850 A DicomString can contain as many \0 as they want
851 and it is *always* of even length.
852 We only support odd length for very rare case.
853 And in the near future this should be removed.
855 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
856 * /binary_write/ gdcm source. Now even on big endian we are writting
857 little endian. This should -heopfully- fix some tests
859 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
860 * Now the dictionary is compiled into gdcm lib. This is a default
861 behavior, thus any dic file specified is picked before failback to
862 the one comiled into lib
864 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
865 * Change internals for gdcmDict. Don't use any 'new' any more.
866 This should definitely solve any leak problem, and we should be
867 as fast as before, as long as don't modify too much the dictionary.
869 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
870 * STYLE: ivars should start with a capital letter.
871 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
872 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
874 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
875 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
876 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
877 new 2004 dictionaries added (thanks to JPR).
878 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
879 * CLEANUP_ROUND (15) for gdcmPixelConvert
880 - RLEFrame::NumberFragments is now of type unsigned int
881 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
882 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
885 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
886 * Initial work in gathering all transfer syntax accessors. clearly
887 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
888 ivars, but only one transfersyntax (class) ivar with equivalent method on
891 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
892 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
893 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
894 discussed (plus I didn't like having a 2000 lines patch not commited)
896 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
897 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
898 * CLEANUP_ROUND (14) for gdcmPixelConvert
899 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
900 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
901 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
903 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
904 anymore and hence avoids storing a copy of PixelConvert::Decompressed
905 into File::Pixel_Data.
907 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
908 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
909 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
910 * CLEANUP_ROUND (13) for gdcmPixelConvert
911 Substituted File::ParsePixelData() with PixelConvert::Print() new
913 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
914 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
915 method to those classes.
916 - src/gdcmFile.[cxx|h]:
917 -- Added a ::Print() method.
918 -- PixelConverter is now a reference instead of a member.
919 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
920 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
922 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
923 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
924 collaboration diagram and inheritance diagram should be generated with
926 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
927 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
928 pointlessly wrapped (see
929 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
930 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
931 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
932 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
933 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
934 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
935 -- File::Initialise: PixelConverter setup moved away to
936 PixelConverter::GrabInformationsFromHeader()
937 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
938 interpretation moved away to PixelConverter::BuildRGBImage()
940 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
941 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
942 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
944 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
945 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
946 displayed on Win32 when a brutal abort() occurs (because of uncatched
947 exception). See TODO new entry of this commit for more on this.
948 * TODO added new entry.
949 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
950 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
951 - HandleColor is no longer called from gdcmFile.cxx
952 - gdcmPixelConvert.cxx clean up on method arguments and internal
953 variable names for semantical coherence.
955 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
956 * Finished lossless transition, not only do we now read all lossless jpeg
957 images, without the need of the Cornwell lib, but we do read them properly now
958 * To reduce code (well to avoid code duplication), I defined a common place
959 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
960 redefine symbols. This is not perfect but this the best solution I found for a
961 compilation time jpeg option.
963 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
964 * Update jpeg ijg lib to support lossless jpeg implementation
965 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
967 * Also added a special copyright for dcmtk since we use their bugfixes.
970 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
971 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
972 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
973 matters, as stated in warning note at begining of %include section).
974 * src/gdcmDicomDir*.[cxx|h]: coding style
975 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
976 * src/gdcmJpeg8.cxx: doxygen fix.
977 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
978 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
979 from File:: to PixelConvert::.
981 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
982 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
983 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
984 - more code moved away from File:: to PixelConvert::
985 - fat setup of PixelConverter set in place in File::Initialise.
987 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
988 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
989 namespace at the file system level. So now you should convert your examples
991 gdcmHeader -> gdcm::Header
992 It would be nice if people keep in mind to no open the namespace, since it
993 allows compilation on broken plateform which were defining common symbol in
994 the standart namespace (like LP, Unknown ...)
996 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
997 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
998 The JPEG fragments are now parsed at the same stage than the RLE
999 information. All code related to JPEG is now in gdcmPixelConvert:
1000 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1001 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1002 export a gdcmFile:: method. Those are simply global functions
1003 (for the time being this is better than having them attach to
1004 either gdcmFile:: or gdcmPixelConvert::).
1005 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1006 and stores the result in a gdcmJPEGFragmentsInfo.
1007 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1008 code (among other stuff) moved away from gdcmFile:; to
1011 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1012 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1013 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1014 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1015 clean up of RLE related code.
1016 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1017 - src/gdcmRLE.cxx removed
1018 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1019 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1020 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1021 * CLEANUP_ROUND (9) for gdcmPixelConvert
1022 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1023 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1024 away from gdcmFile:: to gdcmPixelConvert::.
1026 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1027 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1028 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1029 This is because Parse7Fe0 used to parse the pixels to compute the
1030 length. This task was passed over to FindDocEntryLengthOB() a long
1031 time ago, EXCEPT I had forgotten the OW case...
1032 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1033 we just recylce the code for parsing RLE fragments and computing
1035 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1036 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1037 with the retired Parse7Fe0().
1038 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1039 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1041 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1042 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1043 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1044 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1045 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1046 * CLEANUP_ROUND (4) for gdcmPixelConvert
1047 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1048 to return an unused length.
1050 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1051 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1052 this should be cleanner from the plane view. The iostream are erally a pain
1053 to use to do simple stuff.
1055 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1056 * Redo the compilation of the ijg jpeg library. Now only one source is
1057 necesseray. No need to rename file by hand what so ever. CMake handle the
1058 copying of the file within different directory, configure header file to
1059 modify some symbol. The only addition made to ijg wasd a mangle table so
1060 that symbol are different whether we are within 8bits or 12bits.
1062 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1063 * Added documentation of vtkgdcmReader on Website:
1064 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1065 with it's binary name).
1066 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1067 the Website to be more complete.
1068 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1069 doxygenated documentation.
1070 - Doc/DoxyVtkGdcmReaderExamples.txt added
1071 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1072 DoxyVtkGdmReaderExamples.html )
1073 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1074 * CLEANUP_ROUND (3) for gdcmPixelConvert
1075 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1077 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1078 * CLEANUP_ROUND (2) for gdcmPixelConvert
1079 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1081 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1082 * CLEANUP_ROUND for gdcmPixelConvert:
1083 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1084 - src/gdcmPixelStuff[h|cxx] removed
1085 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1086 - src/CMakeLists.txt changed accordingly
1087 * GDCMHOME clean up:
1088 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1089 gdcmVersion.py moved to newly created ATTIC related
1090 gdcmPython/SetupOldies/ directory.
1091 * Autotools clean up:
1092 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1093 - autogen.sh configure.in acinclude.m4 python.m4 removed
1095 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1096 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1097 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1098 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1100 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1101 * TODO updated with Mathieu suggestions. I proposed a template for
1102 describing TODO entries and used it for new entries.
1103 * Added Doc/Website/CodingStyle.html, Developpers.html,
1104 DeveloppersPython.html, GdcmDataCvs.html and
1105 DownloadVersion0_1.html, DownloadVersion0_3.html.
1106 * Some Doc/*.txt Doxygen files (which do not really concern the
1107 documentation itself, but the website) moved to html and
1108 placed in directory Doc/Website:
1109 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1110 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1111 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1112 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1113 * CMakeLists.txt changed accordingly.
1114 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1115 DeveloppersPython.html
1116 * INSTALL nows refers to Doc/Website/Installation.html
1118 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1119 * Added Doc/Website directory, that contains a first raw version
1122 2004-09-23 Jean-Pierre Roux
1123 * FIX In order not to be poluted any longer by casting problems,
1124 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1125 we can now delete[] it safely
1126 * VoidArea is now called BinArea (less confusing name),
1127 and all the methods called ...VoidArea... are now ... BinArea...
1128 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1130 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1131 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1132 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1133 up to the destructor of gdcmElementSet to clean up TagHt and it's
1136 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1137 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1138 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1140 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1141 * ENH: added some utility method that builds a flat dictionary
1142 holding all the Dicom entries contained in the recursive structure
1143 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1144 an example of usage.
1145 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1146 BuildFlatHashTable() that build a flat dictionary.
1147 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1148 gdcmDocument is now a friend of gdcmElementSet.
1149 - src/gdcmElementSet.cxx: clean up.
1150 - Example/FlatHashTablePrint.cxx added.
1151 - Example/CmakeLists.txt changed accordingly
1153 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1154 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1155 moved away from gdcmDocEntrySet (since this class is an abstract class
1156 acting like an interface). SQDepthLevel and BaseTagKey are now
1158 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1159 and associated accessors. Doxygenation of the class.
1160 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1162 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1163 Use SQDepthLevel accessor instead. ::Print() adapted.
1164 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1165 - src/gdcmDocument.cxx changed accordingly.
1167 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1168 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1169 - The following is the doxygen comment of the typedef declaration
1170 of gdcmTagKey in src/gdcmCommon.h:
1171 gdcmTagKey is made to old an "universal" (as in URL, Universal
1172 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1173 A dicom tag always has a group and an element, but a set of tags
1174 embeded in various (optionally nested) sequences and sharing
1175 the same group and element all share the same (group, element)
1176 "identifier". Hence the (group, element) cannot be used as an
1177 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1178 In order to construct a proper tag identifier (i.e. a key) we
1179 consider the following definition of a TagKey:
1180 - let Group, Element be the string representation of the
1181 group and element dicom tag members,
1182 - let ItemNumber be the string representation of the integer
1183 index of the considered item number of a sequence,
1184 Let the key of a tag embeded in a sequence, noted SeqTag, be
1186 /ItemNumber#Group|Element
1187 where "/", "#" and "|" are characters acting as separators.
1188 Then the general form of a gdcmTagKey is given by:
1189 Group|Element<SeqTag>
1190 where <SeqTag> means NO or many instances of SeqTag.
1191 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1194 but the gdcmTagKey of a tag "embeded" is the first item of
1195 a sequence, itself nested in the third item of a sequence is the
1197 0004|1220/2#0008|0082/0#0008|0090
1198 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1199 order to hold the new sequence compatible key. Previously, the
1200 GetKey() method would look in the underlying gdcmDictEntry.
1201 - src/gdcmDocEntry.cxx:
1202 -- constructor now copies the underlying DictEntry key, in the local
1204 -- ::Print: displays the member Key, instead of the (group, element).
1205 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1206 - src/gdcmDocEntrySet.h:xi
1207 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1208 -- now has a new BaseTagKey member.
1210 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1211 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1213 This poses the problem with the semantics of the following lines
1214 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1215 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1216 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1217 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1218 to the long FIXME note for what the problem is. Nevertheless in
1219 order to get things working the dicom dictionary was altered !
1220 Please fix things urgently...
1221 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1222 information), see above note on moving the member VoidArea. Nevertheless
1223 the following entries previously correctly set as US are now inproperly
1225 0028 1201 OW IMG Red Palette Color Lookup Table Data
1226 0028 1202 OW IMG Green Palette Color Lookup Table Data
1227 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1228 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1229 of gdcmDocEntry moved to gdcmSeqEntry.
1230 * src/gdcmSeqEntry.cxx: STYLE.
1232 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1233 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1235 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1236 * gdcmPython/testSuite.py: all the test suite in python is now moved
1237 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1238 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1239 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1241 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1242 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1243 to avoid inclusion recursion until STL is reached.
1244 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1245 mecanism. errno.h is not included in gdcm anymore.
1246 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1247 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1249 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1250 gdcmData/TestAllEntryVerifyReference.txt
1251 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1252 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1253 exception_on_error parameter.
1254 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1255 - vtk/vtkGdcmReader.cxx changed accordingly,
1256 - Example/*.cxx and Test/*.cxx changed accordingly.
1258 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1259 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1260 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1261 enable_sequences removed from gdcmHeader constructor and dependencies.
1262 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1263 * gdcmPython/demo/PrintHeader.py: dummy fix.
1264 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1265 skip_shadow removed from gdcmHeader constructor and dependencies.
1266 * Example/*.cxx and Test/*.cxx changed accordingly.
1268 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1269 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1270 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1272 2004-07-21 Jean-Pierre Roux
1273 * FIX Now, Parsing and Printing a DICOMDIR do work!
1274 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1276 2004-07-20 Jean-Pierre Roux
1277 * FIX Some brain damaged headers have Zero-Lenght fields
1278 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1280 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1281 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1282 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1283 variable (instance of gdcmDebug) by a definition macro, and the instance
1284 is now in static in the gdcmDebug class
1285 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1286 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1288 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1289 * WARNING: ctest now depends more tightly on gdcmData. You should
1290 check out gdcmData properly for things to run smoothly...
1291 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1292 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1293 we need the pixels not be loaded in order to use the ValEntry
1294 that displays position and size).
1295 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1296 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1297 be deprecated. If you have any doubts about the advantages of a
1298 modern scripting language (read Python) versus grass root C++ (i.e.
1299 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1300 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1301 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1302 Anyhow, consider documenting the gdcmData images in
1303 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1305 * Test/CMakeLists.txt:
1306 - now uses TestAllEntryVerify.cxx
1307 - specific comments on oldACR00001.ima (now renamed in gdcmData
1308 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1309 gdcmData/TestAllEntryVerifyReference.txt
1312 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1313 * src/*.[h|cxx] : typedef clean up
1314 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1315 - TagKey renamed to gdcmTagKey (for external usage)
1316 - VRKey renamed to gdcmVRKey (for external usage)
1317 - removal of typedef duplication.
1318 - Removed all unecessary inline keyword from class inline definitions.
1319 - Some method|function(void) declarations replaced with method|function().
1320 * src/jpeg/libijg12/jdhuff12.c:
1321 - printf polluting ctest removed.
1322 - TAB removal for comminting
1324 - TestAllReadCompareDicom.cxx: added a test that compares all the
1325 images in gdcmDataImages.h with corresponding images in
1326 gdcmData/BaselineDicom/. When baseline images are not present
1327 this test creates them.
1328 Note: we need to validate each reference image, but before that
1329 I'd like to rename them with a more explicit name...
1330 - CMakeLists.txt: changed accordingly.
1331 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1332 including each header needed).
1334 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1335 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1336 test suite to the Example directory. Are concerned:
1341 - TestWriteSimple.cxx
1342 * Test/CMakeLists.txt: added some comments on reasons for black listing
1343 image gdcmData/oldACR00001.ima
1345 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1346 * Test/CmakeList.txt: removed the following from black list (to be coherent
1347 with removal from gdcmData):
1348 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1349 - gdcm-MR-PHILIPS-16.dcm
1351 Added the following because after last cvs update, they cause
1352 ctest -R TestReadWriteReadCompare
1354 - gdcm-MR-SIEMENS-16-1.acr
1356 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1357 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1358 new comments in this file) we temporarily (sigh) move to a weaker
1360 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1361 we don't need to black list the following images anymore:
1362 - 8BitsUncompressedColor.dcm
1364 - US-PAL-8-10x-echo.dcm
1365 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1366 fixes and the beautified code ;-)
1367 This fixes the bug introduced in version 1.42 (when beautifying)
1368 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1369 Note: ctest was blind to this bug (this means we need to still
1370 improve the test suite). The bug could be detected by using
1371 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1373 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1374 and by displaying the (garbage) produced file temp.XDCM...
1376 2004-06-29 Jean-Pierre Roux
1377 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1378 - replace by uggly but working old code :-(
1379 A lot of things should be OK again.
1380 It's really urgent to have a test suite that *tests*,
1381 to prevent Frog's beautifying sessions to break all the stuff
1382 (twice, withing a fortnigh ...)
1384 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1385 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1386 redundancy) to added Test/TestReadWriteReadCompare.cxx
1387 * Test/CmakeList.txt: because the compare test of
1388 Test/TestReadWriteReadCompare.cxx fails, the following images are
1389 black listed: - 8BitsUncompressedColor.dcm
1391 - US-PAL-8-10x-echo.dcm
1392 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1393 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1394 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1395 and ad-hoc kludge. This kludge is now removed, and on encountering
1396 such an image (OB field brain damaged) we set errno. Then in
1397 ::FindDocLength() we "fix" the length as being ALL what remains
1398 in the file (until EOF). We then proceed, hoping for the best...
1399 This fixes a SegFault in ShowDicom when trying to write such an
1401 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1402 (because TestWriteRead breaks on it, after a non conformal commit?).
1403 ctest now runs properly, except for MakeDicomDir (which was always
1404 broken) and the Python related stuff (still not fixed).
1406 2004-06-24 Jean-Pierre Roux
1407 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1408 FIX : Test/TestReadWrite now iterates on all the file names
1409 (instead of infinite loop)
1410 ENH : Test/TestWriteRead now iterates on all the file names
1412 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1413 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1415 2004-06-24 Jean-Pierre Roux
1416 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1417 when SamplesPerPixel =3
1418 - now Write is no longer confused by
1419 'BitsAllocated = 12" and 'BitsStored=12"
1420 - "UN" value representation Elements are now written correctly
1421 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1422 ENH : - now gdcmHeader has its own Write methods
1423 (in order to split the job that has not to be done
1426 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1427 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1428 loop on the same image until memory went out.
1429 Note: this means we still have gobs of memory loss in PrintDocument
1430 * src/gdcmDocument.cxx: fixes problem on parsing on file
1431 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1433 2004-06-24 Jean-Pierre Roux
1434 FIX : Write - All the Sequences and Sequence Item are now written
1435 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1436 is added a the end, when necessary.
1437 - A lot of brain-damaged images, that were read correctly are
1438 now written correctly
1439 - length compatible BinEntry are now loaded correctly
1440 (even for odd groups)
1441 Note : only Explicit Value Representation was checked.
1442 (question : is implicit VR really necessary for gdcm ?)
1444 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1445 * DEVELOPPER: added a proposition of coding style.
1446 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1449 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1450 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1451 Use the gdcmDocEntry::Print() and Write() instead.
1452 * src/gdcmDocument.cxx: bug fix.
1454 2004-06-22 Jean-Pierre Roux
1455 FIX : gdcmDocument.cxx
1456 - Now we do recognize the JpegLossLess format (there was a misstyping in
1457 code 'beautyfication' :-(
1458 - Now we automaticaticaly load the Luts, if any
1460 2004-06-22 Jean-Pierre Roux
1461 In order : to write Sequences, whatever their imbrication level,
1462 : to allow user to create his own Sequences
1463 a lot of modif where necessary (adding, moving, or virtualising methods)
1465 WARNING : save your own sources *before* cvs up !
1468 ADD virtual void Write(FILE *fp, FileType filetype);
1471 ADD virtual void Write(FILE *fp, FileType filetype);
1472 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1475 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1476 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1477 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1478 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1479 ADD std::string GetEntryByName(TagName name);
1480 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1482 std::string vr = "unkn",
1483 std::string fourth = "unkn",
1484 std::string name = "unkn");
1485 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1486 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1487 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1488 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1489 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1490 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1491 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1492 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1495 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1496 ADD virtual std::string GetEntryByName (TagName tagName);
1497 ADD virtual std::string GetEntryVRByName (TagName tagName);
1498 REM virtual bool Write(FILE *, FileType);
1499 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1500 FILE *_fp, FileType type);
1501 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1502 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1503 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1504 REM virtual std::string GetEntryByName (std::string tagName);
1505 REM virtual std::string GetEntryVRByName (std::string tagName);
1506 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1507 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1508 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1510 std::string vr = "unkn",
1511 std::string fourth = "unkn",
1512 std::string name = "unkn");
1513 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1514 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1515 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1516 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1519 ADD virtual void Write(FILE *fp, FileType filetype);
1522 ADD virtual void Write(FILE *fp,FileType filetype);
1525 ADD virtual void Write(FILE *fp, FileType filetype);
1526 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1527 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1528 REM std::string GetEntryByName(TagName name);
1531 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1533 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1534 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1535 The default constructor invoked by the line
1536 gdcmHeader *f1 = new gdcmHeader( header );
1537 was gdcmHeader::gdcmHeader(bool) instead of the expected
1538 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1539 Hence the parsing wasn't executed... See also below.
1540 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1541 as explicit constructor didn't do the trick to fix the above problem.
1542 Could anyone explain why ?
1543 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1544 properly calls gdcmValEntry::Print() (that was weed out from
1545 code related to gdcmBinEntry).
1547 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1548 * In order to fix memory leaks:
1549 - Test/TestWriteSimple.cxx: added cleaning of free store through
1551 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1552 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1553 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1554 (through the call to ::AddDicomDirMeta()) or the destructor
1555 would crash when deleting uninitialized ::metaElems].
1556 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1557 - src/gdcmDocument.cxx:
1558 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1559 from dynamic stores.
1560 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1561 was causing memory leaks.
1562 - src/gdcmSQItem.cxx:
1563 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1564 cleanly handled with polymophism: sorry but my milage is low).
1565 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1566 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1567 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1568 This avoids SegFaulting.
1569 - src/gdcmSQItem.h: coding style.
1571 - Test/TestWriteSimple still severely sucks. The output image content
1572 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1573 damaged when displayed with vtkgdcmViewer.
1574 - on memory leaks: TestWriteSimple leaks really less (see entry
1575 of 2004-06-18 in Changelog file for the call to valgrind).
1576 - on segfaults: ctest now passes all the tests but one (no more
1578 * Erroneous leading white fix:
1579 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1580 white[s] (as opposed to from >> xxx, that removes it [them].
1581 - src/gdcmTS.cxx: ditto.
1582 - gdcmPython/testSuite.py: dirty related kludge removed.
1583 * src/*: remaining references to gdcmParser removed.
1584 * src/*[cxx|h]: added copy[way]left header.
1587 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1588 * In order to fix writing of dicom files:
1589 - Test/TestWriteSimple.cxx: a simpler example of writing.
1590 - Test/CMakeLists.txt changed accordingly.
1591 - src/gdcmDocument.cxx:
1592 -- The destructor now recursilvely removes potential sequences.
1593 -- Bug fix in ::IsJPEG2000()
1594 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1595 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1597 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1598 to only declared) and build on top of
1599 ::GetDocEntryByNumber(guint16, guint16).
1600 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1601 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1602 for usage in destructor and treatement of promotion in
1603 ::ReplaceOrCreateByNumber().
1604 - src/gdcmSQItem.cxx: destructor should better handle his job.
1605 Test/TestWriteSimple now runs (or at least it DOES something).
1606 * We can now start hutting memory links. A good starting point is:
1607 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1608 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1609 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1611 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1612 * Valgrind note: after Mathieu Malaterre teached me how to read
1613 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1615 Using gcc, you can force the STL to use malloc and to free memory as
1616 soon as possible by globally disabling memory caching.
1617 With 3.2.2 and later, you should export the environment variable
1618 GLIBCPP_FORCE_NEW before running your program.
1619 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1620 simply vanish (it is still not clear to me, whether this means that
1621 STL std::string leaks or if valgrind believes it leaks...).
1622 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1623 running bin/gdcmTests makeDicomDir):
1624 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1625 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1627 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1628 SegFaulting (I drowned in DicomDir related code when trying to
1629 understand why the list is empty...).
1630 * src/gdcmDocument.h: first BSD license header try.
1631 * Doc/License.txt added.
1633 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1634 * src/gdcmDocument.[h|cxx]:
1635 - Clean up of the Transfer related predicates. They are now all based
1636 on new method isGivenTransferSyntax, that (should) handle properly
1637 the padding problem.
1638 - general clean up, simplification, and coding style.
1639 - Specific clean up of Parse7FE0() (umproperly named actually).
1640 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1642 2004-06-14 Jean-Pierre Roux
1644 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1645 - fix the display of SQItem ordinal number
1646 - add the GetSQItemByOrdinalNumber method
1647 - remove some useless never written private methods
1649 2004-06-14 Jean-Pierre Roux
1651 - adding a constructor taking a gdcmDocEntry as an input param
1652 - ReplaceOrCreateByNumber now returns :
1653 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1654 a gdcmValEntry * if a string value is passed as a param
1656 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1657 according to the param type (no longer sets a gdcmDocEntry)
1658 - GetValEntryByNumber, GetBinEntryByNumber added
1659 - NewValEntryByNumber and NewBinEntryByNumber added
1661 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1663 - GetSQItemNumber and SetSQItemNumber added, to provide
1664 a (relative) Item identier inside a given Sequence
1665 \warning : some pb remaining around this number
1667 - AddEntry now takes the Item Number as a param
1669 - adding a constructor taking a gdcmDocEntry as an input param
1671 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1672 * Memory leak hunt with the following command:
1673 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1674 --show-reachable=yes gdcmTests PrintDocument
1675 It looks like many (all?) leaks are due to the STL (or a bad usage
1676 of the STL. The lines producing the leaks now have a comment with
1677 a "MEMORY LEAK" tag: you can retrieve them with
1678 grep "MEMORY LEAK" src/*
1679 Here are two typical examples which I can't help fixing:
1684 char * test = "babo";
1685 name = test; //// <--- valgrind detects 960 bytes lost in
1686 //// call to std::string::operator=(char const*)
1687 name.clear(); //// Doesn't help !
1695 std::cout << "Type a bunch of characters followed by RETURN: ";
1696 getline(std::cin, line); //// <--- valgrind dectects a loss
1697 //// of 1320 bytes in call to
1698 /// std::basic_istream<>& std::getline<>
1704 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1705 * src/gdcmHeader.[cxx|h]:
1706 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1707 and related, moved away to gdcmDocument.
1708 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1709 the corresponding protected accessors of inherited class
1710 gdcmDocument, removed ! As a consequence gdcmFile had to be
1711 declared friend of class gdcmDocument (see below).
1712 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1713 - Clean up of undefined or unused methods.
1714 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1715 account the changes to gdcmHeader.h).
1716 * src/gdcmDocument.h:
1717 - gdcmFile is now a friend class (in order to take into account the
1718 changes to gdcmHeader.h).
1719 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1720 (see changes to gdcmHeader.h).
1721 - Accessors (reading on the form GetEntry*) are now public.
1722 - Clean up of undefined or unused methods.
1723 * src/gdcmDocument.cxx:
1724 - adaptation to changes to gdcmDocument.h
1725 - ::OpenFile now writes a verbose message when file cannot be opened.
1726 - some std::string properly set to VRKey
1727 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1728 references to gdcmDocument.
1729 * Test/TestFindTags.cxx: changed accordingly to above changes.
1730 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1731 cvs repository gdcmData.
1733 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1734 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1735 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1736 conflicts with gdcmValEntry::voidArea.
1737 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1738 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1739 Value representation between StringRepresentable and BinaryRepresentable.
1740 * src/gdcmDocument.cxx:
1741 - method ParseDES: proper indentation restored and usage of
1742 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1743 - method LoadDocEntry: the fingerprint left in the SetValue() of
1744 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1745 removed. Reverting to previous code segment with the proper
1746 dynamic_cast< gdcmValEntry* >.
1747 Note: this was (partially) breaking the python test suite
1748 (gdcmPython/testSuite.py) that made usage of the above
1749 fingerprint to check presence of "Pixel Data".
1750 * src/gdcmDocEntry.h: coding style.
1751 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1752 now taken into account.
1753 * gdcmPython/gdcm.i: adaptation to the new internal representation
1754 of gdcm (exit gdcmParser, hello gdcmDocument).
1755 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1757 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1758 anymore, but instead prints the loaded Python dictionary.
1759 * .... alas, the python testSuite is still broken.
1761 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1762 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1764 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1765 * src/gdcmUtil.h : export methods
1767 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1768 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1770 * Initial addition of automatic python testing
1771 * Initial addition of automatic image comparison
1773 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1774 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1775 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1777 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1778 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1779 * Test/ShowDicom.cxx : bug fix for msvc compilation
1780 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1782 2004-05-04 Jean-Pierre Roux
1783 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1784 new concepts (and new classes) :
1785 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1786 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1787 - Sequence Doc Entries (gdcmSeqEntries)
1788 a Sequence is composed of Items.
1789 Each item is a set of Doc Entries (this is recursive)
1790 The non uniqueness of the 'Dicom tag' is due to this recursivity
1791 (never taken into account)
1792 Our unability to add a new 'entry' in the header
1793 at the proper location (neither in the H-Table (map or multimap),
1794 nor in the Chained List is also due to this recursivity.
1795 Don't try, right now, to use/modify/compile these new sources :
1796 nothing is finished.
1797 We just commit all the stuff, 'as is', in order not to loose it.
1799 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1800 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1802 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1803 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1804 file prefix (SetFilePrefix)
1806 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1807 * Add a new test: ShowDicom, for now this is just the c++ version of
1808 checkRead.sh, later it will be able to compare the image read against a
1810 * Replace the DEBUG on the stack with a global entry in cmake interface:
1811 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1813 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1814 * Add an example subdir, with a real example on how to read + write a
1817 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1818 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1819 * Doc/CMakeLists.txt: the main page is now properly differentiated
1820 between the developper and user version.
1821 * Doc/doxygen.config.in: dropped search related obsolete flags
1822 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1824 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1825 * DEVELOPPER: added some helpfull comments for compile/test/install
1828 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1829 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1830 src directory, now generated in the build dir.
1831 2. Tests as mentionned smarter
1833 4. Add a new method in gdcmDict that return the PubDict by name
1834 this is interesting for 3rd party lib like ITK,
1835 where we could set the institution name / patient name...
1837 * ENH: 1. Now the test suite is working for real
1838 2. All binaries are now output in the gdcm-bin directory
1839 (this was not true before)
1841 2004-04-28 Jean-Pierre Roux
1842 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1843 SeQuence indented printing of Dicom Header.
1844 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1845 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1846 Computation of SQDepthLevel is now part of gdcmHeader constructor
1847 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1848 tree-like structure of a Dicom Header.
1849 * FIX Test code cleaning
1851 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1852 * ENH: Adding automatic testing
1853 1. Need a DartConfig.cmake to submit to public
1854 2. Add a test driver gdcmTest.cxx
1855 3. gdcmTestMain, an helper for the main test driver gdcmTest
1856 4. Files in Test don't have a main anymore, this becomes interesting
1857 when we add more and more tests, thus dsw don't have to load
1859 * ENH: Adding a GDCM_DATA_ROOT for testing
1860 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1861 one file instead of seven + some small cleanup
1863 2004-04-22 Jean-Pierre Roux
1864 * ENH Minor changes to the Print() methods.
1865 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1866 Header printing. Example given with :
1867 > PrintHeader fileName 2 new
1868 (SQ based tree-like structure still to be done for the Header ...)
1870 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1871 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1872 1. I have added some unsigned where needed
1873 2. Some function parameter not used -> (void)
1874 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1875 4. g++ don't like character '\' in comment
1876 5. #define jpeg_create_decompress jCreaDecompress
1877 this really need to be fixed
1878 6. virtualize destructor of gdcmObject ... leakage
1879 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1880 this also really need to be fixed
1881 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1882 remove compression file
1883 (as we only do decompression, right ?)
1884 * ENH: Change malloc/calloc/free with c++ equivalent
1886 2004-04-21 Jean-Pierre Roux
1887 * FIX gdcmHeaderHelper::GetXSpacing
1888 when a single value is found (bug ?), xpacing is now
1889 defaulted to yspacing
1891 2004-04-19 Jean-Pierre Roux
1892 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1893 * ENH add parameters :
1894 bool exception_on_error = false,
1895 bool enable_sequences = false,
1896 bool ignore_shadow = false
1897 to the gdcmFile constructors to be full gdcmParser compliant
1898 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1899 to allow reading of PAPYRUS 3.0 files
1901 2004-04-06 Jean-Pierre Roux
1902 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1904 2004-04-02 Jean-Pierre Roux
1905 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1906 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1907 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1909 2004-03-30 Jean-Pierre Roux
1910 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1911 for ACR file, written out as DICOM files (hope so...)
1913 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1914 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1915 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1916 moved to base class gdcmParser and only the specialisation is kept
1918 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1919 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1920 already does the job.
1921 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1922 (to be consistent with gdcmParser::WriteEntries).
1924 2004-03-30 Benoit Regrain
1925 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1926 upate of the object's instance. It's passed to 2 in the unfavorable
1927 case : one in the ExecuteInformation, one in the ExecuteData
1929 2004-03-29 Jean-Pierre Roux
1930 * ENH : Check on file type to be written moved
1931 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1932 * FIX : gdcmObject::ResetBoundaries now stops properly
1933 when end-of-list is reached
1934 : gdcmVersion modified (as Benoit Regrain asked)
1936 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1937 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1938 * src/gdcmUtil.cxx: added forgotten iostream include.
1939 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1940 equivalent to ExplicitVR in existing code).
1942 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1943 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1944 now contains all the gdcmGlobal related code.
1945 * minor coding style and doxygenation changes.
1947 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1948 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1949 now contains all the Debug related code.
1950 * minor clean-up of includes in src/*.cxx
1951 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1952 CreateCleanString) removed.
1953 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1954 * Doc/DoxyMainPageUser.txt added.
1955 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1956 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1957 src/gdcmDirList.cxx)
1959 2004-03-24 Jean-Pierre Roux
1960 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1962 2004-03-23 Jean-Pierre Roux
1963 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1964 big endian made volumes
1965 * ENH Now gdcmParser constructor and destructor are protected to forbid
1966 end user to instanciate class gdcmParser
1967 (only gdcmHeader and gdcmDicomDir are meaningfull)
1969 2004-03-22 Benoit Regrain
1970 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1971 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1972 gdcmSerie to gdcmDicomDirSerie
1974 2004-03-19 Jean-Pierre Roux
1975 * ENH Now the tree-like structure describing a DICOMDIR comming from
1976 an already existing DICOMDIR file is consistent with
1977 the home-made tree-like structure build ex-nihilo
1978 or build from the files held (recursively) in a Directory
1979 functions gdcmDicomDir::CheckBoundaries()
1980 gdcmObject::SetBoundaries() added
1982 2004-03-17 Jean-Pierre Roux
1983 * REM (Eric Boix bug) : removal of meaningless
1984 gdcmDicomDirImage::NewImage function.
1985 * FIX now file names and directory name are written properly in the
1987 * FIX now gdcmDicomDir constructor may be call without any trick
1990 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1991 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1992 of gdcmDicomDirImage::NewImage as empty function.
1994 2004-02-28 Jean-Pierre Roux
1995 * ENH add gdcmDicomDir:NewPatient
1996 add gdcmDicomDirPatient:NewStudy
1997 add gdcmDicomDirStudy:NewSerie
1998 add gdcmDicomDirSerie:NewImage
1999 to allow making gdcDicomDir object.
2000 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2001 (as opposite to the gdcmHeader chained list)
2003 2004-02-11 Benoit Regrain
2004 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2005 when using from python
2007 2004-02-10 Benoit Regrain
2008 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2009 * FIX : in gdcmDicomDir when the directory is empty
2010 * ENH : add callback and methods to get the progression of dicomDir
2013 2004-02-06 Jean-Pierre Roux
2014 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2015 - GDCM_META added to gdcmDicomDirType
2016 - class gdcmMeta created
2017 * ENH : - A brief summary is now displayed at the beginning of
2018 'testDicomDir' to help disaster magnitude estimation
2019 * REM : Now useless Test/explDICOMDIR.cxx
2021 2004-02-05 Benoit Regrain
2022 * ENH : add methods in gdcmObject to get the hash table or the list of
2024 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2025 * FIX : wrapping python for TagHeaderEntryHT
2027 2004-02-04 Benoit Regrain
2028 * FIX : even length for some strings when writting the dicom dir
2029 * FIX : sort the images in the dicom dir
2030 * FIX : Bug fix for python use of dicom dir
2031 * ADD : a python demo
2033 2004-02-04 Jean-Pierre Roux
2034 * FIX : Final solution (?) for icone embedded images
2035 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2036 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2037 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2038 gdcmData/gdcm-MR-SIEMENS-16.acr1
2039 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2040 to make full checking easier
2042 2004-02-04 Benoit Regrain
2043 * FIX : WriteEntries : coding style & logic in parameters
2044 * FIX : Set the elements to create the DicomDir in a dictionary file
2046 2004-02-03 Benoit Regrain
2047 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2048 * gdcmDicomDir : add the load of directory
2049 * Bug fix and print add-on
2051 2004-02-03 Jean-Pierre Roux
2052 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2053 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2054 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2055 * FIX gdcmParser.cxx : 'group length' elements are now considered
2056 as integers, even for shadow groups, when file is Implicit VR
2058 2004-02-02 Jean-Pierre Roux
2059 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2061 of the last synonym :-(
2062 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2064 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2065 * FIX taking into account the possible 7fe0,0010 multiplicity
2066 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2067 to allow removal of references to 7fe0,0010, to deal with
2068 ACR-NEMA images, when 0028,0200 is meaningfull
2070 2004-01-31 Jean-Pierre Roux
2071 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2072 no longer writes 'Un' on disk
2073 * FIX SQ elements with actual length are now dealt with corectly
2074 * FIX gdcmFile::WriteBase make the difference, for color images, between
2075 the length (for Palette expanded images)
2076 and Raw Length (non expanded image + Palette)
2077 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2078 (that broke Write). Replaced by UL.
2079 Aware user will reload the field if he
2080 thinks it's necesssary
2082 2004-01-30 Jean-Pierre Roux
2083 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2084 when 'dirty Acr' is found, to be compliant with the new
2085 IsReadable() methods.
2087 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2088 (no DOUBLE images in kosher DICOM,
2089 but so usefull for people that miss them ;-)
2091 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2092 DICOMDIR related utilities (not checked as Windoze compliant)
2094 2004-01-28 Jean-Pierre Roux
2095 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2097 2004-01-27 Jean-Pierre Roux
2098 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2099 to allow skipping the shadow elements, to save memory space.
2100 The TRUE value for this param has to be used
2101 with a FALSE value for the 'enable_sequence' param.
2102 ('public elements' may be embedded in 'shadow Sequences')
2103 * gdcmHeader methods now deal with 'embedded icones images' in the header
2104 (even when an 'icone image sequence' is announced by the
2105 element (0x0088,0x0200), but there is NO icone at all ...
2107 * gdcmHeader sometimes Image Location value doesn't follow
2108 the supposed processor endianity (see gdcmData/cr172241.dcm).
2111 * gdcmHeader add the method
2112 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2113 to get *all* the Header Entries with the same tag.
2114 GetHeaderEntrySameName is probabely *useless*
2115 (no meaning : Name is *not* an identifier within the Dictionary)
2117 2004-01-26 Benoit Regrain
2118 * Bug fix in the print of hexadecimal representations. Remove long fields
2119 in the print and add a third level of print to print them
2121 2004-01-23 Benoit Regrain
2122 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2123 * Bug fix on test suite after remove the strip made on not string fields
2124 * Split the IsReadable method between gdcmParser which test that the file
2125 is dicom and gdcmHeader which test that it's an image file
2127 2004-01-22 Benoit Regrain
2128 * DicomDir : clean code, add methods, set variables in protected or private
2129 * gdcmUtil : bug fix for the clean string method
2131 2004-01-19 Benoit Regrain
2132 * Add the use of shadow dictionaries
2133 * bug fix and coding style
2135 2004-01-19 Benoit Regrain
2136 * src/gdcmFile.cxx : bug fix concerning the close of file
2137 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2138 * Add the update of header entries using the shadow library
2140 2004-01-19 Benoit Regrain
2141 * removal of file gdcmHeader2.cxx
2142 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2143 inheriting from gdcmParser. This split is to prepare the integration
2144 of dicom dir parsing
2145 * bug fix under python
2147 2004-01-16 Jean-Pierre Roux
2148 * REM removal of class gdcmHeaderEntrySet
2149 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2150 * ADD add file gdcmHeader2.cxx
2151 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2153 2004-01-15 Benoit Regrain
2154 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2155 entries created while parsing the header. Thus, they will be destroyed
2156 when the gdcmDictSet will be destroyed
2157 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2160 2004-01-15 Benoit Regrain
2161 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2162 made a fatal error because of the memory release at the end of program.
2163 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2164 some memory and vtk seems to have some problems with that.
2165 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2167 2004-01-14 Benoit Regrain
2168 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2169 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2170 * src/*.[h|cxx] : make changes due to class name changes
2171 * gdcmPython/demo/*.py : bug fix due to method names
2173 2004-01-13 Benoit Regrain
2174 * src/*.[h|cxx] : coding style
2175 * vtk/*.[h|cxx] : coding style
2177 2004-01-13 Benoit Regrain
2178 * gdcmPython/testSuite.py : test the readable flag of file for tests
2179 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2180 It's lied to the stl compilation by MSVC (windows, always windows...)
2181 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2183 2004-01-12 Benoit Regrain
2184 * src/*.h : add comments
2185 * src/gdcmDictSet.h : set the method BuildDictPath in public
2186 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2187 directly setted in the source code
2188 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2191 2004-01-09 Benoit Regrain
2192 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2193 * setup.py : use a reference to gdcmVERSION
2195 2004-01-07 Benoit Regrain
2196 * Modification to compile with the distutils.
2199 2003-12-10 Benoit Regrain
2200 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2201 can use a gdcmHeaderHelper to load data
2202 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2203 made in the source code
2205 2003-12-10 Benoit Regrain
2206 * Update Windows projects and .cvsignore files
2208 2003-11-12 Jean-Pierre Roux
2209 * ENH gdcmHeader constructor has one more parameter (default value : false)
2210 that allows the user to 'go inside' the SeQuences only
2212 gdcmElValSet:Print takes it into account
2214 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2215 * ENH: Update gdcmPython/CMakeLists
2216 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2217 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2219 2003-11-10 Jean-Pierre Roux
2220 * FIX : gdcmHeader::LoadElements is now based
2221 on the ListTag listElem member,
2222 not longer on the TagElValueHT tagHt member
2223 * ENH : PrintPubElVal shows (temporarily) both results,
2224 with the tagHt member and the listElem member.
2225 (it's easier to 'see' the problems when using Printheader)
2227 * FIX : old private member LgrElem is now splitted into
2228 ReadLength : Length actually found on disk (updated only
2229 if bug fixing is necessary), for internal
2231 UsableLength : Updated by FixFoundLength, to fix a bug
2232 or to allow Parser going on.
2233 Will allow to re-write a kosher header when a SeQuence
2234 with a length (not 0000) is found
2235 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2236 because gdcmElValSet::Add does not update ListElem
2239 2003-11-07 Jean-Pierre Roux
2240 * FIX misstyping in Transfert Syntax name table
2241 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2242 when they have an actual length (not 0000 nor FFFFF)
2243 (Nobody should care of it, but DICOMDIR explorers)
2245 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2246 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2248 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2249 * ENH: vtkGdcmReader now supports LUT !
2250 (vtkgdcmViewer for now is not able to use them though)
2252 2003-11-05 Jean-Pierre Roux
2253 * in testSuite.py : new files names for checking the package
2254 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2255 that returns the pixel area size to the *aware* (vtk) user
2256 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2258 2003-11-05 Benoit Regrain
2259 * in testSuite.py : Modify the rules for checking the paths
2260 : Explicit error messages
2261 * in __init__.py : Related modif
2263 2003-11-03 Jean-Pierre Roux
2264 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2265 to be used by aware (vtk) users that want to manage
2266 LUT (and no to turn the PALETTE image into an RGB pixels one)
2267 * GetPixelType now returns 8U for 24 Bits images
2268 (vtkGdcmReader compliant)
2270 2003-10-31 Jean-Pierre Roux
2271 * Removal of *all* gdcmData images and add them again
2272 in order to loose the 'history' of un-anonymised images
2274 2003-10-31 Jean-Pierre Roux
2275 * RMV : removal of useless jBitsInJsample.h
2276 for both 8 and 12 Bits JPEG Lossy Libraries
2278 2003-10-31 Jean-Pierre Roux
2279 * ENH : Add the functions gdcmFile::GetImageDataRaw
2280 gdcmFile::GetImageDataIntoVectorRaw
2281 that act as GetImageData and GetImageDataIntoVector
2282 except the making of an RGB Plane from Gray Plane + LUT
2283 Intended to aware (vtk) users who know how to manage
2286 GetLUTRGBA return a R,G,B,A LUT if any
2287 lgrTotaleRaw gives the 'Raw' length
2288 GetImageDataRaw returns the gray Plane
2289 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2290 (They stay Grey, just like with other Dicom viewers :-(
2292 2003-10-30 Jean-Pierre Roux
2293 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2295 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2296 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2297 being coherents dicom files.
2299 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2300 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2302 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2303 * ENH: Two steps is necessary to please VC++ compiler...
2304 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2305 * ENH: Add include dir to medcon lib
2306 * FIX: only one function is being exported for now !
2307 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2309 2003-10-29 Jean-Pierre Roux
2310 * adding gdcmHeader::GetLUTRGBA
2311 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2312 --> Mathieu, the modif u're waiting for is not yet committed
2313 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2315 2003-10-27 Jean-Pierre Roux
2316 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2317 00191113.dcm DermaColorLossLess.dcm
2318 MxTwinLossLess.dcm RadBWLossLess.dcm
2319 * ENH: For version prior to vtkImageViewer2 -r 1.19
2320 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2322 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2323 * Removal of ido stuff in CMakeLists.txt
2325 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2326 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2327 * FIX: remove a call to ->Modified ... see comments
2328 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2330 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2331 * FIX: Problem with path for libvtkgdcmPython
2332 * ENH: Try adding a search script for python site-package
2333 * RMV: Remove some file from medcon lib that are not necessary
2334 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2335 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2336 * FIX: More pragma disable fro VC++,
2337 I don't think I break something as it is also disable in VTK/ITK.
2338 But it fasten debug compilation time.
2340 2003-10-23 Jean-Pierre Roux
2341 * gdcm now deals with 16 Bits Run Length Encoded images
2342 (they are compressed as 2 planes images,
2343 one for the high Bytes, the other for low Bytes)
2345 2003-10-22 Jean-Pierre Roux
2346 * Now CheckRead takes into account :
2347 - the bugged 'Leonardo' Siemens images
2348 - the XA images, sent thru the burning VPRO station
2349 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2352 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2353 * FIX: When copying a Makefile.am to CMakeLists.txt
2354 one should remove the '\'
2356 2003-10-22 Jean-Pierre Roux
2357 * in gdcmData adding a bugged 'Leonardo' Siemens image
2358 (wrong lengths in header)
2359 OK with gdcm, KO with the other viewers :-)
2360 * add a GE dlx XA image, thru the VEPRO burning station
2363 2003-10-21 Jean-Pierre Roux
2364 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2365 for a brutal checking of vtkgdcmViewer compliance
2367 2003-10-21 Jean-Pierre Roux
2368 * add the files for 'xmedcon' Jpeg Lossless library
2369 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2371 2003-10-21 Jean-Pierre Roux
2372 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2374 2003-10-21 Jean-Pierre Roux
2375 * garbage Siemens 'Leonardo' images dealt with
2376 (the patch is easy to remove)
2377 * cosmetic changes to avoid warnings
2379 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2380 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2381 no need to press 'r' now.
2383 2003-10-20 Jean-Pierre Roux
2384 * upgrade of checkRead.sh checkWrite.sh according
2385 to new Jpeg Lossless decompressor
2386 * add US.3405.1.dcm, a genuine RGB medical file ...
2387 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2388 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2390 2003-10-15 Jean-Pierre Roux
2391 * general anonymisation in gdcmData
2392 * adding the 'color files' from
2393 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2394 * adding some well knowed bugged-header images
2395 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2396 waiting for their inclusion in Python testsuite
2398 2003-10-15 Jean-Pierre Roux
2399 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2400 no longer seg faults when file is not found
2402 2003-10-14 Jean-Pierre Roux
2403 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2406 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2407 * TODO: *.in file to genereate a UseGDCM later
2409 2003-10-14 Jean-Pierre Roux
2410 * Some supposed-to-be Dicom Images have no preamble.
2411 OpenFile takes it into account
2412 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2413 * Missing elements added in dicomV3.dic
2414 (just to be affraid : have a look at
2415 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2416 and do it again next year ;->
2418 2003-10-13 Jean-Pierre Roux
2419 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2420 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2421 But there are NOT. It's fixed !
2423 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2424 * FIX: "jpeglib.h" was not found on VC++
2425 * FIX: vtkgdcm was not being installed
2427 2003-10-10 Jean-Pierre Roux
2428 * ENH : OpenFile closes the file if it *really* doesn't look like
2429 an ACR-NEMA / DICOM one.
2430 * FIX : testWrite no longer writes an empty file if the source file
2431 is not gdcm Readable
2432 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2435 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2436 * FIX: CMake generate now documentation
2437 * ENH: out of source doc build !
2438 * ENH: Generate both user and dev documentation
2439 * ENH: Should work on windows too
2440 * ENH: Only one doxygen config.in file is needed
2441 * FIX: make install should be ok now on ùnix plateform
2442 * FIX: PATH to dictionary was wrong (missing /)
2443 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2445 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2446 * vtkGdcmReader is now able to read rgb dicom file.
2447 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2448 * added a gdcmViewer to vtk test, use mouse to control
2449 window level & window width
2451 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2452 * CMake-ification of gdcm, we have now two build system
2453 * FIX: on cygwin Wsock32 doesn't exist
2454 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2456 2003-10-06 Emanuel Ollart
2457 * FIX : compilation process wad broken.
2458 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2460 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2461 * change gdcmViewer -> vtkgdcmViewer
2462 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2464 2003-10-06 Jean-Pierre Roux
2465 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2466 ( e.g : well known GE images with a wrong elem length,
2467 : Philips MRI Images with a wrong Huffman table)
2468 * still to be done : allow the reading of bugged LEONARDO Siemens images
2470 2003-10-03 Jean-Pierre Roux
2471 * Odd length strings are padded with '\0' (not with spaces,
2472 to remain compliant with already defined strings,
2473 like Transfert Syntax UID and others)
2475 2003-10-03 Jean-Pierre Roux
2476 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2477 to allow displaying RGB images (not only by affim ;-)
2479 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2480 * vtkGdcmReader is now able to read rgb dicom file.
2481 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2483 2003-10-03 Jean-Pierre Roux
2484 * A few nasty patches to allow the reading of a lot of nasty images
2485 ( e.g : well known GE images with a wrong elem length,
2486 : Philips MRI Images with a wrong Huffman table)
2487 * still to be done : allow the reading of bugged LEONARDO Siemens images
2489 2003-10-03 Jean-Pierre Roux
2490 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2492 2003-10-03 Jean-Pierre Roux
2493 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2494 to allow displaying RGB images (not only by affim ;-)
2496 2003-10-03 Jean-Pierre Roux
2497 * gdcmFile::GetImageDataIntoVector now
2498 - deals with MultiFrames MultiFragments Run Length Encoded files
2499 - deals with YcBcR (YBR_FULL) files
2500 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2501 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2503 (no sample found :-(
2505 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2506 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2507 Two reasons: - clear things
2508 - third parties acces gdcm through header files, so won't
2509 suffer anymore VC++ complains
2511 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2512 * add argv[1] in testvtkGdcmReader.cxx
2515 2003-09-24 Jean-Pierre Roux
2516 * The lines are now eigthy characters long.for
2517 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2519 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2520 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2521 char* to std::string. Thus, the use of strdup becomes useless. (see
2522 previous commis of Malaterre)
2523 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2524 before the last Malaterre's commit.
2526 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2527 * This commit should fix the Debug building under VC++, the problem
2528 was mainly a mixture of debug and release lib being loaded at startup.
2529 * I also remove a depency to a specific C function: strdup. Because I had
2530 to force the link to msvcrtd (whereas strdup is in libc).
2532 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2533 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2534 located in the gdcmCommon.h file. All use of reference of tha has been
2535 changed to now use the variable GDCM_UNFOUND.
2537 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2539 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2540 Dicom dictionary. The test suite can now be run again. Note:
2541 I'm note very happy with the " (RET)" changes. I believe this
2542 RETAINED comment should be dropped when parsing the dictionary.
2543 - PACKAGER corrected
2545 - AUTHORS updated and now in alphabetical order
2546 * Makefile.am now exports gdcm.dsw for Windoze users.
2548 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2549 * cygwin complains about missing std:: in subdir Test/
2551 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2552 * remove some methods that are now in gdcmHeaderHelper
2554 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2555 * vtkGdcmReader set spacing and origin correctly
2557 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2558 * Fix a few delete/delete[] mismatch
2560 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2561 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2562 interpretation to data given by gdcmHeader. For instance there are
2563 heuristics to get informations (look at different places).
2564 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2565 sorting DICOM images based on different strategies.
2566 * modified Makefiles accordingly.
2568 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2569 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2570 when building in debug mode
2571 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2572 src/win32/gdcmdll.dsp
2573 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2575 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2576 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2579 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2580 * src/win32/libgdcmjpeg12.dsp was not dos format
2581 * src/win32/libgdcmjpeg12.dsp :
2582 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2583 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2585 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2586 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2588 * src/gdcmFile.cxx : bug fix in affectation type
2589 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2590 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2591 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2592 symbols... future problem ?
2594 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2595 * src/win32/libgdcmijpeg12.dsp was missing
2596 * modified gdcm.dsw accordingly
2598 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2599 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2601 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2602 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2603 commit of JPR (before his hollidays to facilitate our work).
2604 * setup.py : bug fix in code. Modifications made while the last commit
2605 of JPR. The code hasn't been tested before the commit... it's so
2606 useless to make that (for best programmer that is JPR) !!!
2608 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2609 * tagged the current version as Version0_3 (i.e. version 0.3)
2611 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2612 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2613 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2614 * *.dsp : modifications to use new libgdcmijpeg8 library
2615 * setup.py : bug fix on VTKPATH variable
2616 * PACKAGER : adding all concerning windows
2618 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2619 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2621 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2622 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2623 test suite reported error.
2624 * PACKAGER file added (describes what a packager must do when
2625 packaging a new release).
2626 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2627 * configure.in: upgraded version number to 0.3.0
2628 * fixing build of rpm (through rpm -ta):
2629 - Doc/Makefile.am exports proper doxygen files
2630 - src/jpeg/libijg8/Makefile.am exports the include files.
2632 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2633 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2634 * src/gdcmHeader.h : formatting code
2636 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2637 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2638 We were obtaining error message from vtk. Now, creation of file list
2639 is made in an internal list to prevent this problem.
2640 Bug fix when output is empty.
2641 Bug fix in update of progress value. Previous commit for this was a bad
2643 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2645 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2646 * src/gdcmHeader.h : added method to get the file name
2647 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2648 files. Added method to remove all files on the input
2649 Added FIXME comment concerning the bad parsing of header made by
2650 ExecuteInformation method (in ExecuteData method)
2652 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2653 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2654 when using make instal.
2655 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2656 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2658 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2659 * setup.py : adding include dir of jpeg lib to compile all sources
2660 * */Win32/*.dsp : JPR fix for windows compilation
2662 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2663 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2665 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2666 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2668 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2669 * setup.py is again effective on un*x (takes into account the
2670 addon of the jpeg library)
2671 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2672 * Doc/Doxy* updated (includes above enhancements)
2673 * INSTALL now points to web documentation
2675 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2676 * src/gdcmHeader.h doesn't make unnecessary reference to
2678 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2680 * src/gdcm*.[cxx|h] :
2681 - to allow compilation with gcc 3.x
2682 -- clean up of STL usage (added explicit usage of std::)
2683 -- small fixes on exceptions.
2684 Note: linking not tested !
2685 - clean of doxygen comments to avoid warnings at documentation
2687 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2688 dependent convertion).
2690 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2691 * Clean up of previous JPR garbage commit (not even commented in the
2693 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2694 - moved all jpeg related files from src to src/jpeg/libijg8, with
2695 addition/modification of Makefile.am and configure.in.
2696 - the testSuite is still brain damage (not guilty).
2698 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2699 * WrapVTK.py : modifications to get correctly vtk source files to
2701 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2702 (FileName -> Filename)
2704 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2705 * vtk/vtkGdcmReader.[cxx/h]:
2706 - UpdateProgress method should now be effective
2707 - removed the limitation on having only images loaded (as opposed
2709 - when building a stack of images/volume, a lesser number of
2710 gdcmHeader and gdcmFile instances should be used (hopefully
2711 accelerating things).
2712 - when building a stack of images/volumes, files which are not
2713 loadable (wrong path-filename, wrong permissions on existing file,
2714 or file not parsable by gdcm) are replaced with a black image
2715 in the stack (for the caller to notice the problem).
2717 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2718 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2720 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2721 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2722 between standard library (std) and vtk library (problems are found
2723 under Windows... thanks Windows !)
2725 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2726 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2728 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2730 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2731 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2733 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2734 * When compiling with distutils (see setup.py) the C++ compiler is
2735 called with different flags than the default ones (with automake).
2736 In order to fix all those warning, I compiled gdcm with the command
2737 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2738 and went for warning fixes:
2739 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2740 up from unused variables.
2741 - vtk/vtkGdcmReader.cxx: potential bug fix.
2742 * src/gdcmHeader.h: Doxygen warning cleanup
2744 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2745 * gdcmPython/gdcm.i:
2746 - typemaps correction to take into account the systematic replacement
2747 of "using namespace std" with std:: prefix e.g. std::list,
2748 std::string... (cf changes of 2003-05-21).
2749 - gdcmGlob global variable of type gdcmGlobal (defined in
2750 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2751 exported to Python a as cvar.
2752 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2753 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2754 gdcmDictSet.GetPubDictTagNames() and
2755 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2756 C++ static methods).
2757 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2758 with the above changes.
2760 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2761 * setup.py, manifest.in : bug fix under linux
2763 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2764 * Modification of setup.py to compile vtk part too. Then, we have 2
2765 wrappers which must work with same distutils. For that, we have a
2766 generic distutils in distusiltsWrapping.py ; with :
2767 - build_extWrap class to wrap generically all extensions,
2768 - ExtensionWrap base class for all wrapping extension that contains
2770 - Wrapper interface which wrap sources
2771 + In WrapSwig.py we have extension and wrapper for Swig
2772 + In WrapVTK.py we have extension and wrapper for VTK
2773 * MANIFEST.in : modifications to consider vtk directory and new python
2774 files for compilation
2776 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2777 * Added python wrappers of vtkGdcmReader vtk class (see the
2778 source in vtk/vtkGdcmReader.cxx) :
2779 - vtk/Makefile.am now builds a library
2780 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2781 python library (as opposed to _gdcm.so wich are the python
2782 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2783 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2785 - configure.in has an additional flag --enable-vtk that needs
2786 to be set to enable compilation of vtk related code, that is:
2787 + vtk/vtkGdcmReader.so and
2788 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2789 + gdcmPython/vtkgdcmPython.so (see above)
2790 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2791 be read when compressed or when HighBit + 1 != BitsStored),
2792 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2793 the usage of the python wrapper of vtkGdcmReader vtk class.
2794 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2795 * src/*.[h] all occurences of stl classes are now prefixed with
2796 std::, and all occurences of "using namespace std;" where removed.
2797 This is to avoid pollution of global namespace in included files.
2798 Apparently vtk does not avoid this pitfall: when using both
2799 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2800 collision of various stl members (principally cout...).
2801 * gdcmPython/testSuite.py now cleanly removes temprory generated
2803 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2804 comply with above changes)
2806 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2807 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2808 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2809 vtk data structure (an image Flip was required).
2810 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2811 * cosmetic changes in documentation.
2813 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2814 * src/gdcmHeader.cxx: the constructor no longer exits when an
2815 unexisting file is given as argument.
2816 * The subdirectory Data (containing all the images used for the
2817 test suite) is not part of this repository anymore. A new module
2818 containing those images is now available at
2819 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2820 with the name gdcmData.
2821 All the python scripts (including the package initialisation file
2822 gdcmPython/__init__.py) were adapated to take this change into
2823 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2825 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2826 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2827 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2828 demo of the usage of this class.
2829 Compilation of this vtk part is only done when using the --enable-vtk
2830 at configure (or autogen.sh) stage.
2832 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2833 * More memory link related corrections and documentation fixes.
2835 - maximum info is obtained with a command of the form:
2836 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2837 --show-reachable=yes PrintHeader
2838 - the remaining reachable blocks seem to come from the STL
2839 allocation scheme through the usage of map and list. It looks
2840 like this memory cannot be freed but it is not a memory leak
2841 (in fact further invocation to the STL would recollect the
2842 unused memory allthough it cannot explicitely be freed).
2843 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2844 of displaying an image parsed with gdcm and displayed with VTK.
2845 Note: some images don't seem to work e.g.
2846 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2847 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2848 Allthough this weakens the semantics, it is a ditch attempt to
2849 make gdcm more thread friendly.
2851 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2852 * Memory link hunt (by using valgrind through the command
2853 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2854 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2855 gdcmHeader::_dicom_vr.
2856 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2857 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2859 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2861 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2862 * src/Makefile.am now exports all the necessary include files at
2866 * UpdateGroupLength replaced by new one
2869 * UpdateGroupLength re-written using H-Table
2870 (named UpdateGroupLengthNew untill checks are over)
2872 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2873 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2874 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2876 - gdcmHeader::GetPubElValSet removed.
2877 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2878 UpdateGroupLength, WriteElements, Write.
2879 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2880 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2881 carried the same semantics.
2882 - src/gdcmHeaderIdo.cxx changed accordingly.
2883 - gdcmFile::WriteBase now regroups all the codes from previous
2884 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2885 - enum FileType moved to gdcmCommon.h
2886 * src/gdcmHeader.cxx AddDefault trashed
2887 * gdcmGetXSize added
2888 * getimageDataSize now calls gdcmGetXSize
2889 * Test/*.cxx changed to agree with above changes
2891 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2892 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2893 (to avoid double call by end user).
2894 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2895 by end user, since gdcmHeader::gdcmHeader now handles it.
2897 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2898 * gdcm/Doc many doxygen changes:
2899 - Doxyfile now has two different versions, DoxyfileUsers that generates
2900 the html.users end users oriented documentation and
2901 DoxyfileDeveloppers that generates the html.developper developper
2902 oriented documentation.
2903 - README changed accordingly
2904 - requirement.txt removed (old design info moved to TODO).
2905 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2906 DoxyMainPage.txt, DoxyPython.txt provide more information.
2907 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2908 be updated by simply regenerating the docs with doxygen and copying
2909 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2910 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2911 all the tests in the form "if (<map>.count() >1)" were removed.
2912 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2913 ill-formed documentation sections.
2914 * src/gdcmHeader.cxx: ditto
2916 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2917 * setup.py fixed for un*x (needed macro for stdint.h)
2918 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2919 un*ces with sh-utils test utility.
2920 * gdcmPython/demo/test.py renamed to PrintHeader.py
2921 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2922 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2923 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2924 * src/gdcm*.cxx JPR's bad inclusion fixed.
2926 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2927 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2928 * gdcmPython/demo/test.py changed accordingly.
2930 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2931 * gdcmPython/Makefile.am fixed linking against libstdc++
2932 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2933 * Swig subdir (historical tests of swig version 1.3.17++) removed
2934 * Test/testChangeEntete.cxx some lines commented out in order to make
2936 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2937 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2939 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2940 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2941 hence the user doesn't need this explicit call.
2942 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2943 i.e. LoadElements() call removed.
2944 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2945 - src/Makefile.am declares the proper flag for g++.
2946 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2947 for adding user defined new tags.
2948 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2949 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2950 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2952 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2953 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2954 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2955 src/Makefile.am : the project should properly compile and install
2956 with the autotools, included the python wrappers part.
2957 * gdcm.spec.in : added a spec file for RPM packaging.
2959 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2960 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2962 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2963 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2964 to exported to the environement (see gdcmPython/testSuite.py
2966 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2967 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2968 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2969 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2970 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2972 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2973 * gdcmPython/__init__.py doesn't crash anymore when running in
2974 in InstallMode or PreInstallMode but with an environment given
2975 value of GDCM_DICT_PATH.
2976 * src/gdcmDictSet.[cxx/h] coding style.
2978 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2979 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2980 * src/gdcm.h general comments moved to TODO, and README
2981 * src/gdcm.h should now be seen as a user commodity (including it
2982 should suffice to fully use gdcm). It is nowhere including within
2983 any of the kernel files src/*.cxx and src/*.h.
2985 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2986 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2987 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2989 * src/gdcm*.cxx only include their corresponding include file
2990 (as opposed to gdcm.h)
2991 * gdcmPython/gdcm.i changed accordingly
2992 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2993 the autogen.sh generated "make snapshot" command to work.
2994 * autogen.sh removed history related references to crea package.
2996 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2997 * distutilsSwigCPlusPlus.py work around some swig portability
3000 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3001 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3002 was done in a last ditch attempt to get setup.py _really_
3003 operationnal. The python/gdcmPython layaout add the advantage
3004 of hidding away the python related distutils specific files
3005 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3006 Alas, the src directory was out of scope (i.e. it's relative
3007 position to setup.py was ../src) which made things impossible to
3008 handle (see previous version of python/setup.py). Crossing fingers...
3010 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3011 * python/setup.py now works on Un*x. (harder than I thougth)
3012 * python/distutilsSwigCPlusPlus.py can now have include files
3013 among the list of sources.
3015 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3016 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3017 * modifications in MSVC projects
3019 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3020 * As stated by the first lines of Test/ExceptionAndPython/README, it
3021 looks like we can move back to original usage of exception within
3022 src/gdcm* and hence remove the errno stuff that was introduced
3023 as a quick and dirty fixture of this problem (added to the TODO).
3024 * Doc/Doxyfile configuration file for Doxygen and corresponding
3025 README file for usage added.
3026 * Test/testWrite.cxx added. This new test comes from a split of
3027 test.cxx that is now reverted to its original purpous i.e.
3028 testing the proper parsing of a Dicom related file.
3029 testWrite.cxx concentrates on testing the IO part of gdcm.
3030 * Test/bug1.cxx (containing a bug on WIn32) added.
3031 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3032 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3033 whose purpose is to publish the content of the TagNames of the
3034 Dicom public dictionary were not accessible without an
3035 instance of class gdcmHeader.
3036 - those methods are now static methods of gdcmDictSet and hence
3037 require no instances at all to be invocated.
3038 - within gdcmDictSet this change required to change some method
3039 to class methods (i.e. are now static) among which SetDictPath
3040 (renamed to BuildDictPath) and LoadDefaultPubDict.
3041 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3042 the above changes by calling the new method classes of gdcmDictSet.
3043 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3044 the above to be effective.
3045 * python/gdcmPython: in order to wrap properly the above changes
3046 for Python, swig version now needs to be > 1.3.17.
3047 * python/gdcmPython/Makefile fixed to adapt itself to new
3048 configure/make shema introduced by Johan Montagnat (thanks for the
3049 contribution). Alas this Makefile cannot be turned into a proper
3050 Makefile.am without some heavy changes in the configure.in
3051 (for python dectection).
3052 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3053 now avoids publishing the empty entries.
3055 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3056 * python/setup.py : bug fix concerning install under windows
3057 ExtraPath reused :-P
3058 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3060 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3061 * Dicts/dicomV3.dic : remove double spaces !!!
3062 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3063 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3066 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3067 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3068 method. Doxygenation.
3069 * src/gdcm.h clean up of JPR spurious comments.
3071 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3072 * python/distutilsSwigCPlusPlus.py now properly collects the
3073 shadow classes generated by "swig -c++" (gdcm.py in our case)
3074 when using "python setup.py install".
3075 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3076 reexports the working classes.
3077 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3078 by the classical C errno scheme. This is to prevent an obscure
3079 behavior of the python wrappers when importing wxPython.wx prior
3080 to gdcmPython (which ended up in an abort call). An illustration
3081 of this oddity can be found in the Test/ExceptionAndPython
3082 subdir (see the README file). This problem probably due to
3083 an combination of g++ and dynamic loading.
3084 * added Test/ExceptionAndPython (see above)
3086 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3087 * Changed the layout of the python part to avoid bloating main
3088 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3089 i.e. the distutils arsenal. All the python related stuff is
3090 again in a python subdir, but the package itself is now in
3092 * setup.py was cleaned up:
3093 - pythonIncludePath removed
3094 - python setup.py bdist target is now functional.
3095 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3096 collision with other packages). gdcmPython/demo/*.py changed
3099 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3100 * python subdir moved to gdcmPython (preparation of distutils packaging).
3101 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3102 distutils installer is operational.
3103 * - gdcmPython/__init__.py now properly loads the swig generated
3104 shadow classes (from gdcm.py).
3105 - gdcmPython/demo/*.py changed to import the package gdcmPython
3106 instead of gdcmPython/demo/load.py.
3107 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3109 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3110 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3111 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3112 entries within the associated public Dicom dictionary resp. the same
3113 information but sorted by the fourth field (PAT, IMG, DIR) of the
3115 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3116 are now in the "???" group.
3117 - python/gdcm.i changed accordingly,
3118 - python/demo/printGroupedPublicDict.py added, that gives an example
3119 of the above new functionalities in Python.
3121 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3122 * src/gdcm.h, gdcmHeader.cxx:
3123 - historic references to glib's g_malloc and g_free (#defined)
3124 were definitively removed.
3125 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3126 * src/gdcmElValSet.cxx:
3127 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3128 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3129 - GetElValue(string) renamed to GetElValueByName.
3130 - Added GetElementByName(string).
3131 * src/gdcmHeader.cxx: added
3132 - GetPubElValRepByNumber(guint16, guint16)
3133 - GetPubElValRepByName(string)
3134 - GetShaElValRepByNumber(guint16, guint16)
3135 - GetShaElValRepByName(string)
3136 - GetShaElValByNumber(guint16, guint16)
3137 - GetShaElValRepByName(string)
3138 - GetElValRepByNumber(guint16, guint16)
3139 - GetElValRepByName(string)
3140 - GetElValByNumber(guint16, guint16)
3141 - GetElValRepByName(string)
3142 * Doc/requirements.txt added.
3144 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3145 * Test/Makefile building now depends on the one of libgdcm.so
3146 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3147 pixel data) aware which enables finding the address (offset) of
3148 the pixel data of JPEG encoded DICOM files. This leaves only a single
3149 file in the testSuite whose pixel data address (offset) is unknown.
3150 * python/testSuite.py changed accordingly.
3152 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3153 * VC++ has some strong limitations when working with the STL, as stated
3154 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3155 "Also note that some STL containers (map, set, queue, list, deque)
3156 cannot be exported. [...]
3157 Some STL classes contain nested classes. These classes can not
3159 This is caused by a designed limitation that once a template
3160 class is instantiated, it can not be re-instantiated and
3162 Since our usage of map<> is ubiquitous in gdcm, this "designed
3163 limitation" of VC++ is a pitfall.
3164 Hence the Python wrappers of gdcm cannot be incrementally linked
3165 against the c++ dynamic library. The dirty but only workaround is
3166 to forget about incremental link of dynamic libraries and to generate
3167 the Python wrappers library with the inclusions of the underlying C++
3169 The following modifications concern this matter on Win32/VC++:
3170 - wrapping python correct with standalone wrapped dll (don't use separate
3171 dll under windows !!!!)
3172 - python21_d debug mode enabled (ask Frog how to use it :-)
3173 - NO problem with having an STL member of class for example string in C++
3174 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3175 - Python test of dcmlib in Python is ok under windows on a large set
3177 * removed glib references
3178 * typedef's inserted in gdcm.i for correct swig type management
3180 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3181 * python/demo/*.py load.py extracted from test.py. Added explore.py
3182 that only displays required tags and testAll.py that parses all
3183 the files of the testsuite without using unittest.
3184 * python/testSuite.py other additional test on new files added.
3185 * Data/* new test files added accordingly to the testSuite.
3186 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3187 the vr in the file differs from the one of the dictionary.
3189 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3190 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3191 values, but limits itself to values which are below a user specified
3192 size (by default 1024 bytes).
3193 * python/gdcm.i : elements not loaded (because their size is above the
3194 user specified treshold) are exported with their TagKey as key of the
3195 python dictionary. This enables the testsuite to make some checks
3196 on the unloaded elements (since we have their offset and size).
3197 * python/testSuite.py
3198 - now tests for the existence and proper value of the pixel data
3199 - two new examples added.
3200 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3202 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3203 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3204 aware. See the strategy comments in gdcmHeader::FindeLength().
3205 * Test/test.cxx now accepts a filename as first argument.
3206 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3207 * python/testSuite.py changed to integrate test on above files.
3209 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3210 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3211 the vr was also RET.
3212 * python/testSuite.py more tests added.
3214 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3215 * python/testSuite.py unittest test suite added (uses Data)
3216 * Data/* dcm and acr files for the test suite.
3217 * glib dependance removed from un*x version. We now use ISO C99
3218 7.18 Integer types (see stdint.h)
3219 - python/Makefile, src/Makefile src/gdcm.h
3220 * src/ when an explicit vr (like dicom files) suddenly poped an
3221 implicit element we use to mark the underlying DictEntry of the
3222 concerned ElValue with "Implicit". This strategy was damageable
3223 too the public or provite dictionaries, since some of their vr
3224 would be changed. Since Header::FindLength heavily relies on the
3225 detection by Header::FindVR of falsely explicit elements, I
3226 added an extra ImplicitVr member to ElValue (boolean).
3227 The rest of the changes we the necessary adaptations.
3229 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3230 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3232 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3234 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3235 * Adaptation for porting to VC++:
3237 o forced to use std namespace (for string to be known)
3238 o all class use __declspec export style on WIN32
3239 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3240 (in stdlib.h on Win32 but in std:: for gcc)
3241 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3242 variable GDCM_DICT_PATH.
3243 * src/gdcmHeader.cxx verbose comments made discrete.
3245 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3246 * python/gdcm.i: added a typemap that converts a C++ hashing table
3247 to native Python dictionary.
3248 * python/demo/test.py:
3249 - now uses the native dictionary for exploration of gdcmHeader.
3250 - takes an optional filename argument (the file to parse).
3251 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3252 PubElVals hashing table.
3253 * Dicts/dicomV3.dic removed error prone trailing spaces.
3255 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3256 * Python wrapping process moved away from src/Makefile to
3257 newly created python/Makefile (as well as gdcm.i)
3258 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3259 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3260 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3261 from the environement variable GDCM_DICT_PATH (when existing).
3262 * src/gdcmDict::GetTag bug fix.
3264 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3265 * Straightforward temporary fixes for swig to build the python wrappers.
3266 src/Makefile now has a python working entry [by working we mean
3267 that we can import de shadow classes without errors].
3269 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3270 * hashtest.cxx removed (since already in Test)
3271 * src/gdcmlib.h renamed to src/gdcm.h
3272 * src/dcm.i renamed to src/gdcm.i
3273 * src/Makefile prepared for python wrapping
3275 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3276 * src/gdcmHeader.cxx :
3277 - Parsing of header is now separated from loading of element values
3278 (see gdcmHeader::LoadElements).
3279 - general clean up of hopefully all file access (creation of
3280 ReadInt16 and ReadInt32)
3282 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3283 * src/gdcmHeader.cxx :
3284 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3286 - SetLgrElem renamed to SetLength
3287 - GetLgrElem renamed to GetLength
3288 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3289 * src/gdcmElValSet.cxx fixed both GetElValue methods
3290 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3291 due to IdoDude was cleaned out.
3293 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3294 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3295 concentrates on finding the value representation (when it exists).
3296 RecupLgr now only finds the element value length, and it avoids
3297 returning the unecessary skL (skipped length).
3298 Also, offsetCourant was simply removed (with taille_fich) since
3299 it was redundant with the File position internals (by using
3300 ftell and fseek). This also made skL (see above in RecupLgr) usage
3302 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3303 on the libido specificities which are handled through class
3305 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3308 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3309 * Truckload of changes. Parsing of header is barely functional
3310 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3312 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3313 * src/gdcmHeader.cxx many addons of low level methods
3315 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3316 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3317 and _IdDcmSWAP_LONG.
3319 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3320 * This corresponds to all the changes decided at the meeting of
3321 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob