1 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Finish cleaning up my JPEG mess. Should be ok now.
3 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
4 contained within the RLE* class(doh!)
6 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
7 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
8 * SerieHeader::AddFileName() creates as many Coherent Files lists
9 (same Serie UID) as it founds different Serie UID
10 amongst the files instead of discarting any file
11 that doesn't match with the first one he found.
12 * SerieHeader::OrderGdcmFileList has now one parameter :
13 the Coherent Files list the user wants to sort
14 * SerieHeader::GetFirstCoherentFileList() |
15 * SerieHeader::GetLastCoherentFileList() | allow to parse
16 the set of Coherent Files lists
17 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
18 compatibility (it returns the *first* Coherent Files list,
19 since there was only one before)
20 * Test/TestSerieHeader gets gdcmData as a default root directory
22 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * Remove friend between DocEntry and File classes
24 * Remove friend between PixelReadConverter and RLEFramesInfo,
27 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
29 0002|0000. The value was incorrect.
31 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
34 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * src/gdcmUtil.cxx : compilation fix on Win32
36 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
37 variable, to be easy found. Add methods to change the default UID.
38 Amelioration of the CreateUniqueUID to use the correct default UID.
39 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
42 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * Test/TestVR.cxx : fix memory leaks
45 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
46 * Rewrite the base 256 to base 10 conversion, using string operation only.
47 This allows us to get rid of the problematic 64bits integer type (does not
48 always exist on target platform).
50 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
51 * Add construct and destructor to class gdcm::Debug to close the debug file
53 * Don't let uset to open twice the same file
54 * gdcm has now an official UID prefix,
55 supplied by http://www.medicalconnections.co.uk
56 1.2.826.0.1.3680043.2.1143
57 (Thx to Mathieu for providing URL)
58 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
59 to be able to perform some more tests
60 * gdcm::ContentEntry : Contructors and Destructor are now protected,
61 in order to be sure no user will try to use them.
62 (at user level, only the children classes are meaningfull)
64 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * move RLEInfo & JPEGInfo from Document to File
67 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * FIX : remove so many friend between classes
70 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
72 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
74 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
75 In order to avoid missbehaviour :
76 . gdcm::DocEntry is now specialized in
77 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
78 - gdcm::ContentEntry (Dicom entry with a 'content')
79 . gdcm::ContentEntry is specialized in
80 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
81 characters value, or integers)
82 - gdcm::BinEntry (Dicom entry with a non strig representable value
83 (user hasn't any longer to thing about the precedence of his dynamic_casts)
85 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * Test/VTKTest*.cxx : bug fix under linux
88 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
90 use with python. Some methods are moved from Document to ElementSet or
91 DocEntrySet. The equivalent methods to ElementSet have been added to
92 SQItem and are virtual in DocEntrySet. Methods that may have the same code
93 in SQItem and ElementSet is directly placed in DocEntrySet
95 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * Test/VTKTest*.cxx : remove the show variable in each test method because
97 it's useless (the viewer variable replace this variable)
99 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * src/gdcmDocument.cxx : bug fix on potential memory leak
101 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
102 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
103 Add ClearXxx methods to remove all the content of the list or map
104 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
106 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
107 * methods ReplaceOrCreate renamed as Insert
108 (nobody will be any longer confused by 'CreateOrReplace')
110 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
111 * Grealty simplify the JPEg decompression, no need to differenciate based on
112 the JPEG possible type (with/without fragment, with/without multiple frame).
113 Everything is done throught the JPEG IO Suspension mechanism in IJG
115 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
116 * Stage 3 of normalization :
117 in order to avoid any missunderstanding while reading method names :
118 - All the methods xxxEntry now deal with dicom Entries
119 - Methods GetEntry splitted into
122 - Method SetEntry renamed as SetEntryValue
123 - Method SetEntryBinArea let as it was
125 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
126 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
127 - Position correctly the entry points for JPEG2000 and JPEG-LS
128 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
130 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
132 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
133 with other method names
134 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
135 * Test/TestDicomDirElement.cxx : add new test
137 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
138 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
139 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
140 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
141 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
142 So can't you use __int64 in ostream at all.
144 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
145 * bug fix for compilation on MSVC6
146 * gdcmPython/gdcm.i : rename of classes missed
148 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
149 * Stage 2 of names normalization :
150 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
151 (easy to understand ...)
152 - gdcm::FileHelper replaces old class gdcm::File
154 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
156 type and not a string. So, there remove problems on the format of the
159 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
160 * Add Example/TestPapyrus.cxx
161 - reads a Papyrus file (gdcm::Header compliant),
162 - gets the pixels of all the images, using low level iterators
163 - writes an multiframes Dicom image.
164 (Just to show it's *possible* to do that)
165 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
168 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
170 Thus, DicomDirXXX are created with a flad that indicates if the created
171 object is empty or not (when not empty, the DicomDirElement is used to
174 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
175 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
176 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
178 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
179 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
181 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
183 Remove all access to the hash-tables or lists in the objects.
185 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
187 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
188 be complient with all the gdcm source code
190 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
194 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
195 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
198 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * Test/ : rename VTK tests to have a best name for the tests
200 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
201 GetFirstEntry/GetNextEntry use
203 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
204 * In SerieHeader::ImagePositionPatientOrdering()
205 // a Dicom 'Serie' may contain scout views
206 // and images may have differents directions.
207 // -> More than one may have the same 'pos'
208 // Sorting has then NO meaning !
209 Thx to Eduardo Davila for reporting bug.
211 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
213 test. Now it's on image content and not on the resulting visualisation...
214 might solve the problem on linux when using the OpenGL drivers
216 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
217 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
218 DicomDirSerie, DicomDirImage
219 Dict, DictSet classes :
220 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
221 -remove InitTraversal method.
222 * UPD Test programs + Example programs
224 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
225 * remove useless and never updated keyword \ingroup
226 * Solve pb when structure (list, map, ...) is empty.
227 Thx to Benoit for reporting bug
229 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
230 * Taking into account of 'Transfer Syntax' value
231 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
234 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
235 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
236 is no memory access violation
237 * gdcmPython/demo : add python demos using VTK
239 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
240 * FIX 'Dictionnary' is now spelt 'Dictionary'
241 'wether' is now spelt 'whether'
242 'archieve' is now spelt 'archive' ;-)
244 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
245 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
246 related methods, in order not to expose internal mechanisms
249 * REM methods that exposed internal mechanisms :
250 DicomDir::GetDicomDirPatients()
251 DicomDirPatient::GetDicomDirStudies()
252 DicomDirStudy::GetDicomDirSeries()
253 DicomDirSerie::GetDicomDirImages()
254 * UPD Test programs :
258 * UPD Example program
260 * ADD DictSet methods
264 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
265 * Removed the Print/indent/default parameter mess. There is absolutely no
266 reason to have to methods, moreover with the second taking the ostream as
267 *SECOND* parameter. This was clearly a bad hack to get things compile.
269 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
270 * Complete rewrite of the GetMacAddress code. Now the code is *much*
271 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
272 Unfortunately the main code does not work on SunOS, thus provide a specific
273 code for this platform only (and Win32 of course). Since this seems to be
274 working, change CreateUniqueUID to use GetMACAddress instead of the
275 problematic GctestetIPAddress
277 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
278 * Unfortunately to be able to test gdcmDirList I had to break the API
279 a little. Now the class is not a std::list anymore but has a member
280 std::vector (more ITK compatible). Allow unit testing on Win32 and
283 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
284 * Update SerieHeader to take into account a Serie Instance UID to properly
287 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
288 * ENH - Comment out Mathieu's (dangerous) Super Hack
289 for dealing with BIGENDIAN processors
290 - Move equivalent stuff to BinEntry::WriteContent
291 When necessary, 16 Bits Pixels are swapped in a small buffer
292 and then written. This avoid allocating a huge buffer, in
293 PixelWriteConvertor, and avoid modifying the Pixel Area.
295 Probabely, the same operation will have to be done when we want
296 to write image with Big Endian Transfert Syntax,
297 and we are working on Little Endian Processor
299 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
302 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
303 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
304 all the dict content.
305 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
307 * Test/TestDict.cxx : add a new test for the dict classes
309 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
310 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
311 file. Debug is yanked if compiled with NDEBUG
313 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
314 * src/gdcmDictSet.h : set the default output to the os variable
315 * src/gdcmDictEntry.[h|cxx] : add the Print method
316 * gdcmPython/demo/ : add a new test
318 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
319 * merging of Test/PrintDicomDir and Test/TestDicomDir
320 * removal of now redundant Test/PrintDicomDir
321 * enhancement of Example/PrintDicomDir
323 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
324 * Now, python test might work on systems
325 * Add the PrintDicomDir test
327 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
328 * FIX : First entry following group 0002 was lost for
329 Explicit Big Endian Transfer Syntax files
330 (group and elem not swaped)
332 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
333 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
334 Big Endian Transfer Syntax supposed the group following 0002
335 begins always by element 0000 (element 0000 is *optional*)
336 To avoid further troubles, let's be pessimistic, and use
337 Document::HandleOutOfGroup0002() method
338 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
339 (related pb not yet solved)
341 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * Bug fix for the python part use
343 * Now, PrintHeader.py pass... but outside the ctest use. shit !
345 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
348 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
349 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
350 a string and should ask the global TS dict what are the propreties of
353 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
354 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
355 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
356 to swap the Swap Code, at parsing time, when we come out of group 0002
357 and Transfer Syntax is Big Endian
358 We should be able to read now 'true DICOM" Big Endian coded images
359 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
360 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
362 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
363 * Hopefully fix the bug on MacOSX and static global initialization.
364 This is the only -minor- patch I found that both please MacOSX and VS6.
365 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
366 but this would require a lot of change. Another approach would be that Global
367 create those string and GDCM_UNFOUND becomes a pointer to a string (which
368 gdcm::Global would destroy at exit).
370 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
371 * Fix bug on MacOSX with static initialization in a multy threaded
372 environment. static const string in a header file used to be ill
373 initialized provoquing the freeze of any tests. patch should solve this
376 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
377 * According to Benoit's suggestion, and without any objection from anybody
378 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
379 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
380 - method gdcmDicomDirObject::GetEntry() renamed as
381 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
383 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
384 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
385 you debug/warning message just as c++ streams which make them very convinient
386 to use. Once this is stabilize I will change the ostringstrem to be
387 redirected to a file (ofstream).
388 * Properly support C99 extension: __FUNCTION__ which allow us to display
389 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
391 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
392 * Removal of useless and dangerous methods :
393 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
394 GetDocEntryByName, GetEntryByName, GetDictEntryByName
395 * Removal of usless methods :
396 Dict::PrintByName, Dict::GetDictEntryByName
397 * Commenting out of probabely useless methods :
398 Dict::GetDictEntryNames()
399 Dict::GetDictEntryNamesByCategory()
400 DictSet::GetPubDictEntryNames()
401 DictSet::GetPubDictEntryNamesByCategory()
402 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
403 * ENH : Use dicomTS.dic as described in 2004 version
404 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
405 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
406 Add Accessors on VM (Value Multiplicity), and VM related methods
407 * ADD : Add a list of 'Dicom Attribute types', as found in
408 http://medical.nema.org/dicom/2004/04_15PU.PDF
410 * ADD : Add dicomGroupNameAbbreviations.dic
411 should be used to write a method to replace the former
412 Dict::GetDictEntryNamesByCategory()
414 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
415 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
416 to read in the file... and only it ! Length is the efective length of the
417 data in the DocEntry structure
419 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
420 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
421 And now use a static function call instead, with a global variable. i
422 This is much closer to the VTK approach. Hopefully should be bulletproof
423 and easier to use...hopefully
425 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
426 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
428 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
431 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
432 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
433 ValEntry, BinEntry, SeqEntry creation or replace
435 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
436 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
437 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
439 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
440 when specifying the VR
441 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
442 * src/gdcmDocEntry.cxx : amelioration of print
444 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
445 * ADD : Add the method Util::IsCurrentProcessorBigEndian
446 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
447 * ADD Method Document::ComputeGroupLength
448 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
449 in order to allow further VR modification by user
450 * REM : removal of once-called method File::WriteBase
451 integration of its code in formerly one-line method File::Write
453 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
454 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
455 replace the different values "??", "Unkn", "Unknown".
456 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
457 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
458 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
459 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
461 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
462 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
464 * Set the gdcm::Base class to some Printable classes
466 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
467 * src/gdcmFile.[h|cxx] : add the Print method
468 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
469 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
470 * src/gdcmDocument.h : remove the PrintLevel informations
471 * Example/PrintFile.cxx : use the new gdcm::File::Print
473 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
474 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
475 problems when compiling with the python wrapping
477 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
478 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
479 writting in ImplicitVR
481 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
482 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
483 JPEG decompression, especially when dicom frames are split into several
484 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
485 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
487 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
488 * src/gdcmHeader.cxx : change the initialisation of default header.
489 Now, this header is readable by gdm, e-film, DicomWorks
491 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
492 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
493 Rename Decompressed to Raw
494 * Use the API changes in gdcm::File.
495 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
498 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
500 each added entry in the header. Replace the 'Planes' field by the 'Number
503 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
504 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
505 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
507 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
509 At this time, this image isn't readable by e-film... waiting JPR help to
512 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
513 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
514 DocEntry. Now use methods of the Document !
516 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
517 * Test/ShowDicomSeq.cxx : bug fix
519 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
520 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
521 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
522 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
523 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
525 * Test/TestCopyRescaleDicom.cxx : remove unused variable
526 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
527 containing found sequences
529 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
530 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
532 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
533 Some fields in BinEntry must be copied to not seg fault when making the :
534 gdcm::File *copy = new gdcm::File( copyH );
535 and tests are now made on good variables
537 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
538 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
539 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
541 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
542 * Add vtkGdcmWriter example and test
544 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * Test/TestUtil.cxx : reformat the source code
546 * vtk/vtkGdcmReader.cxx : remove and change prints
547 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
549 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
550 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
552 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
553 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
554 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
556 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
557 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
558 by an eof to prevent all bad read of the file... and in this case, the
561 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * Example/Volume2Dicom.cxx : comment unused variables
563 * Test/PrintDicomDir.cxx : comment unused variables
564 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
565 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
566 method that is redondant with AddEntry.
567 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
570 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
571 * Bug fix due my last commit (compilation under Windows).
572 * Example/Volume2Dicom : bug fix in the file and reformatting source code
573 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
575 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
577 - Remove printf / sprintf
578 - include iostream AFTER gdcm so we don't get warnings
579 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
581 - Also remove tons of include from header files, hopefully this should
582 speeup the compilation time, since it was becoming a dog slow.
583 - Remove gdcm.h as it include way too many files and slow down compilation
584 (plus it is not up to date)
585 - remove 'using namespace std' this is BAD !
587 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
588 * Remove memory leaks on the DicomDir
589 * Remove some useless data in DicomDirObject
590 * Add usefull methods in SQItem, to be complient withe the ElementSet
592 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
593 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
595 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
596 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
597 future, with convertion)
598 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
599 and ImageDataSize values. Remove the method to get the PixelReadConverter
600 from the output of the class
602 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
603 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
605 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
606 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
607 and vtkErrorMacro use.
608 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
610 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
611 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
613 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
614 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
615 The string leaves only in the fonction. So when we make a .c_str(), we
616 get the pointeur on the first element, element that will be destroyed
617 immediately after thee instruction.
618 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
619 file has been opened : the test must be made on the content of the
620 pointer and not directly on the pointer !
623 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
624 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
625 the python part recompiles
627 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
628 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
629 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
630 X session is killed (for my computer... it seems to not be identic on
633 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
634 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
635 avoid problems (otherwise, the difference test between the visible image
636 and the reference is incorrect. If the reference is greater than the
637 screen resolution, it's produce errors).
638 Can be used for only one image. Can be used with a visible flag.
639 * vtk/vtkGdcmReader.cxx : remove commented codes.
640 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
641 under windows at compilation
642 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
644 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
646 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
647 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
648 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
649 tests on the image size X, Y, Z
651 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
652 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
653 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
654 between the class name and the file name
656 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
657 * src/ : fix compilation warnings for the Write method (2 different
658 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
659 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
660 variable... create a static method in gdcm::Document to access to
661 this variable content.
663 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
664 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
665 file, to be accessed by other files (like gdcmFile). Remove commented
666 code. Move the change of the header to the gdcmFile, using the
668 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
669 To be sure of that (and simplify calls), the Write of the header now
670 gets a file name and not a file pointer (std::ifstream).
671 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
672 DocEntryArchive. Remove all open of the written file
674 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
675 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
677 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
678 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
679 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
681 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
682 some corresponding methods. Write correctly the file and check before
684 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
685 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
686 is now on RGB data (as before my last commit
687 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
689 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
690 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
691 Add a print information of the type of the entry
692 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
693 It was in the gdcmFile, and all write have been regrouped
694 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
695 Write correctly all dicom files (in decompressed mode only at this time)
696 * Test/ : test on files are now made using Raw data and not color data if
698 * Example/PrintFile.cxx : add more printings
700 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
701 * Amelioration of code, remove some code copy. For the loading of
702 BinEntry (in gdcmDocument), add the test to verify if the file is already
705 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
706 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
707 remove a DocEntry in the header (push an empty DocEntry)
708 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
709 lines. Bug fix in the initialization of the PixelConvert and the
711 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
712 use in TestCopyDicom (now this test can run under windows... but fails)
713 * Test/TestCopyDicom.cxx : amelioration of the test :
714 - test the pixels written
715 - add test points to quickly find where is the error
716 - can set a file name input and output in arguments
717 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
718 amelioration of the test output
720 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
721 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
722 all replaced DocEntry's
723 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
724 Now, each needed DocEntry to modify is duplicated, modified and inserted
725 to the header using DocEntryArchive. Thus, after save, we can restore the
726 header initial state.
728 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
729 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
731 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
732 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
733 correct to copy it. The DictEntry is specified at the DocEntry creation,
734 then, it musn't change in the time.
735 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
736 header correctly. At this time, the change is only made for the first
737 level of the Document. In the future, it might consider sequences.
738 The change is made by replacing a DocEntry by an other that is created
739 outside the class. The old value is kept. When we restore the header
740 status, the added DocEntry is deleted and replaced by the old value.
741 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
742 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
743 set the write type to explicit VR, implicit VR or ACR. Add methods to set
744 the write mode to native, decompressed or RGB (but not used at this time)
746 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
747 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
748 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
750 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
751 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
752 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
754 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
755 set because already copied when copying the BinEntry's of the header
756 * Test/TestAllReadCompareDicom.cxx : remove warnings
758 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
759 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
760 Two problems appear when doing it :
761 - with the gdcmFile : when the GetImageData method is called, the pixels
762 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
763 data (pixels). And each structure destruct the data when it's
764 destructed. So we have two destructions for the same data. To solve it,
765 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
766 data or not. If it doesn't own data, then they will not destroyed by
768 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
769 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
770 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
771 create a double destruction of the same DocEntry's. So, to solve it,
772 the TagHT is simply cleared and the DicomDir* elements are destroyed.
773 * TODO : add an entry concerning memory leaks in the DicomDir
775 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
776 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
777 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
780 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
781 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
782 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
783 after it have been deleted
785 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
786 * FIX: src/* fix the doxygen warnings.
787 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
788 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
789 was erroneously defined with a size of 15 instead of 16. [many thanks
790 to Jean Michel Rouet for pointing out this bug].
792 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
793 1. Finish merging JMR patch for writting DICOM from scratch
794 2. Fix -hopefully- bug with MONOCHROME and space vs null character
795 3. Use const ref when possible
796 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
797 5. A few more comments
798 6. CreateUniqueUID can now be called without parameter"
800 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
801 * ENH: Slightly bigger patch:
802 1. Getting toward full integration of JMR patch for writting dicom from scratch
803 2. Update Test to test part of this patch: CreateUniqueUID
804 3. File was not close properly in gdcmDict
805 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
806 5. Use of const ref instead of copy (speed issue)
807 6. Remove temporary (duplicate) string in TranslateToKey
808 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
809 8. Do not repeat virtual in subclasses
810 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
812 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
813 * Apply first patch toward better string comparison when dealing with broken
814 DICOM files. Essentially the string could be padded with a space instead
815 of a null character as defined by standard
817 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
818 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
819 because never used... and in the same time, that's remove some memory leaks
821 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
822 * src/gdcmFile.cxx : now delete the PixelConvert instance.
823 * In examples and tests : change the type of image data variables from void*
824 to uint8_t*. Remmove all delete on image data variables
826 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
827 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
828 Verify the file pointer value before open the file, and if it's not null,
829 a verbose message is generated.
830 Close correctly the file when the file isn't considered dicom-like. The
831 correctly close is a call to CloseFile.
832 When closing the file pointer, test if its not null to close the file.
833 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
834 file. For an uncompressed image, the copied data correspond in the least
835 case to the image size (calculated) or the image size specified in the
836 header. A verbose is generated if these two size mismatch
838 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
839 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
840 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
841 break under windows (with msvc6 compilation).
843 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
844 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
845 compiling with MSVC6)
847 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
848 * Bugs fix for the Windows build with VC6
849 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
850 needed (only for projects required VTK). If the VTK is included in all
851 projects, there is conflicts with the jpeg lib of vtk when compiling the
852 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
853 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
854 when compiling the gdcm_wrap.cxx file (created by the compilation of the
856 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
857 (like it's already made for the cout use). Otherwise, conflict with the
860 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
861 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
863 - comments on the DicomDir::Method related usage added.
864 - now that we use the namespace gdcm, a lot of internal classes do
865 NOT need to be wrapped anymore.
866 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
867 DicomDir::Method) new example added.
869 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
870 * Improve string manipulation. I now inforce the notion of 'DicomString'
871 A DicomString can contain as many \0 as they want
872 and it is *always* of even length.
873 We only support odd length for very rare case.
874 And in the near future this should be removed.
876 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
877 * /binary_write/ gdcm source. Now even on big endian we are writting
878 little endian. This should -heopfully- fix some tests
880 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
881 * Now the dictionary is compiled into gdcm lib. This is a default
882 behavior, thus any dic file specified is picked before failback to
883 the one comiled into lib
885 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
886 * Change internals for gdcmDict. Don't use any 'new' any more.
887 This should definitely solve any leak problem, and we should be
888 as fast as before, as long as don't modify too much the dictionary.
890 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
891 * STYLE: ivars should start with a capital letter.
892 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
893 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
895 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
896 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
897 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
898 new 2004 dictionaries added (thanks to JPR).
899 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
900 * CLEANUP_ROUND (15) for gdcmPixelConvert
901 - RLEFrame::NumberFragments is now of type unsigned int
902 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
903 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
906 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
907 * Initial work in gathering all transfer syntax accessors. clearly
908 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
909 ivars, but only one transfersyntax (class) ivar with equivalent method on
912 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
913 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
914 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
915 discussed (plus I didn't like having a 2000 lines patch not commited)
917 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
918 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
919 * CLEANUP_ROUND (14) for gdcmPixelConvert
920 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
921 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
922 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
924 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
925 anymore and hence avoids storing a copy of PixelConvert::Decompressed
926 into File::Pixel_Data.
928 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
929 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
930 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
931 * CLEANUP_ROUND (13) for gdcmPixelConvert
932 Substituted File::ParsePixelData() with PixelConvert::Print() new
934 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
935 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
936 method to those classes.
937 - src/gdcmFile.[cxx|h]:
938 -- Added a ::Print() method.
939 -- PixelConverter is now a reference instead of a member.
940 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
941 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
943 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
944 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
945 collaboration diagram and inheritance diagram should be generated with
947 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
948 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
949 pointlessly wrapped (see
950 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
951 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
952 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
953 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
954 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
955 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
956 -- File::Initialise: PixelConverter setup moved away to
957 PixelConverter::GrabInformationsFromHeader()
958 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
959 interpretation moved away to PixelConverter::BuildRGBImage()
961 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
962 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
963 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
965 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
966 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
967 displayed on Win32 when a brutal abort() occurs (because of uncatched
968 exception). See TODO new entry of this commit for more on this.
969 * TODO added new entry.
970 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
971 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
972 - HandleColor is no longer called from gdcmFile.cxx
973 - gdcmPixelConvert.cxx clean up on method arguments and internal
974 variable names for semantical coherence.
976 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
977 * Finished lossless transition, not only do we now read all lossless jpeg
978 images, without the need of the Cornwell lib, but we do read them properly now
979 * To reduce code (well to avoid code duplication), I defined a common place
980 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
981 redefine symbols. This is not perfect but this the best solution I found for a
982 compilation time jpeg option.
984 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
985 * Update jpeg ijg lib to support lossless jpeg implementation
986 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
988 * Also added a special copyright for dcmtk since we use their bugfixes.
991 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
992 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
993 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
994 matters, as stated in warning note at beginning of %include section).
995 * src/gdcmDicomDir*.[cxx|h]: coding style
996 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
997 * src/gdcmJpeg8.cxx: doxygen fix.
998 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
999 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1000 from File:: to PixelConvert::.
1002 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1003 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1004 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1005 - more code moved away from File:: to PixelConvert::
1006 - fat setup of PixelConverter set in place in File::Initialise.
1008 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1009 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1010 namespace at the file system level. So now you should convert your examples
1012 gdcmHeader -> gdcm::Header
1013 It would be nice if people keep in mind to no open the namespace, since it
1014 allows compilation on broken plateform which were defining common symbol in
1015 the standart namespace (like LP, Unknown ...)
1017 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1018 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1019 The JPEG fragments are now parsed at the same stage than the RLE
1020 information. All code related to JPEG is now in gdcmPixelConvert:
1021 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1022 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1023 export a gdcmFile:: method. Those are simply global functions
1024 (for the time being this is better than having them attach to
1025 either gdcmFile:: or gdcmPixelConvert::).
1026 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1027 and stores the result in a gdcmJPEGFragmentsInfo.
1028 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1029 code (among other stuff) moved away from gdcmFile:; to
1032 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1033 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1034 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1035 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1036 clean up of RLE related code.
1037 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1038 - src/gdcmRLE.cxx removed
1039 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1040 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1041 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1042 * CLEANUP_ROUND (9) for gdcmPixelConvert
1043 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1044 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1045 away from gdcmFile:: to gdcmPixelConvert::.
1047 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1048 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1049 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1050 This is because Parse7Fe0 used to parse the pixels to compute the
1051 length. This task was passed over to FindDocEntryLengthOB() a long
1052 time ago, EXCEPT I had forgotten the OW case...
1053 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1054 we just recylce the code for parsing RLE fragments and computing
1056 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1057 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1058 with the retired Parse7Fe0().
1059 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1060 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1062 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1063 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1064 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1065 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1066 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1067 * CLEANUP_ROUND (4) for gdcmPixelConvert
1068 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1069 to return an unused length.
1071 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1072 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1073 this should be cleanner from the plane view. The iostream are erally a pain
1074 to use to do simple stuff.
1076 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1077 * Redo the compilation of the ijg jpeg library. Now only one source is
1078 necesseray. No need to rename file by hand what so ever. CMake handle the
1079 copying of the file within different directory, configure header file to
1080 modify some symbol. The only addition made to ijg wasd a mangle table so
1081 that symbol are different whether we are within 8bits or 12bits.
1083 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1084 * Added documentation of vtkgdcmReader on Website:
1085 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1086 with it's binary name).
1087 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1088 the Website to be more complete.
1089 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1090 doxygenated documentation.
1091 - Doc/DoxyVtkGdcmReaderExamples.txt added
1092 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1093 DoxyVtkGdmReaderExamples.html )
1094 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1095 * CLEANUP_ROUND (3) for gdcmPixelConvert
1096 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1098 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1099 * CLEANUP_ROUND (2) for gdcmPixelConvert
1100 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1102 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1103 * CLEANUP_ROUND for gdcmPixelConvert:
1104 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1105 - src/gdcmPixelStuff[h|cxx] removed
1106 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1107 - src/CMakeLists.txt changed accordingly
1108 * GDCMHOME clean up:
1109 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1110 gdcmVersion.py moved to newly created ATTIC related
1111 gdcmPython/SetupOldies/ directory.
1112 * Autotools clean up:
1113 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1114 - autogen.sh configure.in acinclude.m4 python.m4 removed
1116 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1117 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1118 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1119 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1121 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1122 * TODO updated with Mathieu suggestions. I proposed a template for
1123 describing TODO entries and used it for new entries.
1124 * Added Doc/Website/CodingStyle.html, Developpers.html,
1125 DeveloppersPython.html, GdcmDataCvs.html and
1126 DownloadVersion0_1.html, DownloadVersion0_3.html.
1127 * Some Doc/*.txt Doxygen files (which do not really concern the
1128 documentation itself, but the website) moved to html and
1129 placed in directory Doc/Website:
1130 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1131 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1132 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1133 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1134 * CMakeLists.txt changed accordingly.
1135 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1136 DeveloppersPython.html
1137 * INSTALL nows refers to Doc/Website/Installation.html
1139 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1140 * Added Doc/Website directory, that contains a first raw version
1143 2004-09-23 Jean-Pierre Roux
1144 * FIX In order not to be poluted any longer by casting problems,
1145 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1146 we can now delete[] it safely
1147 * VoidArea is now called BinArea (less confusing name),
1148 and all the methods called ...VoidArea... are now ... BinArea...
1149 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1151 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1152 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1153 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1154 up to the destructor of gdcmElementSet to clean up TagHt and it's
1157 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1158 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1159 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1161 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1162 * ENH: added some utility method that builds a flat dictionary
1163 holding all the Dicom entries contained in the recursive structure
1164 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1165 an example of usage.
1166 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1167 BuildFlatHashTable() that build a flat dictionary.
1168 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1169 gdcmDocument is now a friend of gdcmElementSet.
1170 - src/gdcmElementSet.cxx: clean up.
1171 - Example/FlatHashTablePrint.cxx added.
1172 - Example/CmakeLists.txt changed accordingly
1174 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1175 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1176 moved away from gdcmDocEntrySet (since this class is an abstract class
1177 acting like an interface). SQDepthLevel and BaseTagKey are now
1179 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1180 and associated accessors. Doxygenation of the class.
1181 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1183 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1184 Use SQDepthLevel accessor instead. ::Print() adapted.
1185 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1186 - src/gdcmDocument.cxx changed accordingly.
1188 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1189 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1190 - The following is the doxygen comment of the typedef declaration
1191 of gdcmTagKey in src/gdcmCommon.h:
1192 gdcmTagKey is made to old an "universal" (as in URL, Universal
1193 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1194 A dicom tag always has a group and an element, but a set of tags
1195 embeded in various (optionally nested) sequences and sharing
1196 the same group and element all share the same (group, element)
1197 "identifier". Hence the (group, element) cannot be used as an
1198 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1199 In order to construct a proper tag identifier (i.e. a key) we
1200 consider the following definition of a TagKey:
1201 - let Group, Element be the string representation of the
1202 group and element dicom tag members,
1203 - let ItemNumber be the string representation of the integer
1204 index of the considered item number of a sequence,
1205 Let the key of a tag embeded in a sequence, noted SeqTag, be
1207 /ItemNumber#Group|Element
1208 where "/", "#" and "|" are characters acting as separators.
1209 Then the general form of a gdcmTagKey is given by:
1210 Group|Element<SeqTag>
1211 where <SeqTag> means NO or many instances of SeqTag.
1212 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1215 but the gdcmTagKey of a tag "embeded" is the first item of
1216 a sequence, itself nested in the third item of a sequence is the
1218 0004|1220/2#0008|0082/0#0008|0090
1219 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1220 order to hold the new sequence compatible key. Previously, the
1221 GetKey() method would look in the underlying gdcmDictEntry.
1222 - src/gdcmDocEntry.cxx:
1223 -- constructor now copies the underlying DictEntry key, in the local
1225 -- ::Print: displays the member Key, instead of the (group, element).
1226 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1227 - src/gdcmDocEntrySet.h:xi
1228 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1229 -- now has a new BaseTagKey member.
1231 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1232 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1234 This poses the problem with the semantics of the following lines
1235 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1236 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1237 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1238 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1239 to the long FIXME note for what the problem is. Nevertheless in
1240 order to get things working the dicom dictionary was altered !
1241 Please fix things urgently...
1242 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1243 information), see above note on moving the member VoidArea. Nevertheless
1244 the following entries previously correctly set as US are now inproperly
1246 0028 1201 OW IMG Red Palette Color Lookup Table Data
1247 0028 1202 OW IMG Green Palette Color Lookup Table Data
1248 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1249 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1250 of gdcmDocEntry moved to gdcmSeqEntry.
1251 * src/gdcmSeqEntry.cxx: STYLE.
1253 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1254 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1256 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1257 * gdcmPython/testSuite.py: all the test suite in python is now moved
1258 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1259 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1260 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1262 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1263 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1264 to avoid inclusion recursion until STL is reached.
1265 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1266 mecanism. errno.h is not included in gdcm anymore.
1267 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1268 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1270 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1271 gdcmData/TestAllEntryVerifyReference.txt
1272 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1273 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1274 exception_on_error parameter.
1275 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1276 - vtk/vtkGdcmReader.cxx changed accordingly,
1277 - Example/*.cxx and Test/*.cxx changed accordingly.
1279 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1280 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1281 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1282 enable_sequences removed from gdcmHeader constructor and dependencies.
1283 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1284 * gdcmPython/demo/PrintHeader.py: dummy fix.
1285 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1286 skip_shadow removed from gdcmHeader constructor and dependencies.
1287 * Example/*.cxx and Test/*.cxx changed accordingly.
1289 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1290 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1291 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1293 2004-07-21 Jean-Pierre Roux
1294 * FIX Now, Parsing and Printing a DICOMDIR do work!
1295 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1297 2004-07-20 Jean-Pierre Roux
1298 * FIX Some brain damaged headers have Zero-Lenght fields
1299 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1301 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1302 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1303 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1304 variable (instance of gdcmDebug) by a definition macro, and the instance
1305 is now in static in the gdcmDebug class
1306 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1307 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1309 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1310 * WARNING: ctest now depends more tightly on gdcmData. You should
1311 check out gdcmData properly for things to run smoothly...
1312 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1313 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1314 we need the pixels not be loaded in order to use the ValEntry
1315 that displays position and size).
1316 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1317 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1318 be deprecated. If you have any doubts about the advantages of a
1319 modern scripting language (read Python) versus grass root C++ (i.e.
1320 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1321 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1322 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1323 Anyhow, consider documenting the gdcmData images in
1324 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1326 * Test/CMakeLists.txt:
1327 - now uses TestAllEntryVerify.cxx
1328 - specific comments on oldACR00001.ima (now renamed in gdcmData
1329 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1330 gdcmData/TestAllEntryVerifyReference.txt
1333 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1334 * src/*.[h|cxx] : typedef clean up
1335 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1336 - TagKey renamed to gdcmTagKey (for external usage)
1337 - VRKey renamed to gdcmVRKey (for external usage)
1338 - removal of typedef duplication.
1339 - Removed all unecessary inline keyword from class inline definitions.
1340 - Some method|function(void) declarations replaced with method|function().
1341 * src/jpeg/libijg12/jdhuff12.c:
1342 - printf polluting ctest removed.
1343 - TAB removal for comminting
1345 - TestAllReadCompareDicom.cxx: added a test that compares all the
1346 images in gdcmDataImages.h with corresponding images in
1347 gdcmData/BaselineDicom/. When baseline images are not present
1348 this test creates them.
1349 Note: we need to validate each reference image, but before that
1350 I'd like to rename them with a more explicit name...
1351 - CMakeLists.txt: changed accordingly.
1352 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1353 including each header needed).
1355 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1356 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1357 test suite to the Example directory. Are concerned:
1362 - TestWriteSimple.cxx
1363 * Test/CMakeLists.txt: added some comments on reasons for black listing
1364 image gdcmData/oldACR00001.ima
1366 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1367 * Test/CmakeList.txt: removed the following from black list (to be coherent
1368 with removal from gdcmData):
1369 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1370 - gdcm-MR-PHILIPS-16.dcm
1372 Added the following because after last cvs update, they cause
1373 ctest -R TestReadWriteReadCompare
1375 - gdcm-MR-SIEMENS-16-1.acr
1377 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1378 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1379 new comments in this file) we temporarily (sigh) move to a weaker
1381 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1382 we don't need to black list the following images anymore:
1383 - 8BitsUncompressedColor.dcm
1385 - US-PAL-8-10x-echo.dcm
1386 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1387 fixes and the beautified code ;-)
1388 This fixes the bug introduced in version 1.42 (when beautifying)
1389 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1390 Note: ctest was blind to this bug (this means we need to still
1391 improve the test suite). The bug could be detected by using
1392 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1394 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1395 and by displaying the (garbage) produced file temp.XDCM...
1397 2004-06-29 Jean-Pierre Roux
1398 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1399 - replace by uggly but working old code :-(
1400 A lot of things should be OK again.
1401 It's really urgent to have a test suite that *tests*,
1402 to prevent Frog's beautifying sessions to break all the stuff
1403 (twice, withing a fortnigh ...)
1405 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1406 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1407 redundancy) to added Test/TestReadWriteReadCompare.cxx
1408 * Test/CmakeList.txt: because the compare test of
1409 Test/TestReadWriteReadCompare.cxx fails, the following images are
1410 black listed: - 8BitsUncompressedColor.dcm
1412 - US-PAL-8-10x-echo.dcm
1413 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1414 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1415 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1416 and ad-hoc kludge. This kludge is now removed, and on encountering
1417 such an image (OB field brain damaged) we set errno. Then in
1418 ::FindDocLength() we "fix" the length as being ALL what remains
1419 in the file (until EOF). We then proceed, hoping for the best...
1420 This fixes a SegFault in ShowDicom when trying to write such an
1422 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1423 (because TestWriteRead breaks on it, after a non conformal commit?).
1424 ctest now runs properly, except for MakeDicomDir (which was always
1425 broken) and the Python related stuff (still not fixed).
1427 2004-06-24 Jean-Pierre Roux
1428 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1429 FIX : Test/TestReadWrite now iterates on all the file names
1430 (instead of infinite loop)
1431 ENH : Test/TestWriteRead now iterates on all the file names
1433 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1434 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1436 2004-06-24 Jean-Pierre Roux
1437 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1438 when SamplesPerPixel =3
1439 - now Write is no longer confused by
1440 'BitsAllocated = 12" and 'BitsStored=12"
1441 - "UN" value representation Elements are now written correctly
1442 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1443 ENH : - now gdcmHeader has its own Write methods
1444 (in order to split the job that has not to be done
1447 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1448 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1449 loop on the same image until memory went out.
1450 Note: this means we still have gobs of memory loss in PrintDocument
1451 * src/gdcmDocument.cxx: fixes problem on parsing on file
1452 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1454 2004-06-24 Jean-Pierre Roux
1455 FIX : Write - All the Sequences and Sequence Item are now written
1456 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1457 is added a the end, when necessary.
1458 - A lot of brain-damaged images, that were read correctly are
1459 now written correctly
1460 - length compatible BinEntry are now loaded correctly
1461 (even for odd groups)
1462 Note : only Explicit Value Representation was checked.
1463 (question : is implicit VR really necessary for gdcm ?)
1465 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1466 * DEVELOPPER: added a proposition of coding style.
1467 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1470 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1471 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1472 Use the gdcmDocEntry::Print() and Write() instead.
1473 * src/gdcmDocument.cxx: bug fix.
1475 2004-06-22 Jean-Pierre Roux
1476 FIX : gdcmDocument.cxx
1477 - Now we do recognize the JpegLossLess format (there was a misstyping in
1478 code 'beautyfication' :-(
1479 - Now we automaticaticaly load the Luts, if any
1481 2004-06-22 Jean-Pierre Roux
1482 In order : to write Sequences, whatever their imbrication level,
1483 : to allow user to create his own Sequences
1484 a lot of modif where necessary (adding, moving, or virtualising methods)
1486 WARNING : save your own sources *before* cvs up !
1489 ADD virtual void Write(FILE *fp, FileType filetype);
1492 ADD virtual void Write(FILE *fp, FileType filetype);
1493 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1496 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1497 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1498 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1499 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1500 ADD std::string GetEntryByName(TagName name);
1501 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1503 std::string vr = "unkn",
1504 std::string fourth = "unkn",
1505 std::string name = "unkn");
1506 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1507 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1508 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1509 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1510 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1511 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1512 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1513 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1516 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1517 ADD virtual std::string GetEntryByName (TagName tagName);
1518 ADD virtual std::string GetEntryVRByName (TagName tagName);
1519 REM virtual bool Write(FILE *, FileType);
1520 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1521 FILE *_fp, FileType type);
1522 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1523 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1524 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1525 REM virtual std::string GetEntryByName (std::string tagName);
1526 REM virtual std::string GetEntryVRByName (std::string tagName);
1527 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1528 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1529 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1531 std::string vr = "unkn",
1532 std::string fourth = "unkn",
1533 std::string name = "unkn");
1534 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1535 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1536 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1537 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1540 ADD virtual void Write(FILE *fp, FileType filetype);
1543 ADD virtual void Write(FILE *fp,FileType filetype);
1546 ADD virtual void Write(FILE *fp, FileType filetype);
1547 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1548 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1549 REM std::string GetEntryByName(TagName name);
1552 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1554 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1555 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1556 The default constructor invoked by the line
1557 gdcmHeader *f1 = new gdcmHeader( header );
1558 was gdcmHeader::gdcmHeader(bool) instead of the expected
1559 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1560 Hence the parsing wasn't executed... See also below.
1561 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1562 as explicit constructor didn't do the trick to fix the above problem.
1563 Could anyone explain why ?
1564 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1565 properly calls gdcmValEntry::Print() (that was weed out from
1566 code related to gdcmBinEntry).
1568 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1569 * In order to fix memory leaks:
1570 - Test/TestWriteSimple.cxx: added cleaning of free store through
1572 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1573 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1574 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1575 (through the call to ::AddDicomDirMeta()) or the destructor
1576 would crash when deleting uninitialized ::metaElems].
1577 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1578 - src/gdcmDocument.cxx:
1579 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1580 from dynamic stores.
1581 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1582 was causing memory leaks.
1583 - src/gdcmSQItem.cxx:
1584 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1585 cleanly handled with polymophism: sorry but my milage is low).
1586 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1587 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1588 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1589 This avoids SegFaulting.
1590 - src/gdcmSQItem.h: coding style.
1592 - Test/TestWriteSimple still severely sucks. The output image content
1593 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1594 damaged when displayed with vtkgdcmViewer.
1595 - on memory leaks: TestWriteSimple leaks really less (see entry
1596 of 2004-06-18 in Changelog file for the call to valgrind).
1597 - on segfaults: ctest now passes all the tests but one (no more
1599 * Erroneous leading white fix:
1600 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1601 white[s] (as opposed to from >> xxx, that removes it [them].
1602 - src/gdcmTS.cxx: ditto.
1603 - gdcmPython/testSuite.py: dirty related kludge removed.
1604 * src/*: remaining references to gdcmParser removed.
1605 * src/*[cxx|h]: added copy[way]left header.
1608 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1609 * In order to fix writing of dicom files:
1610 - Test/TestWriteSimple.cxx: a simpler example of writing.
1611 - Test/CMakeLists.txt changed accordingly.
1612 - src/gdcmDocument.cxx:
1613 -- The destructor now recursilvely removes potential sequences.
1614 -- Bug fix in ::IsJPEG2000()
1615 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1616 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1618 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1619 to only declared) and build on top of
1620 ::GetDocEntryByNumber(guint16, guint16).
1621 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1622 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1623 for usage in destructor and treatement of promotion in
1624 ::ReplaceOrCreateByNumber().
1625 - src/gdcmSQItem.cxx: destructor should better handle his job.
1626 Test/TestWriteSimple now runs (or at least it DOES something).
1627 * We can now start hutting memory links. A good starting point is:
1628 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1629 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1630 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1632 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1633 * Valgrind note: after Mathieu Malaterre teached me how to read
1634 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1636 Using gcc, you can force the STL to use malloc and to free memory as
1637 soon as possible by globally disabling memory caching.
1638 With 3.2.2 and later, you should export the environment variable
1639 GLIBCPP_FORCE_NEW before running your program.
1640 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1641 simply vanish (it is still not clear to me, whether this means that
1642 STL std::string leaks or if valgrind believes it leaks...).
1643 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1644 running bin/gdcmTests makeDicomDir):
1645 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1646 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1648 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1649 SegFaulting (I drowned in DicomDir related code when trying to
1650 understand why the list is empty...).
1651 * src/gdcmDocument.h: first BSD license header try.
1652 * Doc/License.txt added.
1654 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1655 * src/gdcmDocument.[h|cxx]:
1656 - Clean up of the Transfer related predicates. They are now all based
1657 on new method isGivenTransferSyntax, that (should) handle properly
1658 the padding problem.
1659 - general clean up, simplification, and coding style.
1660 - Specific clean up of Parse7FE0() (umproperly named actually).
1661 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1663 2004-06-14 Jean-Pierre Roux
1665 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1666 - fix the display of SQItem ordinal number
1667 - add the GetSQItemByOrdinalNumber method
1668 - remove some useless never written private methods
1670 2004-06-14 Jean-Pierre Roux
1672 - adding a constructor taking a gdcmDocEntry as an input param
1673 - ReplaceOrCreateByNumber now returns :
1674 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1675 a gdcmValEntry * if a string value is passed as a param
1677 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1678 according to the param type (no longer sets a gdcmDocEntry)
1679 - GetValEntryByNumber, GetBinEntryByNumber added
1680 - NewValEntryByNumber and NewBinEntryByNumber added
1682 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1684 - GetSQItemNumber and SetSQItemNumber added, to provide
1685 a (relative) Item identier inside a given Sequence
1686 \warning : some pb remaining around this number
1688 - AddEntry now takes the Item Number as a param
1690 - adding a constructor taking a gdcmDocEntry as an input param
1692 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1693 * Memory leak hunt with the following command:
1694 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1695 --show-reachable=yes gdcmTests PrintDocument
1696 It looks like many (all?) leaks are due to the STL (or a bad usage
1697 of the STL. The lines producing the leaks now have a comment with
1698 a "MEMORY LEAK" tag: you can retrieve them with
1699 grep "MEMORY LEAK" src/*
1700 Here are two typical examples which I can't help fixing:
1705 char * test = "babo";
1706 name = test; //// <--- valgrind detects 960 bytes lost in
1707 //// call to std::string::operator=(char const*)
1708 name.clear(); //// Doesn't help !
1716 std::cout << "Type a bunch of characters followed by RETURN: ";
1717 getline(std::cin, line); //// <--- valgrind dectects a loss
1718 //// of 1320 bytes in call to
1719 /// std::basic_istream<>& std::getline<>
1725 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1726 * src/gdcmHeader.[cxx|h]:
1727 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1728 and related, moved away to gdcmDocument.
1729 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1730 the corresponding protected accessors of inherited class
1731 gdcmDocument, removed ! As a consequence gdcmFile had to be
1732 declared friend of class gdcmDocument (see below).
1733 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1734 - Clean up of undefined or unused methods.
1735 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1736 account the changes to gdcmHeader.h).
1737 * src/gdcmDocument.h:
1738 - gdcmFile is now a friend class (in order to take into account the
1739 changes to gdcmHeader.h).
1740 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1741 (see changes to gdcmHeader.h).
1742 - Accessors (reading on the form GetEntry*) are now public.
1743 - Clean up of undefined or unused methods.
1744 * src/gdcmDocument.cxx:
1745 - adaptation to changes to gdcmDocument.h
1746 - ::OpenFile now writes a verbose message when file cannot be opened.
1747 - some std::string properly set to VRKey
1748 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1749 references to gdcmDocument.
1750 * Test/TestFindTags.cxx: changed accordingly to above changes.
1751 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1752 cvs repository gdcmData.
1754 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1755 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1756 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1757 conflicts with gdcmValEntry::voidArea.
1758 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1759 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1760 Value representation between StringRepresentable and BinaryRepresentable.
1761 * src/gdcmDocument.cxx:
1762 - method ParseDES: proper indentation restored and usage of
1763 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1764 - method LoadDocEntry: the fingerprint left in the SetValue() of
1765 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1766 removed. Reverting to previous code segment with the proper
1767 dynamic_cast< gdcmValEntry* >.
1768 Note: this was (partially) breaking the python test suite
1769 (gdcmPython/testSuite.py) that made usage of the above
1770 fingerprint to check presence of "Pixel Data".
1771 * src/gdcmDocEntry.h: coding style.
1772 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1773 now taken into account.
1774 * gdcmPython/gdcm.i: adaptation to the new internal representation
1775 of gdcm (exit gdcmParser, hello gdcmDocument).
1776 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1778 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1779 anymore, but instead prints the loaded Python dictionary.
1780 * .... alas, the python testSuite is still broken.
1782 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1783 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1785 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1786 * src/gdcmUtil.h : export methods
1788 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1789 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1791 * Initial addition of automatic python testing
1792 * Initial addition of automatic image comparison
1794 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1795 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1796 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1798 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1799 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1800 * Test/ShowDicom.cxx : bug fix for msvc compilation
1801 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1803 2004-05-04 Jean-Pierre Roux
1804 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1805 new concepts (and new classes) :
1806 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1807 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1808 - Sequence Doc Entries (gdcmSeqEntries)
1809 a Sequence is composed of Items.
1810 Each item is a set of Doc Entries (this is recursive)
1811 The non uniqueness of the 'Dicom tag' is due to this recursivity
1812 (never taken into account)
1813 Our unability to add a new 'entry' in the header
1814 at the proper location (neither in the H-Table (map or multimap),
1815 nor in the Chained List is also due to this recursivity.
1816 Don't try, right now, to use/modify/compile these new sources :
1817 nothing is finished.
1818 We just commit all the stuff, 'as is', in order not to loose it.
1820 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1821 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1823 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1824 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1825 file prefix (SetFilePrefix)
1827 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1828 * Add a new test: ShowDicom, for now this is just the c++ version of
1829 checkRead.sh, later it will be able to compare the image read against a
1831 * Replace the DEBUG on the stack with a global entry in cmake interface:
1832 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1834 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1835 * Add an example subdir, with a real example on how to read + write a
1838 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1839 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1840 * Doc/CMakeLists.txt: the main page is now properly differentiated
1841 between the developper and user version.
1842 * Doc/doxygen.config.in: dropped search related obsolete flags
1843 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1845 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1846 * DEVELOPPER: added some helpfull comments for compile/test/install
1849 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1850 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1851 src directory, now generated in the build dir.
1852 2. Tests as mentionned smarter
1854 4. Add a new method in gdcmDict that return the PubDict by name
1855 this is interesting for 3rd party lib like ITK,
1856 where we could set the institution name / patient name...
1858 * ENH: 1. Now the test suite is working for real
1859 2. All binaries are now output in the gdcm-bin directory
1860 (this was not true before)
1862 2004-04-28 Jean-Pierre Roux
1863 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1864 SeQuence indented printing of Dicom Header.
1865 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1866 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1867 Computation of SQDepthLevel is now part of gdcmHeader constructor
1868 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1869 tree-like structure of a Dicom Header.
1870 * FIX Test code cleaning
1872 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1873 * ENH: Adding automatic testing
1874 1. Need a DartConfig.cmake to submit to public
1875 2. Add a test driver gdcmTest.cxx
1876 3. gdcmTestMain, an helper for the main test driver gdcmTest
1877 4. Files in Test don't have a main anymore, this becomes interesting
1878 when we add more and more tests, thus dsw don't have to load
1880 * ENH: Adding a GDCM_DATA_ROOT for testing
1881 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1882 one file instead of seven + some small cleanup
1884 2004-04-22 Jean-Pierre Roux
1885 * ENH Minor changes to the Print() methods.
1886 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1887 Header printing. Example given with :
1888 > PrintHeader fileName 2 new
1889 (SQ based tree-like structure still to be done for the Header ...)
1891 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1892 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1893 1. I have added some unsigned where needed
1894 2. Some function parameter not used -> (void)
1895 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1896 4. g++ don't like character '\' in comment
1897 5. #define jpeg_create_decompress jCreaDecompress
1898 this really need to be fixed
1899 6. virtualize destructor of gdcmObject ... leakage
1900 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1901 this also really need to be fixed
1902 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1903 remove compression file
1904 (as we only do decompression, right ?)
1905 * ENH: Change malloc/calloc/free with c++ equivalent
1907 2004-04-21 Jean-Pierre Roux
1908 * FIX gdcmHeaderHelper::GetXSpacing
1909 when a single value is found (bug ?), xpacing is now
1910 defaulted to yspacing
1912 2004-04-19 Jean-Pierre Roux
1913 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1914 * ENH add parameters :
1915 bool exception_on_error = false,
1916 bool enable_sequences = false,
1917 bool ignore_shadow = false
1918 to the gdcmFile constructors to be full gdcmParser compliant
1919 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1920 to allow reading of PAPYRUS 3.0 files
1922 2004-04-06 Jean-Pierre Roux
1923 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1925 2004-04-02 Jean-Pierre Roux
1926 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1927 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1928 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1930 2004-03-30 Jean-Pierre Roux
1931 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1932 for ACR file, written out as DICOM files (hope so...)
1934 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1935 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1936 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1937 moved to base class gdcmParser and only the specialisation is kept
1939 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1940 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1941 already does the job.
1942 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1943 (to be consistent with gdcmParser::WriteEntries).
1945 2004-03-30 Benoit Regrain
1946 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1947 upate of the object's instance. It's passed to 2 in the unfavorable
1948 case : one in the ExecuteInformation, one in the ExecuteData
1950 2004-03-29 Jean-Pierre Roux
1951 * ENH : Check on file type to be written moved
1952 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1953 * FIX : gdcmObject::ResetBoundaries now stops properly
1954 when end-of-list is reached
1955 : gdcmVersion modified (as Benoit Regrain asked)
1957 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1958 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1959 * src/gdcmUtil.cxx: added forgotten iostream include.
1960 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1961 equivalent to ExplicitVR in existing code).
1963 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1964 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1965 now contains all the gdcmGlobal related code.
1966 * minor coding style and doxygenation changes.
1968 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1969 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1970 now contains all the Debug related code.
1971 * minor clean-up of includes in src/*.cxx
1972 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1973 CreateCleanString) removed.
1974 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1975 * Doc/DoxyMainPageUser.txt added.
1976 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1977 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1978 src/gdcmDirList.cxx)
1980 2004-03-24 Jean-Pierre Roux
1981 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1983 2004-03-23 Jean-Pierre Roux
1984 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1985 big endian made volumes
1986 * ENH Now gdcmParser constructor and destructor are protected to forbid
1987 end user to instanciate class gdcmParser
1988 (only gdcmHeader and gdcmDicomDir are meaningfull)
1990 2004-03-22 Benoit Regrain
1991 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1992 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1993 gdcmSerie to gdcmDicomDirSerie
1995 2004-03-19 Jean-Pierre Roux
1996 * ENH Now the tree-like structure describing a DICOMDIR comming from
1997 an already existing DICOMDIR file is consistent with
1998 the home-made tree-like structure build ex-nihilo
1999 or build from the files held (recursively) in a Directory
2000 functions gdcmDicomDir::CheckBoundaries()
2001 gdcmObject::SetBoundaries() added
2003 2004-03-17 Jean-Pierre Roux
2004 * REM (Eric Boix bug) : removal of meaningless
2005 gdcmDicomDirImage::NewImage function.
2006 * FIX now file names and directory name are written properly in the
2008 * FIX now gdcmDicomDir constructor may be call without any trick
2011 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2012 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2013 of gdcmDicomDirImage::NewImage as empty function.
2015 2004-02-28 Jean-Pierre Roux
2016 * ENH add gdcmDicomDir:NewPatient
2017 add gdcmDicomDirPatient:NewStudy
2018 add gdcmDicomDirStudy:NewSerie
2019 add gdcmDicomDirSerie:NewImage
2020 to allow making gdcDicomDir object.
2021 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2022 (as opposite to the gdcmHeader chained list)
2024 2004-02-11 Benoit Regrain
2025 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2026 when using from python
2028 2004-02-10 Benoit Regrain
2029 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2030 * FIX : in gdcmDicomDir when the directory is empty
2031 * ENH : add callback and methods to get the progression of dicomDir
2034 2004-02-06 Jean-Pierre Roux
2035 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2036 - GDCM_META added to gdcmDicomDirType
2037 - class gdcmMeta created
2038 * ENH : - A brief summary is now displayed at the beginning of
2039 'testDicomDir' to help disaster magnitude estimation
2040 * REM : Now useless Test/explDICOMDIR.cxx
2042 2004-02-05 Benoit Regrain
2043 * ENH : add methods in gdcmObject to get the hash table or the list of
2045 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2046 * FIX : wrapping python for TagHeaderEntryHT
2048 2004-02-04 Benoit Regrain
2049 * FIX : even length for some strings when writting the dicom dir
2050 * FIX : sort the images in the dicom dir
2051 * FIX : Bug fix for python use of dicom dir
2052 * ADD : a python demo
2054 2004-02-04 Jean-Pierre Roux
2055 * FIX : Final solution (?) for icone embedded images
2056 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2057 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2058 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2059 gdcmData/gdcm-MR-SIEMENS-16.acr1
2060 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2061 to make full checking easier
2063 2004-02-04 Benoit Regrain
2064 * FIX : WriteEntries : coding style & logic in parameters
2065 * FIX : Set the elements to create the DicomDir in a dictionary file
2067 2004-02-03 Benoit Regrain
2068 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2069 * gdcmDicomDir : add the load of directory
2070 * Bug fix and print add-on
2072 2004-02-03 Jean-Pierre Roux
2073 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2074 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2075 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2076 * FIX gdcmParser.cxx : 'group length' elements are now considered
2077 as integers, even for shadow groups, when file is Implicit VR
2079 2004-02-02 Jean-Pierre Roux
2080 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2082 of the last synonym :-(
2083 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2085 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2086 * FIX taking into account the possible 7fe0,0010 multiplicity
2087 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2088 to allow removal of references to 7fe0,0010, to deal with
2089 ACR-NEMA images, when 0028,0200 is meaningfull
2091 2004-01-31 Jean-Pierre Roux
2092 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2093 no longer writes 'Un' on disk
2094 * FIX SQ elements with actual length are now dealt with corectly
2095 * FIX gdcmFile::WriteBase make the difference, for color images, between
2096 the length (for Palette expanded images)
2097 and Raw Length (non expanded image + Palette)
2098 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2099 (that broke Write). Replaced by UL.
2100 Aware user will reload the field if he
2101 thinks it's necesssary
2103 2004-01-30 Jean-Pierre Roux
2104 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2105 when 'dirty Acr' is found, to be compliant with the new
2106 IsReadable() methods.
2108 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2109 (no DOUBLE images in kosher DICOM,
2110 but so usefull for people that miss them ;-)
2112 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2113 DICOMDIR related utilities (not checked as Windoze compliant)
2115 2004-01-28 Jean-Pierre Roux
2116 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2118 2004-01-27 Jean-Pierre Roux
2119 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2120 to allow skipping the shadow elements, to save memory space.
2121 The TRUE value for this param has to be used
2122 with a FALSE value for the 'enable_sequence' param.
2123 ('public elements' may be embedded in 'shadow Sequences')
2124 * gdcmHeader methods now deal with 'embedded icones images' in the header
2125 (even when an 'icone image sequence' is announced by the
2126 element (0x0088,0x0200), but there is NO icone at all ...
2128 * gdcmHeader sometimes Image Location value doesn't follow
2129 the supposed processor endianity (see gdcmData/cr172241.dcm).
2132 * gdcmHeader add the method
2133 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2134 to get *all* the Header Entries with the same tag.
2135 GetHeaderEntrySameName is probabely *useless*
2136 (no meaning : Name is *not* an identifier within the Dictionary)
2138 2004-01-26 Benoit Regrain
2139 * Bug fix in the print of hexadecimal representations. Remove long fields
2140 in the print and add a third level of print to print them
2142 2004-01-23 Benoit Regrain
2143 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2144 * Bug fix on test suite after remove the strip made on not string fields
2145 * Split the IsReadable method between gdcmParser which test that the file
2146 is dicom and gdcmHeader which test that it's an image file
2148 2004-01-22 Benoit Regrain
2149 * DicomDir : clean code, add methods, set variables in protected or private
2150 * gdcmUtil : bug fix for the clean string method
2152 2004-01-19 Benoit Regrain
2153 * Add the use of shadow dictionaries
2154 * bug fix and coding style
2156 2004-01-19 Benoit Regrain
2157 * src/gdcmFile.cxx : bug fix concerning the close of file
2158 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2159 * Add the update of header entries using the shadow library
2161 2004-01-19 Benoit Regrain
2162 * removal of file gdcmHeader2.cxx
2163 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2164 inheriting from gdcmParser. This split is to prepare the integration
2165 of dicom dir parsing
2166 * bug fix under python
2168 2004-01-16 Jean-Pierre Roux
2169 * REM removal of class gdcmHeaderEntrySet
2170 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2171 * ADD add file gdcmHeader2.cxx
2172 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2174 2004-01-15 Benoit Regrain
2175 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2176 entries created while parsing the header. Thus, they will be destroyed
2177 when the gdcmDictSet will be destroyed
2178 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2181 2004-01-15 Benoit Regrain
2182 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2183 made a fatal error because of the memory release at the end of program.
2184 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2185 some memory and vtk seems to have some problems with that.
2186 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2188 2004-01-14 Benoit Regrain
2189 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2190 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2191 * src/*.[h|cxx] : make changes due to class name changes
2192 * gdcmPython/demo/*.py : bug fix due to method names
2194 2004-01-13 Benoit Regrain
2195 * src/*.[h|cxx] : coding style
2196 * vtk/*.[h|cxx] : coding style
2198 2004-01-13 Benoit Regrain
2199 * gdcmPython/testSuite.py : test the readable flag of file for tests
2200 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2201 It's lied to the stl compilation by MSVC (windows, always windows...)
2202 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2204 2004-01-12 Benoit Regrain
2205 * src/*.h : add comments
2206 * src/gdcmDictSet.h : set the method BuildDictPath in public
2207 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2208 directly setted in the source code
2209 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2212 2004-01-09 Benoit Regrain
2213 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2214 * setup.py : use a reference to gdcmVERSION
2216 2004-01-07 Benoit Regrain
2217 * Modification to compile with the distutils.
2220 2003-12-10 Benoit Regrain
2221 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2222 can use a gdcmHeaderHelper to load data
2223 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2224 made in the source code
2226 2003-12-10 Benoit Regrain
2227 * Update Windows projects and .cvsignore files
2229 2003-11-12 Jean-Pierre Roux
2230 * ENH gdcmHeader constructor has one more parameter (default value : false)
2231 that allows the user to 'go inside' the SeQuences only
2233 gdcmElValSet:Print takes it into account
2235 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2236 * ENH: Update gdcmPython/CMakeLists
2237 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2238 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2240 2003-11-10 Jean-Pierre Roux
2241 * FIX : gdcmHeader::LoadElements is now based
2242 on the ListTag listElem member,
2243 not longer on the TagElValueHT tagHt member
2244 * ENH : PrintPubElVal shows (temporarily) both results,
2245 with the tagHt member and the listElem member.
2246 (it's easier to 'see' the problems when using Printheader)
2248 * FIX : old private member LgrElem is now splitted into
2249 ReadLength : Length actually found on disk (updated only
2250 if bug fixing is necessary), for internal
2252 UsableLength : Updated by FixFoundLength, to fix a bug
2253 or to allow Parser going on.
2254 Will allow to re-write a kosher header when a SeQuence
2255 with a length (not 0000) is found
2256 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2257 because gdcmElValSet::Add does not update ListElem
2260 2003-11-07 Jean-Pierre Roux
2261 * FIX misstyping in Transfert Syntax name table
2262 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2263 when they have an actual length (not 0000 nor FFFFF)
2264 (Nobody should care of it, but DICOMDIR explorers)
2266 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2267 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2269 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2270 * ENH: vtkGdcmReader now supports LUT !
2271 (vtkgdcmViewer for now is not able to use them though)
2273 2003-11-05 Jean-Pierre Roux
2274 * in testSuite.py : new files names for checking the package
2275 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2276 that returns the pixel area size to the *aware* (vtk) user
2277 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2279 2003-11-05 Benoit Regrain
2280 * in testSuite.py : Modify the rules for checking the paths
2281 : Explicit error messages
2282 * in __init__.py : Related modif
2284 2003-11-03 Jean-Pierre Roux
2285 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2286 to be used by aware (vtk) users that want to manage
2287 LUT (and no to turn the PALETTE image into an RGB pixels one)
2288 * GetPixelType now returns 8U for 24 Bits images
2289 (vtkGdcmReader compliant)
2291 2003-10-31 Jean-Pierre Roux
2292 * Removal of *all* gdcmData images and add them again
2293 in order to loose the 'history' of un-anonymised images
2295 2003-10-31 Jean-Pierre Roux
2296 * RMV : removal of useless jBitsInJsample.h
2297 for both 8 and 12 Bits JPEG Lossy Libraries
2299 2003-10-31 Jean-Pierre Roux
2300 * ENH : Add the functions gdcmFile::GetImageDataRaw
2301 gdcmFile::GetImageDataIntoVectorRaw
2302 that act as GetImageData and GetImageDataIntoVector
2303 except the making of an RGB Plane from Gray Plane + LUT
2304 Intended to aware (vtk) users who know how to manage
2307 GetLUTRGBA return a R,G,B,A LUT if any
2308 lgrTotaleRaw gives the 'Raw' length
2309 GetImageDataRaw returns the gray Plane
2310 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2311 (They stay Grey, just like with other Dicom viewers :-(
2313 2003-10-30 Jean-Pierre Roux
2314 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2316 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2317 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2318 being coherents dicom files.
2320 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2321 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2323 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2324 * ENH: Two steps is necessary to please VC++ compiler...
2325 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2326 * ENH: Add include dir to medcon lib
2327 * FIX: only one function is being exported for now !
2328 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2330 2003-10-29 Jean-Pierre Roux
2331 * adding gdcmHeader::GetLUTRGBA
2332 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2333 --> Mathieu, the modif u're waiting for is not yet committed
2334 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2336 2003-10-27 Jean-Pierre Roux
2337 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2338 00191113.dcm DermaColorLossLess.dcm
2339 MxTwinLossLess.dcm RadBWLossLess.dcm
2340 * ENH: For version prior to vtkImageViewer2 -r 1.19
2341 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2343 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2344 * Removal of ido stuff in CMakeLists.txt
2346 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2347 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2348 * FIX: remove a call to ->Modified ... see comments
2349 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2351 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2352 * FIX: Problem with path for libvtkgdcmPython
2353 * ENH: Try adding a search script for python site-package
2354 * RMV: Remove some file from medcon lib that are not necessary
2355 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2356 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2357 * FIX: More pragma disable fro VC++,
2358 I don't think I break something as it is also disable in VTK/ITK.
2359 But it fasten debug compilation time.
2361 2003-10-23 Jean-Pierre Roux
2362 * gdcm now deals with 16 Bits Run Length Encoded images
2363 (they are compressed as 2 planes images,
2364 one for the high Bytes, the other for low Bytes)
2366 2003-10-22 Jean-Pierre Roux
2367 * Now CheckRead takes into account :
2368 - the bugged 'Leonardo' Siemens images
2369 - the XA images, sent thru the burning VPRO station
2370 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2373 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2374 * FIX: When copying a Makefile.am to CMakeLists.txt
2375 one should remove the '\'
2377 2003-10-22 Jean-Pierre Roux
2378 * in gdcmData adding a bugged 'Leonardo' Siemens image
2379 (wrong lengths in header)
2380 OK with gdcm, KO with the other viewers :-)
2381 * add a GE dlx XA image, thru the VEPRO burning station
2384 2003-10-21 Jean-Pierre Roux
2385 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2386 for a brutal checking of vtkgdcmViewer compliance
2388 2003-10-21 Jean-Pierre Roux
2389 * add the files for 'xmedcon' Jpeg Lossless library
2390 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2392 2003-10-21 Jean-Pierre Roux
2393 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2395 2003-10-21 Jean-Pierre Roux
2396 * garbage Siemens 'Leonardo' images dealt with
2397 (the patch is easy to remove)
2398 * cosmetic changes to avoid warnings
2400 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2401 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2402 no need to press 'r' now.
2404 2003-10-20 Jean-Pierre Roux
2405 * upgrade of checkRead.sh checkWrite.sh according
2406 to new Jpeg Lossless decompressor
2407 * add US.3405.1.dcm, a genuine RGB medical file ...
2408 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2409 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2411 2003-10-15 Jean-Pierre Roux
2412 * general anonymisation in gdcmData
2413 * adding the 'color files' from
2414 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2415 * adding some well knowed bugged-header images
2416 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2417 waiting for their inclusion in Python testsuite
2419 2003-10-15 Jean-Pierre Roux
2420 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2421 no longer seg faults when file is not found
2423 2003-10-14 Jean-Pierre Roux
2424 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2427 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2428 * TODO: *.in file to genereate a UseGDCM later
2430 2003-10-14 Jean-Pierre Roux
2431 * Some supposed-to-be Dicom Images have no preamble.
2432 OpenFile takes it into account
2433 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2434 * Missing elements added in dicomV3.dic
2435 (just to be affraid : have a look at
2436 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2437 and do it again next year ;->
2439 2003-10-13 Jean-Pierre Roux
2440 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2441 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2442 But there are NOT. It's fixed !
2444 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2445 * FIX: "jpeglib.h" was not found on VC++
2446 * FIX: vtkgdcm was not being installed
2448 2003-10-10 Jean-Pierre Roux
2449 * ENH : OpenFile closes the file if it *really* doesn't look like
2450 an ACR-NEMA / DICOM one.
2451 * FIX : testWrite no longer writes an empty file if the source file
2452 is not gdcm Readable
2453 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2456 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2457 * FIX: CMake generate now documentation
2458 * ENH: out of source doc build !
2459 * ENH: Generate both user and dev documentation
2460 * ENH: Should work on windows too
2461 * ENH: Only one doxygen config.in file is needed
2462 * FIX: make install should be ok now on ùnix plateform
2463 * FIX: PATH to dictionary was wrong (missing /)
2464 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2466 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2467 * vtkGdcmReader is now able to read rgb dicom file.
2468 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2469 * added a gdcmViewer to vtk test, use mouse to control
2470 window level & window width
2472 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2473 * CMake-ification of gdcm, we have now two build system
2474 * FIX: on cygwin Wsock32 doesn't exist
2475 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2477 2003-10-06 Emanuel Ollart
2478 * FIX : compilation process wad broken.
2479 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2481 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2482 * change gdcmViewer -> vtkgdcmViewer
2483 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2485 2003-10-06 Jean-Pierre Roux
2486 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2487 ( e.g : well known GE images with a wrong elem length,
2488 : Philips MRI Images with a wrong Huffman table)
2489 * still to be done : allow the reading of bugged LEONARDO Siemens images
2491 2003-10-03 Jean-Pierre Roux
2492 * Odd length strings are padded with '\0' (not with spaces,
2493 to remain compliant with already defined strings,
2494 like Transfert Syntax UID and others)
2496 2003-10-03 Jean-Pierre Roux
2497 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2498 to allow displaying RGB images (not only by affim ;-)
2500 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2501 * vtkGdcmReader is now able to read rgb dicom file.
2502 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2504 2003-10-03 Jean-Pierre Roux
2505 * A few nasty patches to allow the reading of a lot of nasty images
2506 ( e.g : well known GE images with a wrong elem length,
2507 : Philips MRI Images with a wrong Huffman table)
2508 * still to be done : allow the reading of bugged LEONARDO Siemens images
2510 2003-10-03 Jean-Pierre Roux
2511 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2513 2003-10-03 Jean-Pierre Roux
2514 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2515 to allow displaying RGB images (not only by affim ;-)
2517 2003-10-03 Jean-Pierre Roux
2518 * gdcmFile::GetImageDataIntoVector now
2519 - deals with MultiFrames MultiFragments Run Length Encoded files
2520 - deals with YcBcR (YBR_FULL) files
2521 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2522 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2524 (no sample found :-(
2526 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2527 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2528 Two reasons: - clear things
2529 - third parties acces gdcm through header files, so won't
2530 suffer anymore VC++ complains
2532 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2533 * add argv[1] in testvtkGdcmReader.cxx
2536 2003-09-24 Jean-Pierre Roux
2537 * The lines are now eigthy characters long.for
2538 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2540 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2541 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2542 char* to std::string. Thus, the use of strdup becomes useless. (see
2543 previous commis of Malaterre)
2544 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2545 before the last Malaterre's commit.
2547 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2548 * This commit should fix the Debug building under VC++, the problem
2549 was mainly a mixture of debug and release lib being loaded at startup.
2550 * I also remove a depency to a specific C function: strdup. Because I had
2551 to force the link to msvcrtd (whereas strdup is in libc).
2553 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2554 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2555 located in the gdcmCommon.h file. All use of reference of tha has been
2556 changed to now use the variable GDCM_UNFOUND.
2558 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2560 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2561 Dicom dictionary. The test suite can now be run again. Note:
2562 I'm note very happy with the " (RET)" changes. I believe this
2563 RETAINED comment should be dropped when parsing the dictionary.
2564 - PACKAGER corrected
2566 - AUTHORS updated and now in alphabetical order
2567 * Makefile.am now exports gdcm.dsw for Windoze users.
2569 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2570 * cygwin complains about missing std:: in subdir Test/
2572 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2573 * remove some methods that are now in gdcmHeaderHelper
2575 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2576 * vtkGdcmReader set spacing and origin correctly
2578 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2579 * Fix a few delete/delete[] mismatch
2581 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2582 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2583 interpretation to data given by gdcmHeader. For instance there are
2584 heuristics to get informations (look at different places).
2585 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2586 sorting DICOM images based on different strategies.
2587 * modified Makefiles accordingly.
2589 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2590 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2591 when building in debug mode
2592 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2593 src/win32/gdcmdll.dsp
2594 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2596 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2597 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2600 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2601 * src/win32/libgdcmjpeg12.dsp was not dos format
2602 * src/win32/libgdcmjpeg12.dsp :
2603 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2604 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2606 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2607 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2609 * src/gdcmFile.cxx : bug fix in affectation type
2610 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2611 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2612 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2613 symbols... future problem ?
2615 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2616 * src/win32/libgdcmijpeg12.dsp was missing
2617 * modified gdcm.dsw accordingly
2619 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2620 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2622 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2623 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2624 commit of JPR (before his hollidays to facilitate our work).
2625 * setup.py : bug fix in code. Modifications made while the last commit
2626 of JPR. The code hasn't been tested before the commit... it's so
2627 useless to make that (for best programmer that is JPR) !!!
2629 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2630 * tagged the current version as Version0_3 (i.e. version 0.3)
2632 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2633 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2634 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2635 * *.dsp : modifications to use new libgdcmijpeg8 library
2636 * setup.py : bug fix on VTKPATH variable
2637 * PACKAGER : adding all concerning windows
2639 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2640 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2642 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2643 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2644 test suite reported error.
2645 * PACKAGER file added (describes what a packager must do when
2646 packaging a new release).
2647 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2648 * configure.in: upgraded version number to 0.3.0
2649 * fixing build of rpm (through rpm -ta):
2650 - Doc/Makefile.am exports proper doxygen files
2651 - src/jpeg/libijg8/Makefile.am exports the include files.
2653 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2654 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2655 * src/gdcmHeader.h : formatting code
2657 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2658 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2659 We were obtaining error message from vtk. Now, creation of file list
2660 is made in an internal list to prevent this problem.
2661 Bug fix when output is empty.
2662 Bug fix in update of progress value. Previous commit for this was a bad
2664 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2666 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2667 * src/gdcmHeader.h : added method to get the file name
2668 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2669 files. Added method to remove all files on the input
2670 Added FIXME comment concerning the bad parsing of header made by
2671 ExecuteInformation method (in ExecuteData method)
2673 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2674 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2675 when using make instal.
2676 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2677 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2679 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2680 * setup.py : adding include dir of jpeg lib to compile all sources
2681 * */Win32/*.dsp : JPR fix for windows compilation
2683 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2684 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2686 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2687 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2689 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2690 * setup.py is again effective on un*x (takes into account the
2691 addon of the jpeg library)
2692 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2693 * Doc/Doxy* updated (includes above enhancements)
2694 * INSTALL now points to web documentation
2696 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2697 * src/gdcmHeader.h doesn't make unnecessary reference to
2699 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2701 * src/gdcm*.[cxx|h] :
2702 - to allow compilation with gcc 3.x
2703 -- clean up of STL usage (added explicit usage of std::)
2704 -- small fixes on exceptions.
2705 Note: linking not tested !
2706 - clean of doxygen comments to avoid warnings at documentation
2708 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2709 dependent convertion).
2711 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2712 * Clean up of previous JPR garbage commit (not even commented in the
2714 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2715 - moved all jpeg related files from src to src/jpeg/libijg8, with
2716 addition/modification of Makefile.am and configure.in.
2717 - the testSuite is still brain damage (not guilty).
2719 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2720 * WrapVTK.py : modifications to get correctly vtk source files to
2722 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2723 (FileName -> Filename)
2725 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2726 * vtk/vtkGdcmReader.[cxx/h]:
2727 - UpdateProgress method should now be effective
2728 - removed the limitation on having only images loaded (as opposed
2730 - when building a stack of images/volume, a lesser number of
2731 gdcmHeader and gdcmFile instances should be used (hopefully
2732 accelerating things).
2733 - when building a stack of images/volumes, files which are not
2734 loadable (wrong path-filename, wrong permissions on existing file,
2735 or file not parsable by gdcm) are replaced with a black image
2736 in the stack (for the caller to notice the problem).
2738 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2739 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2741 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2742 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2743 between standard library (std) and vtk library (problems are found
2744 under Windows... thanks Windows !)
2746 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2747 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2749 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2751 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2752 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2754 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2755 * When compiling with distutils (see setup.py) the C++ compiler is
2756 called with different flags than the default ones (with automake).
2757 In order to fix all those warning, I compiled gdcm with the command
2758 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2759 and went for warning fixes:
2760 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2761 up from unused variables.
2762 - vtk/vtkGdcmReader.cxx: potential bug fix.
2763 * src/gdcmHeader.h: Doxygen warning cleanup
2765 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2766 * gdcmPython/gdcm.i:
2767 - typemaps correction to take into account the systematic replacement
2768 of "using namespace std" with std:: prefix e.g. std::list,
2769 std::string... (cf changes of 2003-05-21).
2770 - gdcmGlob global variable of type gdcmGlobal (defined in
2771 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2772 exported to Python a as cvar.
2773 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2774 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2775 gdcmDictSet.GetPubDictTagNames() and
2776 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2777 C++ static methods).
2778 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2779 with the above changes.
2781 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2782 * setup.py, manifest.in : bug fix under linux
2784 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2785 * Modification of setup.py to compile vtk part too. Then, we have 2
2786 wrappers which must work with same distutils. For that, we have a
2787 generic distutils in distusiltsWrapping.py ; with :
2788 - build_extWrap class to wrap generically all extensions,
2789 - ExtensionWrap base class for all wrapping extension that contains
2791 - Wrapper interface which wrap sources
2792 + In WrapSwig.py we have extension and wrapper for Swig
2793 + In WrapVTK.py we have extension and wrapper for VTK
2794 * MANIFEST.in : modifications to consider vtk directory and new python
2795 files for compilation
2797 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2798 * Added python wrappers of vtkGdcmReader vtk class (see the
2799 source in vtk/vtkGdcmReader.cxx) :
2800 - vtk/Makefile.am now builds a library
2801 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2802 python library (as opposed to _gdcm.so wich are the python
2803 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2804 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2806 - configure.in has an additional flag --enable-vtk that needs
2807 to be set to enable compilation of vtk related code, that is:
2808 + vtk/vtkGdcmReader.so and
2809 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2810 + gdcmPython/vtkgdcmPython.so (see above)
2811 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2812 be read when compressed or when HighBit + 1 != BitsStored),
2813 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2814 the usage of the python wrapper of vtkGdcmReader vtk class.
2815 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2816 * src/*.[h] all occurences of stl classes are now prefixed with
2817 std::, and all occurences of "using namespace std;" where removed.
2818 This is to avoid pollution of global namespace in included files.
2819 Apparently vtk does not avoid this pitfall: when using both
2820 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2821 collision of various stl members (principally cout...).
2822 * gdcmPython/testSuite.py now cleanly removes temprory generated
2824 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2825 comply with above changes)
2827 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2828 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2829 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2830 vtk data structure (an image Flip was required).
2831 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2832 * cosmetic changes in documentation.
2834 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2835 * src/gdcmHeader.cxx: the constructor no longer exits when an
2836 unexisting file is given as argument.
2837 * The subdirectory Data (containing all the images used for the
2838 test suite) is not part of this repository anymore. A new module
2839 containing those images is now available at
2840 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2841 with the name gdcmData.
2842 All the python scripts (including the package initialisation file
2843 gdcmPython/__init__.py) were adapated to take this change into
2844 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2846 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2847 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2848 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2849 demo of the usage of this class.
2850 Compilation of this vtk part is only done when using the --enable-vtk
2851 at configure (or autogen.sh) stage.
2853 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2854 * More memory link related corrections and documentation fixes.
2856 - maximum info is obtained with a command of the form:
2857 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2858 --show-reachable=yes PrintHeader
2859 - the remaining reachable blocks seem to come from the STL
2860 allocation scheme through the usage of map and list. It looks
2861 like this memory cannot be freed but it is not a memory leak
2862 (in fact further invocation to the STL would recollect the
2863 unused memory allthough it cannot explicitely be freed).
2864 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2865 of displaying an image parsed with gdcm and displayed with VTK.
2866 Note: some images don't seem to work e.g.
2867 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2868 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2869 Allthough this weakens the semantics, it is a ditch attempt to
2870 make gdcm more thread friendly.
2872 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2873 * Memory link hunt (by using valgrind through the command
2874 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2875 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2876 gdcmHeader::_dicom_vr.
2877 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2878 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2880 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2882 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2883 * src/Makefile.am now exports all the necessary include files at
2887 * UpdateGroupLength replaced by new one
2890 * UpdateGroupLength re-written using H-Table
2891 (named UpdateGroupLengthNew untill checks are over)
2893 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2894 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2895 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2897 - gdcmHeader::GetPubElValSet removed.
2898 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2899 UpdateGroupLength, WriteElements, Write.
2900 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2901 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2902 carried the same semantics.
2903 - src/gdcmHeaderIdo.cxx changed accordingly.
2904 - gdcmFile::WriteBase now regroups all the codes from previous
2905 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2906 - enum FileType moved to gdcmCommon.h
2907 * src/gdcmHeader.cxx AddDefault trashed
2908 * gdcmGetXSize added
2909 * getimageDataSize now calls gdcmGetXSize
2910 * Test/*.cxx changed to agree with above changes
2912 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2913 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2914 (to avoid double call by end user).
2915 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2916 by end user, since gdcmHeader::gdcmHeader now handles it.
2918 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2919 * gdcm/Doc many doxygen changes:
2920 - Doxyfile now has two different versions, DoxyfileUsers that generates
2921 the html.users end users oriented documentation and
2922 DoxyfileDeveloppers that generates the html.developper developper
2923 oriented documentation.
2924 - README changed accordingly
2925 - requirement.txt removed (old design info moved to TODO).
2926 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2927 DoxyMainPage.txt, DoxyPython.txt provide more information.
2928 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2929 be updated by simply regenerating the docs with doxygen and copying
2930 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2931 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2932 all the tests in the form "if (<map>.count() >1)" were removed.
2933 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2934 ill-formed documentation sections.
2935 * src/gdcmHeader.cxx: ditto
2937 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2938 * setup.py fixed for un*x (needed macro for stdint.h)
2939 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2940 un*ces with sh-utils test utility.
2941 * gdcmPython/demo/test.py renamed to PrintHeader.py
2942 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2943 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2944 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2945 * src/gdcm*.cxx JPR's bad inclusion fixed.
2947 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2948 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2949 * gdcmPython/demo/test.py changed accordingly.
2951 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2952 * gdcmPython/Makefile.am fixed linking against libstdc++
2953 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2954 * Swig subdir (historical tests of swig version 1.3.17++) removed
2955 * Test/testChangeEntete.cxx some lines commented out in order to make
2957 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2958 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2960 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2961 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2962 hence the user doesn't need this explicit call.
2963 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2964 i.e. LoadElements() call removed.
2965 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2966 - src/Makefile.am declares the proper flag for g++.
2967 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2968 for adding user defined new tags.
2969 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2970 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2971 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2973 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2974 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2975 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2976 src/Makefile.am : the project should properly compile and install
2977 with the autotools, included the python wrappers part.
2978 * gdcm.spec.in : added a spec file for RPM packaging.
2980 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2981 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2983 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2984 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2985 to exported to the environement (see gdcmPython/testSuite.py
2987 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2988 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2989 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2990 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2991 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2993 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2994 * gdcmPython/__init__.py doesn't crash anymore when running in
2995 in InstallMode or PreInstallMode but with an environment given
2996 value of GDCM_DICT_PATH.
2997 * src/gdcmDictSet.[cxx/h] coding style.
2999 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3000 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3001 * src/gdcm.h general comments moved to TODO, and README
3002 * src/gdcm.h should now be seen as a user commodity (including it
3003 should suffice to fully use gdcm). It is nowhere including within
3004 any of the kernel files src/*.cxx and src/*.h.
3006 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3007 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3008 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3010 * src/gdcm*.cxx only include their corresponding include file
3011 (as opposed to gdcm.h)
3012 * gdcmPython/gdcm.i changed accordingly
3013 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3014 the autogen.sh generated "make snapshot" command to work.
3015 * autogen.sh removed history related references to crea package.
3017 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3018 * distutilsSwigCPlusPlus.py work around some swig portability
3021 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3022 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3023 was done in a last ditch attempt to get setup.py _really_
3024 operationnal. The python/gdcmPython layaout add the advantage
3025 of hidding away the python related distutils specific files
3026 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3027 Alas, the src directory was out of scope (i.e. it's relative
3028 position to setup.py was ../src) which made things impossible to
3029 handle (see previous version of python/setup.py). Crossing fingers...
3031 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3032 * python/setup.py now works on Un*x. (harder than I thougth)
3033 * python/distutilsSwigCPlusPlus.py can now have include files
3034 among the list of sources.
3036 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3037 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3038 * modifications in MSVC projects
3040 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3041 * As stated by the first lines of Test/ExceptionAndPython/README, it
3042 looks like we can move back to original usage of exception within
3043 src/gdcm* and hence remove the errno stuff that was introduced
3044 as a quick and dirty fixture of this problem (added to the TODO).
3045 * Doc/Doxyfile configuration file for Doxygen and corresponding
3046 README file for usage added.
3047 * Test/testWrite.cxx added. This new test comes from a split of
3048 test.cxx that is now reverted to its original purpous i.e.
3049 testing the proper parsing of a Dicom related file.
3050 testWrite.cxx concentrates on testing the IO part of gdcm.
3051 * Test/bug1.cxx (containing a bug on WIn32) added.
3052 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3053 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3054 whose purpose is to publish the content of the TagNames of the
3055 Dicom public dictionary were not accessible without an
3056 instance of class gdcmHeader.
3057 - those methods are now static methods of gdcmDictSet and hence
3058 require no instances at all to be invocated.
3059 - within gdcmDictSet this change required to change some method
3060 to class methods (i.e. are now static) among which SetDictPath
3061 (renamed to BuildDictPath) and LoadDefaultPubDict.
3062 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3063 the above changes by calling the new method classes of gdcmDictSet.
3064 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3065 the above to be effective.
3066 * python/gdcmPython: in order to wrap properly the above changes
3067 for Python, swig version now needs to be > 1.3.17.
3068 * python/gdcmPython/Makefile fixed to adapt itself to new
3069 configure/make shema introduced by Johan Montagnat (thanks for the
3070 contribution). Alas this Makefile cannot be turned into a proper
3071 Makefile.am without some heavy changes in the configure.in
3072 (for python dectection).
3073 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3074 now avoids publishing the empty entries.
3076 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3077 * python/setup.py : bug fix concerning install under windows
3078 ExtraPath reused :-P
3079 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3081 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3082 * Dicts/dicomV3.dic : remove double spaces !!!
3083 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3084 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3087 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3088 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3089 method. Doxygenation.
3090 * src/gdcm.h clean up of JPR spurious comments.
3092 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3093 * python/distutilsSwigCPlusPlus.py now properly collects the
3094 shadow classes generated by "swig -c++" (gdcm.py in our case)
3095 when using "python setup.py install".
3096 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3097 reexports the working classes.
3098 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3099 by the classical C errno scheme. This is to prevent an obscure
3100 behavior of the python wrappers when importing wxPython.wx prior
3101 to gdcmPython (which ended up in an abort call). An illustration
3102 of this oddity can be found in the Test/ExceptionAndPython
3103 subdir (see the README file). This problem probably due to
3104 an combination of g++ and dynamic loading.
3105 * added Test/ExceptionAndPython (see above)
3107 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3108 * Changed the layout of the python part to avoid bloating main
3109 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3110 i.e. the distutils arsenal. All the python related stuff is
3111 again in a python subdir, but the package itself is now in
3113 * setup.py was cleaned up:
3114 - pythonIncludePath removed
3115 - python setup.py bdist target is now functional.
3116 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3117 collision with other packages). gdcmPython/demo/*.py changed
3120 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3121 * python subdir moved to gdcmPython (preparation of distutils packaging).
3122 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3123 distutils installer is operational.
3124 * - gdcmPython/__init__.py now properly loads the swig generated
3125 shadow classes (from gdcm.py).
3126 - gdcmPython/demo/*.py changed to import the package gdcmPython
3127 instead of gdcmPython/demo/load.py.
3128 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3130 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3131 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3132 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3133 entries within the associated public Dicom dictionary resp. the same
3134 information but sorted by the fourth field (PAT, IMG, DIR) of the
3136 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3137 are now in the "???" group.
3138 - python/gdcm.i changed accordingly,
3139 - python/demo/printGroupedPublicDict.py added, that gives an example
3140 of the above new functionalities in Python.
3142 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3143 * src/gdcm.h, gdcmHeader.cxx:
3144 - historic references to glib's g_malloc and g_free (#defined)
3145 were definitively removed.
3146 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3147 * src/gdcmElValSet.cxx:
3148 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3149 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3150 - GetElValue(string) renamed to GetElValueByName.
3151 - Added GetElementByName(string).
3152 * src/gdcmHeader.cxx: added
3153 - GetPubElValRepByNumber(guint16, guint16)
3154 - GetPubElValRepByName(string)
3155 - GetShaElValRepByNumber(guint16, guint16)
3156 - GetShaElValRepByName(string)
3157 - GetShaElValByNumber(guint16, guint16)
3158 - GetShaElValRepByName(string)
3159 - GetElValRepByNumber(guint16, guint16)
3160 - GetElValRepByName(string)
3161 - GetElValByNumber(guint16, guint16)
3162 - GetElValRepByName(string)
3163 * Doc/requirements.txt added.
3165 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3166 * Test/Makefile building now depends on the one of libgdcm.so
3167 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3168 pixel data) aware which enables finding the address (offset) of
3169 the pixel data of JPEG encoded DICOM files. This leaves only a single
3170 file in the testSuite whose pixel data address (offset) is unknown.
3171 * python/testSuite.py changed accordingly.
3173 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3174 * VC++ has some strong limitations when working with the STL, as stated
3175 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3176 "Also note that some STL containers (map, set, queue, list, deque)
3177 cannot be exported. [...]
3178 Some STL classes contain nested classes. These classes can not
3180 This is caused by a designed limitation that once a template
3181 class is instantiated, it can not be re-instantiated and
3183 Since our usage of map<> is ubiquitous in gdcm, this "designed
3184 limitation" of VC++ is a pitfall.
3185 Hence the Python wrappers of gdcm cannot be incrementally linked
3186 against the c++ dynamic library. The dirty but only workaround is
3187 to forget about incremental link of dynamic libraries and to generate
3188 the Python wrappers library with the inclusions of the underlying C++
3190 The following modifications concern this matter on Win32/VC++:
3191 - wrapping python correct with standalone wrapped dll (don't use separate
3192 dll under windows !!!!)
3193 - python21_d debug mode enabled (ask Frog how to use it :-)
3194 - NO problem with having an STL member of class for example string in C++
3195 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3196 - Python test of dcmlib in Python is ok under windows on a large set
3198 * removed glib references
3199 * typedef's inserted in gdcm.i for correct swig type management
3201 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3202 * python/demo/*.py load.py extracted from test.py. Added explore.py
3203 that only displays required tags and testAll.py that parses all
3204 the files of the testsuite without using unittest.
3205 * python/testSuite.py other additional test on new files added.
3206 * Data/* new test files added accordingly to the testSuite.
3207 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3208 the vr in the file differs from the one of the dictionary.
3210 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3211 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3212 values, but limits itself to values which are below a user specified
3213 size (by default 1024 bytes).
3214 * python/gdcm.i : elements not loaded (because their size is above the
3215 user specified treshold) are exported with their TagKey as key of the
3216 python dictionary. This enables the testsuite to make some checks
3217 on the unloaded elements (since we have their offset and size).
3218 * python/testSuite.py
3219 - now tests for the existence and proper value of the pixel data
3220 - two new examples added.
3221 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3223 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3224 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3225 aware. See the strategy comments in gdcmHeader::FindLength().
3226 * Test/test.cxx now accepts a filename as first argument.
3227 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3228 * python/testSuite.py changed to integrate test on above files.
3230 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3231 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3232 the vr was also RET.
3233 * python/testSuite.py more tests added.
3235 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3236 * python/testSuite.py unittest test suite added (uses Data)
3237 * Data/* dcm and acr files for the test suite.
3238 * glib dependance removed from un*x version. We now use ISO C99
3239 7.18 Integer types (see stdint.h)
3240 - python/Makefile, src/Makefile src/gdcm.h
3241 * src/ when an explicit vr (like dicom files) suddenly poped an
3242 implicit element we use to mark the underlying DictEntry of the
3243 concerned ElValue with "Implicit". This strategy was damageable
3244 too the public or provite dictionaries, since some of their vr
3245 would be changed. Since Header::FindLength heavily relies on the
3246 detection by Header::FindVR of falsely explicit elements, I
3247 added an extra ImplicitVr member to ElValue (boolean).
3248 The rest of the changes we the necessary adaptations.
3250 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3251 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3253 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3255 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3256 * Adaptation for porting to VC++:
3258 o forced to use std namespace (for string to be known)
3259 o all class use __declspec export style on WIN32
3260 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3261 (in stdlib.h on Win32 but in std:: for gcc)
3262 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3263 variable GDCM_DICT_PATH.
3264 * src/gdcmHeader.cxx verbose comments made discrete.
3266 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3267 * python/gdcm.i: added a typemap that converts a C++ hashing table
3268 to native Python dictionary.
3269 * python/demo/test.py:
3270 - now uses the native dictionary for exploration of gdcmHeader.
3271 - takes an optional filename argument (the file to parse).
3272 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3273 PubElVals hashing table.
3274 * Dicts/dicomV3.dic removed error prone trailing spaces.
3276 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3277 * Python wrapping process moved away from src/Makefile to
3278 newly created python/Makefile (as well as gdcm.i)
3279 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3280 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3281 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3282 from the environement variable GDCM_DICT_PATH (when existing).
3283 * src/gdcmDict::GetTag bug fix.
3285 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3286 * Straightforward temporary fixes for swig to build the python wrappers.
3287 src/Makefile now has a python working entry [by working we mean
3288 that we can import the shadow classes without errors].
3290 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3291 * hashtest.cxx removed (since already in Test)
3292 * src/gdcmlib.h renamed to src/gdcm.h
3293 * src/dcm.i renamed to src/gdcm.i
3294 * src/Makefile prepared for python wrapping
3296 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3297 * src/gdcmHeader.cxx :
3298 - Parsing of header is now separated from loading of element values
3299 (see gdcmHeader::LoadElements).
3300 - general clean up of hopefully all file access (creation of
3301 ReadInt16 and ReadInt32)
3303 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3304 * src/gdcmHeader.cxx :
3305 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3307 - SetLgrElem renamed to SetLength
3308 - GetLgrElem renamed to GetLength
3309 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3310 * src/gdcmElValSet.cxx fixed both GetElValue methods
3311 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3312 due to IdoDude was cleaned out.
3314 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3315 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3316 concentrates on finding the value representation (when it exists).
3317 RecupLgr now only finds the element value length, and it avoids
3318 returning the unecessary skL (skipped length).
3319 Also, offsetCourant was simply removed (with taille_fich) since
3320 it was redundant with the File position internals (by using
3321 ftell and fseek). This also made skL (see above in RecupLgr) usage
3323 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3324 on the libido specificities which are handled through class
3326 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3329 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3330 * Truckload of changes. Parsing of header is barely functional
3331 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3333 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3334 * src/gdcmHeader.cxx many addons of low level methods
3336 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3337 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3338 and _IdDcmSWAP_LONG.
3340 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3341 * This corresponds to all the changes decided at the meeting of
3342 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob