1 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Now, python test might work on systems
4 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
5 * FIX : First entry following group 0002 was lost for
6 Explicit Big Endian Transfer Syntax files
7 (group and elem not swaped)
9 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
10 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
11 Big Endian Transfer Syntax supposed the group following 0002
12 begins always by element 0000 (element 0000 is *optional*)
13 To avoid further troubles, let's be pessimistic, and use
14 Document::HandleOutOfGroup0002() method
15 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
16 (related pb not yet solved)
18 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * Bug fix for the python part use
20 * Now, PrintHeader.py pass... but outside the ctest use. shit !
22 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
25 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
26 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
27 a string and should ask the global TS dict what are the propreties of
30 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
31 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
32 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
33 to swap the Swap Code, at parsing time, when we come out of group 0002
34 and Transfer Syntax is Big Endian
35 We should be able to read now 'true DICOM" Big Endian coded images
36 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
37 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
39 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
40 * Hopefully fix the bug on MacOSX and static global initialization.
41 This is the only -minor- patch I found that both please MacOSX and VS6.
42 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
43 but this would require a lot of change. Another approach would be that Global
44 create those string and GDCM_UNFOUND becomes a pointer to a string (which
45 gdcm::Global would destroy at exit).
47 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
48 * Fix bug on MacOSX with static initialization in a multy threaded
49 environment. static const string in a header file used to be ill
50 initialized provoquing the freeze of any tests. patch should solve this
53 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
54 * According to Benoit's suggestion, and without any objection from anybody
55 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
56 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
57 - method gdcmDicomDirObject::GetEntry() renamed as
58 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
60 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
61 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
62 you debug/warning message just as c++ streams which make them very convinient
63 to use. Once this is stabilize I will change the ostringstrem to be
64 redirected to a file (ofstream).
65 * Properly support C99 extension: __FUNCTION__ which allow us to display
66 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
68 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
69 * Removal of useless and dangerous methods :
70 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
71 GetDocEntryByName, GetEntryByName, GetDictEntryByName
72 * Removal of usless methods :
73 Dict::PrintByName, Dict::GetDictEntryByName
74 * Commenting out of probabely useless methods :
75 Dict::GetDictEntryNames()
76 Dict::GetDictEntryNamesByCategory()
77 DictSet::GetPubDictEntryNames()
78 DictSet::GetPubDictEntryNamesByCategory()
79 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
80 * ENH : Use dicomTS.dic as described in 2004 version
81 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
82 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
83 Add Accessors on VM (Value Multiplicity), and VM related methods
84 * ADD : Add a list of 'Dicom Attribute types', as found in
85 http://medical.nema.org/dicom/2004/04_15PU.PDF
87 * ADD : Add dicomGroupNameAbbreviations.dic
88 should be used to write a method to replace the former
89 Dict::GetDictEntryNamesByCategory()
91 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
93 to read in the file... and only it ! Length is the efective length of the
94 data in the DocEntry structure
96 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
97 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
98 And now use a static function call instead, with a global variable. i
99 This is much closer to the VTK approach. Hopefully should be bulletproof
100 and easier to use...hopefully
102 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
103 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
105 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
108 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
110 ValEntry, BinEntry, SeqEntry creation or replace
112 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
114 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
116 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
117 when specifying the VR
118 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
119 * src/gdcmDocEntry.cxx : amelioration of print
121 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
122 * ADD : Add the method Util::IsCurrentProcessorBigEndian
123 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
124 * ADD Method Document::ComputeGroupLength
125 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
126 in order to allow further VR modification by user
127 * REM : removal of once-called method File::WriteBase
128 integration of its code in formerly one-line method File::Write
130 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
132 replace the different values "??", "Unkn", "Unknown".
133 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
134 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
135 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
136 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
138 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
139 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
141 * Set the gdcm::Base class to some Printable classes
143 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * src/gdcmFile.[h|cxx] : add the Print method
145 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
146 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
147 * src/gdcmDocument.h : remove the PrintLevel informations
148 * Example/PrintFile.cxx : use the new gdcm::File::Print
150 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
152 problems when compiling with the python wrapping
154 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
156 writting in ImplicitVR
158 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
159 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
160 JPEG decompression, especially when dicom frames are split into several
161 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
162 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
164 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * src/gdcmHeader.cxx : change the initialisation of default header.
166 Now, this header is readable by gdm, e-film, DicomWorks
168 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
170 Rename Decompressed to Raw
171 * Use the API changes in gdcm::File.
172 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
175 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
177 each added entry in the header. Replace the 'Planes' field by the 'Number
180 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
182 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
184 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
185 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
186 At this time, this image isn't readable by e-film... waiting JPR help to
189 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
191 DocEntry. Now use methods of the Document !
193 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
194 * Test/ShowDicomSeq.cxx : bug fix
196 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
197 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
198 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
199 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
200 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
202 * Test/TestCopyRescaleDicom.cxx : remove unused variable
203 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
204 containing found sequences
206 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
207 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
209 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
210 Some fields in BinEntry must be copied to not seg fault when making the :
211 gdcm::File *copy = new gdcm::File( copyH );
212 and tests are now made on good variables
214 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
215 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
216 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
218 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
219 * Add vtkGdcmWriter example and test
221 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
222 * Test/TestUtil.cxx : reformat the source code
223 * vtk/vtkGdcmReader.cxx : remove and change prints
224 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
226 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
227 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
229 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
231 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
233 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
234 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
235 by an eof to prevent all bad read of the file... and in this case, the
238 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
239 * Example/Volume2Dicom.cxx : comment unused variables
240 * Test/PrintDicomDir.cxx : comment unused variables
241 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
242 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
243 method that is redondant with AddEntry.
244 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
247 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * Bug fix due my last commit (compilation under Windows).
249 * Example/Volume2Dicom : bug fix in the file and reformatting source code
250 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
252 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
254 - Remove printf / sprintf
255 - include iostream AFTER gdcm so we don't get warnings
256 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
258 - Also remove tons of include from header files, hopefully this should
259 speeup the compilation time, since it was becoming a dog slow.
260 - Remove gdcm.h as it include way too many files and slow down compilation
261 (plus it is not up to date)
262 - remove 'using namespace std' this is BAD !
264 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
265 * Remove memory leaks on the DicomDir
266 * Remove some useless data in DicomDirObject
267 * Add usefull methods in SQItem, to be complient withe the ElementSet
269 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
272 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
273 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
274 future, with convertion)
275 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
276 and ImageDataSize values. Remove the method to get the PixelReadConverter
277 from the output of the class
279 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
280 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
282 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
283 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
284 and vtkErrorMacro use.
285 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
287 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
290 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
291 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
292 The string leaves only in the fonction. So when we make a .c_str(), we
293 get the pointeur on the first element, element that will be destroyed
294 immediately after thee instruction.
295 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
296 file has been opened : the test must be made on the content of the
297 pointer and not directly on the pointer !
300 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
301 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
302 the python part recompiles
304 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
306 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
307 X session is killed (for my computer... it seems to not be identic on
310 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
312 avoid problems (otherwise, the difference test between the visible image
313 and the reference is incorrect. If the reference is greater than the
314 screen resolution, it's produce errors).
315 Can be used for only one image. Can be used with a visible flag.
316 * vtk/vtkGdcmReader.cxx : remove commented codes.
317 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
318 under windows at compilation
319 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
321 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
323 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
324 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
325 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
326 tests on the image size X, Y, Z
328 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
329 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
330 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
331 between the class name and the file name
333 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
334 * src/ : fix compilation warnings for the Write method (2 different
335 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
336 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
337 variable... create a static method in gdcm::Document to access to
338 this variable content.
340 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
341 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
342 file, to be accessed by other files (like gdcmFile). Remove commented
343 code. Move the change of the header to the gdcmFile, using the
345 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
346 To be sure of that (and simplify calls), the Write of the header now
347 gets a file name and not a file pointer (std::ifstream).
348 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
349 DocEntryArchive. Remove all open of the written file
351 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
352 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
354 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
355 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
356 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
358 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
359 some corresponding methods. Write correctly the file and check before
361 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
362 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
363 is now on RGB data (as before my last commit
364 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
366 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
367 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
368 Add a print information of the type of the entry
369 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
370 It was in the gdcmFile, and all write have been regrouped
371 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
372 Write correctly all dicom files (in decompressed mode only at this time)
373 * Test/ : test on files are now made using Raw data and not color data if
375 * Example/PrintFile.cxx : add more printings
377 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
378 * Amelioration of code, remove some code copy. For the loading of
379 BinEntry (in gdcmDocument), add the test to verify if the file is already
382 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
383 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
384 remove a DocEntry in the header (push an empty DocEntry)
385 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
386 lines. Bug fix in the initialization of the PixelConvert and the
388 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
389 use in TestCopyDicom (now this test can run under windows... but fails)
390 * Test/TestCopyDicom.cxx : amelioration of the test :
391 - test the pixels written
392 - add test points to quickly find where is the error
393 - can set a file name input and output in arguments
394 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
395 amelioration of the test output
397 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
398 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
399 all replaced DocEntry's
400 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
401 Now, each needed DocEntry to modify is duplicated, modified and inserted
402 to the header using DocEntryArchive. Thus, after save, we can restore the
403 header initial state.
405 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
406 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
408 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
410 correct to copy it. The DictEntry is specified at the DocEntry creation,
411 then, it musn't change in the time.
412 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
413 header correctly. At this time, the change is only made for the first
414 level of the Document. In the future, it might consider sequences.
415 The change is made by replacing a DocEntry by an other that is created
416 outside the class. The old value is kept. When we restore the header
417 status, the added DocEntry is deleted and replaced by the old value.
418 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
419 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
420 set the write type to explicit VR, implicit VR or ACR. Add methods to set
421 the write mode to native, decompressed or RGB (but not used at this time)
423 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
424 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
425 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
427 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
428 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
429 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
431 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
432 set because already copied when copying the BinEntry's of the header
433 * Test/TestAllReadCompareDicom.cxx : remove warnings
435 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
436 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
437 Two problems appear when doing it :
438 - with the gdcmFile : when the GetImageData method is called, the pixels
439 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
440 data (pixels). And each structure destruct the data when it's
441 destructed. So we have two destructions for the same data. To solve it,
442 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
443 data or not. If it doesn't own data, then they will not destroyed by
445 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
446 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
447 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
448 create a double destruction of the same DocEntry's. So, to solve it,
449 the TagHT is simply cleared and the DicomDir* elements are destroyed.
450 * TODO : add an entry concerning memory leaks in the DicomDir
452 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
453 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
454 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
457 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
458 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
459 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
460 after it have been deleted
462 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
463 * FIX: src/* fix the doxygen warnings.
464 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
465 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
466 was erroneously defined with a size of 15 instead of 16. [many thanks
467 to Jean Michel Rouet for pointing out this bug].
469 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
470 1. Finish merging JMR patch for writting DICOM from scratch
471 2. Fix -hopefully- bug with MONOCHROME and space vs null character
472 3. Use const ref when possible
473 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
474 5. A few more comments
475 6. CreateUniqueUID can now be called without parameter"
477 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
478 * ENH: Slightly bigger patch:
479 1. Getting toward full integration of JMR patch for writting dicom from scratch
480 2. Update Test to test part of this patch: CreateUniqueUID
481 3. File was not close properly in gdcmDict
482 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
483 5. Use of const ref instead of copy (speed issue)
484 6. Remove temporary (duplicate) string in TranslateToKey
485 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
486 8. Do not repeat virtual in subclasses
487 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
489 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
490 * Apply first patch toward better string comparison when dealing with broken
491 DICOM files. Essentially the string could be padded with a space instead
492 of a null character as defined by standard
494 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
495 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
496 because never used... and in the same time, that's remove some memory leaks
498 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * src/gdcmFile.cxx : now delete the PixelConvert instance.
500 * In examples and tests : change the type of image data variables from void*
501 to uint8_t*. Remmove all delete on image data variables
503 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
504 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
505 Verify the file pointer value before open the file, and if it's not null,
506 a verbose message is generated.
507 Close correctly the file when the file isn't considered dicom-like. The
508 correctly close is a call to CloseFile.
509 When closing the file pointer, test if its not null to close the file.
510 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
511 file. For an uncompressed image, the copied data correspond in the least
512 case to the image size (calculated) or the image size specified in the
513 header. A verbose is generated if these two size mismatch
515 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
516 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
517 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
518 break under windows (with msvc6 compilation).
520 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
522 compiling with MSVC6)
524 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
525 * Bugs fix for the Windows build with VC6
526 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
527 needed (only for projects required VTK). If the VTK is included in all
528 projects, there is conflicts with the jpeg lib of vtk when compiling the
529 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
530 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
531 when compiling the gdcm_wrap.cxx file (created by the compilation of the
533 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
534 (like it's already made for the cout use). Otherwise, conflict with the
537 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
538 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
540 - comments on the DicomDir::Method related usage added.
541 - now that we use the namespace gdcm, a lot of internal classes do
542 NOT need to be wrapped anymore.
543 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
544 DicomDir::Method) new example added.
546 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
547 * Improve string manipulation. I now inforce the notion of 'DicomString'
548 A DicomString can contain as many \0 as they want
549 and it is *always* of even length.
550 We only support odd length for very rare case.
551 And in the near future this should be removed.
553 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
554 * /binary_write/ gdcm source. Now even on big endian we are writting
555 little endian. This should -heopfully- fix some tests
557 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
558 * Now the dictionary is compiled into gdcm lib. This is a default
559 behavior, thus any dic file specified is picked before failback to
560 the one comiled into lib
562 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
563 * Change internals for gdcmDict. Don't use any 'new' any more.
564 This should definitely solve any leak problem, and we should be
565 as fast as before, as long as don't modify too much the dictionary.
567 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
568 * STYLE: ivars should start with a capital letter.
569 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
570 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
572 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
573 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
574 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
575 new 2004 dictionaries added (thanks to JPR).
576 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
577 * CLEANUP_ROUND (15) for gdcmPixelConvert
578 - RLEFrame::NumberFragments is now of type unsigned int
579 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
580 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
583 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
584 * Initial work in gathering all transfer syntax accessors. clearly
585 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
586 ivars, but only one transfersyntax (class) ivar with equivalent method on
589 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
590 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
591 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
592 discussed (plus I didn't like having a 2000 lines patch not commited)
594 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
595 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
596 * CLEANUP_ROUND (14) for gdcmPixelConvert
597 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
598 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
599 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
601 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
602 anymore and hence avoids storing a copy of PixelConvert::Decompressed
603 into File::Pixel_Data.
605 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
606 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
607 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
608 * CLEANUP_ROUND (13) for gdcmPixelConvert
609 Substituted File::ParsePixelData() with PixelConvert::Print() new
611 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
612 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
613 method to those classes.
614 - src/gdcmFile.[cxx|h]:
615 -- Added a ::Print() method.
616 -- PixelConverter is now a reference instead of a member.
617 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
618 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
620 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
621 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
622 collaboration diagram and inheritance diagram should be generated with
624 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
625 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
626 pointlessly wrapped (see
627 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
628 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
629 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
630 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
631 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
632 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
633 -- File::Initialise: PixelConverter setup moved away to
634 PixelConverter::GrabInformationsFromHeader()
635 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
636 interpretation moved away to PixelConverter::BuildRGBImage()
638 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
639 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
640 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
642 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
643 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
644 displayed on Win32 when a brutal abort() occurs (because of uncatched
645 exception). See TODO new entry of this commit for more on this.
646 * TODO added new entry.
647 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
648 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
649 - HandleColor is no longer called from gdcmFile.cxx
650 - gdcmPixelConvert.cxx clean up on method arguments and internal
651 variable names for semantical coherence.
653 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
654 * Finished lossless transition, not only do we now read all lossless jpeg
655 images, without the need of the Cornwell lib, but we do read them properly now
656 * To reduce code (well to avoid code duplication), I defined a common place
657 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
658 redefine symbols. This is not perfect but this the best solution I found for a
659 compilation time jpeg option.
661 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
662 * Update jpeg ijg lib to support lossless jpeg implementation
663 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
665 * Also added a special copyright for dcmtk since we use their bugfixes.
668 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
669 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
670 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
671 matters, as stated in warning note at begining of %include section).
672 * src/gdcmDicomDir*.[cxx|h]: coding style
673 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
674 * src/gdcmJpeg8.cxx: doxygen fix.
675 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
676 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
677 from File:: to PixelConvert::.
679 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
680 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
681 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
682 - more code moved away from File:: to PixelConvert::
683 - fat setup of PixelConverter set in place in File::Initialise.
685 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
686 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
687 namespace at the file system level. So now you should convert your examples
689 gdcmHeader -> gdcm::Header
690 It would be nice if people keep in mind to no open the namespace, since it
691 allows compilation on broken plateform which were defining common symbol in
692 the standart namespace (like LP, Unknown ...)
694 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
695 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
696 The JPEG fragments are now parsed at the same stage than the RLE
697 information. All code related to JPEG is now in gdcmPixelConvert:
698 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
699 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
700 export a gdcmFile:: method. Those are simply global functions
701 (for the time being this is better than having them attach to
702 either gdcmFile:: or gdcmPixelConvert::).
703 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
704 and stores the result in a gdcmJPEGFragmentsInfo.
705 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
706 code (among other stuff) moved away from gdcmFile:; to
709 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
710 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
711 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
712 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
713 clean up of RLE related code.
714 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
715 - src/gdcmRLE.cxx removed
716 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
717 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
718 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
719 * CLEANUP_ROUND (9) for gdcmPixelConvert
720 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
721 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
722 away from gdcmFile:: to gdcmPixelConvert::.
724 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
725 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
726 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
727 This is because Parse7Fe0 used to parse the pixels to compute the
728 length. This task was passed over to FindDocEntryLengthOB() a long
729 time ago, EXCEPT I had forgotten the OW case...
730 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
731 we just recylce the code for parsing RLE fragments and computing
733 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
734 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
735 with the retired Parse7Fe0().
736 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
737 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
739 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
740 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
741 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
742 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
743 - src/CMakeLists.txt: alphabetic order reodering + new entries.
744 * CLEANUP_ROUND (4) for gdcmPixelConvert
745 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
746 to return an unused length.
748 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
749 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
750 this should be cleanner from the plane view. The iostream are erally a pain
751 to use to do simple stuff.
753 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
754 * Redo the compilation of the ijg jpeg library. Now only one source is
755 necesseray. No need to rename file by hand what so ever. CMake handle the
756 copying of the file within different directory, configure header file to
757 modify some symbol. The only addition made to ijg wasd a mangle table so
758 that symbol are different wether we are within 8bits or 12bits.
760 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
761 * Added documentation of vtkgdcmReader on Website:
762 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
763 with it's binary name).
764 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
765 the Website to be more complete.
766 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
767 doxygenated documentation.
768 - Doc/DoxyVtkGdcmReaderExamples.txt added
769 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
770 DoxyVtkGdmReaderExamples.html )
771 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
772 * CLEANUP_ROUND (3) for gdcmPixelConvert
773 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
775 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
776 * CLEANUP_ROUND (2) for gdcmPixelConvert
777 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
779 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
780 * CLEANUP_ROUND for gdcmPixelConvert:
781 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
782 - src/gdcmPixelStuff[h|cxx] removed
783 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
784 - src/CMakeLists.txt changed accordingly
786 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
787 gdcmVersion.py moved to newly created ATTIC related
788 gdcmPython/SetupOldies/ directory.
789 * Autotools clean up:
790 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
791 - autogen.sh configure.in acinclude.m4 python.m4 removed
793 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
794 * src/*.cxx *.h Reference to License.htm fixed to License.html.
795 * Doc/CMakeLists.txt, doxygen.config.in: fix.
796 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
798 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
799 * TODO updated with Mathieu suggestions. I proposed a template for
800 describing TODO entries and used it for new entries.
801 * Added Doc/Website/CodingStyle.html, Developpers.html,
802 DeveloppersPython.html, GdcmDataCvs.html and
803 DownloadVersion0_1.html, DownloadVersion0_3.html.
804 * Some Doc/*.txt Doxygen files (which do not really concern the
805 documentation itself, but the website) moved to html and
806 placed in directory Doc/Website:
807 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
808 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
809 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
810 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
811 * CMakeLists.txt changed accordingly.
812 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
813 DeveloppersPython.html
814 * INSTALL nows refers to Doc/Website/Installation.html
816 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
817 * Added Doc/Website directory, that contains a first raw version
820 2004-09-23 Jean-Pierre Roux
821 * FIX In order not to be poluted any longer by casting problems,
822 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
823 we can now delete[] it safely
824 * VoidArea is now called BinArea (less confusing name),
825 and all the methods called ...VoidArea... are now ... BinArea...
826 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
828 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
829 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
830 clear) TagHT, which is an inherited member of gdcmElementSet. It is
831 up to the destructor of gdcmElementSet to clean up TagHt and it's
834 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
835 * Test/CMakeLists.txt: update to follow gdcmData renamings.
836 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
838 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
839 * ENH: added some utility method that builds a flat dictionnary
840 holding all the Dicom entries contained in the recursive structure
841 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
843 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
844 BuildFlatHashTable() that build a flat dictionary.
845 - src/gdcmElementSet.h: added a new private GetTag() accessor.
846 gdcmDocument is now a friend of gdcmElementSet.
847 - src/gdcmElementSet.cxx: clean up.
848 - Example/FlatHashTablePrint.cxx added.
849 - Example/CmakeLists.txt changed accordingly
851 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
852 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
853 moved away from gdcmDocEntrySet (since this class is an abstract class
854 acting like an interface). SQDepthLevel and BaseTagKey are now
856 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
857 and associated accessors. Doxygenation of the class.
858 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
860 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
861 Use SQDepthLevel accessor instead. ::Print() adapted.
862 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
863 - src/gdcmDocument.cxx changed accordingly.
865 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
866 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
867 - The following is the doxygen comment of the typedef declaration
868 of gdcmTagKey in src/gdcmCommon.h:
869 gdcmTagKey is made to old an "universal" (as in URL, Universal
870 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
871 A dicom tag always has a group and an element, but a set of tags
872 embeded in various (optionally nested) sequences and sharing
873 the same group and element all share the same (group, element)
874 "identifier". Hence the (group, element) cannot be used as an
875 identifier (in gdcm we shall refer to a "TagKey") of a tag.
876 In order to construct a proper tag identifier (i.e. a key) we
877 consider the following definition of a TagKey:
878 - let Group, Element be the string representation of the
879 group and element dicom tag members,
880 - let ItemNumber be the string representation of the integer
881 index of the considered item number of a sequence,
882 Let the key of a tag embeded in a sequence, noted SeqTag, be
884 /ItemNumber#Group|Element
885 where "/", "#" and "|" are characters acting as separators.
886 Then the general form of a gdcmTagKey is given by:
887 Group|Element<SeqTag>
888 where <SeqTag> means NO or many instances of SeqTag.
889 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
892 but the gdcmTagKey of a tag "embeded" is the first item of
893 a sequence, itself nested in the third item of a sequence is the
895 0004|1220/2#0008|0082/0#0008|0090
896 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
897 order to hold the new sequence compatible key. Previously, the
898 GetKey() method would look in the underlying gdcmDictEntry.
899 - src/gdcmDocEntry.cxx:
900 -- constructor now copies the underlying DictEntry key, in the local
902 -- ::Print: displays the member Key, instead of the (group, element).
903 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
904 - src/gdcmDocEntrySet.h:xi
905 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
906 -- now has a new BaseTagKey member.
908 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
909 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
911 This poses the problem with the semantics of the following lines
912 LoadEntryVoidArea(0x0028,0x1201); // R LUT
913 LoadEntryVoidArea(0x0028,0x1202); // G LUT
914 LoadEntryVoidArea(0x0028,0x1203); // B LUT
915 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
916 to the long FIXME note for what the problem is. Nevertheless in
917 order to get things working the dicom dictionary was altered !
918 Please fix things urgently...
919 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
920 information), see above note on moving the member VoidArea. Nevertheless
921 the following entries previously correctly set as US are now inproperly
923 0028 1201 OW IMG Red Palette Color Lookup Table Data
924 0028 1202 OW IMG Green Palette Color Lookup Table Data
925 0028 1203 OW IMG Blue Palette Color Lookup Table Data
926 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
927 of gdcmDocEntry moved to gdcmSeqEntry.
928 * src/gdcmSeqEntry.cxx: STYLE.
930 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
931 * Test/TestAllEntryVerify.cxx minor fix and added comments.
933 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
934 * gdcmPython/testSuite.py: all the test suite in python is now moved
935 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
936 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
937 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
939 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
940 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
941 to avoid inclusion recursion until STL is reached.
942 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
943 mecanism. errno.h is not included in gdcm anymore.
944 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
945 (gdcmFormatError now inherits from gdcmFormatUnexpected).
947 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
948 gdcmData/TestAllEntryVerifyReference.txt
949 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
950 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
951 exception_on_error parameter.
952 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
953 - vtk/vtkGdcmReader.cxx changed accordingly,
954 - Example/*.cxx and Test/*.cxx changed accordingly.
956 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
957 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
958 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
959 enable_sequences removed from gdcmHeader constructor and dependencies.
960 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
961 * gdcmPython/demo/PrintHeader.py: dummy fix.
962 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
963 skip_shadow removed from gdcmHeader constructor and dependencies.
964 * Example/*.cxx and Test/*.cxx changed accordingly.
966 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
967 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
968 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
970 2004-07-21 Jean-Pierre Roux
971 * FIX Now, Parsing and Printing a DICOMDIR do work!
972 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
974 2004-07-20 Jean-Pierre Roux
975 * FIX Some brain damaged headers have Zero-Lenght fields
976 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
978 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
979 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
980 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
981 variable (instance of gdcmDebug) by a definition macro, and the instance
982 is now in static in the gdcmDebug class
983 * src/gdcmSQItem.h : (FIXME) remove an undefined method
984 * Test/PrintAllDocument.cxx : bug fix in the result of the test
986 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
987 * WARNING: ctest now depends more tightly on gdcmData. You should
988 check out gdcmData properly for things to run smoothly...
989 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
990 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
991 we need the pixels not be loaded in order to use the ValEntry
992 that displays position and size).
993 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
994 This is a C++ based equivalent of gdcmPython/testSuite.py that should
995 be deprecated. If you have any doubts about the advantages of a
996 modern scripting language (read Python) versus grass root C++ (i.e.
997 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
998 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
999 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1000 Anyhow, consider documenting the gdcmData images in
1001 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1003 * Test/CMakeLists.txt:
1004 - now uses TestAllEntryVerify.cxx
1005 - specific comments on oldACR00001.ima (now renamed in gdcmData
1006 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1007 gdcmData/TestAllEntryVerifyReference.txt
1010 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1011 * src/*.[h|cxx] : typedef clean up
1012 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1013 - TagKey renamed to gdcmTagKey (for external usage)
1014 - VRKey renamed to gdcmVRKey (for external usage)
1015 - removal of typedef duplication.
1016 - Removed all unecessary inline keyword from class inline definitions.
1017 - Some method|function(void) declarations replaced with method|function().
1018 * src/jpeg/libijg12/jdhuff12.c:
1019 - printf polluting ctest removed.
1020 - TAB removal for comminting
1022 - TestAllReadCompareDicom.cxx: added a test that compares all the
1023 images in gdcmDataImages.h with corresponding images in
1024 gdcmData/BaselineDicom/. When baseline images are not present
1025 this test creates them.
1026 Note: we need to validate each reference image, but before that
1027 I'd like to rename them with a more explicit name...
1028 - CMakeLists.txt: changed accordingly.
1029 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1030 including each header needed).
1032 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1033 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1034 test suite to the Example directory. Are concerned:
1039 - TestWriteSimple.cxx
1040 * Test/CMakeLists.txt: added some comments on reasons for black listing
1041 image gdcmData/oldACR00001.ima
1043 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1044 * Test/CmakeList.txt: removed the following from black list (to be coherent
1045 with removal from gdcmData):
1046 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1047 - gdcm-MR-PHILIPS-16.dcm
1049 Added the following because after last cvs update, they cause
1050 ctest -R TestReadWriteReadCompare
1052 - gdcm-MR-SIEMENS-16-1.acr
1054 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1055 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1056 new comments in this file) we temporarily (sigh) move to a weaker
1058 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1059 we don't need to black list the following images anymore:
1060 - 8BitsUncompressedColor.dcm
1062 - US-PAL-8-10x-echo.dcm
1063 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1064 fixes and the beautified code ;-)
1065 This fixes the bug introduced in version 1.42 (when beautifying)
1066 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1067 Note: ctest was blind to this bug (this means we need to still
1068 improve the test suite). The bug could be detected by using
1069 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1071 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1072 and by displaying the (garbage) produced file temp.XDCM...
1074 2004-06-29 Jean-Pierre Roux
1075 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1076 - replace by uggly but working old code :-(
1077 A lot of things should be OK again.
1078 It's really urgent to have a test suite that *tests*,
1079 to prevent Frog's beautifying sessions to break all the stuff
1080 (twice, withing a fortnigh ...)
1082 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1083 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1084 redundancy) to added Test/TestReadWriteReadCompare.cxx
1085 * Test/CmakeList.txt: because the compare test of
1086 Test/TestReadWriteReadCompare.cxx fails, the following images are
1087 black listed: - 8BitsUncompressedColor.dcm
1089 - US-PAL-8-10x-echo.dcm
1090 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1091 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1092 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1093 and ad-hoc kludge. This kludge is now removed, and on encountering
1094 such an image (OB field brain damaged) we set errno. Then in
1095 ::FindDocLength() we "fix" the length as being ALL what remains
1096 in the file (until EOF). We then proceed, hoping for the best...
1097 This fixes a SegFault in ShowDicom when trying to write such an
1099 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1100 (because TestWriteRead breaks on it, after a non conformal commit?).
1101 ctest now runs properly, except for MakeDicomDir (which was always
1102 broken) and the Python related stuff (still not fixed).
1104 2004-06-24 Jean-Pierre Roux
1105 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1106 FIX : Test/TestReadWrite now iterates on all the file names
1107 (instead of infinite loop)
1108 ENH : Test/TestWriteRead now iterates on all the file names
1110 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1111 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1113 2004-06-24 Jean-Pierre Roux
1114 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1115 when SamplesPerPixel =3
1116 - now Write is no longer confused by
1117 'BitsAllocated = 12" and 'BitsStored=12"
1118 - "UN" value representation Elements are now written correctly
1119 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1120 ENH : - now gdcmHeader has its own Write methods
1121 (in order to split the job that has not to be done
1124 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1125 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1126 loop on the same image until memory went out.
1127 Note: this means we still have gobs of memory loss in PrintDocument
1128 * src/gdcmDocument.cxx: fixes problem on parsing on file
1129 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1131 2004-06-24 Jean-Pierre Roux
1132 FIX : Write - All the Sequences and Sequence Item are now written
1133 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1134 is added a the end, when necessary.
1135 - A lot of brain-damaged images, that were read correctly are
1136 now written correctly
1137 - length compatible BinEntry are now loaded correctly
1138 (even for odd groups)
1139 Note : only Explicit Value Representation was checked.
1140 (question : is implicit VR really necessary for gdcm ?)
1142 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1143 * DEVELOPPER: added a proposition of coding style.
1144 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1147 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1148 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1149 Use the gdcmDocEntry::Print() and Write() instead.
1150 * src/gdcmDocument.cxx: bug fix.
1152 2004-06-22 Jean-Pierre Roux
1153 FIX : gdcmDocument.cxx
1154 - Now we do recognize the JpegLossLess format (there was a misstyping in
1155 code 'beautyfication' :-(
1156 - Now we automaticaticaly load the Luts, if any
1158 2004-06-22 Jean-Pierre Roux
1159 In order : to write Sequences, whatever their imbrication level,
1160 : to allow user to create his own Sequences
1161 a lot of modif where necessary (adding, moving, or virtualising methods)
1163 WARNING : save your own sources *before* cvs up !
1166 ADD virtual void Write(FILE *fp, FileType filetype);
1169 ADD virtual void Write(FILE *fp, FileType filetype);
1170 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1173 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1174 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1175 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1176 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1177 ADD std::string GetEntryByName(TagName name);
1178 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1180 std::string vr = "unkn",
1181 std::string fourth = "unkn",
1182 std::string name = "unkn");
1183 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1184 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1185 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1186 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1187 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1188 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1189 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1190 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1193 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1194 ADD virtual std::string GetEntryByName (TagName tagName);
1195 ADD virtual std::string GetEntryVRByName (TagName tagName);
1196 REM virtual bool Write(FILE *, FileType);
1197 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1198 FILE *_fp, FileType type);
1199 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1200 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1201 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1202 REM virtual std::string GetEntryByName (std::string tagName);
1203 REM virtual std::string GetEntryVRByName (std::string tagName);
1204 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1205 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1206 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1208 std::string vr = "unkn",
1209 std::string fourth = "unkn",
1210 std::string name = "unkn");
1211 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1212 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1213 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1214 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1217 ADD virtual void Write(FILE *fp, FileType filetype);
1220 ADD virtual void Write(FILE *fp,FileType filetype);
1223 ADD virtual void Write(FILE *fp, FileType filetype);
1224 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1225 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1226 REM std::string GetEntryByName(TagName name);
1229 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1231 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1232 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1233 The default constructor invoked by the line
1234 gdcmHeader *f1 = new gdcmHeader( header );
1235 was gdcmHeader::gdcmHeader(bool) instead of the expected
1236 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1237 Hence the parsing wasn't executed... See also below.
1238 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1239 as explicit constructor didn't do the trick to fix the above problem.
1240 Could anyone explain why ?
1241 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1242 properly calls gdcmValEntry::Print() (that was weed out from
1243 code related to gdcmBinEntry).
1245 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1246 * In order to fix memory leaks:
1247 - Test/TestWriteSimple.cxx: added cleaning of free store through
1249 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1250 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1251 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1252 (through the call to ::AddDicomDirMeta()) or the destructor
1253 would crash when deleting uninitialized ::metaElems].
1254 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1255 - src/gdcmDocument.cxx:
1256 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1257 from dynamic stores.
1258 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1259 was causing memory leaks.
1260 - src/gdcmSQItem.cxx:
1261 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1262 cleanly handled with polymophism: sorry but my milage is low).
1263 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1264 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1265 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1266 This avoids SegFaulting.
1267 - src/gdcmSQItem.h: coding style.
1269 - Test/TestWriteSimple still severely sucks. The output image content
1270 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1271 damaged when displayed with vtkgdcmViewer.
1272 - on memory leaks: TestWriteSimple leaks really less (see entry
1273 of 2004-06-18 in Changelog file for the call to valgrind).
1274 - on segfaults: ctest now passes all the tests but one (no more
1276 * Erroneous leading white fix:
1277 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1278 white[s] (as opposed to from >> xxx, that removes it [them].
1279 - src/gdcmTS.cxx: ditto.
1280 - gdcmPython/testSuite.py: dirty related kludge removed.
1281 * src/*: remaining references to gdcmParser removed.
1282 * src/*[cxx|h]: added copy[way]left header.
1285 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1286 * In order to fix writing of dicom files:
1287 - Test/TestWriteSimple.cxx: a simpler example of writing.
1288 - Test/CMakeLists.txt changed accordingly.
1289 - src/gdcmDocument.cxx:
1290 -- The destructor now recursilvely removes potential sequences.
1291 -- Bug fix in ::IsJPEG2000()
1292 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1293 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1295 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1296 to only declared) and build on top of
1297 ::GetDocEntryByNumber(guint16, guint16).
1298 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1299 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1300 for usage in destructor and treatement of promotion in
1301 ::ReplaceOrCreateByNumber().
1302 - src/gdcmSQItem.cxx: destructor should better handle his job.
1303 Test/TestWriteSimple now runs (or at least it DOES something).
1304 * We can now start hutting memory links. A good starting point is:
1305 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1306 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1307 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1309 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1310 * Valgrind note: after Mathieu Malaterre teached me how to read
1311 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1313 Using gcc, you can force the STL to use malloc and to free memory as
1314 soon as possible by globally disabling memory caching.
1315 With 3.2.2 and later, you should export the environment variable
1316 GLIBCPP_FORCE_NEW before running your program.
1317 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1318 simply vanish (it is still not clear to me, whether this means that
1319 STL std::string leaks or if valgrind believes it leaks...).
1320 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1321 running bin/gdcmTests makeDicomDir):
1322 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1323 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1325 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1326 SegFaulting (I drowned in DicomDir related code when trying to
1327 understand why the list is empty...).
1328 * src/gdcmDocument.h: first BSD license header try.
1329 * Doc/License.txt added.
1331 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1332 * src/gdcmDocument.[h|cxx]:
1333 - Clean up of the Transfer related predicates. They are now all based
1334 on new method isGivenTransferSyntax, that (should) handle properly
1335 the padding problem.
1336 - general clean up, simplification, and coding style.
1337 - Specific clean up of Parse7FE0() (umproperly named actually).
1338 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1340 2004-06-14 Jean-Pierre Roux
1342 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1343 - fix the display of SQItem ordinal number
1344 - add the GetSQItemByOrdinalNumber method
1345 - remove some useless never written private methods
1347 2004-06-14 Jean-Pierre Roux
1349 - adding a constructor taking a gdcmDocEntry as an input param
1350 - ReplaceOrCreateByNumber now returns :
1351 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1352 a gdcmValEntry * if a string value is passed as a param
1354 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1355 according to the param type (no longer sets a gdcmDocEntry)
1356 - GetValEntryByNumber, GetBinEntryByNumber added
1357 - NewValEntryByNumber and NewBinEntryByNumber added
1359 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1361 - GetSQItemNumber and SetSQItemNumber added, to provide
1362 a (relative) Item identier inside a given Sequence
1363 \warning : some pb remaining around this number
1365 - AddEntry now takes the Item Number as a param
1367 - adding a constructor taking a gdcmDocEntry as an input param
1369 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1370 * Memory leak hunt with the following command:
1371 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1372 --show-reachable=yes gdcmTests PrintDocument
1373 It looks like many (all?) leaks are due to the STL (or a bad usage
1374 of the STL. The lines producing the leaks now have a comment with
1375 a "MEMORY LEAK" tag: you can retrieve them with
1376 grep "MEMORY LEAK" src/*
1377 Here are two typical examples which I can't help fixing:
1382 char * test = "babo";
1383 name = test; //// <--- valgrind detects 960 bytes lost in
1384 //// call to std::string::operator=(char const*)
1385 name.clear(); //// Doesn't help !
1393 std::cout << "Type a bunch of characters followed by RETURN: ";
1394 getline(std::cin, line); //// <--- valgrind dectects a loss
1395 //// of 1320 bytes in call to
1396 /// std::basic_istream<>& std::getline<>
1402 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1403 * src/gdcmHeader.[cxx|h]:
1404 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1405 and related, moved away to gdcmDocument.
1406 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1407 the corresponding protected accessors of inherited class
1408 gdcmDocument, removed ! As a consequence gdcmFile had to be
1409 declared friend of class gdcmDocument (see below).
1410 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1411 - Clean up of undefined or unused methods.
1412 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1413 account the changes to gdcmHeader.h).
1414 * src/gdcmDocument.h:
1415 - gdcmFile is now a friend class (in order to take into account the
1416 changes to gdcmHeader.h).
1417 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1418 (see changes to gdcmHeader.h).
1419 - Accessors (reading on the form GetEntry*) are now public.
1420 - Clean up of undefined or unused methods.
1421 * src/gdcmDocument.cxx:
1422 - adaptation to changes to gdcmDocument.h
1423 - ::OpenFile now writes a verbose message when file cannot be opened.
1424 - some std::string properly set to VRKey
1425 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1426 references to gdcmDocument.
1427 * Test/TestFindTags.cxx: changed accordingly to above changes.
1428 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1429 cvs repository gdcmData.
1431 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1432 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1433 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1434 conflicts with gdcmValEntry::voidArea.
1435 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1436 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1437 Value representation between StringRepresentable and BinaryRepresentable.
1438 * src/gdcmDocument.cxx:
1439 - method ParseDES: proper indentation restored and usage of
1440 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1441 - method LoadDocEntry: the fingerprint left in the SetValue() of
1442 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1443 removed. Reverting to previous code segment with the proper
1444 dynamic_cast< gdcmValEntry* >.
1445 Note: this was (partially) breaking the python test suite
1446 (gdcmPython/testSuite.py) that made usage of the above
1447 fingerprint to check presence of "Pixel Data".
1448 * src/gdcmDocEntry.h: coding style.
1449 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1450 now taken into account.
1451 * gdcmPython/gdcm.i: adaptation to the new internal representation
1452 of gdcm (exit gdcmParser, hello gdcmDocument).
1453 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1455 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1456 anymore, but instead prints the loaded Python dictionary.
1457 * .... alas, the python testSuite is still broken.
1459 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1460 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1462 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1463 * src/gdcmUtil.h : export methods
1465 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1466 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1468 * Initial addition of automatic python testing
1469 * Initial addition of automatic image comparison
1471 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1472 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1473 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1475 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1476 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1477 * Test/ShowDicom.cxx : bug fix for msvc compilation
1478 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1480 2004-05-04 Jean-Pierre Roux
1481 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1482 new concepts (and new classes) :
1483 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1484 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1485 - Sequence Doc Entries (gdcmSeqEntries)
1486 a Sequence is composed of Items.
1487 Each item is a set of Doc Entries (this is recursive)
1488 The non uniqueness of the 'Dicom tag' is due to this recursivity
1489 (never taken into account)
1490 Our unability to add a new 'entry' in the header
1491 at the proper location (neither in the H-Table (map or multimap),
1492 nor in the Chained List is also due to this recursivity.
1493 Don't try, right now, to use/modify/compile these new sources :
1494 nothing is finished.
1495 We just commit all the stuff, 'as is', in order not to loose it.
1497 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1498 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1500 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1501 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1502 file prefix (SetFilePrefix)
1504 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1505 * Add a new test: ShowDicom, for now this is just the c++ version of
1506 checkRead.sh, later it will be able to compare the image read against a
1508 * Replace the DEBUG on the stack with a global entry in cmake interface:
1509 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1511 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1512 * Add an example subdir, with a real example on how to read + write a
1515 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1516 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1517 * Doc/CMakeLists.txt: the main page is now properly differentiated
1518 between the developper and user version.
1519 * Doc/doxygen.config.in: dropped search related obsolete flags
1520 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1522 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1523 * DEVELOPPER: added some helpfull comments for compile/test/install
1526 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1527 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1528 src directory, now generated in the build dir.
1529 2. Tests as mentionned smarter
1531 4. Add a new method in gdcmDict that return the PubDict by name
1532 this is interesting for 3rd party lib like ITK,
1533 where we could set the institution name / patient name...
1535 * ENH: 1. Now the test suite is working for real
1536 2. All binaries are now output in the gdcm-bin directory
1537 (this was not true before)
1539 2004-04-28 Jean-Pierre Roux
1540 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1541 SeQuence indented printing of Dicom Header.
1542 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1543 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1544 Computation of SQDepthLevel is now part of gdcmHeader constructor
1545 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1546 tree-like structure of a Dicom Header.
1547 * FIX Test code cleaning
1549 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1550 * ENH: Adding automatic testing
1551 1. Need a DartConfig.cmake to submit to public
1552 2. Add a test driver gdcmTest.cxx
1553 3. gdcmTestMain, an helper for the main test driver gdcmTest
1554 4. Files in Test don't have a main anymore, this becomes interesting
1555 when we add more and more tests, thus dsw don't have to load
1557 * ENH: Adding a GDCM_DATA_ROOT for testing
1558 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1559 one file instead of seven + some small cleanup
1561 2004-04-22 Jean-Pierre Roux
1562 * ENH Minor changes to the Print() methods.
1563 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1564 Header printing. Example given with :
1565 > PrintHeader fileName 2 new
1566 (SQ based tree-like structure still to be done for the Header ...)
1568 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1569 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1570 1. I have added some unsigned where needed
1571 2. Some function parameter not used -> (void)
1572 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1573 4. g++ don't like character '\' in comment
1574 5. #define jpeg_create_decompress jCreaDecompress
1575 this really need to be fixed
1576 6. virtualize destructor of gdcmObject ... leakage
1577 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1578 this also really need to be fixed
1579 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1580 remove compression file
1581 (as we only do decompression, right ?)
1582 * ENH: Change malloc/calloc/free with c++ equivalent
1584 2004-04-21 Jean-Pierre Roux
1585 * FIX gdcmHeaderHelper::GetXSpacing
1586 when a single value is found (bug ?), xpacing is now
1587 defaulted to yspacing
1589 2004-04-19 Jean-Pierre Roux
1590 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1591 * ENH add parameters :
1592 bool exception_on_error = false,
1593 bool enable_sequences = false,
1594 bool ignore_shadow = false
1595 to the gdcmFile constructors to be full gdcmParser compliant
1596 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1597 to allow reading of PAPYRUS 3.0 files
1599 2004-04-06 Jean-Pierre Roux
1600 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1602 2004-04-02 Jean-Pierre Roux
1603 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1604 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1605 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1607 2004-03-30 Jean-Pierre Roux
1608 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1609 for ACR file, written out as DICOM files (hope so...)
1611 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1612 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1613 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1614 moved to base class gdcmParser and only the specialisation is kept
1616 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1617 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1618 already does the job.
1619 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1620 (to be consistent with gdcmParser::WriteEntries).
1622 2004-03-30 Benoit Regrain
1623 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1624 upate of the object's instance. It's passed to 2 in the unfavorable
1625 case : one in the ExecuteInformation, one in the ExecuteData
1627 2004-03-29 Jean-Pierre Roux
1628 * ENH : Check on file type to be written moved
1629 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1630 * FIX : gdcmObject::ResetBoundaries now stops properly
1631 when end-of-list is reached
1632 : gdcmVersion modified (as Benoit Regrain asked)
1634 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1635 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1636 * src/gdcmUtil.cxx: added forgotten iostream include.
1637 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1638 equivalent to ExplicitVR in existing code).
1640 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1641 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1642 now contains all the gdcmGlobal related code.
1643 * minor coding style and doxygenation changes.
1645 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1646 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1647 now contains all the Debug related code.
1648 * minor clean-up of includes in src/*.cxx
1649 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1650 CreateCleanString) removed.
1651 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1652 * Doc/DoxyMainPageUser.txt added.
1653 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1654 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1655 src/gdcmDirList.cxx)
1657 2004-03-24 Jean-Pierre Roux
1658 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1660 2004-03-23 Jean-Pierre Roux
1661 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1662 big endian made volumes
1663 * ENH Now gdcmParser constructor and destructor are protected to forbid
1664 end user to instanciate class gdcmParser
1665 (only gdcmHeader and gdcmDicomDir are meaningfull)
1667 2004-03-22 Benoit Regrain
1668 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1669 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1670 gdcmSerie to gdcmDicomDirSerie
1672 2004-03-19 Jean-Pierre Roux
1673 * ENH Now the tree-like structure describing a DICOMDIR comming from
1674 an already existing DICOMDIR file is consistent with
1675 the home-made tree-like structure build ex-nihilo
1676 or build from the files held (recursively) in a Directory
1677 functions gdcmDicomDir::CheckBoundaries()
1678 gdcmObject::SetBoundaries() added
1680 2004-03-17 Jean-Pierre Roux
1681 * REM (Eric Boix bug) : removal of meaningless
1682 gdcmDicomDirImage::NewImage function.
1683 * FIX now file names and directory name are written properly in the
1685 * FIX now gdcmDicomDir constructor may be call without any trick
1688 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1689 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1690 of gdcmDicomDirImage::NewImage as empty function.
1692 2004-02-28 Jean-Pierre Roux
1693 * ENH add gdcmDicomDir:NewPatient
1694 add gdcmDicomDirPatient:NewStudy
1695 add gdcmDicomDirStudy:NewSerie
1696 add gdcmDicomDirSerie:NewImage
1697 to allow making gdcDicomDir object.
1698 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1699 (as opposite to the gdcmHeader chained list)
1701 2004-02-11 Benoit Regrain
1702 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1703 when using from python
1705 2004-02-10 Benoit Regrain
1706 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1707 * FIX : in gdcmDicomDir when the directory is empty
1708 * ENH : add callback and methods to get the progression of dicomDir
1711 2004-02-06 Jean-Pierre Roux
1712 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1713 - GDCM_META added to gdcmDicomDirType
1714 - class gdcmMeta created
1715 * ENH : - A brief summary is now displayed at the beginning of
1716 'testDicomDir' to help disaster magnitude estimation
1717 * REM : Now useless Test/explDICOMDIR.cxx
1719 2004-02-05 Benoit Regrain
1720 * ENH : add methods in gdcmObject to get the hash table or the list of
1722 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1723 * FIX : wrapping python for TagHeaderEntryHT
1725 2004-02-04 Benoit Regrain
1726 * FIX : even length for some strings when writting the dicom dir
1727 * FIX : sort the images in the dicom dir
1728 * FIX : Bug fix for python use of dicom dir
1729 * ADD : a python demo
1731 2004-02-04 Jean-Pierre Roux
1732 * FIX : Final solution (?) for icone embedded images
1733 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1734 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1735 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1736 gdcmData/gdcm-MR-SIEMENS-16.acr1
1737 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1738 to make full checking easier
1740 2004-02-04 Benoit Regrain
1741 * FIX : WriteEntries : coding style & logic in parameters
1742 * FIX : Set the elements to create the DicomDir in a dictionary file
1744 2004-02-03 Benoit Regrain
1745 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1746 * gdcmDicomDir : add the load of directory
1747 * Bug fix and print add-on
1749 2004-02-03 Jean-Pierre Roux
1750 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1751 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1752 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1753 * FIX gdcmParser.cxx : 'group length' elements are now considered
1754 as integers, even for shadow groups, when file is Implicit VR
1756 2004-02-02 Jean-Pierre Roux
1757 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1759 of the last synonym :-(
1760 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1762 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1763 * FIX taking into account the possible 7fe0,0010 multiplicity
1764 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1765 to allow removal of references to 7fe0,0010, to deal with
1766 ACR-NEMA images, when 0028,0200 is meaningfull
1768 2004-01-31 Jean-Pierre Roux
1769 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1770 no longer writes 'Un' on disk
1771 * FIX SQ elements with actual length are now dealt with corectly
1772 * FIX gdcmFile::WriteBase make the difference, for color images, between
1773 the length (for Palette expanded images)
1774 and Raw Length (non expanded image + Palette)
1775 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1776 (that broke Write). Replaced by UL.
1777 Aware user will reload the field if he
1778 thinks it's necesssary
1780 2004-01-30 Jean-Pierre Roux
1781 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1782 when 'dirty Acr' is found, to be compliant with the new
1783 IsReadable() methods.
1785 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1786 (no DOUBLE images in kosher DICOM,
1787 but so usefull for people that miss them ;-)
1789 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1790 DICOMDIR related utilities (not checked as Windoze compliant)
1792 2004-01-28 Jean-Pierre Roux
1793 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1795 2004-01-27 Jean-Pierre Roux
1796 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1797 to allow skipping the shadow elements, to save memory space.
1798 The TRUE value for this param has to be used
1799 with a FALSE value for the 'enable_sequence' param.
1800 ('public elements' may be embedded in 'shadow Sequences')
1801 * gdcmHeader methods now deal with 'embedded icones images' in the header
1802 (even when an 'icone image sequence' is announced by the
1803 element (0x0088,0x0200), but there is NO icone at all ...
1805 * gdcmHeader sometimes Image Location value doesn't follow
1806 the supposed processor endianity (see gdcmData/cr172241.dcm).
1809 * gdcmHeader add the method
1810 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1811 to get *all* the Header Entries with the same tag.
1812 GetHeaderEntrySameName is probabely *useless*
1813 (no meaning : Name is *not* an identifier within the Dictionnary)
1815 2004-01-26 Benoit Regrain
1816 * Bug fix in the print of hexadecimal representations. Remove long fields
1817 in the print and add a third level of print to print them
1819 2004-01-23 Benoit Regrain
1820 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1821 * Bug fix on test suite after remove the strip made on not string fields
1822 * Split the IsReadable method between gdcmParser which test that the file
1823 is dicom and gdcmHeader which test that it's an image file
1825 2004-01-22 Benoit Regrain
1826 * DicomDir : clean code, add methods, set variables in protected or private
1827 * gdcmUtil : bug fix for the clean string method
1829 2004-01-19 Benoit Regrain
1830 * Add the use of shadow dictionaries
1831 * bug fix and coding style
1833 2004-01-19 Benoit Regrain
1834 * src/gdcmFile.cxx : bug fix concerning the close of file
1835 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1836 * Add the update of header entries using the shadow library
1838 2004-01-19 Benoit Regrain
1839 * removal of file gdcmHeader2.cxx
1840 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1841 inheriting from gdcmParser. This split is to prepare the integration
1842 of dicom dir parsing
1843 * bug fix under python
1845 2004-01-16 Jean-Pierre Roux
1846 * REM removal of class gdcmHeaderEntrySet
1847 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1848 * ADD add file gdcmHeader2.cxx
1849 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1851 2004-01-15 Benoit Regrain
1852 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1853 entries created while parsing the header. Thus, they will be destroyed
1854 when the gdcmDictSet will be destroyed
1855 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1858 2004-01-15 Benoit Regrain
1859 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1860 made a fatal error because of the memory release at the end of program.
1861 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1862 some memory and vtk seems to have some problems with that.
1863 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1865 2004-01-14 Benoit Regrain
1866 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1867 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1868 * src/*.[h|cxx] : make changes due to class name changes
1869 * gdcmPython/demo/*.py : bug fix due to method names
1871 2004-01-13 Benoit Regrain
1872 * src/*.[h|cxx] : coding style
1873 * vtk/*.[h|cxx] : coding style
1875 2004-01-13 Benoit Regrain
1876 * gdcmPython/testSuite.py : test the readable flag of file for tests
1877 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1878 It's lied to the stl compilation by MSVC (windows, always windows...)
1879 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1881 2004-01-12 Benoit Regrain
1882 * src/*.h : add comments
1883 * src/gdcmDictSet.h : set the method BuildDictPath in public
1884 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1885 directly setted in the source code
1886 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1889 2004-01-09 Benoit Regrain
1890 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1891 * setup.py : use a reference to gdcmVERSION
1893 2004-01-07 Benoit Regrain
1894 * Modification to compile with the distutils.
1897 2003-12-10 Benoit Regrain
1898 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1899 can use a gdcmHeaderHelper to load data
1900 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1901 made in the source code
1903 2003-12-10 Benoit Regrain
1904 * Update Windows projects and .cvsignore files
1906 2003-11-12 Jean-Pierre Roux
1907 * ENH gdcmHeader constructor has one more parameter (default value : false)
1908 that allows the user to 'go inside' the SeQuences only
1910 gdcmElValSet:Print takes it into account
1912 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1913 * ENH: Update gdcmPython/CMakeLists
1914 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1915 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1917 2003-11-10 Jean-Pierre Roux
1918 * FIX : gdcmHeader::LoadElements is now based
1919 on the ListTag listElem member,
1920 not longer on the TagElValueHT tagHt member
1921 * ENH : PrintPubElVal shows (temporarily) both results,
1922 with the tagHt member and the listElem member.
1923 (it's easier to 'see' the problems when using Printheader)
1925 * FIX : old private member LgrElem is now splitted into
1926 ReadLength : Length actually found on disk (updated only
1927 if bug fixing is necessary), for internal
1929 UsableLength : Updated by FixFoundLength, to fix a bug
1930 or to allow Parser going on.
1931 Will allow to re-write a kosher header when a SeQuence
1932 with a length (not 0000) is found
1933 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1934 because gdcmElValSet::Add does not update ListElem
1937 2003-11-07 Jean-Pierre Roux
1938 * FIX misstyping in Transfert Syntax name table
1939 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1940 when they have an actual length (not 0000 nor FFFFF)
1941 (Nobody should care of it, but DICOMDIR explorers)
1943 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1944 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1946 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1947 * ENH: vtkGdcmReader now supports LUT !
1948 (vtkgdcmViewer for now is not able to use them though)
1950 2003-11-05 Jean-Pierre Roux
1951 * in testSuite.py : new files names for checking the package
1952 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1953 that returns the pixel area size to the *aware* (vtk) user
1954 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1956 2003-11-05 Benoit Regrain
1957 * in testSuite.py : Modify the rules for checking the paths
1958 : Explicit error messages
1959 * in __init__.py : Related modif
1961 2003-11-03 Jean-Pierre Roux
1962 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1963 to be used by aware (vtk) users that want to manage
1964 LUT (and no to turn the PALETTE image into an RGB pixels one)
1965 * GetPixelType now returns 8U for 24 Bits images
1966 (vtkGdcmReader compliant)
1968 2003-10-31 Jean-Pierre Roux
1969 * Removal of *all* gdcmData images and add them again
1970 in order to loose the 'history' of un-anonymised images
1972 2003-10-31 Jean-Pierre Roux
1973 * RMV : removal of useless jBitsInJsample.h
1974 for both 8 and 12 Bits JPEG Lossy Libraries
1976 2003-10-31 Jean-Pierre Roux
1977 * ENH : Add the functions gdcmFile::GetImageDataRaw
1978 gdcmFile::GetImageDataIntoVectorRaw
1979 that act as GetImageData and GetImageDataIntoVector
1980 except the making of an RGB Plane from Gray Plane + LUT
1981 Intended to aware (vtk) users who know how to manage
1984 GetLUTRGBA return a R,G,B,A LUT if any
1985 lgrTotaleRaw gives the 'Raw' length
1986 GetImageDataRaw returns the gray Plane
1987 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1988 (They stay Grey, just like with other Dicom viewers :-(
1990 2003-10-30 Jean-Pierre Roux
1991 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1993 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1994 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1995 being coherents dicom files.
1997 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1998 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2000 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2001 * ENH: Two steps is necessary to please VC++ compiler...
2002 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2003 * ENH: Add include dir to medcon lib
2004 * FIX: only one function is being exported for now !
2005 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2007 2003-10-29 Jean-Pierre Roux
2008 * adding gdcmHeader::GetLUTRGBA
2009 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2010 --> Mathieu, the modif u're waiting for is not yet committed
2011 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2013 2003-10-27 Jean-Pierre Roux
2014 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2015 00191113.dcm DermaColorLossLess.dcm
2016 MxTwinLossLess.dcm RadBWLossLess.dcm
2017 * ENH: For version prior to vtkImageViewer2 -r 1.19
2018 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2020 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2021 * Removal of ido stuff in CMakeLists.txt
2023 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2024 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2025 * FIX: remove a call to ->Modified ... see comments
2026 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2028 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2029 * FIX: Problem with path for libvtkgdcmPython
2030 * ENH: Try adding a search script for python site-package
2031 * RMV: Remove some file from medcon lib that are not necessary
2032 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2033 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2034 * FIX: More pragma disable fro VC++,
2035 I don't think I break something as it is also disable in VTK/ITK.
2036 But it fasten debug compilation time.
2038 2003-10-23 Jean-Pierre Roux
2039 * gdcm now deals with 16 Bits Run Length Encoded images
2040 (they are compressed as 2 planes images,
2041 one for the high Bytes, the other for low Bytes)
2043 2003-10-22 Jean-Pierre Roux
2044 * Now CheckRead takes into account :
2045 - the bugged 'Leonardo' Siemens images
2046 - the XA images, sent thru the burning VPRO station
2047 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2050 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2051 * FIX: When copying a Makefile.am to CMakeLists.txt
2052 one should remove the '\'
2054 2003-10-22 Jean-Pierre Roux
2055 * in gdcmData adding a bugged 'Leonardo' Siemens image
2056 (wrong lengths in header)
2057 OK with gdcm, KO with the other viewers :-)
2058 * add a GE dlx XA image, thru the VEPRO burning station
2061 2003-10-21 Jean-Pierre Roux
2062 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2063 for a brutal checking of vtkgdcmViewer compliance
2065 2003-10-21 Jean-Pierre Roux
2066 * add the files for 'xmedcon' Jpeg Lossless library
2067 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2069 2003-10-21 Jean-Pierre Roux
2070 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2072 2003-10-21 Jean-Pierre Roux
2073 * garbage Siemens 'Leonardo' images dealt with
2074 (the patch is easy to remove)
2075 * cosmetic changes to avoid warnings
2077 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2078 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2079 no need to press 'r' now.
2081 2003-10-20 Jean-Pierre Roux
2082 * upgrade of checkRead.sh checkWrite.sh according
2083 to new Jpeg Lossless decompressor
2084 * add US.3405.1.dcm, a genuine RGB medical file ...
2085 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2086 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2088 2003-10-15 Jean-Pierre Roux
2089 * general anonymisation in gdcmData
2090 * adding the 'color files' from
2091 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2092 * adding some well knowed bugged-header images
2093 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2094 waiting for their inclusion in Python testsuite
2096 2003-10-15 Jean-Pierre Roux
2097 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2098 no longer seg faults when file is not found
2100 2003-10-14 Jean-Pierre Roux
2101 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2104 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2105 * TODO: *.in file to genereate a UseGDCM later
2107 2003-10-14 Jean-Pierre Roux
2108 * Some supposed-to-be Dicom Images have no preamble.
2109 OpenFile takes it into account
2110 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2111 * Missing elements added in dicomV3.dic
2112 (just to be affraid : have a look at
2113 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2114 and do it again next year ;->
2116 2003-10-13 Jean-Pierre Roux
2117 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2118 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2119 But there are NOT. It's fixed !
2121 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2122 * FIX: "jpeglib.h" was not found on VC++
2123 * FIX: vtkgdcm was not being installed
2125 2003-10-10 Jean-Pierre Roux
2126 * ENH : OpenFile closes the file if it *really* doesn't look like
2127 an ACR-NEMA / DICOM one.
2128 * FIX : testWrite no longer writes an empty file if the source file
2129 is not gdcm Readable
2130 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2133 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2134 * FIX: CMake generate now documentation
2135 * ENH: out of source doc build !
2136 * ENH: Generate both user and dev documentation
2137 * ENH: Should work on windows too
2138 * ENH: Only one doxygen config.in file is needed
2139 * FIX: make install should be ok now on ùnix plateform
2140 * FIX: PATH to dictionary was wrong (missing /)
2141 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2143 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2144 * vtkGdcmReader is now able to read rgb dicom file.
2145 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2146 * added a gdcmViewer to vtk test, use mouse to control
2147 window level & window width
2149 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2150 * CMake-ification of gdcm, we have now two build system
2151 * FIX: on cygwin Wsock32 doesn't exist
2152 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2154 2003-10-06 Emanuel Ollart
2155 * FIX : compilation process wad broken.
2156 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2158 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2159 * change gdcmViewer -> vtkgdcmViewer
2160 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2162 2003-10-06 Jean-Pierre Roux
2163 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2164 ( e.g : well known GE images with a wrong elem length,
2165 : Philips MRI Images with a wrong Huffman table)
2166 * still to be done : allow the reading of bugged LEONARDO Siemens images
2168 2003-10-03 Jean-Pierre Roux
2169 * Odd length strings are padded with '\0' (not with spaces,
2170 to remain compliant with already defined strings,
2171 like Transfert Syntax UID and others)
2173 2003-10-03 Jean-Pierre Roux
2174 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2175 to allow displaying RGB images (not only by affim ;-)
2177 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2178 * vtkGdcmReader is now able to read rgb dicom file.
2179 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2181 2003-10-03 Jean-Pierre Roux
2182 * A few nasty patches to allow the reading of a lot of nasty images
2183 ( e.g : well known GE images with a wrong elem length,
2184 : Philips MRI Images with a wrong Huffman table)
2185 * still to be done : allow the reading of bugged LEONARDO Siemens images
2187 2003-10-03 Jean-Pierre Roux
2188 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2190 2003-10-03 Jean-Pierre Roux
2191 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2192 to allow displaying RGB images (not only by affim ;-)
2194 2003-10-03 Jean-Pierre Roux
2195 * gdcmFile::GetImageDataIntoVector now
2196 - deals with MultiFrames MultiFragments Run Length Encoded files
2197 - deals with YcBcR (YBR_FULL) files
2198 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2199 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2201 (no sample found :-(
2203 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2204 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2205 Two reasons: - clear things
2206 - third parties acces gdcm through header files, so won't
2207 suffer anymore VC++ complains
2209 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2210 * add argv[1] in testvtkGdcmReader.cxx
2213 2003-09-24 Jean-Pierre Roux
2214 * The lines are now eigthy characters long.for
2215 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2217 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2218 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2219 char* to std::string. Thus, the use of strdup becomes useless. (see
2220 previous commis of Malaterre)
2221 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2222 before the last Malaterre's commit.
2224 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2225 * This commit should fix the Debug building under VC++, the problem
2226 was mainly a mixture of debug and release lib being loaded at startup.
2227 * I also remove a depency to a specific C function: strdup. Because I had
2228 to force the link to msvcrtd (whereas strdup is in libc).
2230 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2231 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2232 located in the gdcmCommon.h file. All use of reference of tha has been
2233 changed to now use the variable GDCM_UNFOUND.
2235 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2237 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2238 Dicom dictionary. The test suite can now be run again. Note:
2239 I'm note very happy with the " (RET)" changes. I believe this
2240 RETAINED comment should be dropped when parsing the dictionary.
2241 - PACKAGER corrected
2243 - AUTHORS updated and now in alphabetical order
2244 * Makefile.am now exports gdcm.dsw for Windoze users.
2246 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2247 * cygwin complains about missing std:: in subdir Test/
2249 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2250 * remove some methods that are now in gdcmHeaderHelper
2252 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2253 * vtkGdcmReader set spacing and origin correctly
2255 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2256 * Fix a few delete/delete[] mismatch
2258 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2259 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2260 interpretation to data given by gdcmHeader. For instance there are
2261 heuristics to get informations (look at different places).
2262 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2263 sorting DICOM images based on different strategies.
2264 * modified Makefiles accordingly.
2266 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2267 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2268 when building in debug mode
2269 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2270 src/win32/gdcmdll.dsp
2271 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2273 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2274 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2277 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2278 * src/win32/libgdcmjpeg12.dsp was not dos format
2279 * src/win32/libgdcmjpeg12.dsp :
2280 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2281 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2283 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2284 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2286 * src/gdcmFile.cxx : bug fix in affectation type
2287 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2288 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2289 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2290 symbols... future problem ?
2292 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2293 * src/win32/libgdcmijpeg12.dsp was missing
2294 * modified gdcm.dsw accordingly
2296 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2297 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2299 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2300 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2301 commit of JPR (before his hollidays to facilitate our work).
2302 * setup.py : bug fix in code. Modifications made while the last commit
2303 of JPR. The code hasn't been tested before the commit... it's so
2304 useless to make that (for best programmer that is JPR) !!!
2306 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2307 * tagged the current version as Version0_3 (i.e. version 0.3)
2309 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2310 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2311 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2312 * *.dsp : modifications to use new libgdcmijpeg8 library
2313 * setup.py : bug fix on VTKPATH variable
2314 * PACKAGER : adding all concerning windows
2316 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2317 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2319 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2320 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2321 test suite reported error.
2322 * PACKAGER file added (describes what a packager must do when
2323 packaging a new release).
2324 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2325 * configure.in: upgraded version number to 0.3.0
2326 * fixing build of rpm (through rpm -ta):
2327 - Doc/Makefile.am exports proper doxygen files
2328 - src/jpeg/libijg8/Makefile.am exports the include files.
2330 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2331 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2332 * src/gdcmHeader.h : formatting code
2334 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2335 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2336 We were obtaining error message from vtk. Now, creation of file list
2337 is made in an internal list to prevent this problem.
2338 Bug fix when output is empty.
2339 Bug fix in update of progress value. Previous commit for this was a bad
2341 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2343 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2344 * src/gdcmHeader.h : added method to get the file name
2345 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2346 files. Added method to remove all files on the input
2347 Added FIXME comment concerning the bad parsing of header made by
2348 ExecuteInformation method (in ExecuteData method)
2350 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2351 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2352 when using make instal.
2353 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2354 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2356 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2357 * setup.py : adding include dir of jpeg lib to compile all sources
2358 * */Win32/*.dsp : JPR fix for windows compilation
2360 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2361 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2363 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2364 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2366 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2367 * setup.py is again effective on un*x (takes into account the
2368 addon of the jpeg library)
2369 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2370 * Doc/Doxy* updated (includes above enhancements)
2371 * INSTALL now points to web documentation
2373 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2374 * src/gdcmHeader.h doesn't make unnecessary reference to
2376 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2378 * src/gdcm*.[cxx|h] :
2379 - to allow compilation with gcc 3.x
2380 -- clean up of STL usage (added explicit usage of std::)
2381 -- small fixes on exceptions.
2382 Note: linking not tested !
2383 - clean of doxygen comments to avoid warnings at documentation
2385 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2386 dependent convertion).
2388 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2389 * Clean up of previous JPR garbage commit (not even commented in the
2391 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2392 - moved all jpeg related files from src to src/jpeg/libijg8, with
2393 addition/modification of Makefile.am and configure.in.
2394 - the testSuite is still brain damage (not guilty).
2396 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2397 * WrapVTK.py : modifications to get correctly vtk source files to
2399 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2400 (FileName -> Filename)
2402 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2403 * vtk/vtkGdcmReader.[cxx/h]:
2404 - UpdateProgress method should now be effective
2405 - removed the limitation on having only images loaded (as opposed
2407 - when building a stack of images/volume, a lesser number of
2408 gdcmHeader and gdcmFile instances should be used (hopefully
2409 accelerating things).
2410 - when building a stack of images/volumes, files which are not
2411 loadable (wrong path-filename, wrong permissions on existing file,
2412 or file not parsable by gdcm) are replaced with a black image
2413 in the stack (for the caller to notice the problem).
2415 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2416 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2418 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2419 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2420 between standard library (std) and vtk library (problems are found
2421 under Windows... thanks Windows !)
2423 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2424 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2426 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2428 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2429 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2431 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2432 * When compiling with distutils (see setup.py) the C++ compiler is
2433 called with different flags than the default ones (with automake).
2434 In order to fix all those warning, I compiled gdcm with the command
2435 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2436 and went for warning fixes:
2437 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2438 up from unused variables.
2439 - vtk/vtkGdcmReader.cxx: potential bug fix.
2440 * src/gdcmHeader.h: Doxygen warning cleanup
2442 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2443 * gdcmPython/gdcm.i:
2444 - typemaps correction to take into account the systematic replacement
2445 of "using namespace std" with std:: prefix e.g. std::list,
2446 std::string... (cf changes of 2003-05-21).
2447 - gdcmGlob global variable of type gdcmGlobal (defined in
2448 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2449 exported to Python a as cvar.
2450 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2451 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2452 gdcmDictSet.GetPubDictTagNames() and
2453 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2454 C++ static methods).
2455 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2456 with the above changes.
2458 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2459 * setup.py, manifest.in : bug fix under linux
2461 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2462 * Modification of setup.py to compile vtk part too. Then, we have 2
2463 wrappers which must work with same distutils. For that, we have a
2464 generic distutils in distusiltsWrapping.py ; with :
2465 - build_extWrap class to wrap generically all extensions,
2466 - ExtensionWrap base class for all wrapping extension that contains
2468 - Wrapper interface which wrap sources
2469 + In WrapSwig.py we have extension and wrapper for Swig
2470 + In WrapVTK.py we have extension and wrapper for VTK
2471 * MANIFEST.in : modifications to consider vtk directory and new python
2472 files for compilation
2474 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2475 * Added python wrappers of vtkGdcmReader vtk class (see the
2476 source in vtk/vtkGdcmReader.cxx) :
2477 - vtk/Makefile.am now builds a library
2478 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2479 python library (as opposed to _gdcm.so wich are the python
2480 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2481 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2483 - configure.in has an additional flag --enable-vtk that needs
2484 to be set to enable compilation of vtk related code, that is:
2485 + vtk/vtkGdcmReader.so and
2486 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2487 + gdcmPython/vtkgdcmPython.so (see above)
2488 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2489 be read when compressed or when HighBit + 1 != BitsStored),
2490 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2491 the usage of the python wrapper of vtkGdcmReader vtk class.
2492 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2493 * src/*.[h] all occurences of stl classes are now prefixed with
2494 std::, and all occurences of "using namespace std;" where removed.
2495 This is to avoid pollution of global namespace in included files.
2496 Apparently vtk does not avoid this pitfall: when using both
2497 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2498 collision of various stl members (principally cout...).
2499 * gdcmPython/testSuite.py now cleanly removes temprory generated
2501 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2502 comply with above changes)
2504 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2505 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2506 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2507 vtk data structure (an image Flip was required).
2508 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2509 * cosmetic changes in documentation.
2511 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2512 * src/gdcmHeader.cxx: the constructor no longer exits when an
2513 unexisting file is given as argument.
2514 * The subdirectory Data (containing all the images used for the
2515 test suite) is not part of this repository anymore. A new module
2516 containing those images is now available at
2517 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2518 with the name gdcmData.
2519 All the python scripts (including the package initialisation file
2520 gdcmPython/__init__.py) were adapated to take this change into
2521 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2523 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2524 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2525 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2526 demo of the usage of this class.
2527 Compilation of this vtk part is only done when using the --enable-vtk
2528 at configure (or autogen.sh) stage.
2530 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2531 * More memory link related corrections and documentation fixes.
2533 - maximum info is obtained with a command of the form:
2534 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2535 --show-reachable=yes PrintHeader
2536 - the remaining reachable blocks seem to come from the STL
2537 allocation scheme through the usage of map and list. It looks
2538 like this memory cannot be freed but it is not a memory leak
2539 (in fact further invocation to the STL would recollect the
2540 unused memory allthough it cannot explicitely be freed).
2541 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2542 of displaying an image parsed with gdcm and displayed with VTK.
2543 Note: some images don't seem to work e.g.
2544 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2545 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2546 Allthough this weakens the semantics, it is a ditch attempt to
2547 make gdcm more thread friendly.
2549 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2550 * Memory link hunt (by using valgrind through the command
2551 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2552 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2553 gdcmHeader::_dicom_vr.
2554 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2555 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2557 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2559 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2560 * src/Makefile.am now exports all the necessary include files at
2564 * UpdateGroupLength replaced by new one
2567 * UpdateGroupLength re-written using H-Table
2568 (named UpdateGroupLengthNew untill checks are over)
2570 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2571 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2572 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2574 - gdcmHeader::GetPubElValSet removed.
2575 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2576 UpdateGroupLength, WriteElements, Write.
2577 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2578 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2579 carried the same semantics.
2580 - src/gdcmHeaderIdo.cxx changed accordingly.
2581 - gdcmFile::WriteBase now regroups all the codes from previous
2582 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2583 - enum FileType moved to gdcmCommon.h
2584 * src/gdcmHeader.cxx AddDefault trashed
2585 * gdcmGetXSize added
2586 * getimageDataSize now calls gdcmGetXSize
2587 * Test/*.cxx changed to agree with above changes
2589 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2590 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2591 (to avoid double call by end user).
2592 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2593 by end user, since gdcmHeader::gdcmHeader now handles it.
2595 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2596 * gdcm/Doc many doxygen changes:
2597 - Doxyfile now has two different versions, DoxyfileUsers that generates
2598 the html.users end users oriented documentation and
2599 DoxyfileDeveloppers that generates the html.developper developper
2600 oriented documentation.
2601 - README changed accordingly
2602 - requirement.txt removed (old design info moved to TODO).
2603 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2604 DoxyMainPage.txt, DoxyPython.txt provide more information.
2605 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2606 be updated by simply regenerating the docs with doxygen and copying
2607 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2608 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2609 all the tests in the form "if (<map>.count() >1)" were removed.
2610 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2611 ill-formed documentation sections.
2612 * src/gdcmHeader.cxx: ditto
2614 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2615 * setup.py fixed for un*x (needed macro for stdint.h)
2616 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2617 un*ces with sh-utils test utility.
2618 * gdcmPython/demo/test.py renamed to PrintHeader.py
2619 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2620 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2621 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2622 * src/gdcm*.cxx JPR's bad inclusion fixed.
2624 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2625 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2626 * gdcmPython/demo/test.py changed accordingly.
2628 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2629 * gdcmPython/Makefile.am fixed linking against libstdc++
2630 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2631 * Swig subdir (historical tests of swig version 1.3.17++) removed
2632 * Test/testChangeEntete.cxx some lines commented out in order to make
2634 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2635 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2637 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2638 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2639 hence the user doesn't need this explicit call.
2640 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2641 i.e. LoadElements() call removed.
2642 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2643 - src/Makefile.am declares the proper flag for g++.
2644 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2645 for adding user defined new tags.
2646 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2647 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2648 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2650 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2651 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2652 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2653 src/Makefile.am : the project should properly compile and install
2654 with the autotools, included the python wrappers part.
2655 * gdcm.spec.in : added a spec file for RPM packaging.
2657 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2658 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2660 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2661 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2662 to exported to the environement (see gdcmPython/testSuite.py
2664 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2665 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2666 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2667 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2668 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2670 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2671 * gdcmPython/__init__.py doesn't crash anymore when running in
2672 in InstallMode or PreInstallMode but with an environement given
2673 value of GDCM_DICT_PATH.
2674 * src/gdcmDictSet.[cxx/h] coding style.
2676 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2677 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2678 * src/gdcm.h general comments moved to TODO, and README
2679 * src/gdcm.h should now be seen as a user commodity (including it
2680 should suffice to fully use gdcm). It is nowhere including within
2681 any of the kernel files src/*.cxx and src/*.h.
2683 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2684 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2685 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2687 * src/gdcm*.cxx only include their corresponding include file
2688 (as opposed to gdcm.h)
2689 * gdcmPython/gdcm.i changed accordingly
2690 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2691 the autogen.sh generated "make snapshot" command to work.
2692 * autogen.sh removed history related references to crea package.
2694 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2695 * distutilsSwigCPlusPlus.py work around some swig portability
2698 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2699 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2700 was done in a last ditch attempt to get setup.py _really_
2701 operationnal. The python/gdcmPython layaout add the advantage
2702 of hidding away the python related distutils specific files
2703 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2704 Alas, the src directory was out of scope (i.e. it's relative
2705 position to setup.py was ../src) which made things impossible to
2706 handle (see previous version of python/setup.py). Crossing fingers...
2708 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2709 * python/setup.py now works on Un*x. (harder than I thougth)
2710 * python/distutilsSwigCPlusPlus.py can now have include files
2711 among the list of sources.
2713 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2714 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2715 * modifications in MSVC projects
2717 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2718 * As stated by the first lines of Test/ExceptionAndPython/README, it
2719 looks like we can move back to original usage of exception within
2720 src/gdcm* and hence remove the errno stuff that was introduced
2721 as a quick and dirty fixture of this problem (added to the TODO).
2722 * Doc/Doxyfile configuration file for Doxygen and corresponding
2723 README file for usage added.
2724 * Test/testWrite.cxx added. This new test comes from a split of
2725 test.cxx that is now reverted to its original purpous i.e.
2726 testing the proper parsing of a Dicom related file.
2727 testWrite.cxx concentrates on testing the IO part of gdcm.
2728 * Test/bug1.cxx (containing a bug on WIn32) added.
2729 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2730 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2731 whose purpose is to publish the content of the TagNames of the
2732 Dicom public dictionnary were not accessible without an
2733 instance of class gdcmHeader.
2734 - those methods are now static methods of gdcmDictSet and hence
2735 require no instances at all to be invocated.
2736 - within gdcmDictSet this change required to change some method
2737 to class methods (i.e. are now static) among which SetDictPath
2738 (renamed to BuildDictPath) and LoadDefaultPubDict.
2739 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2740 the above changes by calling the new method classes of gdcmDictSet.
2741 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2742 the above to be effective.
2743 * python/gdcmPython: in order to wrap properly the above changes
2744 for Python, swig version now needs to be > 1.3.17.
2745 * python/gdcmPython/Makefile fixed to adapt itself to new
2746 configure/make shema introduced by Johan Montagnat (thanks for the
2747 contribution). Alas this Makefile cannot be turned into a proper
2748 Makefile.am without some heavy changes in the configure.in
2749 (for python dectection).
2750 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2751 now avoids publishing the empty entries.
2753 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2754 * python/setup.py : bug fix concerning install under windows
2755 ExtraPath reused :-P
2756 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2758 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2759 * Dicts/dicomV3.dic : remove double spaces !!!
2760 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2761 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2764 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2765 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2766 method. Doxygenation.
2767 * src/gdcm.h clean up of JPR spurious comments.
2769 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2770 * python/distutilsSwigCPlusPlus.py now properly collects the
2771 shadow classes generated by "swig -c++" (gdcm.py in our case)
2772 when using "python setup.py install".
2773 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2774 reexports the working classes.
2775 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2776 by the classical C errno scheme. This is to prevent an obscure
2777 behavior of the python wrappers when importing wxPython.wx prior
2778 to gdcmPython (which ended up in an abort call). An illustration
2779 of this oddity can be found in the Test/ExceptionAndPython
2780 subdir (see the README file). This problem probably due to
2781 an combination of g++ and dynamic loading.
2782 * added Test/ExceptionAndPython (see above)
2784 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2785 * Changed the layout of the python part to avoid bloating main
2786 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2787 i.e. the distutils arsenal. All the python related stuff is
2788 again in a python subdir, but the package itself is now in
2790 * setup.py was cleaned up:
2791 - pythonIncludePath removed
2792 - python setup.py bdist target is now functional.
2793 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2794 collision with other packages). gdcmPython/demo/*.py changed
2797 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2798 * python subdir moved to gdcmPython (preparation of distutils packaging).
2799 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2800 distutils installer is operational.
2801 * - gdcmPython/__init__.py now properly loads the swig generated
2802 shadow classes (from gdcm.py).
2803 - gdcmPython/demo/*.py changed to import the package gdcmPython
2804 instead of gdcmPython/demo/load.py.
2805 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2807 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2808 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2809 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2810 entries within the associated public Dicom dictionary resp. the same
2811 information but sorted by the fourth field (PAT, IMG, DIR) of the
2813 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2814 are now in the "???" group.
2815 - python/gdcm.i changed accordingly,
2816 - python/demo/printGroupedPublicDict.py added, that gives an example
2817 of the above new functionalities in Python.
2819 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2820 * src/gdcm.h, gdcmHeader.cxx:
2821 - historic references to glib's g_malloc and g_free (#defined)
2822 were definitively removed.
2823 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2824 * src/gdcmElValSet.cxx:
2825 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2826 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2827 - GetElValue(string) renamed to GetElValueByName.
2828 - Added GetElementByName(string).
2829 * src/gdcmHeader.cxx: added
2830 - GetPubElValRepByNumber(guint16, guint16)
2831 - GetPubElValRepByName(string)
2832 - GetShaElValRepByNumber(guint16, guint16)
2833 - GetShaElValRepByName(string)
2834 - GetShaElValByNumber(guint16, guint16)
2835 - GetShaElValRepByName(string)
2836 - GetElValRepByNumber(guint16, guint16)
2837 - GetElValRepByName(string)
2838 - GetElValByNumber(guint16, guint16)
2839 - GetElValRepByName(string)
2840 * Doc/requirements.txt added.
2842 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2843 * Test/Makefile building now depends on the one of libgdcm.so
2844 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2845 pixel data) aware which enables finding the address (offset) of
2846 the pixel data of JPEG encoded DICOM files. This leaves only a single
2847 file in the testSuite whose pixel data address (offset) is unknown.
2848 * python/testSuite.py changed accordingly.
2850 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2851 * VC++ has some strong limitations when working with the STL, as stated
2852 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2853 "Also note that some STL containers (map, set, queue, list, deque)
2854 cannot be exported. [...]
2855 Some STL classes contain nested classes. These classes can not
2857 This is caused by a designed limitation that once a template
2858 class is instantiated, it can not be re-instantiated and
2860 Since our usage of map<> is ubiquitous in gdcm, this "designed
2861 limitation" of VC++ is a pitfall.
2862 Hence the Python wrappers of gdcm cannot be incrementally linked
2863 against the c++ dynamic library. The dirty but only workaround is
2864 to forget about incremental link of dynamic libraries and to generate
2865 the Python wrappers library with the inclusions of the underlying C++
2867 The following modifications concern this matter on Win32/VC++:
2868 - wrapping python correct with standalone wrapped dll (don't use separate
2869 dll under windows !!!!)
2870 - python21_d debug mode enabled (ask Frog how to use it :-)
2871 - NO problem with having an STL member of class for example string in C++
2872 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2873 - Python test of dcmlib in Python is ok under windows on a large set
2875 * removed glib references
2876 * typedef's inserted in gdcm.i for correct swig type management
2878 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2879 * python/demo/*.py load.py extracted from test.py. Added explore.py
2880 that only displays required tags and testAll.py that parses all
2881 the files of the testsuite without using unittest.
2882 * python/testSuite.py other additional test on new files added.
2883 * Data/* new test files added accordingly to the testSuite.
2884 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2885 the vr in the file differs from the one of the dictionary.
2887 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2888 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2889 values, but limits itself to values which are below a user specified
2890 size (by default 1024 bytes).
2891 * python/gdcm.i : elements not loaded (because their size is above the
2892 user specified treshold) are exported with their TagKey as key of the
2893 python dictionary. This enables the testsuite to make some checks
2894 on the unloaded elements (since we have their offset and size).
2895 * python/testSuite.py
2896 - now tests for the existence and proper value of the pixel data
2897 - two new examples added.
2898 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2900 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2901 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2902 aware. See the strategy comments in gdcmHeader::FindeLength().
2903 * Test/test.cxx now accepts a filename as first argument.
2904 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2905 * python/testSuite.py changed to integrate test on above files.
2907 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2908 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2909 the vr was also RET.
2910 * python/testSuite.py more tests added.
2912 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2913 * python/testSuite.py unittest test suite added (uses Data)
2914 * Data/* dcm and acr files for the test suite.
2915 * glib dependance removed from un*x version. We now use ISO C99
2916 7.18 Integer types (see stdint.h)
2917 - python/Makefile, src/Makefile src/gdcm.h
2918 * src/ when an explicit vr (like dicom files) suddenly poped an
2919 implicit element we use to mark the underlying DictEntry of the
2920 concerned ElValue with "Implicit". This strategy was damageable
2921 too the public or provite dictionaries, since some of their vr
2922 would be changed. Since Header::FindLength heavily relies on the
2923 detection by Header::FindVR of falsely explicit elements, I
2924 added an extra ImplicitVr member to ElValue (boolean).
2925 The rest of the changes we the necessary adaptations.
2927 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2928 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2930 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2932 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2933 * Adaptation for porting to VC++:
2935 o forced to use std namespace (for string to be known)
2936 o all class use __declspec export style on WIN32
2937 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2938 (in stdlib.h on Win32 but in std:: for gcc)
2939 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2940 variable GDCM_DICT_PATH.
2941 * src/gdcmHeader.cxx verbose comments made discrete.
2943 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2944 * python/gdcm.i: added a typemap that converts a C++ hashing table
2945 to native Python dictionary.
2946 * python/demo/test.py:
2947 - now uses the native dictionary for exploration of gdcmHeader.
2948 - takes an optional filename argument (the file to parse).
2949 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2950 PubElVals hashing table.
2951 * Dicts/dicomV3.dic removed error prone trailing spaces.
2953 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2954 * Python wrapping process moved away from src/Makefile to
2955 newly created python/Makefile (as well as gdcm.i)
2956 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2957 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2958 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2959 from the environement variable GDCM_DICT_PATH (when existing).
2960 * src/gdcmDict::GetTag bug fix.
2962 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2963 * Straightforward temporary fixes for swig to build the python wrappers.
2964 src/Makefile now has a python working entry [by working we mean
2965 that we can import de shadow classes without errors].
2967 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2968 * hashtest.cxx removed (since already in Test)
2969 * src/gdcmlib.h renamed to src/gdcm.h
2970 * src/dcm.i renamed to src/gdcm.i
2971 * src/Makefile prepared for python wrapping
2973 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2974 * src/gdcmHeader.cxx :
2975 - Parsing of header is now separated from loading of element values
2976 (see gdcmHeader::LoadElements).
2977 - general clean up of hopefully all file access (creation of
2978 ReadInt16 and ReadInt32)
2980 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2981 * src/gdcmHeader.cxx :
2982 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2984 - SetLgrElem renamed to SetLength
2985 - GetLgrElem renamed to GetLength
2986 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2987 * src/gdcmElValSet.cxx fixed both GetElValue methods
2988 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2989 due to IdoDude was cleaned out.
2991 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2992 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2993 concentrates on finding the value representation (when it exists).
2994 RecupLgr now only finds the element value length, and it avoids
2995 returning the unecessary skL (skipped length).
2996 Also, offsetCourant was simply removed (with taille_fich) since
2997 it was redundant with the File position internals (by using
2998 ftell and fseek). This also made skL (see above in RecupLgr) usage
3000 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3001 on the libido specificities which are handled through class
3003 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3006 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3007 * Truckload of changes. Parsing of header is barely functional
3008 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3010 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3011 * src/gdcmHeader.cxx many addons of low level methods
3013 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3014 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3015 and _IdDcmSWAP_LONG.
3017 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3018 * This corresponds to all the changes decided at the meeting of
3019 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob