1 Mon Oct 18 10:27:49 2005 by regrain
2 * Correctly use the VRKey for all vr variables... instead of TagName
4 * Replace the definition of VRKey from std::string to a class
5 containing a char[2]. All methods are inline to have no speed low
6 * Create the GDCM_VRUNKNOWN = " " for the VR values
8 Mon Oct 18 10:27:49 2005 by regrain
9 * Remove useless constructor of gdcm::Document
10 * Remove useless parameter in the constructor of gdcm::ElementSet
11 * Split gdcmCommon to separate the System specifications to the gdcm
14 Mon Oct 18 10:27:49 2005 by regrain
15 * Minor coding-style clean up
16 * Replace the ContentEntry and its derived classes (BinEntry and ValEntry)
17 by the DataEntry. This unique entry considers all datas like binary datas.
18 Some methods are added to interpret - at fly - the binary datas.
19 Due to this important change, some methods of the DocEntrySet, concerning
20 the BinEntry and ValEntry classes, are erased ; and new methods for the
21 DataEntry class are created.
22 Some methods to set the ValEntry or the BinEntry are renamed to
23 correspond to the new DataEntry, like for example :
24 - SetValEntry -> SetEntryString
25 - SetBinEntry -> SetEntryBinArea
26 This change will remove all useless creation of the string when working
29 Thu Aug 25 16:59:49 2005 by jpr
31 Now Print displays the BinEntry Content (if it's printable, and loaded)
32 Usefull for a lot od Implicit VR 'Bin'Entry (if we knew there VR, they wouldn't
34 Appreciate the difference having a look at PrintFile result for
35 gdcmData/SIEMENS_MAGNETOM-12-MONO2-FileSeq0.dcm.
37 Thu Aug 25 16:55:47 2005 by jpr
39 Add methods to check the 'printability' of a bin area
41 Thu Aug 25 15:45:40 2005 by jpr
43 According to Mathieu's suggestion, Print now display FL BinEntries in a human
46 Thu Aug 25 15:12:43 2005 by jpr
48 According to Mathieu's suggestion, *all* the elements 0x000
49 are now named 'Group Length' (even if they belong to a Shadow Group')
51 Wed Aug 24 14:09:13 2005 by jpr
52 gdcmDocEntry.cxx,h, gdcmDocEntrySet.cxx,h
53 Removal of QD patch for Private Sequence + Immplicit VR.
54 Add a clean solution (Backtracking if an Item Starter is found
57 Tue Aug 23 14:57:49 2005 by jpr
59 Brutal patch, waiting till we find a clever way to guess
60 if a doc entry is a Sequence,
61 - when it's odd number
62 - and the file is Implicit VR Transfert Syntax
63 It solves temporarily some Philips Medical Systems image problems
65 Mon Aug 22 18:17:54 200 by jpr
67 Save a *few* microseconds at run time : inline method Util::GetVersion()
70 Tue Aug 23 14:58:49 2005 by jpr
71 gdcmSeqEntry.cxx, gdcmDocEntry.cxx
72 Improve 'Print' methods
74 Sat Aug 20 11:10:24 2005by jpr
76 Use new style FileHelper contructor
78 Sat Aug 20 11:04:50 2005 by jpr
80 FileHelper::Initialize() doesn't call GrabInformationFromFile(),
81 in order not to do the job twice when using new style FileHelper Constructor.
83 Fri Aug 19 18:31:07 2005 by malaterre
85 ENH: Provide a GetVersion function, apparently need for python
87 Fri Aug 19 15:12:15 2005 by jpr
89 Initialize UserFunction pointer to 0, even for 'deprecated' form
92 Sat Jul 30 20:27:00 2005 by jpr
93 gdcmFileHelper.cxx, gdcmPixelReadConvertor.cxx
94 User is now allowed to pass a Pointer to a function of his own
95 to allow modification of pixel order (i.e. : Mirror, TopDown, )
96 to gdcm::FileHeleper, using SetUserFunction(userSuppliedFunction)
97 described as : void userSuppliedFunction(uint8_t *im, gdcm::File *f);
98 NB : the "uint8_t *" type of first param is just for prototyping.
99 User will Cast it according what he founds with f->GetPixelType()
100 See ctkgdcmSerieViewer for an example
102 Sat Jul 30 20:13:24 2005 by jpr
104 Add SerieHelper::IsCoherent() method to allow checking that the files with same
105 Serie UID have the same sizes and pixel type.
107 Fri Jul 29 17:07:16 2005 by jpr
110 SetSortOrderToDirect() or SetSortOrderToReverse()
111 to choose the ways the File* will be sorted.
113 Thu Jul 21 06:55:50 2005 by jpr
114 AnonymizeDicomDir.cxx, AnomymizeNoLoad.cxx, PrintFile.cxx, PrintDicomDir.cxx
117 Thu Jul 21 06:55:30 2005 by jpr
119 Add an example of use for SerieHelper
121 Thu Jul 21 07:00:15 2005 by jpr
123 Extend 'Restriction' syntax :
124 void SerieHelper::AddRestriction(uint16_t group, uint16_t elem,
125 std::string const &value, int op)
127 /// \brief comparaison operators
137 Wed Jul 20 15:39:00 2005 by jpr
139 AnonymizeNoLoad user can now ask for anonymization of 'BinEntries'
140 (e.g. Private entries when the TS is Implict VR)
141 AnonymizeNoLoad filein=... rubout=0x0009-0x0001,0x0013-0x1100
142 Thx to Luca Picello for reporting pb and supplying data to fix the bug.
144 Wed Jul 20 16:49:41 2005 by jpr
146 Use GDCM_LEGACY for DicomDir, as well
148 Wed Jul 20 15:31:01 2005 by jpr
150 We can now anonymize 'BinEntries' as well
152 Wed Jul 20 15:29:42 2005 by jpr
154 Add ArgMgrGetXInt16Enum to decode from the command line pairs of unsigned int
155 16, written in hexadecimal.
156 (usefull to allow terminal user to pass the (private) elements he wants to
159 Tue Jul 19 17:25:53 2005 by jpr
161 Add some comments on the 'Patient Position'
163 Tue Jul 19 11:04:58 2005 by jpr
165 Add SerieHelper::AddGdcmFile(File *header) method.
166 * \brief add a gdcm::File to the first (and supposed to be unique) list
167 * of the gdcm::SerieHelper.
168 * \warning : this method should be used by aware users only!
169 * User is supposed to know the files he want to deal with
170 * and consider them they belong to the same Serie
171 * (even if their Serie UID is different)
172 * user will probabely OrderFileList() this list (actually, ordering
173 * user choosen gdm::File is the sole interest of this method)
174 * Moreover, using vtkGdcmReader::SetCoherentFileList() will avoid
175 * vtkGdcmReader parsing twice the same files.
176 * *no* coherence check is performed, but those specified
177 * by SerieHelper::AddRestriction()
179 Mon Jul 18 12:20:20 2005 by jpr
181 In order to prepare the future extension of SerieHelper::AddRestriction (key,
183 operator = { EQUAL, DIFFERENT, LESS, LESSOREQUAL, GREATER, GREATEROOREQUAL}
185 bool Util::CompareDicomString(const std::string &s1, const char *s2, int op)
187 Sun Jul 17 06:27:49 2005 by jpr
189 Use new style for Loading files
191 Tue Jul 12 19:08:12 2005 by jpr
192 gdcmCommon.cxx, gdcmSQItem.cxx
193 To speed up DicomDir, instead of copying -and removing the source afterwards-
194 each entry of the SQItem (found after gdcm::Document parsing) towards
195 the gdcm::Object belonging to the gdcm::DicomDir, we just copy
196 the chained list itself.
198 Tue Jul 12 16:55:43 2005 by jpr
200 AnonymizeNoLoad has now one more option :
202 to give the (single Patient) directory name whose content we want to anonymize.
204 Mon Jul 11 10:20:25 2005 by jpr
205 gdcmDicomDirStudy.cxx
208 Fri Jul 8 21:07:12 2005 by jpr
210 Add the VISIT object within DicomDir
212 Fri Jul 8 12:15:08 2005 by jpr
214 Use new style for DicomDir loading
216 Fri Jul 8 16:36:48 2005 by jpr
218 To remain unimpared, gdcm::FileHelper class needs also its
219 void FileHelper::SetLoadMode(int loadMode)
220 void FileHelper::SetFileName(std::string const &fileName)
221 bool FileHelper::Load()
223 Thu Jul 7 19:31:53 2005 by jpr
225 Begin of kosherization of Example
228 Thu Jul 7 18:37:40 2005 by jpr
230 On the way to gdcm2 ...
231 Now, the stand way to use a file is :
232 gdcm::File *f = new gdcm::File();
233 f->SetLoadMode ( user say here what he wants *not* to load );
234 f->SetFileName("myFile.gdcm");
236 Old styles are kept, not to break the C++ API.
237 - gdcm::File *f = new gdcm::File("myFile.gdcm");
238 - f->Load("myFile.gdcm");
239 Due to the syntaxic abilities of Python maybe some troubles will occur
242 Thu Jul 7 15:55:39 2005 by jpr
244 Comment out the time consuming, never used/useless
245 'Extended tag' stuff for Sequence embedded Entries
247 Thu Jul 7 15:11:38 2005 by jpr
249 Move code lines LTTG so save some CPU time.
252 Tue Jun 7 13:12:10 2005 CEST by jpr
254 Use Argument Manager in 'utilities'
256 Thu Jul 7 12:12:32 2005 by jpr
258 Due to something stupid in the gdcm::File constructor, the file was parsed
259 twice when we used old style, e.g :
260 gdcm::File *f = new gdcm::File(fileName);
261 instead of new style, e.g. :
262 gdcm::File *f = new gdcm::File( );
263 f->SetLoadMode ( choose what you want *not* to load here );
266 Wed Jul 6 11:53:43 2005 by jpr
267 TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx
268 Now TestAllReadCompareDicom.cxx TestReadWriteReadCompare.cxx accept a third
269 param, in order not to have to recompile to gdcm::Debug::DebugOn().
271 Wed Jul 6 17:18:42 2005 by jpr
273 According to Mathieu's requirement, Load twice the same file keeps the rseult of
274 the first Load (instead of doing it twice)
276 Wed Jul 6 11:25:12 2005 by jpr
278 - Clean out the Entries if a Document is parsed more than once
279 - Uncomment (usefull) warning messages
281 Wed Jul 6 10:42:33 2005 by jpr
283 - Comment out a for the moment too much verbose warning message.
284 - Delay some statement as late as possible, to save some CPU time when they're
287 Wed Jul 6 13:01:08 2005 by jpr
289 Now gdcmFile::Load() returns false if file is not gdcm parsable
290 Only gdcmDocument::Load() did it, before.
291 Thx to Benoit for reporting bug
293 Sun Jul 3 14:42:04 2005 by jpr
295 Should avoid some troubles with 'no length' SQItems within 'true length'
297 Thx to Loic Boussel for providing data to fix the bug.
299 Sun Jul 3 14:42:04 2005 by jpr
301 Should avoid some troubles with 'no length' SQItems within 'true length'
303 Thx to Loic Boussel for providing data to fix the bug.
305 Sun Jul 3 14:47:23 2005 by jpr
309 Fri Jul 1 13:25:51 2005 by jpr
310 gdcmPixelReadConvert.cxx
311 Initialize RLEInfo and JPEGInfo to 0 a avoid further problems
312 (e.g. PrintFile on a DICOMDIR document)
314 Thu Jun 30 16:49:02 2005 by jpr
316 Enhance gdcm::File::IsReable() heuristics to be able to process some Loic
317 Boussel's Hall of Shame Dicom images
319 Wed Jun 29 17:58:33 2005 by jpr
321 Add the NO_SHADOWSEQ load mode
323 2005-06-26 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
324 * Quite a few new dictionaries were added in gdcm. The file:
325 gdcm/Dict/README should always explain were the info was found
326 (in case of double check). Also some dict are still only
327 express as 'template' (they contain 'xx'), therefore
328 a python script should be run first to generate a full dict.
329 In the longer term this python script should be replaced by
332 2005-06-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
333 * dicomV3.dic is deprecated in favor of gdcm.dic
334 There is now a dictionary per family:
335 - dicomV3.dic -> DICOM V3
336 - Papyrus.dic -> Papyrus
337 - NIH.dic -> tags that were never allowed in the main standard
339 Fri Jun 24 12:50:20 2005 CEST by jpr
341 Pixel Spacing related problems : update comments.
342 Thx to D. Clunie for providing data to check the code
344 Fri Jun 24 12:55:58 2005 by jpr
345 Summer nights are really too hot to sleep.
346 Coding style : kosherization of all the 'if's (300 amongst 900 were haram)
348 Thu Jun 23 11:20:23 2005 by jpr
350 Extend warning message, for debugging purpose
352 Wed Jun 22 10:11:23 2005 by jpr
356 Wed Jun 22 10:00:29 2005 by jpr
357 gdcmPixelReadConvert.cxx
358 Fix misstyping, while removing spurious \t characters
360 Wed Jun 22 09:52:32 2005 by jpr
361 gdcmPixelReadConvert.cxx
362 Some constructors (at least one ...) use BitsAllocated =! BitsStored for
364 That break at lot of viewers ...
365 We now *propagate the sign bit* upon the unused ones, better than masking them
367 Thx to Luca Picello for profiding data to fix the bug
369 Wed Jun 22 09:53:52 2005 by jpr
371 gdcm images are now "GDCM 1.1" built.
373 Mon Jun 20 19:10:17 2005 by jpr
375 Avoid re writing Palette Color Lookup Table UID when Palette Color is removed
377 Mon Jun 20 17:58:53 2005 by jpr
379 Preventive bug fix for LUT Data.
380 I said : LUT Date, *not* Palette Color
382 Sun Jun 19 17:57:29 2005 by jpr
384 To avoid warnings at compile time
386 Fri Jun 17 14:27:52 2005 by jpr
390 Fri Jun 17 14:36:07 2005 by jpr
394 Fri Jun 17 14:35:00 2005 by jpr
396 Add some accessors for debugging purpose
398 Tue Jun 14 15:56:41 2005 by jpr
399 gdcmPixelReadConvert.cxx
400 Now gdcm deals with 16 bits per pixel images with 16 bits Palette colors
401 (3 * 65536 short int ...)
403 "Segmented Palettes" pb still pending, but I never saw any viewer dealing with it.
405 Mon Jun 13 17:43:48 2005 by jpr
406 gdcmPixelReadConvert.cxx
407 Some more oddities dealt with.
408 Doesn't work yet with 65536 entries 16 Bits LUT (?!?), with 16 bits pixels.
409 Still looking for accurate info on the web about it
411 Fri Jun 10 16:05:38 2005 by jpr
413 Bug fix in Load method.
414 Thx to Benoit for providing fix.
415 2005-06-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
416 * src/gdcmUtil.cxx : change call to Util::Format to sprintf because of
417 lantency with the Util::Format function
419 Tue Jun 7 15:48:35 2005 by jpr
421 The highy time consuming method GetMacAdress is now called just once
423 Tue Jun 7 11:58:29 2005 by jpr
424 gdcmDicomDirElement.cxx
425 Use TranslateToKey better than Format
427 Tue Jun 7 12:07:20 by jpr
429 Remove some spurious calls to Format
430 // according to 'Purify', TranslateToKey is one of the most
431 // time consuming methods.
432 // Let's try to shorten it !
434 Mon Jun 6 14:37:58 2005
435 class ArgMgr (for Arguments Manager) is designed for
436 command line arguments management
437 (to make programmer's live easier)
438 (could be used for any kind of 'command line program')
440 2005-06-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
441 * Adding users file in CVSROOT for mail blaming
443 2005-06-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
444 * Adding potential support for JPEG-LS DICOM files.
446 Fri Jun 3 18:05:23 2005 by jpr
448 Fix VR processing, to be CP-288 conform.
449 Now we can parse any kind of DICOM SR.
451 Fri Jun 3 11:05:15 2005 by jpr
455 Thu Jun 2 15:42:18 2005 by jpr
457 Add warning about Load Mode
459 Thu Jun 2 16:20:14 2005 by jpr
461 Harden gdcm::File::IsReadable(), in order not to be confused any longer
462 by lost of Pixel Element
464 Fri May 27 12:51:00 2005 by jpr
466 To avoid pushing out twice the meta elements, wile trying to write 'ACR-NEMA-
468 And avoid some memry leaks -hope so-
470 Wed May 25 14:54:17 2005 by jpr
472 Should avoid some memory leaks
474 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
475 * Adding potential support for mpeg and jpeg2000 through two new lin
476 - JasPer for JPEG2000
477 - libmpeg2 from the MPEG consortium
478 Also adding intial work to use this lib.
480 Fri May 20 10:27:55 2005 by jpr
483 (this time, it's wasn't dangerous at run time)
485 Thu May 19 17:31:21 2005 by jpr
487 FIX possible troubles when checking
488 'Hight Bit Position' vs 'Bits Allocated' and 'Bits Stored'
489 Thx to Mathieu for reporting bug
491 Wed May 18 12:12:07 2005 by jpr
493 Fix : now dcm deals with 'No preamble', Big Endian Explicit VR group 0002.
494 Thx to Dennis Hu for providing a sample image to fix the bug.
496 Tue May 17 14:44:09 2005 by jpr
498 ENH : According to David Clunie's advice, we check now 'Imager Pixel Spacing'
499 before 'Pixel Spacing', when we want to get X or Y Spacing.
501 Tue May 17 19:10:49 2005 by jpr
503 ENH : Now, FileHelper::CheckMandatoryElements() makes some consistency checking,
504 at LTTG (Least Time To Go)
505 around Bits Allocated, Bits Stored, High Bit Position,
506 to avoid unaware user to mess up the stuff.
508 Tue May 3 11:43:04 2005 by jpr
510 Load returns now a bool (allow user not to call IsReadable() )
512 Tue May 3 11:51:06 2005by jpr
514 Now the gdcm::File remains unimpaired after writting, in any case
516 Fri Apr 29 17:10:55 2005by jpr
518 Don't abort the prog when File not open
520 Wed Apr 27 12:00:35 2005 by jpr
522 Removal of now useless lut-related stuff
524 Wed Apr 27 11:52:27 2005 by jpr
526 Pb of 'Bits Allocated = 12' is now dealt with in
527 FileHelper::CheckMandatoryElements, no longer in File::Write.
528 Thx to Mathieu for reporting bug.
530 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
531 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
534 Tue Apr 26 18:18:23 2005 by jpr
536 Should leave gdcm::Document constructor in a much quicker
537 and much cleaner way when anything wrong occurs.
539 Tue Apr 26 18:25:49 2005 by jpr
540 gdcmPixelReadConvert.cxx
541 Prepare MPEG Dicom encapsulated processing (within a loooong future)
543 Fri Apr 22 14:59:58 2005 by jpr
545 Modify Print() output
547 Fri Apr 22 15:37:57 2005 by jpr
549 Prepare (future) MPEG integration
551 Thu Apr 21 09:40:00 2005 by jpr
553 Taking into account Dicom MPEG
555 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
556 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
557 But this is a case where we should really signify the user there is
558 few chance the serie is really a serie...
560 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
561 * FIX : on X, the python part is correctly installed. All files are
562 installed in gdcm sub-directory
564 Tue Apr 19 11:58:19 2005 by jpr
566 Should suppress some warnings from Borland compiler
568 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
569 * Builder/ : add something to facilitate the RPM creation of gdcm
571 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
572 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
574 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
576 Thu Apr 14 16:26:19 2005 by jpr
578 Now, user can ask gdcm::DicomDir to skip SeqEntries or shadow groups, when
580 // Old style (still available) :
581 dcmdir = new gdcm::DicomDir(dirName, true);
583 // new style (user is allowed no to load Sequences an/or Shadow Groups)
584 dcmdir = new gdcm::DicomDir( );
585 dcmdir->SetParseDir(true);
586 dcmdir->SetLoadMode(NO_SEQ | NO_SHADOW);
587 dcmdir->Load(dirName);
589 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
590 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
592 * Fix compilation on gcc 2.96 (which does not have ios::failure)
594 Mon Apr 4 17:15:24 2005 by jpr
596 Fix stupid bug when writting ACR-NEMA image from 'ACR-LibIDO' one.
598 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
599 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
600 and it's representation name (for the NIH)
602 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
603 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
604 conversion of YBR to RGB pixels. So, now, the conversion is made using
607 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
608 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
609 format) to replace 'at-run' dicom files generated by the
610 TestAllReadCompareDicom test
612 Tue Mar 22 12:29:37 2005 by jpr
614 * FIX : element 0x0000 of shadow groups is now force to a ValEntry,
615 and it's VR is forced to UL
616 * ENH : user id now allowed to tell he doesn't want to deal with Sequences
617 and/or with Shadow groups
618 use SetLoadMode (NO_SEQ | NO-SHADOW);
620 Tue Mar 22 12:40:13 2005 by jpr
622 *FIX Restore pushed out elements
624 Fri Mar 11 12:08:31 2005 by jpr
626 Remove spurious #define MAX_SIZE_PRINT_ELEMENT_VALUE
628 Fri Mar 11 12:12:13 2005 by jpr
630 Final removal of gdcmFileHelper::InitializeDefaultFile();
632 Wed Mar 9 20:29:38 2005 by jpr
634 Add Anonymize method (not yet fully checked)
636 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
637 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
639 Wed Mar 2 18:18:32 2005by jpr
641 Fix gdcm::FileHelper::CheckMandatoryElements() to take into account David
644 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
647 Mon Feb 21 18:45:41 2005 by jpr
649 * Replace method CheckMetaElements by CheckManadatoryElements
650 To deal with the pb of UID's, and with Type 1 an Type 2 Entries
651 (probabely some stuff still missing)
652 * We shall have to decide the way we proceed to allow user 'freeze' Serie UID
653 between a given call and the next one (to add images to a Serie he just
655 * We shall have to decide the way we proceed to allow user 'freeze' Study UID
656 between a given call and the next one, or to reuse an already existing
657 Study UID (i he wants to add his own Series to an already existing Study)
659 Thu Feb 17 17:18:33 2005 by jpr
661 To avoid further pb, Initialize defaults now Photochromatic Interpretation to
662 MONOCHROME2 (low values = dark), better than MONOCHRONE1.
663 Thx to Benoit for reporting bug
665 Thu Feb 17 11:56:20 2005 by jpr
667 Prepare FileMetaInformationVersion (group 0002) management
669 Thu Feb 17 12:02:47 2005 by jpr
671 Group 0002 management
673 Thu Feb 17 12:03:32 2005 by jpr
674 gdcmDocEntryArchive.cxx
677 Wed Feb 16 11:19:19 2005 CET by jpr
678 gdcmPixelReadConvert.cxx
679 Taking into account MONOCHROME1 + Signed Pixels (?!)
681 Tue Feb 15 19:12:34 2005 by jpr
683 Taking into account the difference between MONOCHROME1 (low values = bright)
684 and MONOCHROME2 (low values = dark)
686 Mon Feb 14 11:45:04 2005by jpr
688 Remove some useless mask operations, to save CPU time
690 Mon Feb 14 15:51:10 2005 by jpr
692 *never* forget to re-compile just *before* committing!
694 Mon Feb 14 15:34:27 2005 by jpr
696 First commit on the post 1.0 (Version? / Tag? / Branch?) :
699 Mon Feb 14 11:45:47 2005 by jpr
701 remove useless comments
703 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
704 * Testing/TestMAkeIcon.cxx : complete the test
706 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
707 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memory leaks
709 Fri Feb 11 16:22:18 2005 by jpr
711 Typo, comments, doxygenation
713 Thu Feb 10 11:55:26 2005 by jpr
715 AnonymizeNoLoad improvement
717 Thu Feb 10 10:07:19 2005 by jpr
719 Duplicate Matthieu's hack to prevent bombing in Anonymize
721 Thu Feb 10 12:20:34 2005by jpr
723 The following gdcm::DocEntrySet methods, no re-definable is child classes are no
725 virtual ValEntry *GetValEntry(uint16_t group, uint16_t elem);
726 virtual BinEntry *GetBinEntry(uint16_t group, uint16_t elem);
727 virtual SeqEntry *GetSeqEntry(uint16_t group, uint16_t elem);
728 virtual bool SetValEntry(std::string const &content,
729 virtual bool SetBinEntry(uint8_t *content, int lgth,
730 virtual bool SetValEntry(std::string const &content, ValEntry *entry);
731 virtual bool SetBinEntry(uint8_t *content, int lgth, BinEntry *entry);
732 virtual ValEntry *InsertValEntry(std::string const &value,
733 virtual BinEntry *InsertBinEntry(uint8_t *binArea, int lgth,
734 virtual SeqEntry *InsertSeqEntry(uint16_t group, uint16_t elem);
736 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
737 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
740 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
741 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
743 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
744 * Test/ : accelerate tests (it's not very significant accelerations).
745 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
747 Mon Feb 7 15:48:34 2005 by jpr
749 Add some commented out lines to prepare future version of 'Full DICOMDIR' stuff
752 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
753 * Testing/TestSequence.cxx : add test for sequences of images... test that
754 we have the same serie or the same study UID
756 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
757 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
759 * src/gdcmDict.h : remove commented code
760 * src/gdcmDocument.cxx : initialize values
761 * src/gdcmFile.cxx : bug fix when reading values
762 * gdcmPython/demo/ : change file names. Remove useless files
764 Sun Feb 6 15:31:09 2005 by jpr
766 Update comments for DicomDir stuff
768 Sun Feb 6 15:39:35 2005 by jpr
770 * Add method File::AnonymizeNoLoad, to allow anomymizing files
771 even when the pixels are not gdcm Readable
772 * Add methods File::AddAnonymizeElement and File::ClearAnonymizeList
773 to allow user to choose the elements whose value
774 he wants to white out / replace
776 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
777 * src/gdcmFile.cxx : remove the default array of initialization.
778 The static array contained pointers to non-static values (comming from
779 strings). To have coherences, when creating files, these values can't be
780 static. So, the array can't be static, too ! To simplify, the array have
781 been replaced by repeted lines to insert values in the File
783 Fri Feb 4 15:49:01 2005 by jpr
785 * Add GetFirstValEntry + GetNextValEntry, for Python users
786 * Some more Doxygenation + typo fixing
788 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
789 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
790 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
792 Thu Feb 3 18:12:46 2005 by jpr
793 gdcmPixelReadConvert.cxx
796 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
797 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
798 (Dicom Element) into the Sequence Item
800 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
801 * src/*.cxx : first parss to normalize file organisation
803 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
804 * src/gdcmDirList.[h|cxx] : add method to find a directory
805 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
807 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
808 * Finish cleaning up my JPEG mess. Should be ok now.
809 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
810 contained within the RLE* class(doh!)
812 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
813 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
814 * SerieHeader::AddFileName() creates as many Coherent Files lists
815 (same Serie UID) as it founds different Serie UID
816 amongst the files instead of discarting any file
817 that doesn't match with the first one he found.
818 * SerieHeader::OrderGdcmFileList has now one parameter :
819 the Coherent Files list the user wants to sort
820 * SerieHeader::GetFirstCoherentFileList() |
821 * SerieHeader::GetLastCoherentFileList() | allow to parse
822 the set of Coherent Files lists
823 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
824 compatibility (it returns the *first* Coherent Files list,
825 since there was only one before)
826 * Test/TestSerieHeader gets gdcmData as a default root directory
828 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
829 * Remove friend between DocEntry and File classes
830 * Remove friend between PixelReadConverter and RLEFramesInfo,
833 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
834 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
835 0002|0000. The value was incorrect.
837 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
838 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
840 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
841 * src/gdcmUtil.cxx : compilation fix on Win32
842 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
843 variable, to be easy found. Add methods to change the default UID.
844 Amelioration of the CreateUniqueUID to use the correct default UID.
845 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
848 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
849 * Test/TestVR.cxx : fix memory leaks
851 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
852 * Rewrite the base 256 to base 10 conversion, using string operation only.
853 This allows us to get rid of the problematic 64bits integer type (does not
854 always exist on target platform).
856 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
857 * Add construct and destructor to class gdcm::Debug to close the debug file
859 * Don't let uset to open twice the same file
860 * gdcm has now an official UID prefix,
861 supplied by http://www.medicalconnections.co.uk
862 1.2.826.0.1.3680043.2.1143
863 (Thx to Mathieu for providing URL)
864 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
865 to be able to perform some more tests
866 * gdcm::ContentEntry : Contructors and Destructor are now protected,
867 in order to be sure no user will try to use them.
868 (at user level, only the children classes are meaningfull)
870 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
871 * move RLEInfo & JPEGInfo from Document to File
873 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
874 * FIX : remove so many friend between classes
876 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
877 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
878 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
880 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
881 In order to avoid missbehaviour :
882 . gdcm::DocEntry is now specialized in
883 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
884 - gdcm::ContentEntry (Dicom entry with a 'content')
885 . gdcm::ContentEntry is specialized in
886 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
887 characters value, or integers)
888 - gdcm::BinEntry (Dicom entry with a non strig representable value
889 (user hasn't any longer to thing about the precedence of his dynamic_casts)
891 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
892 * Test/VTKTest*.cxx : bug fix under linux
894 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
895 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
896 use with python. Some methods are moved from Document to ElementSet or
897 DocEntrySet. The equivalent methods to ElementSet have been added to
898 SQItem and are virtual in DocEntrySet. Methods that may have the same code
899 in SQItem and ElementSet is directly placed in DocEntrySet
901 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
902 * Test/VTKTest*.cxx : remove the show variable in each test method because
903 it's useless (the viewer variable replace this variable)
905 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
906 * src/gdcmDocument.cxx : bug fix on potential memory leak
907 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
908 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
909 Add ClearXxx methods to remove all the content of the list or map
910 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
912 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
913 * methods ReplaceOrCreate renamed as Insert
914 (nobody will be any longer confused by 'CreateOrReplace')
916 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
917 * Grealty simplify the JPEg decompression, no need to differenciate based on
918 the JPEG possible type (with/without fragment, with/without multiple frame).
919 Everything is done throught the JPEG IO Suspension mechanism in IJG
921 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
922 * Stage 3 of normalization :
923 in order to avoid any missunderstanding while reading method names :
924 - All the methods xxxEntry now deal with dicom Entries
925 - Methods GetEntry splitted into
928 - Method SetEntry renamed as SetEntryValue
929 - Method SetEntryBinArea let as it was
931 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
932 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
933 - Position correctly the entry points for JPEG2000 and JPEG-LS
934 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
936 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
937 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
938 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
939 with other method names
940 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
941 * Test/TestDicomDirElement.cxx : add new test
943 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
944 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
945 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
946 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
947 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
948 So can't you use __int64 in ostream at all.
950 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
951 * bug fix for compilation on MSVC6
952 * gdcmPython/gdcm.i : rename of classes missed
954 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
955 * Stage 2 of names normalization :
956 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
957 (easy to understand ...)
958 - gdcm::FileHelper replaces old class gdcm::File
960 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
961 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
962 type and not a string. So, there remove problems on the format of the
965 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
966 * Add Example/TestPapyrus.cxx
967 - reads a Papyrus file (gdcm::Header compliant),
968 - gets the pixels of all the images, using low level iterators
969 - writes an multiframes Dicom image.
970 (Just to show it's *possible* to do that)
971 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
974 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
975 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
976 Thus, DicomDirXXX are created with a flad that indicates if the created
977 object is empty or not (when not empty, the DicomDirElement is used to
980 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
981 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
982 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
984 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
985 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
987 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
988 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
989 Remove all access to the hash-tables or lists in the objects.
991 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
992 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
993 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
994 be complient with all the gdcm source code
996 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
997 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
1000 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1001 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
1004 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1005 * Test/ : rename VTK tests to have a best name for the tests
1006 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
1007 GetFirstEntry/GetNextEntry use
1009 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1010 * In SerieHeader::ImagePositionPatientOrdering()
1011 // a Dicom 'Serie' may contain scout views
1012 // and images may have differents directions.
1013 // -> More than one may have the same 'pos'
1014 // Sorting has then NO meaning !
1015 Thx to Eduardo Davila for reporting bug.
1017 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1018 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
1019 test. Now it's on image content and not on the resulting visualisation...
1020 might solve the problem on linux when using the OpenGL drivers
1022 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1023 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
1024 DicomDirSerie, DicomDirImage
1025 Dict, DictSet classes :
1026 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
1027 -remove InitTraversal method.
1028 * UPD Test programs + Example programs
1030 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1031 * remove useless and never updated keyword \ingroup
1032 * Solve pb when structure (list, map, ...) is empty.
1033 Thx to Benoit for reporting bug
1035 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1036 * Taking into account of 'Transfer Syntax' value
1037 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
1040 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1041 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
1042 is no memory access violation
1043 * gdcmPython/demo : add python demos using VTK
1045 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1046 * FIX 'Dictionnary' is now spelt 'Dictionary'
1047 'wether' is now spelt 'whether'
1048 'archieve' is now spelt 'archive' ;-)
1050 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1051 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
1052 related methods, in order not to expose internal mechanisms
1055 * REM methods that exposed internal mechanisms :
1056 DicomDir::GetDicomDirPatients()
1057 DicomDirPatient::GetDicomDirStudies()
1058 DicomDirStudy::GetDicomDirSeries()
1059 DicomDirSerie::GetDicomDirImages()
1060 * UPD Test programs :
1064 * UPD Example program
1066 * ADD DictSet methods
1070 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1071 * Removed the Print/indent/default parameter mess. There is absolutely no
1072 reason to have to methods, moreover with the second taking the ostream as
1073 *SECOND* parameter. This was clearly a bad hack to get things compile.
1075 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1076 * Complete rewrite of the GetMacAddress code. Now the code is *much*
1077 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
1078 Unfortunately the main code does not work on SunOS, thus provide a specific
1079 code for this platform only (and Win32 of course). Since this seems to be
1080 working, change CreateUniqueUID to use GetMACAddress instead of the
1081 problematic GctestetIPAddress
1083 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1084 * Unfortunately to be able to test gdcmDirList I had to break the API
1085 a little. Now the class is not a std::list anymore but has a member
1086 std::vector (more ITK compatible). Allow unit testing on Win32 and
1089 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1090 * Update SerieHeader to take into account a Serie Instance UID to properly
1093 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1094 * ENH - Comment out Mathieu's (dangerous) Super Hack
1095 for dealing with BIGENDIAN processors
1096 - Move equivalent stuff to BinEntry::WriteContent
1097 When necessary, 16 Bits Pixels are swapped in a small buffer
1098 and then written. This avoid allocating a huge buffer, in
1099 PixelWriteConvertor, and avoid modifying the Pixel Area.
1101 Probabely, the same operation will have to be done when we want
1102 to write image with Big Endian Transfert Syntax,
1103 and we are working on Little Endian Processor
1105 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1106 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
1108 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
1109 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
1110 all the dict content.
1111 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
1113 * Test/TestDict.cxx : add a new test for the dict classes
1115 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1116 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
1117 file. Debug is yanked if compiled with NDEBUG
1119 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1120 * src/gdcmDictSet.h : set the default output to the os variable
1121 * src/gdcmDictEntry.[h|cxx] : add the Print method
1122 * gdcmPython/demo/ : add a new test
1124 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1125 * merging of Test/PrintDicomDir and Test/TestDicomDir
1126 * removal of now redundant Test/PrintDicomDir
1127 * enhancement of Example/PrintDicomDir
1129 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1130 * Now, python test might work on systems
1131 * Add the PrintDicomDir test
1133 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1134 * FIX : First entry following group 0002 was lost for
1135 Explicit Big Endian Transfer Syntax files
1136 (group and elem not swaped)
1138 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1139 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
1140 Big Endian Transfer Syntax supposed the group following 0002
1141 begins always by element 0000 (element 0000 is *optional*)
1142 To avoid further troubles, let's be pessimistic, and use
1143 Document::HandleOutOfGroup0002() method
1144 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
1145 (related pb not yet solved)
1147 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1148 * Bug fix for the python part use
1149 * Now, PrintHeader.py pass... but outside the ctest use. shit !
1151 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1152 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
1154 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1155 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
1156 a string and should ask the global TS dict what are the propreties of
1159 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1160 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
1161 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
1162 to swap the Swap Code, at parsing time, when we come out of group 0002
1163 and Transfer Syntax is Big Endian
1164 We should be able to read now 'true DICOM" Big Endian coded images
1165 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
1166 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
1168 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1169 * Hopefully fix the bug on MacOSX and static global initialization.
1170 This is the only -minor- patch I found that both please MacOSX and VS6.
1171 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
1172 but this would require a lot of change. Another approach would be that Global
1173 create those string and GDCM_UNFOUND becomes a pointer to a string (which
1174 gdcm::Global would destroy at exit).
1176 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1177 * Fix bug on MacOSX with static initialization in a multy threaded
1178 environment. static const string in a header file used to be ill
1179 initialized provoquing the freeze of any tests. patch should solve this
1182 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1183 * According to Benoit's suggestion, and without any objection from anybody
1184 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
1185 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
1186 - method gdcmDicomDirObject::GetEntry() renamed as
1187 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
1189 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1190 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
1191 you debug/warning message just as c++ streams which make them very convinient
1192 to use. Once this is stabilize I will change the ostringstrem to be
1193 redirected to a file (ofstream).
1194 * Properly support C99 extension: __FUNCTION__ which allow us to display
1195 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
1197 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1198 * Removal of useless and dangerous methods :
1199 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
1200 GetDocEntryByName, GetEntryByName, GetDictEntryByName
1201 * Removal of usless methods :
1202 Dict::PrintByName, Dict::GetDictEntryByName
1203 * Commenting out of probabely useless methods :
1204 Dict::GetDictEntryNames()
1205 Dict::GetDictEntryNamesByCategory()
1206 DictSet::GetPubDictEntryNames()
1207 DictSet::GetPubDictEntryNamesByCategory()
1208 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
1209 * ENH : Use dicomTS.dic as described in 2004 version
1210 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
1211 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
1212 Add Accessors on VM (Value Multiplicity), and VM related methods
1213 * ADD : Add a list of 'Dicom Attribute types', as found in
1214 http://medical.nema.org/dicom/2004/04_15PU.PDF
1216 * ADD : Add dicomGroupNameAbbreviations.dic
1217 should be used to write a method to replace the former
1218 Dict::GetDictEntryNamesByCategory()
1220 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1221 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
1222 to read in the file... and only it ! Length is the efective length of the
1223 data in the DocEntry structure
1225 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1226 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
1227 And now use a static function call instead, with a global variable. i
1228 This is much closer to the VTK approach. Hopefully should be bulletproof
1229 and easier to use...hopefully
1231 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1232 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
1234 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1235 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
1237 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1238 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
1239 ValEntry, BinEntry, SeqEntry creation or replace
1241 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1242 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
1243 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
1245 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
1246 when specifying the VR
1247 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
1248 * src/gdcmDocEntry.cxx : amelioration of print
1250 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1251 * ADD : Add the method Util::IsCurrentProcessorBigEndian
1252 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
1253 * ADD Method Document::ComputeGroupLength
1254 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
1255 in order to allow further VR modification by user
1256 * REM : removal of once-called method File::WriteBase
1257 integration of its code in formerly one-line method File::Write
1259 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1260 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
1261 replace the different values "??", "Unkn", "Unknown".
1262 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
1263 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
1264 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
1265 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
1267 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1268 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
1270 * Set the gdcm::Base class to some Printable classes
1272 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1273 * src/gdcmFile.[h|cxx] : add the Print method
1274 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
1275 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
1276 * src/gdcmDocument.h : remove the PrintLevel informations
1277 * Example/PrintFile.cxx : use the new gdcm::File::Print
1279 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1280 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
1281 problems when compiling with the python wrapping
1283 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1284 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
1285 writting in ImplicitVR
1287 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
1288 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
1289 JPEG decompression, especially when dicom frames are split into several
1290 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
1291 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
1293 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1294 * src/gdcmHeader.cxx : change the initialisation of default header.
1295 Now, this header is readable by gdm, e-film, DicomWorks
1297 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1298 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
1299 Rename Decompressed to Raw
1300 * Use the API changes in gdcm::File.
1301 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
1304 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1305 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
1306 each added entry in the header. Replace the 'Planes' field by the 'Number
1309 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1310 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
1311 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
1313 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1314 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
1315 At this time, this image isn't readable by e-film... waiting JPR help to
1318 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1319 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
1320 DocEntry. Now use methods of the Document !
1322 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1323 * Test/ShowDicomSeq.cxx : bug fix
1325 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1326 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
1327 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
1328 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
1329 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
1331 * Test/TestCopyRescaleDicom.cxx : remove unused variable
1332 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
1333 containing found sequences
1335 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1336 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
1338 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
1339 Some fields in BinEntry must be copied to not seg fault when making the :
1340 gdcm::File *copy = new gdcm::File( copyH );
1341 and tests are now made on good variables
1343 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1344 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
1345 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
1347 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
1348 * Add vtkGdcmWriter example and test
1350 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1351 * Test/TestUtil.cxx : reformat the source code
1352 * vtk/vtkGdcmReader.cxx : remove and change prints
1353 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
1355 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
1356 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
1358 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1359 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
1360 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
1362 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1363 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
1364 by an eof to prevent all bad read of the file... and in this case, the
1365 file isn't readable.
1367 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1368 * Example/Volume2Dicom.cxx : comment unused variables
1369 * Test/PrintDicomDir.cxx : comment unused variables
1370 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
1371 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
1372 method that is redondant with AddEntry.
1373 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
1376 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1377 * Bug fix due my last commit (compilation under Windows).
1378 * Example/Volume2Dicom : bug fix in the file and reformatting source code
1379 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
1381 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1383 - Remove printf / sprintf
1384 - include iostream AFTER gdcm so we don't get warnings
1385 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
1387 - Also remove tons of include from header files, hopefully this should
1388 speeup the compilation time, since it was becoming a dog slow.
1389 - Remove gdcm.h as it include way too many files and slow down compilation
1390 (plus it is not up to date)
1391 - remove 'using namespace std' this is BAD !
1393 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1394 * Remove memory leaks on the DicomDir
1395 * Remove some useless data in DicomDirObject
1396 * Add usefull methods in SQItem, to be complient withe the ElementSet
1398 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1399 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
1401 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1402 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
1403 future, with convertion)
1404 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
1405 and ImageDataSize values. Remove the method to get the PixelReadConverter
1406 from the output of the class
1408 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1409 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
1411 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1412 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
1413 and vtkErrorMacro use.
1414 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
1416 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1417 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
1419 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
1420 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
1421 The string leaves only in the fonction. So when we make a .c_str(), we
1422 get the pointeur on the first element, element that will be destroyed
1423 immediately after thee instruction.
1424 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
1425 file has been opened : the test must be made on the content of the
1426 pointer and not directly on the pointer !
1429 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1430 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
1431 the python part recompiles
1433 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1434 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
1435 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
1436 X session is killed (for my computer... it seems to not be identic on
1439 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1440 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
1441 avoid problems (otherwise, the difference test between the visible image
1442 and the reference is incorrect. If the reference is greater than the
1443 screen resolution, it's produce errors).
1444 Can be used for only one image. Can be used with a visible flag.
1445 * vtk/vtkGdcmReader.cxx : remove commented codes.
1446 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
1447 under windows at compilation
1448 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
1449 for grayscale images
1450 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
1452 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1453 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
1454 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
1455 tests on the image size X, Y, Z
1457 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1458 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
1459 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
1460 between the class name and the file name
1462 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1463 * src/ : fix compilation warnings for the Write method (2 different
1464 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
1465 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
1466 variable... create a static method in gdcm::Document to access to
1467 this variable content.
1469 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1470 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
1471 file, to be accessed by other files (like gdcmFile). Remove commented
1472 code. Move the change of the header to the gdcmFile, using the
1474 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
1475 To be sure of that (and simplify calls), the Write of the header now
1476 gets a file name and not a file pointer (std::ifstream).
1477 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
1478 DocEntryArchive. Remove all open of the written file
1480 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1481 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
1483 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1484 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
1485 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
1487 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
1488 some corresponding methods. Write correctly the file and check before
1490 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
1491 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
1492 is now on RGB data (as before my last commit
1493 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
1495 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1496 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
1497 Add a print information of the type of the entry
1498 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
1499 It was in the gdcmFile, and all write have been regrouped
1500 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
1501 Write correctly all dicom files (in decompressed mode only at this time)
1502 * Test/ : test on files are now made using Raw data and not color data if
1504 * Example/PrintFile.cxx : add more printings
1506 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1507 * Amelioration of code, remove some code copy. For the loading of
1508 BinEntry (in gdcmDocument), add the test to verify if the file is already
1511 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1512 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
1513 remove a DocEntry in the header (push an empty DocEntry)
1514 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
1515 lines. Bug fix in the initialization of the PixelConvert and the
1517 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
1518 use in TestCopyDicom (now this test can run under windows... but fails)
1519 * Test/TestCopyDicom.cxx : amelioration of the test :
1520 - test the pixels written
1521 - add test points to quickly find where is the error
1522 - can set a file name input and output in arguments
1523 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
1524 amelioration of the test output
1526 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1527 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
1528 all replaced DocEntry's
1529 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
1530 Now, each needed DocEntry to modify is duplicated, modified and inserted
1531 to the header using DocEntryArchive. Thus, after save, we can restore the
1532 header initial state.
1534 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1535 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
1537 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1538 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
1539 correct to copy it. The DictEntry is specified at the DocEntry creation,
1540 then, it musn't change in the time.
1541 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
1542 header correctly. At this time, the change is only made for the first
1543 level of the Document. In the future, it might consider sequences.
1544 The change is made by replacing a DocEntry by an other that is created
1545 outside the class. The old value is kept. When we restore the header
1546 status, the added DocEntry is deleted and replaced by the old value.
1547 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
1548 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
1549 set the write type to explicit VR, implicit VR or ACR. Add methods to set
1550 the write mode to native, decompressed or RGB (but not used at this time)
1552 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1553 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
1554 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
1556 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1557 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
1558 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
1560 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
1561 set because already copied when copying the BinEntry's of the header
1562 * Test/TestAllReadCompareDicom.cxx : remove warnings
1564 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1565 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
1566 Two problems appear when doing it :
1567 - with the gdcmFile : when the GetImageData method is called, the pixels
1568 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
1569 data (pixels). And each structure destruct the data when it's
1570 destructed. So we have two destructions for the same data. To solve it,
1571 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
1572 data or not. If it doesn't own data, then they will not destroyed by
1574 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
1575 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
1576 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
1577 create a double destruction of the same DocEntry's. So, to solve it,
1578 the TagHT is simply cleared and the DicomDir* elements are destroyed.
1579 * TODO : add an entry concerning memory leaks in the DicomDir
1581 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1582 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
1583 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
1586 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1587 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
1588 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
1589 after it have been deleted
1591 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1592 * FIX: src/* fix the doxygen warnings.
1593 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
1594 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
1595 was erroneously defined with a size of 15 instead of 16. [many thanks
1596 to Jean Michel Rouet for pointing out this bug].
1598 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1599 1. Finish merging JMR patch for writting DICOM from scratch
1600 2. Fix -hopefully- bug with MONOCHROME and space vs null character
1601 3. Use const ref when possible
1602 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
1603 5. A few more comments
1604 6. CreateUniqueUID can now be called without parameter"
1606 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1607 * ENH: Slightly bigger patch:
1608 1. Getting toward full integration of JMR patch for writting dicom from scratch
1609 2. Update Test to test part of this patch: CreateUniqueUID
1610 3. File was not close properly in gdcmDict
1611 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
1612 5. Use of const ref instead of copy (speed issue)
1613 6. Remove temporary (duplicate) string in TranslateToKey
1614 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
1615 8. Do not repeat virtual in subclasses
1616 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
1618 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1619 * Apply first patch toward better string comparison when dealing with broken
1620 DICOM files. Essentially the string could be padded with a space instead
1621 of a null character as defined by standard
1623 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1624 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
1625 because never used... and in the same time, that's remove some memory leaks
1627 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1628 * src/gdcmFile.cxx : now delete the PixelConvert instance.
1629 * In examples and tests : change the type of image data variables from void*
1630 to uint8_t*. Remmove all delete on image data variables
1632 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1633 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
1634 Verify the file pointer value before open the file, and if it's not null,
1635 a verbose message is generated.
1636 Close correctly the file when the file isn't considered dicom-like. The
1637 correctly close is a call to CloseFile.
1638 When closing the file pointer, test if its not null to close the file.
1639 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
1640 file. For an uncompressed image, the copied data correspond in the least
1641 case to the image size (calculated) or the image size specified in the
1642 header. A verbose is generated if these two size mismatch
1644 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1645 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
1646 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
1647 break under windows (with msvc6 compilation).
1649 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1650 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
1651 compiling with MSVC6)
1653 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1654 * Bugs fix for the Windows build with VC6
1655 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
1656 needed (only for projects required VTK). If the VTK is included in all
1657 projects, there is conflicts with the jpeg lib of vtk when compiling the
1658 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
1659 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
1660 when compiling the gdcm_wrap.cxx file (created by the compilation of the
1662 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
1663 (like it's already made for the cout use). Otherwise, conflict with the
1666 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1667 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
1668 * gdcmPython/gdcm.i:
1669 - comments on the DicomDir::Method related usage added.
1670 - now that we use the namespace gdcm, a lot of internal classes do
1671 NOT need to be wrapped anymore.
1672 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
1673 DicomDir::Method) new example added.
1675 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1676 * Improve string manipulation. I now inforce the notion of 'DicomString'
1677 A DicomString can contain as many \0 as they want
1678 and it is *always* of even length.
1679 We only support odd length for very rare case.
1680 And in the near future this should be removed.
1682 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1683 * /binary_write/ gdcm source. Now even on big endian we are writting
1684 little endian. This should -heopfully- fix some tests
1686 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1687 * Now the dictionary is compiled into gdcm lib. This is a default
1688 behavior, thus any dic file specified is picked before failback to
1689 the one comiled into lib
1691 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1692 * Change internals for gdcmDict. Don't use any 'new' any more.
1693 This should definitely solve any leak problem, and we should be
1694 as fast as before, as long as don't modify too much the dictionary.
1696 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1697 * STYLE: ivars should start with a capital letter.
1698 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
1699 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
1701 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1702 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1703 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1704 new 2004 dictionaries added (thanks to JPR).
1705 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1706 * CLEANUP_ROUND (15) for gdcmPixelConvert
1707 - RLEFrame::NumberFragments is now of type unsigned int
1708 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1709 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1712 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1713 * Initial work in gathering all transfer syntax accessors. clearly
1714 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1715 ivars, but only one transfersyntax (class) ivar with equivalent method on
1718 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1719 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1720 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1721 discussed (plus I didn't like having a 2000 lines patch not commited)
1723 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1724 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1725 * CLEANUP_ROUND (14) for gdcmPixelConvert
1726 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1727 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1728 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1729 CloseFile() anymore.
1730 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1731 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1732 into File::Pixel_Data.
1734 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1735 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1736 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1737 * CLEANUP_ROUND (13) for gdcmPixelConvert
1738 Substituted File::ParsePixelData() with PixelConvert::Print() new
1740 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1741 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1742 method to those classes.
1743 - src/gdcmFile.[cxx|h]:
1744 -- Added a ::Print() method.
1745 -- PixelConverter is now a reference instead of a member.
1746 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1747 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1749 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1750 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1751 collaboration diagram and inheritance diagram should be generated with
1753 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1754 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1755 pointlessly wrapped (see
1756 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1757 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1758 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1759 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1760 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1761 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1762 -- File::Initialise: PixelConverter setup moved away to
1763 PixelConverter::GrabInformationsFromHeader()
1764 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1765 interpretation moved away to PixelConverter::BuildRGBImage()
1767 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1768 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1769 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1771 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1772 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1773 displayed on Win32 when a brutal abort() occurs (because of uncatched
1774 exception). See TODO new entry of this commit for more on this.
1775 * TODO added new entry.
1776 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1777 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1778 - HandleColor is no longer called from gdcmFile.cxx
1779 - gdcmPixelConvert.cxx clean up on method arguments and internal
1780 variable names for semantical coherence.
1782 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1783 * Finished lossless transition, not only do we now read all lossless jpeg
1784 images, without the need of the Cornwell lib, but we do read them properly now
1785 * To reduce code (well to avoid code duplication), I defined a common place
1786 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1787 redefine symbols. This is not perfect but this the best solution I found for a
1788 compilation time jpeg option.
1790 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1791 * Update jpeg ijg lib to support lossless jpeg implementation
1792 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1794 * Also added a special copyright for dcmtk since we use their bugfixes.
1797 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1798 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1799 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1800 matters, as stated in warning note at beginning of %include section).
1801 * src/gdcmDicomDir*.[cxx|h]: coding style
1802 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1803 * src/gdcmJpeg8.cxx: doxygen fix.
1804 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1805 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1806 from File:: to PixelConvert::.
1808 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1809 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1810 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1811 - more code moved away from File:: to PixelConvert::
1812 - fat setup of PixelConverter set in place in File::Initialise.
1814 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1815 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1816 namespace at the file system level. So now you should convert your examples
1818 gdcmHeader -> gdcm::Header
1819 It would be nice if people keep in mind to no open the namespace, since it
1820 allows compilation on broken plateform which were defining common symbol in
1821 the standard namespace (like LP, Unknown ...)
1823 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1824 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1825 The JPEG fragments are now parsed at the same stage than the RLE
1826 information. All code related to JPEG is now in gdcmPixelConvert:
1827 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1828 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1829 export a gdcmFile:: method. Those are simply global functions
1830 (for the time being this is better than having them attach to
1831 either gdcmFile:: or gdcmPixelConvert::).
1832 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1833 and stores the result in a gdcmJPEGFragmentsInfo.
1834 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1835 code (among other stuff) moved away from gdcmFile:; to
1838 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1839 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1840 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1841 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1842 clean up of RLE related code.
1843 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1844 - src/gdcmRLE.cxx removed
1845 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1846 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1847 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1848 * CLEANUP_ROUND (9) for gdcmPixelConvert
1849 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1850 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1851 away from gdcmFile:: to gdcmPixelConvert::.
1853 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1854 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1855 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1856 This is because Parse7Fe0 used to parse the pixels to compute the
1857 length. This task was passed over to FindDocEntryLengthOB() a long
1858 time ago, EXCEPT I forgot the OW case...
1859 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1860 we just recylce the code for parsing RLE fragments and computing
1862 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1863 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1864 with the retired Parse7Fe0().
1865 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1866 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1868 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1869 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1870 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1871 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1872 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1873 * CLEANUP_ROUND (4) for gdcmPixelConvert
1874 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1875 to return an unused length.
1877 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1878 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1879 this should be cleanner from the plane view. The iostream are erally a pain
1880 to use to do simple stuff.
1882 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1883 * Redo the compilation of the ijg jpeg library. Now only one source is
1884 necesseray. No need to rename file by hand what so ever. CMake handle the
1885 copying of the file within different directory, configure header file to
1886 modify some symbol. The only addition made to ijg wasd a mangle table so
1887 that symbol are different whether we are within 8bits or 12bits.
1889 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1890 * Added documentation of vtkgdcmReader on Website:
1891 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1892 with it's binary name).
1893 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1894 the Website to be more complete.
1895 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1896 doxygenated documentation.
1897 - Doc/DoxyVtkGdcmReaderExamples.txt added
1898 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1899 DoxyVtkGdmReaderExamples.html )
1900 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1901 * CLEANUP_ROUND (3) for gdcmPixelConvert
1902 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1904 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1905 * CLEANUP_ROUND (2) for gdcmPixelConvert
1906 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1908 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1909 * CLEANUP_ROUND for gdcmPixelConvert:
1910 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1911 - src/gdcmPixelStuff[h|cxx] removed
1912 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1913 - src/CMakeLists.txt changed accordingly
1914 * GDCMHOME clean up:
1915 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1916 gdcmVersion.py moved to newly created ATTIC related
1917 gdcmPython/SetupOldies/ directory.
1918 * Autotools clean up:
1919 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1920 - autogen.sh configure.in acinclude.m4 python.m4 removed
1922 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1923 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1924 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1925 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1927 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1928 * TODO updated with Mathieu suggestions. I proposed a template for
1929 describing TODO entries and used it for new entries.
1930 * Added Doc/Website/CodingStyle.html, Developpers.html,
1931 DeveloppersPython.html, GdcmDataCvs.html and
1932 DownloadVersion0_1.html, DownloadVersion0_3.html.
1933 * Some Doc/*.txt Doxygen files (which do not really concern the
1934 documentation itself, but the website) moved to html and
1935 placed in directory Doc/Website:
1936 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1937 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1938 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1939 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1940 * CMakeLists.txt changed accordingly.
1941 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1942 DeveloppersPython.html
1943 * INSTALL nows refers to Doc/Website/Installation.html
1945 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1946 * Added Doc/Website directory, that contains a first raw version
1949 2004-09-23 Jean-Pierre Roux
1950 * FIX In order not to be poluted any longer by casting problems,
1951 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1952 we can now delete[] it safely
1953 * VoidArea is now called BinArea (less confusing name),
1954 and all the methods called ...VoidArea... are now ... BinArea...
1955 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1957 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1958 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1959 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1960 up to the destructor of gdcmElementSet to clean up TagHt and it's
1963 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1964 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1965 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1967 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1968 * ENH: added some utility method that builds a flat dictionary
1969 holding all the Dicom entries contained in the recursive structure
1970 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1971 an example of usage.
1972 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1973 BuildFlatHashTable() that build a flat dictionary.
1974 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1975 gdcmDocument is now a friend of gdcmElementSet.
1976 - src/gdcmElementSet.cxx: clean up.
1977 - Example/FlatHashTablePrint.cxx added.
1978 - Example/CmakeLists.txt changed accordingly
1980 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1981 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1982 moved away from gdcmDocEntrySet (since this class is an abstract class
1983 acting like an interface). SQDepthLevel and BaseTagKey are now
1985 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1986 and associated accessors. Doxygenation of the class.
1987 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1989 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1990 Use SQDepthLevel accessor instead. ::Print() adapted.
1991 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1992 - src/gdcmDocument.cxx changed accordingly.
1994 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1995 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1996 - The following is the doxygen comment of the typedef declaration
1997 of gdcmTagKey in src/gdcmCommon.h:
1998 gdcmTagKey is made to old an "universal" (as in URL, Universal
1999 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
2000 A dicom tag always has a group and an element, but a set of tags
2001 embeded in various (optionally nested) sequences and sharing
2002 the same group and element all share the same (group, element)
2003 "identifier". Hence the (group, element) cannot be used as an
2004 identifier (in gdcm we shall refer to a "TagKey") of a tag.
2005 In order to construct a proper tag identifier (i.e. a key) we
2006 consider the following definition of a TagKey:
2007 - let Group, Element be the string representation of the
2008 group and element dicom tag members,
2009 - let ItemNumber be the string representation of the integer
2010 index of the considered item number of a sequence,
2011 Let the key of a tag embeded in a sequence, noted SeqTag, be
2013 /ItemNumber#Group|Element
2014 where "/", "#" and "|" are characters acting as separators.
2015 Then the general form of a gdcmTagKey is given by:
2016 Group|Element<SeqTag>
2017 where <SeqTag> means NO or many instances of SeqTag.
2018 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
2021 but the gdcmTagKey of a tag "embeded" is the first item of
2022 a sequence, itself nested in the third item of a sequence is the
2024 0004|1220/2#0008|0082/0#0008|0090
2025 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
2026 order to hold the new sequence compatible key. Previously, the
2027 GetKey() method would look in the underlying gdcmDictEntry.
2028 - src/gdcmDocEntry.cxx:
2029 -- constructor now copies the underlying DictEntry key, in the local
2031 -- ::Print: displays the member Key, instead of the (group, element).
2032 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
2033 - src/gdcmDocEntrySet.h:xi
2034 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
2035 -- now has a new BaseTagKey member.
2037 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
2038 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
2040 This poses the problem with the semantics of the following lines
2041 LoadEntryVoidArea(0x0028,0x1201); // R LUT
2042 LoadEntryVoidArea(0x0028,0x1202); // G LUT
2043 LoadEntryVoidArea(0x0028,0x1203); // B LUT
2044 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
2045 to the long FIXME note for what the problem is. Nevertheless in
2046 order to get things working the dicom dictionary was altered !
2047 Please fix things urgently...
2048 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
2049 information), see above note on moving the member VoidArea. Nevertheless
2050 the following entries previously correctly set as US are now inproperly
2052 0028 1201 OW IMG Red Palette Color Lookup Table Data
2053 0028 1202 OW IMG Green Palette Color Lookup Table Data
2054 0028 1203 OW IMG Blue Palette Color Lookup Table Data
2055 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
2056 of gdcmDocEntry moved to gdcmSeqEntry.
2057 * src/gdcmSeqEntry.cxx: STYLE.
2059 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2060 * Test/TestAllEntryVerify.cxx minor fix and added comments.
2062 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2063 * gdcmPython/testSuite.py: all the test suite in python is now moved
2064 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
2065 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
2066 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
2068 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2069 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
2070 to avoid inclusion recursion until STL is reached.
2071 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
2072 mecanism. errno.h is not included in gdcm anymore.
2073 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
2074 (gdcmFormatError now inherits from gdcmFormatUnexpected).
2076 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
2077 gdcmData/TestAllEntryVerifyReference.txt
2078 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
2079 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
2080 exception_on_error parameter.
2081 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
2082 - vtk/vtkGdcmReader.cxx changed accordingly,
2083 - Example/*.cxx and Test/*.cxx changed accordingly.
2085 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2086 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
2087 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
2088 enable_sequences removed from gdcmHeader constructor and dependencies.
2089 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
2090 * gdcmPython/demo/PrintHeader.py: dummy fix.
2091 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
2092 skip_shadow removed from gdcmHeader constructor and dependencies.
2093 * Example/*.cxx and Test/*.cxx changed accordingly.
2095 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2096 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
2097 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
2099 2004-07-21 Jean-Pierre Roux
2100 * FIX Now, Parsing and Printing a DICOMDIR do work!
2101 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
2103 2004-07-20 Jean-Pierre Roux
2104 * FIX Some brain damaged headers have Zero-Lenght fields
2105 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
2107 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2108 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
2109 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
2110 variable (instance of gdcmDebug) by a definition macro, and the instance
2111 is now in static in the gdcmDebug class
2112 * src/gdcmSQItem.h : (FIXME) remove an undefined method
2113 * Test/PrintAllDocument.cxx : bug fix in the result of the test
2115 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2116 * WARNING: ctest now depends more tightly on gdcmData. You should
2117 check out gdcmData properly for things to run smoothly...
2118 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
2119 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
2120 we need the pixels not be loaded in order to use the ValEntry
2121 that displays position and size).
2122 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
2123 This is a C++ based equivalent of gdcmPython/testSuite.py that should
2124 be deprecated. If you have any doubts about the advantages of a
2125 modern scripting language (read Python) versus grass root C++ (i.e.
2126 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
2127 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
2128 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
2129 Anyhow, consider documenting the gdcmData images in
2130 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
2132 * Test/CMakeLists.txt:
2133 - now uses TestAllEntryVerify.cxx
2134 - specific comments on oldACR00001.ima (now renamed in gdcmData
2135 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
2136 gdcmData/TestAllEntryVerifyReference.txt
2139 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2140 * src/*.[h|cxx] : typedef clean up
2141 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
2142 - TagKey renamed to gdcmTagKey (for external usage)
2143 - VRKey renamed to gdcmVRKey (for external usage)
2144 - removal of typedef duplication.
2145 - Removed all unecessary inline keyword from class inline definitions.
2146 - Some method|function(void) declarations replaced with method|function().
2147 * src/jpeg/libijg12/jdhuff12.c:
2148 - printf polluting ctest removed.
2149 - TAB removal for comminting
2151 - TestAllReadCompareDicom.cxx: added a test that compares all the
2152 images in gdcmDataImages.h with corresponding images in
2153 gdcmData/BaselineDicom/. When baseline images are not present
2154 this test creates them.
2155 Note: we need to validate each reference image, but before that
2156 I'd like to rename them with a more explicit name...
2157 - CMakeLists.txt: changed accordingly.
2158 * Example/*.cxx: examples now only include gdcm.h (as opposed to
2159 including each header needed).
2161 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2162 * Test/*.cxx and Example/*.cxx: moved some examples away from the
2163 test suite to the Example directory. Are concerned:
2168 - TestWriteSimple.cxx
2169 * Test/CMakeLists.txt: added some comments on reasons for black listing
2170 image gdcmData/oldACR00001.ima
2172 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2173 * Test/CmakeList.txt: removed the following from black list (to be coherent
2174 with removal from gdcmData):
2175 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
2176 - gdcm-MR-PHILIPS-16.dcm
2178 Added the following because after last cvs update, they cause
2179 ctest -R TestReadWriteReadCompare
2181 - gdcm-MR-SIEMENS-16-1.acr
2183 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
2184 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
2185 new comments in this file) we temporarily (sigh) move to a weaker
2187 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
2188 we don't need to black list the following images anymore:
2189 - 8BitsUncompressedColor.dcm
2191 - US-PAL-8-10x-echo.dcm
2192 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
2193 fixes and the beautified code ;-)
2194 This fixes the bug introduced in version 1.42 (when beautifying)
2195 that made the parsing of 8BitsRunLengthColor.dcm unproper.
2196 Note: ctest was blind to this bug (this means we need to still
2197 improve the test suite). The bug could be detected by using
2198 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
2200 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
2201 and by displaying the (garbage) produced file temp.XDCM...
2203 2004-06-29 Jean-Pierre Roux
2204 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
2205 - replace by uggly but working old code :-(
2206 A lot of things should be OK again.
2207 It's really urgent to have a test suite that *tests*,
2208 to prevent Frog's beautifying sessions to break all the stuff
2209 (twice, withing a fortnigh ...)
2211 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2212 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
2213 redundancy) to added Test/TestReadWriteReadCompare.cxx
2214 * Test/CmakeList.txt: because the compare test of
2215 Test/TestReadWriteReadCompare.cxx fails, the following images are
2216 black listed: - 8BitsUncompressedColor.dcm
2218 - US-PAL-8-10x-echo.dcm
2219 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
2220 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
2221 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
2222 and ad-hoc kludge. This kludge is now removed, and on encountering
2223 such an image (OB field brain damaged) we set errno. Then in
2224 ::FindDocLength() we "fix" the length as being ALL what remains
2225 in the file (until EOF). We then proceed, hoping for the best...
2226 This fixes a SegFault in ShowDicom when trying to write such an
2228 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
2229 (because TestWriteRead breaks on it, after a non conformal commit?).
2230 ctest now runs properly, except for MakeDicomDir (which was always
2231 broken) and the Python related stuff (still not fixed).
2233 2004-06-24 Jean-Pierre Roux
2234 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
2235 FIX : Test/TestReadWrite now iterates on all the file names
2236 (instead of infinite loop)
2237 ENH : Test/TestWriteRead now iterates on all the file names
2239 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2240 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
2242 2004-06-24 Jean-Pierre Roux
2243 FIX : - now Write drops LUT Descriptors and LUTs (if any)
2244 when SamplesPerPixel =3
2245 - now Write is no longer confused by
2246 'BitsAllocated = 12" and 'BitsStored=12"
2247 - "UN" value representation Elements are now written correctly
2248 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
2249 ENH : - now gdcmHeader has its own Write methods
2250 (in order to split the job that has not to be done
2253 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2254 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
2255 loop on the same image until memory went out.
2256 Note: this means we still have gobs of memory loss in PrintDocument
2257 * src/gdcmDocument.cxx: fixes problem on parsing on file
2258 gdcmData/16BitsJpegLosslessGrayScale.dcm.
2260 2004-06-24 Jean-Pierre Roux
2261 FIX : Write - All the Sequences and Sequence Item are now written
2262 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
2263 is added a the end, when necessary.
2264 - A lot of brain-damaged images, that were read correctly are
2265 now written correctly
2266 - length compatible BinEntry are now loaded correctly
2267 (even for odd groups)
2268 Note : only Explicit Value Representation was checked.
2269 (question : is implicit VR really necessary for gdcm ?)
2271 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2272 * DEVELOPPER: added a proposition of coding style.
2273 * src/gdcmDocEntry.h: removed every inline declaration (for test of
2276 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2277 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
2278 Use the gdcmDocEntry::Print() and Write() instead.
2279 * src/gdcmDocument.cxx: bug fix.
2281 2004-06-22 Jean-Pierre Roux
2282 FIX : gdcmDocument.cxx
2283 - Now we do recognize the JpegLossLess format (there was a misstyping in
2284 code 'beautyfication' :-(
2285 - Now we automaticaticaly load the Luts, if any
2287 2004-06-22 Jean-Pierre Roux
2288 In order : to write Sequences, whatever their imbrication level,
2289 : to allow user to create his own Sequences
2290 a lot of modif where necessary (adding, moving, or virtualising methods)
2292 WARNING : save your own sources *before* cvs up !
2295 ADD virtual void Write(FILE *fp, FileType filetype);
2298 ADD virtual void Write(FILE *fp, FileType filetype);
2299 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
2302 ADD virtual void Write (FILE *fp, FileType filetype)=0;
2303 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
2304 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
2305 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
2306 ADD std::string GetEntryByName(TagName name);
2307 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2309 std::string vr = "unkn",
2310 std::string fourth = "unkn",
2311 std::string name = "unkn");
2312 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2313 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2314 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2315 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
2316 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
2317 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2318 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
2319 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
2322 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
2323 ADD virtual std::string GetEntryByName (TagName tagName);
2324 ADD virtual std::string GetEntryVRByName (TagName tagName);
2325 REM virtual bool Write(FILE *, FileType);
2326 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
2327 FILE *_fp, FileType type);
2328 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
2329 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
2330 REM virtual bool WriteEntries(FILE *_fp,FileType type);
2331 REM virtual std::string GetEntryByName (std::string tagName);
2332 REM virtual std::string GetEntryVRByName (std::string tagName);
2333 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
2334 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2335 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2337 std::string vr = "unkn",
2338 std::string fourth = "unkn",
2339 std::string name = "unkn");
2340 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2341 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
2342 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2343 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2346 ADD virtual void Write(FILE *fp, FileType filetype);
2349 ADD virtual void Write(FILE *fp,FileType filetype);
2352 ADD virtual void Write(FILE *fp, FileType filetype);
2353 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
2354 REM std::string GetEntryByNumber(guint16 group, guint16 element);
2355 REM std::string GetEntryByName(TagName name);
2358 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
2360 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2361 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
2362 The default constructor invoked by the line
2363 gdcmHeader *f1 = new gdcmHeader( header );
2364 was gdcmHeader::gdcmHeader(bool) instead of the expected
2365 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
2366 Hence the parsing wasn't executed... See also below.
2367 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
2368 as explicit constructor didn't do the trick to fix the above problem.
2369 Could anyone explain why ?
2370 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
2371 properly calls gdcmValEntry::Print() (that was weed out from
2372 code related to gdcmBinEntry).
2374 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2375 * In order to fix memory leaks:
2376 - Test/TestWriteSimple.cxx: added cleaning of free store through
2378 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
2379 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
2380 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
2381 (through the call to ::AddDicomDirMeta()) or the destructor
2382 would crash when deleting uninitialized ::metaElems].
2383 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
2384 - src/gdcmDocument.cxx:
2385 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
2386 from dynamic stores.
2387 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
2388 was causing memory leaks.
2389 - src/gdcmSQItem.cxx:
2390 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
2391 cleanly handled with polymophism: sorry but my milage is low).
2392 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
2393 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
2394 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
2395 This avoids SegFaulting.
2396 - src/gdcmSQItem.h: coding style.
2398 - Test/TestWriteSimple still severely sucks. The output image content
2399 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
2400 damaged when displayed with vtkgdcmViewer.
2401 - on memory leaks: TestWriteSimple leaks really less (see entry
2402 of 2004-06-18 in Changelog file for the call to valgrind).
2403 - on segfaults: ctest now passes all the tests but one (no more
2405 * Erroneous leading white fix:
2406 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
2407 white[s] (as opposed to from >> xxx, that removes it [them].
2408 - src/gdcmTS.cxx: ditto.
2409 - gdcmPython/testSuite.py: dirty related kludge removed.
2410 * src/*: remaining references to gdcmParser removed.
2411 * src/*[cxx|h]: added copy[way]left header.
2414 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2415 * In order to fix writing of dicom files:
2416 - Test/TestWriteSimple.cxx: a simpler example of writing.
2417 - Test/CMakeLists.txt changed accordingly.
2418 - src/gdcmDocument.cxx:
2419 -- The destructor now recursilvely removes potential sequences.
2420 -- Bug fix in ::IsJPEG2000()
2421 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
2422 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
2424 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
2425 to only declared) and build on top of
2426 ::GetDocEntryByNumber(guint16, guint16).
2427 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
2428 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
2429 for usage in destructor and treatement of promotion in
2430 ::ReplaceOrCreateByNumber().
2431 - src/gdcmSQItem.cxx: destructor should better handle his job.
2432 Test/TestWriteSimple now runs (or at least it DOES something).
2433 * We can now start hutting memory links. A good starting point is:
2434 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
2435 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
2436 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
2438 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2439 * Valgrind note: after Mathieu Malaterre teached me how to read
2440 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
2442 Using gcc, you can force the STL to use malloc and to free memory as
2443 soon as possible by globally disabling memory caching.
2444 With 3.2.2 and later, you should export the environment variable
2445 GLIBCPP_FORCE_NEW before running your program.
2446 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
2447 simply vanish (it is still not clear to me, whether this means that
2448 STL std::string leaks or if valgrind believes it leaks...).
2449 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
2450 running bin/gdcmTests makeDicomDir):
2451 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
2452 - Test/makeDicomDir.cxx now properly traps empty lists and returns
2454 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
2455 SegFaulting (I drowned in DicomDir related code when trying to
2456 understand why the list is empty...).
2457 * src/gdcmDocument.h: first BSD license header try.
2458 * Doc/License.txt added.
2460 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2461 * src/gdcmDocument.[h|cxx]:
2462 - Clean up of the Transfer related predicates. They are now all based
2463 on new method isGivenTransferSyntax, that (should) handle properly
2464 the padding problem.
2465 - general clean up, simplification, and coding style.
2466 - Specific clean up of Parse7FE0() (umproperly named actually).
2467 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
2469 2004-06-14 Jean-Pierre Roux
2471 - fix the display of Sequence Delimitor (SQDepthLevel pb)
2472 - fix the display of SQItem ordinal number
2473 - add the GetSQItemByOrdinalNumber method
2474 - remove some useless never written private methods
2476 2004-06-14 Jean-Pierre Roux
2478 - adding a constructor taking a gdcmDocEntry as an input param
2479 - ReplaceOrCreateByNumber now returns :
2480 a gdcmBinEntry * if a Binary (void *) value is passed as a param
2481 a gdcmValEntry * if a string value is passed as a param
2483 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
2484 according to the param type (no longer sets a gdcmDocEntry)
2485 - GetValEntryByNumber, GetBinEntryByNumber added
2486 - NewValEntryByNumber and NewBinEntryByNumber added
2488 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
2490 - GetSQItemNumber and SetSQItemNumber added, to provide
2491 a (relative) Item identier inside a given Sequence
2492 \warning : some pb remaining around this number
2494 - AddEntry now takes the Item Number as a param
2496 - adding a constructor taking a gdcmDocEntry as an input param
2498 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2499 * Memory leak hunt with the following command:
2500 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2501 --show-reachable=yes gdcmTests PrintDocument
2502 It looks like many (all?) leaks are due to the STL (or a bad usage
2503 of the STL. The lines producing the leaks now have a comment with
2504 a "MEMORY LEAK" tag: you can retrieve them with
2505 grep "MEMORY LEAK" src/*
2506 Here are two typical examples which I can't help fixing:
2511 char * test = "babo";
2512 name = test; //// <--- valgrind detects 960 bytes lost in
2513 //// call to std::string::operator=(char const*)
2514 name.clear(); //// Doesn't help !
2522 std::cout << "Type a bunch of characters followed by RETURN: ";
2523 getline(std::cin, line); //// <--- valgrind dectects a loss
2524 //// of 1320 bytes in call to
2525 /// std::basic_istream<>& std::getline<>
2531 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2532 * src/gdcmHeader.[cxx|h]:
2533 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
2534 and related, moved away to gdcmDocument.
2535 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
2536 the corresponding protected accessors of inherited class
2537 gdcmDocument, removed ! As a consequence gdcmFile had to be
2538 declared friend of class gdcmDocument (see below).
2539 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
2540 - Clean up of undefined or unused methods.
2541 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
2542 account the changes to gdcmHeader.h).
2543 * src/gdcmDocument.h:
2544 - gdcmFile is now a friend class (in order to take into account the
2545 changes to gdcmHeader.h).
2546 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
2547 (see changes to gdcmHeader.h).
2548 - Accessors (reading on the form GetEntry*) are now public.
2549 - Clean up of undefined or unused methods.
2550 * src/gdcmDocument.cxx:
2551 - adaptation to changes to gdcmDocument.h
2552 - ::OpenFile now writes a verbose message when file cannot be opened.
2553 - some std::string properly set to VRKey
2554 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
2555 references to gdcmDocument.
2556 * Test/TestFindTags.cxx: changed accordingly to above changes.
2557 * gdcmPython/testSuite.py: adapted to renaming of acr files in
2558 cvs repository gdcmData.
2560 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2561 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
2562 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
2563 conflicts with gdcmValEntry::voidArea.
2564 * src/gdcmValEntry.cxx: unmatching comment wiped out.
2565 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
2566 Value representation between StringRepresentable and BinaryRepresentable.
2567 * src/gdcmDocument.cxx:
2568 - method ParseDES: proper indentation restored and usage of
2569 gdcmVR::IsVROfGdcmStringRepresentable wired in.
2570 - method LoadDocEntry: the fingerprint left in the SetValue() of
2571 unloaded entries (length > MaxSizeLoadEntry) had curiously been
2572 removed. Reverting to previous code segment with the proper
2573 dynamic_cast< gdcmValEntry* >.
2574 Note: this was (partially) breaking the python test suite
2575 (gdcmPython/testSuite.py) that made usage of the above
2576 fingerprint to check presence of "Pixel Data".
2577 * src/gdcmDocEntry.h: coding style.
2578 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
2579 now taken into account.
2580 * gdcmPython/gdcm.i: adaptation to the new internal representation
2581 of gdcm (exit gdcmParser, hello gdcmDocument).
2582 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
2584 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
2585 anymore, but instead prints the loaded Python dictionary.
2586 * .... alas, the python testSuite is still broken.
2588 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2589 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
2591 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
2592 * src/gdcmUtil.h : export methods
2594 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2595 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
2597 * Initial addition of automatic python testing
2598 * Initial addition of automatic image comparison
2600 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2601 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
2602 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
2604 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2605 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
2606 * Test/ShowDicom.cxx : bug fix for msvc compilation
2607 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
2609 2004-05-04 Jean-Pierre Roux
2610 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
2611 new concepts (and new classes) :
2612 a 'gdcmDocument' is composed of a set of Doc Entries, that are
2613 - elementary gdcmDocEntries (former gdcmHeaderEntries)
2614 - Sequence Doc Entries (gdcmSeqEntries)
2615 a Sequence is composed of Items.
2616 Each item is a set of Doc Entries (this is recursive)
2617 The non uniqueness of the 'Dicom tag' is due to this recursivity
2618 (never taken into account)
2619 Our unability to add a new 'entry' in the header
2620 at the proper location (neither in the H-Table (map or multimap),
2621 nor in the Chained List is also due to this recursivity.
2622 Don't try, right now, to use/modify/compile these new sources :
2623 nothing is finished.
2624 We just commit all the stuff, 'as is', in order not to loose it.
2626 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2627 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
2629 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2630 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
2631 file prefix (SetFilePrefix)
2633 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2634 * Add a new test: ShowDicom, for now this is just the c++ version of
2635 checkRead.sh, later it will be able to compare the image read against a
2637 * Replace the DEBUG on the stack with a global entry in cmake interface:
2638 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
2640 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2641 * Add an example subdir, with a real example on how to read + write a
2644 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2645 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
2646 * Doc/CMakeLists.txt: the main page is now properly differentiated
2647 between the developper and user version.
2648 * Doc/doxygen.config.in: dropped search related obsolete flags
2649 * src/gdcmParser.h, gdcmHeader.h: doxygenation
2651 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2652 * DEVELOPPER: added some helpfull comments for compile/test/install
2655 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2656 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
2657 src directory, now generated in the build dir.
2658 2. Tests as mentionned smarter
2660 4. Add a new method in gdcmDict that return the PubDict by name
2661 this is interesting for 3rd party lib like ITK,
2662 where we could set the institution name / patient name...
2664 * ENH: 1. Now the test suite is working for real
2665 2. All binaries are now output in the gdcm-bin directory
2666 (this was not true before)
2668 2004-04-28 Jean-Pierre Roux
2669 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
2670 SeQuence indented printing of Dicom Header.
2671 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
2672 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
2673 Computation of SQDepthLevel is now part of gdcmHeader constructor
2674 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
2675 tree-like structure of a Dicom Header.
2676 * FIX Test code cleaning
2678 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2679 * ENH: Adding automatic testing
2680 1. Need a DartConfig.cmake to submit to public
2681 2. Add a test driver gdcmTest.cxx
2682 3. gdcmTestMain, an helper for the main test driver gdcmTest
2683 4. Files in Test don't have a main anymore, this becomes interesting
2684 when we add more and more tests, thus dsw don't have to load
2686 * ENH: Adding a GDCM_DATA_ROOT for testing
2687 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
2688 one file instead of seven + some small cleanup
2690 2004-04-22 Jean-Pierre Roux
2691 * ENH Minor changes to the Print() methods.
2692 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
2693 Header printing. Example given with :
2694 > PrintHeader fileName 2 new
2695 (SQ based tree-like structure still to be done for the Header ...)
2697 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2698 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
2699 1. I have added some unsigned where needed
2700 2. Some function parameter not used -> (void)
2701 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
2702 4. g++ don't like character '\' in comment
2703 5. #define jpeg_create_decompress jCreaDecompress
2704 this really need to be fixed
2705 6. virtualize destructor of gdcmObject ... leakage
2706 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2707 this also really need to be fixed
2708 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2709 remove compression file
2710 (as we only do decompression, right ?)
2711 * ENH: Change malloc/calloc/free with c++ equivalent
2713 2004-04-21 Jean-Pierre Roux
2714 * FIX gdcmHeaderHelper::GetXSpacing
2715 when a single value is found (bug ?), xpacing is now
2716 defaulted to yspacing
2718 2004-04-19 Jean-Pierre Roux
2719 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2720 * ENH add parameters :
2721 bool exception_on_error = false,
2722 bool enable_sequences = false,
2723 bool ignore_shadow = false
2724 to the gdcmFile constructors to be full gdcmParser compliant
2725 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2726 to allow reading of PAPYRUS 3.0 files
2728 2004-04-06 Jean-Pierre Roux
2729 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2731 2004-04-02 Jean-Pierre Roux
2732 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2733 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2734 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2736 2004-03-30 Jean-Pierre Roux
2737 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2738 for ACR file, written out as DICOM files (hope so...)
2740 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2741 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2742 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2743 moved to base class gdcmParser and only the specialisation is kept
2745 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2746 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2747 already does the job.
2748 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2749 (to be consistent with gdcmParser::WriteEntries).
2751 2004-03-30 Benoit Regrain
2752 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2753 upate of the object's instance. It's passed to 2 in the unfavorable
2754 case : one in the ExecuteInformation, one in the ExecuteData
2756 2004-03-29 Jean-Pierre Roux
2757 * ENH : Check on file type to be written moved
2758 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2759 * FIX : gdcmObject::ResetBoundaries now stops properly
2760 when end-of-list is reached
2761 : gdcmVersion modified (as Benoit Regrain asked)
2763 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2764 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2765 * src/gdcmUtil.cxx: added forgotten iostream include.
2766 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2767 equivalent to ExplicitVR in existing code).
2769 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2770 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2771 now contains all the gdcmGlobal related code.
2772 * minor coding style and doxygenation changes.
2774 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2775 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2776 now contains all the Debug related code.
2777 * minor clean-up of includes in src/*.cxx
2778 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2779 CreateCleanString) removed.
2780 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2781 * Doc/DoxyMainPageUser.txt added.
2782 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2783 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2784 src/gdcmDirList.cxx)
2786 2004-03-24 Jean-Pierre Roux
2787 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2789 2004-03-23 Jean-Pierre Roux
2790 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2791 big endian made volumes
2792 * ENH Now gdcmParser constructor and destructor are protected to forbid
2793 end user to instanciate class gdcmParser
2794 (only gdcmHeader and gdcmDicomDir are meaningfull)
2796 2004-03-22 Benoit Regrain
2797 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2798 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2799 gdcmSerie to gdcmDicomDirSerie
2801 2004-03-19 Jean-Pierre Roux
2802 * ENH Now the tree-like structure describing a DICOMDIR comming from
2803 an already existing DICOMDIR file is consistent with
2804 the home-made tree-like structure build ex-nihilo
2805 or build from the files held (recursively) in a Directory
2806 functions gdcmDicomDir::CheckBoundaries()
2807 gdcmObject::SetBoundaries() added
2809 2004-03-17 Jean-Pierre Roux
2810 * REM (Eric Boix bug) : removal of meaningless
2811 gdcmDicomDirImage::NewImage function.
2812 * FIX now file names and directory name are written properly in the
2814 * FIX now gdcmDicomDir constructor may be call without any trick
2817 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2818 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2819 of gdcmDicomDirImage::NewImage as empty function.
2821 2004-02-28 Jean-Pierre Roux
2822 * ENH add gdcmDicomDir:NewPatient
2823 add gdcmDicomDirPatient:NewStudy
2824 add gdcmDicomDirStudy:NewSerie
2825 add gdcmDicomDirSerie:NewImage
2826 to allow making gdcDicomDir object.
2827 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2828 (as opposite to the gdcmHeader chained list)
2830 2004-02-11 Benoit Regrain
2831 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2832 when using from python
2834 2004-02-10 Benoit Regrain
2835 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2836 * FIX : in gdcmDicomDir when the directory is empty
2837 * ENH : add callback and methods to get the progression of dicomDir
2840 2004-02-06 Jean-Pierre Roux
2841 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2842 - GDCM_META added to gdcmDicomDirType
2843 - class gdcmMeta created
2844 * ENH : - A brief summary is now displayed at the beginning of
2845 'testDicomDir' to help disaster magnitude estimation
2846 * REM : Now useless Test/explDICOMDIR.cxx
2848 2004-02-05 Benoit Regrain
2849 * ENH : add methods in gdcmObject to get the hash table or the list of
2851 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2852 * FIX : wrapping python for TagHeaderEntryHT
2854 2004-02-04 Benoit Regrain
2855 * FIX : even length for some strings when writting the dicom dir
2856 * FIX : sort the images in the dicom dir
2857 * FIX : Bug fix for python use of dicom dir
2858 * ADD : a python demo
2860 2004-02-04 Jean-Pierre Roux
2861 * FIX : Final solution (?) for icone embedded images
2862 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2863 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2864 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2865 gdcmData/gdcm-MR-SIEMENS-16.acr1
2866 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2867 to make full checking easier
2869 2004-02-04 Benoit Regrain
2870 * FIX : WriteEntries : coding style & logic in parameters
2871 * FIX : Set the elements to create the DicomDir in a dictionary file
2873 2004-02-03 Benoit Regrain
2874 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2875 * gdcmDicomDir : add the load of directory
2876 * Bug fix and print add-on
2878 2004-02-03 Jean-Pierre Roux
2879 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2880 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2881 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2882 * FIX gdcmParser.cxx : 'group length' elements are now considered
2883 as integers, even for shadow groups, when file is Implicit VR
2885 2004-02-02 Jean-Pierre Roux
2886 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2888 of the last synonym :-(
2889 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2891 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2892 * FIX taking into account the possible 7fe0,0010 multiplicity
2893 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2894 to allow removal of references to 7fe0,0010, to deal with
2895 ACR-NEMA images, when 0028,0200 is meaningfull
2897 2004-01-31 Jean-Pierre Roux
2898 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2899 no longer writes 'Un' on disk
2900 * FIX SQ elements with actual length are now dealt with corectly
2901 * FIX gdcmFile::WriteBase make the difference, for color images, between
2902 the length (for Palette expanded images)
2903 and Raw Length (non expanded image + Palette)
2904 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2905 (that broke Write). Replaced by UL.
2906 Aware user will reload the field if he
2907 thinks it's necesssary
2909 2004-01-30 Jean-Pierre Roux
2910 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2911 when 'dirty Acr' is found, to be compliant with the new
2912 IsReadable() methods.
2914 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2915 (no DOUBLE images in kosher DICOM,
2916 but so usefull for people that miss them ;-)
2918 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2919 DICOMDIR related utilities (not checked as Windoze compliant)
2921 2004-01-28 Jean-Pierre Roux
2922 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2924 2004-01-27 Jean-Pierre Roux
2925 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2926 to allow skipping the shadow elements, to save memory space.
2927 The TRUE value for this param has to be used
2928 with a FALSE value for the 'enable_sequence' param.
2929 ('public elements' may be embedded in 'shadow Sequences')
2930 * gdcmHeader methods now deal with 'embedded icones images' in the header
2931 (even when an 'icone image sequence' is announced by the
2932 element (0x0088,0x0200), but there is NO icone at all ...
2934 * gdcmHeader sometimes Image Location value doesn't follow
2935 the supposed processor endianity (see gdcmData/cr172241.dcm).
2938 * gdcmHeader add the method
2939 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2940 to get *all* the Header Entries with the same tag.
2941 GetHeaderEntrySameName is probabely *useless*
2942 (no meaning : Name is *not* an identifier within the Dictionary)
2944 2004-01-26 Benoit Regrain
2945 * Bug fix in the print of hexadecimal representations. Remove long fields
2946 in the print and add a third level of print to print them
2948 2004-01-23 Benoit Regrain
2949 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2950 * Bug fix on test suite after remove the strip made on not string fields
2951 * Split the IsReadable method between gdcmParser which test that the file
2952 is dicom and gdcmHeader which test that it's an image file
2954 2004-01-22 Benoit Regrain
2955 * DicomDir : clean code, add methods, set variables in protected or private
2956 * gdcmUtil : bug fix for the clean string method
2958 2004-01-19 Benoit Regrain
2959 * Add the use of shadow dictionaries
2960 * bug fix and coding style
2962 2004-01-19 Benoit Regrain
2963 * src/gdcmFile.cxx : bug fix concerning the close of file
2964 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2965 * Add the update of header entries using the shadow library
2967 2004-01-19 Benoit Regrain
2968 * removal of file gdcmHeader2.cxx
2969 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2970 inheriting from gdcmParser. This split is to prepare the integration
2971 of dicom dir parsing
2972 * bug fix under python
2974 2004-01-16 Jean-Pierre Roux
2975 * REM removal of class gdcmHeaderEntrySet
2976 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2977 * ADD add file gdcmHeader2.cxx
2978 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2980 2004-01-15 Benoit Regrain
2981 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2982 entries created while parsing the header. Thus, they will be destroyed
2983 when the gdcmDictSet will be destroyed
2984 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2987 2004-01-15 Benoit Regrain
2988 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2989 made a fatal error because of the memory release at the end of program.
2990 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2991 some memory and vtk seems to have some problems with that.
2992 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2994 2004-01-14 Benoit Regrain
2995 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2996 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2997 * src/*.[h|cxx] : make changes due to class name changes
2998 * gdcmPython/demo/*.py : bug fix due to method names
3000 2004-01-13 Benoit Regrain
3001 * src/*.[h|cxx] : coding style
3002 * vtk/*.[h|cxx] : coding style
3004 2004-01-13 Benoit Regrain
3005 * gdcmPython/testSuite.py : test the readable flag of file for tests
3006 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
3007 It's lied to the stl compilation by MSVC (windows, always windows...)
3008 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
3010 2004-01-12 Benoit Regrain
3011 * src/*.h : add comments
3012 * src/gdcmDictSet.h : set the method BuildDictPath in public
3013 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
3014 directly setted in the source code
3015 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
3018 2004-01-09 Benoit Regrain
3019 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
3020 * setup.py : use a reference to gdcmVERSION
3022 2004-01-07 Benoit Regrain
3023 * Modification to compile with the distutils.
3026 2003-12-10 Benoit Regrain
3027 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
3028 can use a gdcmHeaderHelper to load data
3029 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
3030 made in the source code
3032 2003-12-10 Benoit Regrain
3033 * Update Windows projects and .cvsignore files
3035 2003-11-12 Jean-Pierre Roux
3036 * ENH gdcmHeader constructor has one more parameter (default value : false)
3037 that allows the user to 'go inside' the SeQuences only
3039 gdcmElValSet:Print takes it into account
3041 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3042 * ENH: Update gdcmPython/CMakeLists
3043 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
3044 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
3046 2003-11-10 Jean-Pierre Roux
3047 * FIX : gdcmHeader::LoadElements is now based
3048 on the ListTag listElem member,
3049 not longer on the TagElValueHT tagHt member
3050 * ENH : PrintPubElVal shows (temporarily) both results,
3051 with the tagHt member and the listElem member.
3052 (it's easier to 'see' the problems when using Printheader)
3054 * FIX : old private member LgrElem is now splitted into
3055 ReadLength : Length actually found on disk (updated only
3056 if bug fixing is necessary), for internal
3058 UsableLength : Updated by FixFoundLength, to fix a bug
3059 or to allow Parser going on.
3060 Will allow to re-write a kosher header when a SeQuence
3061 with a length (not 0000) is found
3062 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
3063 because gdcmElValSet::Add does not update ListElem
3066 2003-11-07 Jean-Pierre Roux
3067 * FIX misstyping in Transfert Syntax name table
3068 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
3069 when they have an actual length (not 0000 nor FFFFF)
3070 (Nobody should care of it, but DICOMDIR explorers)
3072 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3073 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
3075 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3076 * ENH: vtkGdcmReader now supports LUT !
3077 (vtkgdcmViewer for now is not able to use them though)
3079 2003-11-05 Jean-Pierre Roux
3080 * in testSuite.py : new files names for checking the package
3081 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
3082 that returns the pixel area size to the *aware* (vtk) user
3083 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
3085 2003-11-05 Benoit Regrain
3086 * in testSuite.py : Modify the rules for checking the paths
3087 : Explicit error messages
3088 * in __init__.py : Related modif
3090 2003-11-03 Jean-Pierre Roux
3091 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
3092 to be used by aware (vtk) users that want to manage
3093 LUT (and no to turn the PALETTE image into an RGB pixels one)
3094 * GetPixelType now returns 8U for 24 Bits images
3095 (vtkGdcmReader compliant)
3097 2003-10-31 Jean-Pierre Roux
3098 * Removal of *all* gdcmData images and add them again
3099 in order to loose the 'history' of un-anonymised images
3101 2003-10-31 Jean-Pierre Roux
3102 * RMV : removal of useless jBitsInJsample.h
3103 for both 8 and 12 Bits JPEG Lossy Libraries
3105 2003-10-31 Jean-Pierre Roux
3106 * ENH : Add the functions gdcmFile::GetImageDataRaw
3107 gdcmFile::GetImageDataIntoVectorRaw
3108 that act as GetImageData and GetImageDataIntoVector
3109 except the making of an RGB Plane from Gray Plane + LUT
3110 Intended to aware (vtk) users who know how to manage
3113 GetLUTRGBA return a R,G,B,A LUT if any
3114 lgrTotaleRaw gives the 'Raw' length
3115 GetImageDataRaw returns the gray Plane
3116 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
3117 (They stay Grey, just like with other Dicom viewers :-(
3119 2003-10-30 Jean-Pierre Roux
3120 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
3122 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3123 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
3124 being coherents dicom files.
3126 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3127 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
3129 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
3130 * ENH: Two steps is necessary to please VC++ compiler...
3131 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
3132 * ENH: Add include dir to medcon lib
3133 * FIX: only one function is being exported for now !
3134 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
3136 2003-10-29 Jean-Pierre Roux
3137 * adding gdcmHeader::GetLUTRGBA
3138 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
3139 --> Mathieu, the modif u're waiting for is not yet committed
3140 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
3142 2003-10-27 Jean-Pierre Roux
3143 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
3144 00191113.dcm DermaColorLossLess.dcm
3145 MxTwinLossLess.dcm RadBWLossLess.dcm
3146 * ENH: For version prior to vtkImageViewer2 -r 1.19
3147 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
3149 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3150 * Removal of ido stuff in CMakeLists.txt
3152 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3153 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
3154 * FIX: remove a call to ->Modified ... see comments
3155 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
3157 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3158 * FIX: Problem with path for libvtkgdcmPython
3159 * ENH: Try adding a search script for python site-package
3160 * RMV: Remove some file from medcon lib that are not necessary
3161 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
3162 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
3163 * FIX: More pragma disable fro VC++,
3164 I don't think I break something as it is also disable in VTK/ITK.
3165 But it fasten debug compilation time.
3167 2003-10-23 Jean-Pierre Roux
3168 * gdcm now deals with 16 Bits Run Length Encoded images
3169 (they are compressed as 2 planes images,
3170 one for the high Bytes, the other for low Bytes)
3172 2003-10-22 Jean-Pierre Roux
3173 * Now CheckRead takes into account :
3174 - the bugged 'Leonardo' Siemens images
3175 - the XA images, sent thru the burning VPRO station
3176 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
3179 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3180 * FIX: When copying a Makefile.am to CMakeLists.txt
3181 one should remove the '\'
3183 2003-10-22 Jean-Pierre Roux
3184 * in gdcmData adding a bugged 'Leonardo' Siemens image
3185 (wrong lengths in header)
3186 OK with gdcm, KO with the other viewers :-)
3187 * add a GE dlx XA image, thru the VEPRO burning station
3190 2003-10-21 Jean-Pierre Roux
3191 * in gdcmData add the checkvtkgdcmViewer.sh shell script
3192 for a brutal checking of vtkgdcmViewer compliance
3194 2003-10-21 Jean-Pierre Roux
3195 * add the files for 'xmedcon' Jpeg Lossless library
3196 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
3198 2003-10-21 Jean-Pierre Roux
3199 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
3201 2003-10-21 Jean-Pierre Roux
3202 * garbage Siemens 'Leonardo' images dealt with
3203 (the patch is easy to remove)
3204 * cosmetic changes to avoid warnings
3206 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3207 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
3208 no need to press 'r' now.
3210 2003-10-20 Jean-Pierre Roux
3211 * upgrade of checkRead.sh checkWrite.sh according
3212 to new Jpeg Lossless decompressor
3213 * add US.3405.1.dcm, a genuine RGB medical file ...
3214 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
3215 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
3217 2003-10-15 Jean-Pierre Roux
3218 * general anonymisation in gdcmData
3219 * adding the 'color files' from
3220 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
3221 * adding some well knowed bugged-header images
3222 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
3223 waiting for their inclusion in Python testsuite
3225 2003-10-15 Jean-Pierre Roux
3226 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
3227 no longer seg faults when file is not found
3229 2003-10-14 Jean-Pierre Roux
3230 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
3233 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3234 * TODO: *.in file to genereate a UseGDCM later
3236 2003-10-14 Jean-Pierre Roux
3237 * Some supposed-to-be Dicom Images have no preamble.
3238 OpenFile takes it into account
3239 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
3240 * Missing elements added in dicomV3.dic
3241 (just to be affraid : have a look at
3242 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
3243 and do it again next year ;->
3245 2003-10-13 Jean-Pierre Roux
3246 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
3247 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
3248 But there are NOT. It's fixed !
3250 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3251 * FIX: "jpeglib.h" was not found on VC++
3252 * FIX: vtkgdcm was not being installed
3254 2003-10-10 Jean-Pierre Roux
3255 * ENH : OpenFile closes the file if it *really* doesn't look like
3256 an ACR-NEMA / DICOM one.
3257 * FIX : testWrite no longer writes an empty file if the source file
3258 is not gdcm Readable
3259 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
3262 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3263 * FIX: CMake generate now documentation
3264 * ENH: out of source doc build !
3265 * ENH: Generate both user and dev documentation
3266 * ENH: Should work on windows too
3267 * ENH: Only one doxygen config.in file is needed
3268 * FIX: make install should be ok now on Unix plateform
3269 * FIX: PATH to dictionary was wrong (missing /)
3270 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
3272 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3273 * vtkGdcmReader is now able to read rgb dicom file.
3274 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3275 * added a gdcmViewer to vtk test, use mouse to control
3276 window level & window width
3278 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3279 * CMake-ification of gdcm, we have now two build system
3280 * FIX: on cygwin Wsock32 doesn't exist
3281 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
3283 2003-10-06 Emanuel Ollart
3284 * FIX : compilation process wad broken.
3285 Changed gdcmViewer_sources to vtkgdcmViewer_sources
3287 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3288 * change gdcmViewer -> vtkgdcmViewer
3289 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
3291 2003-10-06 Jean-Pierre Roux
3292 * FIX :A few nasty patches to allow the reading of a lot of nasty images
3293 ( e.g : well known GE images with a wrong elem length,
3294 : Philips MRI Images with a wrong Huffman table)
3295 * still to be done : allow the reading of bugged LEONARDO Siemens images
3297 2003-10-03 Jean-Pierre Roux
3298 * Odd length strings are padded with '\0' (not with spaces,
3299 to remain compliant with already defined strings,
3300 like Transfert Syntax UID and others)
3302 2003-10-03 Jean-Pierre Roux
3303 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3304 to allow displaying RGB images (not only by affim ;-)
3306 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3307 * vtkGdcmReader is now able to read rgb dicom file.
3308 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3310 2003-10-03 Jean-Pierre Roux
3311 * A few nasty patches to allow the reading of a lot of nasty images
3312 ( e.g : well known GE images with a wrong elem length,
3313 : Philips MRI Images with a wrong Huffman table)
3314 * still to be done : allow the reading of bugged LEONARDO Siemens images
3316 2003-10-03 Jean-Pierre Roux
3317 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
3319 2003-10-03 Jean-Pierre Roux
3320 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3321 to allow displaying RGB images (not only by affim ;-)
3323 2003-10-03 Jean-Pierre Roux
3324 * gdcmFile::GetImageDataIntoVector now
3325 - deals with MultiFrames MultiFragments Run Length Encoded files
3326 - deals with YcBcR (YBR_FULL) files
3327 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
3328 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
3330 (no sample found :-(
3332 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3333 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
3334 Two reasons: - clear things
3335 - third parties acces gdcm through header files, so won't
3336 suffer anymore VC++ complains
3338 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3339 * add argv[1] in testvtkGdcmReader.cxx
3342 2003-09-24 Jean-Pierre Roux
3343 * The lines are now eigthy characters long for
3344 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
3346 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3347 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
3348 char* to std::string. Thus, the use of strdup becomes useless. (see
3349 previous commis of Malaterre)
3350 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
3351 before the last Malaterre's commit.
3353 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3354 * This commit should fix the Debug building under VC++, the problem
3355 was mainly a mixture of debug and release lib being loaded at startup.
3356 * I also remove a depency to a specific C function: strdup. Because I had
3357 to force the link to msvcrtd (whereas strdup is in libc).
3359 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3360 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
3361 located in the gdcmCommon.h file. All use of reference of tha has been
3362 changed to now use the variable GDCM_UNFOUND.
3364 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3366 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
3367 Dicom dictionary. The test suite can now be run again. Note:
3368 I'm note very happy with the " (RET)" changes. I believe this
3369 RETAINED comment should be dropped when parsing the dictionary.
3370 - PACKAGER corrected
3372 - AUTHORS updated and now in alphabetical order
3373 * Makefile.am now exports gdcm.dsw for Windoze users.
3375 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3376 * cygwin complains about missing std:: in subdir Test/
3378 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3379 * remove some methods that are now in gdcmHeaderHelper
3381 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3382 * vtkGdcmReader set spacing and origin correctly
3384 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3385 * Fix a few delete/delete[] mismatch
3387 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3388 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
3389 interpretation to data given by gdcmHeader. For instance there are
3390 heuristics to get informations (look at different places).
3391 * it also include a specific class: gdcmSerieHeaderHelper devoted to
3392 sorting DICOM images based on different strategies.
3393 * modified Makefiles accordingly.
3395 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3396 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
3397 when building in debug mode
3398 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
3399 src/win32/gdcmdll.dsp
3400 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
3402 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3403 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
3406 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3407 * src/win32/libgdcmjpeg12.dsp was not dos format
3408 * src/win32/libgdcmjpeg12.dsp :
3409 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
3410 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
3412 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3413 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
3415 * src/gdcmFile.cxx : bug fix in affectation type
3416 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
3417 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
3418 * Modifs of MVSC projects to compile them. Not concerning 2 identic
3419 symbols... future problem ?
3421 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3422 * src/win32/libgdcmijpeg12.dsp was missing
3423 * modified gdcm.dsw accordingly
3425 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3426 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
3428 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3429 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
3430 commit of JPR (before his hollidays to facilitate our work).
3431 * setup.py : bug fix in code. Modifications made while the last commit
3432 of JPR. The code hasn't been tested before the commit... it's so
3433 useless to make that (for best programmer that is JPR) !!!
3435 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3436 * tagged the current version as Version0_3 (i.e. version 0.3)
3438 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3439 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
3440 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
3441 * *.dsp : modifications to use new libgdcmijpeg8 library
3442 * setup.py : bug fix on VTKPATH variable
3443 * PACKAGER : adding all concerning windows
3445 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3446 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
3448 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
3449 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
3450 test suite reported error.
3451 * PACKAGER file added (describes what a packager must do when
3452 packaging a new release).
3453 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
3454 * configure.in: upgraded version number to 0.3.0
3455 * fixing build of rpm (through rpm -ta):
3456 - Doc/Makefile.am exports proper doxygen files
3457 - src/jpeg/libijg8/Makefile.am exports the include files.
3459 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3460 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
3461 * src/gdcmHeader.h : formatting code
3463 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3464 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
3465 We were obtaining error message from vtk. Now, creation of file list
3466 is made in an internal list to prevent this problem.
3467 Bug fix when output is empty.
3468 Bug fix in update of progress value. Previous commit for this was a bad
3470 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
3472 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3473 * src/gdcmHeader.h : added method to get the file name
3474 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
3475 files. Added method to remove all files on the input
3476 Added FIXME comment concerning the bad parsing of header made by
3477 ExecuteInformation method (in ExecuteData method)
3479 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3480 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
3481 when using make instal.
3482 * src/gdcmFile.cxx : bug fix under Window after JPR commit
3483 RQ : the JPR doesn't appear in the ChangeLog... normal for him
3485 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3486 * setup.py : adding include dir of jpeg lib to compile all sources
3487 * */Win32/*.dsp : JPR fix for windows compilation
3489 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3490 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
3492 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
3493 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
3495 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3496 * setup.py is again effective on un*x (takes into account the
3497 addon of the jpeg library)
3498 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
3499 * Doc/Doxy* updated (includes above enhancements)
3500 * INSTALL now points to web documentation
3502 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3503 * src/gdcmHeader.h doesn't make unnecessary reference to
3505 * gdcmPython/Makefile.am now avoids calling the wrappers for the
3507 * src/gdcm*.[cxx|h] :
3508 - to allow compilation with gcc 3.x
3509 -- clean up of STL usage (added explicit usage of std::)
3510 -- small fixes on exceptions.
3511 Note: linking not tested !
3512 - clean of doxygen comments to avoid warnings at documentation
3514 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
3515 dependent convertion).
3517 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3518 * Clean up of previous JPR garbage commit (not even commented in the
3520 - Test/Makefile.am removed the reference to unexisting testTS.cxx
3521 - moved all jpeg related files from src to src/jpeg/libijg8, with
3522 addition/modification of Makefile.am and configure.in.
3523 - the testSuite is still brain damage (not guilty).
3525 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3526 * WrapVTK.py : modifications to get correctly vtk source files to
3528 * vtk/vtkGdcmReader.cxx : modification for an already existing name
3529 (FileName -> Filename)
3531 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3532 * vtk/vtkGdcmReader.[cxx/h]:
3533 - UpdateProgress method should now be effective
3534 - removed the limitation on having only images loaded (as opposed
3536 - when building a stack of images/volume, a lesser number of
3537 gdcmHeader and gdcmFile instances should be used (hopefully
3538 accelerating things).
3539 - when building a stack of images/volumes, files which are not
3540 loadable (wrong path-filename, wrong permissions on existing file,
3541 or file not parsable by gdcm) are replaced with a black image
3542 in the stack (for the caller to notice the problem).
3544 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3545 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
3547 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3548 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
3549 between standard library (std) and vtk library (problems are found
3550 under Windows... thanks Windows !)
3552 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3553 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
3555 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
3557 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3558 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
3560 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3561 * When compiling with distutils (see setup.py) the C++ compiler is
3562 called with different flags than the default ones (with automake).
3563 In order to fix all those warning, I compiled gdcm with the command
3564 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
3565 and went for warning fixes:
3566 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
3567 up from unused variables.
3568 - vtk/vtkGdcmReader.cxx: potential bug fix.
3569 * src/gdcmHeader.h: Doxygen warning cleanup
3571 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3572 * gdcmPython/gdcm.i:
3573 - typemaps correction to take into account the systematic replacement
3574 of "using namespace std" with std:: prefix e.g. std::list,
3575 std::string... (cf changes of 2003-05-21).
3576 - gdcmGlob global variable of type gdcmGlobal (defined in
3577 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
3578 exported to Python a as cvar.
3579 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
3580 and GetPubDictTagNamesByCategory() as a replacement for deprecated
3581 gdcmDictSet.GetPubDictTagNames() and
3582 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
3583 C++ static methods).
3584 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
3585 with the above changes.
3587 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3588 * setup.py, manifest.in : bug fix under linux
3590 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3591 * Modification of setup.py to compile vtk part too. Then, we have 2
3592 wrappers which must work with same distutils. For that, we have a
3593 generic distutils in distusiltsWrapping.py ; with :
3594 - build_extWrap class to wrap generically all extensions,
3595 - ExtensionWrap base class for all wrapping extension that contains
3597 - Wrapper interface which wrap sources
3598 + In WrapSwig.py we have extension and wrapper for Swig
3599 + In WrapVTK.py we have extension and wrapper for VTK
3600 * MANIFEST.in : modifications to consider vtk directory and new python
3601 files for compilation
3603 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
3604 * Added python wrappers of vtkGdcmReader vtk class (see the
3605 source in vtk/vtkGdcmReader.cxx) :
3606 - vtk/Makefile.am now builds a library
3607 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
3608 python library (as opposed to _gdcm.so wich are the python
3609 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
3610 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
3612 - configure.in has an additional flag --enable-vtk that needs
3613 to be set to enable compilation of vtk related code, that is:
3614 + vtk/vtkGdcmReader.so and
3615 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
3616 + gdcmPython/vtkgdcmPython.so (see above)
3617 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
3618 be read when compressed or when HighBit + 1 != BitsStored),
3619 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
3620 the usage of the python wrapper of vtkGdcmReader vtk class.
3621 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
3622 * src/*.[h] all occurences of stl classes are now prefixed with
3623 std::, and all occurences of "using namespace std;" where removed.
3624 This is to avoid pollution of global namespace in included files.
3625 Apparently vtk does not avoid this pitfall: when using both
3626 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
3627 collision of various stl members (principally cout...).
3628 * gdcmPython/testSuite.py now cleanly removes temprory generated
3630 * gdcmPython/gdcm.i now declares a typemap for std::string (to
3631 comply with above changes)
3633 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3634 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
3635 * vtk/vtkGdcmReader.cxx now properly inports the image in the
3636 vtk data structure (an image Flip was required).
3637 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
3638 * cosmetic changes in documentation.
3640 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3641 * src/gdcmHeader.cxx: the constructor no longer exits when an
3642 unexisting file is given as argument.
3643 * The subdirectory Data (containing all the images used for the
3644 test suite) is not part of this repository anymore. A new module
3645 containing those images is now available at
3646 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
3647 with the name gdcmData.
3648 All the python scripts (including the package initialisation file
3649 gdcmPython/__init__.py) were adapated to take this change into
3650 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
3652 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3653 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
3654 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
3655 demo of the usage of this class.
3656 Compilation of this vtk part is only done when using the --enable-vtk
3657 at configure (or autogen.sh) stage.
3659 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3660 * More memory link related corrections and documentation fixes.
3662 - maximum info is obtained with a command of the form:
3663 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
3664 --show-reachable=yes PrintHeader
3665 - the remaining reachable blocks seem to come from the STL
3666 allocation scheme through the usage of map and list. It looks
3667 like this memory cannot be freed but it is not a memory leak
3668 (in fact further invocation to the STL would recollect the
3669 unused memory allthough it cannot explicitely be freed).
3670 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
3671 of displaying an image parsed with gdcm and displayed with VTK.
3672 Note: some images don't seem to work e.g.
3673 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
3674 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
3675 Allthough this weakens the semantics, it is a ditch attempt to
3676 make gdcm more thread friendly.
3678 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3679 * Memory link hunt (by using valgrind through the command
3680 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
3681 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
3682 gdcmHeader::_dicom_vr.
3683 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
3684 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
3686 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
3688 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3689 * src/Makefile.am now exports all the necessary include files at
3693 * UpdateGroupLength replaced by new one
3696 * UpdateGroupLength re-written using H-Table
3697 (named UpdateGroupLengthNew untill checks are over)
3699 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3700 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
3701 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3703 - gdcmHeader::GetPubElValSet removed.
3704 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3705 UpdateGroupLength, WriteElements, Write.
3706 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3707 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3708 carried the same semantics.
3709 - src/gdcmHeaderIdo.cxx changed accordingly.
3710 - gdcmFile::WriteBase now regroups all the codes from previous
3711 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3712 - enum FileType moved to gdcmCommon.h
3713 * src/gdcmHeader.cxx AddDefault trashed
3714 * gdcmGetXSize added
3715 * getimageDataSize now calls gdcmGetXSize
3716 * Test/*.cxx changed to agree with above changes
3718 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3719 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3720 (to avoid double call by end user).
3721 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3722 by end user, since gdcmHeader::gdcmHeader now handles it.
3724 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3725 * gdcm/Doc many doxygen changes:
3726 - Doxyfile now has two different versions, DoxyfileUsers that generates
3727 the html.users end users oriented documentation and
3728 DoxyfileDeveloppers that generates the html.developper developper
3729 oriented documentation.
3730 - README changed accordingly
3731 - requirement.txt removed (old design info moved to TODO).
3732 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3733 DoxyMainPage.txt, DoxyPython.txt provide more information.
3734 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3735 be updated by simply regenerating the docs with doxygen and copying
3736 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3737 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3738 all the tests in the form "if (<map>.count() >1)" were removed.
3739 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3740 ill-formed documentation sections.
3741 * src/gdcmHeader.cxx: ditto
3743 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3744 * setup.py fixed for un*x (needed macro for stdint.h)
3745 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3746 un*ces with sh-utils test utility.
3747 * gdcmPython/demo/test.py renamed to PrintHeader.py
3748 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3749 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3750 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3751 * src/gdcm*.cxx JPR's bad inclusion fixed.
3753 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3754 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3755 * gdcmPython/demo/test.py changed accordingly.
3757 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3758 * gdcmPython/Makefile.am fixed linking against libstdc++
3759 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3760 * Swig subdir (historical tests of swig version 1.3.17++) removed
3761 * Test/testChangeEntete.cxx some lines commented out in order to make
3763 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3764 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3766 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3767 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3768 hence the user doesn't need this explicit call.
3769 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3770 i.e. LoadElements() call removed.
3771 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3772 - src/Makefile.am declares the proper flag for g++.
3773 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3774 for adding user defined new tags.
3775 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3776 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3777 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3779 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3780 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3781 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3782 src/Makefile.am : the project should properly compile and install
3783 with the autotools, included the python wrappers part.
3784 * gdcm.spec.in : added a spec file for RPM packaging.
3786 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3787 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3789 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3790 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3791 to exported to the environement (see gdcmPython/testSuite.py
3793 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3794 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3795 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3796 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3797 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3799 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3800 * gdcmPython/__init__.py doesn't crash anymore when running in
3801 in InstallMode or PreInstallMode but with an environment given
3802 value of GDCM_DICT_PATH.
3803 * src/gdcmDictSet.[cxx/h] coding style.
3805 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3806 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3807 * src/gdcm.h general comments moved to TODO, and README
3808 * src/gdcm.h should now be seen as a user commodity (including it
3809 should suffice to fully use gdcm). It is nowhere including within
3810 any of the kernel files src/*.cxx and src/*.h.
3812 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3813 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3814 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3816 * src/gdcm*.cxx only include their corresponding include file
3817 (as opposed to gdcm.h)
3818 * gdcmPython/gdcm.i changed accordingly
3819 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3820 the autogen.sh generated "make snapshot" command to work.
3821 * autogen.sh removed history related references to crea package.
3823 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3824 * distutilsSwigCPlusPlus.py work around some swig portability
3827 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3828 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3829 was done in a last ditch attempt to get setup.py _really_
3830 operationnal. The python/gdcmPython layaout add the advantage
3831 of hidding away the python related distutils specific files
3832 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3833 Alas, the src directory was out of scope (i.e. it's relative
3834 position to setup.py was ../src) which made things impossible to
3835 handle (see previous version of python/setup.py). Crossing fingers...
3837 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3838 * python/setup.py now works on Un*x. (harder than I thougth)
3839 * python/distutilsSwigCPlusPlus.py can now have include files
3840 among the list of sources.
3842 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3843 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3844 * modifications in MSVC projects
3846 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3847 * As stated by the first lines of Test/ExceptionAndPython/README, it
3848 looks like we can move back to original usage of exception within
3849 src/gdcm* and hence remove the errno stuff that was introduced
3850 as a quick and dirty fixture of this problem (added to the TODO).
3851 * Doc/Doxyfile configuration file for Doxygen and corresponding
3852 README file for usage added.
3853 * Test/testWrite.cxx added. This new test comes from a split of
3854 test.cxx that is now reverted to its original purpous i.e.
3855 testing the proper parsing of a Dicom related file.
3856 testWrite.cxx concentrates on testing the IO part of gdcm.
3857 * Test/bug1.cxx (containing a bug on WIn32) added.
3858 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3859 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3860 whose purpose is to publish the content of the TagNames of the
3861 Dicom public dictionary were not accessible without an
3862 instance of class gdcmHeader.
3863 - those methods are now static methods of gdcmDictSet and hence
3864 require no instances at all to be invocated.
3865 - within gdcmDictSet this change required to change some method
3866 to class methods (i.e. are now static) among which SetDictPath
3867 (renamed to BuildDictPath) and LoadDefaultPubDict.
3868 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3869 the above changes by calling the new method classes of gdcmDictSet.
3870 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3871 the above to be effective.
3872 * python/gdcmPython: in order to wrap properly the above changes
3873 for Python, swig version now needs to be > 1.3.17.
3874 * python/gdcmPython/Makefile fixed to adapt itself to new
3875 configure/make shema introduced by Johan Montagnat (thanks for the
3876 contribution). Alas this Makefile cannot be turned into a proper
3877 Makefile.am without some heavy changes in the configure.in
3878 (for python dectection).
3879 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3880 now avoids publishing the empty entries.
3882 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3883 * python/setup.py : bug fix concerning install under windows
3884 ExtraPath reused :-P
3885 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3887 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3888 * Dicts/dicomV3.dic : remove double spaces !!!
3889 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3890 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3893 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3894 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3895 method. Doxygenation.
3896 * src/gdcm.h clean up of JPR spurious comments.
3898 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3899 * python/distutilsSwigCPlusPlus.py now properly collects the
3900 shadow classes generated by "swig -c++" (gdcm.py in our case)
3901 when using "python setup.py install".
3902 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3903 reexports the working classes.
3904 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3905 by the classical C errno scheme. This is to prevent an obscure
3906 behavior of the python wrappers when importing wxPython.wx prior
3907 to gdcmPython (which ended up in an abort call). An illustration
3908 of this oddity can be found in the Test/ExceptionAndPython
3909 subdir (see the README file). This problem probably due to
3910 an combination of g++ and dynamic loading.
3911 * added Test/ExceptionAndPython (see above)
3913 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3914 * Changed the layout of the python part to avoid bloating main
3915 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3916 i.e. the distutils arsenal. All the python related stuff is
3917 again in a python subdir, but the package itself is now in
3919 * setup.py was cleaned up:
3920 - pythonIncludePath removed
3921 - python setup.py bdist target is now functional.
3922 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3923 collision with other packages). gdcmPython/demo/*.py changed
3926 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3927 * python subdir moved to gdcmPython (preparation of distutils packaging).
3928 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3929 distutils installer is operational.
3930 * - gdcmPython/__init__.py now properly loads the swig generated
3931 shadow classes (from gdcm.py).
3932 - gdcmPython/demo/*.py changed to import the package gdcmPython
3933 instead of gdcmPython/demo/load.py.
3934 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3936 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3937 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3938 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3939 entries within the associated public Dicom dictionary resp. the same
3940 information but sorted by the fourth field (PAT, IMG, DIR) of the
3942 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3943 are now in the "???" group.
3944 - python/gdcm.i changed accordingly,
3945 - python/demo/printGroupedPublicDict.py added, that gives an example
3946 of the above new functionalities in Python.
3948 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3949 * src/gdcm.h, gdcmHeader.cxx:
3950 - historic references to glib's g_malloc and g_free (#defined)
3951 were definitively removed.
3952 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3953 * src/gdcmElValSet.cxx:
3954 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3955 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3956 - GetElValue(string) renamed to GetElValueByName.
3957 - Added GetElementByName(string).
3958 * src/gdcmHeader.cxx: added
3959 - GetPubElValRepByNumber(guint16, guint16)
3960 - GetPubElValRepByName(string)
3961 - GetShaElValRepByNumber(guint16, guint16)
3962 - GetShaElValRepByName(string)
3963 - GetShaElValByNumber(guint16, guint16)
3964 - GetShaElValRepByName(string)
3965 - GetElValRepByNumber(guint16, guint16)
3966 - GetElValRepByName(string)
3967 - GetElValByNumber(guint16, guint16)
3968 - GetElValRepByName(string)
3969 * Doc/requirements.txt added.
3971 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3972 * Test/Makefile building now depends on the one of libgdcm.so
3973 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3974 pixel data) aware which enables finding the address (offset) of
3975 the pixel data of JPEG encoded DICOM files. This leaves only a single
3976 file in the testSuite whose pixel data address (offset) is unknown.
3977 * python/testSuite.py changed accordingly.
3979 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3980 * VC++ has some strong limitations when working with the STL, as stated
3981 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3982 "Also note that some STL containers (map, set, queue, list, deque)
3983 cannot be exported. [...]
3984 Some STL classes contain nested classes. These classes can not
3986 This is caused by a designed limitation that once a template
3987 class is instantiated, it can not be re-instantiated and
3989 Since our usage of map<> is ubiquitous in gdcm, this "designed
3990 limitation" of VC++ is a pitfall.
3991 Hence the Python wrappers of gdcm cannot be incrementally linked
3992 against the c++ dynamic library. The dirty but only workaround is
3993 to forget about incremental link of dynamic libraries and to generate
3994 the Python wrappers library with the inclusions of the underlying C++
3996 The following modifications concern this matter on Win32/VC++:
3997 - wrapping python correct with standalone wrapped dll (don't use separate
3998 dll under windows !!!!)
3999 - python21_d debug mode enabled (ask Frog how to use it :-)
4000 - NO problem with having an STL member of class for example string in C++
4001 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
4002 - Python test of dcmlib in Python is ok under windows on a large set
4004 * removed glib references
4005 * typedef's inserted in gdcm.i for correct swig type management
4007 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4008 * python/demo/*.py load.py extracted from test.py. Added explore.py
4009 that only displays required tags and testAll.py that parses all
4010 the files of the testsuite without using unittest.
4011 * python/testSuite.py other additional test on new files added.
4012 * Data/* new test files added accordingly to the testSuite.
4013 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
4014 the vr in the file differs from the one of the dictionary.
4016 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4017 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
4018 values, but limits itself to values which are below a user specified
4019 size (by default 1024 bytes).
4020 * python/gdcm.i : elements not loaded (because their size is above the
4021 user specified treshold) are exported with their TagKey as key of the
4022 python dictionary. This enables the testsuite to make some checks
4023 on the unloaded elements (since we have their offset and size).
4024 * python/testSuite.py
4025 - now tests for the existence and proper value of the pixel data
4026 - two new examples added.
4027 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
4029 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4030 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
4031 aware. See the strategy comments in gdcmHeader::FindLength().
4032 * Test/test.cxx now accepts a filename as first argument.
4033 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
4034 * python/testSuite.py changed to integrate test on above files.
4036 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4037 * Dicts/dicomV3.dic removed all the trailing (RET) when the
4038 the vr was also RET.
4039 * python/testSuite.py more tests added.
4041 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4042 * python/testSuite.py unittest test suite added (uses Data)
4043 * Data/* dcm and acr files for the test suite.
4044 * glib dependance removed from un*x version. We now use ISO C99
4045 7.18 Integer types (see stdint.h)
4046 - python/Makefile, src/Makefile src/gdcm.h
4047 * src/ when an explicit vr (like dicom files) suddenly poped an
4048 implicit element we use to mark the underlying DictEntry of the
4049 concerned ElValue with "Implicit". This strategy was damageable
4050 too the public or provite dictionaries, since some of their vr
4051 would be changed. Since Header::FindLength heavily relies on the
4052 detection by Header::FindVR of falsely explicit elements, I
4053 added an extra ImplicitVr member to ElValue (boolean).
4054 The rest of the changes we the necessary adaptations.
4056 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4057 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
4059 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
4061 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4062 * Adaptation for porting to VC++:
4064 o forced to use std namespace (for string to be known)
4065 o all class use __declspec export style on WIN32
4066 - src/gdcmUtil.cxx new Exit method that wraps the exit call
4067 (in stdlib.h on Win32 but in std:: for gcc)
4068 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
4069 variable GDCM_DICT_PATH.
4070 * src/gdcmHeader.cxx verbose comments made discrete.
4072 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4073 * python/gdcm.i: added a typemap that converts a C++ hashing table
4074 to native Python dictionary.
4075 * python/demo/test.py:
4076 - now uses the native dictionary for exploration of gdcmHeader.
4077 - takes an optional filename argument (the file to parse).
4078 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
4079 PubElVals hashing table.
4080 * Dicts/dicomV3.dic removed error prone trailing spaces.
4082 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4083 * Python wrapping process moved away from src/Makefile to
4084 newly created python/Makefile (as well as gdcm.i)
4085 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
4086 * src/gdcmHeader::FindLength only looks for current vr when necessary.
4087 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
4088 from the environement variable GDCM_DICT_PATH (when existing).
4089 * src/gdcmDict::GetTag bug fix.
4091 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4092 * Straightforward temporary fixes for swig to build the python wrappers.
4093 src/Makefile now has a python working entry [by working we mean
4094 that we can import the shadow classes without errors].
4096 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4097 * hashtest.cxx removed (since already in Test)
4098 * src/gdcmlib.h renamed to src/gdcm.h
4099 * src/dcm.i renamed to src/gdcm.i
4100 * src/Makefile prepared for python wrapping
4102 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4103 * src/gdcmHeader.cxx :
4104 - Parsing of header is now separated from loading of element values
4105 (see gdcmHeader::LoadElements).
4106 - general clean up of hopefully all file access (creation of
4107 ReadInt16 and ReadInt32)
4109 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4110 * src/gdcmHeader.cxx :
4111 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
4113 - SetLgrElem renamed to SetLength
4114 - GetLgrElem renamed to GetLength
4115 - ~gdcmHeader() made virtual to pesky warning messages at compile.
4116 * src/gdcmElValSet.cxx fixed both GetElValue methods
4117 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
4118 due to IdoDude was cleaned out.
4120 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4121 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
4122 concentrates on finding the value representation (when it exists).
4123 RecupLgr now only finds the element value length, and it avoids
4124 returning the unecessary skL (skipped length).
4125 Also, offsetCourant was simply removed (with taille_fich) since
4126 it was redundant with the File position internals (by using
4127 ftell and fseek). This also made skL (see above in RecupLgr) usage
4129 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
4130 on the libido specificities which are handled through class
4132 * Test/implicit_vr.dcm dicom v3 in implicit value representation
4135 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4136 * Truckload of changes. Parsing of header is barely functional
4137 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
4139 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4140 * src/gdcmHeader.cxx many addons of low level methods
4142 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4143 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
4144 and _IdDcmSWAP_LONG.
4146 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4147 * This corresponds to all the changes decided at the meeting of
4148 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob