1 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
3 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
4 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
5 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
6 So can't you use __int64 in ostream at all.
8 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * bug fix for compilation on MSVC6
10 * gdcmPython/gdcm.i : rename of classes missed
12 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
14 type and not a string. So, there remove problems on the format of the
17 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
19 Thus, DicomDirXXX are created with a flad that indicates if the created
20 object is empty or not (when not empty, the DicomDirElement is used to
23 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
25 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
27 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
30 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
32 Remove all access to the hash-tables or lists in the objects.
34 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
36 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
37 be complient with all the gdcm source code
39 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
43 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
47 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * Test/ : rename VTK tests to have a best name for the tests
49 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
50 GetFirstEntry/GetNextEntry use
52 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
54 test. Now it's on image content and not on the resulting visualisation...
55 might solve the problem on linux when using the OpenGL drivers
57 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
58 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
59 DicomDirSerie, DicomDirImage
60 Dict, DictSet classes :
61 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
62 -remove InitTraversal method.
63 * UPD Test programs + Example programs
65 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
66 remove useless and never updated keyword \ingroup
68 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
70 is no memory access violation
71 * gdcmPython/demo : add python demos using VTK
73 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
74 * FIX 'Dictionnary' is now spelt 'Dictionary'
75 'wether' is now spelt 'whether'
76 'archieve' is now spelt 'archive' ;-)
78 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
79 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
80 related methods, in order not to expose internal mechanisms
83 * REM methods that exposed internal mechanisms :
84 DicomDir::GetDicomDirPatients()
85 DicomDirPatient::GetDicomDirStudies()
86 DicomDirStudy::GetDicomDirSeries()
87 DicomDirSerie::GetDicomDirImages()
98 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
99 * Removed the Print/indent/default parameter mess. There is absolutely no
100 reason to have to methods, moreover with the second taking the ostream as
101 *SECOND* parameter. This was clearly a bad hack to get things compile.
103 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
104 * Complete rewrite of the GetMacAddress code. Now the code is *much*
105 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
106 Unfortunately the main code does not work on SunOS, thus provide a specific
107 code for this platform only (and Win32 of course). Since this seems to be
108 working, change CreateUniqueUID to use GetMACAddress instead of the
109 problematic GctestetIPAddress
111 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
112 * Unfortunately to be able to test gdcmDirList I had to break the API
113 a little. Now the class is not a std::list anymore but has a member
114 std::vector (more ITK compatible). Allow unit testing on Win32 and
117 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
118 * Update SerieHeader to take into account a Serie Instance UID to properly
121 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
122 * ENH - Comment out Mathieu's (dangerous) Super Hack
123 for dealing with BIGENDIAN processors
124 - Move equivalent stuff to BinEntry::WriteContent
125 When necessary, 16 Bits Pixels are swapped in a small buffer
126 and then written. This avoid allocating a huge buffer, in
127 PixelWriteConvertor, and avoid modifying the Pixel Area.
129 Probabely, the same operation will have to be done when we want
130 to write image with Big Endian Transfert Syntax,
131 and we are working on Little Endian Processor
133 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
136 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
137 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
138 all the dict content.
139 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
141 * Test/TestDict.cxx : add a new test for the dict classes
143 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
144 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
145 file. Debug is yanked if compiled with NDEBUG
147 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * src/gdcmDictSet.h : set the default output to the os variable
149 * src/gdcmDictEntry.[h|cxx] : add the Print method
150 * gdcmPython/demo/ : add a new test
152 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
153 * merging of Test/PrintDicomDir and Test/TestDicomDir
154 * removal of now redundant Test/PrintDicomDir
155 * enhancement of Example/PrintDicomDir
157 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * Now, python test might work on systems
159 * Add the PrintDicomDir test
161 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
162 * FIX : First entry following group 0002 was lost for
163 Explicit Big Endian Transfer Syntax files
164 (group and elem not swaped)
166 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
167 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
168 Big Endian Transfer Syntax supposed the group following 0002
169 begins always by element 0000 (element 0000 is *optional*)
170 To avoid further troubles, let's be pessimistic, and use
171 Document::HandleOutOfGroup0002() method
172 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
173 (related pb not yet solved)
175 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * Bug fix for the python part use
177 * Now, PrintHeader.py pass... but outside the ctest use. shit !
179 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
182 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
183 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
184 a string and should ask the global TS dict what are the propreties of
187 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
188 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
189 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
190 to swap the Swap Code, at parsing time, when we come out of group 0002
191 and Transfer Syntax is Big Endian
192 We should be able to read now 'true DICOM" Big Endian coded images
193 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
194 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
196 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
197 * Hopefully fix the bug on MacOSX and static global initialization.
198 This is the only -minor- patch I found that both please MacOSX and VS6.
199 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
200 but this would require a lot of change. Another approach would be that Global
201 create those string and GDCM_UNFOUND becomes a pointer to a string (which
202 gdcm::Global would destroy at exit).
204 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
205 * Fix bug on MacOSX with static initialization in a multy threaded
206 environment. static const string in a header file used to be ill
207 initialized provoquing the freeze of any tests. patch should solve this
210 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
211 * According to Benoit's suggestion, and without any objection from anybody
212 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
213 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
214 - method gdcmDicomDirObject::GetEntry() renamed as
215 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
217 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
218 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
219 you debug/warning message just as c++ streams which make them very convinient
220 to use. Once this is stabilize I will change the ostringstrem to be
221 redirected to a file (ofstream).
222 * Properly support C99 extension: __FUNCTION__ which allow us to display
223 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
225 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
226 * Removal of useless and dangerous methods :
227 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
228 GetDocEntryByName, GetEntryByName, GetDictEntryByName
229 * Removal of usless methods :
230 Dict::PrintByName, Dict::GetDictEntryByName
231 * Commenting out of probabely useless methods :
232 Dict::GetDictEntryNames()
233 Dict::GetDictEntryNamesByCategory()
234 DictSet::GetPubDictEntryNames()
235 DictSet::GetPubDictEntryNamesByCategory()
236 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
237 * ENH : Use dicomTS.dic as described in 2004 version
238 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
239 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
240 Add Accessors on VM (Value Multiplicity), and VM related methods
241 * ADD : Add a list of 'Dicom Attribute types', as found in
242 http://medical.nema.org/dicom/2004/04_15PU.PDF
244 * ADD : Add dicomGroupNameAbbreviations.dic
245 should be used to write a method to replace the former
246 Dict::GetDictEntryNamesByCategory()
248 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
250 to read in the file... and only it ! Length is the efective length of the
251 data in the DocEntry structure
253 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
254 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
255 And now use a static function call instead, with a global variable. i
256 This is much closer to the VTK approach. Hopefully should be bulletproof
257 and easier to use...hopefully
259 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
260 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
262 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
265 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
267 ValEntry, BinEntry, SeqEntry creation or replace
269 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
271 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
273 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
274 when specifying the VR
275 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
276 * src/gdcmDocEntry.cxx : amelioration of print
278 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
279 * ADD : Add the method Util::IsCurrentProcessorBigEndian
280 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
281 * ADD Method Document::ComputeGroupLength
282 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
283 in order to allow further VR modification by user
284 * REM : removal of once-called method File::WriteBase
285 integration of its code in formerly one-line method File::Write
287 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
289 replace the different values "??", "Unkn", "Unknown".
290 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
291 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
292 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
293 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
295 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
296 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
298 * Set the gdcm::Base class to some Printable classes
300 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
301 * src/gdcmFile.[h|cxx] : add the Print method
302 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
303 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
304 * src/gdcmDocument.h : remove the PrintLevel informations
305 * Example/PrintFile.cxx : use the new gdcm::File::Print
307 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
309 problems when compiling with the python wrapping
311 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
313 writting in ImplicitVR
315 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
316 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
317 JPEG decompression, especially when dicom frames are split into several
318 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
319 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
321 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
322 * src/gdcmHeader.cxx : change the initialisation of default header.
323 Now, this header is readable by gdm, e-film, DicomWorks
325 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
326 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
327 Rename Decompressed to Raw
328 * Use the API changes in gdcm::File.
329 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
332 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
333 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
334 each added entry in the header. Replace the 'Planes' field by the 'Number
337 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
339 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
341 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
343 At this time, this image isn't readable by e-film... waiting JPR help to
346 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
347 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
348 DocEntry. Now use methods of the Document !
350 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
351 * Test/ShowDicomSeq.cxx : bug fix
353 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
354 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
355 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
356 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
357 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
359 * Test/TestCopyRescaleDicom.cxx : remove unused variable
360 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
361 containing found sequences
363 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
364 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
366 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
367 Some fields in BinEntry must be copied to not seg fault when making the :
368 gdcm::File *copy = new gdcm::File( copyH );
369 and tests are now made on good variables
371 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
372 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
373 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
375 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
376 * Add vtkGdcmWriter example and test
378 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
379 * Test/TestUtil.cxx : reformat the source code
380 * vtk/vtkGdcmReader.cxx : remove and change prints
381 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
383 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
384 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
386 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
387 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
388 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
390 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
391 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
392 by an eof to prevent all bad read of the file... and in this case, the
395 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
396 * Example/Volume2Dicom.cxx : comment unused variables
397 * Test/PrintDicomDir.cxx : comment unused variables
398 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
399 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
400 method that is redondant with AddEntry.
401 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
404 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
405 * Bug fix due my last commit (compilation under Windows).
406 * Example/Volume2Dicom : bug fix in the file and reformatting source code
407 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
409 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
411 - Remove printf / sprintf
412 - include iostream AFTER gdcm so we don't get warnings
413 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
415 - Also remove tons of include from header files, hopefully this should
416 speeup the compilation time, since it was becoming a dog slow.
417 - Remove gdcm.h as it include way too many files and slow down compilation
418 (plus it is not up to date)
419 - remove 'using namespace std' this is BAD !
421 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
422 * Remove memory leaks on the DicomDir
423 * Remove some useless data in DicomDirObject
424 * Add usefull methods in SQItem, to be complient withe the ElementSet
426 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
427 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
429 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
430 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
431 future, with convertion)
432 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
433 and ImageDataSize values. Remove the method to get the PixelReadConverter
434 from the output of the class
436 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
437 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
439 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
440 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
441 and vtkErrorMacro use.
442 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
444 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
445 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
447 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
448 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
449 The string leaves only in the fonction. So when we make a .c_str(), we
450 get the pointeur on the first element, element that will be destroyed
451 immediately after thee instruction.
452 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
453 file has been opened : the test must be made on the content of the
454 pointer and not directly on the pointer !
457 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
458 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
459 the python part recompiles
461 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
462 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
463 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
464 X session is killed (for my computer... it seems to not be identic on
467 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
468 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
469 avoid problems (otherwise, the difference test between the visible image
470 and the reference is incorrect. If the reference is greater than the
471 screen resolution, it's produce errors).
472 Can be used for only one image. Can be used with a visible flag.
473 * vtk/vtkGdcmReader.cxx : remove commented codes.
474 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
475 under windows at compilation
476 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
478 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
480 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
481 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
482 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
483 tests on the image size X, Y, Z
485 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
486 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
487 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
488 between the class name and the file name
490 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * src/ : fix compilation warnings for the Write method (2 different
492 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
493 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
494 variable... create a static method in gdcm::Document to access to
495 this variable content.
497 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
498 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
499 file, to be accessed by other files (like gdcmFile). Remove commented
500 code. Move the change of the header to the gdcmFile, using the
502 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
503 To be sure of that (and simplify calls), the Write of the header now
504 gets a file name and not a file pointer (std::ifstream).
505 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
506 DocEntryArchive. Remove all open of the written file
508 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
509 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
511 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
512 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
513 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
515 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
516 some corresponding methods. Write correctly the file and check before
518 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
519 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
520 is now on RGB data (as before my last commit
521 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
523 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
525 Add a print information of the type of the entry
526 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
527 It was in the gdcmFile, and all write have been regrouped
528 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
529 Write correctly all dicom files (in decompressed mode only at this time)
530 * Test/ : test on files are now made using Raw data and not color data if
532 * Example/PrintFile.cxx : add more printings
534 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
535 * Amelioration of code, remove some code copy. For the loading of
536 BinEntry (in gdcmDocument), add the test to verify if the file is already
539 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
540 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
541 remove a DocEntry in the header (push an empty DocEntry)
542 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
543 lines. Bug fix in the initialization of the PixelConvert and the
545 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
546 use in TestCopyDicom (now this test can run under windows... but fails)
547 * Test/TestCopyDicom.cxx : amelioration of the test :
548 - test the pixels written
549 - add test points to quickly find where is the error
550 - can set a file name input and output in arguments
551 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
552 amelioration of the test output
554 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
556 all replaced DocEntry's
557 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
558 Now, each needed DocEntry to modify is duplicated, modified and inserted
559 to the header using DocEntryArchive. Thus, after save, we can restore the
560 header initial state.
562 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
563 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
565 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
566 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
567 correct to copy it. The DictEntry is specified at the DocEntry creation,
568 then, it musn't change in the time.
569 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
570 header correctly. At this time, the change is only made for the first
571 level of the Document. In the future, it might consider sequences.
572 The change is made by replacing a DocEntry by an other that is created
573 outside the class. The old value is kept. When we restore the header
574 status, the added DocEntry is deleted and replaced by the old value.
575 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
576 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
577 set the write type to explicit VR, implicit VR or ACR. Add methods to set
578 the write mode to native, decompressed or RGB (but not used at this time)
580 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
581 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
582 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
584 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
585 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
586 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
588 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
589 set because already copied when copying the BinEntry's of the header
590 * Test/TestAllReadCompareDicom.cxx : remove warnings
592 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
593 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
594 Two problems appear when doing it :
595 - with the gdcmFile : when the GetImageData method is called, the pixels
596 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
597 data (pixels). And each structure destruct the data when it's
598 destructed. So we have two destructions for the same data. To solve it,
599 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
600 data or not. If it doesn't own data, then they will not destroyed by
602 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
603 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
604 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
605 create a double destruction of the same DocEntry's. So, to solve it,
606 the TagHT is simply cleared and the DicomDir* elements are destroyed.
607 * TODO : add an entry concerning memory leaks in the DicomDir
609 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
610 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
611 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
614 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
615 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
616 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
617 after it have been deleted
619 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
620 * FIX: src/* fix the doxygen warnings.
621 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
622 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
623 was erroneously defined with a size of 15 instead of 16. [many thanks
624 to Jean Michel Rouet for pointing out this bug].
626 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
627 1. Finish merging JMR patch for writting DICOM from scratch
628 2. Fix -hopefully- bug with MONOCHROME and space vs null character
629 3. Use const ref when possible
630 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
631 5. A few more comments
632 6. CreateUniqueUID can now be called without parameter"
634 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
635 * ENH: Slightly bigger patch:
636 1. Getting toward full integration of JMR patch for writting dicom from scratch
637 2. Update Test to test part of this patch: CreateUniqueUID
638 3. File was not close properly in gdcmDict
639 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
640 5. Use of const ref instead of copy (speed issue)
641 6. Remove temporary (duplicate) string in TranslateToKey
642 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
643 8. Do not repeat virtual in subclasses
644 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
646 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
647 * Apply first patch toward better string comparison when dealing with broken
648 DICOM files. Essentially the string could be padded with a space instead
649 of a null character as defined by standard
651 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
652 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
653 because never used... and in the same time, that's remove some memory leaks
655 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
656 * src/gdcmFile.cxx : now delete the PixelConvert instance.
657 * In examples and tests : change the type of image data variables from void*
658 to uint8_t*. Remmove all delete on image data variables
660 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
661 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
662 Verify the file pointer value before open the file, and if it's not null,
663 a verbose message is generated.
664 Close correctly the file when the file isn't considered dicom-like. The
665 correctly close is a call to CloseFile.
666 When closing the file pointer, test if its not null to close the file.
667 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
668 file. For an uncompressed image, the copied data correspond in the least
669 case to the image size (calculated) or the image size specified in the
670 header. A verbose is generated if these two size mismatch
672 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
673 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
674 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
675 break under windows (with msvc6 compilation).
677 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
678 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
679 compiling with MSVC6)
681 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * Bugs fix for the Windows build with VC6
683 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
684 needed (only for projects required VTK). If the VTK is included in all
685 projects, there is conflicts with the jpeg lib of vtk when compiling the
686 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
687 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
688 when compiling the gdcm_wrap.cxx file (created by the compilation of the
690 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
691 (like it's already made for the cout use). Otherwise, conflict with the
694 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
695 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
697 - comments on the DicomDir::Method related usage added.
698 - now that we use the namespace gdcm, a lot of internal classes do
699 NOT need to be wrapped anymore.
700 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
701 DicomDir::Method) new example added.
703 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
704 * Improve string manipulation. I now inforce the notion of 'DicomString'
705 A DicomString can contain as many \0 as they want
706 and it is *always* of even length.
707 We only support odd length for very rare case.
708 And in the near future this should be removed.
710 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
711 * /binary_write/ gdcm source. Now even on big endian we are writting
712 little endian. This should -heopfully- fix some tests
714 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
715 * Now the dictionary is compiled into gdcm lib. This is a default
716 behavior, thus any dic file specified is picked before failback to
717 the one comiled into lib
719 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
720 * Change internals for gdcmDict. Don't use any 'new' any more.
721 This should definitely solve any leak problem, and we should be
722 as fast as before, as long as don't modify too much the dictionary.
724 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
725 * STYLE: ivars should start with a capital letter.
726 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
727 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
729 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
730 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
731 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
732 new 2004 dictionaries added (thanks to JPR).
733 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
734 * CLEANUP_ROUND (15) for gdcmPixelConvert
735 - RLEFrame::NumberFragments is now of type unsigned int
736 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
737 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
740 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
741 * Initial work in gathering all transfer syntax accessors. clearly
742 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
743 ivars, but only one transfersyntax (class) ivar with equivalent method on
746 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
747 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
748 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
749 discussed (plus I didn't like having a 2000 lines patch not commited)
751 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
752 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
753 * CLEANUP_ROUND (14) for gdcmPixelConvert
754 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
755 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
756 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
758 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
759 anymore and hence avoids storing a copy of PixelConvert::Decompressed
760 into File::Pixel_Data.
762 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
763 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
764 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
765 * CLEANUP_ROUND (13) for gdcmPixelConvert
766 Substituted File::ParsePixelData() with PixelConvert::Print() new
768 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
769 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
770 method to those classes.
771 - src/gdcmFile.[cxx|h]:
772 -- Added a ::Print() method.
773 -- PixelConverter is now a reference instead of a member.
774 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
775 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
777 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
778 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
779 collaboration diagram and inheritance diagram should be generated with
781 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
782 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
783 pointlessly wrapped (see
784 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
785 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
786 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
787 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
788 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
789 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
790 -- File::Initialise: PixelConverter setup moved away to
791 PixelConverter::GrabInformationsFromHeader()
792 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
793 interpretation moved away to PixelConverter::BuildRGBImage()
795 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
796 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
797 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
799 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
800 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
801 displayed on Win32 when a brutal abort() occurs (because of uncatched
802 exception). See TODO new entry of this commit for more on this.
803 * TODO added new entry.
804 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
805 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
806 - HandleColor is no longer called from gdcmFile.cxx
807 - gdcmPixelConvert.cxx clean up on method arguments and internal
808 variable names for semantical coherence.
810 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
811 * Finished lossless transition, not only do we now read all lossless jpeg
812 images, without the need of the Cornwell lib, but we do read them properly now
813 * To reduce code (well to avoid code duplication), I defined a common place
814 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
815 redefine symbols. This is not perfect but this the best solution I found for a
816 compilation time jpeg option.
818 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
819 * Update jpeg ijg lib to support lossless jpeg implementation
820 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
822 * Also added a special copyright for dcmtk since we use their bugfixes.
825 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
826 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
827 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
828 matters, as stated in warning note at begining of %include section).
829 * src/gdcmDicomDir*.[cxx|h]: coding style
830 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
831 * src/gdcmJpeg8.cxx: doxygen fix.
832 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
833 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
834 from File:: to PixelConvert::.
836 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
837 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
838 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
839 - more code moved away from File:: to PixelConvert::
840 - fat setup of PixelConverter set in place in File::Initialise.
842 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
843 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
844 namespace at the file system level. So now you should convert your examples
846 gdcmHeader -> gdcm::Header
847 It would be nice if people keep in mind to no open the namespace, since it
848 allows compilation on broken plateform which were defining common symbol in
849 the standart namespace (like LP, Unknown ...)
851 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
852 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
853 The JPEG fragments are now parsed at the same stage than the RLE
854 information. All code related to JPEG is now in gdcmPixelConvert:
855 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
856 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
857 export a gdcmFile:: method. Those are simply global functions
858 (for the time being this is better than having them attach to
859 either gdcmFile:: or gdcmPixelConvert::).
860 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
861 and stores the result in a gdcmJPEGFragmentsInfo.
862 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
863 code (among other stuff) moved away from gdcmFile:; to
866 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
868 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
869 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
870 clean up of RLE related code.
871 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
872 - src/gdcmRLE.cxx removed
873 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
874 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
875 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
876 * CLEANUP_ROUND (9) for gdcmPixelConvert
877 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
878 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
879 away from gdcmFile:: to gdcmPixelConvert::.
881 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
882 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
883 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
884 This is because Parse7Fe0 used to parse the pixels to compute the
885 length. This task was passed over to FindDocEntryLengthOB() a long
886 time ago, EXCEPT I had forgotten the OW case...
887 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
888 we just recylce the code for parsing RLE fragments and computing
890 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
891 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
892 with the retired Parse7Fe0().
893 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
894 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
896 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
897 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
898 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
899 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
900 - src/CMakeLists.txt: alphabetic order reodering + new entries.
901 * CLEANUP_ROUND (4) for gdcmPixelConvert
902 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
903 to return an unused length.
905 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
906 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
907 this should be cleanner from the plane view. The iostream are erally a pain
908 to use to do simple stuff.
910 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
911 * Redo the compilation of the ijg jpeg library. Now only one source is
912 necesseray. No need to rename file by hand what so ever. CMake handle the
913 copying of the file within different directory, configure header file to
914 modify some symbol. The only addition made to ijg wasd a mangle table so
915 that symbol are different whether we are within 8bits or 12bits.
917 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
918 * Added documentation of vtkgdcmReader on Website:
919 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
920 with it's binary name).
921 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
922 the Website to be more complete.
923 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
924 doxygenated documentation.
925 - Doc/DoxyVtkGdcmReaderExamples.txt added
926 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
927 DoxyVtkGdmReaderExamples.html )
928 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
929 * CLEANUP_ROUND (3) for gdcmPixelConvert
930 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
932 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
933 * CLEANUP_ROUND (2) for gdcmPixelConvert
934 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
936 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
937 * CLEANUP_ROUND for gdcmPixelConvert:
938 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
939 - src/gdcmPixelStuff[h|cxx] removed
940 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
941 - src/CMakeLists.txt changed accordingly
943 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
944 gdcmVersion.py moved to newly created ATTIC related
945 gdcmPython/SetupOldies/ directory.
946 * Autotools clean up:
947 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
948 - autogen.sh configure.in acinclude.m4 python.m4 removed
950 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
951 * src/*.cxx *.h Reference to License.htm fixed to License.html.
952 * Doc/CMakeLists.txt, doxygen.config.in: fix.
953 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
955 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
956 * TODO updated with Mathieu suggestions. I proposed a template for
957 describing TODO entries and used it for new entries.
958 * Added Doc/Website/CodingStyle.html, Developpers.html,
959 DeveloppersPython.html, GdcmDataCvs.html and
960 DownloadVersion0_1.html, DownloadVersion0_3.html.
961 * Some Doc/*.txt Doxygen files (which do not really concern the
962 documentation itself, but the website) moved to html and
963 placed in directory Doc/Website:
964 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
965 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
966 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
967 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
968 * CMakeLists.txt changed accordingly.
969 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
970 DeveloppersPython.html
971 * INSTALL nows refers to Doc/Website/Installation.html
973 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
974 * Added Doc/Website directory, that contains a first raw version
977 2004-09-23 Jean-Pierre Roux
978 * FIX In order not to be poluted any longer by casting problems,
979 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
980 we can now delete[] it safely
981 * VoidArea is now called BinArea (less confusing name),
982 and all the methods called ...VoidArea... are now ... BinArea...
983 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
985 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
986 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
987 clear) TagHT, which is an inherited member of gdcmElementSet. It is
988 up to the destructor of gdcmElementSet to clean up TagHt and it's
991 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
992 * Test/CMakeLists.txt: update to follow gdcmData renamings.
993 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
995 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
996 * ENH: added some utility method that builds a flat dictionary
997 holding all the Dicom entries contained in the recursive structure
998 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1000 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1001 BuildFlatHashTable() that build a flat dictionary.
1002 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1003 gdcmDocument is now a friend of gdcmElementSet.
1004 - src/gdcmElementSet.cxx: clean up.
1005 - Example/FlatHashTablePrint.cxx added.
1006 - Example/CmakeLists.txt changed accordingly
1008 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1009 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1010 moved away from gdcmDocEntrySet (since this class is an abstract class
1011 acting like an interface). SQDepthLevel and BaseTagKey are now
1013 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1014 and associated accessors. Doxygenation of the class.
1015 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1017 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1018 Use SQDepthLevel accessor instead. ::Print() adapted.
1019 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1020 - src/gdcmDocument.cxx changed accordingly.
1022 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1023 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1024 - The following is the doxygen comment of the typedef declaration
1025 of gdcmTagKey in src/gdcmCommon.h:
1026 gdcmTagKey is made to old an "universal" (as in URL, Universal
1027 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1028 A dicom tag always has a group and an element, but a set of tags
1029 embeded in various (optionally nested) sequences and sharing
1030 the same group and element all share the same (group, element)
1031 "identifier". Hence the (group, element) cannot be used as an
1032 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1033 In order to construct a proper tag identifier (i.e. a key) we
1034 consider the following definition of a TagKey:
1035 - let Group, Element be the string representation of the
1036 group and element dicom tag members,
1037 - let ItemNumber be the string representation of the integer
1038 index of the considered item number of a sequence,
1039 Let the key of a tag embeded in a sequence, noted SeqTag, be
1041 /ItemNumber#Group|Element
1042 where "/", "#" and "|" are characters acting as separators.
1043 Then the general form of a gdcmTagKey is given by:
1044 Group|Element<SeqTag>
1045 where <SeqTag> means NO or many instances of SeqTag.
1046 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1049 but the gdcmTagKey of a tag "embeded" is the first item of
1050 a sequence, itself nested in the third item of a sequence is the
1052 0004|1220/2#0008|0082/0#0008|0090
1053 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1054 order to hold the new sequence compatible key. Previously, the
1055 GetKey() method would look in the underlying gdcmDictEntry.
1056 - src/gdcmDocEntry.cxx:
1057 -- constructor now copies the underlying DictEntry key, in the local
1059 -- ::Print: displays the member Key, instead of the (group, element).
1060 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1061 - src/gdcmDocEntrySet.h:xi
1062 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1063 -- now has a new BaseTagKey member.
1065 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1066 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1068 This poses the problem with the semantics of the following lines
1069 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1070 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1071 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1072 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1073 to the long FIXME note for what the problem is. Nevertheless in
1074 order to get things working the dicom dictionary was altered !
1075 Please fix things urgently...
1076 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1077 information), see above note on moving the member VoidArea. Nevertheless
1078 the following entries previously correctly set as US are now inproperly
1080 0028 1201 OW IMG Red Palette Color Lookup Table Data
1081 0028 1202 OW IMG Green Palette Color Lookup Table Data
1082 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1083 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1084 of gdcmDocEntry moved to gdcmSeqEntry.
1085 * src/gdcmSeqEntry.cxx: STYLE.
1087 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1088 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1090 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1091 * gdcmPython/testSuite.py: all the test suite in python is now moved
1092 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1093 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1094 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1096 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1097 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1098 to avoid inclusion recursion until STL is reached.
1099 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1100 mecanism. errno.h is not included in gdcm anymore.
1101 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1102 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1104 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1105 gdcmData/TestAllEntryVerifyReference.txt
1106 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1107 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1108 exception_on_error parameter.
1109 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1110 - vtk/vtkGdcmReader.cxx changed accordingly,
1111 - Example/*.cxx and Test/*.cxx changed accordingly.
1113 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1114 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1115 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1116 enable_sequences removed from gdcmHeader constructor and dependencies.
1117 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1118 * gdcmPython/demo/PrintHeader.py: dummy fix.
1119 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1120 skip_shadow removed from gdcmHeader constructor and dependencies.
1121 * Example/*.cxx and Test/*.cxx changed accordingly.
1123 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1124 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1125 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1127 2004-07-21 Jean-Pierre Roux
1128 * FIX Now, Parsing and Printing a DICOMDIR do work!
1129 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1131 2004-07-20 Jean-Pierre Roux
1132 * FIX Some brain damaged headers have Zero-Lenght fields
1133 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1135 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1136 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1137 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1138 variable (instance of gdcmDebug) by a definition macro, and the instance
1139 is now in static in the gdcmDebug class
1140 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1141 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1143 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * WARNING: ctest now depends more tightly on gdcmData. You should
1145 check out gdcmData properly for things to run smoothly...
1146 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1147 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1148 we need the pixels not be loaded in order to use the ValEntry
1149 that displays position and size).
1150 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1151 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1152 be deprecated. If you have any doubts about the advantages of a
1153 modern scripting language (read Python) versus grass root C++ (i.e.
1154 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1155 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1156 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1157 Anyhow, consider documenting the gdcmData images in
1158 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1160 * Test/CMakeLists.txt:
1161 - now uses TestAllEntryVerify.cxx
1162 - specific comments on oldACR00001.ima (now renamed in gdcmData
1163 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1164 gdcmData/TestAllEntryVerifyReference.txt
1167 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1168 * src/*.[h|cxx] : typedef clean up
1169 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1170 - TagKey renamed to gdcmTagKey (for external usage)
1171 - VRKey renamed to gdcmVRKey (for external usage)
1172 - removal of typedef duplication.
1173 - Removed all unecessary inline keyword from class inline definitions.
1174 - Some method|function(void) declarations replaced with method|function().
1175 * src/jpeg/libijg12/jdhuff12.c:
1176 - printf polluting ctest removed.
1177 - TAB removal for comminting
1179 - TestAllReadCompareDicom.cxx: added a test that compares all the
1180 images in gdcmDataImages.h with corresponding images in
1181 gdcmData/BaselineDicom/. When baseline images are not present
1182 this test creates them.
1183 Note: we need to validate each reference image, but before that
1184 I'd like to rename them with a more explicit name...
1185 - CMakeLists.txt: changed accordingly.
1186 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1187 including each header needed).
1189 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1190 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1191 test suite to the Example directory. Are concerned:
1196 - TestWriteSimple.cxx
1197 * Test/CMakeLists.txt: added some comments on reasons for black listing
1198 image gdcmData/oldACR00001.ima
1200 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1201 * Test/CmakeList.txt: removed the following from black list (to be coherent
1202 with removal from gdcmData):
1203 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1204 - gdcm-MR-PHILIPS-16.dcm
1206 Added the following because after last cvs update, they cause
1207 ctest -R TestReadWriteReadCompare
1209 - gdcm-MR-SIEMENS-16-1.acr
1211 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1212 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1213 new comments in this file) we temporarily (sigh) move to a weaker
1215 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1216 we don't need to black list the following images anymore:
1217 - 8BitsUncompressedColor.dcm
1219 - US-PAL-8-10x-echo.dcm
1220 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1221 fixes and the beautified code ;-)
1222 This fixes the bug introduced in version 1.42 (when beautifying)
1223 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1224 Note: ctest was blind to this bug (this means we need to still
1225 improve the test suite). The bug could be detected by using
1226 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1228 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1229 and by displaying the (garbage) produced file temp.XDCM...
1231 2004-06-29 Jean-Pierre Roux
1232 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1233 - replace by uggly but working old code :-(
1234 A lot of things should be OK again.
1235 It's really urgent to have a test suite that *tests*,
1236 to prevent Frog's beautifying sessions to break all the stuff
1237 (twice, withing a fortnigh ...)
1239 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1240 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1241 redundancy) to added Test/TestReadWriteReadCompare.cxx
1242 * Test/CmakeList.txt: because the compare test of
1243 Test/TestReadWriteReadCompare.cxx fails, the following images are
1244 black listed: - 8BitsUncompressedColor.dcm
1246 - US-PAL-8-10x-echo.dcm
1247 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1248 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1249 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1250 and ad-hoc kludge. This kludge is now removed, and on encountering
1251 such an image (OB field brain damaged) we set errno. Then in
1252 ::FindDocLength() we "fix" the length as being ALL what remains
1253 in the file (until EOF). We then proceed, hoping for the best...
1254 This fixes a SegFault in ShowDicom when trying to write such an
1256 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1257 (because TestWriteRead breaks on it, after a non conformal commit?).
1258 ctest now runs properly, except for MakeDicomDir (which was always
1259 broken) and the Python related stuff (still not fixed).
1261 2004-06-24 Jean-Pierre Roux
1262 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1263 FIX : Test/TestReadWrite now iterates on all the file names
1264 (instead of infinite loop)
1265 ENH : Test/TestWriteRead now iterates on all the file names
1267 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1268 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1270 2004-06-24 Jean-Pierre Roux
1271 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1272 when SamplesPerPixel =3
1273 - now Write is no longer confused by
1274 'BitsAllocated = 12" and 'BitsStored=12"
1275 - "UN" value representation Elements are now written correctly
1276 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1277 ENH : - now gdcmHeader has its own Write methods
1278 (in order to split the job that has not to be done
1281 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1282 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1283 loop on the same image until memory went out.
1284 Note: this means we still have gobs of memory loss in PrintDocument
1285 * src/gdcmDocument.cxx: fixes problem on parsing on file
1286 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1288 2004-06-24 Jean-Pierre Roux
1289 FIX : Write - All the Sequences and Sequence Item are now written
1290 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1291 is added a the end, when necessary.
1292 - A lot of brain-damaged images, that were read correctly are
1293 now written correctly
1294 - length compatible BinEntry are now loaded correctly
1295 (even for odd groups)
1296 Note : only Explicit Value Representation was checked.
1297 (question : is implicit VR really necessary for gdcm ?)
1299 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1300 * DEVELOPPER: added a proposition of coding style.
1301 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1304 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1305 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1306 Use the gdcmDocEntry::Print() and Write() instead.
1307 * src/gdcmDocument.cxx: bug fix.
1309 2004-06-22 Jean-Pierre Roux
1310 FIX : gdcmDocument.cxx
1311 - Now we do recognize the JpegLossLess format (there was a misstyping in
1312 code 'beautyfication' :-(
1313 - Now we automaticaticaly load the Luts, if any
1315 2004-06-22 Jean-Pierre Roux
1316 In order : to write Sequences, whatever their imbrication level,
1317 : to allow user to create his own Sequences
1318 a lot of modif where necessary (adding, moving, or virtualising methods)
1320 WARNING : save your own sources *before* cvs up !
1323 ADD virtual void Write(FILE *fp, FileType filetype);
1326 ADD virtual void Write(FILE *fp, FileType filetype);
1327 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1330 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1331 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1332 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1333 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1334 ADD std::string GetEntryByName(TagName name);
1335 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1337 std::string vr = "unkn",
1338 std::string fourth = "unkn",
1339 std::string name = "unkn");
1340 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1341 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1342 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1343 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1344 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1345 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1346 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1347 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1350 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1351 ADD virtual std::string GetEntryByName (TagName tagName);
1352 ADD virtual std::string GetEntryVRByName (TagName tagName);
1353 REM virtual bool Write(FILE *, FileType);
1354 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1355 FILE *_fp, FileType type);
1356 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1357 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1358 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1359 REM virtual std::string GetEntryByName (std::string tagName);
1360 REM virtual std::string GetEntryVRByName (std::string tagName);
1361 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1362 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1363 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1365 std::string vr = "unkn",
1366 std::string fourth = "unkn",
1367 std::string name = "unkn");
1368 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1369 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1370 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1371 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1374 ADD virtual void Write(FILE *fp, FileType filetype);
1377 ADD virtual void Write(FILE *fp,FileType filetype);
1380 ADD virtual void Write(FILE *fp, FileType filetype);
1381 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1382 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1383 REM std::string GetEntryByName(TagName name);
1386 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1388 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1389 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1390 The default constructor invoked by the line
1391 gdcmHeader *f1 = new gdcmHeader( header );
1392 was gdcmHeader::gdcmHeader(bool) instead of the expected
1393 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1394 Hence the parsing wasn't executed... See also below.
1395 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1396 as explicit constructor didn't do the trick to fix the above problem.
1397 Could anyone explain why ?
1398 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1399 properly calls gdcmValEntry::Print() (that was weed out from
1400 code related to gdcmBinEntry).
1402 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1403 * In order to fix memory leaks:
1404 - Test/TestWriteSimple.cxx: added cleaning of free store through
1406 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1407 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1408 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1409 (through the call to ::AddDicomDirMeta()) or the destructor
1410 would crash when deleting uninitialized ::metaElems].
1411 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1412 - src/gdcmDocument.cxx:
1413 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1414 from dynamic stores.
1415 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1416 was causing memory leaks.
1417 - src/gdcmSQItem.cxx:
1418 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1419 cleanly handled with polymophism: sorry but my milage is low).
1420 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1421 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1422 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1423 This avoids SegFaulting.
1424 - src/gdcmSQItem.h: coding style.
1426 - Test/TestWriteSimple still severely sucks. The output image content
1427 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1428 damaged when displayed with vtkgdcmViewer.
1429 - on memory leaks: TestWriteSimple leaks really less (see entry
1430 of 2004-06-18 in Changelog file for the call to valgrind).
1431 - on segfaults: ctest now passes all the tests but one (no more
1433 * Erroneous leading white fix:
1434 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1435 white[s] (as opposed to from >> xxx, that removes it [them].
1436 - src/gdcmTS.cxx: ditto.
1437 - gdcmPython/testSuite.py: dirty related kludge removed.
1438 * src/*: remaining references to gdcmParser removed.
1439 * src/*[cxx|h]: added copy[way]left header.
1442 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1443 * In order to fix writing of dicom files:
1444 - Test/TestWriteSimple.cxx: a simpler example of writing.
1445 - Test/CMakeLists.txt changed accordingly.
1446 - src/gdcmDocument.cxx:
1447 -- The destructor now recursilvely removes potential sequences.
1448 -- Bug fix in ::IsJPEG2000()
1449 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1450 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1452 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1453 to only declared) and build on top of
1454 ::GetDocEntryByNumber(guint16, guint16).
1455 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1456 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1457 for usage in destructor and treatement of promotion in
1458 ::ReplaceOrCreateByNumber().
1459 - src/gdcmSQItem.cxx: destructor should better handle his job.
1460 Test/TestWriteSimple now runs (or at least it DOES something).
1461 * We can now start hutting memory links. A good starting point is:
1462 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1463 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1464 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1466 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1467 * Valgrind note: after Mathieu Malaterre teached me how to read
1468 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1470 Using gcc, you can force the STL to use malloc and to free memory as
1471 soon as possible by globally disabling memory caching.
1472 With 3.2.2 and later, you should export the environment variable
1473 GLIBCPP_FORCE_NEW before running your program.
1474 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1475 simply vanish (it is still not clear to me, whether this means that
1476 STL std::string leaks or if valgrind believes it leaks...).
1477 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1478 running bin/gdcmTests makeDicomDir):
1479 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1480 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1482 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1483 SegFaulting (I drowned in DicomDir related code when trying to
1484 understand why the list is empty...).
1485 * src/gdcmDocument.h: first BSD license header try.
1486 * Doc/License.txt added.
1488 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1489 * src/gdcmDocument.[h|cxx]:
1490 - Clean up of the Transfer related predicates. They are now all based
1491 on new method isGivenTransferSyntax, that (should) handle properly
1492 the padding problem.
1493 - general clean up, simplification, and coding style.
1494 - Specific clean up of Parse7FE0() (umproperly named actually).
1495 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1497 2004-06-14 Jean-Pierre Roux
1499 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1500 - fix the display of SQItem ordinal number
1501 - add the GetSQItemByOrdinalNumber method
1502 - remove some useless never written private methods
1504 2004-06-14 Jean-Pierre Roux
1506 - adding a constructor taking a gdcmDocEntry as an input param
1507 - ReplaceOrCreateByNumber now returns :
1508 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1509 a gdcmValEntry * if a string value is passed as a param
1511 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1512 according to the param type (no longer sets a gdcmDocEntry)
1513 - GetValEntryByNumber, GetBinEntryByNumber added
1514 - NewValEntryByNumber and NewBinEntryByNumber added
1516 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1518 - GetSQItemNumber and SetSQItemNumber added, to provide
1519 a (relative) Item identier inside a given Sequence
1520 \warning : some pb remaining around this number
1522 - AddEntry now takes the Item Number as a param
1524 - adding a constructor taking a gdcmDocEntry as an input param
1526 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1527 * Memory leak hunt with the following command:
1528 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1529 --show-reachable=yes gdcmTests PrintDocument
1530 It looks like many (all?) leaks are due to the STL (or a bad usage
1531 of the STL. The lines producing the leaks now have a comment with
1532 a "MEMORY LEAK" tag: you can retrieve them with
1533 grep "MEMORY LEAK" src/*
1534 Here are two typical examples which I can't help fixing:
1539 char * test = "babo";
1540 name = test; //// <--- valgrind detects 960 bytes lost in
1541 //// call to std::string::operator=(char const*)
1542 name.clear(); //// Doesn't help !
1550 std::cout << "Type a bunch of characters followed by RETURN: ";
1551 getline(std::cin, line); //// <--- valgrind dectects a loss
1552 //// of 1320 bytes in call to
1553 /// std::basic_istream<>& std::getline<>
1559 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1560 * src/gdcmHeader.[cxx|h]:
1561 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1562 and related, moved away to gdcmDocument.
1563 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1564 the corresponding protected accessors of inherited class
1565 gdcmDocument, removed ! As a consequence gdcmFile had to be
1566 declared friend of class gdcmDocument (see below).
1567 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1568 - Clean up of undefined or unused methods.
1569 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1570 account the changes to gdcmHeader.h).
1571 * src/gdcmDocument.h:
1572 - gdcmFile is now a friend class (in order to take into account the
1573 changes to gdcmHeader.h).
1574 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1575 (see changes to gdcmHeader.h).
1576 - Accessors (reading on the form GetEntry*) are now public.
1577 - Clean up of undefined or unused methods.
1578 * src/gdcmDocument.cxx:
1579 - adaptation to changes to gdcmDocument.h
1580 - ::OpenFile now writes a verbose message when file cannot be opened.
1581 - some std::string properly set to VRKey
1582 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1583 references to gdcmDocument.
1584 * Test/TestFindTags.cxx: changed accordingly to above changes.
1585 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1586 cvs repository gdcmData.
1588 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1589 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1590 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1591 conflicts with gdcmValEntry::voidArea.
1592 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1593 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1594 Value representation between StringRepresentable and BinaryRepresentable.
1595 * src/gdcmDocument.cxx:
1596 - method ParseDES: proper indentation restored and usage of
1597 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1598 - method LoadDocEntry: the fingerprint left in the SetValue() of
1599 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1600 removed. Reverting to previous code segment with the proper
1601 dynamic_cast< gdcmValEntry* >.
1602 Note: this was (partially) breaking the python test suite
1603 (gdcmPython/testSuite.py) that made usage of the above
1604 fingerprint to check presence of "Pixel Data".
1605 * src/gdcmDocEntry.h: coding style.
1606 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1607 now taken into account.
1608 * gdcmPython/gdcm.i: adaptation to the new internal representation
1609 of gdcm (exit gdcmParser, hello gdcmDocument).
1610 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1612 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1613 anymore, but instead prints the loaded Python dictionary.
1614 * .... alas, the python testSuite is still broken.
1616 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1617 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1619 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1620 * src/gdcmUtil.h : export methods
1622 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1623 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1625 * Initial addition of automatic python testing
1626 * Initial addition of automatic image comparison
1628 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1629 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1630 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1632 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1633 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1634 * Test/ShowDicom.cxx : bug fix for msvc compilation
1635 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1637 2004-05-04 Jean-Pierre Roux
1638 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1639 new concepts (and new classes) :
1640 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1641 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1642 - Sequence Doc Entries (gdcmSeqEntries)
1643 a Sequence is composed of Items.
1644 Each item is a set of Doc Entries (this is recursive)
1645 The non uniqueness of the 'Dicom tag' is due to this recursivity
1646 (never taken into account)
1647 Our unability to add a new 'entry' in the header
1648 at the proper location (neither in the H-Table (map or multimap),
1649 nor in the Chained List is also due to this recursivity.
1650 Don't try, right now, to use/modify/compile these new sources :
1651 nothing is finished.
1652 We just commit all the stuff, 'as is', in order not to loose it.
1654 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1655 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1657 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1658 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1659 file prefix (SetFilePrefix)
1661 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1662 * Add a new test: ShowDicom, for now this is just the c++ version of
1663 checkRead.sh, later it will be able to compare the image read against a
1665 * Replace the DEBUG on the stack with a global entry in cmake interface:
1666 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1668 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1669 * Add an example subdir, with a real example on how to read + write a
1672 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1673 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1674 * Doc/CMakeLists.txt: the main page is now properly differentiated
1675 between the developper and user version.
1676 * Doc/doxygen.config.in: dropped search related obsolete flags
1677 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1679 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1680 * DEVELOPPER: added some helpfull comments for compile/test/install
1683 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1684 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1685 src directory, now generated in the build dir.
1686 2. Tests as mentionned smarter
1688 4. Add a new method in gdcmDict that return the PubDict by name
1689 this is interesting for 3rd party lib like ITK,
1690 where we could set the institution name / patient name...
1692 * ENH: 1. Now the test suite is working for real
1693 2. All binaries are now output in the gdcm-bin directory
1694 (this was not true before)
1696 2004-04-28 Jean-Pierre Roux
1697 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1698 SeQuence indented printing of Dicom Header.
1699 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1700 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1701 Computation of SQDepthLevel is now part of gdcmHeader constructor
1702 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1703 tree-like structure of a Dicom Header.
1704 * FIX Test code cleaning
1706 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1707 * ENH: Adding automatic testing
1708 1. Need a DartConfig.cmake to submit to public
1709 2. Add a test driver gdcmTest.cxx
1710 3. gdcmTestMain, an helper for the main test driver gdcmTest
1711 4. Files in Test don't have a main anymore, this becomes interesting
1712 when we add more and more tests, thus dsw don't have to load
1714 * ENH: Adding a GDCM_DATA_ROOT for testing
1715 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1716 one file instead of seven + some small cleanup
1718 2004-04-22 Jean-Pierre Roux
1719 * ENH Minor changes to the Print() methods.
1720 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1721 Header printing. Example given with :
1722 > PrintHeader fileName 2 new
1723 (SQ based tree-like structure still to be done for the Header ...)
1725 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1726 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1727 1. I have added some unsigned where needed
1728 2. Some function parameter not used -> (void)
1729 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1730 4. g++ don't like character '\' in comment
1731 5. #define jpeg_create_decompress jCreaDecompress
1732 this really need to be fixed
1733 6. virtualize destructor of gdcmObject ... leakage
1734 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1735 this also really need to be fixed
1736 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1737 remove compression file
1738 (as we only do decompression, right ?)
1739 * ENH: Change malloc/calloc/free with c++ equivalent
1741 2004-04-21 Jean-Pierre Roux
1742 * FIX gdcmHeaderHelper::GetXSpacing
1743 when a single value is found (bug ?), xpacing is now
1744 defaulted to yspacing
1746 2004-04-19 Jean-Pierre Roux
1747 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1748 * ENH add parameters :
1749 bool exception_on_error = false,
1750 bool enable_sequences = false,
1751 bool ignore_shadow = false
1752 to the gdcmFile constructors to be full gdcmParser compliant
1753 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1754 to allow reading of PAPYRUS 3.0 files
1756 2004-04-06 Jean-Pierre Roux
1757 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1759 2004-04-02 Jean-Pierre Roux
1760 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1761 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1762 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1764 2004-03-30 Jean-Pierre Roux
1765 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1766 for ACR file, written out as DICOM files (hope so...)
1768 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1769 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1770 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1771 moved to base class gdcmParser and only the specialisation is kept
1773 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1774 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1775 already does the job.
1776 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1777 (to be consistent with gdcmParser::WriteEntries).
1779 2004-03-30 Benoit Regrain
1780 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1781 upate of the object's instance. It's passed to 2 in the unfavorable
1782 case : one in the ExecuteInformation, one in the ExecuteData
1784 2004-03-29 Jean-Pierre Roux
1785 * ENH : Check on file type to be written moved
1786 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1787 * FIX : gdcmObject::ResetBoundaries now stops properly
1788 when end-of-list is reached
1789 : gdcmVersion modified (as Benoit Regrain asked)
1791 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1792 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1793 * src/gdcmUtil.cxx: added forgotten iostream include.
1794 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1795 equivalent to ExplicitVR in existing code).
1797 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1798 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1799 now contains all the gdcmGlobal related code.
1800 * minor coding style and doxygenation changes.
1802 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1803 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1804 now contains all the Debug related code.
1805 * minor clean-up of includes in src/*.cxx
1806 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1807 CreateCleanString) removed.
1808 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1809 * Doc/DoxyMainPageUser.txt added.
1810 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1811 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1812 src/gdcmDirList.cxx)
1814 2004-03-24 Jean-Pierre Roux
1815 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1817 2004-03-23 Jean-Pierre Roux
1818 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1819 big endian made volumes
1820 * ENH Now gdcmParser constructor and destructor are protected to forbid
1821 end user to instanciate class gdcmParser
1822 (only gdcmHeader and gdcmDicomDir are meaningfull)
1824 2004-03-22 Benoit Regrain
1825 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1826 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1827 gdcmSerie to gdcmDicomDirSerie
1829 2004-03-19 Jean-Pierre Roux
1830 * ENH Now the tree-like structure describing a DICOMDIR comming from
1831 an already existing DICOMDIR file is consistent with
1832 the home-made tree-like structure build ex-nihilo
1833 or build from the files held (recursively) in a Directory
1834 functions gdcmDicomDir::CheckBoundaries()
1835 gdcmObject::SetBoundaries() added
1837 2004-03-17 Jean-Pierre Roux
1838 * REM (Eric Boix bug) : removal of meaningless
1839 gdcmDicomDirImage::NewImage function.
1840 * FIX now file names and directory name are written properly in the
1842 * FIX now gdcmDicomDir constructor may be call without any trick
1845 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1846 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1847 of gdcmDicomDirImage::NewImage as empty function.
1849 2004-02-28 Jean-Pierre Roux
1850 * ENH add gdcmDicomDir:NewPatient
1851 add gdcmDicomDirPatient:NewStudy
1852 add gdcmDicomDirStudy:NewSerie
1853 add gdcmDicomDirSerie:NewImage
1854 to allow making gdcDicomDir object.
1855 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1856 (as opposite to the gdcmHeader chained list)
1858 2004-02-11 Benoit Regrain
1859 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1860 when using from python
1862 2004-02-10 Benoit Regrain
1863 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1864 * FIX : in gdcmDicomDir when the directory is empty
1865 * ENH : add callback and methods to get the progression of dicomDir
1868 2004-02-06 Jean-Pierre Roux
1869 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1870 - GDCM_META added to gdcmDicomDirType
1871 - class gdcmMeta created
1872 * ENH : - A brief summary is now displayed at the beginning of
1873 'testDicomDir' to help disaster magnitude estimation
1874 * REM : Now useless Test/explDICOMDIR.cxx
1876 2004-02-05 Benoit Regrain
1877 * ENH : add methods in gdcmObject to get the hash table or the list of
1879 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1880 * FIX : wrapping python for TagHeaderEntryHT
1882 2004-02-04 Benoit Regrain
1883 * FIX : even length for some strings when writting the dicom dir
1884 * FIX : sort the images in the dicom dir
1885 * FIX : Bug fix for python use of dicom dir
1886 * ADD : a python demo
1888 2004-02-04 Jean-Pierre Roux
1889 * FIX : Final solution (?) for icone embedded images
1890 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1891 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1892 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1893 gdcmData/gdcm-MR-SIEMENS-16.acr1
1894 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1895 to make full checking easier
1897 2004-02-04 Benoit Regrain
1898 * FIX : WriteEntries : coding style & logic in parameters
1899 * FIX : Set the elements to create the DicomDir in a dictionary file
1901 2004-02-03 Benoit Regrain
1902 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1903 * gdcmDicomDir : add the load of directory
1904 * Bug fix and print add-on
1906 2004-02-03 Jean-Pierre Roux
1907 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1908 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1909 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1910 * FIX gdcmParser.cxx : 'group length' elements are now considered
1911 as integers, even for shadow groups, when file is Implicit VR
1913 2004-02-02 Jean-Pierre Roux
1914 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1916 of the last synonym :-(
1917 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1919 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1920 * FIX taking into account the possible 7fe0,0010 multiplicity
1921 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1922 to allow removal of references to 7fe0,0010, to deal with
1923 ACR-NEMA images, when 0028,0200 is meaningfull
1925 2004-01-31 Jean-Pierre Roux
1926 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1927 no longer writes 'Un' on disk
1928 * FIX SQ elements with actual length are now dealt with corectly
1929 * FIX gdcmFile::WriteBase make the difference, for color images, between
1930 the length (for Palette expanded images)
1931 and Raw Length (non expanded image + Palette)
1932 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1933 (that broke Write). Replaced by UL.
1934 Aware user will reload the field if he
1935 thinks it's necesssary
1937 2004-01-30 Jean-Pierre Roux
1938 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1939 when 'dirty Acr' is found, to be compliant with the new
1940 IsReadable() methods.
1942 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1943 (no DOUBLE images in kosher DICOM,
1944 but so usefull for people that miss them ;-)
1946 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1947 DICOMDIR related utilities (not checked as Windoze compliant)
1949 2004-01-28 Jean-Pierre Roux
1950 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1952 2004-01-27 Jean-Pierre Roux
1953 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1954 to allow skipping the shadow elements, to save memory space.
1955 The TRUE value for this param has to be used
1956 with a FALSE value for the 'enable_sequence' param.
1957 ('public elements' may be embedded in 'shadow Sequences')
1958 * gdcmHeader methods now deal with 'embedded icones images' in the header
1959 (even when an 'icone image sequence' is announced by the
1960 element (0x0088,0x0200), but there is NO icone at all ...
1962 * gdcmHeader sometimes Image Location value doesn't follow
1963 the supposed processor endianity (see gdcmData/cr172241.dcm).
1966 * gdcmHeader add the method
1967 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1968 to get *all* the Header Entries with the same tag.
1969 GetHeaderEntrySameName is probabely *useless*
1970 (no meaning : Name is *not* an identifier within the Dictionary)
1972 2004-01-26 Benoit Regrain
1973 * Bug fix in the print of hexadecimal representations. Remove long fields
1974 in the print and add a third level of print to print them
1976 2004-01-23 Benoit Regrain
1977 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1978 * Bug fix on test suite after remove the strip made on not string fields
1979 * Split the IsReadable method between gdcmParser which test that the file
1980 is dicom and gdcmHeader which test that it's an image file
1982 2004-01-22 Benoit Regrain
1983 * DicomDir : clean code, add methods, set variables in protected or private
1984 * gdcmUtil : bug fix for the clean string method
1986 2004-01-19 Benoit Regrain
1987 * Add the use of shadow dictionaries
1988 * bug fix and coding style
1990 2004-01-19 Benoit Regrain
1991 * src/gdcmFile.cxx : bug fix concerning the close of file
1992 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1993 * Add the update of header entries using the shadow library
1995 2004-01-19 Benoit Regrain
1996 * removal of file gdcmHeader2.cxx
1997 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1998 inheriting from gdcmParser. This split is to prepare the integration
1999 of dicom dir parsing
2000 * bug fix under python
2002 2004-01-16 Jean-Pierre Roux
2003 * REM removal of class gdcmHeaderEntrySet
2004 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2005 * ADD add file gdcmHeader2.cxx
2006 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2008 2004-01-15 Benoit Regrain
2009 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2010 entries created while parsing the header. Thus, they will be destroyed
2011 when the gdcmDictSet will be destroyed
2012 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2015 2004-01-15 Benoit Regrain
2016 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2017 made a fatal error because of the memory release at the end of program.
2018 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2019 some memory and vtk seems to have some problems with that.
2020 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2022 2004-01-14 Benoit Regrain
2023 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2024 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2025 * src/*.[h|cxx] : make changes due to class name changes
2026 * gdcmPython/demo/*.py : bug fix due to method names
2028 2004-01-13 Benoit Regrain
2029 * src/*.[h|cxx] : coding style
2030 * vtk/*.[h|cxx] : coding style
2032 2004-01-13 Benoit Regrain
2033 * gdcmPython/testSuite.py : test the readable flag of file for tests
2034 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2035 It's lied to the stl compilation by MSVC (windows, always windows...)
2036 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2038 2004-01-12 Benoit Regrain
2039 * src/*.h : add comments
2040 * src/gdcmDictSet.h : set the method BuildDictPath in public
2041 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2042 directly setted in the source code
2043 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2046 2004-01-09 Benoit Regrain
2047 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2048 * setup.py : use a reference to gdcmVERSION
2050 2004-01-07 Benoit Regrain
2051 * Modification to compile with the distutils.
2054 2003-12-10 Benoit Regrain
2055 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2056 can use a gdcmHeaderHelper to load data
2057 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2058 made in the source code
2060 2003-12-10 Benoit Regrain
2061 * Update Windows projects and .cvsignore files
2063 2003-11-12 Jean-Pierre Roux
2064 * ENH gdcmHeader constructor has one more parameter (default value : false)
2065 that allows the user to 'go inside' the SeQuences only
2067 gdcmElValSet:Print takes it into account
2069 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2070 * ENH: Update gdcmPython/CMakeLists
2071 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2072 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2074 2003-11-10 Jean-Pierre Roux
2075 * FIX : gdcmHeader::LoadElements is now based
2076 on the ListTag listElem member,
2077 not longer on the TagElValueHT tagHt member
2078 * ENH : PrintPubElVal shows (temporarily) both results,
2079 with the tagHt member and the listElem member.
2080 (it's easier to 'see' the problems when using Printheader)
2082 * FIX : old private member LgrElem is now splitted into
2083 ReadLength : Length actually found on disk (updated only
2084 if bug fixing is necessary), for internal
2086 UsableLength : Updated by FixFoundLength, to fix a bug
2087 or to allow Parser going on.
2088 Will allow to re-write a kosher header when a SeQuence
2089 with a length (not 0000) is found
2090 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2091 because gdcmElValSet::Add does not update ListElem
2094 2003-11-07 Jean-Pierre Roux
2095 * FIX misstyping in Transfert Syntax name table
2096 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2097 when they have an actual length (not 0000 nor FFFFF)
2098 (Nobody should care of it, but DICOMDIR explorers)
2100 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2101 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2103 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2104 * ENH: vtkGdcmReader now supports LUT !
2105 (vtkgdcmViewer for now is not able to use them though)
2107 2003-11-05 Jean-Pierre Roux
2108 * in testSuite.py : new files names for checking the package
2109 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2110 that returns the pixel area size to the *aware* (vtk) user
2111 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2113 2003-11-05 Benoit Regrain
2114 * in testSuite.py : Modify the rules for checking the paths
2115 : Explicit error messages
2116 * in __init__.py : Related modif
2118 2003-11-03 Jean-Pierre Roux
2119 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2120 to be used by aware (vtk) users that want to manage
2121 LUT (and no to turn the PALETTE image into an RGB pixels one)
2122 * GetPixelType now returns 8U for 24 Bits images
2123 (vtkGdcmReader compliant)
2125 2003-10-31 Jean-Pierre Roux
2126 * Removal of *all* gdcmData images and add them again
2127 in order to loose the 'history' of un-anonymised images
2129 2003-10-31 Jean-Pierre Roux
2130 * RMV : removal of useless jBitsInJsample.h
2131 for both 8 and 12 Bits JPEG Lossy Libraries
2133 2003-10-31 Jean-Pierre Roux
2134 * ENH : Add the functions gdcmFile::GetImageDataRaw
2135 gdcmFile::GetImageDataIntoVectorRaw
2136 that act as GetImageData and GetImageDataIntoVector
2137 except the making of an RGB Plane from Gray Plane + LUT
2138 Intended to aware (vtk) users who know how to manage
2141 GetLUTRGBA return a R,G,B,A LUT if any
2142 lgrTotaleRaw gives the 'Raw' length
2143 GetImageDataRaw returns the gray Plane
2144 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2145 (They stay Grey, just like with other Dicom viewers :-(
2147 2003-10-30 Jean-Pierre Roux
2148 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2150 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2151 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2152 being coherents dicom files.
2154 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2155 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2157 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2158 * ENH: Two steps is necessary to please VC++ compiler...
2159 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2160 * ENH: Add include dir to medcon lib
2161 * FIX: only one function is being exported for now !
2162 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2164 2003-10-29 Jean-Pierre Roux
2165 * adding gdcmHeader::GetLUTRGBA
2166 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2167 --> Mathieu, the modif u're waiting for is not yet committed
2168 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2170 2003-10-27 Jean-Pierre Roux
2171 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2172 00191113.dcm DermaColorLossLess.dcm
2173 MxTwinLossLess.dcm RadBWLossLess.dcm
2174 * ENH: For version prior to vtkImageViewer2 -r 1.19
2175 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2177 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2178 * Removal of ido stuff in CMakeLists.txt
2180 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2181 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2182 * FIX: remove a call to ->Modified ... see comments
2183 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2185 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2186 * FIX: Problem with path for libvtkgdcmPython
2187 * ENH: Try adding a search script for python site-package
2188 * RMV: Remove some file from medcon lib that are not necessary
2189 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2190 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2191 * FIX: More pragma disable fro VC++,
2192 I don't think I break something as it is also disable in VTK/ITK.
2193 But it fasten debug compilation time.
2195 2003-10-23 Jean-Pierre Roux
2196 * gdcm now deals with 16 Bits Run Length Encoded images
2197 (they are compressed as 2 planes images,
2198 one for the high Bytes, the other for low Bytes)
2200 2003-10-22 Jean-Pierre Roux
2201 * Now CheckRead takes into account :
2202 - the bugged 'Leonardo' Siemens images
2203 - the XA images, sent thru the burning VPRO station
2204 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2207 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2208 * FIX: When copying a Makefile.am to CMakeLists.txt
2209 one should remove the '\'
2211 2003-10-22 Jean-Pierre Roux
2212 * in gdcmData adding a bugged 'Leonardo' Siemens image
2213 (wrong lengths in header)
2214 OK with gdcm, KO with the other viewers :-)
2215 * add a GE dlx XA image, thru the VEPRO burning station
2218 2003-10-21 Jean-Pierre Roux
2219 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2220 for a brutal checking of vtkgdcmViewer compliance
2222 2003-10-21 Jean-Pierre Roux
2223 * add the files for 'xmedcon' Jpeg Lossless library
2224 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2226 2003-10-21 Jean-Pierre Roux
2227 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2229 2003-10-21 Jean-Pierre Roux
2230 * garbage Siemens 'Leonardo' images dealt with
2231 (the patch is easy to remove)
2232 * cosmetic changes to avoid warnings
2234 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2235 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2236 no need to press 'r' now.
2238 2003-10-20 Jean-Pierre Roux
2239 * upgrade of checkRead.sh checkWrite.sh according
2240 to new Jpeg Lossless decompressor
2241 * add US.3405.1.dcm, a genuine RGB medical file ...
2242 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2243 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2245 2003-10-15 Jean-Pierre Roux
2246 * general anonymisation in gdcmData
2247 * adding the 'color files' from
2248 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2249 * adding some well knowed bugged-header images
2250 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2251 waiting for their inclusion in Python testsuite
2253 2003-10-15 Jean-Pierre Roux
2254 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2255 no longer seg faults when file is not found
2257 2003-10-14 Jean-Pierre Roux
2258 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2261 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2262 * TODO: *.in file to genereate a UseGDCM later
2264 2003-10-14 Jean-Pierre Roux
2265 * Some supposed-to-be Dicom Images have no preamble.
2266 OpenFile takes it into account
2267 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2268 * Missing elements added in dicomV3.dic
2269 (just to be affraid : have a look at
2270 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2271 and do it again next year ;->
2273 2003-10-13 Jean-Pierre Roux
2274 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2275 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2276 But there are NOT. It's fixed !
2278 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2279 * FIX: "jpeglib.h" was not found on VC++
2280 * FIX: vtkgdcm was not being installed
2282 2003-10-10 Jean-Pierre Roux
2283 * ENH : OpenFile closes the file if it *really* doesn't look like
2284 an ACR-NEMA / DICOM one.
2285 * FIX : testWrite no longer writes an empty file if the source file
2286 is not gdcm Readable
2287 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2290 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2291 * FIX: CMake generate now documentation
2292 * ENH: out of source doc build !
2293 * ENH: Generate both user and dev documentation
2294 * ENH: Should work on windows too
2295 * ENH: Only one doxygen config.in file is needed
2296 * FIX: make install should be ok now on ùnix plateform
2297 * FIX: PATH to dictionary was wrong (missing /)
2298 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2300 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2301 * vtkGdcmReader is now able to read rgb dicom file.
2302 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2303 * added a gdcmViewer to vtk test, use mouse to control
2304 window level & window width
2306 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2307 * CMake-ification of gdcm, we have now two build system
2308 * FIX: on cygwin Wsock32 doesn't exist
2309 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2311 2003-10-06 Emanuel Ollart
2312 * FIX : compilation process wad broken.
2313 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2315 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2316 * change gdcmViewer -> vtkgdcmViewer
2317 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2319 2003-10-06 Jean-Pierre Roux
2320 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2321 ( e.g : well known GE images with a wrong elem length,
2322 : Philips MRI Images with a wrong Huffman table)
2323 * still to be done : allow the reading of bugged LEONARDO Siemens images
2325 2003-10-03 Jean-Pierre Roux
2326 * Odd length strings are padded with '\0' (not with spaces,
2327 to remain compliant with already defined strings,
2328 like Transfert Syntax UID and others)
2330 2003-10-03 Jean-Pierre Roux
2331 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2332 to allow displaying RGB images (not only by affim ;-)
2334 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2335 * vtkGdcmReader is now able to read rgb dicom file.
2336 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2338 2003-10-03 Jean-Pierre Roux
2339 * A few nasty patches to allow the reading of a lot of nasty images
2340 ( e.g : well known GE images with a wrong elem length,
2341 : Philips MRI Images with a wrong Huffman table)
2342 * still to be done : allow the reading of bugged LEONARDO Siemens images
2344 2003-10-03 Jean-Pierre Roux
2345 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2347 2003-10-03 Jean-Pierre Roux
2348 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2349 to allow displaying RGB images (not only by affim ;-)
2351 2003-10-03 Jean-Pierre Roux
2352 * gdcmFile::GetImageDataIntoVector now
2353 - deals with MultiFrames MultiFragments Run Length Encoded files
2354 - deals with YcBcR (YBR_FULL) files
2355 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2356 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2358 (no sample found :-(
2360 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2361 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2362 Two reasons: - clear things
2363 - third parties acces gdcm through header files, so won't
2364 suffer anymore VC++ complains
2366 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2367 * add argv[1] in testvtkGdcmReader.cxx
2370 2003-09-24 Jean-Pierre Roux
2371 * The lines are now eigthy characters long.for
2372 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2374 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2375 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2376 char* to std::string. Thus, the use of strdup becomes useless. (see
2377 previous commis of Malaterre)
2378 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2379 before the last Malaterre's commit.
2381 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2382 * This commit should fix the Debug building under VC++, the problem
2383 was mainly a mixture of debug and release lib being loaded at startup.
2384 * I also remove a depency to a specific C function: strdup. Because I had
2385 to force the link to msvcrtd (whereas strdup is in libc).
2387 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2388 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2389 located in the gdcmCommon.h file. All use of reference of tha has been
2390 changed to now use the variable GDCM_UNFOUND.
2392 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2394 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2395 Dicom dictionary. The test suite can now be run again. Note:
2396 I'm note very happy with the " (RET)" changes. I believe this
2397 RETAINED comment should be dropped when parsing the dictionary.
2398 - PACKAGER corrected
2400 - AUTHORS updated and now in alphabetical order
2401 * Makefile.am now exports gdcm.dsw for Windoze users.
2403 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2404 * cygwin complains about missing std:: in subdir Test/
2406 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2407 * remove some methods that are now in gdcmHeaderHelper
2409 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2410 * vtkGdcmReader set spacing and origin correctly
2412 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2413 * Fix a few delete/delete[] mismatch
2415 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2416 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2417 interpretation to data given by gdcmHeader. For instance there are
2418 heuristics to get informations (look at different places).
2419 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2420 sorting DICOM images based on different strategies.
2421 * modified Makefiles accordingly.
2423 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2424 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2425 when building in debug mode
2426 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2427 src/win32/gdcmdll.dsp
2428 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2430 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2431 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2434 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2435 * src/win32/libgdcmjpeg12.dsp was not dos format
2436 * src/win32/libgdcmjpeg12.dsp :
2437 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2438 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2440 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2441 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2443 * src/gdcmFile.cxx : bug fix in affectation type
2444 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2445 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2446 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2447 symbols... future problem ?
2449 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2450 * src/win32/libgdcmijpeg12.dsp was missing
2451 * modified gdcm.dsw accordingly
2453 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2454 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2456 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2457 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2458 commit of JPR (before his hollidays to facilitate our work).
2459 * setup.py : bug fix in code. Modifications made while the last commit
2460 of JPR. The code hasn't been tested before the commit... it's so
2461 useless to make that (for best programmer that is JPR) !!!
2463 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2464 * tagged the current version as Version0_3 (i.e. version 0.3)
2466 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2467 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2468 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2469 * *.dsp : modifications to use new libgdcmijpeg8 library
2470 * setup.py : bug fix on VTKPATH variable
2471 * PACKAGER : adding all concerning windows
2473 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2474 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2476 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2477 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2478 test suite reported error.
2479 * PACKAGER file added (describes what a packager must do when
2480 packaging a new release).
2481 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2482 * configure.in: upgraded version number to 0.3.0
2483 * fixing build of rpm (through rpm -ta):
2484 - Doc/Makefile.am exports proper doxygen files
2485 - src/jpeg/libijg8/Makefile.am exports the include files.
2487 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2488 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2489 * src/gdcmHeader.h : formatting code
2491 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2492 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2493 We were obtaining error message from vtk. Now, creation of file list
2494 is made in an internal list to prevent this problem.
2495 Bug fix when output is empty.
2496 Bug fix in update of progress value. Previous commit for this was a bad
2498 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2500 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2501 * src/gdcmHeader.h : added method to get the file name
2502 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2503 files. Added method to remove all files on the input
2504 Added FIXME comment concerning the bad parsing of header made by
2505 ExecuteInformation method (in ExecuteData method)
2507 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2508 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2509 when using make instal.
2510 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2511 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2513 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2514 * setup.py : adding include dir of jpeg lib to compile all sources
2515 * */Win32/*.dsp : JPR fix for windows compilation
2517 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2518 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2520 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2521 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2523 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2524 * setup.py is again effective on un*x (takes into account the
2525 addon of the jpeg library)
2526 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2527 * Doc/Doxy* updated (includes above enhancements)
2528 * INSTALL now points to web documentation
2530 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2531 * src/gdcmHeader.h doesn't make unnecessary reference to
2533 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2535 * src/gdcm*.[cxx|h] :
2536 - to allow compilation with gcc 3.x
2537 -- clean up of STL usage (added explicit usage of std::)
2538 -- small fixes on exceptions.
2539 Note: linking not tested !
2540 - clean of doxygen comments to avoid warnings at documentation
2542 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2543 dependent convertion).
2545 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2546 * Clean up of previous JPR garbage commit (not even commented in the
2548 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2549 - moved all jpeg related files from src to src/jpeg/libijg8, with
2550 addition/modification of Makefile.am and configure.in.
2551 - the testSuite is still brain damage (not guilty).
2553 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2554 * WrapVTK.py : modifications to get correctly vtk source files to
2556 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2557 (FileName -> Filename)
2559 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2560 * vtk/vtkGdcmReader.[cxx/h]:
2561 - UpdateProgress method should now be effective
2562 - removed the limitation on having only images loaded (as opposed
2564 - when building a stack of images/volume, a lesser number of
2565 gdcmHeader and gdcmFile instances should be used (hopefully
2566 accelerating things).
2567 - when building a stack of images/volumes, files which are not
2568 loadable (wrong path-filename, wrong permissions on existing file,
2569 or file not parsable by gdcm) are replaced with a black image
2570 in the stack (for the caller to notice the problem).
2572 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2573 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2575 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2576 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2577 between standard library (std) and vtk library (problems are found
2578 under Windows... thanks Windows !)
2580 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2581 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2583 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2585 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2586 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2588 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2589 * When compiling with distutils (see setup.py) the C++ compiler is
2590 called with different flags than the default ones (with automake).
2591 In order to fix all those warning, I compiled gdcm with the command
2592 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2593 and went for warning fixes:
2594 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2595 up from unused variables.
2596 - vtk/vtkGdcmReader.cxx: potential bug fix.
2597 * src/gdcmHeader.h: Doxygen warning cleanup
2599 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2600 * gdcmPython/gdcm.i:
2601 - typemaps correction to take into account the systematic replacement
2602 of "using namespace std" with std:: prefix e.g. std::list,
2603 std::string... (cf changes of 2003-05-21).
2604 - gdcmGlob global variable of type gdcmGlobal (defined in
2605 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2606 exported to Python a as cvar.
2607 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2608 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2609 gdcmDictSet.GetPubDictTagNames() and
2610 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2611 C++ static methods).
2612 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2613 with the above changes.
2615 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2616 * setup.py, manifest.in : bug fix under linux
2618 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2619 * Modification of setup.py to compile vtk part too. Then, we have 2
2620 wrappers which must work with same distutils. For that, we have a
2621 generic distutils in distusiltsWrapping.py ; with :
2622 - build_extWrap class to wrap generically all extensions,
2623 - ExtensionWrap base class for all wrapping extension that contains
2625 - Wrapper interface which wrap sources
2626 + In WrapSwig.py we have extension and wrapper for Swig
2627 + In WrapVTK.py we have extension and wrapper for VTK
2628 * MANIFEST.in : modifications to consider vtk directory and new python
2629 files for compilation
2631 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2632 * Added python wrappers of vtkGdcmReader vtk class (see the
2633 source in vtk/vtkGdcmReader.cxx) :
2634 - vtk/Makefile.am now builds a library
2635 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2636 python library (as opposed to _gdcm.so wich are the python
2637 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2638 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2640 - configure.in has an additional flag --enable-vtk that needs
2641 to be set to enable compilation of vtk related code, that is:
2642 + vtk/vtkGdcmReader.so and
2643 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2644 + gdcmPython/vtkgdcmPython.so (see above)
2645 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2646 be read when compressed or when HighBit + 1 != BitsStored),
2647 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2648 the usage of the python wrapper of vtkGdcmReader vtk class.
2649 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2650 * src/*.[h] all occurences of stl classes are now prefixed with
2651 std::, and all occurences of "using namespace std;" where removed.
2652 This is to avoid pollution of global namespace in included files.
2653 Apparently vtk does not avoid this pitfall: when using both
2654 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2655 collision of various stl members (principally cout...).
2656 * gdcmPython/testSuite.py now cleanly removes temprory generated
2658 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2659 comply with above changes)
2661 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2662 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2663 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2664 vtk data structure (an image Flip was required).
2665 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2666 * cosmetic changes in documentation.
2668 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2669 * src/gdcmHeader.cxx: the constructor no longer exits when an
2670 unexisting file is given as argument.
2671 * The subdirectory Data (containing all the images used for the
2672 test suite) is not part of this repository anymore. A new module
2673 containing those images is now available at
2674 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2675 with the name gdcmData.
2676 All the python scripts (including the package initialisation file
2677 gdcmPython/__init__.py) were adapated to take this change into
2678 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2680 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2681 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2682 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2683 demo of the usage of this class.
2684 Compilation of this vtk part is only done when using the --enable-vtk
2685 at configure (or autogen.sh) stage.
2687 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2688 * More memory link related corrections and documentation fixes.
2690 - maximum info is obtained with a command of the form:
2691 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2692 --show-reachable=yes PrintHeader
2693 - the remaining reachable blocks seem to come from the STL
2694 allocation scheme through the usage of map and list. It looks
2695 like this memory cannot be freed but it is not a memory leak
2696 (in fact further invocation to the STL would recollect the
2697 unused memory allthough it cannot explicitely be freed).
2698 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2699 of displaying an image parsed with gdcm and displayed with VTK.
2700 Note: some images don't seem to work e.g.
2701 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2702 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2703 Allthough this weakens the semantics, it is a ditch attempt to
2704 make gdcm more thread friendly.
2706 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2707 * Memory link hunt (by using valgrind through the command
2708 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2709 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2710 gdcmHeader::_dicom_vr.
2711 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2712 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2714 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2716 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2717 * src/Makefile.am now exports all the necessary include files at
2721 * UpdateGroupLength replaced by new one
2724 * UpdateGroupLength re-written using H-Table
2725 (named UpdateGroupLengthNew untill checks are over)
2727 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2728 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2729 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2731 - gdcmHeader::GetPubElValSet removed.
2732 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2733 UpdateGroupLength, WriteElements, Write.
2734 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2735 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2736 carried the same semantics.
2737 - src/gdcmHeaderIdo.cxx changed accordingly.
2738 - gdcmFile::WriteBase now regroups all the codes from previous
2739 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2740 - enum FileType moved to gdcmCommon.h
2741 * src/gdcmHeader.cxx AddDefault trashed
2742 * gdcmGetXSize added
2743 * getimageDataSize now calls gdcmGetXSize
2744 * Test/*.cxx changed to agree with above changes
2746 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2747 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2748 (to avoid double call by end user).
2749 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2750 by end user, since gdcmHeader::gdcmHeader now handles it.
2752 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2753 * gdcm/Doc many doxygen changes:
2754 - Doxyfile now has two different versions, DoxyfileUsers that generates
2755 the html.users end users oriented documentation and
2756 DoxyfileDeveloppers that generates the html.developper developper
2757 oriented documentation.
2758 - README changed accordingly
2759 - requirement.txt removed (old design info moved to TODO).
2760 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2761 DoxyMainPage.txt, DoxyPython.txt provide more information.
2762 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2763 be updated by simply regenerating the docs with doxygen and copying
2764 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2765 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2766 all the tests in the form "if (<map>.count() >1)" were removed.
2767 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2768 ill-formed documentation sections.
2769 * src/gdcmHeader.cxx: ditto
2771 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2772 * setup.py fixed for un*x (needed macro for stdint.h)
2773 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2774 un*ces with sh-utils test utility.
2775 * gdcmPython/demo/test.py renamed to PrintHeader.py
2776 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2777 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2778 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2779 * src/gdcm*.cxx JPR's bad inclusion fixed.
2781 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2782 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2783 * gdcmPython/demo/test.py changed accordingly.
2785 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2786 * gdcmPython/Makefile.am fixed linking against libstdc++
2787 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2788 * Swig subdir (historical tests of swig version 1.3.17++) removed
2789 * Test/testChangeEntete.cxx some lines commented out in order to make
2791 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2792 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2794 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2795 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2796 hence the user doesn't need this explicit call.
2797 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2798 i.e. LoadElements() call removed.
2799 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2800 - src/Makefile.am declares the proper flag for g++.
2801 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2802 for adding user defined new tags.
2803 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2804 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2805 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2807 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2808 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2809 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2810 src/Makefile.am : the project should properly compile and install
2811 with the autotools, included the python wrappers part.
2812 * gdcm.spec.in : added a spec file for RPM packaging.
2814 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2815 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2817 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2818 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2819 to exported to the environement (see gdcmPython/testSuite.py
2821 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2822 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2823 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2824 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2825 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2827 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2828 * gdcmPython/__init__.py doesn't crash anymore when running in
2829 in InstallMode or PreInstallMode but with an environment given
2830 value of GDCM_DICT_PATH.
2831 * src/gdcmDictSet.[cxx/h] coding style.
2833 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2834 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2835 * src/gdcm.h general comments moved to TODO, and README
2836 * src/gdcm.h should now be seen as a user commodity (including it
2837 should suffice to fully use gdcm). It is nowhere including within
2838 any of the kernel files src/*.cxx and src/*.h.
2840 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2841 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2842 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2844 * src/gdcm*.cxx only include their corresponding include file
2845 (as opposed to gdcm.h)
2846 * gdcmPython/gdcm.i changed accordingly
2847 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2848 the autogen.sh generated "make snapshot" command to work.
2849 * autogen.sh removed history related references to crea package.
2851 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2852 * distutilsSwigCPlusPlus.py work around some swig portability
2855 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2856 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2857 was done in a last ditch attempt to get setup.py _really_
2858 operationnal. The python/gdcmPython layaout add the advantage
2859 of hidding away the python related distutils specific files
2860 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2861 Alas, the src directory was out of scope (i.e. it's relative
2862 position to setup.py was ../src) which made things impossible to
2863 handle (see previous version of python/setup.py). Crossing fingers...
2865 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2866 * python/setup.py now works on Un*x. (harder than I thougth)
2867 * python/distutilsSwigCPlusPlus.py can now have include files
2868 among the list of sources.
2870 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2871 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2872 * modifications in MSVC projects
2874 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2875 * As stated by the first lines of Test/ExceptionAndPython/README, it
2876 looks like we can move back to original usage of exception within
2877 src/gdcm* and hence remove the errno stuff that was introduced
2878 as a quick and dirty fixture of this problem (added to the TODO).
2879 * Doc/Doxyfile configuration file for Doxygen and corresponding
2880 README file for usage added.
2881 * Test/testWrite.cxx added. This new test comes from a split of
2882 test.cxx that is now reverted to its original purpous i.e.
2883 testing the proper parsing of a Dicom related file.
2884 testWrite.cxx concentrates on testing the IO part of gdcm.
2885 * Test/bug1.cxx (containing a bug on WIn32) added.
2886 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2887 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2888 whose purpose is to publish the content of the TagNames of the
2889 Dicom public dictionary were not accessible without an
2890 instance of class gdcmHeader.
2891 - those methods are now static methods of gdcmDictSet and hence
2892 require no instances at all to be invocated.
2893 - within gdcmDictSet this change required to change some method
2894 to class methods (i.e. are now static) among which SetDictPath
2895 (renamed to BuildDictPath) and LoadDefaultPubDict.
2896 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2897 the above changes by calling the new method classes of gdcmDictSet.
2898 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2899 the above to be effective.
2900 * python/gdcmPython: in order to wrap properly the above changes
2901 for Python, swig version now needs to be > 1.3.17.
2902 * python/gdcmPython/Makefile fixed to adapt itself to new
2903 configure/make shema introduced by Johan Montagnat (thanks for the
2904 contribution). Alas this Makefile cannot be turned into a proper
2905 Makefile.am without some heavy changes in the configure.in
2906 (for python dectection).
2907 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2908 now avoids publishing the empty entries.
2910 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2911 * python/setup.py : bug fix concerning install under windows
2912 ExtraPath reused :-P
2913 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2915 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2916 * Dicts/dicomV3.dic : remove double spaces !!!
2917 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2918 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2921 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2922 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2923 method. Doxygenation.
2924 * src/gdcm.h clean up of JPR spurious comments.
2926 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2927 * python/distutilsSwigCPlusPlus.py now properly collects the
2928 shadow classes generated by "swig -c++" (gdcm.py in our case)
2929 when using "python setup.py install".
2930 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2931 reexports the working classes.
2932 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2933 by the classical C errno scheme. This is to prevent an obscure
2934 behavior of the python wrappers when importing wxPython.wx prior
2935 to gdcmPython (which ended up in an abort call). An illustration
2936 of this oddity can be found in the Test/ExceptionAndPython
2937 subdir (see the README file). This problem probably due to
2938 an combination of g++ and dynamic loading.
2939 * added Test/ExceptionAndPython (see above)
2941 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2942 * Changed the layout of the python part to avoid bloating main
2943 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2944 i.e. the distutils arsenal. All the python related stuff is
2945 again in a python subdir, but the package itself is now in
2947 * setup.py was cleaned up:
2948 - pythonIncludePath removed
2949 - python setup.py bdist target is now functional.
2950 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2951 collision with other packages). gdcmPython/demo/*.py changed
2954 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2955 * python subdir moved to gdcmPython (preparation of distutils packaging).
2956 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2957 distutils installer is operational.
2958 * - gdcmPython/__init__.py now properly loads the swig generated
2959 shadow classes (from gdcm.py).
2960 - gdcmPython/demo/*.py changed to import the package gdcmPython
2961 instead of gdcmPython/demo/load.py.
2962 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2964 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2965 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2966 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2967 entries within the associated public Dicom dictionary resp. the same
2968 information but sorted by the fourth field (PAT, IMG, DIR) of the
2970 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2971 are now in the "???" group.
2972 - python/gdcm.i changed accordingly,
2973 - python/demo/printGroupedPublicDict.py added, that gives an example
2974 of the above new functionalities in Python.
2976 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2977 * src/gdcm.h, gdcmHeader.cxx:
2978 - historic references to glib's g_malloc and g_free (#defined)
2979 were definitively removed.
2980 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2981 * src/gdcmElValSet.cxx:
2982 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2983 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2984 - GetElValue(string) renamed to GetElValueByName.
2985 - Added GetElementByName(string).
2986 * src/gdcmHeader.cxx: added
2987 - GetPubElValRepByNumber(guint16, guint16)
2988 - GetPubElValRepByName(string)
2989 - GetShaElValRepByNumber(guint16, guint16)
2990 - GetShaElValRepByName(string)
2991 - GetShaElValByNumber(guint16, guint16)
2992 - GetShaElValRepByName(string)
2993 - GetElValRepByNumber(guint16, guint16)
2994 - GetElValRepByName(string)
2995 - GetElValByNumber(guint16, guint16)
2996 - GetElValRepByName(string)
2997 * Doc/requirements.txt added.
2999 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3000 * Test/Makefile building now depends on the one of libgdcm.so
3001 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3002 pixel data) aware which enables finding the address (offset) of
3003 the pixel data of JPEG encoded DICOM files. This leaves only a single
3004 file in the testSuite whose pixel data address (offset) is unknown.
3005 * python/testSuite.py changed accordingly.
3007 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3008 * VC++ has some strong limitations when working with the STL, as stated
3009 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3010 "Also note that some STL containers (map, set, queue, list, deque)
3011 cannot be exported. [...]
3012 Some STL classes contain nested classes. These classes can not
3014 This is caused by a designed limitation that once a template
3015 class is instantiated, it can not be re-instantiated and
3017 Since our usage of map<> is ubiquitous in gdcm, this "designed
3018 limitation" of VC++ is a pitfall.
3019 Hence the Python wrappers of gdcm cannot be incrementally linked
3020 against the c++ dynamic library. The dirty but only workaround is
3021 to forget about incremental link of dynamic libraries and to generate
3022 the Python wrappers library with the inclusions of the underlying C++
3024 The following modifications concern this matter on Win32/VC++:
3025 - wrapping python correct with standalone wrapped dll (don't use separate
3026 dll under windows !!!!)
3027 - python21_d debug mode enabled (ask Frog how to use it :-)
3028 - NO problem with having an STL member of class for example string in C++
3029 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3030 - Python test of dcmlib in Python is ok under windows on a large set
3032 * removed glib references
3033 * typedef's inserted in gdcm.i for correct swig type management
3035 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3036 * python/demo/*.py load.py extracted from test.py. Added explore.py
3037 that only displays required tags and testAll.py that parses all
3038 the files of the testsuite without using unittest.
3039 * python/testSuite.py other additional test on new files added.
3040 * Data/* new test files added accordingly to the testSuite.
3041 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3042 the vr in the file differs from the one of the dictionary.
3044 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3045 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3046 values, but limits itself to values which are below a user specified
3047 size (by default 1024 bytes).
3048 * python/gdcm.i : elements not loaded (because their size is above the
3049 user specified treshold) are exported with their TagKey as key of the
3050 python dictionary. This enables the testsuite to make some checks
3051 on the unloaded elements (since we have their offset and size).
3052 * python/testSuite.py
3053 - now tests for the existence and proper value of the pixel data
3054 - two new examples added.
3055 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3057 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3058 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3059 aware. See the strategy comments in gdcmHeader::FindeLength().
3060 * Test/test.cxx now accepts a filename as first argument.
3061 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3062 * python/testSuite.py changed to integrate test on above files.
3064 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3065 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3066 the vr was also RET.
3067 * python/testSuite.py more tests added.
3069 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3070 * python/testSuite.py unittest test suite added (uses Data)
3071 * Data/* dcm and acr files for the test suite.
3072 * glib dependance removed from un*x version. We now use ISO C99
3073 7.18 Integer types (see stdint.h)
3074 - python/Makefile, src/Makefile src/gdcm.h
3075 * src/ when an explicit vr (like dicom files) suddenly poped an
3076 implicit element we use to mark the underlying DictEntry of the
3077 concerned ElValue with "Implicit". This strategy was damageable
3078 too the public or provite dictionaries, since some of their vr
3079 would be changed. Since Header::FindLength heavily relies on the
3080 detection by Header::FindVR of falsely explicit elements, I
3081 added an extra ImplicitVr member to ElValue (boolean).
3082 The rest of the changes we the necessary adaptations.
3084 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3085 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3087 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3089 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3090 * Adaptation for porting to VC++:
3092 o forced to use std namespace (for string to be known)
3093 o all class use __declspec export style on WIN32
3094 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3095 (in stdlib.h on Win32 but in std:: for gcc)
3096 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3097 variable GDCM_DICT_PATH.
3098 * src/gdcmHeader.cxx verbose comments made discrete.
3100 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3101 * python/gdcm.i: added a typemap that converts a C++ hashing table
3102 to native Python dictionary.
3103 * python/demo/test.py:
3104 - now uses the native dictionary for exploration of gdcmHeader.
3105 - takes an optional filename argument (the file to parse).
3106 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3107 PubElVals hashing table.
3108 * Dicts/dicomV3.dic removed error prone trailing spaces.
3110 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3111 * Python wrapping process moved away from src/Makefile to
3112 newly created python/Makefile (as well as gdcm.i)
3113 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3114 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3115 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3116 from the environement variable GDCM_DICT_PATH (when existing).
3117 * src/gdcmDict::GetTag bug fix.
3119 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3120 * Straightforward temporary fixes for swig to build the python wrappers.
3121 src/Makefile now has a python working entry [by working we mean
3122 that we can import de shadow classes without errors].
3124 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3125 * hashtest.cxx removed (since already in Test)
3126 * src/gdcmlib.h renamed to src/gdcm.h
3127 * src/dcm.i renamed to src/gdcm.i
3128 * src/Makefile prepared for python wrapping
3130 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3131 * src/gdcmHeader.cxx :
3132 - Parsing of header is now separated from loading of element values
3133 (see gdcmHeader::LoadElements).
3134 - general clean up of hopefully all file access (creation of
3135 ReadInt16 and ReadInt32)
3137 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * src/gdcmHeader.cxx :
3139 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3141 - SetLgrElem renamed to SetLength
3142 - GetLgrElem renamed to GetLength
3143 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3144 * src/gdcmElValSet.cxx fixed both GetElValue methods
3145 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3146 due to IdoDude was cleaned out.
3148 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3149 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3150 concentrates on finding the value representation (when it exists).
3151 RecupLgr now only finds the element value length, and it avoids
3152 returning the unecessary skL (skipped length).
3153 Also, offsetCourant was simply removed (with taille_fich) since
3154 it was redundant with the File position internals (by using
3155 ftell and fseek). This also made skL (see above in RecupLgr) usage
3157 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3158 on the libido specificities which are handled through class
3160 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3163 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3164 * Truckload of changes. Parsing of header is barely functional
3165 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3167 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3168 * src/gdcmHeader.cxx many addons of low level methods
3170 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3171 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3172 and _IdDcmSWAP_LONG.
3174 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3175 * This corresponds to all the changes decided at the meeting of
3176 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob