1 Thu Aug 25 16:59:49 2005 by jpr
3 Now Print displays the BinEntry Content (if it's printable, and loaded)
4 Usefull for a lot od Implicit VR 'Bin'Entry (if we knew there VR, they wouldn't
6 Appreciate the difference having a look at PrintFile result for
7 gdcmData/SIEMENS_MAGNETOM-12-MONO2-FileSeq0.dcm.
9 Thu Aug 25 16:55:47 2005 by jpr
11 Add methods to check the 'printability' of a bin area
13 Thu Aug 25 15:45:40 2005 by jpr
15 According to Mathieu's suggestion, Print now display FL BinEntries in a human
18 Thu Aug 25 15:12:43 2005 by jpr
20 According to Mathieu's suggestion, *all* the elements 0x000
21 are now named 'Group Length' (even if they belong to a Shadow Group')
23 Wed Aug 24 14:09:13 2005 by jpr
24 gdcmDocEntry.cxx,h, gdcmDocEntrySet.cxx,h
25 Removal of QD patch for Private Sequence + Immplicit VR.
26 Add a clean solution (Backtracking if an Item Starter is found
29 Tue Aug 23 14:57:49 2005 by jpr
31 Brutal patch, waiting till we find a clever way to guess
32 if a doc entry is a Sequence,
33 - when it's odd number
34 - and the file is Implicit VR Transfert Syntax
35 It solves temporarily some Philips Medical Systems image problems
37 Mon Aug 22 18:17:54 200 by jpr
39 Save a *few* microseconds at run time : inline method Util::GetVersion()
42 Tue Aug 23 14:58:49 2005 by jpr
43 gdcmSeqEntry.cxx, gdcmDocEntry.cxx
44 Improve 'Print' methods
46 Sat Aug 20 11:10:24 2005by jpr
48 Use new style FileHelper contructor
50 Sat Aug 20 11:04:50 2005 by jpr
52 FileHelper::Initialize() doesn't call GrabInformationFromFile(),
53 in order not to do the job twice when using new style FileHelper Constructor.
55 Fri Aug 19 18:31:07 2005 by malaterre
57 ENH: Provide a GetVersion function, apparently need for python
59 Fri Aug 19 15:12:15 2005 by jpr
61 Initialize UserFunction pointer to 0, even for 'deprecated' form
64 Sat Jul 30 20:27:00 2005 by jpr
65 gdcmFileHelper.cxx, gdcmPixelReadConvertor.cxx
66 User is now allowed to pass a Pointer to a function of his own
67 to allow modification of pixel order (i.e. : Mirror, TopDown, )
68 to gdcm::FileHeleper, using SetUserFunction(userSuppliedFunction)
69 described as : void userSuppliedFunction(uint8_t *im, gdcm::File *f);
70 NB : the "uint8_t *" type of first param is just for prototyping.
71 User will Cast it according what he founds with f->GetPixelType()
72 See ctkgdcmSerieViewer for an example
74 Sat Jul 30 20:13:24 2005 by jpr
76 Add SerieHelper::IsCoherent() method to allow checking that the files with same
77 Serie UID have the same sizes and pixel type.
79 Fri Jul 29 17:07:16 2005 by jpr
82 SetSortOrderToDirect() or SetSortOrderToReverse()
83 to choose the ways the File* will be sorted.
85 Thu Jul 21 06:55:50 2005 by jpr
86 AnonymizeDicomDir.cxx, AnomymizeNoLoad.cxx, PrintFile.cxx, PrintDicomDir.cxx
89 Thu Jul 21 06:55:30 2005 by jpr
91 Add an example of use for SerieHelper
93 Thu Jul 21 07:00:15 2005 by jpr
95 Extend 'Restriction' syntax :
96 void SerieHelper::AddRestriction(uint16_t group, uint16_t elem,
97 std::string const &value, int op)
99 /// \brief comparaison operators
109 Wed Jul 20 15:39:00 2005 by jpr
111 AnonymizeNoLoad user can now ask for anonymization of 'BinEntries'
112 (e.g. Private entries when the TS is Implict VR)
113 AnonymizeNoLoad filein=... rubout=0x0009-0x0001,0x0013-0x1100
114 Thx to Luca Picello for reporting pb and supplying data to fix the bug.
116 Wed Jul 20 16:49:41 2005 by jpr
118 Use GDCM_LEGACY for DicomDir, as well
120 Wed Jul 20 15:31:01 2005 by jpr
122 We can now anonymize 'BinEntries' as well
124 Wed Jul 20 15:29:42 2005 by jpr
126 Add ArgMgrGetXInt16Enum to decode from the command line pairs of unsigned int
127 16, written in hexadecimal.
128 (usefull to allow terminal user to pass the (private) elements he wants to
131 Tue Jul 19 17:25:53 2005 by jpr
133 Add some comments on the 'Patient Position'
135 Tue Jul 19 11:04:58 2005 by jpr
137 Add SerieHelper::AddGdcmFile(File *header) method.
138 * \brief add a gdcm::File to the first (and supposed to be unique) list
139 * of the gdcm::SerieHelper.
140 * \warning : this method should be used by aware users only!
141 * User is supposed to know the files he want to deal with
142 * and consider them they belong to the same Serie
143 * (even if their Serie UID is different)
144 * user will probabely OrderFileList() this list (actually, ordering
145 * user choosen gdm::File is the sole interest of this method)
146 * Moreover, using vtkGdcmReader::SetCoherentFileList() will avoid
147 * vtkGdcmReader parsing twice the same files.
148 * *no* coherence check is performed, but those specified
149 * by SerieHelper::AddRestriction()
151 Mon Jul 18 12:20:20 2005 by jpr
153 In order to prepare the future extension of SerieHelper::AddRestriction (key,
155 operator = { EQUAL, DIFFERENT, LESS, LESSOREQUAL, GREATER, GREATEROOREQUAL}
157 bool Util::CompareDicomString(const std::string &s1, const char *s2, int op)
159 Sun Jul 17 06:27:49 2005 by jpr
161 Use new style for Loading files
163 Tue Jul 12 19:08:12 2005 by jpr
164 gdcmCommon.cxx, gdcmSQItem.cxx
165 To speed up DicomDir, instead of copying -and removing the source afterwards-
166 each entry of the SQItem (found after gdcm::Document parsing) towards
167 the gdcm::Object belonging to the gdcm::DicomDir, we just copy
168 the chained list itself.
170 Tue Jul 12 16:55:43 2005 by jpr
172 AnonymizeNoLoad has now one more option :
174 to give the (single Patient) directory name whose content we want to anonymize.
176 Mon Jul 11 10:20:25 2005 by jpr
177 gdcmDicomDirStudy.cxx
180 Fri Jul 8 21:07:12 2005 by jpr
182 Add the VISIT object within DicomDir
184 Fri Jul 8 12:15:08 2005 by jpr
186 Use new style for DicomDir loading
188 Fri Jul 8 16:36:48 2005 by jpr
190 To remain unimpared, gdcm::FileHelper class needs also its
191 void FileHelper::SetLoadMode(int loadMode)
192 void FileHelper::SetFileName(std::string const &fileName)
193 bool FileHelper::Load()
195 Thu Jul 7 19:31:53 2005 by jpr
197 Begin of kosherization of Example
200 Thu Jul 7 18:37:40 2005 by jpr
202 On the way to gdcm2 ...
203 Now, the stand way to use a file is :
204 gdcm::File *f = new gdcm::File();
205 f->SetLoadMode ( user say here what he wants *not* to load );
206 f->SetFileName("myFile.gdcm");
208 Old styles are kept, not to break the C++ API.
209 - gdcm::File *f = new gdcm::File("myFile.gdcm");
210 - f->Load("myFile.gdcm");
211 Due to the syntaxic abilities of Python maybe some troubles will occur
214 Thu Jul 7 15:55:39 2005 by jpr
216 Comment out the time consuming, never used/useless
217 'Extended tag' stuff for Sequence embedded Entries
219 Thu Jul 7 15:11:38 2005 by jpr
221 Move code lines LTTG so save some CPU time.
224 Tue Jun 7 13:12:10 2005 CEST by jpr
226 Use Argument Manager in 'utilities'
228 Thu Jul 7 12:12:32 2005 by jpr
230 Due to something stupid in the gdcm::File constructor, the file was parsed
231 twice when we used old style, e.g :
232 gdcm::File *f = new gdcm::File(fileName);
233 instead of new style, e.g. :
234 gdcm::File *f = new gdcm::File( );
235 f->SetLoadMode ( choose what you want *not* to load here );
238 Wed Jul 6 11:53:43 2005 by jpr
239 TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx
240 Now TestAllReadCompareDicom.cxx TestReadWriteReadCompare.cxx accept a third
241 param, in order not to have to recompile to gdcm::Debug::DebugOn().
243 Wed Jul 6 17:18:42 2005 by jpr
245 According to Mathieu's requirement, Load twice the same file keeps the rseult of
246 the first Load (instead of doing it twice)
248 Wed Jul 6 11:25:12 2005 by jpr
250 - Clean out the Entries if a Document is parsed more than once
251 - Uncomment (usefull) warning messages
253 Wed Jul 6 10:42:33 2005 by jpr
255 - Comment out a for the moment too much verbose warning message.
256 - Delay some statement as late as possible, to save some CPU time when they're
259 Wed Jul 6 13:01:08 2005 by jpr
261 Now gdcmFile::Load() returns false if file is not gdcm parsable
262 Only gdcmDocument::Load() did it, before.
263 Thx to Benoit for reporting bug
265 Sun Jul 3 14:42:04 2005 by jpr
267 Should avoid some troubles with 'no length' SQItems within 'true length'
269 Thx to Loic Boussel for providing data to fix the bug.
271 Sun Jul 3 14:42:04 2005 by jpr
273 Should avoid some troubles with 'no length' SQItems within 'true length'
275 Thx to Loic Boussel for providing data to fix the bug.
277 Sun Jul 3 14:47:23 2005 by jpr
281 Fri Jul 1 13:25:51 2005 by jpr
282 gdcmPixelReadConvert.cxx
283 Initialize RLEInfo and JPEGInfo to 0 a avoid further problems
284 (e.g. PrintFile on a DICOMDIR document)
286 Thu Jun 30 16:49:02 2005 by jpr
288 Enhance gdcm::File::IsReable() heuristics to be able to process some Loic
289 Boussel's Hall of Shame Dicom images
291 Wed Jun 29 17:58:33 2005 by jpr
293 Add the NO_SHADOWSEQ load mode
295 2005-06-26 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
296 * Quite a few new dictionaries were added in gdcm. The file:
297 gdcm/Dict/README should always explain were the info was found
298 (in case of double check). Also some dict are still only
299 express as 'template' (they contain 'xx'), therefore
300 a python script should be run first to generate a full dict.
301 In the longer term this python script should be replaced by
304 2005-06-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
305 * dicomV3.dic is deprecated in favor of gdcm.dic
306 There is now a dictionary per family:
307 - dicomV3.dic -> DICOM V3
308 - Papyrus.dic -> Papyrus
309 - NIH.dic -> tags that were never allowed in the main standard
311 Fri Jun 24 12:50:20 2005 CEST by jpr
313 Pixel Spacing related problems : update comments.
314 Thx to D. Clunie for providing data to check the code
316 Fri Jun 24 12:55:58 2005 by jpr
317 Summer nights are really too hot to sleep.
318 Coding style : kosherization of all the 'if's (300 amongst 900 were haram)
320 Thu Jun 23 11:20:23 2005 by jpr
322 Extend warning message, for debugging purpose
324 Wed Jun 22 10:11:23 2005 by jpr
328 Wed Jun 22 10:00:29 2005 by jpr
329 gdcmPixelReadConvert.cxx
330 Fix misstyping, while removing spurious \t characters
332 Wed Jun 22 09:52:32 2005 by jpr
333 gdcmPixelReadConvert.cxx
334 Some constructors (at least one ...) use BitsAllocated =! BitsStored for
336 That break at lot of viewers ...
337 We now *propagate the sign bit* upon the unused ones, better than masking them
339 Thx to Luca Picello for profiding data to fix the bug
341 Wed Jun 22 09:53:52 2005 by jpr
343 gdcm images are now "GDCM 1.1" built.
345 Mon Jun 20 19:10:17 2005 by jpr
347 Avoid re writing Palette Color Lookup Table UID when Palette Color is removed
349 Mon Jun 20 17:58:53 2005 by jpr
351 Preventive bug fix for LUT Data.
352 I said : LUT Date, *not* Palette Color
354 Sun Jun 19 17:57:29 2005 by jpr
356 To avoid warnings at compile time
358 Fri Jun 17 14:27:52 2005 by jpr
362 Fri Jun 17 14:36:07 2005 by jpr
366 Fri Jun 17 14:35:00 2005 by jpr
368 Add some accessors for debugging purpose
370 Tue Jun 14 15:56:41 2005 by jpr
371 gdcmPixelReadConvert.cxx
372 Now gdcm deals with 16 bits per pixel images with 16 bits Palette colors
373 (3 * 65536 short int ...)
375 "Segmented Palettes" pb still pending, but I never saw any viewer dealing with it.
377 Mon Jun 13 17:43:48 2005 by jpr
378 gdcmPixelReadConvert.cxx
379 Some more oddities dealt with.
380 Doesn't work yet with 65536 entries 16 Bits LUT (?!?), with 16 bits pixels.
381 Still looking for accurate info on the web about it
383 Fri Jun 10 16:05:38 2005 by jpr
385 Bug fix in Load method.
386 Thx to Benoit for providing fix.
387 2005-06-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
388 * src/gdcmUtil.cxx : change call to Util::Format to sprintf because of
389 lantency with the Util::Format function
391 Tue Jun 7 15:48:35 2005 by jpr
393 The highy time consuming method GetMacAdress is now called just once
395 Tue Jun 7 11:58:29 2005 by jpr
396 gdcmDicomDirElement.cxx
397 Use TranslateToKey better than Format
399 Tue Jun 7 12:07:20 by jpr
401 Remove some spurious calls to Format
402 // according to 'Purify', TranslateToKey is one of the most
403 // time consuming methods.
404 // Let's try to shorten it !
406 Mon Jun 6 14:37:58 2005
407 class ArgMgr (for Arguments Manager) is designed for
408 command line arguments management
409 (to make programmer's live easier)
410 (could be used for any kind of 'command line program')
412 2005-06-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
413 * Adding users file in CVSROOT for mail blaming
415 2005-06-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
416 * Adding potential support for JPEG-LS DICOM files.
418 Fri Jun 3 18:05:23 2005 by jpr
420 Fix VR processing, to be CP-288 conform.
421 Now we can parse any kind of DICOM SR.
423 Fri Jun 3 11:05:15 2005 by jpr
427 Thu Jun 2 15:42:18 2005 by jpr
429 Add warning about Load Mode
431 Thu Jun 2 16:20:14 2005 by jpr
433 Harden gdcm::File::IsReadable(), in order not to be confused any longer
434 by lost of Pixel Element
436 Fri May 27 12:51:00 2005 by jpr
438 To avoid pushing out twice the meta elements, wile trying to write 'ACR-NEMA-
440 And avoid some memry leaks -hope so-
442 Wed May 25 14:54:17 2005 by jpr
444 Should avoid some memory leaks
446 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
447 * Adding potential support for mpeg and jpeg2000 through two new lin
448 - JasPer for JPEG2000
449 - libmpeg2 from the MPEG consortium
450 Also adding intial work to use this lib.
452 Fri May 20 10:27:55 2005 by jpr
455 (this time, it's wasn't dangerous at run time)
457 Thu May 19 17:31:21 2005 by jpr
459 FIX possible troubles when checking
460 'Hight Bit Position' vs 'Bits Allocated' and 'Bits Stored'
461 Thx to Mathieu for reporting bug
463 Wed May 18 12:12:07 2005 by jpr
465 Fix : now dcm deals with 'No preamble', Big Endian Explicit VR group 0002.
466 Thx to Dennis Hu for providing a sample image to fix the bug.
468 Tue May 17 14:44:09 2005 by jpr
470 ENH : According to David Clunie's advice, we check now 'Imager Pixel Spacing'
471 before 'Pixel Spacing', when we want to get X or Y Spacing.
473 Tue May 17 19:10:49 2005 by jpr
475 ENH : Now, FileHelper::CheckMandatoryElements() makes some consistency checking,
476 at LTTG (Least Time To Go)
477 around Bits Allocated, Bits Stored, High Bit Position,
478 to avoid unaware user to mess up the stuff.
480 Tue May 3 11:43:04 2005 by jpr
482 Load returns now a bool (allow user not to call IsReadable() )
484 Tue May 3 11:51:06 2005by jpr
486 Now the gdcm::File remains unimpaired after writting, in any case
488 Fri Apr 29 17:10:55 2005by jpr
490 Don't abort the prog when File not open
492 Wed Apr 27 12:00:35 2005 by jpr
494 Removal of now useless lut-related stuff
496 Wed Apr 27 11:52:27 2005 by jpr
498 Pb of 'Bits Allocated = 12' is now dealt with in
499 FileHelper::CheckMandatoryElements, no longer in File::Write.
500 Thx to Mathieu for reporting bug.
502 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
506 Tue Apr 26 18:18:23 2005 by jpr
508 Should leave gdcm::Document constructor in a much quicker
509 and much cleaner way when anything wrong occurs.
511 Tue Apr 26 18:25:49 2005 by jpr
512 gdcmPixelReadConvert.cxx
513 Prepare MPEG Dicom encapsulated processing (within a loooong future)
515 Fri Apr 22 14:59:58 2005 by jpr
517 Modify Print() output
519 Fri Apr 22 15:37:57 2005 by jpr
521 Prepare (future) MPEG integration
523 Thu Apr 21 09:40:00 2005 by jpr
525 Taking into account Dicom MPEG
527 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
528 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
529 But this is a case where we should really signify the user there is
530 few chance the serie is really a serie...
532 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * FIX : on X, the python part is correctly installed. All files are
534 installed in gdcm sub-directory
536 Tue Apr 19 11:58:19 2005 by jpr
538 Should suppress some warnings from Borland compiler
540 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
541 * Builder/ : add something to facilitate the RPM creation of gdcm
543 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
544 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
546 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
548 Thu Apr 14 16:26:19 2005 by jpr
550 Now, user can ask gdcm::DicomDir to skip SeqEntries or shadow groups, when
552 // Old style (still available) :
553 dcmdir = new gdcm::DicomDir(dirName, true);
555 // new style (user is allowed no to load Sequences an/or Shadow Groups)
556 dcmdir = new gdcm::DicomDir( );
557 dcmdir->SetParseDir(true);
558 dcmdir->SetLoadMode(NO_SEQ | NO_SHADOW);
559 dcmdir->Load(dirName);
561 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
562 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
564 * Fix compilation on gcc 2.96 (which does not have ios::failure)
566 Mon Apr 4 17:15:24 2005 by jpr
568 Fix stupid bug when writting ACR-NEMA image from 'ACR-LibIDO' one.
570 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
571 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
572 and it's representation name (for the NIH)
574 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
576 conversion of YBR to RGB pixels. So, now, the conversion is made using
579 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
580 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
581 format) to replace 'at-run' dicom files generated by the
582 TestAllReadCompareDicom test
584 Tue Mar 22 12:29:37 2005 by jpr
586 * FIX : element 0x0000 of shadow groups is now force to a ValEntry,
587 and it's VR is forced to UL
588 * ENH : user id now allowed to tell he doesn't want to deal with Sequences
589 and/or with Shadow groups
590 use SetLoadMode (NO_SEQ | NO-SHADOW);
592 Tue Mar 22 12:40:13 2005 by jpr
594 *FIX Restore pushed out elements
596 Fri Mar 11 12:08:31 2005 by jpr
598 Remove spurious #define MAX_SIZE_PRINT_ELEMENT_VALUE
600 Fri Mar 11 12:12:13 2005 by jpr
602 Final removal of gdcmFileHelper::InitializeDefaultFile();
604 Wed Mar 9 20:29:38 2005 by jpr
606 Add Anonymize method (not yet fully checked)
608 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
609 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
611 Wed Mar 2 18:18:32 2005by jpr
613 Fix gdcm::FileHelper::CheckMandatoryElements() to take into account David
616 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
617 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
619 Mon Feb 21 18:45:41 2005 by jpr
621 * Replace method CheckMetaElements by CheckManadatoryElements
622 To deal with the pb of UID's, and with Type 1 an Type 2 Entries
623 (probabely some stuff still missing)
624 * We shall have to decide the way we proceed to allow user 'freeze' Serie UID
625 between a given call and the next one (to add images to a Serie he just
627 * We shall have to decide the way we proceed to allow user 'freeze' Study UID
628 between a given call and the next one, or to reuse an already existing
629 Study UID (i he wants to add his own Series to an already existing Study)
631 Thu Feb 17 17:18:33 2005 by jpr
633 To avoid further pb, Initialize defaults now Photochromatic Interpretation to
634 MONOCHROME2 (low values = dark), better than MONOCHRONE1.
635 Thx to Benoit for reporting bug
637 Thu Feb 17 11:56:20 2005 by jpr
639 Prepare FileMetaInformationVersion (group 0002) management
641 Thu Feb 17 12:02:47 2005 by jpr
643 Group 0002 management
645 Thu Feb 17 12:03:32 2005 by jpr
646 gdcmDocEntryArchive.cxx
649 Wed Feb 16 11:19:19 2005 CET by jpr
650 gdcmPixelReadConvert.cxx
651 Taking into account MONOCHROME1 + Signed Pixels (?!)
653 Tue Feb 15 19:12:34 2005 by jpr
655 Taking into account the difference between MONOCHROME1 (low values = bright)
656 and MONOCHROME2 (low values = dark)
658 Mon Feb 14 11:45:04 2005by jpr
660 Remove some useless mask operations, to save CPU time
662 Mon Feb 14 15:51:10 2005 by jpr
664 *never* forget to re-compile just *before* committing!
666 Mon Feb 14 15:34:27 2005 by jpr
668 First commit on the post 1.0 (Version? / Tag? / Branch?) :
671 Mon Feb 14 11:45:47 2005 by jpr
673 remove useless comments
675 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
676 * Testing/TestMAkeIcon.cxx : complete the test
678 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
679 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memory leaks
681 Fri Feb 11 16:22:18 2005 by jpr
683 Typo, comments, doxygenation
685 Thu Feb 10 11:55:26 2005 by jpr
687 AnonymizeNoLoad improvement
689 Thu Feb 10 10:07:19 2005 by jpr
691 Duplicate Matthieu's hack to prevent bombing in Anonymize
693 Thu Feb 10 12:20:34 2005by jpr
695 The following gdcm::DocEntrySet methods, no re-definable is child classes are no
697 virtual ValEntry *GetValEntry(uint16_t group, uint16_t elem);
698 virtual BinEntry *GetBinEntry(uint16_t group, uint16_t elem);
699 virtual SeqEntry *GetSeqEntry(uint16_t group, uint16_t elem);
700 virtual bool SetValEntry(std::string const &content,
701 virtual bool SetBinEntry(uint8_t *content, int lgth,
702 virtual bool SetValEntry(std::string const &content, ValEntry *entry);
703 virtual bool SetBinEntry(uint8_t *content, int lgth, BinEntry *entry);
704 virtual ValEntry *InsertValEntry(std::string const &value,
705 virtual BinEntry *InsertBinEntry(uint8_t *binArea, int lgth,
706 virtual SeqEntry *InsertSeqEntry(uint16_t group, uint16_t elem);
708 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
709 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
712 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
713 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
715 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
716 * Test/ : accelerate tests (it's not very significant accelerations).
717 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
719 Mon Feb 7 15:48:34 2005 by jpr
721 Add some commented out lines to prepare future version of 'Full DICOMDIR' stuff
724 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
725 * Testing/TestSequence.cxx : add test for sequences of images... test that
726 we have the same serie or the same study UID
728 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
729 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
731 * src/gdcmDict.h : remove commented code
732 * src/gdcmDocument.cxx : initialize values
733 * src/gdcmFile.cxx : bug fix when reading values
734 * gdcmPython/demo/ : change file names. Remove useless files
736 Sun Feb 6 15:31:09 2005 by jpr
738 Update comments for DicomDir stuff
740 Sun Feb 6 15:39:35 2005 by jpr
742 * Add method File::AnonymizeNoLoad, to allow anomymizing files
743 even when the pixels are not gdcm Readable
744 * Add methods File::AddAnonymizeElement and File::ClearAnonymizeList
745 to allow user to choose the elements whose value
746 he wants to white out / replace
748 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
749 * src/gdcmFile.cxx : remove the default array of initialization.
750 The static array contained pointers to non-static values (comming from
751 strings). To have coherences, when creating files, these values can't be
752 static. So, the array can't be static, too ! To simplify, the array have
753 been replaced by repeted lines to insert values in the File
755 Fri Feb 4 15:49:01 2005 by jpr
757 * Add GetFirstValEntry + GetNextValEntry, for Python users
758 * Some more Doxygenation + typo fixing
760 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
761 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
762 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
764 Thu Feb 3 18:12:46 2005 by jpr
765 gdcmPixelReadConvert.cxx
768 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
769 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
770 (Dicom Element) into the Sequence Item
772 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
773 * src/*.cxx : first parss to normalize file organisation
775 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
776 * src/gdcmDirList.[h|cxx] : add method to find a directory
777 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
779 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
780 * Finish cleaning up my JPEG mess. Should be ok now.
781 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
782 contained within the RLE* class(doh!)
784 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
785 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
786 * SerieHeader::AddFileName() creates as many Coherent Files lists
787 (same Serie UID) as it founds different Serie UID
788 amongst the files instead of discarting any file
789 that doesn't match with the first one he found.
790 * SerieHeader::OrderGdcmFileList has now one parameter :
791 the Coherent Files list the user wants to sort
792 * SerieHeader::GetFirstCoherentFileList() |
793 * SerieHeader::GetLastCoherentFileList() | allow to parse
794 the set of Coherent Files lists
795 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
796 compatibility (it returns the *first* Coherent Files list,
797 since there was only one before)
798 * Test/TestSerieHeader gets gdcmData as a default root directory
800 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
801 * Remove friend between DocEntry and File classes
802 * Remove friend between PixelReadConverter and RLEFramesInfo,
805 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
806 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
807 0002|0000. The value was incorrect.
809 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
810 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
812 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
813 * src/gdcmUtil.cxx : compilation fix on Win32
814 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
815 variable, to be easy found. Add methods to change the default UID.
816 Amelioration of the CreateUniqueUID to use the correct default UID.
817 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
820 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
821 * Test/TestVR.cxx : fix memory leaks
823 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
824 * Rewrite the base 256 to base 10 conversion, using string operation only.
825 This allows us to get rid of the problematic 64bits integer type (does not
826 always exist on target platform).
828 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
829 * Add construct and destructor to class gdcm::Debug to close the debug file
831 * Don't let uset to open twice the same file
832 * gdcm has now an official UID prefix,
833 supplied by http://www.medicalconnections.co.uk
834 1.2.826.0.1.3680043.2.1143
835 (Thx to Mathieu for providing URL)
836 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
837 to be able to perform some more tests
838 * gdcm::ContentEntry : Contructors and Destructor are now protected,
839 in order to be sure no user will try to use them.
840 (at user level, only the children classes are meaningfull)
842 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
843 * move RLEInfo & JPEGInfo from Document to File
845 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
846 * FIX : remove so many friend between classes
848 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
849 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
850 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
852 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
853 In order to avoid missbehaviour :
854 . gdcm::DocEntry is now specialized in
855 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
856 - gdcm::ContentEntry (Dicom entry with a 'content')
857 . gdcm::ContentEntry is specialized in
858 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
859 characters value, or integers)
860 - gdcm::BinEntry (Dicom entry with a non strig representable value
861 (user hasn't any longer to thing about the precedence of his dynamic_casts)
863 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
864 * Test/VTKTest*.cxx : bug fix under linux
866 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
867 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
868 use with python. Some methods are moved from Document to ElementSet or
869 DocEntrySet. The equivalent methods to ElementSet have been added to
870 SQItem and are virtual in DocEntrySet. Methods that may have the same code
871 in SQItem and ElementSet is directly placed in DocEntrySet
873 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
874 * Test/VTKTest*.cxx : remove the show variable in each test method because
875 it's useless (the viewer variable replace this variable)
877 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
878 * src/gdcmDocument.cxx : bug fix on potential memory leak
879 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
880 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
881 Add ClearXxx methods to remove all the content of the list or map
882 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
884 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
885 * methods ReplaceOrCreate renamed as Insert
886 (nobody will be any longer confused by 'CreateOrReplace')
888 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
889 * Grealty simplify the JPEg decompression, no need to differenciate based on
890 the JPEG possible type (with/without fragment, with/without multiple frame).
891 Everything is done throught the JPEG IO Suspension mechanism in IJG
893 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
894 * Stage 3 of normalization :
895 in order to avoid any missunderstanding while reading method names :
896 - All the methods xxxEntry now deal with dicom Entries
897 - Methods GetEntry splitted into
900 - Method SetEntry renamed as SetEntryValue
901 - Method SetEntryBinArea let as it was
903 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
904 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
905 - Position correctly the entry points for JPEG2000 and JPEG-LS
906 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
908 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
909 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
910 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
911 with other method names
912 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
913 * Test/TestDicomDirElement.cxx : add new test
915 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
916 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
917 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
918 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
919 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
920 So can't you use __int64 in ostream at all.
922 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
923 * bug fix for compilation on MSVC6
924 * gdcmPython/gdcm.i : rename of classes missed
926 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
927 * Stage 2 of names normalization :
928 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
929 (easy to understand ...)
930 - gdcm::FileHelper replaces old class gdcm::File
932 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
933 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
934 type and not a string. So, there remove problems on the format of the
937 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
938 * Add Example/TestPapyrus.cxx
939 - reads a Papyrus file (gdcm::Header compliant),
940 - gets the pixels of all the images, using low level iterators
941 - writes an multiframes Dicom image.
942 (Just to show it's *possible* to do that)
943 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
946 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
947 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
948 Thus, DicomDirXXX are created with a flad that indicates if the created
949 object is empty or not (when not empty, the DicomDirElement is used to
952 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
953 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
954 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
956 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
957 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
959 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
960 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
961 Remove all access to the hash-tables or lists in the objects.
963 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
964 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
965 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
966 be complient with all the gdcm source code
968 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
969 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
972 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
973 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
976 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
977 * Test/ : rename VTK tests to have a best name for the tests
978 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
979 GetFirstEntry/GetNextEntry use
981 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
982 * In SerieHeader::ImagePositionPatientOrdering()
983 // a Dicom 'Serie' may contain scout views
984 // and images may have differents directions.
985 // -> More than one may have the same 'pos'
986 // Sorting has then NO meaning !
987 Thx to Eduardo Davila for reporting bug.
989 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
990 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
991 test. Now it's on image content and not on the resulting visualisation...
992 might solve the problem on linux when using the OpenGL drivers
994 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
995 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
996 DicomDirSerie, DicomDirImage
997 Dict, DictSet classes :
998 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
999 -remove InitTraversal method.
1000 * UPD Test programs + Example programs
1002 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1003 * remove useless and never updated keyword \ingroup
1004 * Solve pb when structure (list, map, ...) is empty.
1005 Thx to Benoit for reporting bug
1007 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1008 * Taking into account of 'Transfer Syntax' value
1009 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
1012 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1013 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
1014 is no memory access violation
1015 * gdcmPython/demo : add python demos using VTK
1017 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1018 * FIX 'Dictionnary' is now spelt 'Dictionary'
1019 'wether' is now spelt 'whether'
1020 'archieve' is now spelt 'archive' ;-)
1022 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1023 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
1024 related methods, in order not to expose internal mechanisms
1027 * REM methods that exposed internal mechanisms :
1028 DicomDir::GetDicomDirPatients()
1029 DicomDirPatient::GetDicomDirStudies()
1030 DicomDirStudy::GetDicomDirSeries()
1031 DicomDirSerie::GetDicomDirImages()
1032 * UPD Test programs :
1036 * UPD Example program
1038 * ADD DictSet methods
1042 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1043 * Removed the Print/indent/default parameter mess. There is absolutely no
1044 reason to have to methods, moreover with the second taking the ostream as
1045 *SECOND* parameter. This was clearly a bad hack to get things compile.
1047 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1048 * Complete rewrite of the GetMacAddress code. Now the code is *much*
1049 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
1050 Unfortunately the main code does not work on SunOS, thus provide a specific
1051 code for this platform only (and Win32 of course). Since this seems to be
1052 working, change CreateUniqueUID to use GetMACAddress instead of the
1053 problematic GctestetIPAddress
1055 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1056 * Unfortunately to be able to test gdcmDirList I had to break the API
1057 a little. Now the class is not a std::list anymore but has a member
1058 std::vector (more ITK compatible). Allow unit testing on Win32 and
1061 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1062 * Update SerieHeader to take into account a Serie Instance UID to properly
1065 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1066 * ENH - Comment out Mathieu's (dangerous) Super Hack
1067 for dealing with BIGENDIAN processors
1068 - Move equivalent stuff to BinEntry::WriteContent
1069 When necessary, 16 Bits Pixels are swapped in a small buffer
1070 and then written. This avoid allocating a huge buffer, in
1071 PixelWriteConvertor, and avoid modifying the Pixel Area.
1073 Probabely, the same operation will have to be done when we want
1074 to write image with Big Endian Transfert Syntax,
1075 and we are working on Little Endian Processor
1077 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1078 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
1080 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
1081 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
1082 all the dict content.
1083 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
1085 * Test/TestDict.cxx : add a new test for the dict classes
1087 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1088 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
1089 file. Debug is yanked if compiled with NDEBUG
1091 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1092 * src/gdcmDictSet.h : set the default output to the os variable
1093 * src/gdcmDictEntry.[h|cxx] : add the Print method
1094 * gdcmPython/demo/ : add a new test
1096 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1097 * merging of Test/PrintDicomDir and Test/TestDicomDir
1098 * removal of now redundant Test/PrintDicomDir
1099 * enhancement of Example/PrintDicomDir
1101 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1102 * Now, python test might work on systems
1103 * Add the PrintDicomDir test
1105 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1106 * FIX : First entry following group 0002 was lost for
1107 Explicit Big Endian Transfer Syntax files
1108 (group and elem not swaped)
1110 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1111 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
1112 Big Endian Transfer Syntax supposed the group following 0002
1113 begins always by element 0000 (element 0000 is *optional*)
1114 To avoid further troubles, let's be pessimistic, and use
1115 Document::HandleOutOfGroup0002() method
1116 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
1117 (related pb not yet solved)
1119 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1120 * Bug fix for the python part use
1121 * Now, PrintHeader.py pass... but outside the ctest use. shit !
1123 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1124 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
1126 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1127 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
1128 a string and should ask the global TS dict what are the propreties of
1131 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1132 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
1133 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
1134 to swap the Swap Code, at parsing time, when we come out of group 0002
1135 and Transfer Syntax is Big Endian
1136 We should be able to read now 'true DICOM" Big Endian coded images
1137 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
1138 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
1140 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1141 * Hopefully fix the bug on MacOSX and static global initialization.
1142 This is the only -minor- patch I found that both please MacOSX and VS6.
1143 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
1144 but this would require a lot of change. Another approach would be that Global
1145 create those string and GDCM_UNFOUND becomes a pointer to a string (which
1146 gdcm::Global would destroy at exit).
1148 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1149 * Fix bug on MacOSX with static initialization in a multy threaded
1150 environment. static const string in a header file used to be ill
1151 initialized provoquing the freeze of any tests. patch should solve this
1154 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1155 * According to Benoit's suggestion, and without any objection from anybody
1156 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
1157 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
1158 - method gdcmDicomDirObject::GetEntry() renamed as
1159 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
1161 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1162 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
1163 you debug/warning message just as c++ streams which make them very convinient
1164 to use. Once this is stabilize I will change the ostringstrem to be
1165 redirected to a file (ofstream).
1166 * Properly support C99 extension: __FUNCTION__ which allow us to display
1167 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
1169 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1170 * Removal of useless and dangerous methods :
1171 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
1172 GetDocEntryByName, GetEntryByName, GetDictEntryByName
1173 * Removal of usless methods :
1174 Dict::PrintByName, Dict::GetDictEntryByName
1175 * Commenting out of probabely useless methods :
1176 Dict::GetDictEntryNames()
1177 Dict::GetDictEntryNamesByCategory()
1178 DictSet::GetPubDictEntryNames()
1179 DictSet::GetPubDictEntryNamesByCategory()
1180 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
1181 * ENH : Use dicomTS.dic as described in 2004 version
1182 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
1183 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
1184 Add Accessors on VM (Value Multiplicity), and VM related methods
1185 * ADD : Add a list of 'Dicom Attribute types', as found in
1186 http://medical.nema.org/dicom/2004/04_15PU.PDF
1188 * ADD : Add dicomGroupNameAbbreviations.dic
1189 should be used to write a method to replace the former
1190 Dict::GetDictEntryNamesByCategory()
1192 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1193 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
1194 to read in the file... and only it ! Length is the efective length of the
1195 data in the DocEntry structure
1197 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1198 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
1199 And now use a static function call instead, with a global variable. i
1200 This is much closer to the VTK approach. Hopefully should be bulletproof
1201 and easier to use...hopefully
1203 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1204 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
1206 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1207 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
1209 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1210 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
1211 ValEntry, BinEntry, SeqEntry creation or replace
1213 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1214 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
1215 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
1217 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
1218 when specifying the VR
1219 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
1220 * src/gdcmDocEntry.cxx : amelioration of print
1222 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1223 * ADD : Add the method Util::IsCurrentProcessorBigEndian
1224 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
1225 * ADD Method Document::ComputeGroupLength
1226 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
1227 in order to allow further VR modification by user
1228 * REM : removal of once-called method File::WriteBase
1229 integration of its code in formerly one-line method File::Write
1231 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1232 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
1233 replace the different values "??", "Unkn", "Unknown".
1234 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
1235 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
1236 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
1237 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
1239 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1240 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
1242 * Set the gdcm::Base class to some Printable classes
1244 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1245 * src/gdcmFile.[h|cxx] : add the Print method
1246 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
1247 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
1248 * src/gdcmDocument.h : remove the PrintLevel informations
1249 * Example/PrintFile.cxx : use the new gdcm::File::Print
1251 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1252 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
1253 problems when compiling with the python wrapping
1255 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1256 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
1257 writting in ImplicitVR
1259 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
1260 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
1261 JPEG decompression, especially when dicom frames are split into several
1262 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
1263 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
1265 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1266 * src/gdcmHeader.cxx : change the initialisation of default header.
1267 Now, this header is readable by gdm, e-film, DicomWorks
1269 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1270 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
1271 Rename Decompressed to Raw
1272 * Use the API changes in gdcm::File.
1273 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
1276 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1277 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
1278 each added entry in the header. Replace the 'Planes' field by the 'Number
1281 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1282 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
1283 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
1285 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1286 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
1287 At this time, this image isn't readable by e-film... waiting JPR help to
1290 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1291 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
1292 DocEntry. Now use methods of the Document !
1294 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1295 * Test/ShowDicomSeq.cxx : bug fix
1297 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1298 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
1299 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
1300 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
1301 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
1303 * Test/TestCopyRescaleDicom.cxx : remove unused variable
1304 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
1305 containing found sequences
1307 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1308 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
1310 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
1311 Some fields in BinEntry must be copied to not seg fault when making the :
1312 gdcm::File *copy = new gdcm::File( copyH );
1313 and tests are now made on good variables
1315 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1316 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
1317 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
1319 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
1320 * Add vtkGdcmWriter example and test
1322 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1323 * Test/TestUtil.cxx : reformat the source code
1324 * vtk/vtkGdcmReader.cxx : remove and change prints
1325 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
1327 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
1328 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
1330 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1331 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
1332 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
1334 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1335 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
1336 by an eof to prevent all bad read of the file... and in this case, the
1337 file isn't readable.
1339 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1340 * Example/Volume2Dicom.cxx : comment unused variables
1341 * Test/PrintDicomDir.cxx : comment unused variables
1342 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
1343 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
1344 method that is redondant with AddEntry.
1345 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
1348 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1349 * Bug fix due my last commit (compilation under Windows).
1350 * Example/Volume2Dicom : bug fix in the file and reformatting source code
1351 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
1353 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1355 - Remove printf / sprintf
1356 - include iostream AFTER gdcm so we don't get warnings
1357 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
1359 - Also remove tons of include from header files, hopefully this should
1360 speeup the compilation time, since it was becoming a dog slow.
1361 - Remove gdcm.h as it include way too many files and slow down compilation
1362 (plus it is not up to date)
1363 - remove 'using namespace std' this is BAD !
1365 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1366 * Remove memory leaks on the DicomDir
1367 * Remove some useless data in DicomDirObject
1368 * Add usefull methods in SQItem, to be complient withe the ElementSet
1370 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1371 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
1373 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1374 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
1375 future, with convertion)
1376 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
1377 and ImageDataSize values. Remove the method to get the PixelReadConverter
1378 from the output of the class
1380 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1381 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
1383 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1384 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
1385 and vtkErrorMacro use.
1386 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
1388 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1389 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
1391 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
1392 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
1393 The string leaves only in the fonction. So when we make a .c_str(), we
1394 get the pointeur on the first element, element that will be destroyed
1395 immediately after thee instruction.
1396 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
1397 file has been opened : the test must be made on the content of the
1398 pointer and not directly on the pointer !
1401 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1402 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
1403 the python part recompiles
1405 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1406 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
1407 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
1408 X session is killed (for my computer... it seems to not be identic on
1411 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1412 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
1413 avoid problems (otherwise, the difference test between the visible image
1414 and the reference is incorrect. If the reference is greater than the
1415 screen resolution, it's produce errors).
1416 Can be used for only one image. Can be used with a visible flag.
1417 * vtk/vtkGdcmReader.cxx : remove commented codes.
1418 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
1419 under windows at compilation
1420 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
1421 for grayscale images
1422 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
1424 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1425 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
1426 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
1427 tests on the image size X, Y, Z
1429 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1430 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
1431 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
1432 between the class name and the file name
1434 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1435 * src/ : fix compilation warnings for the Write method (2 different
1436 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
1437 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
1438 variable... create a static method in gdcm::Document to access to
1439 this variable content.
1441 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1442 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
1443 file, to be accessed by other files (like gdcmFile). Remove commented
1444 code. Move the change of the header to the gdcmFile, using the
1446 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
1447 To be sure of that (and simplify calls), the Write of the header now
1448 gets a file name and not a file pointer (std::ifstream).
1449 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
1450 DocEntryArchive. Remove all open of the written file
1452 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1453 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
1455 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1456 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
1457 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
1459 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
1460 some corresponding methods. Write correctly the file and check before
1462 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
1463 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
1464 is now on RGB data (as before my last commit
1465 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
1467 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1468 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
1469 Add a print information of the type of the entry
1470 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
1471 It was in the gdcmFile, and all write have been regrouped
1472 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
1473 Write correctly all dicom files (in decompressed mode only at this time)
1474 * Test/ : test on files are now made using Raw data and not color data if
1476 * Example/PrintFile.cxx : add more printings
1478 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1479 * Amelioration of code, remove some code copy. For the loading of
1480 BinEntry (in gdcmDocument), add the test to verify if the file is already
1483 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1484 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
1485 remove a DocEntry in the header (push an empty DocEntry)
1486 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
1487 lines. Bug fix in the initialization of the PixelConvert and the
1489 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
1490 use in TestCopyDicom (now this test can run under windows... but fails)
1491 * Test/TestCopyDicom.cxx : amelioration of the test :
1492 - test the pixels written
1493 - add test points to quickly find where is the error
1494 - can set a file name input and output in arguments
1495 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
1496 amelioration of the test output
1498 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1499 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
1500 all replaced DocEntry's
1501 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
1502 Now, each needed DocEntry to modify is duplicated, modified and inserted
1503 to the header using DocEntryArchive. Thus, after save, we can restore the
1504 header initial state.
1506 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1507 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
1509 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1510 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
1511 correct to copy it. The DictEntry is specified at the DocEntry creation,
1512 then, it musn't change in the time.
1513 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
1514 header correctly. At this time, the change is only made for the first
1515 level of the Document. In the future, it might consider sequences.
1516 The change is made by replacing a DocEntry by an other that is created
1517 outside the class. The old value is kept. When we restore the header
1518 status, the added DocEntry is deleted and replaced by the old value.
1519 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
1520 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
1521 set the write type to explicit VR, implicit VR or ACR. Add methods to set
1522 the write mode to native, decompressed or RGB (but not used at this time)
1524 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1525 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
1526 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
1528 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1529 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
1530 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
1532 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
1533 set because already copied when copying the BinEntry's of the header
1534 * Test/TestAllReadCompareDicom.cxx : remove warnings
1536 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1537 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
1538 Two problems appear when doing it :
1539 - with the gdcmFile : when the GetImageData method is called, the pixels
1540 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
1541 data (pixels). And each structure destruct the data when it's
1542 destructed. So we have two destructions for the same data. To solve it,
1543 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
1544 data or not. If it doesn't own data, then they will not destroyed by
1546 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
1547 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
1548 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
1549 create a double destruction of the same DocEntry's. So, to solve it,
1550 the TagHT is simply cleared and the DicomDir* elements are destroyed.
1551 * TODO : add an entry concerning memory leaks in the DicomDir
1553 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1554 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
1555 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
1558 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1559 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
1560 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
1561 after it have been deleted
1563 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1564 * FIX: src/* fix the doxygen warnings.
1565 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
1566 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
1567 was erroneously defined with a size of 15 instead of 16. [many thanks
1568 to Jean Michel Rouet for pointing out this bug].
1570 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1571 1. Finish merging JMR patch for writting DICOM from scratch
1572 2. Fix -hopefully- bug with MONOCHROME and space vs null character
1573 3. Use const ref when possible
1574 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
1575 5. A few more comments
1576 6. CreateUniqueUID can now be called without parameter"
1578 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1579 * ENH: Slightly bigger patch:
1580 1. Getting toward full integration of JMR patch for writting dicom from scratch
1581 2. Update Test to test part of this patch: CreateUniqueUID
1582 3. File was not close properly in gdcmDict
1583 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
1584 5. Use of const ref instead of copy (speed issue)
1585 6. Remove temporary (duplicate) string in TranslateToKey
1586 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
1587 8. Do not repeat virtual in subclasses
1588 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
1590 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1591 * Apply first patch toward better string comparison when dealing with broken
1592 DICOM files. Essentially the string could be padded with a space instead
1593 of a null character as defined by standard
1595 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1596 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
1597 because never used... and in the same time, that's remove some memory leaks
1599 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1600 * src/gdcmFile.cxx : now delete the PixelConvert instance.
1601 * In examples and tests : change the type of image data variables from void*
1602 to uint8_t*. Remmove all delete on image data variables
1604 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1605 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
1606 Verify the file pointer value before open the file, and if it's not null,
1607 a verbose message is generated.
1608 Close correctly the file when the file isn't considered dicom-like. The
1609 correctly close is a call to CloseFile.
1610 When closing the file pointer, test if its not null to close the file.
1611 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
1612 file. For an uncompressed image, the copied data correspond in the least
1613 case to the image size (calculated) or the image size specified in the
1614 header. A verbose is generated if these two size mismatch
1616 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1617 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
1618 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
1619 break under windows (with msvc6 compilation).
1621 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1622 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
1623 compiling with MSVC6)
1625 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1626 * Bugs fix for the Windows build with VC6
1627 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
1628 needed (only for projects required VTK). If the VTK is included in all
1629 projects, there is conflicts with the jpeg lib of vtk when compiling the
1630 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
1631 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
1632 when compiling the gdcm_wrap.cxx file (created by the compilation of the
1634 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
1635 (like it's already made for the cout use). Otherwise, conflict with the
1638 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1639 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
1640 * gdcmPython/gdcm.i:
1641 - comments on the DicomDir::Method related usage added.
1642 - now that we use the namespace gdcm, a lot of internal classes do
1643 NOT need to be wrapped anymore.
1644 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
1645 DicomDir::Method) new example added.
1647 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1648 * Improve string manipulation. I now inforce the notion of 'DicomString'
1649 A DicomString can contain as many \0 as they want
1650 and it is *always* of even length.
1651 We only support odd length for very rare case.
1652 And in the near future this should be removed.
1654 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1655 * /binary_write/ gdcm source. Now even on big endian we are writting
1656 little endian. This should -heopfully- fix some tests
1658 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1659 * Now the dictionary is compiled into gdcm lib. This is a default
1660 behavior, thus any dic file specified is picked before failback to
1661 the one comiled into lib
1663 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1664 * Change internals for gdcmDict. Don't use any 'new' any more.
1665 This should definitely solve any leak problem, and we should be
1666 as fast as before, as long as don't modify too much the dictionary.
1668 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1669 * STYLE: ivars should start with a capital letter.
1670 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
1671 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
1673 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1674 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1675 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1676 new 2004 dictionaries added (thanks to JPR).
1677 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1678 * CLEANUP_ROUND (15) for gdcmPixelConvert
1679 - RLEFrame::NumberFragments is now of type unsigned int
1680 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1681 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1684 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1685 * Initial work in gathering all transfer syntax accessors. clearly
1686 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1687 ivars, but only one transfersyntax (class) ivar with equivalent method on
1690 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1691 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1692 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1693 discussed (plus I didn't like having a 2000 lines patch not commited)
1695 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1696 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1697 * CLEANUP_ROUND (14) for gdcmPixelConvert
1698 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1699 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1700 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1701 CloseFile() anymore.
1702 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1703 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1704 into File::Pixel_Data.
1706 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1707 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1708 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1709 * CLEANUP_ROUND (13) for gdcmPixelConvert
1710 Substituted File::ParsePixelData() with PixelConvert::Print() new
1712 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1713 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1714 method to those classes.
1715 - src/gdcmFile.[cxx|h]:
1716 -- Added a ::Print() method.
1717 -- PixelConverter is now a reference instead of a member.
1718 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1719 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1721 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1722 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1723 collaboration diagram and inheritance diagram should be generated with
1725 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1726 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1727 pointlessly wrapped (see
1728 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1729 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1730 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1731 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1732 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1733 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1734 -- File::Initialise: PixelConverter setup moved away to
1735 PixelConverter::GrabInformationsFromHeader()
1736 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1737 interpretation moved away to PixelConverter::BuildRGBImage()
1739 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1740 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1741 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1743 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1744 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1745 displayed on Win32 when a brutal abort() occurs (because of uncatched
1746 exception). See TODO new entry of this commit for more on this.
1747 * TODO added new entry.
1748 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1749 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1750 - HandleColor is no longer called from gdcmFile.cxx
1751 - gdcmPixelConvert.cxx clean up on method arguments and internal
1752 variable names for semantical coherence.
1754 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1755 * Finished lossless transition, not only do we now read all lossless jpeg
1756 images, without the need of the Cornwell lib, but we do read them properly now
1757 * To reduce code (well to avoid code duplication), I defined a common place
1758 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1759 redefine symbols. This is not perfect but this the best solution I found for a
1760 compilation time jpeg option.
1762 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1763 * Update jpeg ijg lib to support lossless jpeg implementation
1764 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1766 * Also added a special copyright for dcmtk since we use their bugfixes.
1769 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1770 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1771 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1772 matters, as stated in warning note at beginning of %include section).
1773 * src/gdcmDicomDir*.[cxx|h]: coding style
1774 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1775 * src/gdcmJpeg8.cxx: doxygen fix.
1776 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1777 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1778 from File:: to PixelConvert::.
1780 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1781 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1782 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1783 - more code moved away from File:: to PixelConvert::
1784 - fat setup of PixelConverter set in place in File::Initialise.
1786 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1787 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1788 namespace at the file system level. So now you should convert your examples
1790 gdcmHeader -> gdcm::Header
1791 It would be nice if people keep in mind to no open the namespace, since it
1792 allows compilation on broken plateform which were defining common symbol in
1793 the standard namespace (like LP, Unknown ...)
1795 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1796 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1797 The JPEG fragments are now parsed at the same stage than the RLE
1798 information. All code related to JPEG is now in gdcmPixelConvert:
1799 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1800 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1801 export a gdcmFile:: method. Those are simply global functions
1802 (for the time being this is better than having them attach to
1803 either gdcmFile:: or gdcmPixelConvert::).
1804 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1805 and stores the result in a gdcmJPEGFragmentsInfo.
1806 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1807 code (among other stuff) moved away from gdcmFile:; to
1810 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1811 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1812 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1813 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1814 clean up of RLE related code.
1815 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1816 - src/gdcmRLE.cxx removed
1817 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1818 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1819 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1820 * CLEANUP_ROUND (9) for gdcmPixelConvert
1821 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1822 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1823 away from gdcmFile:: to gdcmPixelConvert::.
1825 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1826 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1827 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1828 This is because Parse7Fe0 used to parse the pixels to compute the
1829 length. This task was passed over to FindDocEntryLengthOB() a long
1830 time ago, EXCEPT I forgot the OW case...
1831 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1832 we just recylce the code for parsing RLE fragments and computing
1834 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1835 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1836 with the retired Parse7Fe0().
1837 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1838 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1840 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1841 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1842 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1843 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1844 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1845 * CLEANUP_ROUND (4) for gdcmPixelConvert
1846 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1847 to return an unused length.
1849 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1850 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1851 this should be cleanner from the plane view. The iostream are erally a pain
1852 to use to do simple stuff.
1854 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1855 * Redo the compilation of the ijg jpeg library. Now only one source is
1856 necesseray. No need to rename file by hand what so ever. CMake handle the
1857 copying of the file within different directory, configure header file to
1858 modify some symbol. The only addition made to ijg wasd a mangle table so
1859 that symbol are different whether we are within 8bits or 12bits.
1861 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1862 * Added documentation of vtkgdcmReader on Website:
1863 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1864 with it's binary name).
1865 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1866 the Website to be more complete.
1867 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1868 doxygenated documentation.
1869 - Doc/DoxyVtkGdcmReaderExamples.txt added
1870 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1871 DoxyVtkGdmReaderExamples.html )
1872 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1873 * CLEANUP_ROUND (3) for gdcmPixelConvert
1874 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1876 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1877 * CLEANUP_ROUND (2) for gdcmPixelConvert
1878 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1880 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1881 * CLEANUP_ROUND for gdcmPixelConvert:
1882 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1883 - src/gdcmPixelStuff[h|cxx] removed
1884 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1885 - src/CMakeLists.txt changed accordingly
1886 * GDCMHOME clean up:
1887 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1888 gdcmVersion.py moved to newly created ATTIC related
1889 gdcmPython/SetupOldies/ directory.
1890 * Autotools clean up:
1891 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1892 - autogen.sh configure.in acinclude.m4 python.m4 removed
1894 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1895 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1896 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1897 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1899 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1900 * TODO updated with Mathieu suggestions. I proposed a template for
1901 describing TODO entries and used it for new entries.
1902 * Added Doc/Website/CodingStyle.html, Developpers.html,
1903 DeveloppersPython.html, GdcmDataCvs.html and
1904 DownloadVersion0_1.html, DownloadVersion0_3.html.
1905 * Some Doc/*.txt Doxygen files (which do not really concern the
1906 documentation itself, but the website) moved to html and
1907 placed in directory Doc/Website:
1908 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1909 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1910 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1911 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1912 * CMakeLists.txt changed accordingly.
1913 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1914 DeveloppersPython.html
1915 * INSTALL nows refers to Doc/Website/Installation.html
1917 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1918 * Added Doc/Website directory, that contains a first raw version
1921 2004-09-23 Jean-Pierre Roux
1922 * FIX In order not to be poluted any longer by casting problems,
1923 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1924 we can now delete[] it safely
1925 * VoidArea is now called BinArea (less confusing name),
1926 and all the methods called ...VoidArea... are now ... BinArea...
1927 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1929 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1930 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1931 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1932 up to the destructor of gdcmElementSet to clean up TagHt and it's
1935 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1936 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1937 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1939 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1940 * ENH: added some utility method that builds a flat dictionary
1941 holding all the Dicom entries contained in the recursive structure
1942 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1943 an example of usage.
1944 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1945 BuildFlatHashTable() that build a flat dictionary.
1946 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1947 gdcmDocument is now a friend of gdcmElementSet.
1948 - src/gdcmElementSet.cxx: clean up.
1949 - Example/FlatHashTablePrint.cxx added.
1950 - Example/CmakeLists.txt changed accordingly
1952 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1953 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1954 moved away from gdcmDocEntrySet (since this class is an abstract class
1955 acting like an interface). SQDepthLevel and BaseTagKey are now
1957 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1958 and associated accessors. Doxygenation of the class.
1959 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1961 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1962 Use SQDepthLevel accessor instead. ::Print() adapted.
1963 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1964 - src/gdcmDocument.cxx changed accordingly.
1966 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1967 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1968 - The following is the doxygen comment of the typedef declaration
1969 of gdcmTagKey in src/gdcmCommon.h:
1970 gdcmTagKey is made to old an "universal" (as in URL, Universal
1971 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1972 A dicom tag always has a group and an element, but a set of tags
1973 embeded in various (optionally nested) sequences and sharing
1974 the same group and element all share the same (group, element)
1975 "identifier". Hence the (group, element) cannot be used as an
1976 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1977 In order to construct a proper tag identifier (i.e. a key) we
1978 consider the following definition of a TagKey:
1979 - let Group, Element be the string representation of the
1980 group and element dicom tag members,
1981 - let ItemNumber be the string representation of the integer
1982 index of the considered item number of a sequence,
1983 Let the key of a tag embeded in a sequence, noted SeqTag, be
1985 /ItemNumber#Group|Element
1986 where "/", "#" and "|" are characters acting as separators.
1987 Then the general form of a gdcmTagKey is given by:
1988 Group|Element<SeqTag>
1989 where <SeqTag> means NO or many instances of SeqTag.
1990 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1993 but the gdcmTagKey of a tag "embeded" is the first item of
1994 a sequence, itself nested in the third item of a sequence is the
1996 0004|1220/2#0008|0082/0#0008|0090
1997 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1998 order to hold the new sequence compatible key. Previously, the
1999 GetKey() method would look in the underlying gdcmDictEntry.
2000 - src/gdcmDocEntry.cxx:
2001 -- constructor now copies the underlying DictEntry key, in the local
2003 -- ::Print: displays the member Key, instead of the (group, element).
2004 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
2005 - src/gdcmDocEntrySet.h:xi
2006 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
2007 -- now has a new BaseTagKey member.
2009 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
2010 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
2012 This poses the problem with the semantics of the following lines
2013 LoadEntryVoidArea(0x0028,0x1201); // R LUT
2014 LoadEntryVoidArea(0x0028,0x1202); // G LUT
2015 LoadEntryVoidArea(0x0028,0x1203); // B LUT
2016 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
2017 to the long FIXME note for what the problem is. Nevertheless in
2018 order to get things working the dicom dictionary was altered !
2019 Please fix things urgently...
2020 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
2021 information), see above note on moving the member VoidArea. Nevertheless
2022 the following entries previously correctly set as US are now inproperly
2024 0028 1201 OW IMG Red Palette Color Lookup Table Data
2025 0028 1202 OW IMG Green Palette Color Lookup Table Data
2026 0028 1203 OW IMG Blue Palette Color Lookup Table Data
2027 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
2028 of gdcmDocEntry moved to gdcmSeqEntry.
2029 * src/gdcmSeqEntry.cxx: STYLE.
2031 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2032 * Test/TestAllEntryVerify.cxx minor fix and added comments.
2034 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2035 * gdcmPython/testSuite.py: all the test suite in python is now moved
2036 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
2037 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
2038 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
2040 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2041 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
2042 to avoid inclusion recursion until STL is reached.
2043 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
2044 mecanism. errno.h is not included in gdcm anymore.
2045 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
2046 (gdcmFormatError now inherits from gdcmFormatUnexpected).
2048 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
2049 gdcmData/TestAllEntryVerifyReference.txt
2050 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
2051 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
2052 exception_on_error parameter.
2053 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
2054 - vtk/vtkGdcmReader.cxx changed accordingly,
2055 - Example/*.cxx and Test/*.cxx changed accordingly.
2057 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2058 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
2059 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
2060 enable_sequences removed from gdcmHeader constructor and dependencies.
2061 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
2062 * gdcmPython/demo/PrintHeader.py: dummy fix.
2063 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
2064 skip_shadow removed from gdcmHeader constructor and dependencies.
2065 * Example/*.cxx and Test/*.cxx changed accordingly.
2067 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2068 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
2069 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
2071 2004-07-21 Jean-Pierre Roux
2072 * FIX Now, Parsing and Printing a DICOMDIR do work!
2073 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
2075 2004-07-20 Jean-Pierre Roux
2076 * FIX Some brain damaged headers have Zero-Lenght fields
2077 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
2079 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2080 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
2081 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
2082 variable (instance of gdcmDebug) by a definition macro, and the instance
2083 is now in static in the gdcmDebug class
2084 * src/gdcmSQItem.h : (FIXME) remove an undefined method
2085 * Test/PrintAllDocument.cxx : bug fix in the result of the test
2087 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2088 * WARNING: ctest now depends more tightly on gdcmData. You should
2089 check out gdcmData properly for things to run smoothly...
2090 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
2091 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
2092 we need the pixels not be loaded in order to use the ValEntry
2093 that displays position and size).
2094 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
2095 This is a C++ based equivalent of gdcmPython/testSuite.py that should
2096 be deprecated. If you have any doubts about the advantages of a
2097 modern scripting language (read Python) versus grass root C++ (i.e.
2098 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
2099 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
2100 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
2101 Anyhow, consider documenting the gdcmData images in
2102 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
2104 * Test/CMakeLists.txt:
2105 - now uses TestAllEntryVerify.cxx
2106 - specific comments on oldACR00001.ima (now renamed in gdcmData
2107 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
2108 gdcmData/TestAllEntryVerifyReference.txt
2111 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2112 * src/*.[h|cxx] : typedef clean up
2113 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
2114 - TagKey renamed to gdcmTagKey (for external usage)
2115 - VRKey renamed to gdcmVRKey (for external usage)
2116 - removal of typedef duplication.
2117 - Removed all unecessary inline keyword from class inline definitions.
2118 - Some method|function(void) declarations replaced with method|function().
2119 * src/jpeg/libijg12/jdhuff12.c:
2120 - printf polluting ctest removed.
2121 - TAB removal for comminting
2123 - TestAllReadCompareDicom.cxx: added a test that compares all the
2124 images in gdcmDataImages.h with corresponding images in
2125 gdcmData/BaselineDicom/. When baseline images are not present
2126 this test creates them.
2127 Note: we need to validate each reference image, but before that
2128 I'd like to rename them with a more explicit name...
2129 - CMakeLists.txt: changed accordingly.
2130 * Example/*.cxx: examples now only include gdcm.h (as opposed to
2131 including each header needed).
2133 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2134 * Test/*.cxx and Example/*.cxx: moved some examples away from the
2135 test suite to the Example directory. Are concerned:
2140 - TestWriteSimple.cxx
2141 * Test/CMakeLists.txt: added some comments on reasons for black listing
2142 image gdcmData/oldACR00001.ima
2144 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2145 * Test/CmakeList.txt: removed the following from black list (to be coherent
2146 with removal from gdcmData):
2147 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
2148 - gdcm-MR-PHILIPS-16.dcm
2150 Added the following because after last cvs update, they cause
2151 ctest -R TestReadWriteReadCompare
2153 - gdcm-MR-SIEMENS-16-1.acr
2155 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
2156 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
2157 new comments in this file) we temporarily (sigh) move to a weaker
2159 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
2160 we don't need to black list the following images anymore:
2161 - 8BitsUncompressedColor.dcm
2163 - US-PAL-8-10x-echo.dcm
2164 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
2165 fixes and the beautified code ;-)
2166 This fixes the bug introduced in version 1.42 (when beautifying)
2167 that made the parsing of 8BitsRunLengthColor.dcm unproper.
2168 Note: ctest was blind to this bug (this means we need to still
2169 improve the test suite). The bug could be detected by using
2170 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
2172 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
2173 and by displaying the (garbage) produced file temp.XDCM...
2175 2004-06-29 Jean-Pierre Roux
2176 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
2177 - replace by uggly but working old code :-(
2178 A lot of things should be OK again.
2179 It's really urgent to have a test suite that *tests*,
2180 to prevent Frog's beautifying sessions to break all the stuff
2181 (twice, withing a fortnigh ...)
2183 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2184 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
2185 redundancy) to added Test/TestReadWriteReadCompare.cxx
2186 * Test/CmakeList.txt: because the compare test of
2187 Test/TestReadWriteReadCompare.cxx fails, the following images are
2188 black listed: - 8BitsUncompressedColor.dcm
2190 - US-PAL-8-10x-echo.dcm
2191 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
2192 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
2193 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
2194 and ad-hoc kludge. This kludge is now removed, and on encountering
2195 such an image (OB field brain damaged) we set errno. Then in
2196 ::FindDocLength() we "fix" the length as being ALL what remains
2197 in the file (until EOF). We then proceed, hoping for the best...
2198 This fixes a SegFault in ShowDicom when trying to write such an
2200 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
2201 (because TestWriteRead breaks on it, after a non conformal commit?).
2202 ctest now runs properly, except for MakeDicomDir (which was always
2203 broken) and the Python related stuff (still not fixed).
2205 2004-06-24 Jean-Pierre Roux
2206 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
2207 FIX : Test/TestReadWrite now iterates on all the file names
2208 (instead of infinite loop)
2209 ENH : Test/TestWriteRead now iterates on all the file names
2211 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2212 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
2214 2004-06-24 Jean-Pierre Roux
2215 FIX : - now Write drops LUT Descriptors and LUTs (if any)
2216 when SamplesPerPixel =3
2217 - now Write is no longer confused by
2218 'BitsAllocated = 12" and 'BitsStored=12"
2219 - "UN" value representation Elements are now written correctly
2220 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
2221 ENH : - now gdcmHeader has its own Write methods
2222 (in order to split the job that has not to be done
2225 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2226 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
2227 loop on the same image until memory went out.
2228 Note: this means we still have gobs of memory loss in PrintDocument
2229 * src/gdcmDocument.cxx: fixes problem on parsing on file
2230 gdcmData/16BitsJpegLosslessGrayScale.dcm.
2232 2004-06-24 Jean-Pierre Roux
2233 FIX : Write - All the Sequences and Sequence Item are now written
2234 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
2235 is added a the end, when necessary.
2236 - A lot of brain-damaged images, that were read correctly are
2237 now written correctly
2238 - length compatible BinEntry are now loaded correctly
2239 (even for odd groups)
2240 Note : only Explicit Value Representation was checked.
2241 (question : is implicit VR really necessary for gdcm ?)
2243 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2244 * DEVELOPPER: added a proposition of coding style.
2245 * src/gdcmDocEntry.h: removed every inline declaration (for test of
2248 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2249 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
2250 Use the gdcmDocEntry::Print() and Write() instead.
2251 * src/gdcmDocument.cxx: bug fix.
2253 2004-06-22 Jean-Pierre Roux
2254 FIX : gdcmDocument.cxx
2255 - Now we do recognize the JpegLossLess format (there was a misstyping in
2256 code 'beautyfication' :-(
2257 - Now we automaticaticaly load the Luts, if any
2259 2004-06-22 Jean-Pierre Roux
2260 In order : to write Sequences, whatever their imbrication level,
2261 : to allow user to create his own Sequences
2262 a lot of modif where necessary (adding, moving, or virtualising methods)
2264 WARNING : save your own sources *before* cvs up !
2267 ADD virtual void Write(FILE *fp, FileType filetype);
2270 ADD virtual void Write(FILE *fp, FileType filetype);
2271 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
2274 ADD virtual void Write (FILE *fp, FileType filetype)=0;
2275 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
2276 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
2277 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
2278 ADD std::string GetEntryByName(TagName name);
2279 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2281 std::string vr = "unkn",
2282 std::string fourth = "unkn",
2283 std::string name = "unkn");
2284 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2285 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2286 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2287 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
2288 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
2289 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2290 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
2291 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
2294 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
2295 ADD virtual std::string GetEntryByName (TagName tagName);
2296 ADD virtual std::string GetEntryVRByName (TagName tagName);
2297 REM virtual bool Write(FILE *, FileType);
2298 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
2299 FILE *_fp, FileType type);
2300 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
2301 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
2302 REM virtual bool WriteEntries(FILE *_fp,FileType type);
2303 REM virtual std::string GetEntryByName (std::string tagName);
2304 REM virtual std::string GetEntryVRByName (std::string tagName);
2305 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
2306 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2307 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2309 std::string vr = "unkn",
2310 std::string fourth = "unkn",
2311 std::string name = "unkn");
2312 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2313 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
2314 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2315 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2318 ADD virtual void Write(FILE *fp, FileType filetype);
2321 ADD virtual void Write(FILE *fp,FileType filetype);
2324 ADD virtual void Write(FILE *fp, FileType filetype);
2325 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
2326 REM std::string GetEntryByNumber(guint16 group, guint16 element);
2327 REM std::string GetEntryByName(TagName name);
2330 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
2332 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2333 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
2334 The default constructor invoked by the line
2335 gdcmHeader *f1 = new gdcmHeader( header );
2336 was gdcmHeader::gdcmHeader(bool) instead of the expected
2337 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
2338 Hence the parsing wasn't executed... See also below.
2339 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
2340 as explicit constructor didn't do the trick to fix the above problem.
2341 Could anyone explain why ?
2342 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
2343 properly calls gdcmValEntry::Print() (that was weed out from
2344 code related to gdcmBinEntry).
2346 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2347 * In order to fix memory leaks:
2348 - Test/TestWriteSimple.cxx: added cleaning of free store through
2350 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
2351 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
2352 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
2353 (through the call to ::AddDicomDirMeta()) or the destructor
2354 would crash when deleting uninitialized ::metaElems].
2355 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
2356 - src/gdcmDocument.cxx:
2357 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
2358 from dynamic stores.
2359 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
2360 was causing memory leaks.
2361 - src/gdcmSQItem.cxx:
2362 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
2363 cleanly handled with polymophism: sorry but my milage is low).
2364 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
2365 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
2366 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
2367 This avoids SegFaulting.
2368 - src/gdcmSQItem.h: coding style.
2370 - Test/TestWriteSimple still severely sucks. The output image content
2371 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
2372 damaged when displayed with vtkgdcmViewer.
2373 - on memory leaks: TestWriteSimple leaks really less (see entry
2374 of 2004-06-18 in Changelog file for the call to valgrind).
2375 - on segfaults: ctest now passes all the tests but one (no more
2377 * Erroneous leading white fix:
2378 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
2379 white[s] (as opposed to from >> xxx, that removes it [them].
2380 - src/gdcmTS.cxx: ditto.
2381 - gdcmPython/testSuite.py: dirty related kludge removed.
2382 * src/*: remaining references to gdcmParser removed.
2383 * src/*[cxx|h]: added copy[way]left header.
2386 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2387 * In order to fix writing of dicom files:
2388 - Test/TestWriteSimple.cxx: a simpler example of writing.
2389 - Test/CMakeLists.txt changed accordingly.
2390 - src/gdcmDocument.cxx:
2391 -- The destructor now recursilvely removes potential sequences.
2392 -- Bug fix in ::IsJPEG2000()
2393 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
2394 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
2396 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
2397 to only declared) and build on top of
2398 ::GetDocEntryByNumber(guint16, guint16).
2399 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
2400 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
2401 for usage in destructor and treatement of promotion in
2402 ::ReplaceOrCreateByNumber().
2403 - src/gdcmSQItem.cxx: destructor should better handle his job.
2404 Test/TestWriteSimple now runs (or at least it DOES something).
2405 * We can now start hutting memory links. A good starting point is:
2406 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
2407 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
2408 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
2410 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2411 * Valgrind note: after Mathieu Malaterre teached me how to read
2412 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
2414 Using gcc, you can force the STL to use malloc and to free memory as
2415 soon as possible by globally disabling memory caching.
2416 With 3.2.2 and later, you should export the environment variable
2417 GLIBCPP_FORCE_NEW before running your program.
2418 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
2419 simply vanish (it is still not clear to me, whether this means that
2420 STL std::string leaks or if valgrind believes it leaks...).
2421 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
2422 running bin/gdcmTests makeDicomDir):
2423 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
2424 - Test/makeDicomDir.cxx now properly traps empty lists and returns
2426 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
2427 SegFaulting (I drowned in DicomDir related code when trying to
2428 understand why the list is empty...).
2429 * src/gdcmDocument.h: first BSD license header try.
2430 * Doc/License.txt added.
2432 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2433 * src/gdcmDocument.[h|cxx]:
2434 - Clean up of the Transfer related predicates. They are now all based
2435 on new method isGivenTransferSyntax, that (should) handle properly
2436 the padding problem.
2437 - general clean up, simplification, and coding style.
2438 - Specific clean up of Parse7FE0() (umproperly named actually).
2439 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
2441 2004-06-14 Jean-Pierre Roux
2443 - fix the display of Sequence Delimitor (SQDepthLevel pb)
2444 - fix the display of SQItem ordinal number
2445 - add the GetSQItemByOrdinalNumber method
2446 - remove some useless never written private methods
2448 2004-06-14 Jean-Pierre Roux
2450 - adding a constructor taking a gdcmDocEntry as an input param
2451 - ReplaceOrCreateByNumber now returns :
2452 a gdcmBinEntry * if a Binary (void *) value is passed as a param
2453 a gdcmValEntry * if a string value is passed as a param
2455 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
2456 according to the param type (no longer sets a gdcmDocEntry)
2457 - GetValEntryByNumber, GetBinEntryByNumber added
2458 - NewValEntryByNumber and NewBinEntryByNumber added
2460 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
2462 - GetSQItemNumber and SetSQItemNumber added, to provide
2463 a (relative) Item identier inside a given Sequence
2464 \warning : some pb remaining around this number
2466 - AddEntry now takes the Item Number as a param
2468 - adding a constructor taking a gdcmDocEntry as an input param
2470 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2471 * Memory leak hunt with the following command:
2472 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2473 --show-reachable=yes gdcmTests PrintDocument
2474 It looks like many (all?) leaks are due to the STL (or a bad usage
2475 of the STL. The lines producing the leaks now have a comment with
2476 a "MEMORY LEAK" tag: you can retrieve them with
2477 grep "MEMORY LEAK" src/*
2478 Here are two typical examples which I can't help fixing:
2483 char * test = "babo";
2484 name = test; //// <--- valgrind detects 960 bytes lost in
2485 //// call to std::string::operator=(char const*)
2486 name.clear(); //// Doesn't help !
2494 std::cout << "Type a bunch of characters followed by RETURN: ";
2495 getline(std::cin, line); //// <--- valgrind dectects a loss
2496 //// of 1320 bytes in call to
2497 /// std::basic_istream<>& std::getline<>
2503 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * src/gdcmHeader.[cxx|h]:
2505 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
2506 and related, moved away to gdcmDocument.
2507 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
2508 the corresponding protected accessors of inherited class
2509 gdcmDocument, removed ! As a consequence gdcmFile had to be
2510 declared friend of class gdcmDocument (see below).
2511 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
2512 - Clean up of undefined or unused methods.
2513 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
2514 account the changes to gdcmHeader.h).
2515 * src/gdcmDocument.h:
2516 - gdcmFile is now a friend class (in order to take into account the
2517 changes to gdcmHeader.h).
2518 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
2519 (see changes to gdcmHeader.h).
2520 - Accessors (reading on the form GetEntry*) are now public.
2521 - Clean up of undefined or unused methods.
2522 * src/gdcmDocument.cxx:
2523 - adaptation to changes to gdcmDocument.h
2524 - ::OpenFile now writes a verbose message when file cannot be opened.
2525 - some std::string properly set to VRKey
2526 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
2527 references to gdcmDocument.
2528 * Test/TestFindTags.cxx: changed accordingly to above changes.
2529 * gdcmPython/testSuite.py: adapted to renaming of acr files in
2530 cvs repository gdcmData.
2532 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2533 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
2534 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
2535 conflicts with gdcmValEntry::voidArea.
2536 * src/gdcmValEntry.cxx: unmatching comment wiped out.
2537 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
2538 Value representation between StringRepresentable and BinaryRepresentable.
2539 * src/gdcmDocument.cxx:
2540 - method ParseDES: proper indentation restored and usage of
2541 gdcmVR::IsVROfGdcmStringRepresentable wired in.
2542 - method LoadDocEntry: the fingerprint left in the SetValue() of
2543 unloaded entries (length > MaxSizeLoadEntry) had curiously been
2544 removed. Reverting to previous code segment with the proper
2545 dynamic_cast< gdcmValEntry* >.
2546 Note: this was (partially) breaking the python test suite
2547 (gdcmPython/testSuite.py) that made usage of the above
2548 fingerprint to check presence of "Pixel Data".
2549 * src/gdcmDocEntry.h: coding style.
2550 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
2551 now taken into account.
2552 * gdcmPython/gdcm.i: adaptation to the new internal representation
2553 of gdcm (exit gdcmParser, hello gdcmDocument).
2554 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
2556 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
2557 anymore, but instead prints the loaded Python dictionary.
2558 * .... alas, the python testSuite is still broken.
2560 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2561 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
2563 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
2564 * src/gdcmUtil.h : export methods
2566 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2567 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
2569 * Initial addition of automatic python testing
2570 * Initial addition of automatic image comparison
2572 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2573 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
2574 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
2576 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2577 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
2578 * Test/ShowDicom.cxx : bug fix for msvc compilation
2579 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
2581 2004-05-04 Jean-Pierre Roux
2582 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
2583 new concepts (and new classes) :
2584 a 'gdcmDocument' is composed of a set of Doc Entries, that are
2585 - elementary gdcmDocEntries (former gdcmHeaderEntries)
2586 - Sequence Doc Entries (gdcmSeqEntries)
2587 a Sequence is composed of Items.
2588 Each item is a set of Doc Entries (this is recursive)
2589 The non uniqueness of the 'Dicom tag' is due to this recursivity
2590 (never taken into account)
2591 Our unability to add a new 'entry' in the header
2592 at the proper location (neither in the H-Table (map or multimap),
2593 nor in the Chained List is also due to this recursivity.
2594 Don't try, right now, to use/modify/compile these new sources :
2595 nothing is finished.
2596 We just commit all the stuff, 'as is', in order not to loose it.
2598 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2599 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
2601 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2602 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
2603 file prefix (SetFilePrefix)
2605 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2606 * Add a new test: ShowDicom, for now this is just the c++ version of
2607 checkRead.sh, later it will be able to compare the image read against a
2609 * Replace the DEBUG on the stack with a global entry in cmake interface:
2610 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
2612 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2613 * Add an example subdir, with a real example on how to read + write a
2616 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2617 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
2618 * Doc/CMakeLists.txt: the main page is now properly differentiated
2619 between the developper and user version.
2620 * Doc/doxygen.config.in: dropped search related obsolete flags
2621 * src/gdcmParser.h, gdcmHeader.h: doxygenation
2623 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2624 * DEVELOPPER: added some helpfull comments for compile/test/install
2627 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2628 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
2629 src directory, now generated in the build dir.
2630 2. Tests as mentionned smarter
2632 4. Add a new method in gdcmDict that return the PubDict by name
2633 this is interesting for 3rd party lib like ITK,
2634 where we could set the institution name / patient name...
2636 * ENH: 1. Now the test suite is working for real
2637 2. All binaries are now output in the gdcm-bin directory
2638 (this was not true before)
2640 2004-04-28 Jean-Pierre Roux
2641 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
2642 SeQuence indented printing of Dicom Header.
2643 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
2644 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
2645 Computation of SQDepthLevel is now part of gdcmHeader constructor
2646 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
2647 tree-like structure of a Dicom Header.
2648 * FIX Test code cleaning
2650 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2651 * ENH: Adding automatic testing
2652 1. Need a DartConfig.cmake to submit to public
2653 2. Add a test driver gdcmTest.cxx
2654 3. gdcmTestMain, an helper for the main test driver gdcmTest
2655 4. Files in Test don't have a main anymore, this becomes interesting
2656 when we add more and more tests, thus dsw don't have to load
2658 * ENH: Adding a GDCM_DATA_ROOT for testing
2659 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
2660 one file instead of seven + some small cleanup
2662 2004-04-22 Jean-Pierre Roux
2663 * ENH Minor changes to the Print() methods.
2664 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
2665 Header printing. Example given with :
2666 > PrintHeader fileName 2 new
2667 (SQ based tree-like structure still to be done for the Header ...)
2669 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2670 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
2671 1. I have added some unsigned where needed
2672 2. Some function parameter not used -> (void)
2673 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
2674 4. g++ don't like character '\' in comment
2675 5. #define jpeg_create_decompress jCreaDecompress
2676 this really need to be fixed
2677 6. virtualize destructor of gdcmObject ... leakage
2678 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2679 this also really need to be fixed
2680 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2681 remove compression file
2682 (as we only do decompression, right ?)
2683 * ENH: Change malloc/calloc/free with c++ equivalent
2685 2004-04-21 Jean-Pierre Roux
2686 * FIX gdcmHeaderHelper::GetXSpacing
2687 when a single value is found (bug ?), xpacing is now
2688 defaulted to yspacing
2690 2004-04-19 Jean-Pierre Roux
2691 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2692 * ENH add parameters :
2693 bool exception_on_error = false,
2694 bool enable_sequences = false,
2695 bool ignore_shadow = false
2696 to the gdcmFile constructors to be full gdcmParser compliant
2697 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2698 to allow reading of PAPYRUS 3.0 files
2700 2004-04-06 Jean-Pierre Roux
2701 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2703 2004-04-02 Jean-Pierre Roux
2704 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2705 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2706 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2708 2004-03-30 Jean-Pierre Roux
2709 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2710 for ACR file, written out as DICOM files (hope so...)
2712 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2713 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2714 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2715 moved to base class gdcmParser and only the specialisation is kept
2717 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2718 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2719 already does the job.
2720 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2721 (to be consistent with gdcmParser::WriteEntries).
2723 2004-03-30 Benoit Regrain
2724 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2725 upate of the object's instance. It's passed to 2 in the unfavorable
2726 case : one in the ExecuteInformation, one in the ExecuteData
2728 2004-03-29 Jean-Pierre Roux
2729 * ENH : Check on file type to be written moved
2730 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2731 * FIX : gdcmObject::ResetBoundaries now stops properly
2732 when end-of-list is reached
2733 : gdcmVersion modified (as Benoit Regrain asked)
2735 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2736 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2737 * src/gdcmUtil.cxx: added forgotten iostream include.
2738 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2739 equivalent to ExplicitVR in existing code).
2741 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2742 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2743 now contains all the gdcmGlobal related code.
2744 * minor coding style and doxygenation changes.
2746 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2747 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2748 now contains all the Debug related code.
2749 * minor clean-up of includes in src/*.cxx
2750 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2751 CreateCleanString) removed.
2752 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2753 * Doc/DoxyMainPageUser.txt added.
2754 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2755 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2756 src/gdcmDirList.cxx)
2758 2004-03-24 Jean-Pierre Roux
2759 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2761 2004-03-23 Jean-Pierre Roux
2762 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2763 big endian made volumes
2764 * ENH Now gdcmParser constructor and destructor are protected to forbid
2765 end user to instanciate class gdcmParser
2766 (only gdcmHeader and gdcmDicomDir are meaningfull)
2768 2004-03-22 Benoit Regrain
2769 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2770 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2771 gdcmSerie to gdcmDicomDirSerie
2773 2004-03-19 Jean-Pierre Roux
2774 * ENH Now the tree-like structure describing a DICOMDIR comming from
2775 an already existing DICOMDIR file is consistent with
2776 the home-made tree-like structure build ex-nihilo
2777 or build from the files held (recursively) in a Directory
2778 functions gdcmDicomDir::CheckBoundaries()
2779 gdcmObject::SetBoundaries() added
2781 2004-03-17 Jean-Pierre Roux
2782 * REM (Eric Boix bug) : removal of meaningless
2783 gdcmDicomDirImage::NewImage function.
2784 * FIX now file names and directory name are written properly in the
2786 * FIX now gdcmDicomDir constructor may be call without any trick
2789 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2790 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2791 of gdcmDicomDirImage::NewImage as empty function.
2793 2004-02-28 Jean-Pierre Roux
2794 * ENH add gdcmDicomDir:NewPatient
2795 add gdcmDicomDirPatient:NewStudy
2796 add gdcmDicomDirStudy:NewSerie
2797 add gdcmDicomDirSerie:NewImage
2798 to allow making gdcDicomDir object.
2799 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2800 (as opposite to the gdcmHeader chained list)
2802 2004-02-11 Benoit Regrain
2803 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2804 when using from python
2806 2004-02-10 Benoit Regrain
2807 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2808 * FIX : in gdcmDicomDir when the directory is empty
2809 * ENH : add callback and methods to get the progression of dicomDir
2812 2004-02-06 Jean-Pierre Roux
2813 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2814 - GDCM_META added to gdcmDicomDirType
2815 - class gdcmMeta created
2816 * ENH : - A brief summary is now displayed at the beginning of
2817 'testDicomDir' to help disaster magnitude estimation
2818 * REM : Now useless Test/explDICOMDIR.cxx
2820 2004-02-05 Benoit Regrain
2821 * ENH : add methods in gdcmObject to get the hash table or the list of
2823 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2824 * FIX : wrapping python for TagHeaderEntryHT
2826 2004-02-04 Benoit Regrain
2827 * FIX : even length for some strings when writting the dicom dir
2828 * FIX : sort the images in the dicom dir
2829 * FIX : Bug fix for python use of dicom dir
2830 * ADD : a python demo
2832 2004-02-04 Jean-Pierre Roux
2833 * FIX : Final solution (?) for icone embedded images
2834 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2835 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2836 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2837 gdcmData/gdcm-MR-SIEMENS-16.acr1
2838 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2839 to make full checking easier
2841 2004-02-04 Benoit Regrain
2842 * FIX : WriteEntries : coding style & logic in parameters
2843 * FIX : Set the elements to create the DicomDir in a dictionary file
2845 2004-02-03 Benoit Regrain
2846 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2847 * gdcmDicomDir : add the load of directory
2848 * Bug fix and print add-on
2850 2004-02-03 Jean-Pierre Roux
2851 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2852 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2853 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2854 * FIX gdcmParser.cxx : 'group length' elements are now considered
2855 as integers, even for shadow groups, when file is Implicit VR
2857 2004-02-02 Jean-Pierre Roux
2858 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2860 of the last synonym :-(
2861 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2863 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2864 * FIX taking into account the possible 7fe0,0010 multiplicity
2865 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2866 to allow removal of references to 7fe0,0010, to deal with
2867 ACR-NEMA images, when 0028,0200 is meaningfull
2869 2004-01-31 Jean-Pierre Roux
2870 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2871 no longer writes 'Un' on disk
2872 * FIX SQ elements with actual length are now dealt with corectly
2873 * FIX gdcmFile::WriteBase make the difference, for color images, between
2874 the length (for Palette expanded images)
2875 and Raw Length (non expanded image + Palette)
2876 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2877 (that broke Write). Replaced by UL.
2878 Aware user will reload the field if he
2879 thinks it's necesssary
2881 2004-01-30 Jean-Pierre Roux
2882 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2883 when 'dirty Acr' is found, to be compliant with the new
2884 IsReadable() methods.
2886 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2887 (no DOUBLE images in kosher DICOM,
2888 but so usefull for people that miss them ;-)
2890 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2891 DICOMDIR related utilities (not checked as Windoze compliant)
2893 2004-01-28 Jean-Pierre Roux
2894 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2896 2004-01-27 Jean-Pierre Roux
2897 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2898 to allow skipping the shadow elements, to save memory space.
2899 The TRUE value for this param has to be used
2900 with a FALSE value for the 'enable_sequence' param.
2901 ('public elements' may be embedded in 'shadow Sequences')
2902 * gdcmHeader methods now deal with 'embedded icones images' in the header
2903 (even when an 'icone image sequence' is announced by the
2904 element (0x0088,0x0200), but there is NO icone at all ...
2906 * gdcmHeader sometimes Image Location value doesn't follow
2907 the supposed processor endianity (see gdcmData/cr172241.dcm).
2910 * gdcmHeader add the method
2911 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2912 to get *all* the Header Entries with the same tag.
2913 GetHeaderEntrySameName is probabely *useless*
2914 (no meaning : Name is *not* an identifier within the Dictionary)
2916 2004-01-26 Benoit Regrain
2917 * Bug fix in the print of hexadecimal representations. Remove long fields
2918 in the print and add a third level of print to print them
2920 2004-01-23 Benoit Regrain
2921 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2922 * Bug fix on test suite after remove the strip made on not string fields
2923 * Split the IsReadable method between gdcmParser which test that the file
2924 is dicom and gdcmHeader which test that it's an image file
2926 2004-01-22 Benoit Regrain
2927 * DicomDir : clean code, add methods, set variables in protected or private
2928 * gdcmUtil : bug fix for the clean string method
2930 2004-01-19 Benoit Regrain
2931 * Add the use of shadow dictionaries
2932 * bug fix and coding style
2934 2004-01-19 Benoit Regrain
2935 * src/gdcmFile.cxx : bug fix concerning the close of file
2936 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2937 * Add the update of header entries using the shadow library
2939 2004-01-19 Benoit Regrain
2940 * removal of file gdcmHeader2.cxx
2941 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2942 inheriting from gdcmParser. This split is to prepare the integration
2943 of dicom dir parsing
2944 * bug fix under python
2946 2004-01-16 Jean-Pierre Roux
2947 * REM removal of class gdcmHeaderEntrySet
2948 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2949 * ADD add file gdcmHeader2.cxx
2950 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2952 2004-01-15 Benoit Regrain
2953 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2954 entries created while parsing the header. Thus, they will be destroyed
2955 when the gdcmDictSet will be destroyed
2956 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2959 2004-01-15 Benoit Regrain
2960 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2961 made a fatal error because of the memory release at the end of program.
2962 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2963 some memory and vtk seems to have some problems with that.
2964 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2966 2004-01-14 Benoit Regrain
2967 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2968 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2969 * src/*.[h|cxx] : make changes due to class name changes
2970 * gdcmPython/demo/*.py : bug fix due to method names
2972 2004-01-13 Benoit Regrain
2973 * src/*.[h|cxx] : coding style
2974 * vtk/*.[h|cxx] : coding style
2976 2004-01-13 Benoit Regrain
2977 * gdcmPython/testSuite.py : test the readable flag of file for tests
2978 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2979 It's lied to the stl compilation by MSVC (windows, always windows...)
2980 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2982 2004-01-12 Benoit Regrain
2983 * src/*.h : add comments
2984 * src/gdcmDictSet.h : set the method BuildDictPath in public
2985 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2986 directly setted in the source code
2987 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2990 2004-01-09 Benoit Regrain
2991 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2992 * setup.py : use a reference to gdcmVERSION
2994 2004-01-07 Benoit Regrain
2995 * Modification to compile with the distutils.
2998 2003-12-10 Benoit Regrain
2999 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
3000 can use a gdcmHeaderHelper to load data
3001 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
3002 made in the source code
3004 2003-12-10 Benoit Regrain
3005 * Update Windows projects and .cvsignore files
3007 2003-11-12 Jean-Pierre Roux
3008 * ENH gdcmHeader constructor has one more parameter (default value : false)
3009 that allows the user to 'go inside' the SeQuences only
3011 gdcmElValSet:Print takes it into account
3013 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3014 * ENH: Update gdcmPython/CMakeLists
3015 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
3016 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
3018 2003-11-10 Jean-Pierre Roux
3019 * FIX : gdcmHeader::LoadElements is now based
3020 on the ListTag listElem member,
3021 not longer on the TagElValueHT tagHt member
3022 * ENH : PrintPubElVal shows (temporarily) both results,
3023 with the tagHt member and the listElem member.
3024 (it's easier to 'see' the problems when using Printheader)
3026 * FIX : old private member LgrElem is now splitted into
3027 ReadLength : Length actually found on disk (updated only
3028 if bug fixing is necessary), for internal
3030 UsableLength : Updated by FixFoundLength, to fix a bug
3031 or to allow Parser going on.
3032 Will allow to re-write a kosher header when a SeQuence
3033 with a length (not 0000) is found
3034 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
3035 because gdcmElValSet::Add does not update ListElem
3038 2003-11-07 Jean-Pierre Roux
3039 * FIX misstyping in Transfert Syntax name table
3040 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
3041 when they have an actual length (not 0000 nor FFFFF)
3042 (Nobody should care of it, but DICOMDIR explorers)
3044 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3045 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
3047 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3048 * ENH: vtkGdcmReader now supports LUT !
3049 (vtkgdcmViewer for now is not able to use them though)
3051 2003-11-05 Jean-Pierre Roux
3052 * in testSuite.py : new files names for checking the package
3053 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
3054 that returns the pixel area size to the *aware* (vtk) user
3055 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
3057 2003-11-05 Benoit Regrain
3058 * in testSuite.py : Modify the rules for checking the paths
3059 : Explicit error messages
3060 * in __init__.py : Related modif
3062 2003-11-03 Jean-Pierre Roux
3063 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
3064 to be used by aware (vtk) users that want to manage
3065 LUT (and no to turn the PALETTE image into an RGB pixels one)
3066 * GetPixelType now returns 8U for 24 Bits images
3067 (vtkGdcmReader compliant)
3069 2003-10-31 Jean-Pierre Roux
3070 * Removal of *all* gdcmData images and add them again
3071 in order to loose the 'history' of un-anonymised images
3073 2003-10-31 Jean-Pierre Roux
3074 * RMV : removal of useless jBitsInJsample.h
3075 for both 8 and 12 Bits JPEG Lossy Libraries
3077 2003-10-31 Jean-Pierre Roux
3078 * ENH : Add the functions gdcmFile::GetImageDataRaw
3079 gdcmFile::GetImageDataIntoVectorRaw
3080 that act as GetImageData and GetImageDataIntoVector
3081 except the making of an RGB Plane from Gray Plane + LUT
3082 Intended to aware (vtk) users who know how to manage
3085 GetLUTRGBA return a R,G,B,A LUT if any
3086 lgrTotaleRaw gives the 'Raw' length
3087 GetImageDataRaw returns the gray Plane
3088 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
3089 (They stay Grey, just like with other Dicom viewers :-(
3091 2003-10-30 Jean-Pierre Roux
3092 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
3094 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3095 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
3096 being coherents dicom files.
3098 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3099 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
3101 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
3102 * ENH: Two steps is necessary to please VC++ compiler...
3103 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
3104 * ENH: Add include dir to medcon lib
3105 * FIX: only one function is being exported for now !
3106 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
3108 2003-10-29 Jean-Pierre Roux
3109 * adding gdcmHeader::GetLUTRGBA
3110 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
3111 --> Mathieu, the modif u're waiting for is not yet committed
3112 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
3114 2003-10-27 Jean-Pierre Roux
3115 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
3116 00191113.dcm DermaColorLossLess.dcm
3117 MxTwinLossLess.dcm RadBWLossLess.dcm
3118 * ENH: For version prior to vtkImageViewer2 -r 1.19
3119 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
3121 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3122 * Removal of ido stuff in CMakeLists.txt
3124 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3125 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
3126 * FIX: remove a call to ->Modified ... see comments
3127 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
3129 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3130 * FIX: Problem with path for libvtkgdcmPython
3131 * ENH: Try adding a search script for python site-package
3132 * RMV: Remove some file from medcon lib that are not necessary
3133 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
3134 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
3135 * FIX: More pragma disable fro VC++,
3136 I don't think I break something as it is also disable in VTK/ITK.
3137 But it fasten debug compilation time.
3139 2003-10-23 Jean-Pierre Roux
3140 * gdcm now deals with 16 Bits Run Length Encoded images
3141 (they are compressed as 2 planes images,
3142 one for the high Bytes, the other for low Bytes)
3144 2003-10-22 Jean-Pierre Roux
3145 * Now CheckRead takes into account :
3146 - the bugged 'Leonardo' Siemens images
3147 - the XA images, sent thru the burning VPRO station
3148 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
3151 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3152 * FIX: When copying a Makefile.am to CMakeLists.txt
3153 one should remove the '\'
3155 2003-10-22 Jean-Pierre Roux
3156 * in gdcmData adding a bugged 'Leonardo' Siemens image
3157 (wrong lengths in header)
3158 OK with gdcm, KO with the other viewers :-)
3159 * add a GE dlx XA image, thru the VEPRO burning station
3162 2003-10-21 Jean-Pierre Roux
3163 * in gdcmData add the checkvtkgdcmViewer.sh shell script
3164 for a brutal checking of vtkgdcmViewer compliance
3166 2003-10-21 Jean-Pierre Roux
3167 * add the files for 'xmedcon' Jpeg Lossless library
3168 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
3170 2003-10-21 Jean-Pierre Roux
3171 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
3173 2003-10-21 Jean-Pierre Roux
3174 * garbage Siemens 'Leonardo' images dealt with
3175 (the patch is easy to remove)
3176 * cosmetic changes to avoid warnings
3178 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3179 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
3180 no need to press 'r' now.
3182 2003-10-20 Jean-Pierre Roux
3183 * upgrade of checkRead.sh checkWrite.sh according
3184 to new Jpeg Lossless decompressor
3185 * add US.3405.1.dcm, a genuine RGB medical file ...
3186 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
3187 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
3189 2003-10-15 Jean-Pierre Roux
3190 * general anonymisation in gdcmData
3191 * adding the 'color files' from
3192 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
3193 * adding some well knowed bugged-header images
3194 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
3195 waiting for their inclusion in Python testsuite
3197 2003-10-15 Jean-Pierre Roux
3198 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
3199 no longer seg faults when file is not found
3201 2003-10-14 Jean-Pierre Roux
3202 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
3205 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3206 * TODO: *.in file to genereate a UseGDCM later
3208 2003-10-14 Jean-Pierre Roux
3209 * Some supposed-to-be Dicom Images have no preamble.
3210 OpenFile takes it into account
3211 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
3212 * Missing elements added in dicomV3.dic
3213 (just to be affraid : have a look at
3214 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
3215 and do it again next year ;->
3217 2003-10-13 Jean-Pierre Roux
3218 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
3219 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
3220 But there are NOT. It's fixed !
3222 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3223 * FIX: "jpeglib.h" was not found on VC++
3224 * FIX: vtkgdcm was not being installed
3226 2003-10-10 Jean-Pierre Roux
3227 * ENH : OpenFile closes the file if it *really* doesn't look like
3228 an ACR-NEMA / DICOM one.
3229 * FIX : testWrite no longer writes an empty file if the source file
3230 is not gdcm Readable
3231 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
3234 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3235 * FIX: CMake generate now documentation
3236 * ENH: out of source doc build !
3237 * ENH: Generate both user and dev documentation
3238 * ENH: Should work on windows too
3239 * ENH: Only one doxygen config.in file is needed
3240 * FIX: make install should be ok now on Unix plateform
3241 * FIX: PATH to dictionary was wrong (missing /)
3242 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
3244 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3245 * vtkGdcmReader is now able to read rgb dicom file.
3246 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3247 * added a gdcmViewer to vtk test, use mouse to control
3248 window level & window width
3250 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3251 * CMake-ification of gdcm, we have now two build system
3252 * FIX: on cygwin Wsock32 doesn't exist
3253 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
3255 2003-10-06 Emanuel Ollart
3256 * FIX : compilation process wad broken.
3257 Changed gdcmViewer_sources to vtkgdcmViewer_sources
3259 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3260 * change gdcmViewer -> vtkgdcmViewer
3261 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
3263 2003-10-06 Jean-Pierre Roux
3264 * FIX :A few nasty patches to allow the reading of a lot of nasty images
3265 ( e.g : well known GE images with a wrong elem length,
3266 : Philips MRI Images with a wrong Huffman table)
3267 * still to be done : allow the reading of bugged LEONARDO Siemens images
3269 2003-10-03 Jean-Pierre Roux
3270 * Odd length strings are padded with '\0' (not with spaces,
3271 to remain compliant with already defined strings,
3272 like Transfert Syntax UID and others)
3274 2003-10-03 Jean-Pierre Roux
3275 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3276 to allow displaying RGB images (not only by affim ;-)
3278 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3279 * vtkGdcmReader is now able to read rgb dicom file.
3280 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3282 2003-10-03 Jean-Pierre Roux
3283 * A few nasty patches to allow the reading of a lot of nasty images
3284 ( e.g : well known GE images with a wrong elem length,
3285 : Philips MRI Images with a wrong Huffman table)
3286 * still to be done : allow the reading of bugged LEONARDO Siemens images
3288 2003-10-03 Jean-Pierre Roux
3289 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
3291 2003-10-03 Jean-Pierre Roux
3292 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3293 to allow displaying RGB images (not only by affim ;-)
3295 2003-10-03 Jean-Pierre Roux
3296 * gdcmFile::GetImageDataIntoVector now
3297 - deals with MultiFrames MultiFragments Run Length Encoded files
3298 - deals with YcBcR (YBR_FULL) files
3299 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
3300 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
3302 (no sample found :-(
3304 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3305 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
3306 Two reasons: - clear things
3307 - third parties acces gdcm through header files, so won't
3308 suffer anymore VC++ complains
3310 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3311 * add argv[1] in testvtkGdcmReader.cxx
3314 2003-09-24 Jean-Pierre Roux
3315 * The lines are now eigthy characters long for
3316 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
3318 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3319 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
3320 char* to std::string. Thus, the use of strdup becomes useless. (see
3321 previous commis of Malaterre)
3322 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
3323 before the last Malaterre's commit.
3325 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3326 * This commit should fix the Debug building under VC++, the problem
3327 was mainly a mixture of debug and release lib being loaded at startup.
3328 * I also remove a depency to a specific C function: strdup. Because I had
3329 to force the link to msvcrtd (whereas strdup is in libc).
3331 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3332 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
3333 located in the gdcmCommon.h file. All use of reference of tha has been
3334 changed to now use the variable GDCM_UNFOUND.
3336 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3338 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
3339 Dicom dictionary. The test suite can now be run again. Note:
3340 I'm note very happy with the " (RET)" changes. I believe this
3341 RETAINED comment should be dropped when parsing the dictionary.
3342 - PACKAGER corrected
3344 - AUTHORS updated and now in alphabetical order
3345 * Makefile.am now exports gdcm.dsw for Windoze users.
3347 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3348 * cygwin complains about missing std:: in subdir Test/
3350 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3351 * remove some methods that are now in gdcmHeaderHelper
3353 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3354 * vtkGdcmReader set spacing and origin correctly
3356 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3357 * Fix a few delete/delete[] mismatch
3359 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3360 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
3361 interpretation to data given by gdcmHeader. For instance there are
3362 heuristics to get informations (look at different places).
3363 * it also include a specific class: gdcmSerieHeaderHelper devoted to
3364 sorting DICOM images based on different strategies.
3365 * modified Makefiles accordingly.
3367 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3368 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
3369 when building in debug mode
3370 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
3371 src/win32/gdcmdll.dsp
3372 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
3374 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3375 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
3378 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3379 * src/win32/libgdcmjpeg12.dsp was not dos format
3380 * src/win32/libgdcmjpeg12.dsp :
3381 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
3382 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
3384 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3385 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
3387 * src/gdcmFile.cxx : bug fix in affectation type
3388 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
3389 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
3390 * Modifs of MVSC projects to compile them. Not concerning 2 identic
3391 symbols... future problem ?
3393 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3394 * src/win32/libgdcmijpeg12.dsp was missing
3395 * modified gdcm.dsw accordingly
3397 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3398 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
3400 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3401 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
3402 commit of JPR (before his hollidays to facilitate our work).
3403 * setup.py : bug fix in code. Modifications made while the last commit
3404 of JPR. The code hasn't been tested before the commit... it's so
3405 useless to make that (for best programmer that is JPR) !!!
3407 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3408 * tagged the current version as Version0_3 (i.e. version 0.3)
3410 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3411 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
3412 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
3413 * *.dsp : modifications to use new libgdcmijpeg8 library
3414 * setup.py : bug fix on VTKPATH variable
3415 * PACKAGER : adding all concerning windows
3417 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3418 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
3420 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
3421 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
3422 test suite reported error.
3423 * PACKAGER file added (describes what a packager must do when
3424 packaging a new release).
3425 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
3426 * configure.in: upgraded version number to 0.3.0
3427 * fixing build of rpm (through rpm -ta):
3428 - Doc/Makefile.am exports proper doxygen files
3429 - src/jpeg/libijg8/Makefile.am exports the include files.
3431 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3432 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
3433 * src/gdcmHeader.h : formatting code
3435 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3436 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
3437 We were obtaining error message from vtk. Now, creation of file list
3438 is made in an internal list to prevent this problem.
3439 Bug fix when output is empty.
3440 Bug fix in update of progress value. Previous commit for this was a bad
3442 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
3444 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3445 * src/gdcmHeader.h : added method to get the file name
3446 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
3447 files. Added method to remove all files on the input
3448 Added FIXME comment concerning the bad parsing of header made by
3449 ExecuteInformation method (in ExecuteData method)
3451 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3452 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
3453 when using make instal.
3454 * src/gdcmFile.cxx : bug fix under Window after JPR commit
3455 RQ : the JPR doesn't appear in the ChangeLog... normal for him
3457 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3458 * setup.py : adding include dir of jpeg lib to compile all sources
3459 * */Win32/*.dsp : JPR fix for windows compilation
3461 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3462 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
3464 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
3465 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
3467 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3468 * setup.py is again effective on un*x (takes into account the
3469 addon of the jpeg library)
3470 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
3471 * Doc/Doxy* updated (includes above enhancements)
3472 * INSTALL now points to web documentation
3474 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3475 * src/gdcmHeader.h doesn't make unnecessary reference to
3477 * gdcmPython/Makefile.am now avoids calling the wrappers for the
3479 * src/gdcm*.[cxx|h] :
3480 - to allow compilation with gcc 3.x
3481 -- clean up of STL usage (added explicit usage of std::)
3482 -- small fixes on exceptions.
3483 Note: linking not tested !
3484 - clean of doxygen comments to avoid warnings at documentation
3486 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
3487 dependent convertion).
3489 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3490 * Clean up of previous JPR garbage commit (not even commented in the
3492 - Test/Makefile.am removed the reference to unexisting testTS.cxx
3493 - moved all jpeg related files from src to src/jpeg/libijg8, with
3494 addition/modification of Makefile.am and configure.in.
3495 - the testSuite is still brain damage (not guilty).
3497 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3498 * WrapVTK.py : modifications to get correctly vtk source files to
3500 * vtk/vtkGdcmReader.cxx : modification for an already existing name
3501 (FileName -> Filename)
3503 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3504 * vtk/vtkGdcmReader.[cxx/h]:
3505 - UpdateProgress method should now be effective
3506 - removed the limitation on having only images loaded (as opposed
3508 - when building a stack of images/volume, a lesser number of
3509 gdcmHeader and gdcmFile instances should be used (hopefully
3510 accelerating things).
3511 - when building a stack of images/volumes, files which are not
3512 loadable (wrong path-filename, wrong permissions on existing file,
3513 or file not parsable by gdcm) are replaced with a black image
3514 in the stack (for the caller to notice the problem).
3516 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3517 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
3519 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3520 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
3521 between standard library (std) and vtk library (problems are found
3522 under Windows... thanks Windows !)
3524 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3525 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
3527 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
3529 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3530 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
3532 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3533 * When compiling with distutils (see setup.py) the C++ compiler is
3534 called with different flags than the default ones (with automake).
3535 In order to fix all those warning, I compiled gdcm with the command
3536 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
3537 and went for warning fixes:
3538 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
3539 up from unused variables.
3540 - vtk/vtkGdcmReader.cxx: potential bug fix.
3541 * src/gdcmHeader.h: Doxygen warning cleanup
3543 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3544 * gdcmPython/gdcm.i:
3545 - typemaps correction to take into account the systematic replacement
3546 of "using namespace std" with std:: prefix e.g. std::list,
3547 std::string... (cf changes of 2003-05-21).
3548 - gdcmGlob global variable of type gdcmGlobal (defined in
3549 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
3550 exported to Python a as cvar.
3551 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
3552 and GetPubDictTagNamesByCategory() as a replacement for deprecated
3553 gdcmDictSet.GetPubDictTagNames() and
3554 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
3555 C++ static methods).
3556 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
3557 with the above changes.
3559 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3560 * setup.py, manifest.in : bug fix under linux
3562 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3563 * Modification of setup.py to compile vtk part too. Then, we have 2
3564 wrappers which must work with same distutils. For that, we have a
3565 generic distutils in distusiltsWrapping.py ; with :
3566 - build_extWrap class to wrap generically all extensions,
3567 - ExtensionWrap base class for all wrapping extension that contains
3569 - Wrapper interface which wrap sources
3570 + In WrapSwig.py we have extension and wrapper for Swig
3571 + In WrapVTK.py we have extension and wrapper for VTK
3572 * MANIFEST.in : modifications to consider vtk directory and new python
3573 files for compilation
3575 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
3576 * Added python wrappers of vtkGdcmReader vtk class (see the
3577 source in vtk/vtkGdcmReader.cxx) :
3578 - vtk/Makefile.am now builds a library
3579 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
3580 python library (as opposed to _gdcm.so wich are the python
3581 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
3582 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
3584 - configure.in has an additional flag --enable-vtk that needs
3585 to be set to enable compilation of vtk related code, that is:
3586 + vtk/vtkGdcmReader.so and
3587 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
3588 + gdcmPython/vtkgdcmPython.so (see above)
3589 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
3590 be read when compressed or when HighBit + 1 != BitsStored),
3591 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
3592 the usage of the python wrapper of vtkGdcmReader vtk class.
3593 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
3594 * src/*.[h] all occurences of stl classes are now prefixed with
3595 std::, and all occurences of "using namespace std;" where removed.
3596 This is to avoid pollution of global namespace in included files.
3597 Apparently vtk does not avoid this pitfall: when using both
3598 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
3599 collision of various stl members (principally cout...).
3600 * gdcmPython/testSuite.py now cleanly removes temprory generated
3602 * gdcmPython/gdcm.i now declares a typemap for std::string (to
3603 comply with above changes)
3605 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3606 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
3607 * vtk/vtkGdcmReader.cxx now properly inports the image in the
3608 vtk data structure (an image Flip was required).
3609 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
3610 * cosmetic changes in documentation.
3612 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3613 * src/gdcmHeader.cxx: the constructor no longer exits when an
3614 unexisting file is given as argument.
3615 * The subdirectory Data (containing all the images used for the
3616 test suite) is not part of this repository anymore. A new module
3617 containing those images is now available at
3618 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
3619 with the name gdcmData.
3620 All the python scripts (including the package initialisation file
3621 gdcmPython/__init__.py) were adapated to take this change into
3622 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
3624 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3625 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
3626 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
3627 demo of the usage of this class.
3628 Compilation of this vtk part is only done when using the --enable-vtk
3629 at configure (or autogen.sh) stage.
3631 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3632 * More memory link related corrections and documentation fixes.
3634 - maximum info is obtained with a command of the form:
3635 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
3636 --show-reachable=yes PrintHeader
3637 - the remaining reachable blocks seem to come from the STL
3638 allocation scheme through the usage of map and list. It looks
3639 like this memory cannot be freed but it is not a memory leak
3640 (in fact further invocation to the STL would recollect the
3641 unused memory allthough it cannot explicitely be freed).
3642 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
3643 of displaying an image parsed with gdcm and displayed with VTK.
3644 Note: some images don't seem to work e.g.
3645 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
3646 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
3647 Allthough this weakens the semantics, it is a ditch attempt to
3648 make gdcm more thread friendly.
3650 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3651 * Memory link hunt (by using valgrind through the command
3652 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
3653 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
3654 gdcmHeader::_dicom_vr.
3655 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
3656 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
3658 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
3660 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3661 * src/Makefile.am now exports all the necessary include files at
3665 * UpdateGroupLength replaced by new one
3668 * UpdateGroupLength re-written using H-Table
3669 (named UpdateGroupLengthNew untill checks are over)
3671 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3672 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
3673 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3675 - gdcmHeader::GetPubElValSet removed.
3676 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3677 UpdateGroupLength, WriteElements, Write.
3678 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3679 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3680 carried the same semantics.
3681 - src/gdcmHeaderIdo.cxx changed accordingly.
3682 - gdcmFile::WriteBase now regroups all the codes from previous
3683 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3684 - enum FileType moved to gdcmCommon.h
3685 * src/gdcmHeader.cxx AddDefault trashed
3686 * gdcmGetXSize added
3687 * getimageDataSize now calls gdcmGetXSize
3688 * Test/*.cxx changed to agree with above changes
3690 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3691 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3692 (to avoid double call by end user).
3693 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3694 by end user, since gdcmHeader::gdcmHeader now handles it.
3696 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3697 * gdcm/Doc many doxygen changes:
3698 - Doxyfile now has two different versions, DoxyfileUsers that generates
3699 the html.users end users oriented documentation and
3700 DoxyfileDeveloppers that generates the html.developper developper
3701 oriented documentation.
3702 - README changed accordingly
3703 - requirement.txt removed (old design info moved to TODO).
3704 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3705 DoxyMainPage.txt, DoxyPython.txt provide more information.
3706 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3707 be updated by simply regenerating the docs with doxygen and copying
3708 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3709 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3710 all the tests in the form "if (<map>.count() >1)" were removed.
3711 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3712 ill-formed documentation sections.
3713 * src/gdcmHeader.cxx: ditto
3715 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3716 * setup.py fixed for un*x (needed macro for stdint.h)
3717 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3718 un*ces with sh-utils test utility.
3719 * gdcmPython/demo/test.py renamed to PrintHeader.py
3720 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3721 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3722 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3723 * src/gdcm*.cxx JPR's bad inclusion fixed.
3725 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3726 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3727 * gdcmPython/demo/test.py changed accordingly.
3729 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3730 * gdcmPython/Makefile.am fixed linking against libstdc++
3731 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3732 * Swig subdir (historical tests of swig version 1.3.17++) removed
3733 * Test/testChangeEntete.cxx some lines commented out in order to make
3735 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3736 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3738 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3739 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3740 hence the user doesn't need this explicit call.
3741 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3742 i.e. LoadElements() call removed.
3743 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3744 - src/Makefile.am declares the proper flag for g++.
3745 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3746 for adding user defined new tags.
3747 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3748 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3749 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3751 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3752 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3753 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3754 src/Makefile.am : the project should properly compile and install
3755 with the autotools, included the python wrappers part.
3756 * gdcm.spec.in : added a spec file for RPM packaging.
3758 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3759 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3761 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3762 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3763 to exported to the environement (see gdcmPython/testSuite.py
3765 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3766 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3767 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3768 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3769 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3771 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3772 * gdcmPython/__init__.py doesn't crash anymore when running in
3773 in InstallMode or PreInstallMode but with an environment given
3774 value of GDCM_DICT_PATH.
3775 * src/gdcmDictSet.[cxx/h] coding style.
3777 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3778 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3779 * src/gdcm.h general comments moved to TODO, and README
3780 * src/gdcm.h should now be seen as a user commodity (including it
3781 should suffice to fully use gdcm). It is nowhere including within
3782 any of the kernel files src/*.cxx and src/*.h.
3784 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3785 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3786 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3788 * src/gdcm*.cxx only include their corresponding include file
3789 (as opposed to gdcm.h)
3790 * gdcmPython/gdcm.i changed accordingly
3791 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3792 the autogen.sh generated "make snapshot" command to work.
3793 * autogen.sh removed history related references to crea package.
3795 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3796 * distutilsSwigCPlusPlus.py work around some swig portability
3799 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3800 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3801 was done in a last ditch attempt to get setup.py _really_
3802 operationnal. The python/gdcmPython layaout add the advantage
3803 of hidding away the python related distutils specific files
3804 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3805 Alas, the src directory was out of scope (i.e. it's relative
3806 position to setup.py was ../src) which made things impossible to
3807 handle (see previous version of python/setup.py). Crossing fingers...
3809 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3810 * python/setup.py now works on Un*x. (harder than I thougth)
3811 * python/distutilsSwigCPlusPlus.py can now have include files
3812 among the list of sources.
3814 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3815 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3816 * modifications in MSVC projects
3818 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3819 * As stated by the first lines of Test/ExceptionAndPython/README, it
3820 looks like we can move back to original usage of exception within
3821 src/gdcm* and hence remove the errno stuff that was introduced
3822 as a quick and dirty fixture of this problem (added to the TODO).
3823 * Doc/Doxyfile configuration file for Doxygen and corresponding
3824 README file for usage added.
3825 * Test/testWrite.cxx added. This new test comes from a split of
3826 test.cxx that is now reverted to its original purpous i.e.
3827 testing the proper parsing of a Dicom related file.
3828 testWrite.cxx concentrates on testing the IO part of gdcm.
3829 * Test/bug1.cxx (containing a bug on WIn32) added.
3830 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3831 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3832 whose purpose is to publish the content of the TagNames of the
3833 Dicom public dictionary were not accessible without an
3834 instance of class gdcmHeader.
3835 - those methods are now static methods of gdcmDictSet and hence
3836 require no instances at all to be invocated.
3837 - within gdcmDictSet this change required to change some method
3838 to class methods (i.e. are now static) among which SetDictPath
3839 (renamed to BuildDictPath) and LoadDefaultPubDict.
3840 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3841 the above changes by calling the new method classes of gdcmDictSet.
3842 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3843 the above to be effective.
3844 * python/gdcmPython: in order to wrap properly the above changes
3845 for Python, swig version now needs to be > 1.3.17.
3846 * python/gdcmPython/Makefile fixed to adapt itself to new
3847 configure/make shema introduced by Johan Montagnat (thanks for the
3848 contribution). Alas this Makefile cannot be turned into a proper
3849 Makefile.am without some heavy changes in the configure.in
3850 (for python dectection).
3851 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3852 now avoids publishing the empty entries.
3854 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3855 * python/setup.py : bug fix concerning install under windows
3856 ExtraPath reused :-P
3857 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3859 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3860 * Dicts/dicomV3.dic : remove double spaces !!!
3861 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3862 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3865 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3866 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3867 method. Doxygenation.
3868 * src/gdcm.h clean up of JPR spurious comments.
3870 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3871 * python/distutilsSwigCPlusPlus.py now properly collects the
3872 shadow classes generated by "swig -c++" (gdcm.py in our case)
3873 when using "python setup.py install".
3874 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3875 reexports the working classes.
3876 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3877 by the classical C errno scheme. This is to prevent an obscure
3878 behavior of the python wrappers when importing wxPython.wx prior
3879 to gdcmPython (which ended up in an abort call). An illustration
3880 of this oddity can be found in the Test/ExceptionAndPython
3881 subdir (see the README file). This problem probably due to
3882 an combination of g++ and dynamic loading.
3883 * added Test/ExceptionAndPython (see above)
3885 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3886 * Changed the layout of the python part to avoid bloating main
3887 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3888 i.e. the distutils arsenal. All the python related stuff is
3889 again in a python subdir, but the package itself is now in
3891 * setup.py was cleaned up:
3892 - pythonIncludePath removed
3893 - python setup.py bdist target is now functional.
3894 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3895 collision with other packages). gdcmPython/demo/*.py changed
3898 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3899 * python subdir moved to gdcmPython (preparation of distutils packaging).
3900 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3901 distutils installer is operational.
3902 * - gdcmPython/__init__.py now properly loads the swig generated
3903 shadow classes (from gdcm.py).
3904 - gdcmPython/demo/*.py changed to import the package gdcmPython
3905 instead of gdcmPython/demo/load.py.
3906 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3908 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3909 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3910 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3911 entries within the associated public Dicom dictionary resp. the same
3912 information but sorted by the fourth field (PAT, IMG, DIR) of the
3914 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3915 are now in the "???" group.
3916 - python/gdcm.i changed accordingly,
3917 - python/demo/printGroupedPublicDict.py added, that gives an example
3918 of the above new functionalities in Python.
3920 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3921 * src/gdcm.h, gdcmHeader.cxx:
3922 - historic references to glib's g_malloc and g_free (#defined)
3923 were definitively removed.
3924 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3925 * src/gdcmElValSet.cxx:
3926 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3927 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3928 - GetElValue(string) renamed to GetElValueByName.
3929 - Added GetElementByName(string).
3930 * src/gdcmHeader.cxx: added
3931 - GetPubElValRepByNumber(guint16, guint16)
3932 - GetPubElValRepByName(string)
3933 - GetShaElValRepByNumber(guint16, guint16)
3934 - GetShaElValRepByName(string)
3935 - GetShaElValByNumber(guint16, guint16)
3936 - GetShaElValRepByName(string)
3937 - GetElValRepByNumber(guint16, guint16)
3938 - GetElValRepByName(string)
3939 - GetElValByNumber(guint16, guint16)
3940 - GetElValRepByName(string)
3941 * Doc/requirements.txt added.
3943 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3944 * Test/Makefile building now depends on the one of libgdcm.so
3945 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3946 pixel data) aware which enables finding the address (offset) of
3947 the pixel data of JPEG encoded DICOM files. This leaves only a single
3948 file in the testSuite whose pixel data address (offset) is unknown.
3949 * python/testSuite.py changed accordingly.
3951 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3952 * VC++ has some strong limitations when working with the STL, as stated
3953 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3954 "Also note that some STL containers (map, set, queue, list, deque)
3955 cannot be exported. [...]
3956 Some STL classes contain nested classes. These classes can not
3958 This is caused by a designed limitation that once a template
3959 class is instantiated, it can not be re-instantiated and
3961 Since our usage of map<> is ubiquitous in gdcm, this "designed
3962 limitation" of VC++ is a pitfall.
3963 Hence the Python wrappers of gdcm cannot be incrementally linked
3964 against the c++ dynamic library. The dirty but only workaround is
3965 to forget about incremental link of dynamic libraries and to generate
3966 the Python wrappers library with the inclusions of the underlying C++
3968 The following modifications concern this matter on Win32/VC++:
3969 - wrapping python correct with standalone wrapped dll (don't use separate
3970 dll under windows !!!!)
3971 - python21_d debug mode enabled (ask Frog how to use it :-)
3972 - NO problem with having an STL member of class for example string in C++
3973 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3974 - Python test of dcmlib in Python is ok under windows on a large set
3976 * removed glib references
3977 * typedef's inserted in gdcm.i for correct swig type management
3979 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3980 * python/demo/*.py load.py extracted from test.py. Added explore.py
3981 that only displays required tags and testAll.py that parses all
3982 the files of the testsuite without using unittest.
3983 * python/testSuite.py other additional test on new files added.
3984 * Data/* new test files added accordingly to the testSuite.
3985 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3986 the vr in the file differs from the one of the dictionary.
3988 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3989 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3990 values, but limits itself to values which are below a user specified
3991 size (by default 1024 bytes).
3992 * python/gdcm.i : elements not loaded (because their size is above the
3993 user specified treshold) are exported with their TagKey as key of the
3994 python dictionary. This enables the testsuite to make some checks
3995 on the unloaded elements (since we have their offset and size).
3996 * python/testSuite.py
3997 - now tests for the existence and proper value of the pixel data
3998 - two new examples added.
3999 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
4001 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4002 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
4003 aware. See the strategy comments in gdcmHeader::FindLength().
4004 * Test/test.cxx now accepts a filename as first argument.
4005 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
4006 * python/testSuite.py changed to integrate test on above files.
4008 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4009 * Dicts/dicomV3.dic removed all the trailing (RET) when the
4010 the vr was also RET.
4011 * python/testSuite.py more tests added.
4013 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4014 * python/testSuite.py unittest test suite added (uses Data)
4015 * Data/* dcm and acr files for the test suite.
4016 * glib dependance removed from un*x version. We now use ISO C99
4017 7.18 Integer types (see stdint.h)
4018 - python/Makefile, src/Makefile src/gdcm.h
4019 * src/ when an explicit vr (like dicom files) suddenly poped an
4020 implicit element we use to mark the underlying DictEntry of the
4021 concerned ElValue with "Implicit". This strategy was damageable
4022 too the public or provite dictionaries, since some of their vr
4023 would be changed. Since Header::FindLength heavily relies on the
4024 detection by Header::FindVR of falsely explicit elements, I
4025 added an extra ImplicitVr member to ElValue (boolean).
4026 The rest of the changes we the necessary adaptations.
4028 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4029 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
4031 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
4033 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4034 * Adaptation for porting to VC++:
4036 o forced to use std namespace (for string to be known)
4037 o all class use __declspec export style on WIN32
4038 - src/gdcmUtil.cxx new Exit method that wraps the exit call
4039 (in stdlib.h on Win32 but in std:: for gcc)
4040 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
4041 variable GDCM_DICT_PATH.
4042 * src/gdcmHeader.cxx verbose comments made discrete.
4044 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4045 * python/gdcm.i: added a typemap that converts a C++ hashing table
4046 to native Python dictionary.
4047 * python/demo/test.py:
4048 - now uses the native dictionary for exploration of gdcmHeader.
4049 - takes an optional filename argument (the file to parse).
4050 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
4051 PubElVals hashing table.
4052 * Dicts/dicomV3.dic removed error prone trailing spaces.
4054 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4055 * Python wrapping process moved away from src/Makefile to
4056 newly created python/Makefile (as well as gdcm.i)
4057 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
4058 * src/gdcmHeader::FindLength only looks for current vr when necessary.
4059 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
4060 from the environement variable GDCM_DICT_PATH (when existing).
4061 * src/gdcmDict::GetTag bug fix.
4063 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4064 * Straightforward temporary fixes for swig to build the python wrappers.
4065 src/Makefile now has a python working entry [by working we mean
4066 that we can import the shadow classes without errors].
4068 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4069 * hashtest.cxx removed (since already in Test)
4070 * src/gdcmlib.h renamed to src/gdcm.h
4071 * src/dcm.i renamed to src/gdcm.i
4072 * src/Makefile prepared for python wrapping
4074 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4075 * src/gdcmHeader.cxx :
4076 - Parsing of header is now separated from loading of element values
4077 (see gdcmHeader::LoadElements).
4078 - general clean up of hopefully all file access (creation of
4079 ReadInt16 and ReadInt32)
4081 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4082 * src/gdcmHeader.cxx :
4083 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
4085 - SetLgrElem renamed to SetLength
4086 - GetLgrElem renamed to GetLength
4087 - ~gdcmHeader() made virtual to pesky warning messages at compile.
4088 * src/gdcmElValSet.cxx fixed both GetElValue methods
4089 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
4090 due to IdoDude was cleaned out.
4092 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4093 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
4094 concentrates on finding the value representation (when it exists).
4095 RecupLgr now only finds the element value length, and it avoids
4096 returning the unecessary skL (skipped length).
4097 Also, offsetCourant was simply removed (with taille_fich) since
4098 it was redundant with the File position internals (by using
4099 ftell and fseek). This also made skL (see above in RecupLgr) usage
4101 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
4102 on the libido specificities which are handled through class
4104 * Test/implicit_vr.dcm dicom v3 in implicit value representation
4107 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4108 * Truckload of changes. Parsing of header is barely functional
4109 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
4111 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4112 * src/gdcmHeader.cxx many addons of low level methods
4114 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4115 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
4116 and _IdDcmSWAP_LONG.
4118 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4119 * This corresponds to all the changes decided at the meeting of
4120 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob