1 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
4 * src/gdcmDict.h : remove commented code
5 * src/gdcmDocument.cxx : initialize values
6 * src/gdcmFile.cxx : bug fix when reading values
7 * gdcmPython/demo/ : change file names. Remove useless files
9 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * src/gdcmFile.cxx : remove the default array of initialization.
11 The static array contained pointers to non-static values (comming from
12 strings). To have coherences, when creating files, these values can't be
13 static. So, the array can't be static, too ! To simplify, the array have
14 been replaced by repeted lines to insert values in the File
16 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
18 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
20 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
21 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
22 (Dicom Element) into the Sequence Item
24 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * src/*.cxx : first parss to normalize file organisation
27 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmDirList.[h|cxx] : add method to find a directory
29 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
31 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
32 * Finish cleaning up my JPEG mess. Should be ok now.
33 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
34 contained within the RLE* class(doh!)
36 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
37 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
38 * SerieHeader::AddFileName() creates as many Coherent Files lists
39 (same Serie UID) as it founds different Serie UID
40 amongst the files instead of discarting any file
41 that doesn't match with the first one he found.
42 * SerieHeader::OrderGdcmFileList has now one parameter :
43 the Coherent Files list the user wants to sort
44 * SerieHeader::GetFirstCoherentFileList() |
45 * SerieHeader::GetLastCoherentFileList() | allow to parse
46 the set of Coherent Files lists
47 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
48 compatibility (it returns the *first* Coherent Files list,
49 since there was only one before)
50 * Test/TestSerieHeader gets gdcmData as a default root directory
52 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * Remove friend between DocEntry and File classes
54 * Remove friend between PixelReadConverter and RLEFramesInfo,
57 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
59 0002|0000. The value was incorrect.
61 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
62 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
64 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * src/gdcmUtil.cxx : compilation fix on Win32
66 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
67 variable, to be easy found. Add methods to change the default UID.
68 Amelioration of the CreateUniqueUID to use the correct default UID.
69 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
72 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * Test/TestVR.cxx : fix memory leaks
75 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
76 * Rewrite the base 256 to base 10 conversion, using string operation only.
77 This allows us to get rid of the problematic 64bits integer type (does not
78 always exist on target platform).
80 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
81 * Add construct and destructor to class gdcm::Debug to close the debug file
83 * Don't let uset to open twice the same file
84 * gdcm has now an official UID prefix,
85 supplied by http://www.medicalconnections.co.uk
86 1.2.826.0.1.3680043.2.1143
87 (Thx to Mathieu for providing URL)
88 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
89 to be able to perform some more tests
90 * gdcm::ContentEntry : Contructors and Destructor are now protected,
91 in order to be sure no user will try to use them.
92 (at user level, only the children classes are meaningfull)
94 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * move RLEInfo & JPEGInfo from Document to File
97 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
98 * FIX : remove so many friend between classes
100 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
102 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
104 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
105 In order to avoid missbehaviour :
106 . gdcm::DocEntry is now specialized in
107 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
108 - gdcm::ContentEntry (Dicom entry with a 'content')
109 . gdcm::ContentEntry is specialized in
110 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
111 characters value, or integers)
112 - gdcm::BinEntry (Dicom entry with a non strig representable value
113 (user hasn't any longer to thing about the precedence of his dynamic_casts)
115 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * Test/VTKTest*.cxx : bug fix under linux
118 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
120 use with python. Some methods are moved from Document to ElementSet or
121 DocEntrySet. The equivalent methods to ElementSet have been added to
122 SQItem and are virtual in DocEntrySet. Methods that may have the same code
123 in SQItem and ElementSet is directly placed in DocEntrySet
125 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * Test/VTKTest*.cxx : remove the show variable in each test method because
127 it's useless (the viewer variable replace this variable)
129 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * src/gdcmDocument.cxx : bug fix on potential memory leak
131 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
132 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
133 Add ClearXxx methods to remove all the content of the list or map
134 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
136 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
137 * methods ReplaceOrCreate renamed as Insert
138 (nobody will be any longer confused by 'CreateOrReplace')
140 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
141 * Grealty simplify the JPEg decompression, no need to differenciate based on
142 the JPEG possible type (with/without fragment, with/without multiple frame).
143 Everything is done throught the JPEG IO Suspension mechanism in IJG
145 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
146 * Stage 3 of normalization :
147 in order to avoid any missunderstanding while reading method names :
148 - All the methods xxxEntry now deal with dicom Entries
149 - Methods GetEntry splitted into
152 - Method SetEntry renamed as SetEntryValue
153 - Method SetEntryBinArea let as it was
155 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
156 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
157 - Position correctly the entry points for JPEG2000 and JPEG-LS
158 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
160 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
162 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
163 with other method names
164 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
165 * Test/TestDicomDirElement.cxx : add new test
167 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
168 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
169 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
170 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
171 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
172 So can't you use __int64 in ostream at all.
174 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
175 * bug fix for compilation on MSVC6
176 * gdcmPython/gdcm.i : rename of classes missed
178 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
179 * Stage 2 of names normalization :
180 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
181 (easy to understand ...)
182 - gdcm::FileHelper replaces old class gdcm::File
184 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
185 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
186 type and not a string. So, there remove problems on the format of the
189 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
190 * Add Example/TestPapyrus.cxx
191 - reads a Papyrus file (gdcm::Header compliant),
192 - gets the pixels of all the images, using low level iterators
193 - writes an multiframes Dicom image.
194 (Just to show it's *possible* to do that)
195 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
198 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
200 Thus, DicomDirXXX are created with a flad that indicates if the created
201 object is empty or not (when not empty, the DicomDirElement is used to
204 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
205 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
206 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
208 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
211 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
213 Remove all access to the hash-tables or lists in the objects.
215 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
217 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
218 be complient with all the gdcm source code
220 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
224 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
225 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
228 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
229 * Test/ : rename VTK tests to have a best name for the tests
230 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
231 GetFirstEntry/GetNextEntry use
233 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
234 * In SerieHeader::ImagePositionPatientOrdering()
235 // a Dicom 'Serie' may contain scout views
236 // and images may have differents directions.
237 // -> More than one may have the same 'pos'
238 // Sorting has then NO meaning !
239 Thx to Eduardo Davila for reporting bug.
241 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
242 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
243 test. Now it's on image content and not on the resulting visualisation...
244 might solve the problem on linux when using the OpenGL drivers
246 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
247 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
248 DicomDirSerie, DicomDirImage
249 Dict, DictSet classes :
250 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
251 -remove InitTraversal method.
252 * UPD Test programs + Example programs
254 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
255 * remove useless and never updated keyword \ingroup
256 * Solve pb when structure (list, map, ...) is empty.
257 Thx to Benoit for reporting bug
259 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
260 * Taking into account of 'Transfer Syntax' value
261 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
264 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
265 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
266 is no memory access violation
267 * gdcmPython/demo : add python demos using VTK
269 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
270 * FIX 'Dictionnary' is now spelt 'Dictionary'
271 'wether' is now spelt 'whether'
272 'archieve' is now spelt 'archive' ;-)
274 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
275 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
276 related methods, in order not to expose internal mechanisms
279 * REM methods that exposed internal mechanisms :
280 DicomDir::GetDicomDirPatients()
281 DicomDirPatient::GetDicomDirStudies()
282 DicomDirStudy::GetDicomDirSeries()
283 DicomDirSerie::GetDicomDirImages()
284 * UPD Test programs :
288 * UPD Example program
290 * ADD DictSet methods
294 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
295 * Removed the Print/indent/default parameter mess. There is absolutely no
296 reason to have to methods, moreover with the second taking the ostream as
297 *SECOND* parameter. This was clearly a bad hack to get things compile.
299 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
300 * Complete rewrite of the GetMacAddress code. Now the code is *much*
301 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
302 Unfortunately the main code does not work on SunOS, thus provide a specific
303 code for this platform only (and Win32 of course). Since this seems to be
304 working, change CreateUniqueUID to use GetMACAddress instead of the
305 problematic GctestetIPAddress
307 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
308 * Unfortunately to be able to test gdcmDirList I had to break the API
309 a little. Now the class is not a std::list anymore but has a member
310 std::vector (more ITK compatible). Allow unit testing on Win32 and
313 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
314 * Update SerieHeader to take into account a Serie Instance UID to properly
317 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
318 * ENH - Comment out Mathieu's (dangerous) Super Hack
319 for dealing with BIGENDIAN processors
320 - Move equivalent stuff to BinEntry::WriteContent
321 When necessary, 16 Bits Pixels are swapped in a small buffer
322 and then written. This avoid allocating a huge buffer, in
323 PixelWriteConvertor, and avoid modifying the Pixel Area.
325 Probabely, the same operation will have to be done when we want
326 to write image with Big Endian Transfert Syntax,
327 and we are working on Little Endian Processor
329 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
330 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
332 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
333 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
334 all the dict content.
335 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
337 * Test/TestDict.cxx : add a new test for the dict classes
339 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
340 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
341 file. Debug is yanked if compiled with NDEBUG
343 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
344 * src/gdcmDictSet.h : set the default output to the os variable
345 * src/gdcmDictEntry.[h|cxx] : add the Print method
346 * gdcmPython/demo/ : add a new test
348 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
349 * merging of Test/PrintDicomDir and Test/TestDicomDir
350 * removal of now redundant Test/PrintDicomDir
351 * enhancement of Example/PrintDicomDir
353 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
354 * Now, python test might work on systems
355 * Add the PrintDicomDir test
357 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
358 * FIX : First entry following group 0002 was lost for
359 Explicit Big Endian Transfer Syntax files
360 (group and elem not swaped)
362 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
363 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
364 Big Endian Transfer Syntax supposed the group following 0002
365 begins always by element 0000 (element 0000 is *optional*)
366 To avoid further troubles, let's be pessimistic, and use
367 Document::HandleOutOfGroup0002() method
368 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
369 (related pb not yet solved)
371 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
372 * Bug fix for the python part use
373 * Now, PrintHeader.py pass... but outside the ctest use. shit !
375 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
376 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
378 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
379 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
380 a string and should ask the global TS dict what are the propreties of
383 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
384 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
385 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
386 to swap the Swap Code, at parsing time, when we come out of group 0002
387 and Transfer Syntax is Big Endian
388 We should be able to read now 'true DICOM" Big Endian coded images
389 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
390 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
392 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
393 * Hopefully fix the bug on MacOSX and static global initialization.
394 This is the only -minor- patch I found that both please MacOSX and VS6.
395 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
396 but this would require a lot of change. Another approach would be that Global
397 create those string and GDCM_UNFOUND becomes a pointer to a string (which
398 gdcm::Global would destroy at exit).
400 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
401 * Fix bug on MacOSX with static initialization in a multy threaded
402 environment. static const string in a header file used to be ill
403 initialized provoquing the freeze of any tests. patch should solve this
406 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
407 * According to Benoit's suggestion, and without any objection from anybody
408 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
409 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
410 - method gdcmDicomDirObject::GetEntry() renamed as
411 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
413 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
414 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
415 you debug/warning message just as c++ streams which make them very convinient
416 to use. Once this is stabilize I will change the ostringstrem to be
417 redirected to a file (ofstream).
418 * Properly support C99 extension: __FUNCTION__ which allow us to display
419 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
421 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
422 * Removal of useless and dangerous methods :
423 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
424 GetDocEntryByName, GetEntryByName, GetDictEntryByName
425 * Removal of usless methods :
426 Dict::PrintByName, Dict::GetDictEntryByName
427 * Commenting out of probabely useless methods :
428 Dict::GetDictEntryNames()
429 Dict::GetDictEntryNamesByCategory()
430 DictSet::GetPubDictEntryNames()
431 DictSet::GetPubDictEntryNamesByCategory()
432 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
433 * ENH : Use dicomTS.dic as described in 2004 version
434 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
435 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
436 Add Accessors on VM (Value Multiplicity), and VM related methods
437 * ADD : Add a list of 'Dicom Attribute types', as found in
438 http://medical.nema.org/dicom/2004/04_15PU.PDF
440 * ADD : Add dicomGroupNameAbbreviations.dic
441 should be used to write a method to replace the former
442 Dict::GetDictEntryNamesByCategory()
444 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
445 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
446 to read in the file... and only it ! Length is the efective length of the
447 data in the DocEntry structure
449 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
450 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
451 And now use a static function call instead, with a global variable. i
452 This is much closer to the VTK approach. Hopefully should be bulletproof
453 and easier to use...hopefully
455 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
456 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
458 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
459 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
461 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
462 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
463 ValEntry, BinEntry, SeqEntry creation or replace
465 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
466 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
467 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
469 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
470 when specifying the VR
471 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
472 * src/gdcmDocEntry.cxx : amelioration of print
474 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
475 * ADD : Add the method Util::IsCurrentProcessorBigEndian
476 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
477 * ADD Method Document::ComputeGroupLength
478 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
479 in order to allow further VR modification by user
480 * REM : removal of once-called method File::WriteBase
481 integration of its code in formerly one-line method File::Write
483 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
484 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
485 replace the different values "??", "Unkn", "Unknown".
486 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
487 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
488 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
489 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
491 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
492 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
494 * Set the gdcm::Base class to some Printable classes
496 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
497 * src/gdcmFile.[h|cxx] : add the Print method
498 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
499 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
500 * src/gdcmDocument.h : remove the PrintLevel informations
501 * Example/PrintFile.cxx : use the new gdcm::File::Print
503 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
504 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
505 problems when compiling with the python wrapping
507 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
509 writting in ImplicitVR
511 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
512 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
513 JPEG decompression, especially when dicom frames are split into several
514 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
515 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
517 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
518 * src/gdcmHeader.cxx : change the initialisation of default header.
519 Now, this header is readable by gdm, e-film, DicomWorks
521 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
522 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
523 Rename Decompressed to Raw
524 * Use the API changes in gdcm::File.
525 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
528 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
529 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
530 each added entry in the header. Replace the 'Planes' field by the 'Number
533 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
534 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
535 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
537 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
538 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
539 At this time, this image isn't readable by e-film... waiting JPR help to
542 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
544 DocEntry. Now use methods of the Document !
546 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
547 * Test/ShowDicomSeq.cxx : bug fix
549 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
550 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
551 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
552 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
553 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
555 * Test/TestCopyRescaleDicom.cxx : remove unused variable
556 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
557 containing found sequences
559 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
560 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
562 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
563 Some fields in BinEntry must be copied to not seg fault when making the :
564 gdcm::File *copy = new gdcm::File( copyH );
565 and tests are now made on good variables
567 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
568 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
569 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
571 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
572 * Add vtkGdcmWriter example and test
574 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * Test/TestUtil.cxx : reformat the source code
576 * vtk/vtkGdcmReader.cxx : remove and change prints
577 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
579 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
580 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
582 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
583 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
584 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
586 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
587 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
588 by an eof to prevent all bad read of the file... and in this case, the
591 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
592 * Example/Volume2Dicom.cxx : comment unused variables
593 * Test/PrintDicomDir.cxx : comment unused variables
594 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
595 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
596 method that is redondant with AddEntry.
597 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
600 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * Bug fix due my last commit (compilation under Windows).
602 * Example/Volume2Dicom : bug fix in the file and reformatting source code
603 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
605 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
607 - Remove printf / sprintf
608 - include iostream AFTER gdcm so we don't get warnings
609 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
611 - Also remove tons of include from header files, hopefully this should
612 speeup the compilation time, since it was becoming a dog slow.
613 - Remove gdcm.h as it include way too many files and slow down compilation
614 (plus it is not up to date)
615 - remove 'using namespace std' this is BAD !
617 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
618 * Remove memory leaks on the DicomDir
619 * Remove some useless data in DicomDirObject
620 * Add usefull methods in SQItem, to be complient withe the ElementSet
622 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
623 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
625 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
627 future, with convertion)
628 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
629 and ImageDataSize values. Remove the method to get the PixelReadConverter
630 from the output of the class
632 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
635 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
636 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
637 and vtkErrorMacro use.
638 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
640 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
641 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
643 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
644 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
645 The string leaves only in the fonction. So when we make a .c_str(), we
646 get the pointeur on the first element, element that will be destroyed
647 immediately after thee instruction.
648 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
649 file has been opened : the test must be made on the content of the
650 pointer and not directly on the pointer !
653 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
654 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
655 the python part recompiles
657 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
658 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
659 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
660 X session is killed (for my computer... it seems to not be identic on
663 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
664 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
665 avoid problems (otherwise, the difference test between the visible image
666 and the reference is incorrect. If the reference is greater than the
667 screen resolution, it's produce errors).
668 Can be used for only one image. Can be used with a visible flag.
669 * vtk/vtkGdcmReader.cxx : remove commented codes.
670 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
671 under windows at compilation
672 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
674 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
676 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
677 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
678 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
679 tests on the image size X, Y, Z
681 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
683 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
684 between the class name and the file name
686 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
687 * src/ : fix compilation warnings for the Write method (2 different
688 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
689 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
690 variable... create a static method in gdcm::Document to access to
691 this variable content.
693 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
694 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
695 file, to be accessed by other files (like gdcmFile). Remove commented
696 code. Move the change of the header to the gdcmFile, using the
698 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
699 To be sure of that (and simplify calls), the Write of the header now
700 gets a file name and not a file pointer (std::ifstream).
701 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
702 DocEntryArchive. Remove all open of the written file
704 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
705 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
707 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
708 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
709 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
711 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
712 some corresponding methods. Write correctly the file and check before
714 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
715 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
716 is now on RGB data (as before my last commit
717 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
719 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
720 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
721 Add a print information of the type of the entry
722 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
723 It was in the gdcmFile, and all write have been regrouped
724 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
725 Write correctly all dicom files (in decompressed mode only at this time)
726 * Test/ : test on files are now made using Raw data and not color data if
728 * Example/PrintFile.cxx : add more printings
730 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
731 * Amelioration of code, remove some code copy. For the loading of
732 BinEntry (in gdcmDocument), add the test to verify if the file is already
735 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
736 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
737 remove a DocEntry in the header (push an empty DocEntry)
738 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
739 lines. Bug fix in the initialization of the PixelConvert and the
741 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
742 use in TestCopyDicom (now this test can run under windows... but fails)
743 * Test/TestCopyDicom.cxx : amelioration of the test :
744 - test the pixels written
745 - add test points to quickly find where is the error
746 - can set a file name input and output in arguments
747 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
748 amelioration of the test output
750 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
751 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
752 all replaced DocEntry's
753 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
754 Now, each needed DocEntry to modify is duplicated, modified and inserted
755 to the header using DocEntryArchive. Thus, after save, we can restore the
756 header initial state.
758 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
759 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
761 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
762 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
763 correct to copy it. The DictEntry is specified at the DocEntry creation,
764 then, it musn't change in the time.
765 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
766 header correctly. At this time, the change is only made for the first
767 level of the Document. In the future, it might consider sequences.
768 The change is made by replacing a DocEntry by an other that is created
769 outside the class. The old value is kept. When we restore the header
770 status, the added DocEntry is deleted and replaced by the old value.
771 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
772 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
773 set the write type to explicit VR, implicit VR or ACR. Add methods to set
774 the write mode to native, decompressed or RGB (but not used at this time)
776 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
777 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
778 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
780 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
781 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
782 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
784 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
785 set because already copied when copying the BinEntry's of the header
786 * Test/TestAllReadCompareDicom.cxx : remove warnings
788 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
789 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
790 Two problems appear when doing it :
791 - with the gdcmFile : when the GetImageData method is called, the pixels
792 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
793 data (pixels). And each structure destruct the data when it's
794 destructed. So we have two destructions for the same data. To solve it,
795 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
796 data or not. If it doesn't own data, then they will not destroyed by
798 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
799 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
800 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
801 create a double destruction of the same DocEntry's. So, to solve it,
802 the TagHT is simply cleared and the DicomDir* elements are destroyed.
803 * TODO : add an entry concerning memory leaks in the DicomDir
805 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
806 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
807 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
810 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
811 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
812 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
813 after it have been deleted
815 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
816 * FIX: src/* fix the doxygen warnings.
817 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
818 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
819 was erroneously defined with a size of 15 instead of 16. [many thanks
820 to Jean Michel Rouet for pointing out this bug].
822 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
823 1. Finish merging JMR patch for writting DICOM from scratch
824 2. Fix -hopefully- bug with MONOCHROME and space vs null character
825 3. Use const ref when possible
826 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
827 5. A few more comments
828 6. CreateUniqueUID can now be called without parameter"
830 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
831 * ENH: Slightly bigger patch:
832 1. Getting toward full integration of JMR patch for writting dicom from scratch
833 2. Update Test to test part of this patch: CreateUniqueUID
834 3. File was not close properly in gdcmDict
835 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
836 5. Use of const ref instead of copy (speed issue)
837 6. Remove temporary (duplicate) string in TranslateToKey
838 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
839 8. Do not repeat virtual in subclasses
840 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
842 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
843 * Apply first patch toward better string comparison when dealing with broken
844 DICOM files. Essentially the string could be padded with a space instead
845 of a null character as defined by standard
847 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
848 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
849 because never used... and in the same time, that's remove some memory leaks
851 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
852 * src/gdcmFile.cxx : now delete the PixelConvert instance.
853 * In examples and tests : change the type of image data variables from void*
854 to uint8_t*. Remmove all delete on image data variables
856 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
857 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
858 Verify the file pointer value before open the file, and if it's not null,
859 a verbose message is generated.
860 Close correctly the file when the file isn't considered dicom-like. The
861 correctly close is a call to CloseFile.
862 When closing the file pointer, test if its not null to close the file.
863 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
864 file. For an uncompressed image, the copied data correspond in the least
865 case to the image size (calculated) or the image size specified in the
866 header. A verbose is generated if these two size mismatch
868 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
869 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
870 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
871 break under windows (with msvc6 compilation).
873 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
874 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
875 compiling with MSVC6)
877 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
878 * Bugs fix for the Windows build with VC6
879 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
880 needed (only for projects required VTK). If the VTK is included in all
881 projects, there is conflicts with the jpeg lib of vtk when compiling the
882 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
883 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
884 when compiling the gdcm_wrap.cxx file (created by the compilation of the
886 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
887 (like it's already made for the cout use). Otherwise, conflict with the
890 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
891 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
893 - comments on the DicomDir::Method related usage added.
894 - now that we use the namespace gdcm, a lot of internal classes do
895 NOT need to be wrapped anymore.
896 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
897 DicomDir::Method) new example added.
899 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
900 * Improve string manipulation. I now inforce the notion of 'DicomString'
901 A DicomString can contain as many \0 as they want
902 and it is *always* of even length.
903 We only support odd length for very rare case.
904 And in the near future this should be removed.
906 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
907 * /binary_write/ gdcm source. Now even on big endian we are writting
908 little endian. This should -heopfully- fix some tests
910 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
911 * Now the dictionary is compiled into gdcm lib. This is a default
912 behavior, thus any dic file specified is picked before failback to
913 the one comiled into lib
915 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
916 * Change internals for gdcmDict. Don't use any 'new' any more.
917 This should definitely solve any leak problem, and we should be
918 as fast as before, as long as don't modify too much the dictionary.
920 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
921 * STYLE: ivars should start with a capital letter.
922 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
923 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
925 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
926 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
927 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
928 new 2004 dictionaries added (thanks to JPR).
929 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
930 * CLEANUP_ROUND (15) for gdcmPixelConvert
931 - RLEFrame::NumberFragments is now of type unsigned int
932 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
933 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
936 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
937 * Initial work in gathering all transfer syntax accessors. clearly
938 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
939 ivars, but only one transfersyntax (class) ivar with equivalent method on
942 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
943 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
944 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
945 discussed (plus I didn't like having a 2000 lines patch not commited)
947 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
948 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
949 * CLEANUP_ROUND (14) for gdcmPixelConvert
950 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
951 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
952 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
954 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
955 anymore and hence avoids storing a copy of PixelConvert::Decompressed
956 into File::Pixel_Data.
958 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
959 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
960 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
961 * CLEANUP_ROUND (13) for gdcmPixelConvert
962 Substituted File::ParsePixelData() with PixelConvert::Print() new
964 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
965 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
966 method to those classes.
967 - src/gdcmFile.[cxx|h]:
968 -- Added a ::Print() method.
969 -- PixelConverter is now a reference instead of a member.
970 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
971 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
973 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
974 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
975 collaboration diagram and inheritance diagram should be generated with
977 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
978 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
979 pointlessly wrapped (see
980 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
981 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
982 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
983 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
984 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
985 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
986 -- File::Initialise: PixelConverter setup moved away to
987 PixelConverter::GrabInformationsFromHeader()
988 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
989 interpretation moved away to PixelConverter::BuildRGBImage()
991 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
992 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
993 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
995 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
996 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
997 displayed on Win32 when a brutal abort() occurs (because of uncatched
998 exception). See TODO new entry of this commit for more on this.
999 * TODO added new entry.
1000 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1001 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1002 - HandleColor is no longer called from gdcmFile.cxx
1003 - gdcmPixelConvert.cxx clean up on method arguments and internal
1004 variable names for semantical coherence.
1006 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1007 * Finished lossless transition, not only do we now read all lossless jpeg
1008 images, without the need of the Cornwell lib, but we do read them properly now
1009 * To reduce code (well to avoid code duplication), I defined a common place
1010 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1011 redefine symbols. This is not perfect but this the best solution I found for a
1012 compilation time jpeg option.
1014 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1015 * Update jpeg ijg lib to support lossless jpeg implementation
1016 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1018 * Also added a special copyright for dcmtk since we use their bugfixes.
1021 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1022 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1023 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1024 matters, as stated in warning note at beginning of %include section).
1025 * src/gdcmDicomDir*.[cxx|h]: coding style
1026 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1027 * src/gdcmJpeg8.cxx: doxygen fix.
1028 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1029 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1030 from File:: to PixelConvert::.
1032 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1033 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1034 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1035 - more code moved away from File:: to PixelConvert::
1036 - fat setup of PixelConverter set in place in File::Initialise.
1038 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1039 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1040 namespace at the file system level. So now you should convert your examples
1042 gdcmHeader -> gdcm::Header
1043 It would be nice if people keep in mind to no open the namespace, since it
1044 allows compilation on broken plateform which were defining common symbol in
1045 the standart namespace (like LP, Unknown ...)
1047 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1048 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1049 The JPEG fragments are now parsed at the same stage than the RLE
1050 information. All code related to JPEG is now in gdcmPixelConvert:
1051 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1052 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1053 export a gdcmFile:: method. Those are simply global functions
1054 (for the time being this is better than having them attach to
1055 either gdcmFile:: or gdcmPixelConvert::).
1056 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1057 and stores the result in a gdcmJPEGFragmentsInfo.
1058 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1059 code (among other stuff) moved away from gdcmFile:; to
1062 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1063 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1064 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1065 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1066 clean up of RLE related code.
1067 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1068 - src/gdcmRLE.cxx removed
1069 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1070 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1071 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1072 * CLEANUP_ROUND (9) for gdcmPixelConvert
1073 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1074 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1075 away from gdcmFile:: to gdcmPixelConvert::.
1077 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1078 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1079 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1080 This is because Parse7Fe0 used to parse the pixels to compute the
1081 length. This task was passed over to FindDocEntryLengthOB() a long
1082 time ago, EXCEPT I had forgotten the OW case...
1083 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1084 we just recylce the code for parsing RLE fragments and computing
1086 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1087 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1088 with the retired Parse7Fe0().
1089 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1090 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1092 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1093 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1094 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1095 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1096 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1097 * CLEANUP_ROUND (4) for gdcmPixelConvert
1098 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1099 to return an unused length.
1101 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1102 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1103 this should be cleanner from the plane view. The iostream are erally a pain
1104 to use to do simple stuff.
1106 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1107 * Redo the compilation of the ijg jpeg library. Now only one source is
1108 necesseray. No need to rename file by hand what so ever. CMake handle the
1109 copying of the file within different directory, configure header file to
1110 modify some symbol. The only addition made to ijg wasd a mangle table so
1111 that symbol are different whether we are within 8bits or 12bits.
1113 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1114 * Added documentation of vtkgdcmReader on Website:
1115 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1116 with it's binary name).
1117 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1118 the Website to be more complete.
1119 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1120 doxygenated documentation.
1121 - Doc/DoxyVtkGdcmReaderExamples.txt added
1122 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1123 DoxyVtkGdmReaderExamples.html )
1124 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1125 * CLEANUP_ROUND (3) for gdcmPixelConvert
1126 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1128 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1129 * CLEANUP_ROUND (2) for gdcmPixelConvert
1130 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1132 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1133 * CLEANUP_ROUND for gdcmPixelConvert:
1134 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1135 - src/gdcmPixelStuff[h|cxx] removed
1136 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1137 - src/CMakeLists.txt changed accordingly
1138 * GDCMHOME clean up:
1139 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1140 gdcmVersion.py moved to newly created ATTIC related
1141 gdcmPython/SetupOldies/ directory.
1142 * Autotools clean up:
1143 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1144 - autogen.sh configure.in acinclude.m4 python.m4 removed
1146 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1147 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1148 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1149 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1151 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1152 * TODO updated with Mathieu suggestions. I proposed a template for
1153 describing TODO entries and used it for new entries.
1154 * Added Doc/Website/CodingStyle.html, Developpers.html,
1155 DeveloppersPython.html, GdcmDataCvs.html and
1156 DownloadVersion0_1.html, DownloadVersion0_3.html.
1157 * Some Doc/*.txt Doxygen files (which do not really concern the
1158 documentation itself, but the website) moved to html and
1159 placed in directory Doc/Website:
1160 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1161 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1162 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1163 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1164 * CMakeLists.txt changed accordingly.
1165 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1166 DeveloppersPython.html
1167 * INSTALL nows refers to Doc/Website/Installation.html
1169 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1170 * Added Doc/Website directory, that contains a first raw version
1173 2004-09-23 Jean-Pierre Roux
1174 * FIX In order not to be poluted any longer by casting problems,
1175 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1176 we can now delete[] it safely
1177 * VoidArea is now called BinArea (less confusing name),
1178 and all the methods called ...VoidArea... are now ... BinArea...
1179 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1181 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1182 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1183 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1184 up to the destructor of gdcmElementSet to clean up TagHt and it's
1187 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1188 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1189 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1191 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1192 * ENH: added some utility method that builds a flat dictionary
1193 holding all the Dicom entries contained in the recursive structure
1194 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1195 an example of usage.
1196 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1197 BuildFlatHashTable() that build a flat dictionary.
1198 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1199 gdcmDocument is now a friend of gdcmElementSet.
1200 - src/gdcmElementSet.cxx: clean up.
1201 - Example/FlatHashTablePrint.cxx added.
1202 - Example/CmakeLists.txt changed accordingly
1204 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1205 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1206 moved away from gdcmDocEntrySet (since this class is an abstract class
1207 acting like an interface). SQDepthLevel and BaseTagKey are now
1209 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1210 and associated accessors. Doxygenation of the class.
1211 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1213 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1214 Use SQDepthLevel accessor instead. ::Print() adapted.
1215 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1216 - src/gdcmDocument.cxx changed accordingly.
1218 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1219 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1220 - The following is the doxygen comment of the typedef declaration
1221 of gdcmTagKey in src/gdcmCommon.h:
1222 gdcmTagKey is made to old an "universal" (as in URL, Universal
1223 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1224 A dicom tag always has a group and an element, but a set of tags
1225 embeded in various (optionally nested) sequences and sharing
1226 the same group and element all share the same (group, element)
1227 "identifier". Hence the (group, element) cannot be used as an
1228 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1229 In order to construct a proper tag identifier (i.e. a key) we
1230 consider the following definition of a TagKey:
1231 - let Group, Element be the string representation of the
1232 group and element dicom tag members,
1233 - let ItemNumber be the string representation of the integer
1234 index of the considered item number of a sequence,
1235 Let the key of a tag embeded in a sequence, noted SeqTag, be
1237 /ItemNumber#Group|Element
1238 where "/", "#" and "|" are characters acting as separators.
1239 Then the general form of a gdcmTagKey is given by:
1240 Group|Element<SeqTag>
1241 where <SeqTag> means NO or many instances of SeqTag.
1242 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1245 but the gdcmTagKey of a tag "embeded" is the first item of
1246 a sequence, itself nested in the third item of a sequence is the
1248 0004|1220/2#0008|0082/0#0008|0090
1249 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1250 order to hold the new sequence compatible key. Previously, the
1251 GetKey() method would look in the underlying gdcmDictEntry.
1252 - src/gdcmDocEntry.cxx:
1253 -- constructor now copies the underlying DictEntry key, in the local
1255 -- ::Print: displays the member Key, instead of the (group, element).
1256 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1257 - src/gdcmDocEntrySet.h:xi
1258 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1259 -- now has a new BaseTagKey member.
1261 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1262 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1264 This poses the problem with the semantics of the following lines
1265 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1266 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1267 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1268 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1269 to the long FIXME note for what the problem is. Nevertheless in
1270 order to get things working the dicom dictionary was altered !
1271 Please fix things urgently...
1272 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1273 information), see above note on moving the member VoidArea. Nevertheless
1274 the following entries previously correctly set as US are now inproperly
1276 0028 1201 OW IMG Red Palette Color Lookup Table Data
1277 0028 1202 OW IMG Green Palette Color Lookup Table Data
1278 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1279 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1280 of gdcmDocEntry moved to gdcmSeqEntry.
1281 * src/gdcmSeqEntry.cxx: STYLE.
1283 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1284 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1286 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1287 * gdcmPython/testSuite.py: all the test suite in python is now moved
1288 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1289 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1290 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1292 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1293 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1294 to avoid inclusion recursion until STL is reached.
1295 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1296 mecanism. errno.h is not included in gdcm anymore.
1297 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1298 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1300 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1301 gdcmData/TestAllEntryVerifyReference.txt
1302 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1303 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1304 exception_on_error parameter.
1305 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1306 - vtk/vtkGdcmReader.cxx changed accordingly,
1307 - Example/*.cxx and Test/*.cxx changed accordingly.
1309 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1310 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1311 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1312 enable_sequences removed from gdcmHeader constructor and dependencies.
1313 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1314 * gdcmPython/demo/PrintHeader.py: dummy fix.
1315 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1316 skip_shadow removed from gdcmHeader constructor and dependencies.
1317 * Example/*.cxx and Test/*.cxx changed accordingly.
1319 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1320 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1321 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1323 2004-07-21 Jean-Pierre Roux
1324 * FIX Now, Parsing and Printing a DICOMDIR do work!
1325 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1327 2004-07-20 Jean-Pierre Roux
1328 * FIX Some brain damaged headers have Zero-Lenght fields
1329 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1331 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1332 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1333 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1334 variable (instance of gdcmDebug) by a definition macro, and the instance
1335 is now in static in the gdcmDebug class
1336 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1337 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1339 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1340 * WARNING: ctest now depends more tightly on gdcmData. You should
1341 check out gdcmData properly for things to run smoothly...
1342 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1343 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1344 we need the pixels not be loaded in order to use the ValEntry
1345 that displays position and size).
1346 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1347 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1348 be deprecated. If you have any doubts about the advantages of a
1349 modern scripting language (read Python) versus grass root C++ (i.e.
1350 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1351 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1352 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1353 Anyhow, consider documenting the gdcmData images in
1354 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1356 * Test/CMakeLists.txt:
1357 - now uses TestAllEntryVerify.cxx
1358 - specific comments on oldACR00001.ima (now renamed in gdcmData
1359 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1360 gdcmData/TestAllEntryVerifyReference.txt
1363 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1364 * src/*.[h|cxx] : typedef clean up
1365 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1366 - TagKey renamed to gdcmTagKey (for external usage)
1367 - VRKey renamed to gdcmVRKey (for external usage)
1368 - removal of typedef duplication.
1369 - Removed all unecessary inline keyword from class inline definitions.
1370 - Some method|function(void) declarations replaced with method|function().
1371 * src/jpeg/libijg12/jdhuff12.c:
1372 - printf polluting ctest removed.
1373 - TAB removal for comminting
1375 - TestAllReadCompareDicom.cxx: added a test that compares all the
1376 images in gdcmDataImages.h with corresponding images in
1377 gdcmData/BaselineDicom/. When baseline images are not present
1378 this test creates them.
1379 Note: we need to validate each reference image, but before that
1380 I'd like to rename them with a more explicit name...
1381 - CMakeLists.txt: changed accordingly.
1382 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1383 including each header needed).
1385 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1386 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1387 test suite to the Example directory. Are concerned:
1392 - TestWriteSimple.cxx
1393 * Test/CMakeLists.txt: added some comments on reasons for black listing
1394 image gdcmData/oldACR00001.ima
1396 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1397 * Test/CmakeList.txt: removed the following from black list (to be coherent
1398 with removal from gdcmData):
1399 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1400 - gdcm-MR-PHILIPS-16.dcm
1402 Added the following because after last cvs update, they cause
1403 ctest -R TestReadWriteReadCompare
1405 - gdcm-MR-SIEMENS-16-1.acr
1407 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1408 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1409 new comments in this file) we temporarily (sigh) move to a weaker
1411 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1412 we don't need to black list the following images anymore:
1413 - 8BitsUncompressedColor.dcm
1415 - US-PAL-8-10x-echo.dcm
1416 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1417 fixes and the beautified code ;-)
1418 This fixes the bug introduced in version 1.42 (when beautifying)
1419 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1420 Note: ctest was blind to this bug (this means we need to still
1421 improve the test suite). The bug could be detected by using
1422 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1424 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1425 and by displaying the (garbage) produced file temp.XDCM...
1427 2004-06-29 Jean-Pierre Roux
1428 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1429 - replace by uggly but working old code :-(
1430 A lot of things should be OK again.
1431 It's really urgent to have a test suite that *tests*,
1432 to prevent Frog's beautifying sessions to break all the stuff
1433 (twice, withing a fortnigh ...)
1435 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1436 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1437 redundancy) to added Test/TestReadWriteReadCompare.cxx
1438 * Test/CmakeList.txt: because the compare test of
1439 Test/TestReadWriteReadCompare.cxx fails, the following images are
1440 black listed: - 8BitsUncompressedColor.dcm
1442 - US-PAL-8-10x-echo.dcm
1443 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1444 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1445 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1446 and ad-hoc kludge. This kludge is now removed, and on encountering
1447 such an image (OB field brain damaged) we set errno. Then in
1448 ::FindDocLength() we "fix" the length as being ALL what remains
1449 in the file (until EOF). We then proceed, hoping for the best...
1450 This fixes a SegFault in ShowDicom when trying to write such an
1452 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1453 (because TestWriteRead breaks on it, after a non conformal commit?).
1454 ctest now runs properly, except for MakeDicomDir (which was always
1455 broken) and the Python related stuff (still not fixed).
1457 2004-06-24 Jean-Pierre Roux
1458 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1459 FIX : Test/TestReadWrite now iterates on all the file names
1460 (instead of infinite loop)
1461 ENH : Test/TestWriteRead now iterates on all the file names
1463 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1464 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1466 2004-06-24 Jean-Pierre Roux
1467 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1468 when SamplesPerPixel =3
1469 - now Write is no longer confused by
1470 'BitsAllocated = 12" and 'BitsStored=12"
1471 - "UN" value representation Elements are now written correctly
1472 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1473 ENH : - now gdcmHeader has its own Write methods
1474 (in order to split the job that has not to be done
1477 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1478 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1479 loop on the same image until memory went out.
1480 Note: this means we still have gobs of memory loss in PrintDocument
1481 * src/gdcmDocument.cxx: fixes problem on parsing on file
1482 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1484 2004-06-24 Jean-Pierre Roux
1485 FIX : Write - All the Sequences and Sequence Item are now written
1486 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1487 is added a the end, when necessary.
1488 - A lot of brain-damaged images, that were read correctly are
1489 now written correctly
1490 - length compatible BinEntry are now loaded correctly
1491 (even for odd groups)
1492 Note : only Explicit Value Representation was checked.
1493 (question : is implicit VR really necessary for gdcm ?)
1495 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1496 * DEVELOPPER: added a proposition of coding style.
1497 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1500 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1501 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1502 Use the gdcmDocEntry::Print() and Write() instead.
1503 * src/gdcmDocument.cxx: bug fix.
1505 2004-06-22 Jean-Pierre Roux
1506 FIX : gdcmDocument.cxx
1507 - Now we do recognize the JpegLossLess format (there was a misstyping in
1508 code 'beautyfication' :-(
1509 - Now we automaticaticaly load the Luts, if any
1511 2004-06-22 Jean-Pierre Roux
1512 In order : to write Sequences, whatever their imbrication level,
1513 : to allow user to create his own Sequences
1514 a lot of modif where necessary (adding, moving, or virtualising methods)
1516 WARNING : save your own sources *before* cvs up !
1519 ADD virtual void Write(FILE *fp, FileType filetype);
1522 ADD virtual void Write(FILE *fp, FileType filetype);
1523 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1526 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1527 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1528 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1529 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1530 ADD std::string GetEntryByName(TagName name);
1531 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1533 std::string vr = "unkn",
1534 std::string fourth = "unkn",
1535 std::string name = "unkn");
1536 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1537 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1538 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1539 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1540 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1541 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1542 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1543 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1546 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1547 ADD virtual std::string GetEntryByName (TagName tagName);
1548 ADD virtual std::string GetEntryVRByName (TagName tagName);
1549 REM virtual bool Write(FILE *, FileType);
1550 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1551 FILE *_fp, FileType type);
1552 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1553 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1554 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1555 REM virtual std::string GetEntryByName (std::string tagName);
1556 REM virtual std::string GetEntryVRByName (std::string tagName);
1557 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1558 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1559 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1561 std::string vr = "unkn",
1562 std::string fourth = "unkn",
1563 std::string name = "unkn");
1564 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1565 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1566 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1567 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1570 ADD virtual void Write(FILE *fp, FileType filetype);
1573 ADD virtual void Write(FILE *fp,FileType filetype);
1576 ADD virtual void Write(FILE *fp, FileType filetype);
1577 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1578 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1579 REM std::string GetEntryByName(TagName name);
1582 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1584 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1585 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1586 The default constructor invoked by the line
1587 gdcmHeader *f1 = new gdcmHeader( header );
1588 was gdcmHeader::gdcmHeader(bool) instead of the expected
1589 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1590 Hence the parsing wasn't executed... See also below.
1591 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1592 as explicit constructor didn't do the trick to fix the above problem.
1593 Could anyone explain why ?
1594 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1595 properly calls gdcmValEntry::Print() (that was weed out from
1596 code related to gdcmBinEntry).
1598 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1599 * In order to fix memory leaks:
1600 - Test/TestWriteSimple.cxx: added cleaning of free store through
1602 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1603 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1604 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1605 (through the call to ::AddDicomDirMeta()) or the destructor
1606 would crash when deleting uninitialized ::metaElems].
1607 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1608 - src/gdcmDocument.cxx:
1609 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1610 from dynamic stores.
1611 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1612 was causing memory leaks.
1613 - src/gdcmSQItem.cxx:
1614 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1615 cleanly handled with polymophism: sorry but my milage is low).
1616 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1617 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1618 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1619 This avoids SegFaulting.
1620 - src/gdcmSQItem.h: coding style.
1622 - Test/TestWriteSimple still severely sucks. The output image content
1623 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1624 damaged when displayed with vtkgdcmViewer.
1625 - on memory leaks: TestWriteSimple leaks really less (see entry
1626 of 2004-06-18 in Changelog file for the call to valgrind).
1627 - on segfaults: ctest now passes all the tests but one (no more
1629 * Erroneous leading white fix:
1630 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1631 white[s] (as opposed to from >> xxx, that removes it [them].
1632 - src/gdcmTS.cxx: ditto.
1633 - gdcmPython/testSuite.py: dirty related kludge removed.
1634 * src/*: remaining references to gdcmParser removed.
1635 * src/*[cxx|h]: added copy[way]left header.
1638 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1639 * In order to fix writing of dicom files:
1640 - Test/TestWriteSimple.cxx: a simpler example of writing.
1641 - Test/CMakeLists.txt changed accordingly.
1642 - src/gdcmDocument.cxx:
1643 -- The destructor now recursilvely removes potential sequences.
1644 -- Bug fix in ::IsJPEG2000()
1645 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1646 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1648 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1649 to only declared) and build on top of
1650 ::GetDocEntryByNumber(guint16, guint16).
1651 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1652 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1653 for usage in destructor and treatement of promotion in
1654 ::ReplaceOrCreateByNumber().
1655 - src/gdcmSQItem.cxx: destructor should better handle his job.
1656 Test/TestWriteSimple now runs (or at least it DOES something).
1657 * We can now start hutting memory links. A good starting point is:
1658 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1659 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1660 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1662 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1663 * Valgrind note: after Mathieu Malaterre teached me how to read
1664 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1666 Using gcc, you can force the STL to use malloc and to free memory as
1667 soon as possible by globally disabling memory caching.
1668 With 3.2.2 and later, you should export the environment variable
1669 GLIBCPP_FORCE_NEW before running your program.
1670 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1671 simply vanish (it is still not clear to me, whether this means that
1672 STL std::string leaks or if valgrind believes it leaks...).
1673 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1674 running bin/gdcmTests makeDicomDir):
1675 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1676 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1678 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1679 SegFaulting (I drowned in DicomDir related code when trying to
1680 understand why the list is empty...).
1681 * src/gdcmDocument.h: first BSD license header try.
1682 * Doc/License.txt added.
1684 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1685 * src/gdcmDocument.[h|cxx]:
1686 - Clean up of the Transfer related predicates. They are now all based
1687 on new method isGivenTransferSyntax, that (should) handle properly
1688 the padding problem.
1689 - general clean up, simplification, and coding style.
1690 - Specific clean up of Parse7FE0() (umproperly named actually).
1691 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1693 2004-06-14 Jean-Pierre Roux
1695 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1696 - fix the display of SQItem ordinal number
1697 - add the GetSQItemByOrdinalNumber method
1698 - remove some useless never written private methods
1700 2004-06-14 Jean-Pierre Roux
1702 - adding a constructor taking a gdcmDocEntry as an input param
1703 - ReplaceOrCreateByNumber now returns :
1704 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1705 a gdcmValEntry * if a string value is passed as a param
1707 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1708 according to the param type (no longer sets a gdcmDocEntry)
1709 - GetValEntryByNumber, GetBinEntryByNumber added
1710 - NewValEntryByNumber and NewBinEntryByNumber added
1712 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1714 - GetSQItemNumber and SetSQItemNumber added, to provide
1715 a (relative) Item identier inside a given Sequence
1716 \warning : some pb remaining around this number
1718 - AddEntry now takes the Item Number as a param
1720 - adding a constructor taking a gdcmDocEntry as an input param
1722 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1723 * Memory leak hunt with the following command:
1724 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1725 --show-reachable=yes gdcmTests PrintDocument
1726 It looks like many (all?) leaks are due to the STL (or a bad usage
1727 of the STL. The lines producing the leaks now have a comment with
1728 a "MEMORY LEAK" tag: you can retrieve them with
1729 grep "MEMORY LEAK" src/*
1730 Here are two typical examples which I can't help fixing:
1735 char * test = "babo";
1736 name = test; //// <--- valgrind detects 960 bytes lost in
1737 //// call to std::string::operator=(char const*)
1738 name.clear(); //// Doesn't help !
1746 std::cout << "Type a bunch of characters followed by RETURN: ";
1747 getline(std::cin, line); //// <--- valgrind dectects a loss
1748 //// of 1320 bytes in call to
1749 /// std::basic_istream<>& std::getline<>
1755 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1756 * src/gdcmHeader.[cxx|h]:
1757 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1758 and related, moved away to gdcmDocument.
1759 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1760 the corresponding protected accessors of inherited class
1761 gdcmDocument, removed ! As a consequence gdcmFile had to be
1762 declared friend of class gdcmDocument (see below).
1763 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1764 - Clean up of undefined or unused methods.
1765 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1766 account the changes to gdcmHeader.h).
1767 * src/gdcmDocument.h:
1768 - gdcmFile is now a friend class (in order to take into account the
1769 changes to gdcmHeader.h).
1770 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1771 (see changes to gdcmHeader.h).
1772 - Accessors (reading on the form GetEntry*) are now public.
1773 - Clean up of undefined or unused methods.
1774 * src/gdcmDocument.cxx:
1775 - adaptation to changes to gdcmDocument.h
1776 - ::OpenFile now writes a verbose message when file cannot be opened.
1777 - some std::string properly set to VRKey
1778 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1779 references to gdcmDocument.
1780 * Test/TestFindTags.cxx: changed accordingly to above changes.
1781 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1782 cvs repository gdcmData.
1784 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1785 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1786 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1787 conflicts with gdcmValEntry::voidArea.
1788 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1789 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1790 Value representation between StringRepresentable and BinaryRepresentable.
1791 * src/gdcmDocument.cxx:
1792 - method ParseDES: proper indentation restored and usage of
1793 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1794 - method LoadDocEntry: the fingerprint left in the SetValue() of
1795 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1796 removed. Reverting to previous code segment with the proper
1797 dynamic_cast< gdcmValEntry* >.
1798 Note: this was (partially) breaking the python test suite
1799 (gdcmPython/testSuite.py) that made usage of the above
1800 fingerprint to check presence of "Pixel Data".
1801 * src/gdcmDocEntry.h: coding style.
1802 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1803 now taken into account.
1804 * gdcmPython/gdcm.i: adaptation to the new internal representation
1805 of gdcm (exit gdcmParser, hello gdcmDocument).
1806 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1808 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1809 anymore, but instead prints the loaded Python dictionary.
1810 * .... alas, the python testSuite is still broken.
1812 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1813 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1815 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1816 * src/gdcmUtil.h : export methods
1818 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1819 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1821 * Initial addition of automatic python testing
1822 * Initial addition of automatic image comparison
1824 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1825 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1826 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1828 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1829 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1830 * Test/ShowDicom.cxx : bug fix for msvc compilation
1831 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1833 2004-05-04 Jean-Pierre Roux
1834 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1835 new concepts (and new classes) :
1836 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1837 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1838 - Sequence Doc Entries (gdcmSeqEntries)
1839 a Sequence is composed of Items.
1840 Each item is a set of Doc Entries (this is recursive)
1841 The non uniqueness of the 'Dicom tag' is due to this recursivity
1842 (never taken into account)
1843 Our unability to add a new 'entry' in the header
1844 at the proper location (neither in the H-Table (map or multimap),
1845 nor in the Chained List is also due to this recursivity.
1846 Don't try, right now, to use/modify/compile these new sources :
1847 nothing is finished.
1848 We just commit all the stuff, 'as is', in order not to loose it.
1850 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1851 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1853 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1854 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1855 file prefix (SetFilePrefix)
1857 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1858 * Add a new test: ShowDicom, for now this is just the c++ version of
1859 checkRead.sh, later it will be able to compare the image read against a
1861 * Replace the DEBUG on the stack with a global entry in cmake interface:
1862 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1864 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1865 * Add an example subdir, with a real example on how to read + write a
1868 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1869 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1870 * Doc/CMakeLists.txt: the main page is now properly differentiated
1871 between the developper and user version.
1872 * Doc/doxygen.config.in: dropped search related obsolete flags
1873 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1875 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1876 * DEVELOPPER: added some helpfull comments for compile/test/install
1879 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1880 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1881 src directory, now generated in the build dir.
1882 2. Tests as mentionned smarter
1884 4. Add a new method in gdcmDict that return the PubDict by name
1885 this is interesting for 3rd party lib like ITK,
1886 where we could set the institution name / patient name...
1888 * ENH: 1. Now the test suite is working for real
1889 2. All binaries are now output in the gdcm-bin directory
1890 (this was not true before)
1892 2004-04-28 Jean-Pierre Roux
1893 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1894 SeQuence indented printing of Dicom Header.
1895 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1896 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1897 Computation of SQDepthLevel is now part of gdcmHeader constructor
1898 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1899 tree-like structure of a Dicom Header.
1900 * FIX Test code cleaning
1902 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1903 * ENH: Adding automatic testing
1904 1. Need a DartConfig.cmake to submit to public
1905 2. Add a test driver gdcmTest.cxx
1906 3. gdcmTestMain, an helper for the main test driver gdcmTest
1907 4. Files in Test don't have a main anymore, this becomes interesting
1908 when we add more and more tests, thus dsw don't have to load
1910 * ENH: Adding a GDCM_DATA_ROOT for testing
1911 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1912 one file instead of seven + some small cleanup
1914 2004-04-22 Jean-Pierre Roux
1915 * ENH Minor changes to the Print() methods.
1916 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1917 Header printing. Example given with :
1918 > PrintHeader fileName 2 new
1919 (SQ based tree-like structure still to be done for the Header ...)
1921 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1922 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1923 1. I have added some unsigned where needed
1924 2. Some function parameter not used -> (void)
1925 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1926 4. g++ don't like character '\' in comment
1927 5. #define jpeg_create_decompress jCreaDecompress
1928 this really need to be fixed
1929 6. virtualize destructor of gdcmObject ... leakage
1930 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1931 this also really need to be fixed
1932 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1933 remove compression file
1934 (as we only do decompression, right ?)
1935 * ENH: Change malloc/calloc/free with c++ equivalent
1937 2004-04-21 Jean-Pierre Roux
1938 * FIX gdcmHeaderHelper::GetXSpacing
1939 when a single value is found (bug ?), xpacing is now
1940 defaulted to yspacing
1942 2004-04-19 Jean-Pierre Roux
1943 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1944 * ENH add parameters :
1945 bool exception_on_error = false,
1946 bool enable_sequences = false,
1947 bool ignore_shadow = false
1948 to the gdcmFile constructors to be full gdcmParser compliant
1949 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1950 to allow reading of PAPYRUS 3.0 files
1952 2004-04-06 Jean-Pierre Roux
1953 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1955 2004-04-02 Jean-Pierre Roux
1956 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1957 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1958 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1960 2004-03-30 Jean-Pierre Roux
1961 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1962 for ACR file, written out as DICOM files (hope so...)
1964 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1965 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1966 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1967 moved to base class gdcmParser and only the specialisation is kept
1969 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1970 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1971 already does the job.
1972 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1973 (to be consistent with gdcmParser::WriteEntries).
1975 2004-03-30 Benoit Regrain
1976 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1977 upate of the object's instance. It's passed to 2 in the unfavorable
1978 case : one in the ExecuteInformation, one in the ExecuteData
1980 2004-03-29 Jean-Pierre Roux
1981 * ENH : Check on file type to be written moved
1982 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1983 * FIX : gdcmObject::ResetBoundaries now stops properly
1984 when end-of-list is reached
1985 : gdcmVersion modified (as Benoit Regrain asked)
1987 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1988 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1989 * src/gdcmUtil.cxx: added forgotten iostream include.
1990 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1991 equivalent to ExplicitVR in existing code).
1993 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1994 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1995 now contains all the gdcmGlobal related code.
1996 * minor coding style and doxygenation changes.
1998 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1999 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2000 now contains all the Debug related code.
2001 * minor clean-up of includes in src/*.cxx
2002 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2003 CreateCleanString) removed.
2004 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2005 * Doc/DoxyMainPageUser.txt added.
2006 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2007 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2008 src/gdcmDirList.cxx)
2010 2004-03-24 Jean-Pierre Roux
2011 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2013 2004-03-23 Jean-Pierre Roux
2014 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2015 big endian made volumes
2016 * ENH Now gdcmParser constructor and destructor are protected to forbid
2017 end user to instanciate class gdcmParser
2018 (only gdcmHeader and gdcmDicomDir are meaningfull)
2020 2004-03-22 Benoit Regrain
2021 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2022 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2023 gdcmSerie to gdcmDicomDirSerie
2025 2004-03-19 Jean-Pierre Roux
2026 * ENH Now the tree-like structure describing a DICOMDIR comming from
2027 an already existing DICOMDIR file is consistent with
2028 the home-made tree-like structure build ex-nihilo
2029 or build from the files held (recursively) in a Directory
2030 functions gdcmDicomDir::CheckBoundaries()
2031 gdcmObject::SetBoundaries() added
2033 2004-03-17 Jean-Pierre Roux
2034 * REM (Eric Boix bug) : removal of meaningless
2035 gdcmDicomDirImage::NewImage function.
2036 * FIX now file names and directory name are written properly in the
2038 * FIX now gdcmDicomDir constructor may be call without any trick
2041 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2042 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2043 of gdcmDicomDirImage::NewImage as empty function.
2045 2004-02-28 Jean-Pierre Roux
2046 * ENH add gdcmDicomDir:NewPatient
2047 add gdcmDicomDirPatient:NewStudy
2048 add gdcmDicomDirStudy:NewSerie
2049 add gdcmDicomDirSerie:NewImage
2050 to allow making gdcDicomDir object.
2051 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2052 (as opposite to the gdcmHeader chained list)
2054 2004-02-11 Benoit Regrain
2055 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2056 when using from python
2058 2004-02-10 Benoit Regrain
2059 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2060 * FIX : in gdcmDicomDir when the directory is empty
2061 * ENH : add callback and methods to get the progression of dicomDir
2064 2004-02-06 Jean-Pierre Roux
2065 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2066 - GDCM_META added to gdcmDicomDirType
2067 - class gdcmMeta created
2068 * ENH : - A brief summary is now displayed at the beginning of
2069 'testDicomDir' to help disaster magnitude estimation
2070 * REM : Now useless Test/explDICOMDIR.cxx
2072 2004-02-05 Benoit Regrain
2073 * ENH : add methods in gdcmObject to get the hash table or the list of
2075 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2076 * FIX : wrapping python for TagHeaderEntryHT
2078 2004-02-04 Benoit Regrain
2079 * FIX : even length for some strings when writting the dicom dir
2080 * FIX : sort the images in the dicom dir
2081 * FIX : Bug fix for python use of dicom dir
2082 * ADD : a python demo
2084 2004-02-04 Jean-Pierre Roux
2085 * FIX : Final solution (?) for icone embedded images
2086 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2087 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2088 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2089 gdcmData/gdcm-MR-SIEMENS-16.acr1
2090 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2091 to make full checking easier
2093 2004-02-04 Benoit Regrain
2094 * FIX : WriteEntries : coding style & logic in parameters
2095 * FIX : Set the elements to create the DicomDir in a dictionary file
2097 2004-02-03 Benoit Regrain
2098 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2099 * gdcmDicomDir : add the load of directory
2100 * Bug fix and print add-on
2102 2004-02-03 Jean-Pierre Roux
2103 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2104 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2105 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2106 * FIX gdcmParser.cxx : 'group length' elements are now considered
2107 as integers, even for shadow groups, when file is Implicit VR
2109 2004-02-02 Jean-Pierre Roux
2110 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2112 of the last synonym :-(
2113 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2115 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2116 * FIX taking into account the possible 7fe0,0010 multiplicity
2117 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2118 to allow removal of references to 7fe0,0010, to deal with
2119 ACR-NEMA images, when 0028,0200 is meaningfull
2121 2004-01-31 Jean-Pierre Roux
2122 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2123 no longer writes 'Un' on disk
2124 * FIX SQ elements with actual length are now dealt with corectly
2125 * FIX gdcmFile::WriteBase make the difference, for color images, between
2126 the length (for Palette expanded images)
2127 and Raw Length (non expanded image + Palette)
2128 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2129 (that broke Write). Replaced by UL.
2130 Aware user will reload the field if he
2131 thinks it's necesssary
2133 2004-01-30 Jean-Pierre Roux
2134 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2135 when 'dirty Acr' is found, to be compliant with the new
2136 IsReadable() methods.
2138 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2139 (no DOUBLE images in kosher DICOM,
2140 but so usefull for people that miss them ;-)
2142 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2143 DICOMDIR related utilities (not checked as Windoze compliant)
2145 2004-01-28 Jean-Pierre Roux
2146 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2148 2004-01-27 Jean-Pierre Roux
2149 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2150 to allow skipping the shadow elements, to save memory space.
2151 The TRUE value for this param has to be used
2152 with a FALSE value for the 'enable_sequence' param.
2153 ('public elements' may be embedded in 'shadow Sequences')
2154 * gdcmHeader methods now deal with 'embedded icones images' in the header
2155 (even when an 'icone image sequence' is announced by the
2156 element (0x0088,0x0200), but there is NO icone at all ...
2158 * gdcmHeader sometimes Image Location value doesn't follow
2159 the supposed processor endianity (see gdcmData/cr172241.dcm).
2162 * gdcmHeader add the method
2163 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2164 to get *all* the Header Entries with the same tag.
2165 GetHeaderEntrySameName is probabely *useless*
2166 (no meaning : Name is *not* an identifier within the Dictionary)
2168 2004-01-26 Benoit Regrain
2169 * Bug fix in the print of hexadecimal representations. Remove long fields
2170 in the print and add a third level of print to print them
2172 2004-01-23 Benoit Regrain
2173 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2174 * Bug fix on test suite after remove the strip made on not string fields
2175 * Split the IsReadable method between gdcmParser which test that the file
2176 is dicom and gdcmHeader which test that it's an image file
2178 2004-01-22 Benoit Regrain
2179 * DicomDir : clean code, add methods, set variables in protected or private
2180 * gdcmUtil : bug fix for the clean string method
2182 2004-01-19 Benoit Regrain
2183 * Add the use of shadow dictionaries
2184 * bug fix and coding style
2186 2004-01-19 Benoit Regrain
2187 * src/gdcmFile.cxx : bug fix concerning the close of file
2188 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2189 * Add the update of header entries using the shadow library
2191 2004-01-19 Benoit Regrain
2192 * removal of file gdcmHeader2.cxx
2193 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2194 inheriting from gdcmParser. This split is to prepare the integration
2195 of dicom dir parsing
2196 * bug fix under python
2198 2004-01-16 Jean-Pierre Roux
2199 * REM removal of class gdcmHeaderEntrySet
2200 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2201 * ADD add file gdcmHeader2.cxx
2202 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2204 2004-01-15 Benoit Regrain
2205 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2206 entries created while parsing the header. Thus, they will be destroyed
2207 when the gdcmDictSet will be destroyed
2208 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2211 2004-01-15 Benoit Regrain
2212 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2213 made a fatal error because of the memory release at the end of program.
2214 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2215 some memory and vtk seems to have some problems with that.
2216 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2218 2004-01-14 Benoit Regrain
2219 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2220 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2221 * src/*.[h|cxx] : make changes due to class name changes
2222 * gdcmPython/demo/*.py : bug fix due to method names
2224 2004-01-13 Benoit Regrain
2225 * src/*.[h|cxx] : coding style
2226 * vtk/*.[h|cxx] : coding style
2228 2004-01-13 Benoit Regrain
2229 * gdcmPython/testSuite.py : test the readable flag of file for tests
2230 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2231 It's lied to the stl compilation by MSVC (windows, always windows...)
2232 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2234 2004-01-12 Benoit Regrain
2235 * src/*.h : add comments
2236 * src/gdcmDictSet.h : set the method BuildDictPath in public
2237 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2238 directly setted in the source code
2239 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2242 2004-01-09 Benoit Regrain
2243 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2244 * setup.py : use a reference to gdcmVERSION
2246 2004-01-07 Benoit Regrain
2247 * Modification to compile with the distutils.
2250 2003-12-10 Benoit Regrain
2251 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2252 can use a gdcmHeaderHelper to load data
2253 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2254 made in the source code
2256 2003-12-10 Benoit Regrain
2257 * Update Windows projects and .cvsignore files
2259 2003-11-12 Jean-Pierre Roux
2260 * ENH gdcmHeader constructor has one more parameter (default value : false)
2261 that allows the user to 'go inside' the SeQuences only
2263 gdcmElValSet:Print takes it into account
2265 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2266 * ENH: Update gdcmPython/CMakeLists
2267 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2268 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2270 2003-11-10 Jean-Pierre Roux
2271 * FIX : gdcmHeader::LoadElements is now based
2272 on the ListTag listElem member,
2273 not longer on the TagElValueHT tagHt member
2274 * ENH : PrintPubElVal shows (temporarily) both results,
2275 with the tagHt member and the listElem member.
2276 (it's easier to 'see' the problems when using Printheader)
2278 * FIX : old private member LgrElem is now splitted into
2279 ReadLength : Length actually found on disk (updated only
2280 if bug fixing is necessary), for internal
2282 UsableLength : Updated by FixFoundLength, to fix a bug
2283 or to allow Parser going on.
2284 Will allow to re-write a kosher header when a SeQuence
2285 with a length (not 0000) is found
2286 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2287 because gdcmElValSet::Add does not update ListElem
2290 2003-11-07 Jean-Pierre Roux
2291 * FIX misstyping in Transfert Syntax name table
2292 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2293 when they have an actual length (not 0000 nor FFFFF)
2294 (Nobody should care of it, but DICOMDIR explorers)
2296 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2297 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2299 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2300 * ENH: vtkGdcmReader now supports LUT !
2301 (vtkgdcmViewer for now is not able to use them though)
2303 2003-11-05 Jean-Pierre Roux
2304 * in testSuite.py : new files names for checking the package
2305 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2306 that returns the pixel area size to the *aware* (vtk) user
2307 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2309 2003-11-05 Benoit Regrain
2310 * in testSuite.py : Modify the rules for checking the paths
2311 : Explicit error messages
2312 * in __init__.py : Related modif
2314 2003-11-03 Jean-Pierre Roux
2315 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2316 to be used by aware (vtk) users that want to manage
2317 LUT (and no to turn the PALETTE image into an RGB pixels one)
2318 * GetPixelType now returns 8U for 24 Bits images
2319 (vtkGdcmReader compliant)
2321 2003-10-31 Jean-Pierre Roux
2322 * Removal of *all* gdcmData images and add them again
2323 in order to loose the 'history' of un-anonymised images
2325 2003-10-31 Jean-Pierre Roux
2326 * RMV : removal of useless jBitsInJsample.h
2327 for both 8 and 12 Bits JPEG Lossy Libraries
2329 2003-10-31 Jean-Pierre Roux
2330 * ENH : Add the functions gdcmFile::GetImageDataRaw
2331 gdcmFile::GetImageDataIntoVectorRaw
2332 that act as GetImageData and GetImageDataIntoVector
2333 except the making of an RGB Plane from Gray Plane + LUT
2334 Intended to aware (vtk) users who know how to manage
2337 GetLUTRGBA return a R,G,B,A LUT if any
2338 lgrTotaleRaw gives the 'Raw' length
2339 GetImageDataRaw returns the gray Plane
2340 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2341 (They stay Grey, just like with other Dicom viewers :-(
2343 2003-10-30 Jean-Pierre Roux
2344 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2346 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2347 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2348 being coherents dicom files.
2350 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2351 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2353 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2354 * ENH: Two steps is necessary to please VC++ compiler...
2355 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2356 * ENH: Add include dir to medcon lib
2357 * FIX: only one function is being exported for now !
2358 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2360 2003-10-29 Jean-Pierre Roux
2361 * adding gdcmHeader::GetLUTRGBA
2362 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2363 --> Mathieu, the modif u're waiting for is not yet committed
2364 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2366 2003-10-27 Jean-Pierre Roux
2367 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2368 00191113.dcm DermaColorLossLess.dcm
2369 MxTwinLossLess.dcm RadBWLossLess.dcm
2370 * ENH: For version prior to vtkImageViewer2 -r 1.19
2371 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2373 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2374 * Removal of ido stuff in CMakeLists.txt
2376 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2377 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2378 * FIX: remove a call to ->Modified ... see comments
2379 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2381 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2382 * FIX: Problem with path for libvtkgdcmPython
2383 * ENH: Try adding a search script for python site-package
2384 * RMV: Remove some file from medcon lib that are not necessary
2385 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2386 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2387 * FIX: More pragma disable fro VC++,
2388 I don't think I break something as it is also disable in VTK/ITK.
2389 But it fasten debug compilation time.
2391 2003-10-23 Jean-Pierre Roux
2392 * gdcm now deals with 16 Bits Run Length Encoded images
2393 (they are compressed as 2 planes images,
2394 one for the high Bytes, the other for low Bytes)
2396 2003-10-22 Jean-Pierre Roux
2397 * Now CheckRead takes into account :
2398 - the bugged 'Leonardo' Siemens images
2399 - the XA images, sent thru the burning VPRO station
2400 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2403 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2404 * FIX: When copying a Makefile.am to CMakeLists.txt
2405 one should remove the '\'
2407 2003-10-22 Jean-Pierre Roux
2408 * in gdcmData adding a bugged 'Leonardo' Siemens image
2409 (wrong lengths in header)
2410 OK with gdcm, KO with the other viewers :-)
2411 * add a GE dlx XA image, thru the VEPRO burning station
2414 2003-10-21 Jean-Pierre Roux
2415 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2416 for a brutal checking of vtkgdcmViewer compliance
2418 2003-10-21 Jean-Pierre Roux
2419 * add the files for 'xmedcon' Jpeg Lossless library
2420 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2422 2003-10-21 Jean-Pierre Roux
2423 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2425 2003-10-21 Jean-Pierre Roux
2426 * garbage Siemens 'Leonardo' images dealt with
2427 (the patch is easy to remove)
2428 * cosmetic changes to avoid warnings
2430 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2431 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2432 no need to press 'r' now.
2434 2003-10-20 Jean-Pierre Roux
2435 * upgrade of checkRead.sh checkWrite.sh according
2436 to new Jpeg Lossless decompressor
2437 * add US.3405.1.dcm, a genuine RGB medical file ...
2438 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2439 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2441 2003-10-15 Jean-Pierre Roux
2442 * general anonymisation in gdcmData
2443 * adding the 'color files' from
2444 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2445 * adding some well knowed bugged-header images
2446 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2447 waiting for their inclusion in Python testsuite
2449 2003-10-15 Jean-Pierre Roux
2450 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2451 no longer seg faults when file is not found
2453 2003-10-14 Jean-Pierre Roux
2454 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2457 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2458 * TODO: *.in file to genereate a UseGDCM later
2460 2003-10-14 Jean-Pierre Roux
2461 * Some supposed-to-be Dicom Images have no preamble.
2462 OpenFile takes it into account
2463 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2464 * Missing elements added in dicomV3.dic
2465 (just to be affraid : have a look at
2466 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2467 and do it again next year ;->
2469 2003-10-13 Jean-Pierre Roux
2470 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2471 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2472 But there are NOT. It's fixed !
2474 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2475 * FIX: "jpeglib.h" was not found on VC++
2476 * FIX: vtkgdcm was not being installed
2478 2003-10-10 Jean-Pierre Roux
2479 * ENH : OpenFile closes the file if it *really* doesn't look like
2480 an ACR-NEMA / DICOM one.
2481 * FIX : testWrite no longer writes an empty file if the source file
2482 is not gdcm Readable
2483 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2486 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2487 * FIX: CMake generate now documentation
2488 * ENH: out of source doc build !
2489 * ENH: Generate both user and dev documentation
2490 * ENH: Should work on windows too
2491 * ENH: Only one doxygen config.in file is needed
2492 * FIX: make install should be ok now on ùnix plateform
2493 * FIX: PATH to dictionary was wrong (missing /)
2494 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2496 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2497 * vtkGdcmReader is now able to read rgb dicom file.
2498 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2499 * added a gdcmViewer to vtk test, use mouse to control
2500 window level & window width
2502 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2503 * CMake-ification of gdcm, we have now two build system
2504 * FIX: on cygwin Wsock32 doesn't exist
2505 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2507 2003-10-06 Emanuel Ollart
2508 * FIX : compilation process wad broken.
2509 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2511 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2512 * change gdcmViewer -> vtkgdcmViewer
2513 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2515 2003-10-06 Jean-Pierre Roux
2516 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2517 ( e.g : well known GE images with a wrong elem length,
2518 : Philips MRI Images with a wrong Huffman table)
2519 * still to be done : allow the reading of bugged LEONARDO Siemens images
2521 2003-10-03 Jean-Pierre Roux
2522 * Odd length strings are padded with '\0' (not with spaces,
2523 to remain compliant with already defined strings,
2524 like Transfert Syntax UID and others)
2526 2003-10-03 Jean-Pierre Roux
2527 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2528 to allow displaying RGB images (not only by affim ;-)
2530 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2531 * vtkGdcmReader is now able to read rgb dicom file.
2532 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2534 2003-10-03 Jean-Pierre Roux
2535 * A few nasty patches to allow the reading of a lot of nasty images
2536 ( e.g : well known GE images with a wrong elem length,
2537 : Philips MRI Images with a wrong Huffman table)
2538 * still to be done : allow the reading of bugged LEONARDO Siemens images
2540 2003-10-03 Jean-Pierre Roux
2541 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2543 2003-10-03 Jean-Pierre Roux
2544 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2545 to allow displaying RGB images (not only by affim ;-)
2547 2003-10-03 Jean-Pierre Roux
2548 * gdcmFile::GetImageDataIntoVector now
2549 - deals with MultiFrames MultiFragments Run Length Encoded files
2550 - deals with YcBcR (YBR_FULL) files
2551 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2552 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2554 (no sample found :-(
2556 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2557 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2558 Two reasons: - clear things
2559 - third parties acces gdcm through header files, so won't
2560 suffer anymore VC++ complains
2562 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2563 * add argv[1] in testvtkGdcmReader.cxx
2566 2003-09-24 Jean-Pierre Roux
2567 * The lines are now eigthy characters long.for
2568 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2570 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2571 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2572 char* to std::string. Thus, the use of strdup becomes useless. (see
2573 previous commis of Malaterre)
2574 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2575 before the last Malaterre's commit.
2577 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2578 * This commit should fix the Debug building under VC++, the problem
2579 was mainly a mixture of debug and release lib being loaded at startup.
2580 * I also remove a depency to a specific C function: strdup. Because I had
2581 to force the link to msvcrtd (whereas strdup is in libc).
2583 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2584 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2585 located in the gdcmCommon.h file. All use of reference of tha has been
2586 changed to now use the variable GDCM_UNFOUND.
2588 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2590 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2591 Dicom dictionary. The test suite can now be run again. Note:
2592 I'm note very happy with the " (RET)" changes. I believe this
2593 RETAINED comment should be dropped when parsing the dictionary.
2594 - PACKAGER corrected
2596 - AUTHORS updated and now in alphabetical order
2597 * Makefile.am now exports gdcm.dsw for Windoze users.
2599 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2600 * cygwin complains about missing std:: in subdir Test/
2602 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2603 * remove some methods that are now in gdcmHeaderHelper
2605 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2606 * vtkGdcmReader set spacing and origin correctly
2608 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2609 * Fix a few delete/delete[] mismatch
2611 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2612 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2613 interpretation to data given by gdcmHeader. For instance there are
2614 heuristics to get informations (look at different places).
2615 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2616 sorting DICOM images based on different strategies.
2617 * modified Makefiles accordingly.
2619 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2620 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2621 when building in debug mode
2622 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2623 src/win32/gdcmdll.dsp
2624 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2626 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2627 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2630 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2631 * src/win32/libgdcmjpeg12.dsp was not dos format
2632 * src/win32/libgdcmjpeg12.dsp :
2633 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2634 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2636 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2637 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2639 * src/gdcmFile.cxx : bug fix in affectation type
2640 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2641 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2642 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2643 symbols... future problem ?
2645 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2646 * src/win32/libgdcmijpeg12.dsp was missing
2647 * modified gdcm.dsw accordingly
2649 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2650 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2652 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2653 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2654 commit of JPR (before his hollidays to facilitate our work).
2655 * setup.py : bug fix in code. Modifications made while the last commit
2656 of JPR. The code hasn't been tested before the commit... it's so
2657 useless to make that (for best programmer that is JPR) !!!
2659 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2660 * tagged the current version as Version0_3 (i.e. version 0.3)
2662 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2663 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2664 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2665 * *.dsp : modifications to use new libgdcmijpeg8 library
2666 * setup.py : bug fix on VTKPATH variable
2667 * PACKAGER : adding all concerning windows
2669 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2670 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2672 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2673 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2674 test suite reported error.
2675 * PACKAGER file added (describes what a packager must do when
2676 packaging a new release).
2677 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2678 * configure.in: upgraded version number to 0.3.0
2679 * fixing build of rpm (through rpm -ta):
2680 - Doc/Makefile.am exports proper doxygen files
2681 - src/jpeg/libijg8/Makefile.am exports the include files.
2683 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2684 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2685 * src/gdcmHeader.h : formatting code
2687 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2688 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2689 We were obtaining error message from vtk. Now, creation of file list
2690 is made in an internal list to prevent this problem.
2691 Bug fix when output is empty.
2692 Bug fix in update of progress value. Previous commit for this was a bad
2694 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2696 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2697 * src/gdcmHeader.h : added method to get the file name
2698 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2699 files. Added method to remove all files on the input
2700 Added FIXME comment concerning the bad parsing of header made by
2701 ExecuteInformation method (in ExecuteData method)
2703 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2704 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2705 when using make instal.
2706 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2707 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2709 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2710 * setup.py : adding include dir of jpeg lib to compile all sources
2711 * */Win32/*.dsp : JPR fix for windows compilation
2713 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2714 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2716 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2717 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2719 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2720 * setup.py is again effective on un*x (takes into account the
2721 addon of the jpeg library)
2722 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2723 * Doc/Doxy* updated (includes above enhancements)
2724 * INSTALL now points to web documentation
2726 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2727 * src/gdcmHeader.h doesn't make unnecessary reference to
2729 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2731 * src/gdcm*.[cxx|h] :
2732 - to allow compilation with gcc 3.x
2733 -- clean up of STL usage (added explicit usage of std::)
2734 -- small fixes on exceptions.
2735 Note: linking not tested !
2736 - clean of doxygen comments to avoid warnings at documentation
2738 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2739 dependent convertion).
2741 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2742 * Clean up of previous JPR garbage commit (not even commented in the
2744 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2745 - moved all jpeg related files from src to src/jpeg/libijg8, with
2746 addition/modification of Makefile.am and configure.in.
2747 - the testSuite is still brain damage (not guilty).
2749 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2750 * WrapVTK.py : modifications to get correctly vtk source files to
2752 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2753 (FileName -> Filename)
2755 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2756 * vtk/vtkGdcmReader.[cxx/h]:
2757 - UpdateProgress method should now be effective
2758 - removed the limitation on having only images loaded (as opposed
2760 - when building a stack of images/volume, a lesser number of
2761 gdcmHeader and gdcmFile instances should be used (hopefully
2762 accelerating things).
2763 - when building a stack of images/volumes, files which are not
2764 loadable (wrong path-filename, wrong permissions on existing file,
2765 or file not parsable by gdcm) are replaced with a black image
2766 in the stack (for the caller to notice the problem).
2768 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2769 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2771 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2772 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2773 between standard library (std) and vtk library (problems are found
2774 under Windows... thanks Windows !)
2776 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2777 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2779 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2781 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2782 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2784 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2785 * When compiling with distutils (see setup.py) the C++ compiler is
2786 called with different flags than the default ones (with automake).
2787 In order to fix all those warning, I compiled gdcm with the command
2788 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2789 and went for warning fixes:
2790 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2791 up from unused variables.
2792 - vtk/vtkGdcmReader.cxx: potential bug fix.
2793 * src/gdcmHeader.h: Doxygen warning cleanup
2795 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2796 * gdcmPython/gdcm.i:
2797 - typemaps correction to take into account the systematic replacement
2798 of "using namespace std" with std:: prefix e.g. std::list,
2799 std::string... (cf changes of 2003-05-21).
2800 - gdcmGlob global variable of type gdcmGlobal (defined in
2801 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2802 exported to Python a as cvar.
2803 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2804 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2805 gdcmDictSet.GetPubDictTagNames() and
2806 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2807 C++ static methods).
2808 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2809 with the above changes.
2811 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2812 * setup.py, manifest.in : bug fix under linux
2814 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2815 * Modification of setup.py to compile vtk part too. Then, we have 2
2816 wrappers which must work with same distutils. For that, we have a
2817 generic distutils in distusiltsWrapping.py ; with :
2818 - build_extWrap class to wrap generically all extensions,
2819 - ExtensionWrap base class for all wrapping extension that contains
2821 - Wrapper interface which wrap sources
2822 + In WrapSwig.py we have extension and wrapper for Swig
2823 + In WrapVTK.py we have extension and wrapper for VTK
2824 * MANIFEST.in : modifications to consider vtk directory and new python
2825 files for compilation
2827 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2828 * Added python wrappers of vtkGdcmReader vtk class (see the
2829 source in vtk/vtkGdcmReader.cxx) :
2830 - vtk/Makefile.am now builds a library
2831 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2832 python library (as opposed to _gdcm.so wich are the python
2833 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2834 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2836 - configure.in has an additional flag --enable-vtk that needs
2837 to be set to enable compilation of vtk related code, that is:
2838 + vtk/vtkGdcmReader.so and
2839 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2840 + gdcmPython/vtkgdcmPython.so (see above)
2841 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2842 be read when compressed or when HighBit + 1 != BitsStored),
2843 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2844 the usage of the python wrapper of vtkGdcmReader vtk class.
2845 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2846 * src/*.[h] all occurences of stl classes are now prefixed with
2847 std::, and all occurences of "using namespace std;" where removed.
2848 This is to avoid pollution of global namespace in included files.
2849 Apparently vtk does not avoid this pitfall: when using both
2850 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2851 collision of various stl members (principally cout...).
2852 * gdcmPython/testSuite.py now cleanly removes temprory generated
2854 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2855 comply with above changes)
2857 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2858 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2859 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2860 vtk data structure (an image Flip was required).
2861 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2862 * cosmetic changes in documentation.
2864 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2865 * src/gdcmHeader.cxx: the constructor no longer exits when an
2866 unexisting file is given as argument.
2867 * The subdirectory Data (containing all the images used for the
2868 test suite) is not part of this repository anymore. A new module
2869 containing those images is now available at
2870 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2871 with the name gdcmData.
2872 All the python scripts (including the package initialisation file
2873 gdcmPython/__init__.py) were adapated to take this change into
2874 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2876 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2877 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2878 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2879 demo of the usage of this class.
2880 Compilation of this vtk part is only done when using the --enable-vtk
2881 at configure (or autogen.sh) stage.
2883 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2884 * More memory link related corrections and documentation fixes.
2886 - maximum info is obtained with a command of the form:
2887 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2888 --show-reachable=yes PrintHeader
2889 - the remaining reachable blocks seem to come from the STL
2890 allocation scheme through the usage of map and list. It looks
2891 like this memory cannot be freed but it is not a memory leak
2892 (in fact further invocation to the STL would recollect the
2893 unused memory allthough it cannot explicitely be freed).
2894 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2895 of displaying an image parsed with gdcm and displayed with VTK.
2896 Note: some images don't seem to work e.g.
2897 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2898 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2899 Allthough this weakens the semantics, it is a ditch attempt to
2900 make gdcm more thread friendly.
2902 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2903 * Memory link hunt (by using valgrind through the command
2904 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2905 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2906 gdcmHeader::_dicom_vr.
2907 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2908 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2910 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2912 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2913 * src/Makefile.am now exports all the necessary include files at
2917 * UpdateGroupLength replaced by new one
2920 * UpdateGroupLength re-written using H-Table
2921 (named UpdateGroupLengthNew untill checks are over)
2923 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2924 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2925 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2927 - gdcmHeader::GetPubElValSet removed.
2928 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2929 UpdateGroupLength, WriteElements, Write.
2930 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2931 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2932 carried the same semantics.
2933 - src/gdcmHeaderIdo.cxx changed accordingly.
2934 - gdcmFile::WriteBase now regroups all the codes from previous
2935 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2936 - enum FileType moved to gdcmCommon.h
2937 * src/gdcmHeader.cxx AddDefault trashed
2938 * gdcmGetXSize added
2939 * getimageDataSize now calls gdcmGetXSize
2940 * Test/*.cxx changed to agree with above changes
2942 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2943 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2944 (to avoid double call by end user).
2945 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2946 by end user, since gdcmHeader::gdcmHeader now handles it.
2948 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2949 * gdcm/Doc many doxygen changes:
2950 - Doxyfile now has two different versions, DoxyfileUsers that generates
2951 the html.users end users oriented documentation and
2952 DoxyfileDeveloppers that generates the html.developper developper
2953 oriented documentation.
2954 - README changed accordingly
2955 - requirement.txt removed (old design info moved to TODO).
2956 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2957 DoxyMainPage.txt, DoxyPython.txt provide more information.
2958 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2959 be updated by simply regenerating the docs with doxygen and copying
2960 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2961 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2962 all the tests in the form "if (<map>.count() >1)" were removed.
2963 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2964 ill-formed documentation sections.
2965 * src/gdcmHeader.cxx: ditto
2967 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2968 * setup.py fixed for un*x (needed macro for stdint.h)
2969 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2970 un*ces with sh-utils test utility.
2971 * gdcmPython/demo/test.py renamed to PrintHeader.py
2972 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2973 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2974 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2975 * src/gdcm*.cxx JPR's bad inclusion fixed.
2977 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2978 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2979 * gdcmPython/demo/test.py changed accordingly.
2981 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2982 * gdcmPython/Makefile.am fixed linking against libstdc++
2983 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2984 * Swig subdir (historical tests of swig version 1.3.17++) removed
2985 * Test/testChangeEntete.cxx some lines commented out in order to make
2987 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2988 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2990 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2991 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2992 hence the user doesn't need this explicit call.
2993 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2994 i.e. LoadElements() call removed.
2995 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2996 - src/Makefile.am declares the proper flag for g++.
2997 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2998 for adding user defined new tags.
2999 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3000 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3001 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3003 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3004 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3005 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3006 src/Makefile.am : the project should properly compile and install
3007 with the autotools, included the python wrappers part.
3008 * gdcm.spec.in : added a spec file for RPM packaging.
3010 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3011 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3013 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3014 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3015 to exported to the environement (see gdcmPython/testSuite.py
3017 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3018 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3019 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3020 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3021 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3023 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3024 * gdcmPython/__init__.py doesn't crash anymore when running in
3025 in InstallMode or PreInstallMode but with an environment given
3026 value of GDCM_DICT_PATH.
3027 * src/gdcmDictSet.[cxx/h] coding style.
3029 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3030 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3031 * src/gdcm.h general comments moved to TODO, and README
3032 * src/gdcm.h should now be seen as a user commodity (including it
3033 should suffice to fully use gdcm). It is nowhere including within
3034 any of the kernel files src/*.cxx and src/*.h.
3036 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3037 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3038 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3040 * src/gdcm*.cxx only include their corresponding include file
3041 (as opposed to gdcm.h)
3042 * gdcmPython/gdcm.i changed accordingly
3043 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3044 the autogen.sh generated "make snapshot" command to work.
3045 * autogen.sh removed history related references to crea package.
3047 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * distutilsSwigCPlusPlus.py work around some swig portability
3051 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3052 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3053 was done in a last ditch attempt to get setup.py _really_
3054 operationnal. The python/gdcmPython layaout add the advantage
3055 of hidding away the python related distutils specific files
3056 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3057 Alas, the src directory was out of scope (i.e. it's relative
3058 position to setup.py was ../src) which made things impossible to
3059 handle (see previous version of python/setup.py). Crossing fingers...
3061 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3062 * python/setup.py now works on Un*x. (harder than I thougth)
3063 * python/distutilsSwigCPlusPlus.py can now have include files
3064 among the list of sources.
3066 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3067 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3068 * modifications in MSVC projects
3070 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3071 * As stated by the first lines of Test/ExceptionAndPython/README, it
3072 looks like we can move back to original usage of exception within
3073 src/gdcm* and hence remove the errno stuff that was introduced
3074 as a quick and dirty fixture of this problem (added to the TODO).
3075 * Doc/Doxyfile configuration file for Doxygen and corresponding
3076 README file for usage added.
3077 * Test/testWrite.cxx added. This new test comes from a split of
3078 test.cxx that is now reverted to its original purpous i.e.
3079 testing the proper parsing of a Dicom related file.
3080 testWrite.cxx concentrates on testing the IO part of gdcm.
3081 * Test/bug1.cxx (containing a bug on WIn32) added.
3082 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3083 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3084 whose purpose is to publish the content of the TagNames of the
3085 Dicom public dictionary were not accessible without an
3086 instance of class gdcmHeader.
3087 - those methods are now static methods of gdcmDictSet and hence
3088 require no instances at all to be invocated.
3089 - within gdcmDictSet this change required to change some method
3090 to class methods (i.e. are now static) among which SetDictPath
3091 (renamed to BuildDictPath) and LoadDefaultPubDict.
3092 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3093 the above changes by calling the new method classes of gdcmDictSet.
3094 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3095 the above to be effective.
3096 * python/gdcmPython: in order to wrap properly the above changes
3097 for Python, swig version now needs to be > 1.3.17.
3098 * python/gdcmPython/Makefile fixed to adapt itself to new
3099 configure/make shema introduced by Johan Montagnat (thanks for the
3100 contribution). Alas this Makefile cannot be turned into a proper
3101 Makefile.am without some heavy changes in the configure.in
3102 (for python dectection).
3103 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3104 now avoids publishing the empty entries.
3106 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3107 * python/setup.py : bug fix concerning install under windows
3108 ExtraPath reused :-P
3109 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3111 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3112 * Dicts/dicomV3.dic : remove double spaces !!!
3113 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3114 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3117 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3118 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3119 method. Doxygenation.
3120 * src/gdcm.h clean up of JPR spurious comments.
3122 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3123 * python/distutilsSwigCPlusPlus.py now properly collects the
3124 shadow classes generated by "swig -c++" (gdcm.py in our case)
3125 when using "python setup.py install".
3126 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3127 reexports the working classes.
3128 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3129 by the classical C errno scheme. This is to prevent an obscure
3130 behavior of the python wrappers when importing wxPython.wx prior
3131 to gdcmPython (which ended up in an abort call). An illustration
3132 of this oddity can be found in the Test/ExceptionAndPython
3133 subdir (see the README file). This problem probably due to
3134 an combination of g++ and dynamic loading.
3135 * added Test/ExceptionAndPython (see above)
3137 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * Changed the layout of the python part to avoid bloating main
3139 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3140 i.e. the distutils arsenal. All the python related stuff is
3141 again in a python subdir, but the package itself is now in
3143 * setup.py was cleaned up:
3144 - pythonIncludePath removed
3145 - python setup.py bdist target is now functional.
3146 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3147 collision with other packages). gdcmPython/demo/*.py changed
3150 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3151 * python subdir moved to gdcmPython (preparation of distutils packaging).
3152 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3153 distutils installer is operational.
3154 * - gdcmPython/__init__.py now properly loads the swig generated
3155 shadow classes (from gdcm.py).
3156 - gdcmPython/demo/*.py changed to import the package gdcmPython
3157 instead of gdcmPython/demo/load.py.
3158 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3160 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3161 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3162 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3163 entries within the associated public Dicom dictionary resp. the same
3164 information but sorted by the fourth field (PAT, IMG, DIR) of the
3166 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3167 are now in the "???" group.
3168 - python/gdcm.i changed accordingly,
3169 - python/demo/printGroupedPublicDict.py added, that gives an example
3170 of the above new functionalities in Python.
3172 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3173 * src/gdcm.h, gdcmHeader.cxx:
3174 - historic references to glib's g_malloc and g_free (#defined)
3175 were definitively removed.
3176 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3177 * src/gdcmElValSet.cxx:
3178 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3179 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3180 - GetElValue(string) renamed to GetElValueByName.
3181 - Added GetElementByName(string).
3182 * src/gdcmHeader.cxx: added
3183 - GetPubElValRepByNumber(guint16, guint16)
3184 - GetPubElValRepByName(string)
3185 - GetShaElValRepByNumber(guint16, guint16)
3186 - GetShaElValRepByName(string)
3187 - GetShaElValByNumber(guint16, guint16)
3188 - GetShaElValRepByName(string)
3189 - GetElValRepByNumber(guint16, guint16)
3190 - GetElValRepByName(string)
3191 - GetElValByNumber(guint16, guint16)
3192 - GetElValRepByName(string)
3193 * Doc/requirements.txt added.
3195 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3196 * Test/Makefile building now depends on the one of libgdcm.so
3197 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3198 pixel data) aware which enables finding the address (offset) of
3199 the pixel data of JPEG encoded DICOM files. This leaves only a single
3200 file in the testSuite whose pixel data address (offset) is unknown.
3201 * python/testSuite.py changed accordingly.
3203 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3204 * VC++ has some strong limitations when working with the STL, as stated
3205 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3206 "Also note that some STL containers (map, set, queue, list, deque)
3207 cannot be exported. [...]
3208 Some STL classes contain nested classes. These classes can not
3210 This is caused by a designed limitation that once a template
3211 class is instantiated, it can not be re-instantiated and
3213 Since our usage of map<> is ubiquitous in gdcm, this "designed
3214 limitation" of VC++ is a pitfall.
3215 Hence the Python wrappers of gdcm cannot be incrementally linked
3216 against the c++ dynamic library. The dirty but only workaround is
3217 to forget about incremental link of dynamic libraries and to generate
3218 the Python wrappers library with the inclusions of the underlying C++
3220 The following modifications concern this matter on Win32/VC++:
3221 - wrapping python correct with standalone wrapped dll (don't use separate
3222 dll under windows !!!!)
3223 - python21_d debug mode enabled (ask Frog how to use it :-)
3224 - NO problem with having an STL member of class for example string in C++
3225 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3226 - Python test of dcmlib in Python is ok under windows on a large set
3228 * removed glib references
3229 * typedef's inserted in gdcm.i for correct swig type management
3231 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3232 * python/demo/*.py load.py extracted from test.py. Added explore.py
3233 that only displays required tags and testAll.py that parses all
3234 the files of the testsuite without using unittest.
3235 * python/testSuite.py other additional test on new files added.
3236 * Data/* new test files added accordingly to the testSuite.
3237 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3238 the vr in the file differs from the one of the dictionary.
3240 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3241 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3242 values, but limits itself to values which are below a user specified
3243 size (by default 1024 bytes).
3244 * python/gdcm.i : elements not loaded (because their size is above the
3245 user specified treshold) are exported with their TagKey as key of the
3246 python dictionary. This enables the testsuite to make some checks
3247 on the unloaded elements (since we have their offset and size).
3248 * python/testSuite.py
3249 - now tests for the existence and proper value of the pixel data
3250 - two new examples added.
3251 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3253 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3254 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3255 aware. See the strategy comments in gdcmHeader::FindLength().
3256 * Test/test.cxx now accepts a filename as first argument.
3257 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3258 * python/testSuite.py changed to integrate test on above files.
3260 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3261 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3262 the vr was also RET.
3263 * python/testSuite.py more tests added.
3265 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3266 * python/testSuite.py unittest test suite added (uses Data)
3267 * Data/* dcm and acr files for the test suite.
3268 * glib dependance removed from un*x version. We now use ISO C99
3269 7.18 Integer types (see stdint.h)
3270 - python/Makefile, src/Makefile src/gdcm.h
3271 * src/ when an explicit vr (like dicom files) suddenly poped an
3272 implicit element we use to mark the underlying DictEntry of the
3273 concerned ElValue with "Implicit". This strategy was damageable
3274 too the public or provite dictionaries, since some of their vr
3275 would be changed. Since Header::FindLength heavily relies on the
3276 detection by Header::FindVR of falsely explicit elements, I
3277 added an extra ImplicitVr member to ElValue (boolean).
3278 The rest of the changes we the necessary adaptations.
3280 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3281 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3283 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3285 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3286 * Adaptation for porting to VC++:
3288 o forced to use std namespace (for string to be known)
3289 o all class use __declspec export style on WIN32
3290 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3291 (in stdlib.h on Win32 but in std:: for gcc)
3292 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3293 variable GDCM_DICT_PATH.
3294 * src/gdcmHeader.cxx verbose comments made discrete.
3296 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3297 * python/gdcm.i: added a typemap that converts a C++ hashing table
3298 to native Python dictionary.
3299 * python/demo/test.py:
3300 - now uses the native dictionary for exploration of gdcmHeader.
3301 - takes an optional filename argument (the file to parse).
3302 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3303 PubElVals hashing table.
3304 * Dicts/dicomV3.dic removed error prone trailing spaces.
3306 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3307 * Python wrapping process moved away from src/Makefile to
3308 newly created python/Makefile (as well as gdcm.i)
3309 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3310 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3311 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3312 from the environement variable GDCM_DICT_PATH (when existing).
3313 * src/gdcmDict::GetTag bug fix.
3315 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3316 * Straightforward temporary fixes for swig to build the python wrappers.
3317 src/Makefile now has a python working entry [by working we mean
3318 that we can import the shadow classes without errors].
3320 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3321 * hashtest.cxx removed (since already in Test)
3322 * src/gdcmlib.h renamed to src/gdcm.h
3323 * src/dcm.i renamed to src/gdcm.i
3324 * src/Makefile prepared for python wrapping
3326 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3327 * src/gdcmHeader.cxx :
3328 - Parsing of header is now separated from loading of element values
3329 (see gdcmHeader::LoadElements).
3330 - general clean up of hopefully all file access (creation of
3331 ReadInt16 and ReadInt32)
3333 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3334 * src/gdcmHeader.cxx :
3335 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3337 - SetLgrElem renamed to SetLength
3338 - GetLgrElem renamed to GetLength
3339 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3340 * src/gdcmElValSet.cxx fixed both GetElValue methods
3341 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3342 due to IdoDude was cleaned out.
3344 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3345 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3346 concentrates on finding the value representation (when it exists).
3347 RecupLgr now only finds the element value length, and it avoids
3348 returning the unecessary skL (skipped length).
3349 Also, offsetCourant was simply removed (with taille_fich) since
3350 it was redundant with the File position internals (by using
3351 ftell and fseek). This also made skL (see above in RecupLgr) usage
3353 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3354 on the libido specificities which are handled through class
3356 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3359 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3360 * Truckload of changes. Parsing of header is barely functional
3361 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3363 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3364 * src/gdcmHeader.cxx many addons of low level methods
3366 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3367 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3368 and _IdDcmSWAP_LONG.
3370 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3371 * This corresponds to all the changes decided at the meeting of
3372 May 23 2002. Needless to say we are running late...