1 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Hopefully fix the bug on MacOSX and static global initialization.
3 This is the only -minor- patch I found that both please MacOSX and VS6.
4 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
5 but this would require a lot of change. Another approach wqould be that Global
6 create those string and GDCM_UNFOUND becomes a pointer to a string (which
7 gdcm::Global would destroy at exit).
9 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
10 * Fix bug on MacOSX with static initialization in a multui threaded
11 environement. static const string in a header file used to be ill
12 initialized provoquing the freeze of any tests. patch should solve this
15 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
16 * According to Benoit's suggestion, and without any objection from anybody
17 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
18 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
19 - method gdcmDicomDirObject::GetEntry() renamed as
20 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
22 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
23 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
24 you debug/warning message just as c++ streams which make them very convinient
25 to use. Once this is stabilize I will change the ostringstrem to be
26 redirected to a file (ofstream).
27 * Properly support C99 extension: __FUNCTION__ which allow us to display
28 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
30 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
31 * Removal of useless and dangerous methods :
32 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
33 GetDocEntryByName, GetEntryByName, GetDictEntryByName
34 * Removal of usless methods :
35 Dict::PrintByName, Dict::GetDictEntryByName
36 * Commenting out of probabely useless methods :
37 Dict::GetDictEntryNames()
38 Dict::GetDictEntryNamesByCategory()
39 DictSet::GetPubDictEntryNames()
40 DictSet::GetPubDictEntryNamesByCategory()
41 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
42 * ENH : Use dicomTS.dic as described in 2004 version
43 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
44 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
45 Add Accessors on VM (Value Multiplicity), and VM related methods
46 * ADD : Add a list of 'Dicom Attribute types', as found in
47 http://medical.nema.org/dicom/2004/04_15PU.PDF
49 * ADD : Add dicomGroupNameAbbreviations.dic
50 should be used to write a method to replace the former
51 Dict::GetDictEntryNamesByCategory()
53 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
55 to read in the file... and only it ! Length is the efective length of the
56 data in the DocEntry structure
58 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
59 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
60 And now use a static function call instead, with a global variable. i
61 This is much closer to the VTK approach. Hopefully should be bulletproof
62 and easier to use...hopefully
64 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
65 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
67 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
70 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
72 ValEntry, BinEntry, SeqEntry creation or replace
74 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
76 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
78 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
79 when specifying the VR
80 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
81 * src/gdcmDocEntry.cxx : amelioration of print
83 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
84 * ADD : Add the method Util::IsCurrentProcessorBigEndian
85 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
86 * ADD Method Document::ComputeGroupLength
87 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
88 in order to allow further VR modification by user
89 * REM : removal of once-called method File::WriteBase
90 integration of its code in formerly one-line method File::Write
92 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
94 replace the different values "??", "Unkn", "Unknown".
95 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
96 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
97 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
98 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
100 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
103 * Set the gdcm::Base class to some Printable classes
105 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/gdcmFile.[h|cxx] : add the Print method
107 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
108 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
109 * src/gdcmDocument.h : remove the PrintLevel informations
110 * Example/PrintFile.cxx : use the new gdcm::File::Print
112 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
114 problems when compiling with the python wrapping
116 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
117 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
118 writting in ImplicitVR
120 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
121 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
122 JPEG decompression, especially when dicom frames are split into several
123 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
124 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
126 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * src/gdcmHeader.cxx : change the initialisation of default header.
128 Now, this header is readable by gdm, e-film, DicomWorks
130 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
132 Rename Decompressed to Raw
133 * Use the API changes in gdcm::File.
134 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
137 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
139 each added entry in the header. Replace the 'Planes' field by the 'Number
142 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
143 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
144 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
146 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
148 At this time, this image isn't readable by e-film... waiting JPR help to
151 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
153 DocEntry. Now use methods of the Document !
155 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * Test/ShowDicomSeq.cxx : bug fix
158 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
159 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
160 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
161 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
162 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
164 * Test/TestCopyRescaleDicom.cxx : remove unused variable
165 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
166 containing found sequences
168 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
171 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
172 Some fields in BinEntry must be copied to not seg fault when making the :
173 gdcm::File *copy = new gdcm::File( copyH );
174 and tests are now made on good variables
176 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
178 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
180 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
181 * Add vtkGdcmWriter example and test
183 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
184 * Test/TestUtil.cxx : reformat the source code
185 * vtk/vtkGdcmReader.cxx : remove and change prints
186 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
188 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
189 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
191 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
193 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
195 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
196 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
197 by an eof to prevent all bad read of the file... and in this case, the
200 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
201 * Example/Volume2Dicom.cxx : comment unused variables
202 * Test/PrintDicomDir.cxx : comment unused variables
203 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
204 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
205 method that is redondant with AddEntry.
206 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
209 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * Bug fix due my last commit (compilation under Windows).
211 * Example/Volume2Dicom : bug fix in the file and reformatting source code
212 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
214 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
216 - Remove printf / sprintf
217 - include iostream AFTER gdcm so we don't get warnings
218 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
220 - Also remove tons of include from header files, hopefully this should
221 speeup the compilation time, since it was becoming a dog slow.
222 - Remove gdcm.h as it include way too many files and slow down compilation
223 (plus it is not up to date)
224 - remove 'using namespace std' this is BAD !
226 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * Remove memory leaks on the DicomDir
228 * Remove some useless data in DicomDirObject
229 * Add usefull methods in SQItem, to be complient withe the ElementSet
231 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
232 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
234 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
235 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
236 future, with convertion)
237 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
238 and ImageDataSize values. Remove the method to get the PixelReadConverter
239 from the output of the class
241 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
242 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
244 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
246 and vtkErrorMacro use.
247 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
249 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
252 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
253 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
254 The string leaves only in the fonction. So when we make a .c_str(), we
255 get the pointeur on the first element, element that will be destroyed
256 immediately after thee instruction.
257 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
258 file has been opened : the test must be made on the content of the
259 pointer and not directly on the pointer !
262 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
264 the python part recompiles
266 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
268 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
269 X session is killed (for my computer... it seems to not be identic on
272 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
273 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
274 avoid problems (otherwise, the difference test between the visible image
275 and the reference is incorrect. If the reference is greater than the
276 screen resolution, it's produce errors).
277 Can be used for only one image. Can be used with a visible flag.
278 * vtk/vtkGdcmReader.cxx : remove commented codes.
279 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
280 under windows at compilation
281 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
283 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
285 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
286 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
287 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
288 tests on the image size X, Y, Z
290 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
291 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
292 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
293 between the class name and the file name
295 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
296 * src/ : fix compilation warnings for the Write method (2 different
297 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
298 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
299 variable... create a static method in gdcm::Document to access to
300 this variable content.
302 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
303 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
304 file, to be accessed by other files (like gdcmFile). Remove commented
305 code. Move the change of the header to the gdcmFile, using the
307 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
308 To be sure of that (and simplify calls), the Write of the header now
309 gets a file name and not a file pointer (std::ifstream).
310 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
311 DocEntryArchive. Remove all open of the written file
313 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
314 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
316 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
317 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
318 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
320 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
321 some corresponding methods. Write correctly the file and check before
323 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
324 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
325 is now on RGB data (as before my last commit
326 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
328 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
329 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
330 Add a print information of the type of the entry
331 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
332 It was in the gdcmFile, and all write have been regrouped
333 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
334 Write correctly all dicom files (in decompressed mode only at this time)
335 * Test/ : test on files are now made using Raw data and not color data if
337 * Example/PrintFile.cxx : add more printings
339 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
340 * Amelioration of code, remove some code copy. For the loading of
341 BinEntry (in gdcmDocument), add the test to verify if the file is already
344 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
345 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
346 remove a DocEntry in the header (push an empty DocEntry)
347 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
348 lines. Bug fix in the initialization of the PixelConvert and the
350 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
351 use in TestCopyDicom (now this test can run under windows... but fails)
352 * Test/TestCopyDicom.cxx : amelioration of the test :
353 - test the pixels written
354 - add test points to quickly find where is the error
355 - can set a file name input and output in arguments
356 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
357 amelioration of the test output
359 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
360 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
361 all replaced DocEntry's
362 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
363 Now, each needed DocEntry to modify is duplicated, modified and inserted
364 to the header using DocEntryArchive. Thus, after save, we can restore the
365 header initial state.
367 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
368 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
370 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
371 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
372 correct to copy it. The DictEntry is specified at the DocEntry creation,
373 then, it musn't change in the time.
374 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
375 header correctly. At this time, the change is only made for the first
376 level of the Document. In the future, it might consider sequences.
377 The change is made by replacing a DocEntry by an other that is created
378 outside the class. The old value is kept. When we restore the header
379 status, the added DocEntry is deleted and replaced by the old value.
380 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
381 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
382 set the write type to explicit VR, implicit VR or ACR. Add methods to set
383 the write mode to native, decompressed or RGB (but not used at this time)
385 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
386 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
387 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
389 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
390 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
391 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
393 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
394 set because already copied when copying the BinEntry's of the header
395 * Test/TestAllReadCompareDicom.cxx : remove warnings
397 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
398 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
399 Two problems appear when doing it :
400 - with the gdcmFile : when the GetImageData method is called, the pixels
401 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
402 data (pixels). And each structure destruct the data when it's
403 destructed. So we have two destructions for the same data. To solve it,
404 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
405 data or not. If it doesn't own data, then they will not destroyed by
407 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
408 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
409 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
410 create a double destruction of the same DocEntry's. So, to solve it,
411 the TagHT is simply cleared and the DicomDir* elements are destroyed.
412 * TODO : add an entry concerning memory leaks in the DicomDir
414 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
415 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
416 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
419 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
420 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
421 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
422 after it have been deleted
424 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
425 * FIX: src/* fix the doxygen warnings.
426 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
427 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
428 was erroneously defined with a size of 15 instead of 16. [many thanks
429 to Jean Michel Rouet for pointing out this bug].
431 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
432 1. Finish merging JMR patch for writting DICOM from scratch
433 2. Fix -hopefully- bug with MONOCHROME and space vs null character
434 3. Use const ref when possible
435 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
436 5. A few more comments
437 6. CreateUniqueUID can now be called without parameter"
439 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
440 * ENH: Slightly bigger patch:
441 1. Getting toward full integration of JMR patch for writting dicom from scratch
442 2. Update Test to test part of this patch: CreateUniqueUID
443 3. File was not close properly in gdcmDict
444 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
445 5. Use of const ref instead of copy (speed issue)
446 6. Remove temporary (duplicate) string in TranslateToKey
447 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
448 8. Do not repeat virtual in subclasses
449 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
451 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
452 * Apply first patch toward better string comparison when dealing with broken
453 DICOM files. Essentially the string could be padded with a space instead
454 of a null character as defined by standard
456 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
457 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
458 because never used... and in the same time, that's remove some memory leaks
460 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
461 * src/gdcmFile.cxx : now delete the PixelConvert instance.
462 * In examples and tests : change the type of image data variables from void*
463 to uint8_t*. Remmove all delete on image data variables
465 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
466 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
467 Verify the file pointer value before open the file, and if it's not null,
468 a verbose message is generated.
469 Close correctly the file when the file isn't considered dicom-like. The
470 correctly close is a call to CloseFile.
471 When closing the file pointer, test if its not null to close the file.
472 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
473 file. For an uncompressed image, the copied data correspond in the least
474 case to the image size (calculated) or the image size specified in the
475 header. A verbose is generated if these two size mismatch
477 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
478 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
479 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
480 break under windows (with msvc6 compilation).
482 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
483 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
484 compiling with MSVC6)
486 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * Bugs fix for the Windows build with VC6
488 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
489 needed (only for projects required VTK). If the VTK is included in all
490 projects, there is conflicts with the jpeg lib of vtk when compiling the
491 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
492 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
493 when compiling the gdcm_wrap.cxx file (created by the compilation of the
495 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
496 (like it's already made for the cout use). Otherwise, conflict with the
499 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
500 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
502 - comments on the DicomDir::Method related usage added.
503 - now that we use the namespace gdcm, a lot of internal classes do
504 NOT need to be wrapped anymore.
505 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
506 DicomDir::Method) new example added.
508 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
509 * Improve string manipulation. I now inforce the notion of 'DicomString'
510 A DicomString can contain as many \0 as they want
511 and it is *always* of even length.
512 We only support odd length for very rare case.
513 And in the near future this should be removed.
515 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
516 * /binary_write/ gdcm source. Now even on big endian we are writting
517 little endian. This should -heopfully- fix some tests
519 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
520 * Now the dictionary is compiled into gdcm lib. This is a default
521 behavior, thus any dic file specified is picked before failback to
522 the one comiled into lib
524 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
525 * Change internals for gdcmDict. Don't use any 'new' any more.
526 This should definitely solve any leak problem, and we should be
527 as fast as before, as long as don't modify too much the dictionary.
529 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
530 * STYLE: ivars should start with a capital letter.
531 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
532 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
534 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
535 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
536 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
537 new 2004 dictionaries added (thanks to JPR).
538 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
539 * CLEANUP_ROUND (15) for gdcmPixelConvert
540 - RLEFrame::NumberFragments is now of type unsigned int
541 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
542 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
545 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
546 * Initial work in gathering all transfer syntax accessors. clearly
547 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
548 ivars, but only one transfersyntax (class) ivar with equivalent method on
551 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
552 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
553 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
554 discussed (plus I didn't like having a 2000 lines patch not commited)
556 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
557 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
558 * CLEANUP_ROUND (14) for gdcmPixelConvert
559 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
560 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
561 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
563 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
564 anymore and hence avoids storing a copy of PixelConvert::Decompressed
565 into File::Pixel_Data.
567 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
568 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
569 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
570 * CLEANUP_ROUND (13) for gdcmPixelConvert
571 Substituted File::ParsePixelData() with PixelConvert::Print() new
573 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
574 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
575 method to those classes.
576 - src/gdcmFile.[cxx|h]:
577 -- Added a ::Print() method.
578 -- PixelConverter is now a reference instead of a member.
579 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
580 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
582 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
583 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
584 collaboration diagram and inheritance diagram should be generated with
586 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
587 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
588 pointlessly wrapped (see
589 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
590 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
591 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
592 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
593 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
594 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
595 -- File::Initialise: PixelConverter setup moved away to
596 PixelConverter::GrabInformationsFromHeader()
597 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
598 interpretation moved away to PixelConverter::BuildRGBImage()
600 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
601 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
602 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
604 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
605 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
606 displayed on Win32 when a brutal abort() occurs (because of uncatched
607 exception). See TODO new entry of this commit for more on this.
608 * TODO added new entry.
609 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
610 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
611 - HandleColor is no longer called from gdcmFile.cxx
612 - gdcmPixelConvert.cxx clean up on method arguments and internal
613 variable names for semantical coherence.
615 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
616 * Finished lossless transition, not only do we now read all lossless jpeg
617 images, without the need of the Cornwell lib, but we do read them properly now
618 * To reduce code (well to avoid code duplication), I defined a common place
619 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
620 redefine symbols. This is not prefect but this the best solution I found for a
621 compilation time jpeg option.
623 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
624 * Update jpeg ijg lib to support lossless jpeg implementation
625 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
627 * Also added a special copyright for dcmtk since we use their bugfixes.
630 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
631 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
632 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
633 matters, as stated in warning note at begining of %include section).
634 * src/gdcmDicomDir*.[cxx|h]: coding style
635 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
636 * src/gdcmJpeg8.cxx: doxygen fix.
637 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
638 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
639 from File:: to PixelConvert::.
641 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
642 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
643 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
644 - more code moved away from File:: to PixelConvert::
645 - fat setup of PixelConverter set in place in File::Initialise.
647 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
648 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
649 namespace at the file system level. So now you should convert your examples
651 gdcmHeader -> gdcm::Header
652 It would be nice if people keep in mind to no open the namespace, since it
653 allows compilation on broken plateform which were defining common symbol in
654 the standart namespace (like LP, Unknown ...)
656 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
657 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
658 The JPEG fragments are now parsed at the same stage than the RLE
659 information. All code related to JPEG is now in gdcmPixelConvert:
660 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
661 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
662 export a gdcmFile:: method. Those are simply global functions
663 (for the time being this is better than having them attach to
664 either gdcmFile:: or gdcmPixelConvert::).
665 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
666 and stores the result in a gdcmJPEGFragmentsInfo.
667 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
668 code (among other stuff) moved away from gdcmFile:; to
671 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
672 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
673 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
674 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
675 clean up of RLE related code.
676 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
677 - src/gdcmRLE.cxx removed
678 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
679 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
680 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
681 * CLEANUP_ROUND (9) for gdcmPixelConvert
682 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
683 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
684 away from gdcmFile:: to gdcmPixelConvert::.
686 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
687 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
688 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
689 This is because Parse7Fe0 used to parse the pixels to compute the
690 length. This task was passed over to FindDocEntryLengthOB() a long
691 time ago, EXCEPT I had forgotten the OW case...
692 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
693 we just recylce the code for parsing RLE fragments and computing
695 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
696 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
697 with the retired Parse7Fe0().
698 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
699 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
701 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
702 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
703 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
704 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
705 - src/CMakeLists.txt: alphabetic order reodering + new entries.
706 * CLEANUP_ROUND (4) for gdcmPixelConvert
707 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
708 to return an unused length.
710 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
711 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
712 this should be cleanner from the plane view. The iostream are erally a pain
713 to use to do simple stuff.
715 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
716 * Redo the compilation of the ijg jpeg library. Now only one source is
717 necesseray. No need to rename file by hand what so ever. CMake handle the
718 copying of the file within different directory, configure header file to
719 modify some symbol. The only addition made to ijg wasd a mangle table so
720 that symbol are different wether we are within 8bits or 12bits.
722 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
723 * Added documentation of vtkgdcmReader on Website:
724 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
725 with it's binary name).
726 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
727 the Website to be more complete.
728 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
729 doxygenated documentation.
730 - Doc/DoxyVtkGdcmReaderExamples.txt added
731 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
732 DoxyVtkGdmReaderExamples.html )
733 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
734 * CLEANUP_ROUND (3) for gdcmPixelConvert
735 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
737 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
738 * CLEANUP_ROUND (2) for gdcmPixelConvert
739 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
741 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
742 * CLEANUP_ROUND for gdcmPixelConvert:
743 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
744 - src/gdcmPixelStuff[h|cxx] removed
745 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
746 - src/CMakeLists.txt changed accordingly
748 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
749 gdcmVersion.py moved to newly created ATTIC related
750 gdcmPython/SetupOldies/ directory.
751 * Autotools clean up:
752 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
753 - autogen.sh configure.in acinclude.m4 python.m4 removed
755 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
756 * src/*.cxx *.h Reference to License.htm fixed to License.html.
757 * Doc/CMakeLists.txt, doxygen.config.in: fix.
758 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
760 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
761 * TODO updated with Mathieu suggestions. I proposed a template for
762 describing TODO entries and used it for new entries.
763 * Added Doc/Website/CodingStyle.html, Developpers.html,
764 DeveloppersPython.html, GdcmDataCvs.html and
765 DownloadVersion0_1.html, DownloadVersion0_3.html.
766 * Some Doc/*.txt Doxygen files (which do not really concern the
767 documentation itself, but the website) moved to html and
768 placed in directory Doc/Website:
769 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
770 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
771 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
772 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
773 * CMakeLists.txt changed accordingly.
774 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
775 DeveloppersPython.html
776 * INSTALL nows refers to Doc/Website/Installation.html
778 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
779 * Added Doc/Website directory, that contains a first raw version
782 2004-09-23 Jean-Pierre Roux
783 * FIX In order not to be poluted any longer by casting problems,
784 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
785 we can now delete[] it safely
786 * VoidArea is now called BinArea (less confusing name),
787 and all the methods called ...VoidArea... are now ... BinArea...
788 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
790 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
791 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
792 clear) TagHT, which is an inherited member of gdcmElementSet. It is
793 up to the destructor of gdcmElementSet to clean up TagHt and it's
796 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
797 * Test/CMakeLists.txt: update to follow gdcmData renamings.
798 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
800 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
801 * ENH: added some utility method that builds a flat dictionnary
802 holding all the Dicom entries contained in the recursive structure
803 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
805 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
806 BuildFlatHashTable() that build a flat dictionary.
807 - src/gdcmElementSet.h: added a new private GetTag() accessor.
808 gdcmDocument is now a friend of gdcmElementSet.
809 - src/gdcmElementSet.cxx: clean up.
810 - Example/FlatHashTablePrint.cxx added.
811 - Example/CmakeLists.txt changed accordingly
813 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
814 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
815 moved away from gdcmDocEntrySet (since this class is an abstract class
816 acting like an interface). SQDepthLevel and BaseTagKey are now
818 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
819 and associated accessors. Doxygenation of the class.
820 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
822 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
823 Use SQDepthLevel accessor instead. ::Print() adapted.
824 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
825 - src/gdcmDocument.cxx changed accordingly.
827 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
828 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
829 - The following is the doxygen comment of the typedef declaration
830 of gdcmagKey in src/gdcmCommon.h:
831 gdcmTagKey is made to old an "universal" (as in URL, Universal
832 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
833 A dicom tag allways has a group and an element, but a set of tags
834 embeded in various (optionally nested) sequences and sharing
835 the same group and element all share the same (group, element)
836 "identifier". Hence the (group, element) cannot be used as an
837 identifier (in gdcm we shall refer to a "TagKey") of a tag.
838 In order to construct a proper tag identifier (i.e. a key) we
839 consider the following definition of a TagKey:
840 - let Group, Element be the string representation of the
841 group and element dicom tag members,
842 - let ItemNumber be the string representation of the integer
843 index of the considered item number of a sequence,
844 Let the key of a tag embeded in a sequence, noted SeqTag, be
846 /ItemNumber#Group|Element
847 where "/", "#" and "|" are characters acting as separators.
848 Then the general form of a gdcmTagKey is given by:
849 Group|Element<SeqTag>
850 where <SeqTag> means NO or many instances of SeqTag.
851 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
854 but the gdcmTagKey of a tag "embeded" is the first item of
855 a sequence, itself nested in the third item of a sequence is the
857 0004|1220/2#0008|0082/0#0008|0090
858 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
859 order to hold the new sequence compatible key. Previously, the
860 GetKey() method would look in the underlying gdcmDictEntry.
861 - src/gdcmDocEntry.cxx:
862 -- constructor now copies the underlying DictEntry key, in the local
864 -- ::Print: displays the member Key, instead of the (group, element).
865 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
866 - src/gdcmDocEntrySet.h:xi
867 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
868 -- now has a new BaseTagKey member.
870 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
871 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
873 This poses the problem with the semantics of the following lines
874 LoadEntryVoidArea(0x0028,0x1201); // R LUT
875 LoadEntryVoidArea(0x0028,0x1202); // G LUT
876 LoadEntryVoidArea(0x0028,0x1203); // B LUT
877 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
878 to the long FIXME note for what the problem is. Nevertheless in
879 order to get things working the dicom dictionary was altered !
880 Please fix things urgently...
881 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
882 information), see above note on moving the member VoidArea. Nevertheless
883 the following entries previously correctly set as US are now inproperly
885 0028 1201 OW IMG Red Palette Color Lookup Table Data
886 0028 1202 OW IMG Green Palette Color Lookup Table Data
887 0028 1203 OW IMG Blue Palette Color Lookup Table Data
888 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
889 of gdcmDocEntry moved to gdcmSeqEntry.
890 * src/gdcmSeqEntry.cxx: STYLE.
892 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
893 * Test/TestAllEntryVerify.cxx minor fix and added comments.
895 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
896 * gdcmPython/testSuite.py: all the test suite in python is now moved
897 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
898 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
899 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
901 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
902 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
903 to avoid inclusion recursion until STL is reached.
904 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
905 mecanism. errno.h is not included in gdcm anymore.
906 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
907 (gdcmFormatError now inherits from gdcmFormatUnexpected).
909 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
910 gdcmData/TestAllEntryVerifyReference.txt
911 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
912 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
913 exception_on_error parameter.
914 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
915 - vtk/vtkGdcmReader.cxx changed accordingly,
916 - Example/*.cxx and Test/*.cxx changed accordingly.
918 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
919 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
920 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
921 enable_sequences removed from gdcmHeader constructor and dependencies.
922 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
923 * gdcmPython/demo/PrintHeader.py: dummy fix.
924 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
925 skip_shadow removed from gdcmHeader constructor and dependencies.
926 * Example/*.cxx and Test/*.cxx changed accordingly.
928 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
929 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
930 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
932 2004-07-21 Jean-Pierre Roux
933 * FIX Now, Parsing and Printing a DICOMDIR do work!
934 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
936 2004-07-20 Jean-Pierre Roux
937 * FIX Some brain damaged headers have Zero-Lenght fields
938 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
940 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
941 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
942 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
943 variable (instance of gdcmDebug) by a definition macro, and the instance
944 is now in static in the gdcmDebug class
945 * src/gdcmSQItem.h : (FIXME) remove an undefined method
946 * Test/PrintAllDocument.cxx : bug fix in the result of the test
948 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
949 * WARNING: ctest now depends more tightly on gdcmData. You should
950 check out gdcmData properly for things to run smoothly...
951 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
952 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
953 we need the pixels not be loaded in order to use the ValEntry
954 that displays position and size).
955 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
956 This is a C++ based equivalent of gdcmPython/testSuite.py that should
957 be deprecated. If you have any doubts about the advantages of a
958 modern scripting language (read Python) versus grass root C++ (i.e.
959 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
960 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
961 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
962 Anyhow, consider documenting the gdcmData images in
963 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
965 * Test/CMakeLists.txt:
966 - now uses TestAllEntryVerify.cxx
967 - specific comments on oldACR00001.ima (now renamed in gdcmData
968 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
969 gdcmData/TestAllEntryVerifyReference.txt
972 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
973 * src/*.[h|cxx] : typedef clean up
974 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
975 - TagKey renamed to gdcmTagKey (for external usage)
976 - VRKey renamed to gdcmVRKey (for external usage)
977 - removal of typedef duplication.
978 - Removed all unecessary inline keyword from class inline definitions.
979 - Some method|function(void) declarations replaced with method|function().
980 * src/jpeg/libijg12/jdhuff12.c:
981 - printf polluting ctest removed.
982 - TAB removal for comminting
984 - TestAllReadCompareDicom.cxx: added a test that compares all the
985 images in gdcmDataImages.h with corresponding images in
986 gdcmData/BaselineDicom/. When baseline images are not present
987 this test creates them.
988 Note: we need to validate each reference image, but before that
989 I'd like to rename them with a more explicit name...
990 - CMakeLists.txt: changed accordingly.
991 * Example/*.cxx: examples now only include gdcm.h (as opposed to
992 including each header needed).
994 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
995 * Test/*.cxx and Example/*.cxx: moved some examples away from the
996 test suite to the Example directory. Are concerned:
1001 - TestWriteSimple.cxx
1002 * Test/CMakeLists.txt: added some comments on reasons for black listing
1003 image gdcmData/oldACR00001.ima
1005 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1006 * Test/CmakeList.txt: removed the following from black list (to be coherent
1007 with removal from gdcmData):
1008 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1009 - gdcm-MR-PHILIPS-16.dcm
1011 Added the following because after last cvs update, they cause
1012 ctest -R TestReadWriteReadCompare
1014 - gdcm-MR-SIEMENS-16-1.acr
1016 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1017 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1018 new comments in this file) we temporarily (sigh) move to a weaker
1020 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1021 we don't need to black list the following images anymore:
1022 - 8BitsUncompressedColor.dcm
1024 - US-PAL-8-10x-echo.dcm
1025 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1026 fixes and the beautified code ;-)
1027 This fixes the bug introduced in version 1.42 (when beautifying)
1028 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1029 Note: ctest was blind to this bug (this means we need to still
1030 improve the test suite). The bug could be detected by using
1031 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1033 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1034 and by displaying the (garbage) produced file temp.XDCM...
1036 2004-06-29 Jean-Pierre Roux
1037 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1038 - replace by uggly but working old code :-(
1039 A lot of things should be OK again.
1040 It's really urgent to have a test suite that *tests*,
1041 to prevent Frog's beautifying sessions to break all the stuff
1042 (twice, withing a fortnigh ...)
1044 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1045 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1046 redundancy) to added Test/TestReadWriteReadCompare.cxx
1047 * Test/CmakeList.txt: because the compare test of
1048 Test/TestReadWriteReadCompare.cxx fails, the following images are
1049 black listed: - 8BitsUncompressedColor.dcm
1051 - US-PAL-8-10x-echo.dcm
1052 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1053 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1054 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1055 and ad-hoc kludge. This kludge is now removed, and on encountering
1056 such an image (OB field brain damaged) we set errno. Then in
1057 ::FindDocLength() we "fix" the length as being ALL what remains
1058 in the file (until EOF). We then proceed, hoping for the best...
1059 This fixes a SegFault in ShowDicom when trying to write such an
1061 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1062 (because TestWriteRead breaks on it, after a non conformal commit?).
1063 ctest now runs properly, except for MakeDicomDir (which was allways
1064 broken) and the Python related stuff (still not fixed).
1066 2004-06-24 Jean-Pierre Roux
1067 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1068 FIX : Test/TestReadWrite now iterates on all the file names
1069 (instead of infinite loop)
1070 ENH : Test/TestWriteRead now iterates on all the file names
1072 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1073 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1075 2004-06-24 Jean-Pierre Roux
1076 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1077 when SamplesPerPixel =3
1078 - now Write is no longer confused by
1079 'BitsAllocated = 12" and 'BitsStored=12"
1080 - "UN" value representation Elements are now written correctly
1081 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1082 ENH : - now gdcmHeader has its own Write methods
1083 (in order to split the job that has not to be done
1086 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1087 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1088 loop on the same image until memory went out.
1089 Note: this means we still have gobs of memory loss in PrintDocument
1090 * src/gdcmDocument.cxx: fixes problem on parsing on file
1091 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1093 2004-06-24 Jean-Pierre Roux
1094 FIX : Write - All the Sequences and Sequence Item are now written
1095 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1096 is added a the end, when necessary.
1097 - A lot of brain-damaged images, that were read correctly are
1098 now written correctly
1099 - length compatible BinEntry are now loaded correctly
1100 (even for odd groups)
1101 Note : only Explicit Value Representation was checked.
1102 (question : is implicit VR really necessary for gdcm ?)
1104 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1105 * DEVELOPPER: added a proposition of coding style.
1106 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1109 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1110 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1111 Use the gdcmDocEntry::Print() and Write() instead.
1112 * src/gdcmDocument.cxx: bug fix.
1114 2004-06-22 Jean-Pierre Roux
1115 FIX : gdcmDocument.cxx
1116 - Now we do recognize the JpegLossLess format (there was a misstyping in
1117 code 'beautyfication' :-(
1118 - Now we automaticaticaly load the Luts, if any
1120 2004-06-22 Jean-Pierre Roux
1121 In order : to write Sequences, whatever their imbrication level,
1122 : to allow user to create his own Sequences
1123 a lot of modif where necessary (adding, moving, or virtualising methods)
1125 WARNING : save your own sources *before* cvs up !
1128 ADD virtual void Write(FILE *fp, FileType filetype);
1131 ADD virtual void Write(FILE *fp, FileType filetype);
1132 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1135 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1136 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1137 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1138 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1139 ADD std::string GetEntryByName(TagName name);
1140 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1142 std::string vr = "unkn",
1143 std::string fourth = "unkn",
1144 std::string name = "unkn");
1145 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1146 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1147 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1148 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1149 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1150 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1151 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1152 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1155 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1156 ADD virtual std::string GetEntryByName (TagName tagName);
1157 ADD virtual std::string GetEntryVRByName (TagName tagName);
1158 REM virtual bool Write(FILE *, FileType);
1159 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1160 FILE *_fp, FileType type);
1161 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1162 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1163 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1164 REM virtual std::string GetEntryByName (std::string tagName);
1165 REM virtual std::string GetEntryVRByName (std::string tagName);
1166 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1167 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1168 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1170 std::string vr = "unkn",
1171 std::string fourth = "unkn",
1172 std::string name = "unkn");
1173 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1174 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1175 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1176 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1179 ADD virtual void Write(FILE *fp, FileType filetype);
1182 ADD virtual void Write(FILE *fp,FileType filetype);
1185 ADD virtual void Write(FILE *fp, FileType filetype);
1186 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1187 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1188 REM std::string GetEntryByName(TagName name);
1191 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1193 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1194 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1195 The default constructor invoked by the line
1196 gdcmHeader *f1 = new gdcmHeader( header );
1197 was gdcmHeader::gdcmHeader(bool) instead of the expected
1198 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1199 Hence the parsing wasn't executed... See also below.
1200 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1201 as explicit constructor didn't do the trick to fix the above problem.
1202 Could anyone explain why ?
1203 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1204 properly calls gdcmValEntry::Print() (that was weed out from
1205 code related to gdcmBinEntry).
1207 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1208 * In order to fix memory leaks:
1209 - Test/TestWriteSimple.cxx: added cleaning of free store through
1211 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1212 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1213 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1214 (through the call to ::AddDicomDirMeta()) or the destructor
1215 would crash when deleting uninitialized ::metaElems].
1216 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1217 - src/gdcmDocument.cxx:
1218 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1219 from dynamic stores.
1220 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1221 was causing memory leaks.
1222 - src/gdcmSQItem.cxx:
1223 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1224 cleanly handled with polymophism: sorry but my milage is low).
1225 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1226 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1227 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1228 This avoids SegFaulting.
1229 - src/gdcmSQItem.h: coding style.
1231 - Test/TestWriteSimple still severely sucks. The output image content
1232 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1233 damaged when displayed with vtkgdcmViewer.
1234 - on memory leaks: TestWriteSimple leaks really less (see entry
1235 of 2004-06-18 in Changelog file for the call to valgrind).
1236 - on segfaults: ctest now passes all the tests but one (no more
1238 * Erroneous leading white fix:
1239 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1240 white[s] (as opposed to from >> xxx, that removes it [them].
1241 - src/gdcmTS.cxx: ditto.
1242 - gdcmPython/testSuite.py: dirty related kludge removed.
1243 * src/*: remaining references to gdcmParser removed.
1244 * src/*[cxx|h]: added copy[way]left header.
1247 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1248 * In order to fix writing of dicom files:
1249 - Test/TestWriteSimple.cxx: a simpler example of writing.
1250 - Test/CMakeLists.txt changed accordingly.
1251 - src/gdcmDocument.cxx:
1252 -- The destructor now recursilvely removes potential sequences.
1253 -- Bug fix in ::IsJPEG2000()
1254 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1255 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1257 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1258 to only declared) and build on top of
1259 ::GetDocEntryByNumber(guint16, guint16).
1260 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1261 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1262 for usage in destructor and treatement of promotion in
1263 ::ReplaceOrCreateByNumber().
1264 - src/gdcmSQItem.cxx: destructor should better handle his job.
1265 Test/TestWriteSimple now runs (or at least it DOES something).
1266 * We can now start hutting memory links. A good starting point is:
1267 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1268 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1269 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1271 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1272 * Valgrind note: after Mathieu Malaterre teached me how to read
1273 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1275 Using gcc, you can force the STL to use malloc and to free memory as
1276 soon as possible by globally disabling memory caching.
1277 With 3.2.2 and later, you should export the environment variable
1278 GLIBCPP_FORCE_NEW before running your program.
1279 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1280 simply vanish (it is still not clear to me, whether this means that
1281 STL std::string leaks or if valgrind believes it leaks...).
1282 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1283 running bin/gdcmTests makeDicomDir):
1284 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1285 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1287 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1288 SegFaulting (I drowned in DicomDir related code when trying to
1289 understand why the list is empty...).
1290 * src/gdcmDocument.h: first BSD license header try.
1291 * Doc/License.txt added.
1293 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1294 * src/gdcmDocument.[h|cxx]:
1295 - Clean up of the Transfer related predicates. They are now all based
1296 on new method isGivenTransferSyntax, that (should) handle properly
1297 the padding problem.
1298 - general clean up, simplification, and coding style.
1299 - Specific clean up of Parse7FE0() (umproperly named actually).
1300 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1302 2004-06-14 Jean-Pierre Roux
1304 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1305 - fix the display of SQItem ordinal number
1306 - add the GetSQItemByOrdinalNumber method
1307 - remove some useless never written private methods
1309 2004-06-14 Jean-Pierre Roux
1311 - adding a constructor taking a gdcmDocEntry as an input param
1312 - ReplaceOrCreateByNumber now returns :
1313 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1314 a gdcmValEntry * if a string value is passed as a param
1316 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1317 according to the param type (no longer sets a gdcmDocEntry)
1318 - GetValEntryByNumber, GetBinEntryByNumber added
1319 - NewValEntryByNumber and NewBinEntryByNumber added
1321 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1323 - GetSQItemNumber and SetSQItemNumber added, to provide
1324 a (relative) Item identier inside a given Sequence
1325 \warning : some pb remaining around this number
1327 - AddEntry now takes the Item Number as a param
1329 - adding a constructor taking a gdcmDocEntry as an input param
1331 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1332 * Memory leak hunt with the following command:
1333 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1334 --show-reachable=yes gdcmTests PrintDocument
1335 It looks like many (all?) leaks are due to the STL (or a bad usage
1336 of the STL. The lines producing the leaks now have a comment with
1337 a "MEMORY LEAK" tag: you can retrieve them with
1338 grep "MEMORY LEAK" src/*
1339 Here are two typical examples which I can't help fixing:
1344 char * test = "babo";
1345 name = test; //// <--- valgrind detects 960 bytes lost in
1346 //// call to std::string::operator=(char const*)
1347 name.clear(); //// Doesn't help !
1355 std::cout << "Type a bunch of characters followed by RETURN: ";
1356 getline(std::cin, line); //// <--- valgrind dectects a loss
1357 //// of 1320 bytes in call to
1358 /// std::basic_istream<>& std::getline<>
1364 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1365 * src/gdcmHeader.[cxx|h]:
1366 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1367 and related, moved away to gdcmDocument.
1368 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1369 the corresponding protected accessors of inherited class
1370 gdcmDocument, removed ! As a consequence gdcmFile had to be
1371 declared friend of class gdcmDocument (see below).
1372 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1373 - Clean up of undefined or unused methods.
1374 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1375 account the changes to gdcmHeader.h).
1376 * src/gdcmDocument.h:
1377 - gdcmFile is now a friend class (in order to take into account the
1378 changes to gdcmHeader.h).
1379 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1380 (see changes to gdcmHeader.h).
1381 - Accessors (reading on the form GetEntry*) are now public.
1382 - Clean up of undefined or unused methods.
1383 * src/gdcmDocument.cxx:
1384 - adaptation to changes to gdcmDocument.h
1385 - ::OpenFile now writes a verbose message when file cannot be opened.
1386 - some std::string properly set to VRKey
1387 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1388 references to gdcmDocument.
1389 * Test/TestFindTags.cxx: changed accordingly to above changes.
1390 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1391 cvs repository gdcmData.
1393 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1394 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1395 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1396 conflicts with gdcmValEntry::voidArea.
1397 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1398 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1399 Value representation between StringRepresentable and BinaryRepresentable.
1400 * src/gdcmDocument.cxx:
1401 - method ParseDES: proper indentation restored and usage of
1402 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1403 - method LoadDocEntry: the fingerprint left in the SetValue() of
1404 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1405 removed. Reverting to previous code segment with the proper
1406 dynamic_cast< gdcmValEntry* >.
1407 Note: this was (partially) breaking the python test suite
1408 (gdcmPython/testSuite.py) that made usage of the above
1409 fingerprint to check presence of "Pixel Data".
1410 * src/gdcmDocEntry.h: coding style.
1411 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1412 now taken into account.
1413 * gdcmPython/gdcm.i: adaptation to the new internal representation
1414 of gdcm (exit gdcmParser, hello gdcmDocument).
1415 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1417 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1418 anymore, but instead prints the loaded Python dictionary.
1419 * .... alas, the python testSuite is still broken.
1421 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1422 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1424 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1425 * src/gdcmUtil.h : export methods
1427 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1428 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1430 * Initial addition of automatic python testing
1431 * Initial addition of automatic image comparison
1433 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1434 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1435 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1437 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1438 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1439 * Test/ShowDicom.cxx : bug fix for msvc compilation
1440 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1442 2004-05-04 Jean-Pierre Roux
1443 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1444 new concepts (and new classes) :
1445 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1446 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1447 - Sequence Doc Entries (gdcmSeqEntries)
1448 a Sequence is composed of Items.
1449 Each item is a set of Doc Entries (this is recursive)
1450 The non uniqueness of the 'Dicom tag' is due to this recursivity
1451 (never taken into account)
1452 Our unability to add a new 'entry' in the header
1453 at the proper location (neither in the H-Table (map or multimap),
1454 nor in the Chained List is also due to this recursivity.
1455 Don't try, right now, to use/modify/compile these new sources :
1456 nothing is finished.
1457 We just commit all the stuff, 'as is', in order not to loose it.
1459 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1460 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1462 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1463 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1464 file prefix (SetFilePrefix)
1466 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1467 * Add a new test: ShowDicom, for now this is just the c++ version of
1468 checkRead.sh, later it will be able to compare the image read against a
1470 * Replace the DEBUG on the stack with a global entry in cmake interface:
1471 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1473 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1474 * Add an example subdir, with a real example on how to read + write a
1477 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1478 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1479 * Doc/CMakeLists.txt: the main page is now properly differentiated
1480 between the developper and user version.
1481 * Doc/doxygen.config.in: dropped search related obsolete flags
1482 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1484 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1485 * DEVELOPPER: added some helpfull comments for compile/test/install
1488 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1489 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1490 src directory, now generated in the build dir.
1491 2. Tests as mentionned smarter
1493 4. Add a new method in gdcmDict that return the PubDict by name
1494 this is interesting for 3rd party lib like ITK,
1495 where we could set the institution name / patient name...
1497 * ENH: 1. Now the test suite is working for real
1498 2. All binaries are now output in the gdcm-bin directory
1499 (this was not true before)
1501 2004-04-28 Jean-Pierre Roux
1502 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1503 SeQuence indented printing of Dicom Header.
1504 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1505 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1506 Computation of SQDepthLevel is now part of gdcmHeader constructor
1507 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1508 tree-like structure of a Dicom Header.
1509 * FIX Test code cleaning
1511 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1512 * ENH: Adding automatic testing
1513 1. Need a DartConfig.cmake to submit to public
1514 2. Add a test driver gdcmTest.cxx
1515 3. gdcmTestMain, an helper for the main test driver gdcmTest
1516 4. Files in Test don't have a main anymore, this becomes interesting
1517 when we add more and more tests, thus dsw don't have to load
1519 * ENH: Adding a GDCM_DATA_ROOT for testing
1520 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1521 one file instead of seven + some small cleanup
1523 2004-04-22 Jean-Pierre Roux
1524 * ENH Minor changes to the Print() methods.
1525 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1526 Header printing. Example given with :
1527 > PrintHeader fileName 2 new
1528 (SQ based tree-like structure still to be done for the Header ...)
1530 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1531 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1532 1. I have added some unsigned where needed
1533 2. Some function parameter not used -> (void)
1534 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1535 4. g++ don't like character '\' in comment
1536 5. #define jpeg_create_decompress jCreaDecompress
1537 this really need to be fixed
1538 6. virtualize destructor of gdcmObject ... leakage
1539 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1540 this also really need to be fixed
1541 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1542 remove compression file
1543 (as we only do decompression, right ?)
1544 * ENH: Change malloc/calloc/free with c++ equivalent
1546 2004-04-21 Jean-Pierre Roux
1547 * FIX gdcmHeaderHelper::GetXSpacing
1548 when a single value is found (bug ?), xpacing is now
1549 defaulted to yspacing
1551 2004-04-19 Jean-Pierre Roux
1552 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1553 * ENH add parameters :
1554 bool exception_on_error = false,
1555 bool enable_sequences = false,
1556 bool ignore_shadow = false
1557 to the gdcmFile constructors to be full gdcmParser compliant
1558 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1559 to allow reading of PAPYRUS 3.0 files
1561 2004-04-06 Jean-Pierre Roux
1562 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1564 2004-04-02 Jean-Pierre Roux
1565 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1566 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1567 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1569 2004-03-30 Jean-Pierre Roux
1570 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1571 for ACR file, written out as DICOM files (hope so...)
1573 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1574 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1575 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1576 moved to base class gdcmParser and only the specialisation is kept
1578 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1579 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1580 already does the job.
1581 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1582 (to be consistent with gdcmParser::WriteEntries).
1584 2004-03-30 Benoit Regrain
1585 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1586 upate of the object's instance. It's passed to 2 in the unfavorable
1587 case : one in the ExecuteInformation, one in the ExecuteData
1589 2004-03-29 Jean-Pierre Roux
1590 * ENH : Check on file type to be written moved
1591 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1592 * FIX : gdcmObject::ResetBoundaries now stops properly
1593 when end-of-list is reached
1594 : gdcmVersion modified (as Benoit Regrain asked)
1596 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1597 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1598 * src/gdcmUtil.cxx: added forgotten iostream include.
1599 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1600 equivalent to ExplicitVR in existing code).
1602 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1603 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1604 now contains all the gdcmGlobal related code.
1605 * minor coding style and doxygenation changes.
1607 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1608 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1609 now contains all the Debug related code.
1610 * minor clean-up of includes in src/*.cxx
1611 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1612 CreateCleanString) removed.
1613 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1614 * Doc/DoxyMainPageUser.txt added.
1615 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1616 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1617 src/gdcmDirList.cxx)
1619 2004-03-24 Jean-Pierre Roux
1620 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1622 2004-03-23 Jean-Pierre Roux
1623 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1624 big endian made volumes
1625 * ENH Now gdcmParser constructor and destructor are protected to forbid
1626 end user to instanciate class gdcmParser
1627 (only gdcmHeader and gdcmDicomDir are meaningfull)
1629 2004-03-22 Benoit Regrain
1630 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1631 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1632 gdcmSerie to gdcmDicomDirSerie
1634 2004-03-19 Jean-Pierre Roux
1635 * ENH Now the tree-like structure describing a DICOMDIR comming from
1636 an already existing DICOMDIR file is consistent with
1637 the home-made tree-like structure build ex-nihilo
1638 or build from the files held (recursively) in a Directory
1639 functions gdcmDicomDir::CheckBoundaries()
1640 gdcmObject::SetBoundaries() added
1642 2004-03-17 Jean-Pierre Roux
1643 * REM (Eric Boix bug) : removal of meaningless
1644 gdcmDicomDirImage::NewImage function.
1645 * FIX now file names and directory name are written properly in the
1647 * FIX now gdcmDicomDir constructor may be call without any trick
1650 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1651 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1652 of gdcmDicomDirImage::NewImage as empty function.
1654 2004-02-28 Jean-Pierre Roux
1655 * ENH add gdcmDicomDir:NewPatient
1656 add gdcmDicomDirPatient:NewStudy
1657 add gdcmDicomDirStudy:NewSerie
1658 add gdcmDicomDirSerie:NewImage
1659 to allow making gdcDicomDir object.
1660 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1661 (as opposite to the gdcmHeader chained list)
1663 2004-02-11 Benoit Regrain
1664 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1665 when using from python
1667 2004-02-10 Benoit Regrain
1668 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1669 * FIX : in gdcmDicomDir when the directory is empty
1670 * ENH : add callback and methods to get the progression of dicomDir
1673 2004-02-06 Jean-Pierre Roux
1674 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1675 - GDCM_META added to gdcmDicomDirType
1676 - class gdcmMeta created
1677 * ENH : - A brief summary is now displayed at the beginning of
1678 'testDicomDir' to help disaster magnitude estimation
1679 * REM : Now useless Test/explDICOMDIR.cxx
1681 2004-02-05 Benoit Regrain
1682 * ENH : add methods in gdcmObject to get the hash table or the list of
1684 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1685 * FIX : wrapping python for TagHeaderEntryHT
1687 2004-02-04 Benoit Regrain
1688 * FIX : even length for some strings when writting the dicom dir
1689 * FIX : sort the images in the dicom dir
1690 * FIX : Bug fix for python use of dicom dir
1691 * ADD : a python demo
1693 2004-02-04 Jean-Pierre Roux
1694 * FIX : Final solution (?) for icone embedded images
1695 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1696 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1697 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1698 gdcmData/gdcm-MR-SIEMENS-16.acr1
1699 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1700 to make full checking easier
1702 2004-02-04 Benoit Regrain
1703 * FIX : WriteEntries : coding style & logic in parameters
1704 * FIX : Set the elements to create the DicomDir in a dictionary file
1706 2004-02-03 Benoit Regrain
1707 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1708 * gdcmDicomDir : add the load of directory
1709 * Bug fix and print add-on
1711 2004-02-03 Jean-Pierre Roux
1712 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1713 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1714 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1715 * FIX gdcmParser.cxx : 'group length' elements are now considered
1716 as integers, even for shadow groups, when file is Implicit VR
1718 2004-02-02 Jean-Pierre Roux
1719 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1721 of the last synonym :-(
1722 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1724 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1725 * FIX taking into account the possible 7fe0,0010 multiplicity
1726 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1727 to allow removal of references to 7fe0,0010, to deal with
1728 ACR-NEMA images, when 0028,0200 is meaningfull
1730 2004-01-31 Jean-Pierre Roux
1731 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1732 no longer writes 'Un' on disk
1733 * FIX SQ elements with actual length are now dealt with corectly
1734 * FIX gdcmFile::WriteBase make the difference, for color images, between
1735 the length (for Palette expanded images)
1736 and Raw Length (non expanded image + Palette)
1737 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1738 (that broke Write). Replaced by UL.
1739 Aware user will reload the field if he
1740 thinks it's necesssary
1742 2004-01-30 Jean-Pierre Roux
1743 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1744 when 'dirty Acr' is found, to be compliant with the new
1745 IsReadable() methods.
1747 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1748 (no DOUBLE images in kosher DICOM,
1749 but so usefull for people that miss them ;-)
1751 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1752 DICOMDIR related utilities (not checked as Windoze compliant)
1754 2004-01-28 Jean-Pierre Roux
1755 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1757 2004-01-27 Jean-Pierre Roux
1758 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1759 to allow skipping the shadow elements, to save memory space.
1760 The TRUE value for this param has to be used
1761 with a FALSE value for the 'enable_sequence' param.
1762 ('public elements' may be embedded in 'shadow Sequences')
1763 * gdcmHeader methods now deal with 'embedded icones images' in the header
1764 (even when an 'icone image sequence' is announced by the
1765 element (0x0088,0x0200), but there is NO icone at all ...
1767 * gdcmHeader sometimes Image Location value doesn't follow
1768 the supposed processor endianity (see gdcmData/cr172241.dcm).
1771 * gdcmHeader add the method
1772 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1773 to get *all* the Header Entries with the same tag.
1774 GetHeaderEntrySameName is probabely *useless*
1775 (no meaning : Name is *not* an identifier within the Dictionnary)
1777 2004-01-26 Benoit Regrain
1778 * Bug fix in the print of hexadecimal representations. Remove long fields
1779 in the print and add a third level of print to print them
1781 2004-01-23 Benoit Regrain
1782 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1783 * Bug fix on test suite after remove the strip made on not string fields
1784 * Split the IsReadable method between gdcmParser which test that the file
1785 is dicom and gdcmHeader which test that it's an image file
1787 2004-01-22 Benoit Regrain
1788 * DicomDir : clean code, add methods, set variables in protected or private
1789 * gdcmUtil : bug fix for the clean string method
1791 2004-01-19 Benoit Regrain
1792 * Add the use of shadow dictionaries
1793 * bug fix and coding style
1795 2004-01-19 Benoit Regrain
1796 * src/gdcmFile.cxx : bug fix concerning the close of file
1797 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1798 * Add the update of header entries using the shadow library
1800 2004-01-19 Benoit Regrain
1801 * removal of file gdcmHeader2.cxx
1802 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1803 inheriting from gdcmParser. This split is to prepare the integration
1804 of dicom dir parsing
1805 * bug fix under python
1807 2004-01-16 Jean-Pierre Roux
1808 * REM removal of class gdcmHeaderEntrySet
1809 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1810 * ADD add file gdcmHeader2.cxx
1811 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1813 2004-01-15 Benoit Regrain
1814 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1815 entries created while parsing the header. Thus, they will be destroyed
1816 when the gdcmDictSet will be destroyed
1817 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1820 2004-01-15 Benoit Regrain
1821 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1822 made a fatal error because of the memory release at the end of program.
1823 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1824 some memory and vtk seems to have some problems with that.
1825 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1827 2004-01-14 Benoit Regrain
1828 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1829 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1830 * src/*.[h|cxx] : make changes due to class name changes
1831 * gdcmPython/demo/*.py : bug fix due to method names
1833 2004-01-13 Benoit Regrain
1834 * src/*.[h|cxx] : coding style
1835 * vtk/*.[h|cxx] : coding style
1837 2004-01-13 Benoit Regrain
1838 * gdcmPython/testSuite.py : test the readable flag of file for tests
1839 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1840 It's lied to the stl compilation by MSVC (windows, always windows...)
1841 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1843 2004-01-12 Benoit Regrain
1844 * src/*.h : add comments
1845 * src/gdcmDictSet.h : set the method BuildDictPath in public
1846 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1847 directly setted in the source code
1848 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1851 2004-01-09 Benoit Regrain
1852 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1853 * setup.py : use a reference to gdcmVERSION
1855 2004-01-07 Benoit Regrain
1856 * Modification to compile with the distutils.
1859 2003-12-10 Benoit Regrain
1860 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1861 can use a gdcmHeaderHelper to load data
1862 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1863 made in the source code
1865 2003-12-10 Benoit Regrain
1866 * Update Windows projects and .cvsignore files
1868 2003-11-12 Jean-Pierre Roux
1869 * ENH gdcmHeader constructor has one more parameter (default value : false)
1870 that allows the user to 'go inside' the SeQuences only
1872 gdcmElValSet:Print takes it into account
1874 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1875 * ENH: Update gdcmPython/CMakeLists
1876 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1877 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1879 2003-11-10 Jean-Pierre Roux
1880 * FIX : gdcmHeader::LoadElements is now based
1881 on the ListTag listElem member,
1882 not longer on the TagElValueHT tagHt member
1883 * ENH : PrintPubElVal shows (temporarily) both results,
1884 with the tagHt member and the listElem member.
1885 (it's easier to 'see' the problems when using Printheader)
1887 * FIX : old private member LgrElem is now splitted into
1888 ReadLength : Length actually found on disk (updated only
1889 if bug fixing is necessary), for internal
1891 UsableLength : Updated by FixFoundLength, to fix a bug
1892 or to allow Parser going on.
1893 Will allow to re-write a kosher header when a SeQuence
1894 with a length (not 0000) is found
1895 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1896 because gdcmElValSet::Add does not update ListElem
1899 2003-11-07 Jean-Pierre Roux
1900 * FIX misstyping in Transfert Syntax name table
1901 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1902 when they have an actual length (not 0000 nor FFFFF)
1903 (Nobody should care of it, but DICOMDIR explorers)
1905 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1906 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1908 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1909 * ENH: vtkGdcmReader now supports LUT !
1910 (vtkgdcmViewer for now is not able to use them though)
1912 2003-11-05 Jean-Pierre Roux
1913 * in testSuite.py : new files names for checking the package
1914 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1915 that returns the pixel area size to the *aware* (vtk) user
1916 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1918 2003-11-05 Benoit Regrain
1919 * in testSuite.py : Modify the rules for checking the paths
1920 : Explicit error messages
1921 * in __init__.py : Related modif
1923 2003-11-03 Jean-Pierre Roux
1924 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1925 to be used by aware (vtk) users that want to manage
1926 LUT (and no to turn the PALETTE image into an RGB pixels one)
1927 * GetPixelType now returns 8U for 24 Bits images
1928 (vtkGdcmReader compliant)
1930 2003-10-31 Jean-Pierre Roux
1931 * Removal of *all* gdcmData images and add them again
1932 in order to loose the 'history' of un-anonymised images
1934 2003-10-31 Jean-Pierre Roux
1935 * RMV : removal of useless jBitsInJsample.h
1936 for both 8 and 12 Bits JPEG Lossy Libraries
1938 2003-10-31 Jean-Pierre Roux
1939 * ENH : Add the functions gdcmFile::GetImageDataRaw
1940 gdcmFile::GetImageDataIntoVectorRaw
1941 that act as GetImageData and GetImageDataIntoVector
1942 except the making of an RGB Plane from Gray Plane + LUT
1943 Intended to aware (vtk) users who know how to manage
1946 GetLUTRGBA return a R,G,B,A LUT if any
1947 lgrTotaleRaw gives the 'Raw' length
1948 GetImageDataRaw returns the gray Plane
1949 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1950 (They stay Grey, just like with other Dicom viewers :-(
1952 2003-10-30 Jean-Pierre Roux
1953 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1955 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1956 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1957 being coherents dicom files.
1959 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1960 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1962 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1963 * ENH: Two steps is necessary to please VC++ compiler...
1964 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1965 * ENH: Add include dir to medcon lib
1966 * FIX: only one function is being exported for now !
1967 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1969 2003-10-29 Jean-Pierre Roux
1970 * adding gdcmHeader::GetLUTRGBA
1971 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1972 --> Mathieu, the modif u're waiting for is not yet committed
1973 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1975 2003-10-27 Jean-Pierre Roux
1976 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1977 00191113.dcm DermaColorLossLess.dcm
1978 MxTwinLossLess.dcm RadBWLossLess.dcm
1979 * ENH: For version prior to vtkImageViewer2 -r 1.19
1980 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1982 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1983 * Removal of ido stuff in CMakeLists.txt
1985 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1986 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1987 * FIX: remove a call to ->Modified ... see comments
1988 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1990 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1991 * FIX: Problem with path for libvtkgdcmPython
1992 * ENH: Try adding a search script for python site-package
1993 * RMV: Remove some file from medcon lib that are not necessary
1994 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1995 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1996 * FIX: More pragma disable fro VC++,
1997 I don't think I break something as it is also disable in VTK/ITK.
1998 But it fasten debug compilation time.
2000 2003-10-23 Jean-Pierre Roux
2001 * gdcm now deals with 16 Bits Run Length Encoded images
2002 (they are compressed as 2 planes images,
2003 one for the high Bytes, the other for low Bytes)
2005 2003-10-22 Jean-Pierre Roux
2006 * Now CheckRead takes into account :
2007 - the bugged 'Leonardo' Siemens images
2008 - the XA images, sent thru the burning VPRO station
2009 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2012 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2013 * FIX: When copying a Makefile.am to CMakeLists.txt
2014 one should remove the '\'
2016 2003-10-22 Jean-Pierre Roux
2017 * in gdcmData adding a bugged 'Leonardo' Siemens image
2018 (wrong lengths in header)
2019 OK with gdcm, KO with the other viewers :-)
2020 * add a GE dlx XA image, thru the VEPRO burning station
2023 2003-10-21 Jean-Pierre Roux
2024 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2025 for a brutal checking of vtkgdcmViewer compliance
2027 2003-10-21 Jean-Pierre Roux
2028 * add the files for 'xmedcon' Jpeg Lossless library
2029 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2031 2003-10-21 Jean-Pierre Roux
2032 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2034 2003-10-21 Jean-Pierre Roux
2035 * garbage Siemens 'Leonardo' images dealt with
2036 (the patch is easy to remove)
2037 * cosmetic changes to avoid warnings
2039 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2040 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2041 no need to press 'r' now.
2043 2003-10-20 Jean-Pierre Roux
2044 * upgrade of checkRead.sh checkWrite.sh according
2045 to new Jpeg Lossless decompressor
2046 * add US.3405.1.dcm, a genuine RGB medical file ...
2047 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2048 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2050 2003-10-15 Jean-Pierre Roux
2051 * general anonymisation in gdcmData
2052 * adding the 'color files' from
2053 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2054 * adding some well knowed bugged-header images
2055 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2056 waiting for their inclusion in Python testsuite
2058 2003-10-15 Jean-Pierre Roux
2059 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2060 no longer seg faults when file is not found
2062 2003-10-14 Jean-Pierre Roux
2063 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2066 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2067 * TODO: *.in file to genereate a UseGDCM later
2069 2003-10-14 Jean-Pierre Roux
2070 * Some supposed-to-be Dicom Images have no preamble.
2071 OpenFile takes it into account
2072 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2073 * Missing elements added in dicomV3.dic
2074 (just to be affraid : have a look at
2075 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2076 and do it again next year ;->
2078 2003-10-13 Jean-Pierre Roux
2079 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2080 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2081 But there are NOT. It's fixed !
2083 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2084 * FIX: "jpeglib.h" was not found on VC++
2085 * FIX: vtkgdcm was not being installed
2087 2003-10-10 Jean-Pierre Roux
2088 * ENH : OpenFile closes the file if it *really* doesn't look like
2089 an ACR-NEMA / DICOM one.
2090 * FIX : testWrite no longer writes an empty file if the source file
2091 is not gdcm Readable
2092 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2095 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2096 * FIX: CMake generate now documentation
2097 * ENH: out of source doc build !
2098 * ENH: Generate both user and dev documentation
2099 * ENH: Should work on windows too
2100 * ENH: Only one doxygen config.in file is needed
2101 * FIX: make install should be ok now on ùnix plateform
2102 * FIX: PATH to dictionary was wrong (missing /)
2103 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2105 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2106 * vtkGdcmReader is now able to read rgb dicom file.
2107 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2108 * added a gdcmViewer to vtk test, use mouse to control
2109 window level & window width
2111 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2112 * CMake-ification of gdcm, we have now two build system
2113 * FIX: on cygwin Wsock32 doesn't exist
2114 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2116 2003-10-06 Emanuel Ollart
2117 * FIX : compilation process wad broken.
2118 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2120 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2121 * change gdcmViewer -> vtkgdcmViewer
2122 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2124 2003-10-06 Jean-Pierre Roux
2125 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2126 ( e.g : well known GE images with a wrong elem length,
2127 : Philips MRI Images with a wrong Huffman table)
2128 * still to be done : allow the reading of bugged LEONARDO Siemens images
2130 2003-10-03 Jean-Pierre Roux
2131 * Odd length strings are padded with '\0' (not with spaces,
2132 to remain compliant with already defined strings,
2133 like Transfert Syntax UID and others)
2135 2003-10-03 Jean-Pierre Roux
2136 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2137 to allow displaying RGB images (not only by affim ;-)
2139 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2140 * vtkGdcmReader is now able to read rgb dicom file.
2141 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2143 2003-10-03 Jean-Pierre Roux
2144 * A few nasty patches to allow the reading of a lot of nasty images
2145 ( e.g : well known GE images with a wrong elem length,
2146 : Philips MRI Images with a wrong Huffman table)
2147 * still to be done : allow the reading of bugged LEONARDO Siemens images
2149 2003-10-03 Jean-Pierre Roux
2150 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2152 2003-10-03 Jean-Pierre Roux
2153 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2154 to allow displaying RGB images (not only by affim ;-)
2156 2003-10-03 Jean-Pierre Roux
2157 * gdcmFile::GetImageDataIntoVector now
2158 - deals with MultiFrames MultiFragments Run Length Encoded files
2159 - deals with YcBcR (YBR_FULL) files
2160 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2161 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2163 (no sample found :-(
2165 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2166 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2167 Two reasons: - clear things
2168 - third parties acces gdcm through header files, so won't
2169 suffer anymore VC++ complains
2171 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2172 * add argv[1] in testvtkGdcmReader.cxx
2175 2003-09-24 Jean-Pierre Roux
2176 * The lines are now eigthy characters long.for
2177 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2179 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2180 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2181 char* to std::string. Thus, the use of strdup becomes useless. (see
2182 previous commis of Malaterre)
2183 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2184 before the last Malaterre's commit.
2186 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2187 * This commit should fix the Debug building under VC++, the problem
2188 was mainly a mixture of debug and release lib being loaded at startup.
2189 * I also remove a depency to a specific C function: strdup. Because I had
2190 to force the link to msvcrtd (whereas strdup is in libc).
2192 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2193 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2194 located in the gdcmCommon.h file. All use of reference of tha has been
2195 changed to now use the variable GDCM_UNFOUND.
2197 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2199 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2200 Dicom dictionary. The test suite can now be run again. Note:
2201 I'm note very happy with the " (RET)" changes. I believe this
2202 RETAINED comment should be dropped when parsing the dictionary.
2203 - PACKAGER corrected
2205 - AUTHORS updated and now in alphabetical order
2206 * Makefile.am now exports gdcm.dsw for Windoze users.
2208 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2209 * cygwin complains about missing std:: in subdir Test/
2211 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2212 * remove some methods that are now in gdcmHeaderHelper
2214 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2215 * vtkGdcmReader set spacing and origin correctly
2217 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2218 * Fix a few delete/delete[] mismatch
2220 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2221 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2222 interpretation to data given by gdcmHeader. For instance there are
2223 heuristics to get informations (look at different places).
2224 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2225 sorting DICOM images based on different strategies.
2226 * modified Makefiles accordingly.
2228 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2229 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2230 when building in debug mode
2231 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2232 src/win32/gdcmdll.dsp
2233 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2235 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2236 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2239 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2240 * src/win32/libgdcmjpeg12.dsp was not dos format
2241 * src/win32/libgdcmjpeg12.dsp :
2242 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2243 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2245 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2246 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2248 * src/gdcmFile.cxx : bug fix in affectation type
2249 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2250 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2251 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2252 symbols... future problem ?
2254 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2255 * src/win32/libgdcmijpeg12.dsp was missing
2256 * modified gdcm.dsw accordingly
2258 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2259 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2261 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2262 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2263 commit of JPR (before his hollidays to facilitate our work).
2264 * setup.py : bug fix in code. Modifications made while the last commit
2265 of JPR. The code hasn't been tested before the commit... it's so
2266 useless to make that (for best programmer that is JPR) !!!
2268 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2269 * tagged the current version as Version0_3 (i.e. version 0.3)
2271 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2272 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2273 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2274 * *.dsp : modifications to use new libgdcmijpeg8 library
2275 * setup.py : bug fix on VTKPATH variable
2276 * PACKAGER : adding all concerning windows
2278 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2279 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2281 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2282 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2283 test suite reported error.
2284 * PACKAGER file added (describes what a packager must do when
2285 packaging a new release).
2286 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2287 * configure.in: upgraded version number to 0.3.0
2288 * fixing build of rpm (through rpm -ta):
2289 - Doc/Makefile.am exports proper doxygen files
2290 - src/jpeg/libijg8/Makefile.am exports the include files.
2292 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2293 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2294 * src/gdcmHeader.h : formatting code
2296 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2297 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2298 We were obtaining error message from vtk. Now, creation of file list
2299 is made in an internal list to prevent this problem.
2300 Bug fix when output is empty.
2301 Bug fix in update of progress value. Previous commit for this was a bad
2303 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2305 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2306 * src/gdcmHeader.h : added method to get the file name
2307 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2308 files. Added method to remove all files on the input
2309 Added FIXME comment concerning the bad parsing of header made by
2310 ExecuteInformation method (in ExecuteData method)
2312 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2313 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2314 when using make instal.
2315 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2316 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2318 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2319 * setup.py : adding include dir of jpeg lib to compile all sources
2320 * */Win32/*.dsp : JPR fix for windows compilation
2322 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2323 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2325 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2326 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2328 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2329 * setup.py is again effective on un*x (takes into account the
2330 addon of the jpeg library)
2331 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2332 * Doc/Doxy* updated (includes above enhancements)
2333 * INSTALL now points to web documentation
2335 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2336 * src/gdcmHeader.h doesn't make unnecessary reference to
2338 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2340 * src/gdcm*.[cxx|h] :
2341 - to allow compilation with gcc 3.x
2342 -- clean up of STL usage (added explicit usage of std::)
2343 -- small fixes on exceptions.
2344 Note: linking not tested !
2345 - clean of doxygen comments to avoid warnings at documentation
2347 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2348 dependent convertion).
2350 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2351 * Clean up of previous JPR garbage commit (not even commented in the
2353 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2354 - moved all jpeg related files from src to src/jpeg/libijg8, with
2355 addition/modification of Makefile.am and configure.in.
2356 - the testSuite is still brain damage (not guilty).
2358 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2359 * WrapVTK.py : modifications to get correctly vtk source files to
2361 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2362 (FileName -> Filename)
2364 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2365 * vtk/vtkGdcmReader.[cxx/h]:
2366 - UpdateProgress method should now be effective
2367 - removed the limitation on having only images loaded (as opposed
2369 - when building a stack of images/volume, a lesser number of
2370 gdcmHeader and gdcmFile instances should be used (hopefully
2371 accelerating things).
2372 - when building a stack of images/volumes, files which are not
2373 loadable (wrong path-filename, wrong permissions on existing file,
2374 or file not parsable by gdcm) are replaced with a black image
2375 in the stack (for the caller to notice the problem).
2377 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2378 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2380 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2381 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2382 between standard library (std) and vtk library (problems are found
2383 under Windows... thanks Windows !)
2385 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2386 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2388 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2390 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2391 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2393 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2394 * When compiling with distutils (see setup.py) the C++ compiler is
2395 called with different flags than the default ones (with automake).
2396 In order to fix all those warning, I compiled gdcm with the command
2397 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2398 and went for warning fixes:
2399 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2400 up from unused variables.
2401 - vtk/vtkGdcmReader.cxx: potential bug fix.
2402 * src/gdcmHeader.h: Doxygen warning cleanup
2404 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2405 * gdcmPython/gdcm.i:
2406 - typemaps correction to take into account the systematic replacement
2407 of "using namespace std" with std:: prefix e.g. std::list,
2408 std::string... (cf changes of 2003-05-21).
2409 - gdcmGlob global variable of type gdcmGlobal (defined in
2410 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2411 exported to Python a as cvar.
2412 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2413 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2414 gdcmDictSet.GetPubDictTagNames() and
2415 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2416 C++ static methods).
2417 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2418 with the above changes.
2420 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2421 * setup.py, manifest.in : bug fix under linux
2423 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2424 * Modification of setup.py to compile vtk part too. Then, we have 2
2425 wrappers which must work with same distutils. For that, we have a
2426 generic distutils in distusiltsWrapping.py ; with :
2427 - build_extWrap class to wrap generically all extensions,
2428 - ExtensionWrap base class for all wrapping extension that contains
2430 - Wrapper interface which wrap sources
2431 + In WrapSwig.py we have extension and wrapper for Swig
2432 + In WrapVTK.py we have extension and wrapper for VTK
2433 * MANIFEST.in : modifications to consider vtk directory and new python
2434 files for compilation
2436 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2437 * Added python wrappers of vtkGdcmReader vtk class (see the
2438 source in vtk/vtkGdcmReader.cxx) :
2439 - vtk/Makefile.am now builds a library
2440 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2441 python library (as opposed to _gdcm.so wich are the python
2442 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2443 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2445 - configure.in has an additional flag --enable-vtk that needs
2446 to be set to enable compilation of vtk related code, that is:
2447 + vtk/vtkGdcmReader.so and
2448 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2449 + gdcmPython/vtkgdcmPython.so (see above)
2450 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2451 be read when compressed or when HighBit + 1 != BitsStored),
2452 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2453 the usage of the python wrapper of vtkGdcmReader vtk class.
2454 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2455 * src/*.[h] all occurences of stl classes are now prefixed with
2456 std::, and all occurences of "using namespace std;" where removed.
2457 This is to avoid pollution of global namespace in included files.
2458 Apparently vtk does not avoid this pitfall: when using both
2459 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2460 collision of various stl members (principally cout...).
2461 * gdcmPython/testSuite.py now cleanly removes temprory generated
2463 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2464 comply with above changes)
2466 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2467 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2468 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2469 vtk data structure (an image Flip was required).
2470 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2471 * cosmetic changes in documentation.
2473 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2474 * src/gdcmHeader.cxx: the constructor no longer exits when an
2475 unexisting file is given as argument.
2476 * The subdirectory Data (containing all the images used for the
2477 test suite) is not part of this repository anymore. A new module
2478 containing those images is now available at
2479 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2480 with the name gdcmData.
2481 All the python scripts (including the package initialisation file
2482 gdcmPython/__init__.py) were adapated to take this change into
2483 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2485 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2486 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2487 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2488 demo of the usage of this class.
2489 Compilation of this vtk part is only done when using the --enable-vtk
2490 at configure (or autogen.sh) stage.
2492 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2493 * More memory link related corrections and documentation fixes.
2495 - maximum info is obtained with a command of the form:
2496 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2497 --show-reachable=yes PrintHeader
2498 - the remaining reachable blocks seem to come from the STL
2499 allocation scheme through the usage of map and list. It looks
2500 like this memory cannot be freed but it is not a memory leak
2501 (in fact further invocation to the STL would recollect the
2502 unused memory allthough it cannot explicitely be freed).
2503 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2504 of displaying an image parsed with gdcm and displayed with VTK.
2505 Note: some images don't seem to work e.g.
2506 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2507 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2508 Allthough this weakens the semantics, it is a ditch attempt to
2509 make gdcm more thread friendly.
2511 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2512 * Memory link hunt (by using valgrind through the command
2513 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2514 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2515 gdcmHeader::_dicom_vr.
2516 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2517 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2519 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2521 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2522 * src/Makefile.am now exports all the necessary include files at
2526 * UpdateGroupLength replaced by new one
2529 * UpdateGroupLength re-written using H-Table
2530 (named UpdateGroupLengthNew untill checks are over)
2532 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2533 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2534 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2536 - gdcmHeader::GetPubElValSet removed.
2537 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2538 UpdateGroupLength, WriteElements, Write.
2539 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2540 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2541 carried the same semantics.
2542 - src/gdcmHeaderIdo.cxx changed accordingly.
2543 - gdcmFile::WriteBase now regroups all the codes from previous
2544 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2545 - enum FileType moved to gdcmCommon.h
2546 * src/gdcmHeader.cxx AddDefault trashed
2547 * gdcmGetXSize added
2548 * getimageDataSize now calls gdcmGetXSize
2549 * Test/*.cxx changed to agree with above changes
2551 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2552 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2553 (to avoid double call by end user).
2554 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2555 by end user, since gdcmHeader::gdcmHeader now handles it.
2557 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2558 * gdcm/Doc many doxygen changes:
2559 - Doxyfile now has two different versions, DoxyfileUsers that generates
2560 the html.users end users oriented documentation and
2561 DoxyfileDeveloppers that generates the html.developper developper
2562 oriented documentation.
2563 - README changed accordingly
2564 - requirement.txt removed (old design info moved to TODO).
2565 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2566 DoxyMainPage.txt, DoxyPython.txt provide more information.
2567 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2568 be updated by simply regenerating the docs with doxygen and copying
2569 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2570 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2571 all the tests in the form "if (<map>.count() >1)" were removed.
2572 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2573 ill-formed documentation sections.
2574 * src/gdcmHeader.cxx: ditto
2576 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2577 * setup.py fixed for un*x (needed macro for stdint.h)
2578 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2579 un*ces with sh-utils test utility.
2580 * gdcmPython/demo/test.py renamed to PrintHeader.py
2581 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2582 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2583 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2584 * src/gdcm*.cxx JPR's bad inclusion fixed.
2586 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2587 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2588 * gdcmPython/demo/test.py changed accordingly.
2590 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2591 * gdcmPython/Makefile.am fixed linking against libstdc++
2592 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2593 * Swig subdir (historical tests of swig version 1.3.17++) removed
2594 * Test/testChangeEntete.cxx some lines commented out in order to make
2596 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2597 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2599 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2600 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2601 hence the user doesn't need this explicit call.
2602 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2603 i.e. LoadElements() call removed.
2604 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2605 - src/Makefile.am declares the proper flag for g++.
2606 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2607 for adding user defined new tags.
2608 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2609 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2610 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2612 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2613 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2614 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2615 src/Makefile.am : the project should properly compile and install
2616 with the autotools, included the python wrappers part.
2617 * gdcm.spec.in : added a spec file for RPM packaging.
2619 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2620 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2622 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2623 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2624 to exported to the environement (see gdcmPython/testSuite.py
2626 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2627 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2628 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2629 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2630 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2632 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2633 * gdcmPython/__init__.py doesn't crash anymore when running in
2634 in InstallMode or PreInstallMode but with an environement given
2635 value of GDCM_DICT_PATH.
2636 * src/gdcmDictSet.[cxx/h] coding style.
2638 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2639 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2640 * src/gdcm.h general comments moved to TODO, and README
2641 * src/gdcm.h should now be seen as a user commodity (including it
2642 should suffice to fully use gdcm). It is nowhere including within
2643 any of the kernel files src/*.cxx and src/*.h.
2645 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2646 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2647 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2649 * src/gdcm*.cxx only include their corresponding include file
2650 (as opposed to gdcm.h)
2651 * gdcmPython/gdcm.i changed accordingly
2652 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2653 the autogen.sh generated "make snapshot" command to work.
2654 * autogen.sh removed history related references to crea package.
2656 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2657 * distutilsSwigCPlusPlus.py work around some swig portability
2660 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2661 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2662 was done in a last ditch attempt to get setup.py _really_
2663 operationnal. The python/gdcmPython layaout add the advantage
2664 of hidding away the python related distutils specific files
2665 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2666 Alas, the src directory was out of scope (i.e. it's relative
2667 position to setup.py was ../src) which made things impossible to
2668 handle (see previous version of python/setup.py). Crossing fingers...
2670 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2671 * python/setup.py now works on Un*x. (harder than I thougth)
2672 * python/distutilsSwigCPlusPlus.py can now have include files
2673 among the list of sources.
2675 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2676 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2677 * modifications in MSVC projects
2679 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2680 * As stated by the first lines of Test/ExceptionAndPython/README, it
2681 looks like we can move back to original usage of exception within
2682 src/gdcm* and hence remove the errno stuff that was introduced
2683 as a quick and dirty fixture of this problem (added to the TODO).
2684 * Doc/Doxyfile configuration file for Doxygen and corresponding
2685 README file for usage added.
2686 * Test/testWrite.cxx added. This new test comes from a split of
2687 test.cxx that is now reverted to its original purpous i.e.
2688 testing the proper parsing of a Dicom related file.
2689 testWrite.cxx concentrates on testing the IO part of gdcm.
2690 * Test/bug1.cxx (containing a bug on WIn32) added.
2691 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2692 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2693 whose purpose is to publish the content of the TagNames of the
2694 Dicom public dictionnary were not accessible without an
2695 instance of class gdcmHeader.
2696 - those methods are now static methods of gdcmDictSet and hence
2697 require no instances at all to be invocated.
2698 - within gdcmDictSet this change required to change some method
2699 to class methods (i.e. are now static) among which SetDictPath
2700 (renamed to BuildDictPath) and LoadDefaultPubDict.
2701 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2702 the above changes by calling the new method classes of gdcmDictSet.
2703 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2704 the above to be effective.
2705 * python/gdcmPython: in order to wrap properly the above changes
2706 for Python, swig version now needs to be > 1.3.17.
2707 * python/gdcmPython/Makefile fixed to adapt itself to new
2708 configure/make shema introduced by Johan Montagnat (thanks for the
2709 contribution). Alas this Makefile cannot be turned into a proper
2710 Makefile.am without some heavy changes in the configure.in
2711 (for python dectection).
2712 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2713 now avoids publishing the empty entries.
2715 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2716 * python/setup.py : bug fix concerning install under windows
2717 ExtraPath reused :-P
2718 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2720 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2721 * Dicts/dicomV3.dic : remove double spaces !!!
2722 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2723 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2726 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2727 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2728 method. Doxygenation.
2729 * src/gdcm.h clean up of JPR spurious comments.
2731 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2732 * python/distutilsSwigCPlusPlus.py now properly collects the
2733 shadow classes generated by "swig -c++" (gdcm.py in our case)
2734 when using "python setup.py install".
2735 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2736 reexports the working classes.
2737 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2738 by the classical C errno scheme. This is to prevent an obscure
2739 behavior of the python wrappers when importing wxPython.wx prior
2740 to gdcmPython (which ended up in an abort call). An illustration
2741 of this oddity can be found in the Test/ExceptionAndPython
2742 subdir (see the README file). This problem probably due to
2743 an combination of g++ and dynamic loading.
2744 * added Test/ExceptionAndPython (see above)
2746 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2747 * Changed the layout of the python part to avoid bloating main
2748 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2749 i.e. the distutils arsenal. All the python related stuff is
2750 again in a python subdir, but the package itself is now in
2752 * setup.py was cleaned up:
2753 - pythonIncludePath removed
2754 - python setup.py bdist target is now functional.
2755 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2756 collision with other packages). gdcmPython/demo/*.py changed
2759 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2760 * python subdir moved to gdcmPython (preparation of distutils packaging).
2761 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2762 distutils installer is operational.
2763 * - gdcmPython/__init__.py now properly loads the swig generated
2764 shadow classes (from gdcm.py).
2765 - gdcmPython/demo/*.py changed to import the package gdcmPython
2766 instead of gdcmPython/demo/load.py.
2767 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2769 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2770 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2771 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2772 entries within the associated public Dicom dictionary resp. the same
2773 information but sorted by the fourth field (PAT, IMG, DIR) of the
2775 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2776 are now in the "???" group.
2777 - python/gdcm.i changed accordingly,
2778 - python/demo/printGroupedPublicDict.py added, that gives an example
2779 of the above new functionalities in Python.
2781 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2782 * src/gdcm.h, gdcmHeader.cxx:
2783 - historic references to glib's g_malloc and g_free (#defined)
2784 were definitively removed.
2785 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2786 * src/gdcmElValSet.cxx:
2787 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2788 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2789 - GetElValue(string) renamed to GetElValueByName.
2790 - Added GetElementByName(string).
2791 * src/gdcmHeader.cxx: added
2792 - GetPubElValRepByNumber(guint16, guint16)
2793 - GetPubElValRepByName(string)
2794 - GetShaElValRepByNumber(guint16, guint16)
2795 - GetShaElValRepByName(string)
2796 - GetShaElValByNumber(guint16, guint16)
2797 - GetShaElValRepByName(string)
2798 - GetElValRepByNumber(guint16, guint16)
2799 - GetElValRepByName(string)
2800 - GetElValByNumber(guint16, guint16)
2801 - GetElValRepByName(string)
2802 * Doc/requirements.txt added.
2804 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2805 * Test/Makefile building now depends on the one of libgdcm.so
2806 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2807 pixel data) aware which enables finding the address (offset) of
2808 the pixel data of JPEG encoded DICOM files. This leaves only a single
2809 file in the testSuite whose pixel data address (offset) is unknown.
2810 * python/testSuite.py changed accordingly.
2812 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2813 * VC++ has some strong limitations when working with the STL, as stated
2814 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2815 "Also note that some STL containers (map, set, queue, list, deque)
2816 cannot be exported. [...]
2817 Some STL classes contain nested classes. These classes can not
2819 This is caused by a designed limitation that once a template
2820 class is instantiated, it can not be re-instantiated and
2822 Since our usage of map<> is ubiquitous in gdcm, this "designed
2823 limitation" of VC++ is a pitfall.
2824 Hence the Python wrappers of gdcm cannot be incrementally linked
2825 against the c++ dynamic library. The dirty but only workaround is
2826 to forget about incremental link of dynamic libraries and to generate
2827 the Python wrappers library with the inclusions of the underlying C++
2829 The following modifications concern this matter on Win32/VC++:
2830 - wrapping python correct with standalone wrapped dll (don't use separate
2831 dll under windows !!!!)
2832 - python21_d debug mode enabled (ask Frog how to use it :-)
2833 - NO problem with having an STL member of class for example string in C++
2834 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2835 - Python test of dcmlib in Python is ok under windows on a large set
2837 * removed glib references
2838 * typedef's inserted in gdcm.i for correct swig type management
2840 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2841 * python/demo/*.py load.py extracted from test.py. Added explore.py
2842 that only displays required tags and testAll.py that parses all
2843 the files of the testsuite without using unittest.
2844 * python/testSuite.py other additional test on new files added.
2845 * Data/* new test files added accordingly to the testSuite.
2846 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2847 the vr in the file differs from the one of the dictionary.
2849 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2850 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2851 values, but limits itself to values which are below a user specified
2852 size (by default 1024 bytes).
2853 * python/gdcm.i : elements not loaded (because their size is above the
2854 user specified treshold) are exported with their TagKey as key of the
2855 python dictionary. This enables the testsuite to make some checks
2856 on the unloaded elements (since we have their offset and size).
2857 * python/testSuite.py
2858 - now tests for the existence and proper value of the pixel data
2859 - two new examples added.
2860 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2862 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2863 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2864 aware. See the strategy comments in gdcmHeader::FindeLength().
2865 * Test/test.cxx now accepts a filename as first argument.
2866 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2867 * python/testSuite.py changed to integrate test on above files.
2869 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2870 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2871 the vr was also RET.
2872 * python/testSuite.py more tests added.
2874 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2875 * python/testSuite.py unittest test suite added (uses Data)
2876 * Data/* dcm and acr files for the test suite.
2877 * glib dependance removed from un*x version. We now use ISO C99
2878 7.18 Integer types (see stdint.h)
2879 - python/Makefile, src/Makefile src/gdcm.h
2880 * src/ when an explicit vr (like dicom files) suddenly poped an
2881 implicit element we use to mark the underlying DictEntry of the
2882 concerned ElValue with "Implicit". This strategy was damageable
2883 too the public or provite dictionaries, since some of their vr
2884 would be changed. Since Header::FindLength heavily relies on the
2885 detection by Header::FindVR of falsely explicit elements, I
2886 added an extra ImplicitVr member to ElValue (boolean).
2887 The rest of the changes we the necessary adaptations.
2889 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2890 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2892 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2894 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2895 * Adaptation for porting to VC++:
2897 o forced to use std namespace (for string to be known)
2898 o all class use __declspec export style on WIN32
2899 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2900 (in stdlib.h on Win32 but in std:: for gcc)
2901 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2902 variable GDCM_DICT_PATH.
2903 * src/gdcmHeader.cxx verbose comments made discrete.
2905 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2906 * python/gdcm.i: added a typemap that converts a C++ hashing table
2907 to native Python dictionary.
2908 * python/demo/test.py:
2909 - now uses the native dictionary for exploration of gdcmHeader.
2910 - takes an optional filename argument (the file to parse).
2911 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2912 PubElVals hashing table.
2913 * Dicts/dicomV3.dic removed error prone trailing spaces.
2915 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2916 * Python wrapping process moved away from src/Makefile to
2917 newly created python/Makefile (as well as gdcm.i)
2918 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2919 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2920 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2921 from the environement variable GDCM_DICT_PATH (when existing).
2922 * src/gdcmDict::GetTag bug fix.
2924 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2925 * Straightforward temporary fixes for swig to build the python wrappers.
2926 src/Makefile now has a python working entry [by working we mean
2927 that we can import de shadow classes without errors].
2929 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2930 * hashtest.cxx removed (since allready in Test)
2931 * src/gdcmlib.h renamed to src/gdcm.h
2932 * src/dcm.i renamed to src/gdcm.i
2933 * src/Makefile prepared for python wrapping
2935 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2936 * src/gdcmHeader.cxx :
2937 - Parsing of header is now separated from loading of element values
2938 (see gdcmHeader::LoadElements).
2939 - general clean up of hopefully all file access (creation of
2940 ReadInt16 and ReadInt32)
2942 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2943 * src/gdcmHeader.cxx :
2944 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2946 - SetLgrElem renamed to SetLength
2947 - GetLgrElem renamed to GetLength
2948 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2949 * src/gdcmElValSet.cxx fixed both GetElValue methods
2950 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2951 due to IdoDude was cleaned out.
2953 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2954 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2955 concentrates on finding the value representation (when it exists).
2956 RecupLgr now only finds the element value length, and it avoids
2957 returning the unecessary skL (skipped length).
2958 Also, offsetCourant was simply removed (with taille_fich) since
2959 it was redundant with the File position internals (by using
2960 ftell and fseek). This also made skL (see above in RecupLgr) usage
2962 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2963 on the libido specificities which are handled through class
2965 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2968 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2969 * Truckload of changes. Parsing of header is barely functional
2970 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2972 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2973 * src/gdcmHeader.cxx many addons of low level methods
2975 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2976 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2977 and _IdDcmSWAP_LONG.
2979 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2980 * This corresponds to all the changes decided at the meeting of
2981 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob