1 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
3 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
5 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
6 In ordrer to avoid missbehaviour :
7 . gdcm::DocEntry is now specialized in
8 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
9 - gdcm::ContentEntry (Dicom entry with a 'content')
10 . gdcm::ContentEntry is specialized in
11 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
12 characters value, or integers)
13 - gdcm::BinEntry (Dicom entry with a non strig representable value
14 (user hasn't any longer to thing about the precedence of his dynamic_casts)
16 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * Test/VTKTest*.cxx : bug fix under linux
19 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
21 use with python. Some methods are moved from Document to ElementSet or
22 DocEntrySet. The equivalent methods to ElementSet have been added to
23 SQItem and are virtual in DocEntrySet. Methods that may have the same code
24 in SQItem and ElementSet is directly placed in DocEntrySet
26 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * Test/VTKTest*.cxx : remove the show variable in each test method because
28 it's useless (the viewer variable replace this variable)
30 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * src/gdcmDocument.cxx : bug fix on potential memory leak
32 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
33 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
34 Add ClearXxx methods to remove all the content of the list or map
35 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
37 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
38 * methods ReplaceOrCreate renamed as Insert
39 (nobody will be any longer confused by 'CreateOrReplace')
41 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
42 * Grealty simplify the JPEg decompression, no need to differenciate based on
43 the JPEG possible type (with/without fragment, with/without multiple frame).
44 Everything is done throught the JPEG IO Suspension mechanism in IJG
46 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
47 * Stage 3 of normalization :
48 in order to avoid any missunderstanding while reading method names :
49 - All the methods xxxEntry now deal with dicom Entries
50 - Methods GetEntry splitted into
53 - Method SetEntry renamed as SetEntryValue
54 - Method SetEntryBinArea let as it was
56 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
57 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
58 - Position correctly the entry points for JPEG2000 and JPEG-LS
59 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
61 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
62 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
63 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
64 with other method names
65 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
66 * Test/TestDicomDirElement.cxx : add new test
68 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
69 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
70 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
71 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
72 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
73 So can't you use __int64 in ostream at all.
75 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
76 * bug fix for compilation on MSVC6
77 * gdcmPython/gdcm.i : rename of classes missed
79 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
80 * Stage 2 of names normalization :
81 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
82 (easy to understand ...)
83 - gdcm::FileHelper replaces old class gdcm::File
85 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
87 type and not a string. So, there remove problems on the format of the
90 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
91 * Add Example/TestPapyrus.cxx
92 - reads a Papyrus file (gdcm::Header compliant),
93 - gets the pixels of all the images, using low level iterators
94 - writes an multiframes Dicom image.
95 (Just to show it's *possible* to do that)
96 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
99 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
101 Thus, DicomDirXXX are created with a flad that indicates if the created
102 object is empty or not (when not empty, the DicomDirElement is used to
105 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
107 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
109 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
112 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
114 Remove all access to the hash-tables or lists in the objects.
116 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
117 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
118 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
119 be complient with all the gdcm source code
121 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
125 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
129 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * Test/ : rename VTK tests to have a best name for the tests
131 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
132 GetFirstEntry/GetNextEntry use
134 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
135 * In SerieHeader::ImagePositionPatientOrdering()
136 // a Dicom 'Serie' may contain scout views
137 // and images may have differents directions.
138 // -> More than one may have the same 'pos'
139 // Sorting has then NO meaning !
140 Thx to Eduardo Davila for reporting bug.
142 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
143 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
144 test. Now it's on image content and not on the resulting visualisation...
145 might solve the problem on linux when using the OpenGL drivers
147 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
148 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
149 DicomDirSerie, DicomDirImage
150 Dict, DictSet classes :
151 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
152 -remove InitTraversal method.
153 * UPD Test programs + Example programs
155 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
156 * remove useless and never updated keyword \ingroup
157 * Solve pb when structure (list, map, ...) is empty.
158 Thx to Benoit for reporting bug
160 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
161 * Taking into account of 'Transfer Syntax' value
162 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
165 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
166 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
167 is no memory access violation
168 * gdcmPython/demo : add python demos using VTK
170 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
171 * FIX 'Dictionnary' is now spelt 'Dictionary'
172 'wether' is now spelt 'whether'
173 'archieve' is now spelt 'archive' ;-)
175 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
176 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
177 related methods, in order not to expose internal mechanisms
180 * REM methods that exposed internal mechanisms :
181 DicomDir::GetDicomDirPatients()
182 DicomDirPatient::GetDicomDirStudies()
183 DicomDirStudy::GetDicomDirSeries()
184 DicomDirSerie::GetDicomDirImages()
185 * UPD Test programs :
189 * UPD Example program
191 * ADD DictSet methods
195 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
196 * Removed the Print/indent/default parameter mess. There is absolutely no
197 reason to have to methods, moreover with the second taking the ostream as
198 *SECOND* parameter. This was clearly a bad hack to get things compile.
200 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
201 * Complete rewrite of the GetMacAddress code. Now the code is *much*
202 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
203 Unfortunately the main code does not work on SunOS, thus provide a specific
204 code for this platform only (and Win32 of course). Since this seems to be
205 working, change CreateUniqueUID to use GetMACAddress instead of the
206 problematic GctestetIPAddress
208 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
209 * Unfortunately to be able to test gdcmDirList I had to break the API
210 a little. Now the class is not a std::list anymore but has a member
211 std::vector (more ITK compatible). Allow unit testing on Win32 and
214 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
215 * Update SerieHeader to take into account a Serie Instance UID to properly
218 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
219 * ENH - Comment out Mathieu's (dangerous) Super Hack
220 for dealing with BIGENDIAN processors
221 - Move equivalent stuff to BinEntry::WriteContent
222 When necessary, 16 Bits Pixels are swapped in a small buffer
223 and then written. This avoid allocating a huge buffer, in
224 PixelWriteConvertor, and avoid modifying the Pixel Area.
226 Probabely, the same operation will have to be done when we want
227 to write image with Big Endian Transfert Syntax,
228 and we are working on Little Endian Processor
230 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
233 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
234 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
235 all the dict content.
236 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
238 * Test/TestDict.cxx : add a new test for the dict classes
240 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
241 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
242 file. Debug is yanked if compiled with NDEBUG
244 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * src/gdcmDictSet.h : set the default output to the os variable
246 * src/gdcmDictEntry.[h|cxx] : add the Print method
247 * gdcmPython/demo/ : add a new test
249 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
250 * merging of Test/PrintDicomDir and Test/TestDicomDir
251 * removal of now redundant Test/PrintDicomDir
252 * enhancement of Example/PrintDicomDir
254 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
255 * Now, python test might work on systems
256 * Add the PrintDicomDir test
258 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
259 * FIX : First entry following group 0002 was lost for
260 Explicit Big Endian Transfer Syntax files
261 (group and elem not swaped)
263 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
264 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
265 Big Endian Transfer Syntax supposed the group following 0002
266 begins always by element 0000 (element 0000 is *optional*)
267 To avoid further troubles, let's be pessimistic, and use
268 Document::HandleOutOfGroup0002() method
269 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
270 (related pb not yet solved)
272 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
273 * Bug fix for the python part use
274 * Now, PrintHeader.py pass... but outside the ctest use. shit !
276 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
277 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
279 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
280 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
281 a string and should ask the global TS dict what are the propreties of
284 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
285 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
286 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
287 to swap the Swap Code, at parsing time, when we come out of group 0002
288 and Transfer Syntax is Big Endian
289 We should be able to read now 'true DICOM" Big Endian coded images
290 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
291 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
293 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
294 * Hopefully fix the bug on MacOSX and static global initialization.
295 This is the only -minor- patch I found that both please MacOSX and VS6.
296 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
297 but this would require a lot of change. Another approach would be that Global
298 create those string and GDCM_UNFOUND becomes a pointer to a string (which
299 gdcm::Global would destroy at exit).
301 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
302 * Fix bug on MacOSX with static initialization in a multy threaded
303 environment. static const string in a header file used to be ill
304 initialized provoquing the freeze of any tests. patch should solve this
307 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
308 * According to Benoit's suggestion, and without any objection from anybody
309 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
310 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
311 - method gdcmDicomDirObject::GetEntry() renamed as
312 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
314 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
315 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
316 you debug/warning message just as c++ streams which make them very convinient
317 to use. Once this is stabilize I will change the ostringstrem to be
318 redirected to a file (ofstream).
319 * Properly support C99 extension: __FUNCTION__ which allow us to display
320 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
322 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
323 * Removal of useless and dangerous methods :
324 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
325 GetDocEntryByName, GetEntryByName, GetDictEntryByName
326 * Removal of usless methods :
327 Dict::PrintByName, Dict::GetDictEntryByName
328 * Commenting out of probabely useless methods :
329 Dict::GetDictEntryNames()
330 Dict::GetDictEntryNamesByCategory()
331 DictSet::GetPubDictEntryNames()
332 DictSet::GetPubDictEntryNamesByCategory()
333 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
334 * ENH : Use dicomTS.dic as described in 2004 version
335 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
336 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
337 Add Accessors on VM (Value Multiplicity), and VM related methods
338 * ADD : Add a list of 'Dicom Attribute types', as found in
339 http://medical.nema.org/dicom/2004/04_15PU.PDF
341 * ADD : Add dicomGroupNameAbbreviations.dic
342 should be used to write a method to replace the former
343 Dict::GetDictEntryNamesByCategory()
345 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
347 to read in the file... and only it ! Length is the efective length of the
348 data in the DocEntry structure
350 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
351 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
352 And now use a static function call instead, with a global variable. i
353 This is much closer to the VTK approach. Hopefully should be bulletproof
354 and easier to use...hopefully
356 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
357 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
359 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
360 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
362 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
364 ValEntry, BinEntry, SeqEntry creation or replace
366 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
367 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
368 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
370 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
371 when specifying the VR
372 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
373 * src/gdcmDocEntry.cxx : amelioration of print
375 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
376 * ADD : Add the method Util::IsCurrentProcessorBigEndian
377 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
378 * ADD Method Document::ComputeGroupLength
379 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
380 in order to allow further VR modification by user
381 * REM : removal of once-called method File::WriteBase
382 integration of its code in formerly one-line method File::Write
384 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
385 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
386 replace the different values "??", "Unkn", "Unknown".
387 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
388 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
389 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
390 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
392 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
393 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
395 * Set the gdcm::Base class to some Printable classes
397 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
398 * src/gdcmFile.[h|cxx] : add the Print method
399 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
400 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
401 * src/gdcmDocument.h : remove the PrintLevel informations
402 * Example/PrintFile.cxx : use the new gdcm::File::Print
404 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
405 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
406 problems when compiling with the python wrapping
408 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
410 writting in ImplicitVR
412 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
413 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
414 JPEG decompression, especially when dicom frames are split into several
415 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
416 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
418 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
419 * src/gdcmHeader.cxx : change the initialisation of default header.
420 Now, this header is readable by gdm, e-film, DicomWorks
422 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
423 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
424 Rename Decompressed to Raw
425 * Use the API changes in gdcm::File.
426 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
429 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
430 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
431 each added entry in the header. Replace the 'Planes' field by the 'Number
434 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
435 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
436 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
438 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
440 At this time, this image isn't readable by e-film... waiting JPR help to
443 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
444 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
445 DocEntry. Now use methods of the Document !
447 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
448 * Test/ShowDicomSeq.cxx : bug fix
450 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
451 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
452 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
453 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
454 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
456 * Test/TestCopyRescaleDicom.cxx : remove unused variable
457 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
458 containing found sequences
460 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
461 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
463 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
464 Some fields in BinEntry must be copied to not seg fault when making the :
465 gdcm::File *copy = new gdcm::File( copyH );
466 and tests are now made on good variables
468 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
470 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
472 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
473 * Add vtkGdcmWriter example and test
475 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
476 * Test/TestUtil.cxx : reformat the source code
477 * vtk/vtkGdcmReader.cxx : remove and change prints
478 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
480 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
481 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
483 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
484 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
485 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
487 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
488 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
489 by an eof to prevent all bad read of the file... and in this case, the
492 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
493 * Example/Volume2Dicom.cxx : comment unused variables
494 * Test/PrintDicomDir.cxx : comment unused variables
495 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
496 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
497 method that is redondant with AddEntry.
498 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
501 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
502 * Bug fix due my last commit (compilation under Windows).
503 * Example/Volume2Dicom : bug fix in the file and reformatting source code
504 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
506 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
508 - Remove printf / sprintf
509 - include iostream AFTER gdcm so we don't get warnings
510 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
512 - Also remove tons of include from header files, hopefully this should
513 speeup the compilation time, since it was becoming a dog slow.
514 - Remove gdcm.h as it include way too many files and slow down compilation
515 (plus it is not up to date)
516 - remove 'using namespace std' this is BAD !
518 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
519 * Remove memory leaks on the DicomDir
520 * Remove some useless data in DicomDirObject
521 * Add usefull methods in SQItem, to be complient withe the ElementSet
523 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
526 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
527 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
528 future, with convertion)
529 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
530 and ImageDataSize values. Remove the method to get the PixelReadConverter
531 from the output of the class
533 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
534 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
536 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
537 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
538 and vtkErrorMacro use.
539 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
541 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
544 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
545 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
546 The string leaves only in the fonction. So when we make a .c_str(), we
547 get the pointeur on the first element, element that will be destroyed
548 immediately after thee instruction.
549 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
550 file has been opened : the test must be made on the content of the
551 pointer and not directly on the pointer !
554 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
556 the python part recompiles
558 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
559 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
560 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
561 X session is killed (for my computer... it seems to not be identic on
564 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
565 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
566 avoid problems (otherwise, the difference test between the visible image
567 and the reference is incorrect. If the reference is greater than the
568 screen resolution, it's produce errors).
569 Can be used for only one image. Can be used with a visible flag.
570 * vtk/vtkGdcmReader.cxx : remove commented codes.
571 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
572 under windows at compilation
573 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
575 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
577 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
578 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
579 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
580 tests on the image size X, Y, Z
582 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
583 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
584 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
585 between the class name and the file name
587 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
588 * src/ : fix compilation warnings for the Write method (2 different
589 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
590 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
591 variable... create a static method in gdcm::Document to access to
592 this variable content.
594 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
595 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
596 file, to be accessed by other files (like gdcmFile). Remove commented
597 code. Move the change of the header to the gdcmFile, using the
599 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
600 To be sure of that (and simplify calls), the Write of the header now
601 gets a file name and not a file pointer (std::ifstream).
602 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
603 DocEntryArchive. Remove all open of the written file
605 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
606 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
608 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
609 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
610 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
612 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
613 some corresponding methods. Write correctly the file and check before
615 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
616 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
617 is now on RGB data (as before my last commit
618 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
620 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
621 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
622 Add a print information of the type of the entry
623 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
624 It was in the gdcmFile, and all write have been regrouped
625 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
626 Write correctly all dicom files (in decompressed mode only at this time)
627 * Test/ : test on files are now made using Raw data and not color data if
629 * Example/PrintFile.cxx : add more printings
631 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
632 * Amelioration of code, remove some code copy. For the loading of
633 BinEntry (in gdcmDocument), add the test to verify if the file is already
636 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
637 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
638 remove a DocEntry in the header (push an empty DocEntry)
639 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
640 lines. Bug fix in the initialization of the PixelConvert and the
642 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
643 use in TestCopyDicom (now this test can run under windows... but fails)
644 * Test/TestCopyDicom.cxx : amelioration of the test :
645 - test the pixels written
646 - add test points to quickly find where is the error
647 - can set a file name input and output in arguments
648 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
649 amelioration of the test output
651 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
652 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
653 all replaced DocEntry's
654 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
655 Now, each needed DocEntry to modify is duplicated, modified and inserted
656 to the header using DocEntryArchive. Thus, after save, we can restore the
657 header initial state.
659 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
660 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
662 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
663 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
664 correct to copy it. The DictEntry is specified at the DocEntry creation,
665 then, it musn't change in the time.
666 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
667 header correctly. At this time, the change is only made for the first
668 level of the Document. In the future, it might consider sequences.
669 The change is made by replacing a DocEntry by an other that is created
670 outside the class. The old value is kept. When we restore the header
671 status, the added DocEntry is deleted and replaced by the old value.
672 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
673 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
674 set the write type to explicit VR, implicit VR or ACR. Add methods to set
675 the write mode to native, decompressed or RGB (but not used at this time)
677 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
678 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
679 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
681 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
683 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
685 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
686 set because already copied when copying the BinEntry's of the header
687 * Test/TestAllReadCompareDicom.cxx : remove warnings
689 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
690 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
691 Two problems appear when doing it :
692 - with the gdcmFile : when the GetImageData method is called, the pixels
693 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
694 data (pixels). And each structure destruct the data when it's
695 destructed. So we have two destructions for the same data. To solve it,
696 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
697 data or not. If it doesn't own data, then they will not destroyed by
699 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
700 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
701 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
702 create a double destruction of the same DocEntry's. So, to solve it,
703 the TagHT is simply cleared and the DicomDir* elements are destroyed.
704 * TODO : add an entry concerning memory leaks in the DicomDir
706 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
707 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
708 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
711 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
712 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
713 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
714 after it have been deleted
716 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
717 * FIX: src/* fix the doxygen warnings.
718 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
719 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
720 was erroneously defined with a size of 15 instead of 16. [many thanks
721 to Jean Michel Rouet for pointing out this bug].
723 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
724 1. Finish merging JMR patch for writting DICOM from scratch
725 2. Fix -hopefully- bug with MONOCHROME and space vs null character
726 3. Use const ref when possible
727 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
728 5. A few more comments
729 6. CreateUniqueUID can now be called without parameter"
731 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
732 * ENH: Slightly bigger patch:
733 1. Getting toward full integration of JMR patch for writting dicom from scratch
734 2. Update Test to test part of this patch: CreateUniqueUID
735 3. File was not close properly in gdcmDict
736 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
737 5. Use of const ref instead of copy (speed issue)
738 6. Remove temporary (duplicate) string in TranslateToKey
739 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
740 8. Do not repeat virtual in subclasses
741 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
743 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
744 * Apply first patch toward better string comparison when dealing with broken
745 DICOM files. Essentially the string could be padded with a space instead
746 of a null character as defined by standard
748 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
749 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
750 because never used... and in the same time, that's remove some memory leaks
752 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
753 * src/gdcmFile.cxx : now delete the PixelConvert instance.
754 * In examples and tests : change the type of image data variables from void*
755 to uint8_t*. Remmove all delete on image data variables
757 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
758 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
759 Verify the file pointer value before open the file, and if it's not null,
760 a verbose message is generated.
761 Close correctly the file when the file isn't considered dicom-like. The
762 correctly close is a call to CloseFile.
763 When closing the file pointer, test if its not null to close the file.
764 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
765 file. For an uncompressed image, the copied data correspond in the least
766 case to the image size (calculated) or the image size specified in the
767 header. A verbose is generated if these two size mismatch
769 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
770 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
771 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
772 break under windows (with msvc6 compilation).
774 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
775 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
776 compiling with MSVC6)
778 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
779 * Bugs fix for the Windows build with VC6
780 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
781 needed (only for projects required VTK). If the VTK is included in all
782 projects, there is conflicts with the jpeg lib of vtk when compiling the
783 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
784 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
785 when compiling the gdcm_wrap.cxx file (created by the compilation of the
787 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
788 (like it's already made for the cout use). Otherwise, conflict with the
791 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
792 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
794 - comments on the DicomDir::Method related usage added.
795 - now that we use the namespace gdcm, a lot of internal classes do
796 NOT need to be wrapped anymore.
797 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
798 DicomDir::Method) new example added.
800 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
801 * Improve string manipulation. I now inforce the notion of 'DicomString'
802 A DicomString can contain as many \0 as they want
803 and it is *always* of even length.
804 We only support odd length for very rare case.
805 And in the near future this should be removed.
807 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
808 * /binary_write/ gdcm source. Now even on big endian we are writting
809 little endian. This should -heopfully- fix some tests
811 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
812 * Now the dictionary is compiled into gdcm lib. This is a default
813 behavior, thus any dic file specified is picked before failback to
814 the one comiled into lib
816 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
817 * Change internals for gdcmDict. Don't use any 'new' any more.
818 This should definitely solve any leak problem, and we should be
819 as fast as before, as long as don't modify too much the dictionary.
821 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
822 * STYLE: ivars should start with a capital letter.
823 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
824 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
826 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
827 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
828 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
829 new 2004 dictionaries added (thanks to JPR).
830 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
831 * CLEANUP_ROUND (15) for gdcmPixelConvert
832 - RLEFrame::NumberFragments is now of type unsigned int
833 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
834 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
837 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
838 * Initial work in gathering all transfer syntax accessors. clearly
839 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
840 ivars, but only one transfersyntax (class) ivar with equivalent method on
843 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
844 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
845 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
846 discussed (plus I didn't like having a 2000 lines patch not commited)
848 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
849 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
850 * CLEANUP_ROUND (14) for gdcmPixelConvert
851 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
852 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
853 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
855 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
856 anymore and hence avoids storing a copy of PixelConvert::Decompressed
857 into File::Pixel_Data.
859 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
860 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
861 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
862 * CLEANUP_ROUND (13) for gdcmPixelConvert
863 Substituted File::ParsePixelData() with PixelConvert::Print() new
865 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
866 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
867 method to those classes.
868 - src/gdcmFile.[cxx|h]:
869 -- Added a ::Print() method.
870 -- PixelConverter is now a reference instead of a member.
871 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
872 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
874 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
875 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
876 collaboration diagram and inheritance diagram should be generated with
878 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
879 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
880 pointlessly wrapped (see
881 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
882 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
883 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
884 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
885 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
886 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
887 -- File::Initialise: PixelConverter setup moved away to
888 PixelConverter::GrabInformationsFromHeader()
889 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
890 interpretation moved away to PixelConverter::BuildRGBImage()
892 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
893 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
894 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
896 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
897 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
898 displayed on Win32 when a brutal abort() occurs (because of uncatched
899 exception). See TODO new entry of this commit for more on this.
900 * TODO added new entry.
901 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
902 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
903 - HandleColor is no longer called from gdcmFile.cxx
904 - gdcmPixelConvert.cxx clean up on method arguments and internal
905 variable names for semantical coherence.
907 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
908 * Finished lossless transition, not only do we now read all lossless jpeg
909 images, without the need of the Cornwell lib, but we do read them properly now
910 * To reduce code (well to avoid code duplication), I defined a common place
911 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
912 redefine symbols. This is not perfect but this the best solution I found for a
913 compilation time jpeg option.
915 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
916 * Update jpeg ijg lib to support lossless jpeg implementation
917 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
919 * Also added a special copyright for dcmtk since we use their bugfixes.
922 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
923 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
924 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
925 matters, as stated in warning note at begining of %include section).
926 * src/gdcmDicomDir*.[cxx|h]: coding style
927 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
928 * src/gdcmJpeg8.cxx: doxygen fix.
929 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
930 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
931 from File:: to PixelConvert::.
933 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
934 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
935 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
936 - more code moved away from File:: to PixelConvert::
937 - fat setup of PixelConverter set in place in File::Initialise.
939 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
940 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
941 namespace at the file system level. So now you should convert your examples
943 gdcmHeader -> gdcm::Header
944 It would be nice if people keep in mind to no open the namespace, since it
945 allows compilation on broken plateform which were defining common symbol in
946 the standart namespace (like LP, Unknown ...)
948 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
949 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
950 The JPEG fragments are now parsed at the same stage than the RLE
951 information. All code related to JPEG is now in gdcmPixelConvert:
952 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
953 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
954 export a gdcmFile:: method. Those are simply global functions
955 (for the time being this is better than having them attach to
956 either gdcmFile:: or gdcmPixelConvert::).
957 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
958 and stores the result in a gdcmJPEGFragmentsInfo.
959 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
960 code (among other stuff) moved away from gdcmFile:; to
963 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
964 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
965 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
966 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
967 clean up of RLE related code.
968 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
969 - src/gdcmRLE.cxx removed
970 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
971 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
972 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
973 * CLEANUP_ROUND (9) for gdcmPixelConvert
974 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
975 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
976 away from gdcmFile:: to gdcmPixelConvert::.
978 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
979 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
980 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
981 This is because Parse7Fe0 used to parse the pixels to compute the
982 length. This task was passed over to FindDocEntryLengthOB() a long
983 time ago, EXCEPT I had forgotten the OW case...
984 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
985 we just recylce the code for parsing RLE fragments and computing
987 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
988 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
989 with the retired Parse7Fe0().
990 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
991 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
993 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
994 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
995 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
996 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
997 - src/CMakeLists.txt: alphabetic order reodering + new entries.
998 * CLEANUP_ROUND (4) for gdcmPixelConvert
999 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1000 to return an unused length.
1002 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1003 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1004 this should be cleanner from the plane view. The iostream are erally a pain
1005 to use to do simple stuff.
1007 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1008 * Redo the compilation of the ijg jpeg library. Now only one source is
1009 necesseray. No need to rename file by hand what so ever. CMake handle the
1010 copying of the file within different directory, configure header file to
1011 modify some symbol. The only addition made to ijg wasd a mangle table so
1012 that symbol are different whether we are within 8bits or 12bits.
1014 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1015 * Added documentation of vtkgdcmReader on Website:
1016 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1017 with it's binary name).
1018 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1019 the Website to be more complete.
1020 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1021 doxygenated documentation.
1022 - Doc/DoxyVtkGdcmReaderExamples.txt added
1023 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1024 DoxyVtkGdmReaderExamples.html )
1025 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1026 * CLEANUP_ROUND (3) for gdcmPixelConvert
1027 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1029 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1030 * CLEANUP_ROUND (2) for gdcmPixelConvert
1031 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1033 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1034 * CLEANUP_ROUND for gdcmPixelConvert:
1035 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1036 - src/gdcmPixelStuff[h|cxx] removed
1037 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1038 - src/CMakeLists.txt changed accordingly
1039 * GDCMHOME clean up:
1040 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1041 gdcmVersion.py moved to newly created ATTIC related
1042 gdcmPython/SetupOldies/ directory.
1043 * Autotools clean up:
1044 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1045 - autogen.sh configure.in acinclude.m4 python.m4 removed
1047 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1048 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1049 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1050 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1052 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1053 * TODO updated with Mathieu suggestions. I proposed a template for
1054 describing TODO entries and used it for new entries.
1055 * Added Doc/Website/CodingStyle.html, Developpers.html,
1056 DeveloppersPython.html, GdcmDataCvs.html and
1057 DownloadVersion0_1.html, DownloadVersion0_3.html.
1058 * Some Doc/*.txt Doxygen files (which do not really concern the
1059 documentation itself, but the website) moved to html and
1060 placed in directory Doc/Website:
1061 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1062 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1063 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1064 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1065 * CMakeLists.txt changed accordingly.
1066 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1067 DeveloppersPython.html
1068 * INSTALL nows refers to Doc/Website/Installation.html
1070 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1071 * Added Doc/Website directory, that contains a first raw version
1074 2004-09-23 Jean-Pierre Roux
1075 * FIX In order not to be poluted any longer by casting problems,
1076 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1077 we can now delete[] it safely
1078 * VoidArea is now called BinArea (less confusing name),
1079 and all the methods called ...VoidArea... are now ... BinArea...
1080 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1082 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1083 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1084 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1085 up to the destructor of gdcmElementSet to clean up TagHt and it's
1088 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1090 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1092 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1093 * ENH: added some utility method that builds a flat dictionary
1094 holding all the Dicom entries contained in the recursive structure
1095 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1096 an example of usage.
1097 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1098 BuildFlatHashTable() that build a flat dictionary.
1099 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1100 gdcmDocument is now a friend of gdcmElementSet.
1101 - src/gdcmElementSet.cxx: clean up.
1102 - Example/FlatHashTablePrint.cxx added.
1103 - Example/CmakeLists.txt changed accordingly
1105 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1106 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1107 moved away from gdcmDocEntrySet (since this class is an abstract class
1108 acting like an interface). SQDepthLevel and BaseTagKey are now
1110 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1111 and associated accessors. Doxygenation of the class.
1112 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1114 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1115 Use SQDepthLevel accessor instead. ::Print() adapted.
1116 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1117 - src/gdcmDocument.cxx changed accordingly.
1119 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1120 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1121 - The following is the doxygen comment of the typedef declaration
1122 of gdcmTagKey in src/gdcmCommon.h:
1123 gdcmTagKey is made to old an "universal" (as in URL, Universal
1124 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1125 A dicom tag always has a group and an element, but a set of tags
1126 embeded in various (optionally nested) sequences and sharing
1127 the same group and element all share the same (group, element)
1128 "identifier". Hence the (group, element) cannot be used as an
1129 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1130 In order to construct a proper tag identifier (i.e. a key) we
1131 consider the following definition of a TagKey:
1132 - let Group, Element be the string representation of the
1133 group and element dicom tag members,
1134 - let ItemNumber be the string representation of the integer
1135 index of the considered item number of a sequence,
1136 Let the key of a tag embeded in a sequence, noted SeqTag, be
1138 /ItemNumber#Group|Element
1139 where "/", "#" and "|" are characters acting as separators.
1140 Then the general form of a gdcmTagKey is given by:
1141 Group|Element<SeqTag>
1142 where <SeqTag> means NO or many instances of SeqTag.
1143 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1146 but the gdcmTagKey of a tag "embeded" is the first item of
1147 a sequence, itself nested in the third item of a sequence is the
1149 0004|1220/2#0008|0082/0#0008|0090
1150 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1151 order to hold the new sequence compatible key. Previously, the
1152 GetKey() method would look in the underlying gdcmDictEntry.
1153 - src/gdcmDocEntry.cxx:
1154 -- constructor now copies the underlying DictEntry key, in the local
1156 -- ::Print: displays the member Key, instead of the (group, element).
1157 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1158 - src/gdcmDocEntrySet.h:xi
1159 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1160 -- now has a new BaseTagKey member.
1162 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1163 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1165 This poses the problem with the semantics of the following lines
1166 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1167 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1168 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1169 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1170 to the long FIXME note for what the problem is. Nevertheless in
1171 order to get things working the dicom dictionary was altered !
1172 Please fix things urgently...
1173 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1174 information), see above note on moving the member VoidArea. Nevertheless
1175 the following entries previously correctly set as US are now inproperly
1177 0028 1201 OW IMG Red Palette Color Lookup Table Data
1178 0028 1202 OW IMG Green Palette Color Lookup Table Data
1179 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1180 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1181 of gdcmDocEntry moved to gdcmSeqEntry.
1182 * src/gdcmSeqEntry.cxx: STYLE.
1184 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1185 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1187 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1188 * gdcmPython/testSuite.py: all the test suite in python is now moved
1189 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1190 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1191 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1193 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1194 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1195 to avoid inclusion recursion until STL is reached.
1196 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1197 mecanism. errno.h is not included in gdcm anymore.
1198 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1199 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1201 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1202 gdcmData/TestAllEntryVerifyReference.txt
1203 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1204 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1205 exception_on_error parameter.
1206 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1207 - vtk/vtkGdcmReader.cxx changed accordingly,
1208 - Example/*.cxx and Test/*.cxx changed accordingly.
1210 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1211 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1212 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1213 enable_sequences removed from gdcmHeader constructor and dependencies.
1214 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1215 * gdcmPython/demo/PrintHeader.py: dummy fix.
1216 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1217 skip_shadow removed from gdcmHeader constructor and dependencies.
1218 * Example/*.cxx and Test/*.cxx changed accordingly.
1220 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1221 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1222 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1224 2004-07-21 Jean-Pierre Roux
1225 * FIX Now, Parsing and Printing a DICOMDIR do work!
1226 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1228 2004-07-20 Jean-Pierre Roux
1229 * FIX Some brain damaged headers have Zero-Lenght fields
1230 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1232 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1233 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1234 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1235 variable (instance of gdcmDebug) by a definition macro, and the instance
1236 is now in static in the gdcmDebug class
1237 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1238 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1240 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1241 * WARNING: ctest now depends more tightly on gdcmData. You should
1242 check out gdcmData properly for things to run smoothly...
1243 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1244 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1245 we need the pixels not be loaded in order to use the ValEntry
1246 that displays position and size).
1247 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1248 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1249 be deprecated. If you have any doubts about the advantages of a
1250 modern scripting language (read Python) versus grass root C++ (i.e.
1251 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1252 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1253 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1254 Anyhow, consider documenting the gdcmData images in
1255 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1257 * Test/CMakeLists.txt:
1258 - now uses TestAllEntryVerify.cxx
1259 - specific comments on oldACR00001.ima (now renamed in gdcmData
1260 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1261 gdcmData/TestAllEntryVerifyReference.txt
1264 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1265 * src/*.[h|cxx] : typedef clean up
1266 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1267 - TagKey renamed to gdcmTagKey (for external usage)
1268 - VRKey renamed to gdcmVRKey (for external usage)
1269 - removal of typedef duplication.
1270 - Removed all unecessary inline keyword from class inline definitions.
1271 - Some method|function(void) declarations replaced with method|function().
1272 * src/jpeg/libijg12/jdhuff12.c:
1273 - printf polluting ctest removed.
1274 - TAB removal for comminting
1276 - TestAllReadCompareDicom.cxx: added a test that compares all the
1277 images in gdcmDataImages.h with corresponding images in
1278 gdcmData/BaselineDicom/. When baseline images are not present
1279 this test creates them.
1280 Note: we need to validate each reference image, but before that
1281 I'd like to rename them with a more explicit name...
1282 - CMakeLists.txt: changed accordingly.
1283 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1284 including each header needed).
1286 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1287 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1288 test suite to the Example directory. Are concerned:
1293 - TestWriteSimple.cxx
1294 * Test/CMakeLists.txt: added some comments on reasons for black listing
1295 image gdcmData/oldACR00001.ima
1297 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1298 * Test/CmakeList.txt: removed the following from black list (to be coherent
1299 with removal from gdcmData):
1300 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1301 - gdcm-MR-PHILIPS-16.dcm
1303 Added the following because after last cvs update, they cause
1304 ctest -R TestReadWriteReadCompare
1306 - gdcm-MR-SIEMENS-16-1.acr
1308 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1309 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1310 new comments in this file) we temporarily (sigh) move to a weaker
1312 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1313 we don't need to black list the following images anymore:
1314 - 8BitsUncompressedColor.dcm
1316 - US-PAL-8-10x-echo.dcm
1317 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1318 fixes and the beautified code ;-)
1319 This fixes the bug introduced in version 1.42 (when beautifying)
1320 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1321 Note: ctest was blind to this bug (this means we need to still
1322 improve the test suite). The bug could be detected by using
1323 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1325 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1326 and by displaying the (garbage) produced file temp.XDCM...
1328 2004-06-29 Jean-Pierre Roux
1329 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1330 - replace by uggly but working old code :-(
1331 A lot of things should be OK again.
1332 It's really urgent to have a test suite that *tests*,
1333 to prevent Frog's beautifying sessions to break all the stuff
1334 (twice, withing a fortnigh ...)
1336 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1337 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1338 redundancy) to added Test/TestReadWriteReadCompare.cxx
1339 * Test/CmakeList.txt: because the compare test of
1340 Test/TestReadWriteReadCompare.cxx fails, the following images are
1341 black listed: - 8BitsUncompressedColor.dcm
1343 - US-PAL-8-10x-echo.dcm
1344 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1345 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1346 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1347 and ad-hoc kludge. This kludge is now removed, and on encountering
1348 such an image (OB field brain damaged) we set errno. Then in
1349 ::FindDocLength() we "fix" the length as being ALL what remains
1350 in the file (until EOF). We then proceed, hoping for the best...
1351 This fixes a SegFault in ShowDicom when trying to write such an
1353 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1354 (because TestWriteRead breaks on it, after a non conformal commit?).
1355 ctest now runs properly, except for MakeDicomDir (which was always
1356 broken) and the Python related stuff (still not fixed).
1358 2004-06-24 Jean-Pierre Roux
1359 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1360 FIX : Test/TestReadWrite now iterates on all the file names
1361 (instead of infinite loop)
1362 ENH : Test/TestWriteRead now iterates on all the file names
1364 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1365 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1367 2004-06-24 Jean-Pierre Roux
1368 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1369 when SamplesPerPixel =3
1370 - now Write is no longer confused by
1371 'BitsAllocated = 12" and 'BitsStored=12"
1372 - "UN" value representation Elements are now written correctly
1373 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1374 ENH : - now gdcmHeader has its own Write methods
1375 (in order to split the job that has not to be done
1378 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1379 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1380 loop on the same image until memory went out.
1381 Note: this means we still have gobs of memory loss in PrintDocument
1382 * src/gdcmDocument.cxx: fixes problem on parsing on file
1383 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1385 2004-06-24 Jean-Pierre Roux
1386 FIX : Write - All the Sequences and Sequence Item are now written
1387 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1388 is added a the end, when necessary.
1389 - A lot of brain-damaged images, that were read correctly are
1390 now written correctly
1391 - length compatible BinEntry are now loaded correctly
1392 (even for odd groups)
1393 Note : only Explicit Value Representation was checked.
1394 (question : is implicit VR really necessary for gdcm ?)
1396 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1397 * DEVELOPPER: added a proposition of coding style.
1398 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1401 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1402 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1403 Use the gdcmDocEntry::Print() and Write() instead.
1404 * src/gdcmDocument.cxx: bug fix.
1406 2004-06-22 Jean-Pierre Roux
1407 FIX : gdcmDocument.cxx
1408 - Now we do recognize the JpegLossLess format (there was a misstyping in
1409 code 'beautyfication' :-(
1410 - Now we automaticaticaly load the Luts, if any
1412 2004-06-22 Jean-Pierre Roux
1413 In order : to write Sequences, whatever their imbrication level,
1414 : to allow user to create his own Sequences
1415 a lot of modif where necessary (adding, moving, or virtualising methods)
1417 WARNING : save your own sources *before* cvs up !
1420 ADD virtual void Write(FILE *fp, FileType filetype);
1423 ADD virtual void Write(FILE *fp, FileType filetype);
1424 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1427 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1428 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1429 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1430 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1431 ADD std::string GetEntryByName(TagName name);
1432 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1434 std::string vr = "unkn",
1435 std::string fourth = "unkn",
1436 std::string name = "unkn");
1437 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1438 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1439 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1440 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1441 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1442 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1443 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1444 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1447 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1448 ADD virtual std::string GetEntryByName (TagName tagName);
1449 ADD virtual std::string GetEntryVRByName (TagName tagName);
1450 REM virtual bool Write(FILE *, FileType);
1451 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1452 FILE *_fp, FileType type);
1453 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1454 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1455 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1456 REM virtual std::string GetEntryByName (std::string tagName);
1457 REM virtual std::string GetEntryVRByName (std::string tagName);
1458 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1459 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1460 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1462 std::string vr = "unkn",
1463 std::string fourth = "unkn",
1464 std::string name = "unkn");
1465 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1466 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1467 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1468 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1471 ADD virtual void Write(FILE *fp, FileType filetype);
1474 ADD virtual void Write(FILE *fp,FileType filetype);
1477 ADD virtual void Write(FILE *fp, FileType filetype);
1478 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1479 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1480 REM std::string GetEntryByName(TagName name);
1483 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1485 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1486 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1487 The default constructor invoked by the line
1488 gdcmHeader *f1 = new gdcmHeader( header );
1489 was gdcmHeader::gdcmHeader(bool) instead of the expected
1490 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1491 Hence the parsing wasn't executed... See also below.
1492 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1493 as explicit constructor didn't do the trick to fix the above problem.
1494 Could anyone explain why ?
1495 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1496 properly calls gdcmValEntry::Print() (that was weed out from
1497 code related to gdcmBinEntry).
1499 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1500 * In order to fix memory leaks:
1501 - Test/TestWriteSimple.cxx: added cleaning of free store through
1503 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1504 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1505 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1506 (through the call to ::AddDicomDirMeta()) or the destructor
1507 would crash when deleting uninitialized ::metaElems].
1508 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1509 - src/gdcmDocument.cxx:
1510 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1511 from dynamic stores.
1512 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1513 was causing memory leaks.
1514 - src/gdcmSQItem.cxx:
1515 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1516 cleanly handled with polymophism: sorry but my milage is low).
1517 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1518 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1519 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1520 This avoids SegFaulting.
1521 - src/gdcmSQItem.h: coding style.
1523 - Test/TestWriteSimple still severely sucks. The output image content
1524 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1525 damaged when displayed with vtkgdcmViewer.
1526 - on memory leaks: TestWriteSimple leaks really less (see entry
1527 of 2004-06-18 in Changelog file for the call to valgrind).
1528 - on segfaults: ctest now passes all the tests but one (no more
1530 * Erroneous leading white fix:
1531 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1532 white[s] (as opposed to from >> xxx, that removes it [them].
1533 - src/gdcmTS.cxx: ditto.
1534 - gdcmPython/testSuite.py: dirty related kludge removed.
1535 * src/*: remaining references to gdcmParser removed.
1536 * src/*[cxx|h]: added copy[way]left header.
1539 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1540 * In order to fix writing of dicom files:
1541 - Test/TestWriteSimple.cxx: a simpler example of writing.
1542 - Test/CMakeLists.txt changed accordingly.
1543 - src/gdcmDocument.cxx:
1544 -- The destructor now recursilvely removes potential sequences.
1545 -- Bug fix in ::IsJPEG2000()
1546 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1547 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1549 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1550 to only declared) and build on top of
1551 ::GetDocEntryByNumber(guint16, guint16).
1552 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1553 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1554 for usage in destructor and treatement of promotion in
1555 ::ReplaceOrCreateByNumber().
1556 - src/gdcmSQItem.cxx: destructor should better handle his job.
1557 Test/TestWriteSimple now runs (or at least it DOES something).
1558 * We can now start hutting memory links. A good starting point is:
1559 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1560 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1561 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1563 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1564 * Valgrind note: after Mathieu Malaterre teached me how to read
1565 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1567 Using gcc, you can force the STL to use malloc and to free memory as
1568 soon as possible by globally disabling memory caching.
1569 With 3.2.2 and later, you should export the environment variable
1570 GLIBCPP_FORCE_NEW before running your program.
1571 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1572 simply vanish (it is still not clear to me, whether this means that
1573 STL std::string leaks or if valgrind believes it leaks...).
1574 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1575 running bin/gdcmTests makeDicomDir):
1576 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1577 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1579 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1580 SegFaulting (I drowned in DicomDir related code when trying to
1581 understand why the list is empty...).
1582 * src/gdcmDocument.h: first BSD license header try.
1583 * Doc/License.txt added.
1585 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1586 * src/gdcmDocument.[h|cxx]:
1587 - Clean up of the Transfer related predicates. They are now all based
1588 on new method isGivenTransferSyntax, that (should) handle properly
1589 the padding problem.
1590 - general clean up, simplification, and coding style.
1591 - Specific clean up of Parse7FE0() (umproperly named actually).
1592 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1594 2004-06-14 Jean-Pierre Roux
1596 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1597 - fix the display of SQItem ordinal number
1598 - add the GetSQItemByOrdinalNumber method
1599 - remove some useless never written private methods
1601 2004-06-14 Jean-Pierre Roux
1603 - adding a constructor taking a gdcmDocEntry as an input param
1604 - ReplaceOrCreateByNumber now returns :
1605 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1606 a gdcmValEntry * if a string value is passed as a param
1608 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1609 according to the param type (no longer sets a gdcmDocEntry)
1610 - GetValEntryByNumber, GetBinEntryByNumber added
1611 - NewValEntryByNumber and NewBinEntryByNumber added
1613 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1615 - GetSQItemNumber and SetSQItemNumber added, to provide
1616 a (relative) Item identier inside a given Sequence
1617 \warning : some pb remaining around this number
1619 - AddEntry now takes the Item Number as a param
1621 - adding a constructor taking a gdcmDocEntry as an input param
1623 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1624 * Memory leak hunt with the following command:
1625 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1626 --show-reachable=yes gdcmTests PrintDocument
1627 It looks like many (all?) leaks are due to the STL (or a bad usage
1628 of the STL. The lines producing the leaks now have a comment with
1629 a "MEMORY LEAK" tag: you can retrieve them with
1630 grep "MEMORY LEAK" src/*
1631 Here are two typical examples which I can't help fixing:
1636 char * test = "babo";
1637 name = test; //// <--- valgrind detects 960 bytes lost in
1638 //// call to std::string::operator=(char const*)
1639 name.clear(); //// Doesn't help !
1647 std::cout << "Type a bunch of characters followed by RETURN: ";
1648 getline(std::cin, line); //// <--- valgrind dectects a loss
1649 //// of 1320 bytes in call to
1650 /// std::basic_istream<>& std::getline<>
1656 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1657 * src/gdcmHeader.[cxx|h]:
1658 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1659 and related, moved away to gdcmDocument.
1660 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1661 the corresponding protected accessors of inherited class
1662 gdcmDocument, removed ! As a consequence gdcmFile had to be
1663 declared friend of class gdcmDocument (see below).
1664 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1665 - Clean up of undefined or unused methods.
1666 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1667 account the changes to gdcmHeader.h).
1668 * src/gdcmDocument.h:
1669 - gdcmFile is now a friend class (in order to take into account the
1670 changes to gdcmHeader.h).
1671 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1672 (see changes to gdcmHeader.h).
1673 - Accessors (reading on the form GetEntry*) are now public.
1674 - Clean up of undefined or unused methods.
1675 * src/gdcmDocument.cxx:
1676 - adaptation to changes to gdcmDocument.h
1677 - ::OpenFile now writes a verbose message when file cannot be opened.
1678 - some std::string properly set to VRKey
1679 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1680 references to gdcmDocument.
1681 * Test/TestFindTags.cxx: changed accordingly to above changes.
1682 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1683 cvs repository gdcmData.
1685 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1686 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1687 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1688 conflicts with gdcmValEntry::voidArea.
1689 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1690 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1691 Value representation between StringRepresentable and BinaryRepresentable.
1692 * src/gdcmDocument.cxx:
1693 - method ParseDES: proper indentation restored and usage of
1694 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1695 - method LoadDocEntry: the fingerprint left in the SetValue() of
1696 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1697 removed. Reverting to previous code segment with the proper
1698 dynamic_cast< gdcmValEntry* >.
1699 Note: this was (partially) breaking the python test suite
1700 (gdcmPython/testSuite.py) that made usage of the above
1701 fingerprint to check presence of "Pixel Data".
1702 * src/gdcmDocEntry.h: coding style.
1703 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1704 now taken into account.
1705 * gdcmPython/gdcm.i: adaptation to the new internal representation
1706 of gdcm (exit gdcmParser, hello gdcmDocument).
1707 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1709 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1710 anymore, but instead prints the loaded Python dictionary.
1711 * .... alas, the python testSuite is still broken.
1713 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1714 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1716 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1717 * src/gdcmUtil.h : export methods
1719 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1720 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1722 * Initial addition of automatic python testing
1723 * Initial addition of automatic image comparison
1725 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1726 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1727 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1729 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1730 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1731 * Test/ShowDicom.cxx : bug fix for msvc compilation
1732 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1734 2004-05-04 Jean-Pierre Roux
1735 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1736 new concepts (and new classes) :
1737 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1738 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1739 - Sequence Doc Entries (gdcmSeqEntries)
1740 a Sequence is composed of Items.
1741 Each item is a set of Doc Entries (this is recursive)
1742 The non uniqueness of the 'Dicom tag' is due to this recursivity
1743 (never taken into account)
1744 Our unability to add a new 'entry' in the header
1745 at the proper location (neither in the H-Table (map or multimap),
1746 nor in the Chained List is also due to this recursivity.
1747 Don't try, right now, to use/modify/compile these new sources :
1748 nothing is finished.
1749 We just commit all the stuff, 'as is', in order not to loose it.
1751 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1752 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1754 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1755 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1756 file prefix (SetFilePrefix)
1758 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1759 * Add a new test: ShowDicom, for now this is just the c++ version of
1760 checkRead.sh, later it will be able to compare the image read against a
1762 * Replace the DEBUG on the stack with a global entry in cmake interface:
1763 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1765 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1766 * Add an example subdir, with a real example on how to read + write a
1769 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1770 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1771 * Doc/CMakeLists.txt: the main page is now properly differentiated
1772 between the developper and user version.
1773 * Doc/doxygen.config.in: dropped search related obsolete flags
1774 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1776 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1777 * DEVELOPPER: added some helpfull comments for compile/test/install
1780 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1781 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1782 src directory, now generated in the build dir.
1783 2. Tests as mentionned smarter
1785 4. Add a new method in gdcmDict that return the PubDict by name
1786 this is interesting for 3rd party lib like ITK,
1787 where we could set the institution name / patient name...
1789 * ENH: 1. Now the test suite is working for real
1790 2. All binaries are now output in the gdcm-bin directory
1791 (this was not true before)
1793 2004-04-28 Jean-Pierre Roux
1794 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1795 SeQuence indented printing of Dicom Header.
1796 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1797 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1798 Computation of SQDepthLevel is now part of gdcmHeader constructor
1799 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1800 tree-like structure of a Dicom Header.
1801 * FIX Test code cleaning
1803 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1804 * ENH: Adding automatic testing
1805 1. Need a DartConfig.cmake to submit to public
1806 2. Add a test driver gdcmTest.cxx
1807 3. gdcmTestMain, an helper for the main test driver gdcmTest
1808 4. Files in Test don't have a main anymore, this becomes interesting
1809 when we add more and more tests, thus dsw don't have to load
1811 * ENH: Adding a GDCM_DATA_ROOT for testing
1812 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1813 one file instead of seven + some small cleanup
1815 2004-04-22 Jean-Pierre Roux
1816 * ENH Minor changes to the Print() methods.
1817 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1818 Header printing. Example given with :
1819 > PrintHeader fileName 2 new
1820 (SQ based tree-like structure still to be done for the Header ...)
1822 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1823 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1824 1. I have added some unsigned where needed
1825 2. Some function parameter not used -> (void)
1826 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1827 4. g++ don't like character '\' in comment
1828 5. #define jpeg_create_decompress jCreaDecompress
1829 this really need to be fixed
1830 6. virtualize destructor of gdcmObject ... leakage
1831 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1832 this also really need to be fixed
1833 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1834 remove compression file
1835 (as we only do decompression, right ?)
1836 * ENH: Change malloc/calloc/free with c++ equivalent
1838 2004-04-21 Jean-Pierre Roux
1839 * FIX gdcmHeaderHelper::GetXSpacing
1840 when a single value is found (bug ?), xpacing is now
1841 defaulted to yspacing
1843 2004-04-19 Jean-Pierre Roux
1844 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1845 * ENH add parameters :
1846 bool exception_on_error = false,
1847 bool enable_sequences = false,
1848 bool ignore_shadow = false
1849 to the gdcmFile constructors to be full gdcmParser compliant
1850 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1851 to allow reading of PAPYRUS 3.0 files
1853 2004-04-06 Jean-Pierre Roux
1854 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1856 2004-04-02 Jean-Pierre Roux
1857 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1858 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1859 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1861 2004-03-30 Jean-Pierre Roux
1862 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1863 for ACR file, written out as DICOM files (hope so...)
1865 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1866 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1867 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1868 moved to base class gdcmParser and only the specialisation is kept
1870 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1871 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1872 already does the job.
1873 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1874 (to be consistent with gdcmParser::WriteEntries).
1876 2004-03-30 Benoit Regrain
1877 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1878 upate of the object's instance. It's passed to 2 in the unfavorable
1879 case : one in the ExecuteInformation, one in the ExecuteData
1881 2004-03-29 Jean-Pierre Roux
1882 * ENH : Check on file type to be written moved
1883 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1884 * FIX : gdcmObject::ResetBoundaries now stops properly
1885 when end-of-list is reached
1886 : gdcmVersion modified (as Benoit Regrain asked)
1888 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1889 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1890 * src/gdcmUtil.cxx: added forgotten iostream include.
1891 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1892 equivalent to ExplicitVR in existing code).
1894 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1895 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1896 now contains all the gdcmGlobal related code.
1897 * minor coding style and doxygenation changes.
1899 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1900 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1901 now contains all the Debug related code.
1902 * minor clean-up of includes in src/*.cxx
1903 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1904 CreateCleanString) removed.
1905 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1906 * Doc/DoxyMainPageUser.txt added.
1907 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1908 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1909 src/gdcmDirList.cxx)
1911 2004-03-24 Jean-Pierre Roux
1912 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1914 2004-03-23 Jean-Pierre Roux
1915 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1916 big endian made volumes
1917 * ENH Now gdcmParser constructor and destructor are protected to forbid
1918 end user to instanciate class gdcmParser
1919 (only gdcmHeader and gdcmDicomDir are meaningfull)
1921 2004-03-22 Benoit Regrain
1922 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1923 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1924 gdcmSerie to gdcmDicomDirSerie
1926 2004-03-19 Jean-Pierre Roux
1927 * ENH Now the tree-like structure describing a DICOMDIR comming from
1928 an already existing DICOMDIR file is consistent with
1929 the home-made tree-like structure build ex-nihilo
1930 or build from the files held (recursively) in a Directory
1931 functions gdcmDicomDir::CheckBoundaries()
1932 gdcmObject::SetBoundaries() added
1934 2004-03-17 Jean-Pierre Roux
1935 * REM (Eric Boix bug) : removal of meaningless
1936 gdcmDicomDirImage::NewImage function.
1937 * FIX now file names and directory name are written properly in the
1939 * FIX now gdcmDicomDir constructor may be call without any trick
1942 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1943 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1944 of gdcmDicomDirImage::NewImage as empty function.
1946 2004-02-28 Jean-Pierre Roux
1947 * ENH add gdcmDicomDir:NewPatient
1948 add gdcmDicomDirPatient:NewStudy
1949 add gdcmDicomDirStudy:NewSerie
1950 add gdcmDicomDirSerie:NewImage
1951 to allow making gdcDicomDir object.
1952 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1953 (as opposite to the gdcmHeader chained list)
1955 2004-02-11 Benoit Regrain
1956 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1957 when using from python
1959 2004-02-10 Benoit Regrain
1960 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1961 * FIX : in gdcmDicomDir when the directory is empty
1962 * ENH : add callback and methods to get the progression of dicomDir
1965 2004-02-06 Jean-Pierre Roux
1966 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1967 - GDCM_META added to gdcmDicomDirType
1968 - class gdcmMeta created
1969 * ENH : - A brief summary is now displayed at the beginning of
1970 'testDicomDir' to help disaster magnitude estimation
1971 * REM : Now useless Test/explDICOMDIR.cxx
1973 2004-02-05 Benoit Regrain
1974 * ENH : add methods in gdcmObject to get the hash table or the list of
1976 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1977 * FIX : wrapping python for TagHeaderEntryHT
1979 2004-02-04 Benoit Regrain
1980 * FIX : even length for some strings when writting the dicom dir
1981 * FIX : sort the images in the dicom dir
1982 * FIX : Bug fix for python use of dicom dir
1983 * ADD : a python demo
1985 2004-02-04 Jean-Pierre Roux
1986 * FIX : Final solution (?) for icone embedded images
1987 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1988 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1989 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1990 gdcmData/gdcm-MR-SIEMENS-16.acr1
1991 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1992 to make full checking easier
1994 2004-02-04 Benoit Regrain
1995 * FIX : WriteEntries : coding style & logic in parameters
1996 * FIX : Set the elements to create the DicomDir in a dictionary file
1998 2004-02-03 Benoit Regrain
1999 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2000 * gdcmDicomDir : add the load of directory
2001 * Bug fix and print add-on
2003 2004-02-03 Jean-Pierre Roux
2004 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2005 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2006 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2007 * FIX gdcmParser.cxx : 'group length' elements are now considered
2008 as integers, even for shadow groups, when file is Implicit VR
2010 2004-02-02 Jean-Pierre Roux
2011 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2013 of the last synonym :-(
2014 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2016 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2017 * FIX taking into account the possible 7fe0,0010 multiplicity
2018 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2019 to allow removal of references to 7fe0,0010, to deal with
2020 ACR-NEMA images, when 0028,0200 is meaningfull
2022 2004-01-31 Jean-Pierre Roux
2023 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2024 no longer writes 'Un' on disk
2025 * FIX SQ elements with actual length are now dealt with corectly
2026 * FIX gdcmFile::WriteBase make the difference, for color images, between
2027 the length (for Palette expanded images)
2028 and Raw Length (non expanded image + Palette)
2029 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2030 (that broke Write). Replaced by UL.
2031 Aware user will reload the field if he
2032 thinks it's necesssary
2034 2004-01-30 Jean-Pierre Roux
2035 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2036 when 'dirty Acr' is found, to be compliant with the new
2037 IsReadable() methods.
2039 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2040 (no DOUBLE images in kosher DICOM,
2041 but so usefull for people that miss them ;-)
2043 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2044 DICOMDIR related utilities (not checked as Windoze compliant)
2046 2004-01-28 Jean-Pierre Roux
2047 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2049 2004-01-27 Jean-Pierre Roux
2050 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2051 to allow skipping the shadow elements, to save memory space.
2052 The TRUE value for this param has to be used
2053 with a FALSE value for the 'enable_sequence' param.
2054 ('public elements' may be embedded in 'shadow Sequences')
2055 * gdcmHeader methods now deal with 'embedded icones images' in the header
2056 (even when an 'icone image sequence' is announced by the
2057 element (0x0088,0x0200), but there is NO icone at all ...
2059 * gdcmHeader sometimes Image Location value doesn't follow
2060 the supposed processor endianity (see gdcmData/cr172241.dcm).
2063 * gdcmHeader add the method
2064 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2065 to get *all* the Header Entries with the same tag.
2066 GetHeaderEntrySameName is probabely *useless*
2067 (no meaning : Name is *not* an identifier within the Dictionary)
2069 2004-01-26 Benoit Regrain
2070 * Bug fix in the print of hexadecimal representations. Remove long fields
2071 in the print and add a third level of print to print them
2073 2004-01-23 Benoit Regrain
2074 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2075 * Bug fix on test suite after remove the strip made on not string fields
2076 * Split the IsReadable method between gdcmParser which test that the file
2077 is dicom and gdcmHeader which test that it's an image file
2079 2004-01-22 Benoit Regrain
2080 * DicomDir : clean code, add methods, set variables in protected or private
2081 * gdcmUtil : bug fix for the clean string method
2083 2004-01-19 Benoit Regrain
2084 * Add the use of shadow dictionaries
2085 * bug fix and coding style
2087 2004-01-19 Benoit Regrain
2088 * src/gdcmFile.cxx : bug fix concerning the close of file
2089 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2090 * Add the update of header entries using the shadow library
2092 2004-01-19 Benoit Regrain
2093 * removal of file gdcmHeader2.cxx
2094 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2095 inheriting from gdcmParser. This split is to prepare the integration
2096 of dicom dir parsing
2097 * bug fix under python
2099 2004-01-16 Jean-Pierre Roux
2100 * REM removal of class gdcmHeaderEntrySet
2101 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2102 * ADD add file gdcmHeader2.cxx
2103 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2105 2004-01-15 Benoit Regrain
2106 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2107 entries created while parsing the header. Thus, they will be destroyed
2108 when the gdcmDictSet will be destroyed
2109 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2112 2004-01-15 Benoit Regrain
2113 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2114 made a fatal error because of the memory release at the end of program.
2115 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2116 some memory and vtk seems to have some problems with that.
2117 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2119 2004-01-14 Benoit Regrain
2120 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2121 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2122 * src/*.[h|cxx] : make changes due to class name changes
2123 * gdcmPython/demo/*.py : bug fix due to method names
2125 2004-01-13 Benoit Regrain
2126 * src/*.[h|cxx] : coding style
2127 * vtk/*.[h|cxx] : coding style
2129 2004-01-13 Benoit Regrain
2130 * gdcmPython/testSuite.py : test the readable flag of file for tests
2131 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2132 It's lied to the stl compilation by MSVC (windows, always windows...)
2133 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2135 2004-01-12 Benoit Regrain
2136 * src/*.h : add comments
2137 * src/gdcmDictSet.h : set the method BuildDictPath in public
2138 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2139 directly setted in the source code
2140 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2143 2004-01-09 Benoit Regrain
2144 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2145 * setup.py : use a reference to gdcmVERSION
2147 2004-01-07 Benoit Regrain
2148 * Modification to compile with the distutils.
2151 2003-12-10 Benoit Regrain
2152 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2153 can use a gdcmHeaderHelper to load data
2154 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2155 made in the source code
2157 2003-12-10 Benoit Regrain
2158 * Update Windows projects and .cvsignore files
2160 2003-11-12 Jean-Pierre Roux
2161 * ENH gdcmHeader constructor has one more parameter (default value : false)
2162 that allows the user to 'go inside' the SeQuences only
2164 gdcmElValSet:Print takes it into account
2166 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2167 * ENH: Update gdcmPython/CMakeLists
2168 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2169 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2171 2003-11-10 Jean-Pierre Roux
2172 * FIX : gdcmHeader::LoadElements is now based
2173 on the ListTag listElem member,
2174 not longer on the TagElValueHT tagHt member
2175 * ENH : PrintPubElVal shows (temporarily) both results,
2176 with the tagHt member and the listElem member.
2177 (it's easier to 'see' the problems when using Printheader)
2179 * FIX : old private member LgrElem is now splitted into
2180 ReadLength : Length actually found on disk (updated only
2181 if bug fixing is necessary), for internal
2183 UsableLength : Updated by FixFoundLength, to fix a bug
2184 or to allow Parser going on.
2185 Will allow to re-write a kosher header when a SeQuence
2186 with a length (not 0000) is found
2187 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2188 because gdcmElValSet::Add does not update ListElem
2191 2003-11-07 Jean-Pierre Roux
2192 * FIX misstyping in Transfert Syntax name table
2193 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2194 when they have an actual length (not 0000 nor FFFFF)
2195 (Nobody should care of it, but DICOMDIR explorers)
2197 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2198 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2200 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2201 * ENH: vtkGdcmReader now supports LUT !
2202 (vtkgdcmViewer for now is not able to use them though)
2204 2003-11-05 Jean-Pierre Roux
2205 * in testSuite.py : new files names for checking the package
2206 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2207 that returns the pixel area size to the *aware* (vtk) user
2208 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2210 2003-11-05 Benoit Regrain
2211 * in testSuite.py : Modify the rules for checking the paths
2212 : Explicit error messages
2213 * in __init__.py : Related modif
2215 2003-11-03 Jean-Pierre Roux
2216 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2217 to be used by aware (vtk) users that want to manage
2218 LUT (and no to turn the PALETTE image into an RGB pixels one)
2219 * GetPixelType now returns 8U for 24 Bits images
2220 (vtkGdcmReader compliant)
2222 2003-10-31 Jean-Pierre Roux
2223 * Removal of *all* gdcmData images and add them again
2224 in order to loose the 'history' of un-anonymised images
2226 2003-10-31 Jean-Pierre Roux
2227 * RMV : removal of useless jBitsInJsample.h
2228 for both 8 and 12 Bits JPEG Lossy Libraries
2230 2003-10-31 Jean-Pierre Roux
2231 * ENH : Add the functions gdcmFile::GetImageDataRaw
2232 gdcmFile::GetImageDataIntoVectorRaw
2233 that act as GetImageData and GetImageDataIntoVector
2234 except the making of an RGB Plane from Gray Plane + LUT
2235 Intended to aware (vtk) users who know how to manage
2238 GetLUTRGBA return a R,G,B,A LUT if any
2239 lgrTotaleRaw gives the 'Raw' length
2240 GetImageDataRaw returns the gray Plane
2241 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2242 (They stay Grey, just like with other Dicom viewers :-(
2244 2003-10-30 Jean-Pierre Roux
2245 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2247 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2248 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2249 being coherents dicom files.
2251 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2252 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2254 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2255 * ENH: Two steps is necessary to please VC++ compiler...
2256 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2257 * ENH: Add include dir to medcon lib
2258 * FIX: only one function is being exported for now !
2259 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2261 2003-10-29 Jean-Pierre Roux
2262 * adding gdcmHeader::GetLUTRGBA
2263 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2264 --> Mathieu, the modif u're waiting for is not yet committed
2265 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2267 2003-10-27 Jean-Pierre Roux
2268 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2269 00191113.dcm DermaColorLossLess.dcm
2270 MxTwinLossLess.dcm RadBWLossLess.dcm
2271 * ENH: For version prior to vtkImageViewer2 -r 1.19
2272 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2274 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2275 * Removal of ido stuff in CMakeLists.txt
2277 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2278 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2279 * FIX: remove a call to ->Modified ... see comments
2280 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2282 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2283 * FIX: Problem with path for libvtkgdcmPython
2284 * ENH: Try adding a search script for python site-package
2285 * RMV: Remove some file from medcon lib that are not necessary
2286 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2287 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2288 * FIX: More pragma disable fro VC++,
2289 I don't think I break something as it is also disable in VTK/ITK.
2290 But it fasten debug compilation time.
2292 2003-10-23 Jean-Pierre Roux
2293 * gdcm now deals with 16 Bits Run Length Encoded images
2294 (they are compressed as 2 planes images,
2295 one for the high Bytes, the other for low Bytes)
2297 2003-10-22 Jean-Pierre Roux
2298 * Now CheckRead takes into account :
2299 - the bugged 'Leonardo' Siemens images
2300 - the XA images, sent thru the burning VPRO station
2301 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2304 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2305 * FIX: When copying a Makefile.am to CMakeLists.txt
2306 one should remove the '\'
2308 2003-10-22 Jean-Pierre Roux
2309 * in gdcmData adding a bugged 'Leonardo' Siemens image
2310 (wrong lengths in header)
2311 OK with gdcm, KO with the other viewers :-)
2312 * add a GE dlx XA image, thru the VEPRO burning station
2315 2003-10-21 Jean-Pierre Roux
2316 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2317 for a brutal checking of vtkgdcmViewer compliance
2319 2003-10-21 Jean-Pierre Roux
2320 * add the files for 'xmedcon' Jpeg Lossless library
2321 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2323 2003-10-21 Jean-Pierre Roux
2324 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2326 2003-10-21 Jean-Pierre Roux
2327 * garbage Siemens 'Leonardo' images dealt with
2328 (the patch is easy to remove)
2329 * cosmetic changes to avoid warnings
2331 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2332 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2333 no need to press 'r' now.
2335 2003-10-20 Jean-Pierre Roux
2336 * upgrade of checkRead.sh checkWrite.sh according
2337 to new Jpeg Lossless decompressor
2338 * add US.3405.1.dcm, a genuine RGB medical file ...
2339 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2340 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2342 2003-10-15 Jean-Pierre Roux
2343 * general anonymisation in gdcmData
2344 * adding the 'color files' from
2345 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2346 * adding some well knowed bugged-header images
2347 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2348 waiting for their inclusion in Python testsuite
2350 2003-10-15 Jean-Pierre Roux
2351 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2352 no longer seg faults when file is not found
2354 2003-10-14 Jean-Pierre Roux
2355 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2358 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2359 * TODO: *.in file to genereate a UseGDCM later
2361 2003-10-14 Jean-Pierre Roux
2362 * Some supposed-to-be Dicom Images have no preamble.
2363 OpenFile takes it into account
2364 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2365 * Missing elements added in dicomV3.dic
2366 (just to be affraid : have a look at
2367 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2368 and do it again next year ;->
2370 2003-10-13 Jean-Pierre Roux
2371 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2372 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2373 But there are NOT. It's fixed !
2375 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2376 * FIX: "jpeglib.h" was not found on VC++
2377 * FIX: vtkgdcm was not being installed
2379 2003-10-10 Jean-Pierre Roux
2380 * ENH : OpenFile closes the file if it *really* doesn't look like
2381 an ACR-NEMA / DICOM one.
2382 * FIX : testWrite no longer writes an empty file if the source file
2383 is not gdcm Readable
2384 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2387 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2388 * FIX: CMake generate now documentation
2389 * ENH: out of source doc build !
2390 * ENH: Generate both user and dev documentation
2391 * ENH: Should work on windows too
2392 * ENH: Only one doxygen config.in file is needed
2393 * FIX: make install should be ok now on ùnix plateform
2394 * FIX: PATH to dictionary was wrong (missing /)
2395 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2397 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2398 * vtkGdcmReader is now able to read rgb dicom file.
2399 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2400 * added a gdcmViewer to vtk test, use mouse to control
2401 window level & window width
2403 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2404 * CMake-ification of gdcm, we have now two build system
2405 * FIX: on cygwin Wsock32 doesn't exist
2406 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2408 2003-10-06 Emanuel Ollart
2409 * FIX : compilation process wad broken.
2410 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2412 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2413 * change gdcmViewer -> vtkgdcmViewer
2414 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2416 2003-10-06 Jean-Pierre Roux
2417 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2418 ( e.g : well known GE images with a wrong elem length,
2419 : Philips MRI Images with a wrong Huffman table)
2420 * still to be done : allow the reading of bugged LEONARDO Siemens images
2422 2003-10-03 Jean-Pierre Roux
2423 * Odd length strings are padded with '\0' (not with spaces,
2424 to remain compliant with already defined strings,
2425 like Transfert Syntax UID and others)
2427 2003-10-03 Jean-Pierre Roux
2428 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2429 to allow displaying RGB images (not only by affim ;-)
2431 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2432 * vtkGdcmReader is now able to read rgb dicom file.
2433 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2435 2003-10-03 Jean-Pierre Roux
2436 * A few nasty patches to allow the reading of a lot of nasty images
2437 ( e.g : well known GE images with a wrong elem length,
2438 : Philips MRI Images with a wrong Huffman table)
2439 * still to be done : allow the reading of bugged LEONARDO Siemens images
2441 2003-10-03 Jean-Pierre Roux
2442 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2444 2003-10-03 Jean-Pierre Roux
2445 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2446 to allow displaying RGB images (not only by affim ;-)
2448 2003-10-03 Jean-Pierre Roux
2449 * gdcmFile::GetImageDataIntoVector now
2450 - deals with MultiFrames MultiFragments Run Length Encoded files
2451 - deals with YcBcR (YBR_FULL) files
2452 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2453 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2455 (no sample found :-(
2457 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2458 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2459 Two reasons: - clear things
2460 - third parties acces gdcm through header files, so won't
2461 suffer anymore VC++ complains
2463 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2464 * add argv[1] in testvtkGdcmReader.cxx
2467 2003-09-24 Jean-Pierre Roux
2468 * The lines are now eigthy characters long.for
2469 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2471 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2472 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2473 char* to std::string. Thus, the use of strdup becomes useless. (see
2474 previous commis of Malaterre)
2475 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2476 before the last Malaterre's commit.
2478 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2479 * This commit should fix the Debug building under VC++, the problem
2480 was mainly a mixture of debug and release lib being loaded at startup.
2481 * I also remove a depency to a specific C function: strdup. Because I had
2482 to force the link to msvcrtd (whereas strdup is in libc).
2484 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2485 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2486 located in the gdcmCommon.h file. All use of reference of tha has been
2487 changed to now use the variable GDCM_UNFOUND.
2489 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2491 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2492 Dicom dictionary. The test suite can now be run again. Note:
2493 I'm note very happy with the " (RET)" changes. I believe this
2494 RETAINED comment should be dropped when parsing the dictionary.
2495 - PACKAGER corrected
2497 - AUTHORS updated and now in alphabetical order
2498 * Makefile.am now exports gdcm.dsw for Windoze users.
2500 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2501 * cygwin complains about missing std:: in subdir Test/
2503 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2504 * remove some methods that are now in gdcmHeaderHelper
2506 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2507 * vtkGdcmReader set spacing and origin correctly
2509 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2510 * Fix a few delete/delete[] mismatch
2512 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2513 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2514 interpretation to data given by gdcmHeader. For instance there are
2515 heuristics to get informations (look at different places).
2516 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2517 sorting DICOM images based on different strategies.
2518 * modified Makefiles accordingly.
2520 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2521 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2522 when building in debug mode
2523 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2524 src/win32/gdcmdll.dsp
2525 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2527 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2528 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2531 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2532 * src/win32/libgdcmjpeg12.dsp was not dos format
2533 * src/win32/libgdcmjpeg12.dsp :
2534 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2535 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2537 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2538 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2540 * src/gdcmFile.cxx : bug fix in affectation type
2541 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2542 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2543 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2544 symbols... future problem ?
2546 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2547 * src/win32/libgdcmijpeg12.dsp was missing
2548 * modified gdcm.dsw accordingly
2550 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2551 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2553 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2554 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2555 commit of JPR (before his hollidays to facilitate our work).
2556 * setup.py : bug fix in code. Modifications made while the last commit
2557 of JPR. The code hasn't been tested before the commit... it's so
2558 useless to make that (for best programmer that is JPR) !!!
2560 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2561 * tagged the current version as Version0_3 (i.e. version 0.3)
2563 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2564 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2565 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2566 * *.dsp : modifications to use new libgdcmijpeg8 library
2567 * setup.py : bug fix on VTKPATH variable
2568 * PACKAGER : adding all concerning windows
2570 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2571 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2573 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2574 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2575 test suite reported error.
2576 * PACKAGER file added (describes what a packager must do when
2577 packaging a new release).
2578 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2579 * configure.in: upgraded version number to 0.3.0
2580 * fixing build of rpm (through rpm -ta):
2581 - Doc/Makefile.am exports proper doxygen files
2582 - src/jpeg/libijg8/Makefile.am exports the include files.
2584 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2585 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2586 * src/gdcmHeader.h : formatting code
2588 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2589 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2590 We were obtaining error message from vtk. Now, creation of file list
2591 is made in an internal list to prevent this problem.
2592 Bug fix when output is empty.
2593 Bug fix in update of progress value. Previous commit for this was a bad
2595 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2597 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2598 * src/gdcmHeader.h : added method to get the file name
2599 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2600 files. Added method to remove all files on the input
2601 Added FIXME comment concerning the bad parsing of header made by
2602 ExecuteInformation method (in ExecuteData method)
2604 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2605 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2606 when using make instal.
2607 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2608 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2610 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2611 * setup.py : adding include dir of jpeg lib to compile all sources
2612 * */Win32/*.dsp : JPR fix for windows compilation
2614 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2615 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2617 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2618 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2620 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2621 * setup.py is again effective on un*x (takes into account the
2622 addon of the jpeg library)
2623 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2624 * Doc/Doxy* updated (includes above enhancements)
2625 * INSTALL now points to web documentation
2627 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2628 * src/gdcmHeader.h doesn't make unnecessary reference to
2630 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2632 * src/gdcm*.[cxx|h] :
2633 - to allow compilation with gcc 3.x
2634 -- clean up of STL usage (added explicit usage of std::)
2635 -- small fixes on exceptions.
2636 Note: linking not tested !
2637 - clean of doxygen comments to avoid warnings at documentation
2639 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2640 dependent convertion).
2642 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2643 * Clean up of previous JPR garbage commit (not even commented in the
2645 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2646 - moved all jpeg related files from src to src/jpeg/libijg8, with
2647 addition/modification of Makefile.am and configure.in.
2648 - the testSuite is still brain damage (not guilty).
2650 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2651 * WrapVTK.py : modifications to get correctly vtk source files to
2653 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2654 (FileName -> Filename)
2656 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2657 * vtk/vtkGdcmReader.[cxx/h]:
2658 - UpdateProgress method should now be effective
2659 - removed the limitation on having only images loaded (as opposed
2661 - when building a stack of images/volume, a lesser number of
2662 gdcmHeader and gdcmFile instances should be used (hopefully
2663 accelerating things).
2664 - when building a stack of images/volumes, files which are not
2665 loadable (wrong path-filename, wrong permissions on existing file,
2666 or file not parsable by gdcm) are replaced with a black image
2667 in the stack (for the caller to notice the problem).
2669 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2670 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2672 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2673 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2674 between standard library (std) and vtk library (problems are found
2675 under Windows... thanks Windows !)
2677 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2678 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2680 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2682 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2683 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2685 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2686 * When compiling with distutils (see setup.py) the C++ compiler is
2687 called with different flags than the default ones (with automake).
2688 In order to fix all those warning, I compiled gdcm with the command
2689 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2690 and went for warning fixes:
2691 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2692 up from unused variables.
2693 - vtk/vtkGdcmReader.cxx: potential bug fix.
2694 * src/gdcmHeader.h: Doxygen warning cleanup
2696 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2697 * gdcmPython/gdcm.i:
2698 - typemaps correction to take into account the systematic replacement
2699 of "using namespace std" with std:: prefix e.g. std::list,
2700 std::string... (cf changes of 2003-05-21).
2701 - gdcmGlob global variable of type gdcmGlobal (defined in
2702 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2703 exported to Python a as cvar.
2704 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2705 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2706 gdcmDictSet.GetPubDictTagNames() and
2707 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2708 C++ static methods).
2709 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2710 with the above changes.
2712 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2713 * setup.py, manifest.in : bug fix under linux
2715 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2716 * Modification of setup.py to compile vtk part too. Then, we have 2
2717 wrappers which must work with same distutils. For that, we have a
2718 generic distutils in distusiltsWrapping.py ; with :
2719 - build_extWrap class to wrap generically all extensions,
2720 - ExtensionWrap base class for all wrapping extension that contains
2722 - Wrapper interface which wrap sources
2723 + In WrapSwig.py we have extension and wrapper for Swig
2724 + In WrapVTK.py we have extension and wrapper for VTK
2725 * MANIFEST.in : modifications to consider vtk directory and new python
2726 files for compilation
2728 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2729 * Added python wrappers of vtkGdcmReader vtk class (see the
2730 source in vtk/vtkGdcmReader.cxx) :
2731 - vtk/Makefile.am now builds a library
2732 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2733 python library (as opposed to _gdcm.so wich are the python
2734 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2735 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2737 - configure.in has an additional flag --enable-vtk that needs
2738 to be set to enable compilation of vtk related code, that is:
2739 + vtk/vtkGdcmReader.so and
2740 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2741 + gdcmPython/vtkgdcmPython.so (see above)
2742 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2743 be read when compressed or when HighBit + 1 != BitsStored),
2744 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2745 the usage of the python wrapper of vtkGdcmReader vtk class.
2746 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2747 * src/*.[h] all occurences of stl classes are now prefixed with
2748 std::, and all occurences of "using namespace std;" where removed.
2749 This is to avoid pollution of global namespace in included files.
2750 Apparently vtk does not avoid this pitfall: when using both
2751 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2752 collision of various stl members (principally cout...).
2753 * gdcmPython/testSuite.py now cleanly removes temprory generated
2755 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2756 comply with above changes)
2758 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2759 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2760 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2761 vtk data structure (an image Flip was required).
2762 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2763 * cosmetic changes in documentation.
2765 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2766 * src/gdcmHeader.cxx: the constructor no longer exits when an
2767 unexisting file is given as argument.
2768 * The subdirectory Data (containing all the images used for the
2769 test suite) is not part of this repository anymore. A new module
2770 containing those images is now available at
2771 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2772 with the name gdcmData.
2773 All the python scripts (including the package initialisation file
2774 gdcmPython/__init__.py) were adapated to take this change into
2775 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2777 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2778 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2779 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2780 demo of the usage of this class.
2781 Compilation of this vtk part is only done when using the --enable-vtk
2782 at configure (or autogen.sh) stage.
2784 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2785 * More memory link related corrections and documentation fixes.
2787 - maximum info is obtained with a command of the form:
2788 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2789 --show-reachable=yes PrintHeader
2790 - the remaining reachable blocks seem to come from the STL
2791 allocation scheme through the usage of map and list. It looks
2792 like this memory cannot be freed but it is not a memory leak
2793 (in fact further invocation to the STL would recollect the
2794 unused memory allthough it cannot explicitely be freed).
2795 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2796 of displaying an image parsed with gdcm and displayed with VTK.
2797 Note: some images don't seem to work e.g.
2798 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2799 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2800 Allthough this weakens the semantics, it is a ditch attempt to
2801 make gdcm more thread friendly.
2803 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2804 * Memory link hunt (by using valgrind through the command
2805 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2806 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2807 gdcmHeader::_dicom_vr.
2808 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2809 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2811 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2813 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2814 * src/Makefile.am now exports all the necessary include files at
2818 * UpdateGroupLength replaced by new one
2821 * UpdateGroupLength re-written using H-Table
2822 (named UpdateGroupLengthNew untill checks are over)
2824 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2825 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2826 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2828 - gdcmHeader::GetPubElValSet removed.
2829 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2830 UpdateGroupLength, WriteElements, Write.
2831 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2832 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2833 carried the same semantics.
2834 - src/gdcmHeaderIdo.cxx changed accordingly.
2835 - gdcmFile::WriteBase now regroups all the codes from previous
2836 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2837 - enum FileType moved to gdcmCommon.h
2838 * src/gdcmHeader.cxx AddDefault trashed
2839 * gdcmGetXSize added
2840 * getimageDataSize now calls gdcmGetXSize
2841 * Test/*.cxx changed to agree with above changes
2843 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2844 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2845 (to avoid double call by end user).
2846 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2847 by end user, since gdcmHeader::gdcmHeader now handles it.
2849 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2850 * gdcm/Doc many doxygen changes:
2851 - Doxyfile now has two different versions, DoxyfileUsers that generates
2852 the html.users end users oriented documentation and
2853 DoxyfileDeveloppers that generates the html.developper developper
2854 oriented documentation.
2855 - README changed accordingly
2856 - requirement.txt removed (old design info moved to TODO).
2857 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2858 DoxyMainPage.txt, DoxyPython.txt provide more information.
2859 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2860 be updated by simply regenerating the docs with doxygen and copying
2861 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2862 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2863 all the tests in the form "if (<map>.count() >1)" were removed.
2864 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2865 ill-formed documentation sections.
2866 * src/gdcmHeader.cxx: ditto
2868 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2869 * setup.py fixed for un*x (needed macro for stdint.h)
2870 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2871 un*ces with sh-utils test utility.
2872 * gdcmPython/demo/test.py renamed to PrintHeader.py
2873 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2874 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2875 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2876 * src/gdcm*.cxx JPR's bad inclusion fixed.
2878 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2879 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2880 * gdcmPython/demo/test.py changed accordingly.
2882 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2883 * gdcmPython/Makefile.am fixed linking against libstdc++
2884 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2885 * Swig subdir (historical tests of swig version 1.3.17++) removed
2886 * Test/testChangeEntete.cxx some lines commented out in order to make
2888 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2889 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2891 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2892 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2893 hence the user doesn't need this explicit call.
2894 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2895 i.e. LoadElements() call removed.
2896 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2897 - src/Makefile.am declares the proper flag for g++.
2898 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2899 for adding user defined new tags.
2900 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2901 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2902 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2904 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2905 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2906 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2907 src/Makefile.am : the project should properly compile and install
2908 with the autotools, included the python wrappers part.
2909 * gdcm.spec.in : added a spec file for RPM packaging.
2911 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2912 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2914 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2915 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2916 to exported to the environement (see gdcmPython/testSuite.py
2918 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2919 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2920 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2921 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2922 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2924 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2925 * gdcmPython/__init__.py doesn't crash anymore when running in
2926 in InstallMode or PreInstallMode but with an environment given
2927 value of GDCM_DICT_PATH.
2928 * src/gdcmDictSet.[cxx/h] coding style.
2930 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2931 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2932 * src/gdcm.h general comments moved to TODO, and README
2933 * src/gdcm.h should now be seen as a user commodity (including it
2934 should suffice to fully use gdcm). It is nowhere including within
2935 any of the kernel files src/*.cxx and src/*.h.
2937 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2938 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2939 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2941 * src/gdcm*.cxx only include their corresponding include file
2942 (as opposed to gdcm.h)
2943 * gdcmPython/gdcm.i changed accordingly
2944 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2945 the autogen.sh generated "make snapshot" command to work.
2946 * autogen.sh removed history related references to crea package.
2948 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2949 * distutilsSwigCPlusPlus.py work around some swig portability
2952 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2953 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2954 was done in a last ditch attempt to get setup.py _really_
2955 operationnal. The python/gdcmPython layaout add the advantage
2956 of hidding away the python related distutils specific files
2957 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2958 Alas, the src directory was out of scope (i.e. it's relative
2959 position to setup.py was ../src) which made things impossible to
2960 handle (see previous version of python/setup.py). Crossing fingers...
2962 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2963 * python/setup.py now works on Un*x. (harder than I thougth)
2964 * python/distutilsSwigCPlusPlus.py can now have include files
2965 among the list of sources.
2967 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2968 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2969 * modifications in MSVC projects
2971 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2972 * As stated by the first lines of Test/ExceptionAndPython/README, it
2973 looks like we can move back to original usage of exception within
2974 src/gdcm* and hence remove the errno stuff that was introduced
2975 as a quick and dirty fixture of this problem (added to the TODO).
2976 * Doc/Doxyfile configuration file for Doxygen and corresponding
2977 README file for usage added.
2978 * Test/testWrite.cxx added. This new test comes from a split of
2979 test.cxx that is now reverted to its original purpous i.e.
2980 testing the proper parsing of a Dicom related file.
2981 testWrite.cxx concentrates on testing the IO part of gdcm.
2982 * Test/bug1.cxx (containing a bug on WIn32) added.
2983 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2984 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2985 whose purpose is to publish the content of the TagNames of the
2986 Dicom public dictionary were not accessible without an
2987 instance of class gdcmHeader.
2988 - those methods are now static methods of gdcmDictSet and hence
2989 require no instances at all to be invocated.
2990 - within gdcmDictSet this change required to change some method
2991 to class methods (i.e. are now static) among which SetDictPath
2992 (renamed to BuildDictPath) and LoadDefaultPubDict.
2993 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2994 the above changes by calling the new method classes of gdcmDictSet.
2995 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2996 the above to be effective.
2997 * python/gdcmPython: in order to wrap properly the above changes
2998 for Python, swig version now needs to be > 1.3.17.
2999 * python/gdcmPython/Makefile fixed to adapt itself to new
3000 configure/make shema introduced by Johan Montagnat (thanks for the
3001 contribution). Alas this Makefile cannot be turned into a proper
3002 Makefile.am without some heavy changes in the configure.in
3003 (for python dectection).
3004 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3005 now avoids publishing the empty entries.
3007 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3008 * python/setup.py : bug fix concerning install under windows
3009 ExtraPath reused :-P
3010 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3012 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3013 * Dicts/dicomV3.dic : remove double spaces !!!
3014 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3015 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3018 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3019 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3020 method. Doxygenation.
3021 * src/gdcm.h clean up of JPR spurious comments.
3023 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3024 * python/distutilsSwigCPlusPlus.py now properly collects the
3025 shadow classes generated by "swig -c++" (gdcm.py in our case)
3026 when using "python setup.py install".
3027 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3028 reexports the working classes.
3029 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3030 by the classical C errno scheme. This is to prevent an obscure
3031 behavior of the python wrappers when importing wxPython.wx prior
3032 to gdcmPython (which ended up in an abort call). An illustration
3033 of this oddity can be found in the Test/ExceptionAndPython
3034 subdir (see the README file). This problem probably due to
3035 an combination of g++ and dynamic loading.
3036 * added Test/ExceptionAndPython (see above)
3038 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3039 * Changed the layout of the python part to avoid bloating main
3040 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3041 i.e. the distutils arsenal. All the python related stuff is
3042 again in a python subdir, but the package itself is now in
3044 * setup.py was cleaned up:
3045 - pythonIncludePath removed
3046 - python setup.py bdist target is now functional.
3047 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3048 collision with other packages). gdcmPython/demo/*.py changed
3051 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3052 * python subdir moved to gdcmPython (preparation of distutils packaging).
3053 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3054 distutils installer is operational.
3055 * - gdcmPython/__init__.py now properly loads the swig generated
3056 shadow classes (from gdcm.py).
3057 - gdcmPython/demo/*.py changed to import the package gdcmPython
3058 instead of gdcmPython/demo/load.py.
3059 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3061 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3062 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3063 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3064 entries within the associated public Dicom dictionary resp. the same
3065 information but sorted by the fourth field (PAT, IMG, DIR) of the
3067 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3068 are now in the "???" group.
3069 - python/gdcm.i changed accordingly,
3070 - python/demo/printGroupedPublicDict.py added, that gives an example
3071 of the above new functionalities in Python.
3073 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3074 * src/gdcm.h, gdcmHeader.cxx:
3075 - historic references to glib's g_malloc and g_free (#defined)
3076 were definitively removed.
3077 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3078 * src/gdcmElValSet.cxx:
3079 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3080 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3081 - GetElValue(string) renamed to GetElValueByName.
3082 - Added GetElementByName(string).
3083 * src/gdcmHeader.cxx: added
3084 - GetPubElValRepByNumber(guint16, guint16)
3085 - GetPubElValRepByName(string)
3086 - GetShaElValRepByNumber(guint16, guint16)
3087 - GetShaElValRepByName(string)
3088 - GetShaElValByNumber(guint16, guint16)
3089 - GetShaElValRepByName(string)
3090 - GetElValRepByNumber(guint16, guint16)
3091 - GetElValRepByName(string)
3092 - GetElValByNumber(guint16, guint16)
3093 - GetElValRepByName(string)
3094 * Doc/requirements.txt added.
3096 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3097 * Test/Makefile building now depends on the one of libgdcm.so
3098 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3099 pixel data) aware which enables finding the address (offset) of
3100 the pixel data of JPEG encoded DICOM files. This leaves only a single
3101 file in the testSuite whose pixel data address (offset) is unknown.
3102 * python/testSuite.py changed accordingly.
3104 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3105 * VC++ has some strong limitations when working with the STL, as stated
3106 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3107 "Also note that some STL containers (map, set, queue, list, deque)
3108 cannot be exported. [...]
3109 Some STL classes contain nested classes. These classes can not
3111 This is caused by a designed limitation that once a template
3112 class is instantiated, it can not be re-instantiated and
3114 Since our usage of map<> is ubiquitous in gdcm, this "designed
3115 limitation" of VC++ is a pitfall.
3116 Hence the Python wrappers of gdcm cannot be incrementally linked
3117 against the c++ dynamic library. The dirty but only workaround is
3118 to forget about incremental link of dynamic libraries and to generate
3119 the Python wrappers library with the inclusions of the underlying C++
3121 The following modifications concern this matter on Win32/VC++:
3122 - wrapping python correct with standalone wrapped dll (don't use separate
3123 dll under windows !!!!)
3124 - python21_d debug mode enabled (ask Frog how to use it :-)
3125 - NO problem with having an STL member of class for example string in C++
3126 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3127 - Python test of dcmlib in Python is ok under windows on a large set
3129 * removed glib references
3130 * typedef's inserted in gdcm.i for correct swig type management
3132 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3133 * python/demo/*.py load.py extracted from test.py. Added explore.py
3134 that only displays required tags and testAll.py that parses all
3135 the files of the testsuite without using unittest.
3136 * python/testSuite.py other additional test on new files added.
3137 * Data/* new test files added accordingly to the testSuite.
3138 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3139 the vr in the file differs from the one of the dictionary.
3141 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3142 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3143 values, but limits itself to values which are below a user specified
3144 size (by default 1024 bytes).
3145 * python/gdcm.i : elements not loaded (because their size is above the
3146 user specified treshold) are exported with their TagKey as key of the
3147 python dictionary. This enables the testsuite to make some checks
3148 on the unloaded elements (since we have their offset and size).
3149 * python/testSuite.py
3150 - now tests for the existence and proper value of the pixel data
3151 - two new examples added.
3152 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3154 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3155 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3156 aware. See the strategy comments in gdcmHeader::FindeLength().
3157 * Test/test.cxx now accepts a filename as first argument.
3158 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3159 * python/testSuite.py changed to integrate test on above files.
3161 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3162 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3163 the vr was also RET.
3164 * python/testSuite.py more tests added.
3166 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3167 * python/testSuite.py unittest test suite added (uses Data)
3168 * Data/* dcm and acr files for the test suite.
3169 * glib dependance removed from un*x version. We now use ISO C99
3170 7.18 Integer types (see stdint.h)
3171 - python/Makefile, src/Makefile src/gdcm.h
3172 * src/ when an explicit vr (like dicom files) suddenly poped an
3173 implicit element we use to mark the underlying DictEntry of the
3174 concerned ElValue with "Implicit". This strategy was damageable
3175 too the public or provite dictionaries, since some of their vr
3176 would be changed. Since Header::FindLength heavily relies on the
3177 detection by Header::FindVR of falsely explicit elements, I
3178 added an extra ImplicitVr member to ElValue (boolean).
3179 The rest of the changes we the necessary adaptations.
3181 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3182 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3184 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3186 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3187 * Adaptation for porting to VC++:
3189 o forced to use std namespace (for string to be known)
3190 o all class use __declspec export style on WIN32
3191 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3192 (in stdlib.h on Win32 but in std:: for gcc)
3193 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3194 variable GDCM_DICT_PATH.
3195 * src/gdcmHeader.cxx verbose comments made discrete.
3197 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3198 * python/gdcm.i: added a typemap that converts a C++ hashing table
3199 to native Python dictionary.
3200 * python/demo/test.py:
3201 - now uses the native dictionary for exploration of gdcmHeader.
3202 - takes an optional filename argument (the file to parse).
3203 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3204 PubElVals hashing table.
3205 * Dicts/dicomV3.dic removed error prone trailing spaces.
3207 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3208 * Python wrapping process moved away from src/Makefile to
3209 newly created python/Makefile (as well as gdcm.i)
3210 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3211 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3212 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3213 from the environement variable GDCM_DICT_PATH (when existing).
3214 * src/gdcmDict::GetTag bug fix.
3216 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3217 * Straightforward temporary fixes for swig to build the python wrappers.
3218 src/Makefile now has a python working entry [by working we mean
3219 that we can import de shadow classes without errors].
3221 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3222 * hashtest.cxx removed (since already in Test)
3223 * src/gdcmlib.h renamed to src/gdcm.h
3224 * src/dcm.i renamed to src/gdcm.i
3225 * src/Makefile prepared for python wrapping
3227 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3228 * src/gdcmHeader.cxx :
3229 - Parsing of header is now separated from loading of element values
3230 (see gdcmHeader::LoadElements).
3231 - general clean up of hopefully all file access (creation of
3232 ReadInt16 and ReadInt32)
3234 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3235 * src/gdcmHeader.cxx :
3236 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3238 - SetLgrElem renamed to SetLength
3239 - GetLgrElem renamed to GetLength
3240 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3241 * src/gdcmElValSet.cxx fixed both GetElValue methods
3242 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3243 due to IdoDude was cleaned out.
3245 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3246 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3247 concentrates on finding the value representation (when it exists).
3248 RecupLgr now only finds the element value length, and it avoids
3249 returning the unecessary skL (skipped length).
3250 Also, offsetCourant was simply removed (with taille_fich) since
3251 it was redundant with the File position internals (by using
3252 ftell and fseek). This also made skL (see above in RecupLgr) usage
3254 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3255 on the libido specificities which are handled through class
3257 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3260 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3261 * Truckload of changes. Parsing of header is barely functional
3262 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3264 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3265 * src/gdcmHeader.cxx many addons of low level methods
3267 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3268 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3269 and _IdDcmSWAP_LONG.
3271 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3272 * This corresponds to all the changes decided at the meeting of
3273 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob