1 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
4 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
6 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
7 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
9 * Fix compilation on gcc 2.96 (which does not have ios::failure)
11 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
13 and it's representation name (for the NIH)
15 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
17 conversion of YBR to RGB pixels. So, now, the conversion is made using
20 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
22 format) to replace 'at-run' dicom files generated by the
23 TestAllReadCompareDicom test
25 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
26 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
28 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
29 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
31 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * Testing/TestMAkeIcon.cxx : complete the test
34 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
37 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
41 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
44 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * Test/ : accelerate tests (it's not very significant accelerations).
46 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
48 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
49 * Testing/TestSequence.cxx : add test for sequences of images... test that
50 we have the same serie or the same study UID
52 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
55 * src/gdcmDict.h : remove commented code
56 * src/gdcmDocument.cxx : initialize values
57 * src/gdcmFile.cxx : bug fix when reading values
58 * gdcmPython/demo/ : change file names. Remove useless files
60 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * src/gdcmFile.cxx : remove the default array of initialization.
62 The static array contained pointers to non-static values (comming from
63 strings). To have coherences, when creating files, these values can't be
64 static. So, the array can't be static, too ! To simplify, the array have
65 been replaced by repeted lines to insert values in the File
67 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
69 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
71 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
72 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
73 (Dicom Element) into the Sequence Item
75 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
76 * src/*.cxx : first parss to normalize file organisation
78 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
79 * src/gdcmDirList.[h|cxx] : add method to find a directory
80 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
82 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
83 * Finish cleaning up my JPEG mess. Should be ok now.
84 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
85 contained within the RLE* class(doh!)
87 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
88 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
89 * SerieHeader::AddFileName() creates as many Coherent Files lists
90 (same Serie UID) as it founds different Serie UID
91 amongst the files instead of discarting any file
92 that doesn't match with the first one he found.
93 * SerieHeader::OrderGdcmFileList has now one parameter :
94 the Coherent Files list the user wants to sort
95 * SerieHeader::GetFirstCoherentFileList() |
96 * SerieHeader::GetLastCoherentFileList() | allow to parse
97 the set of Coherent Files lists
98 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
99 compatibility (it returns the *first* Coherent Files list,
100 since there was only one before)
101 * Test/TestSerieHeader gets gdcmData as a default root directory
103 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * Remove friend between DocEntry and File classes
105 * Remove friend between PixelReadConverter and RLEFramesInfo,
108 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
110 0002|0000. The value was incorrect.
112 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
115 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * src/gdcmUtil.cxx : compilation fix on Win32
117 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
118 variable, to be easy found. Add methods to change the default UID.
119 Amelioration of the CreateUniqueUID to use the correct default UID.
120 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
123 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * Test/TestVR.cxx : fix memory leaks
126 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
127 * Rewrite the base 256 to base 10 conversion, using string operation only.
128 This allows us to get rid of the problematic 64bits integer type (does not
129 always exist on target platform).
131 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
132 * Add construct and destructor to class gdcm::Debug to close the debug file
134 * Don't let uset to open twice the same file
135 * gdcm has now an official UID prefix,
136 supplied by http://www.medicalconnections.co.uk
137 1.2.826.0.1.3680043.2.1143
138 (Thx to Mathieu for providing URL)
139 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
140 to be able to perform some more tests
141 * gdcm::ContentEntry : Contructors and Destructor are now protected,
142 in order to be sure no user will try to use them.
143 (at user level, only the children classes are meaningfull)
145 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * move RLEInfo & JPEGInfo from Document to File
148 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
149 * FIX : remove so many friend between classes
151 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
153 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
155 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
156 In order to avoid missbehaviour :
157 . gdcm::DocEntry is now specialized in
158 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
159 - gdcm::ContentEntry (Dicom entry with a 'content')
160 . gdcm::ContentEntry is specialized in
161 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
162 characters value, or integers)
163 - gdcm::BinEntry (Dicom entry with a non strig representable value
164 (user hasn't any longer to thing about the precedence of his dynamic_casts)
166 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * Test/VTKTest*.cxx : bug fix under linux
169 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
171 use with python. Some methods are moved from Document to ElementSet or
172 DocEntrySet. The equivalent methods to ElementSet have been added to
173 SQItem and are virtual in DocEntrySet. Methods that may have the same code
174 in SQItem and ElementSet is directly placed in DocEntrySet
176 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * Test/VTKTest*.cxx : remove the show variable in each test method because
178 it's useless (the viewer variable replace this variable)
180 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * src/gdcmDocument.cxx : bug fix on potential memory leak
182 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
183 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
184 Add ClearXxx methods to remove all the content of the list or map
185 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
187 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
188 * methods ReplaceOrCreate renamed as Insert
189 (nobody will be any longer confused by 'CreateOrReplace')
191 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
192 * Grealty simplify the JPEg decompression, no need to differenciate based on
193 the JPEG possible type (with/without fragment, with/without multiple frame).
194 Everything is done throught the JPEG IO Suspension mechanism in IJG
196 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
197 * Stage 3 of normalization :
198 in order to avoid any missunderstanding while reading method names :
199 - All the methods xxxEntry now deal with dicom Entries
200 - Methods GetEntry splitted into
203 - Method SetEntry renamed as SetEntryValue
204 - Method SetEntryBinArea let as it was
206 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
207 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
208 - Position correctly the entry points for JPEG2000 and JPEG-LS
209 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
211 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
213 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
214 with other method names
215 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
216 * Test/TestDicomDirElement.cxx : add new test
218 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
219 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
220 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
221 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
222 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
223 So can't you use __int64 in ostream at all.
225 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * bug fix for compilation on MSVC6
227 * gdcmPython/gdcm.i : rename of classes missed
229 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
230 * Stage 2 of names normalization :
231 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
232 (easy to understand ...)
233 - gdcm::FileHelper replaces old class gdcm::File
235 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
237 type and not a string. So, there remove problems on the format of the
240 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
241 * Add Example/TestPapyrus.cxx
242 - reads a Papyrus file (gdcm::Header compliant),
243 - gets the pixels of all the images, using low level iterators
244 - writes an multiframes Dicom image.
245 (Just to show it's *possible* to do that)
246 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
249 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
251 Thus, DicomDirXXX are created with a flad that indicates if the created
252 object is empty or not (when not empty, the DicomDirElement is used to
255 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
257 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
259 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
260 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
262 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
264 Remove all access to the hash-tables or lists in the objects.
266 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
268 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
269 be complient with all the gdcm source code
271 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
272 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
275 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
276 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
279 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
280 * Test/ : rename VTK tests to have a best name for the tests
281 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
282 GetFirstEntry/GetNextEntry use
284 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
285 * In SerieHeader::ImagePositionPatientOrdering()
286 // a Dicom 'Serie' may contain scout views
287 // and images may have differents directions.
288 // -> More than one may have the same 'pos'
289 // Sorting has then NO meaning !
290 Thx to Eduardo Davila for reporting bug.
292 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
293 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
294 test. Now it's on image content and not on the resulting visualisation...
295 might solve the problem on linux when using the OpenGL drivers
297 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
298 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
299 DicomDirSerie, DicomDirImage
300 Dict, DictSet classes :
301 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
302 -remove InitTraversal method.
303 * UPD Test programs + Example programs
305 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
306 * remove useless and never updated keyword \ingroup
307 * Solve pb when structure (list, map, ...) is empty.
308 Thx to Benoit for reporting bug
310 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
311 * Taking into account of 'Transfer Syntax' value
312 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
315 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
317 is no memory access violation
318 * gdcmPython/demo : add python demos using VTK
320 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
321 * FIX 'Dictionnary' is now spelt 'Dictionary'
322 'wether' is now spelt 'whether'
323 'archieve' is now spelt 'archive' ;-)
325 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
326 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
327 related methods, in order not to expose internal mechanisms
330 * REM methods that exposed internal mechanisms :
331 DicomDir::GetDicomDirPatients()
332 DicomDirPatient::GetDicomDirStudies()
333 DicomDirStudy::GetDicomDirSeries()
334 DicomDirSerie::GetDicomDirImages()
335 * UPD Test programs :
339 * UPD Example program
341 * ADD DictSet methods
345 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
346 * Removed the Print/indent/default parameter mess. There is absolutely no
347 reason to have to methods, moreover with the second taking the ostream as
348 *SECOND* parameter. This was clearly a bad hack to get things compile.
350 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
351 * Complete rewrite of the GetMacAddress code. Now the code is *much*
352 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
353 Unfortunately the main code does not work on SunOS, thus provide a specific
354 code for this platform only (and Win32 of course). Since this seems to be
355 working, change CreateUniqueUID to use GetMACAddress instead of the
356 problematic GctestetIPAddress
358 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
359 * Unfortunately to be able to test gdcmDirList I had to break the API
360 a little. Now the class is not a std::list anymore but has a member
361 std::vector (more ITK compatible). Allow unit testing on Win32 and
364 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
365 * Update SerieHeader to take into account a Serie Instance UID to properly
368 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
369 * ENH - Comment out Mathieu's (dangerous) Super Hack
370 for dealing with BIGENDIAN processors
371 - Move equivalent stuff to BinEntry::WriteContent
372 When necessary, 16 Bits Pixels are swapped in a small buffer
373 and then written. This avoid allocating a huge buffer, in
374 PixelWriteConvertor, and avoid modifying the Pixel Area.
376 Probabely, the same operation will have to be done when we want
377 to write image with Big Endian Transfert Syntax,
378 and we are working on Little Endian Processor
380 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
381 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
383 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
384 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
385 all the dict content.
386 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
388 * Test/TestDict.cxx : add a new test for the dict classes
390 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
391 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
392 file. Debug is yanked if compiled with NDEBUG
394 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
395 * src/gdcmDictSet.h : set the default output to the os variable
396 * src/gdcmDictEntry.[h|cxx] : add the Print method
397 * gdcmPython/demo/ : add a new test
399 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
400 * merging of Test/PrintDicomDir and Test/TestDicomDir
401 * removal of now redundant Test/PrintDicomDir
402 * enhancement of Example/PrintDicomDir
404 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
405 * Now, python test might work on systems
406 * Add the PrintDicomDir test
408 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
409 * FIX : First entry following group 0002 was lost for
410 Explicit Big Endian Transfer Syntax files
411 (group and elem not swaped)
413 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
414 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
415 Big Endian Transfer Syntax supposed the group following 0002
416 begins always by element 0000 (element 0000 is *optional*)
417 To avoid further troubles, let's be pessimistic, and use
418 Document::HandleOutOfGroup0002() method
419 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
420 (related pb not yet solved)
422 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
423 * Bug fix for the python part use
424 * Now, PrintHeader.py pass... but outside the ctest use. shit !
426 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
427 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
429 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
430 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
431 a string and should ask the global TS dict what are the propreties of
434 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
435 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
436 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
437 to swap the Swap Code, at parsing time, when we come out of group 0002
438 and Transfer Syntax is Big Endian
439 We should be able to read now 'true DICOM" Big Endian coded images
440 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
441 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
443 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
444 * Hopefully fix the bug on MacOSX and static global initialization.
445 This is the only -minor- patch I found that both please MacOSX and VS6.
446 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
447 but this would require a lot of change. Another approach would be that Global
448 create those string and GDCM_UNFOUND becomes a pointer to a string (which
449 gdcm::Global would destroy at exit).
451 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
452 * Fix bug on MacOSX with static initialization in a multy threaded
453 environment. static const string in a header file used to be ill
454 initialized provoquing the freeze of any tests. patch should solve this
457 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
458 * According to Benoit's suggestion, and without any objection from anybody
459 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
460 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
461 - method gdcmDicomDirObject::GetEntry() renamed as
462 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
464 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
465 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
466 you debug/warning message just as c++ streams which make them very convinient
467 to use. Once this is stabilize I will change the ostringstrem to be
468 redirected to a file (ofstream).
469 * Properly support C99 extension: __FUNCTION__ which allow us to display
470 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
472 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
473 * Removal of useless and dangerous methods :
474 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
475 GetDocEntryByName, GetEntryByName, GetDictEntryByName
476 * Removal of usless methods :
477 Dict::PrintByName, Dict::GetDictEntryByName
478 * Commenting out of probabely useless methods :
479 Dict::GetDictEntryNames()
480 Dict::GetDictEntryNamesByCategory()
481 DictSet::GetPubDictEntryNames()
482 DictSet::GetPubDictEntryNamesByCategory()
483 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
484 * ENH : Use dicomTS.dic as described in 2004 version
485 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
486 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
487 Add Accessors on VM (Value Multiplicity), and VM related methods
488 * ADD : Add a list of 'Dicom Attribute types', as found in
489 http://medical.nema.org/dicom/2004/04_15PU.PDF
491 * ADD : Add dicomGroupNameAbbreviations.dic
492 should be used to write a method to replace the former
493 Dict::GetDictEntryNamesByCategory()
495 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
497 to read in the file... and only it ! Length is the efective length of the
498 data in the DocEntry structure
500 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
501 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
502 And now use a static function call instead, with a global variable. i
503 This is much closer to the VTK approach. Hopefully should be bulletproof
504 and easier to use...hopefully
506 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
507 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
509 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
510 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
512 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
513 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
514 ValEntry, BinEntry, SeqEntry creation or replace
516 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
517 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
518 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
520 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
521 when specifying the VR
522 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
523 * src/gdcmDocEntry.cxx : amelioration of print
525 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
526 * ADD : Add the method Util::IsCurrentProcessorBigEndian
527 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
528 * ADD Method Document::ComputeGroupLength
529 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
530 in order to allow further VR modification by user
531 * REM : removal of once-called method File::WriteBase
532 integration of its code in formerly one-line method File::Write
534 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
535 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
536 replace the different values "??", "Unkn", "Unknown".
537 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
538 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
539 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
540 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
542 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
545 * Set the gdcm::Base class to some Printable classes
547 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
548 * src/gdcmFile.[h|cxx] : add the Print method
549 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
550 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
551 * src/gdcmDocument.h : remove the PrintLevel informations
552 * Example/PrintFile.cxx : use the new gdcm::File::Print
554 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
556 problems when compiling with the python wrapping
558 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
559 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
560 writting in ImplicitVR
562 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
563 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
564 JPEG decompression, especially when dicom frames are split into several
565 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
566 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
568 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
569 * src/gdcmHeader.cxx : change the initialisation of default header.
570 Now, this header is readable by gdm, e-film, DicomWorks
572 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
573 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
574 Rename Decompressed to Raw
575 * Use the API changes in gdcm::File.
576 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
579 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
580 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
581 each added entry in the header. Replace the 'Planes' field by the 'Number
584 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
585 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
586 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
588 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
589 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
590 At this time, this image isn't readable by e-film... waiting JPR help to
593 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
594 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
595 DocEntry. Now use methods of the Document !
597 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
598 * Test/ShowDicomSeq.cxx : bug fix
600 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
602 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
603 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
604 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
606 * Test/TestCopyRescaleDicom.cxx : remove unused variable
607 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
608 containing found sequences
610 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
611 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
613 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
614 Some fields in BinEntry must be copied to not seg fault when making the :
615 gdcm::File *copy = new gdcm::File( copyH );
616 and tests are now made on good variables
618 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
619 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
620 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
622 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
623 * Add vtkGdcmWriter example and test
625 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * Test/TestUtil.cxx : reformat the source code
627 * vtk/vtkGdcmReader.cxx : remove and change prints
628 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
630 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
631 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
633 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
634 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
635 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
637 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
638 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
639 by an eof to prevent all bad read of the file... and in this case, the
642 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
643 * Example/Volume2Dicom.cxx : comment unused variables
644 * Test/PrintDicomDir.cxx : comment unused variables
645 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
646 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
647 method that is redondant with AddEntry.
648 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
651 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
652 * Bug fix due my last commit (compilation under Windows).
653 * Example/Volume2Dicom : bug fix in the file and reformatting source code
654 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
656 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
658 - Remove printf / sprintf
659 - include iostream AFTER gdcm so we don't get warnings
660 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
662 - Also remove tons of include from header files, hopefully this should
663 speeup the compilation time, since it was becoming a dog slow.
664 - Remove gdcm.h as it include way too many files and slow down compilation
665 (plus it is not up to date)
666 - remove 'using namespace std' this is BAD !
668 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
669 * Remove memory leaks on the DicomDir
670 * Remove some useless data in DicomDirObject
671 * Add usefull methods in SQItem, to be complient withe the ElementSet
673 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
674 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
676 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
677 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
678 future, with convertion)
679 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
680 and ImageDataSize values. Remove the method to get the PixelReadConverter
681 from the output of the class
683 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
684 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
686 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
687 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
688 and vtkErrorMacro use.
689 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
691 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
692 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
694 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
695 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
696 The string leaves only in the fonction. So when we make a .c_str(), we
697 get the pointeur on the first element, element that will be destroyed
698 immediately after thee instruction.
699 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
700 file has been opened : the test must be made on the content of the
701 pointer and not directly on the pointer !
704 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
705 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
706 the python part recompiles
708 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
709 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
710 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
711 X session is killed (for my computer... it seems to not be identic on
714 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
715 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
716 avoid problems (otherwise, the difference test between the visible image
717 and the reference is incorrect. If the reference is greater than the
718 screen resolution, it's produce errors).
719 Can be used for only one image. Can be used with a visible flag.
720 * vtk/vtkGdcmReader.cxx : remove commented codes.
721 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
722 under windows at compilation
723 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
725 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
727 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
728 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
729 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
730 tests on the image size X, Y, Z
732 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
733 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
734 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
735 between the class name and the file name
737 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
738 * src/ : fix compilation warnings for the Write method (2 different
739 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
740 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
741 variable... create a static method in gdcm::Document to access to
742 this variable content.
744 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
745 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
746 file, to be accessed by other files (like gdcmFile). Remove commented
747 code. Move the change of the header to the gdcmFile, using the
749 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
750 To be sure of that (and simplify calls), the Write of the header now
751 gets a file name and not a file pointer (std::ifstream).
752 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
753 DocEntryArchive. Remove all open of the written file
755 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
756 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
758 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
759 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
760 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
762 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
763 some corresponding methods. Write correctly the file and check before
765 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
766 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
767 is now on RGB data (as before my last commit
768 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
770 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
771 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
772 Add a print information of the type of the entry
773 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
774 It was in the gdcmFile, and all write have been regrouped
775 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
776 Write correctly all dicom files (in decompressed mode only at this time)
777 * Test/ : test on files are now made using Raw data and not color data if
779 * Example/PrintFile.cxx : add more printings
781 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
782 * Amelioration of code, remove some code copy. For the loading of
783 BinEntry (in gdcmDocument), add the test to verify if the file is already
786 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
787 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
788 remove a DocEntry in the header (push an empty DocEntry)
789 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
790 lines. Bug fix in the initialization of the PixelConvert and the
792 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
793 use in TestCopyDicom (now this test can run under windows... but fails)
794 * Test/TestCopyDicom.cxx : amelioration of the test :
795 - test the pixels written
796 - add test points to quickly find where is the error
797 - can set a file name input and output in arguments
798 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
799 amelioration of the test output
801 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
802 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
803 all replaced DocEntry's
804 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
805 Now, each needed DocEntry to modify is duplicated, modified and inserted
806 to the header using DocEntryArchive. Thus, after save, we can restore the
807 header initial state.
809 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
810 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
812 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
813 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
814 correct to copy it. The DictEntry is specified at the DocEntry creation,
815 then, it musn't change in the time.
816 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
817 header correctly. At this time, the change is only made for the first
818 level of the Document. In the future, it might consider sequences.
819 The change is made by replacing a DocEntry by an other that is created
820 outside the class. The old value is kept. When we restore the header
821 status, the added DocEntry is deleted and replaced by the old value.
822 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
823 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
824 set the write type to explicit VR, implicit VR or ACR. Add methods to set
825 the write mode to native, decompressed or RGB (but not used at this time)
827 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
828 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
829 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
831 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
832 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
833 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
835 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
836 set because already copied when copying the BinEntry's of the header
837 * Test/TestAllReadCompareDicom.cxx : remove warnings
839 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
840 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
841 Two problems appear when doing it :
842 - with the gdcmFile : when the GetImageData method is called, the pixels
843 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
844 data (pixels). And each structure destruct the data when it's
845 destructed. So we have two destructions for the same data. To solve it,
846 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
847 data or not. If it doesn't own data, then they will not destroyed by
849 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
850 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
851 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
852 create a double destruction of the same DocEntry's. So, to solve it,
853 the TagHT is simply cleared and the DicomDir* elements are destroyed.
854 * TODO : add an entry concerning memory leaks in the DicomDir
856 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
857 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
858 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
861 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
862 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
863 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
864 after it have been deleted
866 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * FIX: src/* fix the doxygen warnings.
868 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
869 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
870 was erroneously defined with a size of 15 instead of 16. [many thanks
871 to Jean Michel Rouet for pointing out this bug].
873 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
874 1. Finish merging JMR patch for writting DICOM from scratch
875 2. Fix -hopefully- bug with MONOCHROME and space vs null character
876 3. Use const ref when possible
877 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
878 5. A few more comments
879 6. CreateUniqueUID can now be called without parameter"
881 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
882 * ENH: Slightly bigger patch:
883 1. Getting toward full integration of JMR patch for writting dicom from scratch
884 2. Update Test to test part of this patch: CreateUniqueUID
885 3. File was not close properly in gdcmDict
886 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
887 5. Use of const ref instead of copy (speed issue)
888 6. Remove temporary (duplicate) string in TranslateToKey
889 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
890 8. Do not repeat virtual in subclasses
891 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
893 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
894 * Apply first patch toward better string comparison when dealing with broken
895 DICOM files. Essentially the string could be padded with a space instead
896 of a null character as defined by standard
898 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
899 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
900 because never used... and in the same time, that's remove some memory leaks
902 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
903 * src/gdcmFile.cxx : now delete the PixelConvert instance.
904 * In examples and tests : change the type of image data variables from void*
905 to uint8_t*. Remmove all delete on image data variables
907 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
908 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
909 Verify the file pointer value before open the file, and if it's not null,
910 a verbose message is generated.
911 Close correctly the file when the file isn't considered dicom-like. The
912 correctly close is a call to CloseFile.
913 When closing the file pointer, test if its not null to close the file.
914 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
915 file. For an uncompressed image, the copied data correspond in the least
916 case to the image size (calculated) or the image size specified in the
917 header. A verbose is generated if these two size mismatch
919 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
920 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
921 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
922 break under windows (with msvc6 compilation).
924 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
925 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
926 compiling with MSVC6)
928 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
929 * Bugs fix for the Windows build with VC6
930 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
931 needed (only for projects required VTK). If the VTK is included in all
932 projects, there is conflicts with the jpeg lib of vtk when compiling the
933 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
934 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
935 when compiling the gdcm_wrap.cxx file (created by the compilation of the
937 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
938 (like it's already made for the cout use). Otherwise, conflict with the
941 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
942 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
944 - comments on the DicomDir::Method related usage added.
945 - now that we use the namespace gdcm, a lot of internal classes do
946 NOT need to be wrapped anymore.
947 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
948 DicomDir::Method) new example added.
950 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
951 * Improve string manipulation. I now inforce the notion of 'DicomString'
952 A DicomString can contain as many \0 as they want
953 and it is *always* of even length.
954 We only support odd length for very rare case.
955 And in the near future this should be removed.
957 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
958 * /binary_write/ gdcm source. Now even on big endian we are writting
959 little endian. This should -heopfully- fix some tests
961 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
962 * Now the dictionary is compiled into gdcm lib. This is a default
963 behavior, thus any dic file specified is picked before failback to
964 the one comiled into lib
966 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
967 * Change internals for gdcmDict. Don't use any 'new' any more.
968 This should definitely solve any leak problem, and we should be
969 as fast as before, as long as don't modify too much the dictionary.
971 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
972 * STYLE: ivars should start with a capital letter.
973 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
974 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
976 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
977 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
978 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
979 new 2004 dictionaries added (thanks to JPR).
980 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
981 * CLEANUP_ROUND (15) for gdcmPixelConvert
982 - RLEFrame::NumberFragments is now of type unsigned int
983 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
984 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
987 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
988 * Initial work in gathering all transfer syntax accessors. clearly
989 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
990 ivars, but only one transfersyntax (class) ivar with equivalent method on
993 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
994 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
995 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
996 discussed (plus I didn't like having a 2000 lines patch not commited)
998 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
999 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1000 * CLEANUP_ROUND (14) for gdcmPixelConvert
1001 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1002 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1003 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1004 CloseFile() anymore.
1005 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1006 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1007 into File::Pixel_Data.
1009 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1010 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1011 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1012 * CLEANUP_ROUND (13) for gdcmPixelConvert
1013 Substituted File::ParsePixelData() with PixelConvert::Print() new
1015 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1016 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1017 method to those classes.
1018 - src/gdcmFile.[cxx|h]:
1019 -- Added a ::Print() method.
1020 -- PixelConverter is now a reference instead of a member.
1021 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1022 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1024 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1025 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1026 collaboration diagram and inheritance diagram should be generated with
1028 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1029 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1030 pointlessly wrapped (see
1031 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1032 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1033 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1034 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1035 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1036 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1037 -- File::Initialise: PixelConverter setup moved away to
1038 PixelConverter::GrabInformationsFromHeader()
1039 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1040 interpretation moved away to PixelConverter::BuildRGBImage()
1042 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1043 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1044 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1046 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1047 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1048 displayed on Win32 when a brutal abort() occurs (because of uncatched
1049 exception). See TODO new entry of this commit for more on this.
1050 * TODO added new entry.
1051 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1052 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1053 - HandleColor is no longer called from gdcmFile.cxx
1054 - gdcmPixelConvert.cxx clean up on method arguments and internal
1055 variable names for semantical coherence.
1057 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1058 * Finished lossless transition, not only do we now read all lossless jpeg
1059 images, without the need of the Cornwell lib, but we do read them properly now
1060 * To reduce code (well to avoid code duplication), I defined a common place
1061 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1062 redefine symbols. This is not perfect but this the best solution I found for a
1063 compilation time jpeg option.
1065 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1066 * Update jpeg ijg lib to support lossless jpeg implementation
1067 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1069 * Also added a special copyright for dcmtk since we use their bugfixes.
1072 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1073 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1074 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1075 matters, as stated in warning note at beginning of %include section).
1076 * src/gdcmDicomDir*.[cxx|h]: coding style
1077 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1078 * src/gdcmJpeg8.cxx: doxygen fix.
1079 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1080 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1081 from File:: to PixelConvert::.
1083 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1084 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1085 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1086 - more code moved away from File:: to PixelConvert::
1087 - fat setup of PixelConverter set in place in File::Initialise.
1089 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1090 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1091 namespace at the file system level. So now you should convert your examples
1093 gdcmHeader -> gdcm::Header
1094 It would be nice if people keep in mind to no open the namespace, since it
1095 allows compilation on broken plateform which were defining common symbol in
1096 the standart namespace (like LP, Unknown ...)
1098 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1099 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1100 The JPEG fragments are now parsed at the same stage than the RLE
1101 information. All code related to JPEG is now in gdcmPixelConvert:
1102 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1103 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1104 export a gdcmFile:: method. Those are simply global functions
1105 (for the time being this is better than having them attach to
1106 either gdcmFile:: or gdcmPixelConvert::).
1107 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1108 and stores the result in a gdcmJPEGFragmentsInfo.
1109 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1110 code (among other stuff) moved away from gdcmFile:; to
1113 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1114 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1115 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1116 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1117 clean up of RLE related code.
1118 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1119 - src/gdcmRLE.cxx removed
1120 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1121 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1122 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1123 * CLEANUP_ROUND (9) for gdcmPixelConvert
1124 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1125 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1126 away from gdcmFile:: to gdcmPixelConvert::.
1128 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1129 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1130 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1131 This is because Parse7Fe0 used to parse the pixels to compute the
1132 length. This task was passed over to FindDocEntryLengthOB() a long
1133 time ago, EXCEPT I had forgotten the OW case...
1134 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1135 we just recylce the code for parsing RLE fragments and computing
1137 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1138 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1139 with the retired Parse7Fe0().
1140 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1141 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1143 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1145 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1146 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1147 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1148 * CLEANUP_ROUND (4) for gdcmPixelConvert
1149 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1150 to return an unused length.
1152 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1153 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1154 this should be cleanner from the plane view. The iostream are erally a pain
1155 to use to do simple stuff.
1157 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1158 * Redo the compilation of the ijg jpeg library. Now only one source is
1159 necesseray. No need to rename file by hand what so ever. CMake handle the
1160 copying of the file within different directory, configure header file to
1161 modify some symbol. The only addition made to ijg wasd a mangle table so
1162 that symbol are different whether we are within 8bits or 12bits.
1164 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1165 * Added documentation of vtkgdcmReader on Website:
1166 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1167 with it's binary name).
1168 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1169 the Website to be more complete.
1170 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1171 doxygenated documentation.
1172 - Doc/DoxyVtkGdcmReaderExamples.txt added
1173 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1174 DoxyVtkGdmReaderExamples.html )
1175 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1176 * CLEANUP_ROUND (3) for gdcmPixelConvert
1177 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1179 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1180 * CLEANUP_ROUND (2) for gdcmPixelConvert
1181 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1183 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1184 * CLEANUP_ROUND for gdcmPixelConvert:
1185 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1186 - src/gdcmPixelStuff[h|cxx] removed
1187 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1188 - src/CMakeLists.txt changed accordingly
1189 * GDCMHOME clean up:
1190 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1191 gdcmVersion.py moved to newly created ATTIC related
1192 gdcmPython/SetupOldies/ directory.
1193 * Autotools clean up:
1194 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1195 - autogen.sh configure.in acinclude.m4 python.m4 removed
1197 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1198 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1199 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1200 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1202 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1203 * TODO updated with Mathieu suggestions. I proposed a template for
1204 describing TODO entries and used it for new entries.
1205 * Added Doc/Website/CodingStyle.html, Developpers.html,
1206 DeveloppersPython.html, GdcmDataCvs.html and
1207 DownloadVersion0_1.html, DownloadVersion0_3.html.
1208 * Some Doc/*.txt Doxygen files (which do not really concern the
1209 documentation itself, but the website) moved to html and
1210 placed in directory Doc/Website:
1211 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1212 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1213 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1214 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1215 * CMakeLists.txt changed accordingly.
1216 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1217 DeveloppersPython.html
1218 * INSTALL nows refers to Doc/Website/Installation.html
1220 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1221 * Added Doc/Website directory, that contains a first raw version
1224 2004-09-23 Jean-Pierre Roux
1225 * FIX In order not to be poluted any longer by casting problems,
1226 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1227 we can now delete[] it safely
1228 * VoidArea is now called BinArea (less confusing name),
1229 and all the methods called ...VoidArea... are now ... BinArea...
1230 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1232 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1233 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1234 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1235 up to the destructor of gdcmElementSet to clean up TagHt and it's
1238 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1239 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1240 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1242 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1243 * ENH: added some utility method that builds a flat dictionary
1244 holding all the Dicom entries contained in the recursive structure
1245 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1246 an example of usage.
1247 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1248 BuildFlatHashTable() that build a flat dictionary.
1249 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1250 gdcmDocument is now a friend of gdcmElementSet.
1251 - src/gdcmElementSet.cxx: clean up.
1252 - Example/FlatHashTablePrint.cxx added.
1253 - Example/CmakeLists.txt changed accordingly
1255 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1256 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1257 moved away from gdcmDocEntrySet (since this class is an abstract class
1258 acting like an interface). SQDepthLevel and BaseTagKey are now
1260 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1261 and associated accessors. Doxygenation of the class.
1262 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1264 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1265 Use SQDepthLevel accessor instead. ::Print() adapted.
1266 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1267 - src/gdcmDocument.cxx changed accordingly.
1269 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1270 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1271 - The following is the doxygen comment of the typedef declaration
1272 of gdcmTagKey in src/gdcmCommon.h:
1273 gdcmTagKey is made to old an "universal" (as in URL, Universal
1274 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1275 A dicom tag always has a group and an element, but a set of tags
1276 embeded in various (optionally nested) sequences and sharing
1277 the same group and element all share the same (group, element)
1278 "identifier". Hence the (group, element) cannot be used as an
1279 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1280 In order to construct a proper tag identifier (i.e. a key) we
1281 consider the following definition of a TagKey:
1282 - let Group, Element be the string representation of the
1283 group and element dicom tag members,
1284 - let ItemNumber be the string representation of the integer
1285 index of the considered item number of a sequence,
1286 Let the key of a tag embeded in a sequence, noted SeqTag, be
1288 /ItemNumber#Group|Element
1289 where "/", "#" and "|" are characters acting as separators.
1290 Then the general form of a gdcmTagKey is given by:
1291 Group|Element<SeqTag>
1292 where <SeqTag> means NO or many instances of SeqTag.
1293 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1296 but the gdcmTagKey of a tag "embeded" is the first item of
1297 a sequence, itself nested in the third item of a sequence is the
1299 0004|1220/2#0008|0082/0#0008|0090
1300 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1301 order to hold the new sequence compatible key. Previously, the
1302 GetKey() method would look in the underlying gdcmDictEntry.
1303 - src/gdcmDocEntry.cxx:
1304 -- constructor now copies the underlying DictEntry key, in the local
1306 -- ::Print: displays the member Key, instead of the (group, element).
1307 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1308 - src/gdcmDocEntrySet.h:xi
1309 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1310 -- now has a new BaseTagKey member.
1312 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1313 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1315 This poses the problem with the semantics of the following lines
1316 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1317 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1318 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1319 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1320 to the long FIXME note for what the problem is. Nevertheless in
1321 order to get things working the dicom dictionary was altered !
1322 Please fix things urgently...
1323 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1324 information), see above note on moving the member VoidArea. Nevertheless
1325 the following entries previously correctly set as US are now inproperly
1327 0028 1201 OW IMG Red Palette Color Lookup Table Data
1328 0028 1202 OW IMG Green Palette Color Lookup Table Data
1329 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1330 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1331 of gdcmDocEntry moved to gdcmSeqEntry.
1332 * src/gdcmSeqEntry.cxx: STYLE.
1334 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1335 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1337 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1338 * gdcmPython/testSuite.py: all the test suite in python is now moved
1339 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1340 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1341 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1343 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1344 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1345 to avoid inclusion recursion until STL is reached.
1346 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1347 mecanism. errno.h is not included in gdcm anymore.
1348 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1349 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1351 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1352 gdcmData/TestAllEntryVerifyReference.txt
1353 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1354 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1355 exception_on_error parameter.
1356 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1357 - vtk/vtkGdcmReader.cxx changed accordingly,
1358 - Example/*.cxx and Test/*.cxx changed accordingly.
1360 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1361 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1362 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1363 enable_sequences removed from gdcmHeader constructor and dependencies.
1364 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1365 * gdcmPython/demo/PrintHeader.py: dummy fix.
1366 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1367 skip_shadow removed from gdcmHeader constructor and dependencies.
1368 * Example/*.cxx and Test/*.cxx changed accordingly.
1370 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1371 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1372 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1374 2004-07-21 Jean-Pierre Roux
1375 * FIX Now, Parsing and Printing a DICOMDIR do work!
1376 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1378 2004-07-20 Jean-Pierre Roux
1379 * FIX Some brain damaged headers have Zero-Lenght fields
1380 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1382 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1383 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1384 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1385 variable (instance of gdcmDebug) by a definition macro, and the instance
1386 is now in static in the gdcmDebug class
1387 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1388 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1390 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1391 * WARNING: ctest now depends more tightly on gdcmData. You should
1392 check out gdcmData properly for things to run smoothly...
1393 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1394 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1395 we need the pixels not be loaded in order to use the ValEntry
1396 that displays position and size).
1397 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1398 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1399 be deprecated. If you have any doubts about the advantages of a
1400 modern scripting language (read Python) versus grass root C++ (i.e.
1401 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1402 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1403 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1404 Anyhow, consider documenting the gdcmData images in
1405 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1407 * Test/CMakeLists.txt:
1408 - now uses TestAllEntryVerify.cxx
1409 - specific comments on oldACR00001.ima (now renamed in gdcmData
1410 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1411 gdcmData/TestAllEntryVerifyReference.txt
1414 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1415 * src/*.[h|cxx] : typedef clean up
1416 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1417 - TagKey renamed to gdcmTagKey (for external usage)
1418 - VRKey renamed to gdcmVRKey (for external usage)
1419 - removal of typedef duplication.
1420 - Removed all unecessary inline keyword from class inline definitions.
1421 - Some method|function(void) declarations replaced with method|function().
1422 * src/jpeg/libijg12/jdhuff12.c:
1423 - printf polluting ctest removed.
1424 - TAB removal for comminting
1426 - TestAllReadCompareDicom.cxx: added a test that compares all the
1427 images in gdcmDataImages.h with corresponding images in
1428 gdcmData/BaselineDicom/. When baseline images are not present
1429 this test creates them.
1430 Note: we need to validate each reference image, but before that
1431 I'd like to rename them with a more explicit name...
1432 - CMakeLists.txt: changed accordingly.
1433 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1434 including each header needed).
1436 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1437 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1438 test suite to the Example directory. Are concerned:
1443 - TestWriteSimple.cxx
1444 * Test/CMakeLists.txt: added some comments on reasons for black listing
1445 image gdcmData/oldACR00001.ima
1447 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1448 * Test/CmakeList.txt: removed the following from black list (to be coherent
1449 with removal from gdcmData):
1450 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1451 - gdcm-MR-PHILIPS-16.dcm
1453 Added the following because after last cvs update, they cause
1454 ctest -R TestReadWriteReadCompare
1456 - gdcm-MR-SIEMENS-16-1.acr
1458 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1459 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1460 new comments in this file) we temporarily (sigh) move to a weaker
1462 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1463 we don't need to black list the following images anymore:
1464 - 8BitsUncompressedColor.dcm
1466 - US-PAL-8-10x-echo.dcm
1467 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1468 fixes and the beautified code ;-)
1469 This fixes the bug introduced in version 1.42 (when beautifying)
1470 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1471 Note: ctest was blind to this bug (this means we need to still
1472 improve the test suite). The bug could be detected by using
1473 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1475 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1476 and by displaying the (garbage) produced file temp.XDCM...
1478 2004-06-29 Jean-Pierre Roux
1479 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1480 - replace by uggly but working old code :-(
1481 A lot of things should be OK again.
1482 It's really urgent to have a test suite that *tests*,
1483 to prevent Frog's beautifying sessions to break all the stuff
1484 (twice, withing a fortnigh ...)
1486 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1487 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1488 redundancy) to added Test/TestReadWriteReadCompare.cxx
1489 * Test/CmakeList.txt: because the compare test of
1490 Test/TestReadWriteReadCompare.cxx fails, the following images are
1491 black listed: - 8BitsUncompressedColor.dcm
1493 - US-PAL-8-10x-echo.dcm
1494 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1495 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1496 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1497 and ad-hoc kludge. This kludge is now removed, and on encountering
1498 such an image (OB field brain damaged) we set errno. Then in
1499 ::FindDocLength() we "fix" the length as being ALL what remains
1500 in the file (until EOF). We then proceed, hoping for the best...
1501 This fixes a SegFault in ShowDicom when trying to write such an
1503 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1504 (because TestWriteRead breaks on it, after a non conformal commit?).
1505 ctest now runs properly, except for MakeDicomDir (which was always
1506 broken) and the Python related stuff (still not fixed).
1508 2004-06-24 Jean-Pierre Roux
1509 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1510 FIX : Test/TestReadWrite now iterates on all the file names
1511 (instead of infinite loop)
1512 ENH : Test/TestWriteRead now iterates on all the file names
1514 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1515 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1517 2004-06-24 Jean-Pierre Roux
1518 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1519 when SamplesPerPixel =3
1520 - now Write is no longer confused by
1521 'BitsAllocated = 12" and 'BitsStored=12"
1522 - "UN" value representation Elements are now written correctly
1523 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1524 ENH : - now gdcmHeader has its own Write methods
1525 (in order to split the job that has not to be done
1528 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1529 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1530 loop on the same image until memory went out.
1531 Note: this means we still have gobs of memory loss in PrintDocument
1532 * src/gdcmDocument.cxx: fixes problem on parsing on file
1533 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1535 2004-06-24 Jean-Pierre Roux
1536 FIX : Write - All the Sequences and Sequence Item are now written
1537 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1538 is added a the end, when necessary.
1539 - A lot of brain-damaged images, that were read correctly are
1540 now written correctly
1541 - length compatible BinEntry are now loaded correctly
1542 (even for odd groups)
1543 Note : only Explicit Value Representation was checked.
1544 (question : is implicit VR really necessary for gdcm ?)
1546 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1547 * DEVELOPPER: added a proposition of coding style.
1548 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1551 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1552 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1553 Use the gdcmDocEntry::Print() and Write() instead.
1554 * src/gdcmDocument.cxx: bug fix.
1556 2004-06-22 Jean-Pierre Roux
1557 FIX : gdcmDocument.cxx
1558 - Now we do recognize the JpegLossLess format (there was a misstyping in
1559 code 'beautyfication' :-(
1560 - Now we automaticaticaly load the Luts, if any
1562 2004-06-22 Jean-Pierre Roux
1563 In order : to write Sequences, whatever their imbrication level,
1564 : to allow user to create his own Sequences
1565 a lot of modif where necessary (adding, moving, or virtualising methods)
1567 WARNING : save your own sources *before* cvs up !
1570 ADD virtual void Write(FILE *fp, FileType filetype);
1573 ADD virtual void Write(FILE *fp, FileType filetype);
1574 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1577 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1578 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1579 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1580 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1581 ADD std::string GetEntryByName(TagName name);
1582 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1584 std::string vr = "unkn",
1585 std::string fourth = "unkn",
1586 std::string name = "unkn");
1587 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1588 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1589 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1590 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1591 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1592 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1593 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1594 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1597 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1598 ADD virtual std::string GetEntryByName (TagName tagName);
1599 ADD virtual std::string GetEntryVRByName (TagName tagName);
1600 REM virtual bool Write(FILE *, FileType);
1601 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1602 FILE *_fp, FileType type);
1603 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1604 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1605 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1606 REM virtual std::string GetEntryByName (std::string tagName);
1607 REM virtual std::string GetEntryVRByName (std::string tagName);
1608 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1609 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1610 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1612 std::string vr = "unkn",
1613 std::string fourth = "unkn",
1614 std::string name = "unkn");
1615 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1616 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1617 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1618 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1621 ADD virtual void Write(FILE *fp, FileType filetype);
1624 ADD virtual void Write(FILE *fp,FileType filetype);
1627 ADD virtual void Write(FILE *fp, FileType filetype);
1628 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1629 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1630 REM std::string GetEntryByName(TagName name);
1633 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1635 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1636 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1637 The default constructor invoked by the line
1638 gdcmHeader *f1 = new gdcmHeader( header );
1639 was gdcmHeader::gdcmHeader(bool) instead of the expected
1640 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1641 Hence the parsing wasn't executed... See also below.
1642 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1643 as explicit constructor didn't do the trick to fix the above problem.
1644 Could anyone explain why ?
1645 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1646 properly calls gdcmValEntry::Print() (that was weed out from
1647 code related to gdcmBinEntry).
1649 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1650 * In order to fix memory leaks:
1651 - Test/TestWriteSimple.cxx: added cleaning of free store through
1653 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1654 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1655 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1656 (through the call to ::AddDicomDirMeta()) or the destructor
1657 would crash when deleting uninitialized ::metaElems].
1658 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1659 - src/gdcmDocument.cxx:
1660 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1661 from dynamic stores.
1662 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1663 was causing memory leaks.
1664 - src/gdcmSQItem.cxx:
1665 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1666 cleanly handled with polymophism: sorry but my milage is low).
1667 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1668 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1669 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1670 This avoids SegFaulting.
1671 - src/gdcmSQItem.h: coding style.
1673 - Test/TestWriteSimple still severely sucks. The output image content
1674 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1675 damaged when displayed with vtkgdcmViewer.
1676 - on memory leaks: TestWriteSimple leaks really less (see entry
1677 of 2004-06-18 in Changelog file for the call to valgrind).
1678 - on segfaults: ctest now passes all the tests but one (no more
1680 * Erroneous leading white fix:
1681 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1682 white[s] (as opposed to from >> xxx, that removes it [them].
1683 - src/gdcmTS.cxx: ditto.
1684 - gdcmPython/testSuite.py: dirty related kludge removed.
1685 * src/*: remaining references to gdcmParser removed.
1686 * src/*[cxx|h]: added copy[way]left header.
1689 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1690 * In order to fix writing of dicom files:
1691 - Test/TestWriteSimple.cxx: a simpler example of writing.
1692 - Test/CMakeLists.txt changed accordingly.
1693 - src/gdcmDocument.cxx:
1694 -- The destructor now recursilvely removes potential sequences.
1695 -- Bug fix in ::IsJPEG2000()
1696 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1697 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1699 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1700 to only declared) and build on top of
1701 ::GetDocEntryByNumber(guint16, guint16).
1702 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1703 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1704 for usage in destructor and treatement of promotion in
1705 ::ReplaceOrCreateByNumber().
1706 - src/gdcmSQItem.cxx: destructor should better handle his job.
1707 Test/TestWriteSimple now runs (or at least it DOES something).
1708 * We can now start hutting memory links. A good starting point is:
1709 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1710 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1711 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1713 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1714 * Valgrind note: after Mathieu Malaterre teached me how to read
1715 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1717 Using gcc, you can force the STL to use malloc and to free memory as
1718 soon as possible by globally disabling memory caching.
1719 With 3.2.2 and later, you should export the environment variable
1720 GLIBCPP_FORCE_NEW before running your program.
1721 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1722 simply vanish (it is still not clear to me, whether this means that
1723 STL std::string leaks or if valgrind believes it leaks...).
1724 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1725 running bin/gdcmTests makeDicomDir):
1726 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1727 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1729 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1730 SegFaulting (I drowned in DicomDir related code when trying to
1731 understand why the list is empty...).
1732 * src/gdcmDocument.h: first BSD license header try.
1733 * Doc/License.txt added.
1735 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1736 * src/gdcmDocument.[h|cxx]:
1737 - Clean up of the Transfer related predicates. They are now all based
1738 on new method isGivenTransferSyntax, that (should) handle properly
1739 the padding problem.
1740 - general clean up, simplification, and coding style.
1741 - Specific clean up of Parse7FE0() (umproperly named actually).
1742 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1744 2004-06-14 Jean-Pierre Roux
1746 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1747 - fix the display of SQItem ordinal number
1748 - add the GetSQItemByOrdinalNumber method
1749 - remove some useless never written private methods
1751 2004-06-14 Jean-Pierre Roux
1753 - adding a constructor taking a gdcmDocEntry as an input param
1754 - ReplaceOrCreateByNumber now returns :
1755 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1756 a gdcmValEntry * if a string value is passed as a param
1758 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1759 according to the param type (no longer sets a gdcmDocEntry)
1760 - GetValEntryByNumber, GetBinEntryByNumber added
1761 - NewValEntryByNumber and NewBinEntryByNumber added
1763 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1765 - GetSQItemNumber and SetSQItemNumber added, to provide
1766 a (relative) Item identier inside a given Sequence
1767 \warning : some pb remaining around this number
1769 - AddEntry now takes the Item Number as a param
1771 - adding a constructor taking a gdcmDocEntry as an input param
1773 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1774 * Memory leak hunt with the following command:
1775 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1776 --show-reachable=yes gdcmTests PrintDocument
1777 It looks like many (all?) leaks are due to the STL (or a bad usage
1778 of the STL. The lines producing the leaks now have a comment with
1779 a "MEMORY LEAK" tag: you can retrieve them with
1780 grep "MEMORY LEAK" src/*
1781 Here are two typical examples which I can't help fixing:
1786 char * test = "babo";
1787 name = test; //// <--- valgrind detects 960 bytes lost in
1788 //// call to std::string::operator=(char const*)
1789 name.clear(); //// Doesn't help !
1797 std::cout << "Type a bunch of characters followed by RETURN: ";
1798 getline(std::cin, line); //// <--- valgrind dectects a loss
1799 //// of 1320 bytes in call to
1800 /// std::basic_istream<>& std::getline<>
1806 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1807 * src/gdcmHeader.[cxx|h]:
1808 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1809 and related, moved away to gdcmDocument.
1810 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1811 the corresponding protected accessors of inherited class
1812 gdcmDocument, removed ! As a consequence gdcmFile had to be
1813 declared friend of class gdcmDocument (see below).
1814 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1815 - Clean up of undefined or unused methods.
1816 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1817 account the changes to gdcmHeader.h).
1818 * src/gdcmDocument.h:
1819 - gdcmFile is now a friend class (in order to take into account the
1820 changes to gdcmHeader.h).
1821 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1822 (see changes to gdcmHeader.h).
1823 - Accessors (reading on the form GetEntry*) are now public.
1824 - Clean up of undefined or unused methods.
1825 * src/gdcmDocument.cxx:
1826 - adaptation to changes to gdcmDocument.h
1827 - ::OpenFile now writes a verbose message when file cannot be opened.
1828 - some std::string properly set to VRKey
1829 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1830 references to gdcmDocument.
1831 * Test/TestFindTags.cxx: changed accordingly to above changes.
1832 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1833 cvs repository gdcmData.
1835 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1836 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1837 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1838 conflicts with gdcmValEntry::voidArea.
1839 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1840 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1841 Value representation between StringRepresentable and BinaryRepresentable.
1842 * src/gdcmDocument.cxx:
1843 - method ParseDES: proper indentation restored and usage of
1844 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1845 - method LoadDocEntry: the fingerprint left in the SetValue() of
1846 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1847 removed. Reverting to previous code segment with the proper
1848 dynamic_cast< gdcmValEntry* >.
1849 Note: this was (partially) breaking the python test suite
1850 (gdcmPython/testSuite.py) that made usage of the above
1851 fingerprint to check presence of "Pixel Data".
1852 * src/gdcmDocEntry.h: coding style.
1853 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1854 now taken into account.
1855 * gdcmPython/gdcm.i: adaptation to the new internal representation
1856 of gdcm (exit gdcmParser, hello gdcmDocument).
1857 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1859 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1860 anymore, but instead prints the loaded Python dictionary.
1861 * .... alas, the python testSuite is still broken.
1863 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1864 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1866 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1867 * src/gdcmUtil.h : export methods
1869 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1870 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1872 * Initial addition of automatic python testing
1873 * Initial addition of automatic image comparison
1875 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1876 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1877 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1879 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1880 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1881 * Test/ShowDicom.cxx : bug fix for msvc compilation
1882 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1884 2004-05-04 Jean-Pierre Roux
1885 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1886 new concepts (and new classes) :
1887 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1888 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1889 - Sequence Doc Entries (gdcmSeqEntries)
1890 a Sequence is composed of Items.
1891 Each item is a set of Doc Entries (this is recursive)
1892 The non uniqueness of the 'Dicom tag' is due to this recursivity
1893 (never taken into account)
1894 Our unability to add a new 'entry' in the header
1895 at the proper location (neither in the H-Table (map or multimap),
1896 nor in the Chained List is also due to this recursivity.
1897 Don't try, right now, to use/modify/compile these new sources :
1898 nothing is finished.
1899 We just commit all the stuff, 'as is', in order not to loose it.
1901 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1902 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1904 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1905 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1906 file prefix (SetFilePrefix)
1908 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1909 * Add a new test: ShowDicom, for now this is just the c++ version of
1910 checkRead.sh, later it will be able to compare the image read against a
1912 * Replace the DEBUG on the stack with a global entry in cmake interface:
1913 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1915 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1916 * Add an example subdir, with a real example on how to read + write a
1919 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1920 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1921 * Doc/CMakeLists.txt: the main page is now properly differentiated
1922 between the developper and user version.
1923 * Doc/doxygen.config.in: dropped search related obsolete flags
1924 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1926 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1927 * DEVELOPPER: added some helpfull comments for compile/test/install
1930 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1931 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1932 src directory, now generated in the build dir.
1933 2. Tests as mentionned smarter
1935 4. Add a new method in gdcmDict that return the PubDict by name
1936 this is interesting for 3rd party lib like ITK,
1937 where we could set the institution name / patient name...
1939 * ENH: 1. Now the test suite is working for real
1940 2. All binaries are now output in the gdcm-bin directory
1941 (this was not true before)
1943 2004-04-28 Jean-Pierre Roux
1944 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1945 SeQuence indented printing of Dicom Header.
1946 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1947 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1948 Computation of SQDepthLevel is now part of gdcmHeader constructor
1949 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1950 tree-like structure of a Dicom Header.
1951 * FIX Test code cleaning
1953 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1954 * ENH: Adding automatic testing
1955 1. Need a DartConfig.cmake to submit to public
1956 2. Add a test driver gdcmTest.cxx
1957 3. gdcmTestMain, an helper for the main test driver gdcmTest
1958 4. Files in Test don't have a main anymore, this becomes interesting
1959 when we add more and more tests, thus dsw don't have to load
1961 * ENH: Adding a GDCM_DATA_ROOT for testing
1962 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1963 one file instead of seven + some small cleanup
1965 2004-04-22 Jean-Pierre Roux
1966 * ENH Minor changes to the Print() methods.
1967 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1968 Header printing. Example given with :
1969 > PrintHeader fileName 2 new
1970 (SQ based tree-like structure still to be done for the Header ...)
1972 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1973 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1974 1. I have added some unsigned where needed
1975 2. Some function parameter not used -> (void)
1976 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1977 4. g++ don't like character '\' in comment
1978 5. #define jpeg_create_decompress jCreaDecompress
1979 this really need to be fixed
1980 6. virtualize destructor of gdcmObject ... leakage
1981 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1982 this also really need to be fixed
1983 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1984 remove compression file
1985 (as we only do decompression, right ?)
1986 * ENH: Change malloc/calloc/free with c++ equivalent
1988 2004-04-21 Jean-Pierre Roux
1989 * FIX gdcmHeaderHelper::GetXSpacing
1990 when a single value is found (bug ?), xpacing is now
1991 defaulted to yspacing
1993 2004-04-19 Jean-Pierre Roux
1994 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1995 * ENH add parameters :
1996 bool exception_on_error = false,
1997 bool enable_sequences = false,
1998 bool ignore_shadow = false
1999 to the gdcmFile constructors to be full gdcmParser compliant
2000 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2001 to allow reading of PAPYRUS 3.0 files
2003 2004-04-06 Jean-Pierre Roux
2004 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2006 2004-04-02 Jean-Pierre Roux
2007 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2008 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2009 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2011 2004-03-30 Jean-Pierre Roux
2012 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2013 for ACR file, written out as DICOM files (hope so...)
2015 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2016 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2017 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2018 moved to base class gdcmParser and only the specialisation is kept
2020 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2021 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2022 already does the job.
2023 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2024 (to be consistent with gdcmParser::WriteEntries).
2026 2004-03-30 Benoit Regrain
2027 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2028 upate of the object's instance. It's passed to 2 in the unfavorable
2029 case : one in the ExecuteInformation, one in the ExecuteData
2031 2004-03-29 Jean-Pierre Roux
2032 * ENH : Check on file type to be written moved
2033 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2034 * FIX : gdcmObject::ResetBoundaries now stops properly
2035 when end-of-list is reached
2036 : gdcmVersion modified (as Benoit Regrain asked)
2038 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2039 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2040 * src/gdcmUtil.cxx: added forgotten iostream include.
2041 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2042 equivalent to ExplicitVR in existing code).
2044 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2045 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2046 now contains all the gdcmGlobal related code.
2047 * minor coding style and doxygenation changes.
2049 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2050 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2051 now contains all the Debug related code.
2052 * minor clean-up of includes in src/*.cxx
2053 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2054 CreateCleanString) removed.
2055 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2056 * Doc/DoxyMainPageUser.txt added.
2057 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2058 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2059 src/gdcmDirList.cxx)
2061 2004-03-24 Jean-Pierre Roux
2062 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2064 2004-03-23 Jean-Pierre Roux
2065 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2066 big endian made volumes
2067 * ENH Now gdcmParser constructor and destructor are protected to forbid
2068 end user to instanciate class gdcmParser
2069 (only gdcmHeader and gdcmDicomDir are meaningfull)
2071 2004-03-22 Benoit Regrain
2072 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2073 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2074 gdcmSerie to gdcmDicomDirSerie
2076 2004-03-19 Jean-Pierre Roux
2077 * ENH Now the tree-like structure describing a DICOMDIR comming from
2078 an already existing DICOMDIR file is consistent with
2079 the home-made tree-like structure build ex-nihilo
2080 or build from the files held (recursively) in a Directory
2081 functions gdcmDicomDir::CheckBoundaries()
2082 gdcmObject::SetBoundaries() added
2084 2004-03-17 Jean-Pierre Roux
2085 * REM (Eric Boix bug) : removal of meaningless
2086 gdcmDicomDirImage::NewImage function.
2087 * FIX now file names and directory name are written properly in the
2089 * FIX now gdcmDicomDir constructor may be call without any trick
2092 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2093 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2094 of gdcmDicomDirImage::NewImage as empty function.
2096 2004-02-28 Jean-Pierre Roux
2097 * ENH add gdcmDicomDir:NewPatient
2098 add gdcmDicomDirPatient:NewStudy
2099 add gdcmDicomDirStudy:NewSerie
2100 add gdcmDicomDirSerie:NewImage
2101 to allow making gdcDicomDir object.
2102 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2103 (as opposite to the gdcmHeader chained list)
2105 2004-02-11 Benoit Regrain
2106 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2107 when using from python
2109 2004-02-10 Benoit Regrain
2110 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2111 * FIX : in gdcmDicomDir when the directory is empty
2112 * ENH : add callback and methods to get the progression of dicomDir
2115 2004-02-06 Jean-Pierre Roux
2116 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2117 - GDCM_META added to gdcmDicomDirType
2118 - class gdcmMeta created
2119 * ENH : - A brief summary is now displayed at the beginning of
2120 'testDicomDir' to help disaster magnitude estimation
2121 * REM : Now useless Test/explDICOMDIR.cxx
2123 2004-02-05 Benoit Regrain
2124 * ENH : add methods in gdcmObject to get the hash table or the list of
2126 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2127 * FIX : wrapping python for TagHeaderEntryHT
2129 2004-02-04 Benoit Regrain
2130 * FIX : even length for some strings when writting the dicom dir
2131 * FIX : sort the images in the dicom dir
2132 * FIX : Bug fix for python use of dicom dir
2133 * ADD : a python demo
2135 2004-02-04 Jean-Pierre Roux
2136 * FIX : Final solution (?) for icone embedded images
2137 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2138 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2139 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2140 gdcmData/gdcm-MR-SIEMENS-16.acr1
2141 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2142 to make full checking easier
2144 2004-02-04 Benoit Regrain
2145 * FIX : WriteEntries : coding style & logic in parameters
2146 * FIX : Set the elements to create the DicomDir in a dictionary file
2148 2004-02-03 Benoit Regrain
2149 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2150 * gdcmDicomDir : add the load of directory
2151 * Bug fix and print add-on
2153 2004-02-03 Jean-Pierre Roux
2154 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2155 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2156 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2157 * FIX gdcmParser.cxx : 'group length' elements are now considered
2158 as integers, even for shadow groups, when file is Implicit VR
2160 2004-02-02 Jean-Pierre Roux
2161 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2163 of the last synonym :-(
2164 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2166 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2167 * FIX taking into account the possible 7fe0,0010 multiplicity
2168 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2169 to allow removal of references to 7fe0,0010, to deal with
2170 ACR-NEMA images, when 0028,0200 is meaningfull
2172 2004-01-31 Jean-Pierre Roux
2173 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2174 no longer writes 'Un' on disk
2175 * FIX SQ elements with actual length are now dealt with corectly
2176 * FIX gdcmFile::WriteBase make the difference, for color images, between
2177 the length (for Palette expanded images)
2178 and Raw Length (non expanded image + Palette)
2179 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2180 (that broke Write). Replaced by UL.
2181 Aware user will reload the field if he
2182 thinks it's necesssary
2184 2004-01-30 Jean-Pierre Roux
2185 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2186 when 'dirty Acr' is found, to be compliant with the new
2187 IsReadable() methods.
2189 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2190 (no DOUBLE images in kosher DICOM,
2191 but so usefull for people that miss them ;-)
2193 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2194 DICOMDIR related utilities (not checked as Windoze compliant)
2196 2004-01-28 Jean-Pierre Roux
2197 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2199 2004-01-27 Jean-Pierre Roux
2200 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2201 to allow skipping the shadow elements, to save memory space.
2202 The TRUE value for this param has to be used
2203 with a FALSE value for the 'enable_sequence' param.
2204 ('public elements' may be embedded in 'shadow Sequences')
2205 * gdcmHeader methods now deal with 'embedded icones images' in the header
2206 (even when an 'icone image sequence' is announced by the
2207 element (0x0088,0x0200), but there is NO icone at all ...
2209 * gdcmHeader sometimes Image Location value doesn't follow
2210 the supposed processor endianity (see gdcmData/cr172241.dcm).
2213 * gdcmHeader add the method
2214 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2215 to get *all* the Header Entries with the same tag.
2216 GetHeaderEntrySameName is probabely *useless*
2217 (no meaning : Name is *not* an identifier within the Dictionary)
2219 2004-01-26 Benoit Regrain
2220 * Bug fix in the print of hexadecimal representations. Remove long fields
2221 in the print and add a third level of print to print them
2223 2004-01-23 Benoit Regrain
2224 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2225 * Bug fix on test suite after remove the strip made on not string fields
2226 * Split the IsReadable method between gdcmParser which test that the file
2227 is dicom and gdcmHeader which test that it's an image file
2229 2004-01-22 Benoit Regrain
2230 * DicomDir : clean code, add methods, set variables in protected or private
2231 * gdcmUtil : bug fix for the clean string method
2233 2004-01-19 Benoit Regrain
2234 * Add the use of shadow dictionaries
2235 * bug fix and coding style
2237 2004-01-19 Benoit Regrain
2238 * src/gdcmFile.cxx : bug fix concerning the close of file
2239 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2240 * Add the update of header entries using the shadow library
2242 2004-01-19 Benoit Regrain
2243 * removal of file gdcmHeader2.cxx
2244 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2245 inheriting from gdcmParser. This split is to prepare the integration
2246 of dicom dir parsing
2247 * bug fix under python
2249 2004-01-16 Jean-Pierre Roux
2250 * REM removal of class gdcmHeaderEntrySet
2251 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2252 * ADD add file gdcmHeader2.cxx
2253 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2255 2004-01-15 Benoit Regrain
2256 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2257 entries created while parsing the header. Thus, they will be destroyed
2258 when the gdcmDictSet will be destroyed
2259 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2262 2004-01-15 Benoit Regrain
2263 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2264 made a fatal error because of the memory release at the end of program.
2265 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2266 some memory and vtk seems to have some problems with that.
2267 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2269 2004-01-14 Benoit Regrain
2270 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2271 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2272 * src/*.[h|cxx] : make changes due to class name changes
2273 * gdcmPython/demo/*.py : bug fix due to method names
2275 2004-01-13 Benoit Regrain
2276 * src/*.[h|cxx] : coding style
2277 * vtk/*.[h|cxx] : coding style
2279 2004-01-13 Benoit Regrain
2280 * gdcmPython/testSuite.py : test the readable flag of file for tests
2281 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2282 It's lied to the stl compilation by MSVC (windows, always windows...)
2283 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2285 2004-01-12 Benoit Regrain
2286 * src/*.h : add comments
2287 * src/gdcmDictSet.h : set the method BuildDictPath in public
2288 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2289 directly setted in the source code
2290 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2293 2004-01-09 Benoit Regrain
2294 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2295 * setup.py : use a reference to gdcmVERSION
2297 2004-01-07 Benoit Regrain
2298 * Modification to compile with the distutils.
2301 2003-12-10 Benoit Regrain
2302 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2303 can use a gdcmHeaderHelper to load data
2304 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2305 made in the source code
2307 2003-12-10 Benoit Regrain
2308 * Update Windows projects and .cvsignore files
2310 2003-11-12 Jean-Pierre Roux
2311 * ENH gdcmHeader constructor has one more parameter (default value : false)
2312 that allows the user to 'go inside' the SeQuences only
2314 gdcmElValSet:Print takes it into account
2316 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2317 * ENH: Update gdcmPython/CMakeLists
2318 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2319 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2321 2003-11-10 Jean-Pierre Roux
2322 * FIX : gdcmHeader::LoadElements is now based
2323 on the ListTag listElem member,
2324 not longer on the TagElValueHT tagHt member
2325 * ENH : PrintPubElVal shows (temporarily) both results,
2326 with the tagHt member and the listElem member.
2327 (it's easier to 'see' the problems when using Printheader)
2329 * FIX : old private member LgrElem is now splitted into
2330 ReadLength : Length actually found on disk (updated only
2331 if bug fixing is necessary), for internal
2333 UsableLength : Updated by FixFoundLength, to fix a bug
2334 or to allow Parser going on.
2335 Will allow to re-write a kosher header when a SeQuence
2336 with a length (not 0000) is found
2337 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2338 because gdcmElValSet::Add does not update ListElem
2341 2003-11-07 Jean-Pierre Roux
2342 * FIX misstyping in Transfert Syntax name table
2343 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2344 when they have an actual length (not 0000 nor FFFFF)
2345 (Nobody should care of it, but DICOMDIR explorers)
2347 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2348 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2350 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2351 * ENH: vtkGdcmReader now supports LUT !
2352 (vtkgdcmViewer for now is not able to use them though)
2354 2003-11-05 Jean-Pierre Roux
2355 * in testSuite.py : new files names for checking the package
2356 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2357 that returns the pixel area size to the *aware* (vtk) user
2358 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2360 2003-11-05 Benoit Regrain
2361 * in testSuite.py : Modify the rules for checking the paths
2362 : Explicit error messages
2363 * in __init__.py : Related modif
2365 2003-11-03 Jean-Pierre Roux
2366 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2367 to be used by aware (vtk) users that want to manage
2368 LUT (and no to turn the PALETTE image into an RGB pixels one)
2369 * GetPixelType now returns 8U for 24 Bits images
2370 (vtkGdcmReader compliant)
2372 2003-10-31 Jean-Pierre Roux
2373 * Removal of *all* gdcmData images and add them again
2374 in order to loose the 'history' of un-anonymised images
2376 2003-10-31 Jean-Pierre Roux
2377 * RMV : removal of useless jBitsInJsample.h
2378 for both 8 and 12 Bits JPEG Lossy Libraries
2380 2003-10-31 Jean-Pierre Roux
2381 * ENH : Add the functions gdcmFile::GetImageDataRaw
2382 gdcmFile::GetImageDataIntoVectorRaw
2383 that act as GetImageData and GetImageDataIntoVector
2384 except the making of an RGB Plane from Gray Plane + LUT
2385 Intended to aware (vtk) users who know how to manage
2388 GetLUTRGBA return a R,G,B,A LUT if any
2389 lgrTotaleRaw gives the 'Raw' length
2390 GetImageDataRaw returns the gray Plane
2391 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2392 (They stay Grey, just like with other Dicom viewers :-(
2394 2003-10-30 Jean-Pierre Roux
2395 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2397 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2398 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2399 being coherents dicom files.
2401 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2402 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2404 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2405 * ENH: Two steps is necessary to please VC++ compiler...
2406 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2407 * ENH: Add include dir to medcon lib
2408 * FIX: only one function is being exported for now !
2409 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2411 2003-10-29 Jean-Pierre Roux
2412 * adding gdcmHeader::GetLUTRGBA
2413 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2414 --> Mathieu, the modif u're waiting for is not yet committed
2415 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2417 2003-10-27 Jean-Pierre Roux
2418 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2419 00191113.dcm DermaColorLossLess.dcm
2420 MxTwinLossLess.dcm RadBWLossLess.dcm
2421 * ENH: For version prior to vtkImageViewer2 -r 1.19
2422 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2424 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2425 * Removal of ido stuff in CMakeLists.txt
2427 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2428 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2429 * FIX: remove a call to ->Modified ... see comments
2430 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2432 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2433 * FIX: Problem with path for libvtkgdcmPython
2434 * ENH: Try adding a search script for python site-package
2435 * RMV: Remove some file from medcon lib that are not necessary
2436 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2437 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2438 * FIX: More pragma disable fro VC++,
2439 I don't think I break something as it is also disable in VTK/ITK.
2440 But it fasten debug compilation time.
2442 2003-10-23 Jean-Pierre Roux
2443 * gdcm now deals with 16 Bits Run Length Encoded images
2444 (they are compressed as 2 planes images,
2445 one for the high Bytes, the other for low Bytes)
2447 2003-10-22 Jean-Pierre Roux
2448 * Now CheckRead takes into account :
2449 - the bugged 'Leonardo' Siemens images
2450 - the XA images, sent thru the burning VPRO station
2451 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2454 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2455 * FIX: When copying a Makefile.am to CMakeLists.txt
2456 one should remove the '\'
2458 2003-10-22 Jean-Pierre Roux
2459 * in gdcmData adding a bugged 'Leonardo' Siemens image
2460 (wrong lengths in header)
2461 OK with gdcm, KO with the other viewers :-)
2462 * add a GE dlx XA image, thru the VEPRO burning station
2465 2003-10-21 Jean-Pierre Roux
2466 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2467 for a brutal checking of vtkgdcmViewer compliance
2469 2003-10-21 Jean-Pierre Roux
2470 * add the files for 'xmedcon' Jpeg Lossless library
2471 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2473 2003-10-21 Jean-Pierre Roux
2474 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2476 2003-10-21 Jean-Pierre Roux
2477 * garbage Siemens 'Leonardo' images dealt with
2478 (the patch is easy to remove)
2479 * cosmetic changes to avoid warnings
2481 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2482 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2483 no need to press 'r' now.
2485 2003-10-20 Jean-Pierre Roux
2486 * upgrade of checkRead.sh checkWrite.sh according
2487 to new Jpeg Lossless decompressor
2488 * add US.3405.1.dcm, a genuine RGB medical file ...
2489 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2490 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2492 2003-10-15 Jean-Pierre Roux
2493 * general anonymisation in gdcmData
2494 * adding the 'color files' from
2495 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2496 * adding some well knowed bugged-header images
2497 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2498 waiting for their inclusion in Python testsuite
2500 2003-10-15 Jean-Pierre Roux
2501 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2502 no longer seg faults when file is not found
2504 2003-10-14 Jean-Pierre Roux
2505 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2508 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2509 * TODO: *.in file to genereate a UseGDCM later
2511 2003-10-14 Jean-Pierre Roux
2512 * Some supposed-to-be Dicom Images have no preamble.
2513 OpenFile takes it into account
2514 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2515 * Missing elements added in dicomV3.dic
2516 (just to be affraid : have a look at
2517 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2518 and do it again next year ;->
2520 2003-10-13 Jean-Pierre Roux
2521 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2522 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2523 But there are NOT. It's fixed !
2525 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2526 * FIX: "jpeglib.h" was not found on VC++
2527 * FIX: vtkgdcm was not being installed
2529 2003-10-10 Jean-Pierre Roux
2530 * ENH : OpenFile closes the file if it *really* doesn't look like
2531 an ACR-NEMA / DICOM one.
2532 * FIX : testWrite no longer writes an empty file if the source file
2533 is not gdcm Readable
2534 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2537 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2538 * FIX: CMake generate now documentation
2539 * ENH: out of source doc build !
2540 * ENH: Generate both user and dev documentation
2541 * ENH: Should work on windows too
2542 * ENH: Only one doxygen config.in file is needed
2543 * FIX: make install should be ok now on ùnix plateform
2544 * FIX: PATH to dictionary was wrong (missing /)
2545 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2547 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2548 * vtkGdcmReader is now able to read rgb dicom file.
2549 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2550 * added a gdcmViewer to vtk test, use mouse to control
2551 window level & window width
2553 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2554 * CMake-ification of gdcm, we have now two build system
2555 * FIX: on cygwin Wsock32 doesn't exist
2556 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2558 2003-10-06 Emanuel Ollart
2559 * FIX : compilation process wad broken.
2560 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2562 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2563 * change gdcmViewer -> vtkgdcmViewer
2564 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2566 2003-10-06 Jean-Pierre Roux
2567 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2568 ( e.g : well known GE images with a wrong elem length,
2569 : Philips MRI Images with a wrong Huffman table)
2570 * still to be done : allow the reading of bugged LEONARDO Siemens images
2572 2003-10-03 Jean-Pierre Roux
2573 * Odd length strings are padded with '\0' (not with spaces,
2574 to remain compliant with already defined strings,
2575 like Transfert Syntax UID and others)
2577 2003-10-03 Jean-Pierre Roux
2578 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2579 to allow displaying RGB images (not only by affim ;-)
2581 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2582 * vtkGdcmReader is now able to read rgb dicom file.
2583 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2585 2003-10-03 Jean-Pierre Roux
2586 * A few nasty patches to allow the reading of a lot of nasty images
2587 ( e.g : well known GE images with a wrong elem length,
2588 : Philips MRI Images with a wrong Huffman table)
2589 * still to be done : allow the reading of bugged LEONARDO Siemens images
2591 2003-10-03 Jean-Pierre Roux
2592 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2594 2003-10-03 Jean-Pierre Roux
2595 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2596 to allow displaying RGB images (not only by affim ;-)
2598 2003-10-03 Jean-Pierre Roux
2599 * gdcmFile::GetImageDataIntoVector now
2600 - deals with MultiFrames MultiFragments Run Length Encoded files
2601 - deals with YcBcR (YBR_FULL) files
2602 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2603 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2605 (no sample found :-(
2607 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2608 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2609 Two reasons: - clear things
2610 - third parties acces gdcm through header files, so won't
2611 suffer anymore VC++ complains
2613 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2614 * add argv[1] in testvtkGdcmReader.cxx
2617 2003-09-24 Jean-Pierre Roux
2618 * The lines are now eigthy characters long.for
2619 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2621 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2622 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2623 char* to std::string. Thus, the use of strdup becomes useless. (see
2624 previous commis of Malaterre)
2625 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2626 before the last Malaterre's commit.
2628 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2629 * This commit should fix the Debug building under VC++, the problem
2630 was mainly a mixture of debug and release lib being loaded at startup.
2631 * I also remove a depency to a specific C function: strdup. Because I had
2632 to force the link to msvcrtd (whereas strdup is in libc).
2634 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2635 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2636 located in the gdcmCommon.h file. All use of reference of tha has been
2637 changed to now use the variable GDCM_UNFOUND.
2639 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2641 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2642 Dicom dictionary. The test suite can now be run again. Note:
2643 I'm note very happy with the " (RET)" changes. I believe this
2644 RETAINED comment should be dropped when parsing the dictionary.
2645 - PACKAGER corrected
2647 - AUTHORS updated and now in alphabetical order
2648 * Makefile.am now exports gdcm.dsw for Windoze users.
2650 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2651 * cygwin complains about missing std:: in subdir Test/
2653 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2654 * remove some methods that are now in gdcmHeaderHelper
2656 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2657 * vtkGdcmReader set spacing and origin correctly
2659 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2660 * Fix a few delete/delete[] mismatch
2662 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2663 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2664 interpretation to data given by gdcmHeader. For instance there are
2665 heuristics to get informations (look at different places).
2666 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2667 sorting DICOM images based on different strategies.
2668 * modified Makefiles accordingly.
2670 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2671 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2672 when building in debug mode
2673 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2674 src/win32/gdcmdll.dsp
2675 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2677 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2678 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2681 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2682 * src/win32/libgdcmjpeg12.dsp was not dos format
2683 * src/win32/libgdcmjpeg12.dsp :
2684 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2685 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2687 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2688 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2690 * src/gdcmFile.cxx : bug fix in affectation type
2691 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2692 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2693 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2694 symbols... future problem ?
2696 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2697 * src/win32/libgdcmijpeg12.dsp was missing
2698 * modified gdcm.dsw accordingly
2700 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2701 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2703 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2704 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2705 commit of JPR (before his hollidays to facilitate our work).
2706 * setup.py : bug fix in code. Modifications made while the last commit
2707 of JPR. The code hasn't been tested before the commit... it's so
2708 useless to make that (for best programmer that is JPR) !!!
2710 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2711 * tagged the current version as Version0_3 (i.e. version 0.3)
2713 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2714 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2715 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2716 * *.dsp : modifications to use new libgdcmijpeg8 library
2717 * setup.py : bug fix on VTKPATH variable
2718 * PACKAGER : adding all concerning windows
2720 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2721 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2723 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2724 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2725 test suite reported error.
2726 * PACKAGER file added (describes what a packager must do when
2727 packaging a new release).
2728 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2729 * configure.in: upgraded version number to 0.3.0
2730 * fixing build of rpm (through rpm -ta):
2731 - Doc/Makefile.am exports proper doxygen files
2732 - src/jpeg/libijg8/Makefile.am exports the include files.
2734 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2735 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2736 * src/gdcmHeader.h : formatting code
2738 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2739 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2740 We were obtaining error message from vtk. Now, creation of file list
2741 is made in an internal list to prevent this problem.
2742 Bug fix when output is empty.
2743 Bug fix in update of progress value. Previous commit for this was a bad
2745 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2747 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2748 * src/gdcmHeader.h : added method to get the file name
2749 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2750 files. Added method to remove all files on the input
2751 Added FIXME comment concerning the bad parsing of header made by
2752 ExecuteInformation method (in ExecuteData method)
2754 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2755 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2756 when using make instal.
2757 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2758 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2760 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2761 * setup.py : adding include dir of jpeg lib to compile all sources
2762 * */Win32/*.dsp : JPR fix for windows compilation
2764 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2765 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2767 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2768 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2770 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2771 * setup.py is again effective on un*x (takes into account the
2772 addon of the jpeg library)
2773 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2774 * Doc/Doxy* updated (includes above enhancements)
2775 * INSTALL now points to web documentation
2777 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2778 * src/gdcmHeader.h doesn't make unnecessary reference to
2780 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2782 * src/gdcm*.[cxx|h] :
2783 - to allow compilation with gcc 3.x
2784 -- clean up of STL usage (added explicit usage of std::)
2785 -- small fixes on exceptions.
2786 Note: linking not tested !
2787 - clean of doxygen comments to avoid warnings at documentation
2789 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2790 dependent convertion).
2792 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2793 * Clean up of previous JPR garbage commit (not even commented in the
2795 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2796 - moved all jpeg related files from src to src/jpeg/libijg8, with
2797 addition/modification of Makefile.am and configure.in.
2798 - the testSuite is still brain damage (not guilty).
2800 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2801 * WrapVTK.py : modifications to get correctly vtk source files to
2803 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2804 (FileName -> Filename)
2806 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2807 * vtk/vtkGdcmReader.[cxx/h]:
2808 - UpdateProgress method should now be effective
2809 - removed the limitation on having only images loaded (as opposed
2811 - when building a stack of images/volume, a lesser number of
2812 gdcmHeader and gdcmFile instances should be used (hopefully
2813 accelerating things).
2814 - when building a stack of images/volumes, files which are not
2815 loadable (wrong path-filename, wrong permissions on existing file,
2816 or file not parsable by gdcm) are replaced with a black image
2817 in the stack (for the caller to notice the problem).
2819 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2820 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2822 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2823 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2824 between standard library (std) and vtk library (problems are found
2825 under Windows... thanks Windows !)
2827 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2828 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2830 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2832 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2833 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2835 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2836 * When compiling with distutils (see setup.py) the C++ compiler is
2837 called with different flags than the default ones (with automake).
2838 In order to fix all those warning, I compiled gdcm with the command
2839 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2840 and went for warning fixes:
2841 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2842 up from unused variables.
2843 - vtk/vtkGdcmReader.cxx: potential bug fix.
2844 * src/gdcmHeader.h: Doxygen warning cleanup
2846 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2847 * gdcmPython/gdcm.i:
2848 - typemaps correction to take into account the systematic replacement
2849 of "using namespace std" with std:: prefix e.g. std::list,
2850 std::string... (cf changes of 2003-05-21).
2851 - gdcmGlob global variable of type gdcmGlobal (defined in
2852 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2853 exported to Python a as cvar.
2854 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2855 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2856 gdcmDictSet.GetPubDictTagNames() and
2857 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2858 C++ static methods).
2859 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2860 with the above changes.
2862 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2863 * setup.py, manifest.in : bug fix under linux
2865 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2866 * Modification of setup.py to compile vtk part too. Then, we have 2
2867 wrappers which must work with same distutils. For that, we have a
2868 generic distutils in distusiltsWrapping.py ; with :
2869 - build_extWrap class to wrap generically all extensions,
2870 - ExtensionWrap base class for all wrapping extension that contains
2872 - Wrapper interface which wrap sources
2873 + In WrapSwig.py we have extension and wrapper for Swig
2874 + In WrapVTK.py we have extension and wrapper for VTK
2875 * MANIFEST.in : modifications to consider vtk directory and new python
2876 files for compilation
2878 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2879 * Added python wrappers of vtkGdcmReader vtk class (see the
2880 source in vtk/vtkGdcmReader.cxx) :
2881 - vtk/Makefile.am now builds a library
2882 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2883 python library (as opposed to _gdcm.so wich are the python
2884 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2885 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2887 - configure.in has an additional flag --enable-vtk that needs
2888 to be set to enable compilation of vtk related code, that is:
2889 + vtk/vtkGdcmReader.so and
2890 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2891 + gdcmPython/vtkgdcmPython.so (see above)
2892 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2893 be read when compressed or when HighBit + 1 != BitsStored),
2894 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2895 the usage of the python wrapper of vtkGdcmReader vtk class.
2896 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2897 * src/*.[h] all occurences of stl classes are now prefixed with
2898 std::, and all occurences of "using namespace std;" where removed.
2899 This is to avoid pollution of global namespace in included files.
2900 Apparently vtk does not avoid this pitfall: when using both
2901 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2902 collision of various stl members (principally cout...).
2903 * gdcmPython/testSuite.py now cleanly removes temprory generated
2905 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2906 comply with above changes)
2908 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2909 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2910 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2911 vtk data structure (an image Flip was required).
2912 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2913 * cosmetic changes in documentation.
2915 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2916 * src/gdcmHeader.cxx: the constructor no longer exits when an
2917 unexisting file is given as argument.
2918 * The subdirectory Data (containing all the images used for the
2919 test suite) is not part of this repository anymore. A new module
2920 containing those images is now available at
2921 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2922 with the name gdcmData.
2923 All the python scripts (including the package initialisation file
2924 gdcmPython/__init__.py) were adapated to take this change into
2925 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2927 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2928 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2929 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2930 demo of the usage of this class.
2931 Compilation of this vtk part is only done when using the --enable-vtk
2932 at configure (or autogen.sh) stage.
2934 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2935 * More memory link related corrections and documentation fixes.
2937 - maximum info is obtained with a command of the form:
2938 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2939 --show-reachable=yes PrintHeader
2940 - the remaining reachable blocks seem to come from the STL
2941 allocation scheme through the usage of map and list. It looks
2942 like this memory cannot be freed but it is not a memory leak
2943 (in fact further invocation to the STL would recollect the
2944 unused memory allthough it cannot explicitely be freed).
2945 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2946 of displaying an image parsed with gdcm and displayed with VTK.
2947 Note: some images don't seem to work e.g.
2948 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2949 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2950 Allthough this weakens the semantics, it is a ditch attempt to
2951 make gdcm more thread friendly.
2953 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2954 * Memory link hunt (by using valgrind through the command
2955 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2956 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2957 gdcmHeader::_dicom_vr.
2958 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2959 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2961 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2963 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2964 * src/Makefile.am now exports all the necessary include files at
2968 * UpdateGroupLength replaced by new one
2971 * UpdateGroupLength re-written using H-Table
2972 (named UpdateGroupLengthNew untill checks are over)
2974 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2975 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2976 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2978 - gdcmHeader::GetPubElValSet removed.
2979 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2980 UpdateGroupLength, WriteElements, Write.
2981 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2982 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2983 carried the same semantics.
2984 - src/gdcmHeaderIdo.cxx changed accordingly.
2985 - gdcmFile::WriteBase now regroups all the codes from previous
2986 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2987 - enum FileType moved to gdcmCommon.h
2988 * src/gdcmHeader.cxx AddDefault trashed
2989 * gdcmGetXSize added
2990 * getimageDataSize now calls gdcmGetXSize
2991 * Test/*.cxx changed to agree with above changes
2993 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2994 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2995 (to avoid double call by end user).
2996 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2997 by end user, since gdcmHeader::gdcmHeader now handles it.
2999 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3000 * gdcm/Doc many doxygen changes:
3001 - Doxyfile now has two different versions, DoxyfileUsers that generates
3002 the html.users end users oriented documentation and
3003 DoxyfileDeveloppers that generates the html.developper developper
3004 oriented documentation.
3005 - README changed accordingly
3006 - requirement.txt removed (old design info moved to TODO).
3007 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3008 DoxyMainPage.txt, DoxyPython.txt provide more information.
3009 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3010 be updated by simply regenerating the docs with doxygen and copying
3011 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3012 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3013 all the tests in the form "if (<map>.count() >1)" were removed.
3014 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3015 ill-formed documentation sections.
3016 * src/gdcmHeader.cxx: ditto
3018 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3019 * setup.py fixed for un*x (needed macro for stdint.h)
3020 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3021 un*ces with sh-utils test utility.
3022 * gdcmPython/demo/test.py renamed to PrintHeader.py
3023 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3024 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3025 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3026 * src/gdcm*.cxx JPR's bad inclusion fixed.
3028 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3029 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3030 * gdcmPython/demo/test.py changed accordingly.
3032 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3033 * gdcmPython/Makefile.am fixed linking against libstdc++
3034 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3035 * Swig subdir (historical tests of swig version 1.3.17++) removed
3036 * Test/testChangeEntete.cxx some lines commented out in order to make
3038 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3039 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3041 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3042 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3043 hence the user doesn't need this explicit call.
3044 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3045 i.e. LoadElements() call removed.
3046 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3047 - src/Makefile.am declares the proper flag for g++.
3048 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3049 for adding user defined new tags.
3050 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3051 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3052 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3054 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3055 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3056 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3057 src/Makefile.am : the project should properly compile and install
3058 with the autotools, included the python wrappers part.
3059 * gdcm.spec.in : added a spec file for RPM packaging.
3061 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3062 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3064 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3065 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3066 to exported to the environement (see gdcmPython/testSuite.py
3068 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3069 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3070 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3071 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3072 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3074 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3075 * gdcmPython/__init__.py doesn't crash anymore when running in
3076 in InstallMode or PreInstallMode but with an environment given
3077 value of GDCM_DICT_PATH.
3078 * src/gdcmDictSet.[cxx/h] coding style.
3080 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3081 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3082 * src/gdcm.h general comments moved to TODO, and README
3083 * src/gdcm.h should now be seen as a user commodity (including it
3084 should suffice to fully use gdcm). It is nowhere including within
3085 any of the kernel files src/*.cxx and src/*.h.
3087 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3088 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3089 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3091 * src/gdcm*.cxx only include their corresponding include file
3092 (as opposed to gdcm.h)
3093 * gdcmPython/gdcm.i changed accordingly
3094 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3095 the autogen.sh generated "make snapshot" command to work.
3096 * autogen.sh removed history related references to crea package.
3098 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3099 * distutilsSwigCPlusPlus.py work around some swig portability
3102 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3103 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3104 was done in a last ditch attempt to get setup.py _really_
3105 operationnal. The python/gdcmPython layaout add the advantage
3106 of hidding away the python related distutils specific files
3107 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3108 Alas, the src directory was out of scope (i.e. it's relative
3109 position to setup.py was ../src) which made things impossible to
3110 handle (see previous version of python/setup.py). Crossing fingers...
3112 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3113 * python/setup.py now works on Un*x. (harder than I thougth)
3114 * python/distutilsSwigCPlusPlus.py can now have include files
3115 among the list of sources.
3117 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3118 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3119 * modifications in MSVC projects
3121 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3122 * As stated by the first lines of Test/ExceptionAndPython/README, it
3123 looks like we can move back to original usage of exception within
3124 src/gdcm* and hence remove the errno stuff that was introduced
3125 as a quick and dirty fixture of this problem (added to the TODO).
3126 * Doc/Doxyfile configuration file for Doxygen and corresponding
3127 README file for usage added.
3128 * Test/testWrite.cxx added. This new test comes from a split of
3129 test.cxx that is now reverted to its original purpous i.e.
3130 testing the proper parsing of a Dicom related file.
3131 testWrite.cxx concentrates on testing the IO part of gdcm.
3132 * Test/bug1.cxx (containing a bug on WIn32) added.
3133 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3134 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3135 whose purpose is to publish the content of the TagNames of the
3136 Dicom public dictionary were not accessible without an
3137 instance of class gdcmHeader.
3138 - those methods are now static methods of gdcmDictSet and hence
3139 require no instances at all to be invocated.
3140 - within gdcmDictSet this change required to change some method
3141 to class methods (i.e. are now static) among which SetDictPath
3142 (renamed to BuildDictPath) and LoadDefaultPubDict.
3143 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3144 the above changes by calling the new method classes of gdcmDictSet.
3145 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3146 the above to be effective.
3147 * python/gdcmPython: in order to wrap properly the above changes
3148 for Python, swig version now needs to be > 1.3.17.
3149 * python/gdcmPython/Makefile fixed to adapt itself to new
3150 configure/make shema introduced by Johan Montagnat (thanks for the
3151 contribution). Alas this Makefile cannot be turned into a proper
3152 Makefile.am without some heavy changes in the configure.in
3153 (for python dectection).
3154 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3155 now avoids publishing the empty entries.
3157 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3158 * python/setup.py : bug fix concerning install under windows
3159 ExtraPath reused :-P
3160 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3162 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3163 * Dicts/dicomV3.dic : remove double spaces !!!
3164 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3165 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3168 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3169 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3170 method. Doxygenation.
3171 * src/gdcm.h clean up of JPR spurious comments.
3173 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3174 * python/distutilsSwigCPlusPlus.py now properly collects the
3175 shadow classes generated by "swig -c++" (gdcm.py in our case)
3176 when using "python setup.py install".
3177 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3178 reexports the working classes.
3179 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3180 by the classical C errno scheme. This is to prevent an obscure
3181 behavior of the python wrappers when importing wxPython.wx prior
3182 to gdcmPython (which ended up in an abort call). An illustration
3183 of this oddity can be found in the Test/ExceptionAndPython
3184 subdir (see the README file). This problem probably due to
3185 an combination of g++ and dynamic loading.
3186 * added Test/ExceptionAndPython (see above)
3188 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3189 * Changed the layout of the python part to avoid bloating main
3190 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3191 i.e. the distutils arsenal. All the python related stuff is
3192 again in a python subdir, but the package itself is now in
3194 * setup.py was cleaned up:
3195 - pythonIncludePath removed
3196 - python setup.py bdist target is now functional.
3197 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3198 collision with other packages). gdcmPython/demo/*.py changed
3201 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3202 * python subdir moved to gdcmPython (preparation of distutils packaging).
3203 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3204 distutils installer is operational.
3205 * - gdcmPython/__init__.py now properly loads the swig generated
3206 shadow classes (from gdcm.py).
3207 - gdcmPython/demo/*.py changed to import the package gdcmPython
3208 instead of gdcmPython/demo/load.py.
3209 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3211 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3212 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3213 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3214 entries within the associated public Dicom dictionary resp. the same
3215 information but sorted by the fourth field (PAT, IMG, DIR) of the
3217 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3218 are now in the "???" group.
3219 - python/gdcm.i changed accordingly,
3220 - python/demo/printGroupedPublicDict.py added, that gives an example
3221 of the above new functionalities in Python.
3223 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3224 * src/gdcm.h, gdcmHeader.cxx:
3225 - historic references to glib's g_malloc and g_free (#defined)
3226 were definitively removed.
3227 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3228 * src/gdcmElValSet.cxx:
3229 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3230 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3231 - GetElValue(string) renamed to GetElValueByName.
3232 - Added GetElementByName(string).
3233 * src/gdcmHeader.cxx: added
3234 - GetPubElValRepByNumber(guint16, guint16)
3235 - GetPubElValRepByName(string)
3236 - GetShaElValRepByNumber(guint16, guint16)
3237 - GetShaElValRepByName(string)
3238 - GetShaElValByNumber(guint16, guint16)
3239 - GetShaElValRepByName(string)
3240 - GetElValRepByNumber(guint16, guint16)
3241 - GetElValRepByName(string)
3242 - GetElValByNumber(guint16, guint16)
3243 - GetElValRepByName(string)
3244 * Doc/requirements.txt added.
3246 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3247 * Test/Makefile building now depends on the one of libgdcm.so
3248 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3249 pixel data) aware which enables finding the address (offset) of
3250 the pixel data of JPEG encoded DICOM files. This leaves only a single
3251 file in the testSuite whose pixel data address (offset) is unknown.
3252 * python/testSuite.py changed accordingly.
3254 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3255 * VC++ has some strong limitations when working with the STL, as stated
3256 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3257 "Also note that some STL containers (map, set, queue, list, deque)
3258 cannot be exported. [...]
3259 Some STL classes contain nested classes. These classes can not
3261 This is caused by a designed limitation that once a template
3262 class is instantiated, it can not be re-instantiated and
3264 Since our usage of map<> is ubiquitous in gdcm, this "designed
3265 limitation" of VC++ is a pitfall.
3266 Hence the Python wrappers of gdcm cannot be incrementally linked
3267 against the c++ dynamic library. The dirty but only workaround is
3268 to forget about incremental link of dynamic libraries and to generate
3269 the Python wrappers library with the inclusions of the underlying C++
3271 The following modifications concern this matter on Win32/VC++:
3272 - wrapping python correct with standalone wrapped dll (don't use separate
3273 dll under windows !!!!)
3274 - python21_d debug mode enabled (ask Frog how to use it :-)
3275 - NO problem with having an STL member of class for example string in C++
3276 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3277 - Python test of dcmlib in Python is ok under windows on a large set
3279 * removed glib references
3280 * typedef's inserted in gdcm.i for correct swig type management
3282 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3283 * python/demo/*.py load.py extracted from test.py. Added explore.py
3284 that only displays required tags and testAll.py that parses all
3285 the files of the testsuite without using unittest.
3286 * python/testSuite.py other additional test on new files added.
3287 * Data/* new test files added accordingly to the testSuite.
3288 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3289 the vr in the file differs from the one of the dictionary.
3291 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3292 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3293 values, but limits itself to values which are below a user specified
3294 size (by default 1024 bytes).
3295 * python/gdcm.i : elements not loaded (because their size is above the
3296 user specified treshold) are exported with their TagKey as key of the
3297 python dictionary. This enables the testsuite to make some checks
3298 on the unloaded elements (since we have their offset and size).
3299 * python/testSuite.py
3300 - now tests for the existence and proper value of the pixel data
3301 - two new examples added.
3302 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3304 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3305 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3306 aware. See the strategy comments in gdcmHeader::FindLength().
3307 * Test/test.cxx now accepts a filename as first argument.
3308 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3309 * python/testSuite.py changed to integrate test on above files.
3311 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3312 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3313 the vr was also RET.
3314 * python/testSuite.py more tests added.
3316 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3317 * python/testSuite.py unittest test suite added (uses Data)
3318 * Data/* dcm and acr files for the test suite.
3319 * glib dependance removed from un*x version. We now use ISO C99
3320 7.18 Integer types (see stdint.h)
3321 - python/Makefile, src/Makefile src/gdcm.h
3322 * src/ when an explicit vr (like dicom files) suddenly poped an
3323 implicit element we use to mark the underlying DictEntry of the
3324 concerned ElValue with "Implicit". This strategy was damageable
3325 too the public or provite dictionaries, since some of their vr
3326 would be changed. Since Header::FindLength heavily relies on the
3327 detection by Header::FindVR of falsely explicit elements, I
3328 added an extra ImplicitVr member to ElValue (boolean).
3329 The rest of the changes we the necessary adaptations.
3331 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3332 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3334 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3336 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3337 * Adaptation for porting to VC++:
3339 o forced to use std namespace (for string to be known)
3340 o all class use __declspec export style on WIN32
3341 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3342 (in stdlib.h on Win32 but in std:: for gcc)
3343 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3344 variable GDCM_DICT_PATH.
3345 * src/gdcmHeader.cxx verbose comments made discrete.
3347 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3348 * python/gdcm.i: added a typemap that converts a C++ hashing table
3349 to native Python dictionary.
3350 * python/demo/test.py:
3351 - now uses the native dictionary for exploration of gdcmHeader.
3352 - takes an optional filename argument (the file to parse).
3353 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3354 PubElVals hashing table.
3355 * Dicts/dicomV3.dic removed error prone trailing spaces.
3357 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3358 * Python wrapping process moved away from src/Makefile to
3359 newly created python/Makefile (as well as gdcm.i)
3360 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3361 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3362 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3363 from the environement variable GDCM_DICT_PATH (when existing).
3364 * src/gdcmDict::GetTag bug fix.
3366 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3367 * Straightforward temporary fixes for swig to build the python wrappers.
3368 src/Makefile now has a python working entry [by working we mean
3369 that we can import the shadow classes without errors].
3371 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3372 * hashtest.cxx removed (since already in Test)
3373 * src/gdcmlib.h renamed to src/gdcm.h
3374 * src/dcm.i renamed to src/gdcm.i
3375 * src/Makefile prepared for python wrapping
3377 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3378 * src/gdcmHeader.cxx :
3379 - Parsing of header is now separated from loading of element values
3380 (see gdcmHeader::LoadElements).
3381 - general clean up of hopefully all file access (creation of
3382 ReadInt16 and ReadInt32)
3384 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3385 * src/gdcmHeader.cxx :
3386 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3388 - SetLgrElem renamed to SetLength
3389 - GetLgrElem renamed to GetLength
3390 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3391 * src/gdcmElValSet.cxx fixed both GetElValue methods
3392 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3393 due to IdoDude was cleaned out.
3395 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3396 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3397 concentrates on finding the value representation (when it exists).
3398 RecupLgr now only finds the element value length, and it avoids
3399 returning the unecessary skL (skipped length).
3400 Also, offsetCourant was simply removed (with taille_fich) since
3401 it was redundant with the File position internals (by using
3402 ftell and fseek). This also made skL (see above in RecupLgr) usage
3404 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3405 on the libido specificities which are handled through class
3407 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3410 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3411 * Truckload of changes. Parsing of header is barely functional
3412 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3414 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3415 * src/gdcmHeader.cxx many addons of low level methods
3417 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3418 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3419 and _IdDcmSWAP_LONG.
3421 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3422 * This corresponds to all the changes decided at the meeting of
3423 May 23 2002. Needless to say we are running late...